Re: [dpdk-dev] [PATCH v3 0/5] supports RxDID #22 and FDID

2020-09-15 Thread Zhang, Qi Z
> -Original Message- > From: Rong, Leyi > Sent: Wednesday, September 16, 2020 2:30 PM > To: Jiang, JunyuX ; dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; Sun, GuinanX > Subject: RE: [PATCH v3 0/5] supports RxDID #22 and FDID > > > > -Original Message- > > From: Jiang, Jun

Re: [dpdk-dev] [PATCH v3 0/5] supports RxDID #22 and FDID

2020-09-15 Thread Rong, Leyi
> -Original Message- > From: Jiang, JunyuX > Sent: Wednesday, September 16, 2020 11:10 AM > To: dev@dpdk.org > Cc: Rong, Leyi ; Zhang, Qi Z ; > Yang, Qiming ; Sun, GuinanX > ; Jiang, JunyuX > Subject: [PATCH v3 0/5] supports RxDID #22 and FDID > > This patchset supports flex Rx descrip

[dpdk-dev] [PATCH v4] net/iavf: reject floating RSS attribute

2020-09-15 Thread Qi Zhang
For RSS attribute don't have an associated RSS type, we need to reject it. Signed-off-by: Qi Zhang --- v4: - refine macros v3: - add missing floating l2 rss attribute check v2: - fix checkpatch warning. drivers/net/iavf/iavf_hash.c | 70 1 file changed, 4

[dpdk-dev] [PATCH] net/iavf: reject floating RSS attribute

2020-09-15 Thread Qi Zhang
For RSS attribute don't have an associated RSS type, we need to reject it. Signed-off-by: Qi Zhang --- v4: - refine macros v3: - add missing floating l2 rss attribute check v2: - fix checkpatch warning. drivers/net/iavf/iavf_hash.c | 70 1 file changed, 4

[dpdk-dev] [PATCH v4] net/iavf: reject floating RSS attribute

2020-09-15 Thread Qi Zhang
For RSS attribute don't have an associated RSS type, we need to reject it. Signed-off-by: Qi Zhang --- v4: - refine macros v3: - add missing floating l2 rss attribute check v2: - fix checkpatch warning. drivers/net/iavf/iavf_hash.c | 75 +--- 1 file changed, 53

[dpdk-dev] [PATCH v4] net/virtio: fix wrong variable assignment in helper macro

2020-09-15 Thread Vipul Ashri
Inside Macro ASSIGN_UNLESS_EQUAL(var, val), assignment to var is always failing as assignment done using var_ having local scope only. This leads to TX packets not going out and found broken due to cleanup malfunctioning. This patch fixes the wrong variable assignment. Fixes: 57f90f894588 ("net/vi

[dpdk-dev] [PATCH v1 5/5] net/i40e: fix max mtu size packets with vlan tag cannot be received by default

2020-09-15 Thread SteveX Yang
testpmd will initialize default max packet length to 1518 which does't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side. But for i40e/i40evf, they should su

[dpdk-dev] [PATCH v1 0/5] fix default max mtu size when device configured

2020-09-15 Thread SteveX Yang
testpmd will initialize default max packet length to 1518 which does't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side. configure the correct default max

[dpdk-dev] [PATCH v1 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by default

2020-09-15 Thread SteveX Yang
testpmd will initialize default max packet length to 1518 which does't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side. ice can support dual vlan tags tha

[dpdk-dev] [PATCH v1 4/5] net/iavf: fix max mtu size packets with vlan tag cannot be received by default

2020-09-15 Thread SteveX Yang
testpmd will initialize default max packet length to 1518 which does't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side. iavf can support dual vlan tags th

[dpdk-dev] [PATCH v1 1/5] net/e1000: fix max mtu size packets with vlan tag cannot be received by default

2020-09-15 Thread SteveX Yang
testpmd will initialize default max packet length to 1518 which does't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side. e1000 can support single vlan tags

[dpdk-dev] [PATCH v1 2/5] net/igc: fix max mtu size packets with vlan tag cannot be received by default

2020-09-15 Thread SteveX Yang
testpmd will initialize default max packet length to 1518 which does't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side. igc can support single vlan tag th

Re: [dpdk-dev] [PATCH v2] net/i40e: fix incorrect byte counters

2020-09-15 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Guo, Jia > Sent: Wednesday, September 16, 2020 1:22 PM > To: Jiang, JunyuX ; dev@dpdk.org > Cc: Xing, Beilei ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix incorrect byte counters > > Acked-by: Jeff Guo > > > -Or

Re: [dpdk-dev] [PATCH v2] net/i40e: fix incorrect byte counters

2020-09-15 Thread Guo, Jia
Acked-by: Jeff Guo > -Original Message- > From: Jiang, JunyuX > Sent: Wednesday, September 16, 2020 9:51 AM > To: dev@dpdk.org > Cc: Guo, Jia ; Xing, Beilei ; Jiang, > JunyuX ; sta...@dpdk.org > Subject: [PATCH v2] net/i40e: fix incorrect byte counters > > This patch fixed the issue tha

Re: [dpdk-dev] [PATCH] net/dpaa2: fix build error about timesync functions

2020-09-15 Thread Zhou, JunX W
Tested-by: Zhou, Jun -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Chenxu Di Sent: Tuesday, September 15, 2020 10:41 AM To: dev@dpdk.org Cc: hemant.agra...@nxp.com; sachin.sax...@nxp.com; Di, ChenxuX ; sta...@dpdk.org Subject: [dpdk-dev] [PATCH] net/dpaa2: fix

[dpdk-dev] [PATCH v3] net/iavf: support gtpu outer and inner co-exist

2020-09-15 Thread Jeff Guo
Although currently only the gtpu inner hash be enabled while not the gtpu outer hash, but the outer protocol still needed to co-exist with inner protocol when configure the gtpu inner hash rule, that would allow the gtpu innner hash support for the different outer protocols. Signed-off-by: Jeff Gu

Re: [dpdk-dev] DPDK hugepage memory fragmentation

2020-09-15 Thread Kamaraj P
Hi Anatoly, We just dump the memory contents when it fails to allocate the memory. rte_malloc_dump_stats(); rte_dump_physmem_layout(); rte_memzone_dump(); We could see the fragmented memory --- MALLOC_STATS --- Heap id:0 Heap name:socket_0 Heap_size:134217728, Free_size:13360409

[dpdk-dev] [PATCH v2] net/iavf: support gtpu outer and inner co-exist

2020-09-15 Thread Jeff Guo
Although currently only the gtpu inner hash be enabled while not the gtpu outer hash, but the outer protocol still needed to co-exist with inner protocol when configure the gtpu inner hash rule, that would allow the gtpu innner hash support for the different outer protocols. Signed-off-by: Jeff Gu

Re: [dpdk-dev] [PATCH v5 2/2] gro: add VXLAN UDP GRO support

2020-09-15 Thread Stephen Hemminger
On Wed, 16 Sep 2020 11:05:38 +0800 (CST) yang_y_yi wrote: > No, next_proto_id of inner IP header can clearly identify it is a UDP packet > even if it is a no-udp-header ip fragment. Yes GRO will know its UDP, but it will have no port information (in this packet). GRO can only safely combine p

[dpdk-dev] [PATCH v3 4/5] net/ice: support flow mark in SSE path

2020-09-15 Thread Junyu Jiang
From: Guinan Sun Support flow director mark ID parsing from flexible Rx descriptor in SSE path. Signed-off-by: Guinan Sun --- drivers/net/ice/ice_rxtx_vec_sse.c | 49 ++ 1 file changed, 49 insertions(+) diff --git a/drivers/net/ice/ice_rxtx_vec_sse.c b/drivers/net

[dpdk-dev] [PATCH v3 3/5] net/ice: support flow mark in AVX path

2020-09-15 Thread Junyu Jiang
From: Guinan Sun Support flow director mark ID parsing from flexible Rx descriptor in AVX path. Signed-off-by: Guinan Sun --- drivers/net/ice/ice_rxtx_vec_avx2.c | 64 - 1 file changed, 63 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_rxtx_vec_avx2.

[dpdk-dev] [PATCH v3 5/5] net/ice: remove devargs flow-mark-support

2020-09-15 Thread Junyu Jiang
From: Guinan Sun Currently, all data paths already support flow mark, so remove devargs "flow-mark-support". FDIR matched ID will display in verbose when packets match the created rule. Signed-off-by: Guinan Sun --- doc/guides/nics/ice.rst | 12 drivers/net/ice/ice_e

[dpdk-dev] [PATCH v3 1/5] net/ice: support flex Rx descriptor RxDID #22

2020-09-15 Thread Junyu Jiang
This patch supports RxDID #22 by the following changes: -add structure and macro definition for RxDID #22. -support RxDID #22 format in normal path. -change RSS hash parsing from RxDID #22 in AVX/SSE data path. Signed-off-by: Junyu Jiang --- drivers/net/ice/ice_ethdev.c| 20 ++ drive

[dpdk-dev] [PATCH v3 2/5] net/ice: add flow director enabled switch value

2020-09-15 Thread Junyu Jiang
From: Guinan Sun The patch adds fdir_enabled flag to identify if parse flow director mark ID from flexible Rx descriptor. Signed-off-by: Guinan Sun --- drivers/net/ice/ice_ethdev.h | 2 ++ drivers/net/ice/ice_fdir_filter.c | 9 - drivers/net/ice/ice_rxtx.h| 30 ++

[dpdk-dev] [PATCH v3 0/5] supports RxDID #22 and FDID

2020-09-15 Thread Junyu Jiang
This patchset supports flex Rx descriptor RxDID #22 and FDID offload in vPMD. Remove devargs "flow-mark-support". --- v3: * Check if package does support RXDID. * Modify commit message. * Rebase the patchset. v2: * Reorder patches. Guinan Sun (4): net/ice: add flow director enabled switch valu

Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-09-15 Thread Ruifeng Wang
> -Original Message- > From: Medvedkin, Vladimir > Sent: Wednesday, September 16, 2020 12:28 AM > To: Bruce Richardson ; Ruifeng Wang > > Cc: dev@dpdk.org; Honnappa Nagarahalli > ; nd > Subject: Re: [PATCH 2/2] lpm: hide internal data > > Hi Ruifeng, > > On 15/09/2020 17:02, Bruce Ric

Re: [dpdk-dev] [PATCH v5 2/2] gro: add VXLAN UDP GRO support

2020-09-15 Thread yang_y_yi
No, next_proto_id of inner IP header can clearly identify it is a UDP packet even if it is a no-udp-header ip fragment. At 2020-09-16 10:54:24, "Jiayu Hu" wrote: >On Mon, Sep 14, 2020 at 05:14:59PM +0800, yang_y_yi wrote: >> >> Jiayu, VM to VM case for big UDP packet (say ud

[dpdk-dev] [PATCH v1] net/ice: fix incorrect ptype parsing

2020-09-15 Thread Ting Xu
The ptype mask for flexible descriptor in Rx function ice_recv_pkts_vec has a reversed order, which leads to an incorrect value of the final ptype. This patch fix the mask to parse the correct ptype of RX packets. Fixes: c68a52b8b38c ("net/ice: support vector SSE in Rx") Cc: sta...@dpdk.org Signe

Re: [dpdk-dev] [PATCH v1] app/bbdev: fix test vector symlink

2020-09-15 Thread Liu, Tianjiao
Acked-by: Liu Tianjiao > -Original Message- > From: Chautru, Nicolas > Sent: Thursday, September 10, 2020 5:16 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Liu, Tianjiao ; Chautru, Nicolas > > Subject: [PATCH v1] app/bbdev: fix test vector symlink > 5G DL default symlink was pointing

Re: [dpdk-dev] [PATCH v5 2/2] gro: add VXLAN UDP GRO support

2020-09-15 Thread Jiayu Hu
On Mon, Sep 14, 2020 at 05:14:59PM +0800, yang_y_yi wrote: > > Jiayu, VM to VM case for big UDP packet (say udp parload size is 8192K, but > mtu > 1500). VM will segment it as UDP framgments, but when ovs dpdk uses VxLan to > encapsulate them, it doesn't know they are same flow, OVS DPDK has no k

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/i40e: fix incorrect byte counters

2020-09-15 Thread Han, YingyaX
Tested-by: Yingya Han -Original Message- From: stable On Behalf Of Junyu Jiang Sent: Wednesday, September 16, 2020 9:51 AM To: dev@dpdk.org Cc: Guo, Jia ; Xing, Beilei ; Jiang, JunyuX ; sta...@dpdk.org Subject: [dpdk-stable] [PATCH v2] net/i40e: fix incorrect byte counters This patch f

Re: [dpdk-dev] [PATCH v3 6/7] app/bbdev: reduce duration of throughput test

2020-09-15 Thread Liu, Tianjiao
Acked-by: Liu Tianjiao > -Original Message- > From: Chautru, Nicolas > Sent: Tuesday, August 18, 2020 5:06 PM > To: dev@dpdk.org; akhil.go...@nxp.com > Cc: Richardson, Bruce ; Chautru, Nicolas > > Subject: [PATCH v3 6/7] app/bbdev: reduce duration of throughput test > > Reducing numbe

[dpdk-dev] [PATCH v2] net/i40e: fix incorrect byte counters

2020-09-15 Thread Junyu Jiang
This patch fixed the issue that rx/tx bytes overflowed on 48 bit limitation by enlarging the limitation. Fixes: 4861cde46116 ("i40e: new poll mode driver") Cc: sta...@dpdk.org Signed-off-by: Junyu Jiang --- drivers/net/i40e/i40e_ethdev.c | 47 ++ drivers/net/i40e

Re: [dpdk-dev] [PATCH v2] bus/pci: netuio interface for windows

2020-09-15 Thread Stephen Hemminger
On Tue, 15 Sep 2020 16:28:03 -0700 Pallavi Kadam wrote: > + if (IsEqualGUID((const void *)&(device_info_data->ClassGuid), > + (const void *)&GUID_DEVCLASS_NETUIO)) Is there anyway to get rid of casts and have the right types? Casts are evil

[dpdk-dev] [PATCH v2] bus/pci: netuio interface for windows

2020-09-15 Thread Pallavi Kadam
This patch adds implementations to probe PCI devices bound to netuio with the help of "netuio" class device changes. Now Windows will support both "netuio" and "net" device class and can set kernel driver type based on the device class selection. Note: Few definitions and structures have been copi

Re: [dpdk-dev] [PATCH v11 02/24] ethdev: format a link status text

2020-09-15 Thread Morten Brørup
> From: Ivan Dyukov [mailto:i.dyu...@samsung.com] > Sent: Tuesday, September 15, 2020 9:07 PM > > There is new link_speed value introduced. It's INT_MAX value which > means that speed is unknown. To simplify processing of the value > in application, new function is added which convert link_speed t

Re: [dpdk-dev] [PATCH] bus/pci: netuio interface for windows

2020-09-15 Thread Ranjit Menon
Hi, Tal On 9/13/2020 11:42 AM, Tal Shnaiderman wrote: Subject: [PATCH] bus/pci: netuio interface for windows This patch adds implementations to probe PCI devices bound to netuio with the help of "netuio" class device changes. Now Windows will support both "netuio" and "net" device class and can

Re: [dpdk-dev] [PATCH v2 1/6] ethdev: add flow shared action API

2020-09-15 Thread Ajit Khaparde
On Tue, Sep 15, 2020 at 4:51 AM Andrey Vesnovaty wrote: > Hi Ajit, PSB. > > Thanks, > Andrey > > > -Original Message- > > From: Ajit Khaparde > > Sent: Saturday, September 12, 2020 5:18 AM > > To: Andrey Vesnovaty > > Cc: dpdk-dev ; j...@marvell.com; Jerin Jacob > > ; NBU-Contact-Thomas

Re: [dpdk-dev] [PATCH] net/bnxt: fix powerpc build

2020-09-15 Thread Ajit Khaparde
On Tue, Sep 15, 2020 at 7:07 AM Lance Richardson < lance.richard...@broadcom.com> wrote: > A previous commit broke compilation for builds other than x86 and > aarch64. Fix by moving macro definitions to more appropriate header > files. > > Fixes: 479387565605 ("net/bnxt: improve small ring sizes s

[dpdk-dev] [PATCH v1 2/6] app/test: synchronize statistics between lcores

2020-09-15 Thread Lukasz Wojciechowski
Statistics of handled packets are cleared and read on main lcore, while they are increased in workers handlers on different lcores. Without synchronization occasionally showed invalid values. This patch uses atomic acquire/release mechanisms to synchronize. Fixes: c3eabff124e6 ("distributor: add

[dpdk-dev] [PATCH v1 4/6] app/test: collect return mbufs in distributor test

2020-09-15 Thread Lukasz Wojciechowski
During quit_workers function distributor's main core processes some packets to wake up pending worker cores so they can quit. As quit_workers acts also as a cleanup procedure for next test case it should also collect these packages returned by workers' handlers, so the cyclic buffer with returned p

[dpdk-dev] [PATCH v1 5/6] distributor: fix missing handshake synchronization

2020-09-15 Thread Lukasz Wojciechowski
rte_distributor_return_pkt function which is run on worker cores must wait for distributor core to clear handshake on retptr64 before using those buffers. While the handshake is set distributor core controls buffers and any operations on worker side might overwrite buffers which are unread yet. Fi

[dpdk-dev] [PATCH v1 3/6] app/test: fix freeing mbufs in distributor tests

2020-09-15 Thread Lukasz Wojciechowski
Sanity tests with mbuf alloc and shutdown tests assume that mbufs passed to worker cores are freed in handlers. Such packets should not be returned to the distributor's main core. The only packets that should be returned are the packets send after completion of the tests in quit_workers function.

[dpdk-dev] [PATCH v1 6/6] distributor: fix handshake deadlock

2020-09-15 Thread Lukasz Wojciechowski
Synchronization of data exchange between distributor and worker cores is based on 2 handshakes: retptr64 for returning mbufs from workers to distributor and bufptr64 for passing mbufs to workers. Without proper order of verifying those 2 handshakes a deadlock may occur. This can happen when worker

[dpdk-dev] [PATCH v1 1/6] app/test: fix deadlock in distributor test

2020-09-15 Thread Lukasz Wojciechowski
The sanity test with worker shutdown delegates all bufs to be processed by a single lcore worker, then it freezes one of the lcore workers and continues to send more bufs. Problem occurred if freezed lcore is the same as the one that is processing the mbufs. The lcore processing mbufs might be dif

[dpdk-dev] [PATCH v1 0/6] fix distributor synchronization issues

2020-09-15 Thread Lukasz Wojciechowski
During review and verification of the patch created by Sarosh Arif: "test_distributor: prevent memory leakages from the pool" I found out that running distributor unit tests multiple times in a row causes fails. So I investigated all the issues I found. There are few synchronization issues that mi

[dpdk-dev] [PATCH v11 23/24] examples/server_nod*: new link status print format

2020-09-15 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/server_node_efd/server/init.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/examples/server_node_efd/server/init.c b/examples/server_node_efd/server/i

[dpdk-dev] [PATCH v11 21/24] example/performance*: new link status print format

2020-09-15 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/performance-thread/l3fwd-thread/main.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/examples/performance-thread/l3fwd-thread/main.c b/examples/performan

[dpdk-dev] [PATCH v11 24/24] examples/vm_power_*: new link status print format

2020-09-15 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/vm_power_manager/main.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/examples/vm_power_manager/main.c b/examples/vm_power_manager/main.c index 273bfec29

[dpdk-dev] [PATCH v11 16/24] examples/l2fwd: new link status print format

2020-09-15 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/l2fwd/main.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index e04c601b5..28bede684 100644 --- a/examples/

[dpdk-dev] [PATCH v11 22/24] examples/qos_sched: new link status print format

2020-09-15 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/qos_sched/init.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c index 9626c15b8..06328ddb2 100644 ---

[dpdk-dev] [PATCH v11 18/24] examples/l3fwd-power: new link status print format

2020-09-15 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/l3fwd-power/main.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index 9db94ce04..bcd737994 100

[dpdk-dev] [PATCH v11 19/24] examples/multi_proc*: new link status print format

2020-09-15 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- .../client_server_mp/mp_server/init.c | 15 ++- examples/multi_process/symmetric_mp/main.c| 13 + 2 files changed, 11 insertions(+), 17 deletions(-) diff

[dpdk-dev] [PATCH v11 20/24] examples/ntb: new link status print format

2020-09-15 Thread Ivan Dyukov
Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/ntb/ntb_fwd.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/examples/ntb/ntb_fwd.c b/examples/ntb/ntb_fwd.c index eba8ebf9f..6d9b3b45c 100644 --- a/examples/n

[dpdk-dev] [PATCH v11 17/24] examples/l3fwd-graph: new link status print format

2020-09-15 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/l3fwd-graph/main.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/examples/l3fwd-graph/main.c b/examples/l3fwd-graph/main.c index c70270c4d..0f3f4088c 1

[dpdk-dev] [PATCH v11 15/24] examples/l2fwd-event: new link status print format

2020-09-15 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/l2fwd-event/main.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd-event/main.c b/examples/l2fwd-event/main.c index 4fe500333..d90c71698 1006

[dpdk-dev] [PATCH v11 14/24] examples/l2fwd-crypt: new link status print format

2020-09-15 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/l2fwd-crypto/main.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c index 827da9b3e..820470db5 1

[dpdk-dev] [PATCH v11 08/24] examples/bbdev_app: new link status print format

2020-09-15 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/bbdev_app/main.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/examples/bbdev_app/main.c b/examples/bbdev_app/main.c index 68a46050c..fe9d8e0a5 100644 --- a/examp

[dpdk-dev] [PATCH v11 10/24] examples/ip_*: new link status print format

2020-09-15 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications: * ip_fragmentation * ip_reassembly * l3fwd-acl Signed-off-by: Ivan Dyukov --- examples/ip_fragmentation/main.c | 13 + examples/ip_reassembly/main.c| 13 + examples/l3fwd-acl/ma

[dpdk-dev] [PATCH v11 12/24] examples/ipsec-secgw: new link status print format

2020-09-15 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/ipsec-secgw/ipsec-secgw.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index f77

[dpdk-dev] [PATCH v11 09/24] examples/ioat: new link status print format

2020-09-15 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/ioat/ioatfwd.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/examples/ioat/ioatfwd.c b/examples/ioat/ioatfwd.c index b66ee73bc..f77012eb9 100644 --- a/ex

[dpdk-dev] [PATCH v11 11/24] examples/ip_pipeline: new link status print format

2020-09-15 Thread Ivan Dyukov
Add usage of rte_eth_link_speed_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/ip_pipeline/cli.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c index d79699e2e..cf3d7d462 100644 ---

[dpdk-dev] [PATCH v11 13/24] examples/kni: new link status print format

2020-09-15 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/kni/main.c | 27 ++- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/examples/kni/main.c b/examples/kni/main.c index f5d12a5b8..49d888064 100644 --- a

[dpdk-dev] [PATCH v11 05/24] net/i40e: return unknown speed in status

2020-09-15 Thread Ivan Dyukov
rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available and link is up. NUM_NONE should be returned, if link is down. Signed-off-by: Ivan Dyukov Acked-by: Jeff Guo --- drivers/net/i40e/i40e_ethdev.c| 5 - drivers/net/i40e/i40e_et

[dpdk-dev] [PATCH v11 04/24] net/ixgbe: return unknown speed in status

2020-09-15 Thread Ivan Dyukov
rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available Signed-off-by: Ivan Dyukov Reviewed-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_ethdev.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe

[dpdk-dev] [PATCH v11 07/24] examples: new link status print format

2020-09-15 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications: * ipv4_multicast * l2fwd-jobstats * l2fwd-keepalive * l3fwd * link_status_interrupt Signed-off-by: Ivan Dyukov --- examples/ipv4_multicast/main.c| 14 ++--- examples/l2fwd-j

[dpdk-dev] [PATCH v11 06/24] net/ice: return unknown speed in status

2020-09-15 Thread Ivan Dyukov
rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available and link is up. NUM_NONE should be returned, if link is down. Signed-off-by: Ivan Dyukov Reviewed-by: Ferruh Yigit --- drivers/net/ice/ice_ethdev.c | 5 - 1 file changed, 4 inser

[dpdk-dev] [PATCH v11 02/24] ethdev: format a link status text

2020-09-15 Thread Ivan Dyukov
There is new link_speed value introduced. It's INT_MAX value which means that speed is unknown. To simplify processing of the value in application, new function is added which convert link_speed to string. Also dpdk examples have many duplicated code which format entire link status structure to tex

[dpdk-dev] [PATCH v11 00/24] ethdev: allow unknown link speed

2020-09-15 Thread Ivan Dyukov
MAINTAINERS | 1 + app/proc-info/main.c | 11 ++--- app/test-pipeline/init.c | 11 ++--- app/test-pmd/config.c| 9 ++-- app/test-pmd/testpmd.c

[dpdk-dev] [PATCH v11 03/24] app: update apps&docs with new UNKNOWN link speed

2020-09-15 Thread Ivan Dyukov
Add usage of rte_eth_link_to_str function to example applications and docs Signed-off-by: Ivan Dyukov --- app/proc-info/main.c | 11 +-- app/test-pipeline/init.c | 11 +-- app/test-pmd/config.c | 9 +

[dpdk-dev] [PATCH v11 01/24] ethdev: allow unknown link speed

2020-09-15 Thread Ivan Dyukov
From: Thomas Monjalon When querying the link information, the link status is a mandatory major information. Other boolean values are supposed to be accurate: - duplex mode (half/full) - negotiation (auto/fixed) This API update is making explicit that the link speed information is

[dpdk-dev] [PATCH 2/4] event/octeontx2: improve single flow performance

2020-09-15 Thread Harman Kalra
From: Pavan Nikhilesh Improve single flow performance by moving the point of coherence to the end of transmit sequence. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_worker.h | 35 +-- drivers/net/octeontx2/otx2_tx.h | 18 ++ 2 files

[dpdk-dev] [PATCH 4/4] app/eventdev: enable fast free offload

2020-09-15 Thread Harman Kalra
Since we are not holding the mbufs or creating any references in the app, hence mbuf fast free offload can be enabled. Signed-off-by: Harman Kalra --- app/test-eventdev/test_pipeline_common.c | 5 + 1 file changed, 5 insertions(+) diff --git a/app/test-eventdev/test_pipeline_common.c b/app

[dpdk-dev] [PATCH 3/4] net/octeontx2: fix jumbo frame crash

2020-09-15 Thread Harman Kalra
Issue has been observed in case of multi segments where mbuf data gets corrupted due to missing barriers. Changes made to mbuf just before LMTST by one core gets updatded when the same mbuf is in use by another core, leading to corruption. It should be ensured that all changes made to mbuf should b

[dpdk-dev] [PATCH 1/4] event/octeontx2: add switch tag flush op

2020-09-15 Thread Harman Kalra
From: Pavan Nikhilesh Add SWTAG flush operation at the end of transmit sequence to immediately release the tag held by the core. Reuse Tag address to check SWTAG completion status. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_evdev.c | 2 +- drivers/event/octeontx2/otx2_ev

Re: [dpdk-dev] [PATCH v4 04/22] event/dlb: add definitions shared with LKM or shared code

2020-09-15 Thread Eads, Gage
> -Original Message- > From: McDaniel, Timothy > Sent: Friday, September 11, 2020 2:18 PM > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > jer...@marvell.com > Subject: [PATCH v4 04/22] event/dlb: add definitions shared with LKM or > shared code > > Add heade

[dpdk-dev] [PATCH] net/bnxt: fix powerpc build

2020-09-15 Thread Lance Richardson
A previous commit broke compilation for builds other than x86 and aarch64. Fix by moving macro definitions to more appropriate header files. Fixes: 479387565605 ("net/bnxt: improve small ring sizes support") Signed-off-by: Lance Richardson --- drivers/net/bnxt/bnxt_rxq.c | 1 - drive

[dpdk-dev] [PATCH] [PATCH V2] testpmd: add eeprom/module eeprom display

2020-09-15 Thread David Liu
Add module EEPROM/EEPROM dump command "show port (module_eeprom|eeprom)" Commands will dump the content of the EEPROM/module EEPROM for the selected port. Signed-off-by: David Liu --- app/test-pmd/cmdline.c | 49 app/test-pmd/config.c | 11

[dpdk-dev] [PATCH] [PATCH V2] testpmd: add eeprom/module eeprom display

2020-09-15 Thread David Liu
Signed-off-by: David Liu --- app/test-pmd/cmdline.c | 49 app/test-pmd/config.c | 118 app/test-pmd/testpmd.h | 2 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 ++ 4 files changed, 176 insertio

[dpdk-dev] [PATCH v2 2/3] examples/l3fwd-acl: allow explicitly select classify method

2020-09-15 Thread Konstantin Ananyev
Replace '--scalar' command-line option with new one: --alg= to allow user explicitly select desired classify method. This is an optional parameter, if not specified default classify algorithm will be used. Signed-off-by: Konstantin Ananyev --- doc/guides/rel_notes/release_20_11.rst| 5

[dpdk-dev] [PATCH v2 0/3] Few enhancements for l3fwd-acl

2020-09-15 Thread Konstantin Ananyev
Improve l3fwd-acl usability. Allow to specify destination MAC and explicitly select classify algorithm. hese patch series depends on: https://patches.dpdk.org/project/dpdk/list/?series=12241 to be applied first. Konstantin Ananyev (3): examples/l3fwd-acl: add source and destination MAC update

[dpdk-dev] [PATCH v2 3/3] examples/l3fwd-acl: add support for AVX512

2020-09-15 Thread Konstantin Ananyev
Add ability to select AVX512 classify algorithm. Signed-off-by: Konstantin Ananyev --- doc/guides/sample_app_ug/l3_forward_access_ctrl.rst | 2 +- examples/l3fwd-acl/main.c | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/doc/guides/sample_app_ug/

[dpdk-dev] [PATCH v2 1/3] examples/l3fwd-acl: add source and destination MAC update

2020-09-15 Thread Konstantin Ananyev
Introduces two changes into l3fwd-acl behaviour to make it behave in the same way as l3fwd: - Add a command-line parameter to allow the user to specify the destination mac address for each ethernet port used. - While forwarding the packet update source and destination mac addresses. Signed

Re: [dpdk-dev] [PATCH] net/bnxt: fix powerpc build

2020-09-15 Thread Ferruh Yigit
On 9/15/2020 5:08 PM, Ferruh Yigit wrote: > On 9/15/2020 4:38 PM, Ajit Khaparde wrote: >> >> >> On Tue, Sep 15, 2020 at 7:07 AM Lance Richardson >> mailto:lance.richard...@broadcom.com>> >> wrote: >> >> A previous commit broke compilation for builds other than x86 and >> aarch64. Fix by mov

[dpdk-dev] [PATCH v2 11/12] test/acl: add AVX512 classify support

2020-09-15 Thread Konstantin Ananyev
Add AVX512 classify to the test coverage. Signed-off-by: Konstantin Ananyev --- app/test/test_acl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/test/test_acl.c b/app/test/test_acl.c index 333b34757..11d69d2d5 100644 --- a/app/test/test_acl.c +++ b/app/test/test_a

[dpdk-dev] [PATCH v2 10/12] acl: for AVX512 classify use 4B load whenever possible

2020-09-15 Thread Konstantin Ananyev
With current ACL implementation first field in the rule definition has always to be one byte long. Though for optimising classify implementation it might be useful to be able to use 4B reads (as we do for rest of the fields). So at build phase, check user provided field definitions to determine is

[dpdk-dev] [PATCH v2 07/12] acl: add infrastructure to support AVX512 classify

2020-09-15 Thread Konstantin Ananyev
Add necessary changes to support new AVX512 specific ACL classify algorithm: - changes in meson.build to check that build tools (compiler, assembler, etc.) do properly support AVX512. - run-time checks to make sure target platform does support AVX512. - dummy rte_acl_classify_avx512() for tar

[dpdk-dev] [PATCH v2 12/12] app/acl: add AVX512 classify support

2020-09-15 Thread Konstantin Ananyev
Add ability to use AVX512 classify method. Signed-off-by: Konstantin Ananyev --- app/test-acl/main.c | 4 1 file changed, 4 insertions(+) diff --git a/app/test-acl/main.c b/app/test-acl/main.c index d9b65517c..19b714335 100644 --- a/app/test-acl/main.c +++ b/app/test-acl/main.c @@ -81,6 +8

[dpdk-dev] [PATCH v2 09/12] acl: enhance AVX512 classify implementation

2020-09-15 Thread Konstantin Ananyev
Add search_avx512x16x2() which uses mostly 512-bit width registers/instructions and is able to process up to 32 flows in parallel. That allows to futher speedup rte_acl_classify_avx512() for bursts with 32+ requests. Run-time code-path selection is done internally based on input burst size and is t

[dpdk-dev] [PATCH v2 08/12] acl: introduce AVX512 classify implementation

2020-09-15 Thread Konstantin Ananyev
Introduce classify implementation that uses AVX512 specific ISA. Current approach uses mix of 256i/512-bit width registers/instructions and is able to process up to 16 flows in parallel. Note that for now only 64-bit version of rte_acl_classify_avx512() is available. Signed-off-by: Konstantin Anan

[dpdk-dev] [PATCH v2 03/12] acl: remove of unused enum value

2020-09-15 Thread Konstantin Ananyev
Removal of unused enum value (RTE_ACL_CLASSIFY_NUM). This enum value is not used inside DPDK, while it prevents to add new classify algorithms without causing an ABI breakage. Note that this change introduce a formal ABI incompatibility with previous versions of ACL library. Signed-off-by: Konsta

[dpdk-dev] [PATCH v2 06/12] test/acl: expand classify test coverage

2020-09-15 Thread Konstantin Ananyev
Make classify test to run for all supported methods. Signed-off-by: Konstantin Ananyev --- app/test/test_acl.c | 103 ++-- 1 file changed, 51 insertions(+), 52 deletions(-) diff --git a/app/test/test_acl.c b/app/test/test_acl.c index 316bf4d06..333b34757

[dpdk-dev] [PATCH v2 05/12] app/acl: few small improvements

2020-09-15 Thread Konstantin Ananyev
- enhance output to print extra stats - use rte_rdtsc_precise() for cycle measurements Signed-off-by: Konstantin Ananyev --- app/test-acl/main.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/app/test-acl/main.c b/app/test-acl/main.c index 0a5dfb621..d9b6551

[dpdk-dev] [PATCH v2 04/12] acl: remove library constructor

2020-09-15 Thread Konstantin Ananyev
Right now ACL library determines best possible (default) classify method on a given platform with specilal constructor function rte_acl_init(). This patch makes the following changes: - Move selection of default classify method into a separate private function and call it for each ACL context c

[dpdk-dev] [PATCH v2 02/12] doc: fix mixing classify methods in ACL guide

2020-09-15 Thread Konstantin Ananyev
Add brief description for missing ACL classify algorithms: RTE_ACL_CLASSIFY_NEON and RTE_ACL_CLASSIFY_ALTIVEC. Fixes: 34fa6c27c156 ("acl: add NEON optimization for ARMv8") Fixes: 1d73135f9f1c ("acl: add AltiVec for ppc64") Cc: sta...@dpdk.org Signed-off-by: Konstantin Ananyev --- doc/guides/pro

[dpdk-dev] [PATCH v2 00/12] acl: introduce AVX512 classify method

2020-09-15 Thread Konstantin Ananyev
These patch series introduce support of AVX512 specific classify implementation for ACL library. Inside it contains two code-paths – one uses mostly 256 bit instruction/registers and can process up to 16 flows in parallel. second uses 512 bit instruction/registers over majority of places and can pr

[dpdk-dev] [PATCH v2 01/12] acl: fix x86 build when compiler doesn't support AVX2

2020-09-15 Thread Konstantin Ananyev
Right now we define dummy version of rte_acl_classify_avx2() when both X86 and AVX2 are not detected, though it should be for non-AVX2 case only. Fixes: e53ce4e41379 ("acl: remove use of weak functions") Cc: sta...@dpdk.org Signed-off-by: Konstantin Ananyev --- lib/librte_acl/rte_acl.c | 2 +-

Re: [dpdk-dev] [PATCH v4 00/31] remove make support in DPDK

2020-09-15 Thread Thomas Monjalon
15/09/2020 18:39, Chautru, Nicolas: > Hi, > > > From: Thomas Monjalon > > Sent: Tuesday, September 15, 2020 9:11 AM > > To: David Marchand ; Chautru, Nicolas > > ; Power, Ciara ; > > Richardson, Bruce > > Cc: dev > > Subject: Re: [PATCH v4 00/31] remove make support in DPDK > > > > 15/09/2020

Re: [dpdk-dev] [PATCH v4 00/31] remove make support in DPDK

2020-09-15 Thread Chautru, Nicolas
Hi, > From: Thomas Monjalon > Sent: Tuesday, September 15, 2020 9:11 AM > To: David Marchand ; Chautru, Nicolas > ; Power, Ciara ; > Richardson, Bruce > Cc: dev > Subject: Re: [PATCH v4 00/31] remove make support in DPDK > > 15/09/2020 17:57, Richardson, Bruce: > > > > > -Original Message

Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-09-15 Thread Medvedkin, Vladimir
Hi Ruifeng, On 15/09/2020 17:02, Bruce Richardson wrote: On Mon, Sep 07, 2020 at 04:15:17PM +0800, Ruifeng Wang wrote: Fields except tbl24 and tbl8 in rte_lpm structure have no need to be exposed to the user. Hide the unneeded exposure of structure fields for better ABI maintainability. Sugges

  1   2   3   >