Re: [dpdk-dev] [PATCH v2 3/4] app/testpmd: fix packet header in txonly mode

2020-09-17 Thread Chengchang Tang
On 2020/9/15 0:23, Ferruh Yigit wrote: > On 8/20/2020 2:42 AM, Wei Hu (Xavier) wrote: >> From: Chengchang Tang >> >> In txonly forward mode, the packet header is fixed by the initial >> setting, including the packet length and checksum. So when the packets >> varies, this may cause a packet hea

Re: [dpdk-dev] unable to bind to vfio-pci

2020-09-17 Thread Dybkowski, AdamX
Hi. > -Original Message- > From: dev On Behalf Of Sarosh Arif > Sent: Thursday, 17 September, 2020 08:53 > To: dev@dpdk.org > Subject: [dpdk-dev] unable to bind to vfio-pci > > I have been trying to bind to vfio-pci using usertools/dpdk-devbind.py but > am unable to do so. The reason beh

Re: [dpdk-dev] [PATCH 1/2] af_xdp: not return a negative value in af_xdp_rx_zc

2020-09-17 Thread Loftus, Ciara
> > af_xdp_rx_zc should always return the number of received packets, > and negative value will be as number of received packets, and > confuse the caller > > Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks") > Cc: sta...@dpdk.org > Signed-off-by: Li RongQing > --- > drivers/net

Re: [dpdk-dev] [PATCH v2 0/3] enable AVX512 for iavf

2020-09-17 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Thursday, September 17, 2020 3:40 AM > > AVX512 instructions is supported by more and more platforms. These > instructions > can be used in the data path to enhance the per-core performance of > packet > processing. > Compar

Re: [dpdk-dev] [PATCH v2 00/25] patchset for bnxt

2020-09-17 Thread Ferruh Yigit
On 9/17/2020 1:13 AM, Ajit Khaparde wrote: On Wed, Sep 16, 2020 at 4:58 PM Ferruh Yigit wrote: On 9/16/2020 5:21 PM, Ajit Khaparde wrote: On Tue, Sep 15, 2020 at 9:28 PM Ajit Khaparde wrote: Some fixes and enhancements in the PMD and TruFlow layers. v1->v2: - rebased to latest - upd

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: allow negative values in flow rule types

2020-09-17 Thread Ori Kam
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Thursday, September 17, 2020 9:50 AM > > On 9/16/20 8:21 PM, Gregory Etelson wrote: > > From: Gregory Etelson > > Sent: Tuesday, September 15, 2020 13:27 > > To: Andrew Rybchenko ; Ajit Khaparde > > > Cc: dpdk-dev ; Matan

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: allow negative values in flow rule types

2020-09-17 Thread Gregory Etelson
> On 9/16/20 8:21 PM, Gregory Etelson wrote: > > From: Gregory Etelson > > Sent: Tuesday, September 15, 2020 13:27 > > To: Andrew Rybchenko ; Ajit Khaparde > > > > Cc: dpdk-dev ; Matan Azrad ; Raslan > > Darawsheh ; Ori Kam ; Gregory > > Etelson ; Ori Kam ; > > NBU-Contact-Thomas Monjalon ; Ferruh

[dpdk-dev] [PATCH] dpdk: avoid deadlock due to empty fill queue

2020-09-17 Thread Li RongQing
Signed-off-by: Li RongQing --- drivers/net/af_xdp/rte_eth_af_xdp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c index 48824050e..de830825d 100644 --- a/drivers/net/af_xdp/rte_eth_af_xdp.c +++ b

[dpdk-dev] [PATCH v4 1/5] net/iavf: fix vector rx burst for iavf

2020-09-17 Thread Jeff Guo
The limitation of burst size in vector rx was removed, since it should retrieve as much received packets as possible. And also the scattered receive path should use a wrapper function to achieve the goal of burst maximizing. And do some code cleaning for vector rx path. Bugzilla ID: 516 Fixes: af0

[dpdk-dev] [PATCH v4 2/5] net/ixgbe: fix vector rx burst for ixgbe

2020-09-17 Thread Jeff Guo
The limitation of burst size in vector rx was removed, since it should retrieve as much received packets as possible. And also the scattered receive path should use a wrapper function to achieve the goal of burst maximizing. And do some code cleaning for vector rx path. Bugzilla ID: 516 Fixes: b20

[dpdk-dev] [PATCH v4 0/5] fix vector rx burst for PMDs

2020-09-17 Thread Jeff Guo
The limitation of burst size in vector rx was removed, since it should retrieve as much received packets as possible. And also the scattered receive path should use a wrapper function to achieve the goal of burst maximizing. This patch set aims to maximize vector rx burst for for ixgbe/i40e/ice/ia

[dpdk-dev] [PATCH v4 3/5] net/i40e: fix vector rx burst for i40e

2020-09-17 Thread Jeff Guo
The limitation of burst size in vector rx was removed, since it should retrieve as much received packets as possible. And also the scattered receive path should use a wrapper function to achieve the goal of burst maximizing. And do some code cleaning for vector rx path. Bugzilla ID: 516 Fixes: 5b4

[dpdk-dev] [PATCH v4 4/5] net/ice: fix vector rx burst for ice

2020-09-17 Thread Jeff Guo
The limitation of burst size in vector rx was removed, since it should retrieve as much received packets as possible. And also the scattered receive path should use a wrapper function to achieve the goal of burst maximizing. And do some code cleaning for vector rx path. Bugzilla ID: 516 Fixes: c68

[dpdk-dev] [PATCH v4 5/5] net/fm10k: fix vector rx burst for fm10k

2020-09-17 Thread Jeff Guo
The scattered receive path should use a wrapper function to achieve the goal of burst maximizing. And do some code cleaning for vector rx path. Bugzilla ID: 516 Fixes: fe65e1e1ce61 ("fm10k: add vector scatter Rx") Signed-off-by: Jeff Guo --- drivers/net/fm10k/fm10k_rxtx_vec.c | 42 +

[dpdk-dev] [PATCH] af_xdp: avoid deadlock due to empty fill queue

2020-09-17 Thread Li RongQing
when receive packets, it is possible to fail to reserve fill queue, since buffer ring is shared between tx and rx, and maybe not available temporary. at last, both fill queue and rx queue are empty. then kernel side will be unable to receive packets due to empty fill queue, and dpdk will be unable

Re: [dpdk-dev] [PATCH v3] trace: fix compilation with C++

2020-09-17 Thread David Marchand
On Wed, Aug 12, 2020 at 11:52 AM wrote: > > From: Pawel Wodkowski > > trace_mem is declared as 'void *' which triggers following error: > '...invalid conversion from ‘void*’ to ‘__rte_trace_header*’ > [-fpermissive]...' > > Fix this by adding proper typecast to 'struct __rte_trace_header *'. > >

Re: [dpdk-dev] [PATCH 1/2] af_xdp: not return a negative value in af_xdp_rx_zc

2020-09-17 Thread Li,Rongqing
> -Original Message- > From: Loftus, Ciara [mailto:ciara.lof...@intel.com] > Sent: Thursday, September 17, 2020 3:33 PM > To: Li,Rongqing > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 1/2] af_xdp: not return a negative value in > af_xdp_rx_zc > > > > > af_xdp_rx_zc should always

Re: [dpdk-dev] [PATCH 1/2] config: add Graviton2(arm64) meson configuration

2020-09-17 Thread Jerin Jacob
On Mon, Sep 14, 2020 at 10:19 AM Honnappa Nagarahalli wrote: > > > > > > > On 9/11/20 8:23 PM, Honnappa Nagarahalli wrote: > > > > > > +Jerin, Hemant, Dharmik > > > > > > > > > Hi Vimal, > > > Few comments inline. > > > > > >> > > >> Add meson build configuration for Graviton2 platform w

[dpdk-dev] [V5 1/3] ethdev: introduce FEC API

2020-09-17 Thread Min Hu (Connor)
This patch adds Forward error correction(FEC) support for ethdev. Introduce APIs which support query and config FEC information in hardware. Signed-off-by: Min Hu (Connor) Reviewed-by: Wei Hu (Xavier) Reviewed-by: Chengwen Feng Reviewed-by: Chengchang Tang --- v4->v5: Modifies FEC capa definit

[dpdk-dev] [V5 0/3] add FEC support

2020-09-17 Thread Min Hu (Connor)
This series add FEC support for ethdev. Min Hu (Connor) (3): ethdev: introduce FEC API net/hns3: support FEC app/testpmd: add FEC command app/test-pmd/cmdline.c | 219 +++ app/test-pmd/config.c| 54 app/test-pmd/te

[dpdk-dev] [V5 2/3] net/hns3: support FEC

2020-09-17 Thread Min Hu (Connor)
Forward error correction (FEC) is a bit error correction mode. It adds error correction information to data packets at the transmit end, and uses the error correction information to correct the bit errors generated during data packet transmission at the receive end. This improves signal quality but

[dpdk-dev] [V5 3/3] app/testpmd: add FEC command

2020-09-17 Thread Min Hu (Connor)
This commit adds testpmd capability to query and config FEC function of device. This includes: - show FEC capabilities, example: testpmd> show port 0 fec capabilities - show FEC mode, example: testpmd> show port 0 fec_mode - config FEC mode, example: testpmd> set port 0

Re: [dpdk-dev] unable to bind to vfio-pci

2020-09-17 Thread Sarosh Arif
Hello, On Thu, Sep 17, 2020 at 12:32 PM Dybkowski, AdamX wrote: > > Hi. > > > -Original Message- > > From: dev On Behalf Of Sarosh Arif > > Sent: Thursday, 17 September, 2020 08:53 > > To: dev@dpdk.org > > Subject: [dpdk-dev] unable to bind to vfio-pci > > > > I have been trying to bind

[dpdk-dev] [PATCH v4 2/9] sched: add subport profile table

2020-09-17 Thread Savinay Dharmappa
Add subport profile table to internal port data structure and update the port config function. Signed-off-by: Savinay Dharmappa Signed-off-by: Jasvinder Singh --- lib/librte_sched/rte_sched.c | 185 ++- 1 file changed, 182 insertions(+), 3 deletions(-) d

[dpdk-dev] [PATCH v4 4/9] sched: update grinder credit and pipe config function

2020-09-17 Thread Savinay Dharmappa
Credits are updated by fetching subport profile parameters from subport profile table. Similarly subport best effort tc is calculated in pipe config. Signed-off-by: Savinay Dharmappa Signed-off-by: Jasvinder Singh --- lib/librte_sched/rte_sched.c | 55 ++-

[dpdk-dev] [PATCH v4 1/9] sched: add support profile data structure

2020-09-17 Thread Savinay Dharmappa
Add subport profile data structure to support dynamic configuration of subport bandwidth Signed-off-by: Savinay Dharmappa Signed-off-by: Jasvinder Singh --- lib/librte_sched/rte_sched.c | 10 ++ lib/librte_sched/rte_sched.h | 25 + 2 files changed, 35 insertions(

[dpdk-dev] [PATCH v4 0/9] Enable dynamic config of subport bandwidth

2020-09-17 Thread Savinay Dharmappa
DPDK sched library allows runtime configuration of the pipe profiles to the pipes of the subport once scheduler hierarchy is constructed. However, to change the subport level bandwidth, existing hierarchy needs to be dismantled and whole process of building hierarchy under subport nodes needs to be

[dpdk-dev] [PATCH v4 3/9] sched: add subport profile add and config api

2020-09-17 Thread Savinay Dharmappa
Add apis to add new subport profile and configure it. Signed-off-by: Savinay Dharmappa Signed-off-by: Jasvinder Singh --- lib/librte_sched/rte_sched.c | 118 + lib/librte_sched/rte_sched.h | 45 + lib/librte_sched/rte_sched_versio

[dpdk-dev] [PATCH v4 5/9] example/qos_sched: add dynamic config of subport

2020-09-17 Thread Savinay Dharmappa
Modify the qos_sched application to build the hierarchical scheduler with default subport bandwidth profile. It also allows to configure a subport with different subport bandwidth profile dynamically. Signed-off-by: Savinay Dharmappa --- examples/qos_sched/cfg_file.c | 151 +

[dpdk-dev] [PATCH v4 6/9] example/ip_pipeline: add dynamic config of subport

2020-09-17 Thread Savinay Dharmappa
Modify the ip_pipeline application to build the hierarchical scheduler with default subport bandwidth profile. It also allows to configure a subport with different subport bandwidth profile dynamically Signed-off-by: Savinay Dharmappa --- examples/ip_pipeline/cli.c | 14 -- examples

[dpdk-dev] [PATCH v4 9/9] sched: remove the redundant code

2020-09-17 Thread Savinay Dharmappa
Remove redundant data structure fields references from functions and subport level data structures. It also update the release and deprecation note. Signed-off-by: Savinay Dharmappa --- doc/guides/rel_notes/deprecation.rst | 6 -- doc/guides/rel_notes/release_20_11.rst | 4 ++ lib/librte_s

[dpdk-dev] [PATCH v4 7/9] drivers/softnic: add dynamic config of subport

2020-09-17 Thread Savinay Dharmappa
Modify the softnic drivers to build the hierarchical scheduler with default subport bandwidth profile. It also allows to configure a subport with different subport bandwidth profile dynamically. Signed-off-by: Savinay Dharmappa --- drivers/net/softnic/rte_eth_softnic_internals.h | 9 + drivers

[dpdk-dev] [PATCH v4 8/9] app/test_sched: add dynamic config of subport

2020-09-17 Thread Savinay Dharmappa
Modify the test_sched application to build the hierarchical scheduler with default subport bandwidth profile. It also allows to configure a subport with different subport bandwidth profile dynamically Signed-off-by: Savinay Dharmappa --- app/test/test_sched.c | 18 -- 1 file chan

[dpdk-dev] [V5 1/3] ethdev: introduce FEC API

2020-09-17 Thread Min Hu (Connor)
This patch adds Forward error correction(FEC) support for ethdev. Introduce APIs which support query and config FEC information in hardware. Signed-off-by: Min Hu (Connor) Reviewed-by: Wei Hu (Xavier) Reviewed-by: Chengwen Feng Reviewed-by: Chengchang Tang --- v4->v5: Modifies FEC capa definit

[dpdk-dev] [V5 3/3] app/testpmd: add FEC command

2020-09-17 Thread Min Hu (Connor)
This commit adds testpmd capability to query and config FEC function of device. This includes: - show FEC capabilities, example: testpmd> show port 0 fec capabilities - show FEC mode, example: testpmd> show port 0 fec_mode - config FEC mode, example: testpmd> set port 0

[dpdk-dev] [V5 0/3] add FEC support

2020-09-17 Thread Min Hu (Connor)
This series add FEC support for ethdev. Min Hu (Connor) (3): ethdev: introduce FEC API net/hns3: support FEC app/testpmd: add FEC command app/test-pmd/cmdline.c | 219 +++ app/test-pmd/config.c| 54 app/test-pmd/te

[dpdk-dev] [V5 2/3] net/hns3: support FEC

2020-09-17 Thread Min Hu (Connor)
Forward error correction (FEC) is a bit error correction mode. It adds error correction information to data packets at the transmit end, and uses the error correction information to correct the bit errors generated during data packet transmission at the receive end. This improves signal quality but

Re: [dpdk-dev] [PATCH 1/1] net/af_xdp: shared UMEM support

2020-09-17 Thread Loftus, Ciara
> > > > Kernel v5.10 will introduce the ability to efficiently share a UMEM between > > AF_XDP sockets bound to different queue ids on the same or different > > devices. This patch integrates that functionality into the AF_XDP PMD. > > > > A PMD will attempt to share a UMEM with others if the share

Re: [dpdk-dev] [PATCH] eventdev: support telemetry with xstats info

2020-09-17 Thread Power, Ciara
Hi Mike, See comment inline. Asides from that comment, overall the change looks good from a Telemetry usage point of view, in my opinion. Thanks, Ciara >-Original Message- >From: Chen, Mike Ximing >Sent: Wednesday 9 September 2020 21:55 >To: Jerin Jacob >Cc: dev@dpdk.org; Eads, Gage

Re: [dpdk-dev] [PATCH v2 0/3] enable AVX512 for iavf

2020-09-17 Thread Bruce Richardson
On Thu, Sep 17, 2020 at 09:37:29AM +0200, Morten Brørup wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > > Sent: Thursday, September 17, 2020 3:40 AM > > > > AVX512 instructions is supported by more and more platforms. These > > instructions > > can be used in the data

[dpdk-dev] [PATCH v2] net/dpaa2: fix build error about timesync functions

2020-09-17 Thread Chenxu Di
When the build option has '-DRTE_LIBRTE_IEEE1588=1', the announce of timesync functions will be build. However the dpdk_conf doesn't hav RTE_LIBRTE_IEEE1588 so that the file dpaa2_ptp.c will not be build. It cause the build error. This patch fixes it by adding set for dpdk_conf. Fixes: 184c39d1656

Re: [dpdk-dev] unable to bind to vfio-pci

2020-09-17 Thread Bruce Richardson
On Thu, Sep 17, 2020 at 11:52:58AM +0500, Sarosh Arif wrote: > I have been trying to bind to vfio-pci using usertools/dpdk-devbind.py > but am unable to do so. The reason behind this is that I am unable to > write in /sys/bus/pci/drivers/vfio-pci/bind. Upon searching solutions > I tried a couple of

Re: [dpdk-dev] [PATCH v2] test/mcslock: move performance test to perf tests

2020-09-17 Thread Juraj Linkeš
> -Original Message- > From: dev On Behalf Of Phil Yang > Sent: Tuesday, July 28, 2020 5:24 AM > To: david.march...@redhat.com; dev@dpdk.org > Cc: acon...@redhat.com; honnappa.nagaraha...@arm.com; > ruifeng.w...@arm.com; n...@arm.com; Thomas Monjalon > > Subject: [dpdk-dev] [PATCH v2]

Re: [dpdk-dev] [PATCH v2] test/atomic: reduce the number of loops to avoid timeouts

2020-09-17 Thread Juraj Linkeš
> -Original Message- > From: dev On Behalf Of Phil Yang > Sent: Tuesday, July 28, 2020 5:42 AM > To: david.march...@redhat.com; dev@dpdk.org > Cc: acon...@redhat.com; honnappa.nagaraha...@arm.com; > ruifeng.w...@arm.com; n...@arm.com > Subject: [dpdk-dev] [PATCH v2] test/atomic: reduce

Re: [dpdk-dev] [PATCH] net/tap: release port upon close

2020-09-17 Thread wangyunjian
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Wednesday, September 16, 2020 11:48 PM > To: wangyunjian ; dev@dpdk.org > Cc: tho...@monjalon.net; Lilijun (Jerry) ; xudingke > > Subject: Re: [dpdk-dev] [PATCH] net/tap: release port upon close > > On 9/16/

Re: [dpdk-dev] [dpdk-dev v2 2/2] fips_validation: update GCM test

2020-09-17 Thread Griffin, John
> -Original Message- > From: dev On Behalf Of Fan Zhang > Sent: Friday, September 4, 2020 5:10 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; Kusztal, > ArkadiuszX ; Dybkowski, AdamX > ; Zhang, Roy Fan ; > Janjua, Weqaar A > Subject: [dpdk-dev] [dpdk-dev v2 2/2] fips_v

Re: [dpdk-dev] [dpdk-dev v2 1/2] fips_validation: add SGL support

2020-09-17 Thread Griffin, John
> -Original Message- > From: dev On Behalf Of Fan Zhang > Sent: Friday, September 4, 2020 5:10 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; Kusztal, > ArkadiuszX ; Dybkowski, AdamX > ; Zhang, Roy Fan > Subject: [dpdk-dev] [dpdk-dev v2 1/2] fips_validation: add SGL sup

Re: [dpdk-dev] unable to bind to vfio-pci

2020-09-17 Thread Sarosh Arif
On Thu, Sep 17, 2020 at 2:17 PM Bruce Richardson wrote: > > On Thu, Sep 17, 2020 at 11:52:58AM +0500, Sarosh Arif wrote: > > I have been trying to bind to vfio-pci using usertools/dpdk-devbind.py > > but am unable to do so. The reason behind this is that I am unable to > > write in /sys/bus/pci/dr

Re: [dpdk-dev] [PATCH 1/2] config/arm: avoid variable reuse

2020-09-17 Thread Juraj Linkeš
> -Original Message- > From: dev On Behalf Of Dharmik Thakkar > Sent: Tuesday, August 25, 2020 11:13 PM > To: Thomas Monjalon > Cc: dev@dpdk.org; n...@arm.com; Dharmik Thakkar > > Subject: [dpdk-dev] [PATCH 1/2] config/arm: avoid variable reuse > > Rename 'machine' to 'machine_proper

Re: [dpdk-dev] unable to bind to vfio-pci

2020-09-17 Thread Burakov, Anatoly
On 17-Sep-20 10:21 AM, Sarosh Arif wrote: On Thu, Sep 17, 2020 at 2:17 PM Bruce Richardson wrote: On Thu, Sep 17, 2020 at 11:52:58AM +0500, Sarosh Arif wrote: I have been trying to bind to vfio-pci using usertools/dpdk-devbind.py but am unable to do so. The reason behind this is that I am una

Re: [dpdk-dev] [PATCH v2 0/3] enable AVX512 for iavf

2020-09-17 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Thursday, September 17, 2020 11:13 AM > > On Thu, Sep 17, 2020 at 09:37:29AM +0200, Morten Brørup wrote: > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > > > Sent: Thursday, September 17, 2020 3:

Re: [dpdk-dev] [PATCH v8 1/3] ethdev: add level support for RSS offload types

2020-09-17 Thread Andrew Rybchenko
On 9/17/20 5:07 AM, kirankum...@marvell.com wrote: > From: Kiran Kumar K > > This patch reserves 2 bits as input selection to select Inner and > outer encapsulation level for RSS computation. It is combined with existing > ETH_RSS_* to choose Inner or outer layers. > This functionality already ex

Re: [dpdk-dev] [PATCH] ethdev: add security flow item

2020-09-17 Thread Asaf Penso
>-Original Message- >From: dev On Behalf Of Stephen Hemminger >Sent: Thursday, September 10, 2020 7:46 PM >To: Tejasree Kondoj >Cc: Akhil Goyal ; Radu Nicolau >; Declan Doherty ; Ori >Kam ; NBU-Contact-Thomas Monjalon >; Ferruh Yigit ; Andrew >Rybchenko ; Jerin Jacob ; >Narayana Prasad ;

Re: [dpdk-dev] [PATCH 1/1] net/af_xdp: shared UMEM support

2020-09-17 Thread Tahhan, Maryam
> -Original Message- > From: Loftus, Ciara > Sent: Thursday 17 September 2020 09:55 > To: Tahhan, Maryam > Cc: dev@dpdk.org > Subject: RE: [PATCH 1/1] net/af_xdp: shared UMEM support > > > > > > > Kernel v5.10 will introduce the ability to efficiently share a UMEM > > > between AF_XDP

Re: [dpdk-dev] [PATCH 2/2] build: find max lcore programmatically

2020-09-17 Thread Juraj Linkeš
> -Original Message- > From: Dharmik Thakkar > Sent: Friday, September 4, 2020 7:44 AM > To: Stephen Hemminger > Cc: Juraj Linkeš ; Jerin Jacob > ; tho...@monjalon.net; dpdk-dev ; > nd > Subject: Re: [dpdk-dev] [PATCH 2/2] build: find max lcore programmatically > > > > > On Sep 3, 2

Re: [dpdk-dev] [V5 1/3] ethdev: introduce FEC API

2020-09-17 Thread Andrew Rybchenko
On 9/17/20 11:52 AM, Min Hu (Connor) wrote: > This patch adds Forward error correction(FEC) support for ethdev. > Introduce APIs which support query and config FEC information in > hardware. > > Signed-off-by: Min Hu (Connor) > Reviewed-by: Wei Hu (Xavier) > Reviewed-by: Chengwen Feng > Reviewe

Re: [dpdk-dev] unable to bind to vfio-pci

2020-09-17 Thread Bruce Richardson
On Thu, Sep 17, 2020 at 02:21:27PM +0500, Sarosh Arif wrote: > On Thu, Sep 17, 2020 at 2:17 PM Bruce Richardson > wrote: > > > > On Thu, Sep 17, 2020 at 11:52:58AM +0500, Sarosh Arif wrote: > > > I have been trying to bind to vfio-pci using usertools/dpdk-devbind.py > > > but am unable to do so. T

Re: [dpdk-dev] [PATCH v2 RESEND] vfio: fix resource leak when mapping fails

2020-09-17 Thread Burakov, Anatoly
On 11-Sep-20 12:08 PM, wangyunjian wrote: From: Yunjian Wang Currently, only the 'vfio_dev_fd' is closed in failure path, so some resources are not released(such as 'vfio_group_fd'). The rte_vfio_release_device() should be used to avoid this problem. Fixes: 33604c31354a ("vfio: refactor PCI BA

Re: [dpdk-dev] [PATCH v2] vfio: fix mem leak when unmapping resource

2020-09-17 Thread Burakov, Anatoly
On 11-Sep-20 11:57 AM, wangyunjian wrote: From: Yunjian Wang The 'vfio_res' is not freed when unmapping resource by primary process. This leads to memory leak. Fixes: ab53203e194b ("vfio: enable unmapping resource for secondary") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- Acked-by

[dpdk-dev] DPDK Release Status Meeting 17/09/2020

2020-09-17 Thread Ferruh Yigit
Meeting minutes of 17 September 2020 Agenda: * Release Dates * Highlights * Subtrees * LTS * Conferences Participants: * Arm * Broadcom * Intel * Marvell * Nvidia * Red Hat Release Dates - * v20.11 dates * Proposal/V1 deadline passed, it was

[dpdk-dev] [PATCH v2 0/4] remove aliases replaced with IOVA

2020-09-17 Thread Thomas Monjalon
When introducing IOVA semantic, 3 years ago, some fields, functions and macros mentioning "physical address" were marked as deprecated and replaced with IOVA aliases. Some parts of the original "physical address" semantic have been removed over the years, other parts are still there. This pathset

[dpdk-dev] [PATCH v2 3/4] mbuf: remove deprecated function and macro aliases

2020-09-17 Thread Thomas Monjalon
Remove the deprecated functions - rte_mbuf_data_dma_addr - rte_mbuf_data_dma_addr_default which aliased the more recent functions - rte_mbuf_data_iova - rte_mbuf_data_iova_default Remove the deprecated macros - rte_pktmbuf_mtophys - rte_pktmbuf_mtoph

[dpdk-dev] [PATCH v2 2/4] mempool: remove physical address aliases

2020-09-17 Thread Thomas Monjalon
Remove the deprecated unioned fields physaddr and phys_addr from the structures rte_mempool_objhdr and rte_mempool_memhdr. They are replaced with the fields iova which are at the same offsets. Remove the deprecated macro MEMPOOL_F_NO_PHYS_CONTIG which is an alias of the more recent MEMPOOL_F_NO_IO

[dpdk-dev] [PATCH v2 4/4] mbuf: remove physical address alias

2020-09-17 Thread Thomas Monjalon
Remove the deprecated buf_physaddr union field from rte_mbuf. It is replaced with buf_iova which is at the same offset. The single field buf_physaddr in rte_kni_mbuf is also renamed. This concludes a 3-year process of semantic change. Signed-off-by: Thomas Monjalon Acked-by: Andrew Rybchenko -

[dpdk-dev] [PATCH v2 1/4] mem: remove physical address aliases

2020-09-17 Thread Thomas Monjalon
Remove the deprecated unioned fields phys_addr from the structures rte_memseg and rte_memzone. They are replaced with the fields iova which are at the same offsets. Signed-off-by: Thomas Monjalon Acked-by: Andrew Rybchenko Acked-by: Anatoly Burakov --- doc/guides/rel_notes/release_20_11.rst

Re: [dpdk-dev] [PATCH v2 1/4] mem: remove physical address aliases

2020-09-17 Thread Hemant Agrawal
On 9/17/2020 4:11 PM, Thomas Monjalon wrote: Remove the deprecated unioned fields phys_addr from the structures rte_memseg and rte_memzone. They are replaced with the fields iova which are at the same offsets. Signed-off-by: Thomas Monjalon Acked-by: Andrew Rybchenko Acked-by: Anatoly Burako

Re: [dpdk-dev] [PATCH v2 3/4] mbuf: remove deprecated function and macro aliases

2020-09-17 Thread Hemant Agrawal
Acked-by: Hemant Agrawal *

Re: [dpdk-dev] Issue with net/netvsc pmd in 18.11.9

2020-09-17 Thread Long Li
The patch below is correct. I'm wondering if you have missed another patch. The most suspects are "77cf88c0c6 net/netvsc: fix underflow when Rx external mbuf" and https://patches.dpdk.org/patch/67511/

[dpdk-dev] [Bug 537] FM1000 "PMD: eth_fm10k_dev_init(): switch is not ready" error

2020-09-17 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=537 Bug ID: 537 Summary: FM1000 "PMD: eth_fm10k_dev_init(): switch is not ready" error Product: DPDK Version: 19.11 Hardware: x86 OS: Linux Status: UNCONFIRM

Re: [dpdk-dev] [PATCH v4 4/5] net/ice: fix vector rx burst for ice

2020-09-17 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Jia > Sent: Thursday, September 17, 2020 3:59 PM > To: Yang, Qiming ; Xing, Beilei > ; Zhang, Qi Z ; Wu, Jingjing > ; Wang, Haiyue > Cc: Zhao1, Wei ; Richardson, Bruce > ; dev@dpdk.org; Guo, Jia ; > Zhang, Helin ; m...@smartsharesystems.com; Yigit, > F

[dpdk-dev] [PATCH] examples/ioat: fix stats print

2020-09-17 Thread Kevin Laatz
Currently some of the status string at the top of the stats output is being cut off. To fix this, the status string array size has been increased. Bugzilla ID: 536 Fixes: 632bcd9b5d4f ("examples/ioat: print statistics") Signed-off-by: Kevin Laatz --- examples/ioat/ioatfwd.c | 2 +- 1 file chang

Re: [dpdk-dev] [PATCH] devtools: fix ninja break under default DESTDIR path

2020-09-17 Thread Juraj Linkeš
> -Original Message- > From: dev On Behalf Of Phil Yang > Sent: Thursday, July 9, 2020 8:53 AM > To: david.march...@redhat.com; dev@dpdk.org > Cc: honnappa.nagaraha...@arm.com; ruifeng.w...@arm.com; n...@arm.com > Subject: [dpdk-dev] [PATCH] devtools: fix ninja break under default DESTD

Re: [dpdk-dev] [PATCH v3 1/1] vfio: modify spapr iommu support to use static window sizing

2020-09-17 Thread Burakov, Anatoly
On 10-Aug-20 10:07 PM, David Christensen wrote: The SPAPR IOMMU requires that a DMA window size be defined before memory can be mapped for DMA. Current code dynamically modifies the DMA window size in response to every new memory allocation which is potentially dangerous because all existing mapp

Re: [dpdk-dev] [PATCH v2 3/4] app/testpmd: fix packet header in txonly mode

2020-09-17 Thread Ferruh Yigit
On 9/17/2020 8:10 AM, Chengchang Tang wrote: On 2020/9/15 0:23, Ferruh Yigit wrote: On 8/20/2020 2:42 AM, Wei Hu (Xavier) wrote: From: Chengchang Tang In txonly forward mode, the packet header is fixed by the initial setting, including the packet length and checksum. So when the packets var

Re: [dpdk-dev] [PATCH] net/mlx5: fix vectorized Rx burst check

2020-09-17 Thread Matan Azrad
From: Viacheslav Ovsiienko > The Rx queue start/stop feature is not supported if vectorized rx_burst > routine is engaged. There was a routine address typo and rx_burst type > check was wrong. > > Fixes: 161d103b231c ("net/mlx5: add queue start and stop") > > Signed-off-by: Viacheslav Ovsiienk

Re: [dpdk-dev] [PATCH v1 1/6] app/test: fix deadlock in distributor test

2020-09-17 Thread David Hunt
Hi Lukasz, On 15/9/2020 8:34 PM, Lukasz Wojciechowski wrote: The sanity test with worker shutdown delegates all bufs to be processed by a single lcore worker, then it freezes one of the lcore workers and continues to send more bufs. Problem occurred if freezed lcore is the same as the one that

Re: [dpdk-dev] [PATCH] mem: fix allocation failure on non-NUMA kernel

2020-09-17 Thread Burakov, Anatoly
On 05-Aug-20 4:21 PM, Nick Connolly wrote: On 05/08/2020 16:13, Nicolas Dichtel wrote: Le 05/08/2020 à 16:53, Nick Connolly a écrit : [snip] +    if (check_numa()) { +    ret = get_mempolicy(&cur_socket_id, NULL, 0, addr, +    MPOL_F_NODE | MPOL_F_ADDR); +    if (ret <

[dpdk-dev] [PATCH v3 1/6] ethdev: remove unused kernel driver field

2020-09-17 Thread David Marchand
This field was not generic as it was filled with PCI kernel drivers only. It has no known in-tree user (and I could not find opensource projects using it). Signed-off-by: David Marchand Acked-by: Andrew Rybchenko --- doc/guides/rel_notes/deprecation.rst | 3 --- doc/guides/rel_notes/release_2

[dpdk-dev] [PATCH v3 2/6] bus/pci: switch to private kernel driver enum

2020-09-17 Thread David Marchand
The rte_kernel_driver enum actually only pointed at PCI drivers and is only used in the PCI subsystem. Remove it from the generic device API and use a private enum in the PCI code. Signed-off-by: David Marchand Acked-by: Andrew Rybchenko --- doc/guides/rel_notes/deprecation.rst| 4 -- doc/

[dpdk-dev] [PATCH v3 0/6] 20.11 announced cleanups

2020-09-17 Thread David Marchand
I put those EAL and PCI cleanups as a single series since I intend to apply them at once with the rte_logs series. Nothing really hard in this series, but the devil is in the details, reviews welcome. -- David Marchand Changelog since v2: - no change: rebased, added acks, reworded patch3 commi

[dpdk-dev] [PATCH v3 4/6] mem: drop mapping API workaround

2020-09-17 Thread David Marchand
Now that the pci_map_resource API is private to the PCI bus, we can drop the compatibility workaround we had implemented in 20.08. Signed-off-by: David Marchand Acked-by: Andrew Rybchenko --- drivers/bus/pci/bsd/pci.c | 2 +- drivers/bus/pci/linux/pci_uio.c | 2 +- drive

[dpdk-dev] [PATCH v3 6/6] bus/pci: remove duplicate declaration

2020-09-17 Thread David Marchand
This declaration is the same as the one a few lines before. Fixes: 6844d146ff39 ("eal: add bus pointer in device structure") Cc: sta...@dpdk.org Signed-off-by: David Marchand Acked-by: Andrew Rybchenko --- drivers/bus/pci/private.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/b

[dpdk-dev] [PATCH v3 3/6] pci: move resource mapping to the PCI bus

2020-09-17 Thread David Marchand
As reported during 20.08 work for Windows, the pci_map_resource API was built with the assumption that its flags would be passed to mmap(). This introduced a regression when adding the rte_mem_map API as reported in the workaround commit 9d2b24593724 ("pci: keep API compatibility with mmap values"

[dpdk-dev] [PATCH v3 5/6] eal: hide internal device event structure

2020-09-17 Thread David Marchand
This structure is not used in the public API. Fixes: a753e53d517b ("eal: add device event monitor framework") Signed-off-by: David Marchand --- doc/guides/rel_notes/deprecation.rst | 3 --- doc/guides/rel_notes/release_20_11.rst | 3 +++ lib/librte_eal/include/rte_dev.h | 6 -- lib/

Re: [dpdk-dev] [PATCH] mem: fix allocation failure on non-NUMA kernel

2020-09-17 Thread Burakov, Anatoly
On 05-Aug-20 1:26 PM, Nick Connolly wrote: Running dpdk-helloworld on Linux with lib numa present, but no kernel support for NUMA (CONFIG_NUMA=n) causes ret_service_init() to fail with EAL: error allocating rte services array. alloc_seg() calls get_mempolicy to verify that the allocation has hap

Re: [dpdk-dev] [PATCH v2] eal/linux: do not create user mem map repeatedly when it exists

2020-09-17 Thread Burakov, Anatoly
On 05-Aug-20 1:58 PM, wangyunjian wrote: -Original Message- From: Burakov, Anatoly [mailto:anatoly.bura...@intel.com] Sent: Friday, July 31, 2020 7:55 PM To: wangyunjian ; dev@dpdk.org; david.march...@redhat.com Cc: Lilijun (Jerry) ; xudingke ; sta...@dpdk.org Subject: Re: [dpdk-dev] [PAT

Re: [dpdk-dev] [PATCH] examples/ioat: fix stats print

2020-09-17 Thread Bruce Richardson
On Thu, Sep 17, 2020 at 12:02:21PM +0100, Kevin Laatz wrote: > Currently some of the status string at the top of the stats output is being > cut off. To fix this, the status string array size has been increased. > > Bugzilla ID: 536 > Fixes: 632bcd9b5d4f ("examples/ioat: print statistics") > > Si

Re: [dpdk-dev] [PATCH v2] eal/linux: do not create user mem map repeatedly when it exists

2020-09-17 Thread Burakov, Anatoly
On 23-Jul-20 3:48 PM, wangyunjian wrote: From: Yunjian Wang Currently, we will create new user mem map entry for the same memory segment, but in fact it has already been added to the user mem maps. It's not necessary to create it twice. To resolve the issue, add support to remove the same entr

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/dpaa2: fix build error about timesync functions

2020-09-17 Thread Ferruh Yigit
On 9/17/2020 3:03 AM, Di, ChenxuX wrote: Hi, -Original Message- From: Ferruh Yigit Sent: Wednesday, September 16, 2020 11:29 PM To: Di, ChenxuX ; hemant.agra...@nxp.com Cc: sachin.sax...@nxp.com; sta...@dpdk.org; dev@dpdk.org; Richardson, Bruce Subject: Re: [dpdk-stable] [PATCH] net/d

Re: [dpdk-dev] [PATCH 1/2] vfio: fix check for vfio_group_fd

2020-09-17 Thread Burakov, Anatoly
On 19-May-20 4:42 AM, wangyunjian wrote: From: Yunjian Wang The issue is that a file descriptor at 0 is a valid one. Currently the file not found, the return value will be set to 0. As a result, it is impossible to distinguish between a correct descriptor and a failed return value. Fix it to re

[dpdk-dev] [PATCH v2] net/tap: release port upon close

2020-09-17 Thread wangyunjian
From: Yunjian Wang Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources for the port can be freed by rte_eth_dev_close(). Signed-off-by: Yunjian Wang --- v2: Remove redundant check and assignment suggested by Ferruh Yigit and Thomas Monjalon --- drivers/net/tap/rte_eth_ta

Re: [dpdk-dev] [PATCH v2] net/dpaa2: fix build error about timesync functions

2020-09-17 Thread Hemant Agrawal
Acked-by: Hemant Agrawal On 9/17/2020 2:13 PM, Chenxu Di wrote: When the build option has '-DRTE_LIBRTE_IEEE1588=1', the announce of timesync functions will be build. However the dpdk_conf doesn't hav RTE_LIBRTE_IEEE1588 so that the file dpaa2_ptp.c will not be build. It cause the build error.

Re: [dpdk-dev] [PATCH v2 3/4] app/testpmd: fix packet header in txonly mode

2020-09-17 Thread Chengchang Tang
On 2020/9/17 19:16, Ferruh Yigit wrote: > On 9/17/2020 8:10 AM, Chengchang Tang wrote: >> >> >> On 2020/9/15 0:23, Ferruh Yigit wrote: >>> On 8/20/2020 2:42 AM, Wei Hu (Xavier) wrote: From: Chengchang Tang In txonly forward mode, the packet header is fixed by the initial set

Re: [dpdk-dev] unable to bind to vfio-pci

2020-09-17 Thread Burakov, Anatoly
On 17-Sep-20 11:22 AM, Bruce Richardson wrote: On Thu, Sep 17, 2020 at 02:21:27PM +0500, Sarosh Arif wrote: On Thu, Sep 17, 2020 at 2:17 PM Bruce Richardson wrote: On Thu, Sep 17, 2020 at 11:52:58AM +0500, Sarosh Arif wrote: I have been trying to bind to vfio-pci using usertools/dpdk-devbind

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/dpaa2: fix build error about timesync functions

2020-09-17 Thread Hemant Agrawal
On 9/17/2020 5:08 PM, Ferruh Yigit wrote: On 9/17/2020 3:03 AM, Di, ChenxuX wrote: Hi, -Original Message- From: Ferruh Yigit Sent: Wednesday, September 16, 2020 11:29 PM To: Di, ChenxuX ; hemant.agra...@nxp.com Cc: sachin.sax...@nxp.com; sta...@dpdk.org; dev@dpdk.org; Richardson, Br

Re: [dpdk-dev] [PATCH v1 2/6] app/test: synchronize statistics between lcores

2020-09-17 Thread David Hunt
On 15/9/2020 8:34 PM, Lukasz Wojciechowski wrote: Statistics of handled packets are cleared and read on main lcore, while they are increased in workers handlers on different lcores. Without synchronization occasionally showed invalid values. This patch uses atomic acquire/release mechanisms to

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/dpaa2: fix build error about timesync functions

2020-09-17 Thread Ferruh Yigit
On 9/17/2020 12:50 PM, Hemant Agrawal wrote: On 9/17/2020 5:08 PM, Ferruh Yigit wrote: On 9/17/2020 3:03 AM, Di, ChenxuX wrote: Hi, -Original Message- From: Ferruh Yigit Sent: Wednesday, September 16, 2020 11:29 PM To: Di, ChenxuX ; hemant.agra...@nxp.com Cc: sachin.sax...@nxp.com;

[dpdk-dev] [PATCH v1] net/ice: enhance the FlexiMD handling

2020-09-17 Thread Haiyue Wang
The ice hardware supports different FlexiMDs selection into mbuf, it can have different offset in the Rx descriptor for single FlexiMD, like flow id. So it needs to handle the FlexiMD extraction according to the RXDID. Signed-off-by: Haiyue Wang --- drivers/net/ice/ice_rxtx.c | 260 +

Re: [dpdk-dev] [PATCH v1 5/5] net/i40e: fix max mtu size packets with vlan tag cannot be received by default

2020-09-17 Thread Ananyev, Konstantin
> > Subject: RE: [dpdk-dev] [PATCH v1 5/5] net/i40e: fix max mtu size packets > > with vlan tag cannot be received by default > > > > > testpmd will initialize default max packet length to 1518 which does't > > > include vlan tag size in ether overheader. Once, send the max mtu > > > length packe

Re: [dpdk-dev] [PATCH v4 1/3] app/testpmd: add GENEVE parsing

2020-09-17 Thread Olivier Matz
Hi Ophir, Please find some comments below. On Tue, Sep 15, 2020 at 01:17:15PM +, Ophir Munk wrote: > From: Ophir Munk > > GENEVE is a widely used tunneling protocol in modern Virtualized > Networks. testpmd already supports parsing of several tunneling > protocols including VXLAN, VXLAN-GPE

  1   2   >