Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix vf reset hw error handling

2020-09-22 Thread Guo, Jia
Acked-by: Jeff Guo > -Original Message- > From: Yang, SteveX > Sent: Tuesday, September 15, 2020 2:46 PM > To: dev@dpdk.org > Cc: Zhao1, Wei ; Guo, Jia ; Yang, > Qiming ; Yang, SteveX > Subject: [PATCH v3] net/ixgbe: fix vf reset hw error handling > > When start a VF with no initial MA

Re: [dpdk-dev] [PATCH v2] vhost: remove experimental tag on vDPA API

2020-09-22 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, September 15, 2020 3:26 PM > To: dev@dpdk.org; Xia, Chenbo ; ma...@nvidia.com > Cc: Maxime Coquelin > Subject: [PATCH v2] vhost: remove experimental tag on vDPA API > > As announced in v20.08, this patch makes the vDPA > and r

Re: [dpdk-dev] [PATCH 4/4] vhost: remove dequeue zero-copy support

2020-09-22 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, September 15, 2020 9:36 PM > To: dev@dpdk.org; Xia, Chenbo ; Stokes, Ian > > Cc: Maxime Coquelin > Subject: [PATCH 4/4] vhost: remove dequeue zero-copy support > > Dequeue zero-copy removal was announced in DPDK v

Re: [dpdk-dev] [PATCH 3/4] examples/vhost: remove dequeue zero-copy support

2020-09-22 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, September 15, 2020 9:36 PM > To: dev@dpdk.org; Xia, Chenbo ; Stokes, Ian > > Cc: Maxime Coquelin > Subject: [PATCH 3/4] examples/vhost: remove dequeue zero-copy support > > Dequeue zero-copy feature is being removed from the

Re: [dpdk-dev] [PATCH 2/4] examples/vhost_crypto: use vhost async-copy flag

2020-09-22 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, September 15, 2020 9:36 PM > To: dev@dpdk.org; Xia, Chenbo ; Stokes, Ian > > Cc: Maxime Coquelin > Subject: [PATCH 2/4] examples/vhost_crypto: use vhost async-copy flag > > The crypto backend uses RTE_VHOST_USER_DEQUEUE_ZERO_

Re: [dpdk-dev] [PATCH 1/4] net/vhost: remove dequeue zero-copy support

2020-09-22 Thread Xia, Chenbo
Hi Maxime, You left a helper string here 😊 (http://code.dpdk.org/dpdk/v20.08/source/drivers/net/vhost/rte_eth_vhost.c#L1677) Thanks! Chenbo > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, September 15, 2020 9:36 PM > To: dev@dpdk.org; Xia, Chenbo ; Stokes, Ian > > Cc: Max

Re: [dpdk-dev] [PATCH 1/3] test/event_crypto_adapter: return error with unsupported mode

2020-09-22 Thread Ankur Dwivedi
Hi Abhinandan, Please see my comments inline. Thanks Ankur >-Original Message- >From: Ankur Dwivedi >Sent: Friday, September 18, 2020 8:34 PM >To: 'Gujjar, Abhinandan S' ; dev@dpdk.org >Cc: Jerin Jacob Kollanukkaran ; Anoob Joseph > >Subject: RE: [PATCH 1/3] test/event_crypto_adapter: re

Re: [dpdk-dev] [PATCH v2] crypto/octeontx2: fix sessionless code

2020-09-22 Thread Ankur Dwivedi
>-Original Message- >From: Akhil Goyal >Sent: Wednesday, September 23, 2020 1:19 AM >To: Ankur Dwivedi ; dev@dpdk.org >Cc: Anoob Joseph ; Tejasree Kondoj > >Subject: [EXT] RE: [PATCH v2] crypto/octeontx2: fix sessionless code > >External Email > >

Re: [dpdk-dev] [PATCH v2 2/8] app/test: synchronize statistics between lcores

2020-09-22 Thread Honnappa Nagarahalli
> > Statistics of handled packets are cleared and read on main lcore, while they > are increased in workers handlers on different lcores. > > Without synchronization occasionally showed invalid values. What exactly do you mean by invalid values? Can you elaborate? > This patch uses atomic acqu

[dpdk-dev] [PATCH v3 4/5] net/i40e: fix max mtu size packets with vlan tag cannot be received by default

2020-09-22 Thread SteveX Yang
testpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side. But for i40e/i40evf, they should s

[dpdk-dev] [PATCH v3 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by default

2020-09-22 Thread SteveX Yang
testpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side. ice can support dual vlan tags th

[dpdk-dev] [PATCH v3 5/5] net/iavf: fix max mtu size packets with vlan tag cannot be received by default

2020-09-22 Thread SteveX Yang
testpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side. iavf can support dual vlan tags t

[dpdk-dev] [PATCH v3 2/5] net/igc: fix max mtu size packets with vlan tag cannot be received by default

2020-09-22 Thread SteveX Yang
testpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side. igc can support single vlan tag t

[dpdk-dev] [PATCH v3 1/5] net/e1000: fix max mtu size packets with vlan tag cannot be received by default

2020-09-22 Thread SteveX Yang
testpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side. e1000 can support single vlan tag

[dpdk-dev] [PATCH v3 0/5] fix default max mtu size when device configured

2020-09-22 Thread SteveX Yang
testpmd will initialize default max packet length to 1518 which does't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped directly from NIC hw side. configure the correct default max

Re: [dpdk-dev] [PATCH] net/bnxt: fix PCI per-function stats

2020-09-22 Thread Ajit Khaparde
On Mon, Sep 21, 2020 at 10:45 AM Lance Richardson < lance.richard...@broadcom.com> wrote: > Fix to use correct value offset for PCI function stats. > > Fixes: 5f9374de2a3a ("net/bnxt: add PCI function stats to extended stats") > > Reviewed-by: Ajit Kumar Khaparde > Cc: sta...@dpdk.org > Cc: ajit.

[dpdk-dev] [Bug 540] ixgbe: Intel 82599 4*10 NIC with 1000BASE-T SFP transceiver does not work for the first port.

2020-09-22 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=540 Bug ID: 540 Summary: ixgbe: Intel 82599 4*10 NIC with 1000BASE-T SFP transceiver does not work for the first port. Product: DPDK Version: 20.08 Hardware: x86 OS: Lin

Re: [dpdk-dev] [v2 1/2] cryptodev: support enqueue callback functions

2020-09-22 Thread Honnappa Nagarahalli
> > > > > > > > > > > > > In an eventdev world, multiple workers (with ordered queue) > > > > > > will be working on IPsec ESP processing. The ESP header's > > > > > > sequence number is unique and has to be sequentially > > > > > > incremented in an orderly > > > manner. > > > > > > This rises

Re: [dpdk-dev] [PATCH v3 3/6] app/testpmd: remove restriction on txpkts set

2020-09-22 Thread Wei Hu (Xavier)
Hi, Ferruh Yigit On 2020/9/22 22:51, Ferruh Yigit wrote: On 9/19/2020 11:47 AM, Wei Hu (Xavier) wrote: From: Chengchang Tang Currently, if nb_txd is not set, the txpkts is not allowed to be set because the nb_txd is used to avoid the numer of segments exceed the Tx ring size and the default v

Re: [dpdk-dev] [RFC v2 1/1] app/testpmd: distinguish ICMP identifier fields in packet

2020-09-22 Thread Li Zhang
Yes, There is PMD code change to support it. https://patchwork.dpdk.org/patch/78488/ -Original Message- From: dev On Behalf Of Ferruh Yigit Sent: Tuesday, September 22, 2020 11:38 PM To: Li Zhang ; Dekel Peled ; Ori Kam ; Slava Ovsiienko ; Matan Azrad Cc: dev@dpdk.org; NBU-Contact-Thom

[dpdk-dev] [PATCH v1 1/1] net/mlx5: support match ICMP identifier fields

2020-09-22 Thread Li Zhang
PRM expose fields "Icmp_header_data" in ICMP. Update ICMP mask parameter with ICMP identifier and sequence number fields. ICMP sequence number spec with mask, Icmp_header_data low 16 bits are set. ICMP identifier spec with mask, Icmp_header_data high 16 bits are set. Signed-off-by: Li Zhang ---

Re: [dpdk-dev] [PATCH v6 2/3] gro: add VXLAN UDP/IPv4 GRO support

2020-09-22 Thread Jiayu Hu
On Wed, Sep 23, 2020 at 10:28:00AM +0800, yang_y_yi wrote: > Thanks Jiayu, do you mean not comparing timestamp and flush all the packets in > a flow as I showed code, right? If so, we shouldn't provide argument > flush_timestamp. But this will result in very bad issues, > rte_gro_timeout_flush > w

Re: [dpdk-dev] [PATCH V2 1/4] ethdev: fix compiling errors for per-queue statistics

2020-09-22 Thread Min Hu (Connor)
在 2020/9/5 2:31, Ferruh Yigit 写道: On 9/4/2020 12:32 PM, Min Hu (Connor) wrote: From: Huisong Li Currently, only statistics of rx/tx queues with queue_id less than RTE_ETHDEV_QUEUE_STAT_CNTRS can be displayed. If there is a certain application scenario that it needs to use 256 or more than 2

Re: [dpdk-dev] [PATCH v6 2/3] gro: add VXLAN UDP/IPv4 GRO support

2020-09-22 Thread yang_y_yi
Thanks Jiayu, do you mean not comparing timestamp and flush all the packets in a flow as I showed code, right? If so, we shouldn't provide argument flush_timestamp. But this will result in very bad issues, rte_gro_timeout_flush will be called after rte_gro_reassemble every time, so the result ma

Re: [dpdk-dev] Duplicating traffic with RTE Flow

2020-09-22 Thread Jiawei(Jonny) Wang
Hi Jan, Sorry for late response, Could you check the below latest patches that support flow-based traffic sampling? (based on: net/enic: support VXLAN decap action combined with VLAN pop) https://patchwork.dpdk.org/project/dpdk/list/?series=12410 " The solution introduces a new action that will

[dpdk-dev] [PATCH v7 11/11] doc: update bbdev feature table

2020-09-22 Thread Nicolas Chautru
Correcting overview matrix to use acc100 name Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao --- doc/guides/bbdevs/features/acc100.ini | 14 ++ doc/guides/bbdevs/features/mbc.ini| 14 -- 2 files changed, 14 insertions(+), 14 deletions(-) create mode 100644 do

[dpdk-dev] [PATCH v7 09/11] baseband/acc100: add debug function to validate input

2020-09-22 Thread Nicolas Chautru
Debug functions to validate the input API from user Only enabled in DEBUG mode at build time Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao --- drivers/baseband/acc100/rte_acc100_pmd.c | 424 +++ 1 file changed, 424 insertions(+) diff --git a/drivers/baseband

[dpdk-dev] [PATCH v7 10/11] baseband/acc100: add configure function

2020-09-22 Thread Nicolas Chautru
Add configure function to configure the PF from within the bbdev-test itself without external application configuration the device. Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao --- app/test-bbdev/test_bbdev_perf.c | 72 +++ drivers/baseband/acc100/meson.build

[dpdk-dev] [PATCH v7 08/11] baseband/acc100: add interrupt support to PMD

2020-09-22 Thread Nicolas Chautru
Adding capability and functions to support MSI interrupts, call backs and inforing. Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao --- drivers/baseband/acc100/rte_acc100_pmd.c | 288 ++- drivers/baseband/acc100/rte_acc100_pmd.h | 15 ++ 2 files changed, 300 i

[dpdk-dev] [PATCH v7 04/11] baseband/acc100: add queue configuration

2020-09-22 Thread Nicolas Chautru
Adding function to create and configure queues for the device. Still no capability. Signed-off-by: Nicolas Chautru Reviewed-by: Rosen Xu Acked-by: Liu Tianjiao --- drivers/baseband/acc100/rte_acc100_pmd.c | 420 ++- drivers/baseband/acc100/rte_acc100_pmd.h | 45 +++

[dpdk-dev] [PATCH v7 06/11] baseband/acc100: add HARQ loopback support

2020-09-22 Thread Nicolas Chautru
Additional support for HARQ memory loopback Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao --- drivers/baseband/acc100/rte_acc100_pmd.c | 158 +++ 1 file changed, 158 insertions(+) diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc1

[dpdk-dev] [PATCH v7 07/11] baseband/acc100: add support for 4G processing

2020-09-22 Thread Nicolas Chautru
Adding capability for 4G encode and decoder processing Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao --- drivers/baseband/acc100/rte_acc100_pmd.c | 1010 -- 1 file changed, 943 insertions(+), 67 deletions(-) diff --git a/drivers/baseband/acc100/rte_acc100_pm

[dpdk-dev] [PATCH v7 05/11] baseband/acc100: add LDPC processing functions

2020-09-22 Thread Nicolas Chautru
Adding LDPC decode and encode processing operations Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao Acked-by: Dave Burley --- drivers/baseband/acc100/rte_acc100_pmd.c | 1625 +- drivers/baseband/acc100/rte_acc100_pmd.h |3 + 2 files changed, 1626 insertion

[dpdk-dev] [PATCH v7 03/11] baseband/acc100: add info get function

2020-09-22 Thread Nicolas Chautru
Add in the "info_get" function to the driver, to allow us to query the device. No processing capability are available yet. Linking bbdev-test to support the PMD with null capability. Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao --- app/test-bbdev/meson.build | 3 + driv

[dpdk-dev] [PATCH v7 02/11] baseband/acc100: add register definition file

2020-09-22 Thread Nicolas Chautru
Add in the list of registers for the device and related HW specs definitions. Signed-off-by: Nicolas Chautru Reviewed-by: Rosen Xu Acked-by: Liu Tianjiao --- drivers/baseband/acc100/acc100_pf_enum.h | 1068 ++ drivers/baseband/acc100/acc100_vf_enum.h | 73 ++ driv

[dpdk-dev] [PATCH v7 01/11] drivers/baseband: add PMD for ACC100

2020-09-22 Thread Nicolas Chautru
Add stubs for the ACC100 PMD Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao --- doc/guides/bbdevs/acc100.rst | 233 + doc/guides/bbdevs/index.rst| 1 + doc/guides/rel_notes/release_20_11.rst | 6 + drivers/

[dpdk-dev] [PATCH v7 00/11] bbdev PMD ACC100

2020-09-22 Thread Nicolas Chautru
v7: Fingers trouble. Previous one sent mid-rebase. My bad. v6: removed a legacy makefile no longer required v5: rebase based on latest on main. The legacy makefiles are removed. v4: an odd compilation error is reported for one CI variant using "gcc latest" which looks to me like a false positive

[dpdk-dev] [PATCH v6 11/11] baseband/acc100: add debug function to validate input

2020-09-22 Thread Nicolas Chautru
Debug functions to validate the input API from user Only enabled in DEBUG mode at build time Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao --- drivers/baseband/acc100/rte_acc100_pmd.c | 424 +++ 1 file changed, 424 insertions(+) diff --git a/drivers/baseband

Re: [dpdk-dev] [PATCH v4 00/11] bbdev PMD ACC100

2020-09-22 Thread Chautru, Nicolas
Hi Akhil, > > Hi Nicolas, > > > > > Hi Akhil, > > Just a heads up on this bbdev PMD which is ready and was reviewed for > > some time by the community. > > There is one warning on patchwork but it can be ignored (one ack email > > sent with bad formatting). > > Thanks and best regards, > > Nic >

[dpdk-dev] [PATCH v6 10/11] baseband/acc100: add interrupt support to PMD

2020-09-22 Thread Nicolas Chautru
Adding capability and functions to support MSI interrupts, call backs and inforing. Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao --- drivers/baseband/acc100/rte_acc100_pmd.c | 288 ++- drivers/baseband/acc100/rte_acc100_pmd.h | 15 ++ 2 files changed, 300 i

[dpdk-dev] [PATCH v6 04/11] baseband/acc100: add register definition file

2020-09-22 Thread Nicolas Chautru
Add in the list of registers for the device and related HW specs definitions. Signed-off-by: Nicolas Chautru Reviewed-by: Rosen Xu Acked-by: Liu Tianjiao --- drivers/baseband/acc100/acc100_pf_enum.h | 1068 ++ drivers/baseband/acc100/acc100_vf_enum.h | 73 ++ driv

[dpdk-dev] [PATCH v6 09/11] baseband/acc100: add support for 4G processing

2020-09-22 Thread Nicolas Chautru
Adding capability for 4G encode and decoder processing Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao --- drivers/baseband/acc100/rte_acc100_pmd.c | 1010 -- 1 file changed, 943 insertions(+), 67 deletions(-) diff --git a/drivers/baseband/acc100/rte_acc100_pm

[dpdk-dev] [PATCH v6 07/11] baseband/acc100: add LDPC processing functions

2020-09-22 Thread Nicolas Chautru
Adding LDPC decode and encode processing operations Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao Acked-by: Dave Burley --- drivers/baseband/acc100/rte_acc100_pmd.c | 1625 +- drivers/baseband/acc100/rte_acc100_pmd.h |3 + 2 files changed, 1626 insertion

[dpdk-dev] [PATCH v6 06/11] baseband/acc100: add queue configuration

2020-09-22 Thread Nicolas Chautru
Adding function to create and configure queues for the device. Still no capability. Signed-off-by: Nicolas Chautru Reviewed-by: Rosen Xu Acked-by: Liu Tianjiao --- drivers/baseband/acc100/rte_acc100_pmd.c | 420 ++- drivers/baseband/acc100/rte_acc100_pmd.h | 45 +++

[dpdk-dev] [PATCH v6 08/11] baseband/acc100: add HARQ loopback support

2020-09-22 Thread Nicolas Chautru
Additional support for HARQ memory loopback Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao --- drivers/baseband/acc100/rte_acc100_pmd.c | 158 +++ 1 file changed, 158 insertions(+) diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc1

[dpdk-dev] [PATCH v6 03/11] drivers/baseband: add PMD for ACC100

2020-09-22 Thread Nicolas Chautru
Add stubs for the ACC100 PMD Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao --- doc/guides/bbdevs/acc100.rst | 233 + doc/guides/bbdevs/index.rst| 1 + doc/guides/rel_notes/release_20_11.rst | 6 + drivers/

[dpdk-dev] [PATCH v6 02/11] test/service: fix race condition on stopping lcore

2020-09-22 Thread Nicolas Chautru
From: Harry van Haaren This commit fixes a potential race condition in the tests where the lcore running a service would increment a counter that was already reset by the test-suite thread. The resulting race-condition incremented value could cause CI failures, as indicated by DPDK's CI. This pa

[dpdk-dev] [PATCH v6 05/11] baseband/acc100: add info get function

2020-09-22 Thread Nicolas Chautru
Add in the "info_get" function to the driver, to allow us to query the device. No processing capability are available yet. Linking bbdev-test to support the PMD with null capability. Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao --- app/test-bbdev/meson.build | 3 + driv

[dpdk-dev] [PATCH v6 01/11] service: retrieve lcore active state

2020-09-22 Thread Nicolas Chautru
From: Harry van Haaren This commit adds a new experimental API which allows the user to retrieve the active state of an lcore. Knowing when the service lcore is completed its polling loop can be useful to applications to avoid race conditions when e.g. finalizing statistics. The service thread i

[dpdk-dev] [PATCH v6 00/11] bbdev PMD ACC100

2020-09-22 Thread Nicolas Chautru
v6: removed a legacy makefile no longer required v5: rebase based on latest on main. The legacy makefiles are removed. v4: an odd compilation error is reported for one CI variant using "gcc latest" which looks to me like a false positive of maybe-undeclared. http://mails.dpdk.org/archives/test-r

[dpdk-dev] [PATCH v5 05/11] baseband/acc100: add LDPC processing functions

2020-09-22 Thread Nicolas Chautru
Adding LDPC decode and encode processing operations Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao Acked-by: Dave Burley --- drivers/baseband/acc100/rte_acc100_pmd.c | 1625 +- drivers/baseband/acc100/rte_acc100_pmd.h |3 + 2 files changed, 1626 insertion

[dpdk-dev] [PATCH v5 10/11] baseband/acc100: add configure function

2020-09-22 Thread Nicolas Chautru
Add configure function to configure the PF from within the bbdev-test itself without external application configuration the device. Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao --- app/test-bbdev/test_bbdev_perf.c | 72 +++ drivers/baseband/acc100/Makefile

[dpdk-dev] [PATCH v5 09/11] baseband/acc100: add debug function to validate input

2020-09-22 Thread Nicolas Chautru
Debug functions to validate the input API from user Only enabled in DEBUG mode at build time Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao --- drivers/baseband/acc100/rte_acc100_pmd.c | 424 +++ 1 file changed, 424 insertions(+) diff --git a/drivers/baseband

[dpdk-dev] [PATCH v5 06/11] baseband/acc100: add HARQ loopback support

2020-09-22 Thread Nicolas Chautru
Additional support for HARQ memory loopback Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao --- drivers/baseband/acc100/rte_acc100_pmd.c | 158 +++ 1 file changed, 158 insertions(+) diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc1

[dpdk-dev] [PATCH v5 07/11] baseband/acc100: add support for 4G processing

2020-09-22 Thread Nicolas Chautru
Adding capability for 4G encode and decoder processing Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao --- drivers/baseband/acc100/rte_acc100_pmd.c | 1010 -- 1 file changed, 943 insertions(+), 67 deletions(-) diff --git a/drivers/baseband/acc100/rte_acc100_pm

[dpdk-dev] [PATCH v5 11/11] doc: update bbdev feature table

2020-09-22 Thread Nicolas Chautru
Correcting overview matrix to use acc100 name Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao --- doc/guides/bbdevs/features/acc100.ini | 14 ++ doc/guides/bbdevs/features/mbc.ini| 14 -- 2 files changed, 14 insertions(+), 14 deletions(-) create mode 100644 do

[dpdk-dev] [PATCH v5 08/11] baseband/acc100: add interrupt support to PMD

2020-09-22 Thread Nicolas Chautru
Adding capability and functions to support MSI interrupts, call backs and inforing. Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao --- drivers/baseband/acc100/rte_acc100_pmd.c | 288 ++- drivers/baseband/acc100/rte_acc100_pmd.h | 15 ++ 2 files changed, 300 i

[dpdk-dev] [PATCH v5 01/11] drivers/baseband: add PMD for ACC100

2020-09-22 Thread Nicolas Chautru
Add stubs for the ACC100 PMD Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao --- doc/guides/bbdevs/acc100.rst | 233 + doc/guides/bbdevs/index.rst| 1 + doc/guides/rel_notes/release_20_11.rst | 6 + drivers/

[dpdk-dev] [PATCH v5 04/11] baseband/acc100: add queue configuration

2020-09-22 Thread Nicolas Chautru
Adding function to create and configure queues for the device. Still no capability. Signed-off-by: Nicolas Chautru Reviewed-by: Rosen Xu Acked-by: Liu Tianjiao --- drivers/baseband/acc100/rte_acc100_pmd.c | 420 ++- drivers/baseband/acc100/rte_acc100_pmd.h | 45 +++

[dpdk-dev] [PATCH v5 03/11] baseband/acc100: add info get function

2020-09-22 Thread Nicolas Chautru
Add in the "info_get" function to the driver, to allow us to query the device. No processing capability are available yet. Linking bbdev-test to support the PMD with null capability. Signed-off-by: Nicolas Chautru Acked-by: Liu Tianjiao --- app/test-bbdev/meson.build | 3 + driv

[dpdk-dev] [PATCH v5 02/11] baseband/acc100: add register definition file

2020-09-22 Thread Nicolas Chautru
Add in the list of registers for the device and related HW specs definitions. Signed-off-by: Nicolas Chautru Reviewed-by: Rosen Xu Acked-by: Liu Tianjiao --- drivers/baseband/acc100/acc100_pf_enum.h | 1068 ++ drivers/baseband/acc100/acc100_vf_enum.h | 73 ++ driv

[dpdk-dev] [PATCH v5 00/11] bbdev PMD ACC100

2020-09-22 Thread Nicolas Chautru
v5: rebase based on latest on main. The legacy makefiles are removed. v4: an odd compilation error is reported for one CI variant using "gcc latest" which looks to me like a false positive of maybe-undeclared. http://mails.dpdk.org/archives/test-report/2020-August/148936.html Still forcing a dum

[dpdk-dev] [Bug 539] [dpdk-20.11] distributor/test_multiple_ports: Failed to map pci BAR4 only in SLES15_SP1

2020-09-22 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=539 Bug ID: 539 Summary: [dpdk-20.11] distributor/test_multiple_ports: Failed to map pci BAR4 only in SLES15_SP1 Product: DPDK Version: 20.11 Hardware: x86 OS: Linux

Re: [dpdk-dev] [PATCH v6 2/3] gro: add VXLAN UDP/IPv4 GRO support

2020-09-22 Thread Jiayu Hu
On Tue, Sep 22, 2020 at 03:38:29PM +0800, yang_y_yi wrote: > The problem is timestamp of which one item in a flow we should use as > timestamp > reference base for this flow, for merge (reassemble), only the first packet > can > trigger merge of all the packets, merge is forward not backward, if

Re: [dpdk-dev] [PATCH] build: enable packet data prefetch

2020-09-22 Thread Liu, Yong
> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, September 22, 2020 10:12 PM > To: Liu, Yong > Cc: Richardson, Bruce ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] build: enable packet data prefetch > > On Tue, 22 Sep 2020 16:21:35 +0800 > Marvin Liu wrote: > > > Dat

[dpdk-dev] [PATCH v2] config: enable packet data prefetch

2020-09-22 Thread Marvin Liu
Data prefetch instruction can preload data into cpu’s hierarchical cache before data access. Virtualized data paths like virtio utilized this feature for acceleration. Since most modern cpus have support prefetch function, we can enable packet data prefetch as default. Signed-off-by: Marvin Liu -

Re: [dpdk-dev] [PATCH v1 3/6] app/test: fix freeing mbufs in distributor tests

2020-09-22 Thread Lukasz Wojciechowski
Hello David, W dniu 22.09.2020 o 14:42, David Marchand pisze: > Hello Lukasz, David, > > > On Tue, Sep 15, 2020 at 9:35 PM Lukasz Wojciechowski > wrote: >> diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c >> index 0e49e3714..da13a9a3f 100644 >> --- a/app/test/test_distributo

[dpdk-dev] [PATCH v2 8/8] distributor: align API documentation with code

2020-09-22 Thread Lukasz Wojciechowski
After introducing burst API there were some artefacts in the API documentation from legacy single API. Also the rte_distributor_poll_pkt() function return values mismatched the implementation. Fixes: c0de0eb82e40 ("distributor: switch over to new API") Cc: david.h...@intel.com Cc: sta...@dpdk.org

[dpdk-dev] [PATCH v2 5/8] distributor: fix missing handshake synchronization

2020-09-22 Thread Lukasz Wojciechowski
rte_distributor_return_pkt function which is run on worker cores must wait for distributor core to clear handshake on retptr64 before using those buffers. While the handshake is set distributor core controls buffers and any operations on worker side might overwrite buffers which are unread yet. Sam

[dpdk-dev] [PATCH v2 4/8] app/test: collect return mbufs in distributor test

2020-09-22 Thread Lukasz Wojciechowski
During quit_workers function distributor's main core processes some packets to wake up pending worker cores so they can quit. As quit_workers acts also as a cleanup procedure for next test case it should also collect these packages returned by workers' handlers, so the cyclic buffer with returned p

[dpdk-dev] [PATCH v2 7/8] distributor: do not use oldpkt when not needed

2020-09-22 Thread Lukasz Wojciechowski
rte_distributor_request_pkt and rte_distributor_get_pkt dereferenced oldpkt parameter when in RTE_DIST_ALG_SINGLE even if number of returned buffers from worker to distributor was 0. This patch passes NULL to the legacy API when number of returned buffers is 0. This allows passing NULL as oldpkt p

[dpdk-dev] [PATCH v2 6/8] distributor: fix handshake deadlock

2020-09-22 Thread Lukasz Wojciechowski
Synchronization of data exchange between distributor and worker cores is based on 2 handshakes: retptr64 for returning mbufs from workers to distributor and bufptr64 for passing mbufs to workers. Without proper order of verifying those 2 handshakes a deadlock may occur. This can happen when worker

[dpdk-dev] [PATCH v2 3/8] app/test: fix freeing mbufs in distributor tests

2020-09-22 Thread Lukasz Wojciechowski
Sanity tests with mbuf alloc and shutdown tests assume that mbufs passed to worker cores are freed in handlers. Such packets should not be returned to the distributor's main core. The only packets that should be returned are the packets send after completion of the tests in quit_workers function.

[dpdk-dev] [PATCH v2 1/8] app/test: fix deadlock in distributor test

2020-09-22 Thread Lukasz Wojciechowski
The sanity test with worker shutdown delegates all bufs to be processed by a single lcore worker, then it freezes one of the lcore workers and continues to send more bufs. Problem occurred if freezed lcore is the same as the one that is processing the mbufs. The lcore processing mbufs might be dif

[dpdk-dev] [PATCH v2 0/8] fix distributor synchronization issues

2020-09-22 Thread Lukasz Wojciechowski
During review and verification of the patch created by Sarosh Arif: "test_distributor: prevent memory leakages from the pool" I found out that running distributor unit tests multiple times in a row causes fails. So I investigated all the issues I found. There are few synchronization issues that mi

[dpdk-dev] [PATCH v2 2/8] app/test: synchronize statistics between lcores

2020-09-22 Thread Lukasz Wojciechowski
Statistics of handled packets are cleared and read on main lcore, while they are increased in workers handlers on different lcores. Without synchronization occasionally showed invalid values. This patch uses atomic acquire/release mechanisms to synchronize. Fixes: c3eabff124e6 ("distributor: add

Re: [dpdk-dev] [PATCH v11 5/5] net/ice: use WC store to update queue tail registers

2020-09-22 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: dev On Behalf Of Radu Nicolau > Sent: Wednesday, August 26, 2020 5:56 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia ; > Richardson, Bruce ; Ananyev, Konstantin > ; jerinjac...@gmail.com; > david.march...@redhat.com; Trahe, Fiona ; Zhao1, > Wei ; ruif

Re: [dpdk-dev] [PATCH v11 4/5] net/ixgbe: use WC store to update queue tail registers

2020-09-22 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: dev On Behalf Of Radu Nicolau > Sent: Wednesday, August 26, 2020 5:56 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia ; > Richardson, Bruce ; Ananyev, Konstantin > ; jerinjac...@gmail.com; > david.march...@redhat.com; Trahe, Fiona ; Zhao1, > Wei ; ruif

Re: [dpdk-dev] [PATCH v11 2/5] net/i40e: use WC store to update queue tail registers

2020-09-22 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: dev On Behalf Of Radu Nicolau > Sent: Wednesday, August 26, 2020 5:56 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia ; > Richardson, Bruce ; Ananyev, Konstantin > ; jerinjac...@gmail.com; > david.march...@redhat.com; Trahe, Fiona ; Zhao1, > Wei ; ruif

[dpdk-dev] Recent failure in autotest

2020-09-22 Thread Stephen Hemminger
The blacklist/whitelist documentation patch which is totally unrelated to this failed in the unit test. Looks like recent cmdline changes caused a problem? 10: [/home/jenkins-local/jenkins-agent/workspace/Ubuntu18.04-Unit-Test-DPDK/dpdk/build/app/test/dpdk-test(+0x3973a) [0x55acef45573a]] 9: [/

Re: [dpdk-dev] [PATCH v4] eal: add cache-line demote support

2020-09-22 Thread Maslekar, Omkar
Hi Bruce, My comments are inline >-Original Message- >From: Bruce Richardson >Sent: Tuesday, September 22, 2020 1:28 AM >To: Maslekar, Omkar >Cc: dev@dpdk.org; Loftus, Ciara >Subject: Re: [PATCH v4] eal: add cache-line demote support > >On Mon, Sep 21, 2020 at 06:59:27PM -0700,

Re: [dpdk-dev] [PATCH 2/2] net/bnxt: fix rxq/txq offload information get op

2020-09-22 Thread Lance Richardson
On Tue, Sep 22, 2020 at 1:30 PM Lance Richardson wrote: > Apologies for not sending a cover letter. I can resend if needed. Lance

Re: [dpdk-dev] [PATCH v4] windows/netuio: add Windows NetUIO kernel driver

2020-09-22 Thread Ranjit Menon
On 9/18/2020 7:52 PM, Narcisa Ana Maria Vasile wrote: From: Narcisa Vasile The Windows netuio kernel driver provides the DPDK userspace application with direct access to hardware, by mapping the HW registers in userspace and allowing read/write operations from/to the device configuration spac

[dpdk-dev] [PATCH 2/2] net/bnxt: fix rxq/txq offload information get op

2020-09-22 Thread Lance Richardson
Return current offloads in rxq_info_get()/txq_info_get(). Fixes: 2fc201884be8 ("net/bnxt: support rxq/txq get information") Cc: sta...@dpdk.org Signed-off-by: Lance Richardson Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 2 ++ 1 file changed, 2 in

[dpdk-dev] [PATCH 1/2] net/bnxt: fix drop en in rxq get information

2020-09-22 Thread Lance Richardson
Return correct value for rx_drop_en. Add per-queue field to track rx_drop_en configuration. Fixes: 2fc201884be8 ("net/bnxt: support rxq/txq get information") Cc: sta...@dpdk.org Signed-off-by: Lance Richardson Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_eth

Re: [dpdk-dev] [PATCH v4] windows/netuio: add Windows NetUIO kernel driver

2020-09-22 Thread Dmitry Kozlyuk
On Fri, 18 Sep 2020 19:52:33 -0700, Narcisa Ana Maria Vasile wrote: > From: Narcisa Vasile > > The Windows netuio kernel driver provides the DPDK userspace application > with direct access to hardware, by mapping the HW registers in userspace > and allowing read/write operations from/to the devic

[dpdk-dev] Unknown speed

2020-09-22 Thread Ivan Dyukov
It's virtio support for 'ETH_SPEED_NUM_UNKNOWN' which was already merged to dpdk-next-net/main

[dpdk-dev] [PATCH 2/2] net/virtio: sync a virtio speed capa with ethdev

2020-09-22 Thread Ivan Dyukov
ethdev library was updated with new speed 200G Add 200G speed capa to virtio device Signed-off-by: Ivan Dyukov --- drivers/net/virtio/virtio_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 0ef88feda..4

[dpdk-dev] [PATCH 1/2] net/virtio: set UNKNOWN as default speed

2020-09-22 Thread Ivan Dyukov
rte_ethdev states new rule for NICs: they should return UNKNOWN speed if speed is unknown and interface is up, in case of down interface, NONE speed should be returned. Signed-off-by: Ivan Dyukov --- doc/guides/nics/virtio.rst | 4 ++-- drivers/net/virtio/virtio_ethdev.c | 9 - 2

Re: [dpdk-dev] [PATCH v4 00/41] Pipeline alignment with the P4 language

2020-09-22 Thread Dumitrescu, Cristian
> -Original Message- > From: Wang, Han2 > Sent: Tuesday, September 22, 2020 9:06 PM > To: Dumitrescu, Cristian ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 00/41] Pipeline alignment with the P4 > language > > Cristian > > Thanks for updating the patch set. As I mentioned in my pr

Re: [dpdk-dev] [PATCH v4 00/41] Pipeline alignment with the P4 language

2020-09-22 Thread Wang, Han2
Cristian Thanks for updating the patch set. As I mentioned in my previous email, we are working on adding support for this as a new P4C CPU target. We plan to open source the compiler backend in the near future. Cheers, Han On 9/10/20, 8:27 AM, "dev on behalf of Cristian Dumitrescu" wrote:

Re: [dpdk-dev] [PATCH] app/test-sad: fix uninitialized variable

2020-09-22 Thread Akhil Goyal
> Coverity issue: 362055 > > Fixes: 908be0651a5a ("app/test-sad: add test application for IPsec SAD") > Cc: sta...@dpdk.org > > Signed-off-by: Vladimir Medvedkin > --- Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH v2] crypto/octeontx2: fix sessionless code

2020-09-22 Thread Akhil Goyal
> A temporary session is created for sessionless crypto operations. > rte_cryptodev_sym_session_create() should be used for creating the > temporary session as it initializes the session structure in the > correct way. Also the session should be set to 0 before freeing it. > > Fixes: 17ac2a72191b

Re: [dpdk-dev] [PATCH v4 1/6] drivers: add generic API to find PCI extended cap

2020-09-22 Thread Jerin Jacob
On Tue, Jul 28, 2020 at 4:06 AM Gaëtan Rivet wrote: > > On 27/07/20 15:03 -0700, Manish Chopra wrote: > > By adding generic API, this patch removes individual > > functions/defines implemented by drivers to find extended > > PCI capabilities. > > > > Signed-off-by: Manish Chopra > > Signed-off-by

Re: [dpdk-dev] [PATCH v4 00/11] bbdev PMD ACC100

2020-09-22 Thread Akhil Goyal
Hi Nicolas, > > Hi Akhil, > Just a heads up on this bbdev PMD which is ready and was reviewed for some > time by the community. > There is one warning on patchwork but it can be ignored (one ack email sent > with bad formatting). > Thanks and best regards, > Nic There are changes in Makefiles, wh

Re: [dpdk-dev] [PATCH] test/event_crypto_adapter: fix conf issue

2020-09-22 Thread Akhil Goyal
Hi Abhinandan, > This patch updates the xform with right configuration. > For session based ops, sym session pool is created with > valid userdata size. > > Signed-off-by: Abhinandan Gujjar > --- The patch description do not match with the patch. I can see that you are changing the cipher algo f

Re: [dpdk-dev] [PATCH] [RFC] cryptodev: move AES-GMAC to aead algorithms

2020-09-22 Thread Akhil Goyal
Hi Arek, > > Hi Akhil, > > @Akhil: Is there a chance getting this change into 20.11? > > Any more comments or anyone see any potential issues with this approach? > I am ok to take this patch in 20.11 release. Could you please send a new version With complete patch, removing all references of

Re: [dpdk-dev] [PATCH 3/3] crypto/nitrox: support cipher only crypto operations

2020-09-22 Thread Akhil Goyal
Hi Nagadheeraj, > Subject: [PATCH 3/3] crypto/nitrox: support cipher only crypto operations > > This patch adds cipher only crypto operation support. > > Signed-off-by: Nagadheeraj Rottela > --- Could you please rebase this patch on latest TOT? I see a conflict in the last patch. You can also

Re: [dpdk-dev] [PATCH v3] eventdev: support telemetry with xstats info

2020-09-22 Thread Eads, Gage
> -Original Message- > From: Chen, Mike Ximing > Sent: Friday, September 18, 2020 12:39 PM > To: Jerin Jacob > Cc: dev@dpdk.org; Eads, Gage ; Vedantham, Sundar > ; Power, Ciara ; > Richardson, Bruce > Subject: [PATCH v3] eventdev: support telemetry with xstats info > > The telemetry

[dpdk-dev] [PATCH] net/ring: fix unchecked return value

2020-09-22 Thread Kevin Laatz
Add a check for the return value of the sscanf call in parse_internal_args(), returning an error if we don't get the expected result. Coverity issue: 362049 Fixes: 96cb19521147 ("net/ring: use EAL APIs in PMD specific API") Cc: sta...@dpdk.org Signed-off-by: Kevin Laatz --- drivers/net/ring/rte

  1   2   3   4   >