Re: [dpdk-dev] [PATCH v2 00/60] common/sfc_efx: support Riverhead NIC family

2020-09-23 Thread Andrew Rybchenko
Hi Ferruh, On 9/23/20 8:45 PM, Ferruh Yigit wrote: > On 9/22/2020 10:33 AM, Andrew Rybchenko wrote: >> Riverhead is a new NIC family, the first one with EF100 architecture. >> Control interface is an MCDI similar to EF10. Datapath interface is >> completely new. >> >> The patch series is build tes

Re: [dpdk-dev] [PATCH v3 3/6] app/testpmd: remove restriction on txpkts set

2020-09-23 Thread Chengchang Tang
On 2020/9/24 0:59, Ferruh Yigit wrote: > On 9/23/2020 12:57 PM, Wei Hu (Xavier) wrote: >> Hi, Ferruh Yigit >> >> On 2020/9/23 11:14, Wei Hu (Xavier) wrote: >>> Hi, Ferruh Yigit >>> >>> On 2020/9/22 22:51, Ferruh Yigit wrote: On 9/19/2020 11:47 AM, Wei Hu (Xavier) wrote: > From: Chengcha

Re: [dpdk-dev] [PATCH 7/7] net/virtio: introduce Vhost-vDPA backend

2020-09-23 Thread Xia, Chenbo
Hi Patrick, > -Original Message- > From: Fu, Patrick > Sent: Thursday, September 24, 2020 1:44 PM > To: Xia, Chenbo ; Maxime Coquelin > ; dev@dpdk.org; amore...@redhat.com > Subject: RE: [dpdk-dev] [PATCH 7/7] net/virtio: introduce Vhost-vDPA > backend > > > -Original Message- >

Re: [dpdk-dev] [PATCH 7/7] net/virtio: introduce Vhost-vDPA backend

2020-09-23 Thread Fu, Patrick
> -Original Message- > From: Xia, Chenbo > Sent: Thursday, September 24, 2020 1:26 PM > To: Maxime Coquelin ; dev@dpdk.org; Fu, > Patrick ; amore...@redhat.com > Subject: RE: [dpdk-dev] [PATCH 7/7] net/virtio: introduce Vhost-vDPA > backend > > Hi Maxime, > > > + > > +/** > > + * Set up

Re: [dpdk-dev] [PATCH v2] kernel: remove igb_uio

2020-09-23 Thread Stephen Hemminger
On Fri, 11 Sep 2020 17:54:48 +0200 Thomas Monjalon wrote: > As decided in the Technical Board in November 2019, > the kernel module igb_uio is moved to the dpdk-kmods repository > in the /linux/igb_uio/ directory. > > Minutes of Technical Board meeting: > https://mails.dpdk.org/archives/dev/2019

[dpdk-dev] [PATCH v3 4/4] ethdev: use C11 atomic builtins for link status update

2020-09-23 Thread Phil Yang
Since rte_atomicXX APIs are not allowed to be used, use C11 atomic builtins for link status update. Signed-off-by: Phil Yang Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli Acked-by: Andrew Rybchenko --- lib/librte_ethdev/rte_ethdev_driver.h | 19 +-- 1 file change

[dpdk-dev] [PATCH v3 2/4] bbdev: use C11 atomic builtins for device processing counter

2020-09-23 Thread Phil Yang
Since rte_atomicXX APIs are not allowed to be used, use C11 atomic builtins for device processing counter. Signed-off-by: Phil Yang Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- lib/librte_bbdev/rte_bbdev.c | 5 +++-- lib/librte_bbdev/rte_bbdev.h | 4 +--- 2 files changed, 4

[dpdk-dev] [PATCH v3 0/4] use C11 atomic builtins for libs

2020-09-23 Thread Phil Yang
Since rte_atomicXX APIs are not allowed to be used[1][2], use C11 atomic builtins instead in eal, bbdev, power, and ethdev libs. [1] http://code.dpdk.org/dpdk/latest/source/doc/guides/rel_notes/deprecation.rst#L87 [2] http://code.dpdk.org/dpdk/latest/source/devtools/checkpatches.sh#L80 v3: remov

[dpdk-dev] [PATCH v3 1/4] eal: use C11 atomic builtins for already initialized check

2020-09-23 Thread Phil Yang
Since rte_atomicXX APIs are not allowed to be used, use C11 builtins to check if EAL is already initialized. Signed-off-by: Phil Yang Reviewed-by: Honnappa Nagarahalli Reviewed-by: Ruifeng Wang --- lib/librte_eal/freebsd/eal.c | 19 ++- lib/librte_eal/linux/eal.c | 21 +++

[dpdk-dev] [PATCH v3 3/4] power: use C11 atomic builtins for power in use state update

2020-09-23 Thread Phil Yang
Since rte_atomicXX APIs are not allowed to be used, use C11 atomic builtins for power in use state update. Signed-off-by: Phil Yang Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- lib/librte_power/power_acpi_cpufreq.c | 45 + lib/librte_power/p

[dpdk-dev] [PATCH v6 7/7] app/proc-info: provide way to request info on owned ports

2020-09-23 Thread Stephen Hemminger
There are cases where a port maybe owned by another (failsafe, netvsc, bond); but currently proc-info has no way to look at stats of those ports. This patch provides way for the user to explicitly ask for these ports. If no portmask is given the output is unchanged; it only shows the top level por

[dpdk-dev] [PATCH v6 6/7] app/proc-info: add crypto security context info

2020-09-23 Thread Stephen Hemminger
From: Hemant Agrawal If crypto context is not present, no point in displaying it. This patch adds the crypto based security context info. Also improve the flag printing to SECURITY OFFLOAD from INLINE. Use common code for displaying crypto context information when doing show_ports and show_cryp

[dpdk-dev] [PATCH v6 5/7] app/proc-info: dump rx and tx descriptor info

2020-09-23 Thread Stephen Hemminger
Many drivers will report per queue info as well as how many descriptors are in use. Also display per-queue offload flags. Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- app/proc-info/main.c | 93 +++- 1 file changed, 74 insertions(+), 19 de

[dpdk-dev] [PATCH v6 0/7] app/proc-info: enhancements

2020-09-23 Thread Stephen Hemminger
The current proc-info command is useful for diagnosing issues with external DPDK applications, but the display is limited and somewhat ugly. This patchset adds some enhancements which show more info and suppress unnecessary stuff. A before/after example: # dpdk-proc-info -w 03:00.0 -- --show-por

[dpdk-dev] [PATCH v6 2/7] app/proc-info: eliminate useless borders

2020-09-23 Thread Stephen Hemminger
Printing extra borders does not improve readability, and is just unnecessary. Putting TSC hz in header also makes no sense here. Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- app/proc-info/main.c | 35 +++ 1 file changed, 7 insertions(+), 28 delet

[dpdk-dev] [PATCH v6 1/7] app/proc-info: remove unused logtype #define

2020-09-23 Thread Stephen Hemminger
This logtype is defined but never used. Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- app/proc-info/main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index 64fb83b38dd4..1623c3723b3e 100644 --- a/app/proc-info/main.c +++ b/ap

[dpdk-dev] [PATCH v6 4/7] app/proc-info: add more info to show_ports

2020-09-23 Thread Stephen Hemminger
Revise the display of port information to include more data and be more human friendly. * Show driver and device information * Show MAC address * Show flow control information * Combine lines if possible * Show all multicast mode * Show queue mempool name Signed-off-by: Stephen Hemmin

[dpdk-dev] [PATCH v6 3/7] app/proc-info: hide EAL info messages

2020-09-23 Thread Stephen Hemminger
The DPDK EAL info messages at the start of a diagnostic application are not helpful to end user. Suppress them by setting log-level by default. Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- app/proc-info/main.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) di

Re: [dpdk-dev] [PATCH] ethdev: add security flow item

2020-09-23 Thread Tejasree Kondoj
Thanks, Tejasree > -Original Message- > From: Ori Kam > Sent: Wednesday, September 23, 2020 8:00 PM > To: Tejasree Kondoj ; Asaf Penso > ; Stephen Hemminger > Cc: Akhil Goyal ; Radu Nicolau > ; Declan Doherty ; > NBU-Contact-Thomas Monjalon ; Ferruh Yigit > ; Andrew Rybchenko > ; Jerin J

Re: [dpdk-dev] [PATCH 1/7] bus/vdev: add DMA mapping ops

2020-09-23 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: dev On Behalf Of Maxime Coquelin > Sent: Friday, September 11, 2020 11:08 PM > To: dev@dpdk.org; Fu, Patrick ; amore...@redhat.com > Cc: Maxime Coquelin > Subject: [dpdk-dev] [PATCH 1/7] bus/vdev: add DMA mapping ops > > Add DMA map/unmap operatio

Re: [dpdk-dev] [PATCH 7/7] net/virtio: introduce Vhost-vDPA backend

2020-09-23 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: dev On Behalf Of Maxime Coquelin > Sent: Friday, September 11, 2020 11:08 PM > To: dev@dpdk.org; Fu, Patrick ; amore...@redhat.com > Cc: Maxime Coquelin > Subject: [dpdk-dev] [PATCH 7/7] net/virtio: introduce Vhost-vDPA backend > > vhost-vDPA is a

Re: [dpdk-dev] [PATCH 4/7] net/virtio: adapt Virtio-user status size

2020-09-23 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: dev On Behalf Of Maxime Coquelin > Sent: Friday, September 11, 2020 11:08 PM > To: dev@dpdk.org; Fu, Patrick ; amore...@redhat.com > Cc: Maxime Coquelin > Subject: [dpdk-dev] [PATCH 4/7] net/virtio: adapt Virtio-user status size > > Set proper pay

[dpdk-dev] [Bug 541] [dpdk-20.11] loopback_virtio_user_server_mode/Basic_test_for_packed_ring_server_mode: loopback throughput is zero

2020-09-23 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=541 Bug ID: 541 Summary: [dpdk-20.11] loopback_virtio_user_server_mode/Basic_test_for_packed _ring_server_mode: loopback throughput is zero Product: DPDK Version: 20.11

Re: [dpdk-dev] [v2 1/2] cryptodev: support enqueue callback functions

2020-09-23 Thread Honnappa Nagarahalli
> > In an eventdev world, multiple workers (with ordered queue) will be working > on IPsec ESP processing. The ESP header's sequence number is unique and > has to be sequentially incremented in an orderly manner. > This rises a need for incrementing sequence number in crypto stage > especially i

Re: [dpdk-dev] [PATCH 2/2] net/bnxt: fix rxq/txq offload information get op

2020-09-23 Thread Ajit Khaparde
On Tue, Sep 22, 2020 at 10:30 AM Lance Richardson wrote: > > Return current offloads in rxq_info_get()/txq_info_get(). > > Fixes: 2fc201884be8 ("net/bnxt: support rxq/txq get information") > Cc: sta...@dpdk.org > > Signed-off-by: Lance Richardson > Reviewed-by: Somnath Kotur > Reviewed-by: Ajit

Re: [dpdk-dev] [PATCH 1/2] net/bnxt: fix drop en in rxq get information

2020-09-23 Thread Ajit Khaparde
On Tue, Sep 22, 2020 at 7:04 AM Lance Richardson wrote: > > Return correct value for rx_drop_en. Add per-queue field to > track rx_drop_en configuration. > > Fixes: 2fc201884be8 ("net/bnxt: support rxq/txq get information") > Cc: sta...@dpdk.org > > Signed-off-by: Lance Richardson > Reviewed-by:

Re: [dpdk-dev] [PATCH v7] usertools: add a huge page setup script

2020-09-23 Thread Stephen Hemminger
On Wed, 9 Sep 2020 11:51:01 -0700 Stephen Hemminger wrote: > This is an improved version of the setup of huge pages > bases on earlier DPDK setup. > > Differences are: >* autodetects NUMA vs non NUMA >* allows setting different page sizes > recent kernels support multiple sizes. >

Re: [dpdk-dev] [RFC PATCH 1/2] build: rework Arm build options

2020-09-23 Thread Honnappa Nagarahalli
Thanks Juraj for the quick RFC. Few comments inline. > > The current system can identify only the implementer and part number of > the arm device we're targeting, which is enough to identify the target CPU. > However, even the full MIDR information is not enough to identify the SoC > we're targ

[dpdk-dev] [PATCH v3 3/6] net/dpaa2: fix check for key size

2020-09-23 Thread Sachin Saxena (OSS)
From: Apeksha Gupta DPAA2 has support for raw flow classification, which can be used for any protocol rules. This change fixes flow key pattern length match boundary condition with spec length. Fixes: 3f881f8d6eb0 ("net/dpaa2: support raw flow classification") Cc: sta...@dpdk.org Signed-off-by:

[dpdk-dev] [PATCH v3 5/6] net/dpaa: send error packets to application

2020-09-23 Thread Sachin Saxena (OSS)
From: Nipun Gupta Send error packets to main queue (rx) to make application enable to receive error packets. Earlier all packets with L3/L4 checksum errors were getting dropped by the hardware. Signed-off-by: Rohit Raj Signed-off-by: Nipun Gupta --- drivers/net/dpaa/dpaa_ethdev.c | 10 ---

[dpdk-dev] [PATCH v3 4/6] bus/dpaa: enables RX/TX error queues

2020-09-23 Thread Sachin Saxena (OSS)
From: Sachin Saxena Enables a debugging queue to fetch error (Rx/Tx) packets to user space. Earlier all packets with L3/L4 checksum errors were getting dropped by the hardware. Setting CONFIG_RTE_LIBRTE_DPAA_DEBUG_DRIVER=y is required which enables following enhancements. 1) Enable TX/RX error q

[dpdk-dev] [PATCH v3 6/6] bus/dpaa: enhance link status support

2020-09-23 Thread Sachin Saxena (OSS)
From: Rohit Raj This patch adds support to get/set link speed, duplex and autoneg mode status from/to PHY. Enahnce device capabilities to advertise all supported link speeds according to mac type. Also enables fallback support for get link status api where kernel support is missing. Signed-off-

[dpdk-dev] [PATCH v3 2/6] bus/fslmc: run secondary debug app without blacklist devices

2020-09-23 Thread Sachin Saxena (OSS)
From: Rohit Raj dpaa2 hw impose limits on some HW access devices like DPMCP(Management control Port) and DPIO (HW portal). This causes issue in their shared usages in case of multi-process applications. It can overcome by using whitelist/blacklist in primary and secondary applications. However it

[dpdk-dev] [PATCH v3 1/6] bus/fslmc: fix atomic queues on nxp lx2 platform

2020-09-23 Thread Sachin Saxena (OSS)
From: Youri Querry Traffic was stalling after few packet while running l2fwd-event in atomic mode on LX2 platform. It was due to wrong dca setting while enqueuing packets to EQCR. This patch fixes the issue by writing correct dca setting. Fixes: 1b49352f41be ("bus/fslmc: rename portal pi index t

[dpdk-dev] [PATCH v3 0/6] enhancement and fixes for nxp dpaax platform

2020-09-23 Thread Sachin Saxena (OSS)
From: Sachin Saxena - V2: Removed checks warnings reported by checkpatch - V3: handled review comments Apeksha Gupta (1): net/dpaa2: fix check for key size Nipun Gupta (1): net/dpaa: send error packets to application Rohit Raj (2): bus/fslmc: run secondary debug app without blacklist d

Re: [dpdk-dev] [PATCH 0/8] bnxt patches

2020-09-23 Thread Ajit Khaparde
On Tue, Sep 22, 2020 at 12:13 AM Somnath Kotur wrote: > > Fixes and enchancements in the bnxt PMD, mostly > in the TRUFLOW layer Patchset applied to dpdk-next-net-brcm. > > Kishore Padmanabha (3): > net/bnxt: add support for decap action for ipv6 VXLAN flows > net/bnxt: fix flow match to ign

Re: [dpdk-dev] [PATCH v2 0/4] use C11 atomic builtins for libs

2020-09-23 Thread Phil Yang
David Marchand writes: > Subject: Re: [PATCH v2 0/4] use C11 atomic builtins for libs > > On Wed, Sep 16, 2020 at 10:24 AM Phil Yang wrote: > > > > Since rte_atomicXX APIs are not allowed to be used[1][2], use C11 atomic > > builtins instead in eal, bbdev, power, and ethdev libs. > > > > [1] >

Re: [dpdk-dev] [PATCH v2 1/4] eal: use C11 atomic builtins for already initialized check

2020-09-23 Thread Phil Yang
David Marchand writes: > Subject: Re: [PATCH v2 1/4] eal: use C11 atomic builtins for already > initialized > check > > On Wed, Sep 16, 2020 at 10:24 AM Phil Yang wrote: > > > > Since rte_atomicXX APIs are not allowed to be used, use C11 builtins to > > check if EAL is already initialized. > >

Re: [dpdk-dev] [RFC PATCH 0/2] Arm build options rework

2020-09-23 Thread Honnappa Nagarahalli
Adding Ali > -Original Message- > From: Juraj Linkeš > Sent: Wednesday, September 23, 2020 8:19 AM > To: bruce.richard...@intel.com; Ruifeng Wang ; > Honnappa Nagarahalli ; Phil Yang > ; vcchu...@amazon.com; Dharmik Thakkar > ; jerinjac...@gmail.com; > hemant.agra...@nxp.com > Cc: dev@dpd

Re: [dpdk-dev] [PATCH 2/2] app/testpmd: retain original FDIR mode when configuring DCB

2020-09-23 Thread Wei Hu (Xavier)
Hi, Ajit Khaparde On 2020/9/23 15:14, Wei Hu (Xavier) wrote: Hi, Ajit Khaparde On 2020/9/22 13:15, Ajit Khaparde wrote: On Mon, Sep 7, 2020 at 7:16 PM Wei Hu (Xavier) wrote: From: Huisong Li Sometimes, we have to start testpmd application with --pkt-filter-mode to test flow table feature

Re: [dpdk-dev] [PATCH v6 2/3] gro: add VXLAN UDP/IPv4 GRO support

2020-09-23 Thread yang_y_yi
Jiayu, is this comment ok? diff --git a/lib/librte_gro/gro_udp4.c b/lib/librte_gro/gro_udp4.c index 061e7b0..93e368a 100644 --- a/lib/librte_gro/gro_udp4.c +++ b/lib/librte_gro/gro_udp4.c @@ -409,8 +409,10 @@ return k; } else

Re: [dpdk-dev] [PATCH v1] maintainers: update for nxp bus, dpaa, dpaa2 and enetc

2020-09-23 Thread Sachin Saxena (OSS)
On 24-Sep-20 5:29 AM, Thomas Monjalon wrote: 14/09/2020 16:06, Sachin Saxena (OSS): From: Sachin Saxena Updated email of maintainer. Signed-off-by: Sachin Saxena --- NXP buses M: Hemant Agrawal -M: Sachin Saxena +M: Sachin Saxena Tab is replaced with a space, and applied, thank

Re: [dpdk-dev] [RFC] ethdev: make rte flow API thread safe

2020-09-23 Thread Suanming Mou
Hi, > -Original Message- > From: Suanming Mou > Sent: Wednesday, September 9, 2020 10:26 AM > To: Stephen Hemminger ; NBU-Contact- > Thomas Monjalon > Cc: Ori Kam ; Matan Azrad ; > Shahaf Shuler ; Viacheslav Ovsiienko > ; Ferruh Yigit ; Andrew > Rybchenko ; dev@dpdk.org; > joyce.k...@arm.

Re: [dpdk-dev] [PATCH v1] maintainers: update for nxp bus, dpaa, dpaa2 and enetc

2020-09-23 Thread Thomas Monjalon
14/09/2020 16:06, Sachin Saxena (OSS): > From: Sachin Saxena > > Updated email of maintainer. > > Signed-off-by: Sachin Saxena > --- > NXP buses > M: Hemant Agrawal > -M: Sachin Saxena > +M: Sachin Saxena Tab is replaced with a space, and applied, thanks. Sachin, please could you help

Re: [dpdk-dev] [PATCH v3 1/3] eal: add API for bus close

2020-09-23 Thread Thomas Monjalon
> > Signed-off-by: Rohit Raj > Acked-by: Hemant Agrawal Please could you look urgently to the close of a port? All NXP drivers are late to migrate to the new behaviour: http://inbox.dpdk.org/dev/20200913220711.3768597-17-tho...@monjalon.net/ http://inbox.dpdk.org/dev/80837131.n3tlCtGQ32@thomas/

Re: [dpdk-dev] [PATCH] maintainers: update maintainers for event ethdev rx/tx adapters

2020-09-23 Thread Thomas Monjalon
> Jay is the new maintainer since Nikhil no longer works on DPDK. > > Signed-off-by: Nikhil Rao [...] > Eventdev Ethdev Rx Adapter API > -M: Nikhil Rao > +M: Jay Jayatheerthan > T: git://dpdk.org/next/dpdk-next-eventdev > F: lib/librte_eventdev/*eth_rx_adapter* > F: app/test/test_event_eth_

Re: [dpdk-dev] [PATCH] maintainers: update Mellanox maintainers mail

2020-09-23 Thread Thomas Monjalon
12/08/2020 20:59, Matan Azrad: > > From: Ori Kam: > > This patch updates Mellanox maintainers mails from the Mellanox domain to > > Nvidia domain. > > > > Signed-off-by: Ori Kam > Acked-by: Matan Azrad > > Looks Like we need here also > Cc: sta...@dpdk.org Applied, thanks

Re: [dpdk-dev] [PATCH v1] maintainers: remove documentation maintainers

2020-09-23 Thread Thomas Monjalon
> Removed the documentation maintainers. The documentation > is now, currently, unmaintained. > > Signed-off-by: John McNamara > Signed-off-by: Marko Kovacevic Applied, thanks for the work you did so far. As Jim said today in the virtual event, we are looking for a new breath in documentation.

Re: [dpdk-dev] [PATCH] net/iavf: fix link status

2020-09-23 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of murphy yang > Sent: Friday, September 18, 2020 5:47 PM > To: dev@dpdk.org > Cc: Yang, MurphyX ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/iavf: fix link status > > From: murphy > > If the PF driver supports the new speed reporting

Re: [dpdk-dev] [PATCH v1] event/sw: performance improvements

2020-09-23 Thread Honnappa Nagarahalli
> > > > Add minimum burst throughout the scheduler pipeline and a flush counter. > > Replace ring API calls with local single threaded implementation where > > possible. > > > > Signed-off-by: Radu Nicolau > > Thanks for the patch, a few comments inline. > > > --- > > drivers/event/sw/sw_evde

Re: [dpdk-dev] [v2 1/2] cryptodev: support enqueue callback functions

2020-09-23 Thread Honnappa Nagarahalli
> > > > > > > > > > > > > > > > +#ifdef RTE_CRYPTODEV_CALLBACKS int > > > > > > > > +rte_cryptodev_rcu_qsbr_add(uint8_t dev_id, struct > > > > > > > > +rte_rcu_qsbr > > > > > > > > +*qsbr) { > > > > > > > > + > > > > > > > > + struct rte_cryptodev *dev; > > > > > > > > + > > > > > > > > +

Re: [dpdk-dev] [PATCH 02/20] ethdev: allow drivers to return error on close

2020-09-23 Thread Thomas Monjalon
24/09/2020 00:02, Stephen Hemminger: > On Wed, 23 Sep 2020 23:52:07 +0200 > Thomas Monjalon wrote: > > > > > > > Yes it is a step in the right direction. > > > > > > Changing the API means adding some error checks in every apps. > > > > > > The reason for not doing is that I did not commit for th

Re: [dpdk-dev] [PATCH 02/20] ethdev: allow drivers to return error on close

2020-09-23 Thread Stephen Hemminger
On Wed, 23 Sep 2020 23:52:07 +0200 Thomas Monjalon wrote: > > > > > Yes it is a step in the right direction. > > > > > Changing the API means adding some error checks in every apps. > > > > > The reason for not doing is that I did not commit for this task, > > > > > and I am not the author of the

Re: [dpdk-dev] [PATCH 02/20] ethdev: allow drivers to return error on close

2020-09-23 Thread Thomas Monjalon
23/09/2020 23:47, Stephen Hemminger: > On Wed, 23 Sep 2020 23:06:42 +0200 > Thomas Monjalon wrote: > > > 23/09/2020 23:02, Stephen Hemminger: > > > On Wed, 23 Sep 2020 22:53:46 +0200 > > > Thomas Monjalon wrote: > > > > 23/09/2020 18:41, Ferruh Yigit: > > > > > On 9/13/2020 11:06 PM, Thomas

Re: [dpdk-dev] [PATCH 02/20] ethdev: allow drivers to return error on close

2020-09-23 Thread Stephen Hemminger
On Wed, 23 Sep 2020 23:06:42 +0200 Thomas Monjalon wrote: > 23/09/2020 23:02, Stephen Hemminger: > > On Wed, 23 Sep 2020 22:53:46 +0200 > > Thomas Monjalon wrote: > > > 23/09/2020 18:41, Ferruh Yigit: > > > > On 9/13/2020 11:06 PM, Thomas Monjalon wrote: > > > > > The device operation .d

Re: [dpdk-dev] [PATCH 07/20] net/failsafe: release port upon close

2020-09-23 Thread Thomas Monjalon
> +int > +failsafe_eth_dev_close(struct rte_eth_dev *dev) > +{ > + struct sub_device *sdev; > + uint8_t i; > + int ret; > + > + fs_lock(dev, 0); > + failsafe_hotplug_alarm_cancel(dev); > + if (PRIV(dev)->state == DEV_STARTED) > + dev->dev_ops->dev_s

Re: [dpdk-dev] [PATCH 02/20] ethdev: allow drivers to return error on close

2020-09-23 Thread Thomas Monjalon
23/09/2020 23:02, Stephen Hemminger: > On Wed, 23 Sep 2020 22:53:46 +0200 > Thomas Monjalon wrote: > > 23/09/2020 18:41, Ferruh Yigit: > > > On 9/13/2020 11:06 PM, Thomas Monjalon wrote: > > > > The device operation .dev_close was returning void. > > > > This driver interface is changed to retur

Re: [dpdk-dev] [PATCH 02/20] ethdev: allow drivers to return error on close

2020-09-23 Thread Stephen Hemminger
On Wed, 23 Sep 2020 22:53:46 +0200 Thomas Monjalon wrote: > 23/09/2020 18:41, Ferruh Yigit: > > On 9/13/2020 11:06 PM, Thomas Monjalon wrote: > > > The device operation .dev_close was returning void. > > > This driver interface is changed to return an int. > > > > > > Note that the API rte_eth

Re: [dpdk-dev] [PATCH 02/20] ethdev: allow drivers to return error on close

2020-09-23 Thread Thomas Monjalon
23/09/2020 18:41, Ferruh Yigit: > On 9/13/2020 11:06 PM, Thomas Monjalon wrote: > > The device operation .dev_close was returning void. > > This driver interface is changed to return an int. > > > > Note that the API rte_eth_dev_close() is still returning void, > > although a deprecation notice is

Re: [dpdk-dev] [PATCH 04/20] net/atlantic: release port upon close

2020-09-23 Thread Thomas Monjalon
23/09/2020 18:42, Ferruh Yigit: > On 9/13/2020 11:06 PM, Thomas Monjalon wrote: > > The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources > > can be freed by rte_eth_dev_close(). > > > > Freeing of private port resources is moved > > from the ".remove(device)" to the ".dev_close(port)" op

Re: [dpdk-dev] [PATCH 10/20] net/null: release port upon close

2020-09-23 Thread Thomas Monjalon
23/09/2020 18:44, Ferruh Yigit: > On 9/13/2020 11:07 PM, Thomas Monjalon wrote: > > The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources > > can be freed by rte_eth_dev_close(). > > > > Signed-off-by: Thomas Monjalon > > --- > > --- a/drivers/net/null/rte_eth_null.c > > +++ b/drivers/ne

Re: [dpdk-dev] [PATCH 12/20] net/pcap: release port upon close

2020-09-23 Thread Thomas Monjalon
23/09/2020 18:44, Ferruh Yigit: > On 9/13/2020 11:07 PM, Thomas Monjalon wrote: > > The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources > > can be freed by rte_eth_dev_close(). > > > > Freeing of private port resources is moved > > from the ".remove(device)" to the ".dev_close(port)" op

Re: [dpdk-dev] [PATCH 16/20] ethdev: remove old close behaviour

2020-09-23 Thread Thomas Monjalon
23/09/2020 18:44, Ferruh Yigit: > On 9/13/2020 11:07 PM, Thomas Monjalon wrote: > > * Note 3: > > The port is supposed to be in a stopped state when it is closed. > > If it is not the case, it is free to the PMD implementation > > how to react when trying to close a non-stopped port: > > either try

Re: [dpdk-dev] [PATCH 19/20] app/testpmd: reset port status on close notification

2020-09-23 Thread Thomas Monjalon
23/09/2020 18:45, Ferruh Yigit: > On 9/13/2020 11:07 PM, Thomas Monjalon wrote: > > Since rte_eth_dev_release_port() is called on all port close operations, > > the event RTE_ETH_EVENT_DESTROY can be reliably used for resetting > > the port status on the application side. > > > > The intermediate

Re: [dpdk-dev] [PATCH v5 01/41] pipeline: add new SWX pipeline type

2020-09-23 Thread Stephen Hemminger
On Wed, 23 Sep 2020 18:37:19 + "Dumitrescu, Cristian" wrote: > Hi Stephen, > > > -Original Message- > > From: Stephen Hemminger > > Sent: Wednesday, September 23, 2020 7:25 PM > > To: Dumitrescu, Cristian > > Cc: dev@dpdk.org; tho...@monjalon.net; david.march...@redhat.com > > Subj

Re: [dpdk-dev] [PATCH v4 00/41] Pipeline alignment with the P4 language

2020-09-23 Thread Dumitrescu, Cristian
> -Original Message- > From: Dumitrescu, Cristian > Sent: Wednesday, September 23, 2020 5:49 PM > To: 'Thomas Monjalon' ; David Marchand > > Cc: dev > Subject: RE: [dpdk-dev] [PATCH v4 00/41] Pipeline alignment with the P4 > language > > > > > -Original Message- > > From: Th

Re: [dpdk-dev] [PATCH v5 01/41] pipeline: add new SWX pipeline type

2020-09-23 Thread Dumitrescu, Cristian
Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: Wednesday, September 23, 2020 7:25 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; tho...@monjalon.net; david.march...@redhat.com > Subject: Re: [dpdk-dev] [PATCH v5 01/41] pipeline: add new SWX pipeline > type > > On

Re: [dpdk-dev] [PATCH v5 36/41] examples/pipeline: add new example application

2020-09-23 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, September 23, 2020 7:26 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; tho...@monjalon.net; david.march...@redhat.com > Subject: Re: [dpdk-dev] [PATCH v5 36/41] examples/pipeline: add new > example application > > On

Re: [dpdk-dev] [PATCH v5 36/41] examples/pipeline: add new example application

2020-09-23 Thread Stephen Hemminger
On Wed, 23 Sep 2020 19:06:40 +0100 Cristian Dumitrescu wrote: > create mode 100644 examples/pipeline/Makefile Make is no longer supported, examples need to only use meson.

Re: [dpdk-dev] [PATCH v5 01/41] pipeline: add new SWX pipeline type

2020-09-23 Thread Stephen Hemminger
On Wed, 23 Sep 2020 19:06:05 +0100 Cristian Dumitrescu wrote: > +/* > + * Pipeline. > + */ > +struct rte_swx_pipeline { > + int build_done; > + int numa_node; > +}; > + Nit, could build_done be a bool type? +void +rte_swx_pipeline_free(struct rte_swx_pipeline *p) +{ + if (!p) +

[dpdk-dev] Questions on DPDK pkg-config

2020-09-23 Thread Harris, James R
Hi, SPDK would like to use DPDK’s pkg-config files rather than rolling our own linker arguments. I’m running into a couple of issues – one looks like a bug, the other is not as clear. First is the use of --as-needed (https://github.com/DPDK/dpdk/commit/b98447077b0609750c10b84b7b2e7be0c8504fad

[dpdk-dev] [PATCH v5 41/41] examples/pipeline: add VXLAN encapsulation example

2020-09-23 Thread Cristian Dumitrescu
Add VXLAN encapsulation example to the SWX pipeline application. The VXLAN tunnels can be generated with the vxlan_table.py script. Example command line: ./build/pipeline -l0-1 -- -s ./examples/vxlan.cli Signed-off-by: Cristian Dumitrescu --- examples/pipeline/examples/vxlan.cli | 27

[dpdk-dev] [PATCH v5 38/41] examples/pipeline: add configuration commands

2020-09-23 Thread Cristian Dumitrescu
Add CLI commands for application configuration and query. Signed-off-by: Cristian Dumitrescu --- examples/pipeline/Makefile|1 + examples/pipeline/cli.c | 1400 + examples/pipeline/cli.h | 19 + examples/pipeline/main.c | 10 +- exampl

[dpdk-dev] [PATCH v5 39/41] examples/pipeline: add l2fwd example

2020-09-23 Thread Cristian Dumitrescu
Add L2 Forwarding example to the SWX pipeline application. Example command line: ./build/pipeline -l0-1 -- -s ./examples/l2fwd.cli Signed-off-by: Cristian Dumitrescu --- examples/pipeline/examples/l2fwd.cli | 25 ++ examples/pipeline/examples/l2fwd.spec | 42 + examples/pi

[dpdk-dev] [PATCH v5 37/41] examples/pipeline: add message passing mechanism

2020-09-23 Thread Cristian Dumitrescu
Add network-based connectivity mechanism for the application to allow for the exchange of configuration messages through the network as opposed to local CLI only. Signed-off-by: Cristian Dumitrescu --- examples/pipeline/Makefile| 1 + examples/pipeline/conn.c | 331 +++

[dpdk-dev] [PATCH v5 36/41] examples/pipeline: add new example application

2020-09-23 Thread Cristian Dumitrescu
Add new example application to showcase the API of the newly introduced SWX pipeline type. Signed-off-by: Cristian Dumitrescu --- MAINTAINERS | 1 + examples/meson.build | 1 + examples/pipeline/Makefile| 51 examples/pipeline/main.c | 50 exam

[dpdk-dev] [PATCH v5 40/41] examples/pipeline: add l2fwd with MAC swap example

2020-09-23 Thread Cristian Dumitrescu
Add L2 Forwarding example with MAC destination and source address swap to the SWX pipeline application. Example command line: ./build/pipeline -l0-1 -- -s ./examples/l2fwd_macswp.cli Signed-off-by: Cristian Dumitrescu --- examples/pipeline/examples/l2fwd_macswp.cli | 25 examples/pipe

[dpdk-dev] [PATCH v5 33/41] port: add ethernet device SWX port

2020-09-23 Thread Cristian Dumitrescu
Add the Ethernet device input/output port type for the SWX pipeline. Used under the hood by the pipeline rx and tx instructions. Signed-off-by: Cristian Dumitrescu --- lib/librte_port/meson.build | 6 +- lib/librte_port/rte_port_version.map | 3 +- lib/librte_port/rte_swx_port_eth

[dpdk-dev] [PATCH v5 31/41] pipeline: add SWX table update high level API

2020-09-23 Thread Cristian Dumitrescu
High-level transaction-oriented API for SWX pipeline table updates. It supports multi-table atomic updates, i.e. multiple tables can be updated in a single step with only the before and after table set visible to the packets. Uses the lower-level table update mechanisms. Signed-off-by: Cristian Du

[dpdk-dev] [PATCH v5 32/41] pipeline: add SWX pipeline specification file

2020-09-23 Thread Cristian Dumitrescu
Add support for building the SWX pipeline based on specification file with syntax aligned to the P4 language. The specification file may be generated by the P4C compiler in the future. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/meson.build |1 + lib/librte_pipeli

[dpdk-dev] [PATCH v5 35/41] table: add exact match SWX table

2020-09-23 Thread Cristian Dumitrescu
Add the exact match table type for the SWX pipeline. Used under the hood by the SWX pipeline table instruction. Signed-off-by: Cristian Dumitrescu --- lib/librte_table/meson.build | 6 +- lib/librte_table/rte_swx_table_em.c| 851 + lib/librte_table/rte_swx

[dpdk-dev] [PATCH v5 29/41] pipeline: add SWX pipeline query API

2020-09-23 Thread Cristian Dumitrescu
Query API to be used by the control plane to detect the configuration and state of the SWX pipeline and its internal objects. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_pipeline_version.map | 10 + lib/librte_pipeline/rte_swx_ctl.h| 313 +++ lib/l

[dpdk-dev] [PATCH v5 34/41] port: add source and sink SWX ports

2020-09-23 Thread Cristian Dumitrescu
Add the PCAP file-based source (input) and sink (output) port types for the SWX pipeline. The sink port is typically used to implement the packet drop pipeline action. Used under the hood by the pipeline rx and tx instructions. Signed-off-by: Cristian Dumitrescu --- lib/librte_port/meson.build

[dpdk-dev] [PATCH v5 30/41] pipeline: add SWX pipeline flush

2020-09-23 Thread Cristian Dumitrescu
Flush the packets currently buffered by the SWX pipeline output ports. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_pipeline_version.map | 1 + lib/librte_pipeline/rte_swx_pipeline.c | 13 + lib/librte_pipeline/rte_swx_pipeline.h | 12 3 fi

[dpdk-dev] [PATCH v5 27/41] pipeline: add SWX instruction verifier

2020-09-23 Thread Cristian Dumitrescu
Instruction verifier. Executes at instruction translation time during SWX pipeline build, i.e. at initialization instead of run-time. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_swx_pipeline.c | 51 ++ 1 file changed, 51 insertions(+) diff --git a/lib/

[dpdk-dev] [PATCH v5 22/41] pipeline: introduce SWX SHR instruction

2020-09-23 Thread Cristian Dumitrescu
The shr (i.e. shift right) instruction source can be header field (H), meta-data field (M), extern object (E) or function (F) mailbox field, table entry action data field (T) or immediate value (I). The destination is HMEF. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_swx_pipel

[dpdk-dev] [PATCH v5 28/41] pipeline: add SWX instruction optimizer

2020-09-23 Thread Cristian Dumitrescu
Instruction optimizer. Detects frequent patterns and replaces them with some more powerful vector-like pipeline instructions without any user effort. Executes at instruction translation, not at run-time. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_swx_pipeline.c | 226

[dpdk-dev] [PATCH v5 25/41] pipeline: introduce SWX jump and return instructions

2020-09-23 Thread Cristian Dumitrescu
The jump instructions are either unconditional (jmp) or conditional on positive/negative tests such as header validity (jmpv/jmpnv), table lookup hit/miss (jmph/jmpnh), executed action (jmpa/jmpna), equality (jmpeq/jmpneq), comparison result (jmplt/jmpgt). The return instruction resumes the pipelin

[dpdk-dev] [PATCH v5 26/41] pipeline: add SWX instruction description

2020-09-23 Thread Cristian Dumitrescu
Added SWX instruction set reference table. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_swx_pipeline.h | 109 + 1 file changed, 109 insertions(+) diff --git a/lib/librte_pipeline/rte_swx_pipeline.h b/lib/librte_pipeline/rte_swx_pipeline.h index fb83a88

[dpdk-dev] [PATCH v5 24/41] pipeline: introduce SWX extern instruction

2020-09-23 Thread Cristian Dumitrescu
The extern instruction calls one of the member functions of a given extern object or it calls the given extern function. The function arguments must be written in advance to the mailbox. The results are available in the same place after execution. Signed-off-by: Cristian Dumitrescu --- lib/librt

[dpdk-dev] [PATCH v5 23/41] pipeline: introduce SWX table instruction

2020-09-23 Thread Cristian Dumitrescu
The table instruction looks up the input key into the table and then it triggers the execution of the action found in the table entry. On lookup miss, the default table action is executed. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_swx_pipeline.c | 100 +++

[dpdk-dev] [PATCH v5 20/41] pipeline: introduce SWX XOR instruction

2020-09-23 Thread Cristian Dumitrescu
The xor (i.e. bitwise exclusive or) instruction source can be header field (H), meta-data field (M), extern object (E) or function (F) mailbox field, table entry action data field (T) or immediate value (I). The destination is HMEF. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_

[dpdk-dev] [PATCH v5 21/41] pipeline: introduce SWX SHL instruction

2020-09-23 Thread Cristian Dumitrescu
The shl (i.e. shift left) instruction source can be header field (H), meta-data field (M), extern object (E) or function (F) mailbox field, table entry action data field (T) or immediate value (I). The destination is HMEF. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_swx_pipeli

[dpdk-dev] [PATCH v5 19/41] pipeline: introduce SWX or instruction

2020-09-23 Thread Cristian Dumitrescu
The or (i.e. bitwise or) instruction source can be header field (H), meta-data field (M), extern object (E) or function (F) mailbox field, table entry action data field (T) or immediate value (I). The destination is HMEF. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_swx_pipelin

[dpdk-dev] [PATCH v5 17/41] pipeline: introduce SWX cksub instruction

2020-09-23 Thread Cristian Dumitrescu
The cksub (i.e. checksum subtract) instruction is used to update the 1's complement sum commonly used by protocols such as IPv4, TCP or UDP. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_swx_pipeline.c | 116 + 1 file changed, 116 insertions(+) diff --gi

[dpdk-dev] [PATCH v5 18/41] pipeline: introduce SWX and instruction

2020-09-23 Thread Cristian Dumitrescu
The and (i.e. bitwise and) instruction source can be header field (H), meta-data field (M), extern object (E) or function (F) mailbox field, table entry action data field (T) or immediate value (I). The destination is HMEF. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_swx_pipel

[dpdk-dev] [PATCH v5 16/41] pipeline: introduce SWX ckadd instruction

2020-09-23 Thread Cristian Dumitrescu
The ckadd (i.e. checksum add) instruction is used to either compute, verify or update the 1's complement sum commonly used by protocols such as IPv4, TCP or UDP. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_swx_pipeline.c | 230 + 1 file changed, 230 ins

[dpdk-dev] [PATCH v5 15/41] pipeline: introduce SWX subtract instruction

2020-09-23 Thread Cristian Dumitrescu
The sub (i.e. subtract) instruction source can be header field (H), meta-data field (M), extern object (E) or function (F) mailbox field, table entry action data field (T) or immediate value (I). The destination is HMEF. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_swx_pipeline

[dpdk-dev] [PATCH v5 14/41] pipeline: introduce SWX add instruction

2020-09-23 Thread Cristian Dumitrescu
The add instruction source can be header field (H), meta-data field (M), extern object (E) or function (F) mailbox field, table entry action data field (T) or immediate value (I). The destination is HMEF. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_swx_pipeline.c | 302 +++

[dpdk-dev] [PATCH v5 13/41] pipeline: add SWX DMA instruction

2020-09-23 Thread Cristian Dumitrescu
The DMA instruction handles the bulk read transfer of one header from the table entry action data. Typically used to generate headers, i.e. headers that are not extracted from the input packet. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_swx_pipeline.c | 207 ++

  1   2   3   >