Re: [dpdk-dev] [PATCH v3 6/6] doc: update for two ports hairpin mode

2020-10-12 Thread Bing Zhao
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, October 13, 2020 2:37 PM > To: Bing Zhao > Cc: Ori Kam ; ferruh.yi...@intel.com; > arybche...@solarflare.com; m...@ashroe.eu; nhor...@tuxdriver.com; > bernard.iremon...@intel.com; beilei.x...@intel.com; > wenzhuo...

Re: [dpdk-dev] [PATCH v3 6/6] doc: update for two ports hairpin mode

2020-10-12 Thread Thomas Monjalon
13/10/2020 03:13, Bing Zhao: > From: Thomas Monjalon > > 08/10/2020 14:05, Bing Zhao: > > > In the release notes, 2 ports hairpin mode feature is added. > > > > > > In rte flow part, one suggestion is added to mention that metadata > > > could be used to connect the hairpin RX and TX flows if the

[dpdk-dev] [PATCH v2] net/ice: refactor RSS config for potential bugs

2020-10-12 Thread Junfeng Guo
Current implementation for PF RSS config wrap function has some potential bugs about GTPU, e.g., same input set for GTPU inner and non-TUN have different hash values, which should be same. Thus, we use extra pre and post processing to re-config GTPU rules. Signed-off-by: Junfeng Guo --- drivers/

Re: [dpdk-dev] [PATCH 8/8] net/iavf: support check DD bit of a RX descriptor

2020-10-12 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Ferruh Yigit > Sent: Monday, October 12, 2020 4:33 PM > To: Zhang, RobinX ; dev@dpdk.org > Cc: Xing, Beilei ; Wu, Jingjing > ; > Yang, Qiming ; Yang, SteveX > > Subject: Re: [dpdk-dev] [PATCH 8/8] net/iavf: support check DD bit of a RX > de

Re: [dpdk-dev] [PATCH v6] eal: add cache-line demote support

2020-10-12 Thread Ruifeng Wang
> -Original Message- > From: Omkar Maslekar > Sent: Monday, October 12, 2020 6:20 PM > To: dev@dpdk.org > Cc: bruce.richard...@intel.com; ciara.lof...@intel.com; > omkar.masle...@intel.com; d...@linux.vnet.ibm.com; jer...@marvell.com; > Ruifeng Wang ; Honnappa Nagarahalli > > Subject: [

[dpdk-dev] [PATCH v4] ethdev: check if queue setup in queue-related APIs

2020-10-12 Thread Wei Hu (Xavier)
From: Chengchang Tang This patch adds checking whether the related Tx or Rx queue has been setup in the queue-related API functions to avoid illegal address access. And validity check of the queue_id is also added in the API functions rte_eth_dev_rx_intr_enable and rte_eth_dev_rx_intr_disable. S

Re: [dpdk-dev] [PATCH v3 04/18] net/i40e: add checks for max SIMD bitwidth

2020-10-12 Thread Guo, Jia
> -Original Message- > From: Bruce Richardson > Sent: Monday, October 12, 2020 5:38 PM > To: Guo, Jia > Cc: Power, Ciara ; dev@dpdk.org; Xing, Beilei > > Subject: Re: [dpdk-dev] [PATCH v3 04/18] net/i40e: add checks for max SIMD > bitwidth > > On Sat, Oct 10, 2020 at 02:07:15AM +,

Re: [dpdk-dev] [PATCH v2] security: update session create API

2020-10-12 Thread Lukasz Wojciechowski
Hi Akhil, comments inline W dniu 11.10.2020 o 00:11, Akhil Goyal pisze: > The API ``rte_security_session_create`` takes only single > mempool for session and session private data. So the > application need to create mempool for twice the number of > sessions needed and will also lead to wastage o

[dpdk-dev] [PATCH v4 4/4] vhost: fix async unregister deadlock

2020-10-12 Thread Patrick Fu
When async unregister function is invoked in certain vhost event callbacks (e.g. vring state change), deadlock may occur due to recursive spinlock acquire. This patch uses trylock() primitive in the unregister API to avoid deadlock. Fixes: 78639d54563a ("vhost: introduce async enqueue registration

[dpdk-dev] [PATCH v4 3/4] vhost: fix async vector buffer overrun

2020-10-12 Thread Patrick Fu
Add check on the async vector buffer usage to prevent the buf overrun. If the unused vector buffer is not sufficient to prepare for next packet's iov creation, an async transfer will be triggered immediately to free the vector buffer. Fixes: 78639d54563a ("vhost: introduce async enqueue registrati

[dpdk-dev] [PATCH v4 1/4] vhost: simplify async copy completion

2020-10-12 Thread Patrick Fu
Current async ops allows check_completed_copies() callback to return arbitrary number of async iov segments finished from backend async devices. This design creates complexity for vhost to handle breaking transfer of a single packet (i.e. transfer completes in the middle of a async descriptor) and

[dpdk-dev] [PATCH v4 2/4] vhost: dynamically allocate async memory

2020-10-12 Thread Patrick Fu
Allocate async internal memory buffer by rte_malloc(), replacing array declaration inside vq structure. Dynamic allocation can help to save memory footprint when async path is not registered. Signed-off-by: Patrick Fu --- lib/librte_vhost/vhost.c | 69 ++-- li

[dpdk-dev] [PATCH v4 0/4] optimize async data path

2020-10-12 Thread Patrick Fu
This series applies optimization and fixes to the vhost async data path. v4: - fix transfer error handling in async submit function (patch 1/4) - add spinlock in async register function (patch 4/4) - no changes in patch 2/4 & 3/4 v3: - fix a typo in vhost error log (checkpatch warning) - fix

Re: [dpdk-dev] [PATCH v5 06/10] net/ixgbe: implement power management API

2020-10-12 Thread Wang, Haiyue
> -Original Message- > From: Burakov, Anatoly > Sent: Monday, October 12, 2020 17:29 > To: Wang, Haiyue ; dev@dpdk.org > Cc: Ma, Liang J ; Guo, Jia ; Hunt, > David > ; Ananyev, Konstantin ; > jerinjac...@gmail.com; > Richardson, Bruce ; tho...@monjalon.net; > McDaniel, Timothy > ; Eads,

Re: [dpdk-dev] [PATCH v3 6/6] doc: update for two ports hairpin mode

2020-10-12 Thread Bing Zhao
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, October 13, 2020 5:31 AM > To: Bing Zhao > Cc: Ori Kam ; ferruh.yi...@intel.com; > arybche...@solarflare.com; m...@ashroe.eu; nhor...@tuxdriver.com; > bernard.iremon...@intel.com; beilei.x...@intel.com; > wenzhuo...

Re: [dpdk-dev] [PATCH v3 11/18] net/ixgbe: add checks for max SIMD bitwidth

2020-10-12 Thread Wang, Haiyue
> -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, October 13, 2020 00:25 > To: Wang, Haiyue ; Power, Ciara > ; dev@dpdk.org > Cc: Zhao1, Wei ; Guo, Jia > Subject: RE: [PATCH v3 11/18] net/ixgbe: add checks for max SIMD bitwidth > > > > > -Original Message- > > >

Re: [dpdk-dev] [PATCH v9 0/8] Enable dynamic config of subport bandwidth

2020-10-12 Thread Dharmappa, Savinay
09/10/2020 14:39, Savinay Dharmappa: > DPDK sched library allows runtime configuration of the pipe profiles > to the pipes of the subport once scheduler hierarchy is constructed. > However, to change the subport level bandwidth, existing hierarchy > needs to be dismantled and whole process of bui

[dpdk-dev] [PATCH] net/bnx2x: fix to add QLogic vendor id

2020-10-12 Thread Rasesh Mody
Add QLogic vendor id support for BCM57840 device ids. Fixes: 9fb557035d90 ("bnx2x: enable PMD build") Cc: sta...@dpdk.org Reported-by: Souvik Dey Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x_ethdev.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/bnx2x/bnx2x_ethd

Re: [dpdk-dev] [RFC v2 1/1] lib/ring: add scatter gather APIs

2020-10-12 Thread Honnappa Nagarahalli
Hi Konstantin, Appreciate your feedback. > > > > Add scatter gather APIs to avoid intermediate memcpy. Use cases that > > involve copying large amount of data to/from the ring can benefit from > > these APIs. > > > > Signed-off-by: Honnappa Nagarahalli > > --- > > lib/librte_ring/mes

[dpdk-dev] [PATCH v3] pci/linux: copy new id for inserted device

2020-10-12 Thread Jim Harris
When a device is inserted into an existing BDF slot that has not been probed, we must overwrite the old PCI ID with the ID of the new function. Otherwise we may not probe the function with the correct driver, if at all. Signed-off-by: Jim Harris --- drivers/bus/pci/linux/pci.c | 4 +++- 1 file c

Re: [dpdk-dev] [PATCH v2] pci/linux: copy new id for inserted device

2020-10-12 Thread Thomas Monjalon
12/10/2020 22:58, Harris, James R: > > On 10/7/20, 8:06 AM, "Thomas Monjalon" wrote: > > Hi Jim, > > Sorry I see nobody reviewed your patch. > > Jim Harris wrote: > > + memcpy(&dev2->id, &dev->id, sizeof(dev2->id)); > [...] > > + memcmp(&dev2->id, &dev->id, sizeof(dev

Re: [dpdk-dev] [RFC 1/2] ethdev: move queue stats to xstats

2020-10-12 Thread Thomas Monjalon
12/10/2020 18:46, Ferruh Yigit: > Queue stats are stored in 'struct rte_eth_stats' as array and array size > is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag. > > As a result of technical board discussion, decided to remove the queue > statistics from 'struct rte_eth_stats' in the lon

Re: [dpdk-dev] [PATCH v3 2/6] ethdev: add new attributes to hairpin config

2020-10-12 Thread Thomas Monjalon
08/10/2020 14:05, Bing Zhao: > struct rte_eth_hairpin_conf { > - uint16_t peer_count; /**< The number of peers. */ > + uint32_t peer_count:16; /**< The number of peers. */ Why not keeping uint16_t? > + uint32_t tx_explicit:1; /**< Explicit TX flow rule mode. */ > + uint32_t manua

Re: [dpdk-dev] [PATCH v3 6/6] doc: update for two ports hairpin mode

2020-10-12 Thread Thomas Monjalon
08/10/2020 14:05, Bing Zhao: > In the release notes, 2 ports hairpin mode feature is added. > > In rte flow part, one suggestion is added to mention that metadata > could be used to connect the hairpin RX and TX flows if the hairpin > is working in explicit TX flow rule mode. > > In the testpmd c

Re: [dpdk-dev] [PATCH V2] maintainers: update for bonding

2020-10-12 Thread Thomas Monjalon
09/10/2020 15:38, Ferruh Yigit: > On 10/9/2020 2:37 PM, Min Hu (Connor) wrote: > > Adding Connor as additional maintainer to bonding. > > > > Signed-off-by: Min Hu (Connor) > > Reviewed-by: Wei Hu (Xavier) > > Acked-by: Ferruh Yigit Applied, thanks

Re: [dpdk-dev] [PATCH v2 2/2] net/virtio: check return from rte_raw_cksum_mbuf

2020-10-12 Thread Thomas Monjalon
09/10/2020 09:14, Maxime Coquelin: > > On 10/1/20 12:22 PM, Chas Williams wrote: > > rte_raw_cksum_mbuf can fail, so we should check to see if it > > has. If so, return with an error. > > > > Fixes: 96cb6711939e ("net/virtio: support Rx checksum offload") > > > > Signed-off-by: Chas Williams <3c

Re: [dpdk-dev] [PATCH v2] pci/linux: copy new id for inserted device

2020-10-12 Thread Harris, James R
On 10/7/20, 8:06 AM, "Thomas Monjalon" wrote: Hi Jim, Sorry I see nobody reviewed your patch. Jim Harris wrote: > + memcpy(&dev2->id, &dev->id, sizeof(dev2->id)); [...] > + memcmp(&dev2->id, &dev->id, sizeof(dev2->id))) Why using memcpy and memcmp instead of sim

Re: [dpdk-dev] [PATCH v1] doc: fix dpaa2 guide

2020-10-12 Thread Thomas Monjalon
08/10/2020 05:13, Sachin Saxena (OSS): > From: Sachin Saxena > > The diagram to show dpaa2 drivers brief > was missing in dpaa2.html file. > > fix a typo in encoding for a literal block > to make it visible in generated doc file. > > Fixes: 846a8305f277 ("add DPAA2 NIC details") > Cc: sta...@dp

Re: [dpdk-dev] [PATCH v5 02/11] ethdev: add IPv6 fragment extension header item

2020-10-12 Thread Thomas Monjalon
12/10/2020 12:43, Dekel Peled: > --- a/lib/librte_ip_frag/rte_ip_frag.h > +++ b/lib/librte_ip_frag/rte_ip_frag.h > +/* struct ipv6_extension_fragment moved to librte_net/rte_ip.h and renamed. > */ > +#define ipv6_extension_fragment rte_ipv6_fragment_ext This struct name did not have rte_ pre

Re: [dpdk-dev] [PATCH v5 01/11] ethdev: add extensions attributes to IPv6 item

2020-10-12 Thread Thomas Monjalon
12/10/2020 12:43, Dekel Peled: > - * Note: IPv6 options are handled by dedicated pattern items, see > - * RTE_FLOW_ITEM_TYPE_IPV6_EXT. > + * Dedicated flags indicate existence of specific extension headers. > + * Every type of extension header can use a dedicated pattern item, or > + * the generic

Re: [dpdk-dev] [PATCH v3 1/9] ethdev: introduce Rx buffer split

2020-10-12 Thread Slava Ovsiienko
Hi, Andrew You are right - the code duplication of rte_eth_rx_queue_setup() code was large and it did not look well indeed. I've updated the code, now rte_eth_rx_queue_setup() and rte_eth_rxseg_queue_setup() share the underlying internal routine __rte_eth_rx_queue_setup(). Of course, there is s

[dpdk-dev] [PATCH v4 8/9] net/mlx5: register multiple pool for Rx queue

2020-10-12 Thread Viacheslav Ovsiienko
The split feature for receiving packets was added to the mlx5 PMD, now Rx queue can receive the data to the buffers belonging to the different pools and the memory of all the involved pool must be registered for DMA operations in order to allow hardware to store the data. Signed-off-by: Viacheslav

[dpdk-dev] [PATCH v4 7/9] net/mlx5: configure Rx queue to support split

2020-10-12 Thread Viacheslav Ovsiienko
The scatter-gather elements should be configured accordingly to support the buffer split feature. The application provides the desired settings for the segments at the beginning of the packets and PMD pads the buffer chain (if needed) with attributes of last specified segment to accommodate the pac

[dpdk-dev] [PATCH v4 9/9] net/mlx5: update Rx datapath to support split

2020-10-12 Thread Viacheslav Ovsiienko
Only the regular rx_burst routine is updated to support split, because the vectorized ones does not support scatter and MPRQ does not support split at all. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_rxq.c | 11 +-- drivers/net/mlx5/mlx5_rxtx.c | 3 ++- 2 files change

[dpdk-dev] [PATCH v4 5/9] app/testpmd: add extended Rx queue setup

2020-10-12 Thread Viacheslav Ovsiienko
If Rx queue is configured with split feature the extended setup with specified segment sizes and pool will be performed. Signed-off-by: Viacheslav Ovsiienko --- app/test-pmd/cmdline.c | 12 ++-- app/test-pmd/testpmd.c | 38 -- app/test-pmd/testpmd.h |

[dpdk-dev] [PATCH v4 3/9] app/testpmd: add buffer split offload configuration

2020-10-12 Thread Viacheslav Ovsiienko
This patch add support for RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT providing per queue configuration for this offload. Signed-off-by: Viacheslav Ovsiienko --- app/test-pmd/cmdline.c | 21 +++-- app/test-pmd/config.c | 9 + 2 files changed, 20 insertions(+), 10 deletions(-) dif

[dpdk-dev] [PATCH v4 6/9] net/mlx5: add extended Rx queue setup routine

2020-10-12 Thread Viacheslav Ovsiienko
The routine to provide Rx queue setup with specifying extended receiving buffer description is added. It allows application to specify desired segment lengths, data position offsets in the buffer and dedicated memory pool for each segment. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5

[dpdk-dev] [PATCH v4 4/9] app/testpmd: add rxpkts commands and parameters

2020-10-12 Thread Viacheslav Ovsiienko
Add command line parameter: --rxpkts=X[,Y] Sets the length of segments to scatter packets on receiving if split feature is engaged. Affects only the queues configured with split offloads (currently BUFFER_SPLIT is supported only). Add interactive mode command: testpmd> set txpkts (x[,y]*) Wher

[dpdk-dev] [PATCH v4 2/9] app/testpmd: add multiple pools per core creation

2020-10-12 Thread Viacheslav Ovsiienko
The command line parameter --mbuf-size is updated, it can handle the multiple values like the following: --mbuf-size=2176,512,768,4096 specifying the creation the extra memory pools with the requested mbuf data buffer sizes. If some buffer split feature is engaged the extra memory pools can be us

[dpdk-dev] [PATCH v4 1/9] ethdev: introduce Rx buffer split

2020-10-12 Thread Viacheslav Ovsiienko
The DPDK datapath in the transmit direction is very flexible. An application can build the multi-segment packet and manages almost all data aspects - the memory pools where segments are allocated from, the segment lengths, the memory attributes like external buffers, registered for DMA, etc. In th

[dpdk-dev] [PATCH v4 0/9] ethdev: introduce Rx buffer split

2020-10-12 Thread Viacheslav Ovsiienko
The DPDK datapath in the transmit direction is very flexible. An application can build the multi-segment packet and manages almost all data aspects - the memory pools where segments are allocated from, the segment lengths, the memory attributes like external buffers, registered for DMA, etc. In th

Re: [dpdk-dev] [EXT] [PATCH v6 03/14] doc: remove references to make from NICs guides

2020-10-12 Thread Harman Kalra
On Fri, Oct 09, 2020 at 11:21:29AM +0100, Ciara Power wrote: > External Email > > -- > Make is no longer supported for compiling DPDK, references are now > removed in the documentation. > > Signed-off-by: Ciara Power > Reviewed-

Re: [dpdk-dev] [PATCH v5 03/10] eal: add intrinsics support check infrastructure

2020-10-12 Thread David Christensen
On 10/9/20 9:02 AM, Anatoly Burakov wrote: Currently, it is not possible to check support for intrinsics that are platform-specific, cannot be abstracted in a generic way, or do not have support on all architectures. The CPUID flags can be used to some extent, but they are only defined for the

Re: [dpdk-dev] [PATCH v5 02/10] eal: add power management intrinsics

2020-10-12 Thread David Christensen
On 10/9/20 9:02 AM, Anatoly Burakov wrote: From: Liang Ma Add two new power management intrinsics, and provide an implementation in eal/x86 based on UMONITOR/UMWAIT instructions. The instructions are implemented as raw byte opcodes because there is not yet widespread compiler support for the

Re: [dpdk-dev] [PATCH v6 01/14] doc: remove references to make from platforms guides

2020-10-12 Thread Harman Kalra
On Fri, Oct 09, 2020 at 11:21:27AM +0100, Ciara Power wrote: > Make is no longer supported for compiling DPDK, references are now > removed in the documentation. Hi Ciara, Thanks for updating the platform guides for octeontx and octeontx2. All looks good for octeontx2 but for octeontx platf

Re: [dpdk-dev] [EXT] Re: [RFC PATCH v2] app/testpmd: tx pkt clones parameter in flowgen

2020-10-12 Thread Igor Russkikh
>> Here instead of recreating each packet separately, we use clones counter >> to resend the same mbuf to the line multiple times. >> > Do you have any numbers on how much performance improvement gained? Hi Ferruh, Yes, I'll post that in v1. In general, on our 100G device in default configurati

Re: [dpdk-dev] [PATCH v6] eal: add cache-line demote support

2020-10-12 Thread David Christensen
On 10/12/20 3:19 AM, Omkar Maslekar wrote: rte_cldemote is similar to a prefetch hint - in reverse. cldemote(addr) enables software to hint to hardware that line is likely to be shared. Useful in core-to-core communications where cache-line is likely to be shared. ARM and PPC implementation is

Re: [dpdk-dev] [PATCH] test/event_crypto_adapter: fix conf issue

2020-10-12 Thread Akhil Goyal
> Hi Akhil, > > This was introduced in patch (24054e3640a2). > > Fixes: 24054e3640a2 ("test/crypto: use separate session mempools") > Applied to dpdk-next-crypto Cc: sta...@dpdk.org Thanks.

Re: [dpdk-dev] [PATCH v5 10/11] doc: update release notes for MLX5 L3 frag support

2020-10-12 Thread Thomas Monjalon
12/10/2020 12:43, Dekel Peled: > This patch updates 20.11 release notes with the changes included in > patches of this series: > 1) MLX5 support of matching on IPv4/IPv6 fragmented/non-fragmented >packets. > 2) ABI change in ethdev struct rte_flow_item_ipv6. > > Signed-off-by: Dekel Peled > A

[dpdk-dev] [PATCH v2] mem: fix allocation failure on non-NUMA kernel

2020-10-12 Thread Nick Connolly
Running dpdk-helloworld on Linux with lib numa present, but no kernel support for NUMA (CONFIG_NUMA=n) causes ret_service_init() to fail with EAL: error allocating rte services array. alloc_seg() calls get_mempolicy to verify that the allocation has happened on the correct socket, but receives ENO

Re: [dpdk-dev] [PATCH v4 1/2] cryptodev: remove crypto list end enumerators

2020-10-12 Thread Akhil Goyal
> This patch removes enumerators RTE_CRYPTO_CIPHER_LIST_END, > RTE_CRYPTO_AUTH_LIST_END, RTE_CRYPTO_AEAD_LIST_END to prevent > some problems that may arise when adding new crypto algorithms. > > Signed-off-by: Arek Kusztal > --- Acked-by: Akhil Goyal Will squash both the patches while applying

[dpdk-dev] [PATCH v2] mem: fix allocation failure on non-NUMA kernel

2020-10-12 Thread Nick Connolly
Running dpdk-helloworld on Linux with lib numa present, but no kernel support for NUMA (CONFIG_NUMA=n) causes ret_service_init() to fail with EAL: error allocating rte services array. alloc_seg() calls get_mempolicy to verify that the allocation has happened on the correct socket, but receives ENO

[dpdk-dev] [PATCH v4 1/2] cryptodev: remove crypto list end enumerators

2020-10-12 Thread Arek Kusztal
This patch removes enumerators RTE_CRYPTO_CIPHER_LIST_END, RTE_CRYPTO_AUTH_LIST_END, RTE_CRYPTO_AEAD_LIST_END to prevent some problems that may arise when adding new crypto algorithms. Signed-off-by: Arek Kusztal --- lib/librte_cryptodev/rte_crypto_sym.h | 36 ++- 1 file

[dpdk-dev] [PATCH v4 2/2] doc: remove crypto list end deprecation notice

2020-10-12 Thread Arek Kusztal
This patch removes deprecation notice about removing LIST_END enumerators from Cryptodev. Signed-off-by: Arek Kusztal --- doc/guides/rel_notes/deprecation.rst | 5 - 1 file changed, 5 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst inde

[dpdk-dev] [PATCH v4 0/2] remove list end enumerators

2020-10-12 Thread Arek Kusztal
This patchset removes enumerators RTE_CRYPTO_CIPHER_LIST_END, RTE_CRYPTO_AUTH_LIST_END, RTE_CRYPTO_AEAD_LIST_END from symmetric crypto API to prevent some problems that may arise when adding new crypto algorithms. v2: - combined patches into one series - added removal of deprecation notice v3: - r

Re: [dpdk-dev] [PATCH v3 1/1] vfio: modify spapr iommu support to use static window sizing

2020-10-12 Thread David Christensen
\ -vfio_spapr_unmap_walk(const struct rte_memseg_list *msl, -    const struct rte_memseg *ms, void *arg) +vfio_spapr_size_walk(const struct rte_memseg_list *msl, void *arg)   { -    int *vfio_container_fd = arg; +    struct spapr_size_walk_param *param = arg; +    uint64_t max = (uint64_t

Re: [dpdk-dev] [PATCH v2 2/2] eventdev: update app and examples for new eventdev ABI

2020-10-12 Thread Pavan Nikhilesh Bhagavatula
>> Subject: [PATCH v2 2/2] eventdev: update app and examples for new >eventdev ABI >> >> Several data structures and constants changed, or were added, >> in the previous patch. This commit updates the dependent >> apps and examples to use the new ABI. >> >> Signed-off-by: Timothy McDaniel With f

Re: [dpdk-dev] [EXT] [PATCH v2 1/2] eventdev: eventdev: express DLB/DLB2 PMD constraints

2020-10-12 Thread Pavan Nikhilesh Bhagavatula
>This commit implements the eventdev ABI changes required by >the DLB PMD. > >Signed-off-by: Timothy McDaniel For octeontx/octeontx2 Acked-by: Pavan Nikhilesh >--- > drivers/event/dpaa/dpaa_eventdev.c | 3 +- > drivers/event/dpaa2/dpaa2_eventdev.c | 5 +- > drivers/event/

[dpdk-dev] [PATCH] eventdev: add PCI probe named convenience function

2020-10-12 Thread Timothy McDaniel
Add new internal wrapper function for use by pci drivers as a .probe function to attach to an event interface. Same as rte_event_pmd_pci_probe, except the caller can specify the name. Updated rte_event_pmd_pci_probe so as to not duplicate code. Signed-off-by: Timothy McDaniel --- lib/librte_ev

[dpdk-dev] [PATCH] eventdev: add PCI probe named convenience function

2020-10-12 Thread Timothy McDaniel
Add new internal wrapper function for use by pci drivers as a .probe function to attach to an event interface. Same as rte_event_pmd_pci_probe, except the caller can specify the name. Updated rte_event_pmd_pci_probe so as to not duplicate code. Signed-off-by: Timothy McDaniel --- lib/librte_ev

Re: [dpdk-dev] [PATCH v9 0/3] support the flow-based traffic sampling

2020-10-12 Thread Ferruh Yigit
On 10/9/2020 2:46 PM, Jiawei Wang wrote: This patch set implement the flow-based traffic sampling. The solution is introduced a new rte_flow action that will sample the incoming traffic and send a duplicated traffic with the specified ratio to the application, while the original packet will co

Re: [dpdk-dev] [RFC PATCH v2] app/testpmd: tx pkt clones parameter in flowgen

2020-10-12 Thread Ferruh Yigit
On 9/25/2020 10:07 AM, Igor Russkikh wrote: When testing high performance numbers, it is often that CPU performance limits the max values device can reach (both in pps and in gbps) Here instead of recreating each packet separately, we use clones counter to resend the same mbuf to the line multip

Re: [dpdk-dev] [PATCH v2] security: update session create API

2020-10-12 Thread Akhil Goyal
> > The API ``rte_security_session_create`` takes only single > mempool for session and session private data. So the > application need to create mempool for twice the number of > sessions needed and will also lead to wastage of memory as > session private data need more memory compared to session

Re: [dpdk-dev] [PATCH v2] eal: simplify exit functions

2020-10-12 Thread David Marchand
On Mon, Sep 28, 2020 at 2:01 AM Thomas Monjalon wrote: > The option RTE_EAL_ALWAYS_PANIC_ON_ERROR was off by default, > and not customizable with meson. It is completely removed. > > The function rte_dump_registers is a trace of the bare metal support > era, and was not supported in userland. It i

[dpdk-dev] [PATCH v6] eal: add cache-line demote support

2020-10-12 Thread Omkar Maslekar
rte_cldemote is similar to a prefetch hint - in reverse. cldemote(addr) enables software to hint to hardware that line is likely to be shared. Useful in core-to-core communications where cache-line is likely to be shared. ARM and PPC implementation is provided with NOP and can be added if any equiv

[dpdk-dev] [PATCH v6] eal: add cache-line demote support

2020-10-12 Thread Omkar Maslekar
We are including this in rte_prefetch.h since it is the most closely related code location.rte_cldemte is similar to a prefetch hint -in reverse Omkar Maslekar (1): eal: add cache-line demote support app/test/test_prefetch.c | 4 doc/guides/rel_notes/release_20_11.rs

Re: [dpdk-dev] [EXT] Re: [PATCH v2 2/4] regex/octeontx2: add build infra and device support

2020-10-12 Thread Thomas Monjalon
12/10/2020 19:13, Guy Kaneti: > From: Thomas Monjalon > > 12/10/2020 19:06, Guy Kaneti: > > > From: Thomas Monjalon > > > > 12/10/2020 13:31, g...@marvell.com: > > > > > --- a/meson_options.txt > > > > > +++ b/meson_options.txt > > > > > +option('ree_compiler_sdk', type: 'string', value: '', > >

Re: [dpdk-dev] [EXT] Re: [PATCH v2 2/4] regex/octeontx2: add build infra and device support

2020-10-12 Thread Guy Kaneti
> -Original Message- > From: Thomas Monjalon > Sent: Monday, October 12, 2020 8:11 PM > To: Guy Kaneti > Cc: or...@mellanox.com; Jerin Jacob Kollanukkaran ; > Nithin Kumar Dabilpuram ; m...@ashroe.eu; > nhor...@tuxdriver.com; bruce.richard...@intel.com; > anatoly.bura...@intel.com; joh

Re: [dpdk-dev] [PATCH v3 1/9] ethdev: introduce Rx buffer split

2020-10-12 Thread Slava Ovsiienko
> -Original Message- > From: Thomas Monjalon > Sent: Monday, October 12, 2020 20:03 > To: Slava Ovsiienko ; Andrew Rybchenko > > Cc: dev@dpdk.org; step...@networkplumber.org; ferruh.yi...@intel.com; > olivier.m...@6wind.com; jerinjac...@gmail.com; > maxime.coque...@redhat.com; david.march

Re: [dpdk-dev] [EXT] Re: [PATCH v2 4/4] doc: add Marvell OCTEON TX2 regex guide

2020-10-12 Thread Thomas Monjalon
12/10/2020 19:09, Guy Kaneti: > From: Thomas Monjalon > > 12/10/2020 13:31, g...@marvell.com: > > > From: Guy Kaneti > > > > > > Added Marvell OCTEON TX2 regex guide, features and updated release > > > notes. > > > > I think this patch should be merged with doc changes: I meant with "code chang

Re: [dpdk-dev] [PATCH v3 1/9] ethdev: introduce Rx buffer split

2020-10-12 Thread Andrew Rybchenko
On 10/12/20 8:03 PM, Thomas Monjalon wrote: > 12/10/2020 18:38, Andrew Rybchenko: >> On 10/12/20 7:19 PM, Viacheslav Ovsiienko wrote: >>> int >>> +rte_eth_rxseg_queue_setup(uint16_t port_id, uint16_t rx_queue_id, >>> + uint16_t nb_rx_desc, unsigned int socket_id, >>> +

Re: [dpdk-dev] [EXT] Re: [PATCH v2 2/4] regex/octeontx2: add build infra and device support

2020-10-12 Thread Thomas Monjalon
12/10/2020 19:06, Guy Kaneti: > From: Thomas Monjalon > > 12/10/2020 13:31, g...@marvell.com: > > > --- a/meson_options.txt > > > +++ b/meson_options.txt > > > +option('ree_compiler_sdk', type: 'string', value: '', > > > + description: 'path to REE compiler SDK optional library for regex > > devic

Re: [dpdk-dev] [PATCH] net/pcap: fix possible crash on exit for infinite Rx

2020-10-12 Thread Ferruh Yigit
On 10/9/2020 5:16 PM, Ferruh Yigit wrote: If the infinite Rx argument ('infinite_rx') is provided a ring is allocated and filled in the '.rx_queue_setup' dev_ops. Later this ring freed in the '.dev_close' dev_ops. If the 'infinite_rx' provided and '.dev_close' called before '.rx_queue_setup', th

Re: [dpdk-dev] [EXT] Re: [PATCH v2 4/4] doc: add Marvell OCTEON TX2 regex guide

2020-10-12 Thread Guy Kaneti
Hi, > -Original Message- > From: Thomas Monjalon > Sent: Monday, October 12, 2020 5:39 PM > To: Guy Kaneti > Cc: or...@mellanox.com; Jerin Jacob Kollanukkaran ; > Nithin Kumar Dabilpuram ; m...@ashroe.eu; > nhor...@tuxdriver.com; bruce.richard...@intel.com; > anatoly.bura...@intel.com; j

Re: [dpdk-dev] [RFC v2 1/1] lib/ring: add scatter gather APIs

2020-10-12 Thread Ananyev, Konstantin
> > > > > > > Hi Honnappa, > > > > > > > > > > From a quick walkthrough, I have some questions/comments, please > > > > > see below. > > > > Hi Olivier, appreciate your input. > > > > > > > > > > > > > > On Tue, Oct 06, 2020 at 08:29:05AM -0500, Honnappa Nagarahalli wrote: > > > > > > Add sc

Re: [dpdk-dev] [EXT] Re: [PATCH v2 2/4] regex/octeontx2: add build infra and device support

2020-10-12 Thread Guy Kaneti
Hi > -Original Message- > From: Thomas Monjalon > Sent: Monday, October 12, 2020 5:33 PM > To: Guy Kaneti > Cc: or...@mellanox.com; Jerin Jacob Kollanukkaran ; > Nithin Kumar Dabilpuram ; m...@ashroe.eu; > nhor...@tuxdriver.com; bruce.richard...@intel.com; > anatoly.bura...@intel.com; jo

Re: [dpdk-dev] [PATCH v3 1/9] ethdev: introduce Rx buffer split

2020-10-12 Thread Thomas Monjalon
12/10/2020 18:38, Andrew Rybchenko: > On 10/12/20 7:19 PM, Viacheslav Ovsiienko wrote: > > int > > +rte_eth_rxseg_queue_setup(uint16_t port_id, uint16_t rx_queue_id, > > + uint16_t nb_rx_desc, unsigned int socket_id, > > + const struct rte_eth_rxconf *rx_con

Re: [dpdk-dev] [dpdk-techboard] [PATCH V5 1/2] dpdk: resolve compiling errors for per-queue stats

2020-10-12 Thread Ferruh Yigit
On 10/10/2020 9:09 AM, Thomas Monjalon wrote: 09/10/2020 22:32, Ferruh Yigit: On 10/6/2020 9:33 AM, Olivier Matz wrote: On Mon, Oct 05, 2020 at 01:23:08PM +0100, Ferruh Yigit wrote: On 9/28/2020 4:43 PM, Stephen Hemminger wrote: On Mon, 28 Sep 2020 17:24:26 +0200 Thomas Monjalon wrote: 28/0

Re: [dpdk-dev] [dpdk-techboard] [RFC 2/2] doc: announce queue stats moving to xstats

2020-10-12 Thread Stephen Hemminger
On Mon, 12 Oct 2020 17:46:01 +0100 Ferruh Yigit wrote: > Queue stats will be removed from basic stats to xstats. > > It will be PMDs responsibility to fill queue stats based on number of > queues they have. > > Until all PMDs implement the xstats, a temporary > 'RTE_ETH_DEV_QUEUE_STATS_IN_XSTAT

Re: [dpdk-dev] [RFC] ethdev: introduce Rx buffer split

2020-10-12 Thread Thomas Monjalon
12/10/2020 17:56, Ananyev, Konstantin: > > From: Ananyev, Konstantin > > > > 12/10/2020 11:56, Slava Ovsiienko: > > > > > We have two approaches how to specify multiple segments to split Rx > > > packets: > > > > > 1. update queue configuration structure 2. introduce new > > > > > rx_queue_setup_e

[dpdk-dev] [RFC 1/2] ethdev: move queue stats to xstats

2020-10-12 Thread Ferruh Yigit
Queue stats are stored in 'struct rte_eth_stats' as array and array size is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag. As a result of technical board discussion, decided to remove the queue statistics from 'struct rte_eth_stats' in the long term. Instead PMDs should represent the

[dpdk-dev] [RFC 2/2] doc: announce queue stats moving to xstats

2020-10-12 Thread Ferruh Yigit
Queue stats will be removed from basic stats to xstats. It will be PMDs responsibility to fill queue stats based on number of queues they have. Until all PMDs implement the xstats, a temporary 'RTE_ETH_DEV_QUEUE_STATS_IN_XSTATS' device flag created. PMDs switched to the xstats should set this fla

Re: [dpdk-dev] [PATCH v3 1/9] ethdev: introduce Rx buffer split

2020-10-12 Thread Andrew Rybchenko
On 10/12/20 7:19 PM, Viacheslav Ovsiienko wrote: > The DPDK datapath in the transmit direction is very flexible. > An application can build the multi-segment packet and manages > almost all data aspects - the memory pools where segments > are allocated from, the segment lengths, the memory attribut

Re: [dpdk-dev] [PATCH v3 11/18] net/ixgbe: add checks for max SIMD bitwidth

2020-10-12 Thread Ananyev, Konstantin
> > -Original Message- > > From: Ananyev, Konstantin > > Sent: Monday, October 12, 2020 17:09 > > To: Wang, Haiyue ; Power, Ciara > > ; dev@dpdk.org > > Cc: Zhao1, Wei ; Guo, Jia > > Subject: RE: [PATCH v3 11/18] net/ixgbe: add checks for max SIMD bitwidth > > > > > > > > From: Power,

[dpdk-dev] [PATCH v3 1/9] ethdev: introduce Rx buffer split

2020-10-12 Thread Viacheslav Ovsiienko
The DPDK datapath in the transmit direction is very flexible. An application can build the multi-segment packet and manages almost all data aspects - the memory pools where segments are allocated from, the segment lengths, the memory attributes like external buffers, registered for DMA, etc. In th

Re: [dpdk-dev] [RFC v2 1/1] lib/ring: add scatter gather APIs

2020-10-12 Thread Ananyev, Konstantin
> Add scatter gather APIs to avoid intermediate memcpy. Use cases > that involve copying large amount of data to/from the ring > can benefit from these APIs. > > Signed-off-by: Honnappa Nagarahalli > --- > lib/librte_ring/meson.build| 3 +- > lib/librte_ring/rte_ring_elem.h| 1

[dpdk-dev] [PATCH v3 5/9] app/testpmd: add extended Rx queue setup

2020-10-12 Thread Viacheslav Ovsiienko
If Rx queue is configured with split feature the extended setup with specified segment sizes and pool will be performed. Signed-off-by: Viacheslav Ovsiienko --- app/test-pmd/cmdline.c | 12 ++-- app/test-pmd/testpmd.c | 38 -- app/test-pmd/testpmd.h |

[dpdk-dev] [PATCH v3 4/9] app/testpmd: add rxpkts commands and parameters

2020-10-12 Thread Viacheslav Ovsiienko
Add command line parameter: --rxpkts=X[,Y] Sets the length of segments to scatter packets on receiving if split feature is engaged. Affects only the queues configured with split offloads (currently BUFFER_SPLIT is supported only). Add interactive mode command: testpmd> set txpkts (x[,y]*) Wher

[dpdk-dev] [PATCH v3 0/9] ethdev: introduce Rx buffer split

2020-10-12 Thread Viacheslav Ovsiienko
The DPDK datapath in the transmit direction is very flexible. An application can build the multi-segment packet and manages almost all data aspects - the memory pools where segments are allocated from, the segment lengths, the memory attributes like external buffers, registered for DMA, etc. In th

[dpdk-dev] [PATCH v3 6/9] net/mlx5: add extended Rx queue setup routine

2020-10-12 Thread Viacheslav Ovsiienko
The routine to provide Rx queue setup with specifying extended receiving buffer description is added. It allows application to specify desired segment lengths, data position offsets in the buffer and dedicated memory pool for each segment. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5

[dpdk-dev] [PATCH v3 9/9] net/mlx5: update Rx datapath to support split

2020-10-12 Thread Viacheslav Ovsiienko
Only the regular rx_burst routine is updated to support split, because the vectorized ones does not support scatter and MPRQ does not support split at all. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_rxq.c | 11 +-- drivers/net/mlx5/mlx5_rxtx.c | 3 ++- 2 files change

[dpdk-dev] [PATCH v3 8/9] net/mlx5: register multiple pool for Rx queue

2020-10-12 Thread Viacheslav Ovsiienko
The split feature for receiving packets was added to the mlx5 PMD, now Rx queue can receive the data to the buffers belonging to the different pools and the memory of all the involved pool must be registered for DMA operations in order to allow hardware to store the data. Signed-off-by: Viacheslav

[dpdk-dev] [PATCH v3 2/9] app/testpmd: add multiple pools per core creation

2020-10-12 Thread Viacheslav Ovsiienko
The command line parameter --mbuf-size is updated, it can handle the multiple values like the following: --mbuf-size=2176,512,768,4096 specifying the creation the extra memory pools with the requested mbuf data buffer sizes. If some buffer split feature is engaged the extra memory pools can be us

[dpdk-dev] [PATCH v3 7/9] net/mlx5: configure Rx queue to support split

2020-10-12 Thread Viacheslav Ovsiienko
The scatter-gather elements should be configured accordingly to support the buffer split feature. The application provides the desired settings for the segments at the beginning of the packets and PMD pads the buffer chain (if needed) with attributes of last specified segment to accommodate the pac

[dpdk-dev] [PATCH v3 3/9] app/testpmd: add buffer split offload configuration

2020-10-12 Thread Viacheslav Ovsiienko
This patch add support for RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT providing per queue configuration for this offload. Signed-off-by: Viacheslav Ovsiienko --- app/test-pmd/cmdline.c | 21 +++-- app/test-pmd/config.c | 9 + 2 files changed, 20 insertions(+), 10 deletions(-) dif

Re: [dpdk-dev] [dpdk-dev v13 0/4] cryptodev: add raw data-path APIs

2020-10-12 Thread Akhil Goyal
> Subject: [dpdk-dev v13 0/4] cryptodev: add raw data-path APIs > > The Crypto Raw data-path APIs are a set of APIs designed to enable external > libraries/applications to leverage the cryptographic processing provided by > DPDK crypto PMDs through the cryptodev API but in a manner that is not > d

Re: [dpdk-dev] [RFC] ethdev: introduce Rx buffer split

2020-10-12 Thread Slava Ovsiienko
> -Original Message- > From: Andrew Rybchenko > Sent: Monday, October 12, 2020 19:04 > To: NBU-Contact-Thomas Monjalon ; > ferruh.yi...@intel.com; Slava Ovsiienko > Cc: dev@dpdk.org; step...@networkplumber.org; Shahaf Shuler > ; olivier.m...@6wind.com; jerinjac...@gmail.com; > maxime.coqu

Re: [dpdk-dev] [PATCH v3 11/18] net/ixgbe: add checks for max SIMD bitwidth

2020-10-12 Thread Wang, Haiyue
> -Original Message- > From: Ananyev, Konstantin > Sent: Monday, October 12, 2020 17:09 > To: Wang, Haiyue ; Power, Ciara > ; dev@dpdk.org > Cc: Zhao1, Wei ; Guo, Jia > Subject: RE: [PATCH v3 11/18] net/ixgbe: add checks for max SIMD bitwidth > > > > > > From: Power, Ciara > > > > > Se

Re: [dpdk-dev] [RFC] ethdev: introduce Rx buffer split

2020-10-12 Thread Andrew Rybchenko
On 10/12/20 6:14 PM, Thomas Monjalon wrote: > 12/10/2020 11:56, Slava Ovsiienko: >> Hi, Andrew >> >> Thank you for the comments. >> >> We have two approaches how to specify multiple segments to split Rx packets: >> 1. update queue configuration structure >> 2. introduce new rx_queue_setup_ex() rout

Re: [dpdk-dev] [RFC] ethdev: introduce Rx buffer split

2020-10-12 Thread Slava Ovsiienko
> -Original Message- > From: Ananyev, Konstantin > Sent: Monday, October 12, 2020 18:56 > To: Slava Ovsiienko ; NBU-Contact-Thomas > Monjalon ; Andrew Rybchenko > ; Yigit, Ferruh > Cc: dev@dpdk.org; step...@networkplumber.org; Shahaf Shuler > ; olivier.m...@6wind.com; jerinjac...@gmail.co

  1   2   3   >