Re: [dpdk-dev] [PATCH 2/2] build: find max lcore programmatically

2020-10-13 Thread Juraj Linkeš
Hi Dharmik, > -Original Message- > From: Dharmik Thakkar > Sent: Tuesday, October 13, 2020 5:15 PM > To: Juraj Linkeš > Cc: tho...@monjalon.net; dev@dpdk.org; Stephen Hemminger > ; Jerin Jacob ; nd > > Subject: Re: [dpdk-dev] [PATCH 2/2] build: find max lcore programmatically > > Hi Ju

Re: [dpdk-dev] [PATCH v7 1/2] ethdev: add flow shared action API

2020-10-13 Thread Andrew Rybchenko
Hi Andrey, On 10/13/20 11:06 PM, Andrey Vesnovaty wrote: > Hi Andrew. > > Thanks for the input. > All spelling & rephrases will be applied PSB for the rest. > Will publish v8 very soon. > > Thanks, > Andrey > >> -Original Message- >> From: Andrew Rybchenko >> Sent: Monday, October 12,

Re: [dpdk-dev] [PATCH] net/bnx2x: fix to add QLogic vendor id

2020-10-13 Thread Jerin Jacob
On Wed, Oct 14, 2020 at 3:07 AM Ajit Khaparde wrote: > > On Tue, Oct 13, 2020 at 1:43 PM Ferruh Yigit wrote: > > > > On 10/13/2020 7:28 PM, Jerin Jacob wrote: > > > On Tue, Oct 13, 2020 at 4:18 AM Rasesh Mody wrote: > > >> > > >> Add QLogic vendor id support for BCM57840 device ids. > > >> > > >

Re: [dpdk-dev] [RFC] ethdev: unify prefix for static function and variables

2020-10-13 Thread Andrew Rybchenko
On 10/13/20 7:56 PM, Ferruh Yigit wrote: > Prefix static function and variables with 'eth_dev'. > > For some 'rte_' prefix dropped, and for others 'eth_dev' added. > This is useful to differentiate public and static function/variables. > > The cleanup is good to for having consistent naming to he

Re: [dpdk-dev] [RFC PATCH v2 3/6] build: automatic NUMA and cpu counts detection

2020-10-13 Thread Juraj Linkeš
> -Original Message- > From: Bruce Richardson > Sent: Tuesday, October 13, 2020 5:48 PM > To: Juraj Linkeš > Cc: ruifeng.w...@arm.com; honnappa.nagaraha...@arm.com; > phil.y...@arm.com; vcchu...@amazon.com; dharmik.thak...@arm.com; > jerinjac...@gmail.com; hemant.agra...@nxp.com; dev@dp

Re: [dpdk-dev] [PATCH v4] RSS key use with testpmd

2020-10-13 Thread oulijun
在 2020/10/10 2:52, Ferruh Yigit 写道: On 10/9/2020 1:09 PM, oulijun wrote: 在 2020/9/30 21:17, Ferruh Yigit 写道: On 9/24/2020 2:45 PM, Lijun Ou wrote: Consider the follow usage with testpmd: 1. first, startup testpmd: testpmd> show port 0 rss-hash key RSS functions: all ipv4-frag ipv4-other

Re: [dpdk-dev] [PATCH] ethdev: unify error code if port ID is invalid

2020-10-13 Thread Andrew Rybchenko
On 10/13/20 7:12 PM, Ferruh Yigit wrote: > On 10/13/2020 4:39 PM, Andrew Rybchenko wrote: >> On 10/13/20 6:32 PM, Ferruh Yigit wrote: >>> On 10/13/2020 3:53 PM, Andrew Rybchenko wrote: Use ENODEV as the error code if specified port ID is invalid. Signed-off-by: Andrew Rybchenko

[dpdk-dev] [PATCH v3 53/56] net/txgbe: add mirror rule operations

2020-10-13 Thread Jiawen Wu
Add mirror rule set and reset operations. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/txgbe_ethdev.c | 186 + drivers/net/txgbe/txgbe_ethdev.h | 1 + 3 files changed, 188 insertions(+) diff --git a/doc/guides/nics/

[dpdk-dev] [PATCH v3 54/56] net/txgbe: add PTP support

2020-10-13 Thread Jiawen Wu
Add PTP support. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/txgbe_ethdev.c | 234 + drivers/net/txgbe/txgbe_ethdev.h | 22 +++ drivers/net/txgbe/txgbe_rxtx.c | 32 +++

[dpdk-dev] [PATCH v3 56/56] net/txgbe: add Rx and Tx descriptor status

2020-10-13 Thread Jiawen Wu
Supports check the status of Rx and Tx descriptors. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 2 + drivers/net/txgbe/txgbe_ethdev.c | 5 + drivers/net/txgbe/txgbe_ethdev.h | 8 ++ drivers/net/txgbe/txgbe_rxtx.c | 180 + drivers/ne

[dpdk-dev] [PATCH v3 55/56] net/txgbe: add DCB info get operation

2020-10-13 Thread Jiawen Wu
Add DCB information get operation. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 91 1 file changed, 91 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index ddf92f1bd..77292f07f 100644 --- a/drive

[dpdk-dev] [PATCH v3 52/56] net/txgbe: support device LED on and off

2020-10-13 Thread Jiawen Wu
Support device LED on and off. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 46 +++ drivers/net/txgbe/base/txgbe_hw.h | 3 ++ drivers/net/txgbe/txgbe_ethdev.c | 20 ++ 3 files changed, 69 insertions(+) diff --git a/drivers/net/txgbe/

[dpdk-dev] [PATCH v3 50/56] net/txgbe: add EEPROM info get operation

2020-10-13 Thread Jiawen Wu
Add EEPROM information get related operations. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 2 + drivers/net/txgbe/base/txgbe_hw.c | 4 + drivers/net/txgbe/base/txgbe_phy.c | 16 drivers/net/txgbe/base/txgbe_phy.h | 3 + drivers/net/txgbe/txgbe_ethdev.c | 126

[dpdk-dev] [PATCH v3 49/56] net/txgbe: add FW version get operation

2020-10-13 Thread Jiawen Wu
Add firmware version get operation. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/txgbe_ethdev.c | 22 ++ 3 files changed, 24 insertions(+) diff --git a/doc/guides/nics/features/txgbe.in

[dpdk-dev] [PATCH v3 51/56] net/txgbe: add register dump support

2020-10-13 Thread Jiawen Wu
Add register dump support. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/base/txgbe_type.h | 1 + drivers/net/txgbe/txgbe_ethdev.c | 113 +++ drivers/net/txgbe/txgbe_regs_group.h | 54 + 4 files changed, 1

[dpdk-dev] [PATCH v3 48/56] net/txgbe: add MTU set operation

2020-10-13 Thread Jiawen Wu
Add MTU set operation. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/base/txgbe_type.h | 2 ++ drivers/net/txgbe/txgbe_ethdev.c| 41 + 3 files changed, 44 insertions(+) diff --git a/doc/guides/nics/features/txgbe.ini

[dpdk-dev] [PATCH v3 47/56] net/txgbe: add device promiscuous and allmulticast mode

2020-10-13 Thread Jiawen Wu
Add device promiscuous and allmulticast mode. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 2 + doc/guides/nics/txgbe.rst | 2 + drivers/net/txgbe/txgbe_ethdev.c | 63 ++ 3 files changed, 67 insertions(+) diff --git a/doc/guides/nics

[dpdk-dev] [PATCH v3 45/56] net/txgbe: add FC auto negotiation support

2020-10-13 Thread Jiawen Wu
Add flow control negotiation with link partner. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 200 ++ drivers/net/txgbe/base/txgbe_hw.h | 3 + 2 files changed, 203 insertions(+) diff --git a/drivers/net/txgbe/base/txgbe_hw.c b/drivers/net/txgbe/

[dpdk-dev] [PATCH v3 46/56] net/txgbe: add priority flow control support

2020-10-13 Thread Jiawen Wu
Add priority flow control support. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_dcb.c| 148 ++ drivers/net/txgbe/base/txgbe_dcb.h| 2 + drivers/net/txgbe/base/txgbe_dcb_hw.c | 73 + drivers/net/txgbe/txgbe_ethdev.c | 54 ++

[dpdk-dev] [PATCH v3 43/56] net/txgbe: add DCB support

2020-10-13 Thread Jiawen Wu
Add DCB transmit and receive mode configurations, and allocate DCB packet buffer. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini| 1 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/base/meson.build| 2 + drivers/net/txgbe/base/txgbe.h| 1

[dpdk-dev] [PATCH v3 41/56] net/txgbe: add VMDq configure

2020-10-13 Thread Jiawen Wu
Add multiple queue setting with VMDq. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/txgbe_ethdev.c | 35 drivers/net/txgbe/txgbe_ethdev.h | 2 + drivers/net/txgbe/txgbe_rxtx.c | 260 + 4 files changed, 298 i

[dpdk-dev] [PATCH v3 42/56] net/txgbe: add RSS support

2020-10-13 Thread Jiawen Wu
Add RSS configure, support to RSS hash and reta operations for PF. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 3 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/meson.build | 2 + drivers/net/txgbe/txgbe_ethdev.c | 102 ++ drivers/net

[dpdk-dev] [PATCH v3 44/56] net/txgbe: add flow control support

2020-10-13 Thread Jiawen Wu
Add flow control support. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/base/txgbe_hw.c | 425 drivers/net/txgbe/base/txgbe_hw.h | 6 + drivers/net/txgbe/base/txgbe_type.

[dpdk-dev] [PATCH v3 40/56] net/txgbe: add PF module configure for SRIOV

2020-10-13 Thread Jiawen Wu
Add PF module configure for SRIOV. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/base/txgbe_hw.c | 345 drivers/net/txgbe/base/txgbe_hw.h | 12 + drivers/net/txgbe/base/txgbe_type.h | 1 + drivers/net/txgbe/txgbe_e

[dpdk-dev] [PATCH v3 39/56] net/txgbe: add process mailbox operation

2020-10-13 Thread Jiawen Wu
Add check operation for vf function level reset, mailbox messages and ack from vf. Waiting to process the messages. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 5 + drivers/net/txgbe/base/txgbe_mbx.c | 303 +++ drivers/net/txgbe/base/txgbe_mbx.h | 83 +++- dr

[dpdk-dev] [PATCH v3 37/56] net/txgbe: add SWFW semaphore and lock

2020-10-13 Thread Jiawen Wu
Add semaphore between software and firmware. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_dummy.h | 2 +- drivers/net/txgbe/base/txgbe_eeprom.h | 8 ++ drivers/net/txgbe/base/txgbe_hw.c | 129 ++ drivers/net/txgbe/base/txgbe_hw.h | 5 + drivers

[dpdk-dev] [PATCH v3 36/56] net/txgbe: add VLAN handle support

2020-10-13 Thread Jiawen Wu
Add VLAN filter, tpid, offload and strip set support. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + doc/guides/nics/txgbe.rst | 3 +- drivers/net/txgbe/base/txgbe_hw.c | 31 +++ drivers/net/txgbe/base/txgbe_hw.h | 1 + drivers/net/txgbe/base/txgbe_t

[dpdk-dev] [PATCH v3 38/56] net/txgbe: add PF module init and uninit for SRIOV

2020-10-13 Thread Jiawen Wu
Add PF module init and uninit operations with mailbox. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/base/meson.build | 1 + drivers/net/txgbe/base/txgbe.h | 1 + drivers/net/txgbe/base/txgbe_hw.c | 4 + drivers/net/txgbe/base/txgbe_mbx

[dpdk-dev] [PATCH v3 33/56] net/txgbe: add device stats get

2020-10-13 Thread Jiawen Wu
Add device stats get from reading hardware registers. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/base/txgbe_regs.h | 48 ++--- drivers/net/txgbe/base/txgbe_type.h | 155 drivers/net/tx

[dpdk-dev] [PATCH v3 32/56] net/txgbe: add Rx and Tx queue info get

2020-10-13 Thread Jiawen Wu
Add Rx and Tx queue information get operation. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 2 + drivers/net/txgbe/txgbe_ethdev.h | 6 +++ drivers/net/txgbe/txgbe_rxtx.c | 77 3 files changed, 85 insertions(+) diff --git a/drivers/net/txgb

[dpdk-dev] [PATCH v3 35/56] net/txgbe: add queue stats mapping

2020-10-13 Thread Jiawen Wu
Add queue stats mapping set, and clear hardware counters. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/base/txgbe_hw.c | 118 + drivers/net/txgbe/base/txgbe_hw.h | 1 + drivers/net/txgbe/txgbe_ethdev.c | 55

[dpdk-dev] [PATCH v3 34/56] net/txgbe: add device xstats get

2020-10-13 Thread Jiawen Wu
Add device extended stats get from reading hardware registers. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/txgbe_ethdev.c | 378 + drivers/net/txgbe/txgbe_ethdev.h | 6 + 3 files changed, 385 insertions(+) diff --g

[dpdk-dev] [PATCH v3 31/56] net/txgbe: support Rx interrupt

2020-10-13 Thread Jiawen Wu
Support rx queue interrupt. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/txgbe_ethdev.c | 43 ++ 3 files changed, 45 insertions(+) diff --git a/doc/guides/nics/features/txgbe.in

[dpdk-dev] [PATCH v3 30/56] net/txgbe: add device stop and close operations

2020-10-13 Thread Jiawen Wu
Add device stop, close and reset operations. And support hardware thermal sensor. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 69 ++ drivers/net/txgbe/base/txgbe_hw.h | 3 + drivers/net/txgbe/base/txgbe_type.h | 11 +++ drivers/net/txgbe/txgbe_ethdev.

[dpdk-dev] [PATCH v3 27/56] net/txgbe: fill receive functions

2020-10-13 Thread Jiawen Wu
Fill receive functions and define receive descriptor. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + doc/guides/nics/txgbe.rst | 3 +- drivers/net/txgbe/base/txgbe_type.h | 2 + drivers/net/txgbe/txgbe_ethdev.c| 14 + drivers/net/txgbe/txgbe_ethdev.h

[dpdk-dev] [PATCH v3 28/56] net/txgbe: add device start operation

2020-10-13 Thread Jiawen Wu
Add device start operation with hardware start and reset. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_eeprom.h | 1 + drivers/net/txgbe/base/txgbe_hw.c | 346 ++ drivers/net/txgbe/base/txgbe_hw.h | 9 + drivers/net/txgbe/base/txgbe_type.h | 5

[dpdk-dev] [PATCH v3 26/56] net/txgbe: fill Tx prepare function

2020-10-13 Thread Jiawen Wu
Fill transmit prepare function. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 1 + drivers/net/txgbe/txgbe_ethdev.h | 3 ++ drivers/net/txgbe/txgbe_rxtx.c | 61 3 files changed, 65 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.c

[dpdk-dev] [PATCH v3 29/56] net/txgbe: add Rx and Tx data path start and stop

2020-10-13 Thread Jiawen Wu
Add receive and transmit data path start and stop. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 142 ++ drivers/net/txgbe/base/txgbe_hw.h | 5 ++ 2 files changed, 147 insertions(+) diff --git a/drivers/net/txgbe/base/txgbe_hw.c b/drivers/net/tx

[dpdk-dev] [PATCH v3 23/56] net/txgbe: add packet type

2020-10-13 Thread Jiawen Wu
Add packet type marco definition and convert ptype to ptid. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/meson.build | 1 + drivers/net/txgbe/txgbe_ethdev.h | 1 + drivers/net/txgbe/txgbe_ptypes.

[dpdk-dev] [PATCH v3 25/56] net/txgbe: fill transmit function with hardware offload

2020-10-13 Thread Jiawen Wu
Fill transmit function with hardware offload. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 7 + doc/guides/nics/txgbe.rst | 3 + drivers/net/txgbe/txgbe_ethdev.c | 26 ++ drivers/net/txgbe/txgbe_ethdev.h | 6 + drivers/net/txgbe/txgbe_rxtx.c | 670 +++

[dpdk-dev] [PATCH v3 24/56] net/txgbe: fill simple transmit function

2020-10-13 Thread Jiawen Wu
Fill simple transmit function and define transmit descriptor. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_rxtx.c | 237 - drivers/net/txgbe/txgbe_rxtx.h | 84 +++- 2 files changed, 318 insertions(+), 3 deletions(-) diff --git a/drivers/net/txgbe

[dpdk-dev] [PATCH v3 22/56] net/txgbe: add Rx and Tx start and stop

2020-10-13 Thread Jiawen Wu
Add receive and transmit units start and stop for specified queue. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/base/txgbe_type.h | 3 + drivers/net/txgbe/txgbe_ethdev.c| 6 + drivers/net/txgbe/txgbe_ethdev.h| 15 ++ drivers/net/txgbe/t

[dpdk-dev] [PATCH v3 20/56] net/txgbe: add Rx and Tx init

2020-10-13 Thread Jiawen Wu
Add receive and transmit initialize unit. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 4 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/base/txgbe_type.h | 2 + drivers/net/txgbe/txgbe_ethdev.h| 8 + drivers/net/txgbe/txgbe_rxtx.c | 338 +++

[dpdk-dev] [PATCH v3 21/56] net/txgbe: add Rx and Tx queues setup and release

2020-10-13 Thread Jiawen Wu
Add receive and transmit queues setup and release. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 4 + drivers/net/txgbe/txgbe_ethdev.h | 13 + drivers/net/txgbe/txgbe_rxtx.c | 510 +++ drivers/net/txgbe/txgbe_rxtx.h | 130 4 files cha

[dpdk-dev] [PATCH v3 19/56] net/txgbe: add unicast hash bitmap

2020-10-13 Thread Jiawen Wu
Add unicast hash bitmap. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_type.h | 4 +- drivers/net/txgbe/txgbe_ethdev.c| 120 drivers/net/txgbe/txgbe_ethdev.h| 10 +++ 3 files changed, 133 insertions(+), 1 deletion(-) diff --git a/drivers/net/t

[dpdk-dev] [PATCH v3 18/56] net/txgbe: add MAC address operations

2020-10-13 Thread Jiawen Wu
Add MAC address related operations. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini| 2 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/base/txgbe_eeprom.h | 2 + drivers/net/txgbe/base/txgbe_hw.c | 476 ++ drivers/net/txgbe/

[dpdk-dev] [PATCH v3 17/56] net/txgbe: add autoc read and write

2020-10-13 Thread Jiawen Wu
Add autoc read and write for kr/kx/kx4/sfi link. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 2 + drivers/net/txgbe/base/txgbe_phy.c | 859 drivers/net/txgbe/base/txgbe_phy.h | 2 + drivers/net/txgbe/base/txgbe_type.h | 21 + 4 files cha

[dpdk-dev] [PATCH v3 16/56] net/txgbe: add multi-speed link setup

2020-10-13 Thread Jiawen Wu
Add multispeed fiber setup link and laser control. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 398 +- drivers/net/txgbe/base/txgbe_hw.h | 11 + 2 files changed, 408 insertions(+), 1 deletion(-) diff --git a/drivers/net/txgbe/base/txgbe_hw.c b/

[dpdk-dev] [PATCH v3 14/56] net/txgbe: add device configure operation

2020-10-13 Thread Jiawen Wu
Add device configure operation. Signed-off-by: Jiawen Wu --- doc/guides/nics/txgbe.rst| 1 + drivers/net/txgbe/txgbe_ethdev.c | 195 +++ drivers/net/txgbe/txgbe_ethdev.h | 7 ++ 3 files changed, 203 insertions(+) diff --git a/doc/guides/nics/txgbe.rst b/d

[dpdk-dev] [PATCH v3 15/56] net/txgbe: add link status change

2020-10-13 Thread Jiawen Wu
Add ethdev link interrupt handler, MAC setup link and check link status and get capabilities. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_eeprom.h | 3 + drivers/net/txgbe/base/txgbe_hw.c | 498 +- drivers/net/txgbe/base/txgbe_hw.h | 15 + drivers

[dpdk-dev] [PATCH v3 13/56] net/txgbe: add interrupt operation

2020-10-13 Thread Jiawen Wu
Add device interrupt handler and setup misx interrupt. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 2 + doc/guides/nics/txgbe.rst | 5 + drivers/net/txgbe/base/txgbe_type.h | 8 + drivers/net/txgbe/txgbe_ethdev.c| 467 drive

[dpdk-dev] [PATCH v3 12/56] net/txgbe: add info get operation

2020-10-13 Thread Jiawen Wu
Add device information get operation. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/base/txgbe_hw.c | 7 +- drivers/net/txgbe/base/txgbe_type.h | 2 + drivers/net/txgbe/meson.build | 1 + drivers/net/txgbe/txgbe_ethdev.c| 79 ++

[dpdk-dev] [PATCH v3 11/56] net/txgbe: add PHY reset

2020-10-13 Thread Jiawen Wu
Add phy reset function, support read and write phy registers. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 5 + drivers/net/txgbe/base/txgbe_phy.c | 226 + drivers/net/txgbe/base/txgbe_phy.h | 10 ++ 3 files changed, 241 insertions(+) diff --g

[dpdk-dev] [PATCH v3 10/56] net/txgbe: add module identify

2020-10-13 Thread Jiawen Wu
Add sfp anf qsfp module identify, i2c start and stop. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_eeprom.h | 1 + drivers/net/txgbe/base/txgbe_hw.c | 4 + drivers/net/txgbe/base/txgbe_phy.c| 588 +- drivers/net/txgbe/base/txgbe_phy.h| 12 +

[dpdk-dev] [PATCH v3 09/56] net/txgbe: add PHY init

2020-10-13 Thread Jiawen Wu
Add phy init functions, get phy type and identify. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/meson.build | 1 + drivers/net/txgbe/base/txgbe.h | 1 + drivers/net/txgbe/base/txgbe_hw.c | 50 + drivers/net/txgbe/base/txgbe_hw.h | 2 + drivers/net/txgbe/base/txgbe_phy

[dpdk-dev] [PATCH v3 07/56] net/txgbe: add EEPROM functions

2020-10-13 Thread Jiawen Wu
Add EEPROM functions. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/meson.build| 2 + drivers/net/txgbe/base/txgbe.h| 2 + drivers/net/txgbe/base/txgbe_eeprom.c | 581 ++ drivers/net/txgbe/base/txgbe_eeprom.h | 49 +++ drivers/net/txgbe/base/txgbe_h

[dpdk-dev] [PATCH v3 08/56] net/txgbe: add HW init and reset operation

2020-10-13 Thread Jiawen Wu
Add hardware init function adn reset operation in mac layer. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 255 drivers/net/txgbe/base/txgbe_hw.h | 6 +- drivers/net/txgbe/base/txgbe_type.h | 15 ++ drivers/net/txgbe/txgbe_ethdev.c| 35

[dpdk-dev] [PATCH v3 05/56] net/txgbe: add MAC type and bus lan id

2020-10-13 Thread Jiawen Wu
Add base driver shared code. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/meson.build | 4 +- drivers/net/txgbe/base/txgbe.h | 1 + drivers/net/txgbe/base/txgbe_hw.c | 134 + drivers/net/txgbe/base/txgbe_hw.h | 16 +++ drivers/net/txgbe/base/txgbe_ty

[dpdk-dev] [PATCH v3 06/56] net/txgbe: add HW infrastructure and dummy function

2020-10-13 Thread Jiawen Wu
Add hardware infrastructure and dummy function. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_dummy.h | 657 +++ drivers/net/txgbe/base/txgbe_hw.c| 13 + drivers/net/txgbe/base/txgbe_type.h | 187 +++- 3 files changed, 856 insertions(+), 1 deletion(-

[dpdk-dev] [PATCH v3 04/56] net/txgbe: add error types and registers

2020-10-13 Thread Jiawen Wu
Add error types and registers. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_regs.h | 1887 + drivers/net/txgbe/base/txgbe_status.h | 122 ++ 2 files changed, 2009 insertions(+) create mode 100644 drivers/net/txgbe/base/txgbe_regs.h create mode 100644 dri

[dpdk-dev] [PATCH v3 02/56] net/txgbe: add ethdev probe and remove

2020-10-13 Thread Jiawen Wu
Add basic PCIe ethdev probe and remove. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/meson.build| 18 + drivers/net/txgbe/base/txgbe.h| 10 +++ drivers/net/txgbe/base/txgbe_devids.h | 40 ++ drivers/net/txgbe/base/txgbe_type.h | 14 drivers/net/txgbe/mes

[dpdk-dev] [PATCH v3 03/56] net/txgbe: add device init and uninit

2020-10-13 Thread Jiawen Wu
Add basic init and uninit function, and some macro definitions prepare for hardware infrastructure. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_osdep.h | 181 +++ drivers/net/txgbe/base/txgbe_type.h | 20 +++ drivers/net/txgbe/txgbe_ethdev.c | 102

[dpdk-dev] [PATCH v3 00/56] net: txgbe PMD

2020-10-13 Thread Jiawen Wu
v3: Merge some recent changes in the main repo, fix the checkpatch warnings. v2: Re-order patches and fix some known problems. v1: Introduce txgbe PMD. Jiawen Wu (56): net/txgbe: add build and doc infrastructure net/txgbe: add ethdev probe and remove net/txgbe: add device init and uninit

[dpdk-dev] [PATCH v3 01/56] net/txgbe: add build and doc infrastructure

2020-10-13 Thread Jiawen Wu
Adding bare minimum PMD library and doc build infrastructure and claim the maintainership for txgbe PMD. Signed-off-by: Jiawen Wu --- MAINTAINERS | 7 ++ doc/guides/nics/features/txgbe.ini | 11 + doc/guides/nics/txgbe.rst |

[dpdk-dev] [PATCH v2] doc: remove aes-gcm addition of j0 deprecation notice

2020-10-13 Thread Arek Kusztal
This patch removes information about deprecation of AES-GCM/GMAC API for IV without J0. J0 was added with the following patch: - cryptodev: add an option to support both iv and J0 for GCM [1] [1] (http://patchwork.dpdk.org/patch/52886/) Signed-off-by: Arek Kusztal --- v2: - added reference to th

Re: [dpdk-dev] [PATCH v5 07/10] net/i40e: implement power management API

2020-10-13 Thread Guo, Jia
> -Original Message- > From: Burakov, Anatoly > Sent: Saturday, October 10, 2020 12:02 AM > To: dev@dpdk.org > Cc: Ma, Liang J ; Xing, Beilei ; > Guo, Jia ; Hunt, David ; > Ananyev, Konstantin ; > jerinjac...@gmail.com; Richardson, Bruce ; > tho...@monjalon.net; McDaniel, Timothy ; > Ead

Re: [dpdk-dev] [PATCH v5 04/10] ethdev: add simple power management API

2020-10-13 Thread Guo, Jia
> -Original Message- > From: dev On Behalf Of Anatoly Burakov > Sent: Saturday, October 10, 2020 12:02 AM > To: dev@dpdk.org > Cc: Ma, Liang J ; Thomas Monjalon > ; Yigit, Ferruh ; Andrew > Rybchenko ; Ray Kinsella > ; Neil Horman ; Hunt, David > ; Ananyev, Konstantin > ; jerinjac...@gma

Re: [dpdk-dev] [PATCH] gso: fix free issue of mbuf gso segments attach to

2020-10-13 Thread yang_y_yi
I think it isn't a good idea to free it in rte_gso_segment, maybe application will continue to use this pkt for other purpose, rte_gso_segment can't make decision for application without any notice, it is better to return this decision right backt to application. At 2020-10-

[dpdk-dev] [RFC v2 2/2] doc: announce queue stats moving to xstats

2020-10-13 Thread Ferruh Yigit
Queue stats will be removed from basic stats to xstats. It will be PMDs responsibility to fill queue stats based on number of queues they have. Until all PMDs implement the xstats, a temporary 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' device flag created. PMDs switched to the xstats should clear this f

[dpdk-dev] [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue xstats

2020-10-13 Thread Ferruh Yigit
Queue stats are stored in 'struct rte_eth_stats' as array and array size is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag. As a result of technical board discussion, decided to remove the queue statistics from 'struct rte_eth_stats' in the long term. Instead PMDs should represent the

Re: [dpdk-dev] [PATCH v5 12/17] net/virtio: add checks for max SIMD bitwidth

2020-10-13 Thread Xia, Chenbo
> -Original Message- > From: Power, Ciara > Sent: Tuesday, October 13, 2020 7:05 PM > To: dev@dpdk.org > Cc: vikto...@rehivetech.com; ruifeng.w...@arm.com; jer...@marvell.com; > d...@linux.vnet.ibm.com; Richardson, Bruce ; > Ananyev, Konstantin ; Power, Ciara > ; Maxime Coquelin ; Xia, > C

Re: [dpdk-dev] [PATCH v6] eal: add cache-line demote support

2020-10-13 Thread Ruifeng Wang
> -Original Message- > From: Bruce Richardson > Sent: Wednesday, October 14, 2020 12:20 AM > To: Ruifeng Wang > Cc: Omkar Maslekar ; dev@dpdk.org; > ciara.lof...@intel.com; d...@linux.vnet.ibm.com; jer...@marvell.com; > Honnappa Nagarahalli ; nd > Subject: Re: [PATCH v6] eal: add cache

Re: [dpdk-dev] [PATCH] net/bnx2x: fix to add QLogic vendor id

2020-10-13 Thread Ajit Khaparde
On Tue, Oct 13, 2020 at 1:43 PM Ferruh Yigit wrote: > > On 10/13/2020 7:28 PM, Jerin Jacob wrote: > > On Tue, Oct 13, 2020 at 4:18 AM Rasesh Mody wrote: > >> > >> Add QLogic vendor id support for BCM57840 device ids. > >> > >> Fixes: 9fb557035d90 ("bnx2x: enable PMD build") > >> Cc: sta...@dpdk.o

Re: [dpdk-dev] [PATCH] gso: fix free issue of mbuf gso segments attach to

2020-10-13 Thread Hu, Jiayu
> -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, October 13, 2020 11:39 PM > To: Hu, Jiayu ; yang_y...@163.com; dev@dpdk.org > Cc: mark.b.kavan...@intel.com; olivier.m...@6wind.com; > tho...@monjalon.net; yangy...@inspur.com > Subject: RE: [PATCH] gso: fix free issue of

Re: [dpdk-dev] FW: [SPDK] Re: Potential defect in pci_unplug()

2020-10-13 Thread Harris, James R
On 10/12/20, 9:31 PM, "Niu, Yawei" wrote: Thanks a lot for the reply, Gaetan! So seems we have to explicitly use failsafe PMD to deal with this re-plug case? I'm not quite sure if that'll cooperate with current SPDK hotplug code seamlessly. I think it would be great if SPDK/DPDK

Re: [dpdk-dev] [RFC 1/2] ethdev: move queue stats to xstats

2020-10-13 Thread Ferruh Yigit
On 10/12/2020 10:53 PM, Thomas Monjalon wrote: 12/10/2020 18:46, Ferruh Yigit: Queue stats are stored in 'struct rte_eth_stats' as array and array size is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag. As a result of technical board discussion, decided to remove the queue statistic

Re: [dpdk-dev] [RFC 1/2] ethdev: move queue stats to xstats

2020-10-13 Thread Ferruh Yigit
On 10/13/2020 10:16 AM, Andrew Rybchenko wrote: On 10/13/20 12:05 PM, Thomas Monjalon wrote: 13/10/2020 10:31, Andrew Rybchenko: On 10/13/20 12:53 AM, Thomas Monjalon wrote: 12/10/2020 18:46, Ferruh Yigit: Queue stats are stored in 'struct rte_eth_stats' as array and array size is defined by

Re: [dpdk-dev] [PATCH v5 1/6] ethdev: introduce Rx buffer split

2020-10-13 Thread Ferruh Yigit
On 10/13/2020 8:21 PM, Viacheslav Ovsiienko wrote: The DPDK datapath in the transmit direction is very flexible. An application can build the multi-segment packet and manages almost all data aspects - the memory pools where segments are allocated from, the segment lengths, the memory attributes l

Re: [dpdk-dev] [PATCH v4 07/14] acl: add infrastructure to support AVX512 classify

2020-10-13 Thread Ananyev, Konstantin
> On Tue, Oct 6, 2020 at 5:11 PM Konstantin Ananyev > wrote: > > diff --git a/config/x86/meson.build b/config/x86/meson.build > > index fea4d54035..724e69f4c4 100644 > > --- a/config/x86/meson.build > > +++ b/config/x86/meson.build > > @@ -22,7 +22,8 @@ foreach f:base_flags > > endforeach > > >

Re: [dpdk-dev] [RFC] ethdev: introduce Rx buffer split

2020-10-13 Thread Ferruh Yigit
On 10/12/2020 10:56 AM, Slava Ovsiienko wrote: Hi, Andrew Thank you for the comments. We have two approaches how to specify multiple segments to split Rx packets: 1. update queue configuration structure 2. introduce new rx_queue_setup_ex() routine with extra parameters. For [1] my only actual

Re: [dpdk-dev] [PATCH] net/failsafe: check correct error code while handling sub-device add

2020-10-13 Thread Long Li
>Subject: Re: [dpdk-dev] [PATCH] net/failsafe: check correct error code while >handling sub-device add > >On 09/10/20 20:30 +, Long Li wrote: >> >Subject: Re: [dpdk-dev] [PATCH] net/failsafe: check correct error >> >code while handling sub-device add >> > >> >On 05/10/20 11:42 +0200, Gaëtan Riv

Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-10-13 Thread Michel Machado
On 10/13/20 3:06 PM, Medvedkin, Vladimir wrote: On 13/10/2020 18:46, Michel Machado wrote: On 10/13/20 11:41 AM, Medvedkin, Vladimir wrote: Hi Michel, Could you please describe a condition when LPM gets inconsistent? As I can see if there is no free tbl8 it will return -ENOSPC.     Consid

Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-10-13 Thread Michel Machado
Hi Kevin, We do need fields max_rules and number_tbl8s of struct rte_lpm, so the removal would force us to have another patch to our local copy of DPDK. We'd rather avoid this new local patch because we wish to eventually be in sync with the stock DPDK. Those fields are needed in Gatek

Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-10-13 Thread Michel Machado
On 10/13/20 11:41 AM, Medvedkin, Vladimir wrote: Hi Michel, Could you please describe a condition when LPM gets inconsistent? As I can see if there is no free tbl8 it will return -ENOSPC. Consider this simple example, we need to add the following two prefixes with different next hops: 10.

Re: [dpdk-dev] [PATCH v5] pci/linux: copy new id for inserted device

2020-10-13 Thread Thomas Monjalon
13/10/2020 19:03, Jim Harris: > When a device is inserted into an existing BDF slot > that has not been probed, we must overwrite the old > PCI ID with the ID of the new function. Otherwise > we may not probe the function with the correct driver, > if at all. > > Signed-off-by: Jim Harris Applie

Re: [dpdk-dev] [PATCH] net/bnx2x: fix to add QLogic vendor id

2020-10-13 Thread Ferruh Yigit
On 10/13/2020 7:28 PM, Jerin Jacob wrote: On Tue, Oct 13, 2020 at 4:18 AM Rasesh Mody wrote: Add QLogic vendor id support for BCM57840 device ids. Fixes: 9fb557035d90 ("bnx2x: enable PMD build") Cc: sta...@dpdk.org Reported-by: Souvik Dey Signed-off-by: Rasesh Mody There was an error fr

Re: [dpdk-dev] [PATCH v7 1/2] ethdev: add flow shared action API

2020-10-13 Thread Andrey Vesnovaty
Hi Andrew. Thanks for the input. All spelling & rephrases will be applied PSB for the rest. Will publish v8 very soon. Thanks, Andrey > -Original Message- > From: Andrew Rybchenko > Sent: Monday, October 12, 2020 5:19 PM > To: Andrey Vesnovaty ; dev@dpdk.org > Cc: j...@marvell.com; jer

Re: [dpdk-dev] [PATCH v6 2/2] test/service: fix race condition on stopping lcore

2020-10-13 Thread David Marchand
Hello Harry, Long time no see :-) On Mon, Sep 21, 2020 at 4:51 PM David Marchand wrote: > > On Mon, Sep 14, 2020 at 4:30 PM Harry van Haaren > wrote: > > > > This commit fixes a potential race condition in the tests > > where the lcore running a service would increment a counter > > that was al

[dpdk-dev] [PATCH v5 5/6] app/testpmd: add rxoffs commands and parameters

2020-10-13 Thread Viacheslav Ovsiienko
Add command line parameter: --rxoffs=X[,Y] Sets the offsets of packet segments from the beginning of the receiving buffer if split feature is engaged. Affects only the queues configured with split offloads (currently BUFFER_SPLIT is supported only). Add interactive mode command, providing the sa

[dpdk-dev] [PATCH v5 2/6] app/testpmd: add multiple pools per core creation

2020-10-13 Thread Viacheslav Ovsiienko
The command line parameter --mbuf-size is updated, it can handle the multiple values like the following: --mbuf-size=2176,512,768,4096 specifying the creation the extra memory pools with the requested mbuf data buffer sizes. If some buffer split feature is engaged the extra memory pools can be us

[dpdk-dev] [PATCH v5 6/6] app/testpmd: add extended Rx queue setup

2020-10-13 Thread Viacheslav Ovsiienko
If Rx queue is configured with split feature the extended setup with specified segment sizes and pool will be performed. Signed-off-by: Viacheslav Ovsiienko --- app/test-pmd/cmdline.c | 12 ++-- app/test-pmd/testpmd.c | 48 ++-- app/test-pmd/te

[dpdk-dev] [PATCH v5 4/6] app/testpmd: add rxpkts commands and parameters

2020-10-13 Thread Viacheslav Ovsiienko
Add command line parameter: --rxpkts=X[,Y] Sets the length of segments to scatter packets on receiving if split feature is engaged. Affects only the queues configured with split offloads (currently BUFFER_SPLIT is supported only). Add interactive mode command: testpmd> set rxpkts (x[,y]*) Wher

[dpdk-dev] [PATCH v5 0/6] ethdev: introduce Rx buffer split

2020-10-13 Thread Viacheslav Ovsiienko
The DPDK datapath in the transmit direction is very flexible. An application can build the multi-segment packet and manages almost all data aspects - the memory pools where segments are allocated from, the segment lengths, the memory attributes like external buffers, registered for DMA, etc. In th

[dpdk-dev] [PATCH v5 3/6] app/testpmd: add buffer split offload configuration

2020-10-13 Thread Viacheslav Ovsiienko
This patch add support for RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT providing per queue configuration for this offload. Signed-off-by: Viacheslav Ovsiienko --- app/test-pmd/cmdline.c | 21 +++-- app/test-pmd/config.c | 9 + 2 files changed, 20 insertions(+), 10 deletions(-) dif

[dpdk-dev] [PATCH v5 1/6] ethdev: introduce Rx buffer split

2020-10-13 Thread Viacheslav Ovsiienko
The DPDK datapath in the transmit direction is very flexible. An application can build the multi-segment packet and manages almost all data aspects - the memory pools where segments are allocated from, the segment lengths, the memory attributes like external buffers, registered for DMA, etc. In th

Re: [dpdk-dev] [PATCH v2 2/2] eventdev: update app and examples for new eventdev ABI

2020-10-13 Thread Jerin Jacob
On Tue, Oct 13, 2020 at 12:39 AM Pavan Nikhilesh Bhagavatula wrote: > > >> Subject: [PATCH v2 2/2] eventdev: update app and examples for new > >eventdev ABI > >> > >> Several data structures and constants changed, or were added, > >> in the previous patch. This commit updates the dependent > >> a

Re: [dpdk-dev] [PATCH v4 07/14] acl: add infrastructure to support AVX512 classify

2020-10-13 Thread David Marchand
On Tue, Oct 6, 2020 at 5:11 PM Konstantin Ananyev wrote: > diff --git a/config/x86/meson.build b/config/x86/meson.build > index fea4d54035..724e69f4c4 100644 > --- a/config/x86/meson.build > +++ b/config/x86/meson.build > @@ -22,7 +22,8 @@ foreach f:base_flags > endforeach > > optional_flags = [

Re: [dpdk-dev] [PATCH v1] event/sw: performance improvements

2020-10-13 Thread Jerin Jacob
On Wed, Oct 7, 2020 at 4:22 PM Ananyev, Konstantin wrote: > > > On 10/6/2020 11:13 AM, Ananyev, Konstantin wrote: > > >>> -Original Message- > > >>> From: Jerin Jacob > > >>> Sent: Monday, October 5, 2020 5:35 PM > > >>> To: Nicolau, Radu > > >>> Cc: Honnappa Nagarahalli ; Richardson, >

Re: [dpdk-dev] [PATCH v2 4/4] app/eventdev: enable fast free offload

2020-10-13 Thread Jerin Jacob
On Sun, Oct 11, 2020 at 4:03 PM Jerin Jacob wrote: > > On Fri, Oct 9, 2020 at 12:20 AM Harman Kalra wrote: > > > > Since we are not holding the mbufs or creating any references > > in the app, hence mbuf fast free offload can be enabled. > > > > Signed-off-by: Harman Kalra > > --- > > app/test-

Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-10-13 Thread Medvedkin, Vladimir
On 13/10/2020 18:46, Michel Machado wrote: On 10/13/20 11:41 AM, Medvedkin, Vladimir wrote: Hi Michel, Could you please describe a condition when LPM gets inconsistent? As I can see if there is no free tbl8 it will return -ENOSPC.    Consider this simple example, we need to add the follo

  1   2   3   4   >