[dpdk-dev] [PATCH v3 08/56] net/txgbe: add HW init and reset operation

2020-10-13 Thread Jiawen Wu
Add hardware init function adn reset operation in mac layer. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 255 drivers/net/txgbe/base/txgbe_hw.h | 6 +- drivers/net/txgbe/base/txgbe_type.h | 15 ++ drivers/net/txgbe/txgbe_ethdev.c| 35

[dpdk-dev] [PATCH v3 07/56] net/txgbe: add EEPROM functions

2020-10-13 Thread Jiawen Wu
Add EEPROM functions. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/meson.build| 2 + drivers/net/txgbe/base/txgbe.h| 2 + drivers/net/txgbe/base/txgbe_eeprom.c | 581 ++ drivers/net/txgbe/base/txgbe_eeprom.h | 49 +++ drivers/net/txgbe/base/txgbe_h

[dpdk-dev] [PATCH v3 09/56] net/txgbe: add PHY init

2020-10-13 Thread Jiawen Wu
Add phy init functions, get phy type and identify. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/meson.build | 1 + drivers/net/txgbe/base/txgbe.h | 1 + drivers/net/txgbe/base/txgbe_hw.c | 50 + drivers/net/txgbe/base/txgbe_hw.h | 2 + drivers/net/txgbe/base/txgbe_phy

[dpdk-dev] [PATCH v3 10/56] net/txgbe: add module identify

2020-10-13 Thread Jiawen Wu
Add sfp anf qsfp module identify, i2c start and stop. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_eeprom.h | 1 + drivers/net/txgbe/base/txgbe_hw.c | 4 + drivers/net/txgbe/base/txgbe_phy.c| 588 +- drivers/net/txgbe/base/txgbe_phy.h| 12 +

[dpdk-dev] [PATCH v3 12/56] net/txgbe: add info get operation

2020-10-13 Thread Jiawen Wu
Add device information get operation. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/base/txgbe_hw.c | 7 +- drivers/net/txgbe/base/txgbe_type.h | 2 + drivers/net/txgbe/meson.build | 1 + drivers/net/txgbe/txgbe_ethdev.c| 79 ++

[dpdk-dev] [PATCH v3 11/56] net/txgbe: add PHY reset

2020-10-13 Thread Jiawen Wu
Add phy reset function, support read and write phy registers. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 5 + drivers/net/txgbe/base/txgbe_phy.c | 226 + drivers/net/txgbe/base/txgbe_phy.h | 10 ++ 3 files changed, 241 insertions(+) diff --g

[dpdk-dev] [PATCH v3 13/56] net/txgbe: add interrupt operation

2020-10-13 Thread Jiawen Wu
Add device interrupt handler and setup misx interrupt. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 2 + doc/guides/nics/txgbe.rst | 5 + drivers/net/txgbe/base/txgbe_type.h | 8 + drivers/net/txgbe/txgbe_ethdev.c| 467 drive

[dpdk-dev] [PATCH v3 14/56] net/txgbe: add device configure operation

2020-10-13 Thread Jiawen Wu
Add device configure operation. Signed-off-by: Jiawen Wu --- doc/guides/nics/txgbe.rst| 1 + drivers/net/txgbe/txgbe_ethdev.c | 195 +++ drivers/net/txgbe/txgbe_ethdev.h | 7 ++ 3 files changed, 203 insertions(+) diff --git a/doc/guides/nics/txgbe.rst b/d

[dpdk-dev] [PATCH v3 15/56] net/txgbe: add link status change

2020-10-13 Thread Jiawen Wu
Add ethdev link interrupt handler, MAC setup link and check link status and get capabilities. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_eeprom.h | 3 + drivers/net/txgbe/base/txgbe_hw.c | 498 +- drivers/net/txgbe/base/txgbe_hw.h | 15 + drivers

[dpdk-dev] [PATCH v3 17/56] net/txgbe: add autoc read and write

2020-10-13 Thread Jiawen Wu
Add autoc read and write for kr/kx/kx4/sfi link. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 2 + drivers/net/txgbe/base/txgbe_phy.c | 859 drivers/net/txgbe/base/txgbe_phy.h | 2 + drivers/net/txgbe/base/txgbe_type.h | 21 + 4 files cha

[dpdk-dev] [PATCH v3 16/56] net/txgbe: add multi-speed link setup

2020-10-13 Thread Jiawen Wu
Add multispeed fiber setup link and laser control. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 398 +- drivers/net/txgbe/base/txgbe_hw.h | 11 + 2 files changed, 408 insertions(+), 1 deletion(-) diff --git a/drivers/net/txgbe/base/txgbe_hw.c b/

[dpdk-dev] [PATCH v3 18/56] net/txgbe: add MAC address operations

2020-10-13 Thread Jiawen Wu
Add MAC address related operations. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini| 2 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/base/txgbe_eeprom.h | 2 + drivers/net/txgbe/base/txgbe_hw.c | 476 ++ drivers/net/txgbe/

[dpdk-dev] [PATCH v3 19/56] net/txgbe: add unicast hash bitmap

2020-10-13 Thread Jiawen Wu
Add unicast hash bitmap. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_type.h | 4 +- drivers/net/txgbe/txgbe_ethdev.c| 120 drivers/net/txgbe/txgbe_ethdev.h| 10 +++ 3 files changed, 133 insertions(+), 1 deletion(-) diff --git a/drivers/net/t

[dpdk-dev] [PATCH v3 20/56] net/txgbe: add Rx and Tx init

2020-10-13 Thread Jiawen Wu
Add receive and transmit initialize unit. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 4 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/base/txgbe_type.h | 2 + drivers/net/txgbe/txgbe_ethdev.h| 8 + drivers/net/txgbe/txgbe_rxtx.c | 338 +++

[dpdk-dev] [PATCH v3 21/56] net/txgbe: add Rx and Tx queues setup and release

2020-10-13 Thread Jiawen Wu
Add receive and transmit queues setup and release. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 4 + drivers/net/txgbe/txgbe_ethdev.h | 13 + drivers/net/txgbe/txgbe_rxtx.c | 510 +++ drivers/net/txgbe/txgbe_rxtx.h | 130 4 files cha

[dpdk-dev] [PATCH v3 22/56] net/txgbe: add Rx and Tx start and stop

2020-10-13 Thread Jiawen Wu
Add receive and transmit units start and stop for specified queue. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/base/txgbe_type.h | 3 + drivers/net/txgbe/txgbe_ethdev.c| 6 + drivers/net/txgbe/txgbe_ethdev.h| 15 ++ drivers/net/txgbe/t

[dpdk-dev] [PATCH v3 24/56] net/txgbe: fill simple transmit function

2020-10-13 Thread Jiawen Wu
Fill simple transmit function and define transmit descriptor. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_rxtx.c | 237 - drivers/net/txgbe/txgbe_rxtx.h | 84 +++- 2 files changed, 318 insertions(+), 3 deletions(-) diff --git a/drivers/net/txgbe

[dpdk-dev] [PATCH v3 23/56] net/txgbe: add packet type

2020-10-13 Thread Jiawen Wu
Add packet type marco definition and convert ptype to ptid. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/meson.build | 1 + drivers/net/txgbe/txgbe_ethdev.h | 1 + drivers/net/txgbe/txgbe_ptypes.

[dpdk-dev] [PATCH v3 25/56] net/txgbe: fill transmit function with hardware offload

2020-10-13 Thread Jiawen Wu
Fill transmit function with hardware offload. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 7 + doc/guides/nics/txgbe.rst | 3 + drivers/net/txgbe/txgbe_ethdev.c | 26 ++ drivers/net/txgbe/txgbe_ethdev.h | 6 + drivers/net/txgbe/txgbe_rxtx.c | 670 +++

[dpdk-dev] [PATCH v3 26/56] net/txgbe: fill Tx prepare function

2020-10-13 Thread Jiawen Wu
Fill transmit prepare function. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 1 + drivers/net/txgbe/txgbe_ethdev.h | 3 ++ drivers/net/txgbe/txgbe_rxtx.c | 61 3 files changed, 65 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.c

[dpdk-dev] [PATCH v3 28/56] net/txgbe: add device start operation

2020-10-13 Thread Jiawen Wu
Add device start operation with hardware start and reset. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_eeprom.h | 1 + drivers/net/txgbe/base/txgbe_hw.c | 346 ++ drivers/net/txgbe/base/txgbe_hw.h | 9 + drivers/net/txgbe/base/txgbe_type.h | 5

[dpdk-dev] [PATCH v3 29/56] net/txgbe: add Rx and Tx data path start and stop

2020-10-13 Thread Jiawen Wu
Add receive and transmit data path start and stop. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 142 ++ drivers/net/txgbe/base/txgbe_hw.h | 5 ++ 2 files changed, 147 insertions(+) diff --git a/drivers/net/txgbe/base/txgbe_hw.c b/drivers/net/tx

[dpdk-dev] [PATCH v3 27/56] net/txgbe: fill receive functions

2020-10-13 Thread Jiawen Wu
Fill receive functions and define receive descriptor. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + doc/guides/nics/txgbe.rst | 3 +- drivers/net/txgbe/base/txgbe_type.h | 2 + drivers/net/txgbe/txgbe_ethdev.c| 14 + drivers/net/txgbe/txgbe_ethdev.h

[dpdk-dev] [PATCH v3 30/56] net/txgbe: add device stop and close operations

2020-10-13 Thread Jiawen Wu
Add device stop, close and reset operations. And support hardware thermal sensor. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 69 ++ drivers/net/txgbe/base/txgbe_hw.h | 3 + drivers/net/txgbe/base/txgbe_type.h | 11 +++ drivers/net/txgbe/txgbe_ethdev.

[dpdk-dev] [PATCH v3 34/56] net/txgbe: add device xstats get

2020-10-13 Thread Jiawen Wu
Add device extended stats get from reading hardware registers. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/txgbe_ethdev.c | 378 + drivers/net/txgbe/txgbe_ethdev.h | 6 + 3 files changed, 385 insertions(+) diff --g

[dpdk-dev] [PATCH v3 31/56] net/txgbe: support Rx interrupt

2020-10-13 Thread Jiawen Wu
Support rx queue interrupt. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/txgbe_ethdev.c | 43 ++ 3 files changed, 45 insertions(+) diff --git a/doc/guides/nics/features/txgbe.in

[dpdk-dev] [PATCH v3 32/56] net/txgbe: add Rx and Tx queue info get

2020-10-13 Thread Jiawen Wu
Add Rx and Tx queue information get operation. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 2 + drivers/net/txgbe/txgbe_ethdev.h | 6 +++ drivers/net/txgbe/txgbe_rxtx.c | 77 3 files changed, 85 insertions(+) diff --git a/drivers/net/txgb

[dpdk-dev] [PATCH v3 35/56] net/txgbe: add queue stats mapping

2020-10-13 Thread Jiawen Wu
Add queue stats mapping set, and clear hardware counters. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/base/txgbe_hw.c | 118 + drivers/net/txgbe/base/txgbe_hw.h | 1 + drivers/net/txgbe/txgbe_ethdev.c | 55

[dpdk-dev] [PATCH v3 33/56] net/txgbe: add device stats get

2020-10-13 Thread Jiawen Wu
Add device stats get from reading hardware registers. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/base/txgbe_regs.h | 48 ++--- drivers/net/txgbe/base/txgbe_type.h | 155 drivers/net/tx

[dpdk-dev] [PATCH v3 38/56] net/txgbe: add PF module init and uninit for SRIOV

2020-10-13 Thread Jiawen Wu
Add PF module init and uninit operations with mailbox. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/base/meson.build | 1 + drivers/net/txgbe/base/txgbe.h | 1 + drivers/net/txgbe/base/txgbe_hw.c | 4 + drivers/net/txgbe/base/txgbe_mbx

[dpdk-dev] [PATCH v3 37/56] net/txgbe: add SWFW semaphore and lock

2020-10-13 Thread Jiawen Wu
Add semaphore between software and firmware. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_dummy.h | 2 +- drivers/net/txgbe/base/txgbe_eeprom.h | 8 ++ drivers/net/txgbe/base/txgbe_hw.c | 129 ++ drivers/net/txgbe/base/txgbe_hw.h | 5 + drivers

[dpdk-dev] [PATCH v3 36/56] net/txgbe: add VLAN handle support

2020-10-13 Thread Jiawen Wu
Add VLAN filter, tpid, offload and strip set support. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + doc/guides/nics/txgbe.rst | 3 +- drivers/net/txgbe/base/txgbe_hw.c | 31 +++ drivers/net/txgbe/base/txgbe_hw.h | 1 + drivers/net/txgbe/base/txgbe_t

[dpdk-dev] [PATCH v3 39/56] net/txgbe: add process mailbox operation

2020-10-13 Thread Jiawen Wu
Add check operation for vf function level reset, mailbox messages and ack from vf. Waiting to process the messages. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 5 + drivers/net/txgbe/base/txgbe_mbx.c | 303 +++ drivers/net/txgbe/base/txgbe_mbx.h | 83 +++- dr

[dpdk-dev] [PATCH v3 40/56] net/txgbe: add PF module configure for SRIOV

2020-10-13 Thread Jiawen Wu
Add PF module configure for SRIOV. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/base/txgbe_hw.c | 345 drivers/net/txgbe/base/txgbe_hw.h | 12 + drivers/net/txgbe/base/txgbe_type.h | 1 + drivers/net/txgbe/txgbe_e

[dpdk-dev] [PATCH v3 41/56] net/txgbe: add VMDq configure

2020-10-13 Thread Jiawen Wu
Add multiple queue setting with VMDq. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/txgbe_ethdev.c | 35 drivers/net/txgbe/txgbe_ethdev.h | 2 + drivers/net/txgbe/txgbe_rxtx.c | 260 + 4 files changed, 298 i

[dpdk-dev] [PATCH v3 42/56] net/txgbe: add RSS support

2020-10-13 Thread Jiawen Wu
Add RSS configure, support to RSS hash and reta operations for PF. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 3 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/meson.build | 2 + drivers/net/txgbe/txgbe_ethdev.c | 102 ++ drivers/net

[dpdk-dev] [PATCH v3 44/56] net/txgbe: add flow control support

2020-10-13 Thread Jiawen Wu
Add flow control support. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/base/txgbe_hw.c | 425 drivers/net/txgbe/base/txgbe_hw.h | 6 + drivers/net/txgbe/base/txgbe_type.

[dpdk-dev] [PATCH v3 43/56] net/txgbe: add DCB support

2020-10-13 Thread Jiawen Wu
Add DCB transmit and receive mode configurations, and allocate DCB packet buffer. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini| 1 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/base/meson.build| 2 + drivers/net/txgbe/base/txgbe.h| 1

[dpdk-dev] [PATCH v3 46/56] net/txgbe: add priority flow control support

2020-10-13 Thread Jiawen Wu
Add priority flow control support. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_dcb.c| 148 ++ drivers/net/txgbe/base/txgbe_dcb.h| 2 + drivers/net/txgbe/base/txgbe_dcb_hw.c | 73 + drivers/net/txgbe/txgbe_ethdev.c | 54 ++

[dpdk-dev] [PATCH v3 45/56] net/txgbe: add FC auto negotiation support

2020-10-13 Thread Jiawen Wu
Add flow control negotiation with link partner. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 200 ++ drivers/net/txgbe/base/txgbe_hw.h | 3 + 2 files changed, 203 insertions(+) diff --git a/drivers/net/txgbe/base/txgbe_hw.c b/drivers/net/txgbe/

[dpdk-dev] [PATCH v3 47/56] net/txgbe: add device promiscuous and allmulticast mode

2020-10-13 Thread Jiawen Wu
Add device promiscuous and allmulticast mode. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 2 + doc/guides/nics/txgbe.rst | 2 + drivers/net/txgbe/txgbe_ethdev.c | 63 ++ 3 files changed, 67 insertions(+) diff --git a/doc/guides/nics

[dpdk-dev] [PATCH v3 48/56] net/txgbe: add MTU set operation

2020-10-13 Thread Jiawen Wu
Add MTU set operation. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/base/txgbe_type.h | 2 ++ drivers/net/txgbe/txgbe_ethdev.c| 41 + 3 files changed, 44 insertions(+) diff --git a/doc/guides/nics/features/txgbe.ini

[dpdk-dev] [PATCH v3 49/56] net/txgbe: add FW version get operation

2020-10-13 Thread Jiawen Wu
Add firmware version get operation. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/txgbe_ethdev.c | 22 ++ 3 files changed, 24 insertions(+) diff --git a/doc/guides/nics/features/txgbe.in

[dpdk-dev] [PATCH v3 51/56] net/txgbe: add register dump support

2020-10-13 Thread Jiawen Wu
Add register dump support. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/base/txgbe_type.h | 1 + drivers/net/txgbe/txgbe_ethdev.c | 113 +++ drivers/net/txgbe/txgbe_regs_group.h | 54 + 4 files changed, 1

[dpdk-dev] [PATCH v3 50/56] net/txgbe: add EEPROM info get operation

2020-10-13 Thread Jiawen Wu
Add EEPROM information get related operations. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 2 + drivers/net/txgbe/base/txgbe_hw.c | 4 + drivers/net/txgbe/base/txgbe_phy.c | 16 drivers/net/txgbe/base/txgbe_phy.h | 3 + drivers/net/txgbe/txgbe_ethdev.c | 126

[dpdk-dev] [PATCH v3 55/56] net/txgbe: add DCB info get operation

2020-10-13 Thread Jiawen Wu
Add DCB information get operation. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 91 1 file changed, 91 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index ddf92f1bd..77292f07f 100644 --- a/drive

[dpdk-dev] [PATCH v3 56/56] net/txgbe: add Rx and Tx descriptor status

2020-10-13 Thread Jiawen Wu
Supports check the status of Rx and Tx descriptors. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 2 + drivers/net/txgbe/txgbe_ethdev.c | 5 + drivers/net/txgbe/txgbe_ethdev.h | 8 ++ drivers/net/txgbe/txgbe_rxtx.c | 180 + drivers/ne

[dpdk-dev] [PATCH v3 52/56] net/txgbe: support device LED on and off

2020-10-13 Thread Jiawen Wu
Support device LED on and off. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 46 +++ drivers/net/txgbe/base/txgbe_hw.h | 3 ++ drivers/net/txgbe/txgbe_ethdev.c | 20 ++ 3 files changed, 69 insertions(+) diff --git a/drivers/net/txgbe/

[dpdk-dev] [PATCH v3 54/56] net/txgbe: add PTP support

2020-10-13 Thread Jiawen Wu
Add PTP support. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/txgbe_ethdev.c | 234 + drivers/net/txgbe/txgbe_ethdev.h | 22 +++ drivers/net/txgbe/txgbe_rxtx.c | 32 +++

[dpdk-dev] [PATCH v3 53/56] net/txgbe: add mirror rule operations

2020-10-13 Thread Jiawen Wu
Add mirror rule set and reset operations. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/txgbe_ethdev.c | 186 + drivers/net/txgbe/txgbe_ethdev.h | 1 + 3 files changed, 188 insertions(+) diff --git a/doc/guides/nics/

Re: [dpdk-dev] [PATCH v4] RSS key use with testpmd

2020-10-13 Thread oulijun
在 2020/10/10 2:52, Ferruh Yigit 写道: On 10/9/2020 1:09 PM, oulijun wrote: 在 2020/9/30 21:17, Ferruh Yigit 写道: On 9/24/2020 2:45 PM, Lijun Ou wrote: Consider the follow usage with testpmd: 1. first, startup testpmd: testpmd> show port 0 rss-hash key RSS functions: all ipv4-frag ipv4-other

Re: [dpdk-dev] [PATCH] ethdev: unify error code if port ID is invalid

2020-10-13 Thread Andrew Rybchenko
On 10/13/20 7:12 PM, Ferruh Yigit wrote: > On 10/13/2020 4:39 PM, Andrew Rybchenko wrote: >> On 10/13/20 6:32 PM, Ferruh Yigit wrote: >>> On 10/13/2020 3:53 PM, Andrew Rybchenko wrote: Use ENODEV as the error code if specified port ID is invalid. Signed-off-by: Andrew Rybchenko

Re: [dpdk-dev] [RFC PATCH v2 3/6] build: automatic NUMA and cpu counts detection

2020-10-13 Thread Juraj Linkeš
> -Original Message- > From: Bruce Richardson > Sent: Tuesday, October 13, 2020 5:48 PM > To: Juraj Linkeš > Cc: ruifeng.w...@arm.com; honnappa.nagaraha...@arm.com; > phil.y...@arm.com; vcchu...@amazon.com; dharmik.thak...@arm.com; > jerinjac...@gmail.com; hemant.agra...@nxp.com; dev@dp

Re: [dpdk-dev] [RFC] ethdev: unify prefix for static function and variables

2020-10-13 Thread Andrew Rybchenko
On 10/13/20 7:56 PM, Ferruh Yigit wrote: > Prefix static function and variables with 'eth_dev'. > > For some 'rte_' prefix dropped, and for others 'eth_dev' added. > This is useful to differentiate public and static function/variables. > > The cleanup is good to for having consistent naming to he

Re: [dpdk-dev] [PATCH] net/bnx2x: fix to add QLogic vendor id

2020-10-13 Thread Jerin Jacob
On Wed, Oct 14, 2020 at 3:07 AM Ajit Khaparde wrote: > > On Tue, Oct 13, 2020 at 1:43 PM Ferruh Yigit wrote: > > > > On 10/13/2020 7:28 PM, Jerin Jacob wrote: > > > On Tue, Oct 13, 2020 at 4:18 AM Rasesh Mody wrote: > > >> > > >> Add QLogic vendor id support for BCM57840 device ids. > > >> > > >

Re: [dpdk-dev] [PATCH v7 1/2] ethdev: add flow shared action API

2020-10-13 Thread Andrew Rybchenko
Hi Andrey, On 10/13/20 11:06 PM, Andrey Vesnovaty wrote: > Hi Andrew. > > Thanks for the input. > All spelling & rephrases will be applied PSB for the rest. > Will publish v8 very soon. > > Thanks, > Andrey > >> -Original Message- >> From: Andrew Rybchenko >> Sent: Monday, October 12,

Re: [dpdk-dev] [PATCH 2/2] build: find max lcore programmatically

2020-10-13 Thread Juraj Linkeš
Hi Dharmik, > -Original Message- > From: Dharmik Thakkar > Sent: Tuesday, October 13, 2020 5:15 PM > To: Juraj Linkeš > Cc: tho...@monjalon.net; dev@dpdk.org; Stephen Hemminger > ; Jerin Jacob ; nd > > Subject: Re: [dpdk-dev] [PATCH 2/2] build: find max lcore programmatically > > Hi Ju

Re: [dpdk-dev] [PATCH 1/3 v3] ethdev: add rx offload to drop error packets

2020-10-13 Thread Andrew Rybchenko
On 10/12/20 3:22 PM, Andrew Rybchenko wrote: > On 10/12/20 2:30 PM, Nipun Gupta wrote: >>> -Original Message- >>> From: Andrew Rybchenko >>> Sent: Monday, October 12, 2020 1:32 PM >>> To: Nipun Gupta ; dev@dpdk.org >>> Cc: tho...@monjalon.net; ferruh.yi...@intel.com; arybche...@solarflare.

Re: [dpdk-dev] [PATCH 1/3 v3] ethdev: add rx offload to drop error packets

2020-10-13 Thread Nipun Gupta
Hi Thomas and Jerin, There seems two views: 1. Use of existing rx_offload_capa, to have additional error packet drop offload capabilities. This is showcased in v2, and also suggested by Thomas. 2. Adding additional offload capability flag types and configuration structure for error packet drop c

Re: [dpdk-dev] [PATCH] gso: fix free issue of mbuf gso segments attach to

2020-10-13 Thread Hu, Jiayu
> -Original Message- > From: yang_y...@163.com > Sent: Saturday, October 10, 2020 11:10 AM > To: dev@dpdk.org > Cc: Hu, Jiayu ; mark.b.kavan...@intel.com; Ananyev, > Konstantin ; olivier.m...@6wind.com; > tho...@monjalon.net; yangy...@inspur.com; yang_y...@163.com > Subject: [PATCH] gso

Re: [dpdk-dev] [PATCH 1/3 v3] ethdev: add rx offload to drop error packets

2020-10-13 Thread Nipun Gupta
> -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, October 13, 2020 12:52 PM > To: Nipun Gupta ; dev@dpdk.org > Cc: tho...@monjalon.net; ferruh.yi...@intel.com; Hemant Agrawal > ; Sachin Saxena ; Rohit > Raj ; jerinjac...@gmail.com; > step...@networkplumber.org; as...@nvidia.

Re: [dpdk-dev] [PATCH 1/3 v3] ethdev: add rx offload to drop error packets

2020-10-13 Thread Andrew Rybchenko
On 10/13/20 10:36 AM, Nipun Gupta wrote: > > >> -Original Message- >> From: Andrew Rybchenko >> Sent: Tuesday, October 13, 2020 12:52 PM >> To: Nipun Gupta ; dev@dpdk.org >> Cc: tho...@monjalon.net; ferruh.yi...@intel.com; Hemant Agrawal >> ; Sachin Saxena ; Rohit >> Raj ; jerinjac...@gm

Re: [dpdk-dev] [PATCH v2] net/ice: refactor RSS config for potential bugs

2020-10-13 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Junfeng > Sent: Tuesday, October 13, 2020 2:26 PM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; Guo, Junfeng > Subject: [PATCH v2] net/ice: refactor RSS config for potential bugs Renamed to refactor RSS config wrap and fix pot

Re: [dpdk-dev] [PATCH v2] mem: fix allocation failure on non-NUMA kernel

2020-10-13 Thread Nicolas Dichtel
Le 12/10/2020 à 21:28, Nick Connolly a écrit : > Running dpdk-helloworld on Linux with lib numa present, > but no kernel support for NUMA (CONFIG_NUMA=n) causes > ret_service_init() to fail with EAL: error allocating > rte services array. > > alloc_seg() calls get_mempolicy to verify that the allo

Re: [dpdk-dev] [PATCH v4] ethdev: check if queue setup in queue-related APIs

2020-10-13 Thread Andrew Rybchenko
On 10/13/20 5:41 AM, Wei Hu (Xavier) wrote: > From: Chengchang Tang > > This patch adds checking whether the related Tx or Rx queue has been setup "This patch adds checking" -> "Add checking" > in the queue-related API functions to avoid illegal address access. And > validity check of the queue

Re: [dpdk-dev] [PATCH v5 02/11] ethdev: add IPv6 fragment extension header item

2020-10-13 Thread Dekel Peled
Yes, thanks. > -Original Message- > From: Thomas Monjalon > Sent: Monday, October 12, 2020 11:50 PM > To: Dekel Peled > Cc: Ori Kam ; ferruh.yi...@intel.com; > arybche...@solarflare.com; konstantin.anan...@intel.com; > olivier.m...@6wind.com; wenzhuo...@intel.com; beilei.x...@intel.com;

Re: [dpdk-dev] [PATCH 1/3 v3] ethdev: add rx offload to drop error packets

2020-10-13 Thread Nipun Gupta
> -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, October 13, 2020 1:21 PM > To: Nipun Gupta ; dev@dpdk.org > Cc: tho...@monjalon.net; ferruh.yi...@intel.com; Hemant Agrawal > ; Sachin Saxena ; Rohit > Raj ; jerinjac...@gmail.com; > step...@networkplumber.org; as...@nvidia.c

[dpdk-dev] [PATCH v2 03/10] net/mlx5: add the validate sample action

2020-10-13 Thread Jiawei Wang
Add sample action validate function. Sample Flow is supported in NIC-RX and FDB domains. For the NIC-RX the Sample Flow action list must include the destination queue action. Only NIC-RX domain supports the optional actions list. FDB doesn't support any optional actions, the sampled packets is al

[dpdk-dev] [PATCH v2 01/10] common/mlx5: glue for sample action

2020-10-13 Thread Jiawei Wang
The new DR sample action is supported since OFED version 5.1.2 or rdma-core version v32. MLX5 PMD adds the rdma-core command in glue to create this action. Sample action is used for creating the sample object to implement the sampling/mirroring function. Signed-off-by: Jiawei Wang Acked-by: Via

[dpdk-dev] [PATCH v2 07/10] net/mlx5: update validation for mirroring flow

2020-10-13 Thread Jiawei Wang
Mirroring flow using sample action with ratio is 1, and it doesn't support jump action with the same one flow. Sample action must have destination actions like port or queue for mirroring, and don't need split function as sampling flow. Signed-off-by: Jiawei Wang Acked-by: Viacheslav Ovsiienko

[dpdk-dev] [PATCH v2 09/10] doc: add the sample flow limitation description

2020-10-13 Thread Jiawei Wang
Add description about the sample flow limitation. Sample Flow supports in NIC-Rx and E-Switch domains. Due to Metadata register c0 is deleted while doing the loopback, so that only support forward the sampling packet into E-Switch manager port, no additional action support in sample flow. Signed-o

[dpdk-dev] [PATCH v2 02/10] common/mlx5: query sampler object capability via DevX

2020-10-13 Thread Jiawei Wang
Update function mlx5_devx_cmd_query_hca_attr() to add the NIC Flow Table attributes query, then get the log_max_flow_sampler_num from flow table properties. Add the related structs definition in mlx5_prm.h. Signed-off-by: Jiawei Wang Acked-by: Ori Kam Acked-by: Viacheslav Ovsiienko --- driver

[dpdk-dev] [PATCH v2 08/10] net/mlx5: update translate function for mirror

2020-10-13 Thread Jiawei Wang
Translate the attribute of sample action that include sample ratio and sub actions list. PMD will check the destination action number in current flow, if found multiple destination actions, then create the new destination array rdma action that group actions for each destination. Currently only sup

[dpdk-dev] [PATCH v2 06/10] common/mlx5: add glue function for mirroring

2020-10-13 Thread Jiawei Wang
The new DR destination array action is supported since the rdma-core version v32. Destination array action is used group DR actions to a single action, And it can be used for mirroring packet and forward to every destination (port or queue) in the array. Signed-off-by: Jiawei Wang Acked-by: Viac

[dpdk-dev] [PATCH v2 00/10] Add sampling and mirroring support in MLX5 PMD

2020-10-13 Thread Jiawei Wang
This patch set implement the flow sampling and mirroring for mlx5 driver. MLX5 PMD driver will be responsible for validate and translate the sample action while creating a flow. Depends-on: series-12828 ("support the flow-based traffic sampling") v2: * Fix incorrect check for E-Switch sample spl

[dpdk-dev] [PATCH v2 10/10] doc: update offload dependencies document

2020-10-13 Thread Jiawei Wang
Add the offloads minimum versions for new sampling feature. Signed-off-by: Jiawei Wang Reviewed-by: Asaf Penso --- doc/guides/nics/mlx5.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 166310f..8d567e1 100644 --- a/doc/guides

[dpdk-dev] [PATCH v2 05/10] net/mlx5: update translate function for sample action

2020-10-13 Thread Jiawei Wang
Translate the attribute of sample action that include sample ratio and sub actions list, then create the sample DR action. The metadata register value will be lost in the default path after Sampler in FDB due to CX5 HW limitation. Since source vport also be shared with metadata register c0, MLX5

[dpdk-dev] [PATCH v2 04/10] net/mlx5: split sample flow into two sub flows

2020-10-13 Thread Jiawei Wang
The flow with sample action will be splited into two sub flows: the prefix sub flow with the all actions preceding the sample action and sample action itself, and the suffix sub flow with the actions following the sample action. The original items remain in the prefix sub flow, add the implicit ta

Re: [dpdk-dev] [PATCH v5 01/11] ethdev: add extensions attributes to IPv6 item

2020-10-13 Thread Dekel Peled
Thanks, PSB. > -Original Message- > From: Thomas Monjalon > Sent: Monday, October 12, 2020 11:42 PM > To: Ori Kam ; Dekel Peled > Cc: ferruh.yi...@intel.com; arybche...@solarflare.com; > konstantin.anan...@intel.com; olivier.m...@6wind.com; > wenzhuo...@intel.com; beilei.x...@intel.com;

[dpdk-dev] [PATCH v8] net/iavf: support flex desc metadata extraction

2020-10-13 Thread Jeff Guo
Enable metadata extraction for flexible descriptors in AVF, that would allow network function directly get metadata without additional parsing which would reduce the CPU cost for VFs. The enabling metadata extractions involve the metadata of VLAN/IPv4/IPv6/IPv6-FLOW/TCP/MPLS flexible descriptors, a

Re: [dpdk-dev] [PATCH v4] ethdev: check if queue setup in queue-related APIs

2020-10-13 Thread Kalesh Anakkur Purayil
Hi Xavier, Thanks for taking care of the comments. LGTM. Reviewed-by: Kalesh AP Regards, Kalesh On Tue, Oct 13, 2020 at 8:11 AM Wei Hu (Xavier) wrote: > From: Chengchang Tang > > This patch adds checking whether the related Tx or Rx queue has been setup > in the queue-related API functions

Re: [dpdk-dev] [RFC 1/2] ethdev: move queue stats to xstats

2020-10-13 Thread Andrew Rybchenko
On 10/13/20 12:53 AM, Thomas Monjalon wrote: > 12/10/2020 18:46, Ferruh Yigit: >> Queue stats are stored in 'struct rte_eth_stats' as array and array size >> is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag. >> >> As a result of technical board discussion, decided to remove the queue >

Re: [dpdk-dev] [PATCH v3] pci/linux: copy new id for inserted device

2020-10-13 Thread Thomas Monjalon
13/10/2020 00:01, Jim Harris: > When a device is inserted into an existing BDF slot > that has not been probed, we must overwrite the old > PCI ID with the ID of the new function. Otherwise > we may not probe the function with the correct driver, > if at all. > > Signed-off-by: Jim Harris > --- >

Re: [dpdk-dev] [PATCH v4 3/3] ethdev: allow close function to return an error

2020-10-13 Thread Andrew Rybchenko
On 10/6/20 1:57 PM, Thomas Monjalon wrote: > 06/10/2020 11:43, Ferruh Yigit: >> On 10/5/2020 6:08 PM, Thomas Monjalon wrote: >>> The API function rte_eth_dev_close() was returning void. >>> The return type is changed to int for notifying of errors. >>> >>> If an error happens during a close operati

[dpdk-dev] [PATCH v4] support both PIO and MMIO bar for virtio pci device

2020-10-13 Thread 谢华伟(此时此刻)
From: "huawei.xhw" v2 changes: - add more explanation in the commit message v3 changes: - fix patch format issues v4 changes: - fixes for RTE_KDRV_UIO_GENERIC -> RTE_PCI_KDRV_UIO_GENERIC huawei.xhw (1): pci: support both PIO and MMIO BAR for legacy virtio on x86

[dpdk-dev] [PATCH v4] pci: support both PIO and MMIO BAR for legacy virtio on x86

2020-10-13 Thread 谢华伟(此时此刻)
From: "huawei.xhw" Legacy virtio-pci only supports PIO BAR resource. As we need to create lots of virtio devices and PIO resource on x86 is very limited, we expose MMIO BAR. Kernel supports both PIO and MMIO BAR for legacy virtio-pci device. We handles different type of BAR in the similar way.

Re: [dpdk-dev] [PATCH v3] net/hinic: fix secondary process's using coredump.

2020-10-13 Thread Ferruh Yigit
On 10/9/2020 8:47 AM, l00283554 wrote: fix coredump when secondary process using the hinic port. the reason is that during the stage of secondary process port initialization, it lack the initialization of "eth_dev->dev_ops". Signed-off-by: Qingqing Li --- v3: update the signed-off information.

Re: [dpdk-dev] [PATCH] net/af_xdp: Don't allow umem sharing for xsks with same netdev, qid

2020-10-13 Thread Ferruh Yigit
On 10/8/2020 10:17 AM, Ciara Loftus wrote: Supporting this would require locks, which would impact the performance of the more typical cases - xsks with different qids and netdevs. Signed-off-by: Ciara Loftus Fixes: 74b46340e2d4 ("net/af_xdp: support shared UMEM") Hi Ciara, 'check-git-log.sh

Re: [dpdk-dev] [PATCH v4 1/2] ethdev: support query of AGE action

2020-10-13 Thread Andrew Rybchenko
On 10/7/20 4:28 PM, Dekel Peled wrote: > Existing API supports AGE action to monitor the aging of a flow. > This patch implements RFC [1], introducing the response format for query > of an AGE action. > Application will be able to query the AGE action state. > The response will be returned in the f

Re: [dpdk-dev] [PATCH v4 3/3] ethdev: allow close function to return an error

2020-10-13 Thread Thomas Monjalon
13/10/2020 10:40, Andrew Rybchenko: > On 10/6/20 1:57 PM, Thomas Monjalon wrote: > > 06/10/2020 11:43, Ferruh Yigit: > >> On 10/5/2020 6:08 PM, Thomas Monjalon wrote: > >>> The API function rte_eth_dev_close() was returning void. > >>> The return type is changed to int for notifying of errors. > >>

Re: [dpdk-dev] [PATCH v12 0/5] eal: add WC store functions

2020-10-13 Thread Ferruh Yigit
On 10/8/2020 8:28 AM, David Marchand wrote: On Wed, Sep 23, 2020 at 4:23 PM Radu Nicolau wrote: Implement 2 new functions that will enable write combining stores depending on architecture. The functions are provided as a generic stub and a x86 specific implementation. The reason to implement

Re: [dpdk-dev] [RFC 1/2] ethdev: move queue stats to xstats

2020-10-13 Thread Thomas Monjalon
13/10/2020 10:31, Andrew Rybchenko: > On 10/13/20 12:53 AM, Thomas Monjalon wrote: > > 12/10/2020 18:46, Ferruh Yigit: > >> Queue stats are stored in 'struct rte_eth_stats' as array and array size > >> is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag. > >> > >> As a result of technical

Re: [dpdk-dev] [PATCH v5 1/2] net: add run-time architecture specific CRC selection

2020-10-13 Thread Bruce Richardson
On Fri, Oct 09, 2020 at 02:50:44PM +0100, Mairtin o Loingsigh wrote: > This patch adds support for run-time selection of the optimal > architecture-specific CRC path, based on the supported instruction set(s) > of the CPU. > > The compiler option checks have been moved from the C files to the meso

Re: [dpdk-dev] [PATCH] net/mlx5: add debug print of LRO minimal size

2020-10-13 Thread Matan Azrad
From: Dekel Peled > Add debug printout showing HCA capability lro_min_mss_size - the minimal > size of TCP segment required for coalescing. > MLX5 PMD documentation is updated to note this condition. > > Signed-off-by: Dekel Peled Acked-by: Matan Azrad

Re: [dpdk-dev] [RFC 1/2] ethdev: move queue stats to xstats

2020-10-13 Thread Andrew Rybchenko
On 10/13/20 12:05 PM, Thomas Monjalon wrote: > 13/10/2020 10:31, Andrew Rybchenko: >> On 10/13/20 12:53 AM, Thomas Monjalon wrote: >>> 12/10/2020 18:46, Ferruh Yigit: Queue stats are stored in 'struct rte_eth_stats' as array and array size is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compi

Re: [dpdk-dev] [PATCH v4 00/17] Replace terms master/slave

2020-10-13 Thread David Marchand
On Fri, Oct 9, 2020 at 11:56 PM Stephen Hemminger wrote: > There a some minor whitespace issues (from checkpatch) which will get fixed in > next version. Travis reported: https://travis-ci.com/github/ovsrobot/dpdk/builds/189130545 - pipeline example is broken, missed during rebase: ../examples/p

Re: [dpdk-dev] [PATCH v4 3/3] ethdev: allow close function to return an error

2020-10-13 Thread Ferruh Yigit
On 10/13/2020 9:55 AM, Thomas Monjalon wrote: <...> dev = &rte_eth_devices[port_id]; - RTE_FUNC_PTR_OR_RET(*dev->dev_ops->dev_close); - (*dev->dev_ops->dev_close)(dev); + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_close, -ENOTSUP); + *lasterr = (*dev->dev_ops->dev

Re: [dpdk-dev] [PATCH v2] mem: fix allocation failure on non-NUMA kernel

2020-10-13 Thread Burakov, Anatoly
On 12-Oct-20 8:22 PM, Nick Connolly wrote: Running dpdk-helloworld on Linux with lib numa present, but no kernel support for NUMA (CONFIG_NUMA=n) causes ret_service_init() to fail with EAL: error allocating rte services array. alloc_seg() calls get_mempolicy to verify that the allocation has hap

Re: [dpdk-dev] [PATCH v4 02/10] eal: add power management intrinsics

2020-10-13 Thread Burakov, Anatoly
On 12-Oct-20 2:13 PM, Burakov, Anatoly wrote: On 12-Oct-20 1:50 PM, Ananyev, Konstantin wrote: Add two new power management intrinsics, and provide an implementation in eal/x86 based on UMONITOR/UMWAIT instructions. The instructions are implemented as raw byte opcodes because there is not

[dpdk-dev] [PATCH v5 0/3] cleanup ethdev close operation

2020-10-13 Thread Thomas Monjalon
Most of the patches from the v3 have been merged already. The remaining 3 patches are reworked in this v4: - reset dev_started in some PMDs - selectively reset pointers in rte_eth_dev_release_port() - fix error handling v5: change error code to ENODEV if wrong port id Thomas Monjalon (3):

  1   2   3   4   >