Re: [dpdk-dev] [PATCH] net/iavf: fix adding multicast MAC address

2020-10-14 Thread Sun, GuinanX
Hi Beilei > -Original Message- > From: Xing, Beilei > Sent: Thursday, October 15, 2020 2:44 PM > To: Sun, GuinanX ; Peng, Yuan > ; dev@dpdk.org > Cc: Wu, Jingjing ; Zhang, Qi Z > Subject: RE: [dpdk-dev] [PATCH] net/iavf: fix adding multicast MAC address > > > > > -Original Message

Re: [dpdk-dev] [PATCH] net/iavf: fix adding multicast MAC address

2020-10-14 Thread Xing, Beilei
> -Original Message- > From: Sun, GuinanX > Sent: Thursday, October 15, 2020 1:57 PM > To: Xing, Beilei ; Peng, Yuan ; > dev@dpdk.org > Cc: Wu, Jingjing ; Zhang, Qi Z > Subject: RE: [dpdk-dev] [PATCH] net/iavf: fix adding multicast MAC address > > Hi beilei > > > -Original Messag

[dpdk-dev] [PATCH 4/4] net/mlx5/linux: fix Tx queue operations decision

2020-10-14 Thread Matan Azrad
One of the conditions to create Tx queue object by DevX is to be sure that the DPDK mlx5 driver is not going to be the E-Switch manager of the device. The issue is with the default FDB flows managed by the kernel driver, which are not created by the kernel when the Tx queues are created by DevX. T

[dpdk-dev] [PATCH 3/4] net/mlx5: fix event queue number query

2020-10-14 Thread Matan Azrad
When a Rx\Tx queue is created by DevX, its CQ configuration should include the EQ number of the interrupts. The EQ is managed by the kernel and there is a glue API in order to query the EQ number from the kernel. The EQ query API gets a vector number specifies the kernel vector of the interrupt han

[dpdk-dev] [PATCH 1/4] net/mlx5: fix Rx queue release

2020-10-14 Thread Matan Azrad
The HW objects of the Rx queue is created/destroyed in the device start\stop stage while the ethdev configurations for the Rx queue starts from the rx_queue_setup stage. The PMD should save all the last configurations it got from the ethdev and to apply them to the device in the dev_start operation

[dpdk-dev] [PATCH 2/4] net/mlx5: fix Tx queue release

2020-10-14 Thread Matan Azrad
The HW objects of the Tx queue is created/destroyed in the device start\stop stage while the ethdev configurations for the Tx queue starts from the tx_queue_setup stage. The PMD should save all the last configurations it got from the ethdev and to apply them to the device in the dev_start operation

Re: [dpdk-dev] [EXT] Re: [PATCH 2/2] vfio: fix partial DMA unmapping for VFIO type1

2020-10-14 Thread Nithin Dabilpuram
On Wed, Oct 14, 2020 at 04:07:10PM +0100, Burakov, Anatoly wrote: > External Email > > -- > On 12-Oct-20 9:11 AM, Nithin Dabilpuram wrote: > > Partial unmapping is not supported for VFIO IOMMU type1 > > by kernel. Though kernel gi

Re: [dpdk-dev] [PATCH v4 2/2] app/testpmd: support VLAN attributes in ETH and VLAN items

2020-10-14 Thread Ori Kam
Hi Dekel, > -Original Message- > From: Dekel Peled > Sent: Wednesday, October 14, 2020 9:53 PM > Cc: dev@dpdk.org > Subject: [PATCH v4 2/2] app/testpmd: support VLAN attributes in ETH and VLAN > items > > rte_flow update introduced has_vlan field for ETH header item, > and field has_more

Re: [dpdk-dev] [PATCH v2 4/4] raw/ifpga/base: enhance driver reliability in multi-process

2020-10-14 Thread Xu, Rosen
Hi, > -Original Message- > From: Zhang, Tianfei > Sent: Monday, September 28, 2020 9:40 > To: dev@dpdk.org; Xu, Rosen ; Huang, Wei > > Cc: Zhang, Tianfei > Subject: [PATCH v2 4/4] raw/ifpga/base: enhance driver reliability in multi- > process > > From: Wei Huang > > Current hardware

Re: [dpdk-dev] [PATCH] net/iavf: fix adding multicast MAC address

2020-10-14 Thread Sun, GuinanX
Hi beilei > -Original Message- > From: Xing, Beilei > Sent: Thursday, October 15, 2020 1:37 PM > To: Peng, Yuan ; Sun, GuinanX > ; dev@dpdk.org > Cc: Wu, Jingjing ; Zhang, Qi Z ; > Sun, GuinanX > Subject: RE: [dpdk-dev] [PATCH] net/iavf: fix adding multicast MAC address > > > > >

[dpdk-dev] [PATCH] net/virtio: fix invalid indirect desc length

2020-10-14 Thread Marvin Liu
When transmitting indirect descriptors, first desc will store net_hdr and following descs will be mapped to mbuf segments. Total desc number will be seg_num plus one. Meaning of variable needed is the number of used descs in packed ring. This value will always be two for indirect desc. Now use mbuf

[dpdk-dev] [PATCH] net/ice: fix RSS hash offload at vector mode

2020-10-14 Thread Zhang Alvin
From: Alvin Zhang 1. According to whether the RSS offload bit of the received packet is set to determin if the RSS hash should be read or not. 2. Simplify the code of reading RSS hash value. Fixes: 12443386a0b0 ("net/ice: support flex Rx descriptor RxDID22") Cc: sta...@dpdk.org Signed-off-by

Re: [dpdk-dev] [PATCH] net/iavf: fix adding multicast MAC address

2020-10-14 Thread Xing, Beilei
> -Original Message- > From: Peng, Yuan > Sent: Thursday, October 15, 2020 1:14 PM > To: Sun, GuinanX ; dev@dpdk.org > Cc: Xing, Beilei ; Wu, Jingjing > ; > Zhang, Qi Z ; Sun, GuinanX > Subject: RE: [dpdk-dev] [PATCH] net/iavf: fix adding multicast MAC address > > Test-by Peng, Yuan

[dpdk-dev] [PATCH v5 5/5] app/testpmd: change hairpin queues setup

2020-10-14 Thread Bing Zhao
A new parameter `hairpin-mode` is introduced to the testpmd command line. Bitmask value is used to provide a more flexible configuration. This parameter should be used when `hairpinq` is specified in the command line. Bit 0 in the LSB indicates the hairpin will use the loop mode. The previous port

[dpdk-dev] [PATCH v5 3/5] ethdev: add API to get hairpin peer ports list

2020-10-14 Thread Bing Zhao
After hairpin queues are configured, in general, the application will maintain the ports topology and even the queues configuration for the hairpin. But sometimes it will not. If there is no hot-plug, it is easy to bind and unbind hairpin among all the ports. The application can just connect or di

[dpdk-dev] [PATCH v5 4/5] ethdev: add APIs for hairpin queue operation

2020-10-14 Thread Bing Zhao
Every hairpin queue pair should be configured properly and the connection between TX and RX queues should be established, before hairpin function works. In single port hairpin mode, the queues of each pair belong to the same device. It is easy to get the hardware and software information of each qu

[dpdk-dev] [PATCH v5 1/5] ethdev: add hairpin bind and unbind APIs

2020-10-14 Thread Bing Zhao
In single port hairpin mode, all the hairpin TX and RX queues belong to the same device. After the queues are set up properly, there is no other dependency between the TX queue and its RX peer queue. The binding process that connected the TX and RX queues together from hardware level will be done a

[dpdk-dev] [PATCH v5 2/5] ethdev: add new attributes to hairpin config

2020-10-14 Thread Bing Zhao
To support two ports hairpin mode and keep the backward compatibility for the application, two new attribute members of the hairpin queue configuration structure will be added. `tx_explicit` means if the application itself will insert the TX part flow rules. If not set, PMD will insert the rules i

[dpdk-dev] [PATCH v5 0/5] introduce support for hairpin between two ports

2020-10-14 Thread Bing Zhao
The patches contain the following changes: 1. new APIs to bind and unbind hairpin ports in manual binding mode. 2. new API to get the hairpin peer ports list. 3. new internal APIs for PMD to pass the queue information and configure the queue pair. 4. new attribute members in the hairpin queue co

Re: [dpdk-dev] [PATCH v8] net/iavf: support flex desc metadata extraction

2020-10-14 Thread Guo, Jia
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, October 14, 2020 8:32 PM > To: Guo, Jia ; Wu, Jingjing ; > Zhang, Qi Z ; Xing, Beilei > Cc: dev@dpdk.org; Wang, Haiyue ; Richardson, > Bruce ; Olivier Matz > Subject: Re: [PATCH v8] net/iavf: support flex desc metadata extract

Re: [dpdk-dev] [PATCH v3 6/7] app/bbdev: reduce duration of throughput test

2020-10-14 Thread Liu, Tianjiao
Acked-by: Liu Tianjiao > -Original Message- > From: Chautru, Nicolas > Sent: Tuesday, August 18, 2020 5:06 PM > To: dev@dpdk.org; akhil.go...@nxp.com > Cc: Richardson, Bruce ; Chautru, Nicolas > > Subject: [PATCH v3 6/7] app/bbdev: reduce duration of throughput test > > Reducing numbe

[dpdk-dev] [PATCH v4 1/2] net/iavf: add IAVF request queues function

2020-10-14 Thread Ting Xu
Add new virtchnl function to request additional queues from PF. Current default queue pairs number when creating a VF is 16. In order to support up to 256 queue pairs, enable this request queues function. Since request queues command may return event message, modify function iavf_read_msg_from_pf t

[dpdk-dev] [PATCH v4 2/2] net/iavf: enable large VF configuration

2020-10-14 Thread Ting Xu
Add support to negotiate large VF capability, including configure VSI queues, enable/disable queues and IRQ mapping for large VF. Use new virtchnl opcodes and structures to help indicate up to 256 queue pairs. Need to request additional queues from PF first if the current allocated queues are not e

[dpdk-dev] [PATCH v4 0/2] enable large VF configuration

2020-10-14 Thread Ting Xu
This patchset supports to configure up to 256 queue pairs per VF. If large VF is supported after capability negotiation, VF will request queues from PF as needed. New virtual channel opcodes and structures are used to indicate 256 queues, so VF is designed to handle the new function of configure VS

Re: [dpdk-dev] [PATCH] gso: fix free issue of mbuf gso segments attach to

2020-10-14 Thread Hu, Jiayu
> -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, October 14, 2020 8:06 PM > To: yang_y_yi ; Hu, Jiayu > Cc: dev@dpdk.org; olivier.m...@6wind.com; tho...@monjalon.net; > yangy...@inspur.com > Subject: RE: Re:RE: [PATCH] gso: fix free issue of mbuf gso segments attach

Re: [dpdk-dev] [PATCH] net/iavf: fix adding multicast MAC address

2020-10-14 Thread Peng, Yuan
Test-by Peng, Yuan -Original Message- From: dev On Behalf Of Guinan Sun Sent: Thursday, October 15, 2020 10:02 AM To: dev@dpdk.org Cc: Xing, Beilei ; Wu, Jingjing ; Zhang, Qi Z ; Sun, GuinanX Subject: [dpdk-dev] [PATCH] net/iavf: fix adding multicast MAC address When the multicast ad

Re: [dpdk-dev] [PATCH v4 1/4] example/vhost: add async vhost args parsing function

2020-10-14 Thread Jiang, Cheng1
Hi Maxime, The replies are inline. > -Original Message- > From: Maxime Coquelin > Sent: Wednesday, October 14, 2020 5:24 PM > To: Jiang, Cheng1 ; Xia, Chenbo > ; Wang, Zhihong > Cc: dev@dpdk.org; Fu, Patrick > Subject: Re: [PATCH v4 1/4] example/vhost: add async vhost args parsing > fu

Re: [dpdk-dev] [PATCH v3 3/3] net/ice: support ACL filter in DCF

2020-10-14 Thread Zhang, Qi Z
some minor captures > -Original Message- > From: Su, Simei > Sent: Wednesday, October 14, 2020 4:54 PM > To: Zhang, Qi Z ; Yang, Qiming > Cc: dev@dpdk.org; Wang, Haiyue ; Xing, Beilei > ; Ding, Xuan ; Su, Simei > > Subject: [PATCH v3 3/3] net/ice: support ACL filter in DCF > > Add ice_

[dpdk-dev] [PATCH v5 4/4] doc: update release notes for vhost sample

2020-10-14 Thread Cheng Jiang
Add release notes for vhost async data path support in vhost sample. Signed-off-by: Cheng Jiang --- doc/guides/rel_notes/release_20_11.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst index 26cc0949a..a

[dpdk-dev] [PATCH v5 3/4] doc: update vhost sample doc for vhost async data path

2020-10-14 Thread Cheng Jiang
Add vhost async driver arguments information for vhost async data path in vhost sample application. Signed-off-by: Cheng Jiang --- doc/guides/sample_app_ug/vhost.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/guides/sample_app_ug/vhost.rst b/doc/guides/sample_app_ug/vh

[dpdk-dev] [PATCH v5 2/4] example/vhost: add support for vhost async data path

2020-10-14 Thread Cheng Jiang
This patch is to implement vhost DMA operation callbacks for CBDMA PMD and add vhost async data-path in vhost sample. With providing callback implementation for CBDMA, vswitch can leverage IOAT to accelerate vhost async data-path. Signed-off-by: Cheng Jiang --- examples/vhost/ioat.c | 92 +++

[dpdk-dev] [PATCH v5 1/4] example/vhost: add async vhost args parsing function

2020-10-14 Thread Cheng Jiang
This patch is to add async vhost driver arguments parsing function for CBDMA channel, DMA initiation function and args description. The meson build file is changed to fix dependency problem. With these arguments vhost device can be set to use CBDMA or CPU for enqueue operation and bind vhost device

[dpdk-dev] [PATCH v5 0/4] add async data path in vhost sample

2020-10-14 Thread Cheng Jiang
This patch set makes vhost-vswitch be able to use vhost async APIs for enqueue operations. Demonstrated how the application leverage IOAT DMA channel with vhost async APIs. We introduce two parameters to enable DMA acceleration for Tx operations of queues: -dma_type This parameter is used to speci

Re: [dpdk-dev] [PATCH v2] config: enable packet data prefetch

2020-10-14 Thread Honnappa Nagarahalli
> > > > 23/09/2020 03:51, Marvin Liu: > > > Data prefetch instruction can preload data into cpu’s hierarchical > > > cache before data access. Virtualized data paths like virtio > > > utilized this feature for acceleration. Since most modern cpus have > > > support prefetch function, we can enabl

Re: [dpdk-dev] [PATCH v4 3/5] ethdev: add API to get hairpin peer ports list

2020-10-14 Thread Bing Zhao
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, October 14, 2020 11:02 PM > To: Bing Zhao > Cc: Ori Kam ; ferruh.yi...@intel.com; > arybche...@solarflare.com; m...@ashroe.eu; nhor...@tuxdriver.com; > bernard.iremon...@intel.com; beilei.x...@intel.com; > wenzhuo

[dpdk-dev] [PATCH v9] net/iavf: support flex desc metadata extraction

2020-10-14 Thread Jeff Guo
Enable metadata extraction for flexible descriptors in AVF, that would allow network function directly get metadata without additional parsing which would reduce the CPU cost for VFs. The enabling metadata extractions involve the metadata of VLAN/IPv4/IPv6/IPv6-FLOW/TCP/MPLS flexible descriptors, a

Re: [dpdk-dev] [PATCH v8] net/iavf: support flex desc metadata extraction

2020-10-14 Thread Guo, Jia
> -Original Message- > From: Bruce Richardson > Sent: Wednesday, October 14, 2020 10:04 PM > To: Yigit, Ferruh > Cc: Guo, Jia ; Wu, Jingjing ; > Zhang, Qi Z ; Xing, Beilei ; > dev@dpdk.org; Wang, Haiyue ; Olivier Matz > > Subject: Re: [PATCH v8] net/iavf: support flex desc metadata ext

Re: [dpdk-dev] [PATCH] net/bnxt: fix UDP tunnel port remove

2020-10-14 Thread Ajit Khaparde
On Mon, Oct 12, 2020 at 8:30 AM Kalesh A P wrote: > > From: Kalesh AP > > The HWRM supports only one global destination port for a tunnel type. > > When port is stopped, driver deletes the UDP tunnel port configured > in the HW, but it does not update the counter which causes the > tunnel port ad

Re: [dpdk-dev] [PATCH v4 1/5] ethdev: add hairpin bind and unbind APIs

2020-10-14 Thread Bing Zhao
Hi Thomas, All your comments are confirmed and addressed. Thanks > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, October 14, 2020 10:43 PM > To: Bing Zhao > Cc: Ori Kam ; ferruh.yi...@intel.com; > arybche...@solarflare.com; m...@ashroe.eu; nhor...@tuxdriver.com; > berna

Re: [dpdk-dev] [PATCH v3 1/6] ethdev: add hairpin bind and unbind APIs

2020-10-14 Thread Bing Zhao
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, October 14, 2020 10:36 PM > To: Bing Zhao > Cc: Ori Kam ; ferruh.yi...@intel.com; > arybche...@solarflare.com; m...@ashroe.eu; nhor...@tuxdriver.com; > bernard.iremon...@intel.com; beilei.x...@intel.com; > wenzhuo

Re: [dpdk-dev] [PATCH V1 2/3] mbuf: change free_cb interface to adapt to GSO case

2020-10-14 Thread yang_y_yi
Got it, thanks a lot. At 2020-10-14 21:55:25, "Olivier Matz" wrote: >Hi, > >On Sat, Oct 10, 2020 at 09:49:35AM +0800, yang_y_yi wrote: >> Olivier, thank you so much for helping figure out this, it does work >> as the code you changed, so we can fix the issue without this patch

Re: [dpdk-dev] [PATCH v6 1/6] ethdev: introduce Rx buffer split

2020-10-14 Thread Ajit Khaparde
On Wed, Oct 14, 2020 at 11:13 AM Viacheslav Ovsiienko wrote: > > The DPDK datapath in the transmit direction is very flexible. > An application can build the multi-segment packet and manages > almost all data aspects - the memory pools where segments > are allocated from, the segment lengths, the

[dpdk-dev] [PATCH] net/iavf: fix adding multicast MAC address

2020-10-14 Thread Guinan Sun
When the multicast address is added, it will flush previous addresses first, and then add new ones. So when adding an address that exceeds the upper limit causes a failure, you need to add the previous address list back. This patch fixes the issue. Fixes: 05e4c3aff35f ("net/iavf: support multicast

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix dereference before null check

2020-10-14 Thread wangyunjian
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, October 15, 2020 1:03 AM > To: wangyunjian ; dev@dpdk.org > Cc: david.march...@redhat.com; jer...@marvell.com; hka...@marvell.com; > Lilijun (Jerry) ; xudingke ; > sta...@dpdk.org > Subject: Re: [dpd

Re: [dpdk-dev] [PATCH v5 1/2] eal/windows: add pthread mutex lock

2020-10-14 Thread Narcisa Ana Maria Vasile
On Thu, Oct 15, 2020 at 09:07:46AM +0800, Suanming Mou wrote: > Add pthread mutex lock as it is needed for the thread safe rte_flow > functions. > > Signed-off-by: Suanming Mou > Tested-by: Tal Shnaiderman > Acked-by: Dmitry Kozlyuk > Acked-by: Ranjit Menon > --- > > v5: > - Remove PTHREAD_M

Re: [dpdk-dev] [PATCH v4 1/2] eal/windows: add pthread mutex lock

2020-10-14 Thread Suanming Mou
> -Original Message- > From: Narcisa Ana Maria Vasile > Sent: Thursday, October 15, 2020 10:16 AM > To: Suanming Mou > Cc: Dmitry Kozlyuk ; Dmitry Malloy > ; Pallavi Kadam ; > dev@dpdk.org > Subject: Re: [PATCH v4 1/2] eal/windows: add pthread mutex lock > > On Fri, Oct 09, 2020 at 09

Re: [dpdk-dev] [PATCH v4 1/2] eal/windows: add pthread mutex lock

2020-10-14 Thread Narcisa Ana Maria Vasile
On Fri, Oct 09, 2020 at 09:17:22AM +0800, Suanming Mou wrote: > Add pthread mutex lock as it is needed for the thread safe rte_flow > functions. > > Signed-off-by: Suanming Mou > Acked-by: Dmitry Kozlyuk > --- > > v4: > - Add PTHREAD_MUTEX_INITIALIZER macro. > > v3: > - No updates. > > v2:

Re: [dpdk-dev] [PATCH v2] config: enable packet data prefetch

2020-10-14 Thread Liu, Yong
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, October 15, 2020 6:03 AM > To: Liu, Yong > Cc: Richardson, Bruce ; > step...@networkplumber.org; dev@dpdk.org; > david.march...@redhat.com; Yigit, Ferruh ; > maxime.coque...@redhat.com; honnappa.nagaraha...@arm.com; David >

Re: [dpdk-dev] [PATCH v2] security: update session create API

2020-10-14 Thread Lukasz Wojciechowski
W dniu 14.10.2020 o 21:00, Akhil Goyal pisze: > Hi Lukasz, > >> Hi Akhil, >>> -#define SECURITY_TEST_MEMPOOL_NAME "SecurityTestsMempoolName" >>> +#define SECURITY_TEST_MEMPOOL_NAME "SecurityTestMp" >>> +#define SECURITY_TEST_PRIV_MEMPOOL_NAME "SecurityTestPrivMp" >>>#define SECURITY_TEST_MEMP

Re: [dpdk-dev] [PATCH v3] security: update session create API

2020-10-14 Thread Lukasz Wojciechowski
Hi Akhil, thank you for responding to review and for v3. You patch currently does not apply: dpdk$ git apply v3-security-update-session-create-API.patch error: patch failed: doc/guides/rel_notes/deprecation.rst:164 error: doc/guides/rel_notes/deprecation.rst: patch does not apply error: patch fai

[dpdk-dev] [PATCH v5 2/2] ethdev: make rte_flow API thread safe

2020-10-14 Thread Suanming Mou
Currently, the rte_flow functions are not defined as thread safe. DPDK applications either call the functions in single thread or protect any concurrent calling for the rte_flow operations using a lock. For PMDs support the flow operations thread safe natively, the redundant protection in applicat

[dpdk-dev] [PATCH v5 0/2] ethdev: make rte_flow API thread safe

2020-10-14 Thread Suanming Mou
Currently, the rte_flow functions are not defined as thread safe. DPDK applications either call the functions in single thread or add locks around the functions for the critical section. For PMDs support the flow operations thread safe natively, the redundant protection in application hurts the pe

[dpdk-dev] [PATCH v5 1/2] eal/windows: add pthread mutex lock

2020-10-14 Thread Suanming Mou
Add pthread mutex lock as it is needed for the thread safe rte_flow functions. Signed-off-by: Suanming Mou Tested-by: Tal Shnaiderman Acked-by: Dmitry Kozlyuk Acked-by: Ranjit Menon --- v5: - Remove PTHREAD_MUTEX_INITIALIZER macro added in v4. v4: - Add PTHREAD_MUTEX_INITIALIZER macro. v3

Re: [dpdk-dev] [PATCH v3 00/56] net: txgbe PMD

2020-10-14 Thread Ferruh Yigit
On 10/14/2020 6:54 AM, Jiawen Wu wrote: v3: Merge some recent changes in the main repo, fix the checkpatch warnings. v2: Re-order patches and fix some known problems. v1: Introduce txgbe PMD. Jiawen Wu (56): net/txgbe: add build and doc infrastructure net/txgbe: add ethdev probe and r

Re: [dpdk-dev] [PATCH v3 02/56] net/txgbe: add ethdev probe and remove

2020-10-14 Thread Ferruh Yigit
On 10/14/2020 6:54 AM, Jiawen Wu wrote: Add basic PCIe ethdev probe and remove. Signed-off-by: Jiawen Wu <...> +RTE_LOG_REGISTER(txgbe_logtype_init, pmd.net.txgbe.init, NOTICE); +RTE_LOG_REGISTER(txgbe_logtype_driver, pmd.net.txgbe.driver, NOTICE); + +#ifdef RTE_LIBRTE_TXGBE_DEBUG_RX +

[dpdk-dev] [PATCH v2] eal/rte_malloc: add alloc_size() attribute to allocation functions

2020-10-14 Thread Stephen Hemminger
By using the alloc_size() attribute the compiler can optimize better and detect errors at compile time. For example, Gcc will fail one of the invalid allocation examples in app/test/test_malloc.c because the allocation is outside the limits of memory. Signed-off-by: Stephen Hemminger --- v2 - re

Re: [dpdk-dev] [PATCH v3 56/56] net/txgbe: add Rx and Tx descriptor status

2020-10-14 Thread Ferruh Yigit
On 10/14/2020 6:55 AM, Jiawen Wu wrote: Supports check the status of Rx and Tx descriptors. Signed-off-by: Jiawen Wu <...> @@ -480,6 +480,10 @@ eth_txgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused) PMD_INIT_FUNC_TRACE(); eth_dev->dev_ops = &txgbe_eth

Re: [dpdk-dev] [PATCH v3 27/56] net/txgbe: fill receive functions

2020-10-14 Thread Ferruh Yigit
On 10/14/2020 6:54 AM, Jiawen Wu wrote: Fill receive functions and define receive descriptor. Signed-off-by: Jiawen Wu <...> @@ -42,6 +54,17 @@ static const u64 TXGBE_TX_OFFLOAD_MASK = (PKT_TX_IP_CKSUM | #define TXGBE_TX_OFFLOAD_NOTSUP_MASK \ (PKT_TX_OFFLOAD_MASK ^ TXGBE_T

Re: [dpdk-dev] [PATCH v5 1/8] crypto/bcmfs: add BCMFS driver

2020-10-14 Thread Thomas Monjalon
07/10/2020 19:18, Vikas Gupta: > --- /dev/null > +++ b/drivers/crypto/bcmfs/rte_pmd_bcmfs_version.map > @@ -0,0 +1,3 @@ > +DPDK_21.0 { > + local: *; > +}; No! Please be careful, all other libs use ABI DPDK_21. Will fix

Re: [dpdk-dev] [PATCH v5 1/8] crypto/bcmfs: add BCMFS driver

2020-10-14 Thread Thomas Monjalon
07/10/2020 19:18, Vikas Gupta: > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1081,6 +1081,13 @@ F: drivers/crypto/zuc/ > F: doc/guides/cryptodevs/zuc.rst > F: doc/guides/cryptodevs/features/zuc.ini > Drivers are alphabetically sorted. > +Broadcom FlexSparc > +M: Ajit Khaparde > +M: Raveendra

[dpdk-dev] [PATCH 3/3] common/iavf: update version

2020-10-14 Thread Qi Zhang
Update base code release version in readme Signed-off-by: Qi Zhang --- drivers/common/iavf/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/iavf/README b/drivers/common/iavf/README index f301ff665a..5a42750465 100644 --- a/drivers/common/iavf/README +++ b

[dpdk-dev] [PATCH 1/3] common/iavf: replace macro for MAC address length

2020-10-14 Thread Qi Zhang
Replace ETH_ALEN with VIRTCHNL_ETH_LENGTH_OF_ADDRESS. Signed-off-by: Maciej Rabeda Signed-off-by: Qi Zhang --- drivers/common/iavf/virtchnl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h index 81eabd73be.

[dpdk-dev] [PATCH 2/3] common/iavf: add support for VFs with >16 queue pairs

2020-10-14 Thread Qi Zhang
Currently there are limitations in the virthcnl.h interface that only allow a maximum of 16 queues to be used by a VF driver. Add support in virtchnl.h to allow a VF driver to request >16 queues. Also, the RSS qregion size is currently assumed to be the max number of queues a VF can request and/or

[dpdk-dev] [PATCH 0/3] iavf update base code

2020-10-14 Thread Qi Zhang
main change: Add support for VFs with > queue pairs. Qi Zhang (3): common/iavf: replace macro for MAC address length common/iavf: add support for VFs with >16 queue pairs common/iavf: update version drivers/common/iavf/README | 2 +- drivers/common/iavf/virtchnl.h | 235 +

Re: [dpdk-dev] [PATCH v9 0/8] Enable dynamic config of subport bandwidth

2020-10-14 Thread Thomas Monjalon
09/10/2020 14:39, Savinay Dharmappa: > DPDK sched library allows runtime configuration of the pipe profiles to the > pipes of the subport once scheduler hierarchy is constructed. However, to > change the subport level bandwidth, existing hierarchy needs to be > dismantled and whole process of build

Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-10-14 Thread Honnappa Nagarahalli
> >> > >> > >> On 13/10/2020 18:46, Michel Machado wrote: > >>> On 10/13/20 11:41 AM, Medvedkin, Vladimir wrote: > Hi Michel, > > Could you please describe a condition when LPM gets inconsistent? > As I can see if there is no free tbl8 it will return -ENOSPC. > >>> > >>>     C

Re: [dpdk-dev] [PATCH v4 2/4] ethdev: tunnel offload model

2020-10-14 Thread Thomas Monjalon
Formatting review below (someone has to do it): 04/10/2020 15:50, Gregory Etelson: > --- a/doc/guides/prog_guide/rte_flow.rst > +++ b/doc/guides/prog_guide/rte_flow.rst > @@ -3034,6 +3034,111 @@ operations include: > +Tunneled traffic offload > + > + > +Provide software app

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: allow negative values in flow rule types

2020-10-14 Thread Thomas Monjalon
04/10/2020 15:50, Gregory Etelson: > From: Gregory Etelson > > RTE flow items & actions use positive values in item & action type. > Negative values are reserved for PMD private types. PMD > items & actions usually are not exposed to application and are not > used to create RTE flows. > > The pa

Re: [dpdk-dev] [PATCH 0/2] net/hns3: support SVE Tx/Rx

2020-10-14 Thread Ferruh Yigit
On 10/14/2020 11:01 AM, Wei Hu (Xavier) wrote: This series add support SVE Tx/Rx operation. Chengwen Feng (1): net/hns3: support SVE Tx Wei Hu (Xavier) (1): net/hns3: support SVE Rx Series applied to dpdk-next-net/main, thanks.

Re: [dpdk-dev] [PATCH] eal: fix build with conflicting libc variable memory_order

2020-10-14 Thread Thomas Monjalon
14/10/2020 08:19, Eli Britstein: > The cited commit introduced functions with 'int memory_order' argument. > The C11 standard section 7.17.1.4 defines 'memory_order' as the > "enumerated type whose enumerators identify memory ordering constraints". > Applications that use the standard enum (include

Re: [dpdk-dev] [PATCH] eal/rte_malloc: add alloc_size() attribute to allocation functions

2020-10-14 Thread Thomas Monjalon
14/09/2020 18:40, Stephen Hemminger: > On Mon, 14 Sep 2020 16:35:58 +0100 > "Burakov, Anatoly" wrote: > > > >* Replacement function for calloc(), using huge-page memory. Memory > > > area is > > > @@ -239,9 +243,9 @@ rte_zmalloc_socket(const char *type, size_t size, > > > unsigned align, in

Re: [dpdk-dev] [PATCH v3 0/7] cmdline: support Windows

2020-10-14 Thread Thomas Monjalon
> > Dmitry Kozlyuk (7): > > cmdline: make implementation logically opaque > > cmdline: add internal wrappers for terminal handling > > cmdline: add internal wrappers for character input > > cmdline: add internal wrapper for vdprintf > > eal/windows: improve compatibility networking header

Re: [dpdk-dev] [PATCH v3 7/7] examples/cmdline: build on Windows

2020-10-14 Thread Thomas Monjalon
28/09/2020 23:50, Dmitry Kozlyuk: > --- a/examples/meson.build > +++ b/examples/meson.build > @@ -79,9 +79,9 @@ foreach example: examples > > ext_deps = [execinfo] > includes = [include_directories(example)] > - deps = ['eal', 'mempool', 'net', 'mbuf', 'ethdev', 'cmdline'] > -

Re: [dpdk-dev] [PATCH v3 6/7] cmdline: support Windows

2020-10-14 Thread Thomas Monjalon
28/09/2020 23:50, Dmitry Kozlyuk: > --- a/lib/librte_cmdline/cmdline.c > +++ b/lib/librte_cmdline/cmdline.c > @@ -13,11 +13,16 @@ > #include > #include > #include > +#include unistd is already included few lines above.

Re: [dpdk-dev] [PATCH v6 1/6] ethdev: introduce Rx buffer split

2020-10-14 Thread Thomas Monjalon
14/10/2020 20:11, Viacheslav Ovsiienko: > The DPDK datapath in the transmit direction is very flexible. > An application can build the multi-segment packet and manages > almost all data aspects - the memory pools where segments > are allocated from, the segment lengths, the memory attributes > like

Re: [dpdk-dev] [PATCH v2] config: enable packet data prefetch

2020-10-14 Thread Thomas Monjalon
23/09/2020 03:51, Marvin Liu: > Data prefetch instruction can preload data into cpu’s hierarchical > cache before data access. Virtualized data paths like virtio utilized > this feature for acceleration. Since most modern cpus have support > prefetch function, we can enable packet data prefetch as

[dpdk-dev] [Bug 555] Flow API issues with testpmd discovered during the creation of the rte flow test suite

2020-10-14 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=555 Bug ID: 555 Summary: Flow API issues with testpmd discovered during the creation of the rte flow test suite Product: DPDK Version: 20.08 Hardware: All OS: Linux

[dpdk-dev] [PATCH v5] eventdev: add PCI probe named convenience function

2020-10-14 Thread Timothy McDaniel
Add new internal wrapper function for use by pci drivers as a .probe function to attach to an event interface. Same as rte_event_pmd_pci_probe, except the caller can specify the name. Updated rte_event_pmd_pci_probe so as to not duplicate code. Signed-off-by: Timothy McDaniel Reviewed-by: Gage

Re: [dpdk-dev] [PATCH v2 2/2] eal/windows: implement alarm API

2020-10-14 Thread Thomas Monjalon
26/09/2020 01:41, Narcisa Ana Maria Vasile: > On Sat, Sep 26, 2020 at 02:32:43AM +0300, Dmitry Kozlyuk wrote: > > Implementation is based on waitable timers Win32 API. When timer is set, > > a callback and its argument are supplied to the OS, while timer handle > > is stored in EAL alarm list. When

[dpdk-dev] [PATCH 1/2] eventdev: eventdev: express DLB/DLB2 PMD constraints

2020-10-14 Thread Timothy McDaniel
This commit implements the eventdev ABI changes required by the DLB PMD. Signed-off-by: Timothy McDaniel --- drivers/event/dpaa/dpaa_eventdev.c | 3 +- drivers/event/dpaa2/dpaa2_eventdev.c | 5 +- drivers/event/dsw/dsw_evdev.c | 3 +- drivers/event/octeo

[dpdk-dev] [PATCH 2/2] eventdev: update app and examples for new eventdev ABI

2020-10-14 Thread Timothy McDaniel
Several data structures and constants changed, or were added, in the previous patch. This commit updates the dependent apps and examples to use the new ABI. Signed-off-by: Timothy McDaniel Acked-by: Pavan Nikhilesh Acked-by: Harry van Haaren --- app/test-eventdev/evt_common.h

[dpdk-dev] [PATCH 0/2] Eventdev ABI changes for DLB/DLB2

2020-10-14 Thread Timothy McDaniel
This series implements the eventdev ABI changes required by the DLB and DLB2 PMDs. This ABI change was announced in the 20.08 release notes [1]. This patch was initially part of the V1 DLB PMD patchset. The DLB hardware does not conform exactly to the eventdev interface. 1) It has a limit on the n

Re: [dpdk-dev] [PATCH] net/enic: check return code

2020-10-14 Thread Ferruh Yigit
On 10/14/2020 9:25 PM, John Daley wrote: Coverity issue: 363046 Fixes: bb66d562aefc ("net/enic: share flow actions with same signature") Signed-off-by: John Daley Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.

Re: [dpdk-dev] [PATCH] bus/pci: clear undefined bits in Windows segment parsing

2020-10-14 Thread Ranjit Menon
On 10/14/2020 12:30 PM, Tal Shnaiderman wrote: When reading bus and segment values using SPDRP_BUSNUMBER bits 24-31 are undefined. They are cleared to verify we read the segment number correctly. Fixes: c3adf8144a1 ("bus/pci: support segment value as address domain on Window") Cc: sta...@dpd

Re: [dpdk-dev] [PATCH v7] bus/pci: netuio interface for windows

2020-10-14 Thread Thomas Monjalon
09/10/2020 04:12, Narcisa Ana Maria Vasile: > On Thu, Oct 08, 2020 at 11:56:45AM -0700, Pallavi Kadam wrote: > > This patch adds implementations to probe PCI devices bound to netuio > > with the help of "netuio" class device changes. > > Now Windows will support both "netuio" and "net" device class

Re: [dpdk-dev] [PATCH v2 1/1] crypto/bcmfs: optimize crypto request processing

2020-10-14 Thread Akhil Goyal
> Reduce number of source BDs to submit a request to crypto engine. > This improves the performance as crypto engine fetches all the BDs in > single cycle. Adjust optional metadata (OMD) in continuation of > fixed meta data (FMD). > > Signed-off-by: Vikas Gupta > Signed-off-by: Raveendra Padasa

Re: [dpdk-dev] [PATCH v3 2/8] security: modify PDCP xform to support SDAP

2020-10-14 Thread Akhil Goyal
> 12/10/2020 16:10, Akhil Goyal: > > The SDAP is a protocol in the LTE stack on top of PDCP for > > QOS. A particular PDCP session may or may not have > > SDAP enabled. But if it is enabled, SDAP header should be > > authenticated but not encrypted if both confidentiality and > > integrity is enabl

[dpdk-dev] [PATCH] net/enic: check return code

2020-10-14 Thread John Daley
Coverity issue: 363046 Fixes: bb66d562aefc ("net/enic: share flow actions with same signature") Signed-off-by: John Daley --- drivers/net/enic/enic_fm_flow.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/enic/enic_fm_flow.c b/drivers/net/enic/enic_fm_flow.c

[dpdk-dev] [PATCH] bus/pci: remove unused scan by address

2020-10-14 Thread Thomas Monjalon
The function pci_update_device was used to scan a device for probing by PCI address. This private function (and implementations) are unused since such probing is removed. Fixes: f3bac43b60da ("bus/pci: remove unused function to probe by address") Cc: sta...@dpdk.org Signed-off-by: Thomas Monjalon

Re: [dpdk-dev] [PATCH v4 1/2] ethdev: add VLAN attributes to ETH and VLAN items

2020-10-14 Thread Thomas Monjalon
14/10/2020 20:53, Dekel Peled: > @@ -292,6 +292,13 @@ API Changes > > * vhost: Moved vDPA APIs from experimental to stable. > > +* ethdev: Added new field ``has_vlan`` to structure ``rte_flow_item_eth``, > + indicating that packet header contains at least one VLAN. > + > +* ethdev: Added new

Re: [dpdk-dev] [PATCH v3] eventdev: update app and examples for new eventdev ABI

2020-10-14 Thread Jerin Jacob
On Wed, Oct 14, 2020 at 11:01 PM Timothy McDaniel wrote: > > Several data structures and constants changed, or were added, > in the previous patch. This commit updates the dependent > apps and examples to use the new ABI. > > Signed-off-by: Timothy McDaniel > Acked-by: Pavan Nikhilesh > Acked-b

Re: [dpdk-dev] [PATCH v6 05/18] drivers: replace master lcore with main lcore

2020-10-14 Thread Ajit Khaparde
On Wed, Oct 14, 2020 at 8:30 AM Stephen Hemminger wrote: > > Replace use of deprecated rte_master_lcore with rte_main_lcore. > > Signed-off-by: Stephen Hemminger > Acked-by: Anatoly Burakov For bnxt PMD Acked-by: Ajit Khaparde > --- > drivers/bus/dpaa/dpaa_bus.c | 2 +- >

[dpdk-dev] [PATCH] bus/pci: clear undefined bits in Windows segment parsing

2020-10-14 Thread Tal Shnaiderman
When reading bus and segment values using SPDRP_BUSNUMBER bits 24-31 are undefined. They are cleared to verify we read the segment number correctly. Fixes: c3adf8144a1 ("bus/pci: support segment value as address domain on Window") Cc: sta...@dpdk.org Signed-off-by: Tal Shnaiderman --- drivers

Re: [dpdk-dev] [PATCH v2] security: update session create API

2020-10-14 Thread Akhil Goyal
Hi Lukasz, > Hi Akhil, > > -#define SECURITY_TEST_MEMPOOL_NAME "SecurityTestsMempoolName" > > +#define SECURITY_TEST_MEMPOOL_NAME "SecurityTestMp" > > +#define SECURITY_TEST_PRIV_MEMPOOL_NAME "SecurityTestPrivMp" > > #define SECURITY_TEST_MEMPOOL_SIZE 15 > > #define SECURITY_TEST_SESSION_OBJEC

Re: [dpdk-dev] [PATCH v6 1/6] ethdev: introduce Rx buffer split

2020-10-14 Thread Jerin Jacob
On Wed, Oct 14, 2020 at 11:42 PM Viacheslav Ovsiienko wrote: > > The DPDK datapath in the transmit direction is very flexible. > An application can build the multi-segment packet and manages > almost all data aspects - the memory pools where segments > are allocated from, the segment lengths, the

[dpdk-dev] [PATCH v3] security: update session create API

2020-10-14 Thread Akhil Goyal
The API ``rte_security_session_create`` takes only single mempool for session and session private data. So the application need to create mempool for twice the number of sessions needed and will also lead to wastage of memory as session private data need more memory compared to session. Hence the A

[dpdk-dev] [PATCH v4 1/2] ethdev: add VLAN attributes to ETH and VLAN items

2020-10-14 Thread Dekel Peled
This patch implements the change proposes in RFC [1], adding dedicated fields to ETH and VLAN items structs, to clearly define the required characteristic of a packet, and enable precise match criteria. Documentation is updated accordingly. [1] https://mails.dpdk.org/archives/dev/2020-August/17753

[dpdk-dev] [PATCH v4 2/2] app/testpmd: support VLAN attributes in ETH and VLAN items

2020-10-14 Thread Dekel Peled
rte_flow update introduced has_vlan field for ETH header item, and field has_more_vlan for VLAN header item. The new fields are used to clearly indicate packet tagging chrasteristics. This patch updates testpmd CLI to support the new fields. Signed-off-by: Dekel Peled --- app/test-pmd/cmdline_fl

[dpdk-dev] [PATCH v4 0/2] support VLAN attributes in ETH and VLAN items

2020-10-14 Thread Dekel Peled
This series implements the change proposes in RFC [1], adding dedicated fields to ETH and VLAN items structs, to clearly define the required characteristic of a packet, and enable precise match criteria. testpmd CLI is updated accordingly. Documentation is updated accordingly. [1] https://mails.dp

Re: [dpdk-dev] [PATCH v6 05/10] power: add PMD power management API and callback

2020-10-14 Thread Ananyev, Konstantin
> From: Liang Ma > > Add a simple on/off switch that will enable saving power when no > packets are arriving. It is based on counting the number of empty > polls and, when the number reaches a certain threshold, entering an > architecture-defined optimized power state that will either wait > unti

  1   2   3   4   >