[dpdk-dev] [Bug 576] "‘str2flowtype’ defined but not used" when building with net/i40e disabled

2020-11-11 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=576 Bug ID: 576 Summary: "‘str2flowtype’ defined but not used" when building with net/i40e disabled Product: DPDK Version: 20.11 Hardware: All OS: All Status

[dpdk-dev] [PATCH v3] examples/vhost: fix ioat dependency issue

2020-11-11 Thread Cheng Jiang
Fix vhost-switch compiling issue when ioat dependency is missing. Change 'RTE_x86' check into 'RTE_RAW_IOAT' check in meson build file and update Makefile. Clean some codes. Fixes: abec60e7115d ("examples/vhost: support vhost async data path") Fixes: 3a04ecb21420 ("examples/vhost: add async vhost

Re: [dpdk-dev] [PATCH v1] examples/vhost: fix ioat dependency issue

2020-11-11 Thread Jiang, Cheng1
Hi, > -Original Message- > From: David Marchand > Sent: Wednesday, November 11, 2020 10:36 PM > To: Jiang, Cheng1 > Cc: Maxime Coquelin ; Xia, Chenbo > ; dev ; Fu, Patrick > ; Yang, YvonneX ; Hu, > Jiayu ; Thomas Monjalon ; > Yigit, Ferruh > Subject: Re: [PATCH v1] examples/vhost: fix i

[dpdk-dev] [PATCH] net/iavf: fix performance drop after port reset

2020-11-11 Thread Leyi Rong
Needs to reset rxq->rxrearm_start to 0 when reset_rx_queue(), otherwise, the random value of rxrearm_start will cause performance drop due to L3 contested accesses. Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx.c | 1 + 1 file c

[dpdk-dev] [PATCH] net/ice: support flow mark ID in avx512 path

2020-11-11 Thread Zhang,Alvin
From: Alvin Zhang Support flow director mark ID parsing from flexible Rx descriptor in avx512 path. Signed-off-by: Alvin Zhang Fixes: 59852468c19c ("net/ice: support flow mark in AVX path") Cc: sta...@dpdk.org --- drivers/net/ice/ice_rxtx_vec_avx512.c | 65 +--

[dpdk-dev] [PATCH v2] examples/vhost: fix ioat dependency issue

2020-11-11 Thread Cheng Jiang
Fix vhost-switch compiling issue when ioat dependency is missing. Change 'RTE_x86' check into 'RTE_RAW_IOAT' check in meson build file and update Makefile. Clean some codes. Signed-off-by: Cheng Jiang --- v2: * Cleaned some codes * Changed RTE_RAW_IOAT check method in Makefile * Added ioat fun

[dpdk-dev] [RFC] net/i40e: refactor of hash flow

2020-11-11 Thread Zhang,Alvin
From: Alvin Zhang 1. Delete original code. 2. Add 2 tables(pattern RSS type matched PCTYPE, RSS type to input set). 3. Parse RSS pattern and RSS type to get PCTYPE. 4. Parse RSS action to get queues, RSS function and hash field. 5. Create and destroy RSS filters. 6. Create new files for hash flow

[dpdk-dev] [PATCH] net/ice: support flow mark ID in avx512 path

2020-11-11 Thread Zhang,Alvin
From: Alvin Zhang Support flow director mark ID parsing from flexible Rx descriptor in avx512 path. Signed-off-by: Alvin Zhang --- drivers/net/ice/ice_rxtx_vec_avx512.c | 61 +++ 1 file changed, 61 insertions(+) diff --git a/drivers/net/ice/ice_rxtx_vec_avx512.

Re: [dpdk-dev] [RFC V2 1/2] app/testpmd: fix queue stats mapping configuration

2020-11-11 Thread Min Hu (Connor)
Hi Ferruh, any suggestions? 在 2020/11/3 14:30, Min Hu (Connor) 写道: Hi Ferruh, I agree with your proposal. But if we remove record structures, we will not be able to query the current queue stats mapping configuration. Or we can provide a query API for the PMD driver that uses the set_queue_sta

[dpdk-dev] [PATCH v1] net/ixgbe: remove the redundant MAC flag check

2020-11-11 Thread Haiyue Wang
The flag of RTE_ETHTYPE_FLAGS_MAC has been checked twice, so remove the first error message "Not supported by ethertype filter" which is not so specific, and keep the error message "mac compare is unsupported" which aligns to the definition of RTE_ETHTYPE_FLAGS_MAC. Fixes: eb3539fc8550 ("net/ixgbe

Re: [dpdk-dev] [v4]net/hinic: fix coredump when the scondary process using the hinic port.

2020-11-11 Thread Wangxiaoyun (Cloud)
Hi Ferruh, Align with Qingqing Li, this path will not apply to dpdk master now, some dev_ops may casue fail when run in secondary proc, so need to modify it later and add tests for other dev_ops. Thanks 在 2020/10/31 18:10, Qingqing Li 写道: fix coredump when secondary process using the hinic p

Re: [dpdk-dev] [PATCH v2 06/37] net/txgbe: add ethertype parse rule

2020-11-11 Thread Wang, Haiyue
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, November 12, 2020 00:04 > To: Guo, Jia ; Wang, Haiyue > Cc: Jiawen Wu ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 06/37] net/txgbe: add ethertype parse rule > > On 11/11/2020 4:02 PM, Ferruh Yigit wrote: > > On 11/11/2020

Re: [dpdk-dev] [PATCH 06/10] examples/ntb: fix clean target

2020-11-11 Thread Li, Xiaoyun
> -Original Message- > From: David Marchand > Sent: Tuesday, November 10, 2020 23:12 > To: dev@dpdk.org > Cc: tho...@monjalon.net; Richardson, Bruce ; > sta...@dpdk.org; Li, Xiaoyun ; Wu, Jingjing > ; Xiaolong Ye > Subject: [PATCH 06/10] examples/ntb: fix clean target > > When introdu

Re: [dpdk-dev] [PATCH v8 09/14] ci: switch to generic Arm builds

2020-11-11 Thread Honnappa Nagarahalli
> > > > > > > > > > Switch to generic build on arm Travis machines to avoid > > > > > differences in build configuration caused by different Arm hardware. > > > > > > > > > > Signed-off-by: Juraj Linkeš > > > > > --- > > > > > .ci/linux-build.sh | 4 > > > > > 1 file changed, 4 insertions(

Re: [dpdk-dev] [PATCH] event/dlb2: add missing delayed token pop logic

2020-11-11 Thread Chen, Mike Ximing
> -Original Message- > From: dev On Behalf Of Timothy McDaniel > Sent: Wednesday, November 11, 2020 3:27 PM > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > jer...@marvell.com; tho...@monjalon.net; david.march...@redhat.com > Subject: [dpdk-dev] [PATCH] event/

Re: [dpdk-dev] [PATCH] event/dlb: do not free memzone if port create succeeds

2020-11-11 Thread Chen, Mike Ximing
> -Original Message- > From: dev On Behalf Of Timothy McDaniel > Sent: Wednesday, November 11, 2020 3:27 PM > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > jer...@marvell.com; tho...@monjalon.net; david.march...@redhat.com > Subject: [dpdk-dev] [PATCH] event/

Re: [dpdk-dev] [PATCH v15 00/23] Add DLB PMD

2020-11-11 Thread McDaniel, Timothy
> -Original Message- > From: David Marchand > Sent: Tuesday, November 10, 2020 9:51 AM > To: McDaniel, Timothy > Cc: dev ; Carrillo, Erik G ; Eads, > Gage ; Van Haaren, Harry > ; Jerin Jacob Kollanukkaran > ; Thomas Monjalon ; Gaetan > Rivet > Subject: Re: [dpdk-dev] [PATCH v15 00/23]

[dpdk-dev] [PATCH] event/dlb: do not free memzone if port create succeeds

2020-11-11 Thread Timothy McDaniel
Add missing returns so that the memzone free is not called if port create is successful. Signed-off-by: Timothy McDaniel --- drivers/event/dlb/pf/dlb_pf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/event/dlb/pf/dlb_pf.c b/drivers/event/dlb/pf/dlb_pf.c index cf88c49..3aeef6f 10

[dpdk-dev] [PATCH] event/dlb: remove duplicate/unused PCI code and constants

2020-11-11 Thread Timothy McDaniel
Use rte_pci_find_ext_capability instead of private version, Remove unused PCI offsets and values Use PCI definitions from rte_pci.h, where available. Signed-off-by: Timothy McDaniel --- drivers/event/dlb/pf/dlb_main.c | 50 +++-- 1 file changed, 8 insertions(+

[dpdk-dev] [PATCH] event/dlb2: add missing delayed token pop logic

2020-11-11 Thread Timothy McDaniel
The code contained in this commit was inadvertently omitted when dissecting the dlb2 code base into discrete patches for upstream. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/dlb2.c | 314 +++-- drivers/event/dlb2/dlb2_selftest.c | 4 +- 2 fi

[dpdk-dev] [PATCH] event/dlb2: remove duplicate/unused PCI code and constants

2020-11-11 Thread Timothy McDaniel
Use rte_pci_find_ext_capability instead of private version, Remove unused PCI offsets and values Use PCI definitions from rte_pci.h, where available. Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/pf/dlb2_main.c | 46 ++- 1 file changed, 7 insertions(+

Re: [dpdk-dev] [PATCH 1/4] Revert "net/mlx5: fix Rx queue count calculation"

2020-11-11 Thread Slava Ovsiienko
Hi, Maxime Thanks a lot for the patch. There is the comment for the entire series. [1]_ > > First issue, when there are more than 8 CQEs to uncompress, the computation > done in this commit cannot work. Because the zip-ai variable describes the > current index inside the CQE8 array and thus

[dpdk-dev] [PATCH v3 4/4] examples: skip installing unbuildable examples

2020-11-11 Thread Bruce Richardson
Rather than just installing all examples, we can use the build checks to filter out any examples that are missing dependencies or are otherwise unbuildable on the current system. Signed-off-by: Bruce Richardson --- examples/meson.build | 54 +++- meson.bui

[dpdk-dev] [PATCH v3 3/4] examples: stop processing build file if build is impossible

2020-11-11 Thread Bruce Richardson
Once it has been determined that an example cannot be built, there is little point in continuing to process the meson.build file for that example, so we can use subdir_done() to return to the calling file. This can potentially prevent problems where later statement in the file may cause an error on

[dpdk-dev] [PATCH v3 2/4] examples/l2fwd-keepalive: skip build when no librt

2020-11-11 Thread Bruce Richardson
When librt is not present on a system, processing the meson.build file for this example application causes an error. Make the library non-mandatory and just mark the example as unbuildable if it is not present. Fixes: 89f0711f9ddf ("examples: build some samples with meson") Cc: sta...@dpdk.org Si

[dpdk-dev] [PATCH v3 1/4] examples: fix flattening directory layout on install

2020-11-11 Thread Bruce Richardson
By installing the examples one-by-one in a loop in the examples meson.build file we effectively flattened out the structure of the examples folder and omitted some common and shared subfolders that were never directly built. Instead, we can remove the loop and just have the whole "examples" folder

Re: [dpdk-dev] [PATCH v2 2/2] examples: skip installing unbuildable examples

2020-11-11 Thread Bruce Richardson
On Wed, Nov 11, 2020 at 03:56:47PM +, Bruce Richardson wrote: > Rather than just installing all examples, we can use the build checks to > filter out any examples that are missing dependencies or are otherwise > unbuildable on the current system. > > Signed-off-by: Bruce Richardson > --- > e

Re: [dpdk-dev] [PATCH v8 09/14] ci: switch to generic Arm builds

2020-11-11 Thread Juraj Linkeš
> -Original Message- > From: Ruifeng Wang > Sent: Wednesday, November 11, 2020 3:52 PM > To: Juraj Linkeš ; Honnappa Nagarahalli > ; bruce.richard...@intel.com; Phil Yang > ; vcchu...@amazon.com; Dharmik Thakkar > ; jerinjac...@gmail.com; > hemant.agra...@nxp.com; Ajit Khaparde (ajit.kha

Re: [dpdk-dev] [PATCH v2] app/test: fix to prevent zcd gcc compile error

2020-11-11 Thread Honnappa Nagarahalli
> -Original Message- > From: Conor Walsh > Sent: Tuesday, November 10, 2020 5:03 AM > To: Honnappa Nagarahalli ; > konstantin.anan...@intel.com > Cc: dev@dpdk.org; linglix.c...@intel.com; Conor Walsh > > Subject: [PATCH v2] app/test: fix to prevent zcd gcc compile error > > When DPDK

Re: [dpdk-dev] [PATCH v2 32/37] net/txgbe: add macsec setting

2020-11-11 Thread Ferruh Yigit
On 11/11/2020 6:49 AM, Jiawen Wu wrote: Add macsec register enable and setting reset operations. Add macsec offload suuport. Signed-off-by: Jiawen Wu <...> @@ -1763,6 +1767,10 @@ txgbe_dev_start(struct rte_eth_dev *dev) */ txgbe_dev_link_update(dev, 0); + /* setup the ma

Re: [dpdk-dev] [PATCH v2 23/37] net/txgbe: add flow API create function

2020-11-11 Thread Ferruh Yigit
On 11/11/2020 6:49 AM, Jiawen Wu wrote: Add support to create operation for flow API. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.h | 2 + drivers/net/txgbe/txgbe_fdir.c | 27 drivers/net/txgbe/txgbe_flow.c | 257 +++ 3 files changed,

Re: [dpdk-dev] [PATCH v2 21/37] net/txgbe: add filter list init and uninit

2020-11-11 Thread Ferruh Yigit
On 11/11/2020 6:49 AM, Jiawen Wu wrote: Add filter list init and uninit. Can you please describe why this global filter lists are needed? Signed-off-by: Jiawen Wu <...>

Re: [dpdk-dev] [PATCH v2 12/37] net/txgbe: add L2 tunnel filter parse rule

2020-11-11 Thread Ferruh Yigit
On 11/11/2020 6:49 AM, Jiawen Wu wrote: Add support to parse flow for L2 tunnel filter. <...> +static int +txgbe_parse_l2_tn_filter(struct rte_eth_dev *dev, + const struct rte_flow_attr *attr, + const struct rte_flow_item pattern[], +

Re: [dpdk-dev] [PATCH v2 00/37] net: add txgbe PMD part 2

2020-11-11 Thread Ferruh Yigit
On 11/11/2020 4:00 PM, Ferruh Yigit wrote: On 11/11/2020 6:48 AM, Jiawen Wu wrote: This patch adds the rest of txgbe PMD for its PF part. Support include flow API, traffic manager, macsec and ipsec. v2: - Rebase on next-net Jiawen Wu (37):    net/txgbe: add ntuple filter init and uninit    net

Re: [dpdk-dev] [PATCH v2 03/37] net/txgbe: add ntuple parse rule

2020-11-11 Thread Ferruh Yigit
On 11/11/2020 6:49 AM, Jiawen Wu wrote: Add support to parse flow for ntuple filter. Can you please add more information to the commit log what does it mean to support 'ntuple filter' in rte_flow? Like if matching packets dropped, etc..? (From the code below I can see only queue action is su

Re: [dpdk-dev] [PATCH v2 06/37] net/txgbe: add ethertype parse rule

2020-11-11 Thread Ferruh Yigit
On 11/11/2020 4:02 PM, Ferruh Yigit wrote: On 11/11/2020 6:49 AM, Jiawen Wu wrote: Add support to parse flow for ethertype filter. Signed-off-by: Jiawen Wu <...> +static int +txgbe_parse_ethertype_filter(struct rte_eth_dev *dev, + const struct rte_flow_attr *attr, +

Re: [dpdk-dev] [PATCH v2 06/37] net/txgbe: add ethertype parse rule

2020-11-11 Thread Ferruh Yigit
On 11/11/2020 6:49 AM, Jiawen Wu wrote: Add support to parse flow for ethertype filter. Signed-off-by: Jiawen Wu <...> +static int +txgbe_parse_ethertype_filter(struct rte_eth_dev *dev, +const struct rte_flow_attr *attr, +const struct

Re: [dpdk-dev] [PATCH v2 00/37] net: add txgbe PMD part 2

2020-11-11 Thread Ferruh Yigit
On 11/11/2020 6:48 AM, Jiawen Wu wrote: This patch adds the rest of txgbe PMD for its PF part. Support include flow API, traffic manager, macsec and ipsec. v2: - Rebase on next-net Jiawen Wu (37): net/txgbe: add ntuple filter init and uninit net/txgbe: support ntuple filter add and delete

Re: [dpdk-dev] [PATCH] net/virtio: enable packet data prefetch on x86

2020-11-11 Thread David Marchand
On Wed, Nov 11, 2020 at 4:54 PM Bruce Richardson wrote: > > On Wed, Nov 11, 2020 at 04:45:25PM +0100, David Marchand wrote: > > On Wed, Nov 11, 2020 at 4:40 PM Marvin Liu wrote: > > > > > > Data prefetch instruction can preload data into cpu’s hierarchical > > > cache before data access. Virtio d

[dpdk-dev] [PATCH v2 2/2] examples: skip installing unbuildable examples

2020-11-11 Thread Bruce Richardson
Rather than just installing all examples, we can use the build checks to filter out any examples that are missing dependencies or are otherwise unbuildable on the current system. Signed-off-by: Bruce Richardson --- examples/meson.build | 54 +++- meson.bui

[dpdk-dev] [PATCH v2 1/2] examples: fix flattening directory layout on install

2020-11-11 Thread Bruce Richardson
By installing the examples one-by-one in a loop in the examples meson.build file we effectively flattened out the structure of the examples folder and omitted some common and shared subfolders that were never directly built. Instead, we can remove the loop and just have the whole "examples" folder

Re: [dpdk-dev] [PATCH] net/virtio: enable packet data prefetch on x86

2020-11-11 Thread Bruce Richardson
On Wed, Nov 11, 2020 at 04:45:25PM +0100, David Marchand wrote: > On Wed, Nov 11, 2020 at 4:40 PM Marvin Liu wrote: > > > > Data prefetch instruction can preload data into cpu’s hierarchical > > cache before data access. Virtio datapath utilized this feature for > > data access acceleration. As co

Re: [dpdk-dev] [PATCH] net/virtio: enable packet data prefetch on x86

2020-11-11 Thread David Marchand
On Wed, Nov 11, 2020 at 4:40 PM Marvin Liu wrote: > > Data prefetch instruction can preload data into cpu’s hierarchical > cache before data access. Virtio datapath utilized this feature for > data access acceleration. As config RTE_PMD_PACKET_PREFETCH was > discarded, now packet data prefetch is

[dpdk-dev] [PATCH] net/virtio: enable packet data prefetch on x86

2020-11-11 Thread Marvin Liu
Data prefetch instruction can preload data into cpu’s hierarchical cache before data access. Virtio datapath utilized this feature for data access acceleration. As config RTE_PMD_PACKET_PREFETCH was discarded, now packet data prefetch is enabled based on architecture. Signed-off-by: Marvin Liu d

[dpdk-dev] [PATCH v2] net/txgbe: return changed to fix gcc compile error

2020-11-11 Thread Conor Walsh
When DPDK is compiled with gcc 7.5 with the optimization level set to 1 gcc sees the offset variable in txgbe_ethdev.c as possibly being uninitialised. To correct this the final return statement in txgbe_get_offset_by_id was simplified to return -1. Signed-off-by: Conor Walsh --- drivers/net/txg

Re: [dpdk-dev] [EXTERNAL] [RFC] pthread on Windows

2020-11-11 Thread Nick Connolly
Hi Khoa, As far as I can see, the DPDK Performance Test Lab at University of New Hampshire provides the guarantee that the standard tree will build just fine on Windows (https://lab.dpdk.org/results/dashboard/status/) - in particular, the Windows-Compile-DPDK-Meson test. Regards, Nick On 03

Re: [dpdk-dev] [kmods PATCH] windows: normalize line-endings

2020-11-11 Thread Dmitry Kozlyuk
On Tue, 03 Nov 2020 10:05:43 +, Luca Boccassi wrote: > The patch looks good to me, as I really need all files to be checked in > with LF only as a hard requirement before I can upload to > Debian/Ubuntu, so: > > Acked-by: Luca Boccassi > > Does the change also stop future check-ins of CRLF f

Re: [dpdk-dev] [kmods PATCH] windows: normalize line-endings

2020-11-11 Thread Luca Boccassi
On Wed, 2020-11-11 at 15:03 +, Luca Boccassi wrote: > On Wed, 2020-11-11 at 16:02 +0100, Thomas Monjalon wrote: > > 29/10/2020 23:55, Dmitry Kozlyuk: > > > MSBuild XML files have to use CRLF line-endings, otherwise any change > > > results in the whole file being rewritten with CRLF line-ending

Re: [dpdk-dev] [kmods PATCH] windows: normalize line-endings

2020-11-11 Thread Luca Boccassi
On Wed, 2020-11-11 at 16:02 +0100, Thomas Monjalon wrote: > 29/10/2020 23:55, Dmitry Kozlyuk: > > MSBuild XML files have to use CRLF line-endings, otherwise any change > > results in the whole file being rewritten with CRLF line-endings by > > Visual Studio. However, it's inconvenient to have such

Re: [dpdk-dev] [kmods PATCH] windows: normalize line-endings

2020-11-11 Thread Luca Boccassi
On Tue, 2020-11-03 at 10:05 +, Luca Boccassi wrote: > On Tue, 2020-11-03 at 10:42 +0300, Dmitry Kozlyuk wrote: > > Hi Naty, > > > > > Doesn't the 'input' option gets you original (unmodified) line endings on > > > checkout? > > > If a file in the repo has CRLF endings, Unix devs will get it a

Re: [dpdk-dev] [PATCH v1] examples/vhost: fix ioat dependency issue

2020-11-11 Thread Bruce Richardson
On Wed, Nov 11, 2020 at 03:36:25PM +0100, David Marchand wrote: > On Wed, Nov 11, 2020 at 12:29 PM Cheng Jiang wrote: > > > > Fix vhost-switch compiling issue when ioat dependency is missing. > > Change 'RTE_x86' check into 'RTE_RAW_IOAT' check in meson build file > > and update Makefile. > > Sti

Re: [dpdk-dev] [kmods PATCH] windows: normalize line-endings

2020-11-11 Thread Thomas Monjalon
29/10/2020 23:55, Dmitry Kozlyuk: > MSBuild XML files have to use CRLF line-endings, otherwise any change > results in the whole file being rewritten with CRLF line-endings by > Visual Studio. However, it's inconvenient to have such files checked-out > with CLRF in Unix environments. > > Add sugge

Re: [dpdk-dev] [PATCH v8 09/14] ci: switch to generic Arm builds

2020-11-11 Thread Ruifeng Wang
> -Original Message- > From: Juraj Linkeš > Sent: Wednesday, November 11, 2020 7:46 PM > To: Honnappa Nagarahalli ; > bruce.richard...@intel.com; Ruifeng Wang ; Phil > Yang ; vcchu...@amazon.com; Dharmik Thakkar > ; jerinjac...@gmail.com; > hemant.agra...@nxp.com; Ajit Khaparde (ajit.khap

Re: [dpdk-dev] [PATCH v1] examples/vhost: fix ioat dependency issue

2020-11-11 Thread David Marchand
On Wed, Nov 11, 2020 at 12:29 PM Cheng Jiang wrote: > > Fix vhost-switch compiling issue when ioat dependency is missing. > Change 'RTE_x86' check into 'RTE_RAW_IOAT' check in meson build file > and update Makefile. Still failing for me. 98b4c65506 - (HEAD) examples/vhost: fix ioat dependency iss

Re: [dpdk-dev] [PATCH] net/af_xdp: do not use fixed size storage for pointer

2020-11-11 Thread Ferruh Yigit
On 11/9/2020 6:00 PM, Loftus, Ciara wrote: 'uint64_t' is used to hold the pointer, for 32-bits build this assumption is wrong and giving following build error: rte_eth_af_xdp.c: In function ‘xdp_umem_configure’: rte_eth_af_xdp.c:970:15: error: cast to pointer from integer of different size

[dpdk-dev] [PATCH v9 14/14] config: fix Arm implementer and its SoCs

2020-11-11 Thread Juraj Linkeš
Fix the implementer and part number of DPAA and ARMADA SoCs. The current values of 16 cores and 1 NUMA node don't cover all SoCs from the Arm implementer, e.g. Taishan 2280 has 64 cores and 4 NUMA nodes. Increase these to 64 and 4 to widen the coverage. Add configuration to SoC options where smalle

[dpdk-dev] [PATCH v9 11/14] build: disable Arm drivers

2020-11-11 Thread Juraj Linkeš
A few options that disabled drivers in the old makefiles were improperly ported to the meson build system. Fix this by adding a to the list of disabled drivers, similarly how the command line option works. Remove unneeded driver options ported from the old makefile system. Add support for removing

[dpdk-dev] [PATCH v9 12/14] build: disable libnuma in cross builds

2020-11-11 Thread Juraj Linkeš
Some Arm SoCs are not NUMA systems. Add the capability to disable NUMA for cross build and disabled NUMA in Arm cross files. Signed-off-by: Juraj Linkeš --- config/arm/arm64_armada_linux_gcc | 1 + config/arm/arm64_bluefield_linux_gcc | 1 + config/arm/arm64_dpaa_linux_gcc

[dpdk-dev] [PATCH v9 13/14] build: add Arm SoC meson option

2020-11-11 Thread Juraj Linkeš
Add Arm SoC configuration to Arm meson.build and add a meson option to enable those options for native builds. This is preferable to specifying a cross file when doing aarch64 -> aarch64 builds, since the cross file specifies the toolchain as well. Signed-off-by: Juraj Linkeš --- config/arm/arm6

[dpdk-dev] [PATCH v9 10/14] build: add core and NUMA counts to cross files

2020-11-11 Thread Juraj Linkeš
Add support for setting core count and numa nodes in cross files. The values specified in cross files will override the default values. Also add missing default values to Arm config. Signed-off-by: Juraj Linkeš --- config/arm/arm64_armada_linux_gcc | 2 ++ config/arm/arm64_armv8

[dpdk-dev] [PATCH v9 09/14] build: optional NUMA and cpu counts detection

2020-11-11 Thread Juraj Linkeš
Add an option to automatically discover the host's numa and cpu counts and use those values for a non cross-build. Give users the option to override the per-arch default values or values from cross files by specifying them on the command line with -Dmax_lcores and -Dmax_numa_nodes. Signed-off-by:

[dpdk-dev] [PATCH v9 06/14] build: organize Arm config into dict

2020-11-11 Thread Juraj Linkeš
Use dictionary lookup instead of checking for existing variables, iterating over all elements in the list or checking lists for optional configuration. Move variable contents into the dictionary for variables that would be referenced only once. Fallback to generic part number if the discovered part

[dpdk-dev] [PATCH v9 08/14] build: use native machine args in Arm native build

2020-11-11 Thread Juraj Linkeš
Letting the compiler decide is going to yield the best results for native builds, so use native machine args. Signed-off-by: Juraj Linkeš --- config/arm/meson.build | 54 ++ 1 file changed, 28 insertions(+), 26 deletions(-) diff --git a/config/arm/meson.b

[dpdk-dev] [PATCH v9 07/14] build: isolate configuration for generic build

2020-11-11 Thread Juraj Linkeš
Use generic configuration for the only build where it makes sense - the generic build. For other builds, if we don't know either of implementer ID or part number, the build is not supported. Add part numbers to cross files where fallback to generic configuration is assumed. Signed-off-by: Juraj Li

[dpdk-dev] [PATCH v9 04/14] build: reformat and move Arm config and comments

2020-11-11 Thread Juraj Linkeš
Change formatting so that it's more consistent and readable, add/modify comments/stdout messages, move configuration options to more appropriate places and make the order consistent according to these rules: 1. First list generic configuration options, then list options that may be overwritten.

[dpdk-dev] [PATCH v9 03/14] build: remove unused or superfluous variables

2020-11-11 Thread Juraj Linkeš
Remove variables that were either not used, referenced just once or not needed. Signed-off-by: Juraj Linkeš Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- config/arm/meson.build | 28 +++- 1 file changed, 7 insertions(+), 21 deletions(-) diff --git a/c

[dpdk-dev] [PATCH v9 05/14] build: simplify how Arm flags are processed

2020-11-11 Thread Juraj Linkeš
Set flags in one loop. Append flags to a list and use the list in the loop. Signed-off-by: Juraj Linkeš Reviewed-by: Honnappa Nagarahalli --- config/arm/meson.build | 37 + 1 file changed, 17 insertions(+), 20 deletions(-) diff --git a/config/arm/meson.build

[dpdk-dev] [PATCH v9 02/14] build: rename Arm build variables

2020-11-11 Thread Juraj Linkeš
Rename Arm build variables and values so that they better conform to Arm specifications. Also rename generically sounding variable to names that better capture what the variables hold. Rename machine_args_generic to part_number_config_arm since the variable contains more than just the generic mach

[dpdk-dev] [PATCH v9 00/14] Arm build options rework

2020-11-11 Thread Juraj Linkeš
The current way of specifying Arm configuration options is insufficient since we can't identify the SoC we're building for from the MIDR information. For example, we can't distinguish between N1SDP, Graviton2 or Ampere Altra. Add a way to specify the cpu count and numa node count for cross builds

[dpdk-dev] [PATCH v9 01/14] build: alias default build as generic

2020-11-11 Thread Juraj Linkeš
The current machine='default' build name is not descriptive. The actual default build is machine='native'. Add an alternative string which does the same build and better describes what we're building: machine='generic'. Leave machine='default' for backwards compatibility. Signed-off-by: Juraj Link

Re: [dpdk-dev] [PATCH v1] net/txgbe: offset needs to be initialised to fix gcc compile error

2020-11-11 Thread Ferruh Yigit
On 11/11/2020 1:05 PM, Conor Walsh wrote: When DPDK is compiled with gcc 7.5 with the optimization level set to 1 gcc sees the offset variable in txgbe_ethdev.c as possibly being uninitialised. To correct this error offset has been initialised to 0 in txgbe_ethdev.c Signed-off-by: Conor Walsh -

Re: [dpdk-dev] [PATCH]net/hinic: fix coredump when secondary process using the hinic port.

2020-11-11 Thread Ferruh Yigit
On 11/2/2020 2:48 PM, Qingqing Li wrote: the reason is that during the stage of secondary process port initialization, it lacks the initialization of "eth_dev->dev_ops". Signed-off-by: Qingqing Li Hi Ziyang, Guoyang, Xiaoyun, The patch is around for a long time [1], can you please review the

[dpdk-dev] [PATCH v1] net/txgbe: offset needs to be initialised to fix gcc compile error

2020-11-11 Thread Conor Walsh
When DPDK is compiled with gcc 7.5 with the optimization level set to 1 gcc sees the offset variable in txgbe_ethdev.c as possibly being uninitialised. To correct this error offset has been initialised to 0 in txgbe_ethdev.c Signed-off-by: Conor Walsh --- drivers/net/txgbe/txgbe_ethdev.c | 4 ++-

Re: [dpdk-dev] [RFC] app/testpmd: fix MTU after device configure

2020-11-11 Thread Ferruh Yigit
On 11/5/2020 6:09 PM, Ferruh Yigit wrote: In 'rte_eth_dev_configure()', if 'DEV_RX_OFFLOAD_JUMBO_FRAME' is not set the max frame size is limited to 'RTE_ETHER_MAX_LEN' (1518). This is mistake because for the PMDs that has frame size bigger than "RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN" (18 bytes),

Re: [dpdk-dev] [PATCH v3] app/testpmd: support age shared action context

2020-11-11 Thread Ferruh Yigit
On 11/10/2020 5:06 PM, Matan Azrad wrote: When an age action becomes aged-out the next call for rte_flow_get_aged_flows API should return the action context supplied by the action configuration structure. In case the age action is created by the shared action API, the shared action context of th

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix shared RSS action release

2020-11-11 Thread Ferruh Yigit
On 11/10/2020 3:28 AM, Suanming Mou wrote: As shared RSS action will be shared by multiple flows, the action is created as global standalone action and managed only by the relevant shared action management functions. Currently, hrxqs will be created by shared RSS action or general queue action.

Re: [dpdk-dev] [PATCH] net/ice: fix full mask issue for ACL rule

2020-11-11 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Wednesday, November 11, 2020 7:30 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Xing, Beilei ; Ding, Xuan > ; Su, Simei > Subject: [PATCH] net/ice: fix full mask issue for ACL rule > > A rule with an imperfect match(wildcarding) will be route

Re: [dpdk-dev] [PATCH v2] devtools: fix 32-bits build

2020-11-11 Thread Ferruh Yigit
On 11/9/2020 9:02 PM, Thomas Monjalon wrote: 09/11/2020 18:44, Thomas Monjalon: 09/11/2020 18:20, Thomas Monjalon: 09/11/2020 18:15, Ferruh Yigit: On 11/9/2020 5:01 PM, Thomas Monjalon wrote: 09/11/2020 17:48, Ferruh Yigit: I can send a new version to reset 'CUSTOM_PKG_CONFIG_PATH', what is

Re: [dpdk-dev] DPDK AF_XDP test results.

2020-11-11 Thread Loftus, Ciara
> > Hi All, > There is a test plan for the performance tests of different > scenarios > with AF_XDP in the dpdk docs > https://doc.dpdk.org/dts/test_plans/af_xdp_test_plan.html , but I am not > able to find the test results of the same. Can anyone please help in sharing > the resul

Re: [dpdk-dev] [PATCH dpdk-kmods v2] igb_uio: pass MODULE_CFLAGS in Kbuild

2020-11-11 Thread Thomas Monjalon
11/11/2020 13:16, luca.bocca...@gmail.com: > From: Luca Boccassi > > With the legacy build system MODULE_CFLAGS can be set to pass compiler > flags specific for the kernel modules builds. > This is used currently by Ubuntu and Debian. > Set ccflags-y in the Kbuild to achieve the same result with

[dpdk-dev] [PATCH dpdk-kmods v2] igb_uio: pass MODULE_CFLAGS in Kbuild

2020-11-11 Thread luca . boccassi
From: Luca Boccassi With the legacy build system MODULE_CFLAGS can be set to pass compiler flags specific for the kernel modules builds. This is used currently by Ubuntu and Debian. Set ccflags-y in the Kbuild to achieve the same result with Meson, and to keep backward compatbility with older scr

Re: [dpdk-dev] [PATCH v8 09/14] ci: switch to generic Arm builds

2020-11-11 Thread Juraj Linkeš
> -Original Message- > From: Honnappa Nagarahalli > Sent: Sunday, November 8, 2020 3:43 PM > To: Juraj Linkeš ; bruce.richard...@intel.com; > Ruifeng Wang ; Phil Yang ; > vcchu...@amazon.com; Dharmik Thakkar ; > jerinjac...@gmail.com; hemant.agra...@nxp.com; Ajit Khaparde > (ajit.khapa..

[dpdk-dev] [PATCH] net/ice: fix full mask issue for ACL rule

2020-11-11 Thread Simei Su
A rule with an imperfect match(wildcarding) will be routed through ACL. A perfect match should be rejected by ACL. Fixes: 40d466fa9f76 ("net/ice: support ACL filter in DCF") Signed-off-by: Simei Su --- drivers/net/ice/ice_acl_filter.c | 44 1 file change

[dpdk-dev] [PATCH v1] examples/vhost: fix ioat dependency issue

2020-11-11 Thread Cheng Jiang
Fix vhost-switch compiling issue when ioat dependency is missing. Change 'RTE_x86' check into 'RTE_RAW_IOAT' check in meson build file and update Makefile. Signed-off-by: Cheng Jiang --- examples/vhost/Makefile| 5 + examples/vhost/ioat.h | 2 +- examples/vhost/meson.build | 2 +- 3

Re: [dpdk-dev] [PATCH 1/1] devtools: fix build test config inheritance from env

2020-11-11 Thread Thomas Monjalon
11/11/2020 12:13, Ferruh Yigit: > On 11/11/2020 11:00 AM, Bruce Richardson wrote: > > On Wed, Nov 11, 2020 at 11:37:41AM +0100, Thomas Monjalon wrote: > >> 11/11/2020 10:18, Bruce Richardson: > >>> On Tue, Nov 10, 2020 at 06:09:45PM +, Ferruh Yigit wrote: > On 11/10/2020 5:55 PM, Thomas Mo

Re: [dpdk-dev] [PATCH 1/1] devtools: fix build test config inheritance from env

2020-11-11 Thread Ferruh Yigit
On 11/11/2020 11:00 AM, Bruce Richardson wrote: On Wed, Nov 11, 2020 at 11:37:41AM +0100, Thomas Monjalon wrote: 11/11/2020 10:18, Bruce Richardson: On Tue, Nov 10, 2020 at 06:09:45PM +, Ferruh Yigit wrote: On 11/10/2020 5:55 PM, Thomas Monjalon wrote: 10/11/2020 18:18, Ferruh Yigit: On

Re: [dpdk-dev] [PATCH 1/1] devtools: fix build test config inheritance from env

2020-11-11 Thread Bruce Richardson
On Wed, Nov 11, 2020 at 11:37:41AM +0100, Thomas Monjalon wrote: > 11/11/2020 10:18, Bruce Richardson: > > On Tue, Nov 10, 2020 at 06:09:45PM +, Ferruh Yigit wrote: > > > On 11/10/2020 5:55 PM, Thomas Monjalon wrote: > > > > 10/11/2020 18:18, Ferruh Yigit: > > > > > On 11/9/2020 9:00 PM, Thomas

Re: [dpdk-dev] [PATCH v10 7/7] eal: mark old definitions as deprecated

2020-11-11 Thread Luca Boccassi
On Tue, 2020-11-10 at 14:55 -0800, Stephen Hemminger wrote: > This patch marks the compatiablity macros with RTE_DEPRECATED > which causes a warning if used. There are no remaining warnings > in the current release. > > Signed-off-by: Stephen Hemminger > --- > lib/librte_eal/include/rte_bus.h

Re: [dpdk-dev] [PATCH v10 5/7] app/test: use new allowlist and blocklist

2020-11-11 Thread Luca Boccassi
On Tue, 2020-11-10 at 14:55 -0800, Stephen Hemminger wrote: > Test the renamed blocklist and allowlist arguments. > Use new terms in test variable names as well. > > Signed-off-by: Stephen Hemminger > Acked-by: Luca Boccassi > --- > app/test/autotest.py| 16 +-- > app/test/autot

Re: [dpdk-dev] [PATCH v10 6/7] auto test comment fix

2020-11-11 Thread Luca Boccassi
On Tue, 2020-11-10 at 14:55 -0800, Stephen Hemminger wrote: > --- > app/test/autotest_runner.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Luca Boccassi -- Kind regards, Luca Boccassi

Re: [dpdk-dev] [PATCH v10 4/7] doc: update documentation to reflect new options

2020-11-11 Thread Luca Boccassi
On Tue, 2020-11-10 at 14:55 -0800, Stephen Hemminger wrote: > Replace old option syntax -w with -a and update any wording > around blacklisting. > > Signed-off-by: Stephen Hemminger > --- > doc/guides/cryptodevs/dpaa2_sec.rst | 6 ++-- > doc/guides/cryptodevs/dpaa_sec.rst|

Re: [dpdk-dev] [PATCH v10 2/7] drivers: replace references to blacklist

2020-11-11 Thread Luca Boccassi
On Tue, 2020-11-10 at 14:55 -0800, Stephen Hemminger wrote: > Use the new terminology blocked to describe when devices > are excluded from being used. > > Signed-off-by: Stephen Hemminger > Acked-by: Luca Boccassi > Acked-by: Hemant Agrawal > --- > drivers/bus/dpaa/dpaa_bus.c| 7 +++--

Re: [dpdk-dev] [PATCH v10 3/7] eal: replace pci-whitelist/pci-blacklist options

2020-11-11 Thread Luca Boccassi
On Tue, 2020-11-10 at 14:55 -0800, Stephen Hemminger wrote: > Replace -w / --pci-whitelist with -a / --allow options > and --pci-blacklist with --block. > The -b short option remains unchanged. > > Allow the old options for now, but print a nag > warning since old options are deprecated. > > Sign

Re: [dpdk-dev] [PATCH v10 1/7] eal: replace usage of blacklist/whitelist in enum

2020-11-11 Thread Luca Boccassi
On Tue, 2020-11-10 at 14:55 -0800, Stephen Hemminger wrote: > This patch renames the enum values in the EAL include files. > As a backward compatible temporary migration tool, define > a replacement mapping for old values. > > The old names relating to blacklist and whitelist are replaced > by blo

Re: [dpdk-dev] [PATCH 1/1] devtools: fix build test config inheritance from env

2020-11-11 Thread Thomas Monjalon
11/11/2020 10:18, Bruce Richardson: > On Tue, Nov 10, 2020 at 06:09:45PM +, Ferruh Yigit wrote: > > On 11/10/2020 5:55 PM, Thomas Monjalon wrote: > > > 10/11/2020 18:18, Ferruh Yigit: > > > > On 11/9/2020 9:00 PM, Thomas Monjalon wrote: > > > > > PKG_CONFIG_PATH is specific to each target, so i

[dpdk-dev] [PATCH v2] net/i40e: fix argument in RSS action

2020-11-11 Thread Kumar Amber
The driver must check for the queue number in the RSS action list and if not should return with a proper error message to user. Bugzilla ID: 573 Fixes: 9486d60b94b5 ("net/i40e: fix flow RSS queue index check") Cc: wei.zh...@intel.com Signed-off-by: Kumar Amber --- drivers/net/i40e/i40e_flow.c |

Re: [dpdk-dev] [PATCH v8 12/14] build: disable Arm drivers

2020-11-11 Thread Juraj Linkeš
> -Original Message- > From: dev On Behalf Of Juraj Linkeš > Sent: Tuesday, November 10, 2020 10:03 AM > To: Honnappa Nagarahalli ; > bruce.richard...@intel.com; Ruifeng Wang ; Phil > Yang ; vcchu...@amazon.com; Dharmik Thakkar > ; jerinjac...@gmail.com; > hemant.agra...@nxp.com; Ajit Kh

Re: [dpdk-dev] [PATCH v2 2/3] vfio: fix DMA mapping granularity for type1 iova as va

2020-11-11 Thread Burakov, Anatoly
On 11-Nov-20 5:08 AM, Nithin Dabilpuram wrote: On Tue, Nov 10, 2020 at 02:17:39PM +, Burakov, Anatoly wrote: On 05-Nov-20 9:04 AM, Nithin Dabilpuram wrote: Partial unmapping is not supported for VFIO IOMMU type1 by kernel. Though kernel gives return as zero, the unmapped size returned will

[dpdk-dev] [PATCH] test/cryptodev: fix typo in blockcipher test output

2020-11-11 Thread Ciara Power
The print statement had a typo, "sesionless" should have been "sessionless". This is now fixed. Fixes: afcfa2fd0431 ("test/crypto: check session-less support") Cc: pablo.de.lara.gua...@intel.com Cc: sta...@dpdk.org Signed-off-by: Ciara Power --- app/test/test_cryptodev_blockcipher.c | 2 +- 1 f

Re: [dpdk-dev] [PATCH] net/tap: Allow all-zero checksum for UDP over IPv4

2020-11-11 Thread Ferruh Yigit
On 11/11/2020 7:23 AM, Michael Pfeiffer wrote: Hi, On Tue, 2020-11-10 at 15:59 +, Ferruh Yigit wrote: On 11/9/2020 2:22 PM, Michael Pfeiffer wrote: Unlike TCP, UDP checksums are optional and may be zero to indicate "not set" [RFC 768] (except for IPv6, where this prohibited [RFC 8200]). Ad

  1   2   >