From: Selwin Sebastian
Added support for fw_version_get API
Signed-off-by: Selwin Sebastian
---
doc/guides/nics/features/axgbe.ini | 1 +
drivers/net/axgbe/axgbe_ethdev.c | 1 +
drivers/net/axgbe/axgbe_rxtx.c | 21 +
drivers/net/axgbe/axgbe_rxtx.h | 3 +++
4 fi
> -Original Message-
> From: Burakov, Anatoly
> Sent: Thursday, November 19, 2020 00:28
> To: Liu, Yongxin ; dev@dpdk.org;
> tho...@monjalon.net
> Subject: Re: [dpdk-dev] [PATCH v2] usertools/devbind: fix binding for
> built-in 1kernel drivers
>
>
> On 18-Nov-20 2:58 AM, Yongxin Liu wrot
Hi,
> -Original Message-
> From: Yigit, Ferruh
> Sent: Thursday, November 19, 2020 11:53
> To: Jerin Jacob ; Dumitrescu, Cristian
> ; Hemant Agrawal
> ; Sachin Saxena ;
> Ray Kinsella ; Neil Horman ; Xu,
> Rosen ; Wu, Jingjing ; Xing,
> Beilei ; Nithin Dabilpuram
> ; Ajit Khaparde
> ; Rav
A driver can be loaded as a dynamic module or a built-in module.
In commit 681a67288655 ("usertools: check if module is loaded
before binding"), script only checks modules in /sys/module/.
However, for built-in kernel driver, it only shows up in /sys/module/,
if it has a version or at least one pa
Acked-by: Jiayu Hu
> -Original Message-
> From: yang_y...@163.com
> Sent: Thursday, November 19, 2020 2:44 PM
> To: dev@dpdk.org
> Cc: Hu, Jiayu ; tho...@monjalon.net;
> yangy...@inspur.com; yang_y...@163.com
> Subject: [PATCH v4] gso: add VXLAN UDP/IPv4 support
>
> From: Yi Yang
>
>
From: Yi Yang
As most NICs do not support segmentation for VXLAN-encapsulated
UDP/IPv4 packets, this patch adds VXLAN UDP/IPv4 GSO support.
OVS DPDK can significantly improve VXLAN UDP/IPv4 performance by
VXLAN UDP/IPv4 GSO.
Signed-off-by: Yi Yang
---
Changelog:
v3 -> v4:
- Use more precise
Hi, beilei
> -Original Message-
> From: Xing, Beilei
> Sent: Thursday, November 19, 2020 2:16 PM
> To: dev@dpdk.org
> Cc: Guo, Jia ; Xing, Beilei ;
> sta...@dpdk.org
> Subject: [PATCH] net/i40e: fix conflict with multi-driver
>
Seems that this patch both handle multi-driver and none mul
> -Original Message-
> From: yang_y...@163.com
> Sent: Monday, November 16, 2020 9:11 AM
> To: dev@dpdk.org
> Cc: Hu, Jiayu ; Ananyev, Konstantin
> ; tho...@monjalon.net;
> yangy...@inspur.com; yang_y...@163.com
> Subject: [PATCH v3] gso: add VXLAN UDP GSO support
>
> From: Yi Yang
>
Hi,
Recently this patch
https://github.com/DPDK/dpdk/commit/5284adad3e95025f9901869f581c8c04ea642d32
made the following change:
* mbuf: Removed the unioned fields ``userdata`` and ``udata64``
from the structure ``rte_mbuf``. It is replaced with dynamic fields.
Which breaks the SPDK project’
>
> Apologies for the delay, I missed your reply Li.
> With the data you've provided I think the patch is justified.
> I think the rollback requires some explanation in the code as it may not be
> immediately clear what is happening.
> I suggest a v3 with either a comment above the rollback, or a
Hi,
We are seeing a ovs-vswitchd service crash with segfault in the
librte_vhost library when a DPDK application within a guest VM is stopped.
We are using OVS 2.11.1 on CentOS 7.6 (3.10.0-1062 Linux kernel)
with DPDK 18.11.2.
We are using OVS-DPDK o
When creating a flow with eCPRI item, the mask and the value are both
needed in order to build the matching criteria.
In the current implementation, the unused value bits clear operation
was missed when filling the mask and value fields. For the value, the
bits not required were not masked with th
The sample and mirror action objects are maintained on the list
shared between the ports belonging to the same multiport Infiniband
device(between representors).
The actions in the NIC steering domains might contain the references
to the sub-flow action objects created over the given port. The act
Hi,
(Seems I replied to the wrong version yesterday.)
Since the issue happens only in the flow flush when the port status change.
The root cause is the LSC callback should not be called before the port start
is done.
BR,
SuanmingMou
> -Original Message-
> From: dev On Behalf Of Weifeng
On Mon, Nov 16, 2020 at 9:11 PM Ajit Khaparde
wrote:
>
> Update the OS versions. Remove some old OS versions.
>
> Signed-off-by: Ajit Khaparde
Patch applied to dpdk-next-net-brcm.
> ---
> doc/guides/nics/bnxt.rst | 8 +++-
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/d
Add link for firmware/OOT kernel driver/DDP download
Add matching List.
Signed-off-by: Qi Zhang
---
v2:
- correct the DDP version number
doc/guides/nics/ice.rst | 28 +---
1 file changed, 25 insertions(+), 3 deletions(-)
diff --git a/doc/guides/nics/ice.rst b/doc/guide
On Tue, Nov 17, 2020 at 10:37 PM Andrew Rybchenko
wrote:
>
> On 11/18/20 3:34 AM, Ajit Khaparde wrote:
> > On Mon, Nov 16, 2020 at 8:13 AM Ferruh Yigit wrote:
> >
> >> On 11/16/2020 7:55 AM, Xiaoyu Min wrote:
> >>> From: Xiaoyu Min
> >>>
> >>> The rte_flow_item_eth and rte_flow_item_vlan items a
On Wed, Nov 18, 2020 at 1:15 AM Thomas Monjalon wrote:
>
> 18/11/2020 05:15, Radha Mohan:
> > On Mon, Nov 16, 2020 at 12:28 PM Thomas Monjalon
> > wrote:
> > > 16/11/2020 19:28, Radha Mohan:
> > > > On Fri, Nov 13, 2020 at 2:39 PM Thomas Monjalon
> > > > wrote:
> > > > > 13/11/2020 20:18, Radh
On Wed, Nov 18, 2020 at 6:43 AM David Marchand
wrote:
>
> On Wed, Nov 18, 2020 at 12:48 PM Ferruh Yigit wrote:
> >
> > Removing useless 'return' statement.
> >
> > Fixes: b2da02480cb7 ("net/bnxt: support EEM system memory")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Ferruh Yigit
> > ---
> >
>
> On Wed, Nov 18, 2020 at 04:04:25PM +0100, Thomas Monjalon wrote:
> > 18/11/2020 15:54, Bruce Richardson:
> > > On Wed, Nov 18, 2020 at 03:42:36PM +0100, Thomas Monjalon wrote:
> > > > 18/11/2020 15:19, Juraj Linkeš:
> > > > > From: Thomas Monjalon
> > > > > > 16/11/2020 10:13, Bruce Richard
On Wed, 2020-11-18 at 18:11 +, Conor Walsh wrote:
> On some systems Wformat-nonliteral and Wformat-security could not be
> checked without Wformat also being specified this causes a compile
> warning on these systems. This patchset adds Wformat to
> config/meson.build and fixes some format issu
On Wed, Nov 18, 2020 at 4:38 PM Anatoly Burakov
wrote:
>
> Currently, the Linux GSG mentions UIO drivers first. This is not ideal
> as for the longest time, the recommended way to use DPDK with hardware
> devices has been to use VFIO driver.
>
> This commit simply moves UIO section after VFIO, wit
Tunnel offload API provides applications with ability to restore
packet outer headers after partial offload. Exact feature execution
depends on hardware abilities and PMD implementation. Hardware that is
supported by MLX5 PMD places a mark on a packet after partial offload.
PMD decodes that mark an
&device requires the %u format specifer not the %d specifier, as
&device is unsigned.
Fixes: a46bbb57605b ("net/bnxt: update multi device design")
Cc: michael.wi...@broadcom.com
Signed-off-by: Conor Walsh
---
drivers/net/bnxt/tf_core/tf_core.c | 8
1 file changed, 4 insertions(+), 4 de
On some CentOS/RHEL systems using gcc 8.3.1 to compile dpdk, gcc shows a
warning on every build step saying that -Wformat-nonliteral and
-Wformat-security warnings will be ignored unless -Wformat is
also specified as a compiler flag. When the build is run with -werror
the build will fail due to the
On some systems Wformat-nonliteral and Wformat-security could not be
checked without Wformat also being specified this causes a compile
warning on these systems. This patchset adds Wformat to
config/meson.build and fixes some format issues that this exposed.
---
v2:
- expand explaination of patch
Hi Ferruh,
> -Original Message-
> From: Ferruh Yigit
> Sent: Tuesday, November 17, 2020 8:07 PM
> To: Jiawei(Jonny) Wang ; wenzhuo...@intel.com;
> beilei.x...@intel.com; bernard.iremon...@intel.com; Ori Kam
> ; NBU-Contact-Thomas Monjalon
> ; Raslan Darawsheh
> Cc: dev@dpdk.org
> Subject
In regex QP setup, the PMD creates some SQ objects.
When SQ object creation is failed, the previous SQ objects memory were
not freed what caused a memory leak.
Free them.
Fixes: 54fa1f6a67d7 ("regex/mlx5: add teardown for fastpath buffers")
Signed-off-by: Michael Baum
Acked-by: Ori Kam
---
d
The mlx5_regex_pci_probe function allocates a mlx5_regex_priv structure
using rte_zmalloc.
If the allocation fails, the function jumps to the dev_error label in
order to release previously allocated resources in the function.
However, in the dev_error label it attempts to refer to the internal
fie
The rxp_flush_rules function tries to read and write to the register
several times using DevX API, and when it fails the function returns an
error.
Similarly the rxp_init_eng function also tries to write to the register
several times, and if writing is failed, it returns an error too.
Both functio
The rxp_poll_csr_for_value function defines a variable named ret. It is
the return value of the function, and It is updated to 0 by default
later in the function.
Similarly the rxp_init_rtru function also defines a variable named ret.
The function assigns into it return values from functions during
The constant representing the size of the metadata is defined as a
regular number (32-bit signed), even though all of its uses request an
unsigned int variable.
Similarly the constant representing the maximal output is also defined
as a regular number, even though all of its uses request an unsigne
During the rules flush, the rxp_poll_csr_for_value function is called
twice. The rxp_poll_csr_for_value function can fail for two reasons:
1. It could not read the value from register, in which case the
function returns -1.
2. It read a value, but not the value it expected to receive. In this
case
The mlx5_regex_rules_db_import function goes over all engines in the
loop and program rxp rules.
The iterator of the loop is called id and the variable representing the
number of engines is called priv->nb_engines.
The id variable is of uint8_t type while the priv->nb_engines variable
is of uint32
On 18-Nov-20 2:58 AM, Yongxin Liu wrote:
In commit 681a67288655 ("usertools: check if module is loaded before
binding"), script will exit if no driver is found in /sys/module/.
However, for built-in kernel driver, /sys/module/MODULENAME only
shows up if it has a version or at least one parameter
There is a discrepancy between RTE ETHDEV API and flow rules guide
regarding flow rules maintenance after port stop. RTE ETHDEV API in
librte_ethdev.h declares that flow rules will not be stored in PMD
after port stop:
> Quite start
Please note that some configuration is not stored between c
On Wed, Nov 18, 2020 at 04:04:25PM +0100, Thomas Monjalon wrote:
> 18/11/2020 15:54, Bruce Richardson:
> > On Wed, Nov 18, 2020 at 03:42:36PM +0100, Thomas Monjalon wrote:
> > > 18/11/2020 15:19, Juraj Linkeš:
> > > > From: Thomas Monjalon
> > > > > 16/11/2020 10:13, Bruce Richardson:
> > > > > >
There are common problems with VFIO that get asked over and over on the
mailing list. Document common problems with VFIO and how to fix them or
at least figure out what went wrong.
Signed-off-by: Anatoly Burakov
---
doc/guides/linux_gsg/linux_drivers.rst | 43 ++
1 file c
Currently, we have no documentation on how to use VFIO in no-IOMMU mode.
Add such documentation.
Signed-off-by: Anatoly Burakov
---
Notes:
v2:
- Fixed the noiommu parameter name
doc/guides/linux_gsg/linux_drivers.rst | 28 +-
1 file changed, 27 insertions(+), 1
Make sure that we always prioritize VFIO over UIO. Also, minor wording
corrections and improvements.
Signed-off-by: Anatoly Burakov
---
Notes:
v2:
- Fix formatting for VF token section
- Some more typo and formatting fixes
doc/guides/linux_gsg/linux_drivers.rst | 131 ++
Currently, the Linux GSG mentions UIO drivers first. This is not ideal
as for the longest time, the recommended way to use DPDK with hardware
devices has been to use VFIO driver.
This commit simply moves UIO section after VFIO, with minor edits.
Signed-off-by: Anatoly Burakov
---
doc/guides/lin
Hi,
> -Original Message-
> From: dev On Behalf Of Dekel Peled
> Sent: Wednesday, November 18, 2020 11:24 AM
> To: Slava Ovsiienko ; Shahaf Shuler
> ; Matan Azrad
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix RSS queue types validation
>
> Recent patch fixed the RSS acti
> -Original Message-
> From: Thomas Monjalon
> Sent: Wednesday, November 18, 2020 3:43 PM
> To: Bruce Richardson ; Juraj Linkeš
>
> Cc: ruifeng.w...@arm.com; honnappa.nagaraha...@arm.com;
> phil.y...@arm.com; vcchu...@amazon.com; dharmik.thak...@arm.com;
> jerinjac...@gmail.com; hemant.
18/11/2020 15:54, Bruce Richardson:
> On Wed, Nov 18, 2020 at 03:42:36PM +0100, Thomas Monjalon wrote:
> > 18/11/2020 15:19, Juraj Linkeš:
> > > From: Thomas Monjalon
> > > > 16/11/2020 10:13, Bruce Richardson:
> > > > > On Mon, Nov 16, 2020 at 08:24:48AM +0100, Thomas Monjalon wrote:
> > > > > >
On Wed, Nov 18, 2020 at 03:42:36PM +0100, Thomas Monjalon wrote:
> 18/11/2020 15:19, Juraj Linkeš:
> > From: Thomas Monjalon
> > > 16/11/2020 10:13, Bruce Richardson:
> > > > On Mon, Nov 16, 2020 at 08:24:48AM +0100, Thomas Monjalon wrote:
> > > > > 13/11/2020 15:31, Juraj Linkeš:
> > > > > > +opt
On Wed, Nov 18, 2020 at 12:48 PM Ferruh Yigit wrote:
>
> Removing useless 'return' statement.
>
> Fixes: b2da02480cb7 ("net/bnxt: support EEM system memory")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Ferruh Yigit
> ---
> Cc: peter.spreadboro...@broadcom.com
> ---
> drivers/net/bnxt/tf_core/tf_em_
On Wed, Nov 18, 2020 at 12:47 PM Ferruh Yigit wrote:
>
> Assignment of function parameter 'umem' removed.
>
> Fixes: f0ce7af0e182 ("net/af_xdp: remove resources when port is closed")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Ferruh Yigit
> ---
> drivers/net/af_xdp/rte_eth_af_xdp.c | 1 -
> 1 file
18/11/2020 15:19, Juraj Linkeš:
> From: Thomas Monjalon
> > 16/11/2020 10:13, Bruce Richardson:
> > > On Mon, Nov 16, 2020 at 08:24:48AM +0100, Thomas Monjalon wrote:
> > > > 13/11/2020 15:31, Juraj Linkeš:
> > > > > +option('max_lcores', type: 'integer', value: 0,
> > > > > + description: 'ma
On Wed, Nov 18, 2020 at 02:20:53PM +, Juraj Linkeš wrote:
>
>
> > -Original Message-
> > From: Thomas Monjalon
> > Sent: Monday, November 16, 2020 8:20 AM
> > To: Juraj Linkeš
> > Cc: bruce.richard...@intel.com; ruifeng.w...@arm.com;
> > honnappa.nagaraha...@arm.com; phil.y...@arm.c
> -Original Message-
> From: Thomas Monjalon
> Sent: Tuesday, November 17, 2020 10:58 AM
> To: Bruce Richardson
> Cc: Juraj Linkeš ; Honnappa Nagarahalli
> ; Ruifeng Wang
> ; Phil Yang ;
> vcchu...@amazon.com; Dharmik Thakkar ;
> jerinjac...@gmail.com; hemant.agra...@nxp.com; Ajit Khapa
> -Original Message-
> From: Thomas Monjalon
> Sent: Monday, November 16, 2020 8:20 AM
> To: Juraj Linkeš
> Cc: bruce.richard...@intel.com; ruifeng.w...@arm.com;
> honnappa.nagaraha...@arm.com; phil.y...@arm.com;
> vcchu...@amazon.com; dharmik.thak...@arm.com; jerinjac...@gmail.com;
> h
> -Original Message-
> From: Thomas Monjalon
> Sent: Monday, November 16, 2020 10:24 AM
> To: Bruce Richardson
> Cc: Juraj Linkeš ; ruifeng.w...@arm.com;
> honnappa.nagaraha...@arm.com; phil.y...@arm.com;
> vcchu...@amazon.com; dharmik.thak...@arm.com; jerinjac...@gmail.com;
> hemant.ag
On Wed, Nov 18, 2020 at 12:47 PM Ferruh Yigit wrote:
>
> 'ret' is already defined in the function scope, removing the 'ret' in
> the block scope.
>
> Fixes: c9507cd0cada ("net/pcap: support physical interface MAC address")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Ferruh Yigit
> ---
> Cc: juhamatt
On Wed, Nov 18, 2020 at 12:47 PM Ferruh Yigit wrote:
>
> 'flag' is initialized to '0' but it is overwritten later, moving the
> declaration where it is used and initialize with actual value.
>
> Fixes: 0101a0ec6217 ("app/procinfo: add --show-mempool")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Ferru
On Wed, Nov 18, 2020 at 12:46 PM Ferruh Yigit wrote:
>
> The intention with the "sizeof(0)" usage is not clear, but the 'stats'
> already 'memset' by 'rte_cryptodev_stats_get()' API, removing 'memset'
> in application.
>
> Fixes: fe773600fe3e ("app/procinfo: add --show-crypto")
> Cc: sta...@dpdk.o
On Wed, Nov 18, 2020 at 12:46 PM Ferruh Yigit wrote:
>
> 'parse_xstats_ids()' return 'int'. The return value is assigned to
> 'nb_xstats_ids' unsigned value, later negative check on this variable is
> wrong.
>
> Adding interim 'int' variable for negative check.
>
> Fixes: 7ac16a3660c0 ("app/proc-i
On Wed, Nov 18, 2020 at 12:46 PM Ferruh Yigit wrote:
>
> '_filters' is compared twice, second one will be always false, removing
> it using the message more relevant to the '_filters'.
>
> Fixes: 2deb6b5246d7 ("app/procinfo: add collectd format and host id")
> Cc: sta...@dpdk.org
>
> Signed-off-by
Hi,
> -Original Message-
> From: Viacheslav Ovsiienko
> Sent: Wednesday, November 18, 2020 9:38 AM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh ; Matan Azrad
> ; Ori Kam ; Suanming Mou
> ; sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix raw encap/decap limit constant
>
> The MLX5_ENCAPSULA
Hi,
> -Original Message-
> From: Suanming Mou
> Sent: Wednesday, November 18, 2020 4:20 AM
> To: Slava Ovsiienko ; Matan Azrad
>
> Cc: dev@dpdk.org; Raslan Darawsheh
> Subject: [PATCH v3] net/mlx5: fix header reformat action hash key
>
> Currently, header reformat action uses the hash
In some situations, we would get several ip fragments， which total
data length is less than minimum frame(64) and padding with zeros.
Examples: Second Fragment is "a0a1 a2a3 a4a5 a6a7 ..."
and Third Fragment is "a8a9 aaab acad aeaf b0b1 b2b3 ...".
And then, we would reassemble Second and
> -Original Message-
> From: Thomas Monjalon
> Sent: Monday, November 16, 2020 8:38 AM
> To: Juraj Linkeš ;
> honnappa.nagaraha...@arm.com
> Cc: dev@dpdk.org; bruce.richard...@intel.com; ruifeng.w...@arm.com;
> phil.y...@arm.com; vcchu...@amazon.com; dharmik.thak...@arm.com;
> jerinjac.
On 11/17/2020 2:07 PM, Ciara Loftus wrote:
AF_XDP will not work on 32-bit kernels before version 5.4.
Document this restriction in the driver guide.
Signed-off-by: Ciara Loftus
Applied to dpdk-next-net/main, thanks.
On 11/18/2020 1:34 AM, Simei Su wrote:
[PATCH v2 1/2] ethdev: add RSS offload types.
[PATCH v2 2/2] app/testpmd: add cmdline support for RSS types.
v2:
* Update cmd_config_rss.help_str and cmd_help_long_parsed() to add the ecpri.
* Update the documentation to add the ecpri.
Simei Su (2):
eth
On 11/18/2020 1:34 AM, Simei Su wrote:
This patch adds testpmd cmdline support for eCPRI.
Signed-off-by: Simei Su
Reviewed-by: Ferruh Yigit
Add link for firmware/OOT kernel driver/DDP download
Add matching List.
Signed-off-by: Qi Zhang
---
doc/guides/nics/ice.rst | 28 +---
1 file changed, 25 insertions(+), 3 deletions(-)
diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst
index c5a76a2a21..6e28b2
> -Original Message-
> From: Feifei Wang
> Sent: Wednesday, November 18, 2020 18:49
> To: Jerin Jacob ; Ruifeng Wang ;
> Guo, Jia
> ; Wang, Haiyue
> Cc: dev@dpdk.org; n...@arm.com; Feifei Wang
> Subject: [PATCH v2 4/4] net/ixgbe: enable IXGBE NEON vector when need to
> checksum
>
> IX
> -Original Message-
> From: Feifei Wang
> Sent: Wednesday, November 18, 2020 18:49
> To: Jerin Jacob ; Ruifeng Wang ;
> Guo, Jia
> ; Wang, Haiyue
> Cc: dev@dpdk.org; n...@arm.com; Feifei Wang
> Subject: [PATCH v2 3/4] net/ixgbe: support good checksum flag for NEON vector
>
> Add CKSUM
> -Original Message-
> From: Feifei Wang
> Sent: Wednesday, November 18, 2020 18:49
> To: Jerin Jacob ; Ruifeng Wang ;
> Guo, Jia
> ; Wang, Haiyue
> Cc: dev@dpdk.org; n...@arm.com; Feifei Wang
> Subject: [PATCH v2 2/4] net/ixgbe: support bad checksum flag for NEON vector
>
> Updated de
> -Original Message-
> From: Feifei Wang
> Sent: Wednesday, November 18, 2020 18:49
> To: Jerin Jacob ; Ruifeng Wang ;
> Guo, Jia
> ; Wang, Haiyue
> Cc: dev@dpdk.org; n...@arm.com; Feifei Wang
> Subject: [PATCH v2 1/4] net/ixgbe: add new flag of stripped VLAN for NEON
> vector
>
> For
Removing useless 'return' statement.
Fixes: b2da02480cb7 ("net/bnxt: support EEM system memory")
Cc: sta...@dpdk.org
Signed-off-by: Ferruh Yigit
---
Cc: peter.spreadboro...@broadcom.com
---
drivers/net/bnxt/tf_core/tf_em_common.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/bn
Assignment of function parameter 'umem' removed.
Fixes: f0ce7af0e182 ("net/af_xdp: remove resources when port is closed")
Cc: sta...@dpdk.org
Signed-off-by: Ferruh Yigit
---
drivers/net/af_xdp/rte_eth_af_xdp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.
'ret' is already defined in the function scope, removing the 'ret' in
the block scope.
Fixes: c9507cd0cada ("net/pcap: support physical interface MAC address")
Cc: sta...@dpdk.org
Signed-off-by: Ferruh Yigit
---
Cc: juhamatti.kuusisa...@coriant.com
---
drivers/net/pcap/rte_eth_pcap.c | 2 +-
1
'flag' is initialized to '0' but it is overwritten later, moving the
declaration where it is used and initialize with actual value.
Fixes: 0101a0ec6217 ("app/procinfo: add --show-mempool")
Cc: sta...@dpdk.org
Signed-off-by: Ferruh Yigit
---
app/proc-info/main.c | 4 +---
1 file changed, 1 inser
The intention with the "sizeof(0)" usage is not clear, but the 'stats'
already 'memset' by 'rte_cryptodev_stats_get()' API, removing 'memset'
in application.
Fixes: fe773600fe3e ("app/procinfo: add --show-crypto")
Cc: sta...@dpdk.org
Signed-off-by: Ferruh Yigit
---
app/proc-info/main.c | 1 -
1
'parse_xstats_ids()' return 'int'. The return value is assigned to
'nb_xstats_ids' unsigned value, later negative check on this variable is
wrong.
Adding interim 'int' variable for negative check.
Fixes: 7ac16a3660c0 ("app/proc-info: support xstats by ID and by name")
Cc: sta...@dpdk.org
Signed-
'_filters' is compared twice, second one will be always false, removing
it using the message more relevant to the '_filters'.
Fixes: 2deb6b5246d7 ("app/procinfo: add collectd format and host id")
Cc: sta...@dpdk.org
Signed-off-by: Ferruh Yigit
---
app/proc-info/main.c | 4 +---
1 file changed,
Fix a few of issues identified by cppcheck
Ferruh Yigit (7):
app/procinfo: fix redundant condition
app/procinfo: fix negative check on unsigned variable
app/procinfo: remove suspicious sizeof
app/procinfo: remove useless assignment
net/pcap: remove local variable shadown outer one
net/
On Tue, Nov 17, 2020 at 11:38 AM Thomas Monjalon wrote:
>
> The verbosity was meant to be set with options -v and -vv,
> or possibly with the environment variables TEST_MESON_BUILD_VERBOSE
> and TEST_MESON_BUILD_VERY_VERBOSE.
>
> It is decided to keep only the options -v and -vv,
> so the variable
Hi, Haiyue
> -邮件原件-
> 发件人: Wang, Haiyue
> 发送时间: 2020年11月18日 16:34
> 收件人: Feifei Wang ; jer...@marvell.com; Ruifeng
> Wang ; Guo, Jia
> 抄送: dev@dpdk.org; nd
> 主题: RE: [PATCH v1 1/4] net/ixgbe: add VLAN stripping support for Arm
>
> Hi Feifei,
>
> > -Original Message-
> > From:
IXGBE NEON vector PMD now supports checksum offloading, hence can be used
when DEV_RX_OFFLOAD_CHECKSUM is set.
Signed-off-by: Feifei Wang
Reviewed-by: Ruifeng Wang
---
drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_rxtx_v
Add CKSUM_GOOD flag to distinguish a good checksum from an unknown one
in neon vertor RX function.
Signed-off-by: Feifei Wang
Reviewed-by: Ruifeng Wang
---
drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 37 +
1 file changed, 25 insertions(+), 12 deletions(-)
diff --git a/dri
Updated desc_to_olflags_v() to support PKT_RX_IP_CKSUM_BAD and
PKT_RX_L4_CKSUM_BAD in the ol_flags of the mbuf.
And then the NEON vector RX function can be called with hw_ip_checksum
enabled.
Signed-off-by: Feifei Wang
Reviewed-by: Ruifeng Wang
---
drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 47
For NEON vector of IXGBE PMD, introduce new flag PKT_RX_VLAN_STRIPPED to
show the case that the VLAN is stripped from the VLAN tagged packet.
This is because that the old flag PKT_RX_VLAN_PKT only indicates that the
packet is VLAN tagged, but cannot show whether VLAN is in m->vlan_tci or
in the pa
This patch series are mainly to enable checksum offloading for IXGBE NEON
vector PMD, including good and bad checksum flags. In the meanwhile, the
first patch enable VLAN stripping flag for Arm.
Following are the test results for the patches:
NICs: 82599(igb)
Driver: ixgbe(vector)
$:./app/dpdk-tes
On 11/17/2020 6:04 PM, Varghese, Vipin wrote:
Hi Ferruh,
Thanks for the update
snipped
show_mempool(char *name) {
-uint64_t flags = 0;
+uint64_t flags;
Checking the current code base it makes more sense to move the code inside `if`
condition check. Sample code shared below
```
-uint64_t
On Mon, Nov 16, 2020 at 11:12 AM Gaetan Rivet wrote:
>
> The original triple negative was hard to read and the attempt
> to improve the formulation was commendable, unfortunately the new
> comment is the inverse of correct.
>
> Fixes: a65a34a85ebf ("eal: replace usage of blacklist/whitelist in enu
https://bugs.dpdk.org/show_bug.cgi?id=578
Bug ID: 578
Summary: i40evf_check_api_version(): PF/VF API version
mismatch:(0.0)-(1.1) with multiple DPDK instances
using different VFs with the same PF
Product: DPDK
Ver
Recent patch fixed the RSS action validation, making sure hairpin queues
and standard queues are not used together in the same RSS action.
The variable used for comparison was declared and initialized within the
check loop, making the queue type comparison wrong.
This patch moves the variable decl
18/11/2020 05:15, Radha Mohan:
> On Mon, Nov 16, 2020 at 12:28 PM Thomas Monjalon wrote:
> > 16/11/2020 19:28, Radha Mohan:
> > > On Fri, Nov 13, 2020 at 2:39 PM Thomas Monjalon
> > > wrote:
> > > > 13/11/2020 20:18, Radha Mohan:
> > > > > On Tue, Nov 10, 2020 at 11:57 PM Mahipal Challa
> > >
> >> On 11/17/20 10:18 PM, Gregory Etelson wrote:
> >>> There is a discrepancy between RTE ETHDEV API and flow rules guide
> >>> regarding flow rules maintenance after port stop. RTE ETHDEV API in
> >>> librte_ethdev.h declares that flow rules will not be stored in PMD
> >>> after port stop:
> >>>
On 11/18/20 11:59 AM, Gregory Etelson wrote:
> Hello Andrew,
>
>> On 11/17/20 10:18 PM, Gregory Etelson wrote:
>>> There is a discrepancy between RTE ETHDEV API and flow rules guide
>>> regarding flow rules maintenance after port stop. RTE ETHDEV API in
>>> librte_ethdev.h declares that flow rule
Existing code uses the hard-coded value REG_C_5 as input for function
mlx5dv_dr_action_create_flow_hit().
This patch updates function mlx5_flow_get_reg_id() to return the
selected REG_C value for ASO Flow Hit operation.
The returned value is used, after reducing offset REG_C_0, as input
for functi
The age action using ASO was recently introduced in MLX5 PMD.
This series includes fixes for this feature, repairing issues found
and updating it to the released rdma-core API.
Dekel Peled (3):
net/mlx5: fix unfreed memory on ASO age close
net/mlx5: fix input register for ASO object
common/m
Existing code uses the previous API offered by rdma-core in order
to create ASO Flow Hit action.
A general API is now formally released, to create ASO action of any type.
This patch moves the MLX5 PMD code to use the formal API.
Signed-off-by: Dekel Peled
Acked-by: Matan Azrad
---
drivers/comm
Recent patch introduced the use of ASO flow hit action for age action.
The relevant management struct uses dynamically allocated memory.
This memory was not freed on closing.
This patch adds memory freeing as needed.
Fixes: f935ed4b645a ("net/mlx5: support flow hit action for aging")
Signed-off-
Hello Andrew,
> On 11/17/20 10:18 PM, Gregory Etelson wrote:
> > There is a discrepancy between RTE ETHDEV API and flow rules guide
> > regarding flow rules maintenance after port stop. RTE ETHDEV API in
> > librte_ethdev.h declares that flow rules will not be stored in PMD
> > after port stop:
>
Unlinking queues from port should be done during port release. Doing it
during device re-configuration could result in segfault as ports array
is re-allocated based on new number of ports.
Fixes: f7ac8b66b23c ("event/octeontx2: support linking queues to ports")
Cc: sta...@dpdk.org
Signed-off-by:
Hi Feifei,
> -Original Message-
> From: Feifei Wang
> Sent: Wednesday, November 18, 2020 15:35
> To: Jerin Jacob ; Ruifeng Wang ;
> Guo, Jia
> ; Wang, Haiyue
> Cc: dev@dpdk.org; n...@arm.com; Feifei Wang
> Subject: [PATCH v1 1/4] net/ixgbe: add VLAN stripping support for Arm
>
And th
> -邮件原件-
> 发件人: Wang, Haiyue
> 发送时间: 2020年11月18日 16:15
> 收件人: Feifei Wang ; jer...@marvell.com; Ruifeng
> Wang ; Guo, Jia
> 抄送: dev@dpdk.org; nd ; nd
> 主题: RE: [PATCH v1 3/4] net/ixgbe: implement good checksum flag for NEON
> vector
>
> > -Original Message-
> > From: Feifei Wa
> -Original Message-
> From: Feifei Wang
> Sent: Wednesday, November 18, 2020 15:56
> To: Wang, Haiyue ; jer...@marvell.com; Ruifeng Wang
> ; Guo,
> Jia
> Cc: dev@dpdk.org; nd ; nd
> Subject: 回复: [PATCH v1 3/4] net/ixgbe: implement good checksum flag for NEON
> vector
>
> Hi, Haiyue
>
1 - 100 of 101 matches
Mail list logo
