Re: [dpdk-dev] [RFC] net: make eCPRI header host network order

2020-11-29 Thread Wang, Haiyue
> -Original Message- > From: Bing Zhao > Sent: Saturday, November 28, 2020 17:07 > To: Wang, Haiyue ; Yigit, Ferruh > ; Olivier Matz > ; Slava Ovsiienko ; Thomas > Monjalon > > Cc: dev@dpdk.org; Stephen Hemminger > Subject: RE: [RFC] net: make eCPRI header host network order > > Hi Ha

Re: [dpdk-dev] [PATCH iproute2 0/5] fix warnings from gcc-10

2020-11-29 Thread Stephen Hemminger
On Sun, 29 Nov 2020 09:54:32 -0800 Stephen Hemminger wrote: > Just switched over to Gcc-10 which complains about a number > of small issues in iproute2. > > Stephen Hemminger (5): > devlink: fix unitialized warning > bridge: fix string length warning > tc: fix compiler warnings in ip6 pedi

[dpdk-dev] [PATCH 5/5] f_u32: fix compiler gcc-10 compiler warning

2020-11-29 Thread Stephen Hemminger
With gcc-10 it complains about array subscript error. f_u32.c: In function ‘u32_parse_opt’: f_u32.c:1113:24: warning: array subscript 0 is outside the bounds of an interior zero-length array ‘struct tc_u32_key[0]’ [-Wzero-length-bounds] 1113 |hash = sel2.sel.keys[0].val & sel2.sel.keys[0].ma

[dpdk-dev] [PATCH 4/5] misc: fix compiler warning in ifstat and nstat

2020-11-29 Thread Stephen Hemminger
The code here was doing strncpy() in a way that causes gcc 10 warning about possible string overflow. Just use strlcpy() which will null terminate and bound the string as expected. This has existed since start of git era so no Fixes tag. Signed-off-by: Stephen Hemminger --- misc/ifstat.c | 2 +-

[dpdk-dev] [PATCH 3/5] tc: fix compiler warnings in ip6 pedit

2020-11-29 Thread Stephen Hemminger
Gcc-10 complains about referencing a zero size array. This occurs because the array of keys is actually in the following structure which is part of the overall selector. The original code was safe, but better to just use the key array directly. Fixes: 2d9a8dc439ee ("tc: p_ip6: Support pedit of IP

[dpdk-dev] [PATCH 2/5] bridge: fix string length warning

2020-11-29 Thread Stephen Hemminger
Gcc-10 complains about possible string length overflow. This can't happen Ethernet address format is always limited to 18 characters or less. Just resize the temp buffer. Fixes: 70dfb0b8836d ("iplink: bridge: export bridge_id and designated_root") Cc: niko...@cumulusnetworks.com Signed-off-by: Ste

[dpdk-dev] [PATCH 1/5] devlink: fix unitialized warning

2020-11-29 Thread Stephen Hemminger
GCC-10 complains about uninitialized variable. devlink.c: In function ‘cmd_dev’: devlink.c:2803:12: warning: ‘val_u32’ may be used uninitialized in this function [-Wmaybe-uninitialized] 2803 |val_u16 = val_u32; |^ devlink.c:2747:11: note: ‘val_u32’ was declared here

[dpdk-dev] [PATCH iproute2 0/5] fix warnings from gcc-10

2020-11-29 Thread Stephen Hemminger
Just switched over to Gcc-10 which complains about a number of small issues in iproute2. Stephen Hemminger (5): devlink: fix unitialized warning bridge: fix string length warning tc: fix compiler warnings in ip6 pedit misc: fix compiler warning in ifstat and nstat f_u32: fix compiler gcc

[dpdk-dev] [PATCH v2] windows: build warnings with clang

2020-11-29 Thread Nick Connolly
Microsoft CRT defines Windows-specific secure alternatives to standard library functions and triggers warnings when "insecure" functions are used [1]. However, calling code already has all necessary checks around those functions, so these warnings are not useful for DPDK. MinGW provides its own CRT

Re: [dpdk-dev] [PATCH] windows: build warnings with clang

2020-11-29 Thread Dmitry Kozlyuk
On Fri, 27 Nov 2020 11:36:23 +, Nick Connolly wrote: > Compiling with Clang (11.0, --buildtype=debug) for Windows > produces deprecated warnings related to secure crt functions. Please explain what these warnings mean and why disabling them is OK. FWIW, I examined present warnings and found no

Re: [dpdk-dev] NTT TechnoCross roadmap for 21.02

2020-11-29 Thread Baruch Even
Hi, The way we do this accounting is completely different, it depends on having logic that says you are in idle state and counts the start and stop time from entering to exiting the idle function. It then subtracts the idle time from the stat period time and that gives you the time (also percentag

Re: [dpdk-dev] [PATCH v2] eal/windows: vfprintf build warning with clang

2020-11-29 Thread Dmitry Kozlyuk
On Sun, 29 Nov 2020 13:00:47 +, Nick Connolly wrote: > When building with clang (11.0,--buildtype=debug), eal_lcore.c > produces a -Wformat-nonliteral warning from the vfprintf call > in log_early. > > Add __rte_format_printf annotation. > > Fixes: b8a36b086625 ("eal/windows: improve CPU and

[dpdk-dev] [PATCH v2] eal/windows: vfprintf build warning with clang

2020-11-29 Thread Nick Connolly
When building with clang (11.0,--buildtype=debug), eal_lcore.c produces a -Wformat-nonliteral warning from the vfprintf call in log_early. Add __rte_format_printf annotation. Fixes: b8a36b086625 ("eal/windows: improve CPU and NUMA node detection") Cc: sta...@dpdk.org Signed-off-by: Nick Connolly