Re: [dpdk-dev] [PATCH 0/2] support GTP-U Tx offload on FVL and CVL

2020-12-01 Thread Guo, Jia
Hi, murphy > -Original Message- > From: Murphy Yang > Sent: Wednesday, November 25, 2020 5:32 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Yang, SteveX > ; Xing, Beilei ; Guo, Jia > ; Lu, Wenzhuo ; Yang, > MurphyX > Subject: [PATCH 0/2] support GTP-U Tx offload on FVL and CVL Where is the

[dpdk-dev] [PATCH v2] maintainers: update for testpmd

2020-12-01 Thread beilei . xing
From: Beilei Xing Replace Beilei Xing with Xiaoyun Li. Signed-off-by: Beilei Xing --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index eafe9f8c46..e1728616a7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1567,7 +1567,7 @@ F: app/t

Re: [dpdk-dev] [PATCH] net/i40e: fix incorrect checksum flag of L4 checksum

2020-12-01 Thread Guo, Jia
Hi, murphy > -Original Message- > From: Murphy Yang > Sent: Wednesday, November 11, 2020 5:11 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Yang, SteveX > ; Xing, Beilei ; Guo, Jia > ; Yang, MurphyX > Subject: [PATCH] net/i40e: fix incorrect checksum flag of L4 checksum > > When send tunne

[dpdk-dev] [PATCH] maintainers: update for testpmd

2020-12-01 Thread beilei . xing
From: Beilei Xing Replace Beilei Xing with Xiaoyun Li. Signed-off-by: Beilei Xing --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index eafe9f8c46..e1728616a7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1567,7 +1567,7 @@ F: app/t

[dpdk-dev] [PATCH v4 4/4] test: change external memory test to use system page sz

2020-12-01 Thread Nithin Dabilpuram
Currently external memory test uses 4K page size. VFIO DMA mapping works only with system page granularity. Earlier it was working because all the contiguous mappings were coalesced and mapped in one-go which ended up becoming a lot bigger page. Now that VFIO DMA mappings both in IOVA as VA and IO

[dpdk-dev] [PATCH v4 3/4] test: add test case to validate VFIO DMA map/unmap

2020-12-01 Thread Nithin Dabilpuram
Test case mmap's system pages and tries to performs a user DMA map and unmap both partially and fully. Signed-off-by: Nithin Dabilpuram Acked-by: Anatoly Burakov --- app/test/meson.build | 1 + app/test/test_vfio.c | 103 +++ 2 files changed, 10

[dpdk-dev] [PATCH v4 2/4] vfio: fix DMA mapping granularity for type1 IOVA as VA

2020-12-01 Thread Nithin Dabilpuram
Partial unmapping is not supported for VFIO IOMMU type1 by kernel. Though kernel gives return as zero, the unmapped size returned will not be same as expected. So check for returned unmap size and return error. For IOVA as PA, DMA mapping is already at memseg size granularity. Do the same even for

[dpdk-dev] [PATCH v4 1/4] vfio: revert changes for map contiguous areas in one go

2020-12-01 Thread Nithin Dabilpuram
In order to save DMA entries limited by kernel both for externel memory and hugepage memory, an attempt was made to map physically contiguous memory in one go. This cannot be done as VFIO IOMMU type1 does not support partially unmapping a previously mapped memory region while Heap can request for m

[dpdk-dev] [PATCH v4 0/4] fix issue with partial DMA unmap

2020-12-01 Thread Nithin Dabilpuram
Partial DMA unmap is not supported by VFIO type1 IOMMU in Linux. Though the return value is zero, the returned DMA unmap size is not same as expected size. So add test case and fix to both heap triggered DMA mapping and user triggered DMA mapping/unmapping. Refer vfio_dma_do_unmap() in drivers/vfi

Re: [dpdk-dev] [PATCH v3 4/4] test: change external memory test to use system page sz

2020-12-01 Thread Nithin Dabilpuram
On Tue, Dec 01, 2020 at 03:23:39PM -0800, David Christensen wrote: > > diff --git a/app/test/test_external_mem.c b/app/test/test_external_mem.c > > index 7eb81f6..67690c6 100644 > > --- a/app/test/test_external_mem.c > > +++ b/app/test/test_external_mem.c > > @@ -532,8 +532,8 @@ test_extmem_basic(v

Re: [dpdk-dev] [PATCH v3 4/4] test: change external memory test to use system page sz

2020-12-01 Thread David Christensen
diff --git a/app/test/test_external_mem.c b/app/test/test_external_mem.c index 7eb81f6..67690c6 100644 --- a/app/test/test_external_mem.c +++ b/app/test/test_external_mem.c @@ -532,8 +532,8 @@ test_extmem_basic(void *addr, size_t len, size_t pgsz, rte_iova_t *iova, static int test_external_me

[dpdk-dev] [PATCH v3 4/4] test: change external memory test to use system page sz

2020-12-01 Thread Nithin Dabilpuram
Currently external memory test uses 4K page size. VFIO DMA mapping works only with system page granularity. Earlier it was working because all the contiguous mappings were coalesced and mapped in one-go which ended up becoming a lot bigger page. Now that VFIO DMA mappings both in IOVA as VA and IO

[dpdk-dev] [PATCH v3 3/4] test: add test case to validate VFIO DMA map/unmap

2020-12-01 Thread Nithin Dabilpuram
Test case mmap's system pages and tries to performs a user DMA map and unmap both partially and fully. Signed-off-by: Nithin Dabilpuram Acked-by: Anatoly Burakov --- app/test/meson.build | 1 + app/test/test_vfio.c | 103 +++ 2 files changed, 10

[dpdk-dev] [PATCH v3 2/4] vfio: fix DMA mapping granularity for type1 IOVA as VA

2020-12-01 Thread Nithin Dabilpuram
Partial unmapping is not supported for VFIO IOMMU type1 by kernel. Though kernel gives return as zero, the unmapped size returned will not be same as expected. So check for returned unmap size and return error. For IOVA as PA, DMA mapping is already at memseg size granularity. Do the same even for

[dpdk-dev] [PATCH v3 1/4] vfio: revert changes for map contiguous areas in one go

2020-12-01 Thread Nithin Dabilpuram
In order to save DMA entries limited by kernel both for externel memory and hugepage memory, an attempt was made to map physically contiguous memory in one go. This cannot be done as VFIO IOMMU type1 does not support partially unmapping a previously mapped memory region while Heap can request for m

[dpdk-dev] [PATCH v3 0/4] fix issue with partial DMA unmap

2020-12-01 Thread Nithin Dabilpuram
Partial DMA unmap is not supported by VFIO type1 IOMMU in Linux. Though the return value is zero, the returned DMA unmap size is not same as expected size. So add test case and fix to both heap triggered DMA mapping and user triggered DMA mapping/unmapping. Refer vfio_dma_do_unmap() in drivers/vfi

Re: [dpdk-dev] [PATCH v2] eal/windows: add stub for rte_intr_free_epoll_fd

2020-12-01 Thread Dmitry Kozlyuk
On Thu, 19 Nov 2020 17:18:11 +0200, Tal Shnaiderman wrote: > Linux epoll mechanism is not implemented in Windows. > > Add stub similarly to freeBSD. > > Signed-off-by: Tal Shnaiderman > > --- > v2: add missing export in def file [DavidM] > --- > lib/librte_eal/rte_eal_exports.def | 1 + >

Re: [dpdk-dev] [PATCH] eal/windows: add stub for rte_intr_callback_register

2020-12-01 Thread Dmitry Kozlyuk
On Thu, 26 Nov 2020 10:06:39 +0200, Tal Shnaiderman wrote: > interrupt callback register is not implemented in Windows. > Add stub with -ENOTSUP return value and export the function. > > Signed-off-by: Tal Shnaiderman > --- > lib/librte_eal/rte_eal_exports.def | 1 + > lib/librte_eal/window

[dpdk-dev] [PATCH 2/2] pci/windows: fix build with MinGW-w64 8.0.0

2020-12-01 Thread Dmitry Kozlyuk
Fix redefinition of GUID, missing from previous versions. Fixes: b762221ac24f ("bus/pci: support Windows with bifurcated drivers") Cc: sta...@dpdk.org Cc: Tal Shnaiderman Signed-off-by: Dmitry Kozlyuk --- drivers/bus/pci/windows/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[dpdk-dev] [PATCH 1/2] eal/windows: fix build with MinGW-w64 8.0.0

2020-12-01 Thread Dmitry Kozlyuk
MinGW-w64 above 8.0.0 exposes VirtualAlloc2() API in headers, but lacks it in import libraries. Hence, availability of this API at compile-time can't be used to choose between locating VirtualAlloc2() manually or relying on the dynamic linker. Fix redefinition compile-time errors. Always link Virt

Re: [dpdk-dev] [PATCH v1] license: add licenses for exception cases

2020-12-01 Thread Mcnamara, John
> -Original Message- > From: Bruce Richardson > Sent: Tuesday, December 1, 2020 2:35 PM > To: Mcnamara, John > Cc: dev@dpdk.org; tho...@monjalon.net; Yigit, Ferruh > > Subject: Re: [PATCH v1] license: add licenses for exception cases > > ... > > The licenses seem to me like they should

Re: [dpdk-dev] build failure with MinGW GCC 10.2

2020-12-01 Thread Dmitry Kozlyuk
On Tue, 01 Dec 2020 15:05:33 +0100, Thomas Monjalon wrote: > I am using ArchLinux: > mingw-w64-gcc 10.2.0-2 > mingw-w64-headers 8.0.0-1 > mingw-w64-crt 8.0.0-1 Reproduced, working on the patch, thanks.

Re: [dpdk-dev] [PATCH v1] license: add licenses for exception cases

2020-12-01 Thread Bruce Richardson
On Tue, Dec 01, 2020 at 02:26:46PM +, John McNamara wrote: > The license/exceptions.txt file lists a small number of files > that have licenses that are exceptions to the three main > licenses defined in the Intellectual Property Policy of the > DPDK Charter. > > The three exception licenses a

[dpdk-dev] [PATCH v1] license: add licenses for exception cases

2020-12-01 Thread John McNamara
The license/exceptions.txt file lists a small number of files that have licenses that are exceptions to the three main licenses defined in the Intellectual Property Policy of the DPDK Charter. The three exception licenses are MIT, ISC and BSD-2-Clause. Each of these licenses states that the conten

Re: [dpdk-dev] [PATCH v2] net/axgbe: enabling VLAN support in axgbe

2020-12-01 Thread Somalapuram, Amaranath
[AMD Official Use Only - Internal Distribution Only] -Original Message- From: Nandibasappa, Girish Sent: Tuesday, December 1, 2020 5:27 PM To: dev@dpdk.org Cc: Somalapuram, Amaranath Subject: [PATCH v2] net/axgbe: enabling VLAN support in axgbe From: gnandiba Added VLAN support for AM

Re: [dpdk-dev] build failure with MinGW GCC 10.2

2020-12-01 Thread Thomas Monjalon
01/12/2020 14:52, Dmitry Kozlyuk: > On Tue, 01 Dec 2020 14:18:53 +0100, Thomas Monjalon wrote: > > Hi, > > > > I'm hitting an issue with x86_64-w64-mingw32-gcc (GCC) 10.2.0: > > lib/librte_eal/windows/eal_memory.c:30:14: error: > > redeclaration of ‘enum MEM_EXTENDED_PARAMETER_TYPE’ > > an

Re: [dpdk-dev] build failure with MinGW GCC 10.2

2020-12-01 Thread Dmitry Kozlyuk
On Tue, 01 Dec 2020 14:18:53 +0100, Thomas Monjalon wrote: > Hi, > > I'm hitting an issue with x86_64-w64-mingw32-gcc (GCC) 10.2.0: > lib/librte_eal/windows/eal_memory.c:30:14: error: > redeclaration of ‘enum MEM_EXTENDED_PARAMETER_TYPE’ > and others: > redeclaration of enumerato

[dpdk-dev] build failure with MinGW GCC 10.2

2020-12-01 Thread Thomas Monjalon
Hi, I'm hitting an issue with x86_64-w64-mingw32-gcc (GCC) 10.2.0: lib/librte_eal/windows/eal_memory.c:30:14: error: redeclaration of ‘enum MEM_EXTENDED_PARAMETER_TYPE’ and others: redeclaration of enumerator ‘MemExtendedParameterInvalidType’ redeclaration of enumer

[dpdk-dev] [PATCH v2] net/axgbe: enabling VLAN support in axgbe

2020-12-01 Thread gnandiba
From: gnandiba Added VLAN support for AMD XGBE driver adding below APIs for axgbe - axgbe_enable_rx_vlan_stripping: to enable vlan header stipping - axgbe_disable_rx_vlan_stripping: to disable vlan header stipping - axgbe_enable_rx_vlan_filtering: to enable vlan filter mode - axgbe_disable_rx_vl

Re: [dpdk-dev] Basic question about where to write config for optional feature

2020-12-01 Thread Bruce Richardson
On Tue, Dec 01, 2020 at 02:01:26PM +0900, Hideyuki Yamashita wrote: > Hello, > > I am planning to propose patch for > optional feature. > > Question: > Where should I write compile switch for > optional features? > > I was planning to add flag to enable > optional festures into config/common_

Re: [dpdk-dev] Printfs in Signal Handler

2020-12-01 Thread Thomas Monjalon
01/12/2020 04:39, prateekag: > printf is not signal safe and may lead to deadlock if kept in signal handler > and > signal comes in two quick succession. It will not lead to incorrect behavior > and it is a highly unlikely event. And an expert may understand why this > issue happened. Is it wort

Re: [dpdk-dev] [PATCH] raw/ifpga/base: release eth group devices

2020-12-01 Thread Xu, Rosen
Hi, > -Original Message- > From: Zhang, Tianfei > Sent: Wednesday, November 25, 2020 15:19 > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > > Cc: Zhang, Tianfei ; sta...@dpdk.org > Subject: [PATCH] raw/ifpga/base: release eth group devices > > From: Tianfei zhang > > Release the eth grou

[dpdk-dev] [PATCH v1] net/iavf: support FDIR TCP/UDP pattern without input set

2020-12-01 Thread Yuying Zhang
This patch adds an input set refinement function to support outer and inner TCP/UDP patterns without input set for flow director filter. Signed-off-by: Yuying Zhang --- drivers/net/iavf/iavf_fdir.c | 67 ++-- 1 file changed, 56 insertions(+), 11 deletions(-) diff

[dpdk-dev] [PATCH v1] net/axgbe: enabling VLAN support in axgbe

2020-12-01 Thread gnandiba
From: gnandiba Added VLAN support for AMD XGBE driver adding below APIs for axgbe - axgbe_enable_rx_vlan_stripping: to enable vlan header stipping - axgbe_disable_rx_vlan_stripping: to disable vlan header stipping - axgbe_enable_rx_vlan_filtering: to enable vlan filter mode - axgbe_disable_rx_vl