[dpdk-dev] [PATCH v2] net/mlx5: support modify field rte flow action

Add support for new MODIFY_FIELD action to the Mellanox PMD. This is the generic API that allows to manipulate any packet header field by copying data from another packet field or mark, metadata, tag, or immediate value (or pointer to it). Since the API is generic and covers a lot of action under

Re: [dpdk-dev] [EXT] Re: [PATCH v2 05/11] net/octeontx_ep: Add dev info get and configure

-Original Message- From: Ferruh Yigit Sent: Tuesday, January 26, 2021 9:01 PM To: Pradeep Kumar Nalla ; Radha Chintakuntla ; Veerasenareddy Burru Cc: Jerin Jacob Kollanukkaran ; dev@dpdk.org; Satananda Burla Subject: [EXT] Re: [dpdk-dev] [PATCH v2 05/11] net/octeontx_ep: Add dev info

Re: [dpdk-dev] [PATCH v3 1/5] lpm: add sve support for lookup on Arm platform

> -Original Message- > From: David Marchand > Sent: Wednesday, January 27, 2021 9:05 PM > To: Ruifeng Wang > Cc: jer...@marvell.com; Jan Viktorin ; Bruce > Richardson ; Vladimir Medvedkin > ; dev ; Pavan Nikhilesh > ; hemant.agra...@nxp.com; Honnappa > Nagarahalli ; nd > Subject: Re: [dp

[dpdk-dev] [PATCH v2] crypto/octeontx2: fix null pointer dereferences

Coverity reports that pointers ip and ip6 may be dereferenced with null value. This patch fixes this. Coverity issue: 365549 Coverity issue: 365551 Fixes: 8f685ec2d545 ("crypto/octeontx2: support AES-CBC SHA1-HMAC") Signed-off-by: Ankur Dwivedi --- v2: * Fixed wrong fixes reference in commit me

Re: [dpdk-dev] [PATCH] net/iavf: fix vector mapping with queue

> -Original Message- > From: Wu, Jingjing > Sent: Thursday, January 28, 2021 10:37 AM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Xing, Beilei > ; > sta...@dpdk.org > Subject: [PATCH] net/iavf: fix vector mapping with queue > > Fix the vector mapping with queue by changing the recircle wh

[dpdk-dev] [PATCH] net/bnxt: fix mbuf flags for PTP packets

From: Kalesh AP Commit "899f06130724" broke the update of mbuf flags for PTP packets. "mbuf->ol_flags" is overwritten in bnxt_set_ol_flags() function. Fixes: 899f06130724 ("net/bnxt: add Rx logic for 58818 chips") Signed-off-by: Kalesh AP Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt

[dpdk-dev] [PATCH] net/iavf: fix vector mapping with queue

Fix the vector mapping with queue by changing the recircle when exceeds RX_VEC_START + nb_msix; Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt") Signed-off-by: Jingjing Wu --- drivers/net/iavf/iavf_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix setting maximum packet length

> -Original Message- > From: dev On Behalf Of Li, Xiaoyun > Sent: January 27, 2021 11:05 > To: Yigit, Ferruh ; Lu, Wenzhuo > ; Iremonger, Bernard > ; Yang, SteveX > Cc: dev@dpdk.org; sta...@dpdk.org; lance.richard...@broadcom.com; > ouli...@huawei.com; wis...@mellanox.com; lihuis...@huawe

Re: [dpdk-dev] [PATCH 1/3] doc: add FEC in NIC features

在 2021/1/28 8:20, Ferruh Yigit 写道: On 1/20/2021 1:43 PM, Lijun Ou wrote: From: "Min Hu (Connor)" Document FEC in NIC features, add information about FEC and add implementation related support. Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) Signed-off-by: Lijun Ou --- doc/guides/ni

Re: [dpdk-dev] [PATCH v1] eal: add ticket based reader writer lock

On Wed, 27 Jan 2021 10:25:15 + Ruifeng Wang wrote: > > -Original Message- > > From: dev On Behalf Of Stephen Hemminger > > Sent: Friday, January 15, 2021 1:35 AM > > To: dev@dpdk.org > > Cc: Stephen Hemminger > > Subject: [dpdk-dev] [PATCH v1] eal: add ticket based reader writer loc

[dpdk-dev] [PATCH v2] eal: add ticket based reader writer lock

This patch implements a reader/writer ticket lock because the current DPDK reader/writer lock will starve writers when presented with a stream of readers. This lock type acts like rte_rwlock() but uses a ticket algorithm and is therefore fair for multiple writers and readers. It acts like the exis

Re: [dpdk-dev] [PATCH v3 13/34] net/mvpp2: add dsa mode support

On 1/27/2021 4:09 PM, lir...@marvell.com wrote: From: Liron Himi Extend the config file with 'dsa-mode' field. currently 'eth' (default) and 'dsa' headers are supported. Signed-off-by: Liron Himi <...> --- a/doc/guides/nics/mvpp2.rst +++ b/doc/guides/nics/mvpp2.rst @@ -188,12 +188,12 @@ M

Re: [dpdk-dev] [PATCH 2/3] doc: update release notes for hns3

On 1/20/2021 1:43 PM, Lijun Ou wrote: Add TM(Traffic Management) feature with hns3 in release notes. Can you please add the commits of the patches introducing the feature mentioned in the release notes as fixes tag, for reference? Signed-off-by: Lijun Ou --- doc/guides/rel_notes/release

Re: [dpdk-dev] [PATCH 1/3] doc: add FEC in NIC features

On 1/28/2021 12:20 AM, Ferruh Yigit wrote: On 1/20/2021 1:43 PM, Lijun Ou wrote: From: "Min Hu (Connor)" Document FEC in NIC features, add information about FEC and add implementation related support. Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) Signed-off-by: Lijun Ou ---   doc/guid

Re: [dpdk-dev] [PATCH 1/3] doc: add FEC in NIC features

On 1/20/2021 1:43 PM, Lijun Ou wrote: From: "Min Hu (Connor)" Document FEC in NIC features, add information about FEC and add implementation related support. Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) Signed-off-by: Lijun Ou --- doc/guides/nics/features.rst | 14 ++

Re: [dpdk-dev] [PATCH v3 00/34] net/mvpp2: misc updates

On 1/27/2021 4:09 PM, lir...@marvell.com wrote: From: Liron Himi This patch series align the mainline driver with all changes since 19.11 some of the patches are fixes which should be pushed to stable v3: - remove redundant patches - update doc along with configuration changes v2: - fix commi

Re: [dpdk-dev] [PATCH v1 1/2] app/test: remove unnecessary barriers for ring stress test

> > Hi Feifei, > > > > > The variable "wrk_cmd" is a signal to control threads from running and > > stopping. When worker lcores load "wrk_cmd == WRK_CMD_RUN", they > start > > running and when worker lcores load "wrk_cmd == WRK_CMD_STOP", > they > > stop. > > > > For the wmb in test_mt1, no st

Re: [dpdk-dev] [PATCH] net/bnxt: update copyright year

On 1/27/2021 4:09 PM, Ajit Khaparde wrote: Update copyright year in various files. Signed-off-by: Ajit Khaparde Reviewed-by: Somnath Kotur Reviewed-by: Kalesh AP Applied to dpdk-next-net/main, thanks.

Re: [dpdk-dev] [PATCH v2] ethdev: refine doxygen for add UDP tunnel port API

27/01/2021 12:34, Ferruh Yigit: > On 1/19/2021 3:19 AM, Qi Zhang wrote: > > Refine the doxygen for rte_eth_dev_udp_tunnel_port_add. > > Add more detail description of the impacted offload functions. > > > > Signed-off-by: Qi Zhang > > --- > > > > v2: > > - reword doxygen that focus on API impact

Re: [dpdk-dev] [PATCH 0/2] free port private data in dev_close callback

On 1/19/2021 11:56 AM, Heinrich Kuhn wrote: The first patch in this series prepares the NFP PMD for the new expected behavior of the .dev_close() callback function, most recently described in commit fbd191356148 ("ethdev: remove old close behaviour"). Patch one makes the needed infrastructure cha

Re: [dpdk-dev] [PATCH 00/13] net/ionic: fixes and optimizations

On 1/27/2021 10:23 PM, Ferruh Yigit wrote: On 1/27/2021 6:10 PM, Andrew Boyer wrote: On Jan 27, 2021, at 1:02 PM, Ferruh Yigit > wrote: On 1/18/2021 8:34 PM, Andrew Boyer wrote: This patch series fixes some transmit issues, adds (better) support for big-endian

Re: [dpdk-dev] [PATCH 00/13] net/ionic: fixes and optimizations

On 1/27/2021 6:10 PM, Andrew Boyer wrote: On Jan 27, 2021, at 1:02 PM, Ferruh Yigit > wrote: On 1/18/2021 8:34 PM, Andrew Boyer wrote: This patch series fixes some transmit issues, adds (better) support for big-endian systems, and improves performance by stripp

Re: [dpdk-dev] [PATCH v5 0/9] ethdev: support SubFunction representor

On Tue, Jan 26, 2021 at 7:05 PM Xueming(Steven) Li wrote: > [snip] > The patch of device SF capability, but seems I misunderstood your suggestion. > Let me explain process to create a SF: > 1. SF can be created on the fly with scripts, unlike VF which is statically > pre-created. > 2. SF

Re: [dpdk-dev] ixgbe and UDP with zero checksum

"Wang, Haiyue" writes: > Hi Paolo, > >> -Original Message- >> From: Paolo Valerio >> Sent: Wednesday, January 27, 2021 21:50 >> To: dev@dpdk.org >> Cc: Guo, Jia ; Wang, Haiyue ; >> Aaron Conole >> >> Subject: ixgbe and UDP with zero checksum >> >> Hi, >> >> performing some tests, I n

Re: [dpdk-dev] [PATCH v3 1/5] lpm: add sve support for lookup on Arm platform

> > On Tue, Jan 12, 2021 at 3:57 AM Ruifeng Wang > wrote: > > diff --git a/lib/librte_lpm/rte_lpm.h b/lib/librte_lpm/rte_lpm.h index > > 1afe55cdc..28b57683b 100644 > > --- a/lib/librte_lpm/rte_lpm.h > > +++ b/lib/librte_lpm/rte_lpm.h > > @@ -402,7 +402,11 @@ rte_lpm_lookupx4(const struct rte_l

[dpdk-dev] [PATCH] net/bnxt: update copyright year

Update copyright year in various files. Signed-off-by: Ajit Khaparde Reviewed-by: Somnath Kotur Reviewed-by: Kalesh AP --- drivers/net/bnxt/bnxt.h | 2 +- drivers/net/bnxt/bnxt_cpr.c | 2 +- drivers/net/bnxt/bnxt_cpr.h

Re: [dpdk-dev] [PATCH 1/2] test/ipsec: fix return values

> Subject: RE: [PATCH 1/2] test/ipsec: fix return values > > > During SA creation, if the required algorithm is not supported, > > drivers can return ENOTSUP. But in most of the IPsec test cases, > > if the SA creation does not success, it just returns > > TEST_FAILED. > > > > This patch fixes thi

Re: [dpdk-dev] [PATCH 1/2] test/ipsec: fix return values

> During SA creation, if the required algorithm is not supported, > drivers can return ENOTSUP. But in most of the IPsec test cases, > if the SA creation does not success, it just returns > TEST_FAILED. > > This patch fixes this issue by returning the actual return values > from the driver to the

Re: [dpdk-dev] [PATCH 2/2] crypto/dpaa2_sec: fix if check on memory allocation

> When key length is 0, zmalloc will return NULL pointor > and in that case it should not return NOMEM. > So in this patch, adding a check on key length. > > Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation") > Cc: akhil.go...@nxp.com > --- Signed-off missing. Will add it while mer

Re: [dpdk-dev] crypto/qat: fix digest in buffer

> Subject: [dpdk-dev] crypto/qat: fix digest in buffer > > This patch fixes the missed digest in buffer support to > QAT symmetric raw API. Originally digest in buffer is > supported only for wireless algorithms > > Fixes: 728c76b0e50f ("crypto/qat: support raw datapath API") > Cc: roy.fan.zh...@

Re: [dpdk-dev] [PATCH v3 00/11] add mlx5 compress PMD

> Subject: [PATCH v3 00/11] add mlx5 compress PMD > > Add a new compress PMD for Mellanox devices. > > The MLX5 compress driver library provides support for Mellanox BlueField 2 > families of 25/50/100/200 Gb/s adapters. > > Using the BlueField 2 device, the compress class operations can be run

Re: [dpdk-dev] [PATCH v3 0/2] fix mingw build error

On 1/27/2021 6:27 AM, Leyi Rong wrote: This patchset fix mingw build error when avx512 is introduced. --- Tested-by: Pallavi Kadam

Re: [dpdk-dev] [PATCH v3 1/1] doc: add release milestones definition

> -Original Message- > From: dev On Behalf Of Thomas Monjalon > Sent: Wednesday, January 13, 2021 9:12 AM > To: dev@dpdk.org > Cc: david.march...@redhat.com; Yigit, Ferruh ; Asaf > Penso > Subject: [dpdk-dev] [PATCH v3 1/1] doc: add release milestones definition > > From: Asaf Penso >

Re: [dpdk-dev] [RFC] doc: add a guide to describe developing tests

Hi Bruce, Thanks for the review! Responses below. Bruce Richardson writes: > On Wed, Jan 27, 2021 at 10:16:18AM -0500, Aaron Conole wrote: >> The DPDK testing infrastructure includes a comprehensive set of >> libraries, utilities, and CI integrations for developers to test >> their code change

Re: [dpdk-dev] ixgbe and UDP with zero checksum

"Wang, Haiyue" writes: > Hi Paolo, > >> -Original Message- >> From: Paolo Valerio >> Sent: Wednesday, January 27, 2021 21:50 >> To: dev@dpdk.org >> Cc: Guo, Jia ; Wang, Haiyue ; >> Aaron Conole >> >> Subject: ixgbe and UDP with zero checksum >> >> Hi, >> >> performing some tests, I n

Re: [dpdk-dev] [PATCH 00/13] net/ionic: fixes and optimizations

> On Jan 27, 2021, at 1:02 PM, Ferruh Yigit wrote: > > On 1/18/2021 8:34 PM, Andrew Boyer wrote: >> This patch series fixes some transmit issues, adds (better) support for >> big-endian systems, and improves performance by stripping down some >> structures and inlining a few functions. >> The

Re: [dpdk-dev] [PATCH 00/13] net/ionic: fixes and optimizations

On 1/18/2021 8:34 PM, Andrew Boyer wrote: This patch series fixes some transmit issues, adds (better) support for big-endian systems, and improves performance by stripping down some structures and inlining a few functions. The endianness code has been reviewed internally but not really tested -

Re: [dpdk-dev] [EXT] Re: input port in mbuf

-Original Message- From: Tom Barbette Sent: Wednesday, 27 January 2021 18:59 To: Liron Himi ; Stephen Hemminger Cc: dpdk-dev Subject: Re: [dpdk-dev] [EXT] Re: input port in mbuf Le 16/01/2021 à 21:01, Liron Himi a écrit : > Hi, > > Sorry for rearising this issue again, please check m

Re: [dpdk-dev] [PATCH 07/13] net/ionic: inline queue flush function

On 1/27/2021 5:43 PM, Andrew Boyer wrote: On Jan 27, 2021, at 12:36 PM, Ferruh Yigit > wrote: On 1/18/2021 8:35 PM, Andrew Boyer wrote: This is hot-path function. Signed-off-by: Andrew Boyer mailto:abo...@pensando.io>> Signed-off-by: Neel Patel mailto:n...@pens

Re: [dpdk-dev] [PATCH v6 4/8] ethdev: make driver-only headers private

Hi Bruce, On 1/27/21 6:33 PM, Bruce Richardson wrote: > |drivers/net/vhost/rte_eth_vhost.c | 4 ++-- > drivers/net/virtio/virtio_ethdev.c | 4 ++-- > drivers/net/virtio/virtio_pci.h | 2 +- drivers/net/virtio/virtio_rxtx.c > | 2 +- drivers/net/virtio/virtio_rxtx_simple.c | 2 +- > drivers/net/virtio/v

Re: [dpdk-dev] [PATCH 06/13] net/ionic: clean up Tx queue version support

> On Jan 27, 2021, at 12:30 PM, Ferruh Yigit wrote: > > On 1/18/2021 8:35 PM, Andrew Boyer wrote: >> The ionic PMD only supports TX queue version 1 or greater. >> Version 1 introduced a new SGL format with support for more >> fragments per descriptor. >> Signed-off-by: Andrew Boyer > > <...>

Re: [dpdk-dev] [PATCH 07/13] net/ionic: inline queue flush function

> On Jan 27, 2021, at 12:36 PM, Ferruh Yigit wrote: > > On 1/18/2021 8:35 PM, Andrew Boyer wrote: >> This is hot-path function. >> Signed-off-by: Andrew Boyer >> Signed-off-by: Neel Patel >> --- >> drivers/net/ionic/ionic_dev.c | 6 -- >> drivers/net/ionic/ionic_dev.h | 9 -

[dpdk-dev] [PATCH] test: allow taking test names from commandline

While having the ability to run a test based off the DPDK_TEST environment variable is useful, it's often easier to specify the test name as a commandline parameter to a test binary. This also allows the test runs to be saved as part of the shell cmdline history. This patch adds support for checki

Re: [dpdk-dev] [PATCH 04/13] net/ionic: add an array-size macro

> On Jan 27, 2021, at 12:22 PM, Ferruh Yigit wrote: > > On 1/18/2021 8:34 PM, Andrew Boyer wrote: >> Using the IONIC_ARRAY_SIZE() macro makes the code clearer. >> Signed-off-by: Andrew Boyer > > There is already 'RTE_DIM' macro for it (in > 'lib/librte_eal/include/rte_common.h'), what do yo

[dpdk-dev] [PATCH v6 8/8] ci: add checking of includes to CI builds

For CI builds, turn on the checking of includes. Signed-off-by: Bruce Richardson Acked-by: Aaron Conole --- .ci/linux-build.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh index afa3689a09..fdbeb5a616 100755 --- a/.ci/linux-build.sh +++ b/.ci/linux

[dpdk-dev] [PATCH v6 7/8] devtools: remove check-includes script

The check-includes script allowed checking header files in a given directory to ensure that each header compiled alone without requiring any other header inclusions. With header checking now being done by the chkincs app in the build system this script can be removed. Signed-off-by: Bruce Richard

[dpdk-dev] [PATCH v6 6/8] buildtools/chkincs: add app to verify header includes

To verify that all DPDK headers are ok for inclusion directly in a C file, and are not missing any other pre-requisite headers, we can auto-generate for each header an empty C file that includes that header. Compiling these files will throw errors if any header has unmet dependencies. To ensure on

[dpdk-dev] [PATCH v6 5/8] build: separate out headers for include checking

For some libraries, there may be some header files which are not for direct inclusion, but rather are to be included via other header files. To allow later checking of these files for missing includes, we separate out the indirect include files from the direct ones. Signed-off-by: Bruce Richardson

Re: [dpdk-dev] [PATCH 07/13] net/ionic: inline queue flush function

On 1/18/2021 8:35 PM, Andrew Boyer wrote: This is hot-path function. Signed-off-by: Andrew Boyer Signed-off-by: Neel Patel --- drivers/net/ionic/ionic_dev.c | 6 -- drivers/net/ionic/ionic_dev.h | 9 - drivers/net/ionic/ionic_osdep.h | 1 - 3 files changed, 8 insertions(+)

[dpdk-dev] [PATCH v6 4/8] ethdev: make driver-only headers private

The rte_ethdev_driver.h, rte_ethdev_vdev.h and rte_ethdev_pci.h files are for drivers only and should be a private to DPDK and not installed. Signed-off-by: Bruce Richardson --- app/test/test_link_bonding.c | 2 +- app/test/test_pdump.c

[dpdk-dev] [PATCH v6 3/8] rib: fix missing header include

The rte_rib6 header was using RTE_MIN macro from rte_common.h but not including the header file. Fixes: f7e861e21c46 ("rib: support IPv6") Cc: vladimir.medved...@intel.com Signed-off-by: Bruce Richardson Acked-by: Vladimir Medvedkin --- lib/librte_rib/rte_rib6.h | 1 + 1 file changed, 1 insert

[dpdk-dev] [PATCH v6 2/8] eal: fix error attribute use for clang

Clang does not have an "error" attribute for functions, so for marking internal functions we need to check for the error attribute, and provide a fallback if it is not present. For clang, we can use "diagnose_if" attribute, similarly checking for its presence before use. Fixes: fba5af82adc8 ("eal:

[dpdk-dev] [PATCH v6 1/8] eal: add missing include to mcslock

Include 'rte_branch_prediction.h' to get the likely/unlikely macro definitions. Fixes: 2173fb61 ("mcslock: add MCS queued lock implementation") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson Reviewed-by: Honnappa Nagarahalli --- lib/librte_eal/include/generic/rte_mcslock.h | 1 + 1 fi

[dpdk-dev] [PATCH v6 0/8] add checking of header includes

As a general principle, each header file should include any other headers it needs to provide data type definitions or macros. For example, any header using the uintX_t types in structures or function prototypes should include "stdint.h" to provide those type definitions. In practice, while many,

Re: [dpdk-dev] [PATCH 06/13] net/ionic: clean up Tx queue version support

On 1/18/2021 8:35 PM, Andrew Boyer wrote: The ionic PMD only supports TX queue version 1 or greater. Version 1 introduced a new SGL format with support for more fragments per descriptor. Signed-off-by: Andrew Boyer <...> @@ -925,6 +925,11 @@ ionic_lif_alloc(struct ionic_lif *lif) ioni

Re: [dpdk-dev] [RFC] doc: add a guide to describe developing tests

On Wed, Jan 27, 2021 at 10:16:18AM -0500, Aaron Conole wrote: > The DPDK testing infrastructure includes a comprehensive set of > libraries, utilities, and CI integrations for developers to test > their code changes. This isn't well documented, however. > > Document the basics for adding a test s

Re: [dpdk-dev] ixgbe and UDP with zero checksum

Hi Paolo, > -Original Message- > From: Paolo Valerio > Sent: Wednesday, January 27, 2021 21:50 > To: dev@dpdk.org > Cc: Guo, Jia ; Wang, Haiyue ; Aaron > Conole > > Subject: ixgbe and UDP with zero checksum > > Hi, > > performing some tests, I noticed that on ixgbe when receiving UDP

Re: [dpdk-dev] [PATCH 04/13] net/ionic: add an array-size macro

On 1/18/2021 8:34 PM, Andrew Boyer wrote: Using the IONIC_ARRAY_SIZE() macro makes the code clearer. Signed-off-by: Andrew Boyer There is already 'RTE_DIM' macro for it (in 'lib/librte_eal/include/rte_common.h'), what do you think using it instead of creating a new one?

Re: [dpdk-dev] [EXT] Re: input port in mbuf

Le 16/01/2021 à 21:01, Liron Himi a écrit : Hi, Sorry for rearising this issue again, please check my comments inline Liron Himi -Original Message- From: Stephen Hemminger Sent: Wednesday, 6 May 2020 23:24 To: Liron Himi Cc: dpdk-dev Subject: Re: [EXT] Re: [dpdk-dev] input port in m

Re: [dpdk-dev] [PATCH] app/testpmd: add PF and VF targets to flow action type sample

On 12/21/2020 5:46 AM, psathe...@marvell.com wrote: From: Satheesh Paul Add support to specify PF or VF as targets in "set sample_actions" command. Signed-off-by: Satheesh Paul Hi Ori, Can you please support reviewing this patch?

Re: [dpdk-dev] [PATCH v5 3/3] PCI: don't use vfio ioctl call to access PIO resource

On 1/27/2021 2:43 PM, 谢华伟(此时此刻） wrote: On 2021/1/27 18:32, Ferruh Yigit wrote: I was waiting for clarification if this can be solved in virtio, which seems clarified and decided to go with this patch, I am OK to proceed with patch 1 & 2. But first patch changes how PIO address get, it changes

Re: [dpdk-dev] [PATCH v5 2/3] PCI: support MMIO in rte_pci_ioport_map/unap/read/write

On 1/27/2021 3:34 PM, 谢华伟(此时此刻） wrote: On 2021/1/27 18:40, Ferruh Yigit wrote: On 10/22/2020 4:51 PM, 谢华伟(此时此刻） wrote: From: "huawei.xhw" If IO BAR, we get PIO address. If MMIO BAR, we get mapped virtual address. We distinguish PIO and MMIO by their address like how kernel does. ioread/write

[dpdk-dev] [PATCH v1] net/ice/base: don't set VLAN mode in DCF mode

The PF will set the VLAN mode globally, DCF just needs to get the VLAN mode. Signed-off-by: Haiyue Wang --- drivers/net/ice/base/ice_vlan_mode.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ice/base/ice_vlan_mode.c b/drivers/net/ice/base/ice_vlan_mode.c index 2e4c3f62c4

[dpdk-dev] [PATCH v3 34/34] net/mvpp2: add fill buffs to configuration file

From: Dana Vardi Extend config file with 'fill_bpool_buffs' which control the amount of refill buffers Signed-off-by: Dana Vardi Reviewed-by: Liron Himi --- doc/guides/nics/mvpp2.rst | 3 +++ drivers/net/mvpp2/mrvl_ethdev.c | 7 --- drivers/net/mvpp2/mrvl_ethdev.h | 3 +++ driver

[dpdk-dev] [PATCH v3 33/34] net/mvpp2: update qos defaults parameter name

From: Dana Vardi 'global_default' is only being used for 'qos' so adding 'qos' into its name Signed-off-by: Dana Vardi Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 2 +- drivers/net/mvpp2/mrvl_qos.c| 12 ++-- drivers/net/mvpp2/mrvl_qos.h| 2 +- 3 files chang

[dpdk-dev] [PATCH v3 32/34] net/mvpp2: forward bad packets support

From: Dana Vardi Extend the config file with option to forward packets that were marked as "l2 bad pkts". by default the driver drop those packets Signed-off-by: Dana Vardi Reviewed-by: Liron Himi --- doc/guides/nics/mvpp2.rst | 3 +++ drivers/net/mvpp2/mrvl_ethdev.c | 10 -- d

[dpdk-dev] [PATCH v3 31/34] net/mvpp2: support custom header before ethernet

From: Dana Vardi Extend 'start_hdr' options with custom header. Signed-off-by: Dana Vardi Reviewed-by: Liron Himi --- doc/guides/nics/mvpp2.rst| 2 +- drivers/net/mvpp2/mrvl_qos.c | 5 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/mvpp2.rst b/doc/guid

[dpdk-dev] [PATCH v3 30/34] net/mvpp2: consider ptype in cksum info

From: Liron Himi Provide checksum information based on the ptype. Signed-off-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethde

[dpdk-dev] [PATCH v3 29/34] net/mvpp2: update start hdr name

From: Dana Vardi Change 'dsa_mode' to 'start_hdr' in config file Signed-off-by: Dana Vardi Reviewed-by: Liron Himi --- doc/guides/nics/mvpp2.rst| 4 ++-- drivers/net/mvpp2/mrvl_qos.c | 29 +++-- 2 files changed, 21 insertions(+), 12 deletions(-) diff --git a/doc/

[dpdk-dev] [PATCH v3 28/34] net/mvpp2: apply flow-ctrl after port init

From: Liron Himi In case ppio was not initialized yet (only at 'start' function) the flow-ctrl setting should be saved for later stage. Signed-off-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 26 +- drivers/net/mvpp2/mrvl_ethdev.h | 2 ++ 2 files changed, 23 in

[dpdk-dev] [PATCH v3 27/34] net/mvpp2: add 2.5G LINK info

From: Meir Levi Update capability with 2.5G support Signed-off-by: Meir Levi Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c index aaa827b68b..fad08dfd4a 10064

[dpdk-dev] [PATCH v3 26/34] net/mvpp2: expose max MTU size

From: Liron Himi Expose max-MTU based on the max frame size that l4 checksum generation can be done by HW. Signed-off-by: Liron Himi Reviewed-by: Yuri Chipchev --- drivers/net/mvpp2/mrvl_ethdev.c | 24 ++-- drivers/net/mvpp2/mrvl_ethdev.h | 1 + 2 files changed, 23 insert

[dpdk-dev] [PATCH v3 25/34] net/mvpp2: autoneg disable handling

From: Yuri Chipchev Flow control autoneg disable is not supported Signed-off-by: Yuri Chipchev Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethd

[dpdk-dev] [PATCH v3 24/34] net/mvpp2: introduce fixup for fifo overrun

From: Liron Himi Currently the HW is configured with only one pool which its buffer size may be larger than the rx-fifo-size. In that situation, frame size larger than the fifo-size is gets dropped due to fifo overrun. this is cause because the HW works in cut-through mode which waits to have in

[dpdk-dev] [PATCH v3 23/34] net/mvpp2: rearrange functions order

From: Liron Himi Rearrange functions order Signed-off-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 98 - 1 file changed, 49 insertions(+), 49 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c index a386737eeb..b

[dpdk-dev] [PATCH v3 22/34] net/mvpp2: support udf configuration

From: Liron Himi Extend the config file with 'udf' (user-defined) settings Signed-off-by: Liron Himi --- doc/guides/nics/mvpp2.rst | 31 + drivers/net/mvpp2/mrvl_ethdev.c | 4 +- drivers/net/mvpp2/mrvl_qos.c| 212 drivers/net/mvpp2/mrvl_qos.h

[dpdk-dev] [PATCH v3 21/34] net/mvpp2: skip qos init if not requested

From: Liron Himi Skip qos init if not requested Signed-off-by: Liron Himi --- drivers/net/mvpp2/mrvl_qos.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/mvpp2/mrvl_qos.c b/drivers/net/mvpp2/mrvl_qos.c index d3ad7cc5a7..1c65b52764 100644 --- a/drivers/net/m

[dpdk-dev] [PATCH v3 20/34] net/mvpp2: flow: add support for RAW type

From: Liron Himi Add support for RAW type and connect it to MUSDK UDF Signed-off-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.h | 1 + drivers/net/mvpp2/mrvl_flow.c | 141 2 files changed, 142 insertions(+) diff --git a/drivers/net/mvpp2/mrvl_ethdev.h

[dpdk-dev] [PATCH v3 19/34] net/mvpp2: move common functions to common location

From: Liron Himi Move common functions to common location Signed-off-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.h | 41 + drivers/net/mvpp2/mrvl_qos.c| 24 --- 2 files changed, 41 insertions(+), 24 deletions(-) diff --git a/drivers/net

[dpdk-dev] [PATCH v3 18/34] net/mvpp2: flow: build table key along with rule

From: Liron Himi Currently the key is always built in network order regardless of user input. Besides the fact that it is not in user order, it prevent future support for udf header between standard headers. this patch builds the key while parsing the given rule. Signed-off-by: Liron Himi ---

[dpdk-dev] [PATCH v3 17/34] net/mvpp2: flow: support generic pattern combinations

From: Liron Himi Currently only specific pattern combinations are supported. this makes it hard to support additional pattern. in addition there is no a real limitation that prevent any combination. This patch iterate the input patterns and convert them to a mvpp2 API. The doc doesn't describes

[dpdk-dev] [PATCH v3 16/34] net/mvpp2: use generic name for the 'cfg'

From: Liron Himi As the config file is not just for 'qos' it is more accurate to replace the name from 'qos_cfg' to 'cfg' Signed-off-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 12 ++-- drivers/net/mvpp2/mrvl_qos.c| 31 +++ drivers/net/mvpp2/mrv

[dpdk-dev] [PATCH v3 15/34] net/mvpp2: adjust the number of unicast address

From: Liron Himi HW support 25 mac address for filtering plus one for the primary mac address. Signed-off-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev

[dpdk-dev] [PATCH v3 14/34] net/mvpp2: add Tx flow control

From: Yuri Chipchev Add tx flow control operations. Signed-off-by: Yuri Chipchev Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 59 - 1 file changed, 51 insertions(+), 8 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvp

[dpdk-dev] [PATCH v3 13/34] net/mvpp2: add dsa mode support

From: Liron Himi Extend the config file with 'dsa-mode' field. currently 'eth' (default) and 'dsa' headers are supported. Signed-off-by: Liron Himi --- doc/guides/nics/mvpp2.rst | 11 -- drivers/net/mvpp2/mrvl_ethdev.c | 4 ++ drivers/net/mvpp2/mrvl_qos.c| 65 +++

[dpdk-dev] [PATCH v3 12/34] net/mvpp2: update Tx checksum

From: Liron Himi According to the dpdk spec, only 'ol_flags' should be used for tx checksum generation Signed-off-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 60 ++--- 1 file changed, 26 insertions(+), 34 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_et

[dpdk-dev] [PATCH v3 11/34] net/mvpp2: add VLAN offload support

From: Yuri Chipchev Enable VLAN filter configuration Signed-off-by: Yuri Chipchev Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 110 +--- 1 file changed, 86 insertions(+), 24 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/m

[dpdk-dev] [PATCH v3 10/34] net/mvpp2: add loopback support

From: Yuri Chipchev Add support for loopback mode Signed-off-by: Yuri Chipchev Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c index f079939d8c..e64847f4a1 1

[dpdk-dev] [PATCH v3 09/34] net/mvpp2: save initial configuration

From: Yuri Chipchev Save configuration that was done prior 'start' as only then the ppio is being configured. Signed-off-by: Yuri Chipchev Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 101 +++- 1 file changed, 87 insertions(+), 14 deletions(-) dif

[dpdk-dev] [PATCH v3 08/34] net/mvpp2: align checking order

From: Yuri Chipchev First check for 'isolated' and then for '!ppio' Signed-off-by: Yuri Chipchev Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 40 +++-- 1 file changed, 23 insertions(+), 17 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c

[dpdk-dev] [PATCH v3 07/34] net/mvpp2: cosmetic changes to cookie usage

From: Yuri Chipchev No need to add high address to cookie on transmit side, as it has already 64bit value Signed-off-by: Yuri Chipchev Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/net/mvpp

[dpdk-dev] [PATCH v3 06/34] net/mvpp2: update RSS tables reservation

From: Yuri Chipchev In kernel-4.14 the pp2 kernel occupied 4 RSS tables as opposed to 1 RSS table in older version. Signed-off-by: Yuri Chipchev Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mvpp2/mr

[dpdk-dev] [PATCH v3 05/34] net/mvpp2: fix frame size checking

From: Liron Himi Need to add CRC len to the frame-size to compare against max_rx_pkt_len which includes it. Fixes: 79ec62028 ("net/mvpp2: update MTU and MRU related calculations") Cc: sta...@dpdk.org Signed-off-by: Liron Himi Reviewed-by: Yuri Chipchev --- drivers/net/mvpp2/mrvl_ethdev.c | 3

[dpdk-dev] [PATCH v3 04/34] net/mvpp2: remove CRC len from MRU validation

From: Liron Himi CRC is being removed by HW before packet get write to the buffer, so CRC len should not be included in MRU validation Fixes: 79ec62028 ("net/mvpp2: update MTU and MRU related calculations") Cc: sta...@dpdk.org Signed-off-by: Liron Himi Reviewed-by: Yuri Chipchev --- drivers/

[dpdk-dev] [PATCH v3 03/34] net/mvpp2: remove VLAN flush

From: Liron Himi VLAN-flush in MUSDK is not supported yet. until it does, the code should be removed as currently an redundant error message is displayed. Fixes: a8f3d6783 ("net/mrvl: support VLAN filtering") Cc: sta...@dpdk.org Signed-off-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c |

[dpdk-dev] [PATCH v3 02/34] net/mvpp2: remove debug log on fast-path

From: Liron Himi In case of non-ip frame the current code reached the 'default' case which result with function call to log a msg. those kind of calls should not be performed on fast-path. The performance for this kind of frames increased by 50% Fixes: acab7d58c ("net/mvpp2: convert to dynamic

[dpdk-dev] [PATCH v3 01/34] net/mvpp2: fix stack corruption

From: Yuri Chipchev Fixes stack corruption in mrvl_fill_bpool function in case num > MRVL_PP2_RXD_MAX Fixes: c3637258d894 ("net/mrvl: fix Rx descriptors number") Cc: sta...@dpdk.org Signed-off-by: Yuri Chipchev Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 4 ++-- 1 file chan

[dpdk-dev] [PATCH v3 00/34] net/mvpp2: misc updates

From: Liron Himi This patch series align the mainline driver with all changes since 19.11 some of the patches are fixes which should be pushed to stable v3: - remove redundant patches - update doc along with configuration changes v2: - fix commit msg styling - Addressed various review comments

Re: [dpdk-dev] [PATCH] common/mlx5: add GTP TEID modification field ID

Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Monday, January 25, 2021 7:01 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Slava Ovsiienko > ; Matan Azrad > Subject: [PATCH] common/mlx5: add GTP TEID modification field ID > > Define hardware ID for GTP TEID modification. Th

Re: [dpdk-dev] [PATCH] net/mlx5: fix count actions query in sample flow

Hi, > -Original Message- > From: dev On Behalf Of Jiawei Wang > Sent: Tuesday, January 26, 2021 5:38 PM > To: Slava Ovsiienko ; Ori Kam > ; NBU-Contact-Thomas Monjalon > ; ferruh.yi...@intel.com > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix count actions

  1   2   >