Re: [dpdk-dev] [dpdk-stable] [PATCH v1 1/1] test/distributor: prevent return buffer overload

2021-01-29 Thread David Marchand
On Thu, Jan 28, 2021 at 3:10 PM David Marchand wrote: > > On Tue, Jan 19, 2021 at 4:59 AM Lukasz Wojciechowski > wrote: > > > > The distributor library implementation uses a cyclic queue to store > > packets returned from workers. These packets can be later collected > > with rte_distributor_retu

[dpdk-dev] [Bug 576] "‘str2flowtype’ defined but not used" when building with net/i40e disabled

2021-01-29 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=576 Zhang, RobinX (robinx.zh...@intel.com) changed: What|Removed |Added Resolution|--- |FIXED Status|

Re: [dpdk-dev] [dpdk-techboard] [PATCH v6 2/8] eal: fix error attribute use for clang

2021-01-29 Thread David Marchand
On Thu, Jan 28, 2021 at 6:36 PM Bruce Richardson wrote: > > > > > We will never know about those compilers behavior, like how we caught > > > > > the clang issue and found an alternative. > > > > > > > > > > > > > So I understand, but I'm still concerned about breaking something that > > > > was

Re: [dpdk-dev] [PATCH v14 00/12] Arm build options rework

2021-01-29 Thread Juraj Linkeš
> > 3) We need to build kni against the aarch64 kernel headers, but it > > fails. It appears that kernel/linux/kni/meson.build doesn’t pass any > > cross-compile flags in the make command it creates. The diff below > > shows how I hardcoded it to get it to work for now. Thoughts on how to > > do th

Re: [dpdk-dev] [PATCH v2 2/5] net/hns3: add FEC feature for hns3.ini

2021-01-29 Thread Ferruh Yigit
On 1/29/2021 1:13 AM, oulijun wrote: 在 2021/1/28 22:12, Thomas Monjalon 写道: 28/01/2021 13:43, Lijun Ou: The hns3 PMD add FEC features implementation in 20.11. Therefore, need to update the hns3.ini for supporting. Fixes: 9bf2ea8dbc65 ("net/hns3: support FEC") Cc: sta...@dpdk.org Signed-off-

Re: [dpdk-dev] [PATCH v2 4/5] doc: update release notes for hns3

2021-01-29 Thread Ferruh Yigit
On 1/29/2021 1:28 AM, oulijun wrote: 在 2021/1/28 22:46, Ferruh Yigit 写道: On 1/28/2021 12:43 PM, Lijun Ou wrote: Add TM(Traffic Management) feature with hns3 in release notes. It includes: 1. configure port's peak rate with PF 2. configure TC's peak rate with PF Fixes: c09c7847d892 ("net/hns3

Re: [dpdk-dev] [dpdk-techboard] [PATCH v6 2/8] eal: fix error attribute use for clang

2021-01-29 Thread Thomas Monjalon
29/01/2021 09:35, David Marchand: > On Thu, Jan 28, 2021 at 6:36 PM Bruce Richardson > wrote: > > > > > > We will never know about those compilers behavior, like how we > > > > > > caught > > > > > > the clang issue and found an alternative. > > > > > > > > > > > > > > > > So I understand, but I'

Re: [dpdk-dev] [PATCH v2 2/5] net/hns3: add FEC feature for hns3.ini

2021-01-29 Thread Thomas Monjalon
29/01/2021 09:46, Ferruh Yigit: > On 1/29/2021 1:13 AM, oulijun wrote: > > 在 2021/1/28 22:12, Thomas Monjalon 写道: > >> 28/01/2021 13:43, Lijun Ou: > >>> The hns3 PMD add FEC features implementation in 20.11. > >>> Therefore, need to update the hns3.ini for supporting. > >>> > >>> Fixes: 9bf2ea8dbc6

Re: [dpdk-dev] [PATCH v12 1/4] raw/ifpga: add fpga rsu function

2021-01-29 Thread Ferruh Yigit
On 1/29/2021 7:38 AM, Huang, Wei wrote: -Original Message- From: Ferruh Yigit Sent: Thursday, January 28, 2021 21:25 To: Huang, Wei ; dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z Cc: sta...@dpdk.org; Zhang, Tianfei ; Ray Kinsella ; Hemant Agrawal Subject: Re: [dpdk-dev] [PATCH v12 1/4] ra

Re: [dpdk-dev] [PATCH v2 2/5] net/hns3: add FEC feature for hns3.ini

2021-01-29 Thread oulijun
在 2021/1/29 16:46, Ferruh Yigit 写道: On 1/29/2021 1:13 AM, oulijun wrote: 在 2021/1/28 22:12, Thomas Monjalon 写道: 28/01/2021 13:43, Lijun Ou: The hns3 PMD add FEC features implementation in 20.11. Therefore, need to update the hns3.ini for supporting. Fixes: 9bf2ea8dbc65 ("net/hns3: suppor

Re: [dpdk-dev] [PATCH v6 04/12] net/octeontx_ep: add device init and uninit

2021-01-29 Thread Ferruh Yigit
On 1/29/2021 12:16 AM, Nalla Pradeep wrote: Add basic init and uninit function which includes initializing fields of ethdev private structure. Signed-off-by: Nalla Pradeep <...> @@ -43,6 +104,7 @@ otx_ep_eth_dev_pci_remove(struct rte_pci_device *pci_dev) /* Set of PCI devices this driver

[dpdk-dev] [PATCH v3 0/3] update doc for hns3

2021-01-29 Thread Lijun Ou
Here series add some updates for hns3 rst and TM feature note for hns3 as well as FEC feature notes. v3: 1. merge patch[2/3] into patch[1] base on v2 2. fix some format errors v2: 1. fix a meson build warning for patch[4/5] 2. add a new patch for update hns3.ini and cxgbe.ini 3. add Fixes for all

[dpdk-dev] [PATCH v3 2/3] doc: update release notes for hns3

2021-01-29 Thread Lijun Ou
Add TM(Traffic Management) feature with hns3 in release notes. It includes: 1. configure port's peak rate with PF 2. configure TC's peak rate with PF Fixes: c09c7847d892 ("net/hns3: support traffic management") Cc: sta...@dpdk.org Signed-off-by: Lijun Ou --- V2->V3: - delete the unnecessary info

[dpdk-dev] [PATCH v3 3/3] doc: fix hns3 rst

2021-01-29 Thread Lijun Ou
Here fixes the Kunpeng introduction address link with hns3.rst Fixes: 565829db8b8f ("net/hns3: add build and doc infrastructure") Cc: sta...@dpdk.org Signed-off-by: Lijun Ou --- doc/guides/nics/hns3.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/nics/hns3.rst

[dpdk-dev] [PATCH v3 1/3] doc: add FEC in NIC features

2021-01-29 Thread Lijun Ou
From: "Min Hu (Connor)" Document FEC in NIC features, add information about FEC and add implementation related support. Fixes: b7ccfb09da95 ("ethdev: introduce FEC API") Fixes: 9bf2ea8dbc65 ("net/hns3: support FEC") Fixes: 62aafe035896 ("net/cxgbe: support configuring link FEC") Cc: sta...@dpdk.

Re: [dpdk-dev] [PATCH v6 11/12] net/octeontx_ep: receive data path function added

2021-01-29 Thread Ferruh Yigit
On 1/29/2021 12:16 AM, Nalla Pradeep wrote: Function to deliver packets from DROQ to application is added. It also fills DROQ with receive buffers timely such that device can fill them with incoming packets. Signed-off-by: Nalla Pradeep <...> @@ -240,7 +246,6 @@ otx_ep_droq_setup_ring_buffe

Re: [dpdk-dev] [PATCH v6] app/testpmd: fix setting maximum packet length

2021-01-29 Thread Ferruh Yigit
On 1/28/2021 12:07 PM, Ferruh Yigit wrote: From: Steve Yang "port config all max-pkt-len" command fails because it doesn't set the 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag properly. Commit in the fixes line moved the 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag update from 'cmd_config_max_pkt_le

Re: [dpdk-dev] [PATCH v2] net/virtio: fix compiling issue for vectorized NEON path

2021-01-29 Thread Subhi Masri
Hi, > -Original Message- > From: Maxime Coquelin > Sent: Wednesday, January 27, 2021 10:44 AM > To: Subhi Masri > Cc: dev@dpdk.org; n...@arm.com; Joyce Kong ; > david.march...@redhat.com; honnappa.nagaraha...@arm.com; > ruifeng.w...@arm.com; i.maxim...@ovn.org > Subject: Re: [PATCH v2] n

[dpdk-dev] [PATCH] lib/librte_vhost: fix vid allocation race

2021-01-29 Thread Peng He
From: "chenwei.0515" vhost_new_devcie might be called in different threads at the same time. thread 1(config thread) rte_vhost_driver_start ->vhost_user_start_client ->vhost_user_add_connection -> vhost_new_device thread 2(vhost-

Re: [dpdk-dev] [PATCH v14 00/12] Arm build options rework

2021-01-29 Thread Bruce Richardson
On Fri, Jan 29, 2021 at 08:41:45AM +, Juraj Linkeš wrote: > > > 3) We need to build kni against the aarch64 kernel headers, but it > > > fails. It appears that kernel/linux/kni/meson.build doesn’t pass any > > > cross-compile flags in the make command it creates. The diff below > > > shows how

Re: [dpdk-dev] Feature Discussion: CPU topology detection on FreeBSD

2021-01-29 Thread Bruce Richardson
On Thu, Jan 28, 2021 at 04:07:07AM +, Oscar Zhao wrote: > Hello dpdk devs, > > I would like to discuss the feasibility of implementing CPU topology > detection on FreeBSD. Currently both eal_cpu_core_id() and > eal_cpu_socket_id() in rte_eal library always return 0 on FreeBSD, making > NUMA

Re: [dpdk-dev] [PATCH v14 00/12] Arm build options rework

2021-01-29 Thread Juraj Linkeš
> -Original Message- > From: Bruce Richardson > Sent: Friday, January 29, 2021 10:46 AM > To: Juraj Linkeš > Cc: Andrew Boyer ; Honnappa Nagarahalli > ; tho...@monjalon.net; Ruifeng Wang > ; Phil Yang ; > vcchu...@amazon.com; Dharmik Thakkar ; > jerinjac...@gmail.com; hemant.agra...@nxp

Re: [dpdk-dev] How to Enable Mellanox Driver Compilation with DPDK20.11

2021-01-29 Thread Bruce Richardson
On Fri, Jan 29, 2021 at 11:50:08AM +0530, Truring Team wrote: > Hi Team , > > Can someone help me to figure out how to enable the Mellanox Driver flag > in meson.build file , so that dpdk 20.11 compiles with mlx driver enabled. > If the driver is not being built there should be a reason given in

Re: [dpdk-dev] [PATCH v14 00/12] Arm build options rework

2021-01-29 Thread Bruce Richardson
On Fri, Jan 29, 2021 at 10:07:30AM +, Juraj Linkeš wrote: > > > > -Original Message- > > From: Bruce Richardson > > Sent: Friday, January 29, 2021 10:46 AM > > To: Juraj Linkeš > > Cc: Andrew Boyer ; Honnappa Nagarahalli > > ; tho...@monjalon.net; Ruifeng Wang > > ; Phil Yang ; > >

[dpdk-dev] [PATCH v5 0/6] power: fix make build for power apps

2021-01-29 Thread David Hunt
The guest channel message definitions and functions in guest_channel.h are needed by applications and need to be made public. This worked pre-20.11, but now with all the meson/ninja changes, making these apps externally no longer works. To fix, we need to move the header file with the API definiti

[dpdk-dev] [PATCH v5 1/6] power: create guest channel public header file

2021-01-29 Thread David Hunt
From: Bruce Richardson In preparation for making the header file public, we first rename channel_commands.h as rte_power_guest_channel.h. Fixes: 210c383e247b ("power: packet format for vm power management") Fixes: cd0d5547e873 ("power: vm communication channels in guest") Cc: sta...@dpdk.org Si

[dpdk-dev] [PATCH v5 2/6] power: make channel msg functions public

2021-01-29 Thread David Hunt
From: Bruce Richardson Move the 2 public functions into rte_power_guest_channel.h Fixes: 210c383e247b ("power: packet format for vm power management") Fixes: cd0d5547e873 ("power: vm communication channels in guest") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson Signed-off-by: David Hunt

[dpdk-dev] [PATCH v5 3/6] power: rename public structs

2021-01-29 Thread David Hunt
From: Bruce Richardson rename the public structs to have an rte_power_ prefix and add them to version.map in experimental section. Fixes: 210c383e247b ("power: packet format for vm power management") Fixes: cd0d5547e873 ("power: vm communication channels in guest") Cc: sta...@dpdk.org Signed-of

[dpdk-dev] [PATCH v5 4/6] power: rename defines

2021-01-29 Thread David Hunt
From: Bruce Richardson Rename the #defines to have an RTE_POWER_ prefix Fixes: 210c383e247b ("power: packet format for vm power management") Fixes: cd0d5547e873 ("power: vm communication channels in guest") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson Signed-off-by: David Hunt Acked-by

[dpdk-dev] [PATCH v5 5/6] power: add new header file to export list

2021-01-29 Thread David Hunt
From: Bruce Richardson Adjust meson.build so that 'ninja install' copies the new header file into the installation directory. Fixes: 210c383e247b ("power: packet format for vm power management") Fixes: cd0d5547e873 ("power: vm communication channels in guest") Cc: sta...@dpdk.org Signed-off-by:

[dpdk-dev] [PATCH v5 6/6] power: clean up includes

2021-01-29 Thread David Hunt
From: Bruce Richardson re-organise the including of the new public header file and remove un-needed includes Fixes: 210c383e247b ("power: packet format for vm power management") Fixes: cd0d5547e873 ("power: vm communication channels in guest") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson

Re: [dpdk-dev] [dpdk-stable] [PATCH v4 0/6] power: fix make build for power apps

2021-01-29 Thread Thomas Monjalon
21/01/2021 18:21, David Hunt: > The guest channel message definitions and functions in guest_channel.h > are needed by applications and need to be made public. > > This worked pre-20.11, but now with all the meson/ninja changes, making > these apps externally no longer works. To fix, we need to mo

[dpdk-dev] [RFC PATCH v1] build: kni gcc cross-compilation support

2021-01-29 Thread Juraj Linkeš
The kni linux module is using a custom target for building, which doesn't take into account any cross compilation arguments. The arguments in question are ARCH and CROSS_COMPILE. Get those from the cross file and pass them to the custom target. The user supplied path may not contain the 'build' di

Re: [dpdk-dev] [PATCH v5 0/6] power: fix make build for power apps

2021-01-29 Thread Thomas Monjalon
29/01/2021 11:21, David Hunt: > The guest channel message definitions and functions in guest_channel.h > are needed by applications and need to be made public. > > This worked pre-20.11, but now with all the meson/ninja changes, making > these apps externally no longer works. To fix, we need to mo

Re: [dpdk-dev] [PATCH v2] app/testpmd: tx pkt clones parameter in flowgen

2021-01-29 Thread Ferruh Yigit
On 1/21/2021 6:05 PM, Igor Russkikh wrote: When testing high performance numbers, it is often that CPU performance limits the max values device can reach (both in pps and in gbps) Here instead of recreating each packet separately, we use clones counter to resend the same mbuf to the line multipl

Re: [dpdk-dev] [PATCH v3 0/3] refactoring ring library

2021-01-29 Thread David Marchand
On Fri, Jan 29, 2021 at 6:59 AM Feifei Wang wrote: > > Do some work for ring refactoring, which includes: > 1. add rte prefix before update tail API > 2. Move all private APIs into new header files > > v2: > 1. add rte_ prefixes for private files (Konstantin) > > v3: > 1. fix compile issue of file

Re: [dpdk-dev] [EXT] Re: [PATCH v2] app/testpmd: tx pkt clones parameter in flowgen

2021-01-29 Thread Igor Russkikh
> > Signed-off-by: Igor Russkikh > > Reviewed-by: Ferruh Yigit > > Also a testpmd command to set the 'flowgen-clones' can be useful, for > interactive mode. If you have time for it, can you please work on it too? > > > Applied to dpdk-next-net/main, thanks. Thanks, Ferruh. Good idea, will

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] app/testpmd: avoid exit without terminal restore

2021-01-29 Thread Ferruh Yigit
On 1/26/2021 8:24 AM, Li, Xiaoyun wrote: <...> From: Dapeng Yu In interactive mode, if testpmd exit by calling rte_exit without restore terminal attributes, terminal will not echo keyboard input. register a function with atexit() in prompt(), when exit() in rte_exit() is called, the registe

Re: [dpdk-dev] [PATCH v20 1/4] eal: rename power monitor condition member

2021-01-29 Thread Thomas Monjalon
22/01/2021 18:12, Anatoly Burakov: > The `data_sz` name is fine, but it looks out of place because nothing > else has "data" prefix in that structure. Rename it to "size", as well > as add more clarity to the comments around each struct member. > > Fixes: 6a17919b0e2a ("eal: change power intrinsic

Re: [dpdk-dev] [PATCH v20 2/4] eal: improve comments around power monitoring API

2021-01-29 Thread Thomas Monjalon
22/01/2021 18:12, Anatoly Burakov: > Currently, the API documentation is ambiguous as to what happens when > certain conditions are met. Document the behavior explicitly, as well as > fix some typos and outdated comments. > > Fixes: 6a17919b0e2a ("eal: change power intrinsics API") > > Signed-off

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/nfp: read chip model from PluDevice register

2021-01-29 Thread Ferruh Yigit
On 1/25/2021 3:25 PM, Heinrich Kuhn wrote: For newer smartNIC NVRAM versions the chip model should be read from the PluDevice register as it provides the authoritative chip model/revision. This method of reading the chip model is backwards compatible with legacy NVRAM versions too. Since the mod

Re: [dpdk-dev] [RFC PATCH v1] build: kni gcc cross-compilation support

2021-01-29 Thread Bruce Richardson
On Fri, Jan 29, 2021 at 11:29:19AM +0100, Juraj Linkeš wrote: > The kni linux module is using a custom target for building, which > doesn't take into account any cross compilation arguments. The arguments > in question are ARCH and CROSS_COMPILE. Get those from the cross file > and pass them to the

Re: [dpdk-dev] [PATCH v3 0/3] update doc for hns3

2021-01-29 Thread Ferruh Yigit
On 1/29/2021 9:22 AM, Lijun Ou wrote: Here series add some updates for hns3 rst and TM feature note for hns3 as well as FEC feature notes. v3: 1. merge patch[2/3] into patch[1] base on v2 2. fix some format errors v2: 1. fix a meson build warning for patch[4/5] 2. add a new patch for update hns

Re: [dpdk-dev] [PATCH v2 4/5] net/ena: fix Tx sq free space assessment

2021-01-29 Thread Ferruh Yigit
On 1/26/2021 6:32 PM, Michal Krawczyk wrote: From: Igor Chauskin Before starting transmission of Tx burst, the driver checked the available space in the sq and limited the number of packets for transmission accordingly. The calculation was incorrect for fragmented packets and potentially had si

Re: [dpdk-dev] [PATCH v2 5/5] net/ena: prevent double doorbell

2021-01-29 Thread Ferruh Yigit
On 1/26/2021 6:32 PM, Michal Krawczyk wrote: From: Igor Chauskin Add per-tx-ring flag for packets that were pushed to HW but await doorbell. That is to prevent a situation when a doorbell is sent due to reaching Tx burst threshold and next send fails (e.g., due to queue full). In such case we s

Re: [dpdk-dev] [PATCH v2 4/5] net/ena: fix Tx sq free space assessment

2021-01-29 Thread Michał Krawczyk
pt., 29 sty 2021 o 13:07 Ferruh Yigit napisał(a): > > On 1/26/2021 6:32 PM, Michal Krawczyk wrote: > > From: Igor Chauskin > > > > Before starting transmission of Tx burst, the driver checked the > > available space in the sq and limited the number of packets for > > transmission accordingly. > >

Re: [dpdk-dev] [PATCH v2 0/5] net/ena: minor bug fixes and improvements

2021-01-29 Thread Ferruh Yigit
On 1/26/2021 6:32 PM, Michal Krawczyk wrote: Hi, this patchset contains few bug fixes for the ENA PMD and the version upgrade to v2.2.1. Besides that, the validation of the Rx req ID was optimized. Best regards, Michal --- v2: * Add patch preventing double doorbell on Tx. Amit Bernstein (1

Re: [dpdk-dev] [RFC PATCH v1] build: kni gcc cross-compilation support

2021-01-29 Thread Juraj Linkeš
> -Original Message- > From: Bruce Richardson > Sent: Friday, January 29, 2021 12:44 PM > To: Juraj Linkeš > Cc: tho...@monjalon.net; ruifeng.w...@arm.com; jerinjac...@gmail.com; > hemant.agra...@nxp.com; ferruh.yi...@intel.com; abo...@pensando.io; > dev@dpdk.org > Subject: Re: [RFC PAT

Re: [dpdk-dev] [PATCH v2 0/5] net/ena: minor bug fixes and improvements

2021-01-29 Thread Michał Krawczyk
pt., 29 sty 2021 o 13:17 Ferruh Yigit napisał(a): > > On 1/26/2021 6:32 PM, Michal Krawczyk wrote: > > Hi, > > > > this patchset contains few bug fixes for the ENA PMD and the version > > upgrade to v2.2.1. Besides that, the validation of the Rx req ID was > > optimized. > > > > Best regards, > >

Re: [dpdk-dev] [dpdk-stable] [PATCH v1 1/1] test/distributor: prevent return buffer overload

2021-01-29 Thread Lukasz Wojciechowski
Thank you guys! W dniu 29.01.2021 o 09:03, David Marchand pisze: > On Thu, Jan 28, 2021 at 3:10 PM David Marchand > wrote: >> On Tue, Jan 19, 2021 at 4:59 AM Lukasz Wojciechowski >> wrote: >>> The distributor library implementation uses a cyclic queue to store >>> packets returned from workers.

[dpdk-dev] [PATCH v7 00/12] Octeon Tx/Tx2 Endpoint pmd

2021-01-29 Thread Nalla Pradeep
v2: Fixed review comments from sburla at marvell v3: Fixed review comments from jerinj at marvell v4: Fixed MAITAINERS file v5: Fixed review comments from Ferruh yigit at intel v6: Created separate patch for octeontx_ep raw driver changes. Used pmd specific log types instead of 'RTE_LOG

[dpdk-dev] [PATCH v7 01/12] raw/octeontx_ep: changed device id

2021-01-29 Thread Nalla Pradeep
Device id to be probed by octeontx_ep raw device pmd is changed from B203 to B204. B203 is for octeontx_ep net device pmd to probe. Signed-off-by: Nalla Pradeep --- drivers/common/octeontx2/otx2_common.h| 3 ++- drivers/raw/octeontx2_ep/otx2_ep_rawdev.c | 6 +++--- 2 files changed, 5 inserti

[dpdk-dev] [PATCH v7 03/12] net/octeontx_ep: add ethdev probe and remove

2021-01-29 Thread Nalla Pradeep
add basic PCIe ethdev probe and remove. Signed-off-by: Nalla Pradeep --- drivers/common/octeontx2/otx2_common.h | 2 + drivers/net/octeontx_ep/meson.build | 2 + drivers/net/octeontx_ep/otx_ep_common.h | 14 ++ drivers/net/octeontx_ep/otx_ep_ethdev.c | 57 + dr

[dpdk-dev] [PATCH v7 05/12] net/octeontx_ep: added basic device setup

2021-01-29 Thread Nalla Pradeep
Functions to setup device, basic input queue and output queue registers are added. Signed-off-by: Nalla Pradeep --- drivers/net/octeontx_ep/meson.build | 2 + drivers/net/octeontx_ep/otx2_ep_vf.c| 131 + drivers/net/octeontx_ep/otx2_ep_vf.h| 11 ++ drivers/net/

[dpdk-dev] [PATCH v7 06/12] net/octeontx_ep: add dev info get and configure

2021-01-29 Thread Nalla Pradeep
Add device information get and device configure operations. Signed-off-by: Nalla Pradeep --- doc/guides/nics/features/octeontx_ep.ini | 1 + drivers/net/octeontx_ep/otx_ep_common.h | 14 drivers/net/octeontx_ep/otx_ep_ethdev.c | 81 +++- drivers/net/octeontx_ep/otx_ep

[dpdk-dev] [PATCH v7 04/12] net/octeontx_ep: add device init and uninit

2021-01-29 Thread Nalla Pradeep
Add basic init and uninit function which includes initializing fields of ethdev private structure. Signed-off-by: Nalla Pradeep --- drivers/net/octeontx_ep/otx_ep_common.h | 22 +++- drivers/net/octeontx_ep/otx_ep_ethdev.c | 72 +++-- 2 files changed, 88 insertions(+), 6

[dpdk-dev] [PATCH v7 08/12] net/octeontx_ep: added tx queue setup and release

2021-01-29 Thread Nalla Pradeep
Transmit queue setup involves allocating memory for the command queue considering tx descriptor count and initializing data structure representing the queue. Transmit queue release function frees the command queue. Signed-off-by: Nalla Pradeep --- drivers/net/octeontx_ep/otx_ep_common.h | 88 ++

[dpdk-dev] [PATCH v7 02/12] net/octeontx_ep: add build and doc infrastructure

2021-01-29 Thread Nalla Pradeep
Adding bare minimum PMD library and doc build infrastructure and claim the maintainership for octeontx end point PMD. Signed-off-by: Nalla Pradeep --- MAINTAINERS | 9 doc/guides/nics/features/octeontx_ep.ini | 10 + doc/guides/nics/index.rst

[dpdk-dev] [PATCH v7 07/12] net/octeontx_ep: added rxq setup and release

2021-01-29 Thread Nalla Pradeep
Receive queue setup involves allocating memory for the queue, initializing data structure representing the queue and filling queue with receive buffers of rx descriptor count. Receive queues are referred as droq. Hardware fills the receive buffers in queue with the packet. In receive queue release

[dpdk-dev] [PATCH v7 09/12] net/octeontx_ep: setting up iq and oq registers

2021-01-29 Thread Nalla Pradeep
Configuring hardware registers with command queue(iq) and driver output queue(oq) parameters. List of parameters configured for IQ after making sure it is idle 1. Base address 2. Instruction size 3. Disabling interrupts for fastpath List of parameters configured for OQ after making sure it is idle

[dpdk-dev] [PATCH v7 10/12] net/octeontx_ep: added dev start and stop

2021-01-29 Thread Nalla Pradeep
Dev start and stop operations are added. To accomplish this internal functions to enable or disable io queues are incorporated. Signed-off-by: Nalla Pradeep --- drivers/net/octeontx_ep/otx2_ep_vf.c| 107 drivers/net/octeontx_ep/otx_ep_common.h | 8 ++ drivers/net/octeo

[dpdk-dev] [PATCH v7 11/12] net/octeontx_ep: receive data path function added

2021-01-29 Thread Nalla Pradeep
Function to deliver packets from DROQ to application is added. It also fills DROQ with receive buffers timely such that device can fill them with incoming packets. Signed-off-by: Nalla Pradeep --- drivers/net/octeontx_ep/otx_ep_common.h | 1 + drivers/net/octeontx_ep/otx_ep_ethdev.c | 3 + d

[dpdk-dev] [PATCH v7 12/12] net/octeontx_ep: transmit data path function added

2021-01-29 Thread Nalla Pradeep
1. Packet transmit function for both otx and otx2 are added. 2. Flushing transmit(command) queue when pending commands are more than maximum allowed value (currently 16). 3. Scatter gather support if the packet spans multiple buffers. Signed-off-by: Nalla Pradeep --- drivers/net/octeontx_ep/o

Re: [dpdk-dev] How to Enable Mellanox Driver Compilation with DPDK20.11

2021-01-29 Thread Truring Team
Hi Bruce , Thanks a lot for your help. After installing below packages mlx is compiled . yum -y groupinstall "Infiniband Support" yum install -y gcc kernel-devel-`uname -r` numactl-devel.x86_64 librdmacm-devel libmnl-devel *find . -name *.a | grep mlx* *./drivers/libtmp_rte_common_mlx5.a* *./

Re: [dpdk-dev] Feature Discussion: CPU topology detection on FreeBSD

2021-01-29 Thread Burakov, Anatoly
On 29-Jan-21 10:05 AM, Bruce Richardson wrote: On Thu, Jan 28, 2021 at 04:07:07AM +, Oscar Zhao wrote: Hello dpdk devs, I would like to discuss the feasibility of implementing CPU topology detection on FreeBSD. Currently both eal_cpu_core_id() and eal_cpu_socket_id() in rte_eal library al

Re: [dpdk-dev] Feature Discussion: CPU topology detection on FreeBSD

2021-01-29 Thread Bruce Richardson
On Fri, Jan 29, 2021 at 12:52:50PM +, Burakov, Anatoly wrote: > On 29-Jan-21 10:05 AM, Bruce Richardson wrote: > > On Thu, Jan 28, 2021 at 04:07:07AM +, Oscar Zhao wrote: > > > Hello dpdk devs, > > > > > > I would like to discuss the feasibility of implementing CPU topology > > > detectio

[dpdk-dev] Feature Discussion: CPU topology detection on FreeBSD

2021-01-29 Thread Oscar Zhao
Hello dpdk devs, I would like to discuss the feasibility of implementing CPU topology detection on FreeBSD. Currently both eal_cpu_core_id() and eal_cpu_socket_id() in rte_eal library always return 0 on FreeBSD, making NUMA-aware development impossible without resorting to external libraries or

Re: [dpdk-dev] [RFC PATCH v1] build: kni gcc cross-compilation support

2021-01-29 Thread Bruce Richardson
On Fri, Jan 29, 2021 at 12:33:06PM +, Juraj Linkeš wrote: > > > > -Original Message- > > From: Bruce Richardson > > Sent: Friday, January 29, 2021 12:44 PM > > To: Juraj Linkeš > > Cc: tho...@monjalon.net; ruifeng.w...@arm.com; jerinjac...@gmail.com; > > hemant.agra...@nxp.com; ferr

Re: [dpdk-dev] [PATCH v7 07/12] net/octeontx_ep: added rxq setup and release

2021-01-29 Thread Ferruh Yigit
On 1/29/2021 12:45 PM, Nalla Pradeep wrote: Receive queue setup involves allocating memory for the queue, initializing data structure representing the queue and filling queue with receive buffers of rx descriptor count. Receive queues are referred as droq. Hardware fills the receive buffers in qu

Re: [dpdk-dev] [PATCH v7 08/12] net/octeontx_ep: added tx queue setup and release

2021-01-29 Thread Ferruh Yigit
On 1/29/2021 12:45 PM, Nalla Pradeep wrote: Transmit queue setup involves allocating memory for the command queue considering tx descriptor count and initializing data structure representing the queue. Transmit queue release function frees the command queue. Signed-off-by: Nalla Pradeep <...>

Re: [dpdk-dev] [PATCH v7 00/12] Octeon Tx/Tx2 Endpoint pmd

2021-01-29 Thread Ferruh Yigit
On 1/29/2021 12:44 PM, Nalla Pradeep wrote: v2: Fixed review comments from sburla at marvell v3: Fixed review comments from jerinj at marvell v4: Fixed MAITAINERS file v5: Fixed review comments from Ferruh yigit at intel v6: Created separate patch for octeontx_ep raw driver changes

Re: [dpdk-dev] [PATCH v20 4/4] examples/l3fwd-power: enable PMD power mgmt

2021-01-29 Thread Thomas Monjalon
22/01/2021 18:12, Anatoly Burakov: > From: Liang Ma > > Add PMD power management feature support to l3fwd-power sample app. > > Signed-off-by: Liang Ma > Signed-off-by: Anatoly Burakov > Acked-by: David Hunt > --- [...] > +PMD Power Management Mode > +- There should b

Re: [dpdk-dev] ixgbe and UDP with zero checksum

2021-01-29 Thread Paolo Valerio
"Wang, Haiyue" writes: > Hi Paolo, > >> -Original Message- >> From: Wang, Haiyue >> Sent: Friday, January 29, 2021 10:02 >> To: Paolo Valerio >> Cc: Guo, Jia ; Aaron Conole ; >> dev@dpdk.org >> Subject: RE: ixgbe and UDP with zero checksum >> >> > -Original Message- >> > From:

Re: [dpdk-dev] [PATCH v20 0/4] Add PMD power management

2021-01-29 Thread Thomas Monjalon
22/01/2021 18:12, Anatoly Burakov: > Things of note: > > - Only 1:1 core to queue mapping is supported, meaning that each lcore > must at most handle RX on a single queue Is there a way to have a more generic solution? I think it may deserve some comments in the API. > - Support 3 type polici

Re: [dpdk-dev] [RFC PATCH v1] build: kni gcc cross-compilation support

2021-01-29 Thread Juraj Linkeš
> -Original Message- > From: Bruce Richardson > Sent: Friday, January 29, 2021 2:51 PM > To: Juraj Linkeš > Cc: tho...@monjalon.net; ruifeng.w...@arm.com; jerinjac...@gmail.com; > hemant.agra...@nxp.com; ferruh.yi...@intel.com; abo...@pensando.io; > dev@dpdk.org > Subject: Re: [RFC PATC

Re: [dpdk-dev] [RFC PATCH v1] build: kni gcc cross-compilation support

2021-01-29 Thread Bruce Richardson
On Fri, Jan 29, 2021 at 02:36:58PM +, Juraj Linkeš wrote: > > > > -Original Message- > > From: Bruce Richardson > > Sent: Friday, January 29, 2021 2:51 PM > > To: Juraj Linkeš > > Cc: tho...@monjalon.net; ruifeng.w...@arm.com; jerinjac...@gmail.com; > > hemant.agra...@nxp.com; ferru

Re: [dpdk-dev] [PATCH v20 0/4] Add PMD power management

2021-01-29 Thread Burakov, Anatoly
On 29-Jan-21 2:20 PM, Thomas Monjalon wrote: 22/01/2021 18:12, Anatoly Burakov: Things of note: - Only 1:1 core to queue mapping is supported, meaning that each lcore must at most handle RX on a single queue Is there a way to have a more generic solution? I think it may deserve some commen

[dpdk-dev] [Bug 629] ixgbe: 82599 chksum rx offload marks UDP packets over IPv4 with zero checksum as CKSUM_BAD

2021-01-29 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=629 Bug ID: 629 Summary: ixgbe: 82599 chksum rx offload marks UDP packets over IPv4 with zero checksum as CKSUM_BAD Product: DPDK Version: 20.11 Hardware: All OS: All

Re: [dpdk-dev] [RFC PATCH v1] build: kni gcc cross-compilation support

2021-01-29 Thread Juraj Linkeš
> -Original Message- > From: Bruce Richardson > Sent: Friday, January 29, 2021 3:42 PM > To: Juraj Linkeš > Cc: tho...@monjalon.net; ruifeng.w...@arm.com; jerinjac...@gmail.com; > hemant.agra...@nxp.com; ferruh.yi...@intel.com; abo...@pensando.io; > dev@dpdk.org > Subject: Re: [RFC PATC

Re: [dpdk-dev] [PATCH 1/1] lib: fix doxygen for parameters of function pointers

2021-01-29 Thread Thomas Monjalon
22/01/2021 00:15, Thomas Monjalon: > Some parameters of typedef'ed function pointers were not properly listed > in the doxygen comments. > The error is seen with doxygen 1.9 which added this specific check: > https://github.com/doxygen/doxygen/commit/d34236ba4037 > > Cc: sta...@dpdk.org > >

Re: [dpdk-dev] [RFC PATCH v1] build: kni gcc cross-compilation support

2021-01-29 Thread Bruce Richardson
On Fri, Jan 29, 2021 at 02:47:57PM +, Juraj Linkeš wrote: > > > > -Original Message- > > From: Bruce Richardson > > Sent: Friday, January 29, 2021 3:42 PM > > To: Juraj Linkeš > > Cc: tho...@monjalon.net; ruifeng.w...@arm.com; jerinjac...@gmail.com; > > hemant.agra...@nxp.com; ferru

Re: [dpdk-dev] [PATCH] examples/pipeline: fix CLI segfault

2021-01-29 Thread Thomas Monjalon
28/01/2021 20:12, Cristian Dumitrescu: > Cannot dereference pointer for token[1] unless valid. > > Fixes: 5074e1d551 ("examples/pipeline: add configuration commands") > Cc: sta...@dpdk.org > > Signed-off-by: Cristian Dumitrescu Applied, thanks

Re: [dpdk-dev] [PATCH v2 0/5] net/ena: minor bug fixes and improvements

2021-01-29 Thread Ferruh Yigit
On 1/29/2021 12:33 PM, Michał Krawczyk wrote: pt., 29 sty 2021 o 13:17 Ferruh Yigit napisał(a): On 1/26/2021 6:32 PM, Michal Krawczyk wrote: Hi, this patchset contains few bug fixes for the ENA PMD and the version upgrade to v2.2.1. Besides that, the validation of the Rx req ID was optimized

Re: [dpdk-dev] [RFC PATCH v1] build: kni gcc cross-compilation support

2021-01-29 Thread Juraj Linkeš
> -Original Message- > From: Bruce Richardson > Sent: Friday, January 29, 2021 4:01 PM > To: Juraj Linkeš > Cc: tho...@monjalon.net; ruifeng.w...@arm.com; jerinjac...@gmail.com; > hemant.agra...@nxp.com; ferruh.yi...@intel.com; abo...@pensando.io; > dev@dpdk.org > Subject: Re: [RFC PATC

[dpdk-dev] [PATCH] mem: fix deadlock on secondary allocation

2021-01-29 Thread Anatoly Burakov
Previous fix used `rte_malloc_heap_socket_is_external()` to check if the heap was an external heap. However, that API is thread-safe, and when we're inside the allocation process, we're already write-locked, so calling `rte_malloc_heap_socket_is_external()` will result in a deadlock followed by a t

Re: [dpdk-dev] [RFC PATCH v1] build: kni gcc cross-compilation support

2021-01-29 Thread Bruce Richardson
On Fri, Jan 29, 2021 at 03:17:02PM +, Juraj Linkeš wrote: > > > > -Original Message- > > From: Bruce Richardson > > Sent: Friday, January 29, 2021 4:01 PM > > To: Juraj Linkeš > > Cc: tho...@monjalon.net; ruifeng.w...@arm.com; jerinjac...@gmail.com; > > hemant.agra...@nxp.com; ferru

Re: [dpdk-dev] [PATCH] mem: fix deadlock on secondary allocation

2021-01-29 Thread Thomas Monjalon
29/01/2021 16:29, Anatoly Burakov: > Previous fix used `rte_malloc_heap_socket_is_external()` to check if the > heap was an external heap. However, that API is thread-safe, and when > we're inside the allocation process, we're already write-locked, so > calling `rte_malloc_heap_socket_is_external()

Re: [dpdk-dev] [PATCH] examples: warn about broken pkg-config

2021-01-29 Thread Thomas Monjalon
19/01/2021 14:03, Bruce Richardson: > Since the examples are designed to be built by end-users using Make, we > can detect and warn about broken pkg-config on the user's system as part > of the build process. > > Signed-off-by: Bruce Richardson > --- > examples/bbdev_app/Makefile

Re: [dpdk-dev] [PATCH] examples: warn about broken pkg-config

2021-01-29 Thread Bruce Richardson
On Fri, Jan 29, 2021 at 04:47:35PM +0100, Thomas Monjalon wrote: > 19/01/2021 14:03, Bruce Richardson: > > Since the examples are designed to be built by end-users using Make, we > > can detect and warn about broken pkg-config on the user's system as part > > of the build process. > > > > Signed-o

Re: [dpdk-dev] [PATCH] examples: warn about broken pkg-config

2021-01-29 Thread Burakov, Anatoly
On 29-Jan-21 3:55 PM, Bruce Richardson wrote: On Fri, Jan 29, 2021 at 04:47:35PM +0100, Thomas Monjalon wrote: 19/01/2021 14:03, Bruce Richardson: Since the examples are designed to be built by end-users using Make, we can detect and warn about broken pkg-config on the user's system as part of

Re: [dpdk-dev] [PATCH] examples: warn about broken pkg-config

2021-01-29 Thread Bruce Richardson
On Fri, Jan 29, 2021 at 04:04:18PM +, Burakov, Anatoly wrote: > On 29-Jan-21 3:55 PM, Bruce Richardson wrote: > > On Fri, Jan 29, 2021 at 04:47:35PM +0100, Thomas Monjalon wrote: > > > 19/01/2021 14:03, Bruce Richardson: > > > > Since the examples are designed to be built by end-users using Mak

Re: [dpdk-dev] [PATCH] mem: fix deadlock on secondary allocation

2021-01-29 Thread Burakov, Anatoly
On 29-Jan-21 3:40 PM, Thomas Monjalon wrote: 29/01/2021 16:29, Anatoly Burakov: Previous fix used `rte_malloc_heap_socket_is_external()` to check if the heap was an external heap. However, that API is thread-safe, and when we're inside the allocation process, we're already write-locked, so calli

Re: [dpdk-dev] [PATCH] examples: warn about broken pkg-config

2021-01-29 Thread Thomas Monjalon
29/01/2021 17:05, Bruce Richardson: > On Fri, Jan 29, 2021 at 04:04:18PM +, Burakov, Anatoly wrote: > > On 29-Jan-21 3:55 PM, Bruce Richardson wrote: > > > On Fri, Jan 29, 2021 at 04:47:35PM +0100, Thomas Monjalon wrote: > > > > 19/01/2021 14:03, Bruce Richardson: > > > > > Since the examples a

[dpdk-dev] [PATCH v7 00/10] add checking of header includes

2021-01-29 Thread Bruce Richardson
As a general principle, each header file should include any other headers it needs to provide data type definitions or macros. For example, any header using the uintX_t types in structures or function prototypes should include "stdint.h" to provide those type definitions. In practice, while many,

[dpdk-dev] [PATCH v7 01/10] eal: add missing include to mcslock

2021-01-29 Thread Bruce Richardson
Include 'rte_branch_prediction.h' to get the likely/unlikely macro definitions. Fixes: 2173fb61 ("mcslock: add MCS queued lock implementation") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson Reviewed-by: Honnappa Nagarahalli --- lib/librte_eal/include/generic/rte_mcslock.h | 1 + 1 fi

[dpdk-dev] [PATCH v7 02/10] eal: fix error attribute use for clang

2021-01-29 Thread Bruce Richardson
Clang does not have an "error" attribute for functions, so for marking internal functions we need to check for the error attribute, and provide a fallback if it is not present. For clang, we can use "diagnose_if" attribute, similarly checking for its presence before use. Fixes: fba5af82adc8 ("eal:

[dpdk-dev] [PATCH v7 03/10] power: fix missing header includes

2021-01-29 Thread Bruce Richardson
The rte_power_guest_channel.h file did not include it's dependent headers, so add them. Fixes: 5f443cc0f905 ("power: create guest channel public header file") Signed-off-by: Bruce Richardson --- This is one of those issues where it's hard to identify exactly where the issue started, so picking

[dpdk-dev] [PATCH v7 04/10] rib: fix missing header include

2021-01-29 Thread Bruce Richardson
The rte_rib6 header was using RTE_MIN macro from rte_common.h but not including the header file. Fixes: f7e861e21c46 ("rib: support IPv6") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson Acked-by: Vladimir Medvedkin --- lib/librte_rib/rte_rib6.h | 1 + 1 file changed, 1 insertion(+) diff

[dpdk-dev] [PATCH v7 05/10] ethdev: make driver-only headers private

2021-01-29 Thread Bruce Richardson
The rte_ethdev_driver.h, rte_ethdev_vdev.h and rte_ethdev_pci.h files are for drivers only and should be a private to DPDK and not installed. Signed-off-by: Bruce Richardson Reviewed-by: Maxime Coquelin Acked-by: Thomas Monjalon Acked-By: Steven Webster --- This patch has some minor conflicts

[dpdk-dev] [PATCH v7 06/10] eventdev: make driver-only headers private

2021-01-29 Thread Bruce Richardson
The rte_eventdev_pmd*.h files are for drivers only and should be private to DPDK, and not installed for app use. Signed-off-by: Bruce Richardson --- doc/guides/rel_notes/release_21_02.rst | 6 ++ drivers/event/dlb/dlb.c | 2 +- drivers

  1   2   >