Re: [dpdk-dev] [PATCH] kni: fix rtnl deadlocks and race conditions

2021-02-21 Thread Elad Nachman
Hi, Regarding the asynchronous call - thought about it, but then the request will always return OK to user-space and I will have no way to return failure error codes back to user-space. If the above explanation is acceptable, per your other comments - I can send a new patch without the parameter

[dpdk-dev] [PATCH v15 4/4] examples/ifpga: add example for ifpga APIs

2021-02-21 Thread Wei Huang
This example application shows how to use ifpga APIs. A set of OPAE APIs are implemented based on these ifpga APIs. You can test each OPAE API by running corresponding command. A guide is also added to show how to run the example. Signed-off-by: Wei Huang Acked-by: Tianfei Zhang Acked-by: Rosen

[dpdk-dev] [PATCH v15 3/4] raw/ifpga: add miscellaneous APIs

2021-02-21 Thread Wei Huang
Below miscellaneous APIs are used to implement OPAE application. 1. rte_pmd_ifpga_get_pci_bus() get PCI bus ifpga driver registered. 2. rte_pmd_ifpga_partial_reconfigure() do partial reconfiguration. 3. rte_pmd_ifpga_cleanup() free software resources allocated by driver. 4. rte_pmd_ifpga_set_rsu_st

[dpdk-dev] [PATCH v15 2/4] raw/ifpga: add APIs to get fpga information

2021-02-21 Thread Wei Huang
There are some information data can be got from FPGA, they are implemented in below APIs: 1. rte_pmd_ifpga_get_property() get properties of FPGA (include BMC). 2. rte_pmd_ifpga_get_phy_info() get information of PHY connect to FPGA. 3. rte_pmd_ifpga_get_rsu_status() get status of rsu process. Signe

[dpdk-dev] [PATCH v15 0/4] raw/ifpga: add extra OPAE APIs

2021-02-21 Thread Wei Huang
Cyborg is part of OpenStack, it needs some OPAE APIs to manage devices with Intel FPGA. The first three patches implement extra APIs to meet Cyborg requirement. The last patch add an example to show how to use these APIs. Main changes from v14: - fix compilation issue of format error Wei Huang (4

[dpdk-dev] [PATCH v15 1/4] raw/ifpga: add fpga rsu APIs

2021-02-21 Thread Wei Huang
RSU (Remote System Update) depends on secure manager which may be different on various implementations, so a new secure manager device is implemented for adapting such difference. There are five APIs added: 1. rte_pmd_ifpga_get_dev_id() get raw device ID of ifpga device from PCI address like 'Domai

Re: [dpdk-dev] [PATCH] maintainers: added liquidio driver maintainer

2021-02-21 Thread Ugendreshwar Kudupudi
++ Ranjan and team Hello Ferruh Yigit Based on my conversations and review with my team, looks like these changes have been already up-streamed. Ranjan (in CC) will give further details and take the conversation forward. Regards Ugen Ugendreshwar Kudupudi | TME Cavium Networks (I) Pvt Ltd | 1

Re: [dpdk-dev] [PATCH 21.05 v3] app/testpmd: display rxq desc used count

2021-02-21 Thread Li, Xiaoyun
> -Original Message- > From: Lance Richardson > Sent: Saturday, February 13, 2021 05:25 > To: Li, Xiaoyun > Cc: dev@dpdk.org; Yigit, Ferruh > Subject: [PATCH 21.05 v3] app/testpmd: display rxq desc used count > > Add support for displaying the count of used (filled by hardware > but not

[dpdk-dev] [PATCH v14 2/4] raw/ifpga: add APIs to get fpga information

2021-02-21 Thread Wei Huang
There are some information data can be got from FPGA, they are implemented in below APIs: 1. rte_pmd_ifpga_get_property() get properties of FPGA (include BMC). 2. rte_pmd_ifpga_get_phy_info() get information of PHY connect to FPGA. 3. rte_pmd_ifpga_get_rsu_status() get status of rsu process. Signe

[dpdk-dev] [PATCH v14 4/4] examples/ifpga: add example for ifpga APIs

2021-02-21 Thread Wei Huang
This example application shows how to use ifpga APIs. A set of OPAE APIs are implemented based on these ifpga APIs. You can test each OPAE API by running corresponding command. A guide is also added to show how to run the example. Signed-off-by: Wei Huang Acked-by: Tianfei Zhang Acked-by: Rosen

[dpdk-dev] [PATCH v14 3/4] raw/ifpga: add miscellaneous APIs

2021-02-21 Thread Wei Huang
Below miscellaneous APIs are used to implement OPAE application. 1. rte_pmd_ifpga_get_pci_bus() get PCI bus ifpga driver registered. 2. rte_pmd_ifpga_partial_reconfigure() do partial reconfiguration. 3. rte_pmd_ifpga_cleanup() free software resources allocated by driver. 4. rte_pmd_ifpga_set_rsu_st

[dpdk-dev] [PATCH v14 0/4] raw/ifpga: add extra OPAE APIs

2021-02-21 Thread Wei Huang
Cyborg is part of OpenStack, it needs some OPAE APIs to manage devices with Intel FPGA. The first three patches implement extra APIs to meet Cyborg requirement. The last patch add an example to show how to use these APIs. Main changes from v13: - fix compilation issue of unused const variable 'kdr

[dpdk-dev] [PATCH v14 1/4] raw/ifpga: add fpga rsu APIs

2021-02-21 Thread Wei Huang
RSU (Remote System Update) depends on secure manager which may be different on various implementations, so a new secure manager device is implemented for adapting such difference. There are five APIs added: 1. rte_pmd_ifpga_get_dev_id() get raw device ID of ifpga device from PCI address like 'Domai

[dpdk-dev] [PATCH 2/2] net/iavf: support GTPU inner IPv6 for FDIR

2021-02-21 Thread Junfeng Guo
Support GTPU_(EH)_IPV6 inner L3 and L4 fields matching for AVF FDIR. Signed-off-by: Junfeng Guo --- drivers/net/iavf/iavf_fdir.c | 24 drivers/net/iavf/iavf_generic_flow.h | 10 ++ 2 files changed, 34 insertions(+) diff --git a/drivers/net/iavf/iavf_fdir

[dpdk-dev] [PATCH 1/2] net/iavf: support GTPU inner IPv4 for FDIR

2021-02-21 Thread Junfeng Guo
Support GTPU_(EH)_IPV4 inner L3 and L4 fields matching for AVF FDIR. Signed-off-by: Junfeng Guo --- drivers/net/iavf/iavf_fdir.c | 37 drivers/net/iavf/iavf_generic_flow.h | 21 2 files changed, 58 insertions(+) diff --git a/drivers/net/iavf

[dpdk-dev] [PATCH 0/2] support GTPU inner IPv4/IPv6 for AVF FDIR

2021-02-21 Thread Junfeng Guo
Support GTPU_(EH)_IPV4/IPV6 inner L3 and L4 fields matching for AVF FDIR. [PATCH 1/2] support GTPU inner IPv4 for FDIR. [PATCH 2/2] support GTPU inner IPv6 for FDIR. Junfeng Guo (2): net/iavf: support GTPU inner IPv4 for FDIR net/iavf: support GTPU inner IPv6 for FDIR drivers/net/iavf/iavf_

Re: [dpdk-dev] [dpdk-stable] [PATCH v13 0/4] raw/ifpga: add extra OPAE APIs

2021-02-21 Thread Huang, Wei
-Original Message- From: Thomas Monjalon Sent: Wednesday, February 10, 2021 17:38 To: Huang, Wei Cc: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z ; sta...@dpdk.org; Zhang, Tianfei ; Yigit, Ferruh Subject: Re: [dpdk-stable] [PATCH v13 0/4] raw/ifpga: add extra OPAE APIs 10/02/2021 02:48,

Re: [dpdk-dev] [PATCH v2 6/7] drivers: remove POSIX dependencies

2021-02-21 Thread Dmitry Kozlyuk
On Sun, 21 Feb 2021 18:54:01 +0300, Andrew Rybchenko wrote: > On 2/21/21 11:59 AM, Tal Shnaiderman wrote: > >> Subject: [dpdk-dev] [PATCH v2 6/7] drivers: remove POSIX dependencies > >> > >> External email: Use caution opening links or attachments > >> > >> > >> Replace POSIX strncasecmp() with EAL

Re: [dpdk-dev] [PATCH v6 1/2] bus/pci: use PCI standard sysfs entry to get PIO address

2021-02-21 Thread 谢华伟(此时此刻)
On 2021/2/18 17:33, David Marchand wrote: On Fri, Jan 29, 2021 at 4:19 AM 谢华伟(此时此刻) wrote: From: "huawei.xhw" Currently virtio PMD asssumes legacy device uses PIO bar. There are three ways to get PIO(PortIO) address for virtio legacy device. under igb_uio, get pio address from uio/uio#

Re: [dpdk-dev] [PATCH v2 6/7] drivers: remove POSIX dependencies

2021-02-21 Thread Andrew Rybchenko
On 2/21/21 11:59 AM, Tal Shnaiderman wrote: Subject: [dpdk-dev] [PATCH v2 6/7] drivers: remove POSIX dependencies External email: Use caution opening links or attachments Replace POSIX strncasecmp() with EAL rte_strncasecmp(). Replace POSIX strtok_r() with EAL rte_strtok(). Replace POSIX strdu

Re: [dpdk-dev] [PATCH v6 2/2] bus/pci: support MMIO in PCI ioport accessors

2021-02-21 Thread 谢华伟(此时此刻)
On 2021/2/19 16:52, Ferruh Yigit wrote: On 2/9/2021 2:51 PM, Ferruh Yigit wrote: On 1/29/2021 3:18 AM, 谢华伟(此时此刻) wrote: From: "huawei.xhw" With IO BAR, we get PIO(programmed IO) address. With MMIO BAR, we get mapped virtual address. We distinguish PIO(Programmed IO) and MMIO(memory mapped I

Re: [dpdk-dev] [PATCH] net/mlx5: fix metadata item validation for ingress flows

2021-02-21 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Wednesday, February 10, 2021 11:31 AM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Matan Azrad > ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix metadata item validation for ingress flows > > In legacy metadata mode the meta

Re: [dpdk-dev] [PATCH v2 7/7] eal/windows: do not expose POSIX symbols

2021-02-21 Thread Dmitry Kozlyuk
On Sun, 21 Feb 2021 11:58:39 +, Tal Shnaiderman wrote: [...] > > Thanks for all your comments, it's weird I didn't hit the failures locally. > > Will fix in v3. > > You might be missing the DevX SDK installation, without it meson will skip > the mlx5 build. > > You can get it either by in

[dpdk-dev] [PATCH v3 7/7] eal/windows: do not expose POSIX symbols

2021-02-21 Thread Dmitry Kozlyuk
Exposing POSIX symbols could break consumer POSIX compatibility code. * Make renaming of close() and unlink() private to EAL. * Remove renaming of strncasecmp(), strtok_r(), and sleep() in favor of using EAL wrappers. Similarly remove PATH_MAX macro. * Replace index(3p), which is not available

[dpdk-dev] [PATCH v3 6/7] drivers: remove POSIX dependencies

2021-02-21 Thread Dmitry Kozlyuk
Replace POSIX strncasecmp() with EAL rte_strncasecmp(). Replace POSIX strtok_r() with EAL rte_strtok(). Replace POSIX strdup() with EAL rte_strdup(). Signed-off-by: Dmitry Kozlyuk --- i40e: checkpatches.sh complains about long lines (it's ~85). I doubt that mechanical fix would keep the cod

[dpdk-dev] [PATCH v3 5/7] lib: remove POSIX dependencies

2021-02-21 Thread Dmitry Kozlyuk
Replace POSIX strtok_r() with EAL rte_strtok(). Replace POSIX strdup() with EAL rte_strdup(). Locally rename Windows _close() to standard close(). Signed-off-by: Dmitry Kozlyuk --- lib/librte_cmdline/cmdline.c | 1 + lib/librte_ethdev/rte_class_eth.c | 2 +- lib/librte_ethdev/rte_ethdev

[dpdk-dev] [PATCH v3 4/7] eal: add asprintf() internal wrapper

2021-02-21 Thread Dmitry Kozlyuk
POSIX asprintf() is unavailable on Windows. Add eal_asprintf() wrapper for EAL internal use. On Windows it's a function, on Unix it's a macro for asprintf(). Signed-off-by: Dmitry Kozlyuk --- lib/librte_eal/common/eal_common_lcore.c | 2 +- lib/librte_eal/common/eal_common_options.c|

[dpdk-dev] [PATCH v3 3/7] eal: add sleep API

2021-02-21 Thread Dmitry Kozlyuk
POSIX sleep(3) is missing from Windows. Add generic rte_thread_sleep() to suspend current OS thread. Signed-off-by: Dmitry Kozlyuk --- lib/librte_eal/common/eal_common_timer.c | 5 +++-- lib/librte_eal/include/rte_thread.h | 11 +++ lib/librte_eal/rte_eal_exports.def | 2 ++

[dpdk-dev] [PATCH v3 2/7] eal: add macro for maximum path length

2021-02-21 Thread Dmitry Kozlyuk
Path length limit is PATH_MAX on Unix and _MAX_PATH on Windows. Add RTE_PATH_MAX macro for use in OS-independent code. Keep PATH_MAX in "common" multiprocess code, because it's really Unix-specific. Signed-off-by: Dmitry Kozlyuk --- lib/librte_eal/common/eal_common_config.c | 2 +- lib/libr

[dpdk-dev] [PATCH v3 1/7] eal: add wrappers for POSIX string functions

2021-02-21 Thread Dmitry Kozlyuk
POSIX strncasecmp(), strdup(), and strtok_r() have different names on Windows, respectively, strnicmp(), _strdup(), and strtok_s(). Add wrappers as inline functions, because they're used from librte_kvargs, and thus cannot be in librte_eal; besides, implementation is trivial. Signed-off-by: Dmitr

[dpdk-dev] [PATCH v3 0/7] eal/windows: do not expose POSIX symbols

2021-02-21 Thread Dmitry Kozlyuk
On Windows, rte_os.h contains a small POSIX compatibility set of functions and macros. Exposing it from EAL can break consumer own POSIX compatibility layer and is against standards in general. First define required wrappers, then fix POSIX dependencies in Windows-enabled libraries and drivers, th

Re: [dpdk-dev] [PATCH v2 7/7] eal/windows: do not expose POSIX symbols

2021-02-21 Thread Tal Shnaiderman
> Subject: Re: [dpdk-dev] [PATCH v2 7/7] eal/windows: do not expose POSIX > symbols > > External email: Use caution opening links or attachments > > > On Sun, 21 Feb 2021 08:59:50 +, Tal Shnaiderman wrote: > [...] > > > -#ifndef close > > > -#define close _close > > > -#endif > > > > mlx5 us

Re: [dpdk-dev] [PATCH] common/mlx5: fix output buffer size calculation

2021-02-21 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Thursday, February 18, 2021 6:18 PM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] common/mlx5: fix output buffer size calculation > > Previous

[dpdk-dev] [PATCH 2/2] qede: make driver accept bigger rss tables

2021-02-21 Thread Igor Russkikh
We found some dpdk applications blindly pass fixed side rss hash tables, and do not check driver/device capabilities. Moreover, many other drivers do not do such a strong check as well. So here we fix it, making qede accept any size rss_key. For larger key tables we just crop it with notice trace

[dpdk-dev] [PATCH 1/2] qede: reduce trace verbosity level

2021-02-21 Thread Igor Russkikh
On some hardware units it was found this trace is flooding the output, making any dpdk interactive usage kind of problematic. It is only informational, without any consequences handling, so reducing it to verbose from explicit notice level. CC: sta...@dpdk.org Signed-off-by: Igor Russkikh --- d

[dpdk-dev] [PATCH 0/2] qede: 2020-02 minor fixes

2021-02-21 Thread Igor Russkikh
Two small fixes after customer feedback. Igor Russkikh (2): qede: reduce trace verbosity level qede: make driver accept bigger rss tables drivers/net/qede/base/ecore_int.c | 2 +- drivers/net/qede/qede_ethdev.c| 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) -- 2.25.1

Re: [dpdk-dev] [PATCH v2 7/7] eal/windows: do not expose POSIX symbols

2021-02-21 Thread Dmitry Kozlyuk
On Sun, 21 Feb 2021 08:59:50 +, Tal Shnaiderman wrote: [...] > > -#ifndef close > > -#define close _close > > -#endif > > mlx5 uses close() in mlx5.c and is broken after this change above, BTW why > not add an rte_close instead of local definition? I'm reluctant to add file manipulation AP

[dpdk-dev] dpdk_21.02--kni interface does not work properly

2021-02-21 Thread mirzaei.reza
Hello, I've recently migrated from dpdk-18.05 to dpdk-21.02. I built "kni" example according to this tutorial [1 [1]], every thing is fine except that it has no output packet (no tx). There is a same problem in dpdk-20.11. Have I ignored something? I would be grateful if anyone could help me. I

Re: [dpdk-dev] [PATCH] net/mlx5: fix TCP flag field modification

2021-02-21 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Friday, February 5, 2021 5:03 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko ; Matan Azrad ; > Ori Kam > Subject: [PATCH] net/mlx5: fix TCP flag field modification > > Wrong modification field

Re: [dpdk-dev] [PATCH v2 7/7] eal/windows: do not expose POSIX symbols

2021-02-21 Thread Tal Shnaiderman
> Subject: [dpdk-dev] [PATCH v2 7/7] eal/windows: do not expose POSIX > symbols > > External email: Use caution opening links or attachments > > > Exposing POSIX symbols could break consumer POSIX compatibility code. > > * Make renaming of close() and unlink() private to EAL. > > * Remove rena

Re: [dpdk-dev] [PATCH v2 6/7] drivers: remove POSIX dependencies

2021-02-21 Thread Tal Shnaiderman
> Subject: [dpdk-dev] [PATCH v2 6/7] drivers: remove POSIX dependencies > > External email: Use caution opening links or attachments > > > Replace POSIX strncasecmp() with EAL rte_strncasecmp(). > Replace POSIX strtok_r() with EAL rte_strtok(). > Replace POSIX strdup() with EAL rte_strdup(). >

Re: [dpdk-dev] [PATCH v2 3/7] eal: add sleep API

2021-02-21 Thread Tal Shnaiderman
> Subject: [dpdk-dev] [PATCH v2 3/7] eal: add sleep API > > External email: Use caution opening links or attachments > > > POSIX sleep(3) is missing from Windows. > Add generic rte_thread_sleep() to suspend current OS thread. > > Signed-off-by: Dmitry Kozlyuk > --- > lib/librte_eal/common/eal

Re: [dpdk-dev] [PATCH] net/mlx5: fix external buffer pool registration for Rx queue

2021-02-21 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Friday, February 12, 2021 1:07 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Matan Azrad > ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix external buffer pool registration for Rx queue > > On Rx queue creation the mlx5 PM