Re: [dpdk-dev] [PATCH] cryptodev: support multiple cipher block sizes

2021-02-25 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Matan Azrad > Sent: Monday, February 8, 2021 7:23 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: akhil.go...@nxp.com; Doherty, Declan ; > Somalapuram Amaranath ; Ruifeng Wang > ; Ajit Khaparde ; > Anoob Joseph ; Zhang, Roy Fan > ; Griffin, John ; De Lara >

Re: [dpdk-dev] [RFC] eventdev: introduce event dispatcher

2021-02-25 Thread Mattias Rönnblom
On 2021-02-22 16:28, Luca Boccassi wrote: > On Thu, 2021-02-18 at 19:30 +0100, Mattias Rönnblom wrote: >> The purpose of the event dispatcher is primarily to decouple different >> parts of an application (e.g., processing pipeline stages), which >> share the same underlying event device. >> >> The

[dpdk-dev] [PATCH v2] net/ice: fix unchecked return value

2021-02-25 Thread Wenjun Wu
Fix unchecked return values reported by coverity. Coverity issue: 349907 Fixes: 03a05924dad0 ("net/ice: support device-specific DDP package loading") Cc: sta...@dpdk.org Signed-off-by: Wenjun Wu --- v2: modify err message; fix the issue related to that reported by coverity --- drivers/net/ice/

[dpdk-dev] [PATCH] vhost: fix potential buffer overflow

2021-02-25 Thread Marvin Liu
In vhost datapath, descriptor's length are mostly used in two coherent operations. First step is used for address translation, second step is used for memory transaction from guest to host. But the iterval between two steps will give a window for malicious guest, in which can change descriptor leng

Re: [dpdk-dev] [PATCH] app/testpmd: add support for forced ethernet speed

2021-02-25 Thread Andrew Rybchenko
On 2/25/21 9:25 PM, Ferruh Yigit wrote: > On 2/22/2021 7:18 PM, Ajit Khaparde wrote: >> Add support for forced ethernet speed setting. >> Currently testpmd tries to configure the Ethernet port in autoneg mode. >> It is not possible to set the Ethernet port to a specific speed while >> starting test

[dpdk-dev] [Bug 643] af_xdp驱动造成rte_rx_queue_setup的coredump问题

2021-02-25 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=643 Bug ID: 643 Summary: af_xdp驱动造成rte_rx_queue_setup的coredump问题 Product: DPDK Version: 20.05 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Pr

Re: [dpdk-dev] [PATCH 7/7] compress/octeontx: enable build only for 64bit Linux

2021-02-25 Thread Ashish Gupta
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Thursday, February 25, 2021 10:33 PM > To: Jerin Jacob Kollanukkaran ; Ashish Gupta > ; Fiona Trahe > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > > Subject: [dpdk-dev] [PATCH 7/7] compress/octeontx: enable build only for

Re: [dpdk-dev] [EXT] [PATCH] cryptodev: support multiple cipher block sizes

2021-02-25 Thread Anoob Joseph
Hi Matan, With the current spec, AES-XTS operation offloading would mean application is expected to track data blocks and the corresponding tweak & cipher stealing, while the final crypto operation gets offloaded to PMD. This proposal aims at moving the entire AES-XTS operation (including tweak

[dpdk-dev] [PATCH v1] net/ice: fix unchecked return value

2021-02-25 Thread Wenjun Wu
Fix unchecked return values reported by coverity. Coverity issue: 349907 Fixes: 03a05924dad0 ("net/ice: support device-specific DDP package loading") Cc: sta...@dpdk.org Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_ethdev.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) d

Re: [dpdk-dev] [PATCH v5 14/17] net/igc: remove use of uint type

2021-02-25 Thread Wang, Haiyue
> -Original Message- > From: Thomas Monjalon > Sent: Friday, February 26, 2021 02:23 > To: dev@dpdk.org > Cc: nc...@alpinelinux.org; sta...@dpdk.org; David Marchand > ; Guo, Jia > ; Wang, Haiyue ; Yigit, Ferruh > ; > Zhang, AlvinX > Subject: [PATCH v5 14/17] net/igc: remove use of uint

Re: [dpdk-dev] [RFC 3/5] eal: lcore state FINISHED is not required

2021-02-25 Thread Honnappa Nagarahalli
+Thomas, David, Konstantin for input > > Subject: [RFC 3/5] eal: lcore state FINISHED is not required > > > > FINISHED state seems to be used to indicate that the worker's update > > of the 'state' is not visible to other threads. There seems to be no > > requirement to have such a state. > > I

Re: [dpdk-dev] [PATCH v2 4/6] net/pcap: add libpcap wrappers

2021-02-25 Thread Dmitry Kozlyuk
2021-02-25 20:31, Nick Connolly: > > Your comment made me revise Windows EAL networking shims. Surprisingly, if > > changed to expose Windows networking headers (specifically, ) > > with > > some additions (but no hacks), they create no issues to any existing code. > > > > The only workaround rema

[dpdk-dev] [Bug 642] bnxt: jumbo packets fail with MBUF_FAST_FREE

2021-02-25 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=642 Bug ID: 642 Summary: bnxt: jumbo packets fail with MBUF_FAST_FREE Product: DPDK Version: 20.11 Hardware: x86 OS: All Status: UNCONFIRMED Severity: normal

[dpdk-dev] [Bug 641] bnxt: rte_eth_stats_get() returning zeros between valid counts

2021-02-25 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=641 Bug ID: 641 Summary: bnxt: rte_eth_stats_get() returning zeros between valid counts Product: DPDK Version: 20.11 Hardware: x86 OS: All Status: UNCONFIRME

Re: [dpdk-dev] [PATCH 2/2] kni: fix rtnl deadlocks and race conditions v4

2021-02-25 Thread Igor Ryzhov
Hi Elad, Thanks for the patch, but this is still NACK from me. The only real advantage of KNI over other exceptional-path techniques like virtio-user is the ability to configure DPDK-managed interfaces directly from the kernel using well-known utils like iproute2. A very important part of this is

Re: [dpdk-dev] [PATCH v2 4/6] net/pcap: add libpcap wrappers

2021-02-25 Thread Nick Connolly
Your comment made me revise Windows EAL networking shims. Surprisingly, if changed to expose Windows networking headers (specifically, ) with some additions (but no hacks), they create no issues to any existing code. The only workaround remaining is `#undef s_addr` in . So maybe this commit c

Re: [dpdk-dev] [PATCH 0/3] Add developer mode to DPDK build

2021-02-25 Thread Thomas Monjalon
25/02/2021 16:29, Bruce Richardson: > To allow more flexibility in enabling additional build checks to DPDK build > process, we can add a developer mode option to the build. With this option > enabled, extra checks of interest to DPDK developers rather than users can be > done on the code, without

[dpdk-dev] [PATCH] test: move debug_autotest out of fast suite

2021-02-25 Thread luca . boccassi
From: Luca Boccassi It consistently fails when ran on a build machine within the reproducible build environment, so move it out of there, so that we can run the fast suite at build time when packaging. Repro test environment: https://salsa.debian.org/salsa-ci-team/pipeline/raw/master/salsa-ci.y

Re: [dpdk-dev] [PATCH v2 4/6] net/pcap: add libpcap wrappers

2021-02-25 Thread Dmitry Kozlyuk
2021-02-25 14:59, Ferruh Yigit: > On 2/14/2021 2:16 AM, Dmitry Kozlyuk wrote: > > libpcap headers can expose OS headers. On Windows, system networking > > headers are incompatible with DPDK ones, causing multiple name clashes. > > API of libpcap itself involves a non-standard u_char type. > > > >

[dpdk-dev] [PATCH 2/2] config: increase interrupt vectors for octeontx2

2021-02-25 Thread pbhagavatula
From: Pavan Nikhilesh Increase maximum interrupt vectors to 1024 for octeontx2. Signed-off-by: Pavan Nikhilesh --- config/arm/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/config/arm/meson.build b/config/arm/meson.build index 00bc4610a..4e728380f 100644 --- a/config/arm/meson

[dpdk-dev] [PATCH 1/2] eal: make max interrupt vector id configurable

2021-02-25 Thread pbhagavatula
From: Pavan Nikhilesh Make RTE_MAX_RXTX_INTR_VEC_ID configurable as MSI-X support a maximum of 2048 vectors. The default value is unchanged and set to 512. Signed-off-by: Pavan Nikhilesh --- config/meson.build | 1 + lib/librte_eal/include/rte_eal_interrupts.h | 1 - 2

Re: [dpdk-dev] [PATCH] app/testpmd: add support for forced ethernet speed

2021-02-25 Thread Andrew Boyer
> On Feb 22, 2021, at 2:18 PM, Ajit Khaparde wrote: > > Add support for forced ethernet speed setting. > Currently testpmd tries to configure the Ethernet port in autoneg mode. > It is not possible to set the Ethernet port to a specific speed while > starting testpmd. In some cases capability

[dpdk-dev] [PATCH v2] mbuf: rename outer ip checksum macro

2021-02-25 Thread Lance Richardson
Rename PKT_RX_EIP_CKSUM_BAD to PKT_RX_OUTER_IP_CKSUM_BAD and deprecate the original name. The new name is better aligned with existing PKT_RX_OUTER_* flags, which should help reduce confusion about its use. Suggested-by: Ferruh Yigit Signed-off-by: Lance Richardson --- v2: - Added deprecation n

[dpdk-dev] [PATCH v5 13/17] net/cxgbe: remove use of uint type

2021-02-25 Thread Thomas Monjalon
From: Natanael Copa Improve portability by replacing non-standard 'uint' with 'unsigned int'. This solves the build error with musl libc: In file included from ../drivers/net/cxgbe/cxgbe.h:9, from ../drivers/net/cxgbe/cxgbe_ethdev.c:37: ../drivers/net/cxgbe/base/common.h:201:4:

Re: [dpdk-dev] [PATCH] app/testpmd: add support for forced ethernet speed

2021-02-25 Thread Ferruh Yigit
On 2/22/2021 7:18 PM, Ajit Khaparde wrote: Add support for forced ethernet speed setting. Currently testpmd tries to configure the Ethernet port in autoneg mode. It is not possible to set the Ethernet port to a specific speed while starting testpmd. In some cases capability to configure a forced

[dpdk-dev] [PATCH v5 17/17] examples/bbdev: fix header include for musl

2021-02-25 Thread Thomas Monjalon
The header file unistd.h should not be included from sys/ directory, it is an error with musl libc. Fixes: 1ffee690eaa1 ("examples/bbdev: add sample app") Cc: sta...@dpdk.org Signed-off-by: Thomas Monjalon --- examples/bbdev_app/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[dpdk-dev] [PATCH v5 14/17] net/igc: remove use of uint type

2021-02-25 Thread Thomas Monjalon
Improve portability (especially with musl libc) by replacing the non-standard type 'uint' with 'size_t'. Fixes: 746664d546fb ("net/igc: support flow API") Cc: sta...@dpdk.org Suggested-by: David Marchand Signed-off-by: Thomas Monjalon --- drivers/net/igc/igc_flow.c | 2 +- 1 file changed, 1 in

[dpdk-dev] [PATCH v5 16/17] app/testpmd: fix build with musl

2021-02-25 Thread Thomas Monjalon
From: Natanael Copa 1/ Improve portability by avoiding use of non-standard 'uint'. Use uint8_t for hash_key_len as rss_key_len is a uint8_t type. This solves following build error when building with musl libc: app/test-pmd/testpmd.h:813:29: error: unknown type name 'uint' 2/ In musl libc, st

[dpdk-dev] [PATCH v5 12/17] common/dpaax/caamflib: simplify log macros

2021-02-25 Thread Thomas Monjalon
From: Natanael Copa Simplify pr_debug, pr_err and pr_warn macros by adding an intermediate pr_msg macro. This way we only need to test for SUPPRESS_PRINTS once. Signed-off-by: Natanael Copa Acked-by: Hemant Agrawal --- drivers/common/dpaax/caamflib/compat.h | 28 +++--- 1

[dpdk-dev] [PATCH v5 15/17] vdpa/mlx5: replace pthread functions unavailable in musl

2021-02-25 Thread Thomas Monjalon
1/ The function pthread_yield() does not exist in musl libc, and can be replaced with sched_yield() after including sched.h. 2/ The function pthread_attr_setaffinity_np() does not exist in musl libc, and can be replaced with pthread_setaffinity_np() after pthread_create(). Fixes: b7fa0bf4d5c6 ("v

[dpdk-dev] [PATCH v5 11/17] common/dpaax/caamflib: fix build with musl

2021-02-25 Thread Thomas Monjalon
From: Natanael Copa The swab16/swab32/swab64 are Linux specific and not GNU libc specific. Keep the check for __GLIBC__ just in case other GNU systems depends on this (Hurd or GNU/kFreeBSD). This fixes a build error with musl libc. Fixes: 04711d41a872 ("crypto/dpaa2_sec: add run-time assembler

[dpdk-dev] [PATCH v5 10/17] bus/dpaa: fix build with musl

2021-02-25 Thread Thomas Monjalon
From: Natanael Copa Fix build with musl libc by using warn(3) instead of using the GNU specific error(3). `error(0, errno, ...)` is identical to `warn(...)` so replace: error(0, ret, ...); with the identical: errno = ret; warn(...); We could have used the identical `warnx("...: %s", st

[dpdk-dev] [PATCH v5 09/17] bus/dpaa: fix 64-bit arch detection

2021-02-25 Thread Thomas Monjalon
From: Natanael Copa There is no standard saying that __WORDSIZE should be be defined or in what include it should be defined. Use RTE_ARCH_64 instead. This solves a warning when building with musl libc: warning: "__WORDSIZE" is not defined, evaluates to 0 [-Wundef] Fixes: 847ee3bd0d1f ("bus/d

[dpdk-dev] [PATCH v5 08/17] bus/pci: support I/O port operations with musl

2021-02-25 Thread Thomas Monjalon
From: Natanael Copa Add a fallback for non-GNU libc systems like musl libc for the non-standard functions outl_p, outw_p and outb_p. This solves the following buildtime errors when building with musl libc: pci_uio.c:(.text+0xaa1): undefined reference to `outw_p' pci_uio.c:(.text+0xac5): undefine

[dpdk-dev] [PATCH v5 07/17] drivers: replace page size definitions with function

2021-02-25 Thread Thomas Monjalon
The page size is often retrieved from the macro PAGE_SIZE. If PAGE_SIZE is not defined, it is either using hard coded default, or getting the system value from the UNIX-only function sysconf(). Such definitions are replaced with the generic function rte_mem_page_size() defined for each supported O

[dpdk-dev] [PATCH v5 06/17] drivers: fix header includes for musl

2021-02-25 Thread Thomas Monjalon
The header files argp.h and error.h do not exist in musl libc and are not needed in dpaa code. The header file fcntl.h should not be included from sys/ directory as done in dlb drivers, it is an error with musl libc. Fixes: 5b22cf744689 ("bus/dpaa: introducing FMan configurations") Fixes: 39f373c

[dpdk-dev] [PATCH v5 05/17] eal/linux: fix build with musl

2021-02-25 Thread Thomas Monjalon
In musl libc, cpu_set_t is defined only if _GNU_SOURCE is defined. In case _GNU_SOURCE is undefined, as in eal_common_errno.c, it was not possible to include rte_os.h which uses cpu_set_t. This limitation is removed: if _GNU_SOURCE is not defined, cpu_set_t related definitions are skipped. Note: s

[dpdk-dev] [PATCH v5 04/17] build: define _GNU_SOURCE globally

2021-02-25 Thread Thomas Monjalon
There was an intent to define _GNU_SOURCE globally, but it was not set in pkg-config for external applications. The internal definition in config/meson.build is kept, and one is added in buildtools/pkg-config/meson.build for external apps. All other specific definitions of _GNU_SOURCE are removed.

[dpdk-dev] [PATCH v5 03/17] build: detect execinfo library on Linux

2021-02-25 Thread Thomas Monjalon
The library execinfo and its header file can be installed on Alpine Linux where the backtrace feature is not part of musl libc: apk add libexecinfo-dev As a consequence, this library should not be restricted to BSD only. At the same time, the library and header are detected once and added

[dpdk-dev] [PATCH v5 02/17] buildtools: fix build with busybox

2021-02-25 Thread Thomas Monjalon
If using busybox for mktemp and awk (as in Alpine), some bugs prevent the script from running: 1/ It seems busybox mktemp requires the pattern to have at least 6 X and no other suffix. The same has been fixed for other scripts in the past: commit 3771edc35438 ("buildtools: fix build for some mktem

[dpdk-dev] [PATCH v5 01/17] eal: fix comment of OS-specific header files

2021-02-25 Thread Thomas Monjalon
The same comment is on top of each rte_os.h file. It is reworded to remove the mention of "future releases". Fixes: 428eb983f5f7 ("eal: add OS specific header file") Cc: sta...@dpdk.org Signed-off-by: Thomas Monjalon --- lib/librte_eal/freebsd/include/rte_os.h | 5 ++--- lib/librte_eal/linux/in

[dpdk-dev] [PATCH v5 00/17] Alpine/musl build support

2021-02-25 Thread Thomas Monjalon
These patches fix some build errors/warning for Alpine Linux, using musl and busybox. Few improvements are added on the way. The goal is to run a container with the following Dockerfile: 8< FROM alpine # DPDK prerequisites RUN apk --no-cache add \ gcc libc-dev bsd-compat-headers

Re: [dpdk-dev] [PATCH v2 5/6] config: discover libpcap on Windows

2021-02-25 Thread Dmitry Kozlyuk
2021-02-25 16:33, Bruce Richardson: > On Thu, Feb 25, 2021 at 07:04:38PM +0300, Dmitry Kozlyuk wrote: > > 2021-02-25 15:02, Ferruh Yigit: > > > On 2/14/2021 2:16 AM, Dmitry Kozlyuk wrote: > > > > WinPcap or Npcap, can be installed anywhere. > > > > Add a Meson option to specify SDK path. > > >

[dpdk-dev] [PATCH 5/7] event/octeontx: enable build only on 64bit Linux

2021-02-25 Thread pbhagavatula
From: Pavan Nikhilesh Due to Linux kernel dependency, only enable build for 64bit Linux. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/meson.build | 6 ++ drivers/event/octeontx2/meson.build | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/event

[dpdk-dev] [PATCH 7/7] compress/octeontx: enable build only for 64bit Linux

2021-02-25 Thread pbhagavatula
From: Pavan Nikhilesh Due to Linux kernel dependency, only enable build for 64bit Linux. Signed-off-by: Pavan Nikhilesh --- drivers/compress/octeontx/meson.build | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/compress/octeontx/meson.build b/drivers/compress/octeontx/meson.b

[dpdk-dev] [PATCH 1/7] common/octeontx: enable build only on 64bit Linux

2021-02-25 Thread pbhagavatula
From: Pavan Nikhilesh Due to Linux kernel dependency, only enable build for 64bit Linux. Signed-off-by: Pavan Nikhilesh --- drivers/common/octeontx/meson.build | 6 ++ drivers/common/octeontx2/meson.build | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/com

[dpdk-dev] [PATCH 6/7] raw/octeontx2: enable build only for 64bit Linux

2021-02-25 Thread pbhagavatula
From: Pavan Nikhilesh Due to Linux kernel dependency, only enable build for 64bit Linux. Signed-off-by: Pavan Nikhilesh --- drivers/raw/octeontx2_dma/meson.build | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/raw/octeontx2_dma/meson.build b/drivers/raw/

[dpdk-dev] [PATCH 4/7] crypto/octeontx: enable build only on 64bit Linux

2021-02-25 Thread pbhagavatula
From: Pavan Nikhilesh Due to Linux kernel dependency, only enable build for 64bit Linux. Signed-off-by: Pavan Nikhilesh --- drivers/crypto/octeontx/meson.build | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/octeontx/meson.build b/drivers/crypto/octeo

[dpdk-dev] [PATCH 3/7] net/octeontx: enable build only on 64bit Linux

2021-02-25 Thread pbhagavatula
From: Pavan Nikhilesh Due to Linux kernel dependency, only enable build for 64bit Linux. Signed-off-by: Pavan Nikhilesh --- drivers/net/octeontx/meson.build | 4 ++-- drivers/net/octeontx2/meson.build | 10 ++ drivers/net/thunderx/meson.build | 4 ++-- 3 files changed, 6 insertions

[dpdk-dev] [PATCH 2/7] mempool/octeontx: enable build only on 64bit Linux

2021-02-25 Thread pbhagavatula
From: Pavan Nikhilesh Due to Linux kernel dependency, only enable build for 64bit Linux. Signed-off-by: Pavan Nikhilesh --- drivers/mempool/octeontx/meson.build | 5 +++-- drivers/mempool/octeontx2/meson.build | 9 ++--- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/drive

Re: [dpdk-dev] [PATCH] app/testpmd: remove unnecessary tunnel UDP cmd check

2021-02-25 Thread Ferruh Yigit
On 2/22/2021 10:44 AM, Ferruh Yigit wrote: On 2/18/2021 3:06 AM, Xiaoyun Li wrote: cmd_tunnel_udp_config checked 'cmd' to set prot_type but this cmd is only for rx_vxlan_port. The unnecessary cmd check will cause uninit coverity issue. So remove it and rename 'cmd' to 'rx_vxlan_port'. Coverity

Re: [dpdk-dev] [PATCH v2 5/6] config: discover libpcap on Windows

2021-02-25 Thread Bruce Richardson
On Thu, Feb 25, 2021 at 07:04:38PM +0300, Dmitry Kozlyuk wrote: > 2021-02-25 15:02, Ferruh Yigit: > > On 2/14/2021 2:16 AM, Dmitry Kozlyuk wrote: > > > WinPcap or Npcap, can be installed anywhere. > > > Add a Meson option to specify SDK path. > > > > > > > I am not sure if it is OK to add a mes

Re: [dpdk-dev] [PATCH v2 00/15] net/ionic: struct optimizations, fixes

2021-02-25 Thread Ferruh Yigit
On 2/16/2021 8:35 PM, Andrew Boyer wrote: This patch series reorganizes the main datastructure for each queue, struct ionic_qcq. Its constituent struct ionic_queue and struct ionic_cq are stripped down first. Then the generic struct ionic_qcq is stripped down, and a unique struct is created for e

Re: [dpdk-dev] [PATCH v2 3/6] net/pcap: move OS-dependent code to separate files

2021-02-25 Thread Dmitry Kozlyuk
2021-02-25 14:51, Ferruh Yigit: > On 2/14/2021 2:16 AM, Dmitry Kozlyuk wrote: > > PCAP PMD queries interface information differently for Linux and > > FreeBSD, OS-specific code is guarded by #ifdef. In preparation to add > > Windows-specific part and libpcap wrapper, extract OS-independent > > inte

Re: [dpdk-dev] [PATCH v2 5/6] config: discover libpcap on Windows

2021-02-25 Thread Dmitry Kozlyuk
2021-02-25 15:02, Ferruh Yigit: > On 2/14/2021 2:16 AM, Dmitry Kozlyuk wrote: > > WinPcap or Npcap, can be installed anywhere. > > Add a Meson option to specify SDK path. > > > > I am not sure if it is OK to add a meson option for this, can't we use the > default path? > > And does this mean

[dpdk-dev] [PATCH 3/3] build: limit symbol checks to developer mode

2021-02-25 Thread Bruce Richardson
The checking of symbols within each library and driver is only of interest to developers, so limit to developer mode only. Signed-off-by: Bruce Richardson --- drivers/meson.build | 20 +++- lib/meson.build | 2 +- 2 files changed, 12 insertions(+), 10 deletions(-) diff --gi

[dpdk-dev] [PATCH 2/3] build: hide debug messages in non-developer mode

2021-02-25 Thread Bruce Richardson
The messages about what components have what dependency names, and information about function versioning not being supported on windows are only of interest to developers, so hide them when building in non-developer mode. Signed-off-by: Bruce Richardson --- drivers/meson.build | 6 -- lib/m

[dpdk-dev] [PATCH 1/3] build: enable a developer mode setting

2021-02-25 Thread Bruce Richardson
To allow support for additional build checks and tests only really relevant for developers, we add support for a developer mode option to DPDK. The default, "auto", value for this enables developer mode if a ".git" folder is found at the root of the source tree - as was the case with the previous "

[dpdk-dev] [PATCH 0/3] Add developer mode to DPDK build

2021-02-25 Thread Bruce Richardson
To allow more flexibility in enabling additional build checks to DPDK build process, we can add a developer mode option to the build. With this option enabled, extra checks of interest to DPDK developers rather than users can be done on the code, without having to worry about possible user impacts.

[dpdk-dev] [PATCH v2] driver/net/pcap: fix fd leak

2021-02-25 Thread ZhangTengfei
pcap file was opened when pcap vdev probed, but was not closed where vdev removed. This bug appears in dpdk-pdump Signed-off-by: ZhangTengfei --- drivers/net/pcap/rte_eth_pcap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c

Re: [dpdk-dev] [PATCH v2 5/6] config: discover libpcap on Windows

2021-02-25 Thread Ferruh Yigit
On 2/14/2021 2:16 AM, Dmitry Kozlyuk wrote: WinPcap or Npcap, can be installed anywhere. Add a Meson option to specify SDK path. I am not sure if it is OK to add a meson option for this, can't we use the default path? And does this mean we will need to add an option for each dependent libra

Re: [dpdk-dev] [PATCH v2 4/6] net/pcap: add libpcap wrappers

2021-02-25 Thread Ferruh Yigit
On 2/14/2021 2:16 AM, Dmitry Kozlyuk wrote: libpcap headers can expose OS headers. On Windows, system networking headers are incompatible with DPDK ones, causing multiple name clashes. API of libpcap itself involves a non-standard u_char type. Add a limited set of trivial libpcap wrappers, so th

Re: [dpdk-dev] [PATCH v2 3/6] net/pcap: move OS-dependent code to separate files

2021-02-25 Thread Ferruh Yigit
On 2/14/2021 2:16 AM, Dmitry Kozlyuk wrote: PCAP PMD queries interface information differently for Linux and FreeBSD, OS-specific code is guarded by #ifdef. In preparation to add Windows-specific part and libpcap wrapper, extract OS-independent interface and move implementations to separate files

Re: [dpdk-dev] [PATCH v2 2/6] net/pcap: fix format string

2021-02-25 Thread Ferruh Yigit
On 2/14/2021 2:16 AM, Dmitry Kozlyuk wrote: Use PRIu32 for uint32_t (found by -Wformat with Clang on Windows). Fixes: a3f5252e5cbd ("net/pcap: enable infinitely Rx a pcap file") Cc: sta...@dpdk.org Signed-off-by: Dmitry Kozlyuk Acked-by: Ferruh Yigit

Re: [dpdk-dev] 20.11.1 patches review and test

2021-02-25 Thread Luca Boccassi
On Thu, 2021-02-25 at 08:00 -0500, Pei Zhang wrote: > Hello Luca, > > The testing with dpdk 20.11.1-rc1 from Red Hat looks good. We tested below 17 > scenarios and and all got PASS on RHEL8: > > (1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS > (2)Guest with device

Re: [dpdk-dev] [PATCH v2] power: remove duplicated symbols from map file

2021-02-25 Thread David Marchand
On Thu, Feb 25, 2021 at 11:55 AM Ferruh Yigit wrote: > > This is causing build error, like: > https://travis-ci.com/github/ovsrobot/dpdk/jobs/482121104 > > Also '@internal' marker removed from doxygen comment, since public API > should not be internal. > Experimental tag removed from 'rte_power_gu

[dpdk-dev] [PATCH 2/2] kni: fix rtnl deadlocks and race conditions v4

2021-02-25 Thread Elad Nachman
This part of the series includes my fixes for the issues reported by Ferruh and Igor (and Igor comments for v3 of the patch) on top of part 1 of the patch series: A. KNI sync lock is being locked while rtnl is held. If two threads are calling kni_net_process_request() , then the first one will tak

[dpdk-dev] [PATCH 1/2] kni: fix kernel deadlock when using mlx devices

2021-02-25 Thread Elad Nachman
This first part of v4 of the patch re-introduces Stephen Hemminger's patch 64106 . This part changes the parameter kni_net_process_request() gets and introduces the initial rtnl unlocking mechanism. Signed-off-by: Elad Nachman --- v4: * for if down case, send asynchronously with rtnl locked and w

Re: [dpdk-dev] [PATCH] doc: clarify disclosure time slot when no response

2021-02-25 Thread Ferruh Yigit
On 2/2/2021 11:28 AM, Ferruh Yigit wrote: On 1/25/2021 1:57 AM, Marvin Liu wrote: Sometimes security team won't send confirmation mail back to reporter in three business days. This mean reported vulnerability is either low severity or not a real vulnerability. Reporter should assume that the iss

[dpdk-dev] [PATCH] driver/net/pcap: fix fd leak

2021-02-25 Thread ZhangTengfei
pcap file was opened when pcap vdev probed, but was not closed where vdev removed. This bug appears in dpdk-pdump Signed-off-by: ZhangTengfei --- drivers/net/pcap/rte_eth_pcap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c

Re: [dpdk-dev] [PATCH] devtools: catch symbol duplicates in version map

2021-02-25 Thread Thomas Monjalon
25/02/2021 13:05, Bruce Richardson: > On Thu, Feb 25, 2021 at 01:01:10PM +0100, Thomas Monjalon wrote: > > 25/02/2021 12:57, Bruce Richardson: > > > On Thu, Feb 25, 2021 at 12:41:16PM +0100, Thomas Monjalon wrote: > > > > 25/02/2021 12:14, David Marchand: > > > > > Add a check on versioned symbol d

Re: [dpdk-dev] 20.11.1 patches review and test

2021-02-25 Thread Pei Zhang
Hello Luca, The testing with dpdk 20.11.1-rc1 from Red Hat looks good. We tested below 17 scenarios and and all got PASS on RHEL8: (1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS (2)Guest with device assignment(PF) throughput testing(2M hugepage size) : PASS (3)Gue

[dpdk-dev] [PATCH] driver/net/pcap: fix fd leak

2021-02-25 Thread ZhangTengfei
pcap file was opened when pcap vdev probed; but was not closed where vdev removed. This bug appears in dpdk-pdump Signed-off-by: ZhangTengfei --- drivers/net/pcap/rte_eth_pcap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c

Re: [dpdk-dev] [RFC PATCH v2] build: add platform meson option

2021-02-25 Thread Juraj Linkeš
> -Original Message- > From: Bruce Richardson > Sent: Thursday, February 25, 2021 1:54 PM > To: Juraj Linkeš > Cc: David Christensen ; tho...@monjalon.net; > honnappa.nagaraha...@arm.com; dev@dpdk.org > Subject: Re: [RFC PATCH v2] build: add platform meson option > > On Thu, Feb 25, 20

Re: [dpdk-dev] [RFC PATCH v2] build: add platform meson option

2021-02-25 Thread Bruce Richardson
On Thu, Feb 25, 2021 at 12:51:57PM +, Juraj Linkeš wrote: > > > > -Original Message- > > From: Bruce Richardson > > Sent: Tuesday, February 23, 2021 10:43 AM > > To: Juraj Linkeš > > Cc: David Christensen ; tho...@monjalon.net; > > honnappa.nagaraha...@arm.com; dev@dpdk.org > > Subj

Re: [dpdk-dev] [RFC PATCH v2] build: add platform meson option

2021-02-25 Thread Juraj Linkeš
> -Original Message- > From: Bruce Richardson > Sent: Tuesday, February 23, 2021 10:43 AM > To: Juraj Linkeš > Cc: David Christensen ; tho...@monjalon.net; > honnappa.nagaraha...@arm.com; dev@dpdk.org > Subject: Re: [RFC PATCH v2] build: add platform meson option > > On Tue, Feb 23, 20

Re: [dpdk-dev] [PATCH] crypto/octeontx2: enable driver compilation on freebsd

2021-02-25 Thread Jerin Jacob
On Thu, Feb 25, 2021 at 5:58 PM wrote: > > From: Pavan Nikhilesh > > Enable compilation on freebsd. Since DPDK octeontx2 drivers have a dependency on Linux kernel driver, I think, in order to simply this stuff, we can completely remove the FreeBSD support in octeontx and octeontx2 drivers. Sinc

Re: [dpdk-dev] [RFC] eventdev: introduce event dispatcher

2021-02-25 Thread Jerin Jacob
On Fri, Feb 19, 2021 at 12:00 AM Mattias Rönnblom wrote: > > The purpose of the event dispatcher is primarily to decouple different > parts of an application (e.g., processing pipeline stages), which > share the same underlying event device. > > The event dispatcher replaces the conditional logic

[dpdk-dev] [PATCH] crypto/octeontx2: enable driver compilation on freebsd

2021-02-25 Thread pbhagavatula
From: Pavan Nikhilesh Enable compilation on freebsd. Signed-off-by: Pavan Nikhilesh --- drivers/crypto/octeontx2/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/octeontx2/meson.build b/drivers/crypto/octeontx2/meson.build index 283818e5d..063

[dpdk-dev] [PATCH 4/4] event/octeontx2: timer always use virtual counter

2021-02-25 Thread pbhagavatula
From: Pavan Nikhilesh Use virtual counter for estimating current bucket as PMU cannot be reliably used to estimate time. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_tim_evdev.c | 19 +++--- drivers/event/octeontx2/otx2_tim_evdev.h | 32 +++ dri

[dpdk-dev] [PATCH 3/4] event/octeontx2: reduce chunk pool memory usage

2021-02-25 Thread pbhagavatula
From: Pavan Nikhilesh Reduce amount of memory used by chunk pool when the mempool used is OCTEONTX2 NPA. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_tim_evdev.c | 19 ++- drivers/event/octeontx2/otx2_tim_evdev.h | 4 ++-- 2 files changed, 12 insertions(+),

[dpdk-dev] [PATCH 2/4] event/octeontx2: optimize timer arm routine

2021-02-25 Thread pbhagavatula
From: Pavan Nikhilesh Use relaxed load exclusive when polling for other threads or hardware to complete. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_tim_worker.c | 1 + drivers/event/octeontx2/otx2_tim_worker.h | 160 -- 2 files changed, 89 insertions(

[dpdk-dev] [PATCH 1/4] event/octeontx2: simplify timer bucket estimation

2021-02-25 Thread pbhagavatula
From: Pavan Nikhilesh Simplify timer bucket estimation we need not align buckets to power of 2 instead use reciprocal division to compute mod. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_tim_evdev.c | 78 - drivers/event/octeontx2/otx2_tim_evdev.h | 84

Re: [dpdk-dev] [PATCH] devtools: catch symbol duplicates in version map

2021-02-25 Thread Bruce Richardson
On Thu, Feb 25, 2021 at 01:01:10PM +0100, Thomas Monjalon wrote: > 25/02/2021 12:57, Bruce Richardson: > > On Thu, Feb 25, 2021 at 12:41:16PM +0100, Thomas Monjalon wrote: > > > 25/02/2021 12:14, David Marchand: > > > > Add a check on versioned symbol duplicates in map files. > > > > > > > > Signe

[dpdk-dev] [PATCH] app/eventdev: fix timeout accuracy

2021-02-25 Thread pbhagavatula
From: Pavan Nikhilesh Round timeout ticks when converting from nanoseconds, this prevents loss of accuracy and deviation from requested timeout value. Fixes: d008f20bce23 ("app/eventdev: add event timer adapter as a producer") Cc: sta...@dpdk.org Signed-off-by: Pavan Nikhilesh --- app/test-ev

Re: [dpdk-dev] [PATCH] devtools: catch symbol duplicates in version map

2021-02-25 Thread Thomas Monjalon
25/02/2021 12:57, Bruce Richardson: > On Thu, Feb 25, 2021 at 12:41:16PM +0100, Thomas Monjalon wrote: > > 25/02/2021 12:14, David Marchand: > > > Add a check on versioned symbol duplicates in map files. > > > > > > Signed-off-by: David Marchand > > > --- > > > This check could be added to buildt

Re: [dpdk-dev] [PATCH] devtools: catch symbol duplicates in version map

2021-02-25 Thread Bruce Richardson
On Thu, Feb 25, 2021 at 12:41:16PM +0100, Thomas Monjalon wrote: > 25/02/2021 12:14, David Marchand: > > Add a check on versioned symbol duplicates in map files. > > > > Signed-off-by: David Marchand > > --- > > This check could be added to buildtools/check-symbols.sh so that > > regular develope

[dpdk-dev] [PATCH] doc: fix nfp multiport syntax

2021-02-25 Thread Heinrich Kuhn
From: "Chaoyong.He" 1. Fixup the suffix of the PCI ID to be consistent with the code. 2. Add specification of using MAC address to identify port. Fixes: 979f2bae0 ("doc: improve multiport PF in nfp guide") Cc: sta...@dpdk.org Signed-off-by: Chaoyong.He Signed-off-by: Heinrich Kuhn --- doc/gu

Re: [dpdk-dev] [PATCH] devtools: catch symbol duplicates in version map

2021-02-25 Thread Thomas Monjalon
25/02/2021 12:14, David Marchand: > Add a check on versioned symbol duplicates in map files. > > Signed-off-by: David Marchand > --- > This check could be added to buildtools/check-symbols.sh so that > regular developers catch the issue when building their changes... > Opinions? In general I am

[dpdk-dev] DPDK Release Status Meeting 25/02/2021

2021-02-25 Thread Ferruh Yigit
Meeting minutes of 25 February 2021 --- Agenda: * Release Dates * Subtrees * LTS Participants: * Arm * Broadcom * Debian/Microsoft * Intel * Marvell * Nvidia * Red Hat Release Dates - * v21.05 dates * Proposal/V1:Thursday, 18 March * -rc1:

[dpdk-dev] IPv6 header misleading comment

2021-02-25 Thread Levend Sayar
Hi, all. Comment for payload_len is misleading. It says "includes header size". In fact, payload_len does not include IPv6 header size. As the name implies, only payload size + plus extensions size if any. struct rte_ipv6_hdr { rte_be32_t vtc_flow;/**< IP version, traffic class & flow

[dpdk-dev] [PATCH] devtools: catch symbol duplicates in version map

2021-02-25 Thread David Marchand
Add a check on versioned symbol duplicates in map files. Signed-off-by: David Marchand --- This check could be added to buildtools/check-symbols.sh so that regular developers catch the issue when building their changes... Opinions? --- devtools/check-symbol-maps.sh | 15 +++ 1 file

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] net/ixgbe: fix UDP zero checksum error

2021-02-25 Thread David Marchand
Hello Haiyue, On Thu, Feb 4, 2021 at 3:56 PM Haiyue Wang wrote: > > There is an 82599 errata that UDP frames with a zero checksum are > incorrectly marked as checksum invalid by the hardware. This was > leading to misleading PKT_RX_L4_CKSUM_BAD flag. > > This patch changes the bad UDP checksum t

[dpdk-dev] [PATCH v2] power: remove duplicated symbols from map file

2021-02-25 Thread Ferruh Yigit
This is causing build error, like: https://travis-ci.com/github/ovsrobot/dpdk/jobs/482121104 Also '@internal' marker removed from doxygen comment, since public API should not be internal. Experimental tag removed from 'rte_power_guest_channel_send_msg()' Fixes: 4d3892dcd77b ("power: make channel

[dpdk-dev] [PATCH 4/4] net/mlx5: fix imissed statistics

2021-02-25 Thread Matan Azrad
The imissed port statistic counts packets that were dropped by the device Rx queues. In mlx5, the imissed counter summarizes 2 counters: - packets dropped by the SW queue handling counted by SW. - packets dropped by the HW queues due to "out of buffer" events detected whe

[dpdk-dev] [PATCH 2/4] common/mlx5: add DevX command to query WQ

2021-02-25 Thread Matan Azrad
Add a DevX command to query Rx queues attributes created by VERBS. Currently support only counter_set_id attribute. This counter ID is managed by the kernel driver and being assigned to any queue created by the kernel. Cc: sta...@dpdk.org Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx

[dpdk-dev] [PATCH 3/4] common/mlx5: add DevX commands for queue counters

2021-02-25 Thread Matan Azrad
A queue counter set is an HW object that can be assigned to any RQ\QP and it counts HW events on the assigned QPs\RQs. Add DevX API to allocate and query queue counter set object. The only used counter event is the "out of buffer" where the queue drops packets when no SW buffer is available to re

[dpdk-dev] [PATCH 1/4] common/mlx5/linux: add glue function to query WQ

2021-02-25 Thread Matan Azrad
When Rx queue is created by VERBS API ibv_create_wq there is a dedicated rdma-core API to query an information about this WQ(Work Queue). VERBS WQ querying is needed for PMD cases which combine VERBS objects with DevX objects. Next feature to use this glue function is the HW queue counters. Cc:

[dpdk-dev] [PATCH 0/4] net/mlx5: fix imissed statistic

2021-02-25 Thread Matan Azrad
The imissed port statistic counts packets that were dropped by the device Rx queues. In mlx5, the imissed counter summarizes 2 counters: - packets dropped by the SW queue handling counted by SW. - packets dropped by the HW queues due to "out of buffer" events detected whe

Re: [dpdk-dev] [PATCH] power: remove duplicated symbols from map file

2021-02-25 Thread David Marchand
On Thu, Feb 25, 2021 at 11:41 AM Ferruh Yigit wrote: > > Sidenote, we can probably catch these duplicates during build. > > For duplicate entries with the same version, this is easy. > > I'll see if I can catch the other case too. > > > > Wasn't there a script for it already, I slightly remember i

  1   2   >