Re: [dpdk-dev] [RFC] eventdev: introduce event dispatcher

2021-02-26 Thread Mattias Rönnblom
On 2021-02-25 13:32, Jerin Jacob wrote: > On Fri, Feb 19, 2021 at 12:00 AM Mattias Rönnblom > wrote: >> The purpose of the event dispatcher is primarily to decouple different >> parts of an application (e.g., processing pipeline stages), which >> share the same underlying event device. >> >> The e

[dpdk-dev] [PATCH] net/i40e: fix IPv4 fragment offload issue

2021-02-26 Thread Xiaoyun Li
IPv4 fragment_offset mask was required to be 0 no matter what the spec value was. But zero mask means not caring about fragment_offset field then both non-frag and frag packets should hit the rule. But the actual fragment rules should be like the following: Only non-fragment packets can hit Rule 1

Re: [dpdk-dev] [RFC 3/5] eal: lcore state FINISHED is not required

2021-02-26 Thread Thomas Monjalon
26/02/2021 00:33, Honnappa Nagarahalli: > +Thomas, David, Konstantin for input > > > > > > Subject: [RFC 3/5] eal: lcore state FINISHED is not required > > > > > > FINISHED state seems to be used to indicate that the worker's update > > > of the 'state' is not visible to other threads. There see

Re: [dpdk-dev] [PATCH v5 04/17] build: define _GNU_SOURCE globally

2021-02-26 Thread Bruce Richardson
On Thu, Feb 25, 2021 at 07:22:37PM +0100, Thomas Monjalon wrote: > There was an intent to define _GNU_SOURCE globally, > but it was not set in pkg-config for external applications. > Is this something that we really want to do, to force all external apps to use _GNU_SOURCE when compiling? Do some

Re: [dpdk-dev] [PATCH v5 03/17] build: detect execinfo library on Linux

2021-02-26 Thread Bruce Richardson
On Thu, Feb 25, 2021 at 07:22:36PM +0100, Thomas Monjalon wrote: > The library execinfo and its header file can be installed on Alpine Linux > where the backtrace feature is not part of musl libc: > apk add libexecinfo-dev > > As a consequence, this library should not be restricted to BSD on

Re: [dpdk-dev] [PATCH v5 02/17] buildtools: fix build with busybox

2021-02-26 Thread Bruce Richardson
On Thu, Feb 25, 2021 at 07:22:35PM +0100, Thomas Monjalon wrote: > If using busybox for mktemp and awk (as in Alpine), > some bugs prevent the script from running: > > 1/ It seems busybox mktemp requires the pattern to have at least > 6 X and no other suffix. > The same has been fixed for other sc

Re: [dpdk-dev] [PATCH v5 04/17] build: define _GNU_SOURCE globally

2021-02-26 Thread Thomas Monjalon
26/02/2021 10:08, Bruce Richardson: > On Thu, Feb 25, 2021 at 07:22:37PM +0100, Thomas Monjalon wrote: > > There was an intent to define _GNU_SOURCE globally, > > but it was not set in pkg-config for external applications. > > > Is this something that we really want to do, to force all external ap

Re: [dpdk-dev] [PATCH v5 04/17] build: define _GNU_SOURCE globally

2021-02-26 Thread Bruce Richardson
On Fri, Feb 26, 2021 at 10:40:32AM +0100, Thomas Monjalon wrote: > 26/02/2021 10:08, Bruce Richardson: > > On Thu, Feb 25, 2021 at 07:22:37PM +0100, Thomas Monjalon wrote: > > > There was an intent to define _GNU_SOURCE globally, > > > but it was not set in pkg-config for external applications. > >

Re: [dpdk-dev] [PATCH v5 04/17] build: define _GNU_SOURCE globally

2021-02-26 Thread Thomas Monjalon
26/02/2021 10:46, Bruce Richardson: > On Fri, Feb 26, 2021 at 10:40:32AM +0100, Thomas Monjalon wrote: > > 26/02/2021 10:08, Bruce Richardson: > > > On Thu, Feb 25, 2021 at 07:22:37PM +0100, Thomas Monjalon wrote: > > > > There was an intent to define _GNU_SOURCE globally, > > > > but it was not se

Re: [dpdk-dev] [PATCH] app/testpmd: add support for forced ethernet speed

2021-02-26 Thread Ferruh Yigit
On 2/26/2021 6:43 AM, Andrew Rybchenko wrote: On 2/25/21 9:25 PM, Ferruh Yigit wrote: On 2/22/2021 7:18 PM, Ajit Khaparde wrote: Add support for forced ethernet speed setting. Currently testpmd tries to configure the Ethernet port in autoneg mode. It is not possible to set the Ethernet port to

Re: [dpdk-dev] [PATCH v3 00/17] net/txgbe: add VF driver support

2021-02-26 Thread Ferruh Yigit
On 2/25/2021 8:08 AM, Jiawen Wu wrote: This patch adds txgbevf PMD as a part of txgbe PMD. v3: - Rebase on 21.05-rc0 - Fix some minor issues v2: - Rebase on latest repo - Remove vf port representor because test issue is found - Add a little doc Jiawen Wu (17): net/txgbe: add ethdev probe an

[dpdk-dev] [PATCH] net/sfc: fix passing wrong buffer size

2021-02-26 Thread Ivan Malov
Pass the size of the buffer where the item's mask is stored and not the indirection pointer size. Coverity issue: 363735 Fixes: dadff137931c ("net/sfc: support encap flow items in transfer rules") Cc: sta...@dpdk.org Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy More

Re: [dpdk-dev] [PATCH 04/13] net/hns3: add Rx and Tx bytes stats

2021-02-26 Thread Ferruh Yigit
On 2/24/2021 1:28 AM, Lijun Ou wrote: From: "Min Hu (Connor)" In current HNS3 PMD, Rx/Tx bytes from packet stats are not implemented. This patch implemented Rx/Tx bytes using soft counters. Rx/Tx bytes stats will be enabled if the macro RTE_LIBRTE_HNS3_PMD_SOFT_COUNTERS is defined. Signed-off

Re: [dpdk-dev] [PATCH 09/13] net/hns3: fix maximum frame size update after buffer alloc

2021-02-26 Thread Ferruh Yigit
On 2/24/2021 1:28 AM, Lijun Ou wrote: From: Chengchang Tang After MTU changed, the buffer used to store packets in HW should be reallocated. And buffer size is allocated based on the maximum frame size in the PF struct. However, the value of maximum frame size is not updated in time when MTU i

Re: [dpdk-dev] [PATCH 07/13] net/hns3: support PF on electrical net device

2021-02-26 Thread Ferruh Yigit
On 2/24/2021 1:28 AM, Lijun Ou wrote: From: Huisong Li The normal operation of electrical interface devices depends on the initialization and configuration of the PHY chip. The task of driving the PHY chip is implemented in some firmware versions. If firmware supports the phy driver, it will re

Re: [dpdk-dev] [PATCH 12/13] net/hns3: add process for MAC interrupt

2021-02-26 Thread Ferruh Yigit
On 2/24/2021 1:28 AM, Lijun Ou wrote: From: Hongbo Zheng Enable the interrupt report of MAC when MAC state changes and log the hardware MAC state value. What is MAC TNL Interrupt, can you please provide more information in the commit log? And what is done as interrupt handling, as far as I c

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: fix passing wrong buffer size

2021-02-26 Thread Ferruh Yigit
On 2/26/2021 2:10 PM, Ivan Malov wrote: Pass the size of the buffer where the item's mask is stored and not the indirection pointer size. Coverity issue: 363735 Fixes: dadff137931c ("net/sfc: support encap flow items in transfer rules") Cc: sta...@dpdk.org Signed-off-by: Ivan Malov Reviewed-by

Re: [dpdk-dev] [PATCH 2/2] kni: fix rtnl deadlocks and race conditions v4

2021-02-26 Thread Stephen Hemminger
On Fri, 26 Feb 2021 00:01:01 +0300 Igor Ryzhov wrote: > Hi Elad, > > Thanks for the patch, but this is still NACK from me. > > The only real advantage of KNI over other exceptional-path techniques > like virtio-user is the ability to configure DPDK-managed interfaces > directly > from the kerne

Re: [dpdk-dev] [PATCH v2] mbuf: rename outer ip checksum macro

2021-02-26 Thread Ferruh Yigit
On 2/25/2021 2:31 PM, Lance Richardson wrote: Rename PKT_RX_EIP_CKSUM_BAD to PKT_RX_OUTER_IP_CKSUM_BAD and deprecate the original name. The new name is better aligned with existing PKT_RX_OUTER_* flags, which should help reduce confusion about its use. Suggested-by: Ferruh Yigit Signed-off-by:

Re: [dpdk-dev] [PATCH] net/mlx5: fix wrong segmented packet in Rx

2021-02-26 Thread Jiawei Zhu
Hi, Slava Thanks for reading my patch, my issue may not be clear. Here I give a possible error. - we assume segs_n is 4 and we are receiving 4 segments multi-segment packet. - we fail to alloc mbuf when receive the 3th segment,so it will free the mbufs which packet chain we have built. Here are

Re: [dpdk-dev] [PATCH] app/testpmd: add support for forced ethernet speed

2021-02-26 Thread Andrew Boyer
> On Feb 26, 2021, at 6:21 AM, Ferruh Yigit wrote: > > On 2/26/2021 6:43 AM, Andrew Rybchenko wrote: >> On 2/25/21 9:25 PM, Ferruh Yigit wrote: >>> On 2/22/2021 7:18 PM, Ajit Khaparde wrote: Add support for forced ethernet speed setting. Currently testpmd tries to configure the Ether

[dpdk-dev] [PATCH] driver/net/pcap fix: pcap fd leak

2021-02-26 Thread ZhangTengfei
pcap fd was opend when vdev probed, but not closed when vdev removed. This bug appears in dpdk-pdump Signed-off-by: ZhangTengfei --- drivers/net/pcap/rte_eth_pcap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index 90f5d75

Re: [dpdk-dev] [PATCH] driver/net/pcap fix: pcap fd leak

2021-02-26 Thread Ferruh Yigit
On 2/26/2021 4:20 PM, ZhangTengfei wrote: pcap fd was opend when vdev probed, but not closed when vdev removed. This bug appears in dpdk-pdump Signed-off-by: ZhangTengfei --- drivers/net/pcap/rte_eth_pcap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/pcap/rte_eth_pcap.c b

Re: [dpdk-dev] [PATCH 2/2] kni: fix rtnl deadlocks and race conditions v4

2021-02-26 Thread Elad Nachman
The way the kernel handles its locks and lists for the dev close many path, there is no way you can go around this with rtnl unlocked : " There is a race condition in __dev_close_many() processing the close_list while the application terminates. It looks like if two vEth devices are terminating, a

[dpdk-dev] 回复: [PATCH] driver/net/pcap fix: pcap fd leak

2021-02-26 Thread 张 杨
I think your idea is fine What do you think just record file path in "pmd_pcap_probe()", Perform an open operation only in "eth_dev_start()"? When the secondary process add pcap vdev, it send the request to primary process, the primary process probe pcap vdev too , Both the two process open the s

[dpdk-dev] [PATCH] pipeline: add register array support to SWX pipeline

2021-02-26 Thread Cristian Dumitrescu
Register arrays are stateful objects that can be read & modified by both the data plane and the control plane, as opposed to tables, which are read-only for data plane. One key use-case is the implementation of stats counters. Signed-off-by: Cristian Dumitrescu --- examples/pipeline/cli.c

[dpdk-dev] [PATCH v2] pipeline: add register array support to SWX pipeline

2021-02-26 Thread Cristian Dumitrescu
Register arrays are stateful objects that can be read & modified by both the data plane and the control plane, as opposed to tables, which are read-only for data plane. One key use-case is the implementation of stats counters. Signed-off-by: Cristian Dumitrescu --- examples/pipeline/cli.c

Re: [dpdk-dev] [PATCH v2] mbuf: rename outer ip checksum macro

2021-02-26 Thread Ajit Khaparde
On Fri, Feb 26, 2021 at 8:01 AM Ferruh Yigit wrote: > > On 2/25/2021 2:31 PM, Lance Richardson wrote: > > Rename PKT_RX_EIP_CKSUM_BAD to PKT_RX_OUTER_IP_CKSUM_BAD and > > deprecate the original name. The new name is better aligned > > with existing PKT_RX_OUTER_* flags, which should help reduce >

Re: [dpdk-dev] [PATCH 09/13] net/hns3: fix maximum frame size update after buffer alloc

2021-02-26 Thread oulijun
在 2021/2/26 23:25, Ferruh Yigit 写道: On 2/24/2021 1:28 AM, Lijun Ou wrote: From: Chengchang Tang After MTU changed, the buffer used to store packets in HW should be reallocated. And buffer size is allocated based on the maximum frame size in the PF struct. However, the value of maximum frame