Re: [dpdk-dev] [EXT] [PATCH] cryptodev: support multiple cipher block sizes

2021-02-28 Thread Matan Azrad
From: Anoob Joseph > Hi Matan, > > With the current spec, AES-XTS operation offloading would mean application is > expected to track data blocks and the corresponding tweak & cipher stealing, > while the final crypto operation gets offloaded to PMD. This proposal aims at > moving the entire AES

[dpdk-dev] [PATCH] net/iavf: fix TSO max segment size

2021-02-28 Thread Qi Zhang
According to Intel® AVF spec (https://www.intel.com/content/dam/ www/public/us/en/documents/product-specifications/ ethernet-adaptive-virtual-function-hardware-spec.pdf) section 2.2.2.3: The max segment size(MSS) of TSO should not be set lower than 88. Fixes: a2b29a7733ef ("net/avf: enable basic R

Re: [dpdk-dev] [PATCH v5 15/17] vdpa/mlx5: replace pthread functions unavailable in musl

2021-02-28 Thread Matan Azrad
From: Thomas Monjalon > 1/ The function pthread_yield() does not exist in musl libc, and can be > replaced > with sched_yield() after including sched.h. > > 2/ The function pthread_attr_setaffinity_np() does not exist in musl libc, and > can be replaced with pthread_setaffinity_np() after pthr

Re: [dpdk-dev] [PATCH] [RFC, v2]: adds support PPS(packet per second) on meter

2021-02-28 Thread Ajit Khaparde
On Sun, Feb 28, 2021 at 7:16 PM Li Zhang wrote: > > Hi Morten, > > Thank you for your comments. > It is packet count instead of frames count. > So 4K TCP packet should be handle as one instead of 3 Ethernet Frames. So it is not dependent on the MTU? > > We will update the struct as below: > enum

Re: [dpdk-dev] [PATCH] [RFC, v2]: adds support PPS(packet per second) on meter

2021-02-28 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Li Zhang > Sent: Monday, March 1, 2021 4:16 AM > > Hi Morten, > > Thank you for your comments. > It is packet count instead of frames count. > So 4K TCP packet should be handle as one instead of 3 Ethernet Frames. > > We will update the stru

[dpdk-dev] [PATCH v3] net/i40e: fix inputset field mask

2021-02-28 Thread Alvin Zhang
The absolute field offsets of IPv4 or IPv6 header are related to hardware configuration. The X710 and X722 have different hardware configurations, and users can even modify the hardware configuration. Therefore, The default values cannot be used when calculating mask offset. The following flows ca

[dpdk-dev] [PATCH v3] net/i40e: fix inputset field mask

2021-02-28 Thread Alvin Zhang
The absolute field offsets of IPv4 or IPv6 header are related to hardware configuration. The X710 and X722 have different hardware configurations, and users can even modify the hardware configuration. Therefore, The default values cannot be used when calculating mask offset. The following flows ca

[dpdk-dev] [PATCH v4] bus/pci/windows: support for PCI scan allowed and blocked lists

2021-02-28 Thread Khoa To
EAL -a and -b options are used to specify which PCI devices are explicitly allowed or blocked during PCI bus scan. This evaluation is missing in the Windows implementation of rte_pci_scan. This patch provides this missing functionality, so that apps can specify which NetUIO devices to ignore duri

[dpdk-dev] [PATCH v3] bus/pci/windows: support for PCI scan allowed and blocked lists

2021-02-28 Thread Khoa To
EAL -a and -b options are used to specify which PCI devices are explicitly allowed or blocked during PCI bus scan. This evaluation is missing in the Windows implementation of rte_pci_scan. This patch provides this missing functionality, so that apps can specify which NetUIO devices to ignore duri

[dpdk-dev] [PATCH] crypto/octeontx: fix session-less mode

2021-02-28 Thread Ankur Dwivedi
A temporary session is created for sessionless crypto operations. rte_cryptodev_sym_session_create() should be used for creating the temporary session as it initializes the session structure in the correct way. Fixes: caeba5062c39 ("crypto/octeontx: improve symmetric session-less path") Signed-of

[dpdk-dev] 回复: [RFC 3/5] eal: lcore state FINISHED is not required

2021-02-28 Thread Feifei Wang
> -邮件原件- > 发件人: Honnappa Nagarahalli > 发送时间: 2021年2月26日 7:33 > 收件人: Feifei Wang ; hemant.agra...@nxp.com; > nipun.gu...@nxp.com; jer...@marvell.com; harry.van.haa...@intel.com; > bruce.richard...@intel.com; dmitry.kozl...@gmail.com; > navas...@linux.microsoft.com; dmit...@microsoft.com; >

Re: [dpdk-dev] 19.11.7 patches review and test

2021-02-28 Thread Pei Zhang
Hello Christian, The testing with dpdk 19.11.7-rc1 from Red Hat looks good. We tested below 16 scenarios and and all got PASS on RHEL8: (1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS (2)Guest with device assignment(PF) throughput testing(2M hugepage size) : PASS (

Re: [dpdk-dev] [PATCH] net/bnxt: refactor HWRM rings allocation routine

2021-02-28 Thread Ajit Khaparde
On Fri, Feb 19, 2021 at 1:28 AM Somnath Kotur wrote: > > bnxt_alloc_hwrm_rings() was duplicating a snippet of code that was > already present in bnxt_alloc_hwrm_rx_ring() with just one line/function > invocation missing. Add that line and replace the snippet of code > with a call to bnxt_hwrm_allo

Re: [dpdk-dev] [PATCH] net/bnxt: fix Rx queue count implementation

2021-02-28 Thread Ajit Khaparde
On Thu, Feb 18, 2021 at 10:19 AM Lance Richardson wrote: > > bnxt_rx_queue_count_op() incorrectly returns the number of > filled but unprocessed completion queue entries instead of > the number of filled but unprocessed received packet > completions. Fix by properly accounting for the number of >

Re: [dpdk-dev] [PATCH] [RFC, v2]: adds support PPS(packet per second) on meter

2021-02-28 Thread Li Zhang
Hi Morten, Thank you for your comments. It is packet count instead of frames count. So 4K TCP packet should be handle as one instead of 3 Ethernet Frames. We will update the struct as below: enum rte_mtr_algorithm { .. /** Single Rate Three Color Marker, Packet based (srTCMp).

Re: [dpdk-dev] DPDK Release Status Meeting 25/02/2021

2021-02-28 Thread Ruifeng Wang
> -Original Message- > From: dev On Behalf Of Ferruh Yigit > Sent: Thursday, February 25, 2021 7:33 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net > Subject: [dpdk-dev] DPDK Release Status Meeting 25/02/2021 > > Meeting minutes of 25 February 2021 > --- >

[dpdk-dev] [Bug 644] [dpdk-19.11.7]usertools/dpdk-devbind.py: bind NIC port to DPDK failed in vm.

2021-02-28 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=644 Bug ID: 644 Summary: [dpdk-19.11.7]usertools/dpdk-devbind.py: bind NIC port to DPDK failed in vm. Product: DPDK Version: 19.11 Hardware: All OS: All Stat

Re: [dpdk-dev] [RFC] ethdev: add sanity packet checks

2021-02-28 Thread Thomas Monjalon
28/02/2021 20:48, Ori Kam: > Currently, DPDK application can offload the checksum check, > and report it in the mbuf. > > However, this approach doesn't work if the traffic > is offloaded and should not arrive to the application. > > This commit introduces rte flow item that enables s/rte flow/r

[dpdk-dev] [RFC] ethdev: add sanity packet checks

2021-02-28 Thread Ori Kam
Currently, DPDK application can offload the checksum check, and report it in the mbuf. However, this approach doesn't work if the traffic is offloaded and should not arrive to the application. This commit introduces rte flow item that enables matching on the checksum of the L3 and L4 layers, in a

Re: [dpdk-dev] DPDK 21.05 Huawei hns3 Roadmap

2021-02-28 Thread Thomas Monjalon
For info, I've updated the website to reflect most of the items below. https://git.dpdk.org/tools/dpdk-web/commit/?id=b9fc4e62c79 23/02/2021 10:08, oulijun: > Hi, > > Following are the work items of hns3 PMD planned for 21.05, Some > features are delayed to the current releases. >

Re: [dpdk-dev] [PATCH] update Marvell roadmap for 21.05

2021-02-28 Thread Thomas Monjalon
20/02/2021 09:46, jer...@marvell.com: > From: Jerin Jacob > > Signed-off-by: Jerin Jacob Applied, thanks. > +- Introduce event vector support to reduce the scheduler overhead and to > improve performance > +- Add support for event vector support in SW Rx eventdev Adapter > +- Update test-even

[dpdk-dev] [PATCH v1] pflock: implementation of phase-fair reader writer locks

2021-02-28 Thread Stephen Hemminger
This is a new type of reader-writer lock that provides better fairness guarantees which makes it better for typical DPDK applications. They lock internally uses two ticket pools, one for readers and one for writers. Phase fair reader writer locks ensure that neither reader or writer will be starve

Re: [dpdk-dev] [PATCH] mem: fix free segment when using huge-unlink option

2021-02-28 Thread Roy Shterman
On Mon, Feb 22, 2021 at 5:53 PM Burakov, Anatoly wrote: > On 22-Feb-21 10:41 AM, Roy Shterman wrote: > > When using huge_unlink we unlink the segment right > > after allocation. Although we unlink the file we keep > > the fd in fd_list so file still exist just the path deleted. > > When freeing t

Re: [dpdk-dev] [PATCH v6] bus/pci: nvme on Windows requires class id and bus

2021-02-28 Thread Dmitry Kozlyuk
2021-02-23 18:18, Nick Connolly: > Attaching to an NVMe disk on Windows using SPDK requires the > PCI class ID and device.bus fields. Decode the class ID from the PCI > device info strings if it is present and set device.bus. > > Signed-off-by: Nick Connolly > Acked-by: Tal Shnaiderman > --- > v

Re: [dpdk-dev] [PATCH v6 0/9] ethdev: support SubFunction representor

2021-02-28 Thread Xueming(Steven) Li
>-Original Message- >From: Wang, Haiyue >Sent: Tuesday, February 23, 2021 7:46 PM >To: Stephen Hemminger ; Xueming(Steven) Li > >Cc: dev@dpdk.org; Slava Ovsiienko ; Asaf Penso > >Subject: RE: [dpdk-dev] [PATCH v6 0/9] ethdev: support SubFunction representor > >> -Original Message-

[dpdk-dev] [PATCH v6 17/17] examples/bbdev: fix header include for musl

2021-02-28 Thread Thomas Monjalon
The header file unistd.h should not be included from sys/ directory, it is an error with musl libc. Fixes: 1ffee690eaa1 ("examples/bbdev: add sample app") Cc: sta...@dpdk.org Signed-off-by: Thomas Monjalon --- examples/bbdev_app/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[dpdk-dev] [PATCH v6 16/17] app/testpmd: fix build with musl

2021-02-28 Thread Thomas Monjalon
From: Natanael Copa 1/ Improve portability by avoiding use of non-standard 'uint'. Use uint8_t for hash_key_len as rss_key_len is a uint8_t type. This solves following build error when building with musl libc: app/test-pmd/testpmd.h:813:29: error: unknown type name 'uint' 2/ In musl libc, st

[dpdk-dev] [PATCH v6 15/17] vdpa/mlx5: replace pthread functions unavailable in musl

2021-02-28 Thread Thomas Monjalon
1/ The function pthread_yield() does not exist in musl libc, and can be replaced with sched_yield() after including sched.h. 2/ The function pthread_attr_setaffinity_np() does not exist in musl libc, and can be replaced with pthread_setaffinity_np() after pthread_create(). Fixes: b7fa0bf4d5c6 ("v

[dpdk-dev] [PATCH v6 14/17] net/igc: remove use of uint type

2021-02-28 Thread Thomas Monjalon
Improve portability (especially with musl libc) by replacing the non-standard type 'uint' with 'size_t'. Fixes: 746664d546fb ("net/igc: support flow API") Cc: sta...@dpdk.org Suggested-by: David Marchand Signed-off-by: Thomas Monjalon Acked-by: Haiyue Wang --- drivers/net/igc/igc_flow.c | 2 +

[dpdk-dev] [PATCH v6 13/17] net/cxgbe: remove use of uint type

2021-02-28 Thread Thomas Monjalon
From: Natanael Copa Improve portability by replacing non-standard 'uint' with 'unsigned int'. This solves the build error with musl libc: In file included from ../drivers/net/cxgbe/cxgbe.h:9, from ../drivers/net/cxgbe/cxgbe_ethdev.c:37: ../drivers/net/cxgbe/base/common.h:201:4:

[dpdk-dev] [PATCH v6 12/17] common/dpaax/caamflib: simplify log macros

2021-02-28 Thread Thomas Monjalon
From: Natanael Copa Simplify pr_debug, pr_err and pr_warn macros by adding an intermediate pr_msg macro. This way we only need to test for SUPPRESS_PRINTS once. Signed-off-by: Natanael Copa Acked-by: Hemant Agrawal --- drivers/common/dpaax/caamflib/compat.h | 28 +++--- 1

[dpdk-dev] [PATCH v6 11/17] common/dpaax/caamflib: fix build with musl

2021-02-28 Thread Thomas Monjalon
From: Natanael Copa The swab16/swab32/swab64 are Linux specific and not GNU libc specific. Keep the check for __GLIBC__ just in case other GNU systems depends on this (Hurd or GNU/kFreeBSD). This fixes a build error with musl libc. Fixes: 04711d41a872 ("crypto/dpaa2_sec: add run-time assembler

[dpdk-dev] [PATCH v6 10/17] bus/dpaa: fix build with musl

2021-02-28 Thread Thomas Monjalon
From: Natanael Copa Fix build with musl libc by using warn(3) instead of using the GNU specific error(3). `error(0, errno, ...)` is identical to `warn(...)` so replace: error(0, ret, ...); with the identical: errno = ret; warn(...); We could have used the identical `warnx("...: %s", st

[dpdk-dev] [PATCH v6 09/17] bus/dpaa: fix 64-bit arch detection

2021-02-28 Thread Thomas Monjalon
From: Natanael Copa There is no standard saying that __WORDSIZE should be be defined or in what include it should be defined. Use RTE_ARCH_64 instead. This solves a warning when building with musl libc: warning: "__WORDSIZE" is not defined, evaluates to 0 [-Wundef] Fixes: 847ee3bd0d1f ("bus/d

[dpdk-dev] [PATCH v6 08/17] bus/pci: support I/O port operations with musl

2021-02-28 Thread Thomas Monjalon
From: Natanael Copa Add a fallback for non-GNU libc systems like musl libc for the non-standard functions outl_p, outw_p and outb_p. This solves the following buildtime errors when building with musl libc: pci_uio.c:(.text+0xaa1): undefined reference to `outw_p' pci_uio.c:(.text+0xac5): undefine

[dpdk-dev] [PATCH v6 07/17] drivers: replace page size definitions with function

2021-02-28 Thread Thomas Monjalon
The page size is often retrieved from the macro PAGE_SIZE. If PAGE_SIZE is not defined, it is either using hard coded default, or getting the system value from the UNIX-only function sysconf(). Such definitions are replaced with the generic function rte_mem_page_size() defined for each supported O

[dpdk-dev] [PATCH v6 06/17] drivers: fix header includes for musl

2021-02-28 Thread Thomas Monjalon
The header files argp.h and error.h do not exist in musl libc and are not needed in dpaa code. The header file fcntl.h should not be included from sys/ directory as done in dlb drivers, it is an error with musl libc. Fixes: 5b22cf744689 ("bus/dpaa: introducing FMan configurations") Fixes: 39f373c

[dpdk-dev] [PATCH v6 05/17] eal: fix build with musl

2021-02-28 Thread Thomas Monjalon
In musl libc, cpu_set_t is defined only if _GNU_SOURCE is defined. In case _GNU_SOURCE is undefined, as in eal_common_errno.c, it was not possible to include rte_os.h which uses cpu_set_t. This limitation is removed: if CPU_SETSIZE is not defined, cpu_set_t related definitions and functions are sk

[dpdk-dev] [PATCH v6 04/17] build: remove redundant _GNU_SOURCE definitions

2021-02-28 Thread Thomas Monjalon
The feature macro _GNU_SOURCE is defined globally, but there was some remaining useless settings. The internal definition in config/meson.build is kept, all other internal definitions of _GNU_SOURCE are removed, except in examples, which can be built as external applications. Note: external applic

[dpdk-dev] [PATCH v6 03/17] build: detect execinfo library on Linux

2021-02-28 Thread Thomas Monjalon
The library execinfo and its header file can be installed on Alpine Linux where the backtrace feature is not part of musl libc: apk add libexecinfo-dev As a consequence, this library should not be restricted to BSD only. At the same time, the library and header are detected once and added

[dpdk-dev] [PATCH v6 02/17] buildtools: fix build with busybox

2021-02-28 Thread Thomas Monjalon
If using busybox for mktemp and awk (as in Alpine), some bugs prevent the script from running: 1/ It seems busybox mktemp requires the pattern to have at least 6 X and no other suffix. The same has been fixed for other scripts in the past: commit 3771edc35438 ("buildtools: fix build for some mktem

[dpdk-dev] [PATCH v6 01/17] eal: fix comment of OS-specific header files

2021-02-28 Thread Thomas Monjalon
The same comment is on top of each rte_os.h file. It is reworded to remove the mention of "future releases". Fixes: 428eb983f5f7 ("eal: add OS specific header file") Cc: sta...@dpdk.org Signed-off-by: Thomas Monjalon --- lib/librte_eal/freebsd/include/rte_os.h | 5 ++--- lib/librte_eal/linux/in

[dpdk-dev] [PATCH v6 00/17] Alpine/musl build support

2021-02-28 Thread Thomas Monjalon
These patches fix some build errors/warning for Alpine Linux, using musl and busybox. Few improvements are added on the way. The goal is to run a container with the following Dockerfile: 8< FROM alpine # DPDK prerequisites RUN apk --no-cache add \ gcc libc-dev bsd-compat-headers

Re: [dpdk-dev] [PATCH v5 04/17] build: define _GNU_SOURCE globally

2021-02-28 Thread Thomas Monjalon
26/02/2021 11:04, Thomas Monjalon: > 26/02/2021 10:46, Bruce Richardson: > > On Fri, Feb 26, 2021 at 10:40:32AM +0100, Thomas Monjalon wrote: > > > 26/02/2021 10:08, Bruce Richardson: > > > > On Thu, Feb 25, 2021 at 07:22:37PM +0100, Thomas Monjalon wrote: > > > > > There was an intent to define _G