Re: [dpdk-dev] [PATCH 8/8] drivers: add common driver API to get efx family

2021-03-13 Thread Ferruh Yigit
On 3/11/2021 11:03 AM, Andrew Rybchenko wrote: From: Vijay Kumar Srivastava Move function to get efx family from net driver into common driver. Signed-off-by: Vijay Kumar Srivastava Signed-off-by: Andrew Rybchenko <...> diff --git a/drivers/meson.build b/drivers/meson.build index fdf7612

[dpdk-dev] [PATCH v3 4/4] net: replace Windows networking shim

2021-03-13 Thread Dmitry Kozlyuk
Remove networking shim from Windows EAL. Replace it with system headers with two workarounds: 1. Windows Sockets headers contain `#define s_addr S_un.S_addr`, which conflicts with `s_addr` field of `struct rte_ether_hdr`. Undefining this macro in had been breaking some usages of DPDK an

[dpdk-dev] [PATCH v3 3/4] net/mlx5: remove POSIX dependency

2021-03-13 Thread Dmitry Kozlyuk
Use for IP-related defines instead of POSIX headers. Keep , because it is incorporated into DPDK. Signed-off-by: Dmitry Kozlyuk --- drivers/net/mlx5/mlx5.h | 2 +- drivers/net/mlx5/mlx5_flow.c | 4 ++-- drivers/net/mlx5/mlx5_flow.h | 4 ++-- drivers/net/mlx5/mlx5_mac.c | 1 - 4 files chan

[dpdk-dev] [PATCH v3 0/4] net: replace Windows networking shim

2021-03-13 Thread Dmitry Kozlyuk
Networking header shim in Windows EAL conflicts with system headers and tries to provide POSIX compatibility out of scope for DPDK. Remove dependency on POSIX headers from libraries supported on Windows, then replace shim with librte_net with workarounds. A proposed deprecation notice is assumed:

[dpdk-dev] [PATCH v3 2/4] ethdev: remove POSIX dependency

2021-03-13 Thread Dmitry Kozlyuk
Use for IP-related defines instead of POSIX headers. Keep , because it is incorporated into DPDK. Cleanup, group, and sort remaining includes per coding style. Signed-off-by: Dmitry Kozlyuk --- lib/librte_ethdev/rte_ethdev.c | 13 + lib/librte_ethdev/rte_ethdev_core.h | 1 - 2

[dpdk-dev] [PATCH v3 1/4] cmdline: remove POSIX dependency

2021-03-13 Thread Dmitry Kozlyuk
Use for IP-related defines instead of POSIX headers. Signed-off-by: Dmitry Kozlyuk --- Depends-on: series-15513 ("eal/windows: do not expose POSIX symbols") examples/cmdline/commands.c | 1 - examples/cmdline/parse_obj_list.c| 2 -- lib/librte_cmdline/cmdline.c

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] net/mlx5: fix wrong segmented packet in Rx

2021-03-13 Thread Thomas Monjalon
> > Signed-off-by: Jiawei Zhu <17826875...@163.com> > > Patch applied to next-net-mlx, Any specific reason for using your email address @163.com? Would your huawei address (Cc'ed) fit here? If you are OK, I prefer recognizing your contributions with a single identity.

Re: [dpdk-dev] [PATCH] librte_eal/common: fix return type of rte_bsf64

2021-03-13 Thread Tyler Retzlaff
On Sat, Mar 13, 2021 at 08:29:10AM +0100, Morten Brørup wrote: > > That would certainly be a nice improvement. But going down that road should > include reviewing and fixing all DPDK libraries with 32/64 versions of the > same functions, e.g. rte_bitops.h - which probably requires a significant

Re: [dpdk-dev] [PATCH] eal, power: don't use '-' sign with unsigned literals

2021-03-13 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tyler Retzlaff > Sent: Friday, March 12, 2021 7:40 PM > > On Fri, Mar 12, 2021 at 10:36:15AM -0800, Tyler Retzlaff wrote: > > On Fri, Mar 12, 2021 at 05:37:41PM +, Bruce Richardson wrote: > > > On Fri, Mar 12, 2021 at 09:05:58AM -0800, Tyl