[dpdk-dev] [PATCH] net/bnxt: fix memory allocation for command response

From: Kalesh AP Driver re-allocates memory for the command response buffer when the installed firmware version is newer (and has a larger max response length) than the version of HWRM that was used to build the PMD. This change helps to avoid the re-allocation by allocating the memory for the co

Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer

Hi, all, have any comments about this set of patches? thanks. 在 2021/3/10 9:35, Lijun Ou 写道: Here addes Kunpeng920 config back which was deleted. Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous variables") Signed-off-by: Chengchang Tang Signed-off-by: Lijun Ou

Re: [dpdk-dev] [PATCH 0/3] Fixes for testpmd

Hi, Ferruh and all, have any comments about this set of patches? thanks. 在 2021/3/5 18:22, Lijun Ou 写道: This series add two test bug fixes and a print style. Hongbo Zheng (1): app/testpmd: use of Rx/Tx in testpmd Huisong Li (2): app/testpmd: fix forwarding configuration w

Re: [dpdk-dev] [PATCH v3] app/testpmd: support multi-process

Hi, ferruh and all, have you any comments about this patch? thanks. 在 2021/3/11 17:07, Min Hu (Connor) 写道: From: Lijun Ou This patch adds multi-process support for testpmd. The test cmd example as follows: the primary cmd: ./dpdk-testpmd -a xxx --proc-type=auto -l 0-1 -- -i \ -

[dpdk-dev] [PATCH] event/octeontx2: fix xaq pool reconfigure

From: Pavan Nikhilesh When XAQ pool is being re-configured, and if the same memzone is used for fc_mem when freeing the old mempool the fc_mem will be incorrectly updated with the free count. Fixes: ffa4ec0b6063 ("event/octeontx2: allow adapters to resize inflight buffers") Cc: sta...@dpdk.org

Re: [dpdk-dev] Questions about keeping CRC

On Fri, Mar 19, 2021 at 12:07 PM Stephen Hemminger wrote: > > On Fri, 19 Mar 2021 20:13:20 +0800 > "Min Hu (Connor)" wrote: > > > Hi, all, > > DPDK has introduced one offload: DEV_RX_OFFLOAD_KEEP_CRC. It means > > that > > the device has the ablility of keeping CRC（four bytes at the end of

[dpdk-dev] [dpdk-dev v21.11] [PATCH v4 8/8] eventdev: simplify Rx adapter event vector config

From: Pavan Nikhilesh Include vector configuration into the structure ``rte_event_eth_rx_adapter_queue_conf`` used when configuring rest of the Rx adapter ethernet device Rx queue parameters. This simplifies event vector configuration as it avoids splitting configuration per Rx queue. Signed-off

[dpdk-dev] [PATCH v4 5/8] eventdev: add Tx adapter event vector support

From: Pavan Nikhilesh Add event vector support for event eth Tx adapter, the implementation receives events from the single linked queue and based on rte_event_vector::union_valid transmits the vector of mbufs to a given port, queue pair. Signed-off-by: Pavan Nikhilesh --- .../rte_event_eth_tx

[dpdk-dev] [PATCH v4 7/8] doc: announce event Rx adapter config changes

From: Pavan Nikhilesh The Rx adapter event vector configuration will be merged into Rx adapter queue configuration to simplify enabling event vectorization. Signed-off-by: Pavan Nikhilesh --- doc/guides/rel_notes/deprecation.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/

[dpdk-dev] [PATCH v4 3/8] eventdev: introduce event vector Tx capability

From: Pavan Nikhilesh Introduce event vector transmit capability for event eth tx adapter. The capability indicates that the Tx adapter is capable of transmitting event vectors. When rte_event_vector::union_valid is set, the Tx adapter should transmit all the packets to the rte_event_vector::por

[dpdk-dev] [PATCH v4 4/8] eventdev: add Rx adapter event vector support

From: Pavan Nikhilesh Add event vector support for event eth Rx adapter, the implementation creates vector flows based on port and queue identifier of the received mbufs. Signed-off-by: Pavan Nikhilesh --- lib/librte_eventdev/eventdev_pmd.h| 60 ++- .../rte_event_eth_rx_adapter.c

[dpdk-dev] [PATCH v4 6/8] app/eventdev: add event vector mode in pipeline test

From: Pavan Nikhilesh Add event vector support in pipeline tests. By default this mode is disabled, it can be enabled by using the option --enable_vector. example: dpdk-test-eventdev -l 7-23 -s 0xff00 -- --prod_type_ethdev --nb_pkts=0 --verbose 2 --test=pipeline_atq --stlist=a

[dpdk-dev] [PATCH v4 2/8] eventdev: introduce event vector Rx capability

From: Pavan Nikhilesh Introduce event ethernet Rx adapter event vector capability. If an event eth Rx adapter has the capability of RTE_EVENT_ETH_RX_ADAPTER_CAP_EVENT_VECTOR then a given Rx queue can be configured to enable event vectorization by passing the flag RTE_EVENT_ETH_RX_ADAPTER_QUEUE_E

[dpdk-dev] [PATCH v4 0/8] Introduce event vectorization

From: Pavan Nikhilesh In traditional event programming model, events are identified by a flow-id and a uintptr_t. The flow-id uniquely identifies a given event and determines the order of scheduling based on schedule type, the uintptr_t holds a single object. Event devices also support burst mod

[dpdk-dev] [PATCH v4 1/8] eventdev: introduce event vector capability

From: Pavan Nikhilesh Introduce rte_event_vector datastructure which is capable of holding multiple uintptr_t of the same flow thereby allowing applications to vectorize their pipeline and reducing the complexity of pipelining the events across multiple stages. This approach also reduces the sche

Re: [dpdk-dev] [PATCH 3/3] drivers: align log names

On Wed, Mar 10, 2021 at 6:01 AM Thomas Monjalon wrote: > > The log levels are configured by using the name of the logs. > Some drivers are aligned to follow a common log name standard: > pmd.class.driver[.sub] > Some "common" drivers skip the "class" part: > pmd.driver.sub > > Sign

Re: [dpdk-dev] [PATCH 3/3] drivers: align log names

On Fri, Mar 19, 2021 at 6:15 PM Thomas Monjalon wrote: > > 19/03/2021 17:29, David Marchand: > > On Wed, Mar 10, 2021 at 3:02 PM Thomas Monjalon wrote: > > > > > > The log levels are configured by using the name of the logs. > > > Some drivers are aligned to follow a common log name standard: > >

[dpdk-dev] [PATCH] devtools: check logtype format

Enforce that added logtypes follow the convention: - for lib/librte_XXX: lib.XXX and lib.XXX.* - for drivers/class/XXX: pmd.class.XXX and pmd.class.XXX.* Signed-off-by: David Marchand --- devtools/checkpatches.sh | 44 1 file changed, 44 insertions(+) di

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: replace callback getting filter operations

15/03/2021 10:15, Thomas Monjalon: > 15/03/2021 10:08, Andrew Rybchenko: > > On 3/15/21 11:55 AM, Thomas Monjalon wrote: > > > 15/03/2021 09:43, Andrew Rybchenko: > > >> On 3/15/21 10:54 AM, Thomas Monjalon wrote: > > >>> 15/03/2021 08:18, Andrew Rybchenko: > > On 3/12/21 8:46 PM, Thomas Monja

Re: [dpdk-dev] [PATCH v2 4/6] net/ngbe: add device init and uninit

On Fri, 19 Mar 2021 15:26:26 +0800 Jiawen Wu wrote: > +++ b/drivers/net/ngbe/base/ngbe_osdep.h > @@ -0,0 +1,172 @@ > +#define false 0 > +#define true1 These will conflict with normal definitions in Why are you not using that? > +#define min(a, b)RTE_MIN(a, b)

Re: [dpdk-dev] [RFC 0/4] SocketPair Broker support for vhost and virtio-user.

On Fri, Mar 19, 2021 at 04:29:21PM +0100, Ilya Maximets wrote: > On 3/19/21 3:05 PM, Stefan Hajnoczi wrote: > > On Thu, Mar 18, 2021 at 08:47:12PM +0100, Ilya Maximets wrote: > >> On 3/18/21 6:52 PM, Stefan Hajnoczi wrote: > >>> On Wed, Mar 17, 2021 at 09:25:26PM +0100, Ilya Maximets wrote: >

Re: [dpdk-dev] [PATCH 3/3] drivers: align log names

19/03/2021 17:29, David Marchand: > On Wed, Mar 10, 2021 at 3:02 PM Thomas Monjalon wrote: > > > > The log levels are configured by using the name of the logs. > > Some drivers are aligned to follow a common log name standard: > > pmd.class.driver[.sub] > > Some "common" drivers skip the "

[dpdk-dev] [PATCH v2] app/test-pmd: enable testpmd on windows

From: Jie Zhou This patch is to enable testpmd on windows. It mainly includes: - Enable building libraries on Windows that TestPMD depends on - Enable building testpmd on Windows - Resolve name collisions with Windows types - Add clock_gettime_monotic for testpmd on Windows - Make printf format w

Re: [dpdk-dev] [PATCH 2/3] examples/ipsec-secgw: add UDP encapsulation support

Hi, > Adding lookaside IPsec UDP encapsulation support > for NAT traversal. > Added --udp-encap option for application to specify > if UDP encapsulation need to be enabled. > Example secgw command with UDP encapsultation enabled: > -c 0x1 -- -P -p 0x1 --config "(0,0,0)" -f ep0.cfg --udp-encap Ca

Re: [dpdk-dev] [RFC 0/4] SocketPair Broker support for vhost and virtio-user.

On 3/19/21 5:11 PM, Ilya Maximets wrote: > On 3/19/21 3:39 PM, Stefan Hajnoczi wrote: >> Hi Ilya, >> By the way, it's not clear to me why dpdkvhostuser is deprecated. If OVS >> is restarted then existing vhost-user connections drop with an error but >> QEMU could attempt to reconnect to the UNIX do

Re: [dpdk-dev] [PATCH 3/3] drivers: align log names

On Wed, Mar 10, 2021 at 3:02 PM Thomas Monjalon wrote: > > The log levels are configured by using the name of the logs. > Some drivers are aligned to follow a common log name standard: > pmd.class.driver[.sub] > Some "common" drivers skip the "class" part: > pmd.driver.sub Without

Re: [dpdk-dev] [RFC 0/4] SocketPair Broker support for vhost and virtio-user.

On 3/19/21 3:39 PM, Stefan Hajnoczi wrote: > Hi Ilya, > By the way, it's not clear to me why dpdkvhostuser is deprecated. If OVS > is restarted then existing vhost-user connections drop with an error but > QEMU could attempt to reconnect to the UNIX domain socket which the new > OVS instance will s

Re: [dpdk-dev] Questions about keeping CRC

On Fri, 19 Mar 2021 20:13:20 +0800 "Min Hu (Connor)" wrote: > Hi, all, > DPDK has introduced one offload: DEV_RX_OFFLOAD_KEEP_CRC. It means that > the device has the ablility of keeping CRC（four bytes at the end of > packet）of packet in RX. > In common scenarios, When one packet ent

Re: [dpdk-dev] [RFC 0/4] SocketPair Broker support for vhost and virtio-user.

Hi On Fri, Mar 19, 2021 at 7:37 PM Ilya Maximets wrote: > On 3/19/21 3:16 PM, Stefan Hajnoczi wrote: > > On Thu, Mar 18, 2021 at 09:14:27PM +0100, Ilya Maximets wrote: > >> On 3/18/21 8:47 PM, Ilya Maximets wrote: > >>> On 3/18/21 6:52 PM, Stefan Hajnoczi wrote: > On Wed, Mar 17, 2021 at 09

Re: [dpdk-dev] [RFC 0/4] SocketPair Broker support for vhost and virtio-user.

On Fri, Mar 19, 2021 at 04:37:01PM +0100, Ilya Maximets wrote: > On 3/19/21 3:16 PM, Stefan Hajnoczi wrote: > > On Thu, Mar 18, 2021 at 09:14:27PM +0100, Ilya Maximets wrote: > >> On 3/18/21 8:47 PM, Ilya Maximets wrote: > >>> On 3/18/21 6:52 PM, Stefan Hajnoczi wrote: > On Wed, Mar 17, 2021 a

Re: [dpdk-dev] [PATCH v7 06/17] drivers: replace page size definitions with function

> -Original Message- > From: Thomas Monjalon > Sent: Friday, March 19, 2021 9:57 AM > To: dev@dpdk.org > Cc: nc...@alpinelinux.org; Andrew Boyer ; Andrew > Rybchenko ; David Marchand > ; Burakov, Anatoly > ; Stephen Hemminger > ; Long Li ; Jay Zhou > ; McDaniel, Timothy > ; Rasesh Mody

Re: [dpdk-dev] [PATCH v7 15/17] event/dlb: fix header includes for musl

> -Original Message- > From: Thomas Monjalon > Sent: Friday, March 19, 2021 9:57 AM > To: dev@dpdk.org > Cc: nc...@alpinelinux.org; sta...@dpdk.org; Andrew Rybchenko > ; David Marchand > ; McDaniel, Timothy > ; Gage Eads > Subject: [PATCH v7 15/17] event/dlb: fix header includes for mu

Re: [dpdk-dev] [RFC 0/4] SocketPair Broker support for vhost and virtio-user.

On 3/19/21 3:16 PM, Stefan Hajnoczi wrote: > On Thu, Mar 18, 2021 at 09:14:27PM +0100, Ilya Maximets wrote: >> On 3/18/21 8:47 PM, Ilya Maximets wrote: >>> On 3/18/21 6:52 PM, Stefan Hajnoczi wrote: On Wed, Mar 17, 2021 at 09:25:26PM +0100, Ilya Maximets wrote: BTW what is the security mo

Re: [dpdk-dev] [RFC 0/4] SocketPair Broker support for vhost and virtio-user.

On 3/19/21 3:05 PM, Stefan Hajnoczi wrote: > On Thu, Mar 18, 2021 at 08:47:12PM +0100, Ilya Maximets wrote: >> On 3/18/21 6:52 PM, Stefan Hajnoczi wrote: >>> On Wed, Mar 17, 2021 at 09:25:26PM +0100, Ilya Maximets wrote: And some housekeeping usually required for applications in case the

Re: [dpdk-dev] [PATCH v2] bus/pci: fix Windows kernel driver categories

18/03/2021 23:07, Ranjit Menon: > On 3/18/2021 3:48 AM, Thomas Monjalon wrote: > > In Windows probing, the value RTE_PCI_KDRV_NONE was used > > instead of RTE_PCI_KDRV_UNKNOWN. > > This value covers the mlx case where the kernel driver is in place, > > offering a bifurcated mode to the userspace dr

Re: [dpdk-dev] [PATCH] eal: mark version parts API as experimental

18/03/2021 13:29, Bruce Richardson: > On Wed, Mar 17, 2021 at 04:15:35PM +0100, Thomas Monjalon wrote: > > Some functions were introduced in DPDK 21.05 to query the version parts > > (prefix, year, month, minor, suffix, release) at runtime. > > Per guidelines, these new public functions must be mar

[dpdk-dev] [PATCH v7 17/17] examples/bbdev: fix header include for musl

The header file unistd.h should not be included from sys/ directory, it is an error with musl libc. Fixes: 1ffee690eaa1 ("examples/bbdev: add sample app") Cc: sta...@dpdk.org Signed-off-by: Thomas Monjalon Acked-by: Andrew Rybchenko Acked-by: David Marchand --- examples/bbdev_app/main.c | 2 +

[dpdk-dev] [PATCH v7 16/17] app/testpmd: fix build with musl

From: Natanael Copa 1/ Improve portability by avoiding use of non-standard 'uint'. Use uint8_t for hash_key_len as rss_key_len is a uint8_t type. This solves following build error when building with musl libc: app/test-pmd/testpmd.h:813:29: error: unknown type name 'uint' 2/ In musl libc, st

[dpdk-dev] [PATCH v7 15/17] event/dlb: fix header includes for musl

The header file fcntl.h should not be included from sys/ directory as done in dlb drivers, it is an error with musl libc. Fixes: 19980083fd57 ("event/dlb: add eventdev probe") Fixes: 5433956d5185 ("event/dlb2: add eventdev probe") Cc: sta...@dpdk.org Signed-off-by: Thomas Monjalon Acked-by: Andr

[dpdk-dev] [PATCH v7 14/17] vdpa/mlx5: replace pthread functions unavailable in musl

1/ The function pthread_yield() does not exist in musl libc, and can be replaced with sched_yield() after including sched.h. 2/ The function pthread_attr_setaffinity_np() does not exist in musl libc, and can be replaced with pthread_setaffinity_np() after pthread_create(). Fixes: b7fa0bf4d5c6 ("v

[dpdk-dev] [PATCH v7 13/17] net/igc: remove use of uint type

Improve portability (especially with musl libc) by replacing the non-standard type 'uint' with 'size_t'. Fixes: 746664d546fb ("net/igc: support flow API") Cc: sta...@dpdk.org Suggested-by: David Marchand Signed-off-by: Thomas Monjalon Acked-by: Haiyue Wang Acked-by: Andrew Rybchenko Acked-by:

[dpdk-dev] [PATCH v7 12/17] net/cxgbe: remove use of uint type

From: Natanael Copa Improve portability by replacing non-standard 'uint' with 'unsigned int'. This solves the build error with musl libc: In file included from ../drivers/net/cxgbe/cxgbe.h:9, from ../drivers/net/cxgbe/cxgbe_ethdev.c:37: ../drivers/net/cxgbe/base/common.h:201:4:

[dpdk-dev] [PATCH v7 11/17] bus/pci: support I/O port operations with musl

Add a fallback for non-GNU libc systems like musl libc for the non-standard functions outl_p, outw_p and outb_p. It solves the following errors when building with musl libc: pci_uio.c: undefined reference to 'outw_p' pci_uio.c: undefined reference to 'outl_p' pci_uio.c: und

[dpdk-dev] [PATCH v7 10/17] bus/dpaa: fix build with musl

From: Natanael Copa The header files argp.h and error.h do not exist in musl libc. Fix build with musl libc by using err(3) instead of the GNU-specific error(3). We could have used the identical errx("...: %s", strerror(ret))` but strerror(3) is not thread-safe and the strerror_r variant has tw

[dpdk-dev] [PATCH v7 09/17] bus/dpaa: fix 64-bit arch detection

From: Natanael Copa There is no standard saying that __WORDSIZE should be be defined or in what include it should be defined. Use RTE_ARCH_64 instead. This solves a warning when building with musl libc: warning: "__WORDSIZE" is not defined, evaluates to 0 [-Wundef] Fixes: 847ee3bd0d1f ("bus/d

[dpdk-dev] [PATCH v7 08/17] common/dpaax/caamflib: simplify log macros

From: Natanael Copa Simplify pr_debug, pr_err and pr_warn macros by adding an intermediate pr_msg macro. This way we only need to test for SUPPRESS_PRINTS once. Signed-off-by: Natanael Copa Acked-by: Hemant Agrawal Acked-by: Andrew Rybchenko Acked-by: David Marchand --- drivers/common/dpaax

[dpdk-dev] [PATCH v7 07/17] common/dpaax/caamflib: fix build with musl

From: Natanael Copa The swab16/swab32/swab64 are Linux specific and not GNU libc specific. Keep the check for __GLIBC__ just in case other GNU systems depends on this (Hurd or GNU/kFreeBSD). This fixes a build error with musl libc. Fixes: 04711d41a872 ("crypto/dpaa2_sec: add run-time assembler

[dpdk-dev] [PATCH v7 06/17] drivers: replace page size definitions with function

The page size is often retrieved from the macro PAGE_SIZE. If PAGE_SIZE is not defined, it is either using hard coded default, or getting the system value from the UNIX-only function sysconf(). Such definitions are replaced with the generic function rte_mem_page_size() defined for each supported O

[dpdk-dev] [PATCH v7 05/17] eal: fix build with musl

In musl libc, cpu_set_t is defined only if _GNU_SOURCE is defined. In case _GNU_SOURCE is undefined, as in eal_common_errno.c, it was not possible to include rte_os.h which uses cpu_set_t. This limitation is removed: if CPU_SETSIZE is not defined, cpu_set_t related definitions and functions are sk

[dpdk-dev] [PATCH v7 04/17] build: remove redundant _GNU_SOURCE definitions

The feature macro _GNU_SOURCE is defined globally, but there was some remaining useless settings. The internal definition in config/meson.build is kept, all other internal definitions of _GNU_SOURCE are removed, except in examples, which can be built as external applications. Note: external applic

[dpdk-dev] [PATCH v7 03/17] build: detect execinfo library on Linux

The library execinfo and its header file can be installed on Alpine Linux where the backtrace feature is not part of musl libc: apk add libexecinfo-dev As a consequence, this library should not be restricted to BSD only. At the same time, the library and header are detected once and added

[dpdk-dev] [PATCH v7 02/17] buildtools: fix build with busybox

If using busybox for mktemp and awk (as in Alpine), some bugs prevent the script from running: 1/ It seems busybox mktemp requires the pattern to have at least 6 X and no other suffix. The same has been fixed for other scripts in the past: commit 3771edc35438 ("buildtools: fix build for some mktem

[dpdk-dev] [PATCH v7 01/17] eal: fix comment of OS-specific header files

The same comment is on top of each rte_os.h file. It is reworded to remove the mention of "future releases". Fixes: 428eb983f5f7 ("eal: add OS specific header file") Cc: sta...@dpdk.org Signed-off-by: Thomas Monjalon Acked-by: Andrew Rybchenko Acked-by: David Marchand --- lib/librte_eal/freeb

[dpdk-dev] [PATCH v7 00/17] Alpine/musl build support

These patches fix some build errors/warning for Alpine Linux, using musl and busybox. Few improvements are added on the way. The goal is to run a container with the following Dockerfile: 8< FROM alpine # DPDK prerequisites RUN apk --no-cache add \ gcc libc-dev bsd-compat-headers

Re: [dpdk-dev] [RFC 0/4] SocketPair Broker support for vhost and virtio-user.

Hi Ilya, By the way, it's not clear to me why dpdkvhostuser is deprecated. If OVS is restarted then existing vhost-user connections drop with an error but QEMU could attempt to reconnect to the UNIX domain socket which the new OVS instance will set up. Why is it impossible to reconnect when OVS ow

[dpdk-dev] [PATCH] pipeline: fix translation for mailbox fields

Fix to make the translation of extern object & function mailbox fields (e.ext_obj.field and f.ext_func.field) work for the add/sub, shl/shr, jmplt/jmpgt instructions. Fixes: baf7999303d0 ("pipeline: introduce SWX add instruction") Fixes: c88c62943818 ("pipeline: introduce SWX subtract instruction"

Re: [dpdk-dev] [PATCH] test: make hugepage check more robust under Linux

David Marchand writes: > On Wed, Mar 17, 2021 at 3:44 PM Aaron Conole wrote: >> diff --git a/app/test/has-hugepage.sh b/app/test/has-hugepage.sh >> index d600fad319..1c3cfb665a 100755 >> --- a/app/test/has-hugepage.sh >> +++ b/app/test/has-hugepage.sh >> @@ -3,7 +3,17 @@ >> # Copyright 2020 Mel

Re: [dpdk-dev] [RFC 0/4] SocketPair Broker support for vhost and virtio-user.

On Thu, Mar 18, 2021 at 09:14:27PM +0100, Ilya Maximets wrote: > On 3/18/21 8:47 PM, Ilya Maximets wrote: > > On 3/18/21 6:52 PM, Stefan Hajnoczi wrote: > >> On Wed, Mar 17, 2021 at 09:25:26PM +0100, Ilya Maximets wrote: > >> BTW what is the security model of the broker? Unlike pathname UNIX > >> d

Re: [dpdk-dev] [RFC 0/4] SocketPair Broker support for vhost and virtio-user.

On Thu, Mar 18, 2021 at 08:47:12PM +0100, Ilya Maximets wrote: > On 3/18/21 6:52 PM, Stefan Hajnoczi wrote: > > On Wed, Mar 17, 2021 at 09:25:26PM +0100, Ilya Maximets wrote: > >> And some housekeeping usually required for applications in case the > >> socket server terminated abnormally and socket

Re: [dpdk-dev] [RFC 3/5] eal: lcore state FINISHED is not required

Hi everyone, > > > > > > > > > > Subject: [RFC 3/5] eal: lcore state FINISHED is not required > > > > > > > > > > FINISHED state seems to be used to indicate that the worker's > > > > > update of the 'state' is not visible to other threads. There seems > > > > > to be no requirement to have su

Re: [dpdk-dev] [PATCH] test: make hugepage check more robust under Linux

On Wed, Mar 17, 2021 at 3:44 PM Aaron Conole wrote: > diff --git a/app/test/has-hugepage.sh b/app/test/has-hugepage.sh > index d600fad319..1c3cfb665a 100755 > --- a/app/test/has-hugepage.sh > +++ b/app/test/has-hugepage.sh > @@ -3,7 +3,17 @@ > # Copyright 2020 Mellanox Technologies, Ltd > > if [

Re: [dpdk-dev] [PATCH v16 1/3] build: disable/enable drivers in Arm builds

On Fri, Mar 19, 2021 at 6:51 PM Juraj Linkeš wrote: > > > > > > > > > > > > The blocklist is, I think, agreed upon by everyone. The > > > > > > > > > question is whether we want to support the allowlist > > > > > > > > > alongside it and there seem to be enough reasons to do that. > > > > > > > >

Re: [dpdk-dev] [PATCH v16 1/3] build: disable/enable drivers in Arm builds

> > > > > > > > The blocklist is, I think, agreed upon by everyone. The > > > > > > > > question is whether we want to support the allowlist > > > > > > > > alongside it and there seem to be enough reasons to do that. > > > > > > > Sorry, may be this is answered already, but, what additional > >

[dpdk-dev] Questions about keeping CRC

Hi, all, DPDK has introduced one offload: DEV_RX_OFFLOAD_KEEP_CRC. It means that the device has the ablility of keeping CRC（four bytes at the end of packet）of packet in RX. In common scenarios, When one packet enter into NIC device, NIC will check the CRC and then strip the CRC，at last

[dpdk-dev] [PATCH] port: add file descriptor SWX port

Add the file descriptor input/output port type for the SWX pipeline. Signed-off-by: Venkata Suresh Kumar P Signed-off-by: Churchill Khangar Acked-by: Cristian Dumitrescu Depends-on: patch-87498 ("port: add ring SWX port") --- doc/api/doxy-api-index.md | 1 + examples/pipeline/cli.c

Re: [dpdk-dev] [RFC 0/4] SocketPair Broker support for vhost and virtio-user.

On 3/19/21 9:51 AM, Marc-André Lureau wrote: > Hi > > On Thu, Mar 18, 2021 at 11:47 PM Ilya Maximets > wrote: > > On 3/18/21 6:52 PM, Stefan Hajnoczi wrote: > > On Wed, Mar 17, 2021 at 09:25:26PM +0100, Ilya Maximets wrote: > > Hi, > > Some questions to

Re: [dpdk-dev] [PATCH v3 10/15] bus/dpaa: use warn(3) instead of error(3) to improve portability

10/07/2020 07:13, Hemant Agrawal: > NAK > error is different from warning - the return value is also not carried. It seems this comment has been ignored so far. I will address it in a v7.

Re: [dpdk-dev] [PATCH] examples/vhost: fix unchecked return value

On 2/19/21 3:40 AM, Chenbo Xia wrote: > This patch fixes unchecked return value for rte_vhost_get_mem_table(), > which is reported by coverity. > > Coverity issue: 364233 > Fixes: ca059fa5e290 ("examples/vhost: demonstrate the new generic APIs") > Cc: sta...@dpdk.org > > Signed-off-by: Chenbo

Re: [dpdk-dev] [PATCH 2/2] qede: make driver accept bigger rss tables

> IMO, it will be better if the log message also states that RSS key is trimmed > to 'len' size. Resent v2, thanks. Devendra, please take these two patches into our internal codebase as well. Igor

[dpdk-dev] [PATCH v2 2/2] qede: make driver accept bigger rss tables

We found some dpdk applications blindly pass fixed side rss hash tables, and do not check driver/device capabilities. Moreover, many other drivers do not do such a strong check as well. So here we fix it, making qede accept any size rss_key. For larger key tables we just crop it with notice trace

[dpdk-dev] [PATCH v2 1/2] qede: reduce trace verbosity level

On some hardware units it was found this trace is flooding the output, making any dpdk interactive usage kind of problematic. It is only informational, without any consequences handling, so reducing it to verbose from explicit notice level. CC: sta...@dpdk.org Acked-by: Devendra Singh Rawat Sign

[dpdk-dev] [PATCH v2 0/2] qede: 2020-02 minor fixes

Two small fixes after customer feedback. v2: improved abit log message Igor Russkikh (2): qede: reduce trace verbosity level qede: make driver accept bigger rss tables drivers/net/qede/base/ecore_int.c | 2 +- drivers/net/qede/qede_ethdev.c| 6 -- 2 files changed, 5 insertions(+), 3

Re: [dpdk-dev] [PATCH v3 11/11] app/testpmd: fix usage text

19/03/2021 09:59, Li, Xiaoyun: > The patch looks good to me. But I found one issue. > "--tx-ip=SRC,DST | --tx-udp=PORT " These 2 parameters are missing in the > detailed usage text below. > > And out of curiosity, I compared the detailed usage items and lgopts in > launch_args_parse() > There ar

[dpdk-dev] [PATCH 2/2] net/iavf: fix lack of MAC type when set MAC address

When set default MAC address, use type VIRTCHNL_ETHER_ADDR_PRIMARY as this case is changing device/primary unicast MAC. For other cases, such as adding or deleting extra unicast addresses and multicast addresses, use type VIRTCHNL_ETHER_ADDR_EXTRA. Fixes: cb25d4323fbf ("net/avf: enable MAC VLAN an

[dpdk-dev] [PATCH 1/2] net/i40e: fix lack of MAC type when set MAC address

Currently, there is no way for a VF driver to specify that it wants to change its device/primary unicast MAC address. This makes it difficult/impossible for the PF driver to track the VF's device/primary unicast MAC address, which is used for VM/VF reboot and displaying on the host. Fix this by usi

[dpdk-dev] [PATCH 0/2] fix lack of MAC type when set MAC address

Fix lack of MAC type when set MAC address in i40evf and iavf PMD. Robin Zhang (2): net/i40e: fix lack of MAC type when set MAC address net/iavf: fix lack of MAC type when set MAC address drivers/net/i40e/base/virtchnl.h | 29 +- drivers/net/i40e/i40e_ethdev_vf.c | 91 +++

Re: [dpdk-dev] [PATCH] examples/vhost_crypto: remove unused short option

On 2/4/21 9:05 AM, Ibtisam Tariq wrote: > Short option "s" was passed to getopt_long function, while there was > no condition on this option. > > Fixes: f5188211c7 ("examples/vhost_crypto: add sample application") > Cc: roy.fan.zh...@intel.com > > Signed-off-by: Ibtisam Tariq > --- > example

Re: [dpdk-dev] [PATCH] examples/vhost_blk: check protocol feature before get inflight info

Hi Keiichi, On 2/2/21 10:10 AM, Keiichi Watanabe wrote: > Avoid calling rte_vhost_get_vhost_ring_inflight() and > rte_vhost_get_vring_base_from_inflight() when > VHOST_USER_PROTOCOL_F_INFLIGHT_SHMFD is not set. > > Signed-off-by: Keiichi Watanabe > --- > examples/vhost_blk/vhost_blk.c | 22

Re: [dpdk-dev] [PATCH v3 11/11] app/testpmd: fix usage text

Hi > -Original Message- > From: Thomas Monjalon > Sent: Saturday, March 13, 2021 02:17 > To: dev@dpdk.org > Cc: david.march...@redhat.com; Richardson, Bruce > ; m...@smartsharesystems.com; Li, Xiaoyun > > Subject: [PATCH v3 11/11] app/testpmd: fix usage text > > The options help text wa

Re: [dpdk-dev] [RFC 0/4] SocketPair Broker support for vhost and virtio-user.

Hi On Thu, Mar 18, 2021 at 11:47 PM Ilya Maximets wrote: > On 3/18/21 6:52 PM, Stefan Hajnoczi wrote: > > On Wed, Mar 17, 2021 at 09:25:26PM +0100, Ilya Maximets wrote: > > Hi, > > Some questions to understand the problems that SocketPair Broker solves: > > > >> Even more configuration tricks re

Re: [dpdk-dev] [PATCH v1 4/4] net/iavf: support FDIR for IP fragment packet

Hi > -Original Message- > From: Guo, Jia > Sent: Wednesday, March 17, 2021 11:12 > To: or...@nvidia.com; Zhang, Qi Z ; Xing, Beilei > ; Li, Xiaoyun ; Wu, Jingjing > > Cc: Zhang, Yuying ; Xu, Ting ; > dev@dpdk.org; Guo, Jia > Subject: [PATCH v1 4/4] net/iavf: support FDIR for IP fragment

Re: [dpdk-dev] [PATCH] net/bnxt: check return value

On Thu, Mar 18, 2021 at 5:17 PM Ajit Khaparde wrote: > > Check return value of rte_kvargs_process() > > Coverity issue: 357765 > > Fixes: ba404aacc5cf ("net/bnxt: set maximum flow count") > Fixes: 02a95625fe9c ("net/bnxt: add flow stats in extended stats") > Fixes: 7b0940653720 ("net/bnxt: support

Re: [dpdk-dev] [PATCH 1/1] net/bnxt: fix handling of null flow mask

On Thu, Mar 18, 2021 at 12:52 PM Lance Richardson wrote: > > When the mask field of an rte_flow pattern item is NULL, > the default mask for that item type should be used. > > Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter ops") > Cc: sta...@dpdk.org > > Signed-off-by: Lance Richardson Patch

Re: [dpdk-dev] [PATCH 1/1] net/bnxt: fix transmit length hint threshold

On Thu, Mar 18, 2021 at 12:52 PM Lance Richardson wrote: > > Use correct threshold when selecting "greater than or equal to > 2K" length hint. > > Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code") > Cc: sta...@dpdk.org > > Signed-off-by: Lance Richardson > Reviewed-by: Ajit Kumar Khaparde >

Re: [dpdk-dev] [PATCH 1/1] net/bnxt: fix Rx buffer posting

On Thu, Mar 18, 2021 at 12:52 PM Lance Richardson wrote: > > Remove early buffer posting logic from burst receive loop to address > several issues: >- Posting receive descriptors without first posting completion > entries risks overflowing the completion queue. >- Posting receive desc

[dpdk-dev] [PATCH v2 6/6] net/ngbe: define registers

Define all registers that will be used. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_regs.h | 1489 + drivers/net/ngbe/base/ngbe_type.h |2 + 2 files changed, 1491 insertions(+) create mode 100644 drivers/net/ngbe/base/ngbe_regs.h diff --git a/drivers

[dpdk-dev] [PATCH v2 2/6] net/ngbe: add device IDs

Add device IDs for Wangxun 1Gb NICs, and register rte_ngbe_pmd. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/meson.build | 18 +++ drivers/net/ngbe/base/ngbe_devids.h | 83 + drivers/net/ngbe/meson.build| 6 +++ drivers/net/ngbe/ngbe_ethdev.c

[dpdk-dev] [PATCH v2 5/6] net/ngbe: add log type and error type

Add log type and error type to trace functions. Signed-off-by: Jiawen Wu --- doc/guides/nics/ngbe.rst| 20 + drivers/net/ngbe/base/ngbe_status.h | 124 drivers/net/ngbe/base/ngbe_type.h | 1 + drivers/net/ngbe/ngbe_ethdev.c | 16 drive

[dpdk-dev] [PATCH v2 3/6] net/ngbe: support probe and remove

Add basic PCIe ethdev probe and remove. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/ngbe.ini | 1 + drivers/net/ngbe/ngbe_ethdev.c| 77 +-- 2 files changed, 75 insertions(+), 3 deletions(-) diff --git a/doc/guides/nics/features/ngbe.ini b/doc/guides/n

[dpdk-dev] [PATCH v2 4/6] net/ngbe: add device init and uninit

Add basic init and uninit function. Map device IDs and subsystem IDs to single ID for easy operation. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/meson.build | 4 +- drivers/net/ngbe/base/ngbe.h | 11 ++ drivers/net/ngbe/base/ngbe_hw.c| 59 ++ drivers/net/ngbe/base/

[dpdk-dev] [PATCH v2 1/6] net/ngbe: add build and doc infrastructure

Adding bare minimum PMD library and doc build infrastructure and claim the maintainership for ngbe PMD. Signed-off-by: Jiawen Wu --- MAINTAINERS| 6 ++ doc/guides/nics/features/ngbe.ini | 10 + doc/guides/nics/index.rst | 1 + doc/guide

[dpdk-dev] [PATCH v2 0/6] net: ngbe PMD

This patch set provides a skeleton of ngbe PMD, which adapted to Wangxun WX1860 series NICs. v2: - Correct some clerical errors. - Use ethdev debug flags instead of driver own Jiawen Wu (6): net/ngbe: add build and doc infrastructure net/ngbe: add device IDs net/ngbe: support probe and remo

[dpdk-dev] [PATCH v2] examples/packet_ordering: use local port config

From: Dapeng Yu A global ethernet port configuration is assigned to local variable because in this way the local variable may be updated as required. But this local variable is not used as input of rte_eth_dev_configure() in original implementation, and cause that fast mbuf free feature cannot be