Re: [dpdk-dev] [PATCH v2] app/test-pmd: enable testpmd on windows

2021-03-20 Thread Dmitry Kozlyuk
2021-03-19 09:51 (UTC-0700), Jie Zhou: > Issue under active investigation: > - Recent DPDK upstream change "eal: detach memsegs on cleanup" exposed > failure at eal exit with "EAL: Could not unmap memory: No Error". > Investigating KERNELBASE!UnmapViewOfFile. The issue will cause system > cra

Re: [dpdk-dev] [PATCH] net/octeontx2: add support for rte_flow_item_raw

2021-03-20 Thread Jerin Jacob
On Fri, Mar 19, 2021 at 10:14 AM wrote: > > From: Satheesh Paul > > Add support for rte_flow_item_raw to parse custom L2 and L3 protocols. > > Signed-off-by: Satheesh Paul Acked-by: Jerin Jacob Applied to dpdk-next-net-mrvl/for-main. Thanks

Re: [dpdk-dev] [PATCH 4/4] event/octeontx2: timer always use virtual counter

2021-03-20 Thread Jerin Jacob
On Thu, Feb 25, 2021 at 5:53 PM wrote: > > From: Pavan Nikhilesh > > Use virtual counter for estimating current bucket as PMU cannot be > reliably used to estimate time. > > Signed-off-by: Pavan Nikhilesh > > +#ifdef RTE_ARCH_ARM64 > +static inline uint64_t > +tim_cntvct(void) > +{ > + ui

Re: [dpdk-dev] [PATCH 3/4] event/octeontx2: reduce chunk pool memory usage

2021-03-20 Thread Jerin Jacob
On Thu, Feb 25, 2021 at 5:53 PM wrote: > > From: Pavan Nikhilesh > > Reduce amount of memory used by chunk pool when the mempool used > is OCTEONTX2 NPA. Please describe the existing and new memory allocation schemes. > > Signed-off-by: Pavan Nikhilesh > --- > drivers/event/octeontx2/otx2_ti

Re: [dpdk-dev] [EXT] Re: [PATCH 0/8] Optimize qede use of rx/tx_entries

2021-03-20 Thread Jerin Jacob
On Wed, Mar 10, 2021 at 12:13 PM Igor Russkikh wrote: > > > > > On Fri, Mar 5, 2021 at 6:44 PM Balazs Nemeth wrote: > >> > >> This patch set optimizes qede_{rx,tx}_entry and introduces > >> rte_pktmbuf_free_bulk in qede_process_tx_compl. The overall performance > >> improvement depends on the use

Re: [dpdk-dev] [PATCH v2 2/2] qede: make driver accept bigger rss tables

2021-03-20 Thread Jerin Jacob
On Fri, Mar 19, 2021 at 3:17 PM Igor Russkikh wrote: > > We found some dpdk applications blindly pass fixed side rss hash tables, Could you rewrite the git commit by removing "We". > and do not check driver/device capabilities. > > Moreover, many other drivers do not do such a strong check as we

[dpdk-dev] [PATCH v6 4/5] net: provide IP-related API on any OS

2021-03-20 Thread Dmitry Kozlyuk
Users of relied on it to provide IP-related defines, like IPPROTO_* constatns, but still had to include POSIX headers for inet_pton() and other standard IP-related facilities. Extend so that it is a single header to gain access to IP-related facilities on any OS. Use it to replace POSIX include

[dpdk-dev] [PATCH v6 5/5] net: replace Windows networking shim

2021-03-20 Thread Dmitry Kozlyuk
Remove networking shim from Windows EAL. Replace it with system headers with two workarounds: 1. Windows Sockets headers contain `#define s_addr S_un.S_addr`, which conflicts with `s_addr` field of `struct rte_ether_hdr`. Undefining this macro in had been breaking some usages of DPDK an

[dpdk-dev] [PATCH v6 3/5] eal: make OS shims internal

2021-03-20 Thread Dmitry Kozlyuk
DPDK code often relies on functions and macros that are not standard C, but are found on all platforms, even if by slightly different names. Windows provided macros or inline definitions for such symbols. However, when placed in public header, these symbols were unnecessarily exposed, breaking con

[dpdk-dev] [PATCH v6 1/5] eal: add sleep API

2021-03-20 Thread Dmitry Kozlyuk
POSIX sleep(3) is missing from Windows. Add generic rte_thread_sleep() to suspend current OS thread. Signed-off-by: Dmitry Kozlyuk Acked-by: Khoa To --- lib/librte_eal/common/eal_common_timer.c | 5 +++-- lib/librte_eal/include/rte_thread.h | 11 +++ lib/librte_eal/rte_eal_exports

[dpdk-dev] [PATCH v6 2/5] eal/windows: hide asprintf() shim

2021-03-20 Thread Dmitry Kozlyuk
Make asprintf(3) implementation for Windows private to EAL, so that it's hidden from external consumers. It is not exposed to internal consumers either, because they don't need asprintf() and also because callers from other modules would have no reliable way to free allocated memory. Signed-off-by

[dpdk-dev] [PATCH v6 0/5] eal/windows: do not expose POSIX symbols

2021-03-20 Thread Dmitry Kozlyuk
On Windows, EAL contains two sets of functions and macros for POSIX compatibility: and a networking shim (socket headers). The latter conflicts with system headers and should not exist. Exposing the former from EAL can break consumer own POSIX compatibility layer and is against standards in genera

[dpdk-dev] [PATCH v5 5/5] net: replace Windows networking shim

2021-03-20 Thread Dmitry Kozlyuk
Remove networking shim from Windows EAL. Replace it with system headers with two workarounds: 1. Windows Sockets headers contain `#define s_addr S_un.S_addr`, which conflicts with `s_addr` field of `struct rte_ether_hdr`. Undefining this macro in had been breaking some usages of DPDK an

[dpdk-dev] [PATCH v5 4/5] net: provide IP-related API on any OS

2021-03-20 Thread Dmitry Kozlyuk
Users of relied on it to provide IP-related defines, like IPPROTO_* constatns, but still had to include POSIX headers for inet_pton() and other standard IP-related facilities. Extend so that it is a single header to gain access to IP-related facilities on any OS. Use it to replace POSIX include

[dpdk-dev] [PATCH v5 3/5] eal: make OS shims internal

2021-03-20 Thread Dmitry Kozlyuk
DPDK code often relies on functions and macros that are not standard C, but are found on all platforms, even if by slightly different names. Windows provided macros or inline definitions for such symbols. However, when placed in public header, these symbols were unnecessarily exposed, breaking con

[dpdk-dev] [PATCH v5 2/5] eal/windows: hide asprintf() shim

2021-03-20 Thread Dmitry Kozlyuk
Make asprintf(3) implementation for Windows private to EAL, so that it's hidden from external consumers. It is not exposed to internal consumers either, because they don't need asprintf() and also because callers from other modules would have no reliable way to free allocated memory. Signed-off-by

[dpdk-dev] [PATCH v5 1/5] eal: add sleep API

2021-03-20 Thread Dmitry Kozlyuk
POSIX sleep(3) is missing from Windows. Add generic rte_thread_sleep() to suspend current OS thread. Signed-off-by: Dmitry Kozlyuk Acked-by: Khoa To --- lib/librte_eal/common/eal_common_timer.c | 5 +++-- lib/librte_eal/include/rte_thread.h | 11 +++ lib/librte_eal/rte_eal_exports

[dpdk-dev] [PATCH v5 0/5] eal/windows: do not expose POSIX symbols

2021-03-20 Thread Dmitry Kozlyuk
On Windows, EAL contains two sets of functions and macros for POSIX compatibility: and a networking shim (socket headers). The latter conflicts with system headers and should not exist. Exposing the former from EAL can break consumer own POSIX compatibility layer and is against standards in genera

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: replace callback getting filter operations

2021-03-20 Thread Thomas Monjalon
20/03/2021 08:54, Andrew Rybchenko: > On 3/19/21 9:12 PM, Thomas Monjalon wrote: > > 15/03/2021 10:15, Thomas Monjalon: > >> 15/03/2021 10:08, Andrew Rybchenko: > >>> On 3/15/21 11:55 AM, Thomas Monjalon wrote: > 15/03/2021 09:43, Andrew Rybchenko: > > On 3/15/21 10:54 AM, Thomas Monjalon

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: replace callback getting filter operations

2021-03-20 Thread Andrew Rybchenko
On 3/19/21 9:12 PM, Thomas Monjalon wrote: 15/03/2021 10:15, Thomas Monjalon: 15/03/2021 10:08, Andrew Rybchenko: On 3/15/21 11:55 AM, Thomas Monjalon wrote: 15/03/2021 09:43, Andrew Rybchenko: On 3/15/21 10:54 AM, Thomas Monjalon wrote: 15/03/2021 08:18, Andrew Rybchenko: On 3/12/21 8:46 P

Re: [dpdk-dev] [PATCH] devtools: check logtype format

2021-03-20 Thread Thomas Monjalon
19/03/2021 21:37, David Marchand: > Enforce that added logtypes follow the convention: > - for lib/librte_XXX: lib.XXX and lib.XXX.* > - for drivers/class/XXX: pmd.class.XXX and pmd.class.XXX.* What about common drivers which skip the "common" part: pmd.XXX?