[dpdk-dev] [PATCH v2 0/2] pci: add rte prefix

2021-04-05 Thread Thomas Monjalon
Small namespace cleanups in PCI lib and bus driver. v2: - mark old macro with RTE_DEPRECATED - fix common/mlx5 Thomas Monjalon (2): pci: rename catch-all ID bus/pci: rename probe/remove operation types drivers/bus/pci/pci_common.c | 8 drivers/bus/pci/rte_bus_pci.h

[dpdk-dev] [PATCH v2 1/2] pci: rename catch-all ID

2021-04-05 Thread Thomas Monjalon
The name of the constant PCI_ANY_ID was missing RTE_ prefix. It is renamed, and the old name becomes a deprecated alias. While renaming, the duplicate definitions in rte_bus_pci.h are removed to keep only those in rte_pci.h. Note: rte_pci.h is included in rte_bus_pci.h Signed-off-by: Thomas Monja

[dpdk-dev] [PATCH v2 2/2] bus/pci: rename probe/remove operation types

2021-04-05 Thread Thomas Monjalon
The names of the prototypes pci_probe_t and pci_remove_t are missing a prefix rte_. These function types are simply renamed. No compatibility break is expected for the applications because it is considered as an internal name in the driver interface. Signed-off-by: Thomas Monjalon --- drivers/b

Re: [dpdk-dev] [PATCH 3/3] drivers: align log names

2021-04-05 Thread Thomas Monjalon
22/03/2021 11:33, David Marchand: > On Wed, Mar 10, 2021 at 3:02 PM Thomas Monjalon wrote: > > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c > > index 6a1b44bc77..bf7afe4610 100644 > > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > > @@ -

[dpdk-dev] [PATCH] net/mlx5: fix the drop action for the DR/DV

2021-04-05 Thread Viacheslav Ovsiienko
There are multiple branches in rdma-core library backing: the rte flows: - Verbs - Direct Verbs (DV) - Direct Rules (DR) The Verbs API always requires the specifying the queue even if there is the drop action in the flow, though the kernel optimizes out the actual queue usage for the flows c

[dpdk-dev] [PATCH v2 0/3] drivers: align log names

2021-04-05 Thread Thomas Monjalon
After working on the option "--log-level help", it became clear that few adjustments were required for the log registration of some drivers. v2: - align bonding and af_packet - make explicit the RTE_LOGTYPE_EAL default Thomas Monjalon (3): log: choose EAL log type on registration failure

[dpdk-dev] [PATCH v2 1/3] log: choose EAL log type on registration failure

2021-04-05 Thread Thomas Monjalon
In the unlikely case where something goes wrong while registering a log type, the fallback is to use the log type 0, assigned to EAL. Signed-off-by: Thomas Monjalon --- lib/librte_eal/include/rte_log.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_eal/include/rte_log.h b/lib/l

[dpdk-dev] [PATCH v2 2/3] drivers: fix log level after loading

2021-04-05 Thread Thomas Monjalon
When compiled as a shared object, and loaded at runtime as a plugin, the drivers should get the log level set earlier at EAL init by the user through --log-level option. The function for applying the log level setting is rte_log_register_type_and_pick_level(). It is called by most drivers via RTE_

[dpdk-dev] [PATCH v2 3/3] drivers: align log names

2021-04-05 Thread Thomas Monjalon
The log levels are configured by using the name of the logs. Some drivers are aligned to follow a common log name standard: pmd.class.driver[.sub] Some "common" drivers skip the "class" part: pmd.driver.sub Two drivers have exceptions to be clarified: pmd.vdpa.ifcvf instead

Re: [dpdk-dev] [PATCH v2 0/3] drivers: align log names

2021-04-05 Thread Thomas Monjalon
Sorry the name of the series should be "cleanup drivers log registration" 05/04/2021 12:02, Thomas Monjalon: > After working on the option "--log-level help", > it became clear that few adjustments were required > for the log registration of some drivers. > > v2: >- align bonding and af_packe

[dpdk-dev] [PATCH] net/mlx5: fix drop queue function declarations

2021-04-05 Thread Viacheslav Ovsiienko
There are some leftovers of removed code - there are no drop queue handling routines anymore. Fixes: 78be885295b8 ("net/mlx5: handle drop queues as regular queues") Cc: sta...@dpdk.org Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.h | 2 -- 1 file changed, 2 deletions(-) diff -

Re: [dpdk-dev] rte_flow ageing

2021-04-05 Thread Matan Azrad
Hi I will try to answer inline with prefix [MA]. From: David Bouyeure Sent: Tuesday, March 30, 2021 6:46 PM To: Asaf Penso ; dev@dpdk.org Cc: Matan Azrad ; Jack Min Subject: Re: [dpdk-dev] rte_flow ageing External email: Use caution opening links or attachments Thanks a lot Asaf, for your an

Re: [dpdk-dev] [PATCH 1/2] pci: rename catch-all ID

2021-04-05 Thread Parav Pandit
> From: dev On Behalf Of Thomas Monjalon > Sent: Thursday, April 1, 2021 4:04 AM > > The name of the constant PCI_ANY_ID was missing RTE_ prefix. > It is renamed, and the old name becomes a deprecated alias. > > While renaming, the duplicate definitions in rte_bus_pci.h are removed to > keep

Re: [dpdk-dev] [PATCH v2 1/2] common/mlx5: support device global syntax

2021-04-05 Thread Slava Ovsiienko
> -Original Message- > From: Xueming Li > Sent: Monday, January 18, 2021 17:27 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Matan Azrad ; Shahaf Shuler > ; NBU-Contact-Thomas Monjalon > ; Xueming(Steven) Li ; > Asaf Penso > Subject: [PATCH v2 1/2] common/mlx5: support device global syntax >

Re: [dpdk-dev] [PATCH v2 2/2] net/mlx5: support new global device syntax

2021-04-05 Thread Slava Ovsiienko
> -Original Message- > From: Xueming Li > Sent: Monday, January 18, 2021 17:27 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Matan Azrad ; Shahaf Shuler > ; NBU-Contact-Thomas Monjalon > ; Xueming(Steven) Li ; > Asaf Penso > Subject: [PATCH v2 2/2] net/mlx5: support new global device syntax

Re: [dpdk-dev] [PATCH v2 1/6] app/test: refactor of unit test suite runner

2021-04-05 Thread Aaron Conole
Ciara Power writes: > Some small changes were made to the unit test suite runner for > readability and to enable reuse of some of the function in a later patch. > > On test suite setup skip/fail, the loop to count testcases as > skipped/failed has been moved to another function. > This will allow

Re: [dpdk-dev] [PATCH v2 2/6] test: introduce parent testsuite format

2021-04-05 Thread Aaron Conole
Ciara Power writes: > The current structure for unit testing only allows for running a > test suite with nested test cases. This means all test cases for an > autotest must be in one suite, which is not ideal. > For example, in some cases we may want to run multiple lists of test > cases that eac

[dpdk-dev] [PATCH 0/6] net/mlx5: reduce Tx datapath compile time

2021-04-05 Thread Michael Baum
The mlx5_rxtx.c file contains a lot of Tx burst functions, each of those is performance-optimized for the specific set of requested offloads. These ones are generated on the basis of the template function and it takes significant time to compile, just due to a large number of giant functions gen

[dpdk-dev] [PATCH 3/6] net/mlx5: separate Tx function declarations to another file

2021-04-05 Thread Michael Baum
This patch separates Tx function declarations to different header file in preparation for removing their implementation from the source file and as an optional preparation for Tx cleanup. Signed-off-by: Michael Baum --- drivers/net/mlx5/linux/mlx5_mp_os.c | 1 + drivers/net/mlx5/linux/mlx5_os.

[dpdk-dev] [PATCH 1/6] net/mlx5: separate Rx function declarations to another file

2021-04-05 Thread Michael Baum
The mlx5_rxtx.c file contains a lot of Tx burst functions, each of those is performance-optimized for the specific set of requested offloads. These ones are generated on the basis of the template function and it takes significant time to compile, just due to a large number of giant functions genera

[dpdk-dev] [PATCH 6/6] net/mlx5: separate Tx burst functions to different files

2021-04-05 Thread Michael Baum
This patch separates Tx burst function implementations to different source files, thus allowing them to compile in parallel. Signed-off-by: Michael Baum --- drivers/net/mlx5/meson.build | 4 + drivers/net/mlx5/mlx5_rxtx.c | 201 --- drivers/net/mlx5/

[dpdk-dev] [PATCH 2/6] net/mlx5: separate Rx function implementations to new file

2021-04-05 Thread Michael Baum
This patch separates Rx function implementations to different source file as an optional preparation step for further consolidation of Rx burst functions. Signed-off-by: Michael Baum --- drivers/net/mlx5/meson.build |1 + drivers/net/mlx5/mlx5_rx.c | 1203 ++

[dpdk-dev] [PATCH 5/6] net/mlx5: separate Tx function implementations to new file

2021-04-05 Thread Michael Baum
This patch separates Tx function implementations to different source file as an optional preparation step for Tx cleanup. Signed-off-by: Michael Baum --- drivers/net/mlx5/meson.build | 1 + drivers/net/mlx5/mlx5_rxtx.c | 757 - drivers/net/mlx5/mlx5_tx.c

[dpdk-dev] [PATCH] net/mlx5/windows: fix link speed calculation

2021-04-05 Thread Tal Shnaiderman
In Windows DevX returns the value of the current link speed in bps rate, the conversion to the Mbps rate expected by DPDK is incorrect and fixed. Fixes: 6fbd73709ee4be32 ("net/mlx5: support link update on Windows") Cc: sta...@dpdk.org Signed-off-by: Tal Shnaiderman --- drivers/net/mlx5/windows/

[dpdk-dev] [PATCH] event/octeontx2: fix device reconfigure for single slot

2021-04-05 Thread Harman Kalra
When device is re-configured, memory allocated for work slot is freed and new memory is allocated. Due to this we may loose some important configurations/mappings done with initial work slot memory. For example, whenever rte_event_eth_tx_adapter_queue_add is called some important meta i.e. txq han

Re: [dpdk-dev] vfio error

2021-04-05 Thread Liang Ma
On Sun, Apr 04, 2021 at 07:10:43PM +0430, hamidreza Kheirabadi wrote: > Hi, > I have a dpdk application which binds nic with igb_uio. My problem is > whenever the kernel updates, I must recompile igb_uio.ko as well. > I want to use vfio instead but I got an error: > > Error: bind failed for :0

Re: [dpdk-dev] [PATCH v4 1/3] eventdev: introduce crypto adapter enqueue API

2021-04-05 Thread Akhil Goyal
Hi Abhnandan, > > > > In case an event from a previous stage is required to be forwarded to a > > crypto adapter and PMD supports internal event port in crypto adapter, > > exposed via capability > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD, we do not > > have a way to check in the API rte

[dpdk-dev] [PATCH] ethdev: add packet integrity checks

2021-04-05 Thread Ori Kam
Currently, DPDK application can offload the checksum check, and report it in the mbuf. However, as more and more applications are offloading some or all logic and action to the HW, there is a need to check the packet integrity so the right decision can be taken. The application logic can be posit

Re: [dpdk-dev] [PATCH v2 2/4] mbuf: add packet type for UDP-ESP tunnel packets

2021-04-05 Thread Akhil Goyal
> Adding new mbuf packet type for UDP encapsulated > ESP packets. > > Signed-off-by: Tejasree Kondoj > --- > doc/guides/rel_notes/release_21_05.rst | 5 + > lib/librte_mbuf/rte_mbuf_ptype.h | 21 + > 2 files changed, 26 insertions(+) > Acked-by: Akhil Goyal ++Ol

Re: [dpdk-dev] [PATCH v2 1/4] crypto/octeontx2: add UDP encapsulation support

2021-04-05 Thread Akhil Goyal
> Adding UDP encapsulation support for IPsec in > lookaside protocol mode. > > Signed-off-by: Tejasree Kondoj > --- Acked-by: Akhil Goyal

Re: [dpdk-dev] [PATCH v2 4/4] crypto/octeontx2: support lookaside IPv4 transport mode

2021-04-05 Thread Akhil Goyal
> > Adding support for IPv4 lookaside IPsec transport mode. > > Signed-off-by: Tejasree Kondoj > --- Acked-by: Akhil Goyal

Re: [dpdk-dev] [PATCH v2 3/4] examples/ipsec-secgw: add UDP encapsulation support

2021-04-05 Thread Akhil Goyal
> > Adding lookaside IPsec UDP encapsulation support > for NAT traversal. > Application has to add udp-encap option to sa config file > to enable UDP encapsulation on the SA. > > Signed-off-by: Tejasree Kondoj > --- Acked-by: Akhil Goyal Konstantin, Any more comments on this? Regards, Akhil

Re: [dpdk-dev] [PATCH v2 0/2] support block cipher DIGEST_ENCRYPTED mode

2021-04-05 Thread Akhil Goyal
> This series adds support for block cipher DIGEST_ENCRYPTED mode in > OCTEON TX, OCTEON TX2 PMDs and sample unit test application. > > v2: > * Removed duplicate test vectors in test application > * Updated comment with more information > Series applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH] doc: update limitations of OCTEON TX crypto PMDs

2021-04-05 Thread Akhil Goyal
> Update known limitations of OCTEON TX crypto PMDs. > > Signed-off-by: Anoob Joseph > --- Applied to dpdk-next-crypto Thanks.

[dpdk-dev] RSS hash computation on Intel X550 NIC with ixgbe driver

2021-04-05 Thread Deepak Gowda
Hello, I have been doing some experiments on rss hash computation, i'm using DPDK's testpmd application. Even though I apply rss conf on the available DPDK port, i don't see any value populated in the rss hash, it's always zero. Setup details -- *Debian 10 VM with a (Intel X550) VF attached to it

[dpdk-dev] [PATCH] l2fwd-crypto: remove padding after decrypting

2021-04-05 Thread Akhil Goyal
There were some padding left when a packet gets decrypted. This patch removes those padding. This patch also removes the padding left after verifying auth of the packet. Signed-off-by: Rohit Raj --- examples/l2fwd-crypto/main.c | 14 ++ 1 file changed, 14 insertions(+) this patch is

[dpdk-dev] [PATCH] l2fwd-crypto: skip dev configure for masked devices

2021-04-05 Thread Akhil Goyal
The devices which are masked by cryptodev mask should not be initialized and skipped while traversing the device list. Signed-off-by: Apeksha Gupta --- examples/l2fwd-crypto/main.c | 6 ++ 1 file changed, 6 insertions(+) again a fixes tag is missing. title should be examples/l2fwd-crypto: f

[dpdk-dev] [PATCH] l2fwd-crypto: align private data size to cache size

2021-04-05 Thread Akhil Goyal
L2fwd-crypto is passing 24b private data size while packet pool creation. This patch aligns that private data size to cache line size for better performance results. Signed-off-by: Gagandeep Singh --- app/proc-info/main.c | 2 +- examples/l2fwd-crypto/main.c | 3 ++- 2 files changed, 3 i

[dpdk-dev] [PATCH] net/ena: fix releasing Tx ring mbufs

2021-04-05 Thread David Harton
When ena_tx_queue_release_bufs() frees the mbufs it does not clear the mbuf pointers. So, when the device starts and stops multiple times it can cause the application to receive duplicate mbufs for two different packets. Fix the issue by clearing the mbuf pointer. Also, while tracking down the "

Re: [dpdk-dev] [PATCH v2 1/2] test/crypto: close PMD after tests

2021-04-05 Thread Akhil Goyal
Hi Adam/Arek, Could you please reply to the below query. > > This patch adds closing of the PMD after running the tests. > > > > Signed-off-by: Adam Dybkowski > > --- > > app/test/test_cryptodev.c | 6 +- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/app/test/test_

Re: [dpdk-dev] [PATCH] net/mlx5/windows: fix link speed calculation

2021-04-05 Thread Thomas Monjalon
There is no previous commit with net/mlx5/windows as title prefix. In general, there is "on Windows" at the end of the title. This way we can have the same formatting when fixing the common code for a Windows case. 05/04/2021 18:18, Tal Shnaiderman: > In Windows DevX returns the value of the curre

Re: [dpdk-dev] [RFC] drivers: introduce mlx5 crypto PMD

2021-04-05 Thread Akhil Goyal
Hi Matan/Shiri, > > Add a new PMD for Mellanox devices- crypto PMD. > > The crypto PMD will be supported starting Mellanox ConnectX6 and > BlueField2. > > The crypto PMD will add the support of encryption and decryption using > the AES-XTS symmetric algorithm. > > The crypto PMD requires rdma-

Re: [dpdk-dev] [PATCH v2 2/4] mbuf: add packet type for UDP-ESP tunnel packets

2021-04-05 Thread Thomas Monjalon
05/04/2021 20:11, Akhil Goyal: > > Adding new mbuf packet type for UDP encapsulated > > ESP packets. > > > > Signed-off-by: Tejasree Kondoj > > --- > > doc/guides/rel_notes/release_21_05.rst | 5 + > > lib/librte_mbuf/rte_mbuf_ptype.h | 21 + > > 2 files changed, 2

Re: [dpdk-dev] [PATCH] cryptodev: formalize key wrap method in API

2021-04-05 Thread Akhil Goyal
Hi Matan, > The Key Wrap approach is used by applications in order to protect keys > located in untrusted storage or transmitted over untrusted > communications networks. The constructions are typically built from > standard primitives such as block ciphers and cryptographic hash > functions. > >

[dpdk-dev] [PATCH v5 0/4] log level enhancements

2021-04-05 Thread Thomas Monjalon
This series is a part of a bigger one split after v4: "improve options help" The main intent of this series is to provide a nice help for the --log-level option. v5: - rename more private functions - sort log types when printing help Thomas Monjalon (4): log: move private functio

[dpdk-dev] [PATCH v5 1/4] log: move private functions

2021-04-05 Thread Thomas Monjalon
Some private log functions had a wrong "rte_" prefix. All private log functions are moved from eal_private.h to the new file eal_log.h: rte_eal_log_init -> eal_log_init rte_log_save_regexp -> eal_log_save_regexp rte_log_save_pattern -> eal_log_save_pattern eal_log_s

[dpdk-dev] [PATCH v5 2/4] log: introduce macro for maximum level

2021-04-05 Thread Thomas Monjalon
RTE_DIM(...) and RTE_LOG_DEBUG were used to get the highest log level. For better clarity a new constant RTE_LOG_MAX is introduced and mapped to RTE_LOG_DEBUG. Signed-off-by: Thomas Monjalon Acked-by: Bruce Richardson Acked-by: Andrew Rybchenko --- lib/librte_eal/common/eal_common_log.c |

[dpdk-dev] [PATCH v5 4/4] log: add option argument help

2021-04-05 Thread Thomas Monjalon
The option --log-level was not completely described in the usage text, and it was difficult to guess the names of the log types and levels. A new value "help" is accepted after --log-level to give more details about the syntax and listing the log types and levels. The array "levels" used for leve

[dpdk-dev] [PATCH v5 3/4] log: catch invalid level option number

2021-04-05 Thread Thomas Monjalon
The parsing check for invalid log level was not trying to catch irrelevant numeric values. A log level 0 becomes a failure in parsing so it can be caught early. A log level higher than the max (8) is accepted with a warning message. Signed-off-by: Thomas Monjalon Acked-by: Bruce Richardson Acked

[dpdk-dev] [PATCH v5 0/3] cleanup exit and usage messages in apps

2021-04-05 Thread Thomas Monjalon
This series is a part of a bigger one split after v4: "improve options help" v5: no change Thomas Monjalon (3): app: fix exit messages app/regex: fix usage text app/testpmd: fix usage text .../comp_perf_options_parse.c | 2 +- app/test-crypto-perf/cperf_options_pa

[dpdk-dev] [PATCH v5 2/3] app/regex: fix usage text

2021-04-05 Thread Thomas Monjalon
The usage syntax help includes the program name which was fake. It is replaced with the real name from argv. Fixes: de06137cb295 ("app/regex: add RegEx test application") Cc: sta...@dpdk.org Signed-off-by: Thomas Monjalon Acked-by: Ori Kam Acked-by: Bruce Richardson Acked-by: Andrew Rybchenko

[dpdk-dev] [PATCH v5 1/3] app: fix exit messages

2021-04-05 Thread Thomas Monjalon
Some applications were printing useless messages with rte_exit() after showing the help. Using exit() is enough in this case. Some applications were using a redundant printf or fprintf() before calling rte_exit(). The messages are unified in a single rte_exit(). Some rte_exit() calls were missing

[dpdk-dev] [PATCH v5 3/3] app/testpmd: fix usage text

2021-04-05 Thread Thomas Monjalon
The options help text was including an incomplete and redundant summary of the options before explaining each. The summary is dropped. The details of the option --hairpin-mode had an extra space, breaking the alignment with the next line. There were some mismatches between options in the usage te

[dpdk-dev] [PATCH v5 0/4] improve options help

2021-04-05 Thread Thomas Monjalon
After v4, this series is split in several parts. The remaining 4 patches of this series are low priority. Patches 1 and 3 are simple improvements. Patches 2 and 4 lead to a new formatting of the usage text. It is a matter of taste and should be discussed more. v5: no change Thomas Monjalon (4):

[dpdk-dev] [PATCH v5 2/4] eal: improve options usage text

2021-04-05 Thread Thomas Monjalon
The description of the EAL options was printed before the application description provided via the hook. It is better to let the application print the global syntax and describes the detail of the EAL options below. Also, some useless lines are removed, and the alignment of few options is fixed.

[dpdk-dev] [PATCH v5 1/4] eal: explain argv behaviour during init

2021-04-05 Thread Thomas Monjalon
After argument parsing done by rte_eal_init(), the remaining arguments are to be parsed by the application by progressing in the argv array. In this context, the first string represented by argv[0] is still the same program name as the original argv[0], while the next strings are the application ar

[dpdk-dev] [PATCH v5 3/4] eal: use macros for help option

2021-04-05 Thread Thomas Monjalon
The macros OPT_HELP and OPT_HELP_NUM were not used where appropriate. Signed-off-by: Thomas Monjalon Acked-by: Bruce Richardson Acked-by: Andrew Rybchenko --- lib/librte_eal/common/eal_common_options.c | 2 +- lib/librte_eal/freebsd/eal.c | 2 +- lib/librte_eal/linux/eal.c

[dpdk-dev] [PATCH v5 4/4] app: hook in EAL usage help

2021-04-05 Thread Thomas Monjalon
Use rte_set_application_usage_hook() in the test applications, so the full help including EAL options can be printed in one go with the EAL option -h or --help. Signed-off-by: Thomas Monjalon Acked-by: Wisam Jaddo Acked-by: Bruce Richardson Acked-by: Andrew Rybchenko --- app/pdump/main.c

Re: [dpdk-dev] [Linuxarm] [PATCH V2 0/4] add Hisilicon kunpeng CPU support

2021-04-05 Thread Honnappa Nagarahalli
> > 在 2021/3/25 22:40, Thomas Monjalon 写道: > > 25/03/2021 14:26, oulijun: > >> 在 2021/3/25 20:19, Thomas Monjalon 写道: > >>> 25/03/2021 12:17, oulijun: > Ruifeng has reviewed-by. Does anyone else have any comments? Is it > necessary to send the V2? > >>> > >>> v2 for what? There is a ch

Re: [dpdk-dev] [PATCH v2 3/4] examples/ipsec-secgw: add UDP encapsulation support

2021-04-05 Thread Ananyev, Konstantin
Hi Akhil, > > > > Adding lookaside IPsec UDP encapsulation support > > for NAT traversal. > > Application has to add udp-encap option to sa config file > > to enable UDP encapsulation on the SA. > > > > Signed-off-by: Tejasree Kondoj > > --- > Acked-by: Akhil Goyal > > Konstantin, > Any more co

[dpdk-dev] [PATCH] net/ena: fix releasing Tx ring mbufs

2021-04-05 Thread David Harton
When ena_tx_queue_release_bufs() frees the mbufs it does not clear the mbuf pointers. So, when the device starts and stops multiple times it can cause the application to receive duplicate mbufs for two different packets. Fix the issue by clearing the mbuf pointer. Also, while tracking down the "

Re: [dpdk-dev] [PATCH V2] ethdev: add queue state when retrieve queue information

2021-04-05 Thread oulijun
Hi, all, any comments for this patch? Hope for your reply. Thanks 在 2021/3/25 19:09, Lijun Ou 写道: Currently, upper-layer application could get queue state only through pointers such as dev->data->tx_queue_state[queue_id], this is not the recommended way to access it. So this patch add g

[dpdk-dev] [PATCH v2] net/hns3: use the correct HiSilicon copyright

2021-04-05 Thread Min Hu (Connor)
According to the suggestion of our legal department, to standardize the copyright license of our code to avoid potential copyright risks, we make a unified modification to the "Hisilicon", which was nonstandard, in the main modules we maintain. We change it to "HiSilicon", which is consistent with

Re: [dpdk-dev] [PATCH] net/hns3: use the correct HiSilicon copyright

2021-04-05 Thread Min Hu (Connor)
在 2021/4/2 16:07, Ferruh Yigit 写道: On 4/2/2021 2:45 AM, Min Hu (Connor) wrote: 在 2021/4/1 22:45, Ferruh Yigit 写道: On 4/1/2021 9:53 AM, Min Hu (Connor) wrote: According to the suggestion of our legal department, to standardize the copyright license of our code to avoid potential copyright

Re: [dpdk-dev] [Linuxarm] [PATCH V2 0/4] add Hisilicon kunpeng CPU support

2021-04-05 Thread oulijun
在 2021/4/6 3:50, Honnappa Nagarahalli 写道: 在 2021/3/25 22:40, Thomas Monjalon 写道: 25/03/2021 14:26, oulijun: 在 2021/3/25 20:19, Thomas Monjalon 写道: 25/03/2021 12:17, oulijun: Ruifeng has reviewed-by. Does anyone else have any comments? Is it necessary to send the V2? v2 for what? Ther

Re: [dpdk-dev] [PATCH v2 3/3] drivers: align log names

2021-04-05 Thread Wang, Xiao W
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Monday, April 5, 2021 6:03 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Xu, Rosen > ; Wang, Xiao W ; Hemant > Agrawal ; Ajit Khaparde > ; Griffin, John ; > Trahe, Fiona ; Jain, Deepak K > ; Raveendra Padasalagi > ; V

Re: [dpdk-dev] [PATCH v2 0/6] test: refactor crypto unit test framework

2021-04-05 Thread Ruifeng Wang
> -Original Message- > From: Ciara Power > Sent: Friday, April 2, 2021 10:24 PM > To: dev@dpdk.org > Cc: declan.dohe...@intel.com; gak...@marvell.com; acon...@redhat.com; > hemant.agra...@nxp.com; ano...@marvell.com; Ruifeng Wang > ; asoma...@amd.com; Ajit Khaparde > (ajit.khapa...@broadco

Re: [dpdk-dev] [PATCH V2] ethdev: add queue state when retrieve queue information

2021-04-05 Thread Stephen Hemminger
On Tue, 6 Apr 2021 08:49:04 +0800 oulijun wrote: > > /** > > + * RX/TX queue states > > + */ > > +#define RTE_ETH_QUEUE_STATE_STOPPED 0 > > +#define RTE_ETH_QUEUE_STATE_STARTED 1 > > +#define RTE_ETH_QUEUE_STATE_HAIRPIN 2 These could be an enum? > > +/** > >* Ethernet device RX queue info

[dpdk-dev] [PATCH] test/power: fix several bugs in cpufreq autotest

2021-04-05 Thread Richael Zhuang
1. Sleep for 1s before checking the newly updated value from "/sys/devices/system/cpu/cpu%u/cpufreq/cpuinfo_cur_freq", because for some systems it may not be effective immediately. 2. The value in "/sys/.../cpuinfo_cur_freq" may not be exactly the same as what we set. For example, we write "24

[dpdk-dev] [PATCH v1 2/2] test/power: fix a bug in cpufreq autotest

2021-04-05 Thread Richael Zhuang
For platforms that don't support turbo boost,rte_power_turbo_status() returns "-ENOTSUP" (like power_kvm_vm_turbo_status()). So don't allow check_power_turbo() to continue if rte_power_turbo_status(TEST_POWER_LCORE_ID)!=1 Fixes: aeaeaf5f2d62 ("test/power: add cases for turbo feature") Cc: lukaszx

[dpdk-dev] [PATCH v1 1/1] test/power: fix several bugs in cpufreq autotest

2021-04-05 Thread Richael Zhuang
1. Sleep for 1s before checking the newly updated value from "/sys/devices/system/cpu/cpu%u/cpufreq/cpuinfo_cur_freq", because for some systems it may not be effective immediately. 2. The value in "/sys/.../cpuinfo_cur_freq" may not be exactly the same as what we set. For example, we write "24

[dpdk-dev] [PATCH v1 2/2] test/power: fix a bug in cpufreq autotest

2021-04-05 Thread Richael Zhuang
For platforms that don't support turbo boost,rte_power_turbo_status() returns "-ENOTSUP" (like power_kvm_vm_turbo_status()). So don't allow check_power_turbo() to continue if rte_power_turbo_status(TEST_POWER_LCORE_ID)!=1 Fixes: aeaeaf5f2d62 ("test/power: add cases for turbo feature") Cc: lukaszx

Re: [dpdk-dev] [PATCH] vfio: change default per vfio_cfg map all dpdk segments for DMA

2021-04-05 Thread Xia, Chenbo
Hi, Yunjian > -Original Message- > From: dev On Behalf Of wangyunjian > Sent: Friday, May 15, 2020 7:02 PM > To: dev@dpdk.org > Cc: Burakov, Anatoly ; jerry.lili...@huawei.com; > xudin...@huawei.com; Yunjian Wang > Subject: [dpdk-dev] [PATCH] vfio: change default per vfio_cfg map all dpd

Re: [dpdk-dev] [PATCH] net/ena: fix releasing Tx ring mbufs

2021-04-05 Thread Michał Krawczyk
wt., 6 kwi 2021 o 02:27 David Harton napisał(a): > > When ena_tx_queue_release_bufs() frees the mbufs it does not clear > the mbuf pointers. So, when the device starts and stops multiple > times it can cause the application to receive duplicate mbufs for > two different packets. Fix the issue by

Re: [dpdk-dev] [PATCH v2 3/3] drivers: align log names

2021-04-05 Thread Xu, Rosen
Hi, > -Original Message- > From: Thomas Monjalon > Sent: Monday, April 05, 2021 18:03 > To: dev@dpdk.org > Cc: Richardson, Bruce ; Xu, Rosen > ; Wang, Xiao W ; Hemant > Agrawal ; Ajit Khaparde > ; Griffin, John ; > Trahe, Fiona ; Jain, Deepak K > ; Raveendra Padasalagi > ; Vikas Gupta > ;

[dpdk-dev] [PATCH] net/bnxt: fix FW unregister log

2021-04-05 Thread Kalesh A P
From: Kalesh AP The "Unregistered with fw" message was being logged in a wrong function. Moved it to the right place. Fixes: a7dda7e0a00b ("net/bnxt: log port id in async events") Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_

Re: [dpdk-dev] [PATCH v2 3/3] drivers: align log names

2021-04-05 Thread Min Hu (Connor)
Acked-by: Min Hu (Connor) 在 2021/4/5 18:03, Thomas Monjalon 写道: The log levels are configured by using the name of the logs. Some drivers are aligned to follow a common log name standard: pmd.class.driver[.sub] Some "common" drivers skip the "class" part: pmd.driver.sub Two dri

Re: [dpdk-dev] [RFC] drivers: introduce mlx5 crypto PMD

2021-04-05 Thread Matan Azrad
Hi Akhil From: Akhil Goyal > Hi Matan/Shiri, > > > > > Add a new PMD for Mellanox devices- crypto PMD. > > > > The crypto PMD will be supported starting Mellanox ConnectX6 and > > BlueField2. > > > > The crypto PMD will add the support of encryption and decryption using > > the AES-XTS symmetric

Re: [dpdk-dev] [PATCH] vhost: fix accessing uninitialized variables

2021-04-05 Thread Xia, Chenbo
Hi Marvin, > -Original Message- > From: Liu, Yong > Sent: Wednesday, March 3, 2021 3:28 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Liu, Yong ; sta...@dpdk.org > Subject: [PATCH] vhost: fix accessing uninitialized variables > > This patch fixs coverity issue by

Re: [dpdk-dev] [PATCH] cryptodev: formalize key wrap method in API

2021-04-05 Thread Matan Azrad
Hi Akhil From: Akhil Goyal > Hi Matan, > > > The Key Wrap approach is used by applications in order to protect keys > > located in untrusted storage or transmitted over untrusted > > communications networks. The constructions are typically built from > > standard primitives such as block ciphers

Re: [dpdk-dev] [PATCH v2 1/2] pci: rename catch-all ID

2021-04-05 Thread Xueming(Steven) Li
>-Original Message- >From: dev On Behalf Of Thomas Monjalon >Sent: Monday, April 5, 2021 5:15 PM >To: dev@dpdk.org >Cc: Matan Azrad ; Shahaf Shuler ; Slava >Ovsiienko ; Gaetan >Rivet >Subject: [dpdk-dev] [PATCH v2 1/2] pci: rename catch-all ID > >The name of the constant PCI_ANY_ID was

Re: [dpdk-dev] [PATCH v2 2/2] bus/pci: rename probe/remove operation types

2021-04-05 Thread Xueming(Steven) Li
>-Original Message- >From: dev On Behalf Of Thomas Monjalon >Sent: Monday, April 5, 2021 5:15 PM >To: dev@dpdk.org >Subject: [dpdk-dev] [PATCH v2 2/2] bus/pci: rename probe/remove operation types > >The names of the prototypes pci_probe_t and pci_remove_t are missing a prefix >rte_. >Th

[dpdk-dev] [PATCH v1 1/1] test/power: fix several bugs in cpufreq autotest

2021-04-05 Thread Richael Zhuang
1. Sleep for 1s before checking the newly updated value from "/sys/devices/system/cpu/cpu%u/cpufreq/cpuinfo_cur_freq", because for some systems it may not be effective immediately. 2. The value in "/sys/.../cpuinfo_cur_freq" may not be exactly the same as what we set. For example, we write "24

[dpdk-dev] [PATCH] app/flow-perf: support meter policy API

2021-04-05 Thread Haifei Luo
Add option "policy-mtr" to indicate if meter creation will include policy or not. Meter creation will keep same without it. With "policy-mtr", policy is introduced. API create_meter_policy is to create a policy. API create_meter_rule will use it to create meter. Depends-on: series=16037 ("Support