Re: [dpdk-dev] [Linuxarm] Re: [PATCH 2/3] app/testpmd: remove forwarding config from parsing Rx and Tx

2021-04-09 Thread oulijun
在 2021/4/9 15:08, Li, Xiaoyun 写道: -Original Message- From: oulijun Sent: Friday, April 9, 2021 14:10 To: linux...@openeuler.org; dev ; Li, Xiaoyun Subject: Re: [Linuxarm] Re: [PATCH 2/3] app/testpmd: remove forwarding config from parsing Rx and Tx 在 2021/4/2 10:33, Li, Xiaoyun

Re: [dpdk-dev] [Linuxarm] Re: [PATCH 1/3] app/testpmd: fix forwarding configuration when DCB test

2021-04-09 Thread oulijun
在 2021/4/10 8:56, Ferruh Yigit 写道: On 3/25/2021 2:21 AM, Li, Xiaoyun wrote: -Original Message- From: oulijun Sent: Wednesday, March 24, 2021 21:40 To: linux...@openeuler.org; Li, Xiaoyun ; dev Subject: Re: [Linuxarm] Re: [PATCH 1/3] app/testpmd: fix forwarding configuration when

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: fix forwarding configuration when DCB test

2021-04-09 Thread oulijun
在 2021/4/10 9:12, Ferruh Yigit 写道: On 3/23/2021 2:17 PM, oulijun wrote: 在 2021/3/23 16:55, Li, Xiaoyun 写道: Hi -Original Message- From: Lijun Ou Sent: Friday, March 5, 2021 18:22 To: Yigit, Ferruh Cc: Li, Xiaoyun ; dev@dpdk.org; linux...@openeuler.org Subject: [PATCH 1/3] app/te

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: fix forwarding configuration when DCB test

2021-04-09 Thread Ferruh Yigit
On 3/23/2021 2:17 PM, oulijun wrote: 在 2021/3/23 16:55, Li, Xiaoyun 写道: Hi -Original Message- From: Lijun Ou Sent: Friday, March 5, 2021 18:22 To: Yigit, Ferruh Cc: Li, Xiaoyun ; dev@dpdk.org; linux...@openeuler.org Subject: [PATCH 1/3] app/testpmd: fix forwarding configuration whe

[dpdk-dev] [PATCH v2 3/7] net/hns3: fix FLR failure when RAS concurrent with FLR

2021-04-09 Thread Min Hu (Connor)
From: Hongbo Zheng Currently, if RAS interrupt and FLR occurred at the same time, FLR will be detected and corresponding schedule state will be set during RAS interrupt processing. However, the schedule state value will be overridden in subsequent RAS processing, resulting in FLR processing failu

[dpdk-dev] [PATCH v2 7/7] net/hns3: fix configure FEC when concurrent with reset

2021-04-09 Thread Min Hu (Connor)
From: Chengchang Tang Currently, after the reset is complete, the PMD restores the FEC according to the FEC configuration reserved in the driver. If there is a concurrency between the FEC setup operation and the restore operation after a reset, the FEC status of the last hardware may be unknown.

[dpdk-dev] [PATCH v2 1/7] net/hns3: remove variables of selecting Rx/Tx function

2021-04-09 Thread Min Hu (Connor)
From: Chengwen Feng Currently, there are four control variables (rx_simple_allowed, rx_vec_allowed, tx_simple_allowed and tx_vec_allowed) which are used to impact the selection of Rx/Tx burst function. The purpose of the design is to provide a way to control the selection of Rx/Tx burst function

[dpdk-dev] [PATCH v2 4/7] net/hns3: fix some packet type calc error

2021-04-09 Thread Min Hu (Connor)
From: Chengwen Feng Currently, the packet type calculated by vlan/ovlan/l3id/l4id/ol3id/ol4id fields have the following problems: 1) Identify error when exist vlan strip which will lead to the data buffer has non vlan header but mbuf's ptype have L2_ETHER_VLAN flag. 2) Some packet identifies erro

[dpdk-dev] [PATCH v2 6/7] net/hns3: fix queue state when concurrent with reset

2021-04-09 Thread Min Hu (Connor)
From: Chengchang Tang At the end of the reset, the state of queues need to be restored according to the states saved in the driver. If the start and stop operations of the queues are concurrent at this time, it may cause the final status to be uncertain. This patch requires queues to acquire the

[dpdk-dev] [PATCH v2 5/7] net/hns3: fix incorrect timing in resetting queues

2021-04-09 Thread Min Hu (Connor)
From: Chengchang Tang During the task queue pairs reset, the getimeofday is used to obtain the timestamp to determine whether the command execution times out. But gettimeofday is not monotonous, it can be modified by system administrators, so the timing may not be accurate or even cause the loop

[dpdk-dev] [PATCH v2 2/7] net/hns3: fix missing rollback in PF init

2021-04-09 Thread Min Hu (Connor)
This patch adds rollback processing when updating imissed stats failed in PF init. Fixes: 3e9f3042d7c8 ("net/hns3: add imissed packet stats") Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hns3/hn

[dpdk-dev] [PATCH v2 0/7] Bugfix for hns3 PMD

2021-04-09 Thread Min Hu (Connor)
This set of patches contains seven bugfixes for hns3 PMD. Chengchang Tang (3): net/hns3: fix incorrect timing in resetting queues net/hns3: fix queue state when concurrent with reset net/hns3: fix configure FEC when concurrent with reset Chengwen Feng (2): net/hns3: remove variables of se

Re: [dpdk-dev] [Linuxarm] Re: [PATCH 1/3] app/testpmd: fix forwarding configuration when DCB test

2021-04-09 Thread Ferruh Yigit
On 3/25/2021 2:21 AM, Li, Xiaoyun wrote: -Original Message- From: oulijun Sent: Wednesday, March 24, 2021 21:40 To: linux...@openeuler.org; Li, Xiaoyun ; dev Subject: Re: [Linuxarm] Re: [PATCH 1/3] app/testpmd: fix forwarding configuration when DCB test 在 2021/3/24 10:03, Li, Xiao

[dpdk-dev] [PATCH] common/sfc_efx/base: fix indication of MAE encap. support

2021-04-09 Thread Ivan Malov
The indication fields in the MCDI response are individual bits, but the current code mistakenly compares the larger dword with 1. This breaks encap. type discovery. Fix that. Fixes: 891408c45a63 ("common/sfc_efx/base: indicate MAE support for encapsulation") Cc: sta...@dpdk.org Signed-off-by: Iv

Re: [dpdk-dev] [PATCH v2 0/3] Predictable RSS feature

2021-04-09 Thread Wang, Yipeng1
> -Original Message- > From: Medvedkin, Vladimir > Sent: Tuesday, April 6, 2021 12:51 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Chilikin, Andrey > ; Kinsella, Ray ; Wang, > Yipeng1 ; Gobriel, Sameh > ; Richardson, Bruce > > Subject: [PATCH v2 0/3] Predictable RSS feature > > This

Re: [dpdk-dev] [PATCH v2 2/3] hash: add predictable RSS implementation

2021-04-09 Thread Wang, Yipeng1
> -Original Message- > From: Medvedkin, Vladimir > Sent: Tuesday, April 6, 2021 12:51 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Chilikin, Andrey > ; Kinsella, Ray ; Wang, > Yipeng1 ; Gobriel, Sameh > ; Richardson, Bruce > > Subject: [PATCH v2 2/3] hash: add predictable RSS impleme

Re: [dpdk-dev] [PATCH v2 1/3] hash: add predictable RSS API

2021-04-09 Thread Wang, Yipeng1
> -Original Message- > From: Medvedkin, Vladimir > Sent: Tuesday, April 6, 2021 12:51 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Chilikin, Andrey > ; Kinsella, Ray ; Wang, > Yipeng1 ; Gobriel, Sameh > ; Richardson, Bruce > > Subject: [PATCH v2 1/3] hash: add predictable RSS API >

[dpdk-dev] [PATCH] mem: fix cleanup after incomplete initialization

2021-04-09 Thread Dmitry Kozlyuk
In case of EAL initialization failure rte_eal_memory_detach() may be called before mapping memory configuration, which in this case points to the static structure. Attempt to unmap it yields error: EAL: Could not unmap shared memory config: Invalid argument Skip unmapping memory configuration

Re: [dpdk-dev] [PATCH 0/3] Add developer mode to DPDK build

2021-04-09 Thread Thomas Monjalon
25/02/2021 20:50, Thomas Monjalon: > 25/02/2021 16:29, Bruce Richardson: > > To allow more flexibility in enabling additional build checks to DPDK build > > process, we can add a developer mode option to the build. With this option > > enabled, extra checks of interest to DPDK developers rather tha

Re: [dpdk-dev] [PATCH 2/5] net/tap: do not touch Tx offload flags

2021-04-09 Thread Flavio Leitner
On Fri, Apr 09, 2021 at 03:30:18PM +0200, Olivier Matz wrote: > On Thu, Apr 08, 2021 at 09:58:35AM -0300, Flavio Leitner wrote: > > On Thu, Apr 08, 2021 at 02:05:21PM +0200, Olivier Matz wrote: > > > On Thu, Apr 08, 2021 at 08:21:58AM -0300, Flavio Leitner wrote: > > > > On Thu, Apr 08, 2021 at 09:

Re: [dpdk-dev] [PATCH] license: fix typo

2021-04-09 Thread Hemant Agrawal
On 4/9/2021 9:49 PM, Stephen Hemminger wrote: On Fri, 9 Apr 2021 16:53:56 +0100 Ferruh Yigit wrote: Fixes: a4862c9e1a98 ("license: introduce SPDX identifiers") Cc: sta...@dpdk.org Signed-off-by: Ferruh Yigit Acked-by: Stephen Hemminger Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH] license: fix typo

2021-04-09 Thread Stephen Hemminger
On Fri, 9 Apr 2021 16:53:56 +0100 Ferruh Yigit wrote: > Fixes: a4862c9e1a98 ("license: introduce SPDX identifiers") > Cc: sta...@dpdk.org > > Signed-off-by: Ferruh Yigit Acked-by: Stephen Hemminger

[dpdk-dev] [PATCH] license: fix typo

2021-04-09 Thread Ferruh Yigit
Fixes: a4862c9e1a98 ("license: introduce SPDX identifiers") Cc: sta...@dpdk.org Signed-off-by: Ferruh Yigit --- Cc: hemant.agra...@nxp.com --- license/README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/license/README b/license/README index 874abaf4cd1e..79dac86440a5 1

Re: [dpdk-dev] [PATCH] test: make hugepage check more robust under Linux

2021-04-09 Thread Bruce Richardson
On Fri, Apr 09, 2021 at 11:06:20AM -0400, Aaron Conole wrote: > Bruce Richardson writes: > > > On Tue, Apr 06, 2021 at 10:20:37AM -0400, Aaron Conole wrote: > >> Bruce Richardson writes: > >> > >> > On Tue, Apr 06, 2021 at 08:33:07AM -0400, Aaron Conole wrote: > >> >> Thomas Monjalon writes: >

Re: [dpdk-dev] [PATCH v19 1/3] build: disable/enable drivers in Arm builds

2021-04-09 Thread Bruce Richardson
On Fri, Apr 09, 2021 at 03:31:31PM +0100, Bruce Richardson wrote: > On Fri, Apr 09, 2021 at 02:10:08PM +, Juraj Linkeš wrote: > > > > > > > -Original Message- > > > From: Bruce Richardson > > > Sent: Friday, April 9, 2021 12:03 PM > > > To: Juraj Linkeš > > > Cc: ruifeng.w...@arm.co

Re: [dpdk-dev] [PATCH] doc: clarify PMD order in release notes

2021-04-09 Thread Thomas Monjalon
09/04/2021 17:21, Ferruh Yigit: > PMD updates are expected in alphabetical order based on their vendor > name. Clarify this expectation in the section comment. > > Signed-off-by: Ferruh Yigit > --- > Cc: Thomas Monjalon > --- > --- a/doc/guides/rel_notes/release_21_05.rst > +++ b/doc/guides/rel_

Re: [dpdk-dev] [PATCH] test: make hugepage check more robust under Linux

2021-04-09 Thread Thomas Monjalon
09/04/2021 17:06, Aaron Conole: > Bruce Richardson writes: > > > On Tue, Apr 06, 2021 at 10:20:37AM -0400, Aaron Conole wrote: > >> Bruce Richardson writes: > >> > >> > On Tue, Apr 06, 2021 at 08:33:07AM -0400, Aaron Conole wrote: > >> >> Thomas Monjalon writes: > >> >> > >> >> > 17/03/2021 1

[dpdk-dev] [RFC v2] eventdev: introduce event dispatcher

2021-04-09 Thread Mattias Rönnblom
The purpose of the event dispatcher is primarily to decouple different parts of an application (e.g., processing pipeline stages), which share the same underlying event device. The event dispatcher replaces the conditional logic (often, a switch statement) that typically follows an event device de

[dpdk-dev] [PATCH] doc: clarify PMD order in release notes

2021-04-09 Thread Ferruh Yigit
PMD updates are expected in alphabetical order based on their vendor name. Clarify this expectation in the section comment. Signed-off-by: Ferruh Yigit --- Cc: Thomas Monjalon --- doc/guides/rel_notes/release_21_05.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/rel_notes/rel

Re: [dpdk-dev] [PATCH] test: make hugepage check more robust under Linux

2021-04-09 Thread Aaron Conole
Bruce Richardson writes: > On Tue, Apr 06, 2021 at 10:20:37AM -0400, Aaron Conole wrote: >> Bruce Richardson writes: >> >> > On Tue, Apr 06, 2021 at 08:33:07AM -0400, Aaron Conole wrote: >> >> Thomas Monjalon writes: >> >> >> >> > 17/03/2021 15:44, Aaron Conole: >> >> >> The hugepage test rea

Re: [dpdk-dev] [dpdk-stable] [PATCH v5 3/3] kni: fix kernel deadlock when using mlx devices

2021-04-09 Thread Ferruh Yigit
On 3/29/2021 3:36 PM, Ferruh Yigit wrote: KNI runs userspace callback with rtnl lock held, this is not working fine with some devices that needs to interact with kernel interface in the callback, like Mellanox devices. The solution is releasing the rtnl lock before calling the userspace callback

Re: [dpdk-dev] [PATCH v2 1/1] raw/ifpga/base: check size before assigning

2021-04-09 Thread Aaron Conole
Ferruh Yigit writes: > On 4/8/2021 9:51 AM, Wei Huang wrote: >> In max10_staging_area_init(), variable "size" from fdt_get_reg() may >> be invalid, it should be checked before assigning to member variable >> "staging_area_size" of structure "intel_max10_device". >> >> Coverity issue: 367480, 3674

Re: [dpdk-dev] [PATCH v4 0/6] net: ngbe PMD

2021-04-09 Thread Ferruh Yigit
On 4/6/2021 10:30 AM, Jiawen Wu wrote: This patch set provides a skeleton of ngbe PMD, which adapted to Wangxun WX1860 series NICs. v4: - Fix compile error. v3: - Use rte_ether functions to define marcos. v2: - Correct some clerical errors. - Use ethdev debug flags instead of driver own. Jiaw

Re: [dpdk-dev] [PATCH v4 3/6] net/ngbe: support probe and remove

2021-04-09 Thread Ferruh Yigit
On 4/6/2021 10:30 AM, Jiawen Wu wrote: Add basic PCIe ethdev probe and remove. Signed-off-by: Jiawen Wu <...> --- a/drivers/net/ngbe/ngbe_ethdev.c +++ b/drivers/net/ngbe/ngbe_ethdev.c @@ -1,10 +1,12 @@ - /* SPDX-License-Identifier: BSD-3-Clause - * Copyright(c) 2018-2020 - */ +/* SPDX-Lic

Re: [dpdk-dev] [PATCH v4 2/6] net/ngbe: add device IDs

2021-04-09 Thread Ferruh Yigit
On 4/6/2021 10:30 AM, Jiawen Wu wrote: Add device IDs for Wangxun 1Gb NICs, and register rte_ngbe_pmd. Signed-off-by: Jiawen Wu <...> +static struct rte_pci_driver rte_ngbe_pmd = { + .id_table = pci_id_ngbe_map, + .drv_flags = RTE_PCI_DRV_NEED_MAPPING | +RTE_

Re: [dpdk-dev] [PATCH v4 1/6] net/ngbe: add build and doc infrastructure

2021-04-09 Thread Ferruh Yigit
On 4/6/2021 10:30 AM, Jiawen Wu wrote: Adding bare minimum PMD library and doc build infrastructure and claim the maintainership for ngbe PMD. Signed-off-by: Jiawen Wu <...> diff --git a/doc/guides/nics/ngbe.rst b/doc/guides/nics/ngbe.rst new file mode 100644 index 0..007d8e80e ---

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] eal: fix hang in ctrl thread creation error logic

2021-04-09 Thread David Marchand
On Wed, Apr 7, 2021 at 10:29 PM Luc Pelletier wrote: > > The affinity of a control thread is set after it has been launched. If > setting the affinity fails, pthread_cancel is called followed by a call > to pthread_join, which can hang forever if the thread's start routine > doesn't call a pthread

Re: [dpdk-dev] [PATCH v19 1/3] build: disable/enable drivers in Arm builds

2021-04-09 Thread Bruce Richardson
On Fri, Apr 09, 2021 at 02:10:08PM +, Juraj Linkeš wrote: > > > > -Original Message- > > From: Bruce Richardson > > Sent: Friday, April 9, 2021 12:03 PM > > To: Juraj Linkeš > > Cc: ruifeng.w...@arm.com; honnappa.nagaraha...@arm.com; > > phil.y...@arm.com; vcchu...@amazon.com; dharm

Re: [dpdk-dev] [PATCH v19 1/3] build: disable/enable drivers in Arm builds

2021-04-09 Thread Juraj Linkeš
> -Original Message- > From: Bruce Richardson > Sent: Friday, April 9, 2021 12:03 PM > To: Juraj Linkeš > Cc: ruifeng.w...@arm.com; honnappa.nagaraha...@arm.com; > phil.y...@arm.com; vcchu...@amazon.com; dharmik.thak...@arm.com; > jerinjac...@gmail.com; hemant.agra...@nxp.com; > ajit.kh

[dpdk-dev] [PATCH v6 2/3] event/octeontx2: support crypto adapter forward mode

2021-04-09 Thread Shijith Thotton
Advertise crypto adapter forward mode capability and set crypto adapter enqueue function in driver. Signed-off-by: Shijith Thotton --- drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 42 ++ drivers/event/octeontx2/otx2_evdev.c | 5 +- .../event/octeontx2/otx2_evdev_crypto_adptr

[dpdk-dev] [PATCH v6 0/3] Enhancements to crypto adapter forward mode

2021-04-09 Thread Shijith Thotton
This series proposes a new event device enqueue operation if crypto adapter forward mode is supported. Second patch in the series is the implementation of the same in PMD. Test application changes are added in third patch. v6: - Rebased. v5: - Set rte_errno if crypto adapter enqueue fails in driv

[dpdk-dev] [PATCH v6 1/3] eventdev: introduce crypto adapter enqueue API

2021-04-09 Thread Shijith Thotton
From: Akhil Goyal In case an event from a previous stage is required to be forwarded to a crypto adapter and PMD supports internal event port in crypto adapter, exposed via capability RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD, we do not have a way to check in the API rte_event_enqueue_bur

[dpdk-dev] [PATCH v6 3/3] test/event_crypto: use crypto adapter enqueue API

2021-04-09 Thread Shijith Thotton
Use rte_event_crypto_adapter_enqueue() API to enqueue events to crypto adapter if forward mode is supported in driver. Signed-off-by: Shijith Thotton --- app/test/test_event_crypto_adapter.c | 33 ++-- 1 file changed, 21 insertions(+), 12 deletions(-) diff --git a/app/te

Re: [dpdk-dev] [PATCH] test: allow taking test names from commandline

2021-04-09 Thread Bruce Richardson
On Fri, Apr 09, 2021 at 03:27:17PM +0200, David Marchand wrote: > On Wed, Jan 27, 2021 at 6:43 PM Bruce Richardson > wrote: > > > > While having the ability to run a test based off the DPDK_TEST environment > > variable is useful, it's often easier to specify the test name as a > > commandline par

Re: [dpdk-dev] [PATCH v8 4/4] net: provide IP-related API on any OS

2021-04-09 Thread Olivier Matz
On Thu, Apr 08, 2021 at 10:51:34PM +0300, Dmitry Kozlyuk wrote: > 2021-04-08 13:45 (UTC+0200), Olivier Matz: > [...] > > > diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c > > > index c572d003cb..e7361bf520 100644 > > > --- a/drivers/net/i40e/i40e_fdir.c > > > +++ b/drivers/

Re: [dpdk-dev] [PATCH 2/5] net/tap: do not touch Tx offload flags

2021-04-09 Thread Olivier Matz
On Thu, Apr 08, 2021 at 09:58:35AM -0300, Flavio Leitner wrote: > On Thu, Apr 08, 2021 at 02:05:21PM +0200, Olivier Matz wrote: > > On Thu, Apr 08, 2021 at 08:21:58AM -0300, Flavio Leitner wrote: > > > On Thu, Apr 08, 2021 at 09:41:59AM +0200, Olivier Matz wrote: > > > > On Wed, Apr 07, 2021 at 05:

Re: [dpdk-dev] [PATCH] vfio: reformat logs

2021-04-09 Thread David Marchand
On Thu, Apr 1, 2021 at 1:25 PM Burakov, Anatoly wrote: > > On 08-Mar-21 10:24 PM, Thomas Monjalon wrote: > > The log messages had various issues: > > - split on 2 lines, making search (grep) difficult > > - long lines (can be split after the string) > > - indented for no good reason (parent messag

Re: [dpdk-dev] [PATCH] test: allow taking test names from commandline

2021-04-09 Thread David Marchand
On Wed, Jan 27, 2021 at 6:43 PM Bruce Richardson wrote: > > While having the ability to run a test based off the DPDK_TEST environment > variable is useful, it's often easier to specify the test name as a > commandline parameter to a test binary. This also allows the test runs to > be saved as par

[dpdk-dev] [PATCH] eventdev: fix doxygen for function declaration

2021-04-09 Thread pbhagavatula
From: Pavan Nikhilesh Fix missing parameters in doxygen of function declaration. Fixes: 5b1337f0a08a ("eventdev: introduce event vector Rx capability") Signed-off-by: Pavan Nikhilesh --- lib/librte_eventdev/rte_event_eth_rx_adapter.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/

[dpdk-dev] [PATCH v2] l2fwd-crypto: fix packet length while decryption

2021-04-09 Thread Hemant Agrawal
From: Rohit Raj There were some padding left when a packet gets decrypted. This patch removes those padding. This patch also removes the padding left after verifying auth of the packet. Fixes: e2cdfbd07c8a ("examples/l2fwd-crypto: fix port id type") Cc: sta...@dpdk.org Signed-off-by: Rohit Raj

[dpdk-dev] [PATCH v2] l2fwd-crypto: fix dev configure for masked devices

2021-04-09 Thread Hemant Agrawal
From: Apeksha Gupta The devices which are masked by cryptodev mask should not be initialized and skipped while traversing the device list. Fixes: 6ae3fb9df66e ("examples/l2fwd-crypto: fix session mempool size") Cc: sta...@dpdk.org Signed-off-by: Apeksha Gupta --- examples/l2fwd-crypto/main.c

Re: [dpdk-dev] [PATCH] log: deduce log type from filename

2021-04-09 Thread Bruce Richardson
On Fri, Apr 09, 2021 at 02:43:34PM +0200, David Marchand wrote: > Let's try to enforce the convention where drivers use a pmd. logtype > with their class reflected in it and libraries use a lib. logtype. > > RTE_LOG_REGISTER now interprets the log type name: > - if none or a name starting with a .

[dpdk-dev] [PATCH v2] l2fwd-crypto: align private data size to cache size

2021-04-09 Thread Hemant Agrawal
From: Gagandeep Singh L2fwd-crypto is passing 24b private data size while packet pool creation. This patch aligns that private data size to cache line size for better performance results. Signed-off-by: Gagandeep Singh --- examples/l2fwd-crypto/main.c | 3 ++- 1 file changed, 2 insertions(+),

[dpdk-dev] [PATCH] log: deduce log type from filename

2021-04-09 Thread David Marchand
Let's try to enforce the convention where drivers use a pmd. logtype with their class reflected in it and libraries use a lib. logtype. RTE_LOG_REGISTER now interprets the log type name: - if none or a name starting with a . is passed, then the default logtype is used as a prefix, - else the nam

[dpdk-dev] [PATCH] net/mlx5: fix VLAN/DECAP actions not work in mirror flow

2021-04-09 Thread Jiawei Wang
Due to hardware limitations the VLAN push/pop and Decap actions following the sample action are supported in the FDB Tx steering domain only, the flows with incorrect action order for other domains are rejected by rdma-core. To provide the action order requested in RTE flow this patch checks for t

[dpdk-dev] [PATCH] net/mlx5: fix resource release issue for mirror flow

2021-04-09 Thread Jiawei Wang
The mlx5 PMD allocated the resources of the sample actions, and then moved these ones to the destination actions array. The original indices were not cleared and the resources were referenced twice in the flow object - as the fate actions and in the destination actions array. This causes the failu

Re: [dpdk-dev] [PATCH v5 0/3] cleanup exit and usage messages in apps

2021-04-09 Thread David Marchand
On Mon, Apr 5, 2021 at 9:33 PM Thomas Monjalon wrote: > > This series is a part of a bigger one split after v4: > "improve options help" > > v5: no change Previous versions lgtm, hence for the series, Acked-by: David Marchand Series applied, thanks. -- David Marchand

[dpdk-dev] [PATCH v5] build: remove redundant libpcap link

2021-04-09 Thread Thomas Monjalon
From: Gabriel Ganne The pcap PMD and the librte_port both declare their dependency to libpcap with a line "ext_deps += pcap_dep". Then meson automatically adds this dependency to the pkg-config file in the "Requires.private" section for static builds. The additional update of dpdk_extra_ldflags

Re: [dpdk-dev] [PATCH v3 0/3] Track log level changes

2021-04-09 Thread David Marchand
On Fri, Apr 9, 2021 at 1:05 PM David Marchand wrote: > > Here is a little series, following RFC [1]. > No change in behavior expected, but reviews welcome ! :-) > > 1: https://patchwork.dpdk.org/project/dpdk/list/?series=10632 > > Changes since v2: > - rebased on main, > - updated log message in p

Re: [dpdk-dev] [PATCH v3 2/3] log: track log level changes

2021-04-09 Thread David Marchand
On Fri, Apr 9, 2021 at 1:59 PM Thomas Monjalon wrote: > > 09/04/2021 13:04, David Marchand: > > Add a log message when registering log types and changing log levels. > > > > __rte_log_register previous handled both legacy and dynamic logtypes. > > To simplify the code, __rte_log_register is rework

[dpdk-dev] [PATCH v3 2/2] app/crypto-perf: close PMD after benchmark run

2021-04-09 Thread Adam Dybkowski
This patch adds closing of the PMD after running the benchmark. Signed-off-by: Adam Dybkowski --- app/test-crypto-perf/main.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c index 49af812d8b..70cb04a21

[dpdk-dev] [PATCH v3 1/2] test/crypto: close PMD after tests

2021-04-09 Thread Adam Dybkowski
This patch adds closing of the PMD after running the tests. Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev.c | 5 + 1 file changed, 5 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index f91debc168..d68855c442 100644 --- a/app/test/test_cryptodev

[dpdk-dev] [PATCH v3 0/2] test/crypto: close PMD after tests

2021-04-09 Thread Adam Dybkowski
This patch adds closing of the PMD after running the tests. -- v3: * move the call from ut_teardown to testsuite_teardown v2: * display error message on close error Adam Dybkowski (2): test/crypto: close PMD after tests app/crypto-perf: close PMD after benchmark run app/test-crypto-perf/ma

Re: [dpdk-dev] [PATCH v2] mem: fix cleanup when multi-process is disabled

2021-04-09 Thread David Marchand
On Wed, Mar 24, 2021 at 8:32 PM Dmitry Kozlyuk wrote: > @@ -1050,7 +1055,10 @@ rte_eal_memory_detach(void) > * config - we can't zero it out because it might still be referenced > * by other processes. > */ > - rte_mem_unmap(mcfg, RTE_ALIGN(sizeof(*mcfg), page_sz))

Re: [dpdk-dev] [PATCH v3 2/3] log: track log level changes

2021-04-09 Thread Thomas Monjalon
09/04/2021 13:04, David Marchand: > Add a log message when registering log types and changing log levels. > > __rte_log_register previous handled both legacy and dynamic logtypes. > To simplify the code, __rte_log_register is reworked to only handle > dynamic logtypes and takes a log level. > > E

Re: [dpdk-dev] [PATCH v3 0/3] net/pcap: build on Windows

2021-04-09 Thread Ferruh Yigit
On 4/9/2021 12:03 PM, Dmitry Kozlyuk wrote: 2021-04-09 11:51 (UTC+0100), Ferruh Yigit: On 3/24/2021 12:50 AM, Dmitry Kozlyuk wrote: [...] Depends-on: series-15801 ("eal/windows: do not expose POSIX symbols") Depends-on: patch-89639 ("[v2,3/3] meson: remove unnecessary explicit link to libpcap

[dpdk-dev] [PATCH v3 3/3] eal: fix evaluation of log level option

2021-04-09 Thread David Marchand
--log-level option is handled early, no need to reevaluate it later in EAL init. Before: $ echo quit | ./build/app/test/dpdk-test --no-huge -m 512 \ --log-level=lib.eal:debug \ --log-level=lib.ethdev:debug --log-level=lib.ethdev:info \ |& grep -i logtype.level EAL: lib.eal logtype level cha

[dpdk-dev] [PATCH v3 2/3] log: track log level changes

2021-04-09 Thread David Marchand
Add a log message when registering log types and changing log levels. __rte_log_register previous handled both legacy and dynamic logtypes. To simplify the code, __rte_log_register is reworked to only handle dynamic logtypes and takes a log level. Example: $ DPDK_TEST=logs_autotest ./build/app/te

[dpdk-dev] [PATCH v3 1/3] test/log: check levels

2021-04-09 Thread David Marchand
Add checks on log levels: - default values for rte_log_register and RTE_LOG_REGISTER, - level changes with rte_log_set_level and consorts Signed-off-by: David Marchand --- Changes since v1: - dropped unrelated change moving logtype1 and logtype2 as global static variables, - dropped __FILE__ +

[dpdk-dev] [PATCH v3 0/3] Track log level changes

2021-04-09 Thread David Marchand
Here is a little series, following RFC [1]. No change in behavior expected, but reviews welcome ! :-) 1: https://patchwork.dpdk.org/project/dpdk/list/?series=10632 Changes since v2: - rebased on main, - updated log message in patch 2, Changes since v1: - some cleanup in patch 1, - some precision

Re: [dpdk-dev] [PATCH v3 0/3] net/pcap: build on Windows

2021-04-09 Thread Dmitry Kozlyuk
2021-04-09 11:51 (UTC+0100), Ferruh Yigit: > On 3/24/2021 12:50 AM, Dmitry Kozlyuk wrote: [...] > > Depends-on: series-15801 ("eal/windows: do not expose POSIX symbols") > > Depends-on: patch-89639 ("[v2,3/3] meson: remove unnecessary explicit link > > to libpcap") > > > > Hi Dmitry, > > What

Re: [dpdk-dev] [EXT] Re: [PATCH v3 2/4] mbuf: add packet type for UDP-ESP tunnel packets

2021-04-09 Thread Akhil Goyal
Hi Olivier, > On Thu, Apr 08, 2021 at 01:47:18PM +0530, Tejasree Kondoj wrote: > > Adding new mbuf packet type for UDP encapsulated > > ESP packets. > > > > Signed-off-by: Tejasree Kondoj > > --- > > doc/guides/rel_notes/release_21_05.rst | 5 + > > lib/librte_mbuf/rte_mbuf_ptype.h | 2

Re: [dpdk-dev] [PATCH v7 0/4] log level enhancements

2021-04-09 Thread David Marchand
On Thu, Apr 8, 2021 at 6:47 PM Thomas Monjalon wrote: > > This series is a part of a bigger one split after v4: > "improve options help" > > The main intent of this series is to provide a nice help > for the --log-level option. Series applied, thanks. -- David Marchand

Re: [dpdk-dev] [PATCH v3 0/3] net/pcap: build on Windows

2021-04-09 Thread Ferruh Yigit
On 3/24/2021 12:50 AM, Dmitry Kozlyuk wrote: NOTE: dependency patches are requirements, CI may fail. Most modern and actively maintained distribution of libpcap for Windows is Npcap [1]. It currently doesn't provide a pkg-config file [2]. By default it is installed to C:\Program Files\Npcap and

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/1] app/test: fix TCP header initialization

2021-04-09 Thread Ferruh Yigit
On 4/8/2021 5:07 PM, Ferruh Yigit wrote: On 3/30/2021 2:23 PM, Lance Richardson wrote: Initialize TCP data offset field with TCP header length, this field is used to derive L4 header length and by hardware to validate a TCP header. Fixes: 41f72ec94074 ("test: add packet burst generator function

Re: [dpdk-dev] [PATCH] net/i40e: add Tx preparation for vector data path

2021-04-09 Thread Ananyev, Konstantin
> > > > > Fill up dev->tx_pkt_prepare to i40e_pkt_prepare when on vector and > > > > > simple data path selection, as the sanity check is needed ideally. > > > > > > > > > > Signed-off-by: Leyi Rong > > > > > --- > > > > > drivers/net/i40e/i40e_rxtx.c | 2 +- > > > > > 1 file changed, 1 inser

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix queue Rx and Tx offload reconfig cmd

2021-04-09 Thread Yu, DapengX
> -Original Message- > From: Li, Xiaoyun > Sent: Friday, April 9, 2021 3:50 PM > To: Yu, DapengX ; Yigit, Ferruh > ; Zhang, Qi Z > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [dpdk-stable] [PATCH] app/testpmd: fix queue Rx and Tx offload > reconfig cmd > > > > > -Original Me

[dpdk-dev] [PATCH] net/hns3: support trace Rx/Tx burst function

2021-04-09 Thread Min Hu (Connor)
From: Chengwen Feng This patch adds debug info for Rx/Tx burst function which was choosing. Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_rxtx.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/hns3/hns3_rxtx.c b/driver

[dpdk-dev] [PATCH 5/7] net/hns3: fix incorrect timing in resetting queues

2021-04-09 Thread Min Hu (Connor)
From: Chengchang Tang During the task queue pairs reset, the getimeofday is used to obtain the timestamp to determine whether the command execution times out. But gettimeofday is not monotonous, it can be modified by system administrators, so the timing may not be accurate or even cause the loop

[dpdk-dev] [PATCH 6/7] net/hns3: fix queue state when concurrent with reset

2021-04-09 Thread Min Hu (Connor)
From: Chengchang Tang At the end of the reset, the state of queues need to be restored according to the states saved in the driver. If the start and stop operations of the queues are concurrent at this time, it may cause the final status to be uncertain. This patch requires queues to acquire the

[dpdk-dev] [PATCH 7/7] net/hns3: fix configure FEC when concurrent with reset

2021-04-09 Thread Min Hu (Connor)
From: Chengchang Tang Currently, after the reset is complete, the PMD restores the FEC according to the FEC configuration reserved in the driver. If there is a concurrency between the FEC setup operation and the restore operation after a reset, the FEC status of the last hardware may be unknown.

[dpdk-dev] [PATCH 4/7] net/hns3: fix some packet type calc error

2021-04-09 Thread Min Hu (Connor)
From: Chengwen Feng Currently, the packet type calculated by vlan/ovlan/l3id/l4id/ol3id/ol4id fields have the following problems: 1) Identify error when exist vlan strip which will lead to the data buffer has non vlan header but mbuf's ptype have L2_ETHER_VLAN flag. 2) Some packet identifies erro

[dpdk-dev] [PATCH 1/7] net/hns3: remove ariables of selecting Rx/Tx function

2021-04-09 Thread Min Hu (Connor)
From: Chengwen Feng Currently, there are four control variables (rx_simple_allowed, rx_vec_allowed, tx_simple_allowed and tx_vec_allowed) which are used to impact the selection of Rx/Tx burst function. The purpose of the design is to provide a way to control the selection of Rx/Tx burst function

[dpdk-dev] [PATCH 2/7] net/hns3: fix missing rollback in PF init

2021-04-09 Thread Min Hu (Connor)
This patch adds rollback processing when updating imissed stats failed in PF init. Fixes: 3e9f3042d7c8 ("net/hns3: add imissed packet stats") Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hns3/hn

[dpdk-dev] [PATCH 3/7] net/hns3: fix FLR failure when RAS concurrently with FLR

2021-04-09 Thread Min Hu (Connor)
From: Hongbo Zheng Currently, if RAS interrupt and FLR occurred at the same time, FLR will be detected and corresponding schedule state will be set during RAS interrupt processing. However, the schedule state value will be overridden in subsequent RAS processing, resulting in FLR processing failu

[dpdk-dev] [PATCH 0/7] Bugfix for hns3 PMD

2021-04-09 Thread Min Hu (Connor)
This set of patches contains seven bugfixes for hns3 PMD. Chengchang Tang (3): net/hns3: fix incorrect timing in resetting queues net/hns3: fix queue state when concurrent with reset net/hns3: fix configure FEC when concurrent with reset Chengwen Feng (2): net/hns3: remove ariables of sel

[dpdk-dev] [PATCH] net/ice: use write combining store for tail updates on AVX512 path.

2021-04-09 Thread Radu Nicolau
Performance improvement: use a write combining store instead of a regular mmio write to update queue tail registers. Signed-off-by: Radu Nicolau --- drivers/net/ice/ice_rxtx_vec_avx512.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_rxtx_vec_avx512.c

Re: [dpdk-dev] [PATCH v19 1/3] build: disable/enable drivers in Arm builds

2021-04-09 Thread Bruce Richardson
On Fri, Apr 09, 2021 at 10:41:17AM +0200, Juraj Linkeš wrote: > Add support for enabling or disabling drivers for Arm cross build. Do > not implement any enable/disable lists yet. > > Enabling drivers is useful when building for an SoC where we only want > to build a few drivers. That way the list

Re: [dpdk-dev] [PATCH] app/testpmd: fix missing MPLS tokens for RSS

2021-04-09 Thread Ferruh Yigit
On 4/8/2021 10:17 AM, Hemant Agrawal wrote: This patch adds missing MPLS tokens in for RSS config. Fixes: d810252857c9 ("ethdev: add MPLS RSS offload type") Cc: hemant.agra...@nxp.com Signed-off-by: Hemant Agrawal Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.

Re: [dpdk-dev] [PATCH v7 4/4] log: add option argument help

2021-04-09 Thread David Marchand
On Thu, Apr 8, 2021 at 6:47 PM Thomas Monjalon wrote: > > The option --log-level was not completely described in the usage text, > and it was difficult to guess the names of the log types and levels. > > A new value "help" is accepted after --log-level to give more details > about the syntax and l

Re: [dpdk-dev] [PATCH] ethdev: fix VXLAN mask initialization value

2021-04-09 Thread Ferruh Yigit
On 4/8/2021 5:31 PM, Ivan Malov wrote: On 4/8/2021 7:48 AM, Gregory Etelson wrote: In GCC compiler, __builtin_constant_p(exp) is a function. The function returns the integer 1 if the argument is known to be a compile-time constant. Therefore, __builtin_constant_p(0xff << 8) returned 1. As th

Re: [dpdk-dev] [PATCH v3] meson: remove unnecessary explicit link to libpcap

2021-04-09 Thread Thomas Monjalon
09/04/2021 10:31, Gabriel Ganne: > Hi Thomas, > > Thanks for the review. > > The use case that made me see this is that I configured the dpdk using meson > option "-- default_library=static" in conjunction with buildroot which is > patching > meson to prefer static libraries in this case. > This

Re: [dpdk-dev] [PATCH v2 2/3] log: track log level changes

2021-04-09 Thread Thomas Monjalon
09/04/2021 11:08, David Marchand: > On Thu, Apr 8, 2021 at 5:55 PM Thomas Monjalon wrote: > > > > 24/03/2021 11:32, David Marchand: > > > Add a log message when registering log types and changing log levels. > > [...] > > > + RTE_LOG(DEBUG, EAL, "%s logtype level changed from %s to >

Re: [dpdk-dev] [PATCH] net/dpaa2: fix RSS distribution size field

2021-04-09 Thread Ferruh Yigit
On 4/8/2021 10:17 AM, Hemant Agrawal wrote: RSS distribution field is U64, while the DPAA2 code was using integer value, which is causing a issue for MPLS having bit position 33. This patch fixes the code to use unsigned long long. Fixes: 1832bc8ee8d4 ("net/dpaa2: support MPLS distribution") Cc:

Re: [dpdk-dev] [PATCH v2 2/3] log: track log level changes

2021-04-09 Thread David Marchand
On Thu, Apr 8, 2021 at 5:55 PM Thomas Monjalon wrote: > > 24/03/2021 11:32, David Marchand: > > Add a log message when registering log types and changing log levels. > [...] > > + RTE_LOG(DEBUG, EAL, "%s logtype level changed from %s to > > %s\n", > > I would prefer "foo log level cha

Re: [dpdk-dev] [PATCH] net/enic: fix flow initialization error handling

2021-04-09 Thread Ferruh Yigit
On 4/9/2021 12:06 AM, John Daley wrote: Fix a rare case in rte_flow initialization where the action hash table is not freed if allocating a NIC match table fails. Fixes: ea7768b5bba8 ("net/enic: add flow implementation based on Flow Manager API") Cc: sta...@dpdk.org Signed-off-by: John Daley

Re: [dpdk-dev] [PATCH v2 1/2] test/crypto: close PMD after tests

2021-04-09 Thread Dybkowski, AdamX
Thanks for spotting this. I'll move the call to rte_cryptodev_close into the function testsuite_teardown and send v3. Adam > -Original Message- > From: Akhil Goyal > Sent: Thursday, 8 April, 2021 14:16 > To: Dybkowski, AdamX ; dev@dpdk.org; > Doherty, Declan ; Kusztal, ArkadiuszX > > S

Re: [dpdk-dev] [PATCH v19 0/3] Arm build options rework

2021-04-09 Thread Jerin Jacob
On Fri, Apr 9, 2021 at 2:11 PM Juraj Linkeš wrote: > > The current way of specifying Arm configuration options is insufficient > since we can't identify the SoC we're building for from the MIDR > information. For example, we can't distinguish between N1SDP, Graviton2 > or Ampere Altra. > > We also

Re: [dpdk-dev] [PATCH v19 3/3] config: fix Arm implementer and its SoCs

2021-04-09 Thread Ruifeng Wang
> -Original Message- > From: Juraj Linkeš > Sent: Friday, April 9, 2021 4:41 PM > To: bruce.richard...@intel.com; Ruifeng Wang ; > Honnappa Nagarahalli ; Phil Yang > ; vcchu...@amazon.com; Dharmik Thakkar > ; jerinjac...@gmail.com; > hemant.agra...@nxp.com; Ajit Khaparde (ajit.khapa...@bro

[dpdk-dev] [PATCH v19 2/3] build: add 'platform' meson option and Arm SoC config

2021-04-09 Thread Juraj Linkeš
Add Arm SoC configuration sets to Arm meson.build and add an arch agnostic meson option, 'platform', to select from these SoC configurations for meson native builds. This is preferable to specifying a cross file when doing aarch64 -> aarch64 builds, since the cross file specifies the toolchain as w

  1   2   >