Re: [dpdk-dev] [PATCH v7 2/5] eal/windows: hide asprintf() shim

2021-04-10 Thread Nick Connolly
Make asprintf(3) implementation for Windows private to EAL, so that it's hidden from external consumers. It is not exposed to internal consumers either, because they don't need asprintf() and also because callers from other modules would have no reliable way to free allocated memory. Signed-of

[dpdk-dev] [PATCH v3 0/4] Support PPS(packet per second) on meter

2021-04-10 Thread Li Zhang
Currently meter algorithms only supports rate is bytes per second(BPS). Add packet_mode flag in meter profile parameters data structure. So that it can meter traffic by packet per second. When packet_mode is 0, the profile rates and bucket sizes are specified in bytes per second and bytes when pac

[dpdk-dev] [PATCH v3 1/4] ethdev: add packet mode in meter profile structure

2021-04-10 Thread Li Zhang
Currently meter algorithms only supports rate is bytes per second(BPS). Add packet_mode flag in meter profile parameters data structure. So that it can meter traffic by packet per second. When packet_mode is 0, the profile rates and bucket sizes are specified in bytes per second and bytes when pac

[dpdk-dev] [PATCH v3 2/4] app/testpmd: add meter profile packet mode option

2021-04-10 Thread Li Zhang
add meter profile packet_mode to the ethernet device. One example: add port meter profile rfc2697 (port_id) (profile_id) (cir) (cbs) (ebs) (packet_mode) Signed-off-by: Li Zhang Acked-by: Matan Azrad --- app/test-pmd/cmdline_mtr.c | 40 +++-- doc/guides/testpmd_a

[dpdk-dev] [PATCH v3 4/4] net/mvpp2: check meter packet mode

2021-04-10 Thread Li Zhang
Currently meter algorithms only supports bytes per second(BPS). Check packet_mode set to TRUE are rejected. Signed-off-by: Li Zhang Acked-by: Matan Azrad --- drivers/net/mvpp2/mrvl_mtr.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/mvpp2/mrvl_mtr.c b/drivers/net/mvpp2/m

[dpdk-dev] [PATCH v3 3/4] net/softnic: check meter packet mode

2021-04-10 Thread Li Zhang
Currently meter algorithms only supports bytes per second(BPS). Check packet_mode set to TRUE are rejected. Signed-off-by: Li Zhang Acked-by: Matan Azrad --- drivers/net/softnic/rte_eth_softnic_meter.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/softnic/rte_eth_softn

[dpdk-dev] [PATCH v2 2/2] net/mlx5: support meter PPS profile

2021-04-10 Thread Li Zhang
Currently meter algorithms only supports bytes per second(BPS). Such as Single Rate Three Color Marker (srTCM rfc2697) Add packet_mode flag to support rate is packet per second. So that it can meter traffic by packet per second (PPS). Signed-off-by: Li Zhang Acked-by: Matan Azrad --- doc/guides

[dpdk-dev] [PATCH v2 0/2] Support meter PPS(packet per second) in MLX5 PMD

2021-04-10 Thread Li Zhang
Currently meter algorithms only supports rate is bytes per second(BPS). Add packet_mode flag in meter profile parameters data structure. So that it can meter traffic by packet per second. Depends-on: series=16256 ("Support PPS(packet per second) on meter") https://patchwork.dpdk.org/project/dpdk/

[dpdk-dev] [PATCH v2 1/2] common/mlx5: add meter mode definition in PRM file

2021-04-10 Thread Li Zhang
Add meter mode definitions in PRM file Signed-off-by: Li Zhang Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h | 8 1 file changed, 8 insertions(+) diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h index c6d8060bb9..efa5ae67bf 100644 --- a/drivers/c

Re: [dpdk-dev] [PATCH v5] build: alias default build as generic

2021-04-10 Thread Thomas Monjalon
30/03/2021 08:40, Juraj Linkeš: > The current machine='default' build name is not descriptive. The actual > default build is machine='native'. Add an alternative string which does > the same build and better describes what we're building: > machine='generic'. Leave machine='default' for backwards c

[dpdk-dev] [PATCH v2] build: fix symlink of drivers for Windows

2021-04-10 Thread Nick Connolly
The symlink-drivers-solibs.sh script was disabled as part of 'install' for Windows because there is no support for shell scripts. However, this means that driver related DLLs are not present in the installed 'libdir' directory. Add a python script to perform the install and use it for Windows if th

Re: [dpdk-dev] [PATCH] examples/ptpclient: delete wrong comments

2021-04-10 Thread Min Hu (Connor)
Hi, Ferruh, kirill and all, Any comments about this patch? 在 2021/3/27 15:36, Min Hu (Connor) 写道: This patch deletes the comments which are wrong and unnecessary. Fixes: ab129e9065a5 ("examples/ptpclient: add minimal PTP client") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) ---

Re: [dpdk-dev] [PATCH 0/3] fix check of port and core

2021-04-10 Thread Min Hu (Connor)
Hi,Ferruh, bernard, tomasz, bruce and all, Any comments about this set of patches? 在 2021/3/27 15:40, Min Hu (Connor) 写道: Currently, some examples check that the port is on the same NUMA node as the polling thread for best performance. The method is to compare the socket id of port and t

[dpdk-dev] [PATCH] ethdev: add sanity checks in control APIs

2021-04-10 Thread Min Hu (Connor)
This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static functions and variables") Fixes: 0366137722a0 ("ethdev: check for invalid device name") Fixes: d948f596fee2 ("ethdev: f

[dpdk-dev] [PATCH v5] eal: fix create user mem map repeatedly when it exists

2021-04-10 Thread wangyunjian
From: Yunjian Wang Currently, new user mem maps are checked if they are adjacent to an existing mem map and if so, the mem map entries are merged. It doesn't check for duplicate mem maps, so if the API is called with the same mem map multiple times, they will occupy multiple mem map entries. Thi

[dpdk-dev] [PATCH v4 0/4] add support for packed ring in async vhost

2021-04-10 Thread Cheng Jiang
For now async vhost data path only supports split ring structure. In order to make async vhost compatible with virtio 1.1 spec this patch set cleans async split ring codes and enables packed ring in async vhost data path. Batch datapath is also enabled in packed ring. v4: * change the patch stru

[dpdk-dev] [PATCH v4 1/4] vhost: abstract and reorganize async split ring code

2021-04-10 Thread Cheng Jiang
In order to improve code efficiency and readability when async packed ring support is enabled. This patch abstract some functions like shadow_ring_store and write_back_completed_descs_split. And improve the efficiency of some pointer offset calculation. Signed-off-by: Cheng Jiang --- lib/librte_

[dpdk-dev] [PATCH v4 1/4] vhost: abstract and reorganize async split ring code

2021-04-10 Thread Cheng Jiang
In order to improve code efficiency and readability when async packed ring support is enabled. This patch abstract some functions like shadow_ring_store and write_back_completed_descs_split. And improve the efficiency of some pointer offset calculation. Signed-off-by: Cheng Jiang --- lib/librte_

[dpdk-dev] [PATCH v4 2/4] vhost: add support for packed ring in async vhost

2021-04-10 Thread Cheng Jiang
For now async vhost data path only supports split ring structure. In order to make async vhost compatible with virtio 1.1 spec this patch enables packed ring in async vhost data path. Signed-off-by: Cheng Jiang --- lib/librte_vhost/rte_vhost_async.h | 1 + lib/librte_vhost/vhost.c |

[dpdk-dev] [PATCH v4 3/4] vhost: add batch datapath for async vhost packed ring

2021-04-10 Thread Cheng Jiang
Add batch datapath for async vhost packed ring to improve the performance of small packet. Signed-off-by: Cheng Jiang --- lib/librte_vhost/virtio_net.c | 43 +++ 1 file changed, 38 insertions(+), 5 deletions(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/lib

[dpdk-dev] [PATCH v4 4/4] doc: add release note for vhost async packed ring

2021-04-10 Thread Cheng Jiang
Add release note for the support of vhost async packed ring. Signed-off-by: Cheng Jiang --- doc/guides/rel_notes/release_21_05.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_21_05.rst b/doc/guides/rel_notes/release_21_05.rst index 374d6d98e..eb5200669 1

[dpdk-dev] [PATCH 5/7] examples/performance-thread: support set thread name

2021-04-10 Thread Min Hu (Connor)
From: Chengwen Feng This patch supports set helloworld thread name which is helpful for debugging. Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- examples/performance-thread/pthread_shim/main.c | 5 + 1 file changed, 5 insertions(+) diff --git a/examples/performance-thre

[dpdk-dev] [PATCH 4/7] raw/ifpga: support set monitor thread name

2021-04-10 Thread Min Hu (Connor)
From: Chengwen Feng This patch supports set monitor thread name which is helpful for debugging. Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/raw/ifpga/ifpga_rawdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/i

[dpdk-dev] [PATCH 6/7] telemetry: support set init threads name

2021-04-10 Thread Min Hu (Connor)
From: Chengwen Feng This patch supports set init threads name which is helpful for debugging. Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- lib/librte_telemetry/telemetry.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_telemetry/telemetry.c

[dpdk-dev] [PATCH 7/7] examples/vhost_blk: support set ctrl worker thread name

2021-04-10 Thread Min Hu (Connor)
From: Chengwen Feng This patch supports set ctrl worker thread name which is helpful for debugging. Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- examples/vhost_blk/vhost_blk.c | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/vhost_blk/vhost_blk.c b/examples/vhos

[dpdk-dev] [PATCH 0/7] support set thread name

2021-04-10 Thread Min Hu (Connor)
This set of patches support set thread name for debugging. Chengwen Feng (7): net/ark: support set thread name net/ice: support set VSI reset thread name vdpa/ifc: support set notify and vring relay thread name raw/ifpga: support set monitor thread name examples/performance-thread: suppo

[dpdk-dev] [PATCH 3/7] vdpa/ifc: support set notify and vring relay thread name

2021-04-10 Thread Min Hu (Connor)
From: Chengwen Feng This patch supports set notify and vring relay thread name which is helpful for debugging. Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/vdpa/ifc/ifcvf_vdpa.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/vdpa/ifc/ifcvf

[dpdk-dev] [PATCH 2/7] net/ice: support set VSI reset thread name

2021-04-10 Thread Min Hu (Connor)
From: Chengwen Feng This patch supports set VSI reset thread name which is helpful for debugging. Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/ice/ice_dcf_parent.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ice/ice_dcf_parent.c b/driver

[dpdk-dev] [PATCH 1/7] net/ark: support set thread name

2021-04-10 Thread Min Hu (Connor)
From: Chengwen Feng This patch supports set delay packet generator start thread name which is helpful for debugging. Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/ark/ark_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ark/ark_ethdev.c b/

[dpdk-dev] [PATCH 0/2] fix missing check for thread creation

2021-04-10 Thread Min Hu (Connor)
There exist some thread creation function without result check. This set of patches add result check and message print out after failure. Chengwen Feng (2): telemetry: fix missing check for thread creation test: fix missing check for thread creation app/test/process.h |

[dpdk-dev] [PATCH 2/2] test: fix missing check for thread creation

2021-04-10 Thread Min Hu (Connor)
From: Chengwen Feng There was a call for thread create function without result check. Add result check and message print out after failure. Fixes: 086eb64db39e ("test/pdump: add unit test for pdump library") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) ---

[dpdk-dev] [PATCH 1/2] telemetry: fix missing check for thread creation

2021-04-10 Thread Min Hu (Connor)
From: Chengwen Feng Add result check and message print out for thread creation after failure. Fixes: b80fe1805eee ("telemetry: introduce backward compatibility") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- lib/librte_telemetry/telemetry.c| 30 +

[dpdk-dev] [PATCH] ethdev: introduce conntrack flow action and item

2021-04-10 Thread Bing Zhao
This commit introduced the conntrack action and item. Usually the HW offloading is stateless. For some stateful offloading like a TCP connection, HW module will help provide the ability of a full offloading w/o SW participation after the connection was established. The basic usage is that in the

[dpdk-dev] [PATCH v2 1/4] ethdev: introduce indirect action APIs

2021-04-10 Thread Bing Zhao
Right now, rte_flow_shared_action_* APIs are used for some shared actions, like RSS, count. The shared action should be created before using it inside a flow. These shared actions sometimes are not really shared but just some indirect actions decoupled from a flow. The new functions rte_flow_actio

[dpdk-dev] [PATCH v2 0/4] Change shared action API to action handle API

2021-04-10 Thread Bing Zhao
The patch set includes: 1. API changes 2. testpmd adaption and guide update 3. driver update (only net/mlx5 impacted) --- v2: add adaptions of testpmd and driver part --- Bing Zhao (4): ethdev: introduce indirect action APIs app/test-pmd: change to indirect action command doc: update

[dpdk-dev] [PATCH v2 2/4] app/test-pmd: change to indirect action command

2021-04-10 Thread Bing Zhao
Since the APIs are changed from "rte_flow_shared_action*" to the new "rte_flow_action_handle*", the testpmd application code and command line interfaces are also need to be updated to do the adaption. Signed-off-by: Bing Zhao --- app/test-pmd/cmdline.c | 24 ++--- app/test-pmd/cmdline_flow

[dpdk-dev] [PATCH v2 3/4] doc: update user guide for indirect action

2021-04-10 Thread Bing Zhao
The testpmd application user guide is updated. All the "shared action" related parts are replaced with "indirect action" to have a correct explanation. Signed-off-by: Bing Zhao --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 94 ++--- 1 file changed, 47 insertions(+), 4

[dpdk-dev] [PATCH v2 4/4] net/mlx5: adaption to indirect action API

2021-04-10 Thread Bing Zhao
Since the APIs are changed from "rte_flow_shared_action*" to the new "rte_flow_action_handle*" and the "update" interface's 3rd input parameter is changed to generic pointer, mlx5 PMD needs to do the adaption to the new APIs. Signed-off-by: Bing Zhao --- drivers/net/mlx5/mlx5.c | 2 +-

[dpdk-dev] [PATCH v4 0/5] eal: enable global device syntax by default

2021-04-10 Thread Xueming Li
The new Global Device Syntax [1] is used to identify a device with full bus, class and driver description, example: -a bus=pci,addr=82:00.0/class=eth/driver=mlx5,... This patchset fixes bugs and enable global device syntax with backward compatibility by: - unify devargs memory buffer cleanup - pa

[dpdk-dev] [PATCH v4 1/5] devargs: unify scratch buffer storage

2021-04-10 Thread Xueming Li
In current design, legacy parser rte_devargs_parse() saved scratch buffer to devargs.args while new parser rte_devargs_layers_parse() saved to devargs.data. Code using devargs had to know the difference and cleaned up memory accordingly - error prone. This patch unifies scratch buffer to data fiel

[dpdk-dev] [PATCH v4 2/5] devargs: fix memory leak on parsing error

2021-04-10 Thread Xueming Li
This patch fixes memory leak in parsing error handling. Fixes: 338327d731e6 ("devargs: add function to parse device layers") Cc: gaetan.ri...@6wind.com Cc: sta...@dpdk.org Signed-off-by: Xueming Li Reviewed-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_devargs.c | 10 +- 1 file

[dpdk-dev] [PATCH v4 3/5] kvargs: add get by key function

2021-04-10 Thread Xueming Li
Adds a new function to get value of a specific key from kvargs list. Signed-off-by: Xueming Li Reviewed-by: Gaetan Rivet --- lib/librte_kvargs/rte_kvargs.c | 20 lib/librte_kvargs/rte_kvargs.h | 21 + lib/librte_kvargs/version.map | 3 +++ 3 files chan

[dpdk-dev] [PATCH v4 4/5] bus: add device arguments name parsing API

2021-04-10 Thread Xueming Li
For device probe and iterator, devargs name was key information, parsed by rte_devargs_parse. In legacy parser, devargs name was extracted after bus name: bus:name,kv_arguments,,, Example: pci:83:00.0,arguments,... vdev:pcap0,... To be compatible with legacy parser, this patch introduces new

[dpdk-dev] [PATCH v4 5/5] devargs: parse global device syntax

2021-04-10 Thread Xueming Li
When parsing a devargs, try to parse using the global device syntax first. Fallback on legacy syntax on error. Example of new global device syntax: -a bus=pci,addr=82:00.0/class=eth/driver=mlx5,dv_flow_en=1 Signed-off-by: Xueming Li Reviewed-by: Gaetan Rivet --- doc/guides/rel_notes/release_2

[dpdk-dev] [PATCH v2 0/8] baseband: add NXP LA12xx driver

2021-04-10 Thread Hemant Agrawal
This series introduces the BBDEV LA12xx poll mode driver (PMD) to support an implementation for offloading High Phy processing functions like LDPC Encode / Decode 5GNR wireless acceleration function, using PCI based LA12xx Software defined radio. Please check the documentation patch for more inf

[dpdk-dev] [PATCH v2 1/8] baseband: introduce NXP LA12xx driver

2021-04-10 Thread Hemant Agrawal
This patch introduce the baseband device drivers for NXP's LA1200 series software defined baseband modem. Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- drivers/baseband/la12xx/bbdev_la12xx.c| 109 ++ .../baseband/la12xx/bbdev_la12xx_pmd_logs.h | 38

[dpdk-dev] [PATCH v2 2/8] baseband/la12xx: add devargs for max queues

2021-04-10 Thread Hemant Agrawal
This patch adds dev args to take max queues as input Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- drivers/baseband/la12xx/bbdev_la12xx.c | 72 +- 1 file changed, 70 insertions(+), 2 deletions(-) diff --git a/drivers/baseband/la12xx/bbdev_la12xx.c b/dri

[dpdk-dev] [PATCH v2 3/8] baseband/la12xx: add support for multiple modems

2021-04-10 Thread Hemant Agrawal
This patch add support for multiple modems by assigning a modem id as dev args in vdev creation. Signed-off-by: Hemant Agrawal --- drivers/baseband/la12xx/bbdev_la12xx.c | 62 +++--- drivers/baseband/la12xx/bbdev_la12xx.h | 56 +++ drivers/baseband/la12xx/

[dpdk-dev] [PATCH v2 4/8] baseband/la12xx: add queue and modem config support

2021-04-10 Thread Hemant Agrawal
This patch add support for connecting with modem and creating the ipc channel as queues with modem for the exchange of data. Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- drivers/baseband/la12xx/bbdev_la12xx.c | 566 - drivers/baseband/la12xx/bbdev_la12xx.

[dpdk-dev] [PATCH v2 5/8] baseband/la12xx: add enqueue and dequeue support

2021-04-10 Thread Hemant Agrawal
Add support for enqueue and dequeue the LDPC enc/dec from the modem device. Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- drivers/baseband/la12xx/bbdev_la12xx.c | 397 - drivers/baseband/la12xx/bbdev_la12xx_ipc.h | 37 ++ 2 files changed, 430 insertions(+

[dpdk-dev] [PATCH v2 6/8] baseband/la12xx: add documentation support

2021-04-10 Thread Hemant Agrawal
This patch add documentation for LA12xx PMD. Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- MAINTAINERS| 9 ++ doc/guides/bbdevs/features/la12xx.ini | 14 +++ doc/guides/bbdevs/index.rst| 1 + doc/guides/bbdevs/la12xx.rst | 1

[dpdk-dev] [PATCH v2 7/8] app/bbdev: add parameter to take input in network order

2021-04-10 Thread Hemant Agrawal
From: Nipun Gupta Test bbdev application is reading the input and output from the test vector files in the same endianness which is of the system. This patch adds an option to provide data in the network order i.e. big endian format Signed-off-by: Nipun Gupta --- app/test-bbdev/test_bbdev_vect

[dpdk-dev] [PATCH v2 8/8] app/bbdev: add test vectors for transport blocks

2021-04-10 Thread Hemant Agrawal
From: Nipun Gupta This patch adds two test vectors for transport block in network byte order: - LDPC encode for Transport Block - LDPC decode for Transport block Signed-off-by: Nipun Gupta --- app/test-bbdev/test_vectors/ldpc_dec_tb.data | 362 ++ app/test-bbdev/test_vectors/ldpc_e

[dpdk-dev] [PATCH] eal/windows: fix pthreads macros return values

2021-04-10 Thread Tal Shnaiderman
The macro definitions of the following pthread functions return incorrect values from the inner function return code. while pthread_barrier_init, pthread_barrier_destroy and pthread_cancel return 0 in a case of success and non zero (errno) value otherwise the shimming functions InitializeSynchroni

Re: [dpdk-dev] [PATCH v4 1/5] devargs: unify scratch buffer storage

2021-04-10 Thread Tal Shnaiderman
> Subject: [dpdk-dev] [PATCH v4 1/5] devargs: unify scratch buffer storage > > In current design, legacy parser rte_devargs_parse() saved scratch buffer to > devargs.args while new parser rte_devargs_layers_parse() saved to > devargs.data. Code using devargs had to know the difference and cleaned

[dpdk-dev] [PATCH] common/mlx5: export all compiled functions on Windows

2021-04-10 Thread Tal Shnaiderman
The functions mlx5_devx_cmd_*, mlx5_mp_* and mlx5_memory_stat_dump are compiled however some of them are marked with the WINDOWS_NO_EXPORT tag as they are not used. removing the tag to leave only functions which are not compiled for Windows. Signed-off-by: Tal Shnaiderman --- drivers/common/ml

Re: [dpdk-dev] [pull-request] dpdk-next-net-mrvl for-dpdk-main - 21.05 - PRE-RC1

2021-04-10 Thread Thomas Monjalon
09/04/2021 09:17, Jerin Jacob Kollanukkaran: > http://dpdk.org/git/next/dpdk-next-net-mrvl for-dpdk-main Pulled, thanks. Note: I tried to fix some acronyms which were missing uppercasing in titles. Also "add support for" is shorter as "support".

[dpdk-dev] [PATCH v9 0/4] eal/windows: do not expose POSIX symbols

2021-04-10 Thread Dmitry Kozlyuk
On Windows, EAL contains two sets of functions and macros for POSIX compatibility: and a networking shim (socket headers). The latter conflicts with system headers and should not exist. Exposing the former from EAL can break consumer own POSIX compatibility layer and is against standards in genera

[dpdk-dev] [PATCH v9 1/4] eal/windows: hide asprintf() shim

2021-04-10 Thread Dmitry Kozlyuk
Make asprintf(3) implementation for Windows private to EAL, so that it's hidden from external consumers. It is not exposed to internal consumers either, because they don't need asprintf() and also because callers from other modules would have no reliable way to free allocated memory. Signed-off-by

[dpdk-dev] [PATCH v9 2/4] eal: make OS shims internal

2021-04-10 Thread Dmitry Kozlyuk
DPDK code often relies on functions and macros that are not standard C, but are found on all platforms, even if by slightly different names. Windows provided macros or inline definitions for such symbols. However, when placed in public header, these symbols were unnecessarily exposed, breaking con

[dpdk-dev] [PATCH v9 3/4] net: work around s_addr macro on Windows

2021-04-10 Thread Dmitry Kozlyuk
Windows Sockets headers contain `#define s_addr S_un.S_addr`, which conflicts with definition of `s_addr` field of `struct rte_ether_hdr`. Prieviously `s_addr` was undefined in , which had been breaking access to `s_addr` field of `struct in_addr`, so some DPDK and Windows headers could not be incl

[dpdk-dev] [PATCH v9 4/4] net: provide IP-related API on any OS

2021-04-10 Thread Dmitry Kozlyuk
Users of relied on it to provide IP-related defines, like IPPROTO_* constants, but still had to include POSIX headers for inet_pton() and other standard IP-related facilities. Extend so that it is a single header to gain access to IP-related facilities on any OS. Use it to replace POSIX includes

Re: [dpdk-dev] [PATCH] ethdev: add packet integrity checks

2021-04-10 Thread Ori Kam
Hi Jerin & Ajit > -Original Message- > From: Ajit Khaparde > Sent: Sunday, April 11, 2021 7:13 AM > > On Thu, Apr 8, 2021 at 12:44 AM Jerin Jacob wrote: > > > > On Thu, Apr 8, 2021 at 3:45 AM Ori Kam wrote: > > > > > > Hi Jerin, > > > > > > > -Original Message- > > > > From: Je

[dpdk-dev] [PATCH v3 2/4] common/iavf: add proto header for IP fragment

2021-04-10 Thread Jeff Guo
Add new virtchnl protocol header type and fields for IP fragment packets to support RSS hash and FDIR. Signed-off-by: Ting Xu Signed-off-by: Jeff Guo --- drivers/common/iavf/virtchnl.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iav

[dpdk-dev] [PATCH v3 1/4] app/testpmd: add packet id for IP fragment

2021-04-10 Thread Jeff Guo
Add the new items to support the flow configuration for IP fragment packets. Signed-off-by: Ting Xu Signed-off-by: Jeff Guo --- app/test-pmd/cmdline_flow.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdlin

[dpdk-dev] [PATCH v3 3/4] net/iavf: support RSS hash for IP fragment

2021-04-10 Thread Jeff Guo
New pattern and RSS hash flow parsing are added to handle fragmented IPv4/IPv6 packet. Signed-off-by: Ting Xu Signed-off-by: Jeff Guo --- drivers/net/iavf/iavf_generic_flow.c | 24 drivers/net/iavf/iavf_generic_flow.h | 3 + drivers/net/iavf/iavf_hash.c | 83 +

[dpdk-dev] [PATCH v3 4/4] net/iavf: support FDIR for IP fragment packet

2021-04-10 Thread Jeff Guo
New FDIR parsing are added to handle the fragmented IPv4/IPv6 packet. Signed-off-by: Ting Xu Signed-off-by: Jeff Guo --- drivers/net/iavf/iavf_fdir.c | 376 ++- drivers/net/iavf/iavf_generic_flow.h | 5 + 2 files changed, 257 insertions(+), 124 deletions(-) di

[dpdk-dev] [PATCH v3 0/3] support flow for IP fragment in ICE

2021-04-10 Thread Jeff Guo
Support RSS hash and FDIR for IP fragment packets in ICE PMD. v3: rebase code and fix some parsing issues. v2: add some input check Jeff Guo (3): net/ice/base: support IP fragment RSS and FDIR net/ice: support RSS hash for IP fragment net/ice: support FDIR for IP fragment packet drivers/n

[dpdk-dev] [PATCH v3 1/3] net/ice/base: support IP fragment RSS and FDIR

2021-04-10 Thread Jeff Guo
Add support for IP fragment RSS hash and FDIR according to packet ID. Separate IP fragment and IP other packet types. Signed-off-by: Ting Xu Signed-off-by: Jeff Guo --- drivers/net/ice/base/ice_fdir.c | 50 +++-- drivers/net/ice/base/ice_fdir.h | 22 ---

[dpdk-dev] [PATCH v3 2/3] net/ice: support RSS hash for IP fragment

2021-04-10 Thread Jeff Guo
New pattern and RSS hash flow parsing are added to handle fragmented IPv4/IPv6 packet. Signed-off-by: Jeff Guo --- drivers/net/ice/ice_generic_flow.c | 21 + drivers/net/ice/ice_generic_flow.h | 6 drivers/net/ice/ice_hash.c | 48 +- 3 files

[dpdk-dev] [PATCH v3 3/3] net/ice: support FDIR for IP fragment packet

2021-04-10 Thread Jeff Guo
New FDIR parsing are added to handle the fragmented IPv4/IPv6 packet. Signed-off-by: Jeff Guo Signed-off-by: Ting Xu --- drivers/net/ice/ice_fdir_filter.c | 116 ++--- drivers/net/ice/ice_generic_flow.c | 1 + 2 files changed, 106 insertions(+), 11 deletions(-) diff

[dpdk-dev] [PATCH v3 0/3] support flow for IP fragment in ICE

2021-04-10 Thread Jeff Guo
Support RSS hash and FDIR for IP fragment packets in ICE PMD. v3: rebase code and fix some parsing issues. v2: add some input check Jeff Guo (3): net/ice/base: support IP fragment RSS and FDIR net/ice: support RSS hash for IP fragment net/ice: support FDIR for IP fragment packet drivers/n

Re: [dpdk-dev] [PATCH] ethdev: add packet integrity checks

2021-04-10 Thread Ori Kam
Hi Andrew, PSB, Best, Ori > -Original Message- > From: Andrew Rybchenko > > On 4/8/21 2:39 PM, Ori Kam wrote: > > Hi Andrew, > > > > Thanks for your comments. > > > > PSB, > > > > Best, > > Ori > > > >> -Original Message- > >> From: Andrew Rybchenko > >> Sent: Thursday, April 8