Re: [dpdk-dev] [PATCH] eal/windows: fix build warnings in MinGW

2021-04-18 Thread Tal Shnaiderman
> Subject: Re: [PATCH] eal/windows: fix build warnings in MinGW > > External email: Use caution opening links or attachments > > > Hi Tal, > > 2021-04-18 19:04 (UTC+), Tal Shnaiderman: > > > Subject: Re: [PATCH] eal/windows: fix build warnings in MinGW > > > > > > External email: Use cautio

Re: [dpdk-dev] [PATCH v9] app/testpmd: support multi-process

2021-04-18 Thread Singh, Aman Deep
Tested-by: Aman Deep Singh

Re: [dpdk-dev] [PATCH] app/testpmd: support the query of link flow ctrl info

2021-04-18 Thread Min Hu (Connor)
Hi, 在 2021/4/19 10:53, Li, Xiaoyun 写道: Hi -Original Message- From: Min Hu (Connor) Sent: Thursday, April 15, 2021 14:47 To: dev@dpdk.org Cc: Yigit, Ferruh ; Li, Xiaoyun Subject: [PATCH] app/testpmd: support the query of link flow ctrl info From: Huisong Li This patch supports the

Re: [dpdk-dev] [RFC 3/3] net/virtio: add MAC device config getter and setter

2021-04-18 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Friday, March 19, 2021 6:35 AM > To: dev@dpdk.org; Xia, Chenbo ; amore...@redhat.com; > david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [RFC 3/3] net/virtio: add MAC device config getter and setter > > This patch

[dpdk-dev] [PATCH 0/2] fixes for link speed

2021-04-18 Thread Min Hu (Connor)
This patchset contains fixes for link speed in testpmd. Huisong Li (2): app/testpmd: add link speed check before port start app/testpmd: fix link speed for a specified port app/test-pmd/cmdline.c | 48 +++-- 1 file changed, 42 insertions(+), 6 deletions(-) --

[dpdk-dev] [PATCH 2/2] app/testpmd: fix link speed for a specified port

2021-04-18 Thread Min Hu (Connor)
From: Huisong Li When we use the following cmd to modify the link speed of specified port: "port config speed xxx duplex xxx", we have to stop all ports. It's not necessary. Fixes: 82113036e4e5 ("ethdev: redesign link speed config") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by:

[dpdk-dev] [PATCH 1/2] app/testpmd: add link speed check before port start

2021-04-18 Thread Min Hu (Connor)
From: Huisong Li Currently, to check whether the configured link_speeds is valid, we have to run "port start". In addition, if the configuration fails, "port->dev_conf.link_speeds" maintained in testpmd cannot be restored. This patch adds the link_speeds check before port start by calling dev_co

[dpdk-dev] [PATCH] examples/vhost: fix potential overflow in args process

2021-04-18 Thread Cheng Jiang
Add args length check to fix potential overflow issue. Coverity issue: 363741 Fixes: 965b06f0358 ("examples/vhost: enhance getopt_long usage") Cc: sta...@dpdk.org Signed-off-by: Cheng Jiang --- examples/vhost/main.c | 5 + 1 file changed, 5 insertions(+) diff --git a/examples/vhost/main.c

[dpdk-dev] [PATCH] net/iavf: fix hash configuration on Fortville VF

2021-04-18 Thread Alvin Zhang
In i40evf PMD, the VF directly accesses the hash enable registers to enable or disable hashing on ingress packets. When binding Fortville VF to iavf, because the PF doesn't support VIRTCHNL_VF_OFFLOAD_ADV_RSS_PF capability. Therefore, the VF hashing cannot be enabled. This patch adds support of ha

Re: [dpdk-dev] [PATCH v2 3/4] vhost: avoid deadlock on async register

2021-04-18 Thread Hu, Jiayu
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Friday, April 16, 2021 4:34 PM > To: Hu, Jiayu ; dev@dpdk.org > Cc: Xia, Chenbo ; Wang, Yinan > ; Pai G, Sunil ; Jiang, Cheng1 > > Subject: Re: [PATCH v2 3/4] vhost: avoid deadlock on async register > > > > On 4/16/21 10:

Re: [dpdk-dev] 19.11.8 patches review and test

2021-04-18 Thread Pei Zhang
Hi Christian, The testing with dpdk 19.11.8-rc1 from Red Hat looks good. We tested below 16 scenarios and and all got PASS on RHEL8: (1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS (2)Guest with device assignment(PF) throughput testing(2M hugepage size) : PASS (3)Gu

[dpdk-dev] [PATCH v7] net/iavf: deprecate i40evf pmd

2021-04-18 Thread Robin Zhang
The i40evf PMD will be deprecated, iavf will be the only VF driver for Intel 700 serial (i40e) NIC family. To reach this, there will be 2 steps: Step 1: iavf will be the default VF driver, while i40evf still can be selected by devarg: "driver=i40evf". This is covered by this patch, which include:

Re: [dpdk-dev] [PATCH V3] app/testpmd: support Tx mbuf free on demand cmd

2021-04-18 Thread Li, Xiaoyun
Hi > -Original Message- > From: Lijun Ou > Sent: Monday, April 12, 2021 21:13 > To: Yigit, Ferruh > Cc: Li, Xiaoyun ; dev@dpdk.org; > linux...@openeuler.org > Subject: [PATCH V3] app/testpmd: support Tx mbuf free on demand cmd > > From: Chengwen Feng > > This patch support tx_done_cle

Re: [dpdk-dev] [PATCH] app/testpmd: support the query of link flow ctrl info

2021-04-18 Thread Li, Xiaoyun
Hi > -Original Message- > From: Min Hu (Connor) > Sent: Thursday, April 15, 2021 14:47 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Li, Xiaoyun > Subject: [PATCH] app/testpmd: support the query of link flow ctrl info > > From: Huisong Li > > This patch supports the query of the link flow

Re: [dpdk-dev] [PATCH] app/testpmd: add link autoneg status display

2021-04-18 Thread Li, Xiaoyun
Hi > -Original Message- > From: Min Hu (Connor) > Sent: Thursday, April 15, 2021 14:45 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Li, Xiaoyun > Subject: [PATCH] app/testpmd: add link autoneg status display > > From: Huisong Li > > This patch adds link autoneg status display in port_info

Re: [dpdk-dev] [PATCH v6] net/iavf: deprecate i40evf pmd

2021-04-18 Thread Xing, Beilei
> -Original Message- > From: Zhang, RobinX > Sent: Friday, April 16, 2021 9:58 AM > To: dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia ; Wang, > Haiyue ; m...@ashroe.eu; nhor...@tuxdriver.com; > Wu, Jingjing ; Yang, Qiming > ; Yang, SteveX ; Zhang, > RobinX > Subject: [PATCH v6] net/iavf: d

Re: [dpdk-dev] [PATCH V5] ethdev: add queue state when retrieve queue information

2021-04-18 Thread oulijun
在 2021/4/18 6:00, Ferruh Yigit 写道: On 4/17/2021 4:09 AM, Lijun Ou wrote: Currently, upper-layer application could get queue state only through pointers such as dev->data->tx_queue_state[queue_id], this is not the recommended way to access it. So this patch add get queue state when call rte_et

[dpdk-dev] [PATCH V6] ethdev: add queue state when retrieve queue information

2021-04-18 Thread Lijun Ou
Currently, upper-layer application could get queue state only through pointers such as dev->data->tx_queue_state[queue_id], this is not the recommended way to access it. So this patch add get queue state when call rte_eth_rx_queue_info_get and rte_eth_tx_queue_info_get API. Note: After add queue_s

Re: [dpdk-dev] [PATCH V5] ethdev: add queue state when retrieve queue information

2021-04-18 Thread oulijun
在 2021/4/18 6:00, Ferruh Yigit 写道: On 4/17/2021 4:09 AM, Lijun Ou wrote: Currently, upper-layer application could get queue state only through pointers such as dev->data->tx_queue_state[queue_id], this is not the recommended way to access it. So this patch add get queue state when call rte_et

Re: [dpdk-dev] [PATCH v10] app/testpmd: support multi-process

2021-04-18 Thread Min Hu (Connor)
Thanks Ferruh, fixed in v11, thanks. 在 2021/4/18 6:21, Ferruh Yigit 写道: On 4/17/2021 7:12 AM, Min Hu (Connor) wrote: This patch adds multi-process support for testpmd. The test cmd example as follows: the primary cmd: ./dpdk-testpmd -a xxx --proc-type=auto -l 0-1 -- -i \ --rxq=4 --txq=4 --num-p

[dpdk-dev] [PATCH v11] app/testpmd: support multi-process

2021-04-18 Thread Min Hu (Connor)
This patch adds multi-process support for testpmd. The test cmd example as follows: the primary cmd: ./dpdk-testpmd -a xxx --proc-type=auto -l 0-1 -- -i \ --rxq=4 --txq=4 --num-procs=2 --proc-id=0 the secondary cmd: ./dpdk-testpmd -a xxx --proc-type=auto -l 2-3 -- -i \ --rxq=4 --txq=4 --num-procs=

Re: [dpdk-dev] [PATCH v6] ethdev: add sanity checks in control APIs

2021-04-18 Thread Min Hu (Connor)
在 2021/4/18 5:37, Thomas Monjalon 写道: 17/04/2021 02:28, Min Hu (Connor): 在 2021/4/17 0:28, Stephen Hemminger 写道: On Fri, 16 Apr 2021 11:22:02 +0100 Kevin Traynor wrote: + if (dev_conf == NULL) { + RTE_ETHDEV_LOG(ERR, + "Cannot configure ethdev po

Re: [dpdk-dev] [PATCH 00/14] Build file updates

2021-04-18 Thread Thomas Monjalon
16/04/2021 19:04, Bruce Richardson: > RFC -> V1: > * rebased to current main branch > * performed cleanup on many meson.build files to ensure correct formatting of > lists: >* split lists with >3 or >4 entries to be one per line >* first entry on own line >* last entry on own line wit

Re: [dpdk-dev] [pull-request] next-eventdev 21.05-rc1

2021-04-18 Thread Thomas Monjalon
17/04/2021 19:28, Jerin Jacob Kollanukkaran: > http://dpdk.org/git/next/dpdk-next-eventdev Pulled, thanks

Re: [dpdk-dev] [PATCH v6 1/2] ethdev: add packet integrity checks

2021-04-18 Thread Thomas Monjalon
Please read again the comment I did below, and try 32-bit bitfield instead of 64-bit. 18/04/2021 21:24, Gregory Etelson: > Hello Thomas, > > I modified the following drivers/net/mlx5/mlx5_flow_age.c compilation command > to produce pre-processed source code output: > > 1 # 1 "../drivers/ne

Re: [dpdk-dev] [PATCH] eal/windows: fix build warnings in MinGW

2021-04-18 Thread Dmitry Kozlyuk
Hi Tal, 2021-04-18 19:04 (UTC+), Tal Shnaiderman: > > Subject: Re: [PATCH] eal/windows: fix build warnings in MinGW > > > > External email: Use caution opening links or attachments > > > > > > 18/04/2021 19:08, Tal Shnaiderman: > > > the strncasecmp marco defined in rte_os_shim.h is alrea

Re: [dpdk-dev] [PATCH v5 00/14] Add ASO meter support in MLX5 PMD

2021-04-18 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Li Zhang > Sent: Thursday, April 15, 2021 6:11 PM > To: dek...@nvidia.com; Ori Kam ; Slava Ovsiienko > ; Matan Azrad ; Shahaf > Shuler > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon > ; Raslan Darawsheh ; Roni > Bar Yanai > Subject: [PATCH v5 00/14] Add

Re: [dpdk-dev] [PATCH v6 1/2] ethdev: add packet integrity checks

2021-04-18 Thread Gregory Etelson
Hello Thomas, I modified the following drivers/net/mlx5/mlx5_flow_age.c compilation command to produce pre-processed source code output: 1 # 1 "../drivers/net/mlx5/mlx5_flow_age.c" 2 # 1 "/.autodirect/mtrswgwork/getelson/src/dpdk/stable/build-dev//" 3 # 1 "" 4 #define __STDC__

Re: [dpdk-dev] [PATCH v5 9/9] app/testpmd: enable building testpmd on Windows

2021-04-18 Thread Tal Shnaiderman
> Subject: Re: [dpdk-dev] [PATCH v5 9/9] app/testpmd: enable building > testpmd on Windows > > External email: Use caution opening links or attachments > > > > Subject: Re: [dpdk-dev] [PATCH v5 9/9] app/testpmd: enable building > > testpmd on Windows > > > > External email: Use caution opening l

Re: [dpdk-dev] [PATCH v5 9/9] app/testpmd: enable building testpmd on Windows

2021-04-18 Thread Tal Shnaiderman
> Subject: Re: [dpdk-dev] [PATCH v5 9/9] app/testpmd: enable building > testpmd on Windows > > External email: Use caution opening links or attachments > > > 18/04/2021 19:21, Tal Shnaiderman: > > Building testpmd results in 2 warnings in clang: > > > > ../app/test-pmd/config.c:4254:1: warning:

Re: [dpdk-dev] [PATCH] eal/windows: fix build warnings in MinGW

2021-04-18 Thread Tal Shnaiderman
> Subject: Re: [PATCH] eal/windows: fix build warnings in MinGW > > External email: Use caution opening links or attachments > > > 18/04/2021 19:08, Tal Shnaiderman: > > the strncasecmp marco defined in rte_os_shim.h is already defined in > > MinGW-w64, as a result the compiler prints out the wa

Re: [dpdk-dev] [PATCH v5 9/9] app/testpmd: enable building testpmd on Windows

2021-04-18 Thread Thomas Monjalon
18/04/2021 19:21, Tal Shnaiderman: > Building testpmd results in 2 warnings in clang: > > ../app/test-pmd/config.c:4254:1: warning: unused function 'print_fdir_mask' > [-Wunused-function] > print_fdir_mask(struct rte_eth_fdir_masks *mask) > ^ > ../app/test-pmd/config.c:4289:1: warning: unused fun

Re: [dpdk-dev] [PATCH] eal/windows: fix build warnings in MinGW

2021-04-18 Thread Thomas Monjalon
18/04/2021 19:08, Tal Shnaiderman: > the strncasecmp marco defined in rte_os_shim.h is already > defined in MinGW-w64, as a result the compiler prints out > the warning below on function redefinition whenever compiling > a file including the header. > > ..\lib/librte_eal/windows/include/rte_os_shi

Re: [dpdk-dev] [PATCH v6 1/2] ethdev: add packet integrity checks

2021-04-18 Thread Thomas Monjalon
18/04/2021 17:51, Gregory Etelson: > +__extension__ That still doesn't make sense, as in v5. The things which require a macro are anonymous union, anonymous struct and some bit fields with special sizes. > +struct rte_flow_item_integrity { > + /**< Tunnel encapsulation level the item should a

Re: [dpdk-dev] [PATCH v5 1/2] ethdev: add packet integrity checks

2021-04-18 Thread Thomas Monjalon
18/04/2021 10:15, Gregory Etelson: > > > > +__extension__ > > > > > > Why extension here? > > > If this is because of the anonymous union, it should be RTE_STD_C11 > > > before the union. > > > Same for the struct. > > > > > O.K > > The RTE_STD_C11 macro fails compilation on > RHEL-7.9 with gcc v

Re: [dpdk-dev] [PATCH v5 9/9] app/testpmd: enable building testpmd on Windows

2021-04-18 Thread Tal Shnaiderman
> Subject: [dpdk-dev] [PATCH v5 9/9] app/testpmd: enable building testpmd > on Windows > > External email: Use caution opening links or attachments > > > From: Jie Zhou > > - Disable unsupported Apps on Windows > - Enable building of testpmd on Windows > > Signed-off-by: Jie Zhou > Signed-of

Re: [dpdk-dev] [PATCH v5 5/9] app/testpmd: add clock_gettime_monotonic

2021-04-18 Thread Tal Shnaiderman
> Subject: [dpdk-dev] [PATCH v5 5/9] app/testpmd: add > clock_gettime_monotonic > > External email: Use caution opening links or attachments > > > Add clock_gettime_monotonic for testpmd on Windows > > Signed-off-by: Jie Zhou > Signed-off-by: Jie Zhou > --- > app/test-pmd/config.c | 33 +

[dpdk-dev] [PATCH] eal/windows: fix build warnings in MinGW

2021-04-18 Thread Tal Shnaiderman
the strncasecmp marco defined in rte_os_shim.h is already defined in MinGW-w64, as a result the compiler prints out the warning below on function redefinition whenever compiling a file including the header. ..\lib/librte_eal/windows/include/rte_os_shim.h:21: warning: "strncasecmp" redefined #defin

[dpdk-dev] [PATCH v6 2/2] app/testpmd: add support for integrity item

2021-04-18 Thread Gregory Etelson
From: Ori Kam The integrity item allows the application to match on the integrity of a packet. use example: match that packet integrity checks are ok. The checks depend on packet layers. For example ICMP packet will not check L4 level. flow create 0 ingress pattern integrity value mask 0x01 valu

[dpdk-dev] [PATCH v6 0/2] add packet integrity checks

2021-04-18 Thread Gregory Etelson
v6: update API comments Ori Kam (2): ethdev: add packet integrity checks app/testpmd: add support for integrity item app/test-pmd/cmdline_flow.c | 39 doc/guides/prog_guide/rte_flow.rst | 20 + doc/guides/rel_notes/release_21_05.rst | 5

[dpdk-dev] [PATCH v6 1/2] ethdev: add packet integrity checks

2021-04-18 Thread Gregory Etelson
From: Ori Kam Currently, DPDK application can offload the checksum check, and report it in the mbuf. However, as more and more applications are offloading some or all logic and action to the HW, there is a need to check the packet integrity so the right decision can be taken. The application lo

Re: [dpdk-dev] [PATCH] examples/vhost: fix ioat ring space in callbacks

2021-04-18 Thread Liang Ma
On Wed, Apr 07, 2021 at 10:43:36AM +0200, Thomas Monjalon wrote: > +Cc more people to start a discussion about a potential DMA API. > If you think it is interesting, we can start a fresh discussion thread. +1 that's ineresting to have a abstract layer of DMA offload engine. I would like join th

Re: [dpdk-dev] Question about enable CBDMA with ioat PMD ?

2021-04-18 Thread Liang Ma
On Wed, Apr 14, 2021 at 04:33:10PM +0100, Burakov, Anatoly wrote: > On 14-Apr-21 2:45 PM, Liang Ma wrote: > > On Wed, Apr 14, 2021 at 02:21:53PM +0100, Bruce Richardson wrote: > > > On Wed, Apr 14, 2021 at 01:52:14PM +0100, Liang Ma wrote: > > > > On Wed, Apr 14, 2021 at 11:48:03AM +0100, Bruce Ric

Re: [dpdk-dev] [PATCH] doc: announce modification in eventdev structure

2021-04-18 Thread Jerin Jacob
On Thu, Apr 15, 2021 at 2:39 PM wrote: > > From: Akhil Goyal > > A new field ``ca_enqueue`` is added in ``rte_eventdev`` > in the end to maintain ABI. It needs to be moved above > in the structure to align with other enqueue callbacks. > > Signed-off-by: Akhil Goyal Acked-by: Jerin Jacob > -

Re: [dpdk-dev] [PATCH 00/14] Build file updates

2021-04-18 Thread Xueming(Steven) Li
Hi Bruce, > -Original Message- > From: dev On Behalf Of Bruce Richardson > Sent: Saturday, April 17, 2021 1:05 AM > To: dev@dpdk.org > Cc: Bruce Richardson > Subject: [dpdk-dev] [PATCH 00/14] Build file updates > > This RFC contains 5 changes/updates to the DPDK build and build files. >

Re: [dpdk-dev] [PATCH v5 1/2] ethdev: add packet integrity checks

2021-04-18 Thread Gregory Etelson
Hello Thomas, Please see my comment on the use of RTE_STD_C11 below. Regards, Gregory. > > > Currently, DPDK application can offload the checksum check, and > > > report it in the mbuf. > > > > > > However, as more and more applications are offloading some or all > > > logic and action to the HW