Re: [dpdk-dev] [PATCH] version: 21.08-rc0

2021-05-21 Thread Thomas Monjalon
21/05/2021 18:45, David Marchand: > Start a new release cycle with empty release notes. > > Signed-off-by: David Marchand Acked-by: Thomas Monjalon Let's start a new cycle, yeah!

[dpdk-dev] [dpdk-announce] DPDK 21.05 released

2021-05-21 Thread Thomas Monjalon
A new release is available: https://fast.dpdk.org/rel/dpdk-21.05.tar.xz It was a quite big cycle as usual with May releases: 1352 commits from 176 authors 2396 files changed, 134413 insertions(+), 63913 deletions(-) It is not planned to start a maintenance branch for 21.05

[dpdk-dev] [PATCH] version: 21.08-rc0

2021-05-21 Thread David Marchand
Start a new release cycle with empty release notes. Signed-off-by: David Marchand --- .github/workflows/build.yml| 2 +- .travis.yml| 2 +- ABI_VERSION| 2 +- VERSION| 2 +- doc/guides/rel

Re: [dpdk-dev] [dpdk-dev v1] cperf: fix crypto perf out-of-place mempool alloc

2021-05-21 Thread Thomas Monjalon
> > > Add in missing rte_mbuf size in mempool allocation for out-of-place op. > > > > > > Fixes: bf9d6702eca9 ("app/crypto-perf: use single mempool") > > > Cc: pablo.de.lara.gua...@intel.com > > > > > > Signed-off-by: Kai Ji > > Acked-by: Fan Zhang > Acked-by: Pablo de Lara Given the root cause

Re: [dpdk-dev] [PATCH] acl: fix build with GCC 6.3

2021-05-21 Thread Liang Ma
On Fri, May 21, 2021 at 05:10:41PM +0200, Thomas Monjalon wrote: > 21/05/2021 16:42, Konstantin Ananyev: > > --buildtype=debug with gcc 6.3 produces the following error: > > > > ../lib/librte_acl/acl_run_avx512_common.h: In function > > ‘resolve_match_idx_avx512x16’: > > ../lib/librte_acl/acl_run_

Re: [dpdk-dev] [PATCH] acl: fix build with GCC 6.3

2021-05-21 Thread Ananyev, Konstantin
> -Original Message- > From: Thomas Monjalon > Sent: Friday, May 21, 2021 4:11 PM > To: lian...@liangbit.com; Ananyev, Konstantin > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] acl: fix build with GCC 6.3 > > 21/05/2021 16:42, Konstantin Ananyev: > > --buildtype=

Re: [dpdk-dev] [PATCH] acl: fix build with GCC 6.3

2021-05-21 Thread Thomas Monjalon
21/05/2021 16:42, Konstantin Ananyev: > --buildtype=debug with gcc 6.3 produces the following error: > > ../lib/librte_acl/acl_run_avx512_common.h: In function > ‘resolve_match_idx_avx512x16’: > ../lib/librte_acl/acl_run_avx512x16.h:33:18: error: > the last argument must be an 8-bit immediat

Re: [dpdk-dev] [PATCH] devtools: test different build types

2021-05-21 Thread David Marchand
On Mon, Apr 12, 2021 at 11:54 PM Thomas Monjalon wrote: > @@ -213,9 +218,10 @@ for c in gcc clang ; do > abicheck=ABI init of buildtype var is missing here. Rest lgtm. > else > abicheck=skipABI # save time and disk space > +

Re: [dpdk-dev] [PATCH] acl: fix build with GCC 6.3

2021-05-21 Thread Liang Ma
On Fri, May 21, 2021 at 03:42:07PM +0100, Konstantin Ananyev wrote: I apply this patch but it caused i40e pmd avx512 build failure. not sure about the root cause. I build debug version with latest repo.

Re: [dpdk-dev] [PATCH v2] doc: update release notes for 21.05

2021-05-21 Thread Thomas Monjalon
21/05/2021 01:24, John McNamara: > Fix grammar, spelling and formatting of DPDK 21.05 release notes. > > Signed-off-by: John McNamara Applied, with minor improvements, biggest one being the move of eventdev crypto adapter in the middle of other eventdev news. Thanks

[dpdk-dev] [PATCH] acl: fix build with GCC 6.3

2021-05-21 Thread Konstantin Ananyev
--buildtype=debug with gcc 6.3 produces the following error: ../lib/librte_acl/acl_run_avx512_common.h: In function ‘resolve_match_idx_avx512x16’: ../lib/librte_acl/acl_run_avx512x16.h:33:18: error: the last argument must be an 8-bit immediate ^ ../lib/librte

Re: [dpdk-dev] [PATCH v2] doc: update stable section

2021-05-21 Thread Thomas Monjalon
10/03/2021 11:32, Christian Ehrhardt: > On Mon, Feb 22, 2021 at 1:38 PM Kevin Traynor wrote: > > On 19/02/2021 11:17, Kevin Traynor wrote: > > > Updating the docs to elaborate on the stable release > > > characteristics and better document the current practice > > > about new features in stable re

Re: [dpdk-dev] [PATCH v2] doc: improve lstopo tip

2021-05-21 Thread Thomas Monjalon
21/05/2021 11:06, Thomas Monjalon: > The tool lstopo from hwloc package can provide a graphical > or textual view. > In its textual form, the option --merge gives a shorter summary > which fits well with the DPDK need. > > Signed-off-by: Thomas Monjalon I think this option can be quite useful.

Re: [dpdk-dev] [PATCH v2] doc: explain steps for improved code spell checking

2021-05-21 Thread Thomas Monjalon
21/05/2021 11:17, David Marchand: > On Fri, May 21, 2021 at 10:58 AM Thomas Monjalon wrote: > > > > The script build-dict.sh was added in DPDK 20.08. > > It generates a better dictionary for spell checking > > done via checkpatch. > > > > Signed-off-by: Thomas Monjalon > > Reviewed-by: David Mar

Re: [dpdk-dev] [PATCH v3 0/4] DLB2 fixes for 21.05

2021-05-21 Thread Thomas Monjalon
21/05/2021 12:26, Ferruh Yigit: > On 5/21/2021 10:11 AM, David Marchand wrote: > > Just sending a series with 4 ordered fixes (versioned v3 since some were > > marked as v2). > > Fixed rebase damage, fixes lines and updated titles. > > Thanks David! Thanks David for cleaning last minute DLB patch

Re: [dpdk-dev] [PATCH v3] devtools: check %l format specifier

2021-05-21 Thread Thomas Monjalon
21/05/2021 15:33, Ferruh Yigit: > On 5/21/2021 2:30 PM, Thomas Monjalon wrote: > > From: Ferruh Yigit > > > > %lx or %llx tend to be wrong for 32-bit platform > > if used for fixed size variable like uint64_t. > > A checkpatch warning will avoid this common mistake. > > > > Signed-off-by: Ferruh

Re: [dpdk-dev] [PATCH v3] devtools: check %l format specifier

2021-05-21 Thread Ferruh Yigit
On 5/21/2021 2:30 PM, Thomas Monjalon wrote: > From: Ferruh Yigit > > %lx or %llx tend to be wrong for 32-bit platform > if used for fixed size variable like uint64_t. > A checkpatch warning will avoid this common mistake. > > Signed-off-by: Ferruh Yigit > Signed-off-by: Thomas Monjalon Ack.

[dpdk-dev] [PATCH v3] devtools: check %l format specifier

2021-05-21 Thread Thomas Monjalon
From: Ferruh Yigit %lx or %llx tend to be wrong for 32-bit platform if used for fixed size variable like uint64_t. A checkpatch warning will avoid this common mistake. Signed-off-by: Ferruh Yigit Signed-off-by: Thomas Monjalon --- v3: more explicit message v2: proposal to reword the message an

Re: [dpdk-dev] [PATCH v2] devtools: check %l format specifier

2021-05-21 Thread Thomas Monjalon
21/05/2021 14:01, Ferruh Yigit: > On 5/19/2021 8:24 PM, Thomas Monjalon wrote: > > From: Ferruh Yigit > > > > %lx or %llx tend to be wrong for 32-bit platform > > if used for fixed size variable like uint64_t. > > A checkpatch warning will avoid this common mistake. > > > > Signed-off-by: Ferruh

Re: [dpdk-dev] [PATCH v2] devtools: check %l format specifier

2021-05-21 Thread Ferruh Yigit
On 5/19/2021 8:24 PM, Thomas Monjalon wrote: > From: Ferruh Yigit > > %lx or %llx tend to be wrong for 32-bit platform > if used for fixed size variable like uint64_t. > A checkpatch warning will avoid this common mistake. > > Signed-off-by: Ferruh Yigit > Signed-off-by: Thomas Monjalon > ---

Re: [dpdk-dev] [dpdk-dev v1] cperf: fix crypto perf out-of-place mempool alloc

2021-05-21 Thread De Lara Guarch, Pablo
> -Original Message- > From: Zhang, Roy Fan > Sent: Friday, May 21, 2021 10:05 AM > To: Ji, Kai ; dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: RE: [dpdk-dev v1] cperf: fix crypto perf out-of-place mempool alloc > > > -Original Message- > > From: Ji, Kai > > Sent: Thurs

Re: [dpdk-dev] [dpdk-dev v3] maintainers: update for crypto api/crypto perf/sw crypto pmds using ipsec-mb

2021-05-21 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev On Behalf Of Fan Zhang > Sent: Friday, May 21, 2021 10:24 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net; gak...@marvell.com; Yigit, Ferruh > ; Doherty, Declan ; Griffin, > John ; Jain, Deepak K ; > Trahe, Fiona ; Zhang, Roy Fan > > Subject: [dpdk-dev]

Re: [dpdk-dev] [PATCH v3 0/4] DLB2 fixes for 21.05

2021-05-21 Thread Ferruh Yigit
On 5/21/2021 10:11 AM, David Marchand wrote: > Just sending a series with 4 ordered fixes (versioned v3 since some were > marked as v2). > Fixed rebase damage, fixes lines and updated titles. > Thanks David!

[dpdk-dev] [Bug 717] Debug building failed due to librte_acl avx512 code

2021-05-21 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=717 Bug ID: 717 Summary: Debug building failed due to librte_acl avx512 code Product: DPDK Version: 20.11 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: critic

Re: [dpdk-dev] Question Of binutils-avx512-check

2021-05-21 Thread Liang Ma
On Fri, May 21, 2021 at 09:52:30AM +, Ananyev, Konstantin wrote: > > > > On Fri, May 21, 2021 at 09:19:53AM +0100, Bruce Richardson wrote: > > > On Fri, May 21, 2021 at 08:56:50AM +0100, Liang Ma wrote: > > > > On Fri, May 21, 2021 at 09:04:06AM +0200, Thomas Monjalon wrote: > > > > > 20/05/

Re: [dpdk-dev] Question Of binutils-avx512-check

2021-05-21 Thread Liang Ma
On Fri, May 21, 2021 at 10:07:07AM +0100, Bruce Richardson wrote: > On Fri, May 21, 2021 at 09:55:37AM +0100, Liang Ma wrote: > > On Fri, May 21, 2021 at 09:19:53AM +0100, Bruce Richardson wrote: > > > On Fri, May 21, 2021 at 08:56:50AM +0100, Liang Ma wrote: > > > > On Fri, May 21, 2021 at 09:04:0

Re: [dpdk-dev] Question Of binutils-avx512-check

2021-05-21 Thread Ananyev, Konstantin
> On Fri, May 21, 2021 at 09:19:53AM +0100, Bruce Richardson wrote: > > On Fri, May 21, 2021 at 08:56:50AM +0100, Liang Ma wrote: > > > On Fri, May 21, 2021 at 09:04:06AM +0200, Thomas Monjalon wrote: > > > > 20/05/2021 23:22, Liang Ma: > > > > > Hi All, > > > > >I try to build DPDK with de

Re: [dpdk-dev] [dpdk-announce] release candidate 21.05-rc4

2021-05-21 Thread Jiang, YuX
All, Update the test status for Intel part. Till now dpdk21.05-rc4 test is almost finished and no new issue is found. # Basic Intel(R) NIC testing * Build or compile: *Build: cover the build test combination with latest GCC/Clang/ICC version and the popular OS revision s

[dpdk-dev] [dpdk-dev v3] maintainers: update for crypto api/crypto perf/sw crypto pmds using ipsec-mb

2021-05-21 Thread Fan Zhang
Add myself as Crypto API, QAT, SW PMDs based on ipsec-mb, NULL PMD, and crypto perf test maintainer. Also remove Declan, Deepak, and John from the maintainers of these areas. Signed-off-by: Fan Zhang Acked-by: Declan Doherty Acked-by: Fiona Trahe Acked-by: John Griffin --- MAINTAINERS | 19 ++

Re: [dpdk-dev] [PATCH v2] doc: explain steps for improved code spell checking

2021-05-21 Thread David Marchand
On Fri, May 21, 2021 at 10:58 AM Thomas Monjalon wrote: > > The script build-dict.sh was added in DPDK 20.08. > It generates a better dictionary for spell checking > done via checkpatch. > > Signed-off-by: Thomas Monjalon Reviewed-by: David Marchand -- David Marchand

[dpdk-dev] [PATCH v3 4/4] event/dlb2: select scalar dequeue by default

2021-05-21 Thread David Marchand
From: Timothy McDaniel Optimized dequeue using x86 vector instructions was added in 21.05, but due to limited testing the default has been changed back to the scalar mode implementation. The vector mode implementation can be enabled via the devargs option "vector_opts_enabled=". Fixes: 000a7b8e7

[dpdk-dev] [PATCH v3 3/4] event/dlb2: fix extraction of HW scheduling type

2021-05-21 Thread David Marchand
From: Timothy McDaniel The HW scheduling type was not being extracted properly in the vector optimizaed dequeue path. It was also not being recorded in the xstats. Fixes: 000a7b8e7582 ("event/dlb2: optimize dequeue operation") Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/dlb2.c | 13

[dpdk-dev] [PATCH v3 2/4] doc: fix runtime options in DLB2 guide

2021-05-21 Thread David Marchand
From: Timothy McDaniel Convert to PCI "--allow" devarg format. The documentation was previously using the "--vdev" form, which cannot be used with the DLB2 PF PMD. Fixes: f3cad285bb88 ("event/dlb2: add infos get and configure") Fixes: f7cc194b0f7e ("event/dlb2: add enqueue and its burst variants

[dpdk-dev] [PATCH v3 1/4] event/dlb2: remove references to deferred scheduling

2021-05-21 Thread David Marchand
From: Timothy McDaniel Deferred scheduling is a DLB v1.0 feature, and is not valid for DLB v2.0 or v2.5. Fixes: bc62748bd7d4 ("event/dlb2: add private data structures and constants") Fixes: a2e4f1f5e79f ("event/dlb2: add dequeue and its burst variants") Cc: sta...@dpdk.org Signed-off-by: Timoth

[dpdk-dev] [PATCH v3 0/4] DLB2 fixes for 21.05

2021-05-21 Thread David Marchand
Just sending a series with 4 ordered fixes (versioned v3 since some were marked as v2). Fixed rebase damage, fixes lines and updated titles. -- David Marchand Timothy McDaniel (4): event/dlb2: remove references to deferred scheduling doc: fix runtime options in DLB2 guide event/dlb2: fix e

Re: [dpdk-dev] Question Of binutils-avx512-check

2021-05-21 Thread Bruce Richardson
On Fri, May 21, 2021 at 09:55:37AM +0100, Liang Ma wrote: > On Fri, May 21, 2021 at 09:19:53AM +0100, Bruce Richardson wrote: > > On Fri, May 21, 2021 at 08:56:50AM +0100, Liang Ma wrote: > > > On Fri, May 21, 2021 at 09:04:06AM +0200, Thomas Monjalon wrote: > > > > 20/05/2021 23:22, Liang Ma: > >

[dpdk-dev] [PATCH v2] doc: improve lstopo tip

2021-05-21 Thread Thomas Monjalon
The tool lstopo from hwloc package can provide a graphical or textual view. In its textual form, the option --merge gives a shorter summary which fits well with the DPDK need. Signed-off-by: Thomas Monjalon --- v2: add textual output in Linux guide --- doc/guides/linux_gsg/build_sample_apps.rst

Re: [dpdk-dev] [dpdk-dev v1] cperf: fix crypto perf out-of-place mempool alloc

2021-05-21 Thread Zhang, Roy Fan
> -Original Message- > From: Ji, Kai > Sent: Thursday, May 20, 2021 4:07 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Ji, Kai ; > De Lara Guarch, Pablo > Subject: [dpdk-dev v1] cperf: fix crypto perf out-of-place mempool alloc > > Add in missing rte_mbuf size in mempool allocation for ou

Re: [dpdk-dev] [dpdk-dev v2] maintainers: update for qat and ipsec-mb pmds

2021-05-21 Thread Zhang, Roy Fan
Hi Thomas, Will change in V3. Thanks. Regards, Fan > -Original Message- > From: Thomas Monjalon > Sent: Thursday, May 20, 2021 2:01 PM > To: Zhang, Roy Fan > Cc: dev@dpdk.org; gak...@marvell.com; Yigit, Ferruh > ; Doherty, Declan ; > Griffin, John ; Jain, Deepak K > ; Trahe, Fiona > S

[dpdk-dev] [PATCH v2] doc: explain steps for improved code spell checking

2021-05-21 Thread Thomas Monjalon
The script build-dict.sh was added in DPDK 20.08. It generates a better dictionary for spell checking done via checkpatch. Signed-off-by: Thomas Monjalon --- v2: explain the default --- doc/guides/contributing/patches.rst | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) dif

Re: [dpdk-dev] Question Of binutils-avx512-check

2021-05-21 Thread Liang Ma
On Fri, May 21, 2021 at 09:19:53AM +0100, Bruce Richardson wrote: > On Fri, May 21, 2021 at 08:56:50AM +0100, Liang Ma wrote: > > On Fri, May 21, 2021 at 09:04:06AM +0200, Thomas Monjalon wrote: > > > 20/05/2021 23:22, Liang Ma: > > > > Hi All, > > > >I try to build DPDK with debug build-type

Re: [dpdk-dev] Question Of binutils-avx512-check

2021-05-21 Thread Bruce Richardson
On Fri, May 21, 2021 at 08:56:50AM +0100, Liang Ma wrote: > On Fri, May 21, 2021 at 09:04:06AM +0200, Thomas Monjalon wrote: > > 20/05/2021 23:22, Liang Ma: > > > Hi All, > > >I try to build DPDK with debug build-type but the building process is > > >failed becuase of AVX512 code from lib

Re: [dpdk-dev] Question Of binutils-avx512-check

2021-05-21 Thread Liang Ma
On Fri, May 21, 2021 at 09:04:06AM +0200, Thomas Monjalon wrote: > 20/05/2021 23:22, Liang Ma: > > Hi All, > >I try to build DPDK with debug build-type but the building process is > >failed becuase of AVX512 code from librte-acl. The release build type > >is fine. Hence, I dig a bit i

Re: [dpdk-dev] Question Of binutils-avx512-check

2021-05-21 Thread Thomas Monjalon
20/05/2021 23:22, Liang Ma: > Hi All, >I try to build DPDK with debug build-type but the building process is >failed becuase of AVX512 code from librte-acl. The release build type >is fine. Hence, I dig a bit into the avx512 enabling logic of meson. > >I found the main logic is i