Re: [dpdk-dev] [PATCH 2/2] net/bonding: support configuring Tx offloading for bonding

2021-06-08 Thread Chengchang Tang
On 2021/6/8 17:49, Andrew Rybchenko wrote: > "for bonding" is redundant in the summary since it is already > "net/bonding" > > On 4/23/21 12:46 PM, Chengchang Tang wrote: >> Currently, the TX offloading of the bonding device will not take effect by > > TX -> Tx > >> using dev_configure. Becau

Re: [dpdk-dev] [PATCH 1/2] net/bonding: support Tx prepare for bonding

2021-06-08 Thread Chengchang Tang
Hi, Andrew and Ferruh On 2021/6/8 17:49, Andrew Rybchenko wrote: > "for bonding" is redundant in the summary since it is already "net/bonding". > > On 4/23/21 12:46 PM, Chengchang Tang wrote: >> To use the HW offloads capability (e.g. checksum and TSO) in the Tx >> direction, the upper-layer user

Re: [dpdk-dev] [PATCH 0/9] bnxt PMD fixes

2021-06-08 Thread Ajit Khaparde
On Mon, May 31, 2021 at 12:05 AM Kalesh A P wrote: > > From: Kalesh AP > > Kalesh AP (9): > net/bnxt: fix error message when VNIC prepare fails > net/bnxt: set flow error when free filter is not available > net/bnxt: remove unnecessary code > net/bnxt: fix error handling when VNIC prepare

[dpdk-dev] [PATCH v2 3/3] net/ice: support FDIR ESP and NATT to match outer IP

2021-06-08 Thread Simei Su
This patch adds IPV4/IPV6 SRC/DST input set for ESP/NAT_T_ESP to support outer IP match. Signed-off-by: Simei Su --- drivers/net/ice/ice_fdir_filter.c | 73 +++ 1 file changed, 73 insertions(+) diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice

[dpdk-dev] [PATCH v2 2/3] net/ice/base: support FDIR ESP for outer IP match

2021-06-08 Thread Simei Su
Enable FDIR ESP for matching outer IPV4/IPV6 SRC/DST field. Signed-off-by: Simei Su --- drivers/net/ice/base/ice_fdir.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/ice/base/ice_fdir.c b/drivers/net/ice/base/ice_fdir.c index 1805082..926f9c5 100644 --- a/drivers/net/ic

[dpdk-dev] [PATCH v2 1/3] net/iavf: add FDIR ESP support to match outer IP

2021-06-08 Thread Simei Su
This patch adds IPV4/IPV6 SRC/DST input set for ESP to support outer IP match. Signed-off-by: Simei Su --- drivers/net/iavf/iavf_fdir.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/iavf/iavf_fdir.c b/drivers/net/iavf/iavf_fdir.c index f238a83..43460

[dpdk-dev] [PATCH v2 0/3] net/ice: support FDIR ESP and NATT to match outer IP

2021-06-08 Thread Simei Su
[PATCH v2 1/3] enable FDIR ESP to match outer IPV4/IPV6 SRC/DST field in DPDK AVF. [PATCH v2 2/3] add IPV4/IPV6 SRC/DST input set for ESP/NAT_T_ESP in share code. [PATCH v2 3/3] enable FDIR ESP/NAT_T_ESP match outer IPV4/IPV6 SRC/DST field in DPDK PF. v2: * Combine patch for "FDIR ESP support in

[dpdk-dev] [PATCH 4/4] net/bnxt: invoke device removal event on recovery failure

2021-06-08 Thread Kalesh A P
From: Kalesh AP When the driver receives RESET_NOTIFY async event from FW or detects a FW fatal error condition, it tries to recover from the error. When the driver fails to recover from the error condition, fixed to send device removal event to the application. Fixes: df6cd7c1f73a ("net/bnxt: h

[dpdk-dev] [PATCH 3/4] net/bnxt: fix enabling autoneg on Whitney+

2021-06-08 Thread Kalesh A P
From: Kalesh AP Driver should enable autoneg on a port if FW supports it. Because of a wrong check, driver is not enabling autoneg on a port after setting forced speed on Whitney+. Fixes: 7bc8e9a227cc ("net/bnxt: support async link notification") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Re

[dpdk-dev] [PATCH 2/4] net/bnxt: fix typo in log message

2021-06-08 Thread Kalesh A P
From: Kalesh AP In bnxt_rss_hash_update_op, check for valid RSS hashkey length is made against size HW_HASH_KEY_SIZE(40). But the failure log says "Invalid hashkey length, should be 16 bytes". Fixes: 91aee9711ee3 ("net/bnxt: validate RSS hash key length") Cc: sta...@dpdk.org Signed-off-by: Kale

[dpdk-dev] [PATCH 1/4] net/bnxt: cleanup code

2021-06-08 Thread Kalesh A P
From: Kalesh AP This is a cleanup commit and no functional change. 1. use macros instead of hard coded values 2. remove unnecessary comments Fixes: 5cd0e2889c43 ("net/bnxt: support NIC Partitioning") Fixes: 2ba07b7dbd9d ("net/bnxt: set the hash key size") Cc: sta...@dpdk.org Signed-off-by: Kal

[dpdk-dev] [PATCH 0/4] bnxt fixes

2021-06-08 Thread Kalesh A P
From: Kalesh AP This set contains few bnxt fixes and code cleanup changes. Kalesh AP (4): net/bnxt: cleanup code net/bnxt: fix typo in log message net/bnxt: fix enabling autoneg on Whitney+ net/bnxt: invoke device removal event on recovery failure drivers/net/bnxt/bnxt_ethdev.c | 11 ++

[dpdk-dev] [PATCH] net/bnxt: add support to dump SFP module info

2021-06-08 Thread Kalesh A P
From: Kalesh AP Add support to fetch the SFP EEPROM settings from the firmware. For SFP+ modules we will display 0xA0 page for status and 0xA2 page for other information. For QSFP modules we will show the 0xA0 page. Also identify the module types for QSFP28, QSFP, QSFP+ apart from the SFP module

[dpdk-dev] [PATCH] net/mlx5: fix meter policy creation error flow

2021-06-08 Thread Li Zhang
When an error appears in the policy creation, the IDs mapping between the user policy ID to the driver policy ID is skipped. Wrongly, the driver tried to clean the mapping in this case what caused an error. Skip the clearance in this case. Fixes: afb4aa4f122 ("net/mlx5: support meter policy oper

Re: [dpdk-dev] [PATCH v2 09/62] net/cnxk: add build infra and common probe

2021-06-08 Thread Huisong Li
在 2021/6/8 1:58, Nithin Dabilpuram 写道: Add build infrastructure and common probe and remove for cnxk driver which is used by both CN10K and CN9K SoC. Signed-off-by: Nithin Dabilpuram --- MAINTAINERS | 3 + doc/guides/nics/cnxk.rst | 29 + doc/

Re: [dpdk-dev] [PATCH 1/1] lib/vhost: support async dequeue for split ring

2021-06-08 Thread Hu, Jiayu
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, June 8, 2021 12:17 AM > To: Wang, YuanX ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; > Jiang, Cheng1 ; Ma, WenwuX > ; Hu, Jiayu > Subject: Re: [PATCH 1/1] lib/vhost: support async dequeue for split

Re: [dpdk-dev] [PATCH v2 2/2] net/bnxt: workaround for spurious zero counter values in Thor

2021-06-08 Thread Ajit Khaparde
On Sun, May 30, 2021 at 10:55 PM Somnath Kotur wrote: > > There is a HW bug that can result in certain stats being reported as > zero. > Workaround this by ignoring stats with a value of zero based on the > previously stored snapshot of the same stat. > This bug mainly manifests in the output of f

Re: [dpdk-dev] [PATCH v9 10/10] Enable the new EAL thread API

2021-06-08 Thread Dmitry Kozlyuk
2021-06-07 22:50 (UTC-0700), Narcisa Ana Maria Vasile: > On Fri, Jun 04, 2021 at 04:44:34PM -0700, Narcisa Ana Maria Vasile wrote: > > From: Narcisa Vasile > > > > Rename pthread_* occurrences with the new rte_thread_* API. > > Enable the new API in the build system. > > > > Signed-off-by: Narci

Re: [dpdk-dev] [PATCH v9 07/10] eal: implement functions for mutex management

2021-06-08 Thread Dmitry Kozlyuk
2021-06-04 16:44 (UTC-0700), Narcisa Ana Maria Vasile: [...] > diff --git a/lib/eal/include/rte_thread_types.h > b/lib/eal/include/rte_thread_types.h > index d67b24a563..7bb0d2948c 100644 > --- a/lib/eal/include/rte_thread_types.h > +++ b/lib/eal/include/rte_thread_types.h > @@ -7,4 +7,8 @@ > >

Re: [dpdk-dev] [PATCH v9 06/10] eal: add thread lifetime management

2021-06-08 Thread Dmitry Kozlyuk
2021-06-04 16:44 (UTC-0700), Narcisa Ana Maria Vasile: [...] > diff --git a/lib/eal/include/rte_thread.h b/lib/eal/include/rte_thread.h > index 5c54cd9d67..1d481b9ad5 100644 > --- a/lib/eal/include/rte_thread.h > +++ b/lib/eal/include/rte_thread.h > @@ -208,6 +208,73 @@ __rte_experimental > int rt

Re: [dpdk-dev] [PATCH v9 05/10] eal: implement thread priority management functions

2021-06-08 Thread Dmitry Kozlyuk
2021-06-04 16:44 (UTC-0700), Narcisa Ana Maria Vasile: > From: Narcisa Vasile [...] > diff --git a/lib/eal/windows/rte_thread.c b/lib/eal/windows/rte_thread.c > index 9e74a538c2..6dc3d575c0 100644 > --- a/lib/eal/windows/rte_thread.c > +++ b/lib/eal/windows/rte_thread.c > @@ -202,6 +202,98 @@ rte_

Re: [dpdk-dev] [PATCH v8 04/10] eal: implement functions for thread affinity management

2021-06-08 Thread Dmitry Kozlyuk
2021-06-04 16:38 (UTC-0700), Narcisa Ana Maria Vasile: [...] > +static int > +rte_convert_cpuset_to_affinity(const rte_cpuset_t *cpuset, > +PGROUP_AFFINITY affinity) > +{ > + int ret = 0; > + PGROUP_AFFINITY cpu_affinity = NULL; > + > + memset(affinity, 0, si

Re: [dpdk-dev] [PATCH v9 04/10] eal: implement functions for thread affinity management

2021-06-08 Thread Dmitry Kozlyuk
2021-06-04 16:44 (UTC-0700), Narcisa Ana Maria Vasile: [...] > diff --git a/lib/eal/windows/rte_thread.c b/lib/eal/windows/rte_thread.c > index 6ea1dc2a05..9e74a538c2 100644 > --- a/lib/eal/windows/rte_thread.c > +++ b/lib/eal/windows/rte_thread.c > @@ -7,7 +7,8 @@ > #include > #include > #inc

Re: [dpdk-dev] [PATCH v9 02/10] eal: add thread attributes

2021-06-08 Thread Dmitry Kozlyuk
2021-06-04 16:44 (UTC-0700), Narcisa Ana Maria Vasile: > From: Narcisa Vasile > > Implement thread attributes for: > * thread affinity > * thread priority > Implement functions for managing thread attributes. > > Priority is represented through an enum that allows for two levels: > - RTE_T

Re: [dpdk-dev] [PATCH v9 01/10] eal: add thread id and simple thread functions

2021-06-08 Thread Dmitry Kozlyuk
2021-06-04 16:44 (UTC-0700), Narcisa Ana Maria Vasile: > From: Narcisa Vasile > > Use a portable, type-safe representation for the thread identifier. > Add functions for comparing thread ids and obtaining the thread id > for the current thread. > > Signed-off-by: Narcisa Vasile > --- > lib/eal

Re: [dpdk-dev] [PATCH 2/2] net/bnxt: workaround for spurious zero counter values in Thor

2021-06-08 Thread Ajit Khaparde
On Tue, Jun 8, 2021 at 10:47 AM Ajit Khaparde wrote: > > On Wed, May 26, 2021 at 11:21 PM Somnath Kotur > wrote: > > > > There is a HW bug that can result in certain stats being reported as > > zero. > > Workaround this by ignoring stats with a value of zero based on the > > previously stored sna

Re: [dpdk-dev] [PATCH 2/2] net/bnxt: workaround for spurious zero counter values in Thor

2021-06-08 Thread Ajit Khaparde
On Wed, May 26, 2021 at 11:21 PM Somnath Kotur wrote: > > There is a HW bug that can result in certain stats being reported as > zero. > Workaround this by ignoring stats with a value of zero based on the > previously stored snapshot of the same stat. > This bug mainly manifests in the output of f

Re: [dpdk-dev] [PATCH 1/2] net/bnxt: detect bad opaque in Rx completion

2021-06-08 Thread Ajit Khaparde
On Wed, May 26, 2021 at 11:21 PM Somnath Kotur wrote: > > There is a rare hardware bug that can cause a bad opaque value in the RX > or TPA start completion. When this happens, the hardware may have used the > same buffer twice for 2 rx packets. In addition, the driver might also > crash later us

Re: [dpdk-dev] [PATCH 2/2] net/failsafe: fix primary/secondary mutex

2021-06-08 Thread Stephen Hemminger
On Tue, 8 Jun 2021 18:55:17 +0300 Andrew Rybchenko wrote: > On 6/8/21 6:42 PM, Stephen Hemminger wrote: > > On Tue, 8 Jun 2021 11:00:37 +0300 > > Andrew Rybchenko wrote: > > > >> On 4/19/21 8:08 PM, Thomas Monjalon wrote: > >>> About the title, better to speak about multi-process, > >>> it

Re: [dpdk-dev] [RFC PATCH] ethdev: clarify flow action PORT ID semantics

2021-06-08 Thread Thomas Monjalon
08/06/2021 18:32, Andrew Rybchenko: > On 6/8/21 7:13 PM, Thomas Monjalon wrote: > > We will be at least 4 tomorrow Wednesday 3pm UTC. > > Everybody is welcome to join the community meeting: > > https://zoom.us/j/93391811485 > > Invite has July, 7. Typo? Yes was a typo, sorry. The invite was u

[dpdk-dev] Memory leak in rte_pci_scan

2021-06-08 Thread Owen Hilyard
Hello All, As part of the community lab's work to deploy static analysis tools, we've been doing test runs of the various tools. One of the problems we found is that rte_pci_scan leaks 214368 Bytes every time it is run. There are also numerous (180856) instances of the error message "EAL: recvmsg

Re: [dpdk-dev] [RFC PATCH] ethdev: clarify flow action PORT ID semantics

2021-06-08 Thread Andrew Rybchenko
On 6/8/21 7:13 PM, Thomas Monjalon wrote: > 07/06/2021 18:07, Thomas Monjalon: >> 07/06/2021 15:21, Ilya Maximets: >>> On 6/7/21 2:08 PM, Ori Kam wrote: From: Andrew Rybchenko > On 6/7/21 11:28 AM, Thomas Monjalon wrote: >> I see emails don't work well to conclude on how to manage rep

Re: [dpdk-dev] [RFC PATCH] ethdev: clarify flow action PORT ID semantics

2021-06-08 Thread Thomas Monjalon
07/06/2021 18:07, Thomas Monjalon: > 07/06/2021 15:21, Ilya Maximets: > > On 6/7/21 2:08 PM, Ori Kam wrote: > > > From: Andrew Rybchenko > > >> On 6/7/21 11:28 AM, Thomas Monjalon wrote: > > >>> I see emails don't work well to conclude on how to manage representors. > > >>> I propose working in li

Re: [dpdk-dev] [PATCH 2/2] net/failsafe: fix primary/secondary mutex

2021-06-08 Thread Andrew Rybchenko
On 6/8/21 6:42 PM, Stephen Hemminger wrote: > On Tue, 8 Jun 2021 11:00:37 +0300 > Andrew Rybchenko wrote: > >> On 4/19/21 8:08 PM, Thomas Monjalon wrote: >>> About the title, better to speak about multi-process, >>> it is less confusing than primary/secondary. >>> >>> 15/03/2021 20:27, Stephen He

Re: [dpdk-dev] [PATCH 2/2] net/failsafe: fix primary/secondary mutex

2021-06-08 Thread Stephen Hemminger
On Tue, 8 Jun 2021 11:00:37 +0300 Andrew Rybchenko wrote: > On 4/19/21 8:08 PM, Thomas Monjalon wrote: > > About the title, better to speak about multi-process, > > it is less confusing than primary/secondary. > > > > 15/03/2021 20:27, Stephen Hemminger: > >> Set mutex used in failsafe driver

Re: [dpdk-dev] [PATCH] vhost: allow to check in-flight packets for async vhost

2021-06-08 Thread Maxime Coquelin
Hi Jiayu, On 6/2/21 5:05 PM, Jiayu Hu wrote: > This patch allows to check the amount of in-flight packets > for vhost queues which register async channel acceleration. > > Signed-off-by: Jiayu Hu > --- > doc/guides/prog_guide/vhost_lib.rst | 5 + > lib/vhost/rte_vhost_async.h | 14

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/4] net/tap: fix Rx cksum flags on IP options packets

2021-06-08 Thread Olivier Matz
On Tue, Jun 08, 2021 at 04:57:00PM +0300, Andrew Rybchenko wrote: > On 6/8/21 3:49 PM, Olivier Matz wrote: > > On Tue, Jun 08, 2021 at 03:34:36PM +0300, Andrew Rybchenko wrote: > >> On 6/8/21 3:29 PM, Olivier Matz wrote: > >>> Hi Ferruh, Andrew, > >>> > >>> On Tue, Jun 08, 2021 at 01:13:59PM +0300,

[dpdk-dev] [PATCH 3/3] net/virtio: add MAC device config getter and setter

2021-06-08 Thread Maxime Coquelin
This patch uses the new device config ops to get and set the MAC address if supported. If a valid MAC address is passed as devarg of the Virtio-user PMD, the driver will try to store it in the device config space. Otherwise the one provided in the device config space will be used, if available. S

[dpdk-dev] [PATCH 2/3] net/virtio: add device config support to vDPA

2021-06-08 Thread Maxime Coquelin
This patch introduces two virtio-user callbacks to get and set device's config, and implements it for vDPA backends. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_user/vhost.h | 3 + drivers/net/virtio/virtio_user/vhost_vdpa.c | 69 + 2 files changed, 72

[dpdk-dev] [PATCH 1/3] net/virtio: keep device and frontend features separated

2021-06-08 Thread Maxime Coquelin
This patch is preliminary rework to add support for getting and setting device's config space. In order to get or set a device config such as its MAC address, we need to know whether the device itself support the feature, or if it is emulated by the frontend. Signed-off-by: Maxime Coquelin ---

[dpdk-dev] [PATCH 0/3] net/virtio: add vdpa device config support

2021-06-08 Thread Maxime Coquelin
This patch adds vDPA device config space requests support. For now, it only adds MAC address get and set. It may be extended in next revision to support other configs like link state. Regarding the MAC selection strategy, if devargs MAC address is set by the user and valid, the driver tries to sto

Re: [dpdk-dev] [PATCH v5 1/1] ethdev: add new ext hdr for gtp psc

2021-06-08 Thread Raslan Darawsheh
Hi Andrew, Thanks for your comments and review, I'll attempt to handle and fix in the next version. Kindest regards, Raslan Darawsheh > -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, June 8, 2021 3:19 PM > To: Raslan Darawsheh ; dev@dpdk.org > Cc: ferruh.yi...@intel.com;

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/4] net/tap: fix Rx cksum flags on IP options packets

2021-06-08 Thread Andrew Rybchenko
On 6/8/21 3:49 PM, Olivier Matz wrote: > On Tue, Jun 08, 2021 at 03:34:36PM +0300, Andrew Rybchenko wrote: >> On 6/8/21 3:29 PM, Olivier Matz wrote: >>> Hi Ferruh, Andrew, >>> >>> On Tue, Jun 08, 2021 at 01:13:59PM +0300, Andrew Rybchenko wrote: On 4/30/21 5:48 PM, Ferruh Yigit wrote: > On

Re: [dpdk-dev] code.dpdk.org bugfix releases

2021-06-08 Thread Luca Boccassi
On Tue, 2021-06-08 at 12:23 +0200, Thomas Monjalon wrote: > 08/06/2021 11:57, Morten Brørup: > > + Stable maintainers: Luca Boccassi, Kevin Traynor. > > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ali Alnubani > > > Sent: Monday, 7 June 2021 14.49 > > > > > > Hi, > > > > > > > Fro

Re: [dpdk-dev] [PATCH 4/4] drivers/net/enetfec: add enqueue and dequeue support

2021-06-08 Thread Andrew Rybchenko
On 4/30/21 7:34 AM, Apeksha Gupta wrote: > This patch supported checksum offloads and add burst enqueue and > dequeue operations to the enetfec PMD. > > Loopback mode is added, compile time flag 'ENETFEC_LOOPBACK' is > used to enable this feature. By default loopback mode is disabled. > Basic feat

Re: [dpdk-dev] [PATCH 3/4] drivers/net/enetfec: queue configuration

2021-06-08 Thread Andrew Rybchenko
Summary is incorrect. "net/enetfec: support queue configuration" ? On 4/30/21 7:34 AM, Apeksha Gupta wrote: > This patch added RX/TX queue configuration setup operations. RX -> Rx, TX -> Tx > On packet Rx the respective BD Ring status bit is set which is then > used for packet processing. > > S

Re: [dpdk-dev] [PATCH 2/4] drivers/net/enetfec: UIO support added

2021-06-08 Thread Andrew Rybchenko
Summary should be "add UIO support". On 4/30/21 7:34 AM, Apeksha Gupta wrote: > Implemented the fec-uio driver in kernel. enetfec PMD uses > UIO interface to interact with kernel for PHY initialisation > and for mapping the allocated memory of register & BD from > kernel to DPDK which gives access

Re: [dpdk-dev] [PATCH] net/mlx5: allow copy from one tag to another

2021-06-08 Thread Slava Ovsiienko
> -Original Message- > From: Alexander Kozyrev > Sent: Tuesday, May 25, 2021 20:14 > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko ; Matan Azrad ; > Ori Kam > Subject: [PATCH] net/mlx5: allow copy from one tag to another > > The modify field implementation

Re: [dpdk-dev] [PATCH 1/4] drivers/net/enetfec: Introduce NXP ENETFEC driver

2021-06-08 Thread Andrew Rybchenko
On 4/30/21 7:34 AM, Apeksha Gupta wrote: > ENET fec (Fast Ethernet Controller) is a network poll mode driver > for NXP SoC imx8mmevk. > > This patch add skeleton for enetfec driver with probe and > uintialisation functions > > Signed-off-by: Sachin Saxena > Signed-off-by: Apeksha Gupta > --- >

Re: [dpdk-dev] 20.11.2 patches review and test

2021-06-08 Thread Xueming(Steven) Li
> -Original Message- > From: Kevin Traynor > Sent: Tuesday, June 8, 2021 7:31 PM > To: Xueming(Steven) Li > Cc: dev@dpdk.org; John McNamara ; Luca Boccassi > ; NBU-Contact-Thomas > Monjalon ; Christian Ehrhardt > ; Ferruh Yigit ; > David Marchand > Subject: Re: 20.11.2 patches review

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/4] net/tap: fix Rx cksum flags on IP options packets

2021-06-08 Thread Olivier Matz
On Tue, Jun 08, 2021 at 03:34:36PM +0300, Andrew Rybchenko wrote: > On 6/8/21 3:29 PM, Olivier Matz wrote: > > Hi Ferruh, Andrew, > > > > On Tue, Jun 08, 2021 at 01:13:59PM +0300, Andrew Rybchenko wrote: > >> On 4/30/21 5:48 PM, Ferruh Yigit wrote: > >>> On 4/27/2021 2:57 PM, Olivier Matz wrote: >

Re: [dpdk-dev] [PATCH 3/4] net: introduce functions to verify L4 checksums

2021-06-08 Thread Andrew Rybchenko
On 6/8/21 3:29 PM, Olivier Matz wrote: > Hi Ferruh, Andrew, > > On Tue, Jun 08, 2021 at 01:23:33PM +0300, Andrew Rybchenko wrote: >> On 4/30/21 6:42 PM, Ferruh Yigit wrote: >>> On 4/27/2021 2:57 PM, Olivier Matz wrote: Since commit d5df2ae0428a ("net: fix unneeded replacement of TCP chec

Re: [dpdk-dev] [PATCH v13] app/testpmd: support multi-process

2021-06-08 Thread Ferruh Yigit
On 6/8/2021 11:39 AM, Andrew Rybchenko wrote: > On 6/8/21 1:22 PM, Thomas Monjalon wrote: >> 08/06/2021 10:42, Andrew Rybchenko: >>> On 4/22/21 4:18 AM, Min Hu (Connor) wrote: --- a/doc/guides/testpmd_app_ug/run_app.rst +++ b/doc/guides/testpmd_app_ug/run_app.rst >> [...] +All the de

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/4] net/tap: fix Rx cksum flags on IP options packets

2021-06-08 Thread Andrew Rybchenko
On 6/8/21 3:29 PM, Olivier Matz wrote: > Hi Ferruh, Andrew, > > On Tue, Jun 08, 2021 at 01:13:59PM +0300, Andrew Rybchenko wrote: >> On 4/30/21 5:48 PM, Ferruh Yigit wrote: >>> On 4/27/2021 2:57 PM, Olivier Matz wrote: When packet type is IPV4_EXT, the checksum is always marked as good in >>>

Re: [dpdk-dev] [PATCH 3/4] net: introduce functions to verify L4 checksums

2021-06-08 Thread Olivier Matz
Hi Ferruh, Andrew, On Tue, Jun 08, 2021 at 01:23:33PM +0300, Andrew Rybchenko wrote: > On 4/30/21 6:42 PM, Ferruh Yigit wrote: > > On 4/27/2021 2:57 PM, Olivier Matz wrote: > >> Since commit d5df2ae0428a ("net: fix unneeded replacement of TCP > >> checksum 0"), the functions rte_ipv4_udptcp_cksum(

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/4] net/tap: fix Rx cksum flags on IP options packets

2021-06-08 Thread Olivier Matz
Hi Ferruh, Andrew, On Tue, Jun 08, 2021 at 01:13:59PM +0300, Andrew Rybchenko wrote: > On 4/30/21 5:48 PM, Ferruh Yigit wrote: > > On 4/27/2021 2:57 PM, Olivier Matz wrote: > >> When packet type is IPV4_EXT, the checksum is always marked as good in > >> the mbuf offload flags. > >> > >> Since we k

Re: [dpdk-dev] [PATCH v2 02/62] common/cnxk: update Rx inline IPsec mbox message format

2021-06-08 Thread Andrew Rybchenko
On 6/7/21 8:58 PM, Nithin Dabilpuram wrote: > From: Srujana Challa > > Updates Rx inline IPSEC mailbox message format to make it > sync with latest CPT PF driver. > > Signed-off-by: Srujana Challa > --- > drivers/common/cnxk/roc_mbox.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

Re: [dpdk-dev] [PATCH v5 1/1] ethdev: add new ext hdr for gtp psc

2021-06-08 Thread Andrew Rybchenko
On 6/8/21 3:17 PM, Andrew Rybchenko wrote: > On 4/29/21 11:10 AM, Raslan Darawsheh wrote: >> Define new rte header for gtp PDU session container >> based on RFC 38415-g30 >> >> Signed-off-by: Raslan Darawsheh >> --- >> lib/net/rte_gtp.h | 78 +++ >> 1 f

Re: [dpdk-dev] [PATCH v5 1/1] ethdev: add new ext hdr for gtp psc

2021-06-08 Thread Andrew Rybchenko
On 4/29/21 11:10 AM, Raslan Darawsheh wrote: > Define new rte header for gtp PDU session container > based on RFC 38415-g30 > > Signed-off-by: Raslan Darawsheh > --- > lib/net/rte_gtp.h | 78 +++ > 1 file changed, 78 insertions(+) > > diff --git a/lib

Re: [dpdk-dev] [PATCH v4 1/2] ethdev: add new ext hdr for gtp psc

2021-06-08 Thread Andrew Rybchenko
On 4/29/21 7:29 PM, Tyler Retzlaff wrote: > On Thu, Apr 08, 2021 at 02:29:56PM +0200, Olivier Matz wrote: >> Hi Raslan, >> >>> +/** >>> + * Optional extension for GTP with next_ext set to 0x85 >>> + * defined based on RFC 38415-g30. >>> + */ >>> +__extension__ >>> +struct rte_gtp_psc_hdr { >>> +

Re: [dpdk-dev] code.dpdk.org bugfix releases

2021-06-08 Thread David Marchand
On Tue, Jun 8, 2021 at 11:58 AM Morten Brørup wrote: > As a frequent user of code.dpdk.org, I think it would be great. > > Thomas, David, Luca and Kevin, do any of you oppose to code.dpdk.org showing > both the "dpdk" and the "dpdk-stable" repos merged together as one project, > if Ali can do i

Re: [dpdk-dev] [PATCH v2 55/62] net/cnxk: add base PTP timesync support

2021-06-08 Thread Pavan Nikhilesh Bhagavatula
> >+static __rte_always_inline void >+cn10k_nix_xmit_prepare_tstamp(uintptr_t lmt_addr, const uint64_t >*cmd, >+const uint64_t ol_flags, const uint16_t >no_segdw, >+const uint16_t flags) >+{ >+ if (flags & NIX_TX_OFFLOAD_TSTAMP_F) { >+

Re: [dpdk-dev] [PATCH v13] app/testpmd: support multi-process

2021-06-08 Thread Thomas Monjalon
08/06/2021 12:39, Andrew Rybchenko: > On 6/8/21 1:22 PM, Thomas Monjalon wrote: > > 08/06/2021 10:42, Andrew Rybchenko: > >> On 4/22/21 4:18 AM, Min Hu (Connor) wrote: > >>> --- a/doc/guides/testpmd_app_ug/run_app.rst > >>> +++ b/doc/guides/testpmd_app_ug/run_app.rst > > [...] > >>> +All the dev op

[dpdk-dev] [PATCH v4] vhost: allocate and free packets in bulk in Tx split

2021-06-08 Thread Balazs Nemeth
Same idea as commit a287ac28919d ("vhost: allocate and free packets in bulk in Tx packed"), allocate and free packets in bulk. Also remove the unused function virtio_dev_pktmbuf_alloc. Signed-off-by: Balazs Nemeth Reviewed-by: Maxime Coquelin --- lib/vhost/virtio_net.c | 40 +++-

[dpdk-dev] [PATCH v3] vhost: allocate and free packets in bulk in Tx split

2021-06-08 Thread Balazs Nemeth
Same idea as commit a287ac28919d ("vhost: allocate and free packets in bulk in Tx packed"), allocate and free packets in bulk. Also remove the unused function virtio_dev_pktmbuf_alloc. Signed-off-by: Balazs Nemeth Reviewed-by: Maxime Coquelin --- lib/vhost/virtio_net.c | 37

Re: [dpdk-dev] 20.11.2 patches review and test

2021-06-08 Thread Kevin Traynor
(reduced Cc) Hi Steven, On 01/06/2021 08:54, Xueming(Steven) Li wrote: > Hi all, > > Here is a list of patches targeted for stable release 20.11.2. > > The planned date for the final release is 15th June. > > Please help with testing and validation of your use cases and report > any issues/res

Re: [dpdk-dev] [PATCH] kni: fix compilation on SLES15-SP3

2021-06-08 Thread Ferruh Yigit
On 6/2/2021 3:33 PM, Christian Ehrhardt wrote: > Like what was done for mainline kernel in commit 38ad54f3bc76 ("kni: fix > build with Linux 5.6"), a new parameter 'txqueue' has to be added to > 'ndo_tx_timeout' ndo on SLES 15-SP3 kernel. > > Caused by: > commit c3bf155c40e9db722feb8a08c19efd44c

[dpdk-dev] [PATCH] mlx5: fix typing error

2021-06-08 Thread Sarosh Arif
change returing to returning. Signed-off-by: Sarosh Arif --- drivers/net/mlx5/mlx5_rxtx_vec_altivec.h | 2 +- drivers/net/mlx5/mlx5_rxtx_vec_neon.h| 2 +- drivers/net/mlx5/mlx5_rxtx_vec_sse.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxt

Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: add link speed check before port start

2021-06-08 Thread Andrew Rybchenko
On 4/28/21 11:36 AM, Min Hu (Connor) wrote: > From: Huisong Li > > Currently, to check whether the configured link_speeds is valid, we > have to run "port start". In addition, if the configuration fails, > "port->dev_conf.link_speeds" maintained in testpmd cannot be > restored. > > This patch ad

Re: [dpdk-dev] [PATCH v13] app/testpmd: support multi-process

2021-06-08 Thread Andrew Rybchenko
On 6/8/21 1:22 PM, Thomas Monjalon wrote: > 08/06/2021 10:42, Andrew Rybchenko: >> On 4/22/21 4:18 AM, Min Hu (Connor) wrote: >>> --- a/doc/guides/testpmd_app_ug/run_app.rst >>> +++ b/doc/guides/testpmd_app_ug/run_app.rst > [...] >>> +All the dev ops is supported in primary process. While secondary

Re: [dpdk-dev] [RFC] Support metering policy for yellow color in mlx5 PMD

2021-06-08 Thread Dumitrescu, Cristian
Hi Bing, I am not entirely sure what your question is; if your question is: can I use all the features of the API, then the answer is definitely YES :). > -Original Message- > From: Bing Zhao > Sent: Wednesday, June 2, 2021 2:25 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Li Zh

Re: [dpdk-dev] code.dpdk.org bugfix releases

2021-06-08 Thread Kevin Traynor
+Cc: Christian and Steven On 08/06/2021 10:57, Morten Brørup wrote: > + Stable maintainers: Luca Boccassi, Kevin Traynor. > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ali Alnubani >> Sent: Monday, 7 June 2021 14.49 >> >> Hi, >> >>> From: Morten Brørup >>> Sent: Friday, June 4, 2021

Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: add link speed check before port start

2021-06-08 Thread Andrew Rybchenko
On 4/30/21 6:19 AM, Li, Xiaoyun wrote: > >> -Original Message- >> From: Min Hu (Connor) >> Sent: Wednesday, April 28, 2021 16:37 >> To: dev@dpdk.org >> Cc: Yigit, Ferruh ; Li, Xiaoyun >> >> Subject: [PATCH v2 1/2] app/testpmd: add link speed check before port start >> >> From: Huisong L

[dpdk-dev] [PATCH v4] eal: arm: fix out of tree build

2021-06-08 Thread Michael Pfeiffer
Including various headers may fail for ARM builds with 'Platform must be built with RTE_FORCE_INTRINSICS' if rte_config.h is not included before. Move the error message after the includes to ensure rte_config.h is always included. Fixes: de966ccdcd7f ("eal/arm: add byte order operations for ARM")

Re: [dpdk-dev] [PATCH v2 0/2] fixes for link speed

2021-06-08 Thread Andrew Rybchenko
What is the difference of v2 from v1? Please, try to add version changelog in the future. On 4/28/21 11:36 AM, Min Hu (Connor) wrote: > This patchset contains fixes for link speed in testpmd. > > Huisong Li (2): > app/testpmd: add link speed check before port start > app/testpmd: fix link spe

Re: [dpdk-dev] 20.11.2 patches review and test

2021-06-08 Thread Pei Zhang
Hello Xueming, The testing with dpdk 20.11.2-rc1 from Red Hat looks good. We tested below 16 scenarios and all got PASS on RHEL8: (1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS (2)Guest with device assignment(PF) throughput testing(2M hugepage size) : PASS (3)Guest

Re: [dpdk-dev] [PATCH v2] bitmap: fix buffer overrun in bitmap init function

2021-06-08 Thread Dumitrescu, Cristian
> -Original Message- > From: Andrew Rybchenko > Sent: Wednesday, June 2, 2021 10:49 AM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; Ivan Ilchenko ; > sta...@dpdk.org; Andy Moreton > Subject: [PATCH v2] bitmap: fix buffer overrun in bitmap init function > > From: Ivan Ilchenko > >

Re: [dpdk-dev] [PATCH 3/4] net: introduce functions to verify L4 checksums

2021-06-08 Thread Andrew Rybchenko
On 4/30/21 6:42 PM, Ferruh Yigit wrote: > On 4/27/2021 2:57 PM, Olivier Matz wrote: >> Since commit d5df2ae0428a ("net: fix unneeded replacement of TCP >> checksum 0"), the functions rte_ipv4_udptcp_cksum() and >> rte_ipv6_udptcp_cksum() can return either 0x or 0x when used to >> verify a p

Re: [dpdk-dev] code.dpdk.org bugfix releases

2021-06-08 Thread Thomas Monjalon
08/06/2021 11:57, Morten Brørup: > + Stable maintainers: Luca Boccassi, Kevin Traynor. > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ali Alnubani > > Sent: Monday, 7 June 2021 14.49 > > > > Hi, > > > > > From: Morten Brørup > > > Sent: Friday, June 4, 2021 12:14 PM > > > > > > > Fr

Re: [dpdk-dev] [PATCH v13] app/testpmd: support multi-process

2021-06-08 Thread Thomas Monjalon
08/06/2021 10:42, Andrew Rybchenko: > On 4/22/21 4:18 AM, Min Hu (Connor) wrote: > > --- a/doc/guides/testpmd_app_ug/run_app.rst > > +++ b/doc/guides/testpmd_app_ug/run_app.rst [...] > > +All the dev ops is supported in primary process. While secondary process > > is not permitted > > +to allocate

Re: [dpdk-dev] [PATCH 2/4] net/tap: fix Rx cksum flags on TCP packets

2021-06-08 Thread Andrew Rybchenko
On 4/27/21 4:57 PM, Olivier Matz wrote: > Since commit d5df2ae0428a ("net: fix unneeded replacement of TCP > checksum 0"), the functions rte_ipv4_udptcp_cksum() or > rte_ipv6_udptcp_cksum() can return either 0x or 0x when used to > verify a packet containing a valid checksum. > > This new

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/4] net/tap: fix Rx cksum flags on IP options packets

2021-06-08 Thread Andrew Rybchenko
On 4/30/21 5:48 PM, Ferruh Yigit wrote: > On 4/27/2021 2:57 PM, Olivier Matz wrote: >> When packet type is IPV4_EXT, the checksum is always marked as good in >> the mbuf offload flags. >> >> Since we know the header lengths, we can easily call >> rte_ipv4_udptcp_cksum() in this case too. >> >> Fixe

Re: [dpdk-dev] code.dpdk.org bugfix releases

2021-06-08 Thread Morten Brørup
+ Stable maintainers: Luca Boccassi, Kevin Traynor. > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ali Alnubani > Sent: Monday, 7 June 2021 14.49 > > Hi, > > > From: Morten Brørup > > Sent: Friday, June 4, 2021 12:14 PM > > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thom

Re: [dpdk-dev] [PATCH v3] eal: arm: fix out of tree build

2021-06-08 Thread Ruifeng Wang
> -Original Message- > From: Michael Pfeiffer > Sent: Monday, June 7, 2021 2:53 PM > To: Jan Viktorin ; Ruifeng Wang > ; jer...@marvell.com > Cc: dev@dpdk.org; Michael Pfeiffer ; > ko...@rehivetech.com; sta...@dpdk.org > Subject: [PATCH v3] eal: arm: fix out of tree build > > Including rt

Re: [dpdk-dev] [PATCH 2/2] net/bonding: support configuring Tx offloading for bonding

2021-06-08 Thread Andrew Rybchenko
"for bonding" is redundant in the summary since it is already "net/bonding" On 4/23/21 12:46 PM, Chengchang Tang wrote: > Currently, the TX offloading of the bonding device will not take effect by TX -> Tx > using dev_configure. Because the related configuration will not be > delivered to the sl

Re: [dpdk-dev] [PATCH 1/2] net/bonding: support Tx prepare for bonding

2021-06-08 Thread Andrew Rybchenko
"for bonding" is redundant in the summary since it is already "net/bonding". On 4/23/21 12:46 PM, Chengchang Tang wrote: > To use the HW offloads capability (e.g. checksum and TSO) in the Tx > direction, the upper-layer users need to call rte_eth_dev_prepare to do > some adjustment to the packets

[dpdk-dev] [Bug 727] [build]Some branch build failed on Fedora34 with gcc 11/clang12

2021-06-08 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=727 Bug ID: 727 Summary: [build]Some branch build failed on Fedora34 with gcc 11/clang12 Product: DPDK Version: unspecified Hardware: All OS: Linux Status: U

Re: [dpdk-dev] 20.11.2 patches review and test

2021-06-08 Thread Jiang, YuX
Hi Steven, Testing with dpdk v20.11.2-rc1 from Intel looks good, no critical issue is found. All of them are known issues. More details as below: # Basic Intel(R) NIC testing *PF(i40e, ixgbe): test scenarios including rte_flow/TSO/Jumboframe/checksum offload/Tunnel, etc. Listed but not

Re: [dpdk-dev] [PATCH v13] app/testpmd: support multi-process

2021-06-08 Thread Andrew Rybchenko
@Thomas, @Ferruh, please, see question below. On 4/22/21 4:18 AM, Min Hu (Connor) wrote: > This patch adds multi-process support for testpmd. > The test cmd example as follows: > the primary cmd: > ./dpdk-testpmd -a xxx --proc-type=auto -l 0-1 -- -i \ > --rxq=4 --txq=4 --num-procs=2 --proc-id=0 >

Re: [dpdk-dev] [RFC v2] bus/auxiliary: introduce auxiliary bus

2021-06-08 Thread Wang, Haiyue
Hi Andrew, > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, June 8, 2021 15:53 > To: Xueming Li > Cc: dev@dpdk.org; Parav Pandit ; Ray Kinsella > ; Wang, Haiyue > ; andrew.rybche...@oktetlabs.ru > Subject: Re: [dpdk-dev] [RFC v2] bus/auxiliary: introduce auxiliary bus >

Re: [dpdk-dev] [PATCH v7 0/3] fix PF reset causes VF memory request failure

2021-06-08 Thread David Marchand
On Mon, May 24, 2021 at 3:44 AM Haiyue Wang wrote: > > Trigger the VF reset from PF reset, > > echo 1 > /sys/bus/pci/devices/PF-BDF/reset > > the PCI bus master bit will cleared on VF, so the VF needs to enable > this bit before restart. > > This patch set adds the API to enable PCI bus ma

Re: [dpdk-dev] [PATCH 1/2] ethdev: make flow API primary/secondary process safe

2021-06-08 Thread Andrew Rybchenko
On 3/15/21 10:27 PM, Stephen Hemminger wrote: > Posix mutex are not by default safe for protecting for usage > from multiple processes. The flow ops mutex could be used by > both primary and secondary processes. > > Bugzilla ID: 662 > Signed-off-by: Stephen Hemminger > Fixes: 80d1a9aff7f6 ("ethde

Re: [dpdk-dev] [PATCH 2/2] net/failsafe: fix primary/secondary mutex

2021-06-08 Thread Andrew Rybchenko
On 4/19/21 8:08 PM, Thomas Monjalon wrote: > About the title, better to speak about multi-process, > it is less confusing than primary/secondary. > > 15/03/2021 20:27, Stephen Hemminger: >> Set mutex used in failsafe driver to protect when used by >> both primary and secondary process. Without thi

Re: [dpdk-dev] [RFC v2] bus/auxiliary: introduce auxiliary bus

2021-06-08 Thread Thomas Monjalon
10/05/2021 15:47, Xueming Li: > Auxiliary [1] provides a way to split function into child-devices Auxiliary -> Auxiliary bus > representing sub-domains of functionality. Each auxiliary_device auxiliary_device -> auxiliary device > represents a part of its parent functionality. > > Auxiliary de

Re: [dpdk-dev] [PATCH v9 10/10] Enable the new EAL thread API

2021-06-08 Thread David Marchand
On Tue, Jun 8, 2021 at 7:50 AM Narcisa Ana Maria Vasile wrote: > > On Fri, Jun 04, 2021 at 04:44:34PM -0700, Narcisa Ana Maria Vasile wrote: > > From: Narcisa Vasile > > > > Rename pthread_* occurrences with the new rte_thread_* API. > > Enable the new API in the build system. > > > > Signed-off-

Re: [dpdk-dev] [PATCH] gpudev: introduce memory API

2021-06-08 Thread Thomas Monjalon
08/06/2021 09:09, Jerin Jacob: > On Tue, Jun 8, 2021 at 12:05 PM Thomas Monjalon wrote: > > > > 08/06/2021 06:10, Jerin Jacob: > > > On Mon, Jun 7, 2021 at 10:17 PM Thomas Monjalon > > > wrote: > > > > > > > > 07/06/2021 15:54, Jerin Jacob: > > > > > On Mon, Jun 7, 2021 at 4:13 PM Thomas Monjalo

Re: [dpdk-dev] [PATCH] gpudev: introduce memory API

2021-06-08 Thread Jerin Jacob
On Tue, Jun 8, 2021 at 12:05 PM Thomas Monjalon wrote: > > 08/06/2021 06:10, Jerin Jacob: > > On Mon, Jun 7, 2021 at 10:17 PM Thomas Monjalon wrote: > > > > > > 07/06/2021 15:54, Jerin Jacob: > > > > On Mon, Jun 7, 2021 at 4:13 PM Thomas Monjalon > > > > wrote: > > > > > 07/06/2021 09:20, Wang,