Re: [dpdk-dev] [PATCH] parray: introduce internal API for dynamic arrays

2021-06-14 Thread Thomas Monjalon
14/06/2021 17:48, Jerin Jacob: > On Mon, Jun 14, 2021 at 8:29 PM Ananyev, Konstantin > wrote: > > > 14/06/2021 15:15, Bruce Richardson: > > > > On Mon, Jun 14, 2021 at 02:22:42PM +0200, Morten Brørup wrote: > > > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > > > > >

Re: [dpdk-dev] [PATCH] parray: introduce internal API for dynamic arrays

2021-06-14 Thread Thomas Monjalon
14/06/2021 17:48, Morten Brørup: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > It would be much simpler to just increase RTE_MAX_ETHPORTS to something big > enough to hold a sufficiently large array. And possibly add an > rte_max_ethports variable to indicate the numb

Re: [dpdk-dev] [PATCH v1] net/i40e: remove the SMP barrier in HW scanning func

2021-06-14 Thread Joyce Kong
> > > > > Add the logic to determine how many DD bits have been set for > > > > > contiguous packets, for removing the SMP barrier while reading descs. > > > > > > > > I didn't understand this. > > > > The current logic already guarantee the read out DD bits are from > > > > continue packets, as

Re: [dpdk-dev] [RFC 00/14] mlx5: support SubFunction

2021-06-14 Thread Parav Pandit
> From: Xia, Chenbo > Sent: Tuesday, June 15, 2021 11:03 AM > > Hi Parav, > > > -Original Message- > > From: Parav Pandit > > Sent: Tuesday, June 15, 2021 12:05 PM > > To: Xia, Chenbo ; NBU-Contact-Thomas Monjalon > > ; Yigit, Ferruh > > Cc: Xueming(Steven) Li ; Slava Ovsiienko > > ;

Re: [dpdk-dev] [RFC 00/14] mlx5: support SubFunction

2021-06-14 Thread Xia, Chenbo
Hi Parav, > -Original Message- > From: Parav Pandit > Sent: Tuesday, June 15, 2021 12:05 PM > To: Xia, Chenbo ; NBU-Contact-Thomas Monjalon > ; Yigit, Ferruh > Cc: Xueming(Steven) Li ; Slava Ovsiienko > ; dev@dpdk.org; Jason Gunthorpe > Subject: RE: [dpdk-dev] [RFC 00/14] mlx5: support

Re: [dpdk-dev] [RFC 00/14] mlx5: support SubFunction

2021-06-14 Thread Parav Pandit
Hi Chenbo, > From: Xia, Chenbo > Sent: Tuesday, June 15, 2021 7:41 AM > > Hi Thomas, > > > From: Thomas Monjalon > > Sent: Friday, June 11, 2021 3:54 PM [..] > > Yes. In our term it's called Assignable Device Interface (ADI) introduced in > Intel Scalable IOV (https://01.org/blogs/2019/assig

Re: [dpdk-dev] [PATCH v2] net/hns3: support Tx push quick doorbell to improve perf

2021-06-14 Thread Min Hu (Connor)
Hi, Stephen, Volatile is used here to prevent compiler optimization (deleting the reg write operation). By the way, this is an initialization process and does not involve multi-thread synchronization. Therefore no need to use the barrier. 在 2021/6/15 10:37, Stephen Hemminger 写道: On Tue, 15 Jun 2

Re: [dpdk-dev] 19.11.9 patches review and test - V2

2021-06-14 Thread Pei Zhang
Hi Christian, The testing with dpdk 19.11.9-rc2 from Red Hat looks good. We tested below 16 scenarios and all got PASS on RHEL8: (1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS (2)Guest with device assignment(PF) throughput testing(2M hugepage size) : PASS (3)Guest

Re: [dpdk-dev] [PATCH v5 02/24] net/ngbe: add device IDs

2021-06-14 Thread Jiawen Wu
On Tuesday, June 15, 2021 1:09 AM, Andrew Rybchenko wrote: > On 6/2/21 12:40 PM, Jiawen Wu wrote: > > Add device IDs for Wangxun 1Gb NICs, and register rte_ngbe_pmd. > > > > Signed-off-by: Jiawen Wu > > --- > > drivers/net/ngbe/base/meson.build | 18 +++ > > drivers/net/ngbe/base/ngbe_dev

Re: [dpdk-dev] [RFC v3 0/6] Add mdev (Mediated device) support in DPDK

2021-06-14 Thread Xia, Chenbo
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Friday, June 11, 2021 3:16 PM > To: Xia, Chenbo > Cc: dev@dpdk.org; Liang, Cunming ; Wu, Jingjing > ; Burakov, Anatoly ; Yigit, > Ferruh ; m...@ashroe.eu; nhor...@tuxdriver.com; > Richardson, Bruce ; david.march...@redhat.co

Re: [dpdk-dev] [PATCH v2] net/hns3: support Tx push quick doorbell to improve perf

2021-06-14 Thread Stephen Hemminger
On Tue, 15 Jun 2021 09:34:29 +0800 "Min Hu (Connor)" wrote: > +void > +hns3_tx_push_init(struct rte_eth_dev *dev) > +{ > + struct hns3_hw *hw = HNS3_DEV_PRIVATE_TO_HW(dev->data->dev_private); > + volatile uint32_t *reg; > + uint32_t val; > + > + if (!hns3_dev_tx_push_supported(hw)

Re: [dpdk-dev] [PATCH v2] net/hns3: support Tx push quick doorbell to improve perf

2021-06-14 Thread Stephen Hemminger
On Tue, 15 Jun 2021 09:34:29 +0800 "Min Hu (Connor)" wrote: > + return (void *)((char *)pci_dev->mem_resource[bar_id].addr + > + (pci_dev->mem_resource[bar_id].len >> 1) + > + HNS3_TX_PUSH_TQP_REGION_SIZE * queue_id + > + HNS3_TX_PUS

Re: [dpdk-dev] [RFC 00/14] mlx5: support SubFunction

2021-06-14 Thread Xia, Chenbo
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Friday, June 11, 2021 3:54 PM > To: Yigit, Ferruh ; Xia, Chenbo > Cc: Xueming Li ; Viacheslav Ovsiienko > ; dev@dpdk.org; pa...@nvidia.com; j...@nvidia.com > Subject: Re: [dpdk-dev] [RFC 00/14] mlx5: support SubFunction > >

Re: [dpdk-dev] [PATCH] net/hns3: support Tx push quick doorbell to improve perf

2021-06-14 Thread Min Hu (Connor)
fixed in v2, thanks. 在 2021/6/14 22:35, Andrew Rybchenko 写道: Why is the same patch sent twice? Could you cleanup patchwork, please, and set appropriate status? On 6/13/21 4:42 AM, Min Hu (Connor) wrote: From: Chengwen Feng Kunpeng 930 support tx push mode which could improve performance, It

[dpdk-dev] [PATCH v2] net/hns3: support Tx push quick doorbell to improve perf

2021-06-14 Thread Min Hu (Connor)
From: Chengwen Feng Kunpeng 930 support Tx push mode which could improve performance, It works like below: 1. Add PCIe bar45 which support driver direct write the Tx descriptor or tail reg to it. 2. Support three operations: a) direct write one Tx descriptor, b) direct write two Tx descriptors, c

Re: [dpdk-dev] [PATCH 0/6] bugfixes for hns3 PMD

2021-06-14 Thread Min Hu (Connor)
在 2021/6/14 22:43, Andrew Rybchenko 写道: On 6/13/21 5:31 AM, Min Hu (Connor) wrote: This patch set contains 6 bugfixes for hns3 PMD. Chengchang Tang (1):    net/hns3: fix VLAN strip log HongBo Zheng (2):    net/hns3: modify max reset fail retry count    net/hns3: delete redundant blank lines

Re: [dpdk-dev] [PATCH v5 00/24] net: ngbe PMD

2021-06-14 Thread Andrew Rybchenko
On 6/2/21 12:40 PM, Jiawen Wu wrote: This patch set provides a skeleton of ngbe PMD, which adapted to Wangxun WX1860 series NICs. My main concerns for the patch series except style notes is a separation info patches. Every patch should be testable. I should be able to stop at any patch in the s

Re: [dpdk-dev] [PATCH v5 23/24] net/ngbe: start and stop RxTx

2021-06-14 Thread Andrew Rybchenko
On 6/2/21 12:41 PM, Jiawen Wu wrote: Support to start and stop receive and transmit unit for specified queues. Before the patch attempt to setup Rx or Tx queue with deferred start should return an error. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/ngbe.ini | 1 + drivers/net

Re: [dpdk-dev] Memory leak in rte_pci_scan

2021-06-14 Thread Owen Hilyard
>From what I've seen so far, that fixes the PCI leak. That just leaves a few other places. I'll try to get the complete list to you tomorrow, since running the full set of unit tests takes quite a few hours when ASAN is involved. On Mon, Jun 14, 2021 at 6:30 AM David Marchand wrote: > On Mon, Ju

Re: [dpdk-dev] [PATCH v5 22/24] net/ngbe: add device start operation

2021-06-14 Thread Andrew Rybchenko
On 6/2/21 12:41 PM, Jiawen Wu wrote: Setup misx interrupt, complete PHY configuration and set device link speed, msix -> MSI-X to start device. Shouldn't stop go together with start? The patch should be testable. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_dummy.h | 16 +

[dpdk-dev] [PATCH 2/2] event/octeontx2: configure aura backpressure

2021-06-14 Thread pbhagavatula
From: Pavan Nikhilesh In poll mode driver of octeontx2 the RQ is connected to a CQ and it is responsible for asserting backpressure to the CGX channel. When event eth Rx adapter is configured, the RQ is connected to a event queue, to enable backpressure we need to configure AURA assigned to a giv

[dpdk-dev] [PATCH 1/2] mempool/octeontx2: fix shift calculation

2021-06-14 Thread pbhagavatula
From: Pavan Nikhilesh Shift is used to generate an 8-bit saturate value from the current aura used count. The shift value should be derived from the log2 of block count if it is greater than 256 else the shift should be 0. Fixes: 7bcc47cbe2fa ("mempool/octeontx2: add mempool alloc op") Signed-o

Re: [dpdk-dev] [PATCH v5 21/24] net/ngbe: support full-featured Tx path

2021-06-14 Thread Andrew Rybchenko
On 6/14/21 10:22 PM, Andrew Rybchenko wrote: On 6/2/21 12:41 PM, Jiawen Wu wrote: Add the full-featured transmit function, which supports checksum, TSO, tunnel parse, etc. The patch should adviertise corresponding offloads support in features, in dev_info Tx offloads. Tx offloads require Tx p

Re: [dpdk-dev] [PATCH v5 21/24] net/ngbe: support full-featured Tx path

2021-06-14 Thread Andrew Rybchenko
On 6/2/21 12:41 PM, Jiawen Wu wrote: Add the full-featured transmit function, which supports checksum, TSO, tunnel parse, etc. The patch should adviertise corresponding offloads support in features, in dev_info Tx offloads. Tx offloads require Tx prepare implemenation. Can you really skip it?

Re: [dpdk-dev] [PATCH v5 20/24] net/ngbe: support bulk and scatter Rx

2021-06-14 Thread Andrew Rybchenko
On 6/2/21 12:41 PM, Jiawen Wu wrote: Add bulk allocation receive function, and support scattered Rx rely on Rx offload. The patch should advertise Rx scatter offload, not earlier. Corresponding bits of the patch should be here as well. Signed-off-by: Jiawen Wu --- doc/guides/nics/ngbe.rst

Re: [dpdk-dev] [PATCH v5 19/24] net/ngbe: add simple Rx and Tx flow

2021-06-14 Thread Andrew Rybchenko
On 6/2/21 12:41 PM, Jiawen Wu wrote: Initialize device with the simplest receive and transmit functions. Why Rx and Tx are mixed in one patch? It looks separate code. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 8 +- drivers/net/ngbe/ngbe_ethdev.h | 6 + drivers/ne

Re: [dpdk-dev] [PATCH v5 18/24] net/ngbe: add packet type

2021-06-14 Thread Andrew Rybchenko
On 6/2/21 12:41 PM, Jiawen Wu wrote: Add packet type marco definition and convert ptype to ptid. What about eth_dev_ptypes_set_t callback? Signed-off-by: Jiawen Wu --- doc/guides/nics/features/ngbe.ini | 1 + doc/guides/nics/ngbe.rst | 1 + drivers/net/ngbe/meson.build

Re: [dpdk-dev] [PATCH v5 17/24] net/ngbe: add Rx and Tx init

2021-06-14 Thread Andrew Rybchenko
On 6/2/21 12:41 PM, Jiawen Wu wrote: Initializes receive unit and transmit unit. Signed-off-by: Jiawen Wu The patch is a dead code since added functions are not used. --- doc/guides/nics/features/ngbe.ini | 6 + doc/guides/nics/ngbe.rst | 2 + drivers/net/ngbe/ngbe_ethdev.h

Re: [dpdk-dev] [PATCH v5 16/24] net/ngbe: add Tx queue setup and release

2021-06-14 Thread Andrew Rybchenko
On 6/2/21 12:41 PM, Jiawen Wu wrote: Setup device Tx queue and release Tx queue. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 2 + drivers/net/ngbe/ngbe_ethdev.h | 6 + drivers/net/ngbe/ngbe_rxtx.c | 212 + drivers/net/ngbe/ngbe_rxtx.h

Re: [dpdk-dev] [PATCH v5 15/24] net/ngbe: add Rx queue setup and release

2021-06-14 Thread Andrew Rybchenko
On 6/2/21 12:40 PM, Jiawen Wu wrote: Setup device Rx queue and release Rx queue. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 9 + drivers/net/ngbe/ngbe_ethdev.h | 8 + drivers/net/ngbe/ngbe_rxtx.c | 305 + drivers/net/ngbe/ngbe_rxtx.h

Re: [dpdk-dev] [PATCH v5 13/24] net/ngbe: support link update

2021-06-14 Thread Andrew Rybchenko
On 6/2/21 12:40 PM, Jiawen Wu wrote: Register to handle device interrupt. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/ngbe.ini | 2 + doc/guides/nics/ngbe.rst | 5 + drivers/net/ngbe/base/ngbe_dummy.h | 6 + drivers/net/ngbe/base/ngbe_type.h | 11 + drivers/ne

Re: [dpdk-dev] RFC: Kunpeng DMA driver API design decision

2021-06-14 Thread Bruce Richardson
On Sat, Jun 12, 2021 at 02:11:10PM +0530, Jerin Jacob wrote: > On Sat, Jun 12, 2021 at 2:01 PM Thomas Monjalon wrote: > > > > 12/06/2021 09:01, fengchengwen: > > > Hi all, > > > > > > We prepare support Kunpeng DMA engine under rawdev framework, and > > > observed that > > > there are two differe

Re: [dpdk-dev] [PATCH v5 12/24] net/ngbe: add info get operation

2021-06-14 Thread Andrew Rybchenko
On 6/2/21 12:40 PM, Jiawen Wu wrote: Add device information get operation. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/ngbe.ini | 1 + drivers/net/ngbe/meson.build | 1 + drivers/net/ngbe/ngbe_ethdev.c| 86 +++ drivers/net/ngbe/ngbe_ethdev.h

Re: [dpdk-dev] [PATCH v5 09/24] net/ngbe: add HW initialization

2021-06-14 Thread Andrew Rybchenko
On 6/2/21 12:40 PM, Jiawen Wu wrote: Initialize the hardware by resetting the hardware in base code. Signed-off-by: Jiawen Wu [snip] diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c index c2f92a8437..bb5923c485 100644 --- a/drivers/net/ngbe/ngbe_ethdev.c +++ b/dr

Re: [dpdk-dev] [PATCH v5 05/24] net/ngbe: add log type and error type

2021-06-14 Thread Andrew Rybchenko
On 6/2/21 12:40 PM, Jiawen Wu wrote: Add log type and error type to trace functions. Signed-off-by: Jiawen Wu --- doc/guides/nics/ngbe.rst| 20 + drivers/net/ngbe/base/ngbe_status.h | 125 drivers/net/ngbe/base/ngbe_type.h | 1 + drivers/ne

Re: [dpdk-dev] [PATCH] app/testpmd: send failure logs to stderr

2021-06-14 Thread Singh, Aman Deep
On 6/14/2021 10:26 PM, Andrew Rybchenko wrote: On 6/11/21 1:35 PM, Ferruh Yigit wrote: On 6/11/2021 10:19 AM, Andrew Rybchenko wrote: On 6/11/21 5:06 AM, Li, Xiaoyun wrote: Hi -Original Message- From: Andrew Rybchenko Sent: Friday, May 28, 2021 00:25 To: Li, Xiaoyun Cc: dev@dpdk.or

Re: [dpdk-dev] [PATCH v5 04/24] net/ngbe: add device init and uninit

2021-06-14 Thread Andrew Rybchenko
On 6/2/21 12:40 PM, Jiawen Wu wrote: Add basic init and uninit function. Map device IDs and subsystem IDs to single ID for easy operation. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/meson.build | 4 +- drivers/net/ngbe/base/ngbe.h | 11 ++ drivers/net/ngbe/base/ngbe_hw.c

Re: [dpdk-dev] [PATCH v5 03/24] net/ngbe: support probe and remove

2021-06-14 Thread Andrew Rybchenko
On 6/2/21 12:40 PM, Jiawen Wu wrote: Add basic PCIe ethdev probe and remove. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/ngbe.ini | 1 + drivers/net/ngbe/ngbe_ethdev.c| 44 --- drivers/net/ngbe/ngbe_ethdev.h| 10 +++ 3 files changed, 52 in

Re: [dpdk-dev] [PATCH v5 02/24] net/ngbe: add device IDs

2021-06-14 Thread Andrew Rybchenko
On 6/2/21 12:40 PM, Jiawen Wu wrote: Add device IDs for Wangxun 1Gb NICs, and register rte_ngbe_pmd. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/meson.build | 18 +++ drivers/net/ngbe/base/ngbe_devids.h | 84 + drivers/net/ngbe/meson.build|

Re: [dpdk-dev] [PATCH v5 01/24] net/ngbe: add build and doc infrastructure

2021-06-14 Thread Andrew Rybchenko
On 6/2/21 12:40 PM, Jiawen Wu wrote: Adding bare minimum PMD library and doc build infrastructure and claim the maintainership for ngbe PMD. Signed-off-by: Jiawen Wu --- MAINTAINERS| 6 ++ doc/guides/nics/features/ngbe.ini | 10 + doc/guides/nic

Re: [dpdk-dev] [PATCH] app/testpmd: send failure logs to stderr

2021-06-14 Thread Andrew Rybchenko
On 6/11/21 1:35 PM, Ferruh Yigit wrote: On 6/11/2021 10:19 AM, Andrew Rybchenko wrote: On 6/11/21 5:06 AM, Li, Xiaoyun wrote: Hi -Original Message- From: Andrew Rybchenko Sent: Friday, May 28, 2021 00:25 To: Li, Xiaoyun Cc: dev@dpdk.org Subject: [PATCH] app/testpmd: send failure logs

Re: [dpdk-dev] [PATCH] app/testpmd: send failure logs to stderr

2021-06-14 Thread Andrew Rybchenko
On 6/11/21 4:21 PM, Bruce Richardson wrote: On Fri, Jun 11, 2021 at 11:35:59AM +0100, Ferruh Yigit wrote: On 6/11/2021 10:19 AM, Andrew Rybchenko wrote: On 6/11/21 5:06 AM, Li, Xiaoyun wrote: Hi -Original Message- From: Andrew Rybchenko Sent: Friday, May 28, 2021 00:25 To: Li, Xiaoyun

Re: [dpdk-dev] [PATCH v3] doc/rel_notes: remove old deprecation notice for sched

2021-06-14 Thread Andrew Rybchenko
On 6/14/21 7:30 PM, Jasvinder Singh wrote: APIs and data structures hasve been modified as per deprecation note, so removing deprecation notice from the notes. Fixes: 85f52aa422d6 ("sched: add pipe config params to subport struct") Signed-off-by: Jasvinder Singh Acked-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH] net: introduce IPv4 ihl and version fields

2021-06-14 Thread Andrew Rybchenko
On 6/10/21 12:22 PM, Olivier Matz wrote: Hi Gregory, On Thu, Jun 10, 2021 at 04:10:25AM +, Gregory Etelson wrote: Hello, There was no activity that patch for a long time. The patch is marked as failed, but we verified failed tests and concluded that the failures can be ignored. https://pa

[dpdk-dev] [PATCH v3] doc/rel_notes: remove old deprecation notice for sched

2021-06-14 Thread Jasvinder Singh
APIs and data structures hasve been modified as per deprecation note, so removing deprecation notice from the notes. Fixes: 85f52aa422d6 ("sched: add pipe config params to subport struct") Signed-off-by: Jasvinder Singh --- v3 - correct the fixes tag v2 - add fixes tag doc/guides/rel_notes/de

Re: [dpdk-dev] [PATCH] parray: introduce internal API for dynamic arrays

2021-06-14 Thread Ananyev, Konstantin
> > > > 14/06/2021 15:15, Bruce Richardson: > > > On Mon, Jun 14, 2021 at 02:22:42PM +0200, Morten Brørup wrote: > > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > > > > > Sent: Monday, 14 June 2021 12.59 > > > > > > > > > > Performance of access in a fixed-size arr

[dpdk-dev] [Bug 734] memif driver crashes when there's different N of TX and RX queues

2021-06-14 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=734 Bug ID: 734 Summary: memif driver crashes when there's different N of TX and RX queues Product: DPDK Version: 20.11 Hardware: All OS: All Status: UNCONFI

Re: [dpdk-dev] [PATCH] parray: introduce internal API for dynamic arrays

2021-06-14 Thread Jerin Jacob
On Mon, Jun 14, 2021 at 8:29 PM Ananyev, Konstantin wrote: > > > > > > 14/06/2021 15:15, Bruce Richardson: > > > On Mon, Jun 14, 2021 at 02:22:42PM +0200, Morten Brørup wrote: > > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > > > > > Sent: Monday, 14 June 2021 12.59

Re: [dpdk-dev] [PATCH] parray: introduce internal API for dynamic arrays

2021-06-14 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Monday, 14 June 2021 15.32 > > 14/06/2021 15:15, Bruce Richardson: > > On Mon, Jun 14, 2021 at 02:22:42PM +0200, Morten Brørup wrote: > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas > Monjalon > > >

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-06-14 Thread Andrew Rybchenko
Summary should start from "ethdev: " Don't forget to include all maintainers in Cc the next time. Just use --cc-cmd or --to-cmd options. Adding Thomas. On 5/8/21 11:00 AM, Huisong Li wrote: Currently, if dev_configure is not invoked or fails to be invoked, users can still invoke dev_start succ

Re: [dpdk-dev] [PATCH 0/4] features for hns3 PMD

2021-06-14 Thread Andrew Rybchenko
On 6/13/21 6:05 AM, Min Hu (Connor) wrote: This patch set contains 4 features for hns3 PMD: add query basic info support for VF support for VF modify VLAN filter state support multiple TC MAC pause supports disabling PFC by dev configure API Chengchang Tang (2): net/hns3: add query basic info

[dpdk-dev] [PATCH v2] doc/rel_notes: remove old deprecation notice for sched

2021-06-14 Thread Jasvinder Singh
APIs and data structures hasve been modified as per deprecation note, so removing deprecation notice from the notes. Fixes: 8b16a7a6fa5d ("doc: announce sched API change") Signed-off-by: Jasvinder Singh --- v2: - add fixes tag doc/guides/rel_notes/deprecation.rst | 6 -- 1 file changed, 6

Re: [dpdk-dev] [PATCH 4/4] net/hns3: supports disabling PFC by dev configure API

2021-06-14 Thread Andrew Rybchenko
On 6/13/21 6:05 AM, Min Hu (Connor) wrote: From: Huisong Li If "dcb_capability_en" in "data->dev_conf" delivered from the dev_configure does not have the ETH_DCB_PFC_SUPPORT flag, the user wants to disable PFC, and only enable ETS. Therefore, this patch supports the function of disabling PFC by

Re: [dpdk-dev] [PATCH] parray: introduce internal API for dynamic arrays

2021-06-14 Thread Ananyev, Konstantin
> > 14/06/2021 15:15, Bruce Richardson: > > On Mon, Jun 14, 2021 at 02:22:42PM +0200, Morten Brørup wrote: > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > > > > Sent: Monday, 14 June 2021 12.59 > > > > > > > > Performance of access in a fixed-size array is very goo

Re: [dpdk-dev] [PATCH 2/2] net/failsafe: fix primary/secondary mutex

2021-06-14 Thread Gaëtan Rivet
On Wed, Jun 9, 2021, at 12:04, Andrew Rybchenko wrote: > On 6/8/21 11:48 PM, Stephen Hemminger wrote: > > On Tue, 8 Jun 2021 18:55:17 +0300 > > Andrew Rybchenko wrote: > > > >> On 6/8/21 6:42 PM, Stephen Hemminger wrote: > >>> On Tue, 8 Jun 2021 11:00:37 +0300 > >>> Andrew Rybchenko wrote: > >>>

Re: [dpdk-dev] [PATCH 0/6] bugfixes for hns3 PMD

2021-06-14 Thread Andrew Rybchenko
On 6/13/21 5:31 AM, Min Hu (Connor) wrote: This patch set contains 6 bugfixes for hns3 PMD. Chengchang Tang (1): net/hns3: fix VLAN strip log HongBo Zheng (2): net/hns3: modify max reset fail retry count net/hns3: delete redundant blank lines Huisong Li (3): net/hns3: fix delay tim

Re: [dpdk-dev] [PATCH 1/6] net/hns3: modify max reset fail retry count

2021-06-14 Thread Andrew Rybchenko
On 6/13/21 5:31 AM, Min Hu (Connor) wrote: From: HongBo Zheng When the device is very busy, VF reset may have to be retried many times to succeed, leading to the current max reset fail retry count not enough. This patch modify max reset fail retry count to 30 to enhance the reliability of rese

Re: [dpdk-dev] [PATCH] net/hns3: support Tx push quick doorbell to improve perf

2021-06-14 Thread Andrew Rybchenko
Why is the same patch sent twice? Could you cleanup patchwork, please, and set appropriate status? On 6/13/21 4:42 AM, Min Hu (Connor) wrote: From: Chengwen Feng Kunpeng 930 support tx push mode which could improve performance, It tx -> Tx works like below: 1. Add pcie bar45 which support

Re: [dpdk-dev] [PATCH] net/mlx5: fix receiving queue timestamp format

2021-06-14 Thread Matan Azrad
From: Slava Ovsiienko > Sent: Monday, June 14, 2021 4:53 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Matan Azrad > ; christian.ehrha...@canonical.com; Xueming(Steven) > Li ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix receiving queue timestamp format > > The timestamp format was not con

[dpdk-dev] [PATCH] event/dsw: flag proper eventdev adapter capabilities

2021-06-14 Thread Mattias Rönnblom
Set the appropriate capability flags for the RX, crypto and timer eventdev adapters to use. Signed-off-by: Mattias Rönnblom Tested-by: Heng Wang --- drivers/event/dsw/dsw_evdev.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/event/dsw/dsw_evdev.c b

Re: [dpdk-dev] [PATCH 1/2] net/bonding: support Tx prepare for bonding

2021-06-14 Thread Andrew Rybchenko
On 6/10/21 10:32 AM, Chengchang Tang wrote: On 2021/6/9 17:35, Andrew Rybchenko wrote: On 6/9/21 9:42 AM, Chengchang Tang wrote: Hi, Andrew and Ferruh On 2021/6/8 17:49, Andrew Rybchenko wrote: "for bonding" is redundant in the summary since it is already "net/bonding". On 4/23/21 12:46 PM,

Re: [dpdk-dev] [PATCH 2/2] devtools: auto detect branch to search fix patches

2021-06-14 Thread Christian Ehrhardt
On Sat, Jun 12, 2021 at 3:57 PM Xueming Li wrote: > > Current fix scan scripts scanned specified range in current(HEAD) > branch. When users run it in a earlier branch, few patches were ^^ typo missing "an" (if you care) > scanned. > > This patch auto etects branch to scan from range. ^^ typo m

Re: [dpdk-dev] [PATCH 2/2] net/bonding: support configuring Tx offloading for bonding

2021-06-14 Thread Andrew Rybchenko
On 6/14/21 2:05 PM, Ananyev, Konstantin wrote: Hi, Andrew and Ananyev On 2021/6/9 17:37, Andrew Rybchenko wrote: On 6/9/21 12:11 PM, Ananyev, Konstantin wrote: On 2021/6/8 17:49, Andrew Rybchenko wrote: "for bonding" is redundant in the summary since it is already "net/bonding" On 4/2

Re: [dpdk-dev] [PATCH 1/2] devtools: fix version pattern for fix search

2021-06-14 Thread Christian Ehrhardt
On Sat, Jun 12, 2021 at 3:57 PM Xueming Li wrote: > > When scanning fixes from current(HEAD) branch, local tags were included > and reported as version. For example: > $ git tag --contains --merged > 20.11_backport_202010506 // user tag > v20.11 > v20.11.1 > > This patch matches DPDK of

[dpdk-dev] [PATCH] net/mlx5: fix receiving queue timestamp format

2021-06-14 Thread Viacheslav Ovsiienko
The timestamp format was not configured correctly for the receiving queues created via DevX calls. It caused non-UTC timestamps in CQEs for real time configurations. Fixes: d61381ad46d0 ("net/mlx5: support timestamp format") Cc: sta...@dpdk.org Signed-off-by: Viacheslav Ovsiienko --- drivers/n

Re: [dpdk-dev] [PATCH] parray: introduce internal API for dynamic arrays

2021-06-14 Thread Thomas Monjalon
14/06/2021 15:15, Bruce Richardson: > On Mon, Jun 14, 2021 at 02:22:42PM +0200, Morten Brørup wrote: > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > > > Sent: Monday, 14 June 2021 12.59 > > > > > > Performance of access in a fixed-size array is very good > > > because

Re: [dpdk-dev] [PATCH] parray: introduce internal API for dynamic arrays

2021-06-14 Thread Thomas Monjalon
14/06/2021 14:22, Morten Brørup: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > > Sent: Monday, 14 June 2021 12.59 > > > > Performance of access in a fixed-size array is very good > > because of cache locality > > and because there is a single pointer to dereference. >

Re: [dpdk-dev] [PATCH] doc/rel_notes: remove old deprecation notice for sched

2021-06-14 Thread David Marchand
On Mon, Jun 14, 2021 at 11:45 AM Jasvinder Singh wrote: > > APIs and data structures hasve been modifed as per deprecation > note, so removing deprecation notice from the notes. > > Signed-off-by: Jasvinder Singh Please add a Fixes: tag. Thanks. -- David Marchand

Re: [dpdk-dev] [PATCH v2 0/2] Support compressed firmwares

2021-06-14 Thread David Marchand
On Thu, Jun 3, 2021 at 6:55 PM David Marchand wrote: > > Fedora 34 only provides compressed firmwares. > > Introduce an internal driver helper to handle transparently compression. > > I chose libarchive for decompressing as it seems widely available and > DPDK had used it in the past. > > Windows

Re: [dpdk-dev] [PATCH] parray: introduce internal API for dynamic arrays

2021-06-14 Thread Bruce Richardson
On Mon, Jun 14, 2021 at 02:22:42PM +0200, Morten Brørup wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > > Sent: Monday, 14 June 2021 12.59 > > > > Performance of access in a fixed-size array is very good > > because of cache locality > > and because there is a sin

Re: [dpdk-dev] [RFC PATCH] ethdev: add support for testpmd-compliant flow rule dumping

2021-06-14 Thread Singh, Aman Deep
Hi Ivan, As a suggestion, can we add a check for debug log_level in "rte_flow_snprint" itself. So we can avoid CPU time, in cases where we don't want these logs. On 5/27/2021 1:55 PM, Ivan Malov wrote: DPDK applications (for example, OvS) or tests which use RTE flow API need to log created

Re: [dpdk-dev] 20.11.2 patches review and test

2021-06-14 Thread Xueming(Steven) Li
> -Original Message- > From: Xueming(Steven) Li > Sent: Tuesday, June 8, 2021 9:10 PM > To: Kevin Traynor > Cc: dev@dpdk.org; John McNamara ; Luca Boccassi > ; NBU-Contact-Thomas > Monjalon ; Christian Ehrhardt > ; Ferruh Yigit ; > David Marchand > Subject: RE: 20.11.2 patches review

Re: [dpdk-dev] 20.11.2 patches review and test

2021-06-14 Thread Xueming(Steven) Li
> -Original Message- > From: Christian Ehrhardt > Sent: Thursday, June 10, 2021 4:54 PM > To: Xueming(Steven) Li > Cc: dpdk stable ; dev@dpdk.org; Abhishek Marathe > ; Akhil Goyal > ; Ali Alnubani ; > benjamin.wal...@intel.com; David Christensen > ; hariprasad.govindhara...@intel.com;

Re: [dpdk-dev] [PATCH] parray: introduce internal API for dynamic arrays

2021-06-14 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Monday, 14 June 2021 12.59 > > Performance of access in a fixed-size array is very good > because of cache locality > and because there is a single pointer to dereference. > The only drawback is the lack of flexibility:

Re: [dpdk-dev] 19.11.9 patches review and test - V2

2021-06-14 Thread Luc Pelletier
> > # Basic Intel(R) NIC testing > > * PF(i40e, ixgbe): test scenarios including > > rte_flow/TSO/Jumboframe/checksum offload/Tunnel, etc. Listed but not all. > > - Known issues as below: > > 1) https://bugs.dpdk.org/show_bug.cgi?id=731 – [dpdk-19.11.9] > > telemetry: python3 /roo

Re: [dpdk-dev] [PATCH 1/2] net/bonding: support Tx prepare for bonding

2021-06-14 Thread Ananyev, Konstantin
> On 2021/6/9 18:25, Ananyev, Konstantin wrote: > >>> On 4/23/21 12:46 PM, Chengchang Tang wrote: > To use the HW offloads capability (e.g. checksum and TSO) in the Tx > direction, the upper-layer users need to call rte_eth_dev_prepare to do > some adjustment to the packets before s

Re: [dpdk-dev] [PATCH 2/2] net/bonding: support configuring Tx offloading for bonding

2021-06-14 Thread Ananyev, Konstantin
> Hi, Andrew and Ananyev > > On 2021/6/9 17:37, Andrew Rybchenko wrote: > > On 6/9/21 12:11 PM, Ananyev, Konstantin wrote: > >> > >>> > >>> > >>> On 2021/6/8 17:49, Andrew Rybchenko wrote: > "for bonding" is redundant in the summary since it is already > "net/bonding" > > On

[dpdk-dev] [PATCH] parray: introduce internal API for dynamic arrays

2021-06-14 Thread Thomas Monjalon
Performance of access in a fixed-size array is very good because of cache locality and because there is a single pointer to dereference. The only drawback is the lack of flexibility: the size of such an array cannot be increase at runtime. An approach to this problem is to allocate the array at ru

Re: [dpdk-dev] Memory leak in rte_pci_scan

2021-06-14 Thread David Marchand
On Mon, Jun 14, 2021 at 11:11 AM David Marchand wrote: > > On Tue, Jun 8, 2021 at 8:48 PM Owen Hilyard wrote: > > > > Hello All, > > > > As part of the community lab's work to deploy static analysis tools, we've > > been doing test runs of the various tools. One of the problems we found is > > th

[dpdk-dev] [PATCH] doc/rel_notes: remove old deprecation notice for sched

2021-06-14 Thread Jasvinder Singh
APIs and data structures hasve been modifed as per deprecation note, so removing deprecation notice from the notes. Signed-off-by: Jasvinder Singh --- doc/guides/rel_notes/deprecation.rst | 6 -- 1 file changed, 6 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/

[dpdk-dev] [PATCH] ipc: stop mp control thread on cleanup

2021-06-14 Thread David Marchand
When calling rte_eal_cleanup, the mp channel cleanup routine only sets mp_fd to -1 leaving the rte_mp_handle control thread running. This control thread can spew warnings on reading on an invalid fd. To handle this situation, sets mp_fd to -1 to signal the control thread it should exit, but since

Re: [dpdk-dev] Memory leak in rte_pci_scan

2021-06-14 Thread David Marchand
On Tue, Jun 8, 2021 at 8:48 PM Owen Hilyard wrote: > > Hello All, > > As part of the community lab's work to deploy static analysis tools, we've > been doing test runs of the various tools. One of the problems we found is > that rte_pci_scan leaks 214368 Bytes every time it is run. There are also