Re: [dpdk-dev] [PATCH] acl: fix build with GCC 6.3

2021-06-16 Thread Thomas Monjalon
21/05/2021 16:42, Konstantin Ananyev: > --buildtype=debug with gcc 6.3 produces the following error: > > ../lib/librte_acl/acl_run_avx512_common.h: In function > ‘resolve_match_idx_avx512x16’: > ../lib/librte_acl/acl_run_avx512x16.h:33:18: error: > the last argument must be an 8-bit immediat

Re: [dpdk-dev] [PATCH] kni: fix compilation on SLES15-SP3

2021-06-16 Thread Thomas Monjalon
17/06/2021 08:14, Christian Ehrhardt: > On Thu, Jun 10, 2021 at 12:30 PM Christian Ehrhardt > wrote: > > On Thu, Jun 10, 2021 at 10:39 AM Christian Ehrhardt > > wrote: > > > On Tue, Jun 8, 2021 at 1:17 PM Ferruh Yigit > > > wrote: > > > > On 6/2/2021 3:33 PM, Christian Ehrhardt wrote: > > > > >

[dpdk-dev] 19.11.9 patches review and test

2021-06-16 Thread Christian Ehrhardt
Hi all, Here is a list of patches targeted for stable release 19.11.9. The planned date for the final release is 2nd July. Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validations

Re: [dpdk-dev] [PATCH] kni: fix compilation on SLES15-SP3

2021-06-16 Thread Christian Ehrhardt
On Thu, Jun 10, 2021 at 12:30 PM Christian Ehrhardt wrote: > > On Thu, Jun 10, 2021 at 10:39 AM Christian Ehrhardt > wrote: > > > > On Tue, Jun 8, 2021 at 1:17 PM Ferruh Yigit wrote: > > > > > > On 6/2/2021 3:33 PM, Christian Ehrhardt wrote: > > > > Like what was done for mainline kernel in comm

Re: [dpdk-dev] [PATCH v1] net/i40e: fix flow director does not work

2021-06-16 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, June 17, 2021 1:23 AM > To: Xing, Beilei ; Yang, SteveX > ; Zhang, Qi Z > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1] net/i40e: fix flow director does not work > > 01/06/2021 13:12, Zhang, Qi Z: > > > > When user

Re: [dpdk-dev] [PATCH v2] app/testpmd: send failure logs to stderr

2021-06-16 Thread Li, Xiaoyun
Hi > -Original Message- > From: Andrew Rybchenko > Sent: Thursday, June 17, 2021 00:32 > To: Li, Xiaoyun ; Ori Kam > Cc: dev@dpdk.org; Richardson, Bruce ; Yigit, > Ferruh ; Singh, Aman Deep > > Subject: [PATCH v2] app/testpmd: send failure logs to stderr > > Running with stdout suppres

Re: [dpdk-dev] [PATCH 0/4] bnxt fixes

2021-06-16 Thread Ajit Khaparde
On Tue, Jun 8, 2021 at 7:52 PM Kalesh A P wrote: > > From: Kalesh AP > > This set contains few bnxt fixes and code cleanup changes. Patchset applied to dpdk-next-net-brcm for-next-net branch. > > Kalesh AP (4): > net/bnxt: cleanup code > net/bnxt: fix typo in log message > net/bnxt: fix e

[dpdk-dev] [Bug 741] [dpdk-21.05]vhost relaunch meet Segmentation fault issue when virtio queues larger than vhost queues

2021-06-16 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=741 Bug ID: 741 Summary: [dpdk-21.05]vhost relaunch meet Segmentation fault issue when virtio queues larger than vhost queues Product: DPDK Version: unspecified Hardware: All

Re: [dpdk-dev] [PATCH] net/bnxt: add support to dump SFP module info

2021-06-16 Thread Ajit Khaparde
On Tue, Jun 8, 2021 at 7:23 PM Kalesh A P wrote: > > From: Kalesh AP > > Add support to fetch the SFP EEPROM settings from the firmware. > For SFP+ modules we will display 0xA0 page for status and 0xA2 page > for other information. For QSFP modules we will show the 0xA0 page. > > Also identify th

Re: [dpdk-dev] [PATCH] parray: introduce internal API for dynamic arrays

2021-06-16 Thread Dmitry Kozlyuk
2021-06-16 18:29 (UTC+0530), Jerin Jacob: > On Wed, Jun 16, 2021 at 5:52 PM Burakov, Anatoly > wrote: > > > > On 16-Jun-21 10:42 AM, Jerin Jacob wrote: > > > On Tue, Jun 15, 2021 at 12:18 PM Thomas Monjalon > > > wrote: > > >> > > >> 14/06/2021 17:48, Morten Brørup: > > From: dev [mai

[dpdk-dev] [PATCH 4/4] net/bnxt: remove dead code

2021-06-16 Thread Lance Richardson
Code related to maintaining completion ring "valid" state is no longer needed, remove it. Signed-off-by: Lance Richardson Reviewed-by: Ajit Khaparde Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_cpr.h | 17 - drivers/net/bnxt/bnxt_hwrm.c | 2 -- drive

[dpdk-dev] [PATCH 0/4] net/bnxt: various fixes

2021-06-16 Thread Lance Richardson
Several fixes for the bnxt PMD: - Fix NUMA-aware memory allocations. - Fix transmit descriptor status implementation. - Fix handling of transmit completions in non-vector path. - Remove dead code. Lance Richardson (4): net/bnxt: fix ring and context memory allocation net/bnxt: fix

[dpdk-dev] [PATCH 3/4] net/bnxt: fix scalar Tx completion handling

2021-06-16 Thread Lance Richardson
Preserve the raw (unmasked) transmit completion ring consumer index. Remove cache prefetches that have no measurable performance benefit. Fixes: c7de4195cc4c ("net/bnxt: modify ring index logic") Cc: sta...@dpdk.org Signed-off-by: Lance Richardson Reviewed-by: Ajit Khaparde --- drivers/net/bnx

[dpdk-dev] [PATCH 2/4] net/bnxt: fix tx desc status implementation

2021-06-16 Thread Lance Richardson
With tx completion batching, a single transmit completion can correspond to one or more transmit descriptors, adjust implementation to account for this. RTE_ETH_TX_DESC_DONE should be returned for descriptors that are available for use instead of RTE_ETH_TX_DESC_UNAVAIL. Fixes: 5735eb241947 ("net

[dpdk-dev] [PATCH 1/4] net/bnxt: fix ring and context memory allocation

2021-06-16 Thread Lance Richardson
Use requested socket ID when allocating memory for transmit rings, receive rings, and completion queues. Use device NUMA ID when allocating context memory, notification queue rings, async completion queue rings, and VNIC attributes. Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code") Fixes: 9738

Re: [dpdk-dev] [EXT] [PATCH v4 0/8] baseband: add NXP LA12xx driver

2021-06-16 Thread Akhil Goyal
> > Subject: [EXT] [PATCH v4 0/8] baseband: add NXP LA12xx driver > > > > This series introduces the BBDEV LA12xx poll mode driver (PMD) to support > > an implementation for offloading High Phy processing functions like > > LDPC Encode / Decode 5GNR wireless acceleration function, using PCI > based

Re: [dpdk-dev] [PATCH v1] net/i40e: remove the SMP barrier in HW scanning func

2021-06-16 Thread Honnappa Nagarahalli
> > > > > > > > > > > > > > > > > > > Add the logic to determine how many DD bits have been set > > > > > > > for contiguous packets, for removing the SMP barrier while reading > descs. > > > > > > > > > > > > I didn't understand this. > > > > > > The current logic already guarantee the read out

[dpdk-dev] FreeBSD 13 Memory / Contigmem Issues With Booting

2021-06-16 Thread Brandon Lo
Hi everyone, I have been trying to expand the UNH IOL unit testing coverage over to FreeBSD 13. Following this documentation: https://doc.dpdk.org/guides/freebsd_gsg/build_dpdk.html#loading-the-dpdk-contigmem-module I compiled the contigmem kernel module from the latest DPDK v21.05 and set the va

Re: [dpdk-dev] [PATCH 3/3] app/test: adding cnxk asymmetric autotest

2021-06-16 Thread Akhil Goyal
> Subject: [PATCH 3/3] app/test: adding cnxk asymmetric autotest > Title should be test/crypto: add cnxk for asymmetric cases > From: Kiran Kumar K > > Adding autotest for cn9k and cn10k. > > Signed-off-by: Kiran Kumar K

Re: [dpdk-dev] [PATCH 1/3] crypto/cnxk: add asymmetric session ops

2021-06-16 Thread Akhil Goyal
> From: Kiran Kumar K > > Adding asymmetric crypto session ops. > > Signed-off-by: Kiran Kumar K > --- > drivers/crypto/cnxk/cn10k_cryptodev.c | 2 + > drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 6 +- > drivers/crypto/cnxk/cn9k_cryptodev.c | 4 +- > drivers/crypto/cnxk/cn9k_cry

Re: [dpdk-dev] [PATCH 0/4] Add rte_security in crypto_cn10k PMD

2021-06-16 Thread Akhil Goyal
> Add rte_security (lookaside protocol - IPsec) support in crypto_cn10k. > > IPsec operations can be offloaded to CPT's SE and IE engines, which > can process IPsec protcol operations including atomic sequence number > increment (for outbound operations) and anti replay window check (for > inbound

Re: [dpdk-dev] [PATCH 1/4] crypto/cnxk: add security ctx skeleton

2021-06-16 Thread Akhil Goyal
> From: Srujana Challa > > Add security ctx in cn10k crypto PMD. > > Signed-off-by: Anoob Joseph > Signed-off-by: Srujana Challa > Signed-off-by: Tejasree Kondoj > --- > drivers/crypto/cnxk/cn10k_cryptodev.c| 10 +++ > drivers/crypto/cnxk/cnxk_cryptodev_sec.c | 47 > +

Re: [dpdk-dev] [PATCH 3/4] crypto/cnxk: add security session ops

2021-06-16 Thread Akhil Goyal
> diff --git a/drivers/crypto/cnxk/meson.build > b/drivers/crypto/cnxk/meson.build > index ab45483..eea08fa 100644 > --- a/drivers/crypto/cnxk/meson.build > +++ b/drivers/crypto/cnxk/meson.build > @@ -13,6 +13,7 @@ sources = files( > 'cn9k_cryptodev_ops.c', > 'cn10k_cryptodev.c',

Re: [dpdk-dev] [PATCH 01/20] crypto/cnxk: add driver skeleton

2021-06-16 Thread Akhil Goyal
> From: Ankur Dwivedi > > Add driver skeleton for crypto_cn9k & crypto_cn10k PMDs leveraging cnxk > common framework. > > Signed-off-by: Ankur Dwivedi > Signed-off-by: Anoob Joseph > Signed-off-by: Archana Muniganti > Signed-off-by: Tejasree Kondoj > --- > MAINTAINERS

[dpdk-dev] [PATCH] lib/flow_classify: fix leaking rules on delete

2021-06-16 Thread ohilyard
From: Owen Hilyard Rules in a classify table were not freed if the table had a delete function. Fixes: be41ac2a3 ("flow_classify: introduce flow classify library") Signed-off-by: Owen Hilyard --- lib/flow_classify/rte_flow_classify.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [dpdk-dev] [PATCH 00/20] Add Marvell CNXK crypto PMDs

2021-06-16 Thread Akhil Goyal
> > Add cnxk crypto PMDs supporting Marvell CN106XX SoC, based on > 'common/cnxk'. > > This series utilizes 'common/cnxk' to register cn9k & cn10k crypto PMDs and > add symmetric cryptographic features for the same. > > Depends-on: series-17212 ("Add CPT in Marvell CNXK common driver") > Releas

Re: [dpdk-dev] [PATCH 17/20] crypto/cnxk: add KASUMI encrypt

2021-06-16 Thread Akhil Goyal
> diff --git a/doc/guides/cryptodevs/features/cn10k.ini > b/doc/guides/cryptodevs/features/cn10k.ini > index 8f20d07..23ec100 100644 > --- a/doc/guides/cryptodevs/features/cn10k.ini > +++ b/doc/guides/cryptodevs/features/cn10k.ini > @@ -30,6 +30,7 @@ AES CTR (256) = Y > AES XTS (128) = Y > AES

Re: [dpdk-dev] [PATCH 15/20] crypto/cnxk: add ZUC and SNOW3G encrypt

2021-06-16 Thread Akhil Goyal
> diff --git a/doc/guides/cryptodevs/features/cn10k.ini > b/doc/guides/cryptodevs/features/cn10k.ini > index f097d8e..8f20d07 100644 > --- a/doc/guides/cryptodevs/features/cn10k.ini > +++ b/doc/guides/cryptodevs/features/cn10k.ini > @@ -30,6 +30,8 @@ AES CTR (256) = Y > AES XTS (128) = Y > AES

Re: [dpdk-dev] [PATCH 13/20] crypto/cnxk: add flexi crypto cipher encrypt

2021-06-16 Thread Akhil Goyal
> > diff --git a/doc/guides/cryptodevs/features/cn10k.ini > b/doc/guides/cryptodevs/features/cn10k.ini > index 175fbf7..f097d8e 100644 > --- a/doc/guides/cryptodevs/features/cn10k.ini > +++ b/doc/guides/cryptodevs/features/cn10k.ini > @@ -7,6 +7,10 @@ > Symmetric crypto = Y > Sym operation

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-16 Thread Bruce Richardson
On Wed, Jun 16, 2021 at 11:38:08PM +0530, Jerin Jacob wrote: > On Wed, Jun 16, 2021 at 11:01 PM Bruce Richardson > wrote: > > > > On Wed, Jun 16, 2021 at 05:41:45PM +0800, fengchengwen wrote: > > > On 2021/6/16 0:38, Bruce Richardson wrote: > > > > On Tue, Jun 15, 2021 at 09:22:07PM +0800, Chengwe

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-16 Thread Bruce Richardson
On Wed, Jun 16, 2021 at 04:48:59PM +, Honnappa Nagarahalli wrote: > > > > > > On Wed, Jun 16, 2021 at 02:14:54PM +0200, David Marchand wrote: > > > On Tue, Jun 15, 2021 at 3:25 PM Chengwen Feng > > wrote: > > > > + > > > > +#define RTE_DMADEV_NAME_MAX_LEN(64) > > > > +/**< @internal

[dpdk-dev] [PATCH] net/mlx5: do not allow copy to mark via modify field

2021-06-16 Thread Alexander Kozyrev
Mark requires a tag resource to be registered as part of the value assigning. It is not possible during a copy operation from a packet field. Forbid this in MODIFY_FIELD. Signed-off-by: Alexander Kozyrev --- drivers/net/mlx5/mlx5_flow_dv.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(

[dpdk-dev] [PATCH v2] lib/rte_rib6: fix stack buffer overflow

2021-06-16 Thread ohilyard
From: Owen Hilyard ASAN found a stack buffer overflow in lib/rib/rte_rib6.c:get_dir. The fix for the stack buffer overflow was to make sure depth was always < 128, since when depth = 128 it caused the index into the ip address to be 16, which read off the end of the array. While trying to solve

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-16 Thread Jerin Jacob
On Wed, Jun 16, 2021 at 11:01 PM Bruce Richardson wrote: > > On Wed, Jun 16, 2021 at 05:41:45PM +0800, fengchengwen wrote: > > On 2021/6/16 0:38, Bruce Richardson wrote: > > > On Tue, Jun 15, 2021 at 09:22:07PM +0800, Chengwen Feng wrote: > > >> This patch introduces 'dmadevice' which is a generic

[dpdk-dev] [PATCH] tests/cmdline: fix memory leaks

2021-06-16 Thread ohilyard
From: Owen Hilyard Fixes for a few memory leaks in the cmdline_autotest unit test. All of the leaks were related to not freeing the commandline struct after testing had completed. Fixes: dbb860e03e ("cmdline: tests") Signed-off-by: Owen Hilyard Reviewed-by: David Marchand --- app/test/test_

Re: [dpdk-dev] Memory leak in rte_pci_scan

2021-06-16 Thread David Marchand
On Wed, Jun 16, 2021 at 6:27 PM Owen Hilyard wrote: >> - For the fast-tests testsuite, the default timeout should be 10s, not 600s. >> See timeout_seconds_fast, >> https://git.dpdk.org/dpdk/tree/app/test/meson.build#n446 >> Odd that a 600s timeout has been applied to fast-tests in your run. >> How

Re: [dpdk-dev] [PATCH] parray: introduce internal API for dynamic arrays

2021-06-16 Thread Bruce Richardson
On Wed, Jun 16, 2021 at 05:01:46PM +0200, Morten Brørup wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > > Sent: Wednesday, 16 June 2021 15.03 > > > > On Wed, Jun 16, 2021 at 01:27:17PM +0200, Morten Brørup wrote: > > > > From: Jerin Jacob [mailto:jerinjac...@gmai

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-16 Thread Bruce Richardson
On Wed, Jun 16, 2021 at 05:41:45PM +0800, fengchengwen wrote: > On 2021/6/16 0:38, Bruce Richardson wrote: > > On Tue, Jun 15, 2021 at 09:22:07PM +0800, Chengwen Feng wrote: > >> This patch introduces 'dmadevice' which is a generic type of DMA > >> device. > >> > >> The APIs of dmadev library expos

Re: [dpdk-dev] [PATCH] lib/rte_rib6: fix stack buffer overflow

2021-06-16 Thread Medvedkin, Vladimir
Hi Owen, Thanks for the fix. I like your solution with removing the loop. However, while this fixes the buffer overflow, IMO it is not complete, because get_dir() shouldn't be called in cases where depth = 128. In this case checking the MSB of the ip is not quite right thing. The only place w

[dpdk-dev] [Bug 740] event/cnxk/cnxk_tim_worker build failures on Ubuntu 20.04 cross-compile with clang 10

2021-06-16 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=740 Bug ID: 740 Summary: event/cnxk/cnxk_tim_worker build failures on Ubuntu 20.04 cross-compile with clang 10 Product: DPDK Version: unspecified Hardware: All OS: All

Re: [dpdk-dev] [PATCH v1] net/i40e: fix flow director does not work

2021-06-16 Thread Thomas Monjalon
01/06/2021 13:12, Zhang, Qi Z: > > > When user configured the flow rule with raw packet via command > > > "flow_director_filter", it would reset all previous fdir input set > > > flags with "i40e_flow_set_fdir_inset()". > > > > > > Ignore to configure the flow input set with raw packet rule used. >

[dpdk-dev] [Bug 739] Building DPDK with gcc 10.2.1 Generates Multiple Warning Messages

2021-06-16 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=739 Bug ID: 739 Summary: Building DPDK with gcc 10.2.1 Generates Multiple Warning Messages Product: DPDK Version: unspecified Hardware: POWER OS: Linux Statu

Re: [dpdk-dev] [PATCH] lib/rte_rib6: fix stack buffer overflow

2021-06-16 Thread Stephen Hemminger
On Wed, 16 Jun 2021 12:07:29 -0400 ohily...@iol.unh.edu wrote: > From: Owen Hilyard > > ASAN found a stack buffer overflow in lib/rib/rte_rib6.c:get_dir. > The fix for the stack buffer overflow was to make sure depth > was always < 128, since when depth = 128 it caused the index > into the ip ad

Re: [dpdk-dev] [PATCH] tests/test_eal_flags: fix memory leak

2021-06-16 Thread David Marchand
On Wed, Jun 16, 2021 at 6:37 PM David Marchand wrote: > > On Wed, Jun 16, 2021 at 6:26 PM wrote: > > > > From: Owen Hilyard > > > > The directory steam was not closed when the hugepage action was > > HUGEPAGE_CHECK_EXISTS. This caused a memory leak in some parts of > > the unit tests. Just forg

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-16 Thread Honnappa Nagarahalli
> > On Wed, Jun 16, 2021 at 02:14:54PM +0200, David Marchand wrote: > > On Tue, Jun 15, 2021 at 3:25 PM Chengwen Feng > wrote: > > > + > > > +#define RTE_DMADEV_NAME_MAX_LEN(64) > > > +/**< @internal Max length of name of DMA PMD */ > > > + > > > +/** @internal > > > + * The data struct

Re: [dpdk-dev] [PATCH] tests/cmdline: fix memory leaks

2021-06-16 Thread David Marchand
On Wed, Jun 16, 2021 at 6:26 PM wrote: > > From: Owen Hilyard > > Fixes for a few memory leaks in the cmdline_autotest unit test. > > All of the leaks were related to not freeing the commandline struct > after testing had completed. We will need a Fixes: tag and Cc: stable. > > Signed-off-by:

Re: [dpdk-dev] [dpdk-stable] [PATCH] rte_ring: fix racy dequeue/enqueue in ppc64

2021-06-16 Thread Honnappa Nagarahalli
> > Hi, everyone > > This patch can be closed with the following reasons. > > > -邮件原件- > > 发件人: dev 代表 Honnappa Nagarahalli > > 发送时间: 2021年3月28日 9:00 > > 收件人: tho...@monjalon.net; Takeshi Yoshimura > > > > 抄送: sta...@dpdk.org; dev@dpdk.org; olivier.m...@6wind.com; > > chao...@linux.v

Re: [dpdk-dev] [PATCH] tests/test_eal_flags: fix memory leak

2021-06-16 Thread David Marchand
On Wed, Jun 16, 2021 at 6:26 PM wrote: > > From: Owen Hilyard > > The directory steam was not closed when the hugepage action was > HUGEPAGE_CHECK_EXISTS. This caused a memory leak in some parts of > the unit tests. > > Signed-off-by: Owen Hilyard Reviewed-by: David Marchand -- David Marcha

[dpdk-dev] [PATCH] tests/cmdline: fix memory leaks

2021-06-16 Thread ohilyard
From: Owen Hilyard Fixes for a few memory leaks in the cmdline_autotest unit test. All of the leaks were related to not freeing the commandline struct after testing had completed. Signed-off-by: Owen Hilyard --- app/test/test_cmdline_lib.c | 32 1 file changed

[dpdk-dev] [PATCH] tests/test_eal_flags: fix memory leak

2021-06-16 Thread ohilyard
From: Owen Hilyard The directory steam was not closed when the hugepage action was HUGEPAGE_CHECK_EXISTS. This caused a memory leak in some parts of the unit tests. Signed-off-by: Owen Hilyard --- app/test/test_eal_flags.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test/test_eal_f

[dpdk-dev] [PATCH] lib/rte_rib6: fix stack buffer overflow

2021-06-16 Thread ohilyard
From: Owen Hilyard ASAN found a stack buffer overflow in lib/rib/rte_rib6.c:get_dir. The fix for the stack buffer overflow was to make sure depth was always < 128, since when depth = 128 it caused the index into the ip address to be 16, which read off the end of the array. While trying to solve

Re: [dpdk-dev] [PATCH v3] ethdev: add IPv4 and L4 checksum RSS offload types

2021-06-16 Thread Zhang, Qi Z
> -Original Message- > From: Jerin Jacob > Sent: Tuesday, June 15, 2021 4:26 PM > To: Zhang, AlvinX > Cc: Zhang, Qi Z ; Andrew Rybchenko > ; Ajit Khaparde > ; dpdk-dev > Subject: Re: [dpdk-dev] [PATCH v3] ethdev: add IPv4 and L4 checksum RSS > offload types > > On Tue, Jun 15, 2021 at

Re: [dpdk-dev] [PATCH] parray: introduce internal API for dynamic arrays

2021-06-16 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Wednesday, 16 June 2021 15.03 > > On Wed, Jun 16, 2021 at 01:27:17PM +0200, Morten Brørup wrote: > > > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > > > Sent: Wednesday, 16 June 2021 11.42 > > > > > > On Tue, Jun

Re: [dpdk-dev] [PATCH v2 4/6] vhost: improve NUMA reallocation

2021-06-16 Thread Maxime Coquelin
On 6/15/21 10:42 AM, Maxime Coquelin wrote: > This patch improves the numa_realloc() function by making use > of rte_realloc_socket(), which takes care of the memory copy > and freeing of the old data. > > Suggested-by: David Marchand > Signed-off-by: Maxime Coquelin > --- > lib/vhost/vhost_

[dpdk-dev] [PATCH] net/mlx5: convert meta register to big-endian

2021-06-16 Thread Alexander Kozyrev
Metadata is stored in the CPU order (little-endian format on x86), while all the packet header fields are stored in the network order. That leads to the wrong results whenever we try to use the metadata value in the modify_field actions: bytes are swapped as a result. Convert the metadata into the

[dpdk-dev] [PATCH] net/mlx5: fix modify field action order for MAC

2021-06-16 Thread Alexander Kozyrev
MAC addresses are split into 2 parts inside Mellanox NIC: bits 0-15 are separate from bits 16-47. That makes a copy from another packet field tricky because any other field is aligned to 32 bits, not 16. This causes unexpected results when using the MODIFY_FIELD action with MAC addresses. Track cro

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-16 Thread Jerin Jacob
On Wed, Jun 16, 2021 at 3:47 PM fengchengwen wrote: > > On 2021/6/16 15:09, Morten Brørup wrote: > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > >> Sent: Tuesday, 15 June 2021 18.39 > >> > >> On Tue, Jun 15, 2021 at 09:22:07PM +0800, Chengwen Feng wrote: > >>> This pat

Re: [dpdk-dev] [PATCH v4] vhost: check header for legacy dequeue offload

2021-06-16 Thread Wang, Xiao W
Hi David, Thanks for your comments. I agree with your suggestions. BTW, I notice some other invalid corner cases which need rolling back mbuf->l2_len, l3_len and ol_flag. E.g. the default case in the "switch {}" context is not valid. BTW, l4_proto variable is better to be a uint8_t, rather than u

Re: [dpdk-dev] [PATCH v1] net/i40e: remove the SMP barrier in HW scanning func

2021-06-16 Thread Bruce Richardson
On Wed, Jun 16, 2021 at 01:29:24PM +, Zhang, Qi Z wrote: > Hi > > > -Original Message- > > From: Honnappa Nagarahalli > > Sent: Tuesday, June 8, 2021 5:36 AM > > To: Zhang, Qi Z ; Joyce Kong ; > > Xing, Beilei ; Ruifeng Wang > > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli > > ; nd >

Re: [dpdk-dev] [PATCH v1] net/ice/base: fix wrong ptype bitmap for IP fragment

2021-06-16 Thread Zhang, Qi Z
> -Original Message- > From: Xu, Ting > Sent: Thursday, June 10, 2021 10:45 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Xu, Ting ; > sta...@dpdk.org > Subject: [PATCH v1] net/ice/base: fix wrong ptype bitmap for IP fragment > > IPv4 and IPv6 fragment ptypes are supposed to be separated f

Re: [dpdk-dev] [PATCH v1] net/i40e: remove the SMP barrier in HW scanning func

2021-06-16 Thread Zhang, Qi Z
Hi > -Original Message- > From: Honnappa Nagarahalli > Sent: Tuesday, June 8, 2021 5:36 AM > To: Zhang, Qi Z ; Joyce Kong ; > Xing, Beilei ; Ruifeng Wang > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli > ; nd > Subject: RE: [PATCH v1] net/i40e: remove the SMP barrier in HW scanning > func

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-16 Thread Bruce Richardson
On Wed, Jun 16, 2021 at 02:14:54PM +0200, David Marchand wrote: > On Tue, Jun 15, 2021 at 3:25 PM Chengwen Feng wrote: > > + > > +#define RTE_DMADEV_NAME_MAX_LEN(64) > > +/**< @internal Max length of name of DMA PMD */ > > + > > +/** @internal > > + * The data structure associated with eac

Re: [dpdk-dev] [PATCH v1] net/mlx5: fix IPIP multi tunnel validation

2021-06-16 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Lior Margalit > Sent: Wednesday, June 16, 2021 10:01 AM > To: dev@dpdk.org; Slava Ovsiienko ; Matan Azrad > > Cc: Ori Kam ; Lior Margalit ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v1] net/mlx5: fix IPIP multi tunnel validation > >

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-16 Thread Bruce Richardson
On Wed, Jun 16, 2021 at 06:17:07PM +0800, fengchengwen wrote: > On 2021/6/16 15:09, Morten Brørup wrote: > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > >> Sent: Tuesday, 15 June 2021 18.39 > >> > >> On Tue, Jun 15, 2021 at 09:22:07PM +0800, Chengwen Feng wrote: > >>> T

Re: [dpdk-dev] [PATCH] parray: introduce internal API for dynamic arrays

2021-06-16 Thread Bruce Richardson
On Wed, Jun 16, 2021 at 01:27:17PM +0200, Morten Brørup wrote: > > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > > Sent: Wednesday, 16 June 2021 11.42 > > > > On Tue, Jun 15, 2021 at 12:18 PM Thomas Monjalon > > wrote: > > > > > > 14/06/2021 17:48, Morten Brørup: > > > > > From: dev [mailto:

Re: [dpdk-dev] [PATCH] ixgbe: Add runtime tx/rx queue setup for X550

2021-06-16 Thread Zhang, Qi Z
Comments inline. From: Wu, Jianyue (NSB - CN/Hangzhou) Sent: Wednesday, June 16, 2021 1:04 PM To: Zhang, Qi Z Cc: dev@dpdk.org Subject: RE: [dpdk-dev] [PATCH] ixgbe: Add runtime tx/rx queue setup for X550 Hi, Qi, OK, thanks indeed for the explanation, appreciated😊 BTW, I see patch is Supersede

Re: [dpdk-dev] [PATCH] parray: introduce internal API for dynamic arrays

2021-06-16 Thread Jerin Jacob
On Wed, Jun 16, 2021 at 5:52 PM Burakov, Anatoly wrote: > > On 16-Jun-21 10:42 AM, Jerin Jacob wrote: > > On Tue, Jun 15, 2021 at 12:18 PM Thomas Monjalon > > wrote: > >> > >> 14/06/2021 17:48, Morten Brørup: > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > >>> It wo

Re: [dpdk-dev] [PATCH 3/3] net/virtio: add MAC device config getter and setter

2021-06-16 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, June 8, 2021 10:14 PM > To: dev@dpdk.org; Xia, Chenbo ; amore...@redhat.com; > david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 3/3] net/virtio: add MAC device config getter and setter > > This pat

Re: [dpdk-dev] [PATCH 2/3] net/virtio: add device config support to vDPA

2021-06-16 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, June 8, 2021 10:14 PM > To: dev@dpdk.org; Xia, Chenbo ; amore...@redhat.com; > david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 2/3] net/virtio: add device config support to vDPA > > This patch int

Re: [dpdk-dev] [PATCH 1/3] net/virtio: keep device and frontend features separated

2021-06-16 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, June 8, 2021 10:14 PM > To: dev@dpdk.org; Xia, Chenbo ; amore...@redhat.com; > david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 1/3] net/virtio: keep device and frontend features separated > > This patch is pr

Re: [dpdk-dev] [PATCH] parray: introduce internal API for dynamic arrays

2021-06-16 Thread Burakov, Anatoly
On 16-Jun-21 10:42 AM, Jerin Jacob wrote: On Tue, Jun 15, 2021 at 12:18 PM Thomas Monjalon wrote: 14/06/2021 17:48, Morten Brørup: From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon It would be much simpler to just increase RTE_MAX_ETHPORTS to something big enough to hold

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-16 Thread David Marchand
On Tue, Jun 15, 2021 at 3:25 PM Chengwen Feng wrote: > + > +#define RTE_DMADEV_NAME_MAX_LEN(64) > +/**< @internal Max length of name of DMA PMD */ > + > +/** @internal > + * The data structure associated with each DMA device. > + */ > +struct rte_dmadev { > + /**< Device ID for this

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-16 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of fengchengwen > Sent: Wednesday, 16 June 2021 12.17 > > On 2021/6/16 15:09, Morten Brørup wrote: > > I would like to share a couple of ideas for further discussion: > > > > 1. API for bulk operations. > > The ability to prepare a vector of DMA

Re: [dpdk-dev] [PATCH] parray: introduce internal API for dynamic arrays

2021-06-16 Thread Jerin Jacob
On Wed, Jun 16, 2021 at 4:57 PM Morten Brørup wrote: > > > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > > Sent: Wednesday, 16 June 2021 11.42 > > > > On Tue, Jun 15, 2021 at 12:18 PM Thomas Monjalon > > wrote: > > > > > > 14/06/2021 17:48, Morten Brørup: > > > > > From: dev [mailto:dev-bou

Re: [dpdk-dev] [RFC v2] porting AddressSanitizer feature to DPDK

2021-06-16 Thread Jerin Jacob
On Wed, Jun 16, 2021 at 2:43 PM Lin, Xueqin wrote: > > > -Original Message- > > From: Jerin Jacob > > Sent: Tuesday, June 15, 2021 4:40 PM > > To: Peng, ZhihongX > > Cc: Burakov, Anatoly ; Ananyev, Konstantin > > ; Stephen Hemminger > > ; dpdk-dev ; Lin, Xueqin > > > > Subject: Re: [dpd

Re: [dpdk-dev] [PATCH] parray: introduce internal API for dynamic arrays

2021-06-16 Thread Morten Brørup
> From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Wednesday, 16 June 2021 11.42 > > On Tue, Jun 15, 2021 at 12:18 PM Thomas Monjalon > wrote: > > > > 14/06/2021 17:48, Morten Brørup: > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas > Monjalon > > > It would be much sim

Re: [dpdk-dev] [PATCH] parray: introduce internal API for dynamic arrays

2021-06-16 Thread Burakov, Anatoly
On 14-Jun-21 11:58 AM, Thomas Monjalon wrote: Performance of access in a fixed-size array is very good because of cache locality and because there is a single pointer to dereference. The only drawback is the lack of flexibility: the size of such an array cannot be increase at runtime. An approac

Re: [dpdk-dev] [PATCH 05/20] crypto/cnxk: add queue pair ops

2021-06-16 Thread Akhil Goyal
> diff --git a/drivers/crypto/cnxk/cnxk_cpt_ops_helper.c > b/drivers/crypto/cnxk/cnxk_cpt_ops_helper.c > new file mode 100644 > index 000..103195e > --- /dev/null > +++ b/drivers/crypto/cnxk/cnxk_cpt_ops_helper.c > @@ -0,0 +1,28 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(C)

Re: [dpdk-dev] [PATCH 02/20] crypto/cnxk: add probe and remove

2021-06-16 Thread Akhil Goyal
> +/* > + * DP logs, toggled out at compile time if level lower than current level. > + * DP logs would be logged under 'PMD' type. So for dynamic logging, the > + * level of 'pmd' has to be used. > + */ > +#define CPT_LOG_DP(level, fmt, args...) RTE_LOG_DP(level, PMD, fmt "\n", > ##args) > + > +#d

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-16 Thread fengchengwen
On 2021/6/16 15:09, Morten Brørup wrote: >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson >> Sent: Tuesday, 15 June 2021 18.39 >> >> On Tue, Jun 15, 2021 at 09:22:07PM +0800, Chengwen Feng wrote: >>> This patch introduces 'dmadevice' which is a generic type of DMA >>> device

[dpdk-dev] [PATCH v2] bus: clarify log for non-NUMA-aware devices

2021-06-16 Thread Dmitry Kozlyuk
PCI and vmbus drivers printed a warning when NUMA node had beed reported as (-1) or not reported by OS: EAL: Invalid NUMA socket, default to 0 This message and its level might confuse users, because configuration is valid and nothing happens that requires attention or intervention. Reduce

Re: [dpdk-dev] [PATCH 04/20] crypto/cnxk: add symmetric crypto capabilities

2021-06-16 Thread Akhil Goyal
> Subject: [PATCH 04/20] crypto/cnxk: add symmetric crypto capabilities > > From: Ankur Dwivedi > > Add symmetric crypto capabilities for cn9k & cn10k. > Capability patch can also be added in the end along with documentation update in the .ini files after the data path is added. > +++ b/driv

Re: [dpdk-dev] [PATCH] parray: introduce internal API for dynamic arrays

2021-06-16 Thread Jerin Jacob
On Tue, Jun 15, 2021 at 12:18 PM Thomas Monjalon wrote: > > 14/06/2021 17:48, Morten Brørup: > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > > It would be much simpler to just increase RTE_MAX_ETHPORTS to something big > > enough to hold a sufficiently large array. An

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-16 Thread fengchengwen
On 2021/6/16 0:38, Bruce Richardson wrote: > On Tue, Jun 15, 2021 at 09:22:07PM +0800, Chengwen Feng wrote: >> This patch introduces 'dmadevice' which is a generic type of DMA >> device. >> >> The APIs of dmadev library exposes some generic operations which can >> enable configuration and I/O with

Re: [dpdk-dev] Memory leak in rte_pci_scan

2021-06-16 Thread David Marchand
On Tue, Jun 15, 2021 at 5:16 PM Owen Hilyard wrote: > > The issue may have been the interactive docker session I was running it in. > The last few tests (150-157) were all taking until the timeout the lab uses > for unit tests (2 hours since the timeout was multiplied by 10). I had to > leave f

Re: [dpdk-dev] [RFC v2] porting AddressSanitizer feature to DPDK

2021-06-16 Thread Lin, Xueqin
> -Original Message- > From: Jerin Jacob > Sent: Tuesday, June 15, 2021 4:40 PM > To: Peng, ZhihongX > Cc: Burakov, Anatoly ; Ananyev, Konstantin > ; Stephen Hemminger > ; dpdk-dev ; Lin, Xueqin > > Subject: Re: [dpdk-dev] [RFC v2] porting AddressSanitizer feature to DPDK > > On Tue, Ju

Re: [dpdk-dev] [PATCH v1] net/mlx5: fix IPIP multi tunnel validation

2021-06-16 Thread Matan Azrad
From: Lior Margalit > A flow rule must not include multiple tunnel layers. > An attempt to create such a rule, for example: > testpmd> flow create .../ vxlan / eth / ipv4 proto is 4 / end > results in an unclear error. > > In the current implementation there is a check for multiple IPIP tunnel

Re: [dpdk-dev] [dpdk-stable] [PATCH] ipc: stop mp control thread on cleanup

2021-06-16 Thread David Marchand
On Mon, Jun 14, 2021 at 11:13 AM David Marchand wrote: > > When calling rte_eal_cleanup, the mp channel cleanup routine only sets > mp_fd to -1 leaving the rte_mp_handle control thread running. > This control thread can spew warnings on reading on an invalid fd. > > To handle this situation, sets

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-16 Thread Wang, Haiyue
> -Original Message- > From: Richardson, Bruce > Sent: Wednesday, June 16, 2021 16:05 > To: Wang, Haiyue > Cc: Chengwen Feng ; tho...@monjalon.net; Yigit, > Ferruh > ; dev@dpdk.org; nipun.gu...@nxp.com; > hemant.agra...@nxp.com; > maxime.coque...@redhat.com; honnappa.nagaraha...@arm.com

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-16 Thread Bruce Richardson
On Wed, Jun 16, 2021 at 03:17:51AM +0100, Wang, Haiyue wrote: > > -Original Message- > > From: dev On Behalf Of Chengwen Feng > > Sent: Tuesday, June 15, 2021 21:22 > > To: tho...@monjalon.net; Yigit, Ferruh > > Cc: dev@dpdk.org; nipun.gu...@nxp.com; hemant.agra...@nxp.com; > > maxime.co

Re: [dpdk-dev] [PATCH 01/20] crypto/cnxk: add driver skeleton

2021-06-16 Thread Akhil Goyal
> Hi Akhil, > > > > > > > +Marvell cnxk > > This should be Marvell cnxk crypto as we have net and event PMD with the > same > > name. > > [Anoob] Mempool & event already follows this convention for Marvell cnxk. > Net driver (which is in pipeline) is also adding the same. Marvell OCTEON TX2 > all

Re: [dpdk-dev] [PATCH 01/20] crypto/cnxk: add driver skeleton

2021-06-16 Thread Anoob Joseph
Hi Akhil, > > > > +Marvell cnxk > This should be Marvell cnxk crypto as we have net and event PMD with the same > name. [Anoob] Mempool & event already follows this convention for Marvell cnxk. Net driver (which is in pipeline) is also adding the same. Marvell OCTEON TX2 all drivers followed th

Re: [dpdk-dev] [PATCH 01/20] crypto/cnxk: add driver skeleton

2021-06-16 Thread Akhil Goyal
> > +Marvell cnxk This should be Marvell cnxk crypto as we have net and event PMD with the same name. > +M: Ankur Dwivedi > +M: Anoob Joseph > +M: Tejasree Kondoj > +F: drivers/crypto/cnxk/ > +F: doc/guides/cryptodevs/cnxk.rst > +F: doc/guides/cryptodevs/features/cn9k.ini > +F: doc/guides/cr

Re: [dpdk-dev] [PATCH 00/20] Add Marvell CNXK crypto PMDs

2021-06-16 Thread Akhil Goyal
> Subject: [PATCH 00/20] Add Marvell CNXK crypto PMDs > > Add cnxk crypto PMDs supporting Marvell CN106XX SoC, based on > 'common/cnxk'. > > This series utilizes 'common/cnxk' to register cn9k & cn10k crypto PMDs and > add symmetric cryptographic features for the same. > > Depends-on: series-172

[dpdk-dev] 回复: [dpdk-stable] [PATCH] rte_ring: fix racy dequeue/enqueue in ppc64

2021-06-16 Thread Feifei Wang
Hi, everyone This patch can be closed with the following reasons. > -邮件原件- > 发件人: dev 代表 Honnappa Nagarahalli > 发送时间: 2021年3月28日 9:00 > 收件人: tho...@monjalon.net; Takeshi Yoshimura > > 抄送: sta...@dpdk.org; dev@dpdk.org; olivier.m...@6wind.com; > chao...@linux.vnet.ibm.com; konstantin.ana

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

2021-06-16 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Tuesday, 15 June 2021 18.39 > > On Tue, Jun 15, 2021 at 09:22:07PM +0800, Chengwen Feng wrote: > > This patch introduces 'dmadevice' which is a generic type of DMA > > device. > > > > The APIs of dmadev library exposes

[dpdk-dev] [PATCH v1] net/mlx5: fix IPIP multi tunnel validation

2021-06-16 Thread Lior Margalit
A flow rule must not include multiple tunnel layers. An attempt to create such a rule, for example: testpmd> flow create .../ vxlan / eth / ipv4 proto is 4 / end results in an unclear error. In the current implementation there is a check for multiple IPIP tunnels, but not for combination of IPIP