Re: [dpdk-dev] [PATCH 3/4] drivers/net/enetfec: queue configuration

2021-07-03 Thread Sachin Saxena (OSS)
On 30-Apr-21 10:04 AM, Apeksha Gupta wrote: This patch added RX/TX queue configuration setup operations. added -> adds On packet Rx the respective BD Ring status bit is set which is then Suggestion:  Rx -> reception used for packet processing. Signed-off-by: Sachin Saxena Signed-off-by:

Re: [dpdk-dev] [PATCH 2/4] drivers/net/enetfec: UIO support added

2021-07-03 Thread Sachin Saxena (OSS)
On 30-Apr-21 10:04 AM, Apeksha Gupta wrote: Implemented the fec-uio driver in kernel. enetfec PMD uses UIO interface to interact with kernel for PHY initialisation enetfec PMD uses UIO interface to interact with "fec-uio" driver implemented in kernel for PHY initialization... and for mapp

Re: [dpdk-dev] [PATCH 1/4] drivers/net/enetfec: Introduce NXP ENETFEC driver

2021-07-03 Thread Sachin Saxena (OSS)
On 30-Apr-21 10:04 AM, Apeksha Gupta wrote: ENET fec (Fast Ethernet Controller) is a network poll mode driver for NXP SoC imx8mmevk. Either use imx8mmevk  or  "i.MX 8M Mini"at all places ENET fec-> enetfec,   please change it at all places. This patch add skeleton for enetfec driver with pr

Re: [dpdk-dev] [PATCH 0/4] drivers/net: add NXP ENETFEC driver

2021-07-03 Thread Sachin Saxena (OSS)
On 30-Apr-21 10:04 AM, Apeksha Gupta wrote: This patch series introduce the enetfec ethernet driver, enetfec ethernet driver -> enetfec driver ENET fec (Fast Ethernet Controller) is a network poll mode driver for ENET fec ->enetfec Also, please use "enetfec" consistently at all places. the

Re: [dpdk-dev] NUMA node/socket

2021-07-03 Thread Thomas Monjalon
04/07/2021 03:38, Thomas Monjalon: > There are some mix between NUMA node and socket IDs in DPDK. > Examples: > * rte_eth_dev_socket_id() returns the NUMA node. > * rte_malloc use sockets to allocate the memory > > Is it critical? There is a function, implemented for Windows only, whi

[dpdk-dev] NUMA node/socket

2021-07-03 Thread Thomas Monjalon
There are some mix between NUMA node and socket IDs in DPDK. Examples: * rte_eth_dev_socket_id() returns the NUMA node. * rte_malloc use sockets to allocate the memory Is it critical?

Re: [dpdk-dev] atomic operations

2021-07-03 Thread Thomas Monjalon
03/07/2021 19:30, Stephen Hemminger: > Thomas Monjalon wrote: > > It is very difficult to find which wrapper to use. > > > > This is the guide we have: > > https://doc.dpdk.org/guides/prog_guide/writing_efficient_code.html#locks-and-atomic-operations > > There are 2 blog posts: > > https://www.dp

Re: [dpdk-dev] atomic operations

2021-07-03 Thread Thomas Monjalon
03/07/2021 13:29, Thomas Monjalon: > In the deprecation notices of DPDK 21.05, we can still read this: > " > * rte_atomicNN_xxx: These APIs do not take memory order parameter. This does > not allow for writing optimized code for all the CPU architectures supported > in DPDK. DPDK will adopt C11

[dpdk-dev] [PATCH v7 7/7] event/cnxk: add Tx event vector fastpath

2021-07-03 Thread pbhagavatula
From: Pavan Nikhilesh Add Tx event vector fastpath, integrate event vector Tx routine into Tx burst. Signed-off-by: Pavan Nikhilesh --- doc/guides/eventdevs/cnxk.rst | 1 + doc/guides/rel_notes/release_21_08.rst | 2 +- drivers/common/cnxk/roc_sso.h | 23 ++ drivers/

[dpdk-dev] [PATCH v7 6/7] event/cnxk: add Rx event vector fastpath

2021-07-03 Thread pbhagavatula
From: Pavan Nikhilesh Add Rx event vector fastpath to convert HW defined metadata into rte_mbuf and rte_event_vector. Signed-off-by: Pavan Nikhilesh --- doc/guides/rel_notes/release_21_08.rst | 1 + drivers/event/cnxk/cn10k_worker.h | 56 +++ drivers/net/cnxk/cn10k_rx.h

[dpdk-dev] [PATCH v7 5/7] event/cnxk: add Rx adapter vector support

2021-07-03 Thread pbhagavatula
From: Pavan Nikhilesh Add event vector support for cnxk event Rx adapter, add control path APIs to get vector limits and ability to configure event vectorization on a given Rx queue. Signed-off-by: Pavan Nikhilesh --- doc/guides/eventdevs/cnxk.rst| 2 + drivers/event/cnxk/cn10k_e

[dpdk-dev] [PATCH v7 4/7] event/cnxk: add Tx adapter fastpath ops

2021-07-03 Thread pbhagavatula
From: Pavan Nikhilesh Add support for event eth Tx adapter fastpath operations. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 38 drivers/event/cnxk/cn10k_worker.h | 67 + drivers/event/cnxk/cn10k_worker_tx_enq.c | 23 +

[dpdk-dev] [PATCH v7 3/7] event/cnxk: add Tx adapter support

2021-07-03 Thread pbhagavatula
From: Pavan Nikhilesh Add support for event eth Tx adapter. Signed-off-by: Pavan Nikhilesh Acked-by: Nithin Dabilpuram --- doc/guides/eventdevs/cnxk.rst| 4 +- doc/guides/rel_notes/release_21_08.rst | 6 +- drivers/common/cnxk/roc_nix.h| 1 + drivers/common/cnx

[dpdk-dev] [PATCH v7 2/7] event/cnxk: add Rx adapter fastpath ops

2021-07-03 Thread pbhagavatula
From: Pavan Nikhilesh Add support for event eth Rx adapter fastpath operations. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 136 +++- drivers/event/cnxk/cn10k_worker.c | 54 drivers/event/cnxk/cn10k_worker.h | 97 +-

[dpdk-dev] [PATCH v7 1/7] event/cnxk: add Rx adapter support

2021-07-03 Thread pbhagavatula
From: Pavan Nikhilesh Add support for event eth Rx adapter. Resize cn10k workslot fastpath structure to fit in 64B cacheline size. Signed-off-by: Pavan Nikhilesh --- v7 Changes: - Set correct limits for SQB aura. v6 Changes: - More code cleanup. - Fix incorrect SQB configuration and missin

Re: [dpdk-dev] atomic operations

2021-07-03 Thread Stephen Hemminger
On Sat, 03 Jul 2021 13:29:38 +0200 Thomas Monjalon wrote: > In the deprecation notices of DPDK 21.05, we can still read this: > " > * rte_atomicNN_xxx: These APIs do not take memory order parameter. This does > not allow for writing optimized code for all the CPU architectures supported > in

Re: [dpdk-dev] [PATCH v6 3/7] event/cnxk: add Tx adapter support

2021-07-03 Thread Nithin Dabilpuram
On Sat, Jul 03, 2021 at 02:44:04AM +0530, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Add support for event eth Tx adapter. > > Signed-off-by: Pavan Nikhilesh > --- > doc/guides/eventdevs/cnxk.rst| 4 +- > doc/guides/rel_notes/release_21_08.rst | 6 +- > drive

Re: [dpdk-dev] dmadev discussion summary

2021-07-03 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob > Sent: Saturday, 3 July 2021 11.09 > > On Sat, Jul 3, 2021 at 2:23 PM Morten Brørup > wrote: > > > > > From: fengchengwen [mailto:fengcheng...@huawei.com] > > > Sent: Saturday, 3 July 2021 02.32 > > > > > > On 2021/7/2 22:57, Mor

Re: [dpdk-dev] dmadev discussion summary

2021-07-03 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of fengchengwen > Sent: Saturday, 3 July 2021 11.45 > > On 2021/7/3 16:53, Morten Brørup wrote: > >> From: fengchengwen [mailto:fengcheng...@huawei.com] > >> Sent: Saturday, 3 July 2021 02.32 > >> > >> On 2021/7/2 22:57, Morten Brørup wrote: > >>

[dpdk-dev] atomic operations

2021-07-03 Thread Thomas Monjalon
In the deprecation notices of DPDK 21.05, we can still read this: " * rte_atomicNN_xxx: These APIs do not take memory order parameter. This does not allow for writing optimized code for all the CPU architectures supported in DPDK. DPDK will adopt C11 atomic operations semantics and provide wrap

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-07-03 Thread Ananyev, Konstantin
> > 在 2021/7/2 21:23, Ananyev, Konstantin 写道: > > > >> On 7/2/2021 12:08 PM, Andrew Rybchenko wrote: > >>> @Thomas, @Ferruh, I tend to accept it (with minor style fixes), > >>> but I need your opinion on it before doing it. > >>> > >> I guess we were relying on the user/application to have correct

[dpdk-dev] [PATCH v2] net/bnxt: fix nested lock at bond mode

2021-07-03 Thread Weifeng Li
Bnxt register lsc callback (bond_ethdev_lsc_event_callback) when working at bond mode. This callback will dead lock when lsc interrupt triggered. lsc interrupt -> bnxt_handle_async_event -> bnxt_link_update_op -> bond_ethdev_lsc_event_callback (lsc_lock) -> bnxt_link_update_op -> bond_ethdev_lsc_e

[dpdk-dev] [PATCH] net/bnxt: fix nested lock at bond mode

2021-07-03 Thread Weifeng Li
Bnxt regist lsc callback (bond_ethdev_lsc_event_callback) when working at bond mode. This callback will dead lock when lsc interrupt triggerred. lsc interrupt -> bnxt_handle_async_event -> bnxt_link_update_op -> bond_ethdev_lsc_event_callback (lsc_lock) -> bnxt_link_update_op -> bond_ethdev_lsc_ev

Re: [dpdk-dev] dmadev discussion summary

2021-07-03 Thread fengchengwen
On 2021/7/3 16:53, Morten Brørup wrote: >> From: fengchengwen [mailto:fengcheng...@huawei.com] >> Sent: Saturday, 3 July 2021 02.32 >> >> On 2021/7/2 22:57, Morten Brørup wrote: In the DPDK framework, many data-plane API names contain queues. >> e.g. eventdev/crypto.. The concept of

Re: [dpdk-dev] dmadev discussion summary

2021-07-03 Thread Jerin Jacob
On Sat, Jul 3, 2021 at 2:23 PM Morten Brørup wrote: > > > From: fengchengwen [mailto:fengcheng...@huawei.com] > > Sent: Saturday, 3 July 2021 02.32 > > > > On 2021/7/2 22:57, Morten Brørup wrote: > > >> In the DPDK framework, many data-plane API names contain queues. > > e.g. > > >> eventdev/crypt

Re: [dpdk-dev] dmadev discussion summary

2021-07-03 Thread Morten Brørup
> From: fengchengwen [mailto:fengcheng...@huawei.com] > Sent: Saturday, 3 July 2021 02.32 > > On 2021/7/2 22:57, Morten Brørup wrote: > >> In the DPDK framework, many data-plane API names contain queues. > e.g. > >> eventdev/crypto.. > >> The concept of virt queues has continuity. > > > > I was al

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-07-03 Thread Huisong Li
在 2021/7/2 21:23, Ananyev, Konstantin 写道: On 7/2/2021 12:08 PM, Andrew Rybchenko wrote: @Thomas, @Ferruh, I tend to accept it (with minor style fixes), but I need your opinion on it before doing it. I guess we were relying on the user/application to have correct order up until now, it can