Re: [dpdk-dev] [PATCH] ethdev: keep count of allocated and used representor ranges

2021-07-04 Thread Viacheslav Galaktionov
Hello! On 2021-07-03 04:32, Xueming(Steven) Li wrote: + if (i == n_entries) + break; } out: + info->nb_ranges = i; Here info maybe NULL. Good catch, thanks for noticing! faf3bd901d..d2b27c351f 100644 --- a/lib/ethdev/rte_ethdev.h +++ b/lib

Re: [dpdk-dev] [PATCH v3 2/2] eal: handle compressed firmwares

2021-07-04 Thread David Marchand
On Mon, Jul 5, 2021 at 8:35 AM Wang, Haiyue wrote: > > +int > > +rte_firmware_read(const char *name, void **buf, size_t *bufsz) > > +{ > > + char path[PATH_MAX]; > > + int ret; > > + > > + ret = firmware_read(name, buf, bufsz); > > + if (ret < 0) { > > + snprintf(path,

Re: [dpdk-dev] [PATCH v7 2/2] bus/auxiliary: introduce auxiliary bus

2021-07-04 Thread Xueming(Steven) Li
Made changes and forgot to commit :( please ignore and refer to new v8. > -Original Message- > From: Xueming(Steven) Li > Sent: Monday, July 5, 2021 1:37 PM > Cc: dev@dpdk.org; Xueming(Steven) Li ; Wang Haiyue > ; NBU-Contact-Thomas > Monjalon ; Kinsella Ray ; Andrew > Rybchenko ; Para

[dpdk-dev] [PATCH v8 2/2] bus/auxiliary: introduce auxiliary bus

2021-07-04 Thread Xueming Li
Auxiliary bus [1] provides a way to split function into child-devices representing sub-domains of functionality. Each auxiliary device represents a part of its parent functionality. Auxiliary device is identified by unique device name, sysfs path: /sys/bus/auxiliary/devices/ Devargs legacy synt

[dpdk-dev] [PATCH v8 1/2] devargs: add common key definition

2021-07-04 Thread Xueming Li
Adds common devargs key definition for "bus", "class" and "driver". Acked-by: Thomas Monjalon Signed-off-by: Xueming Li --- drivers/common/mlx5/mlx5_common.h | 2 -- drivers/common/mlx5/mlx5_common_pci.c | 2 +- drivers/common/sfc_efx/sfc_efx.c| 7 +++ drivers/common/sfc_

Re: [dpdk-dev] [PATCH v3 2/2] eal: handle compressed firmwares

2021-07-04 Thread Wang, Haiyue
> -Original Message- > From: dev On Behalf Of David Marchand > Sent: Tuesday, June 29, 2021 16:07 > To: dev@dpdk.org > Cc: Igor Russkikh ; Aaron Conole ; > Michael Santana > ; Richardson, Bruce ; > Rasesh Mody > ; Shahed Shaikh ; Yang, Qiming > ; Zhang, > Qi Z ; Heinrich Kuhn ; > Deven

Re: [dpdk-dev] 19.11.9 patches review and test

2021-07-04 Thread Ali Alnubani
Hi Christian, Sorry for the delay. > -Original Message- > From: Christian Ehrhardt > Sent: Friday, July 2, 2021 10:42 AM > To: Ali Alnubani > Cc: sta...@dpdk.org; dev@dpdk.org; Abhishek Marathe > ; Akhil Goyal ; > benjamin.wal...@intel.com; David Christensen ; > hariprasad.govindhara...@

Re: [dpdk-dev] [PATCH] test: fix crypto_op length for sessionless case

2021-07-04 Thread Gujjar, Abhinandan S
Hi Jerin/Akhil, Could you please review the patch? Regards Abhinandan > -Original Message- > From: Yigit, Ferruh > Sent: Saturday, July 3, 2021 4:56 AM > To: Gujjar, Abhinandan S ; dev@dpdk.org; > jer...@marvell.com; dpdk...@iol.unh.edu; acon...@redhat.com > Cc: gak...@marvell.com; Powe

[dpdk-dev] [PATCH v5 4/4] examples/vhost: support vhost async dequeue data path

2021-07-04 Thread Wenwu Ma
This patch is to add vhost async dequeue data-path in vhost sample. vswitch can leverage IOAT to accelerate vhost async dequeue data-path. Signed-off-by: Wenwu Ma --- doc/guides/sample_app_ug/vhost.rst | 9 +- examples/vhost/ioat.c | 61 ++--- examples/vhost/ioat.h

[dpdk-dev] [PATCH v5 3/4] vhost: support async dequeue for split ring

2021-07-04 Thread Wenwu Ma
From: Yuan Wang This patch implements asynchronous dequeue data path for split ring. A new asynchronous dequeue function is introduced. With this function, the application can try to receive packets from the guest with offloading large copies to the DMA engine, thus saving precious CPU cycles. S

[dpdk-dev] [PATCH v5 2/4] examples/vhost: use a new API to query remaining ring space

2021-07-04 Thread Wenwu Ma
A new API for querying the remaining descriptor ring capacity is available, so we use the new one instead of the old one. Signed-off-by: Wenwu Ma --- examples/vhost/ioat.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/examples/vhost/ioat.c b/examples/vhost/ioat.c index

[dpdk-dev] [PATCH v5 1/4] examples/vhost: refactor vhost enqueue and dequeue datapaths.

2021-07-04 Thread Wenwu Ma
Previously, by judging the flag, we call different enqueue/dequeue functions in data path. Now, we use an ops that was initialized when Vhost was created, so that we can call ops directly in Vhost data path without any more flag judgment. Signed-off-by: Wenwu Ma --- examples/vhost/main.c

[dpdk-dev] [PATCH v5 0/4] support async dequeue for split ring

2021-07-04 Thread Wenwu Ma
This patch implements asynchronous dequeue data path for split ring. A new asynchronous dequeue function is introduced. With this function, the application can try to receive packets from the guest with offloading large copies to the DMA engine, thus saving precious CPU cycles. v5: - DMA address u

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-07-04 Thread Thomas Monjalon
05/07/2021 05:18, Huisong Li: > 在 2021/7/5 4:05, Thomas Monjalon 写道: > > 08/05/2021 10:00, Huisong Li: > >> Currently, if dev_configure is not invoked or fails to be invoked, users > >> can still invoke dev_start successfully. This patch adds a "dev_configured" > >> flag in "rte_eth_dev_data" to co

Re: [dpdk-dev] [PATCH v6 2/2] bus/auxiliary: introduce auxiliary bus

2021-07-04 Thread Xueming(Steven) Li
Hi Andrew, Thanks very much all the good suggestions, v7 posted. Best Regards, Xueming > -Original Message- > From: Andrew Rybchenko > Sent: Monday, July 5, 2021 12:13 AM > To: Xueming(Steven) Li > Cc: dev@dpdk.org; Wang Haiyue ; NBU-Contact-Thomas > Monjalon ; Kinsella Ray > ; Neil H

[dpdk-dev] [PATCH v7 2/2] bus/auxiliary: introduce auxiliary bus

2021-07-04 Thread Xueming Li
Auxiliary bus [1] provides a way to split function into child-devices representing sub-domains of functionality. Each auxiliary device represents a part of its parent functionality. Auxiliary device is identified by unique device name, sysfs path: /sys/bus/auxiliary/devices/ Devargs legacy synt

[dpdk-dev] [PATCH v7 1/2] devargs: add common key definition

2021-07-04 Thread Xueming Li
Adds common devargs key definition for "bus", "class" and "driver". Acked-by: Thomas Monjalon Signed-off-by: Xueming Li --- drivers/common/mlx5/mlx5_common.h | 2 -- drivers/common/mlx5/mlx5_common_pci.c | 2 +- drivers/common/sfc_efx/sfc_efx.c| 7 +++ drivers/common/sfc_

[dpdk-dev] [PATCH_v2 3/3] regex/mlx5: fix redundancy in PCI remove function

2021-07-04 Thread Michael Baum
In the PCI removal function, PMD releases all driver resources and cancels the regexdev registry. However, regexdev registration is accidentally canceled twice. Remove one of them. Fixes: b34d816363b5 ("regex/mlx5: support rules import") Cc: sta...@dpdk.org Signed-off-by: Michael Baum --- dri

[dpdk-dev] [PATCH_v2 2/3] regex/mlx5: fix leak in PCI remove function

2021-07-04 Thread Michael Baum
In the PCI removal function, PMD releases all driver resources allocated in the probe function. The MR btree memory is allocated in the probe function, but it is not freed in remove function what caused a memory leak. Release it. Fixes: cda883bbb655 ("regex/mlx5: add dynamic memory registration

[dpdk-dev] [PATCH_v2 1/3] regex/mlx5: fix memory region unregistration

2021-07-04 Thread Michael Baum
The issue can cause illegal physical address access while a huge-page A is released and huge-page B is allocated on the same virtual address. The old MR can be matched using the virtual address of huge-page B but the HW will access the physical address of huge-page A which is no more part of the DP

Re: [dpdk-dev] 19.11.9 patches review and test

2021-07-04 Thread Christian Ehrhardt
On Mon, Jul 5, 2021 at 6:14 AM Pei Zhang wrote: > > Hello Christian, > > The testing with dpdk 19.11.9-rc3 from Red Hat looks good. We tested below 16 > scenarios and all got PASS on RHEL8: > > (1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS > (2)Guest with device a

Re: [dpdk-dev] DTS improvement WG - Debate/triag inputs - Extending for next 5 weeks

2021-07-04 Thread Tu, Lijuan
Hi Honnappa, Shall we cancel this week as I have to leave for urgent family affairs? thanks -Original Appointment- From: Honnappa Nagarahalli Sent: 2021年5月18日 12:37 To: Honnappa Nagarahalli; Chen, Zhaoyan; Buckley, Daniel M; juraj.lin...@pantheon.tech; Tu, Lijuan; jer...@marvell.com; L

Re: [dpdk-dev] 19.11.9 patches review and test

2021-07-04 Thread Pei Zhang
Hello Christian, The testing with dpdk 19.11.9-rc3 from Red Hat looks good. We tested below 16 scenarios and all got PASS on RHEL8: (1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS (2)Guest with device assignment(PF) throughput testing(2M hugepage size) : PASS (3)Gue

[dpdk-dev] [PATCH 2/2] net/cnxk: add support for rte flow item raw

2021-07-04 Thread psatheesh
From: Satheesh Paul Add support for rte_flow_item_raw to parse custom L2 and L3 protocols. Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar Kokkilagadda --- doc/guides/nics/cnxk.rst | 169 +++-- drivers/net/cnxk/cnxk_ethdev_devargs.c | 7 + drivers/net

[dpdk-dev] [PATCH 1/2] common/cnxk: add support for rte flow item raw

2021-07-04 Thread psatheesh
From: Satheesh Paul Add roc API for rte_flow_item_raw to parse custom L2 and L3 protocols. Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar Kokkilagadda --- drivers/common/cnxk/roc_mbox.h | 24 ++-- drivers/common/cnxk/roc_nix_ops.c | 14 + drivers/common/cnxk/roc_npc.h

Re: [dpdk-dev] [PATCH v2] net/i40e: add logic of processing continuous DD bits for Arm

2021-07-04 Thread Joyce Kong
> -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, June 30, 2021 9:15 AM > To: Joyce Kong ; beilei.x...@intel.com; > qi.z.zh...@intel.com; Ruifeng Wang ; > bruce.richard...@intel.com; helin.zh...@intel.com > Cc: dev@dpdk.org; sta...@dpdk.org; nd ; Honnappa > Nagarahall

Re: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading

2021-07-04 Thread Wang, Haiyue
Hi David & Qi, > -Original Message- > From: Wang, Haiyue > Sent: Monday, July 5, 2021 09:43 > To: David Marchand ; dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > Subject: RE: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading > > Hi David, > > > -Original Message- >

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-07-04 Thread Huisong Li
在 2021/7/5 4:05, Thomas Monjalon 写道: 08/05/2021 10:00, Huisong Li: Currently, if dev_configure is not invoked or fails to be invoked, users can still invoke dev_start successfully. This patch adds a "dev_configured" flag in "rte_eth_dev_data" to control whether dev_start can be invoked. [...]

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-07-04 Thread Huisong Li
在 2021/7/3 19:04, Ananyev, Konstantin 写道: 在 2021/7/2 21:23, Ananyev, Konstantin 写道: On 7/2/2021 12:08 PM, Andrew Rybchenko wrote: @Thomas, @Ferruh, I tend to accept it (with minor style fixes), but I need your opinion on it before doing it. I guess we were relying on the user/application to

Re: [dpdk-dev] [PATCH v6 01/19] net/ngbe: add build and doc infrastructure

2021-07-04 Thread Jiawen Wu
On July 2, 2021 9:08 PM, Andrew Rybchenko wrote: > On 6/17/21 1:59 PM, Jiawen Wu wrote: > > Adding bare minimum PMD library and doc build infrastructure and claim > > the maintainership for ngbe PMD. > > > > Signed-off-by: Jiawen Wu > > Just one nit below. > > [snip] > > > diff --git a/drivers/

Re: [dpdk-dev] [PATCH] ethdev: keep count of allocated and used representor ranges

2021-07-04 Thread Xueming(Steven) Li
> -Original Message- > From: Viacheslav Galaktionov > Sent: Saturday, July 3, 2021 6:01 PM > To: Xueming(Steven) Li > Cc: Andrew Rybchenko ; Matan Azrad > ; Shahaf Shuler > ; Slava Ovsiienko ; > NBU-Contact-Thomas Monjalon ; > Ferruh Yigit ; dev@dpdk.org; sta...@dpdk.org > Subject: R

Re: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading

2021-07-04 Thread Wang, Haiyue
Hi David, > -Original Message- > From: dev On Behalf Of David Marchand > Sent: Tuesday, June 29, 2021 16:07 > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > Subject: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading > > Both "normal" and "dcf" inits have their copy of s

Re: [dpdk-dev] [PATCH 2/2] vhost: add thread unsafe async registration functions

2021-07-04 Thread Hu, Jiayu
> -Original Message- > From: Maxime Coquelin > Sent: Friday, July 2, 2021 3:41 PM > To: Hu, Jiayu ; dev@dpdk.org > Cc: Xia, Chenbo ; Wang, Yinan > > Subject: Re: [PATCH 2/2] vhost: add thread unsafe async registration > functions > > > > On 5/28/21 10:11 AM, Jiayu Hu wrote: > > This

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-07-04 Thread Thomas Monjalon
08/05/2021 10:00, Huisong Li: > Currently, if dev_configure is not invoked or fails to be invoked, users > can still invoke dev_start successfully. This patch adds a "dev_configured" > flag in "rte_eth_dev_data" to control whether dev_start can be invoked. [...] > --- a/lib/ethdev/rte_ethdev_core.h

Re: [dpdk-dev] [PATCH v3 19/20] net/sfc: support flow action COUNT in transfer rules

2021-07-04 Thread Thomas Monjalon
02/07/2021 14:53, Andrew Rybchenko: > On 7/2/21 3:30 PM, Thomas Monjalon wrote: > > 02/07/2021 10:43, Andrew Rybchenko: > >> On 7/1/21 4:05 PM, Andrew Rybchenko wrote: > >>> On 7/1/21 3:34 PM, David Marchand wrote: > On Thu, Jul 1, 2021 at 11:22 AM Andrew Rybchenko > wrote: > > The b

Re: [dpdk-dev] [PATCH v2] doc: add link status event pre-conditions

2021-07-04 Thread Thomas Monjalon
02/07/2021 14:58, Andrew Rybchenko: > On 7/2/21 3:35 PM, Thomas Monjalon wrote: > > 02/07/2021 10:55, Andrew Rybchenko: > >> On 6/30/21 4:56 AM, Min Hu (Connor) wrote: > >>> From: Chengwen Feng > >>> +Firmware 1.8.0.0 and later versions support reporting link changes to > >>> the PF. > >>> +There

Re: [dpdk-dev] NUMA node/socket

2021-07-04 Thread Dmitry Kozlyuk
2021-07-04 11:28 (UTC+0200), Thomas Monjalon: > 04/07/2021 10:27, Andrew Rybchenko: > > On 7/4/21 4:53 AM, Thomas Monjalon wrote: > > > 04/07/2021 03:38, Thomas Monjalon: > > >> There are some mix between NUMA node and socket IDs in DPDK. > > >> Examples: > > >> * rte_eth_dev_socket_id() retur

Re: [dpdk-dev] NUMA node/socket

2021-07-04 Thread Stephen Hemminger
On Sun, 04 Jul 2021 11:28:23 +0200 Thomas Monjalon wrote: > 04/07/2021 10:27, Andrew Rybchenko: > > On 7/4/21 4:53 AM, Thomas Monjalon wrote: > > > 04/07/2021 03:38, Thomas Monjalon: > > >> There are some mix between NUMA node and socket IDs in DPDK. > > >> Examples: > > >> * rte_eth_dev_soc

Re: [dpdk-dev] [PATCH v6 2/2] bus/auxiliary: introduce auxiliary bus

2021-07-04 Thread Andrew Rybchenko
On 6/25/21 2:47 PM, Xueming Li wrote: > Auxiliary bus [1] provides a way to split function into child-devices > representing sub-domains of functionality. Each auxiliary device > represents a part of its parent functionality. > > Auxiliary device is identified by unique device name, sysfs path: >

[dpdk-dev] [PATCH v4 2/2] kni: implement basic get_link_ksettings callback

2021-07-04 Thread Igor Ryzhov
Signed-off-by: Igor Ryzhov --- kernel/linux/kni/kni_net.c | 25 + 1 file changed, 25 insertions(+) diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c index 99da8d37dd6b..84357bec1341 100644 --- a/kernel/linux/kni/kni_net.c +++ b/kernel/linux/kni/kni_net.

[dpdk-dev] [PATCH v4 1/2] kni: rework rte_kni_update_link using ioctl

2021-07-04 Thread Igor Ryzhov
Current implementation doesn't allow us to update KNI carrier if the interface is not yet UP in kernel. It means that we can't use it in the same thread which is processing rte_kni_ops.config_network_if, which is very convenient, because it allows us to have correct carrier status of the interface

Re: [dpdk-dev] [PATCH v6 1/2] devargs: add common key definition

2021-07-04 Thread Andrew Rybchenko
On 6/25/21 2:47 PM, Xueming Li wrote: > Adds common devargs key definition for "bus", "class" and "driver". > > Acked-by: Thomas Monjalon > Signed-off-by: Xueming Li Acked-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH v2] add testing requirement for new PMDs

2021-07-04 Thread Andrew Rybchenko
On 7/1/21 9:49 AM, Mcnamara, John wrote: >> -Original Message- >> From: Yigit, Ferruh >> Sent: Tuesday, June 29, 2021 9:35 AM >> To: w...@dpdk.org >> Cc: dev@dpdk.org; Thomas Monjalon ; Mcnamara, John >> ; Dmitry Kozlyuk >> Subject: [PATCH v2] add testing requirement for new PMDs >> >> As

Re: [dpdk-dev] [PATCH] dmadev: introduce DMA device library

2021-07-04 Thread Matan Azrad
From: Chengwen Feng > This patch introduces 'dmadevice' which is a generic type of DMA > device. > > The APIs of dmadev library exposes some generic operations which can > enable configuration and I/O with the DMA devices. > Did you consider RTE_COMP_ALGO_NULL xform in compressdev library? >

Re: [dpdk-dev] [PATCH 3/3] net/bonding: start ethdev prior to setting 8023ad flow

2021-07-04 Thread Matan Azrad
From: Havlík Martin > Dne 2021-06-23 09:04, Min Hu (Connor) napsal: > > 在 2021/6/22 17:25, Martin Havlik 写道: > >> When dedicated queues are enabled, mlx5 PMD fails to install RTE > >> Flows if the underlying ethdev is not started: > >> bond_ethdev_8023ad_flow_set(267) - bond_ethdev_8023ad_flow_se

Re: [dpdk-dev] [PATCH 0/3] net/bonding: make dedicated queues work with mlx5

2021-07-04 Thread Andrew Rybchenko
I guess review from net/mlx5 maintainers would be very useful here. Adding in Cc. On 6/22/21 12:25 PM, Martin Havlik wrote: > This patchset fixes the inability to use dedicated queues > on mlx5 PMD due to RTE Flow rule attempted creation prior to > starting the device. > Missing return value check

Re: [dpdk-dev] [PATCH] dmadev: introduce DMA device library

2021-07-04 Thread Andrew Rybchenko
On 7/2/21 4:18 PM, Chengwen Feng wrote: > This patch introduces 'dmadevice' which is a generic type of DMA > device. "This patch introduces ... " -> "Introduce ..." > > The APIs of dmadev library exposes some generic operations which can > enable configuration and I/O with the DMA devices. > >

Re: [dpdk-dev] [PATCH] dmadev: introduce DMA device library

2021-07-04 Thread Jerin Jacob
On Fri, Jul 2, 2021 at 6:51 PM Chengwen Feng wrote: > > This patch introduces 'dmadevice' which is a generic type of DMA > device. > > The APIs of dmadev library exposes some generic operations which can > enable configuration and I/O with the DMA devices. > > Signed-off-by: Chengwen Feng Thanks

Re: [dpdk-dev] NUMA node/socket

2021-07-04 Thread Thomas Monjalon
04/07/2021 10:27, Andrew Rybchenko: > On 7/4/21 4:53 AM, Thomas Monjalon wrote: > > 04/07/2021 03:38, Thomas Monjalon: > >> There are some mix between NUMA node and socket IDs in DPDK. > >> Examples: > >>* rte_eth_dev_socket_id() returns the NUMA node. > >>* rte_malloc use sockets to alloca

Re: [dpdk-dev] NUMA node/socket

2021-07-04 Thread Andrew Rybchenko
On 7/4/21 4:53 AM, Thomas Monjalon wrote: > 04/07/2021 03:38, Thomas Monjalon: >> There are some mix between NUMA node and socket IDs in DPDK. >> Examples: >> * rte_eth_dev_socket_id() returns the NUMA node. >> * rte_malloc use sockets to allocate the memory >> >> Is it critical? > > The

Re: [dpdk-dev] dmadev discussion summary

2021-07-04 Thread Jerin Jacob
On Sat, Jul 3, 2021 at 5:54 PM Morten Brørup wrote: > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob > > Sent: Saturday, 3 July 2021 11.09 > > > > On Sat, Jul 3, 2021 at 2:23 PM Morten Brørup > > wrote: > > > > > > > From: fengchengwen [mailto:fengcheng...@huawei.com] > > >

Re: [dpdk-dev] dmadev discussion summary

2021-07-04 Thread Jerin Jacob
On Sat, Jul 3, 2021 at 5:30 PM Morten Brørup wrote: > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of fengchengwen > > Sent: Saturday, 3 July 2021 11.45 > > > > On 2021/7/3 16:53, Morten Brørup wrote: > > >> From: fengchengwen [mailto:fengcheng...@huawei.com] > > >> Sent: Saturday, 3 July