Hi Cheng,
Repsonse inline.
> As for this one, I'm not sure why we need have the loop in the application.
> The function of this API is that caller need to drain all the inflight pkts,
> it
> should be called only once to get the job done.
> Don't you think?
Perhaps yes, but my thought was to
On 7/7/21 1:02 PM, David Marchand wrote:
> When calling rte_eal_cleanup, the mp channel cleanup routine only sets
> mp_fd to -1 leaving the rte_mp_handle control thread running.
> This control thread can spew warnings on reading on an invalid fd.
> This is especially noticed with ASAN enabled.
>
08/07/2021 08:32, Jerin Jacob:
> On Thu, Jul 8, 2021 at 11:55 AM Ruifeng Wang wrote:
> > From: Jerin Jacob
> > > On Wed, Jul 7, 2021 at 5:57 PM Bruce Richardson
> > > wrote:
> > > > On Wed, Jul 07, 2021 at 06:46:33AM +, Ruifeng Wang wrote:
> > > > > From: Thomas Monjalon
> > > > > > 07/07/2
On 7/8/21 9:09 AM, Jiawen Wu wrote:
> On July 7, 2021 10:05 PM, Andrew Rybchenko wrote:
>> On 7/6/21 12:55 PM, Jiawen Wu wrote:
>>> Setup MSI-X interrupt, complete PHY configuration and set device link
>>> speed to start device. Disable interrupt, stop hardware and clear
>>> queues to stop device.
> 07/07/2021 21:30, Akhil Goyal:
> > Shijith Thotton (2):
> > drivers: add octeontx crypto adapter framework
> > drivers: add octeontx crypto adapter data path
>
> It seems there is an ABI breakage:
>
> devtools/check-abi.sh: line 38: 958581 Segmentation fault
> (core dumped) abidiff
07/07/2021 23:57, Thomas Monjalon:
> 07/07/2021 21:30, Akhil Goyal:
> > Shijith Thotton (2):
> > drivers: add octeontx crypto adapter framework
> > drivers: add octeontx crypto adapter data path
>
> It seems there is an ABI breakage:
>
> devtools/check-abi.sh: line 38: 958581 Segmenta
@Thomas, @Ferruh, @Ori I need your opinion on the discussion.
On 7/8/21 4:07 AM, Zhang, Qi Z wrote:
>
>
>> -Original Message-
>> From: Andrew Rybchenko
>> Sent: Wednesday, July 7, 2021 9:11 PM
>> To: Zhang, Qi Z ; Zhang, AlvinX
>> ; ajit.khapa...@broadcom.com
>> Cc: dev@dpdk.org
>> Subj
> 07/07/2021 23:57, Thomas Monjalon:
> > 07/07/2021 21:30, Akhil Goyal:
> > > Shijith Thotton (2):
> > > drivers: add octeontx crypto adapter framework
> > > drivers: add octeontx crypto adapter data path
> >
> > It seems there is an ABI breakage:
> >
> > devtools/check-abi.sh: line 38:
On July 8, 2021 3:37 PM, Andrew Rybchenko wrote:
> On 7/8/21 9:09 AM, Jiawen Wu wrote:
> > On July 7, 2021 10:05 PM, Andrew Rybchenko wrote:
> >> On 7/6/21 12:55 PM, Jiawen Wu wrote:
> >>> Setup MSI-X interrupt, complete PHY configuration and set device
> >>> link speed to start device. Disable int
On Thu, Jul 8, 2021 at 9:41 AM Thomas Monjalon wrote:
>
> 07/07/2021 23:57, Thomas Monjalon:
> > 07/07/2021 21:30, Akhil Goyal:
> > > Shijith Thotton (2):
> > > drivers: add octeontx crypto adapter framework
> > > drivers: add octeontx crypto adapter data path
> >
> > It seems there is
On Wed, Jul 7, 2021 at 1:43 AM Thomas Monjalon wrote:
> 15/06/2021 21:33, Ajit Khaparde:
> > On Sat, Jun 12, 2021 at 5:06 PM Ajit Khaparde
> > wrote:
> > >
> > > This patchset adds flow table management support for
> > > Thor network adapter and introduces enhancements to
> > > the existing flow
On 7/8/21 10:50 AM, Jiawen Wu wrote:
> On July 8, 2021 3:37 PM, Andrew Rybchenko wrote:
>> On 7/8/21 9:09 AM, Jiawen Wu wrote:
>>> On July 7, 2021 10:05 PM, Andrew Rybchenko wrote:
On 7/6/21 12:55 PM, Jiawen Wu wrote:
> Setup MSI-X interrupt, complete PHY configuration and set device
>
On 8/7/2021 3:34 AM, Richael Zhuang wrote:
Currently in DPDK only acpi_cpufreq and pstate_cpufreq drivers are
supported, which are both not available on arm64 platforms. Add
support for cppc_cpufreq driver which works on most arm64 platforms.
Signed-off-by: Richael Zhuang
---
app/test/test_
On 8/7/2021 3:34 AM, Richael Zhuang wrote:
On arm platform, the value in "/sys/.../cpuinfo_cur_freq" may not
be exactly the same as what was set when using CPPC cpufreq driver.
For other cpufreq driver, no need to round it currently, or else
this check will fail with turbo enabled. For example,
From: Dapeng Yu
In function pmd_parse_args(), firmware path is duplicated from device
arguments as character string, but is never freed, which cause memory
leak.
This patch changes the type of firmware member of struct pmd_params to
character array, to make memory resource release unnecessary, a
On July 7, 2021 10:13 PM, Andrew Rybchenko wrote:
> On 7/6/21 12:55 PM, Jiawen Wu wrote:
> > Support to close and reset device.
> >
> > Signed-off-by: Jiawen Wu
> > ---
> > drivers/net/ngbe/ngbe_ethdev.c | 63
> > --
> > drivers/net/ngbe/ngbe_ethdev.h | 2 ++
> >
> -Original Message-
> From: Thomas Monjalon
> Sent: Thursday, July 8, 2021 3:33 PM
> To: Ruifeng Wang ; Jerin Jacob
>
> Cc: Bruce Richardson ; Jan Viktorin
> ; jer...@marvell.com; dev@dpdk.org;
> david.march...@redhat.com; nd ; Honnappa Nagarahalli
>
> Subject: Re: [dpdk-dev] [PATCH v4
Hi Raslan,
On 7/6/21 5:24 PM, Raslan Darawsheh wrote:
> Hi Guys,
>
> Sorry for missing this mail, for some reason it was missed in my inbox,
> This is the link to this rfc:
> https://www.3gpp.org/ftp/Specs/archive/38_series/38.415/38415-g30.zip
Thanks for the link. The patch LGTM, but I have onl
On 6/17/21 12:17 PM, Raslan Darawsheh wrote:
> Define new rte header for gtp PDU session container
> based on RFC 38415-g30
>
> Signed-off-by: Raslan Darawsheh
As I understand prefix should be "net: ", not "ethdev: ".
Reviewed-by: Andrew Rybchenko
> ---
> v6 : fixed typos
> fixed indenta
Thank you for the review,
Basically it's not used yet since it will break the abi
The main usage was in rte_flow item of gtp_psc
To replace the current structure with the header definition. And since this
will break the abi I'm adding the header definition now but will be used later
in rte_flow.
Adding bare minimum PMD library and doc build infrastructure
and claim the maintainership for ngbe PMD.
Signed-off-by: Jiawen Wu
---
MAINTAINERS| 6 +
doc/guides/nics/features/ngbe.ini | 10 +
doc/guides/nics/index.rst | 1 +
doc/guides
Add device IDs for Wangxun 1Gb NICs, map device IDs to register ngbe
PMD. Add basic PCIe ethdev probe and remove.
Signed-off-by: Jiawen Wu
---
doc/guides/nics/features/ngbe.ini | 1 +
drivers/net/ngbe/base/meson.build | 13 +
drivers/net/ngbe/base/ngbe_devids.h | 83
Define all registers that will be used.
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/base/ngbe_regs.h | 1490 +
1 file changed, 1490 insertions(+)
create mode 100644 drivers/net/ngbe/base/ngbe_regs.h
diff --git a/drivers/net/ngbe/base/ngbe_regs.h
b/drivers/net/ngb
Add basic init and uninit function.
Map device IDs and subsystem IDs to single ID for easy operation.
Then initialize the shared code.
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/base/meson.build | 4 +-
drivers/net/ngbe/base/ngbe.h | 11 ++
drivers/net/ngbe/base/ngbe_dummy.h | 37 +
Initialize the hardware by resetting the hardware in base code.
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/base/ngbe_dummy.h | 21 +++
drivers/net/ngbe/base/ngbe_hw.c| 235 +
drivers/net/ngbe/base/ngbe_hw.h| 9 ++
drivers/net/ngbe/base/ngbe_type.h | 30
Identify PHY to get the PHY type, and perform a PHY reset.
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/base/meson.build| 4 +
drivers/net/ngbe/base/ngbe_dummy.h | 40 +++
drivers/net/ngbe/base/ngbe_hw.c | 38 +++
drivers/net/ngbe/base/ngbe_hw.h | 2 +
drivers/net/ngbe/bas
Store MAC addresses and init receive address filters.
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/base/ngbe_dummy.h | 33 +++
drivers/net/ngbe/base/ngbe_hw.c| 323 +
drivers/net/ngbe/base/ngbe_hw.h| 13 ++
drivers/net/ngbe/base/ngbe_type.h | 19 ++
drive
Register to handle device interrupt.
Signed-off-by: Jiawen Wu
---
doc/guides/nics/features/ngbe.ini | 3 +
doc/guides/nics/ngbe.rst | 6 +
drivers/net/ngbe/base/ngbe_dummy.h | 6 +
drivers/net/ngbe/base/ngbe_type.h | 11 +
drivers/net/ngbe/ngbe_ethdev.c | 369 +
Setup device Rx queue and release Rx queue.
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/meson.build | 1 +
drivers/net/ngbe/ngbe_ethdev.c | 37 -
drivers/net/ngbe/ngbe_ethdev.h | 16 ++
drivers/net/ngbe/ngbe_rxtx.c | 291 +
drivers/net/ngbe/ngbe_rxtx
Setup device Tx queue and release Tx queue.
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/ngbe_ethdev.c | 24
drivers/net/ngbe/ngbe_ethdev.h | 11 ++
drivers/net/ngbe/ngbe_rxtx.c | 195 +
drivers/net/ngbe/ngbe_rxtx.h | 98 +
4 files cha
Setup MSI-X interrupt, complete PHY configuration and set device link
speed to start device. Disable interrupt, stop hardware and clear queues
to stop device.
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/base/ngbe_dummy.h | 16 +
drivers/net/ngbe/base/ngbe_hw.c | 49 +++
drivers/net/ng
Initializes receive unit, support to start and stop receive unit for
specified queues.
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/base/ngbe_dummy.h | 15 ++
drivers/net/ngbe/base/ngbe_hw.c| 105 ++
drivers/net/ngbe/base/ngbe_hw.h| 4 +
drivers/net/ngbe/base/ngbe_type.h
Initialize device with the simplest transmit functions.
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/ngbe_ethdev.c | 1 +
drivers/net/ngbe/ngbe_ethdev.h | 3 +
drivers/net/ngbe/ngbe_rxtx.c | 228 +
drivers/net/ngbe/ngbe_rxtx.h | 27
4 files changed,
Support to close and reset device.
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/ngbe_ethdev.c | 63 --
drivers/net/ngbe/ngbe_ethdev.h | 2 ++
drivers/net/ngbe/ngbe_rxtx.c | 20 +++
3 files changed, 82 insertions(+), 3 deletions(-)
diff --git a/drivers
Reset swfw lock before NVM access, init EEPROM and validate the
checksum.
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/base/meson.build | 2 +
drivers/net/ngbe/base/ngbe_dummy.h | 23
drivers/net/ngbe/base/ngbe_eeprom.c | 203
drivers/net/ngbe/base/ngbe_e
Setup PHY, determine link and speed status from PHY.
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/base/ngbe_dummy.h | 18 +++
drivers/net/ngbe/base/ngbe_hw.c | 53 +
drivers/net/ngbe/base/ngbe_hw.h | 6 +
drivers/net/ngbe/base/ngbe_phy.c | 22
drivers/net/ngbe/
Initializes transmit unit, support to start and stop transmit unit for
specified queues.
Signed-off-by: Jiawen Wu
---
doc/guides/nics/features/ngbe.ini | 1 +
drivers/net/ngbe/base/ngbe_type.h | 1 +
drivers/net/ngbe/ngbe_ethdev.c| 3 +
drivers/net/ngbe/ngbe_ethdev.h| 7 ++
drive
Initialize device with the simplest receive function.
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/ngbe_ethdev.c | 1 +
drivers/net/ngbe/ngbe_ethdev.h | 3 +
drivers/net/ngbe/ngbe_rxtx.c | 169 +
drivers/net/ngbe/ngbe_rxtx.h | 73 ++
4 files
This patch set provides a skeleton of ngbe PMD,
which adapted to Wangxun WX1860 series NICs.
v8:
- Fix some check patch errors.
- Remove __rte_cold.
v7:
- Fix minor issues and re-order patches.
v6:
- Correct style errors and re-split patches.
v5:
- Extend patches with device initialization and
Add log type and error type to trace functions.
Signed-off-by: Jiawen Wu
---
doc/guides/nics/ngbe.rst| 21 +
drivers/net/ngbe/base/ngbe_status.h | 73 +
drivers/net/ngbe/ngbe_ethdev.c | 15 ++
drivers/net/ngbe/ngbe_logs.h| 46 +
v2: fix to prefer closest match
get_hugepage_dir() was implemented in such a way that a --huge-dir option had to
exactly match the mountpoint, but there's no reason for this restriction. Fix
the implementation to allow a sub-directory within a suitable hugetlbfs
mountpoint to be specified, preferring the closest match.
Signed-of
On 7/8/21 12:27 PM, Raslan Darawsheh wrote:
> Thank you for the review,
>
> Basically it's not used yet since it will break the abi
> The main usage was in rte_flow item of gtp_psc
> To replace the current structure with the header definition. And since
> this will break the abi I'm adding the hea
> -Original Message-
> From: Stephen Hemminger
> Sent: Wednesday, July 7, 2021 10:48 PM
> To: Ruifeng Wang
> Cc: dev@dpdk.org; david.march...@redhat.com; tho...@monjalon.net;
> jer...@marvell.com; nd ; Honnappa Nagarahalli
>
> Subject: Re: [dpdk-dev] Use WFE for spinlock and ring
>
> On
Feature flag in dev would be updated during config. On reconfigure, the
field need to be set again to original value.
Signed-off-by: Anoob Joseph
---
drivers/crypto/cnxk/cn10k_cryptodev.c| 14 +-
drivers/crypto/cnxk/cn9k_cryptodev.c | 13 +
drivers/crypto/cnxk/cnx
Thanks Raslan for the rfc link.The structure order for RTE_BIG_ENDIAN seems ok. I doubt for
RTE_LITTLE_ENDIAN case, if there is a need to reverse the order of
fields, as we are using uint8_t only. If you have already tested on x86
then it should be fine ? Regards Aman
On 7/6/2021 7:54 PM, Rasl
On Thu, Jul 8, 2021 at 9:23 AM Maxime Coquelin
wrote:
> On 7/7/21 1:02 PM, David Marchand wrote:
> > When calling rte_eal_cleanup, the mp channel cleanup routine only sets
> > mp_fd to -1 leaving the rte_mp_handle control thread running.
> > This control thread can spew warnings on reading on an i
On Wed, Jul 7, 2021 at 11:54 AM Huisong Li wrote:
>
> Currently, if dev_configure is not called or fails to be called, users
> can still call dev_start successfully. So it is necessary to have a flag
> which indicates whether the device is configured, to control whether
> dev_start can be called a
Add support for the Longest Prefix Match (LPM) lookup to the SWX
pipeline.
Signed-off-by: Cristian Dumitrescu
Signed-off-by: Churchill Khangar
---
Depends-on: series-17609 ("examples/pipeline: improve table update CLI
commands")
Depends-on: patch-17642 ("[V2] pipeline: fix table entry read")
On 7/8/21 12:32 PM, Jiawen Wu wrote:
> This patch set provides a skeleton of ngbe PMD,
> which adapted to Wangxun WX1860 series NICs.
Applied, thanks.
The front-end should refill the descriptor with the mbuf indicated by
the buff_id rather then the index of used descriptor. Back-end may
return buffers out of order if async copy mode is enabled.
When initializing rxq, refill the descriptors in order as buff_id is
not available at that time.
Fixe
08/07/2021 11:21, Ruifeng Wang:
> From: Thomas Monjalon
> > 08/07/2021 08:32, Jerin Jacob:
> > > On Thu, Jul 8, 2021 at 11:55 AM Ruifeng Wang
> > wrote:
> > > > From: Jerin Jacob
> > > > > On Wed, Jul 7, 2021 at 5:57 PM Bruce Richardson
> > > > > wrote:
> > > > > > On Wed, Jul 07, 2021 at 06:46
08/07/2021 11:39, Andrew Rybchenko:
> On 7/8/21 12:27 PM, Raslan Darawsheh wrote:
> > Thank you for the review,
> >
> > Basically it's not used yet since it will break the abi
> > The main usage was in rte_flow item of gtp_psc
> > To replace the current structure with the header definition. And si
We assume that in the sync path, if there is no buffer wrap in the
avail descriptors fetched in a batch, there is no buffer wrap in the
used descriptors which need to be written back in this batch, but
this assumption is wrong in the async path since there are inflight
descriptors which are process
We introduced some new indexes in async vhost. If we don't pay
attention to the management of these indexes, they will eventually
overflow and lead to errors. This patch is to check and keep these
indexes within a reasonable range.
Fixes: 873e8dad6f49 ("vhost: support packed ring in async datapath
get_hugepage_dir() was implemented in such a way that a --huge-dir
option had to exactly match the mountpoint, but there's no reason for
this restriction. Fix the implementation to allow a sub-directory within
a suitable hugetlbfs mountpoint to be specified, preferring the closest
match.
Signed-of
The dev start and dev stop ops are added in cnxk crypto PMD.
The instruction queues are enabled in dev start and disabled in
dev stop.
Ankur Dwivedi (2):
common/cnxk: move instruction queue enable to roc API
crypto/cnxk: add dev start and dev stop
drivers/common/cnxk/roc_cpt.c| 4
The code for enabling instruction queue is moved to roc API.
Signed-off-by: Ankur Dwivedi
---
drivers/common/cnxk/roc_cpt.c | 41 -
drivers/common/cnxk/roc_cpt.h | 1 +
drivers/common/cnxk/version.map | 1 +
3 files changed, 27 insertions(+), 16 deletions(-)
The instruction queue is enabled in dev start and is disabled in
dev stop.
Signed-off-by: Ankur Dwivedi
---
drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/cnxk/cnxk_cryptodev_ops.c
b/drivers/crypto/cn
> -Original Message-
> From: Joyce Kong
> Sent: Tuesday, July 6, 2021 2:54 PM
> To: Xing, Beilei ; Zhang, Qi Z ;
> ruifeng.w...@arm.com; honnappa.nagaraha...@arm.com; Richardson, Bruce
> ; Zhang, Helin
> Cc: dev@dpdk.org; sta...@dpdk.org; n...@arm.com
> Subject: [PATCH v3 2/2] net/i40e
Hi, Andrew ,
在 2021/7/2 20:47, Andrew Rybchenko 写道:
On 7/2/21 3:09 PM, Andrew Rybchenko wrote:
From: "Min Hu (Connor)"
For example the following commands run two testpmd processes:
* the primary process:
./dpdk-testpmd --proc-type=auto -l 0-1 -- -i \
--rxq=4 --txq=4 --num-procs=2 --pr
On 7/8/21 3:20 PM, Min Hu (Connor) wrote:
> Hi, Andrew ,
>
> 在 2021/7/2 20:47, Andrew Rybchenko 写道:
>> On 7/2/21 3:09 PM, Andrew Rybchenko wrote:
>>> From: "Min Hu (Connor)"
>>>
>>> For example the following commands run two testpmd processes:
>>>
>>> * the primary process:
>>>
>>> ./dpdk-testp
The old code has just low-level error, which just copied the "printf"
above.
Thanks for your patch.
Acked-by: Min Hu (Connor)
在 2021/6/22 17:25, Martin Havlik 写道:
Return value is now saved to errval and log message on error
reports correct function name, doesn't use q_id which was out of conte
在 2021/6/22 17:25, Martin Havlik 写道:
Return value from bond_ethdev_8023ad_flow_set() is now checked
and appropriate message is logged on error.
Fixes: 112891cd27e5 ("net/bonding: add dedicated HW queues for LACP control")
Cc: tomaszx.kula...@intel.com
Signed-off-by: Martin Havlik
Cc: Jan Vi
On Wed, Jun 23, 2021 at 2:04 PM David Hunt wrote:
>
> From: Anatoly Burakov
>
> Currently, ACPI and PSTATE modes have lots of code duplication,
> confusing logic, and a bunch of other issues that can, and have, led to
> various bugs and resource leaks.
>
> This commit factors out the common parts
08/07/2021 05:57, Ajit Khaparde:
> On Wed, Jul 7, 2021 at 1:43 AM Thomas Monjalon wrote:
> > 15/06/2021 21:33, Ajit Khaparde:
> > > On Sat, Jun 12, 2021 at 5:06 PM Ajit Khaparde
> > > wrote:
> > > >
> > > > This patchset adds flow table management support for
> > > > Thor network adapter and intr
Hi,Andrew ,
在 2021/7/8 20:30, Andrew Rybchenko 写道:
On 7/8/21 3:20 PM, Min Hu (Connor) wrote:
Hi, Andrew ,
在 2021/7/2 20:47, Andrew Rybchenko 写道:
On 7/2/21 3:09 PM, Andrew Rybchenko wrote:
From: "Min Hu (Connor)"
For example the following commands run two testpmd processes:
* the primar
Dne 2021-07-08 14:43, Min Hu (Connor) napsal:
在 2021/6/22 17:25, Martin Havlik 写道:
Return value from bond_ethdev_8023ad_flow_set() is now checked
and appropriate message is logged on error.
Fixes: 112891cd27e5 ("net/bonding: add dedicated HW queues for LACP
control")
Cc: tomaszx.kula...@intel
On 8/7/2021 1:49 PM, David Marchand wrote:
On Wed, Jun 23, 2021 at 2:04 PM David Hunt wrote:
From: Anatoly Burakov
Currently, ACPI and PSTATE modes have lots of code duplication,
confusing logic, and a bunch of other issues that can, and have, led to
various bugs and resource leaks.
This c
On Thu, Jul 8, 2021 at 4:35 AM Richael Zhuang wrote:
>
> Currently in DPDK only acpi_cpufreq and pstate_cpufreq drivers are
> supported, which are both not available on arm64 platforms. Add
> support for cppc_cpufreq driver which works on most arm64 platforms.
Worth a release note update.
WDYT of
Hi Maxime,
> -Original Message-
> From: Maxime Coquelin
> Sent: Tuesday, July 6, 2021 10:09 PM
> To: Jiang, Cheng1 ; Xia, Chenbo
>
> Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX
>
> Subject: Re: [PATCH v2 1/3] vhost: add unsafe API to drain pkts in async vhost
>
>
>
> On 6/15/21 4:15
Add support for MSI-X interrupt vectors to the vmxnet3 driver.
This will allow more efficient deployments in cloud environments.
By default it will try to allocate 1 vector (0) for link
event and one MSI-X vector for each Rx queue. To simplify
things, it will only be enabled if the number of Tx a
Hi Akhil,
> -Original Message-
> From: Akhil Goyal
> Sent: Wednesday, July 7, 2021 7:38 PM
> To: Gujjar, Abhinandan S ; dev@dpdk.org;
> Jerin Jacob Kollanukkaran
> Cc: Power, Ciara
> Subject: RE: [EXT] [PATCH] test: fix crypto_op length for sessionless case
>
> Hi Abhinandan,
>
> > Cu
This patchset introduces several changes related to PMD power management:
- Changed monitoring intrinsics to use callbacks as a comparison function, based
on previous patchset [1] but incorporating feedback [2] - this hopefully will
make it possible to add support for .get_monitor_addr in virt
Previously, the semantics of power monitor were such that we were
checking current value against the expected value, and if they matched,
then the sleep was aborted. This is somewhat inflexible, because it only
allowed us to check for a specific value in a specific way.
This commit replaces the co
Implement support for .get_monitor_addr in AF_XDP driver.
Signed-off-by: Anatoly Burakov
---
Notes:
v8:
- Fix checkpatch issue
v2:
- Rewrite using the callback mechanism
drivers/net/af_xdp/rte_eth_af_xdp.c | 34 +
1 file changed, 34 insertions(+
Use RTM and WAITPKG instructions to perform a wait-for-writes similar to
what UMWAIT does, but without the limitation of having to listen for
just one event. This works because the optimized power state used by the
TPAUSE instruction will cause a wake up on RTM transaction abort, so if
we add the a
Currently, we expect that only one callback can be active at any given
moment, for a particular queue configuration, which is relatively easy
to implement in a thread-safe way. However, we're about to add support
for multiple queues per lcore, which will greatly increase the
possibility of various
Currently, there is a hard limitation on the PMD power management
support that only allows it to support a single queue per lcore. This is
not ideal as most DPDK use cases will poll multiple queues per core.
The PMD power management mechanism relies on ethdev Rx callbacks, so it
is very difficult
Use the new multi-monitor intrinsic to allow monitoring multiple ethdev
Rx queues while entering the energy efficient power state. The multi
version will be used unconditionally if supported, and the UMWAIT one
will only be used when multi-monitor is not supported by the hardware.
Signed-off-by: A
Currently, l3fwd-power enforces the limitation of having one queue per
lcore. This is no longer necessary, so remove the limitation.
Signed-off-by: Anatoly Burakov
---
examples/l3fwd-power/main.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/examples/l3fwd-power/main.c b/examples/l3fw
> -Original Message-
> From: Lance Richardson
> Sent: Thursday, July 8, 2021 9:51 PM
> To: Zhang, Qi Z
> Cc: Joyce Kong ; Xing, Beilei ;
> ruifeng.w...@arm.com; honnappa.nagaraha...@arm.com; Richardson, Bruce
> ; Zhang, Helin ;
> dev@dpdk.org; sta...@dpdk.org; n...@arm.com
> Subject: Re
> > > >
> > > > Simply replace the SMP barrier with atomic thread fence for i40e
> > > > hw ring
> > sacn,
> > > > if there is no synchronization point.
> > > >
> > > > Signed-off-by: Joyce Kong
> > > > Reviewed-by: Ruifeng Wang
> > > > ---
> > > > drivers/net/i40e/i40e_rxtx.c | 3 ++-
> > > >
Add a new PMD for Nvidia devices- crypto PMD.
The crypto PMD will be supported on Nvidia ConnectX6.
The crypto PMD will add the support of encryption and decryption using
the AES-XTS symmetric algorithm.
The crypto PMD requires rdma-core and uses mlx5 DevX.
v2:
Add data-path part.
v3:
Rebase.
v4
Add a new PMD for Mellanox devices- crypto PMD.
The crypto PMD will be supported starting Nvidia ConnectX6 and
BlueField2.
The crypto PMD will add the support of encryption and decryption using
the AES-XTS symmetric algorithm.
The crypto PMD requires rdma-core and uses mlx5 DevX.
This patch add
A DEK(Data encryption Key) is an mlx5 HW object which represents the
cipher algorithm key.
The DEKs are used during data encryption/decryption operations.
In symmetric algorithms like AES-STS, we use the same DEK for both
encryption and decryption.
Use the mlx5 hash-list tool to manage the DEK ob
Sessions are used in symmetric transformations in order to prepare
objects and data for packet processing stage.
A mlx5 session includes iv_offset, pointer to mlx5_crypto_dek struct,
bsf_size, bsf_p_type, block size index, encryption_order and encryption
standard.
Implement the next session opera
The basic dev control operations are configure, close and get info.
Extended the existing support of configure and close:
-mlx5_crypto_dev_configure- function used to configure device.
-mlx5_crypto_dev_close- function used to close a configured
device.
Added config struc
The HW queue pairs are a pair of send queue and receive queue of
independent work queues packed together in one object for the purpose
of transferring data between nodes of a network.
Completion Queue is a FIFO queue of completed work requests.
In crypto driver we use one QP in loopback in order
Add the dev_start function that is used to start a configured device.
Add the dev_stop function that is used to stop a configured device.
Both functions set the dev parameter as used and return 0.
Signed-off-by: Shiri Kuzin
Acked-by: Matan Azrad
---
drivers/crypto/mlx5/mlx5_crypto.c | 17 +
Mellanox user space drivers don't deal with physical addresses as part
of a memory protection mechanism.
The device translates the given virtual address to a physical address
using the given memory key as an address space identifier.
That's why any mbuf virtual address is moved directly to the HW
d
To work with crypto engines that are marked with wrapped_import_method,
a login session is required.
A crypto login object needs to be created using DevX.
The crypto login object contains:
- The credential pointer.
- The import_KEK pointer to be used for all secured information
From: Suanming Mou
A keytag is a piece of data encrypted together with a DEK.
When a DEK is referenced by an MKEY.bsf through its index, the keytag is
also supplied in the BSF as plaintext. The HW will decrypt the DEK (and
the attached keytag) and will fail the operation if the keytags don't
mat
From: Suanming Mou
The mlx5 HW crypto operations are done by attaching crypto property
to a memory region. Once done, every access to the memory via the
crypto-enabled memory region will result with in-line encryption or
decryption of the data.
As a result, the design choice is to provide two ty
From: Suanming Mou
Currently, HW handles the WQEs much faster than the software,
Using the constant WQE set layout can initialize most of the WQE
segments in advanced, and software only needs to configure very
limited segments in datapath. This accelerates the software WQE
organize in datapath.
From: Suanming Mou
The crypto operations are done with the WQE set which contains
one UMR WQE and one rdma write WQE. Most segments of the WQE
set are initialized properly during queue setup, only limited
segments are initialized according to the crypto detail in the
datapath process.
This commi
From: Suanming Mou
This commit adds mlx5 crypto statistic get and reset operations.
Signed-off-by: Suanming Mou
Signed-off-by: Matan Azrad
---
drivers/crypto/mlx5/mlx5_crypto.c | 40 ---
1 file changed, 37 insertions(+), 3 deletions(-)
diff --git a/drivers/crypto/
In order to test the new mlx5 crypto PMD, the driver is added to the
crypto test application.
Signed-off-by: Shiri Kuzin
---
app/test/test_cryptodev.c | 7 +++
app/test/test_cryptodev.h | 1 +
doc/guides/cryptodevs/mlx5.rst | 3 +++
3 files changed, 11 insertions(+)
diff --git a/a
The AES-XTS algorithm supports using a wrapped key.
In AES-XTS the data-unit defines the data block size to be
encrypted\decrypted.
Add AES-XTS vectors with a wrapped key.
Add a variable stating whether the key is wrapped or not.
Add the AES-XTS data-unit.
Signed-off-by: Shiri Kuzin
---
app/tes
From: Anatoly Burakov
Currently, ACPI and PSTATE modes have lots of code duplication,
confusing logic, and a bunch of other issues that can, and have, led to
various bugs and resource leaks.
This commit factors out the common parts of sysfs reading/writing for
ACPI and PSTATE drivers.
Signed-of
1 - 100 of 145 matches
Mail list logo
