Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-14 Thread Jerin Jacob
On Tue, Jul 13, 2021 at 7:08 PM Bruce Richardson wrote: > > On Tue, Jul 13, 2021 at 09:06:39PM +0800, fengchengwen wrote: > > Thank you for your valuable comments, and I think we've taken a big step > > forward. > > > > @andrew Could you provide the copyright line so that I can add it to > > rel

[dpdk-dev] [PATCH v2 3/3] examples/ipsec-secgw: update L2 length for Tx

2021-07-14 Thread Nithin Dabilpuram
Update mbuf.l2_len with L2 header size for outbound inline processing. This patch also fixes a bug in arg parsing. Signed-off-by: Nithin Dabilpuram --- examples/ipsec-secgw/ipsec-secgw.c | 2 ++ examples/ipsec-secgw/ipsec_worker.c | 42 - 2 files changed, 3

[dpdk-dev] [PATCH v2 2/3] security: add option for faster udata or mdata access

2021-07-14 Thread Nithin Dabilpuram
Currently rte_security_set_pkt_metadata() and rte_security_get_userdata() methods to set pkt metadata on Inline outbound and get userdata after Inline inbound processing is always driver specific callbacks. For drivers that do not have much to do in the callbacks but just to update metadata in rte

[dpdk-dev] [PATCH v2 1/3] security: enforce semantics for Tx inline processing

2021-07-14 Thread Nithin Dabilpuram
Not all net PMD's/HW can parse packet and identify L2 header and L3 header locations on Tx. This is inline with other Tx offloads requirements such as L3 checksum, L4 checksum offload, etc, where mbuf.l2_len, mbuf.l3_len etc, needs to be set for HW to be able to generate checksum. Since Inline IPSe

[dpdk-dev] [PATCH v2 0/3] security: Improve inline fast path routines

2021-07-14 Thread Nithin Dabilpuram
Improvements to Inline inbound and outbound processing fast path routines rte_security_set_pkt_metadata() and rte_security_get_userdata() to make them inline functions and also provide mechanism for drivers to support fast userdata and metadata access instead of driver specific per-pkt function cal

[dpdk-dev] [PATCH v4] net/softnic: fix memory leak in parsing arguments

2021-07-14 Thread dapengx . yu
From: Dapeng Yu In function pmd_parse_args(), firmware path is duplicated from device arguments as character string, but is never freed, which cause memory leak. This patch changes the type of firmware member of struct pmd_params to character array, to make memory resource release unnecessary, a

Re: [dpdk-dev] [PATCH v4] app/testpmd: fix testpmd doesn't show RSS hash offload

2021-07-14 Thread Li, Xiaoyun
> -Original Message- > From: Wang, Jie1X > Sent: Thursday, July 15, 2021 19:57 > To: dev@dpdk.org > Cc: Li, Xiaoyun ; andrew.rybche...@oktetlabs.ru; Wang, > Jie1X ; sta...@dpdk.org > Subject: [PATCH v4] app/testpmd: fix testpmd doesn't show RSS hash offload > > The driver may change offlo

Re: [dpdk-dev] [PATCH 0/4] bnxt PMD patches

2021-07-14 Thread Ajit Khaparde
On Mon, Jul 12, 2021 at 12:43 AM Kalesh A P < kalesh-anakkur.pura...@broadcom.com> wrote: > From: Kalesh AP > > Please apply. > Patchset applied to dpdk-next-net-brcm. > > Kalesh AP (2): > net/bnxt: update HSI structure > net/bnxt: inform firmware about host MTU > > Somnath Kotur (2): >

[dpdk-dev] [PATCH v4] app/testpmd: fix testpmd doesn't show RSS hash offload

2021-07-14 Thread Jie Wang
The driver may change offloads info into dev->data->dev_conf in dev_configure which may cause port->dev_conf and port->rx_conf contain outdated values. This patch updates the offloads info if it changes to fix this issue. Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") Cc: st

[dpdk-dev] [PATCH v3] app/testpmd: fix testpmd doesn't show RSS hash offload

2021-07-14 Thread Jie Wang
The driver may change offloads info into dev->data->dev_conf in dev_configure which may cause port->dev_conf and port->rx_conf contain outdated values. This patch updates the offloads info if it changes to fix this issue. Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") Cc: st

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix testpmd doesn't show RSS hash offload

2021-07-14 Thread Li, Xiaoyun
Hi > -Original Message- > From: stable On Behalf Of Li, Xiaoyun > Sent: Thursday, July 15, 2021 10:30 > To: Wang, Jie1X ; dev@dpdk.org > Cc: andrew.rybche...@oktetlabs.ru; sta...@dpdk.org > Subject: Re: [dpdk-stable] [PATCH v2] app/testpmd: fix testpmd doesn't show > RSS hash offload > >

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix testpmd doesn't show RSS hash offload

2021-07-14 Thread Li, Xiaoyun
Hi > -Original Message- > From: Wang, Jie1X > Sent: Wednesday, July 14, 2021 01:04 > To: dev@dpdk.org > Cc: Li, Xiaoyun ; andrew.rybche...@oktetlabs.ru; Wang, > Jie1X ; sta...@dpdk.org > Subject: [PATCH v2] app/testpmd: fix testpmd doesn't show RSS hash offload > > This patch reapply Rx/

Re: [dpdk-dev] [PATCH v1] app/testpmd: fix port MAC address after resetting port

2021-07-14 Thread Li, Xiaoyun
> -Original Message- > From: Zhang, Yuying > Sent: Wednesday, July 14, 2021 10:20 > To: dev@dpdk.org; Li, Xiaoyun ; Zhang, Qi Z > > Cc: Zhang, Yuying ; sta...@dpdk.org > Subject: [PATCH v1] app/testpmd: fix port MAC address after resetting port > > MAC address of each port in global vari

[dpdk-dev] [PATCH v1] net/ice: fix not clear bandwidth correctly when DCF close

2021-07-14 Thread Ting Xu
When closing DCF, the bandwidth limit configured for VFs by DCF is not cleared correctly. The configuration will still take effect when DCF starts again, if VFs are not re-allocated. This patch cleared VFs bandwidth limit when DCF closes, and DCF needs to re-configure bandwidth for VFs when it star

[dpdk-dev] [PATCH v1] net/iavf: fix wrong bandwidth unit in TM capability querying

2021-07-14 Thread Ting Xu
In IAVF node TM capability querying, the unit of bandwidth is Kbps, which is not correct according to TM specification. Change the unit to Byte per second. Refine some unclear comments as well. Fixes: 44d0a720a538 ("net/iavf: query QoS capabilities and set queue TC mapping") Cc: sta...@dpdk.org

Re: [dpdk-dev] [PATCH v2 1/1] test/power: fix CPU frequency check

2021-07-14 Thread Richael Zhuang
> -Original Message- > From: David Hunt > Sent: Wednesday, July 14, 2021 8:23 PM > To: Richael Zhuang ; dev@dpdk.org > Cc: zhiminx.hu...@intel.com; sta...@dpdk.org > Subject: Re: [PATCH v2 1/1] test/power: fix CPU frequency check > > Hi Richael, > > On 14/7/2021 11:44 AM, Richael Zhuan

Re: [dpdk-dev] [PATCH v3] net/softnic: fix memory leak in parsing arguments

2021-07-14 Thread Yu, DapengX
> -Original Message- > From: Singh, Jasvinder > Sent: Wednesday, July 14, 2021 7:08 PM > To: Yu, DapengX ; Dumitrescu, Cristian > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH v3] net/softnic: fix memory leak in parsing arguments > > > > > + free(firmware); > > Memory

Re: [dpdk-dev] [PATCH 1/2] security: enforce semantics for Tx inline processing

2021-07-14 Thread Ananyev, Konstantin
> -Original Message- > From: Nithin Dabilpuram > Sent: Wednesday, July 14, 2021 2:30 PM > To: Ananyev, Konstantin > Cc: Akhil Goyal ; dev@dpdk.org; hemant.agra...@nxp.com; > tho...@monjalon.net; g.si...@nxp.com; Yigit, Ferruh > ; Zhang, Roy Fan ; > olivier.m...@6wind.com; jer...@marv

[dpdk-dev] [PATCH v4] guides: add a guide for developing unit tests

2021-07-14 Thread Aaron Conole
The DPDK testing infrastructure includes a comprehensive set of libraries, utilities, and CI integrations for developers to test their code changes. This isn't well documented, however. Document the basics for adding a test suite to the infrastructure and enabling that test suite for continuous i

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-14 Thread Bruce Richardson
On Tue, Jul 13, 2021 at 08:27:43PM +0800, Chengwen Feng wrote: > This patch introduce 'dmadevice' which is a generic type of DMA > device. > > The APIs of dmadev library exposes some generic operations which can > enable configuration and I/O with the DMA devices. > > Signed-off-by: Chengwen Feng

[dpdk-dev] Minutes of Technical Board Meeting, 2021-06-16

2021-07-14 Thread Thomas Monjalon
Members Attending: 12/12 - Aaron Conole - Bruce Richardson - Ferruh Yigit - Hemant Agrawal - Honnappa Nagarahalli - Jerin Jacob - Kevin Traynor - Konstantin Ananyev - Maxime Coquelin - Olivier Matz - Stephen Hem

[dpdk-dev] Minutes of Technical Board Meeting, 2021-06-30

2021-07-14 Thread Aaron Conole
Attendees - * Aaron * Bruce * Ferruh * Hemant * Honnappa * Jerin * Kevin * Konstantin * Lincoln Lavioe (UNH representative) * Maxime * Olivier * Stephen * Thomas NOTE: The technical board meets every second Wednesday at https://meet.jit.si/DPDK at 3 pm UTC. Meetings are public, and DPDK co

Re: [dpdk-dev] [PATCH v2] add testing requirement for new PMDs

2021-07-14 Thread Thomas Monjalon
04/07/2021 17:47, Andrew Rybchenko: > On 7/1/21 9:49 AM, Mcnamara, John wrote: > > From: Yigit, Ferruh > >> As discussed in the technical board meeting > >> https://mails.dpdk.org/archives/dev/2021-February/200012.html > >> > >> This is to record that new upstreamed devices tested adequately. > >

Re: [dpdk-dev] [PATCH 3/3] net/bonding: start ethdev prior to setting 8023ad flow

2021-07-14 Thread Jan Viktorin
On Tue, 13 Jul 2021 17:17:51 + Ori Kam wrote: > Hi Jan, > > > -Original Message- > > From: Jan Viktorin > > Sent: Tuesday, July 13, 2021 2:06 PM > > > > On Tue, 13 Jul 2021 12:26:35 +0300 > > Andrew Rybchenko wrote: > > > > > On 7/13/21 11:18 AM, Havlík Martin wrote: > > > >

Re: [dpdk-dev] [PATCH] ethdev: avoid unregistering a non-allocated callback

2021-07-14 Thread Thomas Monjalon
14/07/2021 16:16, Matan Azrad: > From: Thomas Monjalon > > 13/07/2021 15:42, Matan Azrad: > > > From: Thomas Monjalon > > > > When registering a new event callback, if allocation fails, there is > > > > no need for unregistering the callback, because it is not registered. > > > > > > > > Fixes: 9ec

Re: [dpdk-dev] [PATCH] ethdev: avoid unregistering a non-allocated callback

2021-07-14 Thread Matan Azrad
From: Thomas Monjalon > 13/07/2021 15:42, Matan Azrad: > > Hi Thomas > > > > From: Thomas Monjalon > > > When registering a new event callback, if allocation fails, there is > > > no need for unregistering the callback, because it is not registered. > > > > > > Fixes: 9ec0b3869d8d ("ethdev: allo

[dpdk-dev] [PATCH] eal: add rte_exit() main lcore limitation description

2021-07-14 Thread Suanming Mou
Currently, rte_eal_mp_wait_lcore() function will be called by rte_exit() as the routine below: rte_exit() -> rte_eal_cleanup() -> rte_service_finalize() -> rte_eal_mp_wait_lcore() As rte_eal_mp_wait_lcore() is announced can only be called from main lcore, rte_exit() gets the limitation implicitly

Re: [dpdk-dev] [PATCH 1/2] security: enforce semantics for Tx inline processing

2021-07-14 Thread Nithin Dabilpuram
On Wed, Jul 14, 2021 at 11:09:08AM +, Ananyev, Konstantin wrote: > > > > > > > > Adding more rte_security and PMD maintainers into the loop. > > > > > > > > > > > > > > > > > > > For Tx inline processing, when > > > > > > > > > > > > > > > RTE_SECURITY_TX_OLOAD_NEED_MDATA is > > > > > > > > >

Re: [dpdk-dev] [PATCH v2 1/1] test/power: fix CPU frequency check

2021-07-14 Thread David Hunt
Hi Richael, On 14/7/2021 11:44 AM, Richael Zhuang wrote: For acpi_cpufreq and cppc_cpufreq, both cpuinfo_cur_freq and scaling_cur_freq exist. For pstate, only scaling_cur_freq exists. And value in scaling_cur_freq and cpuinfo_cur_freq may not be the same. For acpi_cpufreq and cppc_cpufreq, we sh

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-14 Thread Nipun Gupta
> +/** > + * A structure used to configure a virtual DMA channel. > + */ > +struct rte_dmadev_vchan_conf { > + uint8_t direction; > + /**< Set of supported transfer directions > + * @see RTE_DMA_MEM_TO_MEM > + * @see RTE_DMA_MEM_TO_DEV > + * @see RTE_DMA_DEV_TO_MEM > +

Re: [dpdk-dev] [PATCH 5/6] net/ena: rework RSS configuration

2021-07-14 Thread Michał Krawczyk
śr., 14 lip 2021 o 13:43 Vladimir Medvedkin napisał(a): > > Great, thanks! > > BTW, you can check with a given hash_key if the rss hash value calculated by > the NIC and by the rte_softrss() are the same. > I already verified it with a script using standard Teoplitz implementation with the key u

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix threshold for mbuf replenishment in MPRQ

2021-07-14 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Tuesday, July 13, 2021 6:21 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Matan Azrad > ; Slava Ovsiienko ; > sta...@dpdk.org > Subject: [PATCH v2] net/mlx5: fix threshold for mbuf replenishment in MPRQ > > The replenishment sch

Re: [dpdk-dev] [PATCH v2 0/8] use GCC's C11 atomic builtins for test

2021-07-14 Thread Thomas Monjalon
13/07/2021 09:28, Joyce Kong: > Hi David, > > Since we have some discussion about the atomic operations now, I changed the > commit message from "C11 atomics"(which has been widely used in previous > commit) to "GCC atomic built-ins". > What's your opinion about whether keeping the previous mess

Re: [dpdk-dev] [PATCH v1] app/testpmd: fix port MAC address after resetting port

2021-07-14 Thread Singh, Aman Deep
Hi Yuying, On 7/14/2021 7:50 AM, Yuying Zhang wrote: MAC address of each port in global variable ports hasn't been updated after resetting. It was the initial one after resetting VF MAC address. This patch gets correct port MAC address when starting port. Fixes: a5279d25616d ("app/testpmd: chec

Re: [dpdk-dev] [PATCH 5/6] net/ena: rework RSS configuration

2021-07-14 Thread Vladimir Medvedkin
Great, thanks! BTW, you can check with a given hash_key if the rss hash value calculated by the NIC and by the rte_softrss() are the same. ср, 14 июл. 2021 г. в 11:21, Michał Krawczyk : > śr., 14 lip 2021 o 10:04 Vladimir Medvedkin > napisał(a): > > > > Hi Michal, > > > > вт, 13 июл. 2021 г. в

Re: [dpdk-dev] [PATCH] ethdev: avoid unregistering a non-allocated callback

2021-07-14 Thread Thomas Monjalon
13/07/2021 15:42, Matan Azrad: > Hi Thomas > > From: Thomas Monjalon > > When registering a new event callback, if allocation fails, there is no > > need for > > unregistering the callback, because it is not registered. > > > > Fixes: 9ec0b3869d8d ("ethdev: allow event registration for all ports

[dpdk-dev] [PATCH] common/cpt: allocate auth key mem dynamically

2021-07-14 Thread Anoob Joseph
Reduce session private data size by allocating auth_key dynamically as required. Added auth_key_iova to eliminate any impact on fastpath. Signed-off-by: Anoob Joseph --- drivers/common/cpt/cpt_mcode_defines.h | 3 ++- drivers/common/cpt/cpt_ucode.h | 10 +

Re: [dpdk-dev] [PATCH] net/softnic: fix memory leak as profile is freed

2021-07-14 Thread Singh, Jasvinder
> -Original Message- > From: Yu, DapengX > Sent: Tuesday, July 13, 2021 9:27 AM > To: Singh, Jasvinder ; Dumitrescu, Cristian > > Cc: dev@dpdk.org; Yu, DapengX ; sta...@dpdk.org > Subject: [PATCH] net/softnic: fix memory leak as profile is freed > > From: Dapeng Yu > > In function s

Re: [dpdk-dev] [PATCH 1/2] security: enforce semantics for Tx inline processing

2021-07-14 Thread Ananyev, Konstantin
> > > > > > Adding more rte_security and PMD maintainers into the loop. > > > > > > > > > > > > > > > > > For Tx inline processing, when > > > > > > > > > > > > > > RTE_SECURITY_TX_OLOAD_NEED_MDATA is > > > > > > > > > > > > > > set, rte_security_set_pkt_metadata() needs to be > > > > > > > > > >

Re: [dpdk-dev] [PATCH v3] net/softnic: fix memory leak in parsing arguments

2021-07-14 Thread Singh, Jasvinder
> + free(firmware); Memory for firmware is not allocated dynamically, so no need for this. > struct pmd_params { > - const char *name; > - const char *firmware; > + char name[RTE_DEV_NAME_MAX_LEN]; Please replace " RTE_DEV_NAME_MAX_LEN " with "NAME_SIZE" which is already de

[dpdk-dev] [PATCH v2 1/1] test/power: fix CPU frequency check

2021-07-14 Thread Richael Zhuang
For acpi_cpufreq and cppc_cpufreq, both cpuinfo_cur_freq and scaling_cur_freq exist. For pstate, only scaling_cur_freq exists. And value in scaling_cur_freq and cpuinfo_cur_freq may not be the same. For acpi_cpufreq and cppc_cpufreq, we should check cpuinfo_cur_freq but not scaling_cur_freq. So her

[dpdk-dev] [PATCH v2 0/1] test/power: fix CPU frequency check

2021-07-14 Thread Richael Zhuang
v1: fix CPU frequency check v2: add rounding for pstate driver Richael Zhuang (1): test/power: fix CPU frequency check app/test/test_power_cpufreq.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.20.1

[dpdk-dev] [PATCH v3 6/6] net/ena: update version to v2.4.0

2021-07-14 Thread Michal Krawczyk
This version update contains: * Rx interrupts feature, * Support for the RSS hash function reconfiguration, * Small rework of the works, * Reset trigger on Tx path fix. Signed-off-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[dpdk-dev] [PATCH v3 5/6] net/ena: rework RSS configuration

2021-07-14 Thread Michal Krawczyk
Allow user to specify his own hash key and hash ctrl if the device is supporting that. HW interprets the key in reverse byte order, so the PMD reorders the key before passing it to the ena_com layer. Default key is being set in random matter each time the device is being initialized. Moreover, ma

[dpdk-dev] [PATCH v3 4/6] net/ena: add support for Rx interrupts

2021-07-14 Thread Michal Krawczyk
In order to support asynchronous Rx in the applications, the driver has to configure the event file descriptors and configure the HW. This patch configures appropriate data structures for the rte_ethdev layer, adds .rx_queue_intr_enable and .rx_queue_intr_disable API handlers, and configures IO qu

[dpdk-dev] [PATCH v3 3/6] net/ena: trigger reset when Tx prepare fails

2021-07-14 Thread Michal Krawczyk
If the prepare function failed, then it means the descriptors are in the invalid state. This condition now triggers the reset, which should be further handled by the application. To notify the application about prepare function failure, the error log was added. In general, it should never fail in

[dpdk-dev] [PATCH v3 2/6] net/ena: make use of the IO debug build option

2021-07-14 Thread Michal Krawczyk
ENA defined its own logger flags for Tx and Rx, but they weren't technically used anywhere. Those data path loggers weren't used anywhere after the definition. This commit uses the generic RTE_ETHDEV_DEBUG_RX and RTE_ETHDEV_DEBUG_TX flags to define PMD_TX_LOG and PMD_RX_LOG which are now being use

[dpdk-dev] [PATCH v3 1/6] net/ena: adjust driver logs

2021-07-14 Thread Michal Krawczyk
ENA logs were not consistent regarding the new line character. Few of them were relying on the new line character added by the PMD_*_LOG macros, but most were adding the new line character by themselves. It was causing ENA logs to add extra empty line after almost each log. To unify this behavior,

[dpdk-dev] [PATCH v3 0/6] net/ena: v2.4.0 driver update

2021-07-14 Thread Michal Krawczyk
Hi, this set contains 2 major ENA features: * RSS hash function key and reconfiguration - API for changing hf was also introduced, although it's not supported in the device right now. * Rx interrupts support. Moreover support for the RTE_ETHDEV_DEBUG_[TR]X flags introduced in v21.05 was added

[dpdk-dev] [PATCH v2 6/6] net/ena: update version to v2.4.0

2021-07-14 Thread Michal Krawczyk
This version update contains: * Rx interrupts feature, * Support for the RSS hash function reconfiguration, * Small rework of the works, * Reset trigger on Tx path fix. Signed-off-by: Michal Krawczyk Change-Id: I66798cdbe5b980eab7e11b036eed256e27f80e8a --- drivers/net/ena/ena_ethdev.c |

[dpdk-dev] [PATCH v2 5/6] net/ena: rework RSS configuration

2021-07-14 Thread Michal Krawczyk
Allow user to specify his own hash key and hash ctrl if the device is supporting that. HW interprets the key in reverse byte order, so the PMD reorders the key before passing it to the ena_com layer. Default key is being set in random matter each time the device is being initialized. Moreover, ma

[dpdk-dev] [PATCH v2 4/6] net/ena: add support for Rx interrupts

2021-07-14 Thread Michal Krawczyk
In order to support asynchronous Rx in the applications, the driver has to configure the event file descriptors and configure the HW. This patch configures appropriate data structures for the rte_ethdev layer, adds .rx_queue_intr_enable and .rx_queue_intr_disable API handlers, and configures IO qu

[dpdk-dev] [PATCH v2 3/6] net/ena: trigger reset when Tx prepare fails

2021-07-14 Thread Michal Krawczyk
If the prepare function failed, then it means the descriptors are in the invalid state. This condition now triggers the reset, which should be further handled by the application. To notify the application about prepare function failure, the error log was added. In general, it should never fail in

[dpdk-dev] [PATCH v2 2/6] net/ena: make use of the IO debug build option

2021-07-14 Thread Michal Krawczyk
ENA defined its own logger flags for Tx and Rx, but they weren't technically used anywhere. Those data path loggers weren't used anywhere after the definition. This commit uses the generic RTE_ETHDEV_DEBUG_RX and RTE_ETHDEV_DEBUG_TX flags to define PMD_TX_LOG and PMD_RX_LOG which are now being use

[dpdk-dev] [PATCH v2 1/6] net/ena: adjust driver logs

2021-07-14 Thread Michal Krawczyk
ENA logs were not consistent regarding the new line character. Few of them were relying on the new line character added by the PMD_*_LOG macros, but most were adding the new line character by themselves. It was causing ENA logs to add extra empty line after almost each log. To unify this behavior,

[dpdk-dev] [PATCH v2 0/6] net/ena: v2.4.0 driver update

2021-07-14 Thread Michal Krawczyk
Hi, this set contains 2 major ENA features: * RSS hash function key and reconfiguration - API for changing hf was also introduced, although it's not supported in the device right now. * Rx interrupts support. Moreover support for the RTE_ETHDEV_DEBUG_[TR]X flags introduced in v21.05 was added

Re: [dpdk-dev] [PATCH v1 1/1] test/power: check cpuinfo cur freq before scaling cur freq

2021-07-14 Thread Richael Zhuang
> -Original Message- > From: David Hunt > Sent: Wednesday, July 14, 2021 6:14 PM > To: Richael Zhuang ; dev@dpdk.org > Cc: zhiminx.hu...@intel.com; sta...@dpdk.org; nd > Subject: Re: [PATCH v1 1/1] test/power: check cpuinfo cur freq before scaling > cur freq > > > On 14/7/2021 10:23 A

Re: [dpdk-dev] [PATCH v1 1/1] test/power: check cpuinfo cur freq before scaling cur freq

2021-07-14 Thread David Hunt
On 14/7/2021 10:23 AM, Richael Zhuang wrote: -Original Message- From: David Hunt Sent: Wednesday, July 14, 2021 5:15 PM To: Richael Zhuang ; dev@dpdk.org Cc: zhiminx.hu...@intel.com; sta...@dpdk.org Subject: Re: [PATCH v1 1/1] test/power: check cpuinfo cur freq before scaling cur fre

Re: [dpdk-dev] [PATCH] net/ena: enable multi segment in Tx offload flags

2021-07-14 Thread Michał Krawczyk
pon., 12 lip 2021 o 19:03 Ghalem Boudour napisał(a): > > The DPDK ENA driver does not provide multi-segment tx offload capability. > Let's add DEV_TX_OFFLOAD_MULTI_SEGS to ports offload capability by default. > Hi Ghalem, This patch enables announcement of the DEV_TX_OFFLOAD_MULTI_SEGS capabilit

[dpdk-dev] [PATCH] net/af_packet: run on kernels without qdisc bypass support

2021-07-14 Thread Tudor Cornea
Some older kernels do not support the PACKET_QDISC_BYPASS socket option. Such an example is the CentOS 7 kernel (3.10). If we only check for the definition of PACKET_QDISC_BYPASS, it might mean that we will not be able to compile the PMD driver on a newer platform, and run in on a machine with an

Re: [dpdk-dev] [PATCH v3] config/arm: split march cfg into arch and features

2021-07-14 Thread Ruifeng Wang
+Pavan Hi Chengwen, Pavan, You had patches to add ability of picking supported march/extension. Can you help to review this patch and see if the generic infrastructure fulfills your needs? Regards. Ruifeng > -Original Message- > From: Juraj Linkeš > Sent: Monday, July 12, 2021 9:02 P

Re: [dpdk-dev] [PATCH v1 1/1] test/power: check cpuinfo cur freq before scaling cur freq

2021-07-14 Thread Richael Zhuang
> -Original Message- > From: David Hunt > Sent: Wednesday, July 14, 2021 5:15 PM > To: Richael Zhuang ; dev@dpdk.org > Cc: zhiminx.hu...@intel.com; sta...@dpdk.org > Subject: Re: [PATCH v1 1/1] test/power: check cpuinfo cur freq before scaling > cur freq > > > On 14/7/2021 9:44 AM, Ric

[dpdk-dev] [PATCH v3 5/5] doc: update doc for try drain API in vhost lib

2021-07-14 Thread Cheng Jiang
update the program guide and release notes for try drain API in vhost lib. Signed-off-by: Cheng Jiang --- doc/guides/prog_guide/vhost_lib.rst| 5 + doc/guides/rel_notes/release_21_08.rst | 5 + 2 files changed, 10 insertions(+) diff --git a/doc/guides/prog_guide/vhost_lib.rst b/doc

[dpdk-dev] [PATCH v3 4/5] examples/vhost: handle memory hotplug for async vhost

2021-07-14 Thread Cheng Jiang
When the guest memory is hotplugged, the vhost application which enables DMA acceleration must stop DMA transfers before the vhost re-maps the guest memory. To accomplish that, we need to do these changes in the vhost sample: 1. add inflight pkt count. 2. add vring_state_changed() callback. 3. add

[dpdk-dev] [PATCH v3 3/5] vhost: handle memory hotplug for async vhost

2021-07-14 Thread Cheng Jiang
From: Jiayu Hu When the guest memory is hotplugged, the vhost application which enables DMA acceleration must stop DMA transfers before the vhost re-maps the guest memory. This patch is to notify the vhost application of stopping DMA transfers. Signed-off-by: Jiayu Hu --- lib/vhost/vhost_user

[dpdk-dev] [PATCH v3 2/5] vhost: add unsafe API to drain pkts in async vhost

2021-07-14 Thread Cheng Jiang
Applications need to stop DMA transfers and finish all the in-flight pkts when in VM memory hot-plug case and async vhost is used. This patch is to provide an unsafe API to drain in-flight pkts which are submitted to DMA engine in vhost async data path. Signed-off-by: Cheng Jiang --- lib/vhost/r

[dpdk-dev] [PATCH v3 1/5] vhost: fix async vhost ops return type

2021-07-14 Thread Cheng Jiang
The async vhost ops callback should return -1 when there are something wrong in the callback, so the return type should be changed into int32_t. The issue in vhost example is also fixed in this patch. Signed-off-by: Cheng Jiang --- examples/vhost/ioat.c | 4 +-- examples/vhost/ioat.h

[dpdk-dev] [PATCH v3 0/5] vhost: handle memory hotplug for async vhost

2021-07-14 Thread Cheng Jiang
When the guest memory is hotplugged, the vhost application which enables DMA acceleration must stop DMA transfers before the vhost re-maps the guest memory. This patch set is to provide an unsafe API to drain in-flight pkts which are submitted to DMA engine in vhost async data path, and notify the

Re: [dpdk-dev] [PATCH v1 1/1] test/power: check cpuinfo cur freq before scaling cur freq

2021-07-14 Thread David Hunt
On 14/7/2021 9:44 AM, Richael Zhuang wrote: For acpi_cpufreq and cppc_cpufreq, both cpuinfo_cur_freq and scaling_cur_freq exist. For pstate, only scaling_cur_freq exists. And value in scaling_cur_freq and cpuinfo_cur_freq may not be the same. For acpi_cpufreq and cppc_cpufreq, we should check c

[dpdk-dev] [PATCH v9 7/7] event/cnxk: add Tx event vector fastpath

2021-07-14 Thread pbhagavatula
From: Pavan Nikhilesh Add Tx event vector fastpath, integrate event vector Tx routine into Tx burst. Signed-off-by: Pavan Nikhilesh --- drivers/common/cnxk/roc_sso.h| 23 ++ drivers/event/cnxk/cn10k_eventdev.c | 3 +- drivers/event/cnxk/cn10k_worker.h| 104 +

[dpdk-dev] [PATCH v9 6/7] event/cnxk: add Rx event vector fastpath

2021-07-14 Thread pbhagavatula
From: Pavan Nikhilesh Add Rx event vector fastpath to convert HW defined metadata into rte_mbuf and rte_event_vector. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_worker.h| 56 drivers/net/cnxk/cn10k_rx.h | 200 --- drivers/net/cnxk

[dpdk-dev] [PATCH v9 5/7] event/cnxk: add Rx adapter vector support

2021-07-14 Thread pbhagavatula
From: Pavan Nikhilesh Add event vector support for cnxk event Rx adapter, add control path APIs to get vector limits and ability to configure event vectorization on a given Rx queue. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 106 ++- driv

[dpdk-dev] [PATCH v9 4/7] event/cnxk: add Tx adapter fastpath ops

2021-07-14 Thread pbhagavatula
From: Pavan Nikhilesh Add support for event eth Tx adapter fastpath operations. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 38 drivers/event/cnxk/cn10k_worker.h | 67 + drivers/event/cnxk/cn10k_worker_tx_enq.c | 23 +

[dpdk-dev] [PATCH v9 3/7] event/cnxk: add Tx adapter support

2021-07-14 Thread pbhagavatula
From: Pavan Nikhilesh Add support for event eth Tx adapter. Signed-off-by: Pavan Nikhilesh Acked-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix.h| 1 + drivers/common/cnxk/roc_nix_queue.c | 8 +- drivers/event/cnxk/cn10k_eventdev.c | 91 ++ driver

[dpdk-dev] [PATCH v9 2/7] event/cnxk: add Rx adapter fastpath ops

2021-07-14 Thread pbhagavatula
From: Pavan Nikhilesh Add support for event eth Rx adapter fastpath operations. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 136 +++- drivers/event/cnxk/cn10k_worker.c | 54 drivers/event/cnxk/cn10k_worker.h | 97 +-

[dpdk-dev] [PATCH v9 1/7] event/cnxk: add Rx adapter support

2021-07-14 Thread pbhagavatula
From: Pavan Nikhilesh Add support for event eth Rx adapter. Resize cn10k workslot fastpath structure to fit in 64B cacheline size. Signed-off-by: Pavan Nikhilesh --- v9 Changes: - Fix doc compilation. - Remove rte prefix used in base code. v8 Changes: - Fix incorrect cq_w1 offset. - Move

Re: [dpdk-dev] [PATCH 0/2] fix RSS expansion missing items

2021-07-14 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Xiaoyu Min > Sent: Wednesday, July 7, 2021 5:33 AM > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 0/2] fix RSS expansion missing items > > This patch set fixs the missing items in RSS expansion. > > Xiaoyu Min (2): > net/mlx5: fix mis

[dpdk-dev] [PATCH v1 1/1] test/power: check cpuinfo cur freq before scaling cur freq

2021-07-14 Thread Richael Zhuang
For acpi_cpufreq and cppc_cpufreq, both cpuinfo_cur_freq and scaling_cur_freq exist. For pstate, only scaling_cur_freq exists. And value in scaling_cur_freq and cpuinfo_cur_freq may not be the same. For acpi_cpufreq and cppc_cpufreq, we should check cpuinfo_cur_freq. So here checking cpuinfo_cur_fr

[dpdk-dev] [PATCH v1 0/1] test/power: check cpuinfo cur freq before

2021-07-14 Thread Richael Zhuang
v1: fix CPU frequency check Richael Zhuang (1): test/power: check cpuinfo cur freq before scaling cur freq app/test/test_power_cpufreq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.20.1

Re: [dpdk-dev] [PATCH 5/6] net/ena: rework RSS configuration

2021-07-14 Thread Michał Krawczyk
śr., 14 lip 2021 o 10:04 Vladimir Medvedkin napisał(a): > > Hi Michal, > > вт, 13 июл. 2021 г. в 18:42, Michal Krawczyk : >> >> Allow user to specify his own hash key and hash ctrl if the >> device is supporting that. HW interprets the key in reverse byte order, >> so the PMD reorders the key befo

Re: [dpdk-dev] [PATCH 5/6] net/ena: rework RSS configuration

2021-07-14 Thread Vladimir Medvedkin
Hi Michal, вт, 13 июл. 2021 г. в 18:42, Michal Krawczyk : > Allow user to specify his own hash key and hash ctrl if the > device is supporting that. HW interprets the key in reverse byte order, > so the PMD reorders the key before passing it to the ena_com layer. > > Default key is being set in r

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix missing RSS expansion of IPv6 frag

2021-07-14 Thread Raslan Darawsheh
> -Original Message- > From: Jack Min > Sent: Wednesday, July 14, 2021 10:31 AM > To: Raslan Darawsheh > Cc: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko ; Dekel > Peled ; Ori Kam ; dev@dpdk.org; > sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix missing RSS expans

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix missing RSS expansion of IPv6 frag

2021-07-14 Thread Jack Min
On Mon, 21-07-12, 08:05, Raslan Darawsheh wrote: Hey, > Hi, > > > -Original Message- > > From: dev On Behalf Of Xiaoyu Min > > Sent: Wednesday, July 7, 2021 5:33 AM > > To: Matan Azrad ; Shahaf Shuler > > ; Slava Ovsiienko ; Dekel > > Peled ; Ori Kam > > Cc: dev@dpdk.org; sta...@dpdk.or

Re: [dpdk-dev] 19.11.9 patches review and test

2021-07-14 Thread Jiang, YuX
> -Original Message- > From: dev On Behalf Of Christian Ehrhardt > Sent: Monday, July 5, 2021 9:23 PM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Akhil Goyal ; Ali Alnubani ; > Walker, Benjamin ; David Christensen > ; Hemant Agrawal ; > Stokes, Ian ; Jerin Jacob ; > Mcna