Re: [dpdk-dev] [PATCH v4 3/3] vhost: add thread unsafe async registeration functions

2021-07-15 Thread Xia, Chenbo
Hi Jiayu, > -Original Message- > From: Hu, Jiayu > Sent: Tuesday, July 13, 2021 3:46 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; Hu, Jiayu > > Subject: [PATCH v4 3/3] vhost: add thread unsafe async registeration functions > > This patch adds thread unsafe versi

Re: [dpdk-dev] [PATCH v4 2/3] vhost: rework async configuration struct

2021-07-15 Thread Hu, Jiayu
> -Original Message- > From: Xia, Chenbo > Sent: Friday, July 16, 2021 2:28 PM > To: Hu, Jiayu ; dev@dpdk.org > Cc: maxime.coque...@redhat.com > Subject: RE: [PATCH v4 2/3] vhost: rework async configuration struct > > > > > > -vq->async_inorder = f.async_inorder; async_threshold = > >

Re: [dpdk-dev] [PATCH v4 2/3] vhost: rework async configuration struct

2021-07-15 Thread Xia, Chenbo
Hi Jiayu, > -Original Message- > From: Hu, Jiayu > Sent: Friday, July 16, 2021 2:18 PM > To: Xia, Chenbo ; dev@dpdk.org > Cc: maxime.coque...@redhat.com > Subject: RE: [PATCH v4 2/3] vhost: rework async configuration struct > > Thanks Chenbo for your comments. > > Replies are inline. >

Re: [dpdk-dev] [PATCH v4 2/3] vhost: rework async configuration struct

2021-07-15 Thread Hu, Jiayu
Thanks Chenbo for your comments. Replies are inline. > -Original Message- > From: Xia, Chenbo > Sent: Friday, July 16, 2021 2:03 PM > To: Hu, Jiayu ; dev@dpdk.org > Cc: maxime.coque...@redhat.com > Subject: RE: [PATCH v4 2/3] vhost: rework async configuration struct > > Hi Jiayu, > > >

Re: [dpdk-dev] [PATCH v4 2/3] vhost: rework async configuration struct

2021-07-15 Thread Xia, Chenbo
Hi Jiayu, > -Original Message- > From: Hu, Jiayu > Sent: Tuesday, July 13, 2021 3:46 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; Hu, Jiayu > > Subject: [PATCH v4 2/3] vhost: rework async configuration struct Struct -> structure > > This patch reworks the asy

Re: [dpdk-dev] [PATCH v4 1/5] vhost: fix async vhost ops return type

2021-07-15 Thread Jiang, Cheng1
Hi Chenbo, > -Original Message- > From: Xia, Chenbo > Sent: Friday, July 16, 2021 1:37 PM > To: Jiang, Cheng1 ; maxime.coque...@redhat.com > Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX > > Subject: RE: [PATCH v4 1/5] vhost: fix async vhost ops return type > > Hi Cheng, > > > -Origi

Re: [dpdk-dev] [PATCH v4 1/5] vhost: fix async vhost ops return type

2021-07-15 Thread Xia, Chenbo
Hi Cheng, > -Original Message- > From: Jiang, Cheng1 > Sent: Friday, July 16, 2021 10:59 AM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX > ; Jiang, Cheng1 > Subject: [PATCH v4 1/5] vhost: fix async vhost ops return type > > The async vhost

[dpdk-dev] [PATCH] common/cnxk: allocate auth key mem dynamically

2021-07-15 Thread Anoob Joseph
Reduce session private data size by allocating auth_key dynamically as required. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/roc_se.c | 6 +- drivers/common/cnxk/roc_se.h | 2 +- drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 11 +++ drivers/crypto/cnxk/

[dpdk-dev] dpdk-testpmd app with SRIOV VF on Kubernetes POD not working

2021-07-15 Thread Truring Team
Hi Everyone, We have Kubernetes setup where Master Node and one worker node are there and tried running dpdk-testpmd on POD So Master Node and Worker Node are AWS VM which has ixgbevf VF interfaces and binded one interface with dpdk igb_uio then expose the interface inside POD with multus cni

Re: [dpdk-dev] [PATCH v3] config/arm: split march cfg into arch and features

2021-07-15 Thread fengchengwen
[snip] >> + >> +# probe supported marchs and their features >> +candidate_march = '' >> +if part_number_config.has_key('march') >> +supported_marchs = ['armv8.6-a', 'armv8.5-a', 'armv8.4-a', >> 'armv8.3-a', >> +'armv8.2-a', 'armv8.1-a', 'armv8-a']

[dpdk-dev] [PATCH v4 5/5] doc: update doc for try drain API in vhost lib

2021-07-15 Thread Cheng Jiang
update the program guide and release notes for try drain API in vhost lib. Signed-off-by: Cheng Jiang --- doc/guides/prog_guide/vhost_lib.rst| 5 + doc/guides/rel_notes/release_21_08.rst | 5 + 2 files changed, 10 insertions(+) diff --git a/doc/guides/prog_guide/vhost_lib.rst b/doc

[dpdk-dev] [PATCH v4 4/5] examples/vhost: handle memory hotplug for async vhost

2021-07-15 Thread Cheng Jiang
When the guest memory is hotplugged, the vhost application which enables DMA acceleration must stop DMA transfers before the vhost re-maps the guest memory. To accomplish that, we need to do these changes in the vhost sample: 1. add inflight pkt count. 2. add vring_state_changed() callback. 3. add

[dpdk-dev] [PATCH v4 3/5] vhost: handle memory hotplug for async vhost

2021-07-15 Thread Cheng Jiang
From: Jiayu Hu When the guest memory is hotplugged, the vhost application which enables DMA acceleration must stop DMA transfers before the vhost re-maps the guest memory. This patch is to notify the vhost application of stopping DMA transfers. Signed-off-by: Jiayu Hu --- lib/vhost/vhost_user

[dpdk-dev] [PATCH v4 2/5] vhost: add unsafe API to drain pkts in async vhost

2021-07-15 Thread Cheng Jiang
Applications need to stop DMA transfers and finish all the in-flight pkts when in VM memory hot-plug case and async vhost is used. This patch is to provide an unsafe API to drain in-flight pkts which are submitted to DMA engine in vhost async data path. Signed-off-by: Cheng Jiang --- lib/vhost/r

[dpdk-dev] [PATCH v4 1/5] vhost: fix async vhost ops return type

2021-07-15 Thread Cheng Jiang
The async vhost ops callback should return -1 when there are something wrong in the callback, so the return type should be changed into int32_t. The issue in vhost example is also fixed in this patch. Signed-off-by: Cheng Jiang --- examples/vhost/ioat.c | 4 +-- examples/vhost/ioat.h

[dpdk-dev] [PATCH v4 0/5] vhost: handle memory hotplug for async vhost

2021-07-15 Thread Cheng Jiang
When the guest memory is hotplugged, the vhost application which enables DMA acceleration must stop DMA transfers before the vhost re-maps the guest memory. This patch set is to provide an unsafe API to drain in-flight pkts which are submitted to DMA engine in vhost async data path, and notify the

Re: [dpdk-dev] [PATCH v4] dmadev: introduce DMA device library

2021-07-15 Thread fengchengwen
On 2021/7/16 0:33, Bruce Richardson wrote: > On Fri, Jul 16, 2021 at 12:04:33AM +0800, fengchengwen wrote: >> @burce, jerin Some unmodified review comments are returned here: >> [snip] > >> 2. COMMENT: > + * @see struct rte_dmadev_info::dev_capa >>> + */ >> Drop this flag as unnecessary. All d

[dpdk-dev] [PATCH] net/bnxt: update CFA resource types

2021-07-15 Thread Ajit Khaparde
Update cfa_resource_types.h to add a new entry for compatibility with FW. Signed-off-by: Shuanglin Wang Reviewed-by: Randy Schacher Reviewed-by: Ajit Khaparde Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/cfa_resource_types.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(

[dpdk-dev] [PATCH v5] dmadev: introduce DMA device library

2021-07-15 Thread Chengwen Feng
This patch introduce 'dmadevice' which is a generic type of DMA device. The APIs of dmadev library exposes some generic operations which can enable configuration and I/O with the DMA devices. Signed-off-by: Chengwen Feng --- v5: * add doxy-api-* file modify. * use RTE_LOG_REGISTER_DEFAULT. * fix

Re: [dpdk-dev] [PATCH v2] vhost: fix index overflow for packed ring in async vhost

2021-07-15 Thread Xia, Chenbo
> -Original Message- > From: Jiang, Cheng1 > Sent: Thursday, July 15, 2021 5:51 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX > ; Jiang, Cheng1 ; > sta...@dpdk.org > Subject: [PATCH v2] vhost: fix index overflow for packed ring in async vho

[dpdk-dev] [PATCH v2 2/2] net/sfc: improve logging in MAE backend of RTE flow support

2021-07-15 Thread Ivan Malov
Errors detected during parsing of pattern items and actions are reflected by setting RTE error, but the name of the bad element is not disclosed, thus leaving the user to join the dots themselves. Adjust the code to log missing information. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko

[dpdk-dev] [PATCH v2 1/2] net/sfc: extend logging in MAE backend of RTE flow support

2021-07-15 Thread Ivan Malov
Extra log statements will provide more details to the user in the case of errors discovered in the pattern or actions. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_mae.c | 92 +++ 1 file changed, 7

[dpdk-dev] [PATCH v2 0/2] RTE flow support logging improvements

2021-07-15 Thread Ivan Malov
Changes in v2: * [2/2] RTE flow item and action type macros are spelled out in full Ivan Malov (2): net/sfc: extend logging in MAE backend of RTE flow support net/sfc: improve logging in MAE backend of RTE flow support drivers/net/sfc/sfc_flow.c | 34 + drivers/net/sfc/sfc_flow.h |

Re: [dpdk-dev] [PATCH] app/testpmd: remove most uses of rte_eth_devices

2021-07-15 Thread Li, Xiaoyun
> -Original Message- > From: Gributs, Paulis > Sent: Thursday, July 15, 2021 21:20 > To: Li, Xiaoyun ; Yigit, Ferruh > ; > Burakov, Anatoly > Cc: dev@dpdk.org; Gributs, Paulis > Subject: [PATCH] app/testpmd: remove most uses of rte_eth_devices > > This patch removes most uses of the

Re: [dpdk-dev] [PATCH v5 3/4] vhost: support async dequeue for split ring

2021-07-15 Thread Hu, Jiayu
Hi, Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Thursday, July 15, 2021 9:18 PM > To: Hu, Jiayu ; Ma, WenwuX ; > dev@dpdk.org > Cc: Xia, Chenbo ; Jiang, Cheng1 > ; Wang, YuanX > Subject: Re: [PATCH v5 3/4] vhost: support async dequeue for split ring > > > > On 7/14/21

Re: [dpdk-dev] [PATCH v3] eal: allow hugetlbfs sub-directories

2021-07-15 Thread Dmitry Kozlyuk
2021-07-08 11:59 (UTC+0100), John Levon: > get_hugepage_dir() was implemented in such a way that a --huge-dir > option had to exactly match the mountpoint, but there's no reason for > this restriction. Fix the implementation to allow a sub-directory within > a suitable hugetlbfs mountpoint to be sp

[dpdk-dev] DPDK Release Status Meeting 15/07/2021

2021-07-15 Thread Mcnamara, John
Release status meeting minutes {Date} = :Date: 15 July 2021 :toc: .Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens .Participants: * ARM * Debian/Microsoft * Intel * Marvell * Nvidia * Red Hat Release Dates - * `v21.08` dates

[dpdk-dev] [PATCH v8 13/16] crypto/mlx5: add statistic get and reset operations

2021-07-15 Thread Shiri Kuzin
From: Suanming Mou This commit adds mlx5 crypto statistic get and reset operations. Signed-off-by: Suanming Mou Signed-off-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 40 --- 1 file changed, 37 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/

[dpdk-dev] [PATCH v8 14/16] test/crypto: add mlx5 crypto driver

2021-07-15 Thread Shiri Kuzin
In order to test the new mlx5 crypto PMD, the driver is added to the crypto test application. Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad --- app/test/test_cryptodev.c | 7 +++ app/test/test_cryptodev.h | 2 ++ doc/guides/cryptodevs/mlx5.rst | 3 +++ 3 files changed, 12 inser

[dpdk-dev] [PATCH v8 12/16] crypto/mlx5: add enqueue and dequeue operations

2021-07-15 Thread Shiri Kuzin
From: Suanming Mou The crypto operations are done with the WQE set which contains one UMR WQE and one rdma write WQE. Most segments of the WQE set are initialized properly during queue setup, only limited segments are initialized according to the crypto detail in the datapath process. This commi

[dpdk-dev] [PATCH v8 15/16] test/crypto: add data-unit and wrapped vectors

2021-07-15 Thread Shiri Kuzin
The AES-XTS algorithm supports using a wrapped key. In AES-XTS the data-unit defines the data block size to be encrypted\decrypted. Add AES-XTS vectors with a wrapped key. Add a variable stating whether the key is wrapped or not. Add the AES-XTS data-unit. Signed-off-by: Shiri Kuzin Acked-by: Ma

[dpdk-dev] [PATCH v8 16/16] test/crypto: add AES-XTS multi segment OOP tests

2021-07-15 Thread Shiri Kuzin
The AES-XTS algorithm can supports wrapped key and data-unit. The encryption/decryption can be done out of place and using multi segments. Add multi segment and out of place tests to the recently added AES-XTS vectors, which support using data-unit and a wrapped key. Signed-off-by: Shiri Kuzin A

[dpdk-dev] [PATCH v8 09/16] crypto/mlx5: add keytag devarg

2021-07-15 Thread Shiri Kuzin
From: Suanming Mou A keytag is a piece of data encrypted together with a DEK. When a DEK is referenced by an MKEY.bsf through its index, the keytag is also supplied in the BSF as plaintext. The HW will decrypt the DEK (and the attached keytag) and will fail the operation if the keytags don't mat

[dpdk-dev] [PATCH v8 11/16] crypto/mlx5: add WQE set initialization

2021-07-15 Thread Shiri Kuzin
From: Suanming Mou Currently, HW handles the WQEs much faster than the software, Using the constant WQE set layout can initialize most of the WQE segments in advanced, and software only needs to configure very limited segments in datapath. This accelerates the software WQE organize in datapath.

[dpdk-dev] [PATCH v8 10/16] crypto/mlx5: add maximum segments devarg

2021-07-15 Thread Shiri Kuzin
From: Suanming Mou The mlx5 HW crypto operations are done by attaching crypto property to a memory region. Once done, every access to the memory via the crypto-enabled memory region will result with in-line encryption or decryption of the data. As a result, the design choice is to provide two ty

[dpdk-dev] [PATCH v8 08/16] crypto/mlx5: create login object using DevX

2021-07-15 Thread Shiri Kuzin
To work with crypto engines that are marked with wrapped_import_method, a login session is required. A crypto login object needs to be created using DevX. The crypto login object contains: - The credential pointer. - The import_KEK pointer to be used for all secured information

[dpdk-dev] [PATCH v8 05/16] crypto/mlx5: add queue pairs operations

2021-07-15 Thread Shiri Kuzin
The HW queue pairs are a pair of send queue and receive queue of independent work queues packed together in one object for the purpose of transferring data between nodes of a network. Completion Queue is a FIFO queue of completed work requests. In crypto driver we use one QP in loopback in order

[dpdk-dev] [PATCH v8 06/16] crypto/mlx5: add dev stop and start operations

2021-07-15 Thread Shiri Kuzin
Add the dev_start function that is used to start a configured device. Add the dev_stop function that is used to stop a configured device. Both functions set the dev parameter as used and return 0. Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 17 +

[dpdk-dev] [PATCH v8 07/16] crypto/mlx5: add memory region management

2021-07-15 Thread Shiri Kuzin
Mellanox user space drivers don't deal with physical addresses as part of a memory protection mechanism. The device translates the given virtual address to a physical address using the given memory key as an address space identifier. That's why any mbuf virtual address is moved directly to the HW d

[dpdk-dev] [PATCH v8 04/16] crypto/mlx5: add basic operations

2021-07-15 Thread Shiri Kuzin
The basic dev control operations are configure, close and get info. Extended the existing support of configure and close: -mlx5_crypto_dev_configure- function used to configure device. -mlx5_crypto_dev_close- function used to close a configured device. Added config struc

[dpdk-dev] [PATCH v8 00/16] drivers: introduce mlx5 crypto PMD

2021-07-15 Thread Shiri Kuzin
v2: - Add data-path part. v3: - Rebase. v4: - Rebase + Address the following Akhil comments: - Set HW feature flag in the capability patch. - Fix mp object release in session clear. - Some spelling and word missing in doc. - Squash data-unit adjustment to the session operations commit. - Wording:

[dpdk-dev] [PATCH v8 01/16] drivers: introduce mlx5 crypto PMD

2021-07-15 Thread Shiri Kuzin
Add a new PMD for Mellanox devices- crypto PMD. The crypto PMD will be supported starting Nvidia ConnectX6 and BlueField2. The crypto PMD will add the support of encryption and decryption using the AES-XTS symmetric algorithm. The crypto PMD requires rdma-core and uses mlx5 DevX. This patch add

[dpdk-dev] [PATCH v8 03/16] crypto/mlx5: add session operations

2021-07-15 Thread Shiri Kuzin
Sessions are used in symmetric transformations in order to prepare objects and data for packet processing stage. A mlx5 session includes iv_offset, pointer to mlx5_crypto_dek struct, bsf_size, bsf_p_type, block size index, encryption_order and encryption standard. Implement the next session opera

[dpdk-dev] [PATCH v8 02/16] crypto/mlx5: add DEK object management

2021-07-15 Thread Shiri Kuzin
A DEK(Data encryption Key) is an mlx5 HW object which represents the cipher algorithm key. The DEKs are used during data encryption/decryption operations. In symmetric algorithms like AES-STS, we use the same DEK for both encryption and decryption. Use the mlx5 hash-list tool to manage the DEK ob

[dpdk-dev] [PATCH v7 14/16] test/crypto: add mlx5 crypto driver

2021-07-15 Thread Shiri Kuzin
In order to test the new mlx5 crypto PMD, the driver is added to the crypto test application. Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad --- app/test/test_cryptodev.c | 7 +++ app/test/test_cryptodev.h | 2 ++ doc/guides/cryptodevs/mlx5.rst | 3 +++ 3 files changed, 12 inser

[dpdk-dev] [PATCH v7 15/16] test/crypto: add data-unit and wrapped vectors

2021-07-15 Thread Shiri Kuzin
The AES-XTS algorithm supports using a wrapped key. In AES-XTS the data-unit defines the data block size to be encrypted\decrypted. Add AES-XTS vectors with a wrapped key. Add a variable stating whether the key is wrapped or not. Add the AES-XTS data-unit. Signed-off-by: Shiri Kuzin Acked-by: Ma

[dpdk-dev] [PATCH v7 11/16] crypto/mlx5: add WQE set initialization

2021-07-15 Thread Shiri Kuzin
From: Suanming Mou Currently, HW handles the WQEs much faster than the software, Using the constant WQE set layout can initialize most of the WQE segments in advanced, and software only needs to configure very limited segments in datapath. This accelerates the software WQE organize in datapath.

[dpdk-dev] [PATCH v7 13/16] crypto/mlx5: add statistic get and reset operations

2021-07-15 Thread Shiri Kuzin
From: Suanming Mou This commit adds mlx5 crypto statistic get and reset operations. Signed-off-by: Suanming Mou Signed-off-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 40 --- 1 file changed, 37 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/

[dpdk-dev] [PATCH v7 16/16] test/crypto: add AES-XTS multi segment OOP tests

2021-07-15 Thread Shiri Kuzin
The AES-XTS algorithm can supports wrapped key and data-unit. The encryption/decryption can be done out of place and using multi segments. Add multi segment and out of place tests to the recently added AES-XTS vectors, which support using data-unit and a wrapped key. Signed-off-by: Shiri Kuzin A

[dpdk-dev] [PATCH v7 08/16] crypto/mlx5: create login object using DevX

2021-07-15 Thread Shiri Kuzin
To work with crypto engines that are marked with wrapped_import_method, a login session is required. A crypto login object needs to be created using DevX. The crypto login object contains: - The credential pointer. - The import_KEK pointer to be used for all secured information

[dpdk-dev] [PATCH v7 12/16] crypto/mlx5: add enqueue and dequeue operations

2021-07-15 Thread Shiri Kuzin
From: Suanming Mou The crypto operations are done with the WQE set which contains one UMR WQE and one rdma write WQE. Most segments of the WQE set are initialized properly during queue setup, only limited segments are initialized according to the crypto detail in the datapath process. This commi

[dpdk-dev] [PATCH v7 10/16] crypto/mlx5: add maximum segments devarg

2021-07-15 Thread Shiri Kuzin
From: Suanming Mou The mlx5 HW crypto operations are done by attaching crypto property to a memory region. Once done, every access to the memory via the crypto-enabled memory region will result with in-line encryption or decryption of the data. As a result, the design choice is to provide two ty

[dpdk-dev] [PATCH v7 09/16] crypto/mlx5: add keytag devarg

2021-07-15 Thread Shiri Kuzin
From: Suanming Mou A keytag is a piece of data encrypted together with a DEK. When a DEK is referenced by an MKEY.bsf through its index, the keytag is also supplied in the BSF as plaintext. The HW will decrypt the DEK (and the attached keytag) and will fail the operation if the keytags don't mat

[dpdk-dev] [PATCH v7 06/16] crypto/mlx5: add dev stop and start operations

2021-07-15 Thread Shiri Kuzin
Add the dev_start function that is used to start a configured device. Add the dev_stop function that is used to stop a configured device. Both functions set the dev parameter as used and return 0. Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 17 +

[dpdk-dev] [PATCH v7 07/16] crypto/mlx5: add memory region management

2021-07-15 Thread Shiri Kuzin
Mellanox user space drivers don't deal with physical addresses as part of a memory protection mechanism. The device translates the given virtual address to a physical address using the given memory key as an address space identifier. That's why any mbuf virtual address is moved directly to the HW d

[dpdk-dev] [PATCH v7 04/16] crypto/mlx5: add basic operations

2021-07-15 Thread Shiri Kuzin
The basic dev control operations are configure, close and get info. Extended the existing support of configure and close: -mlx5_crypto_dev_configure- function used to configure device. -mlx5_crypto_dev_close- function used to close a configured device. Added config struc

[dpdk-dev] [PATCH v7 03/16] crypto/mlx5: add session operations

2021-07-15 Thread Shiri Kuzin
Sessions are used in symmetric transformations in order to prepare objects and data for packet processing stage. A mlx5 session includes iv_offset, pointer to mlx5_crypto_dek struct, bsf_size, bsf_p_type, block size index, encryption_order and encryption standard. Implement the next session opera

[dpdk-dev] [PATCH v7 01/16] drivers: introduce mlx5 crypto PMD

2021-07-15 Thread Shiri Kuzin
Add a new PMD for Mellanox devices- crypto PMD. The crypto PMD will be supported starting Nvidia ConnectX6 and BlueField2. The crypto PMD will add the support of encryption and decryption using the AES-XTS symmetric algorithm. The crypto PMD requires rdma-core and uses mlx5 DevX. This patch add

[dpdk-dev] [PATCH v7 05/16] crypto/mlx5: add queue pairs operations

2021-07-15 Thread Shiri Kuzin
The HW queue pairs are a pair of send queue and receive queue of independent work queues packed together in one object for the purpose of transferring data between nodes of a network. Completion Queue is a FIFO queue of completed work requests. In crypto driver we use one QP in loopback in order

[dpdk-dev] [PATCH v7 02/16] crypto/mlx5: add DEK object management

2021-07-15 Thread Shiri Kuzin
A DEK(Data encryption Key) is an mlx5 HW object which represents the cipher algorithm key. The DEKs are used during data encryption/decryption operations. In symmetric algorithms like AES-STS, we use the same DEK for both encryption and decryption. Use the mlx5 hash-list tool to manage the DEK ob

[dpdk-dev] [PATCH v7 00/16] drivers: introduce mlx5 crypto PMD

2021-07-15 Thread Shiri Kuzin
Add a new PMD for Nvidia devices- crypto PMD. The crypto PMD will be supported on Nvidia ConnectX6. The crypto PMD will add the support of encryption and decryption using the AES-XTS symmetric algorithm. The crypto PMD requires rdma-core and uses mlx5 DevX. v2: - Add data-path part. v3: - Rebase.

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: avoid unbind step to enable switchdev mode

2021-07-15 Thread Raslan Darawsheh
Hi, Can you kindly update on the status of this series? Kindest regards, Raslan Darawsheh > -Original Message- > From: dev On Behalf Of Jan Viktorin > Sent: Monday, March 15, 2021 5:34 PM > To: dev@dpdk.org > Cc: Jan Viktorin ; Asaf Penso ; > Shahaf Shuler ; Slava Ovsiienko > ; Matan Az

Re: [dpdk-dev] [PATCH] mlx5: fix typing error

2021-07-15 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Sarosh Arif > Sent: Tuesday, June 8, 2021 2:09 PM > To: dev@dpdk.org > Cc: Sarosh Arif > Subject: [dpdk-dev] [PATCH] mlx5: fix typing error > > change returing to returning. > > Signed-off-by: Sarosh Arif Patch applied to next-net-mlx

Re: [dpdk-dev] [PATCH v4 19/20] net/sfc: support flow action COUNT in transfer rules

2021-07-15 Thread Ivan Malov
Hi, On 15/07/2021 17:58, David Marchand wrote: On Fri, Jul 2, 2021 at 10:41 AM Andrew Rybchenko wrote: diff --git a/doc/guides/nics/sfc_efx.rst b/doc/guides/nics/sfc_efx.rst index cf1269cc03..bd08118da7 100644 --- a/doc/guides/nics/sfc_efx.rst +++ b/doc/guides/nics/sfc_efx.rst @@ -240,6 +240,8

[dpdk-dev] [Bug 756] performance-thread example fails to build on Alpine linux

2021-07-15 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=756 Bug ID: 756 Summary: performance-thread example fails to build on Alpine linux Product: DPDK Version: 21.08 Hardware: All OS: All Status: UNCONFIRMED

Re: [dpdk-dev] [PATCH v4] dmadev: introduce DMA device library

2021-07-15 Thread Bruce Richardson
On Fri, Jul 16, 2021 at 12:04:33AM +0800, fengchengwen wrote: > @burce, jerin Some unmodified review comments are returned here: > > 1. > COMMENT: > + memset(dmadev_shared_data->data, 0, > > + sizeof(dmadev_shared_data->data)); > I believe all memzones ar

Re: [dpdk-dev] [PATCH v4] dmadev: introduce DMA device library

2021-07-15 Thread fengchengwen
@burce, jerin Some unmodified review comments are returned here: 1. COMMENT: > +memset(dmadev_shared_data->data, 0, > +sizeof(dmadev_shared_data->data)); I believe all memzones are zero on allocation anyway, so this memset is unecessary and can be d

[dpdk-dev] [PATCH v4] dmadev: introduce DMA device library

2021-07-15 Thread Chengwen Feng
This patch introduce 'dmadevice' which is a generic type of DMA device. The APIs of dmadev library exposes some generic operations which can enable configuration and I/O with the DMA devices. Signed-off-by: Chengwen Feng --- v4: * replace xxx_complete_fails with xxx_completed_status. * add SILEN

Re: [dpdk-dev] [PATCH v4 19/20] net/sfc: support flow action COUNT in transfer rules

2021-07-15 Thread David Marchand
On Fri, Jul 2, 2021 at 10:41 AM Andrew Rybchenko wrote: > diff --git a/doc/guides/nics/sfc_efx.rst b/doc/guides/nics/sfc_efx.rst > index cf1269cc03..bd08118da7 100644 > --- a/doc/guides/nics/sfc_efx.rst > +++ b/doc/guides/nics/sfc_efx.rst > @@ -240,6 +240,8 @@ Supported actions (***transfer*** rul

Re: [dpdk-dev] [PATCH] app/testpmd: remove most uses of rte_eth_devices

2021-07-15 Thread Ferruh Yigit
On 7/15/2021 3:20 PM, Paulis Gributs wrote: > This patch removes most uses of the global variable rte_eth_devices > from testpmd. This was done to avoid using the object directly which > applications should not do. > > Most uses have been replaced with standard function calls, however > the use of

Re: [dpdk-dev] [PATCH v2 1/2] drivers: add octeontx crypto adapter framework

2021-07-15 Thread David Marchand
Hello, On Wed, Jun 23, 2021 at 10:54 PM Shijith Thotton wrote: > diff --git a/drivers/event/octeontx/meson.build > b/drivers/event/octeontx/meson.build > index 3cb140b4de..0d9eec3f2e 100644 > --- a/drivers/event/octeontx/meson.build > +++ b/drivers/event/octeontx/meson.build > @@ -12,3 +12,4 @@

Re: [dpdk-dev] [PATCH 3/3] net/bonding: start ethdev prior to setting 8023ad flow

2021-07-15 Thread Thomas Monjalon
14/07/2021 17:00, Jan Viktorin: > > > On Tue, 13 Jul 2021 12:26:35 +0300 > > > Andrew Rybchenko wrote: > > > > >>> > > This matters for the bonding case as well, doesn't it?. > > > > >>> > > It is not desirable to accidently omit a packet that was > > > > >>> > > received by primary ingress logic

[dpdk-dev] [PATCH 4/4] raw/cnxk_bphy: support setting FEC

2021-07-15 Thread Tomasz Duszynski
Add support for setting FEC for a given LMAC. Signed-off-by: Tomasz Duszynski --- drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c | 4 drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c | 19 +++ drivers/raw/cnxk_bphy/rte_pmd_bphy.h | 1 + 3 files changed, 24 insertions(+) diff

[dpdk-dev] [PATCH 2/4] common/cnxk: support setting BPHY CGX/RPM FEC

2021-07-15 Thread Tomasz Duszynski
Add support for setting FEC for a given LMAC. Signed-off-by: Tomasz Duszynski --- drivers/common/cnxk/roc_bphy_cgx.c | 18 ++ drivers/common/cnxk/roc_bphy_cgx.h | 3 +++ drivers/common/cnxk/roc_bphy_cgx_priv.h | 4 drivers/common/cnxk/version.map | 1 +

[dpdk-dev] [PATCH 3/4] raw/cnxk_bphy: support reading FEC

2021-07-15 Thread Tomasz Duszynski
Allow one to retrieve supported FEC setting for specific LMAC. Signed-off-by: Tomasz Duszynski --- drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c | 9 + drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c | 23 ++ drivers/raw/cnxk_bphy/rte_pmd_bphy.h | 1 + 3 files changed

[dpdk-dev] [PATCH 1/4] common/cnxk: support reading BPHY CGX/RPM FEC

2021-07-15 Thread Tomasz Duszynski
Before setting FEC for specific LMAC one needs to know which type is actually supported because it generally differs between modes LMAC operates in (SGMII, SFI, etc.). Signed-off-by: Tomasz Duszynski --- drivers/common/cnxk/roc_bphy_cgx.c | 25 + drivers/common/cnxk/

[dpdk-dev] [PATCH 0/4] raw/cnxk_bphy: add FEC support

2021-07-15 Thread Tomasz Duszynski
This series adds support for changing current LMAC FEC setting. Tomasz Duszynski (4): common/cnxk: support reading BPHY CGX/RPM FEC common/cnxk: support setting BPHY CGX/RPM FEC raw/cnxk_bphy: support reading FEC raw/cnxk_bphy: support setting FEC drivers/common/cnxk/roc_bphy_cgx.c

Re: [dpdk-dev] [PATCH 2/2] net/sfc: improve logging in MAE backend of RTE flow support

2021-07-15 Thread Thomas Monjalon
15/07/2021 14:55, David Marchand: > On Wed, Jul 7, 2021 at 12:56 PM Ivan Malov wrote: > > diff --git a/drivers/net/sfc/sfc_flow.h b/drivers/net/sfc/sfc_flow.h > > index bd3b374d68..5b1f34aa7a 100644 > > --- a/drivers/net/sfc/sfc_flow.h > > +++ b/drivers/net/sfc/sfc_flow.h > > @@ -136,13 +136,21 @@

[dpdk-dev] [PATCH] app/testpmd: remove most uses of rte_eth_devices

2021-07-15 Thread Paulis Gributs
This patch removes most uses of the global variable rte_eth_devices from testpmd. This was done to avoid using the object directly which applications should not do. Most uses have been replaced with standard function calls, however the use of it in the show_macs function could not be replaced as n

Re: [dpdk-dev] [PATCH v5 3/4] vhost: support async dequeue for split ring

2021-07-15 Thread Maxime Coquelin
On 7/14/21 8:50 AM, Hu, Jiayu wrote: > Hi Maxime, > > Thanks for your comments. Applies are inline. > >> -Original Message- >> From: Maxime Coquelin >> Sent: Tuesday, July 13, 2021 10:30 PM >> To: Ma, WenwuX ; dev@dpdk.org >> Cc: Xia, Chenbo ; Jiang, Cheng1 >> ; Hu, Jiayu ; Wang, Yuan

Re: [dpdk-dev] [PATCH 2/2] net/sfc: improve logging in MAE backend of RTE flow support

2021-07-15 Thread David Marchand
On Wed, Jul 7, 2021 at 12:56 PM Ivan Malov wrote: > diff --git a/drivers/net/sfc/sfc_flow.h b/drivers/net/sfc/sfc_flow.h > index bd3b374d68..5b1f34aa7a 100644 > --- a/drivers/net/sfc/sfc_flow.h > +++ b/drivers/net/sfc/sfc_flow.h > @@ -136,13 +136,21 @@ typedef int (sfc_flow_item_parse)(const struc

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-15 Thread Nipun Gupta
> -Original Message- > From: Jerin Jacob > Sent: Thursday, July 15, 2021 6:02 PM > To: Bruce Richardson > Cc: Nipun Gupta ; fengchengwen > ; tho...@monjalon.net; ferruh.yi...@intel.com; > jer...@marvell.com; andrew.rybche...@oktetlabs.ru; dev@dpdk.org; > m...@smartsharesystems.com; Hema

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-15 Thread Jerin Jacob
On Thu, Jul 15, 2021 at 5:41 PM Bruce Richardson wrote: > > On Thu, Jul 15, 2021 at 11:16:54AM +, Nipun Gupta wrote: > > > > > > > -Original Message- > > > From: fengchengwen > > > Sent: Thursday, July 15, 2021 1:59 PM > > > To: Nipun Gupta ; tho...@monjalon.net; > > > ferruh.yi...@in

Re: [dpdk-dev] [PATCH v1] net/mlx5: fix RSS selection flags settings

2021-07-15 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Lior Margalit > Sent: Tuesday, July 13, 2021 3:55 PM > To: dev@dpdk.org; Matan Azrad > Cc: Lior Margalit ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v1] net/mlx5: fix RSS selection flags settings > > The L3 protocol of the RSS type ma

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-15 Thread Bruce Richardson
On Thu, Jul 15, 2021 at 11:16:54AM +, Nipun Gupta wrote: > > > > -Original Message- > > From: fengchengwen > > Sent: Thursday, July 15, 2021 1:59 PM > > To: Nipun Gupta ; tho...@monjalon.net; > > ferruh.yi...@intel.com; bruce.richard...@intel.com; jer...@marvell.com; > > jerinjac...@

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-15 Thread Nipun Gupta
> -Original Message- > From: fengchengwen > Sent: Thursday, July 15, 2021 1:59 PM > To: Nipun Gupta ; tho...@monjalon.net; > ferruh.yi...@intel.com; bruce.richard...@intel.com; jer...@marvell.com; > jerinjac...@gmail.com; andrew.rybche...@oktetlabs.ru > Cc: dev@dpdk.org; m...@smartshares

[dpdk-dev] [PATCH v2] net/iavf: fix wrong bandwidth unit in TM capability querying

2021-07-15 Thread Ting Xu
In IAVF node TM capability querying, the unit of bandwidth is Kbps, which is not correct according to TM specification. Change the unit to Byte per second. Refine some unclear comments as well. Fixes: 44d0a720a538 ("net/iavf: query QoS capabilities and set queue TC mapping") Cc: sta...@dpdk.org

[dpdk-dev] [PATCH v2] net/iavf: fix wrong bandwidth unit in TM capability querying

2021-07-15 Thread Ting Xu
In IAVF node TM capability querying, the unit of bandwidth is Kbps, which is not correct according to TM specification. Change the unit to Byte per second. Refine some unclear comments as well. Fixes: 44d0a720a538 ("net/iavf: query QoS capabilities and set queue TC mapping") Cc: sta...@dpdk.org

[dpdk-dev] [PATCH v2] vhost: fix index overflow for packed ring in async vhost

2021-07-15 Thread Cheng Jiang
We introduced some new indexes in packed ring of async vhost. They will eventually overflow and lead to errors if the ring size is not a power of 2. This patch is to check and keep these indexes within a reasonable range. Fixes: 873e8dad6f49 ("vhost: support packed ring in async datapath") Cc: sta

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-15 Thread Bruce Richardson
On Thu, Jul 15, 2021 at 11:03:08AM +0100, Bruce Richardson wrote: > On Thu, Jul 15, 2021 at 03:00:01PM +0530, Jerin Jacob wrote: > > On Thu, Jul 15, 2021 at 2:33 PM Bruce Richardson > > wrote: > > > > > > On Thu, Jul 15, 2021 at 12:40:01PM +0530, Jerin Jacob wrote: > > > > ) > > > > a > > > > > >

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-15 Thread Bruce Richardson
On Thu, Jul 15, 2021 at 03:00:01PM +0530, Jerin Jacob wrote: > On Thu, Jul 15, 2021 at 2:33 PM Bruce Richardson > wrote: > > > > On Thu, Jul 15, 2021 at 12:40:01PM +0530, Jerin Jacob wrote: > > > ) > > > a > > > > > > On Tue, Jul 13, 2021 at 6:01 PM Chengwen Feng > > > wrote: > > > > > > > > Th

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-15 Thread Bruce Richardson
On Thu, Jul 15, 2021 at 03:19:55PM +0530, Jerin Jacob wrote: > On Thu, Jul 15, 2021 at 1:55 PM Bruce Richardson > wrote: > > > > On Thu, Jul 15, 2021 at 12:14:05PM +0530, Jerin Jacob wrote: > > > On Tue, Jul 13, 2021 at 7:08 PM Bruce Richardson > > > wrote: > > > > > > > > On Tue, Jul 13, 2021 at

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-15 Thread Jerin Jacob
On Thu, Jul 15, 2021 at 1:55 PM Bruce Richardson wrote: > > On Thu, Jul 15, 2021 at 12:14:05PM +0530, Jerin Jacob wrote: > > On Tue, Jul 13, 2021 at 7:08 PM Bruce Richardson > > wrote: > > > > > > On Tue, Jul 13, 2021 at 09:06:39PM +0800, fengchengwen wrote: > > > > > > 4. COMMENT:> + uint

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-15 Thread Jerin Jacob
On Thu, Jul 15, 2021 at 2:33 PM Bruce Richardson wrote: > > On Thu, Jul 15, 2021 at 12:40:01PM +0530, Jerin Jacob wrote: > > ) > > a > > > > On Tue, Jul 13, 2021 at 6:01 PM Chengwen Feng > > wrote: > > > > > > This patch introduce 'dmadevice' which is a generic type of DMA > > > device. > > > >

[dpdk-dev] Techboard - minutes of meeting 2021-07-14

2021-07-15 Thread Bruce Richardson
Attendees - * Aaron Conole * Bruce Richardson * Ferruh Yigit * Hemant Agrawal * Honnappa Nagarahalli * Jerin Jacob * Kevin Traynor * Konstantin Ananyev * Stephen Hemminger * Thomas Monjalon Minutes --- 1. Readout on survey on next-net maintainership * Ferruh provided a summary of re

Re: [dpdk-dev] 19.11.9 patches review and test

2021-07-15 Thread Ali Alnubani
Hi Christian, Thanks again for helping merge the mlx5 fixes into rc4. > -Original Message- > From: Christian Ehrhardt > Sent: Monday, July 5, 2021 4:23 PM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Akhil Goyal ; Ali Alnubani ; > benjamin.wal...@intel.com; David Christe

Re: [dpdk-dev] [PATCH] ethdev: avoid unregistering a non-allocated callback

2021-07-15 Thread Ferruh Yigit
On 7/14/2021 4:42 PM, Thomas Monjalon wrote: > 14/07/2021 16:16, Matan Azrad: >> From: Thomas Monjalon >>> 13/07/2021 15:42, Matan Azrad: From: Thomas Monjalon > When registering a new event callback, if allocation fails, there is > no need for unregistering the callback, because it is

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-15 Thread Bruce Richardson
On Thu, Jul 15, 2021 at 12:40:01PM +0530, Jerin Jacob wrote: > ) > a > > On Tue, Jul 13, 2021 at 6:01 PM Chengwen Feng wrote: > > > > This patch introduce 'dmadevice' which is a generic type of DMA > > device. > > > > The APIs of dmadev library exposes some generic operations which can > > enabl

Re: [dpdk-dev] [PATCH] vhost: fix index overflow issue in async vhost

2021-07-15 Thread Jiang, Cheng1
Hi Chenbo, > -Original Message- > From: Xia, Chenbo > Sent: Thursday, July 15, 2021 4:37 PM > To: Jiang, Cheng1 ; maxime.coque...@redhat.com > Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX > ; sta...@dpdk.org > Subject: RE: [PATCH] vhost: fix index overflow issue in async vhost > > Hi Chen

Re: [dpdk-dev] [PATCH] vhost: fix index overflow issue in async vhost

2021-07-15 Thread Xia, Chenbo
Hi Cheng, > -Original Message- > From: Jiang, Cheng1 > Sent: Thursday, July 8, 2021 6:45 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX > ; Jiang, Cheng1 ; > sta...@dpdk.org > Subject: [PATCH] vhost: fix index overflow issue in async vhost

  1   2   >