Re: [dpdk-dev] [dpdk-users] imissed drop with mellanox connectx5

2021-07-23 Thread Gerry Wan
My understanding of an increasing imissed counter is that it indicates your processing logic in the lcore is not fast enough to handle the rate of incoming packets, and is independent of the number of free mbufs. I would guess that using the pipeline model (passing mbufs between lcores via rings) i

Re: [dpdk-dev] [PATCH] app: fix redundant comparison

2021-07-23 Thread Min Hu (Connor)
Agreed, This patch can be rejected, thanks. 在 2021/7/24 4:16, Andrew Rybchenko 写道: On 4/19/21 3:44 PM, David Hunt wrote: Hi Connor, On 19/4/2021 1:29 PM, Min Hu (Connor) wrote: The return value of 'rte_eal_cleanup' is always zero, so comparison with zero is redundant. This patch fixed it by

Re: [dpdk-dev] [PATCH v3 00/11] net/sfc: provide Rx/Tx doorbells stats

2021-07-23 Thread Thomas Monjalon
23/07/2021 15:15, Andrew Rybchenko: > Ivan Ilchenko (11): > net/sfc: fix get xstats by ID callback to use MAC stats lock > net/sfc: fix reading adapter state without locking > ethdev: fix docs of functions getting xstats by IDs > ethdev: fix docs of drivers callbacks getting xstats by IDs >

Re: [dpdk-dev] [PATCH v3 0/2] RTE flow support logging improvements

2021-07-23 Thread Thomas Monjalon
21/07/2021 06:15, Ivan Malov: > Changes in v3: > * [1/2] Improved style consistency and revised some log levels > * [2/2] RTE flow item and action types/names use no macros now > > Changes in v2: > * [2/2] RTE flow item and action type macros are spelled out in full > > Ivan Malov (2): > net/sf

Re: [dpdk-dev] [PATCH] devtools: test different build types

2021-07-23 Thread Andrew Rybchenko
On 5/21/21 6:03 PM, David Marchand wrote: On Mon, Apr 12, 2021 at 11:54 PM Thomas Monjalon wrote: @@ -213,9 +218,10 @@ for c in gcc clang ; do abicheck=ABI init of buildtype var is missing here. +1 Rest lgtm. else abiche

Re: [dpdk-dev] [PATCH] app: fix redundant comparison

2021-07-23 Thread Andrew Rybchenko
On 4/19/21 3:44 PM, David Hunt wrote: Hi Connor, On 19/4/2021 1:29 PM, Min Hu (Connor) wrote: The return value of 'rte_eal_cleanup' is always zero, so comparison with zero is redundant. This patch fixed it by deleting the redundant comparison. Fixes: 67684d1e87b6 ("app/procinfo: call EAL clea

Re: [dpdk-dev] [PATCH v2] bus: clarify log for non-NUMA-aware devices

2021-07-23 Thread Andrew Rybchenko
On 6/16/21 1:07 PM, Dmitry Kozlyuk wrote: PCI and vmbus drivers printed a warning when NUMA node had beed reported as (-1) or not reported by OS: EAL: Invalid NUMA socket, default to 0 This message and its level might confuse users, because configuration is valid and nothing happens that

Re: [dpdk-dev] [PATCH v3 8/8] test/rcu: use compiler atomics for data sync

2021-07-23 Thread Andrew Rybchenko
On 7/20/21 6:51 AM, Joyce Kong wrote: Covert rte_atomic usages to compiler atomic built-ins in rcu_perf testcases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Acked-by: Stephen Hemminger --- app/test/test_rcu_qsbr_perf.c | 98 +-- 1 file changed, 49

[dpdk-dev] [PATCH v2] Fixed formatting issue in documentation

2021-07-23 Thread Henry Nadeau
One of the titles needed a dash below as the title was extended. Signed-off-by: Henry Nadeau --- doc/guides/prog_guide/toeplitz_hash_lib.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/prog_guide/toeplitz_hash_lib.rst b/doc/guides/prog_guide/toeplitz_hash_lib.

Re: [dpdk-dev] [PATCH] app/testpmd: fix help string for port reset

2021-07-23 Thread Andrew Rybchenko
On 7/23/21 3:24 PM, Ferruh Yigit wrote: Command help string is missing 'reset' keyword, although description has it. Adding it. Fixes: 97f1e196799f ("app/testpmd: add port reset command") Cc: sta...@dpdk.org Signed-off-by: Ferruh Yigit Reviewed-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH 04/11] ethdev: fix docs of drivers callbacks getting xstats by IDs

2021-07-23 Thread Andrew Rybchenko
On 7/23/21 5:31 PM, Ferruh Yigit wrote: On 7/22/2021 10:33 AM, Andrew Rybchenko wrote: On 7/20/21 7:51 PM, Ferruh Yigit wrote: On 6/4/2021 3:42 PM, Andrew Rybchenko wrote: From: Ivan Ilchenko Update xstats by IDs callbacks documentation in accordance with ethdev usage of these callbacks. Doc

Re: [dpdk-dev] [PATCH 0/7] NXP DPAAx fixes and improvements

2021-07-23 Thread Thomas Monjalon
19/07/2021 15:59, Hemant Agrawal: > This series add few minor fixes and enhancements for > the NXP DPAAx drivers. > > Hemant Agrawal (3): > bus/dpaa: fix to use right type of memory free > bus/dpaa: reduce syscall usages > doc: remove SDK info form individual dev guides > > Nipun Gupta (2):

Re: [dpdk-dev] [PATCH] net/mlx5: fix mirror flow split with L3 encapsulation

2021-07-23 Thread Jiawei(Jonny) Wang
Hello, > -Original Message- > From: Thomas Monjalon > Sent: Friday, July 23, 2021 8:57 PM > To: Slava Ovsiienko ; Jiawei(Jonny) Wang > > Cc: Matan Azrad ; Ori Kam ; > Shahaf Shuler ; dev@dpdk.org; Raslan Darawsheh > ; sta...@dpdk.org > Subject: Re: [PATCH] net/mlx5: fix mirror flow spli

Re: [dpdk-dev] [PATCH] build: enable to build on power10 or newer for ppc

2021-07-23 Thread Thinh Tran
Thanks David for reviewing. I'll fix the patch with cross compilation in mind. Regards, Thinh Tran On 7/22/2021 3:20 PM, David Marchand wrote: On Wed, Jul 21, 2021 at 11:14 PM Thinh Tran wrote: A older version of complier would fail to generate code for new Power compiler CPUs when it u

[dpdk-dev] [PATCH] net/mlx5: fix mirror flow split with L3 encapsulation

2021-07-23 Thread Jiawei Wang
Due to hardware limitations, the decap action can't follow the sample action in the same flow, to keep the original action order of sample and decap actions the flow was internally split by PMD, and decap action was moved into suffix subflow in the new table. There is a specific combination of raw

Re: [dpdk-dev] [PATCH] maintainers: update for ena

2021-07-23 Thread Thomas Monjalon
23/07/2021 12:43, Michal Krawczyk: > Remove Guy Tzalik as the driver's maintainer and add Shai Brandes who > will now be another maintainer of the ENA DPDK driver. > > Signed-off-by: Michal Krawczyk Applied, thanks

Re: [dpdk-dev] [PATCH v4 0/6] net/ena: v2.4.0 driver update

2021-07-23 Thread Thomas Monjalon
> Michal Krawczyk (6): > net/ena: adjust driver logs > net/ena: make use of the IO debug build option > net/ena: trigger reset when Tx prepare fails > net/ena: add support for Rx interrupts > net/ena: rework RSS configuration > net/ena: update version to v2.4.0 Applied, thanks

[dpdk-dev] [PATCH v3] eal: fix argument to rte_bsf32_safe

2021-07-23 Thread Stephen Hemminger
The first argument to rte_bsf32_safe was incorrectly declared as a 64 bit value. The code only works on 32 bit values and the underlying function rte_bsf32 only accepts 32 bit values. This was a mistake introduced when the safe version was added and probably cause by copy/paste from the 64 bit vers

Re: [dpdk-dev] [PATCH v3 04/11] ethdev: fix docs of drivers callbacks getting xstats by IDs

2021-07-23 Thread Ferruh Yigit
On 7/23/2021 2:15 PM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Update xstats by IDs callbacks documentation in accordance with > ethdev usage of these callbacks. Document valid combinations of > input arguments to make driver implementation simpler. > > Fixes: 79c913a42f0 ("ethdev: retr

Re: [dpdk-dev] [PATCH v3 03/11] ethdev: fix docs of functions getting xstats by IDs

2021-07-23 Thread Ferruh Yigit
On 7/23/2021 2:15 PM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Document valid combinations of input arguments in accordance with > current implementation in ethdev. > > Fixes: 79c913a42f0 ("ethdev: retrieve xstats by ID") > Cc: sta...@dpdk.org > > Signed-off-by: Ivan Ilchenko > Signed

Re: [dpdk-dev] [PATCH 04/11] ethdev: fix docs of drivers callbacks getting xstats by IDs

2021-07-23 Thread Ferruh Yigit
On 7/22/2021 10:33 AM, Andrew Rybchenko wrote: > On 7/20/21 7:51 PM, Ferruh Yigit wrote: >> On 6/4/2021 3:42 PM, Andrew Rybchenko wrote: >>> From: Ivan Ilchenko >>> >>> Update xstats by IDs callbacks documentation in accordance with >>> ethdev usage of these callbacks. Document valid combinations

Re: [dpdk-dev] [PATCH 03/11] ethdev: fix docs of functions getting xstats by IDs

2021-07-23 Thread Ferruh Yigit
On 7/22/2021 10:12 AM, Andrew Rybchenko wrote: > On 7/20/21 7:25 PM, Ferruh Yigit wrote: >> On 6/4/2021 3:42 PM, Andrew Rybchenko wrote: >>> From: Ivan Ilchenko >>> >>> Document valid combinations of input arguments in accordance with >>> current implementation in ethdev. >>> >>> Fixes: 79c913a42f

Re: [dpdk-dev] [PATCH] net/nfp: remove compile time log

2021-07-23 Thread Thomas Monjalon
Please review. 28/06/2021 13:13, Andrew Rybchenko: > Hi Heinrich, > > could you take a look at the patch? > > Thanks, > Andrew. > > On 5/18/21 1:41 PM, Ferruh Yigit wrote: > > Logging should be converted to dynamic log. > > > > Signed-off-by: Ferruh Yigit > > --- > > drivers/net/nfp/nfp_net

Re: [dpdk-dev] [PATCH] net/mlx5: fix mirror flow split with L3 encapsulation

2021-07-23 Thread Thomas Monjalon
23/07/2021 16:01, Jiawei(Jonny) Wang: > Hello, > > From: Thomas Monjalon > > 23/07/2021 14:43, Jiawei Wang: > > > Due to hardware limitations, the decap action can't follow the > > > > Which decap action? Pleas be more specific. > > All of decap, vxlan_decap, nvgre_decap and raw_decap. > Will

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/txgbe: fix VLAN filter setting for VF

2021-07-23 Thread Thomas Monjalon
14/07/2021 08:05, Jiawen Wu: > Fix the function call error on VLAN filter table address setting for VF. > > Fixes: aa1ae7941e71 ("net/txgbe: support VF VLAN") > Cc: sta...@dpdk.org > > Signed-off-by: Jiawen Wu Applied, thanks

[dpdk-dev] [PATCH] doc: Spell checked DPDK documentation

2021-07-23 Thread Henry Nadeau
Corrected spelling mistakes in the DPDK documentation. Signed-off-by: Henry Nadeau --- doc/guides/contributing/coding_style.rst| 2 +- doc/guides/cryptodevs/mlx5.rst | 4 ++-- doc/guides/cryptodevs/scheduler.rst | 2 +- doc/guides/howto/pvp_reference_benchmar

Re: [dpdk-dev] [PATCH v1 0/3] fix some problems of mtu, vlan, lro

2021-07-23 Thread Thomas Monjalon
16/07/2021 11:54, Guoyang Zhou: > The vlan id 0 can not be deleted, and the rx queue must config > as ceq disable, and must set msix state disable because of lro > function, and fix the problem of MTU inconsistent in the driver > and firmware. > > Guoyang Zhou (3): > net/hinic: increase the prot

[dpdk-dev] [Bug 761] Unit tests fail on FreeBSD

2021-07-23 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=761 Bug ID: 761 Summary: Unit tests fail on FreeBSD Product: DPDK Version: unspecified Hardware: All OS: FreeBSD Status: UNCONFIRMED Severity: normal Priorit

Re: [dpdk-dev] [PATCH v3 5/6] net/ena: rework RSS configuration

2021-07-23 Thread Thomas Monjalon
23/07/2021 13:52, Thomas Monjalon: > 23/07/2021 11:49, Michał Krawczyk: > > pt., 23 lip 2021 o 11:43 Thomas Monjalon napisał(a): > > > 23/07/2021 11:39, Michał Krawczyk: > > > > pt., 23 lip 2021 o 11:22 Thomas Monjalon > > > > napisał(a): > > > > > 14/07/2021 12:43, Michal Krawczyk: > > > > > >

[dpdk-dev] [PATCH v3 11/11] app/testpmd: add option to display extended statistics

2021-07-23 Thread Andrew Rybchenko
From: Ivan Ilchenko Add 'display-xstats' option for using in accompanying with Rx/Tx statistics (i.e. 'stats-period' option or 'show port stats' interactive command) to display specified list of extended statistics. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- app/test-pmd

[dpdk-dev] [PATCH v3 10/11] net/sfc: add xstats for Rx/Tx doorbells

2021-07-23 Thread Andrew Rybchenko
From: Ivan Ilchenko Rx/Tx doorbells statistics are collected in software and available per queue. These stats are useful for performance investigation. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/meson.build| 1 + drive

[dpdk-dev] [PATCH v3 09/11] net/sfc: prepare to add more xstats

2021-07-23 Thread Andrew Rybchenko
From: Ivan Ilchenko Move getting MAC stats code that involves locking to separate functions to simplify addition of new xstats. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc.h| 4 ++ drivers/net/sfc/sfc_ethdev.c | 73 +

[dpdk-dev] [PATCH v3 07/11] net/sfc: fix MAC stats update to work for stopped device

2021-07-23 Thread Andrew Rybchenko
From: Ivan Ilchenko Fixes: 1caab2f1e68 ("net/sfc: add basic statistics") Cc: sta...@dpdk.org Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc.h| 2 +- drivers/net/sfc/sfc_ethdev.c | 6 +++--- drivers/net/sfc/sfc_port.c

[dpdk-dev] [PATCH v3 08/11] net/sfc: simplify getting of available xstats case

2021-07-23 Thread Andrew Rybchenko
From: Ivan Ilchenko There is no point to recalculate number of available xstats on each request. The number is calculated once on device start and may be returned on subsequent calls. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/s

[dpdk-dev] [PATCH v3 06/11] net/sfc: fix accessing xstats by an unsorted list of IDs

2021-07-23 Thread Andrew Rybchenko
From: Ivan Ilchenko Device may support only some MAC stats. Add mapping from ids to subset of supported MAC stats for each port. Fixes: 73280c1e4ff ("net/sfc: support xstats retrieval by ID") Cc: sta...@dpdk.org Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Mo

[dpdk-dev] [PATCH v3 05/11] net/sfc: fix xstats by ID callbacks according to ethdev

2021-07-23 Thread Andrew Rybchenko
From: Ivan Ilchenko Fix xstats by ID callbacks according to ethdev usage. Handle combinations of input arguments that are required by ethdev and sanity check and reject other combinations on callback entry. Fixes: 73280c1e4ff ("net/sfc: support xstats retrieval by ID") Cc: sta...@dpdk.org Signe

[dpdk-dev] [PATCH v3 04/11] ethdev: fix docs of drivers callbacks getting xstats by IDs

2021-07-23 Thread Andrew Rybchenko
From: Ivan Ilchenko Update xstats by IDs callbacks documentation in accordance with ethdev usage of these callbacks. Document valid combinations of input arguments to make driver implementation simpler. Fixes: 79c913a42f0 ("ethdev: retrieve xstats by ID") Cc: sta...@dpdk.org Signed-off-by: Ivan

[dpdk-dev] [PATCH v3 03/11] ethdev: fix docs of functions getting xstats by IDs

2021-07-23 Thread Andrew Rybchenko
From: Ivan Ilchenko Document valid combinations of input arguments in accordance with current implementation in ethdev. Fixes: 79c913a42f0 ("ethdev: retrieve xstats by ID") Cc: sta...@dpdk.org Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- lib/eth

[dpdk-dev] [PATCH v3 02/11] net/sfc: fix reading adapter state without locking

2021-07-23 Thread Andrew Rybchenko
From: Ivan Ilchenko Update MAC stats function reads adapter state with MAC stats locking but without adapter locking. Add adapter locking before calling this function and remove MAC stats locking since there's no point to have it together with adapter locking. The second place MAC stats locking i

[dpdk-dev] [PATCH v3 01/11] net/sfc: fix get xstats by ID callback to use MAC stats lock

2021-07-23 Thread Andrew Rybchenko
From: Ivan Ilchenko Add MAC stats lock in get xstats by id callback before reading number of supported MAC stats. Fixes: 73280c1e4ff ("net/sfc: support xstats retrieval by ID") Cc: sta...@dpdk.org Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- dri

[dpdk-dev] [PATCH v3 00/11] net/sfc: provide Rx/Tx doorbells stats

2021-07-23 Thread Andrew Rybchenko
Rx/Tx doorbells stats are essential for performance investigation. On the way fix ethdev documenation to refine requirements on driver callback. It allows to make these callbacks a bit simpler. Add testpmd option to show specified xstats periodically or upon request, for example: * --display-xs

Re: [dpdk-dev] [PATCH] net/hns3: supports disabling PFC by dev configure API

2021-07-23 Thread Thomas Monjalon
17/07/2021 03:04, Min Hu (Connor): > From: Huisong Li > > If "dcb_capability_en" in "data->dev_conf" delivered from the dev_configure > does not have the ETH_DCB_PFC_SUPPORT flag, the user wants to disable PFC, > and only enable ETS. Therefore, this patch supports the function of > disabling PFC

Re: [dpdk-dev] [PATCH v2 11/11] app/testpmd: add option to display extended statistics

2021-07-23 Thread Andrew Rybchenko
Hi David, On 7/22/21 11:15 PM, David Marchand wrote: On Thu, Jul 22, 2021 at 11:55 AM Andrew Rybchenko wrote: diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 8468018cf3..baffef1642 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -3609,6 +3609,62 @@ cmdli

Re: [dpdk-dev] Question about hardware error handling policy

2021-07-23 Thread Andrew Rybchenko
On 7/23/21 3:33 PM, Ferruh Yigit wrote: On 7/22/2021 4:46 PM, Thomas Monjalon wrote: 22/07/2021 15:50, fengchengwen: Hi, all I notice ethdev support dev_reset ops, which could be used to recover from errors, and only 13+ drivers support this function. 'rte_eth_dev_reset()' can be used t

Re: [dpdk-dev] [PATCH] net/mlx5: fix mirror flow split with L3 encapsulation

2021-07-23 Thread Thomas Monjalon
23/07/2021 14:43, Jiawei Wang: > Due to hardware limitations, the decap action can't follow the Which decap action? Pleas be more specific. > sample action in the same flow, to keep the original action order > of sample and decap actions the flow was internally split by PMD, > and decap action wa

Re: [dpdk-dev] Question about hardware error handling policy

2021-07-23 Thread Thomas Monjalon
23/07/2021 14:33, Ferruh Yigit: > On 7/22/2021 4:46 PM, Thomas Monjalon wrote: > > 22/07/2021 15:50, fengchengwen: > >> Hi, all > >> > >> I notice ethdev support dev_reset ops, which could be used to recover > >> from > >> errors, and only 13+ drivers support this function. > > 'rte_eth_dev_r

Re: [dpdk-dev] [PATCH 0/8] bugfix for hns3 PMD

2021-07-23 Thread Thomas Monjalon
17/07/2021 04:02, Min Hu (Connor): > This patchset contains 8 bugfixes for hns3 PMD. > > Chengchang Tang (2): > net/hns3: fix residual MAC address entry > net/hns3: delete duplicate compile-time check > > Chengwen Feng (3): > net/hns3: delete unnecessary zero assignments > net/hns3: fix i

Re: [dpdk-dev] [PATCH] doc: announce removal of ABIs in PCI bus driver

2021-07-23 Thread Ferruh Yigit
On 7/23/2021 8:39 AM, Xia, Chenbo wrote: > Hi, > > A gentle ping for comments.. > >> -Original Message- >> From: dev On Behalf Of Chenbo Xia >> Sent: Tuesday, June 1, 2021 4:42 PM >> To: dev@dpdk.org; tho...@monjalon.net >> Cc: m...@ashroe.eu; nhor...@tuxdriver.com >> Subject: [dpdk-dev]

Re: [dpdk-dev] Question about hardware error handling policy

2021-07-23 Thread Ferruh Yigit
On 7/22/2021 4:46 PM, Thomas Monjalon wrote: > 22/07/2021 15:50, fengchengwen: >> Hi, all >> >> I notice ethdev support dev_reset ops, which could be used to recover >> from >> errors, and only 13+ drivers support this function. 'rte_eth_dev_reset()' can be used to reset device config to defa

[dpdk-dev] [PATCH] app/testpmd: fix help string for port reset

2021-07-23 Thread Ferruh Yigit
Command help string is missing 'reset' keyword, although description has it. Adding it. Fixes: 97f1e196799f ("app/testpmd: add port reset command") Cc: sta...@dpdk.org Signed-off-by: Ferruh Yigit --- Cc: wei@intel.com --- app/test-pmd/cmdline.c | 4 ++-- 1 file changed, 2 insertions(+), 2 d

Re: [dpdk-dev] [dpdk-users] [DISCUSSION] code snippet documentation

2021-07-23 Thread Ferruh Yigit
On 7/23/2021 1:02 AM, Ajit Khaparde wrote: > On Thu, Jul 22, 2021 at 1:29 PM Thomas Monjalon wrote: >> >> 15/07/2021 09:01, Asaf Penso: >>> Hello DPDK community, >>> >>> I would like to bring up a discussion about a way to have code snippets as >>> an example for proper usage. >>> The DPDK tree i

Re: [dpdk-dev] [PATCH v3 5/6] net/ena: rework RSS configuration

2021-07-23 Thread Thomas Monjalon
23/07/2021 11:49, Michał Krawczyk: > pt., 23 lip 2021 o 11:43 Thomas Monjalon napisał(a): > > > > 23/07/2021 11:39, Michał Krawczyk: > > > pt., 23 lip 2021 o 11:22 Thomas Monjalon napisał(a): > > > > > > > > 14/07/2021 12:43, Michal Krawczyk: > > > > > + PMD_DRV_LOG(WARNING, > > > >

Re: [dpdk-dev] [PATCH] eventdev: remove event port config override in tx adapter

2021-07-23 Thread Jerin Jacob
On Fri, Jul 23, 2021 at 1:42 PM Naga Harish K, S V wrote: > > The event port config set by application is modified in > default configuration callback function. This patch removes > this override and use application configured event port > config value. Is this enhancement or bug fix? If it is a

Re: [dpdk-dev] [PATCH] eventdev: remove event port config override in tx adapter

2021-07-23 Thread Jayatheerthan, Jay
> -Original Message- > From: Naga Harish K, S V > Sent: Friday, July 23, 2021 1:42 PM > To: Jayatheerthan, Jay ; jerinjac...@gmail.com > Cc: dev@dpdk.org > Subject: [PATCH] eventdev: remove event port config override in tx adapter > > The event port config set by application is modified i

[dpdk-dev] [PATCH] maintainers: update for ena

2021-07-23 Thread Michal Krawczyk
Remove Guy Tzalik as the driver's maintainer and add Shai Brandes who will now be another maintainer of the ENA DPDK driver. Signed-off-by: Michal Krawczyk --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8b5a3f0249..8013ba1f14 1

[dpdk-dev] [PATCH v4 6/6] net/ena: update version to v2.4.0

2021-07-23 Thread Michal Krawczyk
This version update contains: * Rx interrupts feature, * Support for the RSS hash function reconfiguration, * Small rework of the works, * Reset trigger on Tx path fix. Signed-off-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[dpdk-dev] [PATCH v4 5/6] net/ena: rework RSS configuration

2021-07-23 Thread Michal Krawczyk
Allow user to specify his own hash key and hash ctrl if the device is supporting that. HW interprets the key in reverse byte order, so the PMD reorders the key before passing it to the ena_com layer. Default key is being set in random matter each time the device is being initialized. Moreover, ma

[dpdk-dev] [PATCH v4 4/6] net/ena: add support for Rx interrupts

2021-07-23 Thread Michal Krawczyk
In order to support asynchronous Rx in the applications, the driver has to configure the event file descriptors and configure the HW. This patch configures appropriate data structures for the rte_ethdev layer, adds .rx_queue_intr_enable and .rx_queue_intr_disable API handlers, and configures IO qu

[dpdk-dev] [PATCH v4 3/6] net/ena: trigger reset when Tx prepare fails

2021-07-23 Thread Michal Krawczyk
If the prepare function failed, then it means the descriptors are in the invalid state. This condition now triggers the reset, which should be further handled by the application. To notify the application about prepare function failure, the error log was added. In general, it should never fail in

[dpdk-dev] [PATCH v4 2/6] net/ena: make use of the IO debug build option

2021-07-23 Thread Michal Krawczyk
ENA defined its own logger flags for Tx and Rx, but they weren't technically used anywhere. Those data path loggers weren't used anywhere after the definition. This commit uses the generic RTE_ETHDEV_DEBUG_RX and RTE_ETHDEV_DEBUG_TX flags to define PMD_TX_LOG and PMD_RX_LOG which are now being use

[dpdk-dev] [PATCH v4 1/6] net/ena: adjust driver logs

2021-07-23 Thread Michal Krawczyk
ENA logs were not consistent regarding the new line character. Few of them were relying on the new line character added by the PMD_*_LOG macros, but most were adding the new line character by themselves. It was causing ENA logs to add extra empty line after almost each log. To unify this behavior,

[dpdk-dev] [PATCH v4 0/6] net/ena: v2.4.0 driver update

2021-07-23 Thread Michal Krawczyk
Hi, this set contains 2 major ENA features: * RSS hash function key and reconfiguration - API for changing hf was also introduced, although it's not supported in the device right now. * Rx interrupts support. Moreover support for the RTE_ETHDEV_DEBUG_[TR]X flags introduced in v21.05 was added

[dpdk-dev] [PATCH v2] doc: update atomic operation deprecation

2021-07-23 Thread Joyce Kong
Update the incorrect description about atomic operations with provided wrappers in deprecation doc[1]. [1]https://mails.dpdk.org/archives/dev/2021-July/21.html Fixes: 7518c5c4ae6a ("doc: announce adoption of C11 atomic operations semantics") Cc: sta...@dpdk.org Signed-off-by: Joyce Kong Re

Re: [dpdk-dev] [PATCH v3 5/6] net/ena: rework RSS configuration

2021-07-23 Thread Michał Krawczyk
pt., 23 lip 2021 o 11:43 Thomas Monjalon napisał(a): > > 23/07/2021 11:39, Michał Krawczyk: > > pt., 23 lip 2021 o 11:22 Thomas Monjalon napisał(a): > > > > > > 14/07/2021 12:43, Michal Krawczyk: > > > > + PMD_DRV_LOG(WARNING, > > > > + "Setting RSS hash fields

Re: [dpdk-dev] [PATCH v3 5/6] net/ena: rework RSS configuration

2021-07-23 Thread Thomas Monjalon
23/07/2021 11:39, Michał Krawczyk: > pt., 23 lip 2021 o 11:22 Thomas Monjalon napisał(a): > > > > 14/07/2021 12:43, Michal Krawczyk: > > > + PMD_DRV_LOG(WARNING, > > > + "Setting RSS hash fields is not supported. Using > > > default values: 0x%llx\n", > > > +

Re: [dpdk-dev] [PATCH v3 5/6] net/ena: rework RSS configuration

2021-07-23 Thread Michał Krawczyk
pt., 23 lip 2021 o 11:22 Thomas Monjalon napisał(a): > > 14/07/2021 12:43, Michal Krawczyk: > > + PMD_DRV_LOG(WARNING, > > + "Setting RSS hash fields is not supported. Using > > default values: 0x%llx\n", > > + ENA_ALL_RSS_HF); > > > > che

Re: [dpdk-dev] [PATCH v3 5/6] net/ena: rework RSS configuration

2021-07-23 Thread Thomas Monjalon
14/07/2021 12:43, Michal Krawczyk: > + PMD_DRV_LOG(WARNING, > + "Setting RSS hash fields is not supported. Using > default values: 0x%llx\n", > + ENA_ALL_RSS_HF); > checkpatch is returning this warning: Using %l format, prefer %PR

Re: [dpdk-dev] [PATCH v2 0/7] Refactor the NFP PMD

2021-07-23 Thread Thomas Monjalon
16/07/2021 10:35, Heinrich Kuhn: > This patch set restructures the NFP PMD, aligning it more with the > common layout adopted by most other PMD's. Although the changes look > fairly large, functionally nothing is added or removed from the driver > and the existing code is mostly just reorganized in

Re: [dpdk-dev] [PATCH v8 0/4] vhost: handle memory hotplug for async vhost

2021-07-23 Thread Xia, Chenbo
> -Original Message- > From: Jiang, Cheng1 > Sent: Friday, July 23, 2021 4:10 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX > ; Jiang, Cheng1 > Subject: [PATCH v8 0/4] vhost: handle memory hotplug for async vhost > > When the guest memory

Re: [dpdk-dev] [PATCH v7 0/5] vhost: handle memory hotplug for async vhost

2021-07-23 Thread Thomas Monjalon
23/07/2021 10:03, Xia, Chenbo: > From: Thomas Monjalon > > 23/07/2021 09:34, Xia, Chenbo: > > > From: Thomas Monjalon > > > > 23/07/2021 07:06, Xia, Chenbo: > > > > > From: Thomas Monjalon > > > > Read the comment at the beginning of the section, it explains > > > > how things must be sorted: >

Re: [dpdk-dev] [PATCH v3 1/1] power: check freq count before filling the freqs array

2021-07-23 Thread David Hunt
Hi Richael, On 23/7/2021 3:22 AM, Richael Zhuang wrote: The freqs array size is RTE_MAX_LCORE_FREQS. Before filling the array with num_freqs elements, restrict the total num to RTE_MAX_LCORE_FREQS. This fix aims to fix the coverity scan issue like: Overrunning array "pi->freqs" of 256 bytes by p

Re: [dpdk-dev] [PATCH] net/af_packet: run on kernels without qdisc bypass support

2021-07-23 Thread Thomas Monjalon
I did a change in the patch while applying. See below: 14/07/2021 11:28, Tudor Cornea: > Some older kernels do not support the PACKET_QDISC_BYPASS socket > option. Such an example is the CentOS 7 kernel (3.10). > > If we only check for the definition of PACKET_QDISC_BYPASS, it might mean > that w

[dpdk-dev] [PATCH v8 4/4] examples/vhost: handle memory hotplug for async vhost

2021-07-23 Thread Cheng Jiang
When the guest memory is hotplugged, the vhost application which enables DMA acceleration must stop DMA transfers before the vhost re-maps the guest memory. To accomplish that, we need to do these changes in the vhost sample: 1. add inflight packets count. 2. add vring_state_changed() callback. 3.

[dpdk-dev] [PATCH v8 3/4] vhost: handle memory hotplug for async vhost

2021-07-23 Thread Cheng Jiang
From: Jiayu Hu When the guest memory is hotplugged, the vhost application which enables DMA acceleration must stop DMA transfers before the vhost re-maps the guest memory. This patch is to notify the vhost application of stopping DMA transfers. Signed-off-by: Jiayu Hu Reviewed-by: Maxime Coque

[dpdk-dev] [PATCH v8 2/4] vhost: add unsafe API to clear packets in async vhost

2021-07-23 Thread Cheng Jiang
Applications need to stop DMA transfers and finish all the inflight packets when in VM memory hot-plug case and async vhost is used. This patch is to provide an unsafe API to clear inflight packets which are submitted to DMA engine in vhost async data path. Update the program guide and release note

[dpdk-dev] [PATCH v8 1/4] vhost: fix async vhost ops return type

2021-07-23 Thread Cheng Jiang
The async vhost callback ops should return negative value when there are something wrong in the callback, so the return type should be changed into int32_t. The issue in vhost example is also fixed. Fixes: cd6760da1076 ("vhost: introduce async enqueue for split ring") Fixes: 819a71685826 ("vhost:

[dpdk-dev] [PATCH v8 0/4] vhost: handle memory hotplug for async vhost

2021-07-23 Thread Cheng Jiang
When the guest memory is hotplugged, the vhost application which enables DMA acceleration must stop DMA transfers before the vhost re-maps the guest memory. This patch set is to provide an unsafe API to drain inflight pkts which are submitted to DMA engine in vhost async data path, and notify the

Re: [dpdk-dev] [PATCH] net/af_packet: run on kernels without qdisc bypass support

2021-07-23 Thread Thomas Monjalon
14/07/2021 11:28, Tudor Cornea: > Some older kernels do not support the PACKET_QDISC_BYPASS socket > option. Such an example is the CentOS 7 kernel (3.10). > > If we only check for the definition of PACKET_QDISC_BYPASS, it might mean > that we will not be able to compile the PMD driver on a newer

[dpdk-dev] [PATCH] eventdev: remove event port config override in tx adapter

2021-07-23 Thread Naga Harish K, S V
The event port config set by application is modified in default configuration callback function. This patch removes this override and use application configured event port config value. Signed-off-by: Naga Harish K, S V --- lib/eventdev/rte_event_eth_tx_adapter.c | 1 - 1 file changed, 1 deletio

Re: [dpdk-dev] [PATCH v4] net/softnic: fix memory leak in parsing arguments

2021-07-23 Thread Thomas Monjalon
> > From: Dapeng Yu > > > > In function pmd_parse_args(), firmware path is duplicated from device > > arguments as character string, but is never freed, which cause memory leak. > > > > This patch changes the type of firmware member of struct pmd_params to > > character array, to make memory res

Re: [dpdk-dev] [PATCH 0/4] raw/cnxk_bphy: add FEC support

2021-07-23 Thread Thomas Monjalon
15/07/2021 15:53, Tomasz Duszynski: > This series adds support for changing current LMAC FEC setting. > > Tomasz Duszynski (4): > common/cnxk: support reading BPHY CGX/RPM FEC > common/cnxk: support setting BPHY CGX/RPM FEC > raw/cnxk_bphy: support reading FEC > raw/cnxk_bphy: support sett

Re: [dpdk-dev] [PATCH v7 0/5] vhost: handle memory hotplug for async vhost

2021-07-23 Thread Xia, Chenbo
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Friday, July 23, 2021 3:40 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: Jiang, Cheng1 ; dev@dpdk.org; Hu, Jiayu > ; Yang, YvonneX ; > david.march...@redhat.com; Yigit, Ferruh > Subject: Re: [dpdk-dev] [PATCH v7 0/

[dpdk-dev] [PATCH] net/iavf: remove interrupt handler

2021-07-23 Thread Robin Zhang
For VF hosted by Intel 700 series NICs, internal rx interrupt and adminq interrupt share the same source, that cause a lot cpu cycles be wasted on interrupt handler on rx path. The patch disable pci interrupt and remove the interrupt handler, replace it with a low frequency(50ms) interrupt polling

Re: [dpdk-dev] [PATCH] doc: announce removal of ABIs in PCI bus driver

2021-07-23 Thread Xia, Chenbo
Hi, A gentle ping for comments.. > -Original Message- > From: dev On Behalf Of Chenbo Xia > Sent: Tuesday, June 1, 2021 4:42 PM > To: dev@dpdk.org; tho...@monjalon.net > Cc: m...@ashroe.eu; nhor...@tuxdriver.com > Subject: [dpdk-dev] [PATCH] doc: announce removal of ABIs in PCI bus drive

Re: [dpdk-dev] [PATCH v7 0/5] vhost: handle memory hotplug for async vhost

2021-07-23 Thread Thomas Monjalon
23/07/2021 09:34, Xia, Chenbo: > From: Thomas Monjalon > > 23/07/2021 07:06, Xia, Chenbo: > > > From: Thomas Monjalon > > > > 22/07/2021 07:07, Xia, Chenbo: > > > > > From: Jiang, Cheng1 > > > > > > When the guest memory is hotplugged, the vhost application which > > > > > > enables DMA accelera

Re: [dpdk-dev] [PATCH v7 0/5] vhost: handle memory hotplug for async vhost

2021-07-23 Thread Xia, Chenbo
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Friday, July 23, 2021 3:25 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: Jiang, Cheng1 ; dev@dpdk.org; Hu, Jiayu > ; Yang, YvonneX ; > david.march...@redhat.com; Yigit, Ferruh > Subject: Re: [dpdk-dev] [PATCH v7 0/

Re: [dpdk-dev] [PATCH v3] eal: allow hugetlbfs sub-directories

2021-07-23 Thread Thomas Monjalon
22/07/2021 23:06, John Levon: > On Thu, Jul 22, 2021 at 10:29:45PM +0200, David Marchand wrote: > > > On Thu, Jul 8, 2021 at 1:00 PM John Levon wrote: > > > > > > get_hugepage_dir() was implemented in such a way that a --huge-dir > > > option had to exactly match the mountpoint, but there's no re

Re: [dpdk-dev] [PATCH v7 0/5] vhost: handle memory hotplug for async vhost

2021-07-23 Thread Thomas Monjalon
23/07/2021 07:06, Xia, Chenbo: > From: Thomas Monjalon > > 22/07/2021 07:07, Xia, Chenbo: > > > From: Jiang, Cheng1 > > > > When the guest memory is hotplugged, the vhost application which > > > > enables DMA acceleration must stop DMA transfers before the vhost > > > > re-maps the guest memory.

[dpdk-dev] RFC: Enahancements to Rx adapter for DPDK 21.11

2021-07-23 Thread Kundapura, Ganapati
Hi dpdk-dev, We would like to submit series of patches to Rx adapters that will enhance the configuration and performance. Please find the details below. (1) Configure Rx event buffer at run time Add new api to configure the size of the Rx event buffer at run time. This api allows setting