Re: [dpdk-dev] [PATCH] net/ena: enable multi segment in Tx offload flags

2021-07-28 Thread Michał Krawczyk
śr., 28 lip 2021 o 16:27 Olivier Matz napisał(a): > > Hi Michał, > > On Wed, Jul 14, 2021 at 12:02:32PM +0200, Michał Krawczyk wrote: > > pon., 12 lip 2021 o 19:03 Ghalem Boudour > > napisał(a): > > > > > > The DPDK ENA driver does not provide multi-segment tx offload capability. > > > Let's add

[dpdk-dev] [PATCH v4] bus: clarify log for non-NUMA-aware devices

2021-07-28 Thread Dmitry Kozlyuk
PCI, vmbus, and auxiliary drivers printed a warning when NUMA node had beed reported as (-1) or not reported by OS: EAL: Invalid NUMA socket, default to 0 This message and its level might confuse users, because configuration is valid and nothing happens that requires attention or interventi

Re: [dpdk-dev] [PATCH v11 1/2] dmadev: introduce DMA device library

2021-07-28 Thread fengchengwen
Thanks, inline comment On 2021/7/28 19:13, Bruce Richardson wrote: > On Tue, Jul 27, 2021 at 11:39:59AM +0800, Chengwen Feng wrote: >> This patch introduce 'dmadevice' which is a generic type of DMA >> device. >> >> The APIs of dmadev library exposes some generic operations which can >> enable con

Re: [dpdk-dev] [PATCH 0/4] net/mlx5: keep indirect actions across port restart

2021-07-28 Thread Ori Kam
Hi, > -Original Message- > From: Dmitry Kozlyuk > Sent: Wednesday, July 28, 2021 5:08 PM > > > -Original Message- > > From: Andrew Rybchenko > > Sent: 28 июля 2021 г. 15:27 > > To: Dmitry Kozlyuk ; dev@dpdk.org > > Cc: David Marchand > > Subject: Re: [dpdk-dev] [PATCH 0/4] net/

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix TX checksum calculation for tunnel

2021-07-28 Thread Gregory Etelson
Hello Oliver, Please see my comments below > On Tue, Jul 27, 2021 at 04:07:57PM +0300, Gregory Etelson wrote: > > TX checksum of a tunnelled packet can be calculated for outer headers > > only or for both outer and inner parts. The calculation method is > > determined by application. > > If TX ch

[dpdk-dev] [PATCH] net/mlx5: fix timestamp initialization on empty clock queue

2021-07-28 Thread Viacheslav Ovsiienko
The committing completions by clock queue might be delayed after queue initialization done and the only Clock Queue completion entry (CQE) might keep the invalid status till the CQE first update happens. The mlx5_txpp_update_timestamp() wrongly recognized invalid status as error and reported about

Re: [dpdk-dev] [PATCH 0/4] net/mlx5: keep indirect actions across port restart

2021-07-28 Thread Dmitry Kozlyuk
> -Original Message- > From: Andrew Rybchenko > Sent: 28 июля 2021 г. 15:27 > To: Dmitry Kozlyuk ; dev@dpdk.org > Cc: David Marchand > Subject: Re: [dpdk-dev] [PATCH 0/4] net/mlx5: keep indirect actions across > port > restart > > External email: Use caution opening links or attachments

Re: [dpdk-dev] [PATCH] net/mlx5: limit implicitly MPLS RSS expansion

2021-07-28 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Wednesday, July 28, 2021 11:24 AM > To: Slava Ovsiienko ; Matan Azrad > > Cc: Raslan Darawsheh ; dev@dpdk.org > Subject: [PATCH] net/mlx5: limit implicitly MPLS RSS expansion > > As [1] optimized the MPLS RSS expansion before, this c

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal/ppc: ignore gcc 10 stringop-overflow warnings

2021-07-28 Thread David Christensen
On 7/12/21 12:35 PM, David Christensen wrote: On 7/5/21 2:28 AM, David Marchand wrote: On Wed, Jun 23, 2021 at 6:13 PM David Christensen wrote: Suppress gcc warning "warning: writing 16 bytes into a region of size 0" for users of the POWER rte_memcpy() function.  Existing rte_memcpy() co

Re: [dpdk-dev] [PATCH v2 0/2] net/mlx5: prevent RSS distribution by L4 proto alone

2021-07-28 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Lior Margalit > Sent: Tuesday, July 27, 2021 9:46 AM > To: Matan Azrad > Cc: Lior Margalit ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2 0/2] net/mlx5: prevent RSS distribution by L4 > proto alone > > Set proper selection flags for the

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix mirror flow split with L3 encapsulation

2021-07-28 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Jiawei(Jonny) Wang > Sent: Monday, July 26, 2021 9:23 AM > To: Slava Ovsiienko ; Matan Azrad > ; Ori Kam ; NBU-Contact-Thomas > Monjalon ; Shahaf Shuler > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: [PATCH v2] net/mlx5: fix mirror fl

[dpdk-dev] [PATCH 2/2] crypto/qat: fix asymmetric crypto pmd create on gen3

2021-07-28 Thread Arek Kusztal
This patch disables asymmetric crypto pmd on gen3 devices. Fixes: 1f5e4053f9b4 ("common/qat: support GEN3 devices") Signed-off-by: Arek Kusztal --- drivers/crypto/qat/qat_asym_pmd.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/crypto/qat/qat_asym_pmd.c b/drivers/crypto/qat/q

[dpdk-dev] [PATCH 1/2] drivers/qat: fix wrong return value for invalid service

2021-07-28 Thread Arek Kusztal
Fix invalid value that is returned when asymmetric crypto or compression service is selected. Fixes: 8f393c4ffdc1 ("common/qat: support GEN4 devices") Signed-off-by: Arek Kusztal --- drivers/compress/qat/qat_comp_pmd.c | 2 +- drivers/crypto/qat/qat_asym_pmd.c | 2 +- 2 files changed, 2 inser

[dpdk-dev] [PATCH 0/2] drivers/qat: fix handling of unsupported services

2021-07-28 Thread Arek Kusztal
This patchset fixes wrong behaviour when service not currently supported is selected for GEN3 and GEN4 devices in Intel QuickAssist Technology PMD. There is dependency between these patches hence the patchset. This patcheset superseeds following patch: drivers/qat: fix unused asymmetric crypto pmd

Re: [dpdk-dev] [PATCH 0/4] net/mlx5: keep indirect actions across port restart

2021-07-28 Thread Ori Kam
Hi Dmitry and Andrew, > -Original Message- > From: dev On Behalf Of Dmitry Kozlyuk > Sent: Wednesday, July 28, 2021 2:19 PM > > Hi Andrew, > > > From: Andrew Rybchenko On 7/27/21 > > 10:31 AM, Dmitry Kozlyuk wrote: > > > It was unspecified what happens to indirect actions when a port i

Re: [dpdk-dev] [PATCH v3] net: fix Intel-specific Prepare the outer ipv4 hdr for checksum

2021-07-28 Thread Andrew Rybchenko
On 7/7/21 12:40 PM, Mohsin Kazmi wrote: Preparation the headers for the hardware offload misses the outer ipv4 checksum offload. It results in bad checksum computed by hardware NIC. This patch fixes the issue by setting the outer ipv4 checksum field to 0. Fixes: 4fb7e803eb1a ("ethdev: add Tx pr

Re: [dpdk-dev] [PATCH] doc: announce removal of ABIs in PCI bus driver

2021-07-28 Thread Andrew Rybchenko
On 7/27/21 11:44 AM, Bruce Richardson wrote: On Mon, Jul 26, 2021 at 05:56:17AM +, Xia, Chenbo wrote: Hi, Ferruh -Original Message- From: Yigit, Ferruh Sent: Friday, July 23, 2021 8:47 PM To: Xia, Chenbo ; dev@dpdk.org; tho...@monjalon.net Cc: m...@ashroe.eu; nhor...@tuxdriver.com

Re: [dpdk-dev] [PATCH 2/3] mbuf: avoid cast-align warning in pktmbuf mtod offset macro

2021-07-28 Thread Olivier Matz
On Tue, Jul 13, 2021 at 09:49:09AM +0300, Eli Britstein wrote: > In rte_pktmbuf_mtod_offset macro, there is a casting from char * to type > 't', which may cause cast-align warning when using gcc flags > '-Werror -Wcast-align': > > .../include/rte_mbuf_core.h:723:3: error: cast increases required a

[dpdk-dev] [PATCH] drivers: add external clock support for cnxk timer

2021-07-28 Thread Shijith Thotton
To configure tim with external clock, requested resolution should be adjusted based on core and external clock frequency for accuracy. tim_ext_clk is the devarg used to pass external clock frequency. E.g. -a 0002:0e:00.0,tim_ext_clk=12288 Signed-off-by: Shijith Thotton Signed-off-by: Pavan

[dpdk-dev] [PATCH] eal: add macro to swap two numbers

2021-07-28 Thread Shijith Thotton
Added a macro to swap two numbers and updated common autotest for the same. Signed-off-by: Shijith Thotton --- Needed-for: drivers: add external clock support for cnxk timer app/test/test_common.c | 4 lib/eal/include/rte_common.h | 8 2 files changed, 12 insertions(+) diff

Re: [dpdk-dev] [PATCH 0/4] net/mlx5: keep indirect actions across port restart

2021-07-28 Thread Dmitry Kozlyuk
Hi Andrew, > From: Andrew Rybchenko > On 7/27/21 10:31 AM, Dmitry Kozlyuk wrote: > > It was unspecified what happens to indirect actions when a port is > > stopped, possibly reconfigured, and started again. MLX5 PMD, the first > > one to use indirect actions, intended to keep them across such a >

[dpdk-dev] [Bug 762] How do I log into my router without a password?

2021-07-28 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=762 Ajit Khaparde (ajit.khapa...@broadcom.com) changed: What|Removed |Added CC||ajit.khapa...@broadcom

Re: [dpdk-dev] [PATCH 2/2] lib/security: add SA lifetime configuration

2021-07-28 Thread Anoob Joseph
Hi Akhil, Konstantin, Now that we have an agreement on bitfields (hoping no one else has an objection), I would like to discuss one more topic. It is more related to checksum offload, but it's better that we discuss along with other similar items (like soft expiry). L3 & L4 checksum can be tri

Re: [dpdk-dev] [PATCH] net/ena: enable multi segment in Tx offload flags

2021-07-28 Thread Olivier Matz
Hi Michał, On Wed, Jul 14, 2021 at 12:02:32PM +0200, Michał Krawczyk wrote: > pon., 12 lip 2021 o 19:03 Ghalem Boudour > napisał(a): > > > > The DPDK ENA driver does not provide multi-segment tx offload capability. > > Let's add DEV_TX_OFFLOAD_MULTI_SEGS to ports offload capability by default. >

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix TX checksum calculation for tunnel

2021-07-28 Thread Olivier Matz
Hi Gregory, Few comments below. On Tue, Jul 27, 2021 at 04:07:57PM +0300, Gregory Etelson wrote: > TX checksum of a tunnelled packet can be calculated for outer headers > only or for both outer and inner parts. The calculation method is > determined by application. > If TX checksum calculation ca

Re: [dpdk-dev] [PATCH 1/1] net/mlx5: fix typo in flow engine type

2021-07-28 Thread Matan Azrad
From: Asaf Penso > The concrete function names have a prefix for flow_dv. > This emphasizes the flow engine is direct verbs. > > The function flow_get_aged_flows doesn’t have this prefix. > It creates an inconsistency with the other functions. > > Update the function name to include dv. > > Fi

Re: [dpdk-dev] [PATCH 4/4] ethdev: document indirect flow action life cycle

2021-07-28 Thread Ori Kam
Hi Dmitry, > -Original Message- > From: Dmitry Kozlyuk > Sent: Tuesday, July 27, 2021 10:31 AM > > Subject: [PATCH 4/4] ethdev: document indirect flow action life cycle > > rte_flow_action_handle_create() did not specify what happens with an > indirect action when device is stopped, poss

[dpdk-dev] [PATCH] app/testpmd: fix vm_hotplug after removal of rte_eth_devices

2021-07-28 Thread Paulis Gributs
After removing rte_eth_devices from testpmd the vm_hotplug no longer recovered after removal of a device, this patch fixes this issue. Fixes: 0a0821bcf312 ("app/testpmd: remove most uses of internal ethdev array") Signed-off-by: Paulis Gributs --- app/test-pmd/testpmd.c | 8 +--- 1 file cha

[dpdk-dev] [PATCH 1/1] net/mlx5: fix typo in flow engine type

2021-07-28 Thread Asaf Penso
The concrete function names have a prefix for flow_dv. This emphasizes the flow engine is direct verbs. The function flow_get_aged_flows doesn’t have this prefix. It creates an inconsistency with the other functions. Update the function name to include dv. Fixes: fa2d01c87d2 ("net/mlx5: support

Re: [dpdk-dev] [PATCH 2/2] lib/security: add SA lifetime configuration

2021-07-28 Thread Akhil Goyal
Hi Konstantin, > Hi Akhil, > > > > > > My vote would probably be for option #2 (use one of the reserved > fields > > > for > > > > > it). > > > > > That way - existing code wouldn't need to be changed. > > > > > > > > Adding a single enum or multiple enums is the same thing. Right wrt > code > > >

Re: [dpdk-dev] [PATCH 0/4] net/mlx5: keep indirect actions across port restart

2021-07-28 Thread Andrew Rybchenko
On 7/28/21 2:18 PM, Dmitry Kozlyuk wrote: Hi Andrew, From: Andrew Rybchenko On 7/27/21 10:31 AM, Dmitry Kozlyuk wrote: It was unspecified what happens to indirect actions when a port is stopped, possibly reconfigured, and started again. MLX5 PMD, the first one to use indirect actions, intende

[dpdk-dev] [PATCH] net/mlx5: limit implicitly MPLS RSS expansion

2021-07-28 Thread Suanming Mou
As [1] optimized the MPLS RSS expansion before, this commit limits the implicitly MPLS RSS expansion for MPLSoGRE as well. For the RSS flow matcher to GRE level only, it will not expand the MPLS match item for the sub flows due to performance consideration. The original RSS flow match item: ETH VL

Re: [dpdk-dev] [RFC] ethdev: introduce shared Rx queue

2021-07-28 Thread Xueming(Steven) Li
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Wednesday, July 28, 2021 3:57 PM > To: Xueming(Steven) Li > Cc: dev@dpdk.org; Slava Ovsiienko ; > NBU-Contact-Thomas Monjalon ; Ferruh > Yigit > Subject: Re: [RFC] ethdev: introduce shared Rx queue > > On 7/27/21 6:42 AM

[dpdk-dev] [PATCH v2] examples/l2fwd-crypto: support cipher multiple data-unit

2021-07-28 Thread Matan Azrad
The support for multiple data-units includes the next: - Add a new command-line argument to provide the data-unit length. - Set the length in the cipher xform. - Validate device capabilities for this feature. - Pad the AES-XTS operation length to be aligned to the defined data-unit. Signed-off-by:

Re: [dpdk-dev] [PATCH] net/mlx5: fix queue leaking in hairpin auto bind checking

2021-07-28 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Saturday, July 24, 2021 4:27 PM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Ori Kam ; Raslan Darawsheh > ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix queue leaking in hairpin auto bind checking > > During the start up

Re: [dpdk-dev] [PATCH v11 1/2] dmadev: introduce DMA device library

2021-07-28 Thread Bruce Richardson
On Tue, Jul 27, 2021 at 11:39:59AM +0800, Chengwen Feng wrote: > This patch introduce 'dmadevice' which is a generic type of DMA > device. > > The APIs of dmadev library exposes some generic operations which can > enable configuration and I/O with the DMA devices. > > Signed-off-by: Chengwen Feng

Re: [dpdk-dev] [PATCH v2] net/memif: fix abstract socket addr_len

2021-07-28 Thread Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
> -Original Message- > From: Nathan Skrzypczak > Sent: Friday, July 23, 2021 11:19 AM > To: dev@dpdk.org > Cc: andrew.rybche...@oktetlabs.ru; Jakub Grajciar -X (jgrajcia - PANTHEON > TECH SRO at Cisco) > Subject: [PATCH v2] net/memif: fix abstract socket addr_len > > This fixes using abs

Re: [dpdk-dev] [dpdk-announce] release candidate 21.08-rc2

2021-07-28 Thread Jiang, YuX
Hi All, Update the test status for Intel part. Till now dpdk21.08-rc2 test execution rate is 90%. No critical issue is found. # Basic Intel(R) NIC testing * Build or compile: *Build: cover the build test combination with latest GCC/Clang/ICC version and the popular OS revision such as Ubu

Re: [dpdk-dev] [PATCH 2/2] lib/security: add SA lifetime configuration

2021-07-28 Thread Ananyev, Konstantin
Hi Akhil, > > > > > There are two options that we considered, > > > > > 1. Extend the enum, rte_crypto_op_status, to cover warnings [1] > > > > > 2. There are reserved fields in rte_cryto_op structure. So we can use > > bits in > > > > them to indicate various cases. [2] > > > > > > > > > > Both

Re: [dpdk-dev] [PATCH v2] eventdev: fix event port setup in tx adapter

2021-07-28 Thread Jayatheerthan, Jay
> -Original Message- > From: Jerin Jacob > Sent: Wednesday, July 28, 2021 3:01 PM > To: Jayatheerthan, Jay > Cc: Naga Harish K, S V ; dev@dpdk.org > Subject: Re: [PATCH v2] eventdev: fix event port setup in tx adapter > > On Wed, Jul 28, 2021 at 12:14 PM Jayatheerthan, Jay > wrote: > >

Re: [dpdk-dev] [PATCH v3 4/8] test/mcslock: use compiler atomics for lcores sync

2021-07-28 Thread Olivier Matz
Hi Joyce, On Mon, Jul 19, 2021 at 10:51:21PM -0500, Joyce Kong wrote: > Convert rte_atomic usages to compiler atomic built-ins for lcores > sync in mcslock testcases. > > Signed-off-by: Joyce Kong > Reviewed-by: Ruifeng Wang > Acked-by: Stephen Hemminger > --- > app/test/test_mcslock.c | 14 +

Re: [dpdk-dev] [PATCH v2] eventdev: fix event port setup in tx adapter

2021-07-28 Thread Jerin Jacob
On Wed, Jul 28, 2021 at 12:14 PM Jayatheerthan, Jay wrote: > > > -Original Message- > > From: Naga Harish K, S V > > Sent: Saturday, July 24, 2021 7:41 PM > > To: Jayatheerthan, Jay ; jerinjac...@gmail.com > > Cc: dev@dpdk.org > > Subject: [PATCH v2] eventdev: fix event port setup in tx a

[dpdk-dev] [Bug 762] How do I log into my router without a password?

2021-07-28 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=762 Bug ID: 762 Summary: How do I log into my router without a password? Product: DPDK Version: 20.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix TX checksum calculation for tunnel

2021-07-28 Thread Ajit Khaparde
On Tue, Jul 27, 2021 at 6:08 AM Gregory Etelson wrote: > > TX checksum of a tunnelled packet can be calculated for outer headers > only or for both outer and inner parts. The calculation method is > determined by application. > If TX checksum calculation can be offloaded, hardware ignores > existi

Re: [dpdk-dev] [PATCH 0/4] net/mlx5: keep indirect actions across port restart

2021-07-28 Thread Andrew Rybchenko
On 7/27/21 10:31 AM, Dmitry Kozlyuk wrote: It was unspecified what happens to indirect actions when a port is stopped, possibly reconfigured, and started again. MLX5 PMD, the first one to use indirect actions, intended to keep them across such a sequence, but the implementation was buggy. Patches

Re: [dpdk-dev] [RFC] ethdev: introduce shared Rx queue

2021-07-28 Thread Andrew Rybchenko
On 7/27/21 6:42 AM, Xueming Li wrote: In eth PMD driver model, each RX queue was pre-loaded with mbufs for saving incoming packets. When number of SF or VF scale out in a switch domain, the memory consumption became significant. Most important, polling all ports leads to high cache miss, high lat

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix TX checksum calculation for tunnel

2021-07-28 Thread Gregory Etelson
Hello, Please see below. Regards, Gregory > > Subject: [PATCH v2] app/testpmd: fix TX checksum calculation for > > tunnel > > > > TX checksum of a tunnelled packet can be calculated for outer headers > > only or for both outer and inner parts. The calculation method is > > determined by applicat

Re: [dpdk-dev] [RFC] ethdev: change queue release callback

2021-07-28 Thread Andrew Rybchenko
On 7/27/21 6:41 AM, Xueming Li wrote: To align with other eth device queue configuration callbacks, change RX and TX queue release callback API parameter from queue object to device and queue index. Signed-off-by: Xueming Li In fact, there is no strong reasons to do it, but I think it is a ni

[dpdk-dev] [PATCH v1] test/func_reentrancy: free memzones after creating test case

2021-07-28 Thread Joyce Kong
Function reentrancy test limits maximum number of iterations simultaneously, however it doesn't free the 'fr_test_once' memzones after the fact, so introduce freeing 'fr_test_once' in ring/mempool/hash/fbk/lpm_clean. Fixes: 104a92bd026f ("app: add reentrancy tests") Fixes: 995eec619024 ("test: cle

[dpdk-dev] 回复: [PATCH v1 2/2] devtools: use absolute path for the build directory

2021-07-28 Thread Feifei Wang
Hi, Bruce Sorry to disturb you again. Would you please help review the second patch of this series? Thanks very much. Best Regards Feifei > -邮件原件- > 发件人: Feifei Wang > 发送时间: Tuesday, June 1, 2021 9:57 AM > 收件人: Bruce Richardson > 抄送: dev@dpdk.org; nd ; Phil Yang ; > Juraj Linkeš ; Feif

Re: [dpdk-dev] [PATCH v3 8/8] test/rcu: use compiler atomics for data sync

2021-07-28 Thread Joyce Kong
> -Original Message- > From: Andrew Rybchenko > Sent: Saturday, July 24, 2021 3:52 AM > To: Joyce Kong ; tho...@monjalon.net; > david.march...@redhat.com; roret...@linux.microsoft.com; > step...@networkplumber.org; olivier.m...@6wind.com; > harry.van.haa...@intel.com; Honnappa Nagarahalli