[dpdk-dev] [Bug 771] [dpdk-21.08]loopback csum fwd performance drop when fwd 8k large pkts

2021-08-03 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=771 Bug ID: 771 Summary: [dpdk-21.08]loopback csum fwd performance drop when fwd 8k large pkts Product: DPDK Version: 21.08 Hardware: All OS: All Status: UNC

Re: [dpdk-dev] [PATCH v2] doc: announce changes to eventdev library

2021-08-03 Thread Gujjar, Abhinandan S
> -Original Message- > From: Jerin Jacob > Sent: Tuesday, August 3, 2021 9:43 AM > To: Pavan Nikhilesh ; Gujjar, Abhinandan S > ; Carrillo, Erik G ; > Van Haaren, Harry ; Hemant Agrawal > ; McDaniel, Timothy > ; Liang Ma ; > Jayatheerthan, Jay > Cc: Jerin Jacob ; Ray Kinsella ; dpdk- >

Re: [dpdk-dev] [PATCH v2] doc: announce changes to eventdev library

2021-08-03 Thread Jayatheerthan, Jay
> -Original Message- > From: Jerin Jacob > Sent: Tuesday, August 3, 2021 9:43 AM > To: Pavan Nikhilesh ; Gujjar, Abhinandan S > ; Carrillo, Erik G > ; Van Haaren, Harry ; > Hemant Agrawal ; > McDaniel, Timothy ; Liang Ma > ; Jayatheerthan, Jay > > Cc: Jerin Jacob ; Ray Kinsella ; dpdk-

[dpdk-dev] [PATCH V1] doc: add tested Intel platforms with Intel NICs

2021-08-03 Thread Yan Xia
Add tested Intel platforms with Intel NICs to v21.08 release note. Signed-off-by: Yan Xia --- doc/guides/rel_notes/release_21_08.rst | 108 + 1 file changed, 108 insertions(+) diff --git a/doc/guides/rel_notes/release_21_08.rst b/doc/guides/rel_notes/release_21_08.rst i

[dpdk-dev] [Bug 770] The softnic start service rte_pmd_softnic_run_internal, when testpmd close port, segmentation fault will appear.

2021-08-03 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=770 Bug ID: 770 Summary: The softnic start service rte_pmd_softnic_run_internal, when testpmd close port, segmentation fault will appear. Product: DPDK Version: 21.08

Re: [dpdk-dev] [PATCH 00/22] backport feature support to DPDK 20.11

2021-08-03 Thread Min Hu (Connor)
Hi, all, Features could be backport to TLS version? It is surprising. 在 2021/8/3 16:37, Wenjun Wu 写道: enable QinQ filter for switch

[dpdk-dev] [PATCH v2] net/virtio: fix repeated memory free of vq

2021-08-03 Thread Gaoxiang Liu
When virtio_init_queue returns error, the memory of vq is freed. But the value of hw->vqs[queue_idx] does not restore. If hw->vqs[queue_idx] != NULL, the memory of vq is freed again in virtio_free_queues. Fixes: 69c80d4ef89b ("net/virtio: allocate queue at init stage") Cc: sta...@dpdk.org Signed-

[dpdk-dev] [PATCH v2] net/virtio: fix repeated memory free of vq

2021-08-03 Thread Gaoxiang Liu
When virtio_init_queue returns error, the memory of vq is freed. But the value of hw->vqs[queue_idx] does not restore. If hw->vqs[queue_idx] != NULL, the memory of vq is freed again in virtio_free_queues. Fixes: 69c80d4ef89b ("net/virtio: allocate queue at init stage") Cc: sta...@dpdk.org Signed-

Re: [dpdk-dev] [PATCH] doc: announce cryptodev-PMD interface as internal

2021-08-03 Thread Ajit Khaparde
On Tue, Aug 3, 2021 at 4:45 AM Akhil Goyal wrote: > > The APIs which are internal to PMD and cryptodev library > can be marked as internal so that ABI checking do not > shout for changes in APIs which are internal to DPDK. > > Signed-off-by: Akhil Goyal Acked-by: Ajit Khaparde > --- > doc/guid

[dpdk-dev] [PATCH] doc: limit FW support for mlx5 RegEx device

2021-08-03 Thread Ori Kam
MLX5 RegEx is only supported with FW version XX.30.1004 or lower. Signed-off-by: Ori Kam Acked-by: Asaf Penso --- doc/guides/regexdevs/mlx5.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/regexdevs/mlx5.rst b/doc/guides/regexdevs/mlx5.rst index 45a0b96980..f8000579f1 100

[dpdk-dev] [PATCH v1] net/mlx5: fix RSS expansion for inner tunnel VLAN

2021-08-03 Thread Lior Margalit
The RSS expansion alg is using a graph to find the possible expansion paths. The VLAN item in the flow pattern requires special treatment, because it should not be added implicitly by the expansion alg. If the flow pattern ends with ETH item, the pattern will be expanded with IPv4 and IPv6. For exa

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: announce change to action modify data

2021-08-03 Thread Ajit Khaparde
On Tue, Aug 3, 2021 at 1:58 AM Ori Kam wrote: > > In the current implementation, > the action rte_flow_action_modify_field is not well defined > for fields larger than 64 bits (for example IPv6 source) > In addition, the byte order is also not well defined. > > Both of those issue should be fixed.

Re: [dpdk-dev] [PATCH] net: announce changes in IPv4 header

2021-08-03 Thread Ajit Khaparde
On Mon, Aug 2, 2021 at 5:38 AM Akhil Goyal wrote: > > > > -Original Message- > > > From: dev On Behalf Of Gregory Etelson > > > Sent: Monday, August 2, 2021 13:39 > > > To: dev@dpdk.org > > > Cc: Gregory Etelson ; Matan Azrad > > > ; Raslan Darawsheh ; Ori Kam > > > ; Ray Kinsella > > >

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: announce moving to general modify function

2021-08-03 Thread Ajit Khaparde
On Tue, Aug 3, 2021 at 1:58 AM Ori Kam wrote: > > Currently there is a dedicated modify function for each > field that the application wants to change. > For example: > rte_flow_action_type_set_tp_port to modify destination port of UDP/TCP. > rte_flow_action_type_set_ipv4_dst to modify destination

Re: [dpdk-dev] [PATCH] doc: announce changes in security session struct

2021-08-03 Thread Ajit Khaparde
On Tue, Aug 3, 2021 at 5:36 AM Ananyev, Konstantin wrote: > > > > The structure rte_security_session is not directly used > > by the application. The application just need an opaque > > pointer to attached to the mbuf or rte_crypto_op while > > enqueue. Hence, it can be hidden inside the library >

[dpdk-dev] [PATCH] net/mlx5: fix find sibling devices

2021-08-03 Thread Gregory Etelson
The routine mlx5_eth_find_next() and related iterating macro MLX5_ETH_FOREACH_DEV is used to iterate through sibling devices (all representors share the same configuration and switching domain) on top of specified root device. The root device parameter was specified as NULL, and it caused the miss

[dpdk-dev] [PATCH v13 09/10] eal: add EAL argument for setting thread priority

2021-08-03 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Allow the user to choose the thread priority through an EAL command line argument. The user can choose thread priority through an EAL parameter, when starting an application. If EAL parameter is not used, the per-platform default value for thread priority is used. Otherwise

[dpdk-dev] [PATCH v13 10/10] Add unit tests for thread API

2021-08-03 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile As a new API for threading is introduced, a set of unit tests have been added to test the new interface. Signed-off-by: Narcisa Vasile --- app/test/meson.build| 2 + app/test/test_threads.c | 419 2 files changed, 421 insertio

[dpdk-dev] [PATCH v13 08/10] eal: implement functions for thread barrier management

2021-08-03 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for barrier init, destroy, wait. A portable type is used to represent a barrier identifier. The rte_thread_barrier_wait() function returns the same value on all platforms. Signed-off-by: Narcisa Vasile --- lib/eal/common/rte_thread.c | 61 ++

[dpdk-dev] [PATCH v13 07/10] eal: implement functions for mutex management

2021-08-03 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for mutex init, destroy, lock, unlock. Add RTE_STATIC_MUTEX macro to replace static initialization of mutexes. Windows does not have a static initializer. Initialization is only done through InitializeCriticalSection(). The RTE_STATIC_MUTEX calls into the rte_

[dpdk-dev] [PATCH v13 05/10] eal: implement thread priority management functions

2021-08-03 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add function for setting the priority for a thread. Priorities on multiple platforms are similarly determined by a priority value and a priority class/policy. On Linux, the following mapping is created: RTE_THREAD_PRIORITY_NORMAL corresponds to * policy SCHED_OTHER * priorit

[dpdk-dev] [PATCH v13 06/10] eal: add thread lifetime management

2021-08-03 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for thread creation, joining, detaching. The *rte_thread_create()* function can optionally receive an rte_thread_attr_t object that will cause the thread to be created with the affinity and priority described by the attributes object. If no rte_thread_attr_t is

[dpdk-dev] [PATCH v13 04/10] eal: implement functions for thread affinity management

2021-08-03 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Implement functions for getting/setting thread affinity. Threads can be pinned to specific cores by setting their affinity attribute. Signed-off-by: Narcisa Vasile Signed-off-by: Dmitry Malloy --- lib/eal/common/rte_thread.c | 16 lib/eal/include/rte_thread.h |

[dpdk-dev] [PATCH v13 03/10] eal/windows: translate Windows errors to errno-style errors

2021-08-03 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add function to translate Windows error codes to errno-style error codes. The possible return values are chosen so that we have as much semantical compatibility between platforms as possible. Signed-off-by: Narcisa Vasile --- lib/eal/common/rte_thread.c | 6 +-- lib/eal/

[dpdk-dev] [PATCH v13 02/10] eal: add thread attributes

2021-08-03 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Implement thread attributes for: * thread affinity * thread priority Implement functions for managing thread attributes. Priority is represented through an enum that allows for two levels: - RTE_THREAD_PRIORITY_NORMAL - RTE_THREAD_PRIORITY_REALTIME_CRITICAL

[dpdk-dev] [PATCH v13 01/10] eal: add basic threading functions

2021-08-03 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Use a portable, type-safe representation for the thread identifier. Add functions for comparing thread ids and obtaining the thread id for the current thread. Signed-off-by: Narcisa Vasile --- lib/eal/common/meson.build| 1 + lib/eal/{unix => common}/rte_threa

[dpdk-dev] [PATCH v13 00/10] eal: Add EAL API for threading

2021-08-03 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile EAL thread API **Problem Statement** DPDK currently uses the pthread interface to create and manage threads. Windows does not support the POSIX thread programming model, so it currently relies on a header file that hides the Windows calls under pthread matched interfaces. Gi

Re: [dpdk-dev] [dpdk-announce] release candidate 21.08-rc3

2021-08-03 Thread Thinh Tran
Hi IBM - Power Systems DPDK 21.08-rc3 * Basic PF on Mellanox: No new issues or regressions were seen. * Performance: not tested. Systems tested: - IBM Power9 PowerNV 9006-22P OS: RHEL 8.3 GCC: version 8.3.1 20191121 (Red Hat 8.3.1-5) NICs: - Mellanox Technologies MT28800 Famil

Re: [dpdk-dev] [PATCH 2/2] doc: update the offload information for Metering Hierarchy

2021-08-03 Thread Asaf Penso
>-Original Message- >From: Jiawei(Jonny) Wang >Sent: Tuesday, August 3, 2021 4:03 PM >To: Slava Ovsiienko ; Matan Azrad >; Asaf Penso ; NBU-Contact- >Thomas Monjalon ; Shahaf Shuler > >Cc: dev@dpdk.org; Raslan Darawsheh >Subject: [PATCH 2/2] doc: update the offload information for Meterin

Re: [dpdk-dev] [PATCH 1/2] doc: update the offload information for ASO Metering

2021-08-03 Thread Asaf Penso
>-Original Message- >From: Jiawei(Jonny) Wang >Sent: Tuesday, August 3, 2021 4:03 PM >To: Slava Ovsiienko ; Matan Azrad >; Asaf Penso ; NBU-Contact- >Thomas Monjalon ; Shahaf Shuler > >Cc: dev@dpdk.org; Raslan Darawsheh >Subject: [PATCH 1/2] doc: update the offload information for ASO Met

[dpdk-dev] [PATCH 1/2] doc: update the offload information for ASO Metering

2021-08-03 Thread Jiawei Wang
Updates the Minimal SW and HW Version offload support information for ASO metering. Signed-off-by: Jiawei Wang --- doc/guides/nics/mlx5.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 3e9c736cae..42559cf261 100644 --- a/doc/g

[dpdk-dev] [PATCH 2/2] doc: update the offload information for Metering Hierarchy

2021-08-03 Thread Jiawei Wang
Updates the Minimal SW and HW Version offload support information for Metering hierarchy. Signed-off-by: Jiawei Wang --- doc/guides/nics/mlx5.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 42559cf261..b6b8ecb3a0 100644 --- a

[dpdk-dev] [PATCH v4] doc: policy on the promotion of experimental APIs

2021-08-03 Thread Ray Kinsella
Clarifying the ABI policy on the promotion of experimental APIS to stable. We have a fair number of APIs that have been experimental for more than 2 years. This policy amendment indicates that these APIs should be promoted or removed, or should at least form a conservation between the maintainer an

Re: [dpdk-dev] [dpdk-ci] [PATCH v12 01/10] eal: add basic threading functions

2021-08-03 Thread Owen Hilyard
Our windows servers are both running 0.57.1, but all of the *nix hosts are running 0.58.1. This issue also happens on 0.57.1 and 0.57.2, with the exact same steps to reproduce. On Tue, Aug 3, 2021 at 11:38 AM Dmitry Kozlyuk wrote: > 2021-08-03 11:11 (UTC-0400), Owen Hilyard: > > It seems like me

Re: [dpdk-dev] [PATCH] doc: abstract the behaviour of rte_ctrl_thread_create

2021-08-03 Thread Honnappa Nagarahalli
Hi Olivier, Any comments on this? Thanks, Honnappa > > > > > > The current expected behaviour of the function > > > rte_ctrl_thread_create is rigid which makes the implementation of the > function complex. > > > Make the expected behaviour abstract to allow for simplified > > > implemen

Re: [dpdk-dev] [dpdk-ci] [PATCH v12 01/10] eal: add basic threading functions

2021-08-03 Thread Dmitry Kozlyuk
2021-08-03 11:11 (UTC-0400), Owen Hilyard: > It seems like meson encountered an error when building > > app/test/meson.build:472:11: ERROR: Index 1 out of bounds of array of size > > 1. > > > > A full log can be found at > > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/

Re: [dpdk-dev] [dpdk-ci] [PATCH v12 01/10] eal: add basic threading functions

2021-08-03 Thread Owen Hilyard
It seems like meson encountered an error when building app/test/meson.build:472:11: ERROR: Index 1 out of bounds of array of size > 1. > > A full log can be found at > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/build/meson-logs/meson-log.txt > ninja: error: loadi

Re: [dpdk-dev] Fwd: [dpdk] Patch notification: 6 patches updated

2021-08-03 Thread Thomas Monjalon
03/08/2021 15:19, fengchengwen: > On 2021/8/3 20:59, Thomas Monjalon wrote: > > 03/08/2021 14:54, fengchengwen: > >> Hi, Thomas > >> > >> Why the dmadev patchset v12/13 both deferred ? Does it have anything to do > >> with > >> the completion of 21.08? > > > > We are fixing the last critical bugs

Re: [dpdk-dev] [PATCH v13 5/6] doc: add DMA device library guide

2021-08-03 Thread Jerin Jacob
On Tue, Aug 3, 2021 at 5:03 PM Chengwen Feng wrote: > > This patch adds dmadev library guide. > > Signed-off-by: Chengwen Feng > --- > doc/guides/prog_guide/dmadev.rst| 126 +++ doc build has following warning in my machine ninja: Entering directory `build' [2789/2813] Gene

Re: [dpdk-dev] [PATCH v3] doc: policy on the promotion of experimental APIs

2021-08-03 Thread Kinsella, Ray
On 11/07/2021 08:22, Jerin Jacob wrote: > On Sat, Jul 10, 2021 at 12:46 AM Tyler Retzlaff > wrote: >> >> On Fri, Jul 09, 2021 at 11:46:54AM +0530, Jerin Jacob wrote: + +Promotion to stable +~~~ + +Ordinarily APIs marked as ``experimental`` will be promot

Re: [dpdk-dev] Fwd: [dpdk] Patch notification: 6 patches updated

2021-08-03 Thread fengchengwen
On 2021/8/3 20:59, Thomas Monjalon wrote: > 03/08/2021 14:54, fengchengwen: >> Hi, Thomas >> >> Why the dmadev patchset v12/13 both deferred ? Does it have anything to do >> with >> the completion of 21.08? > > We are fixing the last critical bugs to close 21.08 this week. > We don't accept new f

Re: [dpdk-dev] [PATCH] net/mlx5: workaround not supported drop action on the root table

2021-08-03 Thread Thomas Monjalon
02/08/2021 16:30, Suanming Mou: > Currently, there are two types of drop action implementation > in the PMD. One is the DR(Direct Rules) dummy placeholder drop > action and another is the dedicated dummy queue drop action. > When creates flow on the root table with DR drop action, the > action will

[dpdk-dev] [PATCH v2 2/2] ethdev: announce moving to general modify function

2021-08-03 Thread Ori Kam
Currently there is a dedicated modify function for each field that the application wants to change. For example: rte_flow_action_type_set_tp_port to modify destination port of UDP/TCP. rte_flow_action_type_set_ipv4_dst to modify destination of IPv4. A new function rte_flow_action_modify_field DPDK

[dpdk-dev] [PATCH v2 1/2] ethdev: announce change to action modify data

2021-08-03 Thread Ori Kam
In the current implementation, the action rte_flow_action_modify_field is not well defined for fields larger than 64 bits (for example IPv6 source) In addition, the byte order is also not well defined. Both of those issue should be fixed. Signed-off-by: Ori Kam Acked-by: Matan Azrad --- V2: F

Re: [dpdk-dev] Fwd: [dpdk] Patch notification: 6 patches updated

2021-08-03 Thread Thomas Monjalon
03/08/2021 14:54, fengchengwen: > Hi, Thomas > > Why the dmadev patchset v12/13 both deferred ? Does it have anything to do > with > the completion of 21.08? We are fixing the last critical bugs to close 21.08 this week. We don't accept new features. What did you expect? Do you understand that

[dpdk-dev] Fwd: [dpdk] Patch notification: 6 patches updated

2021-08-03 Thread fengchengwen
Hi, Thomas Why the dmadev patchset v12/13 both deferred ? Does it have anything to do with the completion of 21.08? Thanks Forwarded Message Subject: [dpdk] Patch notification: 6 patches updated Date: Tue, 3 Aug 2021 12:20:03 + From: DPDK patchwork To: fengcheng...@huawei.

[dpdk-dev] [PATCH v2 2/2] net: macro to extract MAC address bytes

2021-08-03 Thread Aman Singh
Added macros to simplyfy print of MAC address. The other method of first formatting mac address into a string and string printed, is avoided. Signed-off-by: Aman Singh --- The change in the document will be done in seperate patch. To ensure document has direct reference of the code. V2: Fix buil

[dpdk-dev] [PATCH v2 1/2] net: macro for MAC address print

2021-08-03 Thread Aman Singh
Added macro to print six bytes of MAC address. The MAC addresses will be printed in lower case hexdecimal format. In case there is a specific check for upper case MAC address, the user may need to make a change in such test case after this patch. Signed-off-by: Aman Singh --- app/test-pmd/cmdlin

[dpdk-dev] [PATCH v2 0/2] Use macro to print MAC address

2021-08-03 Thread Aman Singh
Added macros to simplyfy print of MAC address. The other method of first formatting mac address into a string and string printed, is avoided. Aman Singh (2): net: macro for MAC address print net: macro to extract MAC address bytes app/pdump/main.c | 5 +--- app

Re: [dpdk-dev] [PATCH v3] net: fix Intel-specific Prepare the outer ipv4 hdr for checksum

2021-08-03 Thread Mohsin Kazmi
On Sat, Jul 31, 2021 at 1:49 PM Andrew Rybchenko < andrew.rybche...@oktetlabs.ru> wrote: > On 7/30/21 2:11 PM, Olivier Matz wrote: > > On Wed, Jul 28, 2021 at 06:46:53PM +0300, Andrew Rybchenko wrote: > >> On 7/7/21 12:40 PM, Mohsin Kazmi wrote: > >>> Preparation the headers for the hardware offlo

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix vni matching with non-std port at ConnectX-5

2021-08-03 Thread Thomas Monjalon
> > In the recent update, the misc5 matcher was introduced to match VxLAN > > header extra fields. However, ConnectX-5 doesn't support misc5 for the UDP > > ports different from VXLAN's standard one (4789). > > > > Need to fall back to the previous approach and use legacy misc matcher if > > non-s

Re: [dpdk-dev] [PATCH] doc: announce changes in security session struct

2021-08-03 Thread Ananyev, Konstantin
> The structure rte_security_session is not directly used > by the application. The application just need an opaque > pointer to attached to the mbuf or rte_crypto_op while > enqueue. Hence, it can be hidden inside the library > and would prevent unnecessary indirection to the priv > session data

Re: [dpdk-dev] [PATCH] net/mlx5: fix port domain_id initialization

2021-08-03 Thread Thomas Monjalon
Title proposal: net/mlx5: fix port initialization of switch domain 02/08/2021 16:55, Gregory Etelson: > All active ports that belong to the same E-switch share domain_id > value. > Port initialization procedure searches through a database for existing > port with matching properties. New domain_id

Re: [dpdk-dev] [PATCH v2] net: prepare the outer ipv4 hdr for checksum

2021-08-03 Thread Mohsin Kazmi
Hi Thomas, Thanks for the review. I did the git grep rte_net_intel_cksum_prepare and git grep PKT_TX_OUTER_UDP_CKSUM. Following are the two drivers that use the function to prepare headers for checksum which also uses the outer_udp_checksum offload within drivers. 1) Hisilicon hns3 2) Wangxun t

Re: [dpdk-dev] [RFC v2 1/3] eventdev: allow for event devices requiring maintenance

2021-08-03 Thread Mattias Rönnblom
On 2021-08-03 06:39, Jerin Jacob wrote: On Mon, Aug 2, 2021 at 9:45 PM Mattias Rönnblom wrote: Extend Eventdev API to allow for event devices which require various forms of internal processing to happen, even when events are not enqueued to or dequeued from a port. RFC v2: - Change rte_eve

[dpdk-dev] [PATCH] doc: announce changes in security session struct

2021-08-03 Thread Akhil Goyal
The structure rte_security_session is not directly used by the application. The application just need an opaque pointer to attached to the mbuf or rte_crypto_op while enqueue. Hence, it can be hidden inside the library and would prevent unnecessary indirection to the priv session data in fastpath.

Re: [dpdk-dev] [dpdk-stable] [PATCH] compress/mlx5: fix level translation in xform API

2021-08-03 Thread Thomas Monjalon
01/08/2021 08:13, Matan Azrad: > From: Raja Zidane > > Compression Level is interpreted by each PMD differently. > > However, lower numbers give faster compression at the expense of > > compression ratio, while higher numbers may give better compression ratios > > but are likely slower. > > The lev

Re: [dpdk-dev] [PATCH v2] doc/guides: add details for new test structure

2021-08-03 Thread Power, Ciara
>-Original Message- >From: Thomas Monjalon >Sent: Saturday 31 July 2021 18:42 >To: Power, Ciara >Cc: dev@dpdk.org; Zhang, Roy Fan ; Doherty, >Declan ; acon...@redhat.com >Subject: Re: [dpdk-dev] [PATCH v2] doc/guides: add details for new test >structure > >16/07/2021 15:40, Ciara Power:

Re: [dpdk-dev] [PATCH 2/2] lib/security: add SA lifetime configuration

2021-08-03 Thread Anoob Joseph
Hi Konstantin, > Subject: [EXT] RE: [PATCH 2/2] lib/security: add SA lifetime configuration > > Hi Anoob, > > > > > Now that we have an agreement on bitfields (hoping no one else has > > > > an objection), I would like to discuss one more topic. It is more > > > > related to > > > checksum offlo

[dpdk-dev] [PATCH v2] doc: announce restructuring of crypto session structs

2021-08-03 Thread Akhil Goyal
The structures rte_cryptodev_sym_session and rte_cryptodev_asym_session are not used by the application directly. The application just need an opaque pointer which it can attach to rte_crypto_op while enqueue. Hence, these structures can be internal to library hidden from the user. Signed-off-by:

[dpdk-dev] [PATCH] doc: announce restructuring of crypto session structs

2021-08-03 Thread Akhil Goyal
The structures rte_cryptodev_sym_session and rte_cryptodev_asym_session are not used by the application directly. The application just need an opaque pointer which it can attach to rte_crypto_op while enqueue. Hence, these structures can be internal to library hidden from the user. Signed-off-by:

Re: [dpdk-dev] [PATCH 2/2] lib/security: add SA lifetime configuration

2021-08-03 Thread Ananyev, Konstantin
Hi Anoob, > > > Now that we have an agreement on bitfields (hoping no one else has an > > > objection), I would like to discuss one more topic. It is more related to > > checksum offload, but it's better that we discuss along with other similar > > items (like soft expiry). > > > > > > L3 & L4 che

Re: [dpdk-dev] [PATCH v13 0/6] support dmadev

2021-08-03 Thread fengchengwen
@Bruce @Jerin @Morten Could you please review 'doc: add DMA device library guide' patch ? PS: other patchs are well reviewed. Thanks On 2021/8/3 19:29, Chengwen Feng wrote: > This patch set contains six patch for new add dmadev. > > Chengwen Feng (6): > dmadev: introduce DMA device library pu

[dpdk-dev] [PATCH] doc: announce cryptodev-PMD interface as internal

2021-08-03 Thread Akhil Goyal
The APIs which are internal to PMD and cryptodev library can be marked as internal so that ABI checking do not shout for changes in APIs which are internal to DPDK. Signed-off-by: Akhil Goyal --- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guid

[dpdk-dev] [PATCH v13 5/6] doc: add DMA device library guide

2021-08-03 Thread Chengwen Feng
This patch adds dmadev library guide. Signed-off-by: Chengwen Feng --- doc/guides/prog_guide/dmadev.rst| 126 +++ doc/guides/prog_guide/img/dmadev_i1.svg | 278 doc/guides/prog_guide/index.rst | 1 + 3 files changed, 405 insertions(+

[dpdk-dev] [PATCH v13 0/6] support dmadev

2021-08-03 Thread Chengwen Feng
This patch set contains six patch for new add dmadev. Chengwen Feng (6): dmadev: introduce DMA device library public APIs dmadev: introduce DMA device library internal header dmadev: introduce DMA device library PMD header dmadev: introduce DMA device library implementation doc: add DMA

[dpdk-dev] [PATCH v13 1/6] dmadev: introduce DMA device library public APIs

2021-08-03 Thread Chengwen Feng
The 'dmadevice' is a generic type of DMA device. This patch introduce the 'dmadevice' public APIs which expose generic operations that can enable configuration and I/O with the DMA devices. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup Acked-by: Jerin Jacob -

[dpdk-dev] [PATCH v13 4/6] dmadev: introduce DMA device library implementation

2021-08-03 Thread Chengwen Feng
This patch introduce DMA device library implementation which includes configuration and I/O with the DMA devices. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup --- config/rte_config.h | 3 + lib/dmadev/meson.build | 1 + lib/dmadev/rte_dmade

[dpdk-dev] [PATCH v13 2/6] dmadev: introduce DMA device library internal header

2021-08-03 Thread Chengwen Feng
This patch introduce DMA device library internal header, which contains internal data types that are used by the DMA devices in order to expose their ops to the class. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup --- lib/dmadev/meson.build | 1 + lib/

[dpdk-dev] [PATCH v13 3/6] dmadev: introduce DMA device library PMD header

2021-08-03 Thread Chengwen Feng
This patch introduce DMA device library PMD header which was driver facing APIs for a DMA device. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup --- lib/dmadev/meson.build | 1 + lib/dmadev/rte_dmadev.h | 2 ++ lib/dmadev/rte_dmadev_pmd.h | 72 ++

[dpdk-dev] [PATCH v13 6/6] maintainers: add for dmadev

2021-08-03 Thread Chengwen Feng
This patch add Chengwen Feng as dmadev's maintainer. Signed-off-by: Chengwen Feng --- MAINTAINERS| 5 + doc/guides/rel_notes/release_21_08.rst | 6 ++ 2 files changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8013ba1..84cfb1a 100644 --- a

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix vni matching with non-std port at ConnectX-5

2021-08-03 Thread Slava Ovsiienko
> -Original Message- > From: Rongwei Liu > Sent: Monday, August 2, 2021 15:21 > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon ; Shahaf Shuler > ; Raslan Darawsheh > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH v2] net/mlx5: fix vni matching with non

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix vni matching with non-std port at ConnectX-5

2021-08-03 Thread Slava Ovsiienko
> -Original Message- > From: Rongwei Liu > Sent: Monday, August 2, 2021 15:21 > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon ; Shahaf Shuler > ; Raslan Darawsheh > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH v2] net/mlx5: fix vni matching with non

Re: [dpdk-dev] vxlan encap offload probelm in mlx5

2021-08-03 Thread wenxu
Hi Asaf, I test the mlnx-dpdk-20.11.0 in the ofed-5.4, This problem is fixed. But there are still other problem estpmd> set vxlan ip-version ipv4 vni 1000 udp-src 0 udp-dst 4789 ip-src 172.168.152.50 ip-dst 172.168.152.73 eth-src 1c:34:da:77:fb:d8 eth-dst 3c:fd:fe:bb:1c:0c testpmd> tes

Re: [dpdk-dev] [PATCH v5] build: optional NUMA and cpu counts detection

2021-08-03 Thread Juraj Linkeš
> -Original Message- > From: David Christensen > Sent: Tuesday, August 3, 2021 1:29 AM > To: Juraj Linkeš ; tho...@monjalon.net; > david.march...@redhat.com; bruce.richard...@intel.com; > honnappa.nagaraha...@arm.com; ruifeng.w...@arm.com; > ferruh.yi...@intel.com; jerinjac...@gmail.com;

Re: [dpdk-dev] [EXT] Re: [RFC v2 1/3] eventdev: allow for event devices requiring maintenance

2021-08-03 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Mattias Rönnblom > Sent: Tuesday, August 3, 2021 1:57 PM > To: Jerin Jacob > Cc: Jerin Jacob Kollanukkaran ; dpdk-dev > ; Richard Eklycke ; Liron Himi > > Subject: [EXT] Re: [dpdk-dev] [RFC v2 1/3] eventdev: allow for event devices > requiring maintenance >

[dpdk-dev] [PATCH 2/2] net: macro to extract MAC address bytes

2021-08-03 Thread Aman Singh
Added macros to simplyfy print of MAC address. The other method of first formatting mac address into a string and string printed, is avoided. Signed-off-by: Aman Singh --- The change in the document will be done in seperate patch. To ensure document has direct reference of the code. --- app/pdum

[dpdk-dev] [PATCH 1/2] net: macro for MAC address print

2021-08-03 Thread Aman Singh
Added macro to print six bytes of MAC address. The MAC addresses will be printed in lower case hexdecimal format. In case there is a specific check for upper case MAC address, the user may need to make a change in such test case after this patch. Signed-off-by: Aman Singh --- app/test-pmd/cmdlin

[dpdk-dev] [PATCH 0/2] Use macro to print MAC address

2021-08-03 Thread Aman Singh
Added macros to simplyfy print of MAC address. The other method of first formatting mac address into a string and string printed, is avoided. Aman Singh (2): net: macro for MAC address print net: macro to extract MAC address bytes app/pdump/main.c | 5 +--- app/

Re: [dpdk-dev] [dpdk-announce] release candidate 21.08-rc3

2021-08-03 Thread Kalesh Anakkur Purayil
Hi Thomas, The testing with dpdk 21.08-rc3 from Broadcom looks good. The following is a list of tests executed with 21.08-rc3: - Basic functionality: Send and receive multiple types of traffic. - testpmd xstats counter test. - RSS tests. - VLAN filtering tests. - Rx Checksum tests - TSO tests.

Re: [dpdk-dev] [PATCH 2/2] vhost: notice Vhost ops struct renaming

2021-08-03 Thread Adrian Moreno
On 7/29/21 4:42 PM, Maxime Coquelin wrote: > This patch announce the renaming of struct vhost_device_ops > to rte_vhost_device_ops in DPDK v21.11. > > Signed-off-by: Maxime Coquelin > --- > doc/guides/rel_notes/deprecation.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/doc/g

[dpdk-dev] [PATCH 22/22] net/ice/base: add priority check of matching recipe

2021-08-03 Thread Wenjun Wu
From: Qi Zhang [ upstream commit 2e6228787d91967a775fb1d99cd887d3f11ad5c6 ] This patch is not for LTS upstream, just for customer to cherry-pick. Check priority when look for a recipe which matches our request to enable flow priority for switch filter. Signed-off-by: Yuying Zhang Signed-off-b

[dpdk-dev] [PATCH 21/22] net/ice: support flow priority for DCF switch filter

2021-08-03 Thread Wenjun Wu
From: Yuying Zhang [ upstream commit 2321e34c23b386c46e4a644682e40214cf59ee4f ] This patch is not for LTS upstream, just for customer to cherry-pick. Support rte flow priority attribute for DCF switch filter. When a packet is matched by two rules, the behavior of it is not defined. This patch s

[dpdk-dev] [PATCH 19/22] net/ice: update QinQ switch filter handling

2021-08-03 Thread Wenjun Wu
From: Haiyue Wang [ upstream commit 23ea199b732bf54861aaea49e52c1089334b29ae ] The hardware outer/inner VLAN protocol types are now updated to map to new interface VLAN protocol types, so update the application to use new VLAN protocol types when the rte_flow is QinQ filter type. Signed-off-by:

[dpdk-dev] [PATCH 18/22] net/ice: enable QinQ filter for switch

2021-08-03 Thread Wenjun Wu
From: Junfeng Guo [ upstream commit bb3386f348ddf1a32b752ca371146e6be5c56a8b ] Enable the double VLAN support for switch QinQ filtering. Signed-off-by: Wei Zhao Signed-off-by: Haiyue Wang Signed-off-by: Junfeng Guo Acked-by: Qi Zhang --- drivers/net/ice/ice_generic_flow.c | 8 +++ drive

[dpdk-dev] [PATCH 20/22] net/ice/base: fix wrong ptype bitmap for IP fragment

2021-08-03 Thread Wenjun Wu
From: Ting Xu IPv4 and IPv6 fragment ptypes are supposed to be separated from IP other ptypes. New bitmaps for IP fragment ptypes were created, but the IP fragment ptypes were not deleted from the previous non-frag bitmaps, which will cause conflicts. This patch removes IP fragment ptypes from th

[dpdk-dev] [PATCH 16/22] net/ice: fix VLAN strip for double VLAN

2021-08-03 Thread Wenjun Wu
From: Haiyue Wang [ upstream commit 8ac4307504bed19ce68b39bc2703975ee0b9ab81 ] VLAN strip was failing for double VLAN because of hardware configuration, resulting mbuf not having the vlan_tci information. Adjusted the strip setting according to current VLAN mode to fix the VLAN strip. Fixes: 1

[dpdk-dev] [PATCH 17/22] net/ice: fix VLAN 0 adding based on VLAN mode

2021-08-03 Thread Wenjun Wu
From: Haiyue Wang [ upstream commit 295b34f55b001bceb27d9177b55326ccda49351b ] In Single VLAN Mode, single VLAN filters via ICE_SW_LKUP_VLAN are based on the inner VLAN ID, so the VLAN TPID (i.e. 0x8100 or 0x888a8) doesn't matter. In Double VLAN Mode, outer/single VLAN filters via ICE_SW_LKUP_V

[dpdk-dev] [PATCH 14/22] net/ice/base: add inner VLAN protocol type for QinQ filter

2021-08-03 Thread Wenjun Wu
From: Qi Zhang [ upstream commit 0475c7770502cb4166b2577df3ff446af9d85515 ] Since VLAN protocol type 'ICE_VLAN_OFOS' has been changed to map the hardware VLAN protocol ID to 'ICE_VLAN_OF_HW (16)' when in Double VLAN mode, and to 'ICE_VLAN_OL_HW (17)' when in Single VLAN mode. So 'ICE_VLAN_OFOS'

[dpdk-dev] [PATCH 13/22] net/ice/base: add ethertype offset for QinQ dummy packet

2021-08-03 Thread Wenjun Wu
From: Yuying Zhang [ upstream commit 0c0735ff4fc15e227631cbfe3fd31e33e42b34fc ] Add the ethertype offset for QinQ switch rule dummy packet to allow matching the corresponding field. Signed-off-by: Yuying Zhang Acked-by: Qi Zhang --- drivers/net/ice/base/ice_switch.c | 13 ++--- 1 fil

[dpdk-dev] [PATCH 15/22] net/ice/base: fix QinQ PPPoE dummy packet selection

2021-08-03 Thread Wenjun Wu
From: Qi Zhang [ upstream commit 03697c24b7cafbd6c536204ba6470698fcf8c5e0 ] The dummy packet should be QinQ PPPoE ipv6 when ppp protocol is ipv6. Fixes: bb3386f348dd ("net/ice: enable QinQ filter for switch") Cc: sta...@dpdk.org Signed-off-by: Yuying Zhang Signed-off-by: Qi Zhang Acked-by: Q

[dpdk-dev] [PATCH 11/22] net/ice/base: refactor post DDP download VLAN mode config

2021-08-03 Thread Wenjun Wu
From: Qi Zhang [ upstream commit 5ade55ab43e6c07a904c03ebe2d796fdea94e7e0 ] Currently it's not clear that only the first PF downloads the package and configures the VLAN mode. When this is happening all other PFs are blocked on the global configuration lock. Once the package is successfully down

[dpdk-dev] [PATCH 12/22] net/ice/base: log if DDP/FW do not support QinQ

2021-08-03 Thread Wenjun Wu
From: Qi Zhang [ upstream commit daa2ca4217ec6bf4fafb84f78985014b20cf5444 ] Currently if the driver supports QinQ there is no message/information if the DDP and/or FW don't support QinQ. Add functionality that prints if the DDP and/or FW don't support QinQ if the driver attempts to configured DV

[dpdk-dev] [PATCH 10/22] net/ice/base: change protocol ID for VLAN in DVM

2021-08-03 Thread Wenjun Wu
From: Qi Zhang [ upstream commit 8d7bb8d500b1ccdeb30668516064337faa20b364 ] Protocol id for first vlan in Double VLAN Mode (DVM) should be ICE_VLAN_OF_HW = 16, but for Single VLAN Mode (SVM) this should be ICE_VLAN_OL_HW = 17. Change protocol id in type to id translation array for outer vlan to

[dpdk-dev] [PATCH 09/22] net/ice/base: update boost TCAM for DVM

2021-08-03 Thread Wenjun Wu
From: Qi Zhang [ upstream commit f977165db0ba8435269a5e19e0e9239a4b22d140 ] Add code to update boost TCAM entries to enable DVM. This requires enabled DVM entries, and disabling SVM entries. Signed-off-by: Dan Nowlin Signed-off-by: Qi Zhang Acked-by: Qiming Yang --- drivers/net/ice/base/ice

[dpdk-dev] [PATCH 07/22] net/ice/base: support configuring device in double VLAN mode

2021-08-03 Thread Wenjun Wu
From: Qi Zhang [ upstream commit 14e7a4b37b4f2f765b4da08019ffc9098d99a076 ] In order to support configuring the device in Double VLAN Mode (DVM), the DDP and FW have to support DVM. If both support DVM, the PF that downloads the package needs to update the default recipes and set the VLAN mode.

[dpdk-dev] [PATCH 08/22] net/ice/base: do not set VLAN mode in DCF mode

2021-08-03 Thread Wenjun Wu
From: Haiyue Wang [ upstream commit 70f4e156ea52e3d8278acff30d06447eab623a15 ] The PF will set the VLAN mode globally, DCF just needs to get the VLAN mode. Signed-off-by: Haiyue Wang Acked-by: Qiming Yang --- drivers/net/ice/base/ice_vlan_mode.c | 6 ++ 1 file changed, 6 insertions(+) d

[dpdk-dev] [PATCH 06/22] net/ice/base: support checking double VLAN mode

2021-08-03 Thread Wenjun Wu
From: Qi Zhang [ upstream commit 67285599c9f413c59118379d1f7162031ea6acdc ] If a driver wants to configure double VLAN mode (DVM) it needs to first check if the DDP supports DVM. To do this the driver needs to read the package metadata section via the upload section AQ (0x04C1). If the DDP does

[dpdk-dev] [PATCH 05/22] net/ice/base: add VLAN TPID for VLAN filters

2021-08-03 Thread Wenjun Wu
From: Qi Zhang [ upstream commit a6b975d23c10756083357355372c4f545ddc1ebe ] Currently VLAN filters via RID4 are only based on VLAN ID. However, with incoming support for Double VLAN Mode (DVM), the driver needs to be able to support filtering on VLAN ID + VLAN TPID (i.e. 0x8100, 0x88a8, etc.). A

[dpdk-dev] [PATCH 04/22] net/ice/base: fix outer VLAN related macro

2021-08-03 Thread Wenjun Wu
From: Qi Zhang [ upstream commit 25aa214490814d14e5f8f69121c23c0b91d2aeb9 ] Fix the wrong value of ICE_AQ_VSI_OUTER_VLAN_PORT_BASED_ACCEPT_HOST Fixes: 9ea028123a0b ("net/ice/base: align add VSI and update VSI AQ command buffer") Signed-off-by: Qi Zhang Acked-by: Qiming Yang --- drivers/net

  1   2   >