Re: [dpdk-dev] [PATCH v1] net/ice: fix memzone leak when device init failed

2021-08-18 Thread David Marchand
On Wed, Aug 18, 2021 at 2:46 AM Wang, Haiyue wrote: > > > -Original Message- > > From: David Marchand > > Sent: Tuesday, August 17, 2021 17:19 > > To: Wang, Haiyue > > Cc: dev ; Zhang, Qi Z ; dpdk stable > > ; Yang, > > Qiming ; Xiaolong Ye ; Xing, > > Beilei > > ; Wang, Ying A > > Su

Re: [dpdk-dev] [PATCH v13] eventdev: simplify Rx adapter event vector config

2021-08-18 Thread Jayatheerthan, Jay
HI Harish, Could you review this patch ? -Jay > -Original Message- > From: pbhagavat...@marvell.com > Sent: Wednesday, August 18, 2021 12:27 PM > To: jer...@marvell.com; Ray Kinsella ; Pavan Nikhilesh > ; Shijith Thotton > ; Jayatheerthan, Jay > Cc: dev@dpdk.org > Subject: [dpdk-dev]

Re: [dpdk-dev] [PATCH v4 2/2] net: added macro to extract MAC address bytes

2021-08-18 Thread Ferruh Yigit
On 8/17/2021 6:00 PM, Stephen Hemminger wrote: > On Tue, 17 Aug 2021 17:44:51 +0100 > Ferruh Yigit wrote: > >> On 8/17/2021 4:25 PM, Stephen Hemminger wrote: >>> On Tue, 17 Aug 2021 09:11:17 +0100 >>> Ferruh Yigit wrote: >>> On 8/17/2021 12:03 AM, Stephen Hemminger wrote: > On Mon,

[dpdk-dev] [PATCH 1/2] net/ice/base: get PF ID of VF's parent

2021-08-18 Thread dapengx . yu
From: Dapeng Yu In original implementation, when one or more VFs are created, and VF0 is used as DCF, there is no way to get the physical function ID of their parent adapter via VF0. The physical function ID is critical for initializing ACL feature, if wrong physical function ID is used, the ACL

[dpdk-dev] [PATCH 2/2] net/ice: get PF ID of VF's parent

2021-08-18 Thread dapengx . yu
From: Dapeng Yu In original implementation, when DCF is initialized, the physical function ID of its parent adapter is not set correctly. Its initial value is always zero, even if DCF is created on 1# physical function and, further, causes ACL to initialize wrongly. Finally, the ACL flow rule can

Re: [dpdk-dev] [PATCH v2 1/6] eal: introduce oops handling API

2021-08-18 Thread Jerin Jacob
On Tue, Aug 17, 2021 at 9:22 PM Stephen Hemminger wrote: > > On Tue, 17 Aug 2021 20:57:50 +0530 > Jerin Jacob wrote: > > > On Tue, Aug 17, 2021 at 8:39 PM Stephen Hemminger > > wrote: > > > > > > On Tue, 17 Aug 2021 13:08:46 +0530 > > > Jerin Jacob wrote: > > > > > > > On Tue, Aug 17, 2021 at 9

[dpdk-dev] [PATCH] net/bnxt: update ring group after ring stop start

2021-08-18 Thread Ajit Khaparde
A Rx ring stop start sequence may result in the FW returning a different set of Rx ring and AGG ring IDs. If the ring group is not updated with the new IDs, the HW sees the host driver using incorrect BD types for the Rx ring and AGG ring. This can cause the chip to go into a bad state or encounter

Re: [dpdk-dev] [RFC V1] ethdev: fix the issue that dev uninit may be called twice

2021-08-18 Thread Singh, Aman Deep
Hi Huison, On 8/2/2021 6:16 PM, Huisong Li wrote: Ethernet devices in DPDK can be released by rte_eth_dev_close() and rte_dev_remove(). However, these two APIs do not have explicit invocation restrictions. In other words, at the ethdev layer, calling rte_eth_dev_close() and then rte_dev_remove()

Re: [dpdk-dev] [RFC V2] ethdev: fix issue that dev close in PMD calls twice

2021-08-18 Thread Ferruh Yigit
On 8/13/2021 9:16 AM, Huisong Li wrote: > > 在 2021/8/13 14:12, Thomas Monjalon 写道: >> 13/08/2021 04:11, Huisong Li: >>> Hi, all >>> >>> This patch can enhance the security of device uninstallation to >>> eliminate dependency on user usage methods. >>> >>> Can you check this patch? >>> >>> >>> 在 20

Re: [dpdk-dev] [PATCH v2 06/15] app/testpmd: add common fwd wrapper function

2021-08-18 Thread Jerin Jacob
On Wed, Aug 18, 2021 at 4:57 PM Xueming(Steven) Li wrote: > > > > > -Original Message- > > From: Jerin Jacob > > Sent: Tuesday, August 17, 2021 5:37 PM > > To: Xueming(Steven) Li > > Cc: Jack Min ; dpdk-dev ; Xiaoyun Li > > > > Subject: Re: [dpdk-dev] [PATCH v2 06/15] app/testpmd: add

[dpdk-dev] [PATCH] common/cnxk: fix attaching NPA LF to CPT VF

2021-08-18 Thread Srujana Challa
ATTACH_RESOURCES mailbox for CPT LFs is being called without setting modify bit. Because of this previously attached NPA LF to the CPT VF is getting removed, when only CPT VF is whitelisted. This patch patch fixes the same. Fixes: c045d2e5cbbc ("common/cnxk: add CPT configuration") Signed-off-by:

[dpdk-dev] [PATCH v2] common/cnxk: fix attaching NPA LF to CPT VF

2021-08-18 Thread Srujana Challa
ATTACH_RESOURCES mailbox for CPT LFs is being called without setting modify bit. Because of this previously attached NPA LF to the CPT VF is getting removed, when only CPT VF is whitelisted. This patch fixes the same. Fixes: c045d2e5cbbc ("common/cnxk: add CPT configuration") v2: - Fixed checkpat

[dpdk-dev] [PATCH 1/4] mempool: add event callbacks

2021-08-18 Thread Dmitry Kozlyuk
Performance of MLX5 PMD of different classes can benefit if PMD knows which memory it will need to handle in advance, before the first mbuf is sent to the PMD. It is impractical, however, to consider all allocated memory for this purpose. Most often mbuf memory comes from mempools that can come and

[dpdk-dev] [PATCH 0/4] net/mlx5: implicit mempool registration

2021-08-18 Thread Dmitry Kozlyuk
MLX5 hardware has its internal IOMMU where PMD registers the memory. On the data path, PMD translates VA into a key consumed by the device IOMMU. It is impractical for the PMD to register all allocated memory because of increased lookup cost both in HW and SW. Most often mbuf memory comes from me

[dpdk-dev] [PATCH 2/4] mempool: add non-IO flag

2021-08-18 Thread Dmitry Kozlyuk
Mempool is a generic allocator that is not necessarily used for device IO operations and its memory for DMA. Add MEMPOOL_F_NON_IO flag to mark such mempools. Signed-off-by: Dmitry Kozlyuk Acked-by: Matan Azrad --- doc/guides/rel_notes/release_21_11.rst | 3 +++ lib/mempool/rte_mempool.h

[dpdk-dev] [PATCH 3/4] common/mlx5: add mempool registration facilities

2021-08-18 Thread Dmitry Kozlyuk
Add internal API to register mempools, that is, to create memory regions (MR) for their memory and store them in a separate database. Implementation deals with multi-process, so that class drivers don't need to. Each protection domain has its own database. Memory regions can be shared within a data

[dpdk-dev] [PATCH 4/4] net/mlx5: support mempool registration

2021-08-18 Thread Dmitry Kozlyuk
When the first port in a given protection domain (PD) starts, install a mempool event callback for this PD and register all existing memory regions (MR) for it. When the last port in a PD closes, remove the callback and unregister all mempools for this PD. On TX slow path, i.e. when an MR key for

[dpdk-dev] [PATCH] build: fix building when essential drivers in disable list

2021-08-18 Thread Bruce Richardson
The PCI and vdev bus drivers cannot be disabled for DPDK builds and special logic is put in place to not skip them when they are specified in the disable list. This logic is broken though, as the inclusion of the driver-specific meson.build file is only included in the "else" leg of the condition c

[dpdk-dev] [PATCH v3 1/6] eal: add function that sets thread name

2021-08-18 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Implement function that sets the name of a thread. On Windows, SetThreadDescription() is used. Use GetProcAddress() to obtain the address of the function for MinGW compatibility. Signed-off-by: Narcisa Vasile --- lib/eal/common/rte_thread.c | 17 + lib/eal/include

[dpdk-dev] [PATCH v3 0/6] Enable the internal EAL thread API

2021-08-18 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile This patchset enables the new EAL thread API. The newly defined thread attributes, priority and affinity, are used in eal/windows when creating the threads. Similarly, some changes have been done in eal/linux/eal.c and eal/freebsd/eal.c to initialize priority to a default va

[dpdk-dev] [PATCH v3 2/6] eal: add function for control thread creation

2021-08-18 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile The existing rte_ctrl_thread_create() function will be replaced with rte_thread_ctrl_thread_create() that uses the internal EAL thread API. This patch only introduces the new control thread creation function. Replacing of the old function needs to be done according to the AB

[dpdk-dev] [PATCH v3 4/6] lib: enable the new EAL thread API

2021-08-18 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Rename pthread* with the new rte_thread* API. Signed-off-by: Narcisa Vasile --- lib/eal/common/eal_common_options.c | 6 ++--- lib/eal/common/eal_common_thread.c | 13 + lib/eal/common/eal_common_trace.c | 1 + lib/eal/common/eal_private.h

[dpdk-dev] [PATCH v3 3/6] Enable the new EAL thread API in app, drivers and examples

2021-08-18 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Rename pthread* with the new rte_thread* API. Signed-off-by: Narcisa Vasile --- app/test/process.h| 8 +-- app/test/test_lcores.c| 18 +++ app/test/test_link_bonding.c | 14 ++--- app/test/test_lpm_p

[dpdk-dev] [PATCH v3 5/6] eal: set affinity and priority attributes

2021-08-18 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile If the user doesn't specify the priority through the command line arguments, initialize the thread priority to 'normal'. Set thread priority for eal threads. Signed-off-by: Narcisa Vasile --- lib/eal/common/eal_common_thread.c | 11 lib/eal/common/eal_thread.h

[dpdk-dev] [PATCH v3 6/6] Allow choice between internal EAL thread API and external lib

2021-08-18 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile The user is offered the option of either using the RTE_THREAD_* API or a 3rd party thread library, through a meson flag called "use_external_thread_lib". By default, this flag is set to FALSE, which means Windows libraries and applications will use the RTE_THREAD_* API for ma

[dpdk-dev] [PATCH v3] eal/windows: ensure all enabled CPUs are counted

2021-08-18 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile On Windows, -l/--lcores EAL option was unable to process CPU sets containing CPUs other than 0 and 1, because CPU_COUNT() macro only checked these CPUs in the set. Fix CPU_COUNT() by enumerating all possible CPU indices. Fixes: e8428a9d89f1 ("eal/windows: add some basic func

[dpdk-dev] [PATCH v2] ethdev: fix representor port ID search by name

2021-08-18 Thread Andrew Rybchenko
From: Viacheslav Galaktionov Getting a list of representors from a representor does not make sense. Instead, a parent device should be used. To this end, extend the rte_eth_dev_data structure to include the port ID of the parent device for representors. Signed-off-by: Viacheslav Galaktionov Si

Re: [dpdk-dev] [PATCH 0/3] Fixes for txgbe

2021-08-18 Thread Ferruh Yigit
On 8/12/2021 3:00 AM, Jiawen Wu wrote: > These patches fix link status, module info and flow director. > > Jiawen Wu (3): > net/txgbe: fix link status when device stopped > net/txgbe: fix to read SFP module's SFF-8472 data > net/txgbe: fix L4 port mask in FDIR > Series applied to dpdk-next

[dpdk-dev] [PATCH 1/2] net/virtio: fix Tx cleanup functions to have same signature

2021-08-18 Thread Andrew Rybchenko
From: Ivan Ilchenko There is a family of cleanup from completed transmits functions. Fix packed virtqueues cleanup functions to have the same signature as split virtqueues have. This lets all functions of the family to match the same callback prototype. Fixes: 892dc798fa9 ("net/virtio: implement

[dpdk-dev] [PATCH 2/2] net/virtio: fix Tx completed mbufs leak on device stop

2021-08-18 Thread Andrew Rybchenko
From: Ivan Ilchenko Free Tx completed mbufs on device stop. Not completed Tx mbufs cannot be freed since they are still in use. Fixes: c1f86306a02 ("virtio: add new driver") Cc: sta...@dpdk.org Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- drivers/net/virtio/virtio_ethdev.

[dpdk-dev] 19.11.10 patches review and test

2021-08-18 Thread christian . ehrhardt
Hi all, Here is a list of patches targeted for stable release 19.11.10. The planned date for the final release is 1st September (two weeks from now). Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fix

[dpdk-dev] [PATCH v2 0/2] TCP flow classification using 4-tuple and flags

2021-08-18 Thread Sowmini Varadhan
V2 updates: checkpatch typo fixes, bernard.iremonger review fixes The problem space of TCP flow tracking and classification based on TCP state requires the ability to classify TCP flows on more packet properties than just the 4-tuple, e.g., TCP flags. This patch-set provides the set of changes nee

[dpdk-dev] [PATCH v2 1/2] examples/flow_classify: hooks for filters on tcp flags

2021-08-18 Thread Sowmini Varadhan
v2 fixes: typo fixes, get_tcp_flags returns -EINVAL The rte_eth_ntuple_filter allows tcp_flags which can check for things like #define RTE_TCP_CWR_FLAG 0x80 /**< Congestion Window Reduced */ #define RTE_TCP_ECE_FLAG 0x40 /**< ECN-Echo */ #define RTE_TCP_URG_FLAG 0x20 /**< Urgent Point

[dpdk-dev] [PATCH v2 2/2] examples/flow_classify: add an ACL table for tcp

2021-08-18 Thread Sowmini Varadhan
v2 updates: typo fixes for checkpatch, bernard.iremonger comments The struct rte_flow_classifier can have up to RTE_FLOW_CLASSIFY_TABLE_MAX (32) classifier tables, but the existing flow_classify examples only adds a single table for the L4 5-tuple. When dealing with tcp flows, we frequently want

Re: [dpdk-dev] [PATCH v2 01/15] ethdev: introduce shared Rx queue

2021-08-18 Thread Xueming(Steven) Li
> -Original Message- > From: Jerin Jacob > Sent: Tuesday, August 17, 2021 11:12 PM > To: Xueming(Steven) Li > Cc: dpdk-dev ; Ferruh Yigit ; > NBU-Contact-Thomas Monjalon ; > Andrew Rybchenko > Subject: Re: [PATCH v2 01/15] ethdev: introduce shared Rx queue > > On Tue, Aug 17, 2021 at

Re: [dpdk-dev] [PATCH v2 06/15] app/testpmd: add common fwd wrapper function

2021-08-18 Thread Xueming(Steven) Li
> -Original Message- > From: Jerin Jacob > Sent: Tuesday, August 17, 2021 5:37 PM > To: Xueming(Steven) Li > Cc: Jack Min ; dpdk-dev ; Xiaoyun Li > > Subject: Re: [dpdk-dev] [PATCH v2 06/15] app/testpmd: add common fwd wrapper > function > > On Wed, Aug 11, 2021 at 7:35 PM Xueming L

[dpdk-dev] [PATCH v4] vhost: fix crash on port deletion

2021-08-18 Thread Gaoxiang Liu
The rte_vhost_driver_unregister() and vhost_user_server_new_connection() can be called at the same time by 2 threads. Eg thread1 calls rte_vhost_driver_unregister() and frees the memory of conn_list. "vhost-events" thread calls fdset_event_dispatch, then calls vhost_user_server_new_connection(). A

[dpdk-dev] [PATCH 1/2] net/i40e: fix generic build on FreeBSD

2021-08-18 Thread Bruce Richardson
The common header file for vectorization is included in multiple files, and so must use macros for the current compilation unit, rather than the compiler-capability flag set for the whole driver. With the current, incorrect, macro, the AVX512 or AVX2 flags may be set when compiling up SSE code, lea

[dpdk-dev] [PATCH 2/2] net/ice: fix generic build on FreeBSD

2021-08-18 Thread Bruce Richardson
The common header file for vectorization is included in multiple files, and so must use macros for the current compilation unit, rather than the compiler-capability flag set for the whole driver. With the current, incorrect, macro, the AVX512 or AVX2 flags may be set when compiling up SSE code, lea

Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix generic build on FreeBSD

2021-08-18 Thread Bruce Richardson
On Wed, Aug 18, 2021 at 05:38:15PM +0100, Bruce Richardson wrote: > The common header file for vectorization is included in multiple files, > and so must use macros for the current compilation unit, rather than the > compiler-capability flag set for the whole driver. With the current, > incorrect,

Re: [dpdk-dev] [PATCH v2 1/6] eal: introduce oops handling API

2021-08-18 Thread Stephen Hemminger
On Wed, 18 Aug 2021 15:07:25 +0530 Jerin Jacob wrote: > On Tue, Aug 17, 2021 at 9:22 PM Stephen Hemminger > wrote: > > > > On Tue, 17 Aug 2021 20:57:50 +0530 > > Jerin Jacob wrote: > > > > > On Tue, Aug 17, 2021 at 8:39 PM Stephen Hemminger > > > wrote: > > > > > > > > On Tue, 17 Aug 2021

Re: [dpdk-dev] [PATCH v4 2/2] net: added macro to extract MAC address bytes

2021-08-18 Thread Stephen Hemminger
On Wed, 18 Aug 2021 09:23:09 +0100 Ferruh Yigit wrote: > On 8/17/2021 6:00 PM, Stephen Hemminger wrote: > > On Tue, 17 Aug 2021 17:44:51 +0100 > > Ferruh Yigit wrote: > > > >> On 8/17/2021 4:25 PM, Stephen Hemminger wrote: > >>> On Tue, 17 Aug 2021 09:11:17 +0100 > >>> Ferruh Yigit wrote:

[dpdk-dev] [PATCH v2 01/13] lib: build libraries that some tests depend on

2021-08-18 Thread Jie Zhou
Enable building subset of libraries that tests depend on for Windows Signed-off-by: Jie Zhou --- lib/meson.build | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/meson.build b/lib/meson.build index 1673ca4323..f109d6987d 100644 --- a/lib/meson.build +++ b/lib/meson.build @@ -81,10 +

[dpdk-dev] [PATCH v2 02/13] driver/mempool: build mempool stack on Windows

2021-08-18 Thread Jie Zhou
mempool_autotest failed on Windows at setting the "stack" handler test case. Per debugging, in rte_mempool_ops_table, there are only 6 ring ops registered, and no "stack" ops registered which caused the failure of rte_mempool_set_ops_byname and thus the test failed. Per code investigation, the "sta

[dpdk-dev] [PATCH v2 00/13] app/test: enable subset of tests on Windows

2021-08-18 Thread Jie Zhou
This patchset is to enable a subset of unit tests on windows. It mainly includes: - Enable building libraries on Windows that some tests depend on - Replace POSIX specific codes - Fix some lib and tests per failures investigation - Replace .sh scripts with .py scripts for meson.build - Enable buil

[dpdk-dev] [PATCH v2 03/13] eal/windows: return ENOTSUP for not supported API

2021-08-18 Thread Jie Zhou
UT memory_autotest on Windows has 2 failed cases on eal APIs eal_memalloc_get_seg_fd and eal_memalloc_get_seg_fd_offset. These 2 APIs are not supported on Windows yet. Should return ENOTSUP such that in test_memory.c these 2 ENOTSUP cases will not be marked as failures, same as other ENOTSUP cases.

[dpdk-dev] [PATCH v2 04/13] app/test: remove unnecessary headers

2021-08-18 Thread Jie Zhou
Remove unnecessary header inclusion Signed-off-by: Jie Zhou --- app/test/commands.c | 2 -- app/test/test.c | 1 - app/test/test_cmdline_lib.c | 1 - 3 files changed, 4 deletions(-) diff --git a/app/test/commands.c b/app/test/commands.c index 76f6ee5d23..82bd8bf474 100644 --

[dpdk-dev] [PATCH v2 06/13] app/test: exclude ENOTSUP as failure

2021-08-18 Thread Jie Zhou
Check rte_errno to exclude ENOTSUP as failures in test_memory.c Signed-off-by: Jie Zhou --- app/test/test_memory.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/test/test_memory.c b/app/test/test_memory.c index 7d5ae99bab..6f4fc02c03 100644 --- a/app/test/test_memo

[dpdk-dev] [PATCH v2 07/13] app/test: skip interrupt tests on Windows

2021-08-18 Thread Jie Zhou
Even though test_interrupts.c can compile on Windows, skip interrupt tests for now since majority of eal_interrupt on Windows are stubs. Will remove the skip after interrupt being fully enabled on Windows. Signed-off-by: Jie Zhou --- app/test/test_interrupts.c | 10 ++ 1 file changed, 10

[dpdk-dev] [PATCH v2 08/13] app/test: temporarily "skip" one cmdline test case

2021-08-18 Thread Jie Zhou
cmdline tests pass except one failure at the test_cmdline_socket_fns test case with error: failed to open /dev/null for reading! Temporarily "skip" this case while enable all other passing cases. Issue is tracked internally and will add the corresponding case on Windows in future. Signed-off-by:

[dpdk-dev] [PATCH v2 09/13] app/test: skip two logs_autotest cases on Windows

2021-08-18 Thread Jie Zhou
DPDK logs_autotest on Windows failed at "dynamic log types" tests. The failures are on 2 test cases for rte_log_set_level_regexp API, due to regular expression is not supported on Windows in DPDK yet and regcomp/regexec are just stubs on Windows (in regex.h). In app\test\test_logs.c, ifndef these

[dpdk-dev] [PATCH v2 05/13] app/test: replace POSIX specific code

2021-08-18 Thread Jie Zhou
- Include rte_os_shim.h - Replace sleep and usleep with rte_delay_us_sleep - #ifndef RTE_EXEC_ENV_WINDOWS for POSIX code only Signed-off-by: Jie Zhou --- app/test/packet_burst_generator.c | 1 + app/test/process.h| 4 +++- app/test/test.c | 4 app/test/test

[dpdk-dev] [PATCH v2 11/13] app/test: remove two alarm_autotest cases

2021-08-18 Thread Jie Zhou
Remove two alarm_autotest test cases which do bogus range check on Windows. Signed-off-by: Jie Zhou --- app/test/test_alarm.c | 4 1 file changed, 4 insertions(+) diff --git a/app/test/test_alarm.c b/app/test/test_alarm.c index b4034339b8..70e97a3109 100644 --- a/app/test/test_alarm.c +++

[dpdk-dev] [PATCH v2 10/13] app/test: differentiate a strerror on different OS

2021-08-18 Thread Jie Zhou
On Windows, strerror returns just "Unknown error" for errnum greater than MAX_ERRNO, while linux and freebsd returns "Unknown error ", which is the current expectation for errno_autotest. Differentiate the error string on Windows to remove a "duplicate error code" failure. Signed-off-by: Jie Zhou

[dpdk-dev] [PATCH v2 12/13] app/test: replace .sh scripts with .py scripts

2021-08-18 Thread Jie Zhou
- Add python scripts to get coremask and check hugepage config - Remove two corresponding .sh scripts - Replace calling of .sh with corresponding .py in meson.build Signed-off-by: Jie Zhou --- app/test/get-coremask.sh | 13 - app/test/get_coremask.py | 8 app/test/has-hugep

[dpdk-dev] [PATCH v2 13/13] app/test: enable subset of unit tests on Windows

2021-08-18 Thread Jie Zhou
In app/test/meson.build - Specify the subset of source files to compile on Windows - Specify the subset of tests to be enabled on Windows Signed-off-by: Jie Zhou --- app/test/meson.build | 859 ++- 1 file changed, 515 insertions(+), 344 deletions(-) diff

Re: [dpdk-dev] [PATCH v2 1/6] eal: introduce oops handling API

2021-08-18 Thread Jerin Jacob
On Wed, Aug 18, 2021 at 10:16 PM Stephen Hemminger wrote: > > On Wed, 18 Aug 2021 15:07:25 +0530 > Jerin Jacob wrote: > > > On Tue, Aug 17, 2021 at 9:22 PM Stephen Hemminger > > wrote: > > > > > > On Tue, 17 Aug 2021 20:57:50 +0530 > > > Jerin Jacob wrote: > > > > > > > On Tue, Aug 17, 2021 at

Re: [dpdk-dev] [PATCH v2 06/15] app/testpmd: add common fwd wrapper function

2021-08-18 Thread Xueming(Steven) Li
> -Original Message- > From: Jerin Jacob > Sent: Wednesday, August 18, 2021 7:48 PM > To: Xueming(Steven) Li > Cc: Jack Min ; dpdk-dev ; Xiaoyun Li > > Subject: Re: [dpdk-dev] [PATCH v2 06/15] app/testpmd: add common fwd wrapper > function > > On Wed, Aug 18, 2021 at 4:57 PM Xueming

[dpdk-dev] [RFC 0/3] mlx5: replaced hardware queue object

2021-08-18 Thread Raja Zidane
The mlx5 PMDs for compress and regex classes use an MMO WQE operated by the GGA engine in BF devices. Currently, all the MMO WQEs are managed by the SQ object. Starting from BF3, the queue of the MMO WQEs should be connected to the GGA engine using a new configuration, mmo, that will be supported

[dpdk-dev] [RFC 1/3] common/mlx5: add common qp_create

2021-08-18 Thread Raja Zidane
Signed-off-by: Raja Zidane --- drivers/common/mlx5/mlx5_common_devx.c | 111 + drivers/common/mlx5/mlx5_common_devx.h | 20 + drivers/common/mlx5/version.map| 2 + drivers/crypto/mlx5/mlx5_crypto.c | 80 +++--- drivers/crypto/mlx5/mlx5_cryp

[dpdk-dev] [RFC 2/3] compress/mlx5: refactor queue creation in mlx5 add support to compress and regex drivers in BlueField3

2021-08-18 Thread Raja Zidane
Signed-off-by: Raja Zidane --- drivers/common/mlx5/mlx5_devx_cmds.c | 14 - drivers/common/mlx5/mlx5_devx_cmds.h | 10 ++- drivers/common/mlx5/mlx5_prm.h| 42 +++-- drivers/compress/mlx5/mlx5_compress.c | 91 ++- 4 files changed, 116 insertions(+), 41

[dpdk-dev] [RFC 3/3] regex/mlx5: refactor queue creation in mlx5 add support to compress and regex drivers in Bluefield3

2021-08-18 Thread Raja Zidane
Signed-off-by: Raja Zidane --- drivers/common/mlx5/mlx5_common_devx.c | 28 drivers/common/mlx5/mlx5_common_devx.h | 3 ++ drivers/common/mlx5/version.map | 1 + drivers/compress/mlx5/mlx5_compress.c | 31 + drivers/crypto/mlx5/mlx5_crypto.c | 30 +

Re: [dpdk-dev] [PATCH] build: fix install from arbitrary directory for meson 0.55

2021-08-18 Thread Dmitry Kozlyuk
2021-08-17 15:35 (UTC+0100), Bruce Richardson: > On Wed, Aug 11, 2021 at 02:03:22AM +0300, Dmitry Kozlyuk wrote: > > Install command for meson >= 0.55.0 referenced the script by a plain > > string, assuming the build directory to be directly under the source > > tree root. This resulted in an error

[dpdk-dev] [PATCH v4 1/6] eal: add function that sets thread name

2021-08-18 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Implement function that sets the name of a thread. On Windows, SetThreadDescription() is used. Use GetProcAddress() to obtain the address of the function for MinGW compatibility. Signed-off-by: Narcisa Vasile --- lib/eal/common/rte_thread.c | 17 lib/eal/include/

[dpdk-dev] [PATCH v4 0/6] Enable the internal EAL thread API

2021-08-18 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile This patchset enables the new EAL thread API. The newly defined thread attributes, priority and affinity, are used in eal/windows when creating the threads. Similarly, some changes have been done in eal/linux/eal.c and eal/freebsd/eal.c to initialize priority to a default va

[dpdk-dev] [PATCH v4 2/6] eal: add function for control thread creation

2021-08-18 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile The existing rte_ctrl_thread_create() function will be replaced with rte_thread_ctrl_thread_create() that uses the internal EAL thread API. This patch only introduces the new control thread creation function. Replacing of the old function needs to be done according to the AB

[dpdk-dev] [PATCH v4 4/6] lib: enable the new EAL thread API

2021-08-18 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Rename pthread* with the new rte_thread* API. Signed-off-by: Narcisa Vasile --- lib/eal/common/eal_common_options.c | 6 ++--- lib/eal/common/eal_common_thread.c | 13 + lib/eal/common/eal_common_trace.c | 1 + lib/eal/common/eal_private.h

[dpdk-dev] [PATCH v4 3/6] Enable the new EAL thread API in app, drivers and examples

2021-08-18 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Rename pthread* with the new rte_thread* API. Signed-off-by: Narcisa Vasile --- app/test/process.h| 8 +-- app/test/test_lcores.c| 18 +++ app/test/test_link_bonding.c | 14 ++--- app/test/test_lpm_p

[dpdk-dev] [PATCH v4 5/6] eal: set affinity and priority attributes

2021-08-18 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile If the user doesn't specify the priority through the command line arguments, initialize the thread priority to 'normal'. Set thread priority for eal threads. Signed-off-by: Narcisa Vasile --- lib/eal/common/eal_common_thread.c | 11 lib/eal/common/eal_thread.h

[dpdk-dev] [PATCH v4 6/6] Allow choice between internal EAL thread API and external lib

2021-08-18 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile The user is offered the option of either using the RTE_THREAD_* API or a 3rd party thread library, through a meson flag called "use_external_thread_lib". By default, this flag is set to FALSE, which means Windows libraries and applications will use the RTE_THREAD_* API for ma

Re: [dpdk-dev] [PATCH v13 09/10] eal: add EAL argument for setting thread priority

2021-08-18 Thread Stephen Hemminger
On Tue, 3 Aug 2021 12:01:30 -0700 Narcisa Ana Maria Vasile wrote: > +static int > +eal_parse_thread_priority(const char *arg) > +{ > + struct internal_config *internal_conf = > + eal_get_internal_configuration(); > + enum rte_thread_priority priority; > + > + if (!strncmp

[dpdk-dev] [PATCH v7] eal: remove sys/queue.h from public headers.

2021-08-18 Thread William Tu
Currently there are some public headers that include 'sys/queue.h', which is not POSIX, but usually provided by the Linux/BSD system library. (Not in POSIX.1, POSIX.1-2001, or POSIX.1-2008. Present on the BSDs.) The file is missing on Windows. During the Windows build, DPDK uses a bundled copy, so

Re: [dpdk-dev] Windows community call: MoM 2021-08-04

2021-08-18 Thread William Tu
On Tue, Aug 17, 2021 at 7:14 AM Bruce Richardson wrote: > > On Fri, Aug 06, 2021 at 04:17:32PM -0700, William Tu wrote: > > On Thu, Aug 5, 2021 at 12:15 PM Dmitry Kozlyuk > > wrote: > > > > > snip > > > > > # Porting OvS build system to meson (William Tu) > > > > > > Status: OvS compiles with so

Re: [dpdk-dev] [PATCH v3 1/6] eal: add function that sets thread name

2021-08-18 Thread Tal Shnaiderman
> Subject: [PATCH v3 1/6] eal: add function that sets thread name > > External email: Use caution opening links or attachments > > > From: Narcisa Vasile > > Implement function that sets the name of a thread. > On Windows, SetThreadDescription() is used. Use GetProcAddress() to obtain > the ad

[dpdk-dev] PCI valgrind detects unintialized access

2021-08-18 Thread Stephen Hemminger
As a sanity test, running lastest DPDK testpmd with valgrind (on x86). One concern is that the PCI code appears to be looking at flags in the PCI device (not from the driver) which are not initialized. The probe logic is a confusing, any recommendation on best fix? ==1695615== Command: build/app

Re: [dpdk-dev] [PATCH RFC] net/ena: Add Windows support.

2021-08-18 Thread William Tu
On Sat, Aug 14, 2021 at 4:31 AM Dmitry Kozlyuk wrote: > > Hi William, > > 2021-08-14 03:36 (UTC+), William Tu: > > I don't have a physical Windows testbed so I want to see if I can > > get virtual nic working, in this case ENA driver on AWS. > > The patch passes build on Windows, but I haven't

[dpdk-dev] [PATCH] telemetry: detach pthreads

2021-08-18 Thread Stephen Hemminger
There are a number telemetry threads which are created and there is nothing that does pthread_join() to wait for them. Mark these threads as detached, so that the pthread library can cleanup state when the thread exits. Signed-off-by: Stephen Hemminger --- lib/telemetry/telemetry.c| 2 ++

[dpdk-dev] [PATCH] eal: detach interrupt and worker threads

2021-08-18 Thread Stephen Hemminger
The EAL library does not wait (pthread_join) these threads so the should be detached so that library can release resources. This shows up when looking for memory leaks with tools like valgrind. Signed-off-by: Stephen Hemminger --- lib/eal/freebsd/eal.c | 3 +++ lib/eal/linux/eal.c

Re: [dpdk-dev] [RFC V2] ethdev: fix issue that dev close in PMD calls twice

2021-08-18 Thread Huisong Li
在 2021/8/18 19:24, Ferruh Yigit 写道: On 8/13/2021 9:16 AM, Huisong Li wrote: 在 2021/8/13 14:12, Thomas Monjalon 写道: 13/08/2021 04:11, Huisong Li: Hi, all This patch can enhance the security of device uninstallation to eliminate dependency on user usage methods. Can you check this patch? 在 2

Re: [dpdk-dev] [PATCH v2 01/15] ethdev: introduce shared Rx queue

2021-08-18 Thread Jerin Jacob
On Wed, Aug 18, 2021 at 4:44 PM Xueming(Steven) Li wrote: > > > > > -Original Message- > > From: Jerin Jacob > > Sent: Tuesday, August 17, 2021 11:12 PM > > To: Xueming(Steven) Li > > Cc: dpdk-dev ; Ferruh Yigit ; > > NBU-Contact-Thomas Monjalon ; > > Andrew Rybchenko > > Subject: Re:

[dpdk-dev] [PATCH] net/virtio: fix indirect descriptors reconnection

2021-08-18 Thread Xuan Ding
Since packed indirect descriptors are added and initialized when initializing vring, the reconnection path also needs to be considered. Fixes: 381f39ebb78a ("net/virtio: fix packed ring indirect descricptors setup") Cc: sta...@dpdk.org Cc: yong@intel.com Signed-off-by: Xuan Ding --- drivers

[dpdk-dev] [PATCH] kni: remove non-C11 path from FIFO sync

2021-08-18 Thread Joyce Kong
Non-C11 path was meant to not break build with GCC version < 4.7(when C11 atomics were introduced), while now minimum GCC version supported by DPDK has been 4.9, C11 atomics support in compiler is no longer a problem. So non-C11 path can be removed. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng

[dpdk-dev] [PATCH] test/service_cores: fix wrong comment

2021-08-18 Thread Joyce Kong
Change the inaccurate comment of 'set pass flag' to 'clear pass flag' as the '*pass_test = 0' code actually implements clearing. Fixes: f038a81e1c56 ("service: add unit tests") Cc: sta...@dpdk.org Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- app/test/test_service_cores.c | 2 +- 1 f

[dpdk-dev] [DPDK] net/ipn3ke: change function label from EXPERIMENTAL to INTERNAL

2021-08-18 Thread Rosen Xu
'ipn3ke_bridge_func' is a global variable and it used in net & raw drivers. It's only used for drivers, so change it from EXPERIMENTAL to INTERNAL. Signed-off-by: Rosen Xu --- drivers/net/ipn3ke/version.map | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ipn3ke/ve