[dpdk-dev] [PATCH 22/38] net/sfc: implement representor Tx routine

2021-08-26 Thread Andrew Rybchenko
From: Igor Romanov Forward traffic that is transmitted from a port representor to the corresponding virtual function using the dedicated TxQ. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Ivan Malov --- drivers/net/sfc/sfc_repr.c |

[dpdk-dev] [PATCH 17/38] net/sfc: implement representor RxQ start/stop

2021-08-26 Thread Andrew Rybchenko
From: Igor Romanov Add extra libefx flags to Rx queue information initialization function interface to be able to specify the ingress m-port flag for a representor RxQ. Rx prefix of packets on that queue will contain ingress m-port field required for packet forwarding in representor proxy. Signe

[dpdk-dev] [PATCH 18/38] net/sfc: implement representor TxQ start/stop

2021-08-26 Thread Andrew Rybchenko
From: Igor Romanov Implement Tx queue start and stop in port representor proxy. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Ivan Malov --- drivers/net/sfc/sfc_ev.h | 8 ++ drivers/net/sfc/sfc_repr_proxy.c | 166 +++

[dpdk-dev] [PATCH 19/38] net/sfc: implement port representor start and stop

2021-08-26 Thread Andrew Rybchenko
From: Igor Romanov Implement queue start and stop operation both in port representors and representor proxy. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Ivan Malov --- drivers/net/sfc/sfc_mae.h| 9 +- drivers/net/sfc/sfc_r

[dpdk-dev] [PATCH 16/38] net/sfc: implement representor queue setup and release

2021-08-26 Thread Andrew Rybchenko
From: Igor Romanov Implement queue creation and destruction both in port representors and representor proxy. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Ivan Malov --- drivers/net/sfc/sfc_repr.c | 279 +

[dpdk-dev] [PATCH 15/38] net/sfc: add representor proxy port API

2021-08-26 Thread Andrew Rybchenko
From: Igor Romanov The API is required to create and destroy representor proxy port assigned to representor. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Ivan Malov --- drivers/net/sfc/sfc.c| 12 + drivers/net/sfc/sfc.h

[dpdk-dev] [PATCH 13/38] common/sfc_efx/base: add API to get mport selector by ID

2021-08-26 Thread Andrew Rybchenko
From: Igor Romanov The conversion is required when mport ID is received via mport allocation and mport selector is required for filter creation. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Ivan Malov --- drivers/common/sfc_efx/base/efx.

[dpdk-dev] [PATCH 14/38] common/sfc_efx/base: add mport alias MCDI wrappers

2021-08-26 Thread Andrew Rybchenko
From: Igor Romanov The APIs allow creation of mports for port representor traffic filtering. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Ivan Malov --- drivers/common/sfc_efx/base/efx.h | 13 drivers/common/sfc_efx/base/efx_mae

[dpdk-dev] [PATCH 12/38] common/sfc_efx/base: add filter ingress mport matching field

2021-08-26 Thread Andrew Rybchenko
From: Igor Romanov The field changes the mport for which the filter is created. It is required to filter traffic from VF on an alias mport. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Ivan Malov --- drivers/common/sfc_efx/base/ef10_filt

[dpdk-dev] [PATCH 11/38] net/sfc: add port representors infrastructure

2021-08-26 Thread Andrew Rybchenko
From: Igor Romanov Provide minimal implementation for port representors that only can be configured and can provide device information. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Ivan Malov --- doc/guides/nics/sfc_efx.rst | 13 +- dr

[dpdk-dev] [PATCH 10/38] common/sfc_efx/base: allow creating invalid mport selectors

2021-08-26 Thread Andrew Rybchenko
From: Viacheslav Galaktionov There isn't always a valid mport that can be used. For these cases, special invalid selectors can be generated. Requests that use such selectors in any way will be rejected. Signed-off-by: Viacheslav Galaktionov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Mor

[dpdk-dev] [PATCH 07/38] net/sfc: add representors proxy infrastructure

2021-08-26 Thread Andrew Rybchenko
From: Igor Romanov Representor proxy is a mediator between virtual functions and port representors. It forwards traffic between virtual functions and port representors performing base PF ethdev + VF's representor traffic (de-)multiplexing. The implementation will be provided by later patches. Si

[dpdk-dev] [PATCH 09/38] net/sfc: move adapter state enum to separate header

2021-08-26 Thread Andrew Rybchenko
From: Igor Romanov Adapter state will be reused by representors, that will have a separate adapter. Rename adapter state to ethdev state so that the meaning of it is clearer. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Ivan Malov --- dr

[dpdk-dev] [PATCH 08/38] net/sfc: reserve TxQ and RxQ for port representors

2021-08-26 Thread Andrew Rybchenko
From: Igor Romanov A Tx/Rx queue pair is required to forward traffic between port representors and virtual functions. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Ivan Malov --- drivers/net/sfc/sfc.c| 51 +

[dpdk-dev] [PATCH 06/38] net/sfc: support EF100 Tx override prefix

2021-08-26 Thread Andrew Rybchenko
From: Igor Romanov Add internal mbuf dynamic flag and field to request EF100 native Tx datapath to use Tx prefix descriptor to override egress m-port. Overriding egress m-port is necessary on representor Tx burst so that the packet will reach corresponding VF. Signed-off-by: Igor Romanov Signed

[dpdk-dev] [PATCH 05/38] common/sfc_efx/base: add an API to get mport ID by selector

2021-08-26 Thread Andrew Rybchenko
From: Igor Romanov The mport ID is required to set appropriate egress mport ID in Tx prefix for port representor TxQ. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Ivan Malov --- drivers/common/sfc_efx/base/efx.h | 21 + drive

[dpdk-dev] [PATCH 04/38] net/sfc: insert switchdev mode MAE rules

2021-08-26 Thread Andrew Rybchenko
From: Igor Romanov By default, the firmware is in EVB mode, but insertion of the first MAE rule resets it to switchdev mode automatically and removes all automatic MAE rules added by EVB support. On initialisation, insert MAE rules that forward traffic between PHY and PF. Add an API for creation

[dpdk-dev] [PATCH 03/38] net/sfc: add switch mode device argument

2021-08-26 Thread Andrew Rybchenko
From: Igor Romanov Add the argument that allows user to choose either switchdev or legacy mode. Legacy mode enables switching by using Ethernet virtual bridging (EVB) API. In switchdev mode, VF traffic goes via port representor (if any) on PF, and software virtual switch (for example, Open vSwitc

[dpdk-dev] [PATCH 02/38] common/sfc_efx/base: update EF100 registers definitions

2021-08-26 Thread Andrew Rybchenko
Pick up all changes and extra definitions. Signed-off-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/efx_regs_ef100.h | 106 +++ drivers/common/sfc_efx/base/rhead_rx.c | 2 +- 2 files changed, 85 insertions(+), 23 deletions(-) diff --git a/drivers/common/sfc_efx/ba

[dpdk-dev] [PATCH 01/38] common/sfc_efx/base: update MCDI headers

2021-08-26 Thread Andrew Rybchenko
Pickup new FW interface definitions. Signed-off-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/efx_regs_mcdi.h | 1211 ++- 1 file changed, 1176 insertions(+), 35 deletions(-) diff --git a/drivers/common/sfc_efx/base/efx_regs_mcdi.h b/drivers/common/sfc_efx/base/efx_regs_m

[dpdk-dev] [PATCH 00/38] net/sfc: support port representors

2021-08-26 Thread Andrew Rybchenko
Support port representors on SN1000 SmartNICs including: - new syntax with controller, PF and VF specification - PF representors - two controllers: host and embedded SoC The patch series depends on [1] (including build dependency) since it provides representors info on admin PF only. [1] https

Re: [dpdk-dev] [EXT] Re: [v4, 1/2] common/cnxk: add telemetry endpoints to npa

2021-08-26 Thread Gowrishankar Muthukrishnan
> > includes += include_directories('../../bus/pci') > > includes += include_directories('../../../lib/net') > > +includes += include_directories('../../../lib/telemetry') > > Rather than giving the include directories, I'd recommend using "deps" > variable to specify a direct dependency on thos

[dpdk-dev] [v5, 2/2] mempool/cnxk: add telemetry end points

2021-08-26 Thread Gowrishankar Muthukrishnan
Adding telemetry end points to cnxk mempool driver. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/mempool/cnxk/cnxk_mempool_telemetry.c | 100 ++ drivers/mempool/cnxk/meson.build | 3 +- 2 files changed, 102 insertions(+), 1 deletion(-) create mode 100644

[dpdk-dev] [v5, 1/2] common/cnxk: add telemetry endpoints to npa

2021-08-26 Thread Gowrishankar Muthukrishnan
Add telemetry endpoints to npa. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/common/cnxk/cnxk_telemetry.h | 26 +++ drivers/common/cnxk/cnxk_telemetry_npa.c | 227 +++ drivers/common/cnxk/meson.build | 6 +- drivers/common/cnxk/roc_platform.h |

[dpdk-dev] [v5, 0/2] cnxk: enable npa and mempool telemetry

2021-08-26 Thread Gowrishankar Muthukrishnan
This patch series enables telemetry in NPA LF and mempool driver of cnxk. v5: - fixed meson.build files to use deps. Gowrishankar Muthukrishnan (2): common/cnxk: add telemetry endpoints to npa mempool/cnxk: add telemetry end points drivers/common/cnxk/cnxk_telemetry.h | 26 ++ dr

[dpdk-dev] [PATCH] app/testpmd: add command to print representor info

2021-08-26 Thread Andrew Rybchenko
From: Viacheslav Galaktionov Make it simpler to debug configurations and code related to the representor info API. Signed-off-by: Viacheslav Galaktionov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- app/test-pmd/cmdline.c | 117 + 1 fil

[dpdk-dev] [PATCH] crypto/octeontx2: fix unaligned access to device memory

2021-08-26 Thread Anoob Joseph
From: Danny Patel Use otx2_mbox_memcpy() instead of memcpy() to prevent unaligned access. Fixes: a0645ed0d6ef ("crypto/octeontx2: discover capabilities") Cc: ktejas...@marvell.com Signed-off-by: Danny Patel Signed-off-by: Anoob Joseph --- drivers/crypto/octeontx2/otx2_cryptodev_mbox.c | 2 +-

[dpdk-dev] [PATCH v1] vhost: add sanity check for resubmiting reqs in split ring

2021-08-26 Thread Li Feng
When getting reqs from the avail ring, the id may exceed inflight queue size. Then the dpdk will crash forever. Signed-off-by: Li Feng --- lib/vhost/vhost_user.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c index 2

Re: [dpdk-dev] DPDK 21.11+ Windows Roadmap

2021-08-26 Thread William Tu
Hi Dmitry, Thanks, I have one question. On Thu, Aug 26, 2021 at 5:19 PM Dmitry Kozlyuk wrote: > > This roadmap has been discussed on Windows community calls Aug 5 and Aug 19 > and it met no principal objections. It extends beyond the nearest release, > but it is useful to have a comprehensive bac

[dpdk-dev] [PATCH v2] examples/vhost: fix memory leak on forwarding packets

2021-08-26 Thread Wenwu Ma
In function virtio_tx_local(), when the device receiving the packet is the same as the device to which the packet is forwarded, or the device is removed, we return but not free the packet, it will cause a memory leak. Fixes: 4796ad63ba1f ("examples/vhost: import userspace vhost application") Cc: s

[dpdk-dev] [Bug 797] [dpdk-21.11]Segmentation fault when start txonly packet forward after set txpkts=40, 64 and txsplit=rand

2021-08-26 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=797 Bug ID: 797 Summary: [dpdk-21.11]Segmentation fault when start txonly packet forward after set txpkts=40,64 and txsplit=rand Product: DPDK Version: unspecified Hardware: All

[dpdk-dev] 回复: [PATCH v2] net/mlx5: fix potential unreleased lock problem

2021-08-26 Thread YE Chengfeng
It seems that I send this patch to a wrong place, please just ignore it. Thanks, Chengfeng 发件人: YE Chengfeng 发送时间: 2021年8月27日 2:56 收件人: asoma...@amd.com 抄送: dev@dpdk.org ; YE Chengfeng 主题: [PATCH v2] net/mlx5: fix potential unreleased lock problem The lock sh-

[dpdk-dev] [PATCH v2] net/axgbe: fix potential unreleased lock problem

2021-08-26 Thread Chengfeng Ye
The lock pdata->phy_mutex may not be correctly released if the function return in these two branches, which may lead to deadlock if the lock is acquired again. Cc: cy...@connect.ust.hk Bugzilla ID: 776 Signed-off-by: Chengfeng Ye --- drivers/net/axgbe/axgbe_phy_impl.c | 5 - 1 file changed,

[dpdk-dev] [PATCH v2] net/mlx5: fix potential unreleased lock problem

2021-08-26 Thread Chengfeng Ye
The lock sh->txpp.mutex isn't correctly released if the function return in these two branches, which may lead to deadlock if the lock is acquired again. Cc: cy...@connect.ust.hk Bugzilla ID: 774 Signed-off-by: Chengfeng Ye --- drivers/net/mlx5/mlx5_txpp.c | 6 +- 1 file changed, 5 insertion

[dpdk-dev] [PATCH v2] net/axgbe: fix potential unreleased lock problem in axgbe_i2c_xfer

2021-08-26 Thread Chengfeng Ye
The lock pdata->i2c_mutex is not released if the function return in these two patched branches, which may lead to deadlock problem if this lock is acquired again. Cc: cy...@connect.ust.hk Bugzilla ID: 777 Signed-off-by: Chengfeng Ye --- drivers/net/axgbe/axgbe_i2c.c | 2 ++ 1 file changed, 2 in

[dpdk-dev] [PATCH v2] net/mlx5: fix potential unreleased lock problem

2021-08-26 Thread Chengfeng Ye
The lock sh->txpp.mutex isn't correctly released if the function return in these two branches, which may lead to deadlock if the lock is acquired again. Cc: cy...@connect.ust.hk Bugzilla ID: 774 Signed-off-by: Chengfeng Ye --- drivers/net/mlx5/mlx5_txpp.c | 6 +- 1 file changed, 5 insertion

Re: [dpdk-dev] [PATCH] docs: fix bond driver name

2021-08-26 Thread Min Hu (Connor)
Acked-by: Min Hu (Connor) 在 2021/8/27 7:10, Ben Magistro 写道: The documentation for the bond driver lists the name as `net/bond` however the driver should be `net/bonding`. Signed-off-by: Ben Magistro --- doc/guides/prog_guide/link_bonding_poll_mode_drv_lib.rst | 2 +- 1 file changed, 1 ins

[dpdk-dev] DPDK 21.11+ Windows Roadmap

2021-08-26 Thread Dmitry Kozlyuk
This roadmap has been discussed on Windows community calls Aug 5 and Aug 19 and it met no principal objections. It extends beyond the nearest release, but it is useful to have a comprehensive backlog in one place. In 21.11 it looks realistic to have: * static build of DPDK installed and consumed

[dpdk-dev] [PATCH] docs: fix bond driver name

2021-08-26 Thread Ben Magistro
The documentation for the bond driver lists the name as `net/bond` however the driver should be `net/bonding`. Signed-off-by: Ben Magistro --- doc/guides/prog_guide/link_bonding_poll_mode_drv_lib.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/prog_guide/link_b

Re: [dpdk-dev] [PATCH v16 6/9] dma/skeleton: introduce skeleton dmadev driver

2021-08-26 Thread Bruce Richardson
On Mon, Aug 23, 2021 at 11:31:31AM +0800, Chengwen Feng wrote: > Skeleton dmadevice driver, on the lines of rawdev skeleton, is for > showcasing of the dmadev library. This driver implements cpucopy 'DMA', > so that a test module can be developed. > > Design of skeleton involves a virtual device w

[dpdk-dev] [RFC PATCH 7/7] app/test: add dmadev fill tests

2021-08-26 Thread Bruce Richardson
From: Kevin Laatz For dma devices which support the fill operation, run unit tests to verify fill behaviour is correct. Signed-off-by: Kevin Laatz Signed-off-by: Bruce Richardson --- app/test/test_dmadev.c | 68 ++ 1 file changed, 68 insertions(+) diff

[dpdk-dev] [RFC PATCH 6/7] app/test: test dmadev instance failure handling

2021-08-26 Thread Bruce Richardson
Add a series of tests to inject bad copy operations into a dmadev to test the error handling and reporting capabilities. Various combinations of errors in various positions in a burst are tested, as are errors in bursts with fence flag set, and multiple errors in a single burst. Signed-off-by: Bru

[dpdk-dev] [RFC PATCH 5/7] app/test: add more comprehensive dmadev copy tests

2021-08-26 Thread Bruce Richardson
Add unit tests for various combinations of use for dmadev, copying bursts of packets in various formats, e.g. 1. enqueuing two smaller bursts and completing them as one burst 2. enqueuing one burst and gathering completions in smaller bursts 3. using completed_status() function to gather completio

[dpdk-dev] [RFC PATCH 4/7] app/test: add basic dmadev copy tests

2021-08-26 Thread Bruce Richardson
For each dmadev instance, perform some basic copy tests to validate that functionality. Signed-off-by: Bruce Richardson --- app/test/test_dmadev.c | 157 + 1 file changed, 157 insertions(+) diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c inde

[dpdk-dev] [RFC PATCH 3/7] app/test: add basic dmadev instance tests

2021-08-26 Thread Bruce Richardson
Run basic sanity tests for configuring, starting and stopping a dmadev instance to help validate drivers. This also provides the framework for future tests for data-path operation. Signed-off-by: Bruce Richardson --- app/test/test_dmadev.c | 70 ++ 1 file

[dpdk-dev] [RFC PATCH 2/7] dmadev: remove selftest support

2021-08-26 Thread Bruce Richardson
Since the dmadev provides a common API for all devices, there should be no need to drivers to perform their own selftests, but instead should be tested by the common tests in the autotest binary. Signed-off-by: Bruce Richardson --- app/test/test_dmadev.c | 27 - d

[dpdk-dev] [RFC PATCH 1/7] app/test: take API tests from skeleton dmadev

2021-08-26 Thread Bruce Richardson
Rather than having the API level tests as self-test for the skeleton driver, we can have these tests included directly into the autotest, so that potentially other drivers can use them in future. Signed-off-by: Bruce Richardson --- app/test/meson.build | 1 + app/test/t

[dpdk-dev] [RFC PATCH 0/7] add test suite for DMA drivers

2021-08-26 Thread Bruce Richardson
This patchset adds a fairly comprehensive set of tests for basic dmadev functionality. It takes the existing tests that were in the skeleton dmadev and uses those to create a set of API-level tests to check the basics of the dmadev library itself. Once that is done, the "selftest" part of the dmade

Re: [dpdk-dev] [v4, 1/2] common/cnxk: add telemetry endpoints to npa

2021-08-26 Thread Bruce Richardson
On Thu, Aug 26, 2021 at 10:45:10PM +0530, Gowrishankar Muthukrishnan wrote: > Add telemetry endpoints to npa. > > Signed-off-by: Gowrishankar Muthukrishnan > --- > drivers/common/cnxk/cnxk_telemetry.h | 26 +++ > drivers/common/cnxk/cnxk_telemetry_npa.c | 227 +++ > driv

Re: [dpdk-dev] [PATCH v5 1/3] kni: rework rte_kni_update_link using ioctl

2021-08-26 Thread Stephen Hemminger
On Thu, 26 Aug 2021 20:46:47 +0300 Igor Ryzhov wrote: > Could you please clarify where exactly do I need to use rtnl lock? > From what I understand, netif_carrier_on/off can be called without the lock. Just a basic concern. The new stuff looks ok. If you follow what current upstream virtio is do

Re: [dpdk-dev] [PATCH v5 1/3] kni: rework rte_kni_update_link using ioctl

2021-08-26 Thread Igor Ryzhov
Could you please clarify where exactly do I need to use rtnl lock? >From what I understand, netif_carrier_on/off can be called without the lock. On Thu, Aug 26, 2021 at 8:15 PM Stephen Hemminger < step...@networkplumber.org> wrote: > On Thu, 26 Aug 2021 18:19:09 +0300 > Igor Ryzhov wrote: > > >

[dpdk-dev] [PATCH] net/mlx5: fix protential unreleased lock problem

2021-08-26 Thread Chengfeng Ye
The lock sh->txpp.mutex isn't correctly released if the function return in the patched branch, which may lead to deadlock if this lock is acuired again. The patch is to fix this problem. Cc: cy...@connect.ust.hk Bugzilla ID: 774 Signed-off-by: Chengfeng Ye --- drivers/net/mlx5/mlx5_txpp.c | 6

[dpdk-dev] [PATCH] net/axgbe: fix protential unreleased lock problem in axgbe_i2c_xfer

2021-08-26 Thread Chengfeng Ye
The lock pdata->i2c_mutex is not released if the function return in these two patched branches, which may lead to deadlock problem if this lock is acuired again. The patch is to fix this problem. Cc: cy...@connect.ust.hk Bugzilla ID: 777 Signed-off-by: Chengfeng Ye --- drivers/net/axgbe/axgbe

[dpdk-dev] [PATCH] net/mlx5: fix protential unreleased lock problem

2021-08-26 Thread Chengfeng Ye
The lock sh->txpp.mutex isn't correctly released if the function return in the patched branch, which may lead to deadlock if this lock is acuired again. The patch is to fix this problem. Cc: cy...@connect.ust.hk Bugzilla ID: 774 Signed-off-by: Chengfeng Ye --- drivers/net/mlx5/mlx5_txpp.c | 6

[dpdk-dev] [PATCH] net/axgbe: fix protential unreleased lock problem

2021-08-26 Thread Chengfeng Ye
The lock pdata->phy_mutex may not be correctly released if the function return in these two branches, which may lead to deadlock if the lock is acuired again. The patch is to fix this problem. Cc: cy...@connect.ust.hk Bugzilla ID: 776 Signed-off-by: Chengfeng Ye --- drivers/net/axgbe/axgbe_ph

[dpdk-dev] [v4, 2/2] mempool/cnxk: add telemetry end points

2021-08-26 Thread Gowrishankar Muthukrishnan
Adding telemetry end points to cnxk mempool driver. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/mempool/cnxk/cnxk_mempool_telemetry.c | 100 ++ drivers/mempool/cnxk/meson.build | 1 + 2 files changed, 101 insertions(+) create mode 100644 drivers/mempool/

Re: [dpdk-dev] [PATCH v5 1/3] kni: rework rte_kni_update_link using ioctl

2021-08-26 Thread Stephen Hemminger
On Thu, 26 Aug 2021 18:19:09 +0300 Igor Ryzhov wrote: > > +static int > +kni_ioctl_link(struct net *net, uint32_t ioctl_num, > + unsigned long ioctl_param) > +{ > + struct kni_net *knet = net_generic(net, kni_net_id); > + int ret = -EINVAL; > + struct kni_dev *dev, *n; >

[dpdk-dev] [v4, 1/2] common/cnxk: add telemetry endpoints to npa

2021-08-26 Thread Gowrishankar Muthukrishnan
Add telemetry endpoints to npa. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/common/cnxk/cnxk_telemetry.h | 26 +++ drivers/common/cnxk/cnxk_telemetry_npa.c | 227 +++ drivers/common/cnxk/meson.build | 4 + drivers/common/cnxk/roc_platform.h |

[dpdk-dev] [v4, 0/2] cnxk: enable npa and mempool telemetry

2021-08-26 Thread Gowrishankar Muthukrishnan
This patch series enables telemetry in NPA LF and mempool driver of cnxk. v4: - added mempool driver endpoints. - removed lib/telemetry changes to include _ptr api. Gowrishankar Muthukrishnan (2): common/cnxk: add telemetry endpoints to npa mempool/cnxk: add telemetry end points drivers/c

Re: [dpdk-dev] [EXT] [PATCH] doc: announce library refactor for ABI improvement

2021-08-26 Thread Andrew Rybchenko
On 8/26/21 2:04 PM, Bruce Richardson wrote: > On Thu, Aug 26, 2021 at 10:46:35AM +, Akhil Goyal wrote: >>> Target is to reduce the public interface surface to improve the ABI >>> stability and this is preparation for the longer term stable ABI >>> support. >>> >>> Mainly device abstraction laye

[dpdk-dev] [PATCH v5 3/3] app/test: fix return value of test_kni_link_change

2021-08-26 Thread Igor Ryzhov
If the child process returns -1, WEXITSTATUS converts to 255 because it takes only 8 least significant bits. As a result, the test is not considered failed when it should. Signed-off-by: Igor Ryzhov --- app/test/test_kni.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/t

[dpdk-dev] [PATCH v5 2/3] kni: implement basic get_link_ksettings callback

2021-08-26 Thread Igor Ryzhov
It allows inspecting link parameters using ethtool. Signed-off-by: Igor Ryzhov --- kernel/linux/kni/kni_net.c | 25 + 1 file changed, 25 insertions(+) diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c index 611719b5ee27..931b9daf104f 100644 --- a/kerne

[dpdk-dev] [PATCH v5 1/3] kni: rework rte_kni_update_link using ioctl

2021-08-26 Thread Igor Ryzhov
Current implementation doesn't allow us to update KNI carrier if the interface is not yet UP in kernel. It means that we can't use it in the same thread which is processing rte_kni_ops.config_network_if, which is very convenient, because it allows us to have correct carrier status of the interface

[dpdk-dev] [PATCH v1 7/8] drivers/crypto: move zuc PMD to IPsec-mb framework

2021-08-26 Thread Ciara Power
From: pbronowx This patch removes the crypto/zuc folder and gathers all zuc PMD implementation specific details into a single file, pmd_zuc.c in the crypto/ipsec_mb folder. Signed-off-by: pbronowx --- doc/guides/cryptodevs/zuc.rst | 3 +- drivers/crypto/ipsec_mb/meson.build

[dpdk-dev] [PATCH v1 8/8] crypto/ipsec_mb: add chacha20-poly1305 PMD to framework

2021-08-26 Thread Ciara Power
From: Kai Ji Add in new chacha20_poly1305 support in ipsec_mb. Add in new chacha20_poly1305 test vector for SGL test. Signed-off-by: Kai Ji --- app/test/test_cryptodev.c | 22 + app/test/test_cryptodev.h | 1 + app/test/test_cryptodev_aead_test_vector

[dpdk-dev] [PATCH v1 6/8] crypto/ipsec_mb: add snow3g digest appended ops support

2021-08-26 Thread Ciara Power
From: pbronowx This patch enables out-of-place auth-cipher operations where digest should be encrypted along with the rest of raw data. It also adds support for partially encrypted digest when using auth-cipher operations. Signed-off-by: Damian Nowak Signed-off-by: Kai Ji Signed-off-by: pbrono

[dpdk-dev] [PATCH v1 5/8] drivers/crypto: move snow3g PMD to IPsec-mb framework

2021-08-26 Thread Ciara Power
From: pbronowx This patch removes the crypto/snow3g folder and gathers all snow3g PMD implementation specific details into a single file, pmd_snow3g.c in the crypto/ipsec_mb folder. Signed-off-by: pbronowx --- doc/guides/cryptodevs/snow3g.rst | 3 +- drivers/crypto/ipsec_mb/meso

[dpdk-dev] [PATCH v1 4/8] drivers/crypto: move kasumi PMD to IPsec-mb framework

2021-08-26 Thread Ciara Power
From: pbronowx This patch removes the crypto/kasumi folder and gathers all kasumi PMD implementation specific details into a single file, pmd_kasumi.c in the crypto/ipsec_mb folder. Signed-off-by: pbronowx --- doc/guides/cryptodevs/kasumi.rst | 3 +- drivers/crypto/ipsec_mb/meso

[dpdk-dev] [PATCH v1 2/8] drivers/crypto: move aesni-mb PMD to IPsec-mb framework

2021-08-26 Thread Ciara Power
From: pbronowx This patch removes the crypto/aesni_mb folder and gathers all aesni-mb PMD implementation specific details into a single file, pmd_aesni_mb.c in crypto/ipsec_mb. Signed-off-by: pbronowx --- doc/guides/cryptodevs/aesni_mb.rst|4 +- .../crypto/aesni_mb/aesni_mb_pmd

[dpdk-dev] [PATCH v1 3/8] drivers/crypto: move aesni-gcm PMD to IPsec-mb framework

2021-08-26 Thread Ciara Power
From: pbronowx This patch removes the crypto/aesni_gcm folder and gathers all aesni-gcm PMD implementation specific details into a single file, pmd_aesni_gcm.c in the crypto/ipsec_mb folder. A redundant check for iv length is removed. Signed-off-by: pbronowx --- doc/guides/cryptodevs/aesni_gcm

[dpdk-dev] [PATCH v1 1/8] drivers/crypto: introduce IPsec-mb framework

2021-08-26 Thread Ciara Power
From: Fan Zhang This patch introduces the new framework making all common code of SW crypto PMDs implementations built on top of intel-ipsec-mb library shareable, also helps to reduce future effort on the code maintenance and feature updates. Signed-off-by: Fan Zhang --- drivers/crypto/ipsec_m

[dpdk-dev] [PATCH v1 0/8] drivers/crypto: introduce ipsec_mb framework

2021-08-26 Thread Ciara Power
This set of patches introduces a new framework, making all common code of SW crypto PMD implementations built on top of intel-ipsec-mb library sharable. This helps to reduce future effort on the code maintenance and future updates. It also moves all SW PMD implementation specific details into singl

[dpdk-dev] [RFC 7/7] eal/alarm: introduce alarm fini routine

2021-08-26 Thread Harman Kalra
Implementing alarm cleanup routine, where the memory allocated for interrupt instance can be freed. Signed-off-by: Harman Kalra --- lib/eal/common/eal_private.h | 11 lib/eal/freebsd/eal.c| 1 + lib/eal/freebsd/eal_alarm.c | 50 +++- lib/eal/lin

[dpdk-dev] [RFC 6/7] eal/interrupts: make interrupt handle structure opaque

2021-08-26 Thread Harman Kalra
Moving interrupt handle structure definition inside the c file to make its fields totally opaque to the outside world. Dynamically allocating the efds and elist array os intr_handle structure, based on size provided by user. Eg size can be MSIX interrupts supported by a PCI device. Signed-off-by:

[dpdk-dev] [RFC 4/7] test/interrupt: apply get set interrupt handle APIs

2021-08-26 Thread Harman Kalra
Updating the interrupt testsuite to make use of interrupt handle get set APIs. Signed-off-by: Harman Kalra --- app/test/test_interrupts.c | 237 - 1 file changed, 152 insertions(+), 85 deletions(-) diff --git a/app/test/test_interrupts.c b/app/test/test_inter

[dpdk-dev] [RFC 3/7] eal/interrupts: avoid direct access to interrupt handle

2021-08-26 Thread Harman Kalra
Making changes to the interrupt framework to use interrupt handle APIs to get/set any field. Direct access to any of the fields should be avoided to avoid any ABI breakage in future. Signed-off-by: Harman Kalra --- lib/eal/freebsd/eal_interrupts.c | 93 ++ lib/eal/linux/eal_interrupts.c

[dpdk-dev] [RFC 2/7] eal/interrupts: implement get set APIs

2021-08-26 Thread Harman Kalra
Implementing get set APIs for interrupt handle fields. To make any change to the interrupt handle fields, one should make use of these APIs. Signed-off-by: Harman Kalra --- lib/eal/common/eal_common_interrupts.c | 506 + lib/eal/common/meson.build | 2 + lib

[dpdk-dev] [RFC 1/7] eal: interrupt handle API prototypes

2021-08-26 Thread Harman Kalra
Defining protypes of get/set APIs for accessing/manipulating interrupt handle fields. Internal interrupt header i.e. rte_eal_interrupt.h is rearranged, as APIs defined are moved to rte_interrupts.h and epoll specific definitions are moved to a new header rte_epoll.h. Later in the series rte_eal_in

[dpdk-dev] [RFC 0/7] make rte_intr_handle internal

2021-08-26 Thread Harman Kalra
Moving struct rte_intr_handle as an internal structure to avoid any ABI breakages in future. Since this structure defines some static arrays and changing respective macros breaks the ABI. Eg: Currently RTE_MAX_RXTX_INTR_VEC_ID imposes a limit of maximum 512 MSI-X interrupts that can be defined for

[dpdk-dev] [Bug 796] Lack of error checking in rte_pktmbuf_mtod could lead to a seg fault

2021-08-26 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=796 Bug ID: 796 Summary: Lack of error checking in rte_pktmbuf_mtod could lead to a seg fault Product: DPDK Version: 21.05 Hardware: All OS: All Status: UNCO

Re: [dpdk-dev] 19.11.10 patches review and test

2021-08-26 Thread Ali Alnubani
> -Original Message- > From: christian.ehrha...@canonical.com > > Sent: Wednesday, August 18, 2021 5:54 PM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Akhil Goyal ; Ali Alnubani ; > benjamin.wal...@intel.com; David Christensen ; > hariprasad.govindhara...@intel.com; Hema

[dpdk-dev] [PATCH v3] net/i40e: solve vf vlan strip

2021-08-26 Thread Qiming Chen
Kernel PF+DPDK VF mode, after vf adds vlan, the test result shows that the vlan received from vf has been stripped. The patch solves the problem that the kernel i40e.ko driver strips the vlan by default after vf adds vlan. Determine whether to strip vlan through the DEV_RX_OFFLOAD_VLAN_STRIP mask

[dpdk-dev] [PATCH v3] net/i40e: solve vf vlan strip

2021-08-26 Thread Qiming Chen
Kernal PF+DPDK VF mode, after vf adds vlan, the test result shows that the vlan received from vf has been stripped. The patch solves the problem that the kernel i40e.ko driver strips the vlan by default after vf adds vlan. Determine whether to strip vlan through the DEV_RX_OFFLOAD_VLAN_STRIP mask

Re: [dpdk-dev] 19.11.10 patches review and test

2021-08-26 Thread Jiang, YuX
Hi All, Testing with dpdk v19.11.10-rc1 from Intel is finished, one new issue is found. New issue: https://bugs.dpdk.org/show_bug.cgi?id=794 # Basic Intel(R) NIC testing * PF(i40e, ixgbe): test scenarios including rte_flow/TSO/Jumboframe/checksum offload/Tunnel, etc. Listed but not all. - Known

Re: [dpdk-dev] [RFC 0/7] hide eth dev related structures

2021-08-26 Thread Jerin Jacob
On Fri, Aug 20, 2021 at 9:59 PM Konstantin Ananyev wrote: > > NOTE: This is just an RFC to start further discussion and collect the > feedback. > Due to significant amount of work, changes required are applied only to two > PMDs so far: net/i40e and net/ice. > So to build it you'll need to add: >

Re: [dpdk-dev] 20.11.3 patches review and test

2021-08-26 Thread Luca Boccassi
On Thu, 2021-08-26 at 12:09 +0200, Christian Ehrhardt wrote: > On Mon, Aug 23, 2021 at 5:30 PM Luca Boccassi wrote: > > > > > -Original Message- > > > From: dev On Behalf Of luca.bocca...@gmail.com > > > Sent: Monday, August 9, 2021 4:44 PM > > > To: sta...@dpdk.org > > > Cc: dev@dpdk.or

Re: [dpdk-dev] [PATCH v2 01/15] ethdev: introduce shared Rx queue

2021-08-26 Thread Jerin Jacob
On Thu, Aug 19, 2021 at 5:39 PM Xueming(Steven) Li wrote: > > > > > -Original Message- > > From: Jerin Jacob > > Sent: Thursday, August 19, 2021 1:27 PM > > To: Xueming(Steven) Li > > Cc: dpdk-dev ; Ferruh Yigit ; > > NBU-Contact-Thomas Monjalon ; > > Andrew Rybchenko > > Subject: Re:

Re: [dpdk-dev] [PATCH] examples/vhost: fix memory leak on forwarding packets.

2021-08-26 Thread Xia, Chenbo
> -Original Message- > From: Ma, WenwuX > Sent: Wednesday, August 18, 2021 1:13 AM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; Jiang, > Cheng1 ; Hu, Jiayu ; Ma, WenwuX > ; sta...@dpdk.org > Subject: [PATCH] examples/vhost: fix memory leak on forwarding packets. Shou

Re: [dpdk-dev] [PATCH v2 06/15] app/testpmd: add common fwd wrapper function

2021-08-26 Thread Jerin Jacob
On Wed, Aug 18, 2021 at 7:38 PM Xueming(Steven) Li wrote: > > > > > -Original Message- > > From: Jerin Jacob > > Sent: Wednesday, August 18, 2021 7:48 PM > > To: Xueming(Steven) Li > > Cc: Jack Min ; dpdk-dev ; Xiaoyun Li > > > > Subject: Re: [dpdk-dev] [PATCH v2 06/15] app/testpmd: ad

[dpdk-dev] [Bug 795] [dpdk-19.11] unit_tests_power/power_cpufreq: unit test failed

2021-08-26 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=795 Bug ID: 795 Summary: [dpdk-19.11] unit_tests_power/power_cpufreq: unit test failed Product: DPDK Version: 19.11 Hardware: All OS: All Status: UNCONFIRMED

[dpdk-dev] [PATCH 5/5] crypto/dpaa_sec: add pdcp short MAC-I support

2021-08-26 Thread Gagandeep Singh
This patch add pdcp security short MAC-I support for dpaa_sec driver. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa_sec/dpaa_sec.c | 3 +++ drivers/crypto/dpaa_sec/dpaa_sec.h | 11 ++- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/dpaa_sec/dpaa_s

[dpdk-dev] [PATCH 4/5] crypto/dpaa2_sec: add PDCP short MAC-I support

2021-08-26 Thread Gagandeep Singh
This patch add PDCP short mac support in dpaa2_sec driver. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 4 drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 9 + 2 files changed, 13 insertions(+) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci

[dpdk-dev] [PATCH 3/5] test/crypto: add pdcp security short MAC-I support

2021-08-26 Thread Gagandeep Singh
This patch add support to test the pdcp short mac packets support in crypto. Signed-off-by: Gagandeep Singh --- app/test/test_cryptodev.c | 48 ...est_cryptodev_security_pdcp_test_vectors.h | 105 +- 2 files changed, 152 insertions(+), 1 deletion(-)

[dpdk-dev] [PATCH 2/5] security: add pdcp short MAC-I support

2021-08-26 Thread Gagandeep Singh
From: Hemant Agrawal This patch add support to handle PDCP short MAC-I domain along with standard control and data domains as it has to be treaty as special case with PDCP protocol offload support. ShortMAC-I is the 16 least significant bits of calculated MAC-I. Usually when a RRC message is exc

[dpdk-dev] [PATCH 1/5] common/dpaax: fix IV value for shortMAC-I for SNOW algo

2021-08-26 Thread Gagandeep Singh
The logic was incorecly doing conditional swap. It need to be bit swap always. Fixes: 73a24060cd70 ("crypto/dpaa2_sec: add sample PDCP descriptor APIs") Cc: sta...@dpdk.org Signed-off-by: Gagandeep Singh --- drivers/common/dpaax/caamflib/desc/pdcp.h | 7 --- 1 file changed, 4 insertions(+),

[dpdk-dev] [PATCH 0/5] support of MAC-I

2021-08-26 Thread Gagandeep Singh
This series add support of Message Authentication Code - Integrity on DPAAX platforms. Gagandeep Singh (4): common/dpaax: fix IV value for shortMAC-I for SNOW algo test/crypto: add pdcp security short MAC-I support crypto/dpaa2_sec: add PDCP short MAC-I support crypto/dpaa_sec: add pdcp sh

Re: [dpdk-dev] [PATCH v5 2/2] drivers/raw: remove octeontx2-ep driver

2021-08-26 Thread Radha Mohan
On Thu, Aug 26, 2021 at 4:20 PM Radha Mohan Chintakuntla wrote: > > Removing the rawdev based octeontx2-ep driver as the dependent > common/octeontx2 will soon be going away. Moreover this driver is no > longer required as the net/octeontx_ep driver is sufficient. > > Signed-off-by: Radha Mohan Ch

Re: [dpdk-dev] [EXT] [PATCH] doc: announce library refactor for ABI improvement

2021-08-26 Thread Bruce Richardson
On Thu, Aug 26, 2021 at 10:46:35AM +, Akhil Goyal wrote: > > Target is to reduce the public interface surface to improve the ABI > > stability and this is preparation for the longer term stable ABI > > support. > > > > Mainly device abstraction layer libraries are impacted because they have >

[dpdk-dev] [PATCH v5 2/2] drivers/raw: remove octeontx2-ep driver

2021-08-26 Thread Radha Mohan Chintakuntla
Removing the rawdev based octeontx2-ep driver as the dependent common/octeontx2 will soon be going away. Moreover this driver is no longer required as the net/octeontx_ep driver is sufficient. Signed-off-by: Radha Mohan Chintakuntla --- Changes from v4: Replaced the reference to documentation in

[dpdk-dev] [PATCH v5 1/2] drivers/raw: remove octeontx2-dma driver

2021-08-26 Thread Radha Mohan Chintakuntla
Removing the rawdev based octeontx2-dma driver as the dependent common/octeontx2 will be soon be going away. Also a new DMA driver will be coming in this place once the rte_dmadev library is in. Signed-off-by: Radha Mohan Chintakuntla --- Changes from v4: Replaced the reference to documentation i

  1   2   >