Re: [dpdk-dev] [PATCH] eal: make rte_lcore_cpuset and rte_lcore_to_cpu_id stable

2021-09-01 Thread Andrew Rybchenko
On 8/31/21 11:08 PM, Stephen Hemminger wrote: > These were converted from inline to functions in 19.11 > and should be marked as stable now. > > Signed-off-by: Stephen Hemminger > --- > lib/eal/include/rte_lcore.h | 8 > lib/eal/version.map | 4 ++-- > 2 files changed, 2 inserti

Re: [dpdk-dev] [PATCH] ethdev: remove experimental flag from getting intr fd API

2021-09-01 Thread Andrew Rybchenko
On 9/1/21 4:50 AM, Xiaoyun Li wrote: > Remove the experimental tag for rte_eth_dev_rx_intr_ctl_q_get_fd API > that was introduced in 18.11 and have been around for 11 releases. > > Signed-off-by: Xiaoyun Li Acked-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH] net: make rte_ether_unformat_addr stable

2021-09-01 Thread Andrew Rybchenko
On 8/31/21 11:07 PM, Stephen Hemminger wrote: > This function has been in since 19.11. > > Signed-off-by: Stephen Hemminger Acked-by: Andrew Rybchenko

[dpdk-dev] [PATCH v3] net/ixgbe: fix mac resourece leak

2021-09-01 Thread Qiming Chen
In the eth_ixgbevf_dev_init and eth_ixgbe_dev_init functions, memory is allocated for the MAC address, and the address is stored in the eth_dev->data->mac_addrs member variable. If the subsequent function is abnormal, you need to use the rte_free function to release the MAC address memory. Fixes:

[dpdk-dev] [PATCH v3] net/ixgbe: fix mbuf leak

2021-09-01 Thread Qiming Chen
A local test found that repeated port start and stop operations during the continuous SSE vector bufflist receiving process will cause the mbuf resource to run out. The final positioning is when the port is stopped, the mbuf of the pkt_first_seg pointer is not released. Resources leak. The patch sc

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix mac resourece leak

2021-09-01 Thread Qiming Chen
Ask a question: how to submit an issue while keeping the exchange log. | | Qiming Chen | | chenqiming_hua...@163.com | 签名由网易邮箱大师定制 On 9/1/2021 14:25,Wang, Haiyue wrote: -Original Message- From: Qiming Chen Sent: Tuesday, August 31, 2021 22:22 To: dev@dpdk.org Cc: Wang, Haiyue ; Qiming Ch

[dpdk-dev] [PATCH] net/bnxt: fix double allocation of ring groups

2021-09-01 Thread Kalesh A P
From: Kalesh AP After commit "d68249f88266", driver allocates ring groups in bnxt_alloc_hwrm_rx_ring(). But during port start, driver invokes bnxt_alloc_hwrm_rx_ring() followed by bnxt_alloc_all_hwrm_ring_grps(). This will cause the FW command failure in bnxt_alloc_all_hwrm_ring_grps(). To fix t

Re: [dpdk-dev] [PATCH] eal: promote random function with upper bound to stable

2021-09-01 Thread David Marchand
On Wed, Sep 1, 2021 at 9:35 AM Mattias Rönnblom wrote: > > On 2021-09-01 09:29, Mattias Rönnblom wrote: > > Remove experimental tag from rte_rand_max(). > > > > Signed-off-by: Mattias Rönnblom > > --- > > lib/eal/include/rte_random.h | 1 - > > lib/eal/version.map | 2 +- > > 2 files

Re: [dpdk-dev] [RFC] Control packet event adapter and FIFO library

2021-09-01 Thread Jerin Jacob
On Wed, Sep 1, 2021 at 11:55 AM Jerin Jacob wrote: > > On Wed, Sep 1, 2021 at 11:12 AM Kaladi, Ashok K > wrote: > > > > Dear dpdk-dev team, > > > > We would like to propose the following RFC for your review. > > > > A user space application may need access to the packets handled by eventdev > > b

Re: [dpdk-dev] [EXT] Re: [PATCH 5/8] crypto/cnxk: add cn9k crypto adapter fast path ops

2021-09-01 Thread Anoob Joseph
> > > On 30/08/2021 12:09, Shijith Thotton wrote: > > Added crypto adapter enqueue and dequeue operations for CN9K. > > > > Signed-off-by: Shijith Thotton > > --- > > drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 235 - > -- > > drivers/crypto/cnxk/cn9k_cryptodev_ops.h | 6 +

Re: [dpdk-dev] [EXT] Re: [PATCH 7/8] crypto/cnxk: add cn10k crypto adapter fast path ops

2021-09-01 Thread Anoob Joseph
> > > On 30/08/2021 12:09, Shijith Thotton wrote: > > Added crypto adapter enqueue and dequeue operations for CN10K. > > > > Signed-off-by: Shijith Thotton > > --- > > drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 95 > > +++ > drivers/crypto/cnxk/cn10k_cryptodev_ops.h | 6 ++

Re: [dpdk-dev] [PATCH] net: make rte_ether_unformat_addr stable

2021-09-01 Thread Ferruh Yigit
On 9/1/2021 8:11 AM, Andrew Rybchenko wrote: > On 8/31/21 11:07 PM, Stephen Hemminger wrote: >> This function has been in since 19.11. >> >> Signed-off-by: Stephen Hemminger > > Acked-by: Andrew Rybchenko > Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH] ethdev: remove experimental flag from getting intr fd API

2021-09-01 Thread Ferruh Yigit
On 9/1/2021 8:08 AM, Andrew Rybchenko wrote: > On 9/1/21 4:50 AM, Xiaoyun Li wrote: >> Remove the experimental tag for rte_eth_dev_rx_intr_ctl_q_get_fd API >> that was introduced in 18.11 and have been around for 11 releases. >> >> Signed-off-by: Xiaoyun Li > > Acked-by: Andrew Rybchenko > Ack

Re: [dpdk-dev] [PATCH v1 1/3] net/ixgbe: promote some API to stable

2021-09-01 Thread Ferruh Yigit
On 9/1/2021 6:07 AM, Haiyue Wang wrote: > The DPDK Symbol Bot reports: > Please note the symbols listed below have expired. In line with the > DPDK ABI policy, they should be scheduled for removal, in the next > DPDK release. > > Symbol > rte_pmd_ixgbe_mdio_lock > rte_pmd_ixgbe_mdio_unlock > rte_p

Re: [dpdk-dev] [PATCH v1 3/3] ethdev: promote burst mode API to stable

2021-09-01 Thread Ferruh Yigit
On 9/1/2021 6:07 AM, Haiyue Wang wrote: > The DPDK Symbol Bot reports: > Please note the symbols listed below have expired. In line with the > DPDK ABI policy, they should be scheduled for removal, in the next > DPDK release. > > Symbol > rte_eth_rx_burst_mode_get > rte_eth_tx_burst_mode_get > >

Re: [dpdk-dev] [PATCH] eal: add log to print dpdk version at start

2021-09-01 Thread Bruce Richardson
On Wed, Sep 01, 2021 at 11:48:21AM +0530, Aman Singh wrote: > From the logs it is difficult to get the DPDK version > that was used. So added a debug log to print the same. > The log has been added in eal_init so it gets printed > at startup for any application. > > Signed-off-by: Aman Singh > --

[dpdk-dev] 19.11.10 patches review and test

2021-09-01 Thread christian . ehrhardt
Hi all, Here is a list of patches targeted for stable release 19.11.10. The planned date for the final release is 6th of September. Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported va

[dpdk-dev] [PATCH v2 4/8] crypto/cnxk: use rlen from CPT result with lookaside

2021-09-01 Thread Tejasree Kondoj
Use rlen from CPT result with lookaside operations Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 40 ++- drivers/crypto/cnxk/cn10k_ipsec.c | 4 +-- drivers/crypto/cnxk/cn10k_ipsec.h | 4 +-- drivers/crypto/cnxk/cn10k_ipsec_la

[dpdk-dev] [PATCH v2 0/8] add lookaside IPsec additional features

2021-09-01 Thread Tejasree Kondoj
This series adds cn10k lookaside IPsec AES-CBC-HMAC-SHA1, UDP encapsulation and transport mode support along with common cnxk pmd changes. The functionality has been tested with ipsec-secgw application running in lookaside protocol offload mode. v2: * Fixed release notes Archana Muniganti (2):

[dpdk-dev] [PATCH v2 5/8] crypto/cnxk: make IPsec verify functions common

2021-09-01 Thread Tejasree Kondoj
From: Archana Muniganti IPsec verify functions can be made common Signed-off-by: Archana Muniganti --- drivers/crypto/cnxk/cn10k_ipsec.c | 116 +- drivers/crypto/cnxk/cnxk_ipsec.h | 113 + 2 files changed, 114 insertions(+), 115 deletion

[dpdk-dev] [PATCH v2 1/8] common/cnxk: add hash generation APIs

2021-09-01 Thread Tejasree Kondoj
Adding functions for hash generation that can be used in hmac opad/ipad calculation. Signed-off-by: Tejasree Kondoj --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_api.h | 3 + drivers/common/cnxk/roc_hash.c | 275 drivers/common/cnxk/ro

[dpdk-dev] [PATCH v2 2/8] crypto/cnxk: add lookaside IPsec AES-CBC-HMAC-SHA1 support

2021-09-01 Thread Tejasree Kondoj
Adding lookaside IPsec AES-CBC-HMAC-SHA1 support to cnxk driver. Signed-off-by: Tejasree Kondoj --- doc/guides/cryptodevs/cnxk.rst| 1 + doc/guides/rel_notes/release_21_11.rst| 4 ++ drivers/common/cnxk/cnxk_security.c | 68 ++- drivers/crypto/

[dpdk-dev] [PATCH v2 3/8] crypto/cnxk: remove redundant code

2021-09-01 Thread Tejasree Kondoj
Removing redundant code in cn10k lookaside IPsec. Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cn10k_ipsec.c | 5 - drivers/crypto/cnxk/cn10k_ipsec.h | 2 -- drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c | 2 -- 3 files changed, 9 deletions(-) d

[dpdk-dev] [PATCH v2 6/8] crypto/cnxk: support cn10k transport mode

2021-09-01 Thread Tejasree Kondoj
Adding support for cn10k lookaside IPsec transport mode. Signed-off-by: Tejasree Kondoj --- doc/guides/cryptodevs/cnxk.rst| 1 + doc/guides/rel_notes/release_21_11.rst| 1 + drivers/crypto/cnxk/cnxk_cryptodev.h | 2 +- .../crypto/cnxk/cnxk_cryptodev_capabiliti

[dpdk-dev] [PATCH v2 7/8] crypto/cnxk: support UDP encap with lookaside IPsec

2021-09-01 Thread Tejasree Kondoj
Adding support for UDP encapsulation in lookaside IPsec. Signed-off-by: Tejasree Kondoj --- doc/guides/cryptodevs/cnxk.rst| 1 + doc/guides/rel_notes/release_21_11.rst| 1 + drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c | 11 ++- 3 files changed, 12

[dpdk-dev] [PATCH v2 8/8] common/cnxk: make IPsec defines common

2021-09-01 Thread Tejasree Kondoj
From: Archana Muniganti Make IPsec defines common and remove redundant macros. Signed-off-by: Archana Muniganti --- drivers/common/cnxk/cnxk_security.c | 24 + drivers/common/cnxk/roc_api.h | 1 + drivers/common/cnxk/roc_ie.h | 33 +++

[dpdk-dev] [PATCH] eal: fix memory leak when saving arguments

2021-09-01 Thread Conor Walsh
This patch fixes a memleak which was reported in Bugzilla within the eal_save_args function. This was caused by the function mistakenly adding -- to the eal args instead of breaking beforehand. Bugzilla ID: 722 Fixes: 293c53d8b23c ("eal: add telemetry callbacks") Reported-by: Zhihong Peng Signed

Re: [dpdk-dev] [PATCH] doc: announce change in vfio dma mapping

2021-09-01 Thread Ferruh Yigit
On 9/1/2021 2:41 AM, Ding, Xuan wrote: > Hi Ferruh, > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Wednesday, September 1, 2021 12:01 AM >> To: Ding, Xuan ; dev@dpdk.org; Burakov, Anatoly >> >> Cc: maxime.coque...@redhat.com; Xia, Chenbo ; Hu, >> Jiayu ; Richardson, Bruce >> Su

Re: [dpdk-dev] [PATCH] eal: fix memory leak when saving arguments

2021-09-01 Thread Bruce Richardson
On Wed, Sep 01, 2021 at 09:38:47AM +, Conor Walsh wrote: > This patch fixes a memleak which was reported in Bugzilla within the > eal_save_args function. This was caused by the function mistakenly > adding -- to the eal args instead of breaking beforehand. > > Bugzilla ID: 722 > Fixes: 293c53d

[dpdk-dev] [PATCH v1] net/iavf: fix QFI fields of GTPU UL and DL for FDIR

2021-09-01 Thread Lingyu Liu
Fix QFI fields matching of GTPU UL/DL for FDIR. Fixes: 78e8a87f6324 ("net/iavf: fix GTPU UL and DL support for flow director") Cc: sta...@dpdk.org Signed-off-by: Junfeng Guo Signed-off-by: Lingyu Liu --- drivers/net/iavf/iavf_fdir.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) d

Re: [dpdk-dev] [PATCH] doc: announce change in vfio dma mapping

2021-09-01 Thread Burakov, Anatoly
On 01-Sep-21 10:56 AM, Ferruh Yigit wrote: On 9/1/2021 2:41 AM, Ding, Xuan wrote: Hi Ferruh, -Original Message- From: Yigit, Ferruh Sent: Wednesday, September 1, 2021 12:01 AM To: Ding, Xuan ; dev@dpdk.org; Burakov, Anatoly Cc: maxime.coque...@redhat.com; Xia, Chenbo ; Hu, Jiayu ; Ri

Re: [dpdk-dev] [PATCH v2 3/3] doc: remove i40evf related documentation

2021-09-01 Thread Kinsella, Ray
On 01/09/2021 04:30, Robin Zhang wrote: > As announced in the deprecation note, i40evf has been removed. So removing > deprecation notice and other i40evf related documentation. > > Signed-off-by: Robin Zhang > --- > doc/guides/howto/lm_bond_virtio_sriov.rst | 4 ++-- > doc/guides/nics/intel_

Re: [dpdk-dev] [PATCH v1 1/3] net/ixgbe: promote some API to stable

2021-09-01 Thread Wang, Haiyue
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, September 1, 2021 17:02 > To: Wang, Haiyue ; dev@dpdk.org > Cc: m...@ashroe.eu; tho...@monjalon.net > Subject: Re: [dpdk-dev] [PATCH v1 1/3] net/ixgbe: promote some API to stable > > On 9/1/2021 6:07 AM, Haiyue Wang wrote: > >

Re: [dpdk-dev] [PATCH v2 2/3] net/iavf: remove i40evf devargs option

2021-09-01 Thread Kinsella, Ray
On 01/09/2021 04:30, Robin Zhang wrote: > Due to i40evf will be removed, so there's no need to keep the devargs > option "driver=i40evf" in iavf. > > Signed-off-by: Robin Zhang > --- [SNIP] > @@ -2556,7 +2508,7 @@ static struct rte_pci_driver rte_iavf_pmd = { > RTE_PMD_REGISTER_PCI(net_iav

Re: [dpdk-dev] [PATCH v2 1/3] net/i40e: remove i40evf

2021-09-01 Thread Kinsella, Ray
On 01/09/2021 04:30, Robin Zhang wrote: > The default VF driver for Intel 700 Series Ethernet Controller already > switch to iavf in DPDK 21.05. And i40evf is no need to maintain now, > so remove i40evf related code. > > Signed-off-by: Robin Zhang > --- > drivers/net/i40e/i40e_ethdev.h|

Re: [dpdk-dev] [PATCH v1] bbdev: remove experimental tag from API

2021-09-01 Thread Kinsella, Ray
On 01/09/2021 04:52, Hemant Agrawal wrote: >> >> On Tue, Aug 31, 2021 at 6:27 PM Nicolas Chautru >> wrote: >>> >>> This was previously suggested last year >>> >> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc >>> hes.dpdk.org%2Fproject%2Fdpdk%2Fpatch%2F1593213242-157394-

Re: [dpdk-dev] [PATCH] common/cnxk: add ROC API to merge base steering rule

2021-09-01 Thread Kinsella, Ray
On 31/08/2021 05:16, psathe...@marvell.com wrote: > From: Satheesh Paul > > This patch adds an ROC API to merge base steering rule with rules > added by VF. > > Signed-off-by: Satheesh Paul > Reviewed-by: Kiran Kumar Kokkilagadda > --- > drivers/common/cnxk/roc_npc.c | 27 +++

Re: [dpdk-dev] [PATCH] eal: promote random function with upper bound to stable

2021-09-01 Thread Kinsella, Ray
On 01/09/2021 08:29, Mattias Rönnblom wrote: > Remove experimental tag from rte_rand_max(). > > Signed-off-by: Mattias Rönnblom Acked-by: Ray Kinsella

Re: [dpdk-dev] [PATCH] ethdev: remove experimental flag from getting intr fd API

2021-09-01 Thread Kinsella, Ray
On 01/09/2021 09:53, Ferruh Yigit wrote: > On 9/1/2021 8:08 AM, Andrew Rybchenko wrote: >> On 9/1/21 4:50 AM, Xiaoyun Li wrote: >>> Remove the experimental tag for rte_eth_dev_rx_intr_ctl_q_get_fd API >>> that was introduced in 18.11 and have been around for 11 releases. >>> >>> Signed-off-by: X

[dpdk-dev] [PATCH] eal: promote random function with upper bound to stable

2021-09-01 Thread Mattias Rönnblom
Remove experimental tag from rte_rand_max(). Signed-off-by: Mattias Rönnblom --- lib/eal/include/rte_random.h | 1 - lib/eal/version.map | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/eal/include/rte_random.h b/lib/eal/include/rte_random.h index 2b30ec85c1..29

Re: [dpdk-dev] [PATCH] eal: promote random function with upper bound to stable

2021-09-01 Thread Mattias Rönnblom
On 2021-09-01 09:29, Mattias Rönnblom wrote: > Remove experimental tag from rte_rand_max(). > > Signed-off-by: Mattias Rönnblom > --- > lib/eal/include/rte_random.h | 1 - > lib/eal/version.map | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/lib/eal/include/

Re: [dpdk-dev] [PATCH] doc: announce change in vfio dma mapping

2021-09-01 Thread Ferruh Yigit
On 9/1/2021 12:01 PM, Burakov, Anatoly wrote: > On 01-Sep-21 10:56 AM, Ferruh Yigit wrote: >> On 9/1/2021 2:41 AM, Ding, Xuan wrote: >>> Hi Ferruh, >>> -Original Message- From: Yigit, Ferruh Sent: Wednesday, September 1, 2021 12:01 AM To: Ding, Xuan ; dev@dpdk.org; Bura

Re: [dpdk-dev] [PATCH 0/6] mlx5: some independent fixes

2021-09-01 Thread Matan Azrad
From: Michael Baum > Some independent fixes in mlx5 net and common driver. > > Michael Baum (6): > net/mlx5: fix shared device context creation error flow > net/mlx5: fix PCI probing error flow > net/mlx5: fix allow duplicate pattern devarg default > common/mlx5: fix class combination

Re: [dpdk-dev] [PATCH] regex/mlx5: fix RegEx probing error flow

2021-09-01 Thread Matan Azrad
From: Michael Baum > In RegEx device probing, there is register read trying after context device > creation. > > When the reading fails, the context device was not freed what caused a > memory leak. > > Free it. > > Fixes: f324162e8e77 ("regex/mlx5: support combined rule file") > Cc: sta...@d

Re: [dpdk-dev] [PATCH] crypto/mlx5: support timestamp format

2021-09-01 Thread Matan Azrad
From: Michael Baum > This patch adds support for the timestamp format settings for the receive > and send queues. If the firmware version x.30.1000 or above is installed and > the NIC timestamps are configured with the real-time format, the default > zero values for newly added fields cause the

Re: [dpdk-dev] [PATCH] compress/mlx5: fix QP setup error flow

2021-09-01 Thread Matan Azrad
From: Michael Baum > Sent: Tuesday, August 31, 2021 11:40 PM > To: dev@dpdk.org > Cc: Matan Azrad ; sta...@dpdk.org > Subject: [PATCH] compress/mlx5: fix QP setup error flow > > The QP setup function allocates buffer for its opaque MR and register it into > MR structure. > > After buffer allo

[dpdk-dev] [PATCH] net/mlx5: fix shared RSS destruction

2021-09-01 Thread Dmitry Kozlyuk
Shared RSS resources were released before checking that the shared RSS has no more references. If it had, the destruction was aborted, leaving the shared RSS in an invalid state where it could no longer be used. Move reference counter check before resource release. Fixes: d2046c09aa64 ("net/mlx5:

Re: [dpdk-dev] [PATCH] regex/mlx5: fix RegEx probing error flow

2021-09-01 Thread Ori Kam
> -Original Message- > From: Michael Baum > > In RegEx device probing, there is register read trying after context device > creation. > > When the reading fails, the context device was not freed what caused a > memory leak. > > Free it. > > Fixes: f324162e8e77 ("regex/mlx5: support

[dpdk-dev] [PATCH] sched: remove experimental tag from the API

2021-09-01 Thread Jasvinder Singh
This API was introduced in 18.05, therefore removing experimental tag to promote it to stable state Signed-off-by: Jasvinder Singh --- lib/sched/rte_sched.h | 4 lib/sched/version.map | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/sched/rte_sched.h b/lib/sched/rte

[dpdk-dev] [PATCH] pipeline: remove experimental tag from API

2021-09-01 Thread Jasvinder Singh
These APIs were introduced in 18.05, therefore removing experimental tag to promote them to stable state. Signed-off-by: Jasvinder Singh --- lib/pipeline/rte_port_in_action.h | 10 -- lib/pipeline/rte_table_action.h | 18 -- lib/pipeline/version.map | 16 ++

[dpdk-dev] [PATCH 0/2] net/mlx5: fix flow indirect action reference counting

2021-09-01 Thread Dmitry Kozlyuk
Dmitry Kozlyuk (2): net/mlx5: report error on indirect CT action destroy net/mlx5: fix flow indirect action reference counting drivers/net/mlx5/mlx5_flow_dv.c | 59 ++--- 1 file changed, 39 insertions(+), 20 deletions(-) -- 2.25.1

[dpdk-dev] [PATCH 1/2] net/mlx5: report error on indirect CT action destroy

2021-09-01 Thread Dmitry Kozlyuk
When an indirect CT action of mlx5 PMD could not be destroyed, rte_action_handle_destroy() was returning (-1), but the error structure was not filled. This lead to a segfault in testpmd on an attempt to print it. Fill the details for each possible cause of this error. Fixes: c5a49265fc23 ("net/mlx

[dpdk-dev] [PATCH] net/softnic: remove experimental table from API

2021-09-01 Thread Jasvinder Singh
This API was introduced in 18.08, therefore removing experimental tag to promote it to stable state. Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic.h | 1 - drivers/net/softnic/version.map | 7 +-- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/dr

[dpdk-dev] [PATCH 2/2] net/mlx5: fix flow indirect action reference counting

2021-09-01 Thread Dmitry Kozlyuk
When an indirect action is used in a flow rule with a pattern that causes RSS expansion, each device flow generated by the expansion incremented the reference counter of the action. When such a flow was destroyed, its action reference counter had been decremented only once. The action remained mark

Re: [dpdk-dev] [PATCH v10 0/3] devtools: scripts to count and track symbols

2021-09-01 Thread Aaron Conole
Ray Kinsella writes: > Scripts to count and track the lifecycle of DPDK symbols. > > The symbol-tool script reports on the growth of symbols over releases > and list expired symbols. The notify-symbol-maintainers script > consumes the input from symbol-tool and generates email notifications > of

Re: [dpdk-dev] [PATCH v10 2/3] devtools: script to send notifications of expired symbols

2021-09-01 Thread Aaron Conole
Ray Kinsella writes: > Use this script with the output of the DPDK symbol tool, to notify > maintainers of expired symbols by email. You need to define the environment > variable DPDK_GETMAINTAINER_PATH for this tool to work. > > Use terminal output to review the emails before sending. > e.g. > $

Re: [dpdk-dev] [PATCH v5] build: optional NUMA and cpu counts detection

2021-09-01 Thread Piotr Kubaj
On 21-08-31 07:54:16, Juraj Linkeš wrote: > > > > -Original Message- > > From: Piotr Kubaj > > Sent: Tuesday, August 31, 2021 2:55 AM > > To: Juraj Linkeš > > Cc: David Christensen ; tho...@monjalon.net; > > david.march...@redhat.com; bruce.richard...@intel.com; > > honnappa.nagaraha...

[dpdk-dev] [RFC PATCH 0/2] Flow entities behavior across port restart

2021-09-01 Thread Dmitry Kozlyuk
It is currently unspecified if flow rules and indirect actions persist across port restart and reconfiguration. Actual behavior differs between PMDs, for example, i40e and mlx5. There are patches that try to fix particular behavior [1] or at least document it for specific PMDs [2]. We propose to co

[dpdk-dev] [RFC PATCH 1/2] ethdev: add capability to keep flow rules on restart

2021-09-01 Thread Dmitry Kozlyuk
Currently, it is not specified what happens to the flow rules when the device is stopped, possibly reconfigured, then started. If flow rules were kept, it can be convenient for application developers, because they wouldn't need to save and restore them. However, due to the number of flows and possi

[dpdk-dev] [RFC PATCH 2/2] ethdev: add capability to keep indirect actions on restart

2021-09-01 Thread Dmitry Kozlyuk
rte_flow_action_handle_create() did not mention what happens with an indirect action when a device is stopped, possibly reconfigured, and started again. It is natural for some indirect actions to be persistent, like counters and meters; keeping others just saves application time and complexity. How

Re: [dpdk-dev] [PATCH v10 2/3] devtools: script to send notifications of expired symbols

2021-09-01 Thread David Marchand
Hello Ray, On Tue, Aug 31, 2021 at 4:51 PM Ray Kinsella wrote: > > Use this script with the output of the DPDK symbol tool, to notify > maintainers of expired symbols by email. You need to define the environment > variable DPDK_GETMAINTAINER_PATH for this tool to work. > > Use terminal output to

Re: [dpdk-dev] [PATCH] doc: announce change in vfio dma mapping

2021-09-01 Thread Burakov, Anatoly
On 01-Sep-21 12:42 PM, Ferruh Yigit wrote: On 9/1/2021 12:01 PM, Burakov, Anatoly wrote: On 01-Sep-21 10:56 AM, Ferruh Yigit wrote: On 9/1/2021 2:41 AM, Ding, Xuan wrote: Hi Ferruh, -Original Message- From: Yigit, Ferruh Sent: Wednesday, September 1, 2021 12:01 AM To: Ding, Xuan ; d

Re: [dpdk-dev] [PATCH v2 1/6] bbdev: add capability for CRC16 check

2021-09-01 Thread Tom Rix
On 8/19/21 2:10 PM, Nicolas Chautru wrote: Adding a missing operation when CRC16 is being used for TB CRC check. Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_vector.c | 2 ++ doc/guides/prog_guide/bbdev.rst| 3 +++ doc/guides/rel_notes/release_21_11.rst | 1

Re: [dpdk-dev] [PATCH] sched: remove experimental tag from the API

2021-09-01 Thread Kinsella, Ray
On 01/09/2021 13:19, Jasvinder Singh wrote: > This API was introduced in 18.05, therefore removing > experimental tag to promote it to stable state > > Signed-off-by: Jasvinder Singh > --- > lib/sched/rte_sched.h | 4 > lib/sched/version.map | 2 +- > 2 files changed, 1 insertion(+), 5 d

Re: [dpdk-dev] [PATCH] pipeline: remove experimental tag from API

2021-09-01 Thread Kinsella, Ray
On 01/09/2021 13:20, Jasvinder Singh wrote: > These APIs were introduced in 18.05, therefore removing > experimental tag to promote them to stable state. > > Signed-off-by: Jasvinder Singh > --- > lib/pipeline/rte_port_in_action.h | 10 -- > lib/pipeline/rte_table_action.h | 18

Re: [dpdk-dev] [PATCH] net/softnic: remove experimental table from API

2021-09-01 Thread Kinsella, Ray
On 01/09/2021 13:20, Jasvinder Singh wrote: > This API was introduced in 18.08, therefore removing > experimental tag to promote it to stable state. > > Signed-off-by: Jasvinder Singh > --- > drivers/net/softnic/rte_eth_softnic.h | 1 - > drivers/net/softnic/version.map | 7 +-- > 2

Re: [dpdk-dev] [PATCH v1 3/3] ethdev: promote burst mode API to stable

2021-09-01 Thread Kinsella, Ray
On 01/09/2021 10:07, Ferruh Yigit wrote: > On 9/1/2021 6:07 AM, Haiyue Wang wrote: >> The DPDK Symbol Bot reports: >> Please note the symbols listed below have expired. In line with the >> DPDK ABI policy, they should be scheduled for removal, in the next >> DPDK release. >> >> Symbol >> rte_eth

Re: [dpdk-dev] [PATCH v1 1/3] net/ixgbe: promote some API to stable

2021-09-01 Thread Kinsella, Ray
On 01/09/2021 12:13, Wang, Haiyue wrote: >> -Original Message- >> From: Yigit, Ferruh >> Sent: Wednesday, September 1, 2021 17:02 >> To: Wang, Haiyue ; dev@dpdk.org >> Cc: m...@ashroe.eu; tho...@monjalon.net >> Subject: Re: [dpdk-dev] [PATCH v1 1/3] net/ixgbe: promote some API to stable

Re: [dpdk-dev] [PATCH v2 2/6] baseband/turbo_sw: add support for CRC16

2021-09-01 Thread Tom Rix
On 8/19/21 2:10 PM, Nicolas Chautru wrote: This is to support the case for operation where CRC16 is to be appended or checked. Signed-off-by: Nicolas Chautru --- doc/guides/rel_notes/release_21_11.rst | 3 +++ drivers/baseband/turbo_sw/bbdev_turbo_software.c | 17 +++

Re: [dpdk-dev] [PATCH v2 4/6] baseband/acc100: add support for 4G CRC drop

2021-09-01 Thread Tom Rix
On 8/19/21 2:10 PM, Nicolas Chautru wrote: This implements in PMD the option to drop the CB CRC after 4G decoding to help transport block concatenation. Signed-off-by: Nicolas Chautru --- doc/guides/bbdevs/acc100.rst | 1 + doc/guides/rel_notes/release_21_11.rst | 4

Re: [dpdk-dev] [PATCH v2 6/6] bbdev: reduce warning level for one scenario

2021-09-01 Thread Tom Rix
On 8/19/21 2:10 PM, Nicolas Chautru wrote: Queue setup may genuinely fail when adding incremental queues for a given priority level. In that case application would attempt to configure a queue at a different priority level. Not an actual error. Signed-off-by: Nicolas Chautru --- lib/bbdev/r

[dpdk-dev] [PATCH 0/4] drivers/qat: isolate implementations of qat generations

2021-09-01 Thread Arek Kusztal
This patchset introduces new qat driver structure and updates existing symmetric crypto qat PMD. The purpose of the change is to isolate QAT generation specific implementations from one to another. It is expected the changes to the specific generation driver code does minimum impact to other ge

[dpdk-dev] [PATCH 1/4] common/qat: isolate implementations of qat generations

2021-09-01 Thread Arek Kusztal
This commit isolates implementations of common part in QAT PMD. When changing/expanding particular generation code, other generations code should left intact. Generation code in drivers common is invisible to other generations code. Signed-off-by: Arek Kusztal --- drivers/common/qat/dev/qat_dev_

[dpdk-dev] [PATCH 2/4] crypto/qat: isolate implementations of symmetric operations

2021-09-01 Thread Arek Kusztal
This commit isolates implementations of symmetric part in QAT PMD. When changing/expanding particular generation code, other generations code should left intact. Generation code in drivers crypto is invisible to other generations code. Signed-off-by: Arek Kusztal --- drivers/common/qat/meson.bui

[dpdk-dev] [PATCH 3/4] crypto/qat: move capabilities initialization to spec files

2021-09-01 Thread Arek Kusztal
Move capabilites static struct to particular generations into separate translation units that it can be isolated from each other. Signed-off-by: Arek Kusztal --- drivers/crypto/qat/dev/qat_sym_pmd_gen1.c | 27 - drivers/crypto/qat/dev/qat_sym_pmd_gen2.c | 25 - drivers/crypto/qat

[dpdk-dev] [PATCH 4/4] common/qat: add extra data to qat pci dev

2021-09-01 Thread Arek Kusztal
Add private data to qat_pci_device struct that will be visible only by specific generation it belongs to. Signed-off-by: Arek Kusztal --- drivers/common/qat/dev/qat_dev_gen1.c | 7 +++ drivers/common/qat/dev/qat_dev_gen1.h | 3 ++ drivers/common/qat/dev/qat_dev_gen2.c | 1 + drive

Re: [dpdk-dev] [PATCH v1] bbdev: remove experimental tag from API

2021-09-01 Thread Chautru, Nicolas
> -Original Message- > From: Hemant Agrawal > Sent: Tuesday, August 31, 2021 8:53 PM > To: David Marchand ; Chautru, Nicolas > > Cc: dev ; Akhil Goyal ; Thomas > Monjalon ; Tom Rix ; Zhang, > Mingshan ; Joshi, Arun > ; Ray Kinsella ; Maxime Coquelin > > Subject: RE: [PATCH v1] bbdev:

Re: [dpdk-dev] [PATCH v1] bbdev: remove experimental tag from API

2021-09-01 Thread Chautru, Nicolas
> -Original Message- > From: Kinsella, Ray > Sent: Wednesday, September 1, 2021 4:15 AM > To: Hemant Agrawal ; David Marchand > ; Chautru, Nicolas > > Cc: dev ; Akhil Goyal ; Thomas > Monjalon ; Tom Rix ; Zhang, > Mingshan ; Joshi, Arun > ; Maxime Coquelin > Subject: Re: [PATCH v1] bbd

Re: [dpdk-dev] [PATCH v4] ethdev: fix representor port ID search by name

2021-09-01 Thread Ferruh Yigit
On 8/31/2021 5:06 PM, Andrew Rybchenko wrote: > From: Viacheslav Galaktionov > > Getting a list of representors from a representor does not make sense. > Instead, a parent device should be used. > Which code is getting list of the representors? As far as I can see impacted APIs are: 'rte_eth_r

Re: [dpdk-dev] [PATCH v2 1/6] bbdev: add capability for CRC16 check

2021-09-01 Thread Chautru, Nicolas
> -Original Message- > From: Tom Rix > Sent: Wednesday, September 1, 2021 6:37 AM > To: Chautru, Nicolas ; dev@dpdk.org; > gak...@marvell.com > Cc: tho...@monjalon.net; hemant.agra...@nxp.com; Zhang, Mingshan > ; Joshi, Arun > Subject: Re: [PATCH v2 1/6] bbdev: add capability for CRC16

[dpdk-dev] [PATCH] doc: clarify implicit filtering in transfer rules

2021-09-01 Thread Andrew Rybchenko
As per existing documentation, attribute "transfer", quote, "complements the behavior of some pattern items such as RTE_FLOW_ITEM_TYPE_PHY_PORT and is meaningless without them". That effectively confronts the idea of implicit filtering imposed by port_id argument passed by flow create API. This bi

Re: [dpdk-dev] [PATCH] doc: announce changes in EFD function

2021-09-01 Thread Mcnamara, John
> -Original Message- > From: dev On Behalf Of Pablo de Lara > Sent: Tuesday, August 31, 2021 3:31 PM > To: Marohn, Byron ; Wang, Yipeng1 > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH] doc: announce changes in EFD function This change is required to fix Cover

Re: [dpdk-dev] Running DPDK application with non-previlege mode

2021-09-01 Thread Kamaraj P
Thanks Bruce. BTW we are trying to run our application as docker container. We may need to pass the parameters(system capability) along with docker command line to mount the hugepages ? Like this : https://github.com/usnistgov/ndn-dpdk/blob/main/docs/Docker.md Please share your thoughts. Thanks,

[dpdk-dev] [PATCH v2 0/6] add test suite for DMA drivers

2021-09-01 Thread Bruce Richardson
This patchset adds a fairly comprehensive set of tests for basic dmadev functionality. Tests are added to verify basic copy operation in each device, using both submit function and submit flag, and verifying completion gathering using both "completed()" and "completed_status()" functions. Beyond th

[dpdk-dev] [PATCH v2 1/6] dmadev: add device idle check for testing use

2021-09-01 Thread Bruce Richardson
Add in a function to check if a device or vchan has completed all jobs assigned to it, without gathering in the results. This is primarily for use in testing, to allow the hardware to be in a known-state prior to gathering completions. Signed-off-by: Bruce Richardson --- lib/dmadev/rte_dmadev.c

[dpdk-dev] [PATCH v2 2/6] app/test: add basic dmadev instance tests

2021-09-01 Thread Bruce Richardson
Run basic sanity tests for configuring, starting and stopping a dmadev instance to help validate drivers. This also provides the framework for future tests for data-path operation. Signed-off-by: Bruce Richardson --- app/test/test_dmadev.c | 81 ++ 1 file

[dpdk-dev] [PATCH v2 3/6] app/test: add basic dmadev copy tests

2021-09-01 Thread Bruce Richardson
For each dmadev instance, perform some basic copy tests to validate that functionality. Signed-off-by: Bruce Richardson --- app/test/test_dmadev.c | 174 + 1 file changed, 174 insertions(+) diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c inde

[dpdk-dev] [PATCH v2 4/6] app/test: add more comprehensive dmadev copy tests

2021-09-01 Thread Bruce Richardson
Add unit tests for various combinations of use for dmadev, copying bursts of packets in various formats, e.g. 1. enqueuing two smaller bursts and completing them as one burst 2. enqueuing one burst and gathering completions in smaller bursts 3. using completed_status() function to gather completio

[dpdk-dev] [PATCH v2 5/6] app/test: test dmadev instance failure handling

2021-09-01 Thread Bruce Richardson
Add a series of tests to inject bad copy operations into a dmadev to test the error handling and reporting capabilities. Various combinations of errors in various positions in a burst are tested, as are errors in bursts with fence flag set, and multiple errors in a single burst. Signed-off-by: Bru

[dpdk-dev] [PATCH v2 6/6] app/test: add dmadev fill tests

2021-09-01 Thread Bruce Richardson
From: Kevin Laatz For dma devices which support the fill operation, run unit tests to verify fill behaviour is correct. Signed-off-by: Kevin Laatz Signed-off-by: Bruce Richardson --- app/test/test_dmadev.c | 73 ++ 1 file changed, 73 insertions(+) diff

Re: [dpdk-dev] [PATCH] net/af_packet: fix ignoring full ring on tx

2021-09-01 Thread Ferruh Yigit
On 8/20/2021 2:39 PM, Tudor Cornea wrote: > The poll call can return POLLERR which is ignored, or it can return > POLLOUT, even if there are no free frames in the mmap-ed area. > > We can account for both of these cases by re-checking if the next > frame is empty before writing into it. > > We al

[dpdk-dev] [PATCH 1/8] common/cnxk: use different macros for sdp and lbk max frames

2021-09-01 Thread skoteshwar
From: Satha Rao For SDP interface all platforms supports up to 65535 frame size. Updated api with new check for SDP interface. Signed-off-by: Satha Rao --- drivers/common/cnxk/hw/nix.h | 1 + drivers/common/cnxk/roc_nix.c | 5 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH 2/8] common/cnxk: flush smq

2021-09-01 Thread skoteshwar
From: Satha Rao Added new API to flush all SMQs related nix interface Signed-off-by: Satha Rao --- drivers/common/cnxk/hw/nix.h | 6 drivers/common/cnxk/roc_nix.h| 1 + drivers/common/cnxk/roc_nix_tm_ops.c | 50 drivers/common/cnxk/version.ma

[dpdk-dev] [PATCH 3/8] common/cnxk: increase sched weight and shaper burst limit

2021-09-01 Thread skoteshwar
From: Nithin Dabilpuram Increase sched weight and shaper burst limit for cn10k. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/hw/nix.h | 13 ++--- drivers/common/cnxk/roc_nix.h | 23 ++- drivers/common/cnxk/roc_nix_priv.h | 11 --- drivers/

[dpdk-dev] [PATCH 4/8] common/cnxk: handle packet mode shaper limits

2021-09-01 Thread skoteshwar
From: Satha Rao Add new macros to reflect HW shaper PPS limits. New API to validate input rates for packet mode. Increase adjust value to support lesser PPS (<61). Signed-off-by: Satha Rao --- drivers/common/cnxk/hw/nix.h | 3 + drivers/common/cnxk/roc_nix_priv.h | 1 + drivers

[dpdk-dev] [PATCH 5/8] common/cnxk: handler to get rte tm error type

2021-09-01 Thread skoteshwar
From: Satha Rao Different TM handlers returns various platform specific errors, this patch introduces new API to convert these internal error types to RTE_TM* error types. Also updated error message API with missed TM error types. Signed-off-by: Satha Rao --- drivers/common/cnxk/cnxk_utils.c |

[dpdk-dev] [PATCH 6/8] common/cnxk: set of handlers to get tm hierarchy internals

2021-09-01 Thread skoteshwar
From: Satha Rao Platform specific TM tree hierarchy details are part of common cnxk driver. This patch introduces missing HAL apis to return state of TM hierarchy required to support ethdev TM operations inside cnxk PMD. Signed-off-by: Satha Rao --- drivers/common/cnxk/roc_model.h| 6

[dpdk-dev] [PATCH 7/8] net/cnxk: tm capabilities and queue rate limit handlers

2021-09-01 Thread skoteshwar
From: Satha Rao Initial version of TM implementation added basic infrastructure, tm node_get, capabilities operations and rate limit queue operation. Signed-off-by: Satha Rao --- drivers/net/cnxk/cnxk_ethdev.c | 2 + drivers/net/cnxk/cnxk_ethdev.h | 3 + drivers/net/cnxk/cnxk_tm.c | 32

[dpdk-dev] [PATCH 8/8] net/cnxk: tm shaper and node operations

2021-09-01 Thread skoteshwar
From: Satha Rao Implemented TM node, shaper profile, hierarchy_commit and statistic operations. Signed-off-by: Satha Rao --- drivers/net/cnxk/cnxk_tm.c | 353 + drivers/net/cnxk/cnxk_tm.h | 5 + 2 files changed, 358 insertions(+) diff --git a/drivers/net/

Re: [dpdk-dev] [PATCH] eal: add log to print dpdk version at start

2021-09-01 Thread Stephen Hemminger
On Wed, 1 Sep 2021 11:48:21 +0530 Aman Singh wrote: > From the logs it is difficult to get the DPDK version > that was used. So added a debug log to print the same. > The log has been added in eal_init so it gets printed > at startup for any application. > > Signed-off-by: Aman Singh > --- >

  1   2   >