[dpdk-dev] [Bug 808] Unexpected error log 'EAL: Cannot find action: mp_malloc_response'

2021-09-09 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=808 Bug ID: 808 Summary: Unexpected error log 'EAL: Cannot find action: mp_malloc_response' Product: DPDK Version: 20.11 Hardware: x86 OS: Linux Status: UNCO

[dpdk-dev] [PATCH] net/iavf: fix rx queue irqs resource leak

2021-09-09 Thread Qiming Chen
In the iavf_config_rx_queues_irqs function, the memory pointed to by the intr_handle->intr_vec and qv_map addresses is not released in the subsequent hook branch, resulting in resource leakage. Fixes: f593944fc988 ("net/iavf: enable IRQ mapping configuration for large VF") Cc: sta...@dpdk.org Sig

Re: [dpdk-dev] [PATCH v1 1/6] build: increase default of max lcores to 512

2021-09-09 Thread David Marchand
On Thu, Sep 9, 2021 at 4:38 PM Bruce Richardson wrote: > > On Thu, Sep 09, 2021 at 02:45:06PM +0100, David Hunt wrote: > > Modern processors are coming with an ever increasing number of cores, > > and 128 does not seem like a sensible max limit any more, especially > > when you consider multi-sock

Re: [dpdk-dev] [dpdk-stable] [PATCH] common/iavf: fix arq resource leak

2021-09-09 Thread Wang, Haiyue
Thanks for the tool. Anyway, please setup your mail firstly. Your mail reply is bad for community, you can see what it looks like: http://patchwork.dpdk.org/project/dpdk/patch/20210910031249.11534-1-chenqiming_hua...@163.com/ The right reply is as: https://patchwork.dpdk.org/project/dpdk/patch/2

Re: [dpdk-dev] [dpdk-stable] [PATCH] common/iavf: fix arq resource leak

2021-09-09 Thread Qiming Chen
Thanks your reply. You are right. The resource leak is indeed scanned by tools, and then manually confirmed whether it is a problem. Our team has been developing and maintaining for many years. Because the company process is not perfect, the bug has not been promoted to the community, resulti

[dpdk-dev] [PATCH 5/5] examples/l3fwd-power: support virtio/vhost

2021-09-09 Thread Miao Li
This patch adds two command line arguments which will be needed when using virtio/vhost vdev. One argument sets rx offloads capabilities DEV_RX_OFFLOAD_VLAN_STRIP. The other argument sets DCB, PSS and VMDQ off for RX side. Signed-off-by: Miao Li --- examples/l3fwd-power/main.c | 15 +

[dpdk-dev] [PATCH 4/5] lib/power: modify return of queue_stopped

2021-09-09 Thread Miao Li
Since some vdevs like virtio and vhost do not support rxq_info_get and queue state inquiry, the error return value -ENOTSUP need to be ignored when queue_stopped cannot get rx queue information and rx queue state. This patch changes the return value of queue_stopped when rte_eth_rx_queue_info_get r

[dpdk-dev] [PATCH 3/5] net/vhost: implement rte_power_monitor API

2021-09-09 Thread Miao Li
This patch implements rte_power_monitor API in vhost PMD to reduce power consumption when no packet come in. According to current semantics of power monitor, this commit adds a callback function to decide whether aborts the sleep by checking current value against the expected value and vhost_get_mo

[dpdk-dev] [PATCH 2/5] lib/vhost: implement rte_power_monitor API

2021-09-09 Thread Miao Li
This patch defines rte_vhost_power_monitor_cond which is used to pass some information to vhost driver. The information is including the address to monitor, the expected value, the mask to extract value read from 'addr', the flag used to distinguish packed ring or split ring. Vhost driver can use t

[dpdk-dev] [PATCH 1/5] net/virtio: implement rte_power_monitor API

2021-09-09 Thread Miao Li
This patch implements rte_power_monitor API in virtio PMD to reduce power consumption when no packet come in. According to current semantics of power monitor, this commit adds a callback function to decide whether aborts the sleep by checking current value against the expected value and virtio_get_

[dpdk-dev] [PATCH 0/5] CPU Enabling: Implement rte_power_monitor API in virtio/vhost PMD

2021-09-09 Thread Miao Li
This patchset implements rte_power_monitor API in virtio and vhost PMD to reduce power consumption when no packet come in. This API can be called and tested in l3fwd-power after adding vhost and virtio support in l3fwd-power and ignoring the rx queue information check in queue_stopped(). Miao Li

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/5] net/enetfec: introduce NXP ENETFEC driver

2021-09-09 Thread Apeksha Gupta
> -Original Message- > From: David Marchand > Sent: Friday, September 3, 2021 12:45 PM > To: Apeksha Gupta > Cc: Andrew Rybchenko ; Yigit, Ferruh > ; dev ; Hemant Agrawal > ; Sachin Saxena > Subject: [EXT] Re: [dpdk-dev] [PATCH v2 1/5] net/enetfec: introduce NXP > ENETFEC driver > >

Re: [dpdk-dev] [dpdk-stable] [PATCH] common/iavf: fix arq resource leak

2021-09-09 Thread Wang, Haiyue
> -Original Message- > From: stable On Behalf Of Qiming Chen > Sent: Friday, September 10, 2021 11:13 > To: dev@dpdk.org > Cc: Xing, Beilei ; Wu, Jingjing > ; Qiming Chen > ; sta...@dpdk.org > Subject: [dpdk-stable] [PATCH] common/iavf: fix arq resource leak > > In the iavf_init_arq func

Re: [dpdk-dev] [PATCH] examples/vhost: change the default value of NIC's max queues

2021-09-09 Thread Xia, Chenbo
Hi Wenwu, > -Original Message- > From: Ma, WenwuX > Sent: Friday, September 10, 2021 9:52 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; Jiang, > Cheng1 ; Hu, Jiayu ; Wang, Yinan > ; Ma, WenwuX > Subject: [PATCH] examples/vhost: change the default value of NIC's ma

[dpdk-dev] [PATCH] common/iavf: fix arq resource leak

2021-09-09 Thread Qiming Chen
In the iavf_init_arq function, if an exception occurs in the iavf_config_arq_regs function, and the previously applied arq bufs resource is released. This patch maintains the same modification as the iavf_init_asq function to roll back resources. Fixes: 87aca6d8d8a4 ("net/iavf/base: fix command bu

Re: [dpdk-dev] [PATCH] Enable AddressSanitizer feature on DPDK

2021-09-09 Thread Stephen Hemminger
On Fri, 10 Sep 2021 02:01:47 + zhihongx.p...@intel.com wrote: > > +if get_option('b_sanitize').startswith('address') > + cflags += '-DRTE_MALLOC_ASAN' > +endif > + This looks great, but can we make it just do-the-right-thing and get rid of the nerd knobs (i.e no meson configure). The a

[dpdk-dev] [PATCH 8/8] bus/pci: remove ABIs in PCI bus

2021-09-09 Thread Chenbo Xia
As announced in the deprecation note, most of ABIs in PCI bus are removed in this patch. Only the function rte_pci_dump is still ABI and experimental APIs are kept for future promotion. This patch creates a new file named pci_driver.h and moves most of the content in original rte_bus_pci.h to it.

[dpdk-dev] [PATCH 7/8] kni: replace unused variable definition with reserved bytes

2021-09-09 Thread Chenbo Xia
PCI ID and address in structure rte_kni_conf are never used. And in order not to break ABI, replace these variables with reserved bytes. Signed-off-by: Chenbo Xia --- lib/kni/rte_kni.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/kni/rte_kni.h b/lib/kni/rte_kni.h in

[dpdk-dev] [PATCH 6/8] examples/ip_pipeline: remove setting of PCI ID and address

2021-09-09 Thread Chenbo Xia
PCI ID and address in structure rte_kni_conf are never used and will be removed in kni library. So remove the setting of them first in the example. Signed-off-by: Chenbo Xia --- examples/ip_pipeline/kni.c | 16 1 file changed, 16 deletions(-) diff --git a/examples/ip_pipeline/k

[dpdk-dev] [PATCH 5/8] test/kni: remove setting of PCI ID and address

2021-09-09 Thread Chenbo Xia
PCI device id and address in structure rte_kni_conf are never used in the test and kni library. So remove the related code. Signed-off-by: Chenbo Xia --- app/test/test_kni.c | 57 - 1 file changed, 57 deletions(-) diff --git a/app/test/test_kni.c b/ap

[dpdk-dev] [PATCH 4/8] examples/kni: remove unused PCI bus header

2021-09-09 Thread Chenbo Xia
The header rte_bus_pci.h is included in kni example but nothing in it is used. So remove it. Signed-off-by: Chenbo Xia --- examples/kni/main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/examples/kni/main.c b/examples/kni/main.c index beabb3c848..6dc335c0b5 100644 --- a/examples/kni/main.

[dpdk-dev] [PATCH 3/8] examples/ethtool: use PCI library API to get PCI address

2021-09-09 Thread Chenbo Xia
Currently ethtool example uses struct rte_pci_device to know PCI address of a device. As this API will be removed later in PCI bus, this patch uses PCI library API to get the PCI address. Signed-off-by: Chenbo Xia --- examples/ethtool/lib/rte_ethtool.c | 14 +- examples/ethtool/meson

[dpdk-dev] [PATCH 2/8] app/testpmd: use PCI memory resource access APIs

2021-09-09 Thread Chenbo Xia
Currently testpmd uses struct rte_pci_device to access PCI memory resource. Since this structure will be internal later, this patch replaces use of rte_pci_device with new PCI memory resource access APIs to read/write BAR 0. Signed-off-by: Chenbo Xia --- app/test-pmd/config.c | 38 +++--

[dpdk-dev] [PATCH 1/8] bus/pci: add new memory resource access APIs

2021-09-09 Thread Chenbo Xia
Some applications wants to access PCI memory resource. Currently applications use struct rte_pci_device to access it. Since the structure will be made internal later, this patch adds two APIs for memory resource access. Signed-off-by: Chenbo Xia --- doc/guides/rel_notes/release_21_11.rst | 5 ++

[dpdk-dev] [PATCH 0/8] Removal of PCI bus ABIs

2021-09-09 Thread Chenbo Xia
As announced in the deprecation notice, most ABIs in PCI bus will be removed. As there exist some applications that want to access PCI memory resource, two new APIs are defined in Patch 1 and corresponding changes are applied to testpmd in Patch 2. Patch 3-4 clean up the unnecessary usage of PCI

[dpdk-dev] [PATCH] vhost: merge repeated loop in vhost Tx

2021-09-09 Thread Gaoxiang Liu
To improve performance of vhost Tx, merge repeated loop in eth_vhost_tx. Move "vlan insert" from eth_vhost_tx to virtio_dev_rx_packed and virtio_dev_rx_split to reduce a loop iteration. Fixes: f63d356ee993 ("net/vhost: insert/strip VLAN header in software") Cc: sta...@dpdk.org Signed-off-by: Gaox

Re: [dpdk-dev] [PATCH] examples/vhost: change the default value of NIC's max queues

2021-09-09 Thread Jiang, Cheng1
Acked-by: Cheng Jiang > -Original Message- > From: Ma, WenwuX > Sent: Friday, September 10, 2021 9:52 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; > Jiang, Cheng1 ; Hu, Jiayu ; > Wang, Yinan ; Ma, WenwuX > > Subject: [PATCH] examples/vhost: change the default

[dpdk-dev] [PATCH] vhost: merge repeated loop in vhost Tx

2021-09-09 Thread Gaoxiang Liu
To improve performance of vhost Tx, merge repeated loop in eth_vhost_tx. Move "vlan insert" from eth_vhost_tx to virtio_dev_rx_packed and virtio_dev_rx_split to reduce a loop iteration. Fixes: f63d356ee993 ("net/vhost: insert/strip VLAN header in software") Cc: sta...@dpdk.org Signed-off-by: Gaox

[dpdk-dev] [PATCH] Enable AddressSanitizer feature on DPDK

2021-09-09 Thread zhihongx . peng
From: Zhihong Peng AddressSanitizer (ASan) is a google memory error detect standard tool. It could help to detect use-after-free and {heap,stack,global}-buffer overflow bugs in C/C++ programs, print detailed error information when error happens, large improve debug efficiency. By referring to it

[dpdk-dev] [PATCH] examples/vhost: change the default value of NIC's max queues

2021-09-09 Thread Wenwu Ma
vswitch can't launch with 40G FTV due to Device start fails if NIC’s max queues > the default number of 128, so, we changed the default value from 128 to 512. Signed-off-by: Wenwu Ma --- examples/vhost/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/vhost/main

[dpdk-dev] [PATCH] port: eventdev port api promoted

2021-09-09 Thread Rahul Shah
rte_port_eventdev_reader_ops, rte_port_eventdev_writer_nodrops_ops, rte_port_eventdev_writer_ops symbols promoted Signed-off-by: Rahul Shah --- lib/port/version.map | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/port/version.map b/lib/port/version.map index 73d08

Re: [dpdk-dev] [PATCH v2 4/6] eal: update rte_eal_wait_lcore definition

2021-09-09 Thread Honnappa Nagarahalli
+ Techboard. This is the API (not ABI as I mentioned) compatibility breakage that I mentioned during the last Techboard meeting. The removal of the FINISHED state itself was announced. This is a change related to that. However, the specific API change was not called out in the deprecation noti

[dpdk-dev] [PATCH v6 10/10] MAINTAINERS: add entry for new pcapng and dumper

2021-09-09 Thread Stephen Hemminger
Claim responsibility for the new code. Signed-off-by: Stephen Hemminger --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 266f5ac1dae8..06384ac2702d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1429,6 +1429,12 @@ F: app/test/test_pdump.*

[dpdk-dev] [PATCH v6 09/10] doc: changes for new pcapng and dumpcap

2021-09-09 Thread Stephen Hemminger
Describe the new packet capture library and utilities Signed-off-by: Stephen Hemminger --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf.in | 1 + .../howto/img/packet_capture_framework.svg| 96 +-- doc/guides/howto/packet_c

[dpdk-dev] [PATCH v6 08/10] app/dumpcap: add new packet capture application

2021-09-09 Thread Stephen Hemminger
This is a new packet capture application to replace existing pdump. The new application works like Wireshark dumpcap program and supports the pdump API features. It is not complete yet some features such as filtering are not implemented. Signed-off-by: Stephen Hemminger --- app/dumpcap/main.c

[dpdk-dev] [PATCH v6 07/10] pdump: support pcapng and filtering

2021-09-09 Thread Stephen Hemminger
This enhances the DPDK pdump library to support new pcapng format and filtering via BPF. The internal client/server protocol is changed to support two versions: the original pdump basic version and a new pcapng version. The internal version number (not part of exposed API or ABI) is intentionally

[dpdk-dev] [PATCH v6 06/10] lib: pdump is not supported on Windows

2021-09-09 Thread Stephen Hemminger
The original version of the pdump library was building on Windows, but it was useless since the pdump utility was not being built. The new version of pdump with filtering now has dependency on bpf. But bpf library is not available on Windows. For now, just stop trying to build pdump on Windows. E

[dpdk-dev] [PATCH v6 05/10] test: add test for bpf_convert

2021-09-09 Thread Stephen Hemminger
Add some functional tests for the Classic BPF to DPDK BPF converter. Signed-off-by: Stephen Hemminger --- app/test/test_bpf.c | 148 1 file changed, 148 insertions(+) diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c index 527c06b80708..68b09067

[dpdk-dev] [PATCH v6 04/10] bpf: add function to dump eBPF instructions

2021-09-09 Thread Stephen Hemminger
When debugging converted (and other) programs it is useful to see disassembled eBPF output. Signed-off-by: Stephen Hemminger --- lib/bpf/bpf_convert.c | 7 ++- lib/bpf/bpf_dump.c| 118 ++ lib/bpf/meson.build | 1 + lib/bpf/rte_bpf.h | 14 +++

[dpdk-dev] [PATCH v6 03/10] bpf: add function to convert classic BPF to DPDK BPF

2021-09-09 Thread Stephen Hemminger
The pcap library emits classic BPF (32 bit) and is useful for creating filter programs. The DPDK BPF library only implements extended BPF (eBPF). Add an function to convert from old to new. The rte_bpf_convert function uses rte_malloc to put the resulting program in hugepage shared memory so it

[dpdk-dev] [PATCH v6 02/10] bpf: allow self-xor operation

2021-09-09 Thread Stephen Hemminger
When doing BPF filter program conversion, a common way to zero a register in single instruction is: xor r7,r7 The BPF validator would not allow this because the value of r7 was undefined. But after this operation it always zero. Signed-off-by: Stephen Hemminger --- lib/bpf/bpf_validate.c |

[dpdk-dev] [PATCH v6 01/10] librte_pcapng: add new library for writing pcapng files

2021-09-09 Thread Stephen Hemminger
This is utility library for writing pcapng format files used by Wireshark family of utilities. Older tcpdump also knows how to read (but not write) this format. See draft RFC https://www.ietf.org/id/draft-tuexen-opsawg-pcapng-03.html and https://github.com/pcapng/pcapng/ Signed-off-by: Stephe

[dpdk-dev] [PATCH v6 00/10] Packet capture framework enhancements

2021-09-09 Thread Stephen Hemminger
This patch set is a more complete version of the the enhanced packet capture support described last year. The new capture library and utility are: - faster avoids lots of extra I/O, does bursting, etc. - gives more information (multiple ports, queues, etc) - has a better user interface (same

[dpdk-dev] [PATCH v2 5/6] eal: ensure memory operations are visible to main

2021-09-09 Thread Honnappa Nagarahalli
Ensure that the memory operations in worker thread, that happen before it returns the status of the assigned function, are visible to the main thread. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Feifei Wang --- lib/eal/common/eal_common_launch.c | 2 -- lib/eal/freebsd/eal_thread.c

[dpdk-dev] [PATCH v2 6/6] test/ring: use relaxed barriers for ring stress test

2021-09-09 Thread Honnappa Nagarahalli
wrk_cmd variable is used to signal the worker thread to start or stop the stress test loop. Relaxed barriers are used to achieve the same. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Ola Liljedahl Reviewed-by: Feifei Wang --- app/test/test_ring_stress_impl.h | 18 +- 1 fil

[dpdk-dev] [PATCH v2 3/6] eal: lcore state FINISHED is not required

2021-09-09 Thread Honnappa Nagarahalli
FINISHED state seems to be used to indicate that the worker's update of the 'state' is not visible to other threads. There seems to be no requirement to have such a state. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Ola Liljedahl Reviewed-by: Feifei Wang --- drivers/event/dpaa2/dpaa2_even

[dpdk-dev] [PATCH v2 2/6] eal: ensure memory operations are visible to worker

2021-09-09 Thread Honnappa Nagarahalli
Ensure that the memory operations before the call to rte_eal_remote_launch are visible to the worker thread. Use the function pointer to execute in worker thread as the guard variable. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Ola Liljedahl Reviewed-by: Feifei Wang --- lib/eal/freebsd/e

[dpdk-dev] [PATCH v2 4/6] eal: update rte_eal_wait_lcore definition

2021-09-09 Thread Honnappa Nagarahalli
Since the FINISHED state is removed, the API rte_eal_wait_lcore is updated to always return the status of the last function that ran in the worker core. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Feifei Wang --- lib/eal/common/eal_common_launch.c | 6 ++ lib/eal/include/rte_launch.h

[dpdk-dev] [PATCH v2 1/6] eal: reset lcore function pointer and argument

2021-09-09 Thread Honnappa Nagarahalli
In the rte_eal_remote_launch function, the lcore function pointer is checked for NULL. However, the pointer is never reset to NULL. Reset the lcore function pointer and argument after the worker has completed executing the lcore function. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Ruifeng W

[dpdk-dev] [PATCH v2 0/6] Use correct memory ordering in eal functions

2021-09-09 Thread Honnappa Nagarahalli
rte_eal_remote_launch and rte_eal_wait_lcore need to provide correct memory ordering to address the data communication from main core to worker core. There are 2 use cases: 1) All the store operations (meant for worker) by main core should be visible to worker core before the worker core runs the

Re: [dpdk-dev] [PATCH v2 06/18] bpf: fix spelling in comments

2021-09-09 Thread Stephen Hemminger
On Thu, 9 Sep 2021 22:49:56 +0300 Dmitry Kozlyuk wrote: > 2021-09-09 11:10 (UTC-0700), Stephen Hemminger: > [...] > > diff --git a/lib/bpf/bpf_validate.c b/lib/bpf/bpf_validate.c > > index 7b1291b382e9..3e7d3d730637 100644 > > --- a/lib/bpf/bpf_validate.c > > +++ b/lib/bpf/bpf_validate.c > > @@ -

[dpdk-dev] [PATCH v3 3/3] doc: update iavf PMD and 21.11 release notes

2021-09-09 Thread Pallavi Kadam
Add documentation to support iavf PMD on Windows. Update the release notes for the same. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- doc/guides/nics/intel_vf.rst | 18 ++ doc/guides/rel_notes/release_21_11.rst | 4 2 files changed, 22 insertions(+)

[dpdk-dev] [PATCH v3 2/3] lib/net: fix support of random

2021-09-09 Thread Pallavi Kadam
IAVF PMD needs to generate a random MAC address if it is not configured by host. 'random' is now supported on Windows. Fixes: 16f0d03098cb ("net: build on Windows") Cc: f...@mellanox.com Cc: sta...@dpdk.org Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- lib/net/rte_ether.c | 4

[dpdk-dev] [PATCH v3 1/3] net/iavf: build on Windows

2021-09-09 Thread Pallavi Kadam
- Enable IAVF PMD build on Windows - Replace x86intrin.h with rte_vect.h to avoid __m_prefetchw conflicting types - Fix for pointer and integer sign warnings using Clang compiler on Windows - Add extra cflags '-fno-asynchronous-unwind-tables' to avoid MinGW build error: Error: invalid regis

[dpdk-dev] [PATCH v3 0/3] Support iavf PMD on Windows

2021-09-09 Thread Pallavi Kadam
This patch-set enables building the iavf PMD on Windows. Currently, it uses alarm functions so, depends on following series. Depends-on: series-18447 ("net/iavf: enable interrupt polling") v3 changes: - Fix doc build warning v2 changes: - Rebase for 21.11 - Fix for 'random

[dpdk-dev] [PATCH v3 5/5] net/enetfec: add features

2021-09-09 Thread Apeksha Gupta
This patch adds checksum and VLAN offloads in enetfec network poll mode driver. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- doc/guides/nics/enetfec.rst | 2 ++ doc/guides/nics/features/enetfec.ini | 3 ++ drivers/net/enetfec/enet_ethdev.c| 17 - drivers/

[dpdk-dev] [PATCH v3 4/5] net/enetfec: add enqueue and dequeue support

2021-09-09 Thread Apeksha Gupta
This patch adds burst enqueue and dequeue operations to the enetfec PMD. Loopback mode is also added, compile time flag 'ENETFEC_LOOPBACK' is used to enable this feature. By default loopback mode is disabled. Basic features added like promiscuous enable, basic stats. Signed-off-by: Sachin Saxena

[dpdk-dev] [PATCH v3 3/5] net/enetfec: support queue configuration

2021-09-09 Thread Apeksha Gupta
This patch adds Rx/Tx queue configuration setup operations. On packet reception the respective BD Ring status bit is set which is then used for packet processing. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- drivers/net/enetfec/enet_ethdev.c | 230 +-

[dpdk-dev] [PATCH v3 2/5] net/enetfec: add UIO support

2021-09-09 Thread Apeksha Gupta
Implemented the fec-uio driver in kernel. enetfec PMD uses UIO interface to interact with "fec-uio" driver implemented in kernel for PHY initialisation and for mapping the allocated memory of register & BD from kernel to DPDK which gives access to non-cacheable memory for BD. Signed-off-by: Sachin

[dpdk-dev] [PATCH v3 1/5] net/enetfec: introduce NXP ENETFEC driver

2021-09-09 Thread Apeksha Gupta
ENETFEC (Fast Ethernet Controller) is a network poll mode driver for NXP SoC i.MX 8M Mini. This patch adds skeleton for enetfec driver with probe function. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- MAINTAINERS| 7 ++ doc/guides/nics/enetfec.rst

[dpdk-dev] [PATCH v3 0/5] drivers/net: add NXP ENETFEC driver

2021-09-09 Thread Apeksha Gupta
This patch series introduce the enetfec driver, ENETFEC (Fast Ethernet Controller) is a network poll mode driver for the inbuilt NIC found in the NXP i.MX 8M Mini SoC. An overview of the enetfec driver with probe and remove are in patch 1. Patch 2 design UIO interface so that user space directly c

Re: [dpdk-dev] [PATCH] app/test: fix event timer adapter create unit test

2021-09-09 Thread Carrillo, Erik G
> -Original Message- > From: Shijith Thotton > Sent: Monday, August 30, 2021 3:13 PM > To: dev@dpdk.org > Cc: Shijith Thotton ; jer...@marvell.com; > pbhagavat...@marvell.com; Carrillo, Erik G > Subject: [PATCH] app/test: fix event timer adapter create unit test > > Removed freeing of un

Re: [dpdk-dev] [PATCH v2 06/18] bpf: fix spelling in comments

2021-09-09 Thread Dmitry Kozlyuk
2021-09-09 11:10 (UTC-0700), Stephen Hemminger: [...] > diff --git a/lib/bpf/bpf_validate.c b/lib/bpf/bpf_validate.c > index 7b1291b382e9..3e7d3d730637 100644 > --- a/lib/bpf/bpf_validate.c > +++ b/lib/bpf/bpf_validate.c > @@ -1723,7 +1723,7 @@ static const struct bpf_ins_check ins_chk[UINT8_MAX +

[dpdk-dev] [PATCH] eal/ppc: replace rte_atomicXX ops with C11 atomic builtins

2021-09-09 Thread David Christensen
Replace existing PPC assembly code for rte_atomicXX ops with compiler atomic builtins as prevously adopted by DPDK (see [1] and [2]). This has the additional benefit of resolving a POWER10 build failure due to an outstanding gcc issue which fails on the existing PPC assembly code [3]. [1] https:/

Re: [dpdk-dev] [PATCH v2 15/18] vhost: fix typo in comment

2021-09-09 Thread Maxime Coquelin
On 9/9/21 8:10 PM, Stephen Hemminger wrote: > Yet another spelling error found by codespell. > > Signed-off-by: Stephen Hemminger > --- > lib/vhost/rte_vhost.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/vhost/rte_vhost.h b/lib/vhost/rte_vhost.h > index 8

[dpdk-dev] [PATCH v2 18/18] test: fix spelling errors in comments

2021-09-09 Thread Stephen Hemminger
Lots of little typos. Signed-off-by: Stephen Hemminger --- app/test/test_atomic.c | 2 +- app/test/test_barrier.c | 2 +- app/test/test_bpf.c | 2 +- app/test/test_compressdev.c | 2 +- app/test/test_func_reentrancy.c | 6 +++--- app/test/test_ipsec.c

[dpdk-dev] [PATCH v2 17/18] test-pmd: fix spelling errors in comments

2021-09-09 Thread Stephen Hemminger
More typos Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c | 2 +- app/test-pmd/config.c | 4 ++-- app/test-pmd/icmpecho.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 82253bc75110..2628bd64dae6 100644

[dpdk-dev] [PATCH v2 16/18] ip_frag: fix typos

2021-09-09 Thread Stephen Hemminger
Minor typos in comment. Signed-off-by: Stephen Hemminger --- lib/ip_frag/rte_ipv4_reassembly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ip_frag/rte_ipv4_reassembly.c b/lib/ip_frag/rte_ipv4_reassembly.c index 69666c8b8271..4a89a5f5365a 100644 --- a/lib/ip_frag/rte_

[dpdk-dev] [PATCH v2 15/18] vhost: fix typo in comment

2021-09-09 Thread Stephen Hemminger
Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/vhost/rte_vhost.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/vhost/rte_vhost.h b/lib/vhost/rte_vhost.h index 8d875e932297..c36dfc705b04 100644 --- a/lib/vhost/rte_vhost.h +++

[dpdk-dev] [PATCH v2 14/18] sched: fix typo in comment

2021-09-09 Thread Stephen Hemminger
Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/sched/rte_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index a858f61f9548..329f4b2e7b48 100644 --- a/lib/sched/rte_sched.c +++ b/li

[dpdk-dev] [PATCH v2 13/18] rib: fix typo in comment

2021-09-09 Thread Stephen Hemminger
Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/rib/rte_rib6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rib/rte_rib6.c b/lib/rib/rte_rib6.c index 96424e9c9f4f..4a6f29b0040d 100644 --- a/lib/rib/rte_rib6.c +++ b/lib/rib/rte_ri

[dpdk-dev] [PATCH v2 12/18] hash: fix typo in comment

2021-09-09 Thread Stephen Hemminger
Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/hash/rte_thash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/hash/rte_thash.c b/lib/hash/rte_thash.c index d5a95a6e009a..f5e9111f0264 100644 --- a/lib/hash/rte_thash.c +++ b/lib/ha

[dpdk-dev] [PATCH v2 11/18] pipeline: fix spellin error in comment

2021-09-09 Thread Stephen Hemminger
Minor typo Signed-off-by: Stephen Hemminger --- lib/pipeline/rte_swx_pipeline.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/pipeline/rte_swx_pipeline.h b/lib/pipeline/rte_swx_pipeline.h index cd395ac39dbb..9bfc69b2bb4f 100644 --- a/lib/pipeline/rte_swx_pipeline.h +++

[dpdk-dev] [PATCH v2 10/18] bbdev: fix typo in comment

2021-09-09 Thread Stephen Hemminger
Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/bbdev/rte_bbdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c index fc37236195be..49a0de49d8df 100644 --- a/lib/bbdev/rte_bbdev.c +++ b/li

[dpdk-dev] [PATCH v2 09/18] net: fix spelling error in gtp comment

2021-09-09 Thread Stephen Hemminger
More codespell finds. Signed-off-by: Stephen Hemminger --- lib/net/rte_gtp.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/net/rte_gtp.h b/lib/net/rte_gtp.h index 6a6f9b238db9..f22dbce47c65 100644 --- a/lib/net/rte_gtp.h +++ b/lib/net/rte_gtp.h @@ -64,9 +64,9 @@ s

[dpdk-dev] [PATCH v2 08/18] eal: fix typos in comments

2021-09-09 Thread Stephen Hemminger
Minor spelling errors. Signed-off-by: Stephen Hemminger --- lib/eal/include/rte_function_versioning.h | 2 +- lib/eal/windows/include/fnmatch.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/eal/include/rte_function_versioning.h b/lib/eal/include/rte_function

[dpdk-dev] [PATCH v2 07/18] acl: fix spelling errors

2021-09-09 Thread Stephen Hemminger
Lots of little typos in comments Signed-off-by: Stephen Hemminger --- lib/acl/acl.h | 4 ++-- lib/acl/acl_bld.c | 2 +- lib/acl/acl_run_avx2.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/acl/acl.h b/lib/acl/acl.h index 4089ab2a0462..f5739a475cf0 10064

[dpdk-dev] [PATCH v2 06/18] bpf: fix spelling in comments

2021-09-09 Thread Stephen Hemminger
Found by running codespell on the bpf implementation. Signed-off-by: Stephen Hemminger --- lib/bpf/bpf_jit_x86.c | 2 +- lib/bpf/bpf_validate.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/bpf/bpf_jit_x86.c b/lib/bpf/bpf_jit_x86.c index aa22ea78a01d..518513376a67

[dpdk-dev] [PATCH v2 05/18] rcu: fix typo in comment

2021-09-09 Thread Stephen Hemminger
Another codespell find. Signed-off-by: Stephen Hemminger --- lib/rcu/rte_rcu_qsbr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h index 18811c1cc106..62a420a785fc 100644 --- a/lib/rcu/rte_rcu_qsbr.h +++ b/lib/rcu/rte_rcu_qsbr.

[dpdk-dev] [PATCH v2 04/18] power: fix typo in comment

2021-09-09 Thread Stephen Hemminger
More spelling errors caught by codespell Signed-off-by: Stephen Hemminger --- lib/power/power_acpi_cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/power/power_acpi_cpufreq.c b/lib/power/power_acpi_cpufreq.c index 1e8aeb84037c..402ed8c99b42 100644 --- a/lib/power

[dpdk-dev] [PATCH v2 03/18] eventdev: fix typo in comment

2021-09-09 Thread Stephen Hemminger
Typo in comment found by codespell Signed-off-by: Stephen Hemminger --- lib/eventdev/rte_event_timer_adapter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/eventdev/rte_event_timer_adapter.c b/lib/eventdev/rte_event_timer_adapter.c index ee20b39f4b24..b5c2dc1427c6 100

[dpdk-dev] [PATCH v2 02/18] ipsec: fix spelling errors

2021-09-09 Thread Stephen Hemminger
Lots of typos in comments found by codespell Signed-off-by: Stephen Hemminger --- lib/ipsec/esp_inb.c | 4 ++-- lib/ipsec/esp_outb.c | 2 +- lib/ipsec/ipsec_sad.c | 2 +- lib/ipsec/sa.c| 2 +- lib/ipsec/sa.h| 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a

[dpdk-dev] [PATCH v2 01/18] node: fix typos

2021-09-09 Thread Stephen Hemminger
Spelling errors in comments including doxygen Signed-off-by: Stephen Hemminger --- lib/node/ethdev_rx_priv.h | 2 +- lib/node/ethdev_tx_priv.h | 2 +- lib/node/ip4_rewrite_priv.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/node/ethdev_rx_priv.h b/lib/node/ethde

[dpdk-dev] [PATCH v2 00/18] Fix spelling errors

2021-09-09 Thread Stephen Hemminger
After finding a few typos in BPF, decided to cast a wider net and fix lots more places. These are all contained to typos in strings or comments. v2 - checkpatch wants more than just subject remove autocorrect of historical text Stephen Hemminger (18): node: fix typos ipsec: fix spelling

[dpdk-dev] [PATCH v2 3/3] doc: update iavf PMD and 21.11 release notes

2021-09-09 Thread Pallavi Kadam
Add documentation to support iavf PMD on Windows. Update the release notes for the same. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- doc/guides/nics/intel_vf.rst | 17 + doc/guides/rel_notes/release_21_11.rst | 4 2 files changed, 21 insertions(+)

[dpdk-dev] [PATCH v2 2/3] lib/net: fix support of random

2021-09-09 Thread Pallavi Kadam
IAVF PMD needs to generate a random MAC address if it is not configured by host. 'random' is now supported on Windows. Fixes: 16f0d03098cb ("net: build on Windows") Cc: f...@mellanox.com Cc: sta...@dpdk.org Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- lib/net/rte_ether.c | 4

[dpdk-dev] [PATCH v2 0/3] Support iavf PMD on Windows

2021-09-09 Thread Pallavi Kadam
This patch-set enables building the iavf PMD on Windows. Currently, it uses alarm functions so, depends on following series. Depends-on: series-18447 ("net/iavf: enable interrupt polling") v2 changes: - rebase for 21.11 - Fix for 'random' Pallavi Kadam (3): net/iavf: build on W

[dpdk-dev] [PATCH v2 1/3] net/iavf: build on Windows

2021-09-09 Thread Pallavi Kadam
- Enable IAVF PMD build on Windows - Replace x86intrin.h with rte_vect.h to avoid __m_prefetchw conflicting types - Fix for pointer and integer sign warnings using Clang compiler on Windows - Add extra cflags '-fno-asynchronous-unwind-tables' to avoid MinGW build error: Error: invalid regis

[dpdk-dev] [PATCH 18/18] test-pmd: fix spelling errors in comments

2021-09-09 Thread Stephen Hemminger
More typos Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c | 2 +- app/test-pmd/config.c | 4 ++-- app/test-pmd/icmpecho.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 82253bc75110..2628bd64dae6 100644

[dpdk-dev] [PATCH 17/18] test: fix spelling errors in comments

2021-09-09 Thread Stephen Hemminger
Lots of little typos Signed-off-by: Stephen Hemminger --- app/test/test_atomic.c | 2 +- app/test/test_barrier.c | 2 +- app/test/test_bpf.c | 2 +- app/test/test_compressdev.c | 2 +- app/test/test_compressdev_test_buffer.h |

[dpdk-dev] [PATCH 16/18] ip_frag: fix typos

2021-09-09 Thread Stephen Hemminger
Minor typos in comment. Signed-off-by: Stephen Hemminger --- lib/ip_frag/rte_ipv4_reassembly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ip_frag/rte_ipv4_reassembly.c b/lib/ip_frag/rte_ipv4_reassembly.c index 69666c8b8271..4a89a5f5365a 100644 --- a/lib/ip_frag/rte_

[dpdk-dev] [PATCH 15/18] vhost: fix typo in comment

2021-09-09 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- lib/vhost/rte_vhost.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/vhost/rte_vhost.h b/lib/vhost/rte_vhost.h index 8d875e932297..c36dfc705b04 100644 --- a/lib/vhost/rte_vhost.h +++ b/lib/vhost/rte_vhost.h @@ -776,7 +776,7 @@ rte_

[dpdk-dev] [PATCH 14/18] sched: fix typo in comment

2021-09-09 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- lib/sched/rte_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index a858f61f9548..329f4b2e7b48 100644 --- a/lib/sched/rte_sched.c +++ b/lib/sched/rte_sched.c @@ -579,7 +579,7 @@ rte_sche

[dpdk-dev] [PATCH 13/18] rib: fix typo in comment

2021-09-09 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- lib/rib/rte_rib6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rib/rte_rib6.c b/lib/rib/rte_rib6.c index 96424e9c9f4f..4a6f29b0040d 100644 --- a/lib/rib/rte_rib6.c +++ b/lib/rib/rte_rib6.c @@ -199,7 +199,7 @@ rte_rib6_lookup_exact(s

[dpdk-dev] [PATCH 12/18] hash: fix typo in comment

2021-09-09 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- lib/hash/rte_thash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/hash/rte_thash.c b/lib/hash/rte_thash.c index d5a95a6e009a..f5e9111f0264 100644 --- a/lib/hash/rte_thash.c +++ b/lib/hash/rte_thash.c @@ -26,7 +26,7 @@ EAL_REGISTER_TA

[dpdk-dev] [PATCH 11/18] pipeline: fix spellin error in comment

2021-09-09 Thread Stephen Hemminger
Minor typo Signed-off-by: Stephen Hemminger --- lib/pipeline/rte_swx_pipeline.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/pipeline/rte_swx_pipeline.h b/lib/pipeline/rte_swx_pipeline.h index cd395ac39dbb..9bfc69b2bb4f 100644 --- a/lib/pipeline/rte_swx_pipeline.h +++

[dpdk-dev] [PATCH 10/18] bbdev: fix typo in comment

2021-09-09 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- lib/bbdev/rte_bbdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c index fc37236195be..49a0de49d8df 100644 --- a/lib/bbdev/rte_bbdev.c +++ b/lib/bbdev/rte_bbdev.c @@ -138,7 +138,7 @@ rte_bbde

[dpdk-dev] [PATCH 09/18] net: fix spelling error in gtp comment

2021-09-09 Thread Stephen Hemminger
More codespell finds. Signed-off-by: Stephen Hemminger --- lib/net/rte_gtp.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/net/rte_gtp.h b/lib/net/rte_gtp.h index 6a6f9b238db9..f22dbce47c65 100644 --- a/lib/net/rte_gtp.h +++ b/lib/net/rte_gtp.h @@ -64,9 +64,9 @@ s

[dpdk-dev] [PATCH 08/18] eal: fix typos in comments

2021-09-09 Thread Stephen Hemminger
Minor spelling errors. Signed-off-by: Stephen Hemminger --- lib/eal/include/rte_function_versioning.h | 2 +- lib/eal/windows/include/fnmatch.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/eal/include/rte_function_versioning.h b/lib/eal/include/rte_function

[dpdk-dev] [PATCH 07/18] acl: fix spelling errors

2021-09-09 Thread Stephen Hemminger
Lots of little typos in comments Signed-off-by: Stephen Hemminger --- lib/acl/acl.h | 4 ++-- lib/acl/acl_bld.c | 2 +- lib/acl/acl_run_avx2.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/acl/acl.h b/lib/acl/acl.h index 4089ab2a0462..f5739a475cf0 10064

  1   2   >