Re: [dpdk-dev] Questions about rte_eth_link_speed_to_str API

2021-09-13 Thread Stephen Hemminger
On Tue, 14 Sep 2021 11:25:44 +0800 "Min Hu (Connor)" wrote: > Thanks Thomas, > I am not sure if we need to print combined slaves speed. > How about others' opinion ? @all > > BTW, If yes, one possible option may be like that: > +const char * > +rte_eth_link_speed_to_str(uint32

Re: [dpdk-dev] [PATCH] net/virtio: report max/min/align desc limits in dev info get

2021-09-13 Thread Andrew Rybchenko
On 9/13/21 10:52 PM, Maxime Coquelin wrote: > > > On 8/20/21 2:48 PM, Andrew Rybchenko wrote: >> From: Ivan Ilchenko >> >> Report max/min/align descriptors limits in device info get callback. >> Before calling the callback, rte_eth_dev_info_get() provides >> default values of nb_min as zero and

Re: [dpdk-dev] [PATCH] net/virtio: remove handling of zero desc number on RxQ setup

2021-09-13 Thread Andrew Rybchenko
On 9/13/21 10:25 PM, Maxime Coquelin wrote: > > > On 8/20/21 2:47 PM, Andrew Rybchenko wrote: >> From: Ivan Ilchenko >> >> Rx queue setup callback allows to use the whole ring when >> descriptor number argument equals zero. There's no point to >> handle zero in any way since RTE Rx queue setup f

Re: [dpdk-dev] DPDK Max Mbuf Allocation

2021-09-13 Thread Lance Richardson
On Mon, Sep 13, 2021 at 11:51 AM Stephen Hemminger wrote: > > On Mon, 13 Sep 2021 16:43:18 +0100 > Ferruh Yigit wrote: > > > On 9/13/2021 5:56 AM, Kamaraj P wrote: > > > Hello All, > > > > > > Would like to understand or if there are any guidelines to allocate the > > > max > > > no of mbuf per

[dpdk-dev] [PATCH] examples/kni: add dev close step when kni free

2021-09-13 Thread Min Hu (Connor)
From: Huisong Li This patch adds dev_close() step to release network adapter resources when kni free. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- examples/kni/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/kni/main.c b/examples/kni/main.c index beabb3c848

Re: [dpdk-dev] [EXT] Re: [PATCH] RFC: ethdev: add reassembly offload

2021-09-13 Thread Anoob Joseph
Hi Andrew, Rosen, Please see inline. Thanks, Anoob > -Original Message- > From: Andrew Rybchenko > Sent: Monday, September 13, 2021 12:52 PM > To: Xu, Rosen ; Anoob Joseph > ; Yigit, Ferruh ; Andrew > Rybchenko > Cc: Nicolau, Radu ; Doherty, Declan > ; hemant.agra...@nxp.com; > ma...@n

Re: [dpdk-dev] [PATCH v3] eventdev: update crypto adapter metadata structures

2021-09-13 Thread Anoob Joseph
Hi Abhinandan, Shijith, Please see inline. Thanks, Anoob > -Original Message- > From: Shijith Thotton > Sent: Tuesday, September 14, 2021 10:07 AM > To: Gujjar, Abhinandan S ; dev@dpdk.org > Cc: Jerin Jacob Kollanukkaran ; Anoob Joseph > ; Pavan Nikhilesh Bhagavatula > ; Akhil Goyal ; R

Re: [dpdk-dev] [PATCH v3] eventdev: update crypto adapter metadata structures

2021-09-13 Thread Shijith Thotton
>> >> >> >> >> In crypto adapter metadata, reserved bytes in request info >> >> >> structure is a space holder for response info. It enforces an >> >> >> order of operation if the structures are updated using memcpy to >> >> >> avoid overwriting response info. It is logical to move the >> >> >> res

Re: [dpdk-dev] [PATCH v2] app/testpmd: Document what the application does.

2021-09-13 Thread Ajit Khaparde
On Mon, Sep 13, 2021 at 5:26 PM Ajit Khaparde wrote: > > On Mon, Sep 13, 2021 at 11:59 AM Thomas Monjalon wrote: > > > > 13/09/2021 20:33, Ben Pfaff: > > > I could not find anything in the documentation that says what > > > testpmd does. This should save other people time trying to > > > figure

Re: [dpdk-dev] [PATCH v2] app/testpmd: Document what the application does.

2021-09-13 Thread Ajit Khaparde
On Mon, Sep 13, 2021 at 11:59 AM Thomas Monjalon wrote: > > 13/09/2021 20:33, Ben Pfaff: > > I could not find anything in the documentation that says what > > testpmd does. This should save other people time trying to > > figure that out in the future. > > > > Signed-off-by: Ben Pfaff > [...] >

Re: [dpdk-dev] Questions about rte_eth_link_speed_to_str API

2021-09-13 Thread Min Hu (Connor)
Thanks Thomas, I am not sure if we need to print combined slaves speed. How about others' opinion ? @all BTW, If yes, one possible option may be like that: +const char * +rte_eth_link_speed_to_str(uint32_t link_speed) +{ + char name[16]; + + if (link_speed ==

Re: [dpdk-dev] [PATCH] Enable AddressSanitizer feature on DPDK

2021-09-13 Thread Lin, Xueqin
> -Original Message- > From: Stephen Hemminger > Sent: Monday, September 13, 2021 11:46 PM > To: Richardson, Bruce > Cc: Peng, ZhihongX ; Burakov, Anatoly > ; Ananyev, Konstantin > ; dev@dpdk.org; Lin, Xueqin > > Subject: Re: [dpdk-dev] [PATCH] Enable AddressSanitizer feature on DPDK >

[dpdk-dev] [PATCH] app/testpmd: fix statistics in multiple process

2021-09-13 Thread Min Hu (Connor)
Currently, 'clear port stats all' in secondary will clear stats in PMD, and also update stats which APP stores in 'ports[]' array in secondary process, note that, that in primary process remains unchanged. So, when 'show fwd stats all' in primary process, stats in PMD may be less than stats which A

Re: [dpdk-dev] [PATCH v1] bbdev: remove experimental tag from API

2021-09-13 Thread Hemant Agrawal
HI Maxime, > > On 9/1/21 4:54 PM, Chautru, Nicolas wrote: > > > > > >> -Original Message- > >> From: Kinsella, Ray > >> Sent: Wednesday, September 1, 2021 4:15 AM > >> To: Hemant Agrawal ; David Marchand > >> ; Chautru, Nicolas > >> > >> Cc: dev ; Akhil Goyal ; Thomas > >> Monjalon ; To

Re: [dpdk-dev] [PATCH] Enable AddressSanitizer feature on DPDK

2021-09-13 Thread Lin, Xueqin
> -Original Message- > From: Richardson, Bruce > Sent: Monday, September 13, 2021 11:22 PM > To: Stephen Hemminger > Cc: Peng, ZhihongX ; Burakov, Anatoly > ; Ananyev, Konstantin > ; dev@dpdk.org; Lin, Xueqin > > Subject: Re: [dpdk-dev] [PATCH] Enable AddressSanitizer feature on DPDK >

[dpdk-dev] [PATCH] net/ice: retry getting VF VSI map after it fails

2021-09-13 Thread dapengx . yu
From: Dapeng Yu The request of getting VF VSI map request may fail when DCF is busy, this patch adds retry mechanism to make it able to succeed. Fixes: b09d34ac8584 ("net/ice: fix flow redirector") Cc: sta...@dpdk.org Signed-off-by: Dapeng Yu --- drivers/net/ice/ice_dcf.c | 15 +--

Re: [dpdk-dev] [PATCH] driver: i40evf device initialization

2021-09-13 Thread Ben Magistro
+cc: sta...@dpdk.org Per discussions here, cc'ing stable for fix to be applied to LTS as i40evf is being removed from next. On Thu, Sep 2, 2021 at 8:37 AM Xueming(Steven) Li wrote: > > > > > -Original Message- > > From: Ferruh Yigit > > Sent: Monday, August 30, 2021 5:43 PM > > To: Xuem

[dpdk-dev] [PATCH] net/ice: add ability to reduce the Rx latency

2021-09-13 Thread Alvin Zhang
This patch adds a devarg parameter to enable/disable reducing the Rx latency. Signed-off-by: Alvin Zhang --- doc/guides/nics/ice.rst | 8 drivers/net/ice/ice_ethdev.c | 26 +++--- drivers/net/ice/ice_ethdev.h | 1 + 3 files changed, 32 insertions(+), 3 deletio

[dpdk-dev] [PATCH] crypto/mlx5: fix indirect mkey cleaning

2021-09-13 Thread Michael Baum
The driver creates an indirect mkey per entry in the queue to manage the crypto operation using the BSF fields. The indirect mkeys were never released neither while error occurs in the creation phase nor when the queue is released. Clean the indirect mkeys in the above cases. Fixes: c2a42d19d967

[dpdk-dev] [PATCH] cryptodev: build on Windows

2021-09-13 Thread Tal Shnaiderman
Build the cryptography device library on Windows OS by removing unneeded include and exports blocking the compilation. Signed-off-by: Tal Shnaiderman --- lib/cryptodev/rte_cryptodev.c | 1 - lib/cryptodev/version.map | 2 -- lib/meson.build | 1 + 3 files changed, 1 insertion(+

[dpdk-dev] [PATCH] eal/windows: fix token pasting build warning

2021-09-13 Thread Tal Shnaiderman
When building DPDK on Windows in debug mode the following warning appear: warning: token pasting of ',' and __VA_ARGS__ is a GNU extension [-Wgnu-zero-variadic-macro-arguments] #define open(path, flags, ...) _open(path, flags, ##__VA_ARGS__) Modified the 'open' macro to avoid it. Fixes: 45d62067

Re: [dpdk-dev] [PATCH] net/virtio: handle Tx checksums correctly for tunnel packets

2021-09-13 Thread Maxime Coquelin
On 8/30/21 4:26 PM, Ivan Malov wrote: > Tx prepare method calls rte_net_intel_cksum_prepare(), which > handles tunnel packets correctly, but Tx burst path does not > take tunnel presence into account when computing the offsets. > > Signed-off-by: Ivan Malov > Reviewed-by: Andrew Rybchenko > -

Re: [dpdk-dev] [PATCH v3 6/6] bbdev: reduce warning level for one scenario

2021-09-13 Thread Tom Rix
On 9/13/21 10:03 AM, Chautru, Nicolas wrote: -Original Message- From: Tom Rix Sent: Sunday, September 12, 2021 5:55 AM To: Chautru, Nicolas ; dev@dpdk.org; gak...@marvell.com Cc: tho...@monjalon.net; hemant.agra...@nxp.com; Zhang, Mingshan ; Joshi, Arun Subject: Re: [PATCH v3 6/6] bbd

Re: [dpdk-dev] [PATCH] net/virtio: report max/min/align desc limits in dev info get

2021-09-13 Thread Maxime Coquelin
On 8/20/21 2:48 PM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Report max/min/align descriptors limits in device info get callback. > Before calling the callback, rte_eth_dev_info_get() provides > default values of nb_min as zero and nb_max as UINT16_MAX that are > not correct for the d

Re: [dpdk-dev] [PATCH] net/virtio: turn SW RxQ size to that of split vec. virtqueue

2021-09-13 Thread Maxime Coquelin
On 8/20/21 2:47 PM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Descriptors number may be set less than queue size for split queue > vectorized Rx path. Pointers to mbufs for received packets are > obtained from SW ring, that is initially filled with them in the end > of queue setup in v

Re: [dpdk-dev] [PATCH v1] bbdev: remove experimental tag from API

2021-09-13 Thread Maxime Coquelin
On 9/1/21 4:54 PM, Chautru, Nicolas wrote: > > >> -Original Message- >> From: Kinsella, Ray >> Sent: Wednesday, September 1, 2021 4:15 AM >> To: Hemant Agrawal ; David Marchand >> ; Chautru, Nicolas >> >> Cc: dev ; Akhil Goyal ; Thomas >> Monjalon ; Tom Rix ; Zhang, >> Mingshan ; Josh

Re: [dpdk-dev] [PATCH] net/virtio: remove handling of zero desc number on RxQ setup

2021-09-13 Thread Maxime Coquelin
On 8/20/21 2:47 PM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Rx queue setup callback allows to use the whole ring when > descriptor number argument equals zero. There's no point to > handle zero in any way since RTE Rx queue setup function > rte_eth_rx_queue_setup() doesn't pass zero

Re: [dpdk-dev] [PATCH] net/virtio: fix reporting of mbufs allocated on RxQ setup

2021-09-13 Thread Maxime Coquelin
On 8/20/21 2:47 PM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Rx queue setup finish function may report wrong number of > allocated mbufs in case of in-order feature. Fix the > function to not ignore allocation error and count only > successfully allocated number of buffers. > > Fixes

Re: [dpdk-dev] [PATCH] vhost: promote some APIs to stable

2021-09-13 Thread Maxime Coquelin
On 9/7/21 4:58 AM, Chenbo Xia wrote: > As reported by symbol bot, APIs listed in this patch have been > experimental for more than two years. This patch promotes these > 18 APIs to stable. > > Signed-off-by: Chenbo Xia > --- > lib/vhost/rte_vhost.h| 13 - > lib/vhost/rte_v

Re: [dpdk-dev] [PATCH V3 01/24] pipeline: move data structures to internal header file

2021-09-13 Thread Stephen Hemminger
On Mon, 13 Sep 2021 18:42:39 + "Dumitrescu, Cristian" wrote: > > -Original Message- > > From: Stephen Hemminger > > Sent: Monday, September 13, 2021 5:51 PM > > To: Dumitrescu, Cristian > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH V3 01/24] pipeline: move data structures

Re: [dpdk-dev] [PATCH v5 9/9] app/bbdev: add test vectors for transport blocks

2021-09-13 Thread Chautru, Nicolas
> -Original Message- > From: Nipun Gupta > Sent: Sunday, September 12, 2021 5:15 AM > To: dev@dpdk.org; gak...@marvell.com; Chautru, Nicolas > > Cc: david.march...@redhat.com; hemant.agra...@nxp.com; Nipun Gupta > > Subject: [PATCH v5 9/9] app/bbdev: add test vectors for transport blo

Re: [dpdk-dev] [PATCH v2] app/testpmd: Document what the application does.

2021-09-13 Thread Thomas Monjalon
13/09/2021 20:33, Ben Pfaff: > I could not find anything in the documentation that says what > testpmd does. This should save other people time trying to > figure that out in the future. > > Signed-off-by: Ben Pfaff [...] > --- a/doc/guides/testpmd_app_ug/intro.rst > +++ b/doc/guides/testpmd_app

Re: [dpdk-dev] [PATCH v5 5/9] baseband/la12xx: add queue and modem config support

2021-09-13 Thread Chautru, Nicolas
> -Original Message- > From: Nipun Gupta > Sent: Sunday, September 12, 2021 5:15 AM > To: dev@dpdk.org; gak...@marvell.com; Chautru, Nicolas > > Cc: david.march...@redhat.com; hemant.agra...@nxp.com; Nipun Gupta > > Subject: [PATCH v5 5/9] baseband/la12xx: add queue and modem config >

[dpdk-dev] [PATCH] lpm6: Fix missing ^ in documentation.

2021-09-13 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- doc/guides/prog_guide/lpm6_lib.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/prog_guide/lpm6_lib.rst b/doc/guides/prog_guide/lpm6_lib.rst index d1aea91ca9..8425d14805 100644 --- a/doc/guides/prog_guide/lpm6_lib.rst +++ b/doc/g

Re: [dpdk-dev] [PATCH v5 8/9] app/bbdev: handle endianness of test data

2021-09-13 Thread Chautru, Nicolas
> -Original Message- > From: Nipun Gupta > Sent: Sunday, September 12, 2021 5:15 AM > To: dev@dpdk.org; gak...@marvell.com; Chautru, Nicolas > > Cc: david.march...@redhat.com; hemant.agra...@nxp.com; Nipun Gupta > > Subject: [PATCH v5 8/9] app/bbdev: handle endianness of test data >

Re: [dpdk-dev] [PATCH V3 01/24] pipeline: move data structures to internal header file

2021-09-13 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger > Sent: Monday, September 13, 2021 5:51 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH V3 01/24] pipeline: move data structures to > internal header file > > On Mon, 13 Sep 2021 17:44:20 +0100 > Cristian

Re: [dpdk-dev] [PATCH v5 1/9] bbdev: add big endian processing data capability

2021-09-13 Thread Chautru, Nicolas
> -Original Message- > From: Nipun Gupta > Sent: Sunday, September 12, 2021 5:15 AM > To: dev@dpdk.org; gak...@marvell.com; Chautru, Nicolas > > Cc: david.march...@redhat.com; hemant.agra...@nxp.com; Nipun Gupta > > Subject: [PATCH v5 1/9] bbdev: add big endian processing data capabil

[dpdk-dev] [PATCH v2] app/testpmd: Document what the application does.

2021-09-13 Thread Ben Pfaff
I could not find anything in the documentation that says what testpmd does. This should save other people time trying to figure that out in the future. Signed-off-by: Ben Pfaff --- v1->v2: Revise introduction instead of option documentation. Thanks to Thomas Monjalon for advice. doc/guides/t

[dpdk-dev] [PATCH 1/2] app/testpmd: add tunnel types

2021-09-13 Thread Eli Britstein
Current testpmd implementation supports VXLAN only for tunnel offload. Add GRE, NVGRE and GENEVE for tunnel offload flow matches. Signed-off-by: Eli Britstein --- app/test-pmd/config.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/confi

[dpdk-dev] [PATCH 2/2] net/mlx5: add support for more tunnel types

2021-09-13 Thread Eli Britstein
Accept RTE_FLOW_ITEM_TYPE_GRE, RTE_FLOW_ITEM_TYPE_NVGRE and RTE_FLOW_ITEM_TYPE_GENEVE as valid tunnel types. Signed-off-by: Eli Britstein --- drivers/net/mlx5/mlx5_flow.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 4762

Re: [dpdk-dev] [PATCH] app/testpmd: Document what the application does.

2021-09-13 Thread Ben Pfaff
On Fri, Sep 10, 2021 at 11:14:26PM +0200, Thomas Monjalon wrote: > 10/09/2021 19:57, Ben Pfaff: > > I could not find anything in the documentation that says what > > testpmd does. This should save other people time trying to > > figure that out in the future. > > Good move indeed :) > > > --- a/

Re: [dpdk-dev] [PATCH] efd: change data type of parameter

2021-09-13 Thread Mcnamara, John
> -Original Message- > From: dev On Behalf Of Pablo de Lara > Sent: Friday, September 10, 2021 5:54 PM > To: Wang, Yipeng1 ; Marohn, Byron > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH] efd: change data type of parameter > > rte_efd_create() function was us

[dpdk-dev] [PATCH v8 12/12] MAINTAINERS: add entry for new packet capture features

2021-09-13 Thread Stephen Hemminger
Since the packet capture is just extension of existing pdump; add myself as maintainer of that. Signed-off-by: Stephen Hemminger --- MAINTAINERS | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 266f5ac1dae8..437cba73de0b 100644 --- a

[dpdk-dev] [PATCH v8 11/12] doc: changes for new pcapng and dumpcap

2021-09-13 Thread Stephen Hemminger
Describe the new packet capture library and utilities Signed-off-by: Stephen Hemminger --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf.in | 1 + .../howto/img/packet_capture_framework.svg| 96 +-- doc/guides/howto/packet_c

[dpdk-dev] [PATCH v8 10/12] test: enable bpf autotest

2021-09-13 Thread Stephen Hemminger
The BPF autotest is defined but not run automatically. Since it is short, it should be added to the autotest suite. Signed-off-by: Stephen Hemminger --- app/test/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test/meson.build b/app/test/meson.build index 0d551ac9c2b2..cd18

[dpdk-dev] [PATCH v8 09/12] test: add a test for pcapng library

2021-09-13 Thread Stephen Hemminger
Simple unit test that created pcapng file using API. To run this test you need to have at least one device. For example: DPDK_TEST=pcapng_autotest ./build/app/test/dpdk-test -l 0-15 \ --no-huge -m 2048 --vdev=net_tap,iface=dummy Signed-off-by: Stephen Hemminger --- app/test/meson.build |

[dpdk-dev] [PATCH v8 08/12] test: add test for bpf_convert

2021-09-13 Thread Stephen Hemminger
Add some functional tests for the Classic BPF to DPDK BPF converter. Signed-off-by: Stephen Hemminger --- app/test/test_bpf.c | 173 1 file changed, 173 insertions(+) diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c index 527c06b80708..1b5a1782

[dpdk-dev] [PATCH v8 07/12] app/dumpcap: add new packet capture application

2021-09-13 Thread Stephen Hemminger
This is a new packet capture application to replace existing pdump. The new application works like Wireshark dumpcap program and supports the pdump API features. It is not complete yet some features such as filtering are not implemented. Signed-off-by: Stephen Hemminger --- app/dumpcap/main.c

[dpdk-dev] [PATCH v8 06/12] pdump: support pcapng and filtering

2021-09-13 Thread Stephen Hemminger
This enhances the DPDK pdump library to support new pcapng format and filtering via BPF. The internal client/server protocol is changed to support two versions: the original pdump basic version and a new pcapng version. The internal version number (not part of exposed API or ABI) is intentionally

[dpdk-dev] [PATCH v8 05/12] bpf: add function to dump eBPF instructions

2021-09-13 Thread Stephen Hemminger
When debugging converted (and other) programs it is useful to see disassembled eBPF output. Signed-off-by: Stephen Hemminger --- lib/bpf/bpf_convert.c | 7 ++- lib/bpf/bpf_dump.c| 118 ++ lib/bpf/meson.build | 1 + lib/bpf/rte_bpf.h | 14 +++

[dpdk-dev] [PATCH v8 04/12] bpf: add function to convert classic BPF to DPDK BPF

2021-09-13 Thread Stephen Hemminger
The pcap library emits classic BPF (32 bit) and is useful for creating filter programs. The DPDK BPF library only implements extended BPF (eBPF). Add an function to convert from old to new. The rte_bpf_convert function uses rte_malloc to put the resulting program in hugepage shared memory so it

[dpdk-dev] [PATCH v8 03/12] bpf: allow self-xor operation

2021-09-13 Thread Stephen Hemminger
When doing BPF filter program conversion, a common way to zero a register in single instruction is: xor r7,r7 The BPF validator would not allow this because the value of r7 was undefined. But after this operation it always zero. Signed-off-by: Stephen Hemminger --- lib/bpf/bpf_validate.c |

[dpdk-dev] [PATCH v8 02/12] lib: pdump is not supported on Windows

2021-09-13 Thread Stephen Hemminger
The current version of the pdump library was building on Windows, but it was useless since the pdump utility was not being built and Windows does not have multi-process support. The new version of pdump with filtering now has dependency on bpf. But bpf library is not available on Windows. Signed-

[dpdk-dev] [PATCH v8 01/12] librte_pcapng: add new library for writing pcapng files

2021-09-13 Thread Stephen Hemminger
This is utility library for writing pcapng format files used by Wireshark family of utilities. Older tcpdump also knows how to read (but not write) this format. See draft RFC https://www.ietf.org/id/draft-tuexen-opsawg-pcapng-03.html and https://github.com/pcapng/pcapng/ Signed-off-by: Stephe

[dpdk-dev] [PATCH v8 00/12] Packet capture framework enhancements

2021-09-13 Thread Stephen Hemminger
This patch set is a more complete version of the the enhanced packet capture support described last year. The new capture library and utility are: - faster avoids lots of extra I/O, does bursting, etc. - gives more information (multiple ports, queues, etc) - has a better user interface (same

[dpdk-dev] [PATCH] crypto/mlx5: fix crypto QP indexing

2021-09-13 Thread Tal Shnaiderman
The crypto QP consumer (ci) and producer (pi) indexes are increased with each successful enqueue/dequeue operations. However the QP pi index is calculated with a wraparound the number of elements while the QP ci does not. This is causing incorrect engine calculation for encqueued WQ values (wq->p

Re: [dpdk-dev] [PATCH] net/af_packet: remove timestamp from packet status

2021-09-13 Thread Tudor Cornea
Thanks for the observation. I have removed the compile-time kernel version check in v2 of the patch On Mon, 13 Sept 2021 at 18:09, Stephen Hemminger wrote: > On Mon, 13 Sep 2021 17:09:11 +0300 > Tudor Cornea wrote: > > > +static inline bool tx_ring_status_unavailable(uint32_t tp_status) > > +

[dpdk-dev] [PATCH v2] net/af_packet: remove timestamp from packet status

2021-09-13 Thread Tudor Cornea
We should eliminate the timestamp status from the packet status. This should only matter if timestamping is enabled on the socket, but we might hit a kernel bug, which is fixed in newer releases. For interfaces of type 'veth', the sent skb is forwarded to the peer and back into the network stack w

Re: [dpdk-dev] [PATCH V2 01/24] pipeline: move data structures to internal header file

2021-09-13 Thread Dumitrescu, Cristian
> -Original Message- > From: Richardson, Bruce > Sent: Friday, September 10, 2021 3:09 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH V2 01/24] pipeline: move data structures to > internal header file > > On Fri, Sep 10, 2021 at 02:36:50PM +0100, Cri

Re: [dpdk-dev] [PATCH v3 6/6] bbdev: reduce warning level for one scenario

2021-09-13 Thread Chautru, Nicolas
> -Original Message- > From: Tom Rix > Sent: Sunday, September 12, 2021 5:55 AM > To: Chautru, Nicolas ; dev@dpdk.org; > gak...@marvell.com > Cc: tho...@monjalon.net; hemant.agra...@nxp.com; Zhang, Mingshan > ; Joshi, Arun > Subject: Re: [PATCH v3 6/6] bbdev: reduce warning level for one

Re: [dpdk-dev] [PATCH V3 01/24] pipeline: move data structures to internal header file

2021-09-13 Thread Stephen Hemminger
On Mon, 13 Sep 2021 17:44:20 +0100 Cristian Dumitrescu wrote: > Start to consolidate the data structures and inline functions required > by the pipeline instructions into an internal header file. > > Signed-off-by: Cristian Dumitrescu > --- > Depends-on: series-18297 ("[V4,1/4] table: add suppo

[dpdk-dev] [PATCH V3 24/24] pipeline: enable pipeline compilation

2021-09-13 Thread Cristian Dumitrescu
Commit the pipeline changes when the compilation process is successful: change the table lookup instructions to execute the action function for each action, replace the regular pipeline instructions with the custom instructions. Signed-off-by: Cristian Dumitrescu --- V3: -added more checks lib/

[dpdk-dev] [PATCH V3 23/24] pipeline: build shared object for pipeline

2021-09-13 Thread Cristian Dumitrescu
Build the generated C file into a shared object library. Signed-off-by: Cristian Dumitrescu Signed-off-by: Cunming Liang --- lib/pipeline/rte_swx_pipeline.c | 131 +++ lib/pipeline/rte_swx_pipeline_internal.h | 1 + 2 files changed, 132 insertions(+) diff --git a

[dpdk-dev] [PATCH V3 22/24] pipeline: generate custom instruction functions

2021-09-13 Thread Cristian Dumitrescu
Generate a C function for each custom instruction, which essentially consolidate multiple regular instructions into a single function call. The pipeline program is split into groups of instructions, and a custom instruction is generated for each group that has more than one instruction. Special car

[dpdk-dev] [PATCH V3 21/24] pipeline: generate action functions

2021-09-13 Thread Cristian Dumitrescu
Generate a C function for each action. For most instructions, the associated inline function is called directly. Special care is taken for TX, jump and return instructions. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 662 1 file chang

[dpdk-dev] [PATCH V3 20/24] pipeline: export pipeline instructions to file

2021-09-13 Thread Cristian Dumitrescu
Export the array of translated instructions to a C file. There is one such array per action and one for the pipeline. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 1093 +++ 1 file changed, 1093 insertions(+) diff --git a/lib/pipeline/rte_s

[dpdk-dev] [PATCH V3 19/24] pipeline: introduce pipeline compilation

2021-09-13 Thread Cristian Dumitrescu
Lay the foundation to generate C code for the pipeline: C functions for actions and custom instructions are generated, built as shared object library and loaded into the pipeline. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 44 + 1 fil

[dpdk-dev] [PATCH V3 18/24] pipeline: introduce custom instructions

2021-09-13 Thread Cristian Dumitrescu
For better performance, the option to create custom instructions when the program is translated and add them on-the-fly to the pipeline is now provided. Multiple regular instructions can now be consolidated into a single C function optimized by the C compiler directly. Signed-off-by: Cristian Dumi

[dpdk-dev] [PATCH V3 17/24] pipeline: introduce action functions

2021-09-13 Thread Cristian Dumitrescu
For better performance, the option to run a single function per action is now provided, which requires a single function call per action that can be better optimized by the C compiler, as opposed to one function call per instruction. Special table lookup instructions are added to to support this fe

[dpdk-dev] [PATCH V3 16/24] pipeline: enable persistent instruction meta-data

2021-09-13 Thread Cristian Dumitrescu
Save the instruction meta-data for later use instead of freeing it up once the instruction translation is completed. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 9 ++--- lib/pipeline/rte_swx_pipeline_internal.h | 2 ++ 2 files changed, 8 insertions(+), 3

[dpdk-dev] [PATCH V3 14/24] pipeline: create inline functions for meter instructions

2021-09-13 Thread Cristian Dumitrescu
Create inline functions for the meter instructions. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 457 +-- lib/pipeline/rte_swx_pipeline_internal.h | 541 +++ 2 files changed, 558 insertions(+), 440 deletions(-) diff --git

[dpdk-dev] [PATCH V3 15/24] pipeline: create inline functions for instruction operands

2021-09-13 Thread Cristian Dumitrescu
Create inline functions to get the instruction operands. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline_internal.h | 29 1 file changed, 29 insertions(+) diff --git a/lib/pipeline/rte_swx_pipeline_internal.h b/lib/pipeline/rte_swx_pipeline_interna

[dpdk-dev] [PATCH V3 13/24] pipeline: create inline functions for register instructions

2021-09-13 Thread Cristian Dumitrescu
Create inline functions for the register instructions. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 320 ++- lib/pipeline/rte_swx_pipeline_internal.h | 475 +++ 2 files changed, 502 insertions(+), 293 deletions(-) diff --git a

[dpdk-dev] [PATCH V3 12/24] pipeline: create inline functions for ALU instructions

2021-09-13 Thread Cristian Dumitrescu
Create inline functions for the ALU instructions. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 348 ++--- lib/pipeline/rte_swx_pipeline_internal.h | 616 +++ 2 files changed, 660 insertions(+), 304 deletions(-) diff --git a/lib/pi

[dpdk-dev] [PATCH V3 11/24] pipeline: create inline functions for DMA instruction

2021-09-13 Thread Cristian Dumitrescu
Create inline functions for the DMA instruction. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 80 ++ lib/pipeline/rte_swx_pipeline_internal.h | 100 +++ 2 files changed, 123 insertions(+), 57 deletions(-) diff --git a/lib

[dpdk-dev] [PATCH V3 10/24] pipeline: create inline functions for move instruction

2021-09-13 Thread Cristian Dumitrescu
Create inline functions for the move instruction. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 26 +++- lib/pipeline/rte_swx_pipeline_internal.h | 53 2 files changed, 58 insertions(+), 21 deletions(-) diff --git a/lib/pipeli

[dpdk-dev] [PATCH V3 09/24] pipeline: create inline functions for extern instruction

2021-09-13 Thread Cristian Dumitrescu
Create inline functions for the extern instruction. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 22 +++- lib/pipeline/rte_swx_pipeline_internal.h | 43 2 files changed, 47 insertions(+), 18 deletions(-) diff --git a/lib/pipe

[dpdk-dev] [PATCH V3 08/24] pipeline: create inline functions for learn instruction

2021-09-13 Thread Cristian Dumitrescu
Create inline functions for the learn and forget instructions. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 36 ++-- lib/pipeline/rte_swx_pipeline_internal.h | 55 2 files changed, 58 insertions(+), 33 deletions(-) diff -

[dpdk-dev] [PATCH V3 07/24] pipeline: create inline functions for validate instruction

2021-09-13 Thread Cristian Dumitrescu
Create inline functions for the validate and invalidate instructions. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 12 ++--- lib/pipeline/rte_swx_pipeline_internal.h | 32 2 files changed, 34 insertions(+), 10 deletions(-) diff -

[dpdk-dev] [PATCH V3 06/24] pipeline: create inline functions for emit instruction

2021-09-13 Thread Cristian Dumitrescu
Create inline functions for the emit instruction. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 162 - lib/pipeline/rte_swx_pipeline_internal.h | 170 +++ 2 files changed, 228 insertions(+), 104 deletions(-) diff --git

[dpdk-dev] [PATCH V3 05/24] pipeline: create inline functions for extract instruction

2021-09-13 Thread Cristian Dumitrescu
Create inline functions for the extract instruction. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 130 - lib/pipeline/rte_swx_pipeline_internal.h | 178 +++ 2 files changed, 203 insertions(+), 105 deletions(-) diff --git a

[dpdk-dev] [PATCH V3 04/24] pipeline: create inline functions for TX instruction

2021-09-13 Thread Cristian Dumitrescu
Create inline functions for the TX instruction. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 86 +- lib/pipeline/rte_swx_pipeline_internal.h | 90 2 files changed, 92 insertions(+), 84 deletions(-) diff --git a/li

[dpdk-dev] [PATCH V3 03/24] pipeline: create inline functions for RX instruction

2021-09-13 Thread Cristian Dumitrescu
Create inline functions for the RX instruction. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 38 -- lib/pipeline/rte_swx_pipeline_internal.h | 51 2 files changed, 51 insertions(+), 38 deletions(-) diff --git a/lib/pi

[dpdk-dev] [PATCH V3 02/24] pipeline: move thread inline functions to header file

2021-09-13 Thread Cristian Dumitrescu
Move the thread inline functions to the internal header file. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline.c | 56 -- lib/pipeline/rte_swx_pipeline_internal.h | 59 2 files changed, 59 insertions(+), 56 deletions(-) d

[dpdk-dev] [PATCH V3 01/24] pipeline: move data structures to internal header file

2021-09-13 Thread Cristian Dumitrescu
Start to consolidate the data structures and inline functions required by the pipeline instructions into an internal header file. Signed-off-by: Cristian Dumitrescu --- Depends-on: series-18297 ("[V4,1/4] table: add support learner tables") V3: -fixed meson.build lib/pipeline/rte_swx_pipeline.

[dpdk-dev] [PATCH v2 18/18] test: fix spelling errors in comments

2021-09-13 Thread Stephen Hemminger
Lots of little typos. Signed-off-by: Stephen Hemminger --- app/test/test_atomic.c | 2 +- app/test/test_barrier.c | 2 +- app/test/test_bpf.c | 2 +- app/test/test_compressdev.c | 2 +- app/test/test_func_reentrancy.c | 6 +++--- app/test/test_ipsec.c

[dpdk-dev] [PATCH v2 17/18] test-pmd: fix spelling errors in comments

2021-09-13 Thread Stephen Hemminger
More typos Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c | 2 +- app/test-pmd/config.c | 4 ++-- app/test-pmd/icmpecho.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 82253bc75110..2628bd64dae6 100644

[dpdk-dev] [PATCH v2 16/18] ip_frag: fix typos

2021-09-13 Thread Stephen Hemminger
Minor typos in comment. Signed-off-by: Stephen Hemminger --- lib/ip_frag/rte_ipv4_reassembly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ip_frag/rte_ipv4_reassembly.c b/lib/ip_frag/rte_ipv4_reassembly.c index 69666c8b8271..4a89a5f5365a 100644 --- a/lib/ip_frag/rte_

[dpdk-dev] [PATCH v2 15/18] vhost: fix typo in comment

2021-09-13 Thread Stephen Hemminger
Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/vhost/rte_vhost.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/vhost/rte_vhost.h b/lib/vhost/rte_vhost.h index 8d875e932297..c36dfc705b04 100644 --- a/lib/vhost/rte_vhost.h +++

[dpdk-dev] [PATCH v2 14/18] sched: fix typo in comment

2021-09-13 Thread Stephen Hemminger
Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/sched/rte_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index a858f61f9548..329f4b2e7b48 100644 --- a/lib/sched/rte_sched.c +++ b/li

[dpdk-dev] [PATCH v2 13/18] rib: fix typo in comment

2021-09-13 Thread Stephen Hemminger
Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/rib/rte_rib6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rib/rte_rib6.c b/lib/rib/rte_rib6.c index 96424e9c9f4f..4a6f29b0040d 100644 --- a/lib/rib/rte_rib6.c +++ b/lib/rib/rte_ri

[dpdk-dev] [PATCH v2 12/18] hash: fix typo in comment

2021-09-13 Thread Stephen Hemminger
Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/hash/rte_thash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/hash/rte_thash.c b/lib/hash/rte_thash.c index d5a95a6e009a..f5e9111f0264 100644 --- a/lib/hash/rte_thash.c +++ b/lib/ha

[dpdk-dev] [PATCH v2 11/18] pipeline: fix spellin error in comment

2021-09-13 Thread Stephen Hemminger
Minor typo Signed-off-by: Stephen Hemminger --- lib/pipeline/rte_swx_pipeline.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/pipeline/rte_swx_pipeline.h b/lib/pipeline/rte_swx_pipeline.h index cd395ac39dbb..9bfc69b2bb4f 100644 --- a/lib/pipeline/rte_swx_pipeline.h +++

[dpdk-dev] [PATCH v2 10/18] bbdev: fix typo in comment

2021-09-13 Thread Stephen Hemminger
Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/bbdev/rte_bbdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c index fc37236195be..49a0de49d8df 100644 --- a/lib/bbdev/rte_bbdev.c +++ b/li

[dpdk-dev] [PATCH v2 09/18] net: fix spelling error in gtp comment

2021-09-13 Thread Stephen Hemminger
More codespell finds. Signed-off-by: Stephen Hemminger --- lib/net/rte_gtp.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/net/rte_gtp.h b/lib/net/rte_gtp.h index 6a6f9b238db9..f22dbce47c65 100644 --- a/lib/net/rte_gtp.h +++ b/lib/net/rte_gtp.h @@ -64,9 +64,9 @@ s

[dpdk-dev] [PATCH v2 08/18] eal: fix typos in comments

2021-09-13 Thread Stephen Hemminger
Minor spelling errors. Signed-off-by: Stephen Hemminger --- lib/eal/include/rte_function_versioning.h | 2 +- lib/eal/windows/include/fnmatch.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/eal/include/rte_function_versioning.h b/lib/eal/include/rte_function

[dpdk-dev] [PATCH v2 07/18] acl: fix spelling errors

2021-09-13 Thread Stephen Hemminger
Lots of little typos in comments Signed-off-by: Stephen Hemminger --- lib/acl/acl.h | 4 ++-- lib/acl/acl_bld.c | 2 +- lib/acl/acl_run_avx2.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/acl/acl.h b/lib/acl/acl.h index 4089ab2a0462..f5739a475cf0 10064

[dpdk-dev] [PATCH v2 06/18] bpf: fix spelling in comments

2021-09-13 Thread Stephen Hemminger
Found by running codespell on the bpf implementation. Signed-off-by: Stephen Hemminger --- lib/bpf/bpf_jit_x86.c | 2 +- lib/bpf/bpf_load_elf.c | 2 +- lib/bpf/bpf_pkt.c | 2 +- lib/bpf/bpf_validate.c | 8 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/bpf/bpf_

[dpdk-dev] [PATCH v2 05/18] rcu: fix typo in comment

2021-09-13 Thread Stephen Hemminger
Another codespell find. Signed-off-by: Stephen Hemminger --- lib/rcu/rte_rcu_qsbr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h index 18811c1cc106..62a420a785fc 100644 --- a/lib/rcu/rte_rcu_qsbr.h +++ b/lib/rcu/rte_rcu_qsbr.

[dpdk-dev] [PATCH v2 04/18] power: fix typo in comment

2021-09-13 Thread Stephen Hemminger
More spelling errors caught by codespell Signed-off-by: Stephen Hemminger --- lib/power/power_acpi_cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/power/power_acpi_cpufreq.c b/lib/power/power_acpi_cpufreq.c index 1e8aeb84037c..402ed8c99b42 100644 --- a/lib/power

  1   2   >