Re: [dpdk-dev] [PATCH 0/2] support to clear in-flight packets for async

2021-09-15 Thread Xia, Chenbo
Hi Yuan, > -Original Message- > From: Wang, YuanX > Sent: Thursday, September 9, 2021 2:58 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; Pai G, > Sunil ; Hu, Jiayu ; Ding, Xuan > ; Jiang, Cheng1 ; Ma, WenwuX > ; Yang, YvonneX ; Wang, YuanX > > Subject: [PATCH 0/2]

Re: [dpdk-dev] [PATCH 1/2] vhost: support to clear in-flight packets for async dequeue

2021-09-15 Thread Xia, Chenbo
Hi Yuan, > -Original Message- > From: Wang, YuanX > Sent: Thursday, September 9, 2021 2:58 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; Pai G, > Sunil ; Hu, Jiayu ; Ding, Xuan > ; Jiang, Cheng1 ; Ma, WenwuX > ; Yang, YvonneX ; Wang, YuanX > > Subject: [PATCH 1/2]

Re: [dpdk-dev] [PATCH] vhost: add unsafe API to check inflight packets

2021-09-15 Thread Ding, Xuan
Hi Chenbo, > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, September 15, 2021 2:49 PM > To: Ding, Xuan ; dev@dpdk.org; > maxime.coque...@redhat.com > Cc: Hu, Jiayu ; cheng.ji...@intel.com; Richardson, Bruce > ; Pai G, Sunil > Subject: RE: [PATCH] vhost: add unsafe API to chec

Re: [dpdk-dev] [PATCH] net/bonding: fix memory leak on closing device

2021-09-15 Thread Yu, DapengX
> -Original Message- > From: Min Hu (Connor) > Sent: Wednesday, September 15, 2021 2:59 PM > To: Yu, DapengX ; Chas Williams > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH] net/bonding: fix memory leak on closing device > > Hi, dapengx, > Why not free internals->kvlis

Re: [dpdk-dev] [PATCH 2/2] vhost: support thread-safe API for clearing in-flight packets in async vhost

2021-09-15 Thread Xia, Chenbo
Hi Yuan, > -Original Message- > From: Wang, YuanX > Sent: Thursday, September 9, 2021 2:58 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; Pai G, > Sunil ; Hu, Jiayu ; Ding, Xuan > ; Jiang, Cheng1 ; Ma, WenwuX > ; Yang, YvonneX ; Wang, YuanX > > Subject: [PATCH 2/2]

Re: [dpdk-dev] [PATCH] net/softnic: remove experimental table from API

2021-09-15 Thread Ferruh Yigit
On 9/1/2021 2:48 PM, Kinsella, Ray wrote: > > > On 01/09/2021 13:20, Jasvinder Singh wrote: >> This API was introduced in 18.08, therefore removing >> experimental tag to promote it to stable state. >> >> Signed-off-by: Jasvinder Singh >> --- >> drivers/net/softnic/rte_eth_softnic.h | 1 - >> d

Re: [dpdk-dev] [PATCH] net/bnxt: fix Rx queue startup state

2021-09-15 Thread Ajit Khaparde
On Tue, Sep 14, 2021 at 5:51 AM Lance Richardson wrote: > > Since the addition of support for runtime queue setup, > receive queues that are started by default no longer > have the correct state. Fix this by setting the state > when a port is started. > > Fixes: 0105ea1296c9 ("net/bnxt: support ru

Re: [dpdk-dev] [PATCH] config/ppc: fix build with GCC >= 10

2021-09-15 Thread Ferruh Yigit
On 9/15/2021 6:08 AM, David Marchand wrote: > Like for python, multiline statements in meson must either use a > backslash character (explicit continuation) or be enclosed in () > (implicit continuation). > > python PEP8 recommends the latter [1], and it looks like meson had > an issue with backsl

Re: [dpdk-dev] [PATCH] net/bonding: fix memory leak on closing device

2021-09-15 Thread Min Hu (Connor)
Acked-by: Min Hu (Connor) 在 2021/9/15 15:18, Yu, DapengX 写道: -Original Message- From: Min Hu (Connor) Sent: Wednesday, September 15, 2021 2:59 PM To: Yu, DapengX ; Chas Williams Cc: dev@dpdk.org; sta...@dpdk.org Subject: Re: [PATCH] net/bonding: fix memory leak on closing device H

Re: [dpdk-dev] [PATCH] ethdev: promote set ptypes API to stable

2021-09-15 Thread Ferruh Yigit
On 9/2/2021 4:56 PM, Kinsella, Ray wrote: > > > On 02/09/2021 09:17, pbhagavat...@marvell.com wrote: >> From: Pavan Nikhilesh >> >> Remove experimental tag from rte_eth_dev_set_ptypes(). >> >> Signed-off-by: Pavan Nikhilesh > Acked-by: Ray Kinsella > Applied to dpdk-next-net/main, thanks.

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/af_xdp: fix support of secondary process

2021-09-15 Thread Ferruh Yigit
On 9/3/2021 5:15 PM, Stephen Hemminger wrote: > Doing basic operations like info_get or get_stats was broken > in af_xdp PMD. The info_get would crash because dev->device > was NULL in secondary process. Fix this by doing same initialization > as af_packet and tap devices. > > The get_stats would

Re: [dpdk-dev] [PATCH] net/i40e/base: fix the resource leakage problem

2021-09-15 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of > chenqiming_hua...@163.com > Sent: Saturday, August 21, 2021 2:30 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Qiming Chen > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/i40e/base: fix the resource leakage problem > > From: Qiming Che

Re: [dpdk-dev] [PATCH] net/i40e: fix vf resource leakage problem

2021-09-15 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, September 15, 2021 9:27 AM > To: 'chenqiming_hua...@163.com' ; > dev@dpdk.org > Cc: Xing, Beilei ; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/i40e: fix vf resource leakage problem > > > > > -Original Message---

Re: [dpdk-dev] [PATCH v3] telemetry: add support for dicts of dicts

2021-09-15 Thread Power, Ciara
Hi Radu, >-Original Message- >From: Nicolau, Radu >Sent: Tuesday 14 September 2021 17:05 >To: Power, Ciara >Cc: dev@dpdk.org; Richardson, Bruce ; Nicolau, >Radu ; Doherty, Declan > >Subject: [PATCH v3] telemetry: add support for dicts of dicts > >Add support for dicts of dicts to telemet

Re: [dpdk-dev] [PATCH 2/2] net/cnxk: callback for getting link status

2021-09-15 Thread Nithin Kumar Dabilpuram
Acked-by: Nithin Dabilpuram On 7/30/21 9:38 PM, Harman Kalra wrote: Adding a new callback for reading the link status. PF can read it's link status and can forward the same to VF once it comes up. Signed-off-by: Harman Kalra --- drivers/net/cnxk/cnxk_ethdev.c | 9 + drivers/net/

[dpdk-dev] [PATCH v2 0/2] i40e Rx descriptor loads ordering

2021-09-15 Thread Ruifeng Wang
On Rx path, NIC fills Rx descriptor with data pertains to received packet. A single descriptor consists of multiple words. Word1 has the bit that indicates readiness of descriptor for software to use. So word1 should be loaded before other words. On architectures with weaker memory ordering, barr

[dpdk-dev] [PATCH v2 1/2] net/i40e: fix risk in Rx descriptor read in NEON vector path

2021-09-15 Thread Ruifeng Wang
Rx descriptor is 16B/32B in size. If the DD bit is set, it indicates that the rest of the descriptor words have valid values. Hence, the word containing DD bit must be read first before reading the rest of the descriptor words. In NEON vector PMD, vector load loads two contiguous 8B of descriptor

[dpdk-dev] [PATCH v2 2/2] net/i40e: fix risk in Rx descriptor read in scalar path

2021-09-15 Thread Ruifeng Wang
Rx descriptor is 16B/32B in size. If the DD bit is set, it indicates that the rest of the descriptor words have valid values. Hence, the word containing DD bit must be read first before reading the rest of the descriptor words. Since the entire descriptor is not read atomically, on relaxed memory

Re: [dpdk-dev] [PATCH v1] lib/ethdev: fix a typo in ethdev comment

2021-09-15 Thread Ferruh Yigit
On 9/6/2021 3:13 AM, Joyce Kong wrote: > Fix a typo that mb_pool was misspelt as mp_pool. > > Fixes: 4ff702b5dfa9 ("ethdev: introduce Rx buffer split") > Cc: Viacheslav Ovsiienko > Cc: sta...@dpdk.org > > Signed-off-by: Joyce Kong > Reviewed-by: Ruifeng Wang Acked-by: Ferruh Yigit Applied t

Re: [dpdk-dev] [PATCH v2] Warns if IPv4, UDP or TCP checksum offload not available

2021-09-15 Thread Ananyev, Konstantin
> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, September 15, 2021 12:44 AM > To: Ananyev, Konstantin > Cc: Usama Nadeem ; tho...@monjalon.net; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] Warns if IPv4, UDP or TCP checksum offload > not available > > On Tue, 1

Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix risk in Rx descriptor read in NEON vector path

2021-09-15 Thread Ruifeng Wang
> -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, September 15, 2021 2:33 AM > To: Ruifeng Wang ; dev@dpdk.org > Cc: beilei.x...@intel.com; qi.z.zh...@intel.com; > bruce.richard...@intel.com; jer...@marvell.com; > hemant.agra...@nxp.com; d...@linux.vnet.ibm.com; sta...@d

[dpdk-dev] [Bug 810] driver i40e: pci can't been probed。

2021-09-15 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=810 Bug ID: 810 Summary: driver i40e: pci can't been probed。 Product: DPDK Version: 21.11 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: major Priori

Re: [dpdk-dev] [PATCH 1/5] net/virtio: implement rte_power_monitor API

2021-09-15 Thread Xia, Chenbo
Hi Miao, > -Original Message- > From: Li, Miao > Sent: Friday, September 10, 2021 9:06 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Li, Miao > > Subject: [PATCH 1/5] net/virtio: implement rte_power_monitor API > > This patch implements rte_power_monitor API in v

Re: [dpdk-dev] [PATCH v2] ethdev: promote burst mode API to stable

2021-09-15 Thread Ferruh Yigit
On 9/6/2021 7:36 AM, Andrew Rybchenko wrote: > On 9/6/21 8:56 AM, Haiyue Wang wrote: >> The DPDK Symbol Bot reports: >> Please note the symbols listed below have expired. In line with the >> DPDK ABI policy, they should be scheduled for removal, in the next >> DPDK release. >> >> Symbol >> rte_eth_

Re: [dpdk-dev] [PATCH 2/5] lib/vhost: implement rte_power_monitor API

2021-09-15 Thread Xia, Chenbo
Hi Miao, > -Original Message- > From: Li, Miao > Sent: Friday, September 10, 2021 9:06 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Li, Miao > > Subject: [PATCH 2/5] lib/vhost: implement rte_power_monitor API Should be 'vhost: implement rte_power_monitor API' >

[dpdk-dev] [PATCH v2 v2] vhost: add unsafe API to check inflight packets

2021-09-15 Thread Xuan Ding
In async data path, when vring state changes, it is necessary to know the number of inflight packets in DMA engine. This patch provides a thread unsafe API to return the number of inflight packets without using any lock. Signed-off-by: Xuan Ding --- v2: * Fixed some format issues. --- doc/guide

Re: [dpdk-dev] [PATCH] config/ppc: fix build with GCC >= 10

2021-09-15 Thread Bruce Richardson
On Wed, Sep 15, 2021 at 09:14:34AM +0100, Ferruh Yigit wrote: > On 9/15/2021 6:08 AM, David Marchand wrote: > > Like for python, multiline statements in meson must either use a > > backslash character (explicit continuation) or be enclosed in () > > (implicit continuation). > > > > python PEP8 rec

Re: [dpdk-dev] [PATCH 2/2] net/virtio: fix Tx completed mbufs leak on device stop

2021-09-15 Thread Andrew Rybchenko
On 9/13/21 6:41 PM, Maxime Coquelin wrote: > > > On 8/18/21 4:13 PM, Andrew Rybchenko wrote: >> From: Ivan Ilchenko >> >> Free Tx completed mbufs on device stop. Not completed Tx mbufs cannot be >> freed since they are still in use. >> >> Fixes: c1f86306a02 ("virtio: add new driver") >> Cc: sta.

[dpdk-dev] [PATCH v2 1/2] net/virtio: fix Tx cleanup functions to have same signature

2021-09-15 Thread Andrew Rybchenko
From: Ivan Ilchenko There is a family of cleanup from completed transmits functions. Fix packed virtqueues cleanup functions to have the same signature as split virtqueues have. This lets all functions of the family to match the same callback prototype. Fixes: 892dc798fa9 ("net/virtio: implement

[dpdk-dev] [PATCH v2 2/2] net/virtio: fix Tx completed mbufs leak on device stop

2021-09-15 Thread Andrew Rybchenko
From: Ivan Ilchenko Free Tx completed mbufs on device stop. Not completed Tx mbufs cannot be freed since they are still in use. Fixes: c1f86306a02 ("virtio: add new driver") Cc: sta...@dpdk.org Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- v2: - check vq pointer vs NULL

Re: [dpdk-dev] [PATCH] net/virtio: wait device ready in device reset

2021-09-15 Thread Xueming(Steven) Li
On Thu, 2021-08-26 at 07:15 +, Xia, Chenbo wrote: > Hi Adrew & Xueming, > > > -Original Message- > > From: Andrew Rybchenko > > Sent: Tuesday, August 24, 2021 11:41 PM > > To: Xueming(Steven) Li > > Cc: dev@dpdk.org; Maxime Coquelin ; Xia, Chenbo > > > > Subject: Re: [dpdk-dev] [PAT

Re: [dpdk-dev] [PATCH v1] net/virtio: wait device ready during reset

2021-09-15 Thread Andrew Rybchenko
On 9/15/21 12:21 PM, Xueming Li wrote: > According to virtio spec, the device MUST reset when 0 is written to > device_status, and present 0 in device_status once reset is done. > > This patch waits status value to be 0 during reset operation, if > timeout in 3 seconds, log and continue. I have n

Re: [dpdk-dev] [RFC 0/7] hide eth dev related structures

2021-09-15 Thread Jerin Jacob
On Tue, Sep 14, 2021 at 7:03 PM Ananyev, Konstantin wrote: > > > Hi Jerin, > > > > NOTE: This is just an RFC to start further discussion and collect the > > > feedback. > > > Due to significant amount of work, changes required are applied only to > > > two > > > PMDs so far: net/i40e and net/ice

Re: [dpdk-dev] [PATCH] ethdev: promote sibling iterators to stable

2021-09-15 Thread Ferruh Yigit
On 9/8/2021 9:54 AM, Kinsella, Ray wrote: > > > On 06/09/2021 15:19, Andrew Rybchenko wrote: >> On 9/6/21 4:02 PM, David Marchand wrote: >>> This API saw no update since its introduction and will help applications >>> like OVS ([1] and [2]) that currently look at rte_eth_devices[] to >>> achieve

[dpdk-dev] [PATCH] doc/contributing: add line continuation note to meson guide

2021-09-15 Thread Bruce Richardson
Add a note for the preference of using "()" rather than "\" for line continuations in meson. Suggested-by: David Marchand Signed-off-by: Bruce Richardson --- doc/guides/contributing/coding_style.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/doc/guides/contributing/coding_s

[dpdk-dev] [PATCH] eal: add telemetry callbacks for memory info

2021-09-15 Thread Harman Kalra
Registering new telemetry callbacks to dump named (memzones) and unnamed (malloc) memory information to a file provided as an argument. Example: Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2 {"version": "DPDK 21.08.0", "pid": 34075, "max_output_len": 16384} Connected to application: "dpdk-test

Re: [dpdk-dev] [PATCH 1/3] usertools/dpdk-telemetry: fix flake8 errors

2021-09-15 Thread Kevin Laatz
On 13/09/2021 11:51, Bruce Richardson wrote: Fix style errors reported by flake8. Fixes: 6a2967c112a3 ("usertools: add new telemetry script") Fixes: 2d9a697e41ca ("usertools: add file-prefix option for telemetry") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- usertools/dpdk-telemet

Re: [dpdk-dev] [PATCH v3 04/17] dma/idxd: add bus device probing

2021-09-15 Thread Maxime Coquelin
Hi Kevin, On 9/8/21 12:30 PM, Kevin Laatz wrote: > Add the basic device probing for DSA devices bound to the IDXD kernel > driver. These devices can be configured via sysfs and made available to > DPDK if they are found during bus scan. Relevant documentation is included. > > Signed-off-by: Bruce

Re: [dpdk-dev] [PATCH v4] app/testpmd: add option to display extended statistics

2021-09-15 Thread Ivan Ilchenko
On 9/2/21 7:08 PM, Ferruh Yigit wrote: On 8/20/2021 2:55 PM, Andrew Rybchenko wrote: From: Ivan Ilchenko Add 'display-xstats' option for using in accompanying with Rx/Tx statistics (i.e. 'stats-period' option or 'show port stats' interactive command) to display specified list of extended sta

Re: [dpdk-dev] [PATCH v2] net/virtio: wait device ready during reset

2021-09-15 Thread Andrew Rybchenko
On 9/15/21 1:12 PM, Xueming Li wrote: > According to virtio spec, the device MUST reset when 0 is written to > device_status, and present 0 in device_status once reset is done. > > This patch waits status value to be 0 during reset operation, if > timeout in 3 seconds, log and continue. > > Signe

[dpdk-dev] OpenSSL 3.0 released, deprecated functions - DPDK crypto compilation issues

2021-09-15 Thread Kusztal, ArkadiuszX
Hi, OpenSSL 3.0 is now released and since some PMDs in DPDK depends on libcrypto deprecated now functions, anyone who install 3.0 may see compilation problems. So we suggest in case adaptation cannot be made in time to put version constraint in meson dependencies "version : '<3.0.0'", it probabl

Re: [dpdk-dev] [PATCH v4] net: fix Intel-specific Prepare the outer IPv4 hdr for checksum

2021-09-15 Thread Ferruh Yigit
On 9/7/2021 11:49 AM, Mohsin Kazmi wrote: > Preparation of the headers for the hardware offload > misses the outer IPv4 checksum offload. > It results in bad checksum computed by hardware NIC. > > This patch fixes the issue by setting the outer IPv4 > checksum field to 0. > > Fixes: 4fb7e803eb1a

[dpdk-dev] [PATCH] net/sfc: fix getting accumulative SW xstat

2021-09-15 Thread Andrew Rybchenko
From: Ivan Ilchenko Add missing initialisation of the accumulative SW xstat to zero since it is sum of per-queue xstats. Fixes: fdd7719eb3c ("net/sfc: add xstats for Rx/Tx doorbells") Cc: sta...@dpdk.org Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_sw_

Re: [dpdk-dev] [PATCH 0/3] improvements for telemetry script

2021-09-15 Thread Power, Ciara
Hi Bruce, >-Original Message- >From: Richardson, Bruce >Sent: Monday 13 September 2021 11:52 >To: dev@dpdk.org >Cc: Power, Ciara ; Hunt, David >; Richardson, Bruce >Subject: [PATCH 0/3] improvements for telemetry script > >Patch 1 fixes errors reported by flake8 in the telemetry python s

Re: [dpdk-dev] [PATCH v1] usertools/telemetry: add non-interactive mode

2021-09-15 Thread Power, Ciara
Hi Dave, >-Original Message- >From: Richardson, Bruce >Sent: Monday 13 September 2021 11:54 >To: Hunt, David >Cc: dev@dpdk.org; Power, Ciara >Subject: Re: [dpdk-dev] [PATCH v1] usertools/telemetry: add non-interactive >mode > >On Mon, Sep 13, 2021 at 11:43:25AM +0100, Bruce Richardson w

Re: [dpdk-dev] OpenSSL 3.0 released, deprecated functions - DPDK crypto compilation issues

2021-09-15 Thread Akhil Goyal
Hi Arek, Can you submit changes for the meson files needed to compile it with 3.0 if needed? Regards, Akhil From: Kusztal, ArkadiuszX Sent: Wednesday, September 15, 2021 4:02 PM To: dev@dpdk.org Cc: Akhil Goyal ; asoma...@amd.com; Zhang, Roy Fan ; Doherty, Declan Subject: [EXT] OpenSSL 3.0 r

Re: [dpdk-dev] [PATCH v8 03/12] bpf: allow self-xor operation

2021-09-15 Thread Ananyev, Konstantin
> When doing BPF filter program conversion, a common way > to zero a register in single instruction is: > xor r7,r7 > The BPF validator would not allow this because the value of > r7 was undefined. But after this operation it always zero. > > Signed-off-by: Stephen Hemminger > --- > lib/

Re: [dpdk-dev] [PATCH v1] usertools/telemetry: add non-interactive mode

2021-09-15 Thread David Hunt
On 15/9/2021 11:49 AM, Power, Ciara wrote: Hi Dave, -Original Message- From: Richardson, Bruce Sent: Monday 13 September 2021 11:54 To: Hunt, David Cc: dev@dpdk.org; Power, Ciara Subject: Re: [dpdk-dev] [PATCH v1] usertools/telemetry: add non-interactive mode On Mon, Sep 13, 2021

Re: [dpdk-dev] [PATCH v8 04/12] bpf: add function to convert classic BPF to DPDK BPF

2021-09-15 Thread Ananyev, Konstantin
> > The pcap library emits classic BPF (32 bit) and is useful for > creating filter programs. The DPDK BPF library only implements > extended BPF (eBPF). Add an function to convert from old to > new. > > The rte_bpf_convert function uses rte_malloc to put the resulting > program in hugepage

Re: [dpdk-dev] [PATCH v4] net: fix Intel-specific Prepare the outer IPv4 hdr for checksum

2021-09-15 Thread Ferruh Yigit
On 9/7/2021 11:49 AM, Mohsin Kazmi wrote: > Preparation of the headers for the hardware offload > misses the outer IPv4 checksum offload. > It results in bad checksum computed by hardware NIC. > > This patch fixes the issue by setting the outer IPv4 > checksum field to 0. > > Fixes: 4fb7e803eb1a

Re: [dpdk-dev] [PATCH v8 05/12] bpf: add function to dump eBPF instructions

2021-09-15 Thread Ananyev, Konstantin
> When debugging converted (and other) programs it is useful > to see disassembled eBPF output. > > Signed-off-by: Stephen Hemminger > --- > lib/bpf/bpf_convert.c | 7 ++- > lib/bpf/bpf_dump.c| 118 ++ > lib/bpf/meson.build | 1 + > lib/bpf/rt

Re: [dpdk-dev] [PATCH v3 04/17] dma/idxd: add bus device probing

2021-09-15 Thread Bruce Richardson
On Wed, Sep 15, 2021 at 12:12:34PM +0200, Maxime Coquelin wrote: > Hi Kevin, > > On 9/8/21 12:30 PM, Kevin Laatz wrote: > > Add the basic device probing for DSA devices bound to the IDXD kernel > > driver. These devices can be configured via sysfs and made available to > > DPDK if they are found d

Re: [dpdk-dev] [PATCH v8 10/12] test: enable bpf autotest

2021-09-15 Thread Ananyev, Konstantin
> The BPF autotest is defined but not run automatically. > Since it is short, it should be added to the autotest suite. > > Signed-off-by: Stephen Hemminger > --- > app/test/meson.build | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/app/test/meson.build b/app/test/meson.build > i

[dpdk-dev] [PATCH v5] app/testpmd: add option to display extended statistics

2021-09-15 Thread Andrew Rybchenko
From: Ivan Ilchenko Add 'display-xstats' option for using in accompanying with Rx/Tx statistics (i.e. 'stats-period' option or 'show port stats' interactive command) to display specified list of extended statistics. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko Acked-by: Ajit Kh

Re: [dpdk-dev] [PATCH v8 08/12] test: add test for bpf_convert

2021-09-15 Thread Ananyev, Konstantin
> > Add some functional tests for the Classic BPF to DPDK BPF converter. > > Signed-off-by: Stephen Hemminger > --- > app/test/test_bpf.c | 173 > 1 file changed, 173 insertions(+) > > diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c > inde

Re: [dpdk-dev] [PATCH 1/4] vhost: support async dequeue for split ring

2021-09-15 Thread Xia, Chenbo
Hi Maxime & Yuan, > -Original Message- > From: Wang, YuanX > Sent: Wednesday, September 15, 2021 5:09 PM > To: Xia, Chenbo ; Ma, WenwuX ; > dev@dpdk.org > Cc: maxime.coque...@redhat.com; Jiang, Cheng1 ; Hu, > Jiayu ; Pai G, Sunil ; Yang, > YvonneX ; Wang, Yinan > Subject: RE: [PATCH 1/4]

Re: [dpdk-dev] [PATCH v2] net/virtio: wait device ready during reset

2021-09-15 Thread Xia, Chenbo
> -Original Message- > From: Xueming Li > Sent: Wednesday, September 15, 2021 6:12 PM > To: dev@dpdk.org > Cc: xuemi...@nvidia.com; Andrew Rybchenko ; > Maxime Coquelin ; Xia, Chenbo > > Subject: [PATCH v2] net/virtio: wait device ready during reset > > According to virtio spec, the devi

Re: [dpdk-dev] OpenSSL 3.0 released, deprecated functions - DPDK crypto compilation issues

2021-09-15 Thread Kusztal, ArkadiuszX
Sure Akhil, will do some more testing and will send (unless some better proposal come in). It needs to be backported as well. From: Akhil Goyal Sent: Wednesday, September 15, 2021 12:51 PM To: Kusztal, ArkadiuszX ; dev@dpdk.org Cc: asoma...@amd.com; Zhang, Roy Fan ; Doherty, Declan Subject: RE

[dpdk-dev] [PATCH v2] eal: add additional info if lcore exceeds max cores

2021-09-15 Thread David Hunt
If the user requests to use an lcore above 128 using -l or -c, the eal will exit with "EAL: invalid core list syntax" and very little other useful information. This patch adds some extra information suggesting to use --lcores so that physical cores above RTE_MAX_LCORE (default 128) can be used. Th

Re: [dpdk-dev] [PATCH v1 1/6] build: increase default of max lcores to 512

2021-09-15 Thread David Hunt
On 14/9/2021 12:29 PM, David Marchand wrote: On Tue, Sep 14, 2021 at 1:07 PM David Hunt wrote: “ERROR: logical core 212 is above the maximum lcore number permitted. Please use the --lcores option to map lcores onto physical cores, e.g. --lcores="(0-3)@(212-215).” If you could directly provid

[dpdk-dev] [PATCH] net/virtio: report max/min/align Tx desc limits in dev info

2021-09-15 Thread Andrew Rybchenko
From: Ivan Ilchenko Report max/min/align Tx descriptors limits in device info get callback. Before calling the callback, rte_eth_dev_info_get() provides default values of nb_min as zero and nb_max as UINT16_MAX that are not correct for the driver, so one can't rely on them. Signed-off-by: Ivan I

[dpdk-dev] [PATCH v14] eventdev: simplify Rx adapter event vector config

2021-09-15 Thread pbhagavatula
From: Pavan Nikhilesh Include vector configuration into the structure ``rte_event_eth_rx_adapter_queue_conf`` that is used to configure Rx adapter ethernet device Rx queue parameters. This simplifies event vector configuration as it avoids splitting configuration per Rx queue. Signed-off-by: Pav

Re: [dpdk-dev] [PATCH v14] eventdev: simplify Rx adapter event vector config

2021-09-15 Thread Kinsella, Ray
On 15/09/2021 14:15, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Include vector configuration into the structure > ``rte_event_eth_rx_adapter_queue_conf`` that is used to configure > Rx adapter ethernet device Rx queue parameters. > This simplifies event vector configuration as

[dpdk-dev] [PATCH v1] net/virtio: wait device ready during reset

2021-09-15 Thread Xueming Li
According to virtio spec, the device MUST reset when 0 is written to device_status, and present 0 in device_status once reset is done. This patch waits status value to be 0 during reset operation, if timeout in 3 seconds, log and continue. Signed-off-by: Xueming Li Cc: Andrew Rybchenko --- dri

Re: [dpdk-dev] [PATCH 02/32] net/ngbe: support scattered Rx

2021-09-15 Thread Ferruh Yigit
On 9/8/2021 9:37 AM, Jiawen Wu wrote: > Add scattered Rx function to support receiving segmented mbufs. > > Signed-off-by: Jiawen Wu > --- > doc/guides/nics/features/ngbe.ini | 1 + > doc/guides/nics/ngbe.rst | 1 + > drivers/net/ngbe/ngbe_ethdev.c| 20 +- > drivers/net/ngbe/ng

[dpdk-dev] [PATCH v2 0/4] iavf: add iAVF IPsec inline crypto support

2021-09-15 Thread Radu Nicolau
Add support for inline crypto for IPsec, for ESP transport and tunnel over IPv4 and IPv6, as well as supporting the offload for ESP over UDP, and inconjunction with TSO for UDP and TCP flows. Radu Nicolau (4): common/iavf: add iAVF IPsec inline crypto support net/iavf: add iAVF IPsec inline cr

[dpdk-dev] [PATCH v2 1/4] common/iavf: add iAVF IPsec inline crypto support

2021-09-15 Thread Radu Nicolau
Add support for inline crypto for IPsec. Signed-off-by: Declan Doherty Signed-off-by: Abhijit Sinha Signed-off-by: Radu Nicolau --- drivers/common/iavf/iavf_type.h | 215 +++- drivers/common/iavf/virtchnl.h | 17 +- drivers/common/iavf/virtchnl_inline_ipsec.h | 55

[dpdk-dev] [PATCH v2 2/4] net/iavf: add iAVF IPsec inline crypto support

2021-09-15 Thread Radu Nicolau
Add support for inline crypto for IPsec, for ESP transport and tunnel over IPv4 and IPv6, as well as supporting the offload for ESP over UDP, and inconjunction with TSO for UDP and TCP flows. Implement support for rte_security packet metadata Add definition for IPsec descriptors, extend support fo

[dpdk-dev] [PATCH v2 3/4] net/iavf: Add xstats support for inline IPsec crypto

2021-09-15 Thread Radu Nicolau
Add per queue counters for maintaining statistics for inline IPsec crypto offload, which can be retrieved through the rte_security_session_stats_get() with more detailed errors through the rte_ethdev xstats. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf.h

[dpdk-dev] [PATCH v2 4/4] net/iavf: add watchdog for VFLR

2021-09-15 Thread Radu Nicolau
Add watchdog to iAVF PMD which support monitoring the VFLR register. If the device is not already in reset then if a VF reset in progress is detected then notfiy user through callback and set into reset state. If the device is already in reset then poll for completion of reset. Signed-off-by: Decl

[dpdk-dev] [PATCH v3] app/testpmd: add command to print representor info

2021-09-15 Thread Andrew Rybchenko
From: Viacheslav Galaktionov Make it simpler to debug configurations and code related to the representor info API. Signed-off-by: Viacheslav Galaktionov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Xueming(Steven) Li --- v3: - change command to "show port info (

Re: [dpdk-dev] [PATCH v2] app/testpmd: add command to print representor info

2021-09-15 Thread Andrew Rybchenko
On 9/14/21 7:36 PM, Ferruh Yigit wrote: > On 9/14/2021 5:17 PM, Andrew Rybchenko wrote: >> On 9/14/21 6:52 PM, Ferruh Yigit wrote: >>> On 8/31/2021 5:12 PM, Andrew Rybchenko wrote: From: Viacheslav Galaktionov Make it simpler to debug configurations and code related to the represent

Re: [dpdk-dev] [PATCH v21 4/7] dmadev: introduce DMA device library implementation

2021-09-15 Thread Kevin Laatz
On 07/09/2021 13:56, Chengwen Feng wrote: This patch introduce DMA device library implementation which includes configuration and I/O with the DMA devices. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup Reviewed-by: Kevin Laatz Reviewed-by: Conor Walsh ---

[dpdk-dev] logs about hugepages detection

2021-09-15 Thread Thomas Monjalon
Hi, I would like to discuss some issues in logging of hugepage lookup. The issues to be discussed will be enumerated and numbered below. I will take an example of an x86 machine with 2M and 1G pages. I reserve only 2M pages: usertools/dpdk-hugepages.py -p 2M -r 80M If I start a DPDK appl

[dpdk-dev] [PATCH v2 0/9] IPsec Sec GW new features

2021-09-15 Thread Radu Nicolau
Update the IPsec sample app with new features and updates: - egress TSO support - telemetry support - add reset callback - stats screen configurable as a command line parameter - UDP encapsulation support for inline crypto - ESN with configurable start value Depends on series 18837 ('new features

[dpdk-dev] [PATCH v2 1/9] examples/ipsec-secgw: update create inline session

2021-09-15 Thread Radu Nicolau
Rework create inline session function as to update the session configuration parameters before create session is called. Also updated the rss key array size to prevent buffers overflows with PMDs that copy more than 40 bytes. Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/ipsec.c | 56

[dpdk-dev] [PATCH v2 2/9] examples/ipsec-secgw: update SA parameters with L3 options

2021-09-15 Thread Radu Nicolau
Set the L3 offset and L3 length in the SA parameters Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/sa.c | 4 1 file changed, 4 insertions(+) diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c index 17a28556c9..7fb8fef264 100644 --- a/examples/ipsec-secgw/sa.c +++ b/e

[dpdk-dev] [PATCH v2 3/9] examples/ipsec-secgw: add support for telemetry

2021-09-15 Thread Radu Nicolau
Add telemetry support to the IPsec GW sample app Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau --- doc/guides/sample_app_ug/ipsec_secgw.rst | 11 + examples/ipsec-secgw/ipsec-secgw.c | 365 ++- examples/ipsec-secgw/ipsec-secgw.h | 33 +- examples/ip

[dpdk-dev] [PATCH v2 4/9] examples/ipsec-secgw: add stats interval argument

2021-09-15 Thread Radu Nicolau
Add -t for stats screen update interval, disabled by default. Signed-off-by: Radu Nicolau --- doc/guides/sample_app_ug/ipsec_secgw.rst | 5 examples/ipsec-secgw/ipsec-secgw.c | 29 examples/ipsec-secgw/ipsec-secgw.h | 15 3 files changed, 2

[dpdk-dev] [PATCH v2 5/9] examples/ipsec-secgw: add support for TSO

2021-09-15 Thread Radu Nicolau
Add support to allow user to specific MSS for TSO offload on a per SA basis. MSS configuration in the context of IPsec is only supported for outbound SA's in the context of an inline IPsec Crypto offload. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau --- doc/guides/sample_app_ug/ips

[dpdk-dev] [PATCH v2 6/9] examples/ipsec-secgw: add support for defining initial sequence number value

2021-09-15 Thread Radu Nicolau
Add esn field to SA definition block to allow initial ESN value Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau --- doc/guides/sample_app_ug/ipsec_secgw.rst | 10 ++ examples/ipsec-secgw/ipsec.c | 5 + examples/ipsec-secgw/ipsec.h | 1 + examples/

[dpdk-dev] [PATCH v2 7/9] examples/ipsec-secgw: add ethdev reset callback

2021-09-15 Thread Radu Nicolau
Add event handler for ethdev reset callback Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/ipsec-secgw.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index 60b25be

[dpdk-dev] [PATCH v2 8/9] examples/ipsec-secgw: add support for additional algorithms

2021-09-15 Thread Radu Nicolau
Add support for AES-GMAC, AES_CTR, AES_XCBC_MAC, AES_CCM, CHACHA20_POLY1305 Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/ipsec.h | 3 +- examples/ipsec-secgw/sa.c| 133 --- 2 files changed, 126 insertions(+), 10 deletio

[dpdk-dev] [PATCH v2 9/9] examples/ipsec-secgw: add support for inline crypto UDP encapsulation

2021-09-15 Thread Radu Nicolau
Enable UDP encapsulation for both transport and tunnel modes for the inline crypto offload path. Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/ipsec.c | 34 -- examples/ipsec-secgw/ipsec.h | 7 +- examples/ipsec-secgw/sa.c| 123 --- 3 files c

Re: [dpdk-dev] [PATCH] build: fix building when essential drivers in disable list

2021-09-15 Thread Thomas Monjalon
09/09/2021 15:38, Nicolau, Radu: > On 8/18/2021 2:42 PM, Bruce Richardson wrote: > > The PCI and vdev bus drivers cannot be disabled for DPDK builds and > > special logic is put in place to not skip them when they are specified > > in the disable list. This logic is broken though, as the inclusion

[dpdk-dev] [PATCH] telemetry: fix "in-memory" process socket conflicts

2021-09-15 Thread Bruce Richardson
When DPDK is run with --in-memory mode, multiple processes can run simultaneously using the same runtime dir. This leads to each process removing another process' telemetry socket as it started up, giving unexpected behaviour. This patch changes that behaviour to first check if the existing socket

[dpdk-dev] [PATCH v2] net/virtio: wait device ready during reset

2021-09-15 Thread Xueming Li
According to virtio spec, the device MUST reset when 0 is written to device_status, and present 0 in device_status once reset is done. This patch waits status value to be 0 during reset operation, if timeout in 3 seconds, log and continue. Signed-off-by: Xueming Li Cc: Andrew Rybchenko --- dri

Re: [dpdk-dev] [PATCH v1 0/7] make rte_intr_handle internal

2021-09-15 Thread Harman Kalra
Ping... Kindly review the series. Also would like to request PMD maintainers(who uses interrupt APIs) to validate the series for their respective drivers, as many drivers underwent interrupt related changes in patch 5 of the series. Thanks Harman > -Original Message- > From: Harman Kalr

Re: [dpdk-dev] [PATCH v1] net/virtio: wait device ready during reset

2021-09-15 Thread Xueming(Steven) Li
On Wed, 2021-09-15 at 12:27 +0300, Andrew Rybchenko wrote: > On 9/15/21 12:21 PM, Xueming Li wrote: > > According to virtio spec, the device MUST reset when 0 is written to > > device_status, and present 0 in device_status once reset is done. > > > > This patch waits status value to be 0 during re

[dpdk-dev] [PATCH] net/virtio: remove blank lines in log

2021-09-15 Thread Thomas Monjalon
The macro PMD_INIT_LOG includes already the line feed character. Redundant \n are removed. Signed-off-by: Thomas Monjalon --- drivers/net/virtio/virtio_ethdev.c| 2 +- drivers/net/virtio/virtio_pci.c | 2 +- drivers/net/virtio/virtio_pci_ethdev.c| 6 ++--- ..

Re: [dpdk-dev] [PATCH v5 1/3] security: enforce semantics for Tx inline processing

2021-09-15 Thread Ananyev, Konstantin
> > Not all net PMD's/HW can parse packet and identify L2 header and > L3 header locations on Tx. This is inline with other Tx offloads > requirements such as L3 checksum, L4 checksum offload, etc, > where mbuf.l2_len, mbuf.l3_len etc, needs to be set for HW to be > able to generate checksum. S

Re: [dpdk-dev] logs about hugepages detection

2021-09-15 Thread Bruce Richardson
On Wed, Sep 15, 2021 at 03:52:35PM +0200, Thomas Monjalon wrote: > Hi, > > I would like to discuss some issues in logging of hugepage lookup. > The issues to be discussed will be enumerated and numbered below. > I will take an example of an x86 machine with 2M and 1G pages. > I reserve only 2M pag

[dpdk-dev] [PATCH v1] sched: adds function to get 64 bits greatest common divisor

2021-09-15 Thread Xueming Li
This patch adds new function that compute the greatest common divisor of 64 bits, also changes the original 32 bits function to call this new 64 bits version. Signed-off-by: Xueming Li --- v1: add 64 bits version and make 32 bits api call it lib/sched/rte_sched_common.h | 19 ---

[dpdk-dev] [PATCH] eal: remove plural syntax for single resource

2021-09-15 Thread Thomas Monjalon
Some comments and logs about cores, nodes and pages were using plural or hypotetic plural (s) form even if preceded by "0" or "no". It is replaced with singular form where appropriate. Signed-off-by: Thomas Monjalon --- lib/eal/common/eal_common_lcore.c | 13 + lib/eal/common/rte_ma

Re: [dpdk-dev] [PATCH v5 2/3] security: add option for faster udata or mdata access

2021-09-15 Thread Ananyev, Konstantin
> > Currently rte_security_set_pkt_metadata() and rte_security_get_userdata() > methods to set pkt metadata on Inline outbound and get userdata > after Inline inbound processing is always driver specific callbacks. > > For drivers that do not have much to do in the callbacks but just > to updat

Re: [dpdk-dev] [PATCH v5 3/3] examples/ipsec-secgw: update event mode inline path

2021-09-15 Thread Ananyev, Konstantin
> Update mbuf.l2_len with L2 header size for outbound > inline processing. > > This patch also fixes a bug in arg parsing. > > Signed-off-by: Nithin Dabilpuram > Acked-by: Akhil Goyal > --- > examples/ipsec-secgw/ipsec-secgw.c | 2 ++ > examples/ipsec-secgw/ipsec_worker.c | 41 > +++

Re: [dpdk-dev] [PATCH v21 4/7] dmadev: introduce DMA device library implementation

2021-09-15 Thread Bruce Richardson
On Wed, Sep 15, 2021 at 02:51:55PM +0100, Kevin Laatz wrote: > On 07/09/2021 13:56, Chengwen Feng wrote: > > This patch introduce DMA device library implementation which includes > > configuration and I/O with the DMA devices. > > > > Signed-off-by: Chengwen Feng > > Acked-by: Bruce Richardson >

Re: [dpdk-dev] logs about hugepages detection

2021-09-15 Thread Thomas Monjalon
15/09/2021 16:25, Bruce Richardson: > On Wed, Sep 15, 2021 at 03:52:35PM +0200, Thomas Monjalon wrote: > > Hi, > > > > I would like to discuss some issues in logging of hugepage lookup. > > The issues to be discussed will be enumerated and numbered below. > > I will take an example of an x86 machi

[dpdk-dev] [RFC PATCH 02/12] common/mlx5: read software parsing capabilities from DevX

2021-09-15 Thread Tal Shnaiderman
mlx5 in Windows needs the software parsing hca capabilities to query the NIC for TSO and Checksum offloading support. Added the capability as part of the capabilities queried by the PMD using DevX. Signed-off-by: Tal Shnaiderman --- drivers/common/mlx5/mlx5_devx_cmds.c | 6 ++ drivers/commo

[dpdk-dev] [RFC PATCH 01/12] net/mlx5: fix software parsing support query

2021-09-15 Thread Tal Shnaiderman
Currently, the PMD decides if the software parsing offload can enable outer IPv4 checksum and tunneled TSO support by checking config->hw_csum and config->tso respectively. This is incorrect, the right way is to check the following flags returned by the mlx5dv_query_device function: MLX5DV_SW_PAR

  1   2   3   >