Re: [dpdk-dev] [PATCH v4 2/2] ethdev: change queue release callback

2021-09-17 Thread Andrew Rybchenko
On 9/17/21 5:28 PM, Xueming Li wrote: > Currently, most ethdev callback API use queue ID as parameter, but Rx > and Tx queue release callback use queue object which is used by Rx and > Tx burst data plane callback. > > To align with other eth device queue configuration callbacks: > - queue release

Re: [dpdk-dev] [PATCH v4 1/2] ethdev: make queue release callback optional

2021-09-17 Thread Andrew Rybchenko
On 9/17/21 5:28 PM, Xueming Li wrote: > Some drivers don't need Rx and Tx queue release callback, make them > optional. Clean up empty queue release callbacks for some drivers. > > Signed-off-by: Xueming Li Many thanks, Reviewed-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH v2] Enable AddressSanitizer feature on DPDK

2021-09-17 Thread Peng, ZhihongX
> -Original Message- > From: Stephen Hemminger > Sent: Friday, September 17, 2021 10:59 PM > To: Peng, ZhihongX > Cc: David Marchand ; Burakov, Anatoly > ; Ananyev, Konstantin > ; dev ; Lin, Xueqin > > Subject: Re: [dpdk-dev] [PATCH v2] Enable AddressSanitizer feature on DPDK > > On Fri

Re: [dpdk-dev] [PATCH v2 2/4] net/iavf: add iAVF IPsec inline crypto support

2021-09-17 Thread Wu, Jingjing
In general, the patch is too big to review. Patch split would help a lot! [...] > +static const struct rte_cryptodev_symmetric_capability * > +get_capability(struct iavf_security_ctx *iavf_sctx, > + uint32_t algo, uint32_t type) > +{ > + const struct rte_cryptodev_capabilities *capability;

[dpdk-dev] [PATCH 5/5] examples/l3fwd-power: support virtio/vhost

2021-09-17 Thread Miao Li
In l3fwd-power, there is default port configuration which requires RSS and IPV4/UDP/TCP checksum. Once device does not support these, the l3fwd-power will exit and report an error. This patch updates the port configuration based on device capabilities after getting the device information to support

[dpdk-dev] [PATCH 4/5] power: modify return of queue_stopped

2021-09-17 Thread Miao Li
Since some vdevs like virtio and vhost do not support rxq_info_get and queue state inquiry, the error return value -ENOTSUP need to be ignored when queue_stopped cannot get rx queue information and rx queue state. This patch changes the return value of queue_stopped when rte_eth_rx_queue_info_get r

[dpdk-dev] [PATCH 3/5] net/vhost: implement rte_power_monitor API

2021-09-17 Thread Miao Li
This patch implements rte_power_monitor API in vhost PMD to reduce power consumption when no packet come in. According to current semantics of power monitor, this commit adds a callback function to decide whether aborts the sleep by checking current value against the expected value and vhost_get_mo

[dpdk-dev] [PATCH 2/5] vhost: implement rte_power_monitor API

2021-09-17 Thread Miao Li
This patch defines rte_vhost_power_monitor_cond which is used to pass some information to vhost driver. The information is including the address to monitor, the expected value, the mask to extract value read from 'addr', the value size of monitor address, the match flag used to distinguish the valu

[dpdk-dev] [PATCH 1/5] net/virtio: implement rte_power_monitor API

2021-09-17 Thread Miao Li
This patch implements rte_power_monitor API in virtio PMD to reduce power consumption when no packet come in. According to current semantics of power monitor, this commit adds a callback function to decide whether aborts the sleep by checking current value against the expected value and virtio_get_

[dpdk-dev] [PATCH 0/5] Implement rte_power_monitor API in virtio/vhost PMD

2021-09-17 Thread Miao Li
This patchset implements rte_power_monitor API in virtio and vhost PMD to reduce power consumption when no packet come in. This API can be called and tested in l3fwd-power after adding vhost and virtio support in l3fwd-power and ignoring the rx queue information check in queue_stopped(). v2: -remo

Re: [dpdk-dev] [RFC V2] ethdev: fix issue that dev close in PMD calls twice

2021-09-17 Thread Huisong Li
Hi, All Can you take a look at this problem? Thanks. 在 2021/8/25 17:53, Huisong Li 写道: 在 2021/8/24 22:42, Ferruh Yigit 写道: On 8/19/2021 4:45 AM, Huisong Li wrote: 在 2021/8/18 19:24, Ferruh Yigit 写道: On 8/13/2021 9:16 AM, Huisong Li wrote: 在 2021/8/13 14:12, Thomas Monjalon 写道: 13/08/202

Re: [dpdk-dev] [RFC V1] examples/l3fwd-power: fix memory leak for rte_pci_device

2021-09-17 Thread Huisong Li
在 2021/9/17 20:50, Thomas Monjalon 写道: 17/09/2021 04:13, Huisong Li: 在 2021/9/16 18:36, Thomas Monjalon 写道: 16/09/2021 10:01, Huisong Li: 在 2021/9/8 15:20, Thomas Monjalon 写道: 08/09/2021 04:01, Huisong Li: 在 2021/9/7 16:53, Thomas Monjalon 写道: 07/09/2021 05:41, Huisong Li: Calling rte_et

Re: [dpdk-dev] [PATCH 4/4] net/ixgbe: delete HW rings when releasing queues

2021-09-17 Thread Wang, Haiyue
> -Original Message- > From: wangyunjian > Sent: Saturday, September 18, 2021 11:11 > To: Wang, Haiyue ; dev@dpdk.org > Cc: Xing, Beilei ; Yang, Qiming > ; Zhang, Qi Z > ; dingxiaoxiong > Subject: RE: [dpdk-dev] [PATCH 4/4] net/ixgbe: delete HW rings when releasing > queues > > > -

Re: [dpdk-dev] [PATCH 4/4] net/ixgbe: delete HW rings when releasing queues

2021-09-17 Thread wangyunjian
> -Original Message- > From: Wang, Haiyue [mailto:haiyue.w...@intel.com] > Sent: Friday, September 17, 2021 11:47 PM > To: wangyunjian ; dev@dpdk.org > Cc: Xing, Beilei ; Yang, Qiming > ; Zhang, Qi Z ; dingxiaoxiong > > Subject: RE: [dpdk-dev] [PATCH 4/4] net/ixgbe: delete HW rings when re

[dpdk-dev] [PATCH v3 2/2] app/testpmd: fix txonly forwording

2021-09-17 Thread Alvin Zhang
When random number of Tx segments is enabled, because the actual number of segments may be only one, the first segment of the Tx packets must accommodate a complete being sending Eth/IP/UDP packet. Besides, if multiple flow is enabled, the forwarding will update the IP and UDP header, these header

[dpdk-dev] [PATCH v3 1/2] app/testpmd: update forward engine beginning

2021-09-17 Thread Alvin Zhang
For each forward engine, there may be some special conditions must be meet before the forwarding run. Adding checks for these conditions in configuring is not suitable, because one condition may rely on multiple configurations, and the conditions required by each forward engine is not general. Th

[dpdk-dev] [PATCH v2] net/ice: add support for low Rx latency

2021-09-17 Thread Alvin Zhang
This patch adds a devarg parameter to enable/disable low Rx latency. Signed-off-by: Alvin Zhang --- doc/guides/nics/ice.rst | 12 drivers/net/ice/ice_ethdev.c | 26 +++--- drivers/net/ice/ice_ethdev.h | 1 + 3 files changed, 36 insertions(+), 3 deletions(-)

Re: [dpdk-dev] [PATCH v2 2/7] app/testpmd: use PCI memory resource access APIs

2021-09-17 Thread Li, Xiaoyun
> -Original Message- > From: Xia, Chenbo > Sent: Saturday, September 18, 2021 10:25 > To: dev@dpdk.org; david.march...@redhat.com > Cc: Li, Xiaoyun > Subject: [PATCH v2 2/7] app/testpmd: use PCI memory resource access APIs > > Currently testpmd uses struct rte_pci_device to access PCI me

[dpdk-dev] [PATCH v2 7/7] bus/pci: remove ABIs in PCI bus

2021-09-17 Thread Chenbo Xia
As announced in the deprecation note, most of ABIs in PCI bus are removed in this patch. Only the function rte_pci_dump is still ABI and experimental APIs are kept for future promotion. This patch creates a new file named pci_driver.h and moves most of the content in original rte_bus_pci.h to it.

[dpdk-dev] [PATCH v2 6/7] kni: replace unused variable definition with reserved bytes

2021-09-17 Thread Chenbo Xia
PCI ID and address in structure rte_kni_conf are never used. And in order not to break ABI, replace these variables with reserved bytes. Signed-off-by: Chenbo Xia --- lib/kni/rte_kni.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/kni/rte_kni.h b/lib/kni/rte_kni.h in

[dpdk-dev] [PATCH v2 5/7] kni: remove unused PCI info from test and example

2021-09-17 Thread Chenbo Xia
PCI device id and address in structure rte_kni_conf are never used in the test, example and kni library. So remove the related code. Fixes: ea6b39b5b847 ("kni: remove ethtool support") Cc: sta...@dpdk.org Signed-off-by: Chenbo Xia Acked-by: Ferruh Yigit --- app/test/test_kni.c| 57

[dpdk-dev] [PATCH v2 4/7] examples/kni: remove unused PCI bus header

2021-09-17 Thread Chenbo Xia
The header rte_bus_pci.h is included in kni example but nothing in it is used. So remove it. Signed-off-by: Chenbo Xia Acked-by: Ferruh Yigit --- examples/kni/main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/examples/kni/main.c b/examples/kni/main.c index beabb3c848..6dc335c0b5 100644

[dpdk-dev] [PATCH v2 3/7] examples/ethtool: use PCI library API to get PCI address

2021-09-17 Thread Chenbo Xia
Currently ethtool example uses struct rte_pci_device to know PCI address of a device. As this API will be removed later in PCI bus, this patch uses PCI library API to get the PCI address. Signed-off-by: Chenbo Xia --- examples/ethtool/lib/rte_ethtool.c | 14 +- examples/ethtool/meson

[dpdk-dev] [PATCH v2 2/7] app/testpmd: use PCI memory resource access APIs

2021-09-17 Thread Chenbo Xia
Currently testpmd uses struct rte_pci_device to access PCI memory resource. Since this structure will be internal later, this patch replaces use of rte_pci_device with new PCI memory resource access APIs to read/write BAR 0. Signed-off-by: Chenbo Xia --- app/test-pmd/config.c | 50 +

[dpdk-dev] [PATCH v2 1/7] bus/pci: add new memory resource access APIs

2021-09-17 Thread Chenbo Xia
Some applications wants to access PCI memory resource. Currently applications use struct rte_pci_device to access it. Since the structure will be made internal later, this patch adds two APIs for memory resource access. Signed-off-by: Chenbo Xia Acked-by: Ray Kinsella --- doc/guides/rel_notes/r

[dpdk-dev] [PATCH v2 0/7] Removal of PCI bus ABIs

2021-09-17 Thread Chenbo Xia
As announced in the deprecation notice, most ABIs in PCI bus will be removed. As there exist some applications that want to access PCI memory resource, two new APIs are defined in Patch 1 and corresponding changes are applied to testpmd in Patch 2. Patch 3-4 clean up the unnecessary usage of PCI

Re: [dpdk-dev] [PATCH v8 2/2] app/testpmd: fix testpmd doesn't show RSS hash offload

2021-09-17 Thread Li, Xiaoyun
Hi > -Original Message- > From: Yigit, Ferruh > Sent: Friday, September 17, 2021 18:20 > To: Li, Xiaoyun ; Wang, Jie1X ; > dev@dpdk.org > Cc: andrew.rybche...@oktetlabs.ru; tho...@monjalon.net; > jer...@marvell.com; Ananyev, Konstantin > Subject: Re: [PATCH v8 2/2] app/testpmd: fix testp

Re: [dpdk-dev] [PATCH v2 00/20] ice/base: add parser module

2021-09-17 Thread Guo, Junfeng
> -Original Message- > From: Zhang, Qi Z > Sent: Friday, September 17, 2021 22:43 > To: Yang, Qiming > Cc: Guo, Junfeng ; dev@dpdk.org; Zhang, Qi Z > > Subject: [PATCH v2 00/20] ice/base: add parser module > > Add the parser module that can parse on a raw packet then figure > out the

Re: [dpdk-dev] [PATCH] net/ice: add ability to reduce the Rx latency

2021-09-17 Thread Zhang, AlvinX
> -Original Message- > From: Kevin Traynor > Sent: Saturday, September 18, 2021 1:25 AM > To: Zhang, AlvinX ; Zhang, Qi Z > ; Guo, Junfeng > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/ice: add ability to reduce the Rx latency > > On 14/09/2021 02:31, Alvin Zhang wrote: > > Th

Re: [dpdk-dev] [PATCH v3 2/8] dmadev: add burst capacity API

2021-09-17 Thread Hu, Jiayu
Hi Jerin, > -Original Message- > From: Jerin Jacob > Sent: Friday, September 17, 2021 9:55 PM > To: Richardson, Bruce > Cc: dpdk-dev ; Walsh, Conor ; > Laatz, Kevin ; fengchengwen > ; Jerin Jacob ; > Satananda Burla ; Radha Mohan Chintakuntla > ; Hu, Jiayu ; Pai G, Sunil > > Subject: Re

Re: [dpdk-dev] I40e-dpdk_18.11-Bonding issue

2021-09-17 Thread Min Hu (Connor)
Hi, Nishant, could you tell us your complete detailed steps and logs for test ? the more detailed the better, thanks. 在 2021/9/18 1:20, Nishant Verma 写道: Hi, I am stuck with a bonding issue wrt. DPDK 18.11 with X722 ethernet controller. My system basically creates VF's through

Re: [dpdk-dev] [PATCH] Enable AddressSanitizer feature on DPDK

2021-09-17 Thread David Christensen
If you want to use this feature, you need to add below compilation options when compiling code: -Dbuildtype=debug -Db_lundef=false -Db_sanitize=address "-Dbuildtype=debug": Display code information when coredump occurs in the program. "-Db_lundef=false": It is enabled by default, and needs to be d

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: change queue release callback

2021-09-17 Thread Xueming(Steven) Li
On Fri, 2021-09-17 at 14:49 +0300, Andrew Rybchenko wrote: > On 9/17/21 12:39 PM, Xueming Li wrote: > > Currently, most ethdev callback api use queue ID as parameter, but Rx > > api -> API > > > and Tx queue release callback use queue object which is used in Rx and > > Tx burst data plane callbac

[dpdk-dev] [PATCH v4 2/2] ethdev: change queue release callback

2021-09-17 Thread Xueming Li
Currently, most ethdev callback API use queue ID as parameter, but Rx and Tx queue release callback use queue object which is used by Rx and Tx burst data plane callback. To align with other eth device queue configuration callbacks: - queue release callbacks are changed to use queue ID - all drive

[dpdk-dev] [PATCH v4 0/2] ethdev: change queue release callback

2021-09-17 Thread Xueming Li
ethdev: change queue release callback This patch is a preparation of shared Rx queue feature[1]. Rxq object could be shared among ports of a share group, a shared rxq object can't tell which port it belongs to. This is the motativation to clean up queue release callback API to use queue ID. v2:

[dpdk-dev] [PATCH v4 1/2] ethdev: make queue release callback optional

2021-09-17 Thread Xueming Li
Some drivers don't need Rx and Tx queue release callback, make them optional. Clean up empty queue release callbacks for some drivers. Signed-off-by: Xueming Li --- app/test/virtual_pmd.c| 12 drivers/net/af_packet/rte_eth_af_packet.c | 7 -- drivers/net/af_xdp/rte_eth_

[dpdk-dev] [PATCH] port: configure loop count for source port

2021-09-17 Thread Yogesh Jangra
Add support for configurable number of loops through the input PCAP file for the source port. Added an additional parameter to source port CLI command. Signed-off-by: Yogesh Jangra Acked-by: Cristian Dumitrescu --- examples/pipeline/cli.c | 17 ++--- .../pipe

Re: [dpdk-dev] [PATCH] net/ice: add ability to reduce the Rx latency

2021-09-17 Thread Kevin Traynor
On 14/09/2021 02:31, Alvin Zhang wrote: > This patch adds a devarg parameter to enable/disable reducing the > Rx latency. > > Signed-off-by: Alvin Zhang > --- > doc/guides/nics/ice.rst | 8 > drivers/net/ice/ice_ethdev.c | 26 +++--- > drivers/net/ice/ice_ethde

[dpdk-dev] I40e-dpdk_18.11-Bonding issue

2021-09-17 Thread Nishant Verma
Hi, I am stuck with a bonding issue wrt. DPDK 18.11 with X722 ethernet controller. My system basically creates VF's through SRIOV on top of two PF's. One issue I found was if I try to change the MAC address of VF more then once, it won't let me do that. Anyway I can live with that but when I am c

[dpdk-dev] [PATCH v2 6/6] examples/ioat: rename application to dmafwd

2021-09-17 Thread Kevin Laatz
Since the APIs have been updated from rawdev to dmadev, the application should also be renamed to match. This patch also includes the documentation updates for the renaming. Signed-off-by: Kevin Laatz --- MAINTAINERS | 7 +- .../sample_app_ug/{ioat.rst => dma.

[dpdk-dev] [PATCH v2 5/6] examples/ioat: update naming to match change to dmadev

2021-09-17 Thread Kevin Laatz
Existing functions, structures, defines etc need to be updated to reflect the change to using the dmadev APIs. Signed-off-by: Kevin Laatz --- examples/ioat/ioatfwd.c | 175 1 file changed, 87 insertions(+), 88 deletions(-) diff --git a/examples/ioat/ioat

[dpdk-dev] [PATCH v2 4/6] examples/ioat: port application to dmadev APIs

2021-09-17 Thread Kevin Laatz
The dmadev library abstraction allows applications to use the same APIs for all DMA device drivers in DPDK. This patch updates the ioatfwd application to make use of the new dmadev APIs, in turn making it a generic application which can be used with any of the DMA device drivers. Signed-off-by: Ke

[dpdk-dev] [PATCH v2 3/6] examples/ioat: add cmd line option to control max frame size

2021-09-17 Thread Kevin Laatz
From: Konstantin Ananyev Add command line option for setting the max frame size. Signed-off-by: Konstantin Ananyev --- examples/ioat/ioatfwd.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/examples/ioat/ioatfwd.c b/examples/ioat/ioatfwd.c index

[dpdk-dev] [PATCH v2 2/6] examples/ioat: add cmd-line option to control DMA batch size

2021-09-17 Thread Kevin Laatz
From: Konstantin Ananyev Add a commandline options to control the HW copy batch size in the application. Signed-off-by: Konstantin Ananyev --- examples/ioat/ioatfwd.c | 40 1 file changed, 32 insertions(+), 8 deletions(-) diff --git a/examples/ioat/ioa

[dpdk-dev] [PATCH v2 1/6] examples/ioat: always use same lcore for both DMA requests enqueue and dequeue

2021-09-17 Thread Kevin Laatz
From: Konstantin Ananyev Few changes in ioat sample behaviour: - Always do SW copy for packet metadata (mbuf fields) - Always use same lcore for both DMA requests enqueue and dequeue Main reasons for that: a) it is safer, as idxd PMD doesn't support MT safe enqueue/dequeue (yet). b) sort of more

[dpdk-dev] [PATCH v2 0/6] port ioatfwd app to dmadev

2021-09-17 Thread Kevin Laatz
This patchset first adds some additional command line options to the existing ioatfwd application to enhance usability. The last 3 patches of this set then port the ioatfwd application to use the dmadev library APIs instead of the IOAT rawdev APIs. Following the port, all variables etc are renamed

Re: [dpdk-dev] [EXT] Re: [PATCH v3] devtools: add acronyms in dictionary for commit checks

2021-09-17 Thread Thomas Monjalon
17/09/2021 16:53, Ashwin Sekhar Thalakalath Kottilveetil: > From: Thomas Monjalon > > 17/09/2021 15:54, Ashwin Sekhar Thalakalath Kottilveetil: > > > From: Thomas Monjalon > > > > 17/09/2021 12:58, Ashwin Sekhar T K: > > > > > Update word list with Marvell specific acronyms. [...] > > Please add

Re: [dpdk-dev] [PATCH 4/4] net/ixgbe: delete HW rings when releasing queues

2021-09-17 Thread Wang, Haiyue
> -Original Message- > From: Yunjian Wang > Sent: Friday, September 17, 2021 19:25 > To: dev@dpdk.org > Cc: Wang, Haiyue ; Xing, Beilei > ; Yang, Qiming > ; Zhang, Qi Z ; > dingxiaoxi...@huawei.com; Yunjian Wang > > Subject: [dpdk-dev] [PATCH 4/4] net/ixgbe: delete HW rings when releasi

[dpdk-dev] [PATCH v4 11/11] devbind: move ioat device ID for ICX to dmadev category

2021-09-17 Thread Conor Walsh
Move Intel IOAT devices on Ice Lake systems from Misc to DMA devices. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz --- usertools/dpdk-devbind.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index 98b698ccc0

[dpdk-dev] [PATCH v4 10/11] dma/ioat: add burst capacity function

2021-09-17 Thread Conor Walsh
Adds the ability to find the remaining space in the IOAT ring. Signed-off-by: Conor Walsh Signed-off-by: Kevin Laatz --- drivers/dma/ioat/ioat_dmadev.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/dma/ioat/ioat_dmadev.c b/drivers/dma/ioat/ioat_dmadev.c index b9328

[dpdk-dev] [PATCH v4 09/11] dma/ioat: add support for vchan status function

2021-09-17 Thread Conor Walsh
Add support for the rte_dmadev_vchan_status API call. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz --- drivers/dma/ioat/ioat_dmadev.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/dma/ioat/ioat_dmadev.c b/drivers/dma/ioat/ioat_dmadev.c index f596637da

[dpdk-dev] [PATCH v4 08/11] dma/ioat: add statistics

2021-09-17 Thread Conor Walsh
Add statistic tracking for operations in IOAT. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz --- doc/guides/dmadevs/ioat.rst| 23 ++ drivers/dma/ioat/ioat_dmadev.c | 43 ++ 2 files changed, 66 insertions(+) diff --git a/doc/guides/dmade

[dpdk-dev] [PATCH v4 07/11] dma/ioat: add data path completion functions

2021-09-17 Thread Conor Walsh
Add the data path functions for gathering completed operations from IOAT devices. Signed-off-by: Conor Walsh Signed-off-by: Kevin Laatz --- doc/guides/dmadevs/ioat.rst| 48 ++- drivers/dma/ioat/ioat_dmadev.c | 141 + 2 files changed, 188 insertions(+

[dpdk-dev] [PATCH v4 06/11] dma/ioat: add data path job submission functions

2021-09-17 Thread Conor Walsh
Add data path functions for enqueuing and submitting operations to IOAT devices. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz --- doc/guides/dmadevs/ioat.rst| 54 drivers/dma/ioat/ioat_dmadev.c | 92 ++ 2 files changed, 146 inserti

[dpdk-dev] [PATCH v4 05/11] dma/ioat: add start and stop functions

2021-09-17 Thread Conor Walsh
Add start, stop and recover functions for IOAT devices. Signed-off-by: Conor Walsh Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz --- doc/guides/dmadevs/ioat.rst| 3 ++ drivers/dma/ioat/ioat_dmadev.c | 92 ++ 2 files changed, 95 insertions(+) dif

[dpdk-dev] [PATCH v4 04/11] dma/ioat: add configuration functions

2021-09-17 Thread Conor Walsh
Add functions for device configuration. The info_get and close functions are included here also. info_get can be useful for checking successful configuration and close is used by the dmadev api when releasing a configured device. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz --- doc/guide

[dpdk-dev] [PATCH v4 03/11] dma/ioat: add datapath structures

2021-09-17 Thread Conor Walsh
Add data structures required for the data path of IOAT devices. Signed-off-by: Conor Walsh Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz --- drivers/dma/ioat/ioat_dmadev.c | 61 - drivers/dma/ioat/ioat_hw_defs.h | 214 2 files changed, 274

[dpdk-dev] [PATCH v4 02/11] dma/ioat: create dmadev instances on PCI probe

2021-09-17 Thread Conor Walsh
When a suitable device is found during the PCI probe, create a dmadev instance for each channel. Internal structures and HW definitions required for device creation are also included. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz --- drivers/dma/ioat/ioat_dmadev.c | 119

[dpdk-dev] [PATCH v4 01/11] dma/ioat: add device probe and removal functions

2021-09-17 Thread Conor Walsh
Add the basic device probe/remove skeleton code and initial documentation for new IOAT DMA driver. Maintainers update is also included in this patch. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz --- MAINTAINERS| 6 +++ doc/guides/dmadevs/index.rst |

[dpdk-dev] [PATCH v4 00/11] dma: add dmadev driver for ioat devices

2021-09-17 Thread Conor Walsh
This patchset adds a dmadev driver and associated documentation to support Intel QuickData Technology devices, part of the Intel I/O Acceleration Technology (Intel I/OAT). This driver is intended to ultimately replace the current IOAT part of the IOAT rawdev driver. This patchset passes all the dri

Re: [dpdk-dev] [PATCH 5/8] test/kni: remove setting of PCI ID and address

2021-09-17 Thread Ferruh Yigit
On 9/10/2021 3:23 AM, Chenbo Xia wrote: > PCI device id and address in structure rte_kni_conf are never used > in the test and kni library. So remove the related code. > > Signed-off-by: Chenbo Xia Acked-by: Ferruh Yigit When/If you merge, please feel free to keep the ack.

Re: [dpdk-dev] [PATCH 4/8] examples/kni: remove unused PCI bus header

2021-09-17 Thread Ferruh Yigit
On 9/10/2021 3:23 AM, Chenbo Xia wrote: > The header rte_bus_pci.h is included in kni example but nothing > in it is used. So remove it. > > Signed-off-by: Chenbo Xia Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH 6/8] examples/ip_pipeline: remove setting of PCI ID and address

2021-09-17 Thread Ferruh Yigit
On 9/17/2021 12:55 PM, David Marchand wrote: > Hi Chenbo, > > On Fri, Sep 17, 2021 at 5:09 AM Xia, Chenbo wrote: PCI ID and address in structure rte_kni_conf are never used and will be removed in kni library. So remove the setting of them first in the example. Signed-off-

[dpdk-dev] DPDK Release Status Meeting 2021-09-16

2021-09-17 Thread Mcnamara, John
Release status meeting minutes 2021-09-16 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * ARM * Broadcom * Canonical * Debian * Intel * Marvell * Nvidia * Red Hat Release Dates - * v21.11 dates * Prop

[dpdk-dev] [PATCH v5 16/16] devbind: move idxd device ID to dmadev class

2021-09-17 Thread Kevin Laatz
The dmadev library is the preferred abstraction for using IDXD devices and will replace the rawdev implementation in future. This patch moves the IDXD device ID to the dmadev class. Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- usertools/dpdk-devbind.py | 4 ++-- 1 file changed, 2 ins

[dpdk-dev] [PATCH v5 15/16] devbind: add dma device class

2021-09-17 Thread Kevin Laatz
Add a new class for DMA devices. Devices listed under the DMA class are to be used with the dmadev library. Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- usertools/dpdk-devbind.py | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/usertools/dpdk-devbind.p

[dpdk-dev] [PATCH v5 14/16] dma/idxd: move dpdk_idxd_cfg.py from raw to dma

2021-09-17 Thread Kevin Laatz
From: Conor Walsh Move the example script for configuring IDXD devices bound to the IDXD kernel driver from raw to dma, and create a symlink to still allow use from raw. Signed-off-by: Conor Walsh Signed-off-by: Kevin Laatz --- drivers/dma/idxd/dpdk_idxd_cfg.py | 117 +

[dpdk-dev] [PATCH v5 13/16] dma/idxd: add burst capacity API

2021-09-17 Thread Kevin Laatz
Add support for the burst capacity API. This API will provide the calling application with the remaining capacity of the current burst (limited by max HW batch size). Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- drivers/dma/idxd/idxd_bus.c | 1 + drivers/dma/idxd/idxd_common.c

[dpdk-dev] [PATCH v5 12/16] dma/idxd: add vchan status function

2021-09-17 Thread Kevin Laatz
When testing dmadev drivers, it is useful to have the HW device in a known state. This patch adds the implementation of the function which will wait for the device to be idle (all jobs completed) before proceeding. Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- v3: update API name to v

[dpdk-dev] [PATCH v5 11/16] dma/idxd: add operation statistic tracking

2021-09-17 Thread Kevin Laatz
Add statistic tracking for DSA devices. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- doc/guides/dmadevs/idxd.rst | 11 +++ drivers/dma/idxd/idxd_bus.c | 2 ++ drivers/dma/idxd/idxd_common.c | 27 +++ driver

[dpdk-dev] [PATCH v5 10/16] dma/idxd: add data-path job completion functions

2021-09-17 Thread Kevin Laatz
Add the data path functions for gathering completed operations. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- v2: - fixed typo in docs - add completion status for invalid opcode --- doc/guides/dmadevs/idxd.rst | 32 + drivers/dma/idxd/

[dpdk-dev] [PATCH v5 09/16] dma/idxd: add data-path job submission functions

2021-09-17 Thread Kevin Laatz
Add data path functions for enqueuing and submitting operations to DSA devices. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- doc/guides/dmadevs/idxd.rst | 64 +++ drivers/dma/idxd/idxd_common.c | 136 +++

[dpdk-dev] [PATCH v5 08/16] dma/idxd: add start and stop functions for pci devices

2021-09-17 Thread Kevin Laatz
Add device start/stop functions for DSA devices bound to vfio. For devices bound to the IDXD kernel driver, these are not required since the IDXD kernel driver takes care of this. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- doc/guides/dmadevs/idxd.rs

[dpdk-dev] [PATCH v5 07/16] dma/idxd: add configure and info_get functions

2021-09-17 Thread Kevin Laatz
Add functions for device configuration. The info_get function is included here since it can be useful for checking successful configuration. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- v2: - fix reconfigure bug in idxd_vchan_setup() - add liter

[dpdk-dev] [PATCH v5 06/16] dma/idxd: add datapath structures

2021-09-17 Thread Kevin Laatz
Add data structures required for the data path for IDXD devices. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- v2: add completion status for invalid opcode --- drivers/dma/idxd/idxd_bus.c | 1 + drivers/dma/idxd/idxd_common.c | 33

[dpdk-dev] [PATCH v5 05/16] dma/idxd: create dmadev instances on pci probe

2021-09-17 Thread Kevin Laatz
When a suitable device is found during the PCI probe, create a dmadev instance for each HW queue. HW definitions required are also included. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- v4: rebase changes --- drivers/dma/idxd/idxd_hw_defs.h | 71 ++

[dpdk-dev] [PATCH v5 04/16] dma/idxd: create dmadev instances on bus probe

2021-09-17 Thread Kevin Laatz
When a suitable device is found during the bus scan/probe, create a dmadev instance for each HW queue. Internal structures required for device creation are also added. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- v4: - fix 'vdev' naming, changed to

[dpdk-dev] [PATCH v5 03/16] dma/idxd: add bus device probing

2021-09-17 Thread Kevin Laatz
Add the basic device probing for DSA devices bound to the IDXD kernel driver. These devices can be configured via sysfs and made available to DPDK if they are found during bus scan. Relevant documentation is included. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor

[dpdk-dev] [PATCH v5 02/16] dma/idxd: add skeleton for VFIO based DSA device

2021-09-17 Thread Kevin Laatz
Add the basic device probe/remove skeleton code for DSA device bound to the vfio pci driver. Relevant documentation and MAINTAINERS update also included. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- v5: add missing toctree entry for idxd driver --- M

[dpdk-dev] [PATCH v5 01/16] raw/ioat: only build if dmadev not present

2021-09-17 Thread Kevin Laatz
From: Bruce Richardson Only build the rawdev IDXD/IOAT drivers if the dmadev drivers are not present. A not is also added to the documentation to inform users of this change. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- v4: - Fix build issue -

[dpdk-dev] [PATCH v5 00/16] add dmadev driver for idxd devices

2021-09-17 Thread Kevin Laatz
This patchset adds a dmadev driver and associated documentation to support Intel Data Streaming Accelerator devices. This driver is intended to ultimately replace the current IDXD part of the IOAT rawdev driver. NOTE: This patchset has several dependencies: - v22 of the dmadev lib set [1] - v5

[dpdk-dev] [PATCH] test/compress: fix buffer overflow bug

2021-09-17 Thread Rebecca Troy
Fixes stack buffer overflow bug in compressdev autotest, which was caused by the use of buf_idx in the debug logs. Originally, buf_idx was treated as an array instead of the reference of an integar. This was fixed by replacing the use of buf_idx[priv_data->orig_idx] with the variable i. Fixes: 466

[dpdk-dev] [PATCH] app/test: fix memory autotests on FreeBSD

2021-09-17 Thread Bruce Richardson
The memory autotests were failing on FreeBSD, due to an incorrect errno variable being checked for ENOTSUP. The test checked "errno" while the DPDK API sets "rte_errno". Changing to check the right variable makes the test behave properly. Fixes: c3e35a0966b8 ("test/mem: check segment fd API") Cc:

Re: [dpdk-dev] [PATCH v2] Enable AddressSanitizer feature on DPDK

2021-09-17 Thread Stephen Hemminger
On Fri, 17 Sep 2021 09:12:07 + "Peng, ZhihongX" wrote: > > > By referring to its implementation algorithm > > > (https://github.com/google/sanitizers/wiki/AddressSanitizerAlgorithm), > > > enable heap-buffer-overflow and use-after-free functions on dpdk. > > > DPDK ASAN function currently onl

Re: [dpdk-dev] [EXT] Re: [PATCH v3] devtools: add acronyms in dictionary for commit checks

2021-09-17 Thread Ashwin Sekhar Thalakalath Kottilveetil
> -Original Message- > From: Thomas Monjalon > Sent: Friday, September 17, 2021 7:35 PM > To: Ashwin Sekhar Thalakalath Kottilveetil > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Sunil > Kumar Kori ; Satha Koteswara Rao Kottidi > ; Pavan Nikhilesh Bhagavatula > ; Kiran Kumar Kokkilaga

[dpdk-dev] [PATCH v2 16/20] net/ice/base: add helper function to aggregate flags

2021-09-17 Thread Qi Zhang
Add internal helper function ice_xlt_kb_flg_get to aggregate 64 bit packet flag into 16 bit key builder flags. Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_xlt_kb.c | 27 +++ drivers/net/ice/base/ice_xlt_kb.h | 1 + 2 files changed, 28 insertions(+) diff --git a

[dpdk-dev] [PATCH v2 15/20] net/ice/base: add helper function to redirect flags

2021-09-17 Thread Qi Zhang
Add internal helper function ice_flg_redirect to redirect parser flags to packet flags. Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flg_rd.c | 23 +++ drivers/net/ice/base/ice_flg_rd.h | 1 + 2 files changed, 24 insertions(+) diff --git a/drivers/net/ice/base/ice_f

[dpdk-dev] [PATCH v2 20/20] net/ice/base: add API for parser profile initialization

2021-09-17 Thread Qi Zhang
Add API ice_parser_profile_init to init a parser profile base on a parser result and a mask buffer. The ice_parser_profile can feed to low level FXP engine to create HW profile / field vector directly. Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_parser.c | 112 ++

[dpdk-dev] [PATCH v2 19/20] net/ice/base: add tunnel port support for parser

2021-09-17 Thread Qi Zhang
UDP tunnel can be added/deleted for vxlan, geneve, ecpri through below APIs: ice_parser_vxlan_tunnel_set ice_parser_geneve_tunnel_set ice_parser_ecpri_tunnel_set Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_parser.c | 75 +++ drivers/net/ice/base/ice_parser.h

[dpdk-dev] [PATCH v2 18/20] net/ice/base: support double VLAN mode configure for parser

2021-09-17 Thread Qi Zhang
Add API ice_parser_dvm_set to support turn on/off parser's double vlan mode. Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_bst_tcam.c | 28 drivers/net/ice/base/ice_bst_tcam.h | 4 drivers/net/ice/base/ice_parser.c | 27 +++ dri

[dpdk-dev] [PATCH v2 17/20] net/ice/base: add parser execution main loop

2021-09-17 Thread Qi Zhang
Implement function ice_parser_rt_execute which perform the main loop of the parser. Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_parser_rt.c | 782 ++- drivers/net/ice/base/ice_parser_rt.h | 27 +- 2 files changed, 803 insertions(+), 6 deletions(-) diff --git a/

[dpdk-dev] [PATCH v2 14/20] net/ice/base: add helper function for ptype markers match

2021-09-17 Thread Qi Zhang
Add internal helper function ice_ptype_mk_tcam_match for ptype markers matching in tcam table. Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_ptype_mk.c | 22 ++ drivers/net/ice/base/ice_ptype_mk.h | 3 +++ 2 files changed, 25 insertions(+) diff --git a/drivers/net/ic

[dpdk-dev] [PATCH v2 13/20] net/ice/base: add helper functions for parse graph key matching

2021-09-17 Thread Qi Zhang
Add below two internal helper functions for parse graph key matching in cam table: ice_pg_cam_match ice_pg_nm_cam_match Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_pg_cam.c | 76 +++ drivers/net/ice/base/ice_pg_cam.h | 6 +++ 2 files changed, 82 insertions(

[dpdk-dev] [PATCH v2 12/20] net/ice/base: add helper function for boost TCAM match

2021-09-17 Thread Qi Zhang
Add internal helper function ice_bst_tcam_match to perform ternary match on boost TCAM. Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_bst_tcam.c | 22 +++ drivers/net/ice/base/ice_bst_tcam.h | 3 ++ drivers/net/ice/base/ice_parser.h | 1 + drivers/net/ice/base/ice_tmatch.h

[dpdk-dev] [PATCH v2 11/20] net/ice/base: add parser runtime skeleton

2021-09-17 Thread Qi Zhang
Add parser runtime data struct ice_parser_rt. Add below APIs for parser runtime preparation: ice_parser_rt_reset ice_parser_rt_pkt_buf_set Add below API skeleton for parser runtime execution: ice_parser_rt_execute Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_parser.c| 39 ++

[dpdk-dev] [PATCH v2 10/20] net/ice/base: init XLT key builder for parser

2021-09-17 Thread Qi Zhang
Parse below DDP section into struct ice_xlt_kb: ICE_SID_XLT_KEY_BUILDER_SW ICE_SID_XLT_KEY_BUILDER_FD ICE_SID_XLT_KEY_BUILDER_RSS Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flex_pipe.c | 2 +- drivers/net/ice/base/ice_flex_pipe.h | 3 + drivers/net/ice/base/ice_parser.c| 28 ++

[dpdk-dev] [PATCH v2 09/20] net/ice/base: init flag redirect table for parser

2021-09-17 Thread Qi Zhang
Parse DDP section ICE_SID_RXPARSER_FLAG_REDIR into an array of ice_flag_rd_item. Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flex_type.h | 2 ++ drivers/net/ice/base/ice_flg_rd.c| 53 drivers/net/ice/base/ice_flg_rd.h| 16 + drivers/net/ice/

[dpdk-dev] [PATCH v2 08/20] net/ice/base: init protocol group table for parser

2021-09-17 Thread Qi Zhang
Parse DDP section ICE_SID_RXPARSER_PROTO_GRP into an array of ice_proto_grp_item. Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_parser.c| 11 +++ drivers/net/ice/base/ice_parser.h| 3 + drivers/net/ice/base/ice_proto_grp.c | 108 +++ drivers/net/ice/base

[dpdk-dev] [PATCH v2 07/20] net/ice/base: init marker group table for parser

2021-09-17 Thread Qi Zhang
Parse DDP section ICE_SID_RXPARSER_MARKER_GRP into an array of ice_mk_grp_item. Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_mk_grp.c | 55 +++ drivers/net/ice/base/ice_mk_grp.h | 15 + drivers/net/ice/base/ice_parser.c | 11 +++ drivers/net/ice/ba

[dpdk-dev] [PATCH v2 06/20] net/ice/base: init ptype marker TCAM table for parser

2021-09-17 Thread Qi Zhang
Parse DDP section ICE_SID_RXPARSER_MARKER_PTYPE into an array of ice_ptype_mk_tcam_item. Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_parser.c | 11 ++ drivers/net/ice/base/ice_parser.h | 3 ++ drivers/net/ice/base/ice_ptype_mk.c | 54 + drivers/net/i

  1   2   3   >