> -Original Message-
> From: Ferruh Yigit
> Sent: Friday, October 1, 2021 8:15 PM
> To: Apeksha Gupta ;
> david.march...@redhat.com; andrew.rybche...@oktetlabs.ru
> Cc: dev@dpdk.org; Sachin Saxena ; Hemant
> Agrawal
> Subject: Re: [EXT] Re: [dpdk-dev] [PATCH v3 1/5] net/enetfec: introd
>
> Hello Honnappa,
>
> On Thu, Sep 30, 2021 at 8:21 AM Honnappa Nagarahalli
> wrote:
> >
> > Hello,
> > Please find the slides and the excel sheet containing the
> > work
> items to fix DTS. We will review the slides in this meeting. Please provide
> your
> review comments be
From: Satheesh Paul
This patch adds support for rte flow action type port_id to
enable directing packets from an input port PF to an output
port which is a VF of the input port PF.
Signed-off-by: Satheesh Paul
---
doc/guides/nics/cnxk.rst | 5 +
doc/guides/nics/features/cnxk.ini
From: Satheesh Paul
This patch adds ROC API to support rte flow port ID action type.
Signed-off-by: Satheesh Paul
---
drivers/common/cnxk/roc_npc.c | 35 +
drivers/common/cnxk/roc_npc.h | 11 ++-
drivers/common/cnxk/version.map | 1 +
3 files change
From: Satheesh Paul
This patch removes the MCAM preallocation scheme. The free
entry cache is removed and for every flow created, an MCAM
allocation request is made to the kernel. Each priority level
has a list of MCAM entries. For every flow rule added, the
MCAM entry obtained from kernel is che
Hide struct rdline definition and some RDLINE_* constants in order
to be able to change internal buffer sizes transparently to the user.
Add new functions:
* rdline_create(): allocate and initialize struct rdline.
This function replaces rdline_init() and takes an extra parameter:
opaque user d
Remove the definition of `struct cmdline` from public header.
Deprecation notice:
https://mails.dpdk.org/archives/dev/2020-September/183310.html
Signed-off-by: Dmitry Kozlyuk
Acked-by: David Marchand
Acked-by: Olivier Matz
---
doc/guides/rel_notes/deprecation.rst | 4
doc/guides/rel_no
Hide struct cmdline following the deprecation notice.
Hide struct rdline following the v1 discussion.
v3: add experimental tags and releae notes for rdline.
v2: also hide struct rdline (David, Olivier).
Dmitry Kozlyuk (2):
cmdline: make struct cmdline opaque
cmdline: make struct rdline opaque
From: Dmitry Kozlyuk
MLX5 PMD uses reference counting to manage RX queue resources.
After port stop shared RSS actions kept references to RX queues,
preventing resource release. As a result, internal PMD mempool
for such queues had been exhausted after a number of port restarts.
Diagnostic messag
From: Dmitry Kozlyuk
Drop queue creation and destruction were not implemented for DevX
flow engine and Verbs engine methods were used as a workaround.
Implement these methods for DevX so that there is a valid queue ID
that can be used regardless of queue configuration via API.
Cc: sta...@dpdk.or
From: Dmitry Kozlyuk
Maximum available flow priority was discovered using Verbs API
regardless of the selected flow engine. This required some Verbs
objects to be initialized in order to use DevX engine. Make priority
discovery an engine method and implement it for DevX using its API.
Cc: sta...
From: Dmitry Kozlyuk
rte_flow_action_handle_create() did not mention what happens
with an indirect action when a device is stopped, possibly reconfigured,
and started again. It is natural for some indirect actions to be
persistent, like counters and meters; keeping others just saves
application t
From: Dmitry Kozlyuk
Currently, it is not specified what happens to the flow rules when
the device is stopped, possibly reconfigured, then started.
If flow rules were kept, it could be convenient for application
developers, because they wouldn't need to save and restore them.
However, due to the
From: Dmitry Kozlyuk
It is unspecified whether flow rules and indirect actions are kept
when a port is stopped, possibly reconfigured, and started again.
Vendors approach the topic differently, e.g. mlx5 and i40e PMD
disagree in whether flow rules can be kept, and mlx5 PMD would keep
indirect act
Introduce a helper API to let applications find transfer
admin port for a given ethdev to avoid failures when
managing "transfer" flows through unprivileged ports.
Signed-off-by: Ivan Malov
Reviewed-by: Andrew Rybchenko
---
Patch series [1] has reworked support for "transfer" flows.
As a result,
Such a counter will only report the number of hits, which is actually
a sum of two contributions (the JUMP rule's own counter + indirect
increments issued by counters of the associated GROUP rules.
Signed-off-by: Ivan Malov
Reviewed-by: Andrew Rybchenko
---
drivers/net/sfc/sfc_flow.c|
By design, in a GROUP flow, outer match criteria go to "ENC" fields
of the action rule match specification. The current HW/FW hasn't
got support for these fields (except the VXLAN VNI) yet.
As a workaround, start parsing the pattern from the tunnel item.
Signed-off-by: Ivan Malov
Reviewed-by: An
By design, JUMP flows should be represented solely by the outer rules. But
the HW/FW hasn't got support for setting Rx mark from RECIRC_ID on outer
rule lookup yet. Neither does it support outer rule counters. As a
workaround, an action rule of lower priority is used to do the job.
Signed-off-by:
The current HW/FW doesn't allow to match on MAC addresses in outer rules.
One day this will change for sure, but right now a workaround is needed.
Match on VLAN presence in outer rules is also unsupported. Ignore it.
Signed-off-by: Ivan Malov
Reviewed-by: Andrew Rybchenko
---
drivers/net/sfc/s
Support generic callbacks which callers will invoke to get
PMD-specific actions and items used to produce JUMP and
GROUP flows and to detect tunnel information.
Signed-off-by: Ivan Malov
Reviewed-by: Andrew Rybchenko
---
drivers/net/sfc/sfc_dp.c | 48 +
drivers/net/sfc/sfc_dp.h
GROUP is an in-house term for so-called "tunnel_match" flows.
On parsing, they are detected by virtue of PMD-internal item
MARK. It associates a given flow with its tunnel context.
Such a flow is represented by a MAE action rule which is
chained with the corresponding JUMP rule's outer rule
by vir
Currently, there is an API for setting recirculation ID in
outer rules. Add an API to let action rules match on it.
Signed-off-by: Ivan Malov
Reviewed-by: Andrew Rybchenko
---
drivers/common/sfc_efx/base/efx.h | 13 ++
drivers/common/sfc_efx/base/efx_mae.c | 36 +
JUMP is an in-house term for so-called "tunnel_set" flows. On parsing,
they are identified by virtue of actions MARK (PMD-internal) and JUMP.
The action MARK associates a given flow with its tunnel context.
Such a flow is represented by a MAE outer rule (OR) which has its
recirculation ID set. Thi
When an outer rule is hit, it can pass recirculation ID down
to action rule lookup, and action rules can match on this ID
instead of matching on the outer rule allocation handle.
By default, recirculation ID is assumed to be zero.
Add an API to set recirculation ID in outer rules.
Signed-off-by:
Later patches add support for tunnel offload on Riverhead (EF100).
A board can host at most 254 tunnels. Partially offloaded (missed)
tunnel packets are identified by virtue of 8 high bits in Rx mark.
Add basic definitions of the upcoming tunnel offload support and
take care of the dedicated bits
The first 6 patches comprise the fundamental part of the series.
They are trying to be future-proof with respect to the planned
HW/FW changes. 4 more patches form the adaptation part of some
sort to make the offload work on the currently available HW/FW.
This patch series should be applied on top
Detect the flag in Rx prefix and pass it to users.
Signed-off-by: Ivan Malov
Reviewed-by: Andrew Rybchenko
Reviewed-by: Andy Moreton
---
drivers/net/sfc/sfc_ef100_rx.c | 18 ++
drivers/net/sfc/sfc_rx.c | 3 +++
2 files changed, 21 insertions(+)
diff --git a/drivers/net/
Add an RxQ flag to request support for user flag field of Rx
prefix. The feature is supported only on EF100 and EF10 ESSB.
Signed-off-by: Ivan Malov
Reviewed-by: Andrew Rybchenko
Reviewed-by: Andy Moreton
---
drivers/common/sfc_efx/base/ef10_rx.c | 54 --
drivers/commo
MAE counter engine gets generation counts by virtue of the mark,
so the code to extract the field is already in place, but flow
action MARK doesn't benefit from it. Support this use case, too.
Signed-off-by: Ivan Malov
Reviewed-by: Andrew Rybchenko
Reviewed-by: Andy Moreton
---
drivers/net/sfc
Provide an API to let the application control the NIC's ability
to deliver specific kinds of per-packet metadata to the PMD.
Checks for the NIC's ability to set these kinds of metadata
in the first place (support for the flow actions) belong in
flow API responsibility domain (flow validate mechani
Initial support for the method. Later patches will extend it to
make FLAG and MARK delivery available on EF100 native datapath.
Signed-off-by: Ivan Malov
Reviewed-by: Andrew Rybchenko
Reviewed-by: Andy Moreton
---
drivers/net/sfc/sfc.h| 2 ++
drivers/net/sfc/sfc_ethdev.c | 29
In 2019, commit [1] announced changes in DEV_RX_OFFLOAD namespace
intending to add new flags, RSS_HASH and FLOW_MARK. Since then,
only the former has been added. The issue has not been solved.
Applications still assume that metadata features always work
and do not need to be configured in advance.
Hi Akhil,
Can this serie below be applied now?
Thanks and regards,
Nic
> -Original Message-
> From: Tom Rix
> Sent: Monday, September 13, 2021 1:02 PM
> To: Chautru, Nicolas ; dev@dpdk.org;
> gak...@marvell.com
> Cc: tho...@monjalon.net; hemant.agra...@nxp.com; Zhang, Mingshan
> ; Joshi,
Hi Akhil,
Can this be applied?
Thanks
Nic
> -Original Message-
> From: Tom Rix
> Sent: Saturday, September 11, 2021 12:19 PM
> To: Chautru, Nicolas ; dev@dpdk.org;
> gak...@marvell.com
> Cc: tho...@monjalon.net; Zhang, Mingshan ;
> Joshi, Arun ; sta...@dpdk.org
> Subject: Re: [PATCH v1]
> -Original Message-
> From: nipun.gu...@nxp.com
> Sent: Tuesday, September 28, 2021 1:30 AM
> To: dev@dpdk.org; gak...@marvell.com; Chautru, Nicolas
>
> Cc: david.march...@redhat.com; hemant.agra...@nxp.com; Nipun Gupta
>
> Subject: [PATCH v7 8/9] app/bbdev: handle endianness of test
Hi Nipin,
Based on patch 8/9 you should not need new vectors with different endianness.
Existing vectors should already be supported (ie all vectors must have the same
LE endianness assumption) and the bbdev-test will call reverse_all_ops to
change the endianness from the vectors when the endia
> -Original Message-
> From: nipun.gu...@nxp.com
> Sent: Tuesday, September 28, 2021 1:30 AM
> To: dev@dpdk.org; gak...@marvell.com; Chautru, Nicolas
>
> Cc: david.march...@redhat.com; hemant.agra...@nxp.com; Nipun Gupta
>
> Subject: [PATCH v7 6/9] baseband/la12xx: add enqueue and deq
> -Original Message-
> From: nipun.gu...@nxp.com
> Sent: Tuesday, September 28, 2021 1:30 AM
> To: dev@dpdk.org; gak...@marvell.com; Chautru, Nicolas
>
> Cc: david.march...@redhat.com; hemant.agra...@nxp.com; Nipun Gupta
>
> Subject: [PATCH v7 5/9] baseband/la12xx: add queue and modem
> -Original Message-
> From: nipun.gu...@nxp.com
> Sent: Tuesday, September 28, 2021 1:30 AM
> To: dev@dpdk.org; gak...@marvell.com; Chautru, Nicolas
>
> Cc: david.march...@redhat.com; hemant.agra...@nxp.com; Nipun Gupta
>
> Subject: [PATCH v7 1/9] bbdev: add big endian processing dat
> Subject: [PATCH v2 1/3] bus/vmbus: fix leak on device scan
>
> Caught running ASAN.
> The device name was leaked on scan.
> rte_device name field being a const, use a local pointer and release in error
> path.
>
> Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support")
> Cc: sta...@
On Fri, Sep 24, 2021 at 3:58 AM Chengwen Feng wrote:
>
> The 'dmadevice' is a generic type of DMA device.
>
> This patch introduce the 'dmadevice' device allocation APIs.
>
> The infrastructure is prepared to welcome drivers in drivers/dma/
>
> Signed-off-by: Chengwen Feng
> Acked-by: Bruce Richa
On Monday, October 10/04/21, 2021 at 18:27:54 +0100, Ferruh Yigit wrote:
> reported by "gcc (GCC) 12.0.0 20211003 (experimental)":
>
> ../drivers/net/cxgbe/cxgbe_ethdev.c:
> In function ‘cxgbe_dev_rx_queue_setup’:
> ../drivers/net/cxgbe/cxgbe_ethdev.c:682:24:
> error: the comparison wi
This inline function was added in 18.08
Signed-off-by: Stephen Hemminger
---
lib/mbuf/rte_mbuf.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h
index 6913b6d6f3ff..aa8a048934ad 100644
--- a/lib/mbuf/rte_mbuf.h
+++ b/lib/mbuf/rte_mbuf.h
@@ -272,7 +272
This function should be made stable now.
Cc: konstantin.anan...@intel.com
Signed-off-by: Stephen Hemminger
Acked-by: Andrew Rybchenko
---
lib/mbuf/rte_mbuf.h | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h
index ff6739ccc2a2..691
This one has been in for required time period.
Signed-off-by: Stephen Hemminger
Acked-by: Andrew Rybchenko
Acked-by: Olivier Matz
---
lib/mbuf/rte_mbuf.h | 1 -
lib/mbuf/version.map | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h
These functions to register dynamic fields were added in 20.11
and should be promoted to stable.
Signed-off-by: Stephen Hemminger
Acked-by: Andrew Rybchenko
Acked-by: Olivier Matz
---
lib/mbuf/rte_mbuf_dyn.h | 15 ---
lib/mbuf/version.map| 18 +-
2 files changed
These two functions were added in 20.11 as experimental.
Time to promote the to stable status.
Signed-off-by: Stephen Hemminger
Acked-by: Andrew Rybchenko
Acked-by: Olivier Matz
---
lib/mbuf/rte_mbuf.h | 2 --
lib/mbuf/version.map | 4 ++--
2 files changed, 2 insertions(+), 4 deletions(-)
di
These are all functions that have been around since at least 19.05
v4 - fix the tx_offload patch
add the mbuf_to_priv patch
Stephen Hemminger (5):
mbuf: make rte_pktmbuf_free_bulk and rte_pktmbuf_copy stable API's
mbuf: make rte_mbuf_dynfield API's stable
mbuf: make rte_mbuf_check part
On Sat, 2 Oct 2021 16:16:14 +0200
David Marchand wrote:
> Those accessors have been introduced more than two years ago
> (rte_mbuf_to_priv in v18.05, rte_mbuf_*_addr* in v19.02).
> Time to mark them stable.
>
> rte_mbuf_to_baddr() could be removed, but since we lack a deprecation
> notice, keep
Hi Jay,
> -Original Message-
> From: Jayatheerthan, Jay
> Sent: 04 October 2021 22:49
> To: Kundapura, Ganapati ;
> jerinjac...@gmail.com; dev@dpdk.org
> Subject: RE: [PATCH v4] eventdev/rx-adapter: fix segfault in queue conf get
>
> > -Original Message-
> > From: Kundapura, Gana
reported by "gcc (GCC) 12.0.0 20211003 (experimental)":
../drivers/net/cxgbe/cxgbe_ethdev.c:
In function ‘cxgbe_dev_rx_queue_setup’:
../drivers/net/cxgbe/cxgbe_ethdev.c:682:24:
error: the comparison will always evaluate as ‘true’ for the
address of ‘fl’ will never be NULL [
> -Original Message-
> From: Kundapura, Ganapati
> Sent: Friday, October 1, 2021 11:00 AM
> To: jerinjac...@gmail.com; dev@dpdk.org
> Cc: Jayatheerthan, Jay
> Subject: [PATCH v4] eventdev/rx-adapter: fix segfault in queue conf get
>
> rte_event_eth_rx_adapter_queue_conf_get() segfaults i
Reported by "gcc (GCC) 12.0.0 20211003 (experimental)":
./drivers/net/softnic/rte_eth_softnic_cli.c:
In function ‘tmgr_hierarchy_default’:
./drivers/net/softnic/rte_eth_softnic_cli.c:634:73:
error: the comparison will always evaluate as ‘true’ for the
address of ‘tc_valid’
> -Original Message-
> From: David Marchand
> Sent: Saturday, October 2, 2021 8:16 AM
> To: Wang, Yipeng1 ; Gobriel, Sameh
> ; Richardson, Bruce
> ; Medvedkin, Vladimir
>
> Cc: dev ; nd ; Dharmik Thakkar
> ; Joyce Kong ; Ruifeng
> Wang
> Subject: Re: [dpdk-dev] [PATCH] test/hash: use com
בתאריך יום ב׳, 4 באוק׳ 2021, 20:00, מאת Eric Christian :
> I am not sure that only we can recreate the KNI request overwrite. We may
> be the only ones with a current use case that exposes the vulnerability.
> It is possible for any KNI operation to encounter this issue with the new
> async mec
On 10/4/21 3:10 AM, Sean Morrissey wrote:
These header includes have been flagged by the iwyu_tool
and removed.
Signed-off-by: Sean Morrissey
---
lib/eal/common/eal_common_dev.c| 5 -
lib/eal/common/eal_common_devargs.c| 1 -
lib/eal/common/eal_common_errno.c | 4
On Mon, Oct 04, 2021 at 08:55:35AM -0700, Stephen Hemminger wrote:
> On Mon, 4 Oct 2021 10:10:53 +
> Sean Morrissey wrote:
>
> > This patchset introduces the include-what-you-use script which removes
> > unused header includes. IWYU GitHub:
> >
> > https://github.com/include-what-you-use/in
https://bugs.dpdk.org/show_bug.cgi?id=822
Bug ID: 822
Summary: failsafe build fails for gcc12
Product: DPDK
Version: 20.11
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: Nor
On 10/4/2021 1:02 PM, Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
wrote:
>
>
>> On 9/28/2021 2:51 PM, Junxiao Shi wrote:
>>> Previously, memif socket hash is always allocated on NUMA socket 0.
>>> If the application is entirely running on another NUMA socket and EAL
>>> --socket-li
Reported by "gcc (GCC) 12.0.0 20211003 (experimental)":
./drivers/net/ena/ena_rss.c: In function ‘ena_rss_reta_query’:
./drivers/net/ena/ena_rss.c:140:66:
error: the comparison will always evaluate as ‘false’ for the
pointer operand in ‘reta_conf + 136’ must not be NULL
[-W
I am not sure that only we can recreate the KNI request overwrite. We may
be the only ones with a current use case that exposes the vulnerability.
It is possible for any KNI operation to encounter this issue with the new
async mechanism. As long as the call to kni_net_process_request() is a
sepa
Some options are needed in the runtime many times, so leaving
it during compilation is not correct. As a result some options
has been exported into command line options to be used at run
time.
The options exported are:
--txq=N
--rxq=N
--txd=N
--rxd=N
--mbuf-size=N
--mbuf-cache-size=N
--total-mbuf-
On Mon, Oct 04, 2021 at 08:59:34AM -0700, Stephen Hemminger wrote:
> On Mon, 4 Oct 2021 15:13:22 +0300
> Gregory Etelson wrote:
>
> > diff --git a/app/test/test_flow_classify.c b/app/test/test_flow_classify.c
> > index 951606f248..4f64be5357 100644
> > --- a/app/test/test_flow_classify.c
> > +++
>
>
> > > > Current mempool per core cache implementation is based on pointer
> > > > For most architectures, each pointer consumes 64b Replace it with
> > > > index-based implementation, where in each buffer is addressed by
> > > > (pool address + index)
> > >
> > > I don't think it is going to
Adding Changpeng Liu from SPDK side.
On 10/4/21, 6:48 AM, "David Marchand" wrote:
On Thu, Sep 30, 2021 at 10:45 AM David Marchand
wrote:
> On Wed, Sep 29, 2021 at 9:38 AM Xia, Chenbo wrote:
> > @David, could you help me understand what is the compile error in
Fedora 31?
>
On Mon, Oct 4, 2021 at 7:05 PM Ferruh Yigit wrote:
> On 10/4/2021 3:58 PM, Elad Nachman wrote:
> > בתאריך יום ב׳, 4 באוק׳ 2021, 17:51, מאת Ferruh Yigit <
> > ferruh.yi...@intel.com>:
> >
> >> On 10/4/2021 3:25 PM, Elad Nachman wrote:
> >>
> >> Can you please try to not top post, it will make imp
RTE IPv4 header definition combines the `version' and `ihl' fields
into a single structure member.
This patch introduces dedicated structure members for both `version'
and `ihl' IPv4 fields. Separated header fields definitions allow to
create simplified code to match on the IHL value in a flow rul
On 10/4/2021 3:58 PM, Elad Nachman wrote:
> בתאריך יום ב׳, 4 באוק׳ 2021, 17:51, מאת Ferruh Yigit <
> ferruh.yi...@intel.com>:
>
>> On 10/4/2021 3:25 PM, Elad Nachman wrote:
>>
>> Can you please try to not top post, it will make impossible to follow this
>> discussion later from the mail archives.
On Mon, 4 Oct 2021 15:13:22 +0300
Gregory Etelson wrote:
> diff --git a/app/test/test_flow_classify.c b/app/test/test_flow_classify.c
> index 951606f248..4f64be5357 100644
> --- a/app/test/test_flow_classify.c
> +++ b/app/test/test_flow_classify.c
> @@ -95,7 +95,7 @@ static struct rte_acl_field_d
On Mon, 4 Oct 2021 10:10:53 +
Sean Morrissey wrote:
> This patchset introduces the include-what-you-use script which removes
> unused header includes. IWYU GitHub:
>
> https://github.com/include-what-you-use/include-what-you-use
>
> Along with the script there are some patches which make a
On Fri, Sep 17, 2021 at 10:08 AM wrote:
>
> From: Satheesh Paul
>
> Upon MCAM allocation failure, free counters only if counters
> were allocated earlier for the flow rule.
>
> Fixes: f9af9080746 ("common/cnxk: add mcam utility API")
>
> Signed-off-by: Satheesh Paul
Acked-by: Jerin Jacob
Appli
On Mon, 4 Oct 2021 01:41:08 +0530
wrote:
> From: Pavan Nikhilesh
>
> Increase the number of routes from 8 to 16 that are statically added for
> lpm and em mode as most of the SoCs support more than 8 interfaces.
> The number of routes added is equal to the number of ethernet devices
> ports ena
Hi Ivan,
> -Original Message-
> From: Ivan Malov
> Sent: Monday, October 4, 2021 2:06 PM
> Cc: dev@dpdk.org
> Subject: Re: [PATCH v1 02/12] ethdev: add eswitch port item to flow API
>
> Hi Ori,
>
> On 04/10/2021 08:45, Ori Kam wrote:
> > Hi Ivan,
> >
> >> -Original Message-
> >>
On 10/4/2021 3:14 PM, Eric Christian wrote:
> Adding Sahithi.
>
> I believe adding the -EAGAIN method puts the responsibility on the
> application/caller. If we take the change MAC address as an example. Most
> application code just does this kind of check:
>
> ret = ioctl(sockfd, SIOCS
On Mon, Oct 04, 2021 at 10:10:54AM +, Sean Morrissey wrote:
> This script can be used for removing headers flagged for removal by the
> include-what-you-use (IWYU) tool. The script has the ability to remove
> headers from specified sub-directories or dpdk as a whole.
>
Since it also is importi
בתאריך יום ב׳, 4 באוק׳ 2021, 17:51, מאת Ferruh Yigit <
ferruh.yi...@intel.com>:
> On 10/4/2021 3:25 PM, Elad Nachman wrote:
>
> Can you please try to not top post, it will make impossible to follow this
> discussion later from the mail archives.
>
> > 1. Userspace will get an error
>
> So there i
On 10/4/2021 12:18 PM, Nicolau, Radu wrote:
On 10/4/2021 3:15 AM, Wu, Jingjing wrote:
-Original Message-
From: Nicolau, Radu
Sent: Friday, October 1, 2021 5:52 PM
To: Wu, Jingjing ; Xing, Beilei
Cc: dev@dpdk.org; Doherty, Declan ; Sinha,
Abhijit
; Zhang, Qi Z ;
Richardson, Bruc
On 10/4/2021 3:25 PM, Elad Nachman wrote:
Can you please try to not top post, it will make impossible to follow this
discussion later from the mail archives.
> 1. Userspace will get an error
So there is nothing special with returning '-EAGAIN', user will only observe an
error.
Wasn't initial int
On 2021-10-04 12:23, Van Haaren, Harry wrote:
>> -Original Message-
>> From: Morrissey, Sean
>> Sent: Monday, October 4, 2021 11:11 AM
>> To: Burakov, Anatoly ; Jerin Jacob
>> ; Sunil Kumar Kori ; mattias.ronnblom
>> ; Van Haaren, Harry
>> ; Harman Kalra ;
>> Richardson, Bruce ; Ananyev, K
Copy public function pointers (rx_pkt_burst(), etc.) and related
pointers to internal data from rte_eth_dev structure into a
separate flat array. That array will remain in a public header.
The intention here is to make rte_eth_dev and related structures internal.
That should allow future possible c
This patch adds missing IPv6-Ex and GTPU flow types to port
info command. It also add the same definitions to
str2flowtype(), used to configure flow director.
Signed-off-by: Maxime Coquelin
---
app/test-pmd/cmdline.c | 4
app/test-pmd/config.c | 4
2 files changed, 8 insertions(+)
di
This patch fixes RETA updating for entries above 64.
Without ithat, these entries are never updated as
calculated mask value will always be 0.
Fixes: 634efbc2c8c0 ("mlx5: support RETA query and update")
Cc: sta...@dpdk.org
Cc: nelio.laranje...@6wind.com
Signed-off-by: Maxime Coquelin
Acked-by: V
This patch fixes the display of the RSS hash types
configured in the port, which displayed "all" even
if only a single type was configured
Fixes: 3c90743dd3b9 ("app/testpmd: support more types for flow RSS")
Cc: sta...@dpdk.org
Signed-off-by: Maxime Coquelin
Acked-by: Xiaoyun Li
Reviewed-by: Ch
port_rss_hash_key_update() initializes rss_conf with the
RSS key configuration provided by the user, but it calls
rte_eth_dev_rss_hash_conf_get() before calling
rte_eth_dev_rss_hash_update(), which overrides the parsed
RSS config.
While the RSS key value is set again after, this is not
the case o
Provide the capability to update the hash key, hash types
and RETA table on the fly (without needing to stop/start
the device). However, the key length and the number of RETA
entries are fixed to 40B and 128 entries respectively. This
is done in order to simplify the design, but may be
revisited la
This series is mainly adding support for RSS to Virtio PMD
driver. The two last patches are fixing an issue in testpmd
that could cause out of bounds access, and fix
an issue spotted in the mlx5 driver while looking for
inspiration.
The first motivation for this series is to eventually
support RSS
1. Userspace will get an error
2. Waiting with rtnl locked causes a deadlock; waiting with rtnl unlocked
for interface down command causes a crash because of a race condition in
the device delete/unregister list in the kernel.
FYI,
Elad.
בתאריך יום ב׳, 4 באוק׳ 2021, 17:13, מאת Ferruh Yigit <
fe
From: Pavan Nikhilesh
Add reassembly perf autotest for both ipv4 and ipv6 reassembly.
Each test is performed with variable number of fragments per flow,
either ordered or unordered fragments and interleaved flows.
Signed-off-by: Pavan Nikhilesh
---
v3 Changes:
- Fix checkpatch issues.
v2 Cha
At queue configure stage always allocate space for maximum possible
number (RTE_MAX_QUEUES_PER_PORT) of queue pointers.
That will allow 'fast' inline functions (eth_rx_burst, etc.) to refer
pointer to internal queue data without extra checking of current number
of configured queues.
That would help
Adding Sahithi.
I believe adding the -EAGAIN method puts the responsibility on the
application/caller. If we take the change MAC address as an example. Most
application code just does this kind of check:
ret = ioctl(sockfd, SIOCSIFHWADDR, &ifr);
if (ret < 0) {
P
On 10/4/2021 2:09 PM, Elad Nachman wrote:
> Hi,
>
> EAGAIN is propogated back to the kernel and to the caller.
>
So will the user get an error, or it will be handled by the kernel and retried?
> We cannot retry from the kni kernel module since we hold the rtnl lock.
>
Why not? We are already
Hi Dmitry,
Please find my comments inline.
> -Original Message-
> From: Dmitry Kozlyuk
> Sent: Sunday, October 3, 2021 11:46 PM
> To: Harman Kalra
> Cc: dev@dpdk.org; Anatoly Burakov
> Subject: [EXT] Re: [dpdk-dev] [PATCH v1 6/7] eal/interrupts: make interrupt
> handle structure opaque
> -Original Message-
> From: Dmitry Kozlyuk
> Sent: Monday, October 4, 2021 4:48 PM
> To: Harman Kalra
> Cc: dev@dpdk.org; Ray Kinsella ; David Marchand
>
> Subject: Re: [EXT] Re: [dpdk-dev] [PATCH v1 2/7] eal/interrupts: implement
> get set APIs
>
> 2021-10-04 10:37 (UTC+), Harm
rte_eth_rx_descriptor_status() should be used as a replacement.
Signed-off-by: Andrew Rybchenko
Reviewed-by: Ferruh Yigit
Acked-by: Konstantin Ananyev
---
doc/guides/nics/features.rst| 6 +-
doc/guides/rel_notes/deprecation.rst| 5 -
doc/guides/rel_notes/release_21_11
Introduce rte_eth_macaddrs_get() to allow user to retrieve all ethernet
addresses assigned to given port.
Change testpmd to use this new function and avoid referencing directly
rte_eth_devices[].
Signed-off-by: Konstantin Ananyev
---
app/test-pmd/config.c | 23 +++---
Move rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback and related
data into private header (ethdev_driver.h).
Few minor changes to keep DPDK building after that.
Signed-off-by: Konstantin Ananyev
---
doc/guides/rel_notes/release_21_11.rst| 6 +
drivers/common/octeontx2/otx2_sec_ide
Rework 'fast' burst functions to use rte_eth_fp_ops[].
While it is an API/ABI breakage, this change is intended to be
transparent for both users (no changes in user app is required) and
PMD developers (no changes in PMD is required).
One extra thing to note - RX/TX callback invocation will cause ex
v4 changes:
- Fix secondary process attach (Pavan)
- Fix build failure (Ferruh)
- Update lib/ethdev/verion.map (Ferruh)
Note that moving newly added symbols from EXPERIMENTAL to DPDK_22
section makes checkpatch.sh to complain.
v3 changes:
- Changes in public struct naming (Jerin/Haiyue)
Currently majority of 'fast' ethdev ops take pointers to internal
queue data structures as an input parameter.
While eth_rx_queue_count() takes a pointer to rte_eth_dev and queue
index.
For future work to hide rte_eth_devices[] and friends it would be
plausible to unify parameters list of all 'fast
On 10/4/21 2:39 PM, Ivan Malov wrote:
> On 04/10/2021 09:56, Ori Kam wrote:
>>> On 04/10/2021 00:04, Ori Kam wrote:
I understand that you are only talking about enabling the action,
meaning to let the PMD know that at some point there will be a rule
that will use the mark action for
1 - 100 of 167 matches
Mail list logo
