[dpdk-dev] [PATCH v3 14/14] eventdev: mark trace variables as internal

2021-10-05 Thread pbhagavatula
From: Pavan Nikhilesh Mark rte_trace global variables as internal i.e. remove them from experimental section of version map. Some of them are used in inline APIs, mark those as global. Signed-off-by: Pavan Nikhilesh Acked-by: Ray Kinsella --- lib/eventdev/version.map | 77 ++--

[dpdk-dev] [PATCH v3 13/14] eventdev: make trace APIs internal

2021-10-05 Thread pbhagavatula
From: Pavan Nikhilesh Slowpath trace APIs are only used in rte_eventdev.c so make them as internal. Signed-off-by: Pavan Nikhilesh Acked-by: Jay Jayatheerthan --- lib/eventdev/{rte_eventdev_trace.h => eventdev_trace.h} | 0 lib/eventdev/eventdev_trace_points.c| 2 +- lib/e

[dpdk-dev] [PATCH v3 12/14] eventdev: promote event vector API to stable

2021-10-05 Thread pbhagavatula
From: Pavan Nikhilesh Promote event vector configuration APIs to stable. Signed-off-by: Pavan Nikhilesh Acked-by: Jay Jayatheerthan Acked-by: Ray Kinsella --- lib/eventdev/rte_event_eth_rx_adapter.h | 2 -- lib/eventdev/rte_eventdev.h | 1 - lib/eventdev/version.map

[dpdk-dev] [PATCH v3 11/14] eventdev: move timer adapters memory to hugepage

2021-10-05 Thread pbhagavatula
From: Pavan Nikhilesh Move memory used by timer adapters to hugepage. Allocate memory on the first adapter create or lookup to address both primary and secondary process usecases. This will prevent TLB misses if any and aligns to memory structure of other subsystems. Signed-off-by: Pavan Nikhile

[dpdk-dev] [PATCH v3 10/14] eventdev: rearrange fields in timer object

2021-10-05 Thread pbhagavatula
From: Pavan Nikhilesh Rearrange fields in rte_event_timer data structure to remove holes. Also, remove use of volatile from rte_event_timer. Signed-off-by: Pavan Nikhilesh --- lib/eventdev/rte_event_timer_adapter.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/eve

[dpdk-dev] [PATCH v3 09/14] eventdev: remove rte prefix for internal structs

2021-10-05 Thread pbhagavatula
From: Pavan Nikhilesh Remove rte_ prefix from rte_eth_event_enqueue_buffer, rte_event_eth_rx_adapter and rte_event_crypto_adapter as they are only used in rte_event_eth_rx_adapter.c and rte_event_crypto_adapter.c Signed-off-by: Pavan Nikhilesh Acked-by: Jay Jayatheerthan --- lib/eventdev/rte_

[dpdk-dev] [PATCH v3 08/14] eventdev: hide timer adapter PMD file

2021-10-05 Thread pbhagavatula
From: Pavan Nikhilesh Hide rte_event_timer_adapter_pmd.h file as it is an internal file. Remove rte_ prefix from rte_event_timer_adapter_ops structure. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cnxk_tim_evdev.c | 5 ++-- drivers/event/cnxk/cnxk_tim_evdev.h | 2

[dpdk-dev] [PATCH v3 07/14] eventdev: hide event device related structures

2021-10-05 Thread pbhagavatula
From: Pavan Nikhilesh Move rte_eventdev, rte_eventdev_data structures to eventdev_pmd.h. Signed-off-by: Pavan Nikhilesh --- drivers/event/dlb2/dlb2_inline_fns.h | 2 + drivers/event/dsw/dsw_evdev.h | 2 + drivers/event/octeontx/timvf_worker.h | 2 + drivers/net/octeontx/octeontx

[dpdk-dev] [PATCH v3 06/14] eventdev: use new API for inline functions

2021-10-05 Thread pbhagavatula
From: Pavan Nikhilesh Use new driver interface for the fastpath enqueue/dequeue inline functions. Signed-off-by: Pavan Nikhilesh Acked-by: Jay Jayatheerthan --- lib/eventdev/rte_event_crypto_adapter.h | 15 +--- lib/eventdev/rte_event_eth_tx_adapter.h | 15 lib/eventdev/rte_event

[dpdk-dev] [PATCH v3 05/14] drivers/event: invoke probing finish function

2021-10-05 Thread pbhagavatula
From: Pavan Nikhilesh Invoke event_dev_probing_finish() functions at the end of probing, this function sets the function pointers in the fp_ops flat array. Signed-off-by: Pavan Nikhilesh --- drivers/event/dpaa/dpaa_eventdev.c | 4 +++- drivers/event/dpaa2/dpaa2_eventdev.c | 4 +++

[dpdk-dev] [PATCH v3 04/14] eventdev: move inline APIs into separate structure

2021-10-05 Thread pbhagavatula
From: Pavan Nikhilesh Move fastpath inline function pointers from rte_eventdev into a separate structure accessed via a flat array. The intension is to make rte_eventdev and related structures private to avoid future API/ABI breakages.` Signed-off-by: Pavan Nikhilesh Acked-by: Ray Kinsella ---

[dpdk-dev] [PATCH v3 03/14] eventdev: allocate max space for internal arrays

2021-10-05 Thread pbhagavatula
From: Pavan Nikhilesh Allocate max space for internal port, port config, queue config and link map arrays. Introduce new macro RTE_EVENT_MAX_PORTS_PER_DEV and set it to max possible value. This simplifies the port and queue reconfigure scenarios and will also allow inline functions to refer point

[dpdk-dev] [PATCH v3 02/14] eventdev: separate internal structures

2021-10-05 Thread pbhagavatula
From: Pavan Nikhilesh Create rte_eventdev_core.h and move all the internal data structures to this file. These structures are mostly used by drivers, but they need to be in the public header file as they are accessed by datapath inline functions for performance reasons. The accessibility of these

[dpdk-dev] [PATCH v3 01/14] eventdev: make driver interface as internal

2021-10-05 Thread pbhagavatula
From: Pavan Nikhilesh Mark all the driver specific functions as internal, remove `rte` prefix from `struct rte_eventdev_ops`. Remove experimental tag from internal functions. Remove `eventdev_pmd.h` from non-internal header files. Signed-off-by: Pavan Nikhilesh --- v3 Changes: - Reset fp_ops

[dpdk-dev] [PATCH] net/nfp: cancel delayed LSC work in port close logic

2021-10-05 Thread heinrich . kuhn
From: Heinrich Kuhn The link state change interrupt handler of the NFP PMD will delay the actual LSC work for a short period to ensure the link is stable. If the link of the port changes state and the port is closed immediately after the link event then a segmentation fault will occur. This happe

Re: [dpdk-dev] [PATCH v7 4/5] eventdev/rx_adapter: implement per queue event buffer

2021-10-05 Thread Jayatheerthan, Jay
> -Original Message- > From: Naga Harish K, S V > Sent: Wednesday, October 6, 2021 9:33 AM > To: jer...@marvell.com; Jayatheerthan, Jay > Cc: dev@dpdk.org > Subject: [PATCH v7 4/5] eventdev/rx_adapter: implement per queue event buffer > > this patch implement the per queue event buffer w

Re: [dpdk-dev] [PATCH v7 1/5] eventdev/rx_adapter: add event buffer size configurability

2021-10-05 Thread Jayatheerthan, Jay
Acked-by: Jay Jayatheerthan > -Original Message- > From: Naga Harish K, S V > Sent: Wednesday, October 6, 2021 9:33 AM > To: jer...@marvell.com; Jayatheerthan, Jay > Cc: dev@dpdk.org; Kundapura, Ganapati > Subject: [PATCH v7 1/5] eventdev/rx_adapter: add event buffer size > configurab

Re: [dpdk-dev] [PATCH v4 4/4] net/ixgbe: build on Windows

2021-10-05 Thread Kadam, Pallavi
On 10/5/2021 10:02 AM, William Tu wrote: This patch enables building the ixgbe driver for Windows. It also enables its dependencies on security and cryptodev. I tested on AWS using ixgbe VF device, using dpdk-testpmd. Signed-off-by: William Tu --- should we mention the added support in the

Re: [dpdk-dev] [PATCH v2 0/7] Removal of PCI bus ABIs

2021-10-05 Thread Xia, Chenbo
Thanks David for helping check this and including SPDK folks! Hi Changpeng, Although we have synced about this during last release's deprecation notice, I’d like to summarize two points for SPDK to change if this patchset applied. 1. The pci bus header for drivers will only be exposed if meson o

Re: [dpdk-dev] [PATCH v5 4/5] eventdev/rx_adapter: implement per queue event buffer

2021-10-05 Thread Naga Harish K, S V
Hi Jay, > -Original Message- > From: Jayatheerthan, Jay > Sent: Tuesday, October 5, 2021 8:31 PM > To: Naga Harish K, S V ; jer...@marvell.com > Cc: dev@dpdk.org > Subject: RE: [PATCH v5 4/5] eventdev/rx_adapter: implement per queue > event buffer > > > -Original Message- > > Fro

[dpdk-dev] [PATCH v7 5/5] test/event: add unit test for Rx adapter

2021-10-05 Thread Naga Harish K S V
this patch adds unit tests for checking per rx queue event buffer feature using rte_event_eth_rx_adapter_queue_add api. Signed-off-by: Naga Harish K S V --- app/test/test_event_eth_rx_adapter.c | 86 1 file changed, 86 insertions(+) diff --git a/app/test/test_event_

[dpdk-dev] [PATCH v7 4/5] eventdev/rx_adapter: implement per queue event buffer

2021-10-05 Thread Naga Harish K S V
this patch implement the per queue event buffer with required validations. Signed-off-by: Naga Harish K S V --- lib/eventdev/rte_event_eth_rx_adapter.c | 206 ++-- 1 file changed, 153 insertions(+), 53 deletions(-) diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/

[dpdk-dev] [PATCH v7 3/5] eventdev/rx_adapter: introduce per queue event buffer

2021-10-05 Thread Naga Harish K S V
To configure per queue event buffer size, application sets ``rte_event_eth_rx_adapter_params::use_queue_event_buf`` flag as true and is passed to ``rte_event_eth_rx_adapter_create_with_params`` api. The per queue event buffer size is populated in ``rte_event_eth_rx_adapter_queue_conf::event_buf_s

[dpdk-dev] [PATCH v7 2/5] test/event: add unit test for Rx adapter

2021-10-05 Thread Naga Harish K S V
this patch adds unit test for rte_event_eth_rx_adapter_create_with_params api and validate all possible input combinations. Signed-off-by: Naga Harish K S V --- app/test/test_event_eth_rx_adapter.c | 53 +--- 1 file changed, 49 insertions(+), 4 deletions(-) diff --git a/

[dpdk-dev] [PATCH v7 1/5] eventdev/rx_adapter: add event buffer size configurability

2021-10-05 Thread Naga Harish K S V
Currently event buffer is static array with a default size defined internally. To configure event buffer size from application, ``rte_event_eth_rx_adapter_create_with_params`` api is added which takes ``struct rte_event_eth_rx_adapter_params`` to configure event buffer size in addition other param

Re: [dpdk-dev] [PATCH v4 1/6] ethdev: fix max Rx packet length

2021-10-05 Thread Ajit Khaparde
On Tue, Oct 5, 2021 at 10:31 AM Ferruh Yigit wrote: > > There is a confusion on setting max Rx packet length, this patch aims to > clarify it. > > 'rte_eth_dev_configure()' API accepts max Rx packet size via > 'uint32_t max_rx_pkt_len' field of the config struct 'struct > rte_eth_conf'. > > Also '

Re: [dpdk-dev] [PATCH v5 1/5] ethdev: negotiate delivery of packet metadata from HW to PMD

2021-10-05 Thread Ajit Khaparde
On Tue, Oct 5, 2021 at 8:56 AM Ivan Malov wrote: > > Provide an API to let the application control the NIC's ability > to deliver specific kinds of per-packet metadata to the PMD. > > Checks for the NIC's ability to set these kinds of metadata > in the first place (support for the flow actions) be

Re: [dpdk-dev] [PATCH] ethdev: remove deprecated shared counter attribute

2021-10-05 Thread Ajit Khaparde
On Tue, Oct 5, 2021 at 12:11 PM Thomas Monjalon wrote: > 28/09/2021 17:23, Andrew Rybchenko: > > Indirect actions should be used to do shared counters. > > > > Signed-off-by: Andrew Rybchenko > > Acked-by: Thomas Monjalon > Acked-by: Ajit Khaparde > > Thanks Andrew, we need more maintainers

Re: [dpdk-dev] [PATCH v4 4/4] net/ixgbe: build on Windows

2021-10-05 Thread Dmitry Kozlyuk
2021-10-05 17:02 (UTC+), William Tu: > This patch enables building the ixgbe driver for Windows. > It also enables its dependencies on security and cryptodev. > I tested on AWS using ixgbe VF device, using dpdk-testpmd. > > Signed-off-by: William Tu Acked-by: Dmitry Kozlyuk

Re: [dpdk-dev] [PATCH v6 1/2] ethdev: make queue release callback optional

2021-10-05 Thread Thomas Monjalon
30/09/2021 17:17, Xueming Li: > Some drivers don't need Rx and Tx queue release callback, make them > optional. Clean up empty queue release callbacks for some drivers. > > Signed-off-by: Xueming Li > Reviewed-by: Andrew Rybchenko > Acked-by: Ferruh Yigit Acked-by: Thomas Monjalon

Re: [dpdk-dev] [PATCH v4 1/2] ethdev: make queue release callback optional

2021-10-05 Thread Thomas Monjalon
18/09/2021 08:44, Andrew Rybchenko: > On 9/17/21 5:28 PM, Xueming Li wrote: > > Some drivers don't need Rx and Tx queue release callback, make them > > optional. Clean up empty queue release callbacks for some drivers. > > > > Signed-off-by: Xueming Li > > Many thanks, > > Reviewed-by: Andrew Ry

Re: [dpdk-dev] [PATCH v5] ethdev: fix representor port ID search by name

2021-10-05 Thread Thomas Monjalon
13/09/2021 13:26, Andrew Rybchenko: > From: Viacheslav Galaktionov > > Getting a list of representors from a representor does not make sense. > Instead, a parent device should be used. I don't understand which issue it is fixing. This function was not working before if not using the backer port?

Re: [dpdk-dev] RHEL7 failures

2021-10-05 Thread Ferruh Yigit
On 10/5/2021 8:09 PM, Lincoln Lavoie wrote: Hello Qiming and Qi, The CI is picking up failures when building on RHEL7, where warnings are being treated as errors. This looks like something has been merged into the mainline, as it's failing across all patches. Here is the specific failure: ./d

[dpdk-dev] [PATCH v2] ethdev: add API to query proxy port to manage transfer flows

2021-10-05 Thread Ivan Malov
Not all DPDK ports in a given e-switch domain may have the privilege to manage "transfer" flows. Add an API to find a port with sufficient privileges by any port in the domain. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Acked-by: Ori Kam --- Patch series [1] has reworked support fo

Re: [dpdk-dev] [PATCH v4 2/2] cmdline: make struct rdline opaque

2021-10-05 Thread Stephen Hemminger
On Tue, 5 Oct 2021 23:15:45 +0300 Dmitry Kozlyuk wrote: > +++ b/app/test/test_cmdline_lib.c > @@ -83,18 +83,19 @@ test_cmdline_parse_fns(void) > static int > test_cmdline_rdline_fns(void) > { > - struct rdline rdl; > + struct rdline *rdl = NULL; Very minor nit. The variable does not

[dpdk-dev] [PATCH v4 2/2] cmdline: make struct rdline opaque

2021-10-05 Thread Dmitry Kozlyuk
Hide struct rdline definition and some RDLINE_* constants in order to be able to change internal buffer sizes transparently to the user. Add new functions: * rdline_new(): allocate and initialize struct rdline. This function replaces rdline_init() and takes an extra parameter: opaque user data

[dpdk-dev] [PATCH v4 1/2] cmdline: make struct cmdline opaque

2021-10-05 Thread Dmitry Kozlyuk
Remove the definition of `struct cmdline` from public header. Deprecation notice: https://mails.dpdk.org/archives/dev/2020-September/183310.html Signed-off-by: Dmitry Kozlyuk Acked-by: David Marchand Acked-by: Olivier Matz --- doc/guides/rel_notes/deprecation.rst | 4 doc/guides/rel_no

[dpdk-dev] [PATCH v4 0/2] cmdline: reduce ABI

2021-10-05 Thread Dmitry Kozlyuk
Hide struct cmdline following the deprecation notice. Hide struct rdline following the v1 discussion. v4: rdline_create -> rdline_new, restore empty line (Olivier). v3: add experimental tags and releae notes for rdline. v2: also hide struct rdline (David, Olivier). Dmitry Kozlyuk (2): cmdline:

Re: [dpdk-dev] [PATCH] ethdev: let apps find transfer admin port for a given ethdev

2021-10-05 Thread Ori Kam
Hi Ivan, I agree with your reply. Acked-by: Ori Kam Thanks, Ori > -Original Message- > From: Ivan Malov > Subject: Re: [PATCH] ethdev: let apps find transfer admin port for a given > ethdev > > Hi Ori, > > Thanks a lot for eagerly reviewing this and related patches. That's very > he

Re: [dpdk-dev] [PATCH 3/3] test/devargs: add devargs test cases

2021-10-05 Thread Xueming(Steven) Li
On Tue, 2021-10-05 at 16:01 +0200, David Marchand wrote: > On Tue, Oct 5, 2021 at 2:31 PM Xueming Li wrote: > > diff --git a/app/test/meson.build b/app/test/meson.build > > index f144d8b8ed6..c688ba2b70a 100644 > > --- a/app/test/meson.build > > +++ b/app/test/meson.build > > @@ -42,6 +42,7 @@ tes

[dpdk-dev] [PATCH v1 2/3] devargs: make bus key parsing optional

2021-10-05 Thread Xueming Li
Global devargs syntax is used as device iteration filter like "class=vdpa", a devargs without bus args is valid from parsing perspective. This patch makes bus args optional. Fixes: d2a66ad79480 ("bus: add device arguments name parsing") Cc: sta...@dpdk.org Signed-off-by: Xueming Li --- drivers

[dpdk-dev] [PATCH v1 3/3] test/devargs: add devargs test cases

2021-10-05 Thread Xueming Li
Initial version to test Global devargs syntax. Signed-off-by: Xueming Li --- app/test/autotest_data.py | 6 ++ app/test/meson.build | 2 + app/test/test_devargs.c | 147 ++ 3 files changed, 155 insertions(+) create mode 100644 app/test/test_devargs

[dpdk-dev] [PATCH v1 1/3] devargs: support path value for global device arguments

2021-10-05 Thread Xueming Li
Slash is used to split global device arguments. To support path value which contains slash, this patch parses devargs by locating both slash and layer name key: bus=a,name=/some/path/class=b,k1=v1/driver=c,k2=v2 "/class=" and "/driver" are valid start of a layer. Signed-off-by: Xueming Li ---

[dpdk-dev] [PATCH v1 0/3] devargs: support path in global syntax

2021-10-05 Thread Xueming Li
- Support path in global syntax. - Fix bus name resolving - Add devargs test cases v1: add test cases to test suite Xueming Li (3): devargs: support path value for global device arguments devargs: make bus key parsing optional test/devargs: add devargs test cases app/test/autotest_data.py

Re: [dpdk-dev] [PATCH] ethdev: fix one MAC address occupies two index in mac addrs

2021-10-05 Thread Thomas Monjalon
22/09/2021 05:36, Min Hu (Connor): > From: Huisong Li > > Use the testpmd to perform the following operations: > 1) mac_addr add 0 00:18:2D:00:00:90 > 2) mac_addr add 0 00:18:2D:00:00:91 > 3) mac_addr add 0 00:18:2D:00:00:92 > 4) mac_addr set 0 00:18:2D:00:00:91 > 5) show port 0 macs > Number of

Re: [dpdk-dev] [PATCH v2] ethdev: replace bit shifts with macros

2021-10-05 Thread Thomas Monjalon
23/09/2021 11:39, Thomas Monjalon: > The macros RTE_BIT32 and RTE_BIT64 are used to replace bit shifts. > The macro UINT64C is also used to replace remaining occurrences of ULL. > > Only bit shifts of ETH_RSS_LEVEL_* are kept for aesthetic reason. > > The API of rte_mtr and rte_tm is using enums

Re: [dpdk-dev] [PATCH] ethdev: remove legacy Rx descriptor done API

2021-10-05 Thread Thomas Monjalon
28/09/2021 17:48, Andrew Rybchenko: > rte_eth_rx_descriptor_status() should be used as a replacement. > > Signed-off-by: Andrew Rybchenko [...] > @@ -126,6 +126,10 @@ Removed Items >blacklist/whitelist are removed. Users must use the new >block/allow list arguments. > > +* ethdev: Remov

Re: [dpdk-dev] [PATCH] ethdev: remove deprecated shared counter attribute

2021-10-05 Thread Thomas Monjalon
28/09/2021 17:23, Andrew Rybchenko: > Indirect actions should be used to do shared counters. > > Signed-off-by: Andrew Rybchenko Acked-by: Thomas Monjalon Thanks Andrew, we need more maintainers like you :)

[dpdk-dev] RHEL7 failures

2021-10-05 Thread Lincoln Lavoie
Hello Qiming and Qi, The CI is picking up failures when building on RHEL7, where warnings are being treated as errors. This looks like something has been merged into the mainline, as it's failing across all patches. Here is the specific failure: ./drivers/net/ice/base/ice_parser_rt.c: In functi

Re: [dpdk-dev] [PATCH 3/4] ethdev: support PPPoL2TPv2oUDP RSS Hash

2021-10-05 Thread Ori Kam
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, October 5, 2021 5:43 PM > To: Ori Kam ; Jie Wang ; > dev@dpdk.org; andrew.rybche...@oktetlabs.ru > Cc: NBU-Contact-Thomas Monjalon ; > xiaoyun...@intel.com; jingjing...@intel.com; beilei.x...@intel.com; > wenjun1...@intel.com; st

Re: [dpdk-dev] [PATCH] ethdev: let apps find transfer admin port for a given ethdev

2021-10-05 Thread Thomas Monjalon
05/10/2021 20:22, Ivan Malov: > Hi Thomas, > > Thanks for joining the review. > > On 05/10/2021 20:56, Thomas Monjalon wrote: > > 05/10/2021 02:36, Ivan Malov: > >> Introduce a helper API to let applications find transfer > >> admin port for a given ethdev to avoid failures when > >> managing "tr

[dpdk-dev] [RFC PATCH] gpu/cuda

2021-10-05 Thread eagost...@nvidia.com
>From 8b603e6a9aa7bf1c5e89bad49f0f4a1b902dd299 Mon Sep 17 00:00:00 2001 From: Elena Agostini Date: Wed, 15 Sep 2021 17:04:53 +0200 Subject: [PATCH] gpu/cuda: introduce CUDA driver This is the CUDA implementation of the gpudev library. Funcitonalities implemented through CUDA Driver API are: - De

[dpdk-dev] [RFC PATCH] gpu/cuda: introduce CUDA driver

2021-10-05 Thread eagostini
From: Elena Agostini This is the CUDA implementation of the gpudev library. Funcitonalities implemented through CUDA Driver API are: - Device probe and remove - Manage device memory allocations - Register/unregister external CPU memory in the device memory area Signed-off-by: Elena Agostini --

Re: [dpdk-dev] [PATCH] ethdev: let apps find transfer admin port for a given ethdev

2021-10-05 Thread Ivan Malov
Hi Thomas, Thanks for joining the review. On 05/10/2021 20:56, Thomas Monjalon wrote: 05/10/2021 02:36, Ivan Malov: Introduce a helper API to let applications find transfer admin port for a given ethdev to avoid failures when managing "transfer" flows through unprivileged ports. Please expla

Re: [dpdk-dev] [PATCH] ethdev: let apps find transfer admin port for a given ethdev

2021-10-05 Thread Thomas Monjalon
05/10/2021 02:36, Ivan Malov: > Introduce a helper API to let applications find transfer > admin port for a given ethdev to avoid failures when > managing "transfer" flows through unprivileged ports. Please explain what is transfer admin port. We may find a simpler wording. > --- a/lib/ethdev/rte

Re: [dpdk-dev] [PATCH v4 5/7] ethdev: add API to retrieve multiple ethernet addresses

2021-10-05 Thread Thomas Monjalon
05/10/2021 19:12, Ananyev, Konstantin: > > 05/10/2021 18:35, Ananyev, Konstantin: > > > > 04/10/2021 15:56, Konstantin Ananyev: > > > > > Introduce rte_eth_macaddrs_get() to allow user to retrieve all > > > > > ethernet > > > > > addresses assigned to given port. > > > > > > > > We already have fu

Re: [dpdk-dev] [PATCH v5 1/3] eal/linux: make hugetlbfs analysis reusable

2021-10-05 Thread Thomas Monjalon
21/09/2021 10:16, dkozl...@oss.nvidia.com: > From: Dmitry Kozlyuk > > get_hugepage_dir() searched for a hugetlbfs mount with a given page size > using handcraft parsing of /proc/mounts and mixing traversal logic with > selecting the needed entry. Separate code to enumerate hugetlbfs mounts > to e

Re: [dpdk-dev] [PATCH v2 0/2] net/cxgbe: add VF xstats and firmware version

2021-10-05 Thread Ferruh Yigit
On 9/30/2021 6:09 PM, Rahul Lakkireddy wrote: This series of patches add following features. Patch 1 adds support to fetch port and queue stats via xstats API for VF. Patch 2 adds support to get firmware version. Thanks, Rahul --- v2: - Update Extended Stats and FW version features in cxgbe.i

[dpdk-dev] [PATCH 1/2] lib/ethdev: introduce RTE_ETH_DEV_CAPA_FLOW_CREATE_BEFORE_START

2021-10-05 Thread Martin Havlik
Not all PMDs allow RTE flow rules to be created before start. This capability will be set for the ones that allow it. Signed-off-by: Martin Havlik --- lib/ethdev/rte_ethdev.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h index bef24173cf.

Re: [dpdk-dev] [RFC PATCH 0/2] Flow entities behavior across port restart

2021-10-05 Thread Thomas Monjalon
> Dmitry Kozlyuk (2): > ethdev: add capability to keep flow rules on restart > ethdev: add capability to keep indirect actions on restart > > doc/guides/prog_guide/rte_flow.rst | 21 + > lib/ethdev/rte_ethdev.h| 7 +++ > 2 files changed, 28 insertions(+)

[dpdk-dev] [PATCH v4 6/6] examples/ip_reassembly: remove unused parameter

2021-10-05 Thread Ferruh Yigit
Remove 'max-pkt-len' parameter. Signed-off-by: Ferruh Yigit --- examples/ip_reassembly/main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/examples/ip_reassembly/main.c b/examples/ip_reassembly/main.c index af67db49f7fb..2ff5ea3e7bc5 100644 --- a/examples/ip_reassembly/main.c +++ b/examp

[dpdk-dev] [PATCH v4 5/6] ethdev: unify MTU checks

2021-10-05 Thread Ferruh Yigit
Both 'rte_eth_dev_configure()' & 'rte_eth_dev_set_mtu()' sets MTU but have slightly different checks. Like one checks min MTU against RTE_ETHER_MIN_MTU and other RTE_ETHER_MIN_LEN. Checks moved into common function to unify the checks. Also this has benefit to have common error logs. Suggested-by

[dpdk-dev] [PATCH v4 4/6] ethdev: remove jumbo offload flag

2021-10-05 Thread Ferruh Yigit
Removing 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag. Instead of drivers announce this capability, application can deduct the capability by checking reported 'dev_info.max_mtu' or 'dev_info.max_rx_pktlen'. And instead of application setting this flag explicitly to enable jumbo frames, this can be d

[dpdk-dev] [PATCH v4 3/6] ethdev: move check to library for MTU set

2021-10-05 Thread Ferruh Yigit
Move requested MTU value check to the API to prevent the duplicated code. Signed-off-by: Ferruh Yigit Reviewed-by: Andrew Rybchenko Reviewed-by: Rosen Xu Acked-by: Somnath Kotur --- drivers/net/axgbe/axgbe_ethdev.c| 15 --- drivers/net/bnxt/bnxt_ethdev.c | 2 +-

[dpdk-dev] [PATCH v4 2/6] ethdev: move jumbo frame offload check to library

2021-10-05 Thread Ferruh Yigit
Setting MTU bigger than RTE_ETHER_MTU requires the jumbo frame support, and application should enable the jumbo frame offload support for it. When jumbo frame offload is not enabled by application, but MTU bigger than RTE_ETHER_MTU is requested there are two options, either fail or enable jumbo fr

[dpdk-dev] [PATCH 2/2] net/bonding: ensure device is started for dedicated queues setup

2021-10-05 Thread Martin Havlik
The flow rule governing dedicated queues is now created when the slave allows it. That is before or after the start of the slave device, as the PMD is able to. Signed-off-by: Martin Havlik --- drivers/net/bonding/rte_eth_bond_pmd.c | 25 +++-- 1 file changed, 19 insertions(+)

[dpdk-dev] [PATCH 0/2] net/bonding: fix dedicated queues flow rule issue

2021-10-05 Thread Martin Havlik
This patchset stems from [1]. Not all PMDs allow RTE flow rule creation before device start. Introduced capability marks the ones that allow it. The capability is then used to fix flow rule creation for dedicated queues in slave devices in bonding. The introduced capa _will need to be set_ for a

Re: [dpdk-dev] [PATCH v4 5/7] ethdev: add API to retrieve multiple ethernet addresses

2021-10-05 Thread Ananyev, Konstantin
> 05/10/2021 18:35, Ananyev, Konstantin: > > > 04/10/2021 15:56, Konstantin Ananyev: > > > > Introduce rte_eth_macaddrs_get() to allow user to retrieve all ethernet > > > > addresses assigned to given port. > > > > > > We already have functions to get MAC addresses. > > > Please explain the di

Re: [dpdk-dev] [PATCH v4 3/7] ethdev: copy ethdev 'fast' API into separate structure

2021-10-05 Thread Ananyev, Konstantin
> > > > +struct rte_eth_fp_ops { > > > > + > > > > + /** first 64B line */ > > > > + eth_rx_burst_t rx_pkt_burst; > > > > + /**< PMD receive function. */ > > > > + eth_tx_burst_t tx_pkt_burst; > > > > + /**< PMD transmit function. */ > > > > + eth_tx_prep_t tx

[dpdk-dev] [PATCH v4 4/4] net/ixgbe: build on Windows

2021-10-05 Thread William Tu
This patch enables building the ixgbe driver for Windows. It also enables its dependencies on security and cryptodev. I tested on AWS using ixgbe VF device, using dpdk-testpmd. Signed-off-by: William Tu --- drivers/net/ixgbe/base/ixgbe_hv_vf.c | 1 + drivers/net/ixgbe/base/ixgbe_osdep.h | 9

[dpdk-dev] [PATCH v4 3/4] cryptodev: build on Windows

2021-10-05 Thread William Tu
From: Tal Shnaiderman Build the cryptography device library on Windows OS by removing unneeded include and exports blocking the compilation. Signed-off-by: Tal Shnaiderman Acked-by: Akhil Goyal Acked-by: William Tu --- lib/cryptodev/cryptodev_pmd.c | 2 ++ lib/cryptodev/rte_cryptodev.c | 1 -

[dpdk-dev] [PATCH v4 2/4] security: build on Windows

2021-10-05 Thread William Tu
From: Tal Shnaiderman Build the security library on Windows. Remove unneeded export from version file. Signed-off-by: Tal Shnaiderman Acked-by: Akhil Goyal Acked-by: William Tu --- lib/meson.build | 1 + lib/security/version.map | 3 --- 2 files changed, 1 insertion(+), 3 deletions

[dpdk-dev] [PATCH v4 1/4] security: use the net library for IP structs

2021-10-05 Thread William Tu
From: Tal Shnaiderman Remove the netinet includes and replaces them with rte_ip.h to support the in_addr/in6_addr structs on all operating systems. Signed-off-by: Tal Shnaiderman Acked-by: Akhil Goyal Acked-by: William Tu --- lib/net/rte_ip.h| 1 + lib/security/meson.build| 2

[dpdk-dev] [PATCH v4 0/4] net/ixgbe: build on Windows

2021-10-05 Thread William Tu
This patch enables building the ixgbe driver for Windows. It also enables its dependencies on security and cryptodev. I tested on AWS using ixgbe VF device, using dpdk-testpmd. Tal Shnaiderman (3): security: use the net library for IP structs security: build on Windows cryptodev: build on Wi

Re: [dpdk-dev] [PATCH v4 1/7] ethdev: allocate max space for internal queue array

2021-10-05 Thread Thomas Monjalon
05/10/2021 18:45, Ananyev, Konstantin: > > > At queue configure stage always allocate space for maximum possible > > > number (RTE_MAX_QUEUES_PER_PORT) of queue pointers. > > > That will allow 'fast' inline functions (eth_rx_burst, etc.) to refer > > > pointer to internal queue data without extra c

Re: [dpdk-dev] [PATCH v4 3/7] ethdev: copy ethdev 'fast' API into separate structure

2021-10-05 Thread Thomas Monjalon
05/10/2021 18:41, Ananyev, Konstantin: > > > +struct rte_eth_fp_ops { > > > + > > > + /** first 64B line */ > > > + eth_rx_burst_t rx_pkt_burst; > > > + /**< PMD receive function. */ > > > + eth_tx_burst_t tx_pkt_burst; > > > + /**< PMD transmit function. */ > > > + eth_tx_prep_t tx_pkt_prepare; >

Re: [dpdk-dev] [PATCH v3 4/6] ethdev: remove jumbo offload flag

2021-10-05 Thread Ferruh Yigit
On 10/4/2021 8:55 AM, Somnath Kotur wrote: On Mon, Oct 4, 2021 at 10:42 AM Somnath Kotur wrote: On Fri, Oct 1, 2021 at 8:07 PM Ferruh Yigit wrote: Removing 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag. Instead of drivers announce this capability, application can deduct the capability by checki

Re: [dpdk-dev] [PATCH v3 1/6] ethdev: fix max Rx packet length

2021-10-05 Thread Ferruh Yigit
On 10/1/2021 4:07 PM, Stephen Hemminger wrote: On Fri, 1 Oct 2021 15:36:18 +0100 Ferruh Yigit wrote: Other issues causing confusion is: * maximum transmission unit (MTU) is payload of the Ethernet frame. And 'max_rx_pkt_len' is the size of the Ethernet frame. Difference is Ethernet fram

Re: [dpdk-dev] [PATCH v4 1/7] ethdev: allocate max space for internal queue array

2021-10-05 Thread Ananyev, Konstantin
> > At queue configure stage always allocate space for maximum possible > > number (RTE_MAX_QUEUES_PER_PORT) of queue pointers. > > That will allow 'fast' inline functions (eth_rx_burst, etc.) to refer > > pointer to internal queue data without extra checking of current number > > of configured que

Re: [dpdk-dev] [PATCH v4 5/7] ethdev: add API to retrieve multiple ethernet addresses

2021-10-05 Thread Thomas Monjalon
05/10/2021 18:35, Ananyev, Konstantin: > > 04/10/2021 15:56, Konstantin Ananyev: > > > Introduce rte_eth_macaddrs_get() to allow user to retrieve all ethernet > > > addresses assigned to given port. > > > > We already have functions to get MAC addresses. > > Please explain the difference. > > rte

Re: [dpdk-dev] [PATCH v4 3/7] ethdev: copy ethdev 'fast' API into separate structure

2021-10-05 Thread Ananyev, Konstantin
> 04/10/2021 15:55, Konstantin Ananyev: > > Copy public function pointers (rx_pkt_burst(), etc.) and related > > pointers to internal data from rte_eth_dev structure into a > > separate flat array. That array will remain in a public header. > > The intention here is to make rte_eth_dev and related

Re: [dpdk-dev] [PATCH v23 1/6] dmadev: introduce DMA device library

2021-10-05 Thread Radha Mohan
On Tue, Oct 5, 2021 at 1:24 AM Kevin Laatz wrote: > > On 04/10/2021 22:12, Radha Mohan wrote: > > On Fri, Sep 24, 2021 at 3:58 AM Chengwen Feng > > wrote: > >> The 'dmadevice' is a generic type of DMA device. > >> > >> This patch introduce the 'dmadevice' device allocation APIs. > >> > >> The in

Re: [dpdk-dev] [PATCH v5 2/2] ethdev: change queue release callback

2021-10-05 Thread Ferruh Yigit
On 9/29/2021 2:57 PM, Xueming(Steven) Li wrote: On Wed, 2021-09-22 at 12:54 +, Xueming(Steven) Li wrote: On Wed, 2021-09-22 at 11:57 +0100, Ferruh Yigit wrote: <...> void -i40e_dev_rx_queue_release(void *rxq) +i40e_dev_rx_queue_release(struct rte_eth_dev *dev, uint16_t qid) +{ +

Re: [dpdk-dev] [PATCH v2 2/4] mempool: add non-IO flag

2021-10-05 Thread Thomas Monjalon
29/09/2021 16:52, dkozl...@oss.nvidia.com: > From: Dmitry Kozlyuk > > Mempool is a generic allocator that is not necessarily used for device > IO operations and its memory for DMA. Add MEMPOOL_F_NON_IO flag to mark > such mempools. > > Signed-off-by: Dmitry Kozlyuk > Acked-by: Matan Azrad > --

Re: [dpdk-dev] [PATCH v4 5/7] ethdev: add API to retrieve multiple ethernet addresses

2021-10-05 Thread Ananyev, Konstantin
> > 04/10/2021 15:56, Konstantin Ananyev: > > Introduce rte_eth_macaddrs_get() to allow user to retrieve all ethernet > > addresses assigned to given port. > > We already have functions to get MAC addresses. > Please explain the difference. rte_eth_macaddr_get() returns just first (primary) M

Re: [dpdk-dev] [PATCH v2 1/4] mempool: add event callbacks

2021-10-05 Thread Thomas Monjalon
29/09/2021 16:52, dkozl...@oss.nvidia.com: > From: Dmitry Kozlyuk > > Performance of MLX5 PMD of different classes can benefit if PMD knows > which memory it will need to handle in advance, before the first mbuf > is sent to the PMD. It is impractical, however, to consider > all allocated memory

[dpdk-dev] [PATCH 3/3] test/devargs: add devargs test cases

2021-10-05 Thread Xueming Li
Initial version to test Global devargs syntax. Signed-off-by: Xueming Li --- app/test/meson.build| 1 + app/test/test_devargs.c | 147 2 files changed, 148 insertions(+) create mode 100644 app/test/test_devargs.c diff --git a/app/test/meson.build

[dpdk-dev] [PATCH 1/3] devargs: support path value for global device arguments

2021-10-05 Thread Xueming Li
Slash is used to split global device arguments. To support path value which contains slash, this patch parses devargs by locating both slash and layer name key: bus=a,name=/some/path/class=b,k1=v1/driver=c,k2=v2 "/class=" and "/driver" are valid start of a layer. Signed-off-by: Xueming Li ---

[dpdk-dev] [PATCH 2/3] devargs: make bus key parsing optional

2021-10-05 Thread Xueming Li
Global devargs syntax is used as device iteration filter like "class=vdpa", a devargs without bus args is valid from parsing perspective. This patch makes bus args optional. Fixes: d2a66ad79480 ("bus: add device arguments name parsing") Cc: sta...@dpdk.org Signed-off-by: Xueming Li --- drivers

[dpdk-dev] [PATCH V6 2/5] common/mlx5: update new MMO HCA capabilities

2021-10-05 Thread Raja Zidane
New MMO HCA capabilities were added and others were renamed. Align hca capabilities with new prm. Add support in devx interface for changes in HCA capabilities. Signed-off-by: Raja Zidane Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 15 --- drivers/common/mlx5/m

[dpdk-dev] [PATCH V6 3/5] common/mlx5: add MMO configuration for the DevX QP

2021-10-05 Thread Raja Zidane
A new configuration MMO was added to QP Context. If set, MMO WQEs are supported on this QP. For DMA MMO, supported only when dma_mmo_qp==1. For REGEXP MMO, supported only when regexp_mmo_qp==1. For COMPRESS MMO, supported only when compress_mmo_qp==1. For DECOMPRESS MMO, supported only when decompr

[dpdk-dev] [PATCH V6 0/5] mlx5: replaced hardware queue object

2021-10-05 Thread Raja Zidane
The mlx5 PMDs for compress and regex classes use an MMO WQE operated by the GGA engine in BF devices. Currently, all the MMO WQEs are managed by the SQ object. Starting from BF3, the queue of the MMO WQEs should be connected to the GGA engine using a new configuration, mmo, that will be supported o

[dpdk-dev] [PATCH V6 5/5] regex/mlx5: refactor HW queue objects

2021-10-05 Thread Raja Zidane
The mlx5 PMD for regex class uses an MMO WQE operated by the GGA engine in BF devices. Currently, all the MMO WQEs are managed by the SQ object. Starting from BF3, the queue of the MMO WQEs should be connected to the GGA engine using a new configuration, MMO, that will be supported only in the QP o

[dpdk-dev] [PATCH V6 4/5] compress/mlx5: refactor queue HW object

2021-10-05 Thread Raja Zidane
The mlx5 PMD for compress class uses an MMO WQE operated by the GGA engine in BF devices. Currently, all the MMO WQEs are managed by the SQ object. Starting from BF3, the queue of the MMO WQEs should be connected to the GGA engine using a new configuration, MMO, that will be supported only in the Q

[dpdk-dev] [PATCH V6 1/5] common/mlx5: share DevX QP operations

2021-10-05 Thread Raja Zidane
Currently drivers using QP (vDPA, crypto and compress, regex soon) manage their memory, creation, modification and destruction of the QP, in almost identical code. Move QP memory management, creation and destruction to common. Add common function to change QP state to RTS. Add user_index attribute

Re: [dpdk-dev] [PATCH v4 7/7] ethdev: hide eth dev related structures

2021-10-05 Thread Ananyev, Konstantin
> 04/10/2021 15:56, Konstantin Ananyev: > > Move rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback and related > > data into private header (ethdev_driver.h). > [...] > > +/** > > + * @internal > > + * Structure used to hold information about the callbacks to be called for > > a > > + * qu

Re: [dpdk-dev] [PATCH v4 7/7] ethdev: hide eth dev related structures

2021-10-05 Thread Thomas Monjalon
05/10/2021 18:19, Ananyev, Konstantin: > > 04/10/2021 15:56, Konstantin Ananyev: > > > Move rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback and related > > > data into private header (ethdev_driver.h). > > [...] > > > +/** > > > + * @internal > > > + * Structure used to hold information about

Re: [dpdk-dev] [PATCH v4 6/7] ethdev: remove legacy Rx descriptor done API

2021-10-05 Thread Ananyev, Konstantin
> > 04/10/2021 15:56, Konstantin Ananyev: > > rte_eth_rx_descriptor_status() should be used as a replacement. > > > > Signed-off-by: Andrew Rybchenko > > Reviewed-by: Ferruh Yigit > > Acked-by: Konstantin Ananyev > > It should be the first patch, or even a standalone patch to apply quickly.

Re: [dpdk-dev] [PATCH V6 0/5] mlx5: replaced hardware queue object

2021-10-05 Thread Thomas Monjalon
> Raja Zidane (5): > common/mlx5: share DevX QP operations > common/mlx5: update new MMO HCA capabilities > common/mlx5: add MMO configuration for the DevX QP > compress/mlx5: refactor queue HW object > regex/mlx5: refactor HW queue objects Applied, thanks.

Re: [dpdk-dev] [EXT] [PATCH] cryptodev: build on Windows

2021-10-05 Thread Tal Shnaiderman
> Subject: RE: [EXT] [PATCH] cryptodev: build on Windows > > External email: Use caution opening links or attachments > > > > > Build the cryptography device library on Windows OS by removing > > > unneeded include and exports blocking the compilation. > > > > > > Signed-off-by: Tal Shnaiderman

  1   2   3   >