Re: [dpdk-dev] [PATCH] net/e1000: build on Windows

2021-10-07 Thread David Marchand
On Fri, Oct 8, 2021 at 8:54 AM David Marchand wrote: > > On Thu, Oct 7, 2021 at 10:25 PM William Tu wrote: > > > > This patch enables building the e1000 driver for Windows. > > I tested using two Windows VM on top of VMware Fusion, > > creating two e1000 devices with device ID 0x10D3, > > verifyi

Re: [dpdk-dev] Questions about vm2vm vhost-user/virtio-net test

2021-10-07 Thread Min Hu (Connor)
Hi, David, thanks for your reply, other question as below, 在 2021/10/1 2:25, David Christensen 写道: On 9/30/21 2:07 AM, Min Hu (Connor) wrote: Hi, all,  I got the answer: testpmd fwd mode should be set "io", then ping OK.  IO fwd mode, it will not change packet MAC address info, and

Re: [dpdk-dev] [PATCH] lib/cmdline: release cl when cmdline exit

2021-10-07 Thread Peng, ZhihongX
> -Original Message- > From: Dmitry Kozlyuk > Sent: Thursday, September 30, 2021 3:44 PM > To: Peng, ZhihongX ; olivier.m...@6wind.com > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] lib/cmdline: release cl when cmdline exit > > 2021-09-30 06:53 (UTC+), Peng, Zhi

Re: [dpdk-dev] [PATCH] net/e1000: build on Windows

2021-10-07 Thread David Marchand
On Thu, Oct 7, 2021 at 10:25 PM William Tu wrote: > > This patch enables building the e1000 driver for Windows. > I tested using two Windows VM on top of VMware Fusion, > creating two e1000 devices with device ID 0x10D3, > verifying rx/tx works correctly using dpdk-testpmd.exe > rxonly and txonly

[dpdk-dev] [PATCH v3 2/2] app/test: delete cmdline free function

2021-10-07 Thread zhihongx . peng
From: Zhihong Peng Cmdline will be released in cmdline_stdin_exit function, so it does not need to be released here. Fixes: acdabc450ea0 (test: fix terminal settings on exit) Cc: sta...@dpdk.org Signed-off-by: Zhihong Peng --- app/test/test.c | 1 - app/test/test_cmdline_lib.c | 1

[dpdk-dev] [PATCH v3 1/2] lib/cmdline: release cl when cmdline exit

2021-10-07 Thread zhihongx . peng
From: Zhihong Peng Malloc cl in the cmdline_stdin_new function, so release in the cmdline_stdin_exit function is logical, so that cl will not be released alone. Fixes: af75078fece3 (first public release) Cc: sta...@dpdk.org Signed-off-by: Zhihong Peng --- doc/guides/rel_notes/release_21_11.rs

Re: [dpdk-dev] [RFC V1] examples/l3fwd-power: fix memory leak for rte_pci_device

2021-10-07 Thread Thomas Monjalon
08/10/2021 08:26, lihuisong (C): > As you mentioned, if we do not want the user to free rte_pci_device and > we want rte_pci_device > to be freed in time. Can we add a code logic calculating the number of > ports under a PCI address > and calling rte_dev_remove() in rte_eth_dev_close() to free >

Re: [dpdk-dev] [RFC V1] examples/l3fwd-power: fix memory leak for rte_pci_device

2021-10-07 Thread lihuisong (C)
在 2021/9/30 15:50, Thomas Monjalon 写道: 30/09/2021 08:28, Huisong Li: Hi. Thomas I've summed up our previous discussion. Can you look at the final proposal again? Do you think we should deal with the problem better? I don't understand what is the final proposal. Sorry. The last idea we di

Re: [dpdk-dev] [PATCH v4 6/6] net/iavf: add watchdog for VFLR

2021-10-07 Thread Wu, Jingjing
> > Besides checking VFGEN_RSTAT, there is a process to handle > VIRTCHNL_OP_EVENT from PF. What is the change for? Any scenario which > VIRTCHNL_OP_EVENT doesn't cover? > > And how is the 500us been determined? > > Hi Jingjing, thanks for reviewing, I think this can be handled with the > VIRTCH

Re: [dpdk-dev] [PATCH v3] net/i40e: fix Rx packet statistics

2021-10-07 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, AlvinX > Sent: Thursday, September 30, 2021 1:20 PM > To: Xing, Beilei ; Guo, Junfeng > ; ktray...@redhat.com; Zhang, Qi Z > > Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org > Subject: [PATCH v3] net/i40e: fix Rx packet statistics > > Some packet

Re: [dpdk-dev] [PATCH v2 0/7] Removal of PCI bus ABIs

2021-10-07 Thread Liu, Changpeng
I tried the above DPDK patches, and got the following errors: pci.c:115:7: error: call to ‘rte_pci_read_config’ declared with attribute error: Symbol is not public ABI 115 | rc = rte_pci_read_config(dev->dev_handle, value, len, offset); | ^~~

Re: [dpdk-dev] [RFC V2] ethdev: fix issue that dev close in PMD calls twice

2021-10-07 Thread lihuisong (C)
在 2021/9/30 19:01, Ferruh Yigit 写道: On 9/30/2021 11:54 AM, Huisong Li wrote: 在 2021/9/28 15:19, Singh, Aman Deep 写道: On 9/22/2021 9:01 AM, Huisong Li wrote: 在 2021/9/20 22:07, Ferruh Yigit 写道: On 8/25/2021 10:53 AM, Huisong Li wrote: 在 2021/8/24 22:42, Ferruh Yigit 写道: On 8/19/2021 4:45 A

Re: [dpdk-dev] [PATCH v3] net/iavf: fix QFI field bit check for GTPU EH

2021-10-07 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Junfeng > Sent: Friday, October 8, 2021 6:42 PM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; Yigit, Ferruh ; Guo, Junfeng > ; sta...@dpdk.org > Subject: [PATCH v3] net/iavf: fix QFI field bit check for GTPU EH > > If GTPU Exti

[dpdk-dev] [PATCH v2] net/virtio: fix check scatter on all Rx queues

2021-10-07 Thread zhihongx . peng
From: Zhihong Peng This patch fixes the wrong way to obtain virtqueue. The end of virtqueue cannot be judged based on whether the array is NULL. Fixes: 4e8169eb0d2d (net/virtio: fix Rx scatter offload) Cc: sta...@dpdk.org Signed-off-by: Zhihong Peng --- drivers/net/virtio/virtio_ethdev.c | 7

Re: [dpdk-dev] [PATCH v3 11/14] eventdev: move timer adapters memory to hugepage

2021-10-07 Thread Pavan Nikhilesh Bhagavatula
Hi Erik, >Hi Pavan, > >Some comments below: > >> -Original Message- >> From: pbhagavat...@marvell.com >> Sent: Wednesday, October 6, 2021 1:50 AM >> To: jer...@marvell.com; Carrillo, Erik G >> Cc: dev@dpdk.org; Pavan Nikhilesh >> Subject: [dpdk-dev] [PATCH v3 11/14] eventdev: move timer

Re: [dpdk-dev] [EXT] [PATCH v9] bbdev: add device info related to data endianness assumption

2021-10-07 Thread Nipun Gupta
> -Original Message- > From: Chautru, Nicolas > Sent: Friday, October 8, 2021 12:29 AM > To: Nipun Gupta ; Akhil Goyal ; > dev@dpdk.org; t...@redhat.com > Cc: tho...@monjalon.net; Zhang, Mingshan ; > Joshi, Arun ; Hemant Agrawal > ; david.march...@redhat.com > Subject: RE: [EXT] [PATCH

[dpdk-dev] [PATCH v10 2/2] app/testpmd: fix testpmd doesn't show RSS hash offload

2021-10-07 Thread Jie Wang
The driver may change offloads info into dev->data->dev_conf in dev_configure which may cause port->dev_conf and port->rx_conf contain outdated values. This patch updates the offloads info if it changes to fix this issue. Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") Signe

[dpdk-dev] [PATCH v10 1/2] ethdev: add an API to get device configuration info

2021-10-07 Thread Jie Wang
The driver may change offloads info into dev->data->dev_conf in dev_configure which may cause port->dev_conf and port->rx_conf contain outdated values. This patch adds a new API "rte_eth_dev_conf_get()" to help users get device configuration info. Add information about the new API in release note

[dpdk-dev] [PATCH v10 0/2] testpmd shows incorrect rx_offload configuration

2021-10-07 Thread Jie Wang
Launch testpmd with multiple queues, and check rx_offload info. When testpmd shows the port configuration, it doesn't show RSS_HASH. --- v10: - update the commit log. - merge the first two patches. - rename the new API name. v9: - add a release notes update for the new API. - update the desc

Re: [dpdk-dev] [PATCH v23 2/6] dmadev: add control plane function support

2021-10-07 Thread fengchengwen
On 2021/10/5 18:16, Matan Azrad wrote: > Hi Chengwen > > API looks good to me, thanks! > > I have some questions below. > >> This patch add control plane functions for dmadev. >> > >> +/** >> + * DMA transfer direction defines. >> + * >> + * @see struct rte_dma_vchan_conf::direction */ enum rt

[dpdk-dev] [PATCH v3] net/iavf: fix QFI field bit check for GTPU EH

2021-10-07 Thread Junfeng Guo
If GTPU Extionsion header has no pdu_type setting, the parsed value of gtp_psc_spec->hdr.type will be 0, which is same as IAVF_GTPU_EH_DWLINK. Thus, for this case, we should check gtp_psc_mask->hdr.type instead, to set QFI field bit of GTPU_EH first. Fixes: cd212c466992 ("net/iavf: fix QFI fields

Re: [dpdk-dev] [kmods PATCH 0/4] windows: independent fixes

2021-10-07 Thread Menon, Ranjit
On 10/2/2021 9:18 AM, Dmitry Kozlyuk wrote: Fixes for building with Windows Development Kit 22000.1 and some build configuration cleanup. Dmitry Kozlyuk (4): windows: specify signature hash algorithm windows/virt2phys: support only x86 configurations windows/virt2phys: change setup clas

Re: [dpdk-dev] [PATCH v4 5/5] app/testpmd: add missing flow types in port info

2021-10-07 Thread Li, Xiaoyun
> -Original Message- > From: Maxime Coquelin > Sent: Monday, October 4, 2021 22:30 > To: dev@dpdk.org; Xia, Chenbo ; > amore...@redhat.com; david.march...@redhat.com; > andrew.rybche...@oktetlabs.ru; Yigit, Ferruh ; > michae...@nvidia.com; viachesl...@nvidia.com; Li, Xiaoyun > > Cc: nelio

Re: [dpdk-dev] [PATCH v3 5/5] app/testpmd: add missing flow types in port info

2021-10-07 Thread Li, Xiaoyun
> -Original Message- > From: Maxime Coquelin > Sent: Friday, October 1, 2021 15:51 > To: Li, Xiaoyun ; dev@dpdk.org; Xia, Chenbo > ; amore...@redhat.com; > david.march...@redhat.com; andrew.rybche...@oktetlabs.ru; Yigit, Ferruh > ; michae...@nvidia.com; viachesl...@nvidia.com > Cc: sta...

Re: [dpdk-dev] [PATCH v23 1/6] dmadev: introduce DMA device library

2021-10-07 Thread fengchengwen
On 2021/10/5 5:12, Radha Mohan wrote: > On Fri, Sep 24, 2021 at 3:58 AM Chengwen Feng wrote: >> >> The 'dmadevice' is a generic type of DMA device. >> >> This patch introduce the 'dmadevice' device allocation APIs. >> >> The infrastructure is prepared to welcome drivers in drivers/dma/ >> >> Signe

[dpdk-dev] [PATCH v1] windows/netuio: fix pci resouce translation

2021-10-07 Thread William Tu
When BAR array is filled like this * Bar[4] = c844000c * Bar[5] = null ex: while ((descriptor->Type != CmResourceTypeMemory) || !(descriptor->Flags & CM_RESOURCE_MEMORY_BAR)); returns true, the loop continue and the decriptor will be NULL, but it's not an error. So I fix i

Re: [dpdk-dev] [PATCH v2 6/6] test/ring: use relaxed barriers for ring stress test

2021-10-07 Thread Honnappa Nagarahalli
> > > > wrk_cmd variable is used to signal the worker thread to start or stop > > the stress test loop. Relaxed barriers are used to achieve the same. > > > > Signed-off-by: Honnappa Nagarahalli > > Reviewed-by: Ola Liljedahl > > Reviewed-by: Feifei Wang > > --- > > app/test/test_ring_stress

[dpdk-dev] [RFC 14/14] vhost: merge sync and async mbuf to desc filling

2021-10-07 Thread Maxime Coquelin
This patches merges copy_mbuf_to_desc() used by the sync path with async_mbuf_to_desc() used by the async path. Most of these complex functions are identical, so merging them will make the maintenance easier. In order not to degrade performance, the patch introduces a boolean function parameter t

[dpdk-dev] [RFC 11/14] vhost: simplify getting the first in-flight index

2021-10-07 Thread Maxime Coquelin
This patch reworks the function getting the index for the first packet in-flight. When this index turns out to be zero, let's use the simple path. Doing that avoid having to do a modulo with the virtqueue size. The patch also rename the function for better clarifty, and only pass the virtqueue me

[dpdk-dev] [RFC 12/14] vhost: prepare async for mbuf to desc refactoring

2021-10-07 Thread Maxime Coquelin
This patch extracts the IO vectors filling from async_mbuf_to_desc() into a dedicated function as a preliminary step of merging copy_mubf_to_desc() and async_mbuf_to_desc(). Signed-off-by: Maxime Coquelin --- lib/vhost/virtio_net.c | 205 ++--- 1 file changed,

[dpdk-dev] [RFC 13/14] vhost: prepare sync for mbuf to desc refactoring

2021-10-07 Thread Maxime Coquelin
This patch extracts the descriptors buffers filling from copy_mbuf_to_desc() into a dedicated function as a preliminary step of merging copy_mubf_to_desc() and async_mbuf_to_desc(). Signed-off-by: Maxime Coquelin --- lib/vhost/virtio_net.c | 73 +- 1 file

[dpdk-dev] [RFC 10/14] vhost: simplify async enqueue completion

2021-10-07 Thread Maxime Coquelin
vhost_poll_enqueue_completed() assumes some inflight packets could have been completed in a previous call but not returned to the application. But this is not the case, since check_completed_copies callback is never called with more than the current count as argument. In other words, async->last_p

[dpdk-dev] [RFC 07/14] vhost: remove useless fields in async iterator struct

2021-10-07 Thread Maxime Coquelin
Offset and count fields are unused and so can be removed. The offset field was actually in the Vhost example, but in a way that does not make sense. Signed-off-by: Maxime Coquelin --- examples/vhost/ioat.c | 6 ++ lib/vhost/rte_vhost_async.h | 4 lib/vhost/virtio_net.c | 19

[dpdk-dev] [RFC 01/14] vhost: move async data in a dedicated structure

2021-10-07 Thread Maxime Coquelin
This patch moves async-related metadata from vhost_virtqueue to a dedicated struct. It makes it clear which fields are async related, and also saves some memory when async feature is not in use. Signed-off-by: Maxime Coquelin --- lib/vhost/vhost.c | 129 -

[dpdk-dev] [RFC 03/14] vhost: simplify async IO vectors

2021-10-07 Thread Maxime Coquelin
IO vectors implementation is unnecessarily complex, mixing source and destinations vectors in the same array. This patch declares two arrays, one for the source and one for the destination. It also get rid off seg_awaits variable in both packed and split implementation, which is the same as iovec_

[dpdk-dev] [RFC 04/14] vhost: simplify async IO vectors iterators

2021-10-07 Thread Maxime Coquelin
This patch splits the iterator arrays in two, one for source and one for destination. The goal is make the code easier to understand. Signed-off-by: Maxime Coquelin --- lib/vhost/vhost.h | 5 +++-- lib/vhost/virtio_net.c | 24 2 files changed, 15 insertions(+), 14

[dpdk-dev] [RFC 08/14] vhost: improve IO vector logic

2021-10-07 Thread Maxime Coquelin
IO vectors and their iterators arrays were part of the async metadata but not their indexes. In order to makes this more consistent, the patch adds the indexes to the async metadata. Doing that, we can avoid triggering DMA transfer within the loop as it IO vector index overflow is now prevented in

[dpdk-dev] [RFC 09/14] vhost: remove notion of async descriptor

2021-10-07 Thread Maxime Coquelin
Now that IO vectors iterator have been simplified, the rte_vhost_async_desc struct only contains a pointer on the iterator array stored in the async metadata. This patch removes it, and pass directly the iterators array pointer to the transfer_data callback. Doing that, we avoid declaring the desc

[dpdk-dev] [RFC 06/14] vhost: introduce specific iovec structure

2021-10-07 Thread Maxime Coquelin
This patch introduces rte_vhost_iovec struct that contains both source and destination addresses since we always have a 1:1 mapping between source and destination. While using the standard iovec struct might have seemed better, having to duplicate IO vectors and its iterators is memory inefficient

[dpdk-dev] [RFC 05/14] vhost: remove async batch threshold

2021-10-07 Thread Maxime Coquelin
Reaching the async batch threshold was one of the condition to trigger the DMA transfer. However, this condition was never met since the threshold value is 32, same as the MAX_PKT_BURST value. Signed-off-by: Maxime Coquelin --- lib/vhost/virtio_net.c | 14 -- 1 file changed, 4 insert

[dpdk-dev] [RFC 00/14] vhost: clean-up and simplify async implementation

2021-10-07 Thread Maxime Coquelin
This series aims at cleaning and simplifying the async enqueue path. I think it makes the code easier to understand, and is necessary before integrating new changes. I may have more reworks to propose in next revisions, but I wanted to share my current status early so that you have time to review/

[dpdk-dev] [PATCH v5 2/2] cmdline: make struct rdline opaque

2021-10-07 Thread Dmitry Kozlyuk
Hide struct rdline definition and some RDLINE_* constants in order to be able to change internal buffer sizes transparently to the user. Add new functions: * rdline_new(): allocate and initialize struct rdline. This function replaces rdline_init() and takes an extra parameter: opaque user data

[dpdk-dev] [PATCH v5 1/2] cmdline: make struct cmdline opaque

2021-10-07 Thread Dmitry Kozlyuk
Remove the definition of `struct cmdline` from public header. Deprecation notice: https://mails.dpdk.org/archives/dev/2020-September/183310.html Signed-off-by: Dmitry Kozlyuk Acked-by: David Marchand Acked-by: Olivier Matz --- doc/guides/rel_notes/deprecation.rst | 4 doc/guides/rel_no

[dpdk-dev] [PATCH v5 0/2] cmdline: reduce ABI

2021-10-07 Thread Dmitry Kozlyuk
Hide struct cmdline following the deprecation notice. Hide struct rdline following the v1 discussion. v5: fix API documentation (Olivier), remove useless NULL assignment (Stephen). v4: rdline_create -> rdline_new, restore empty line (Olivier). v3: add experimental tags and releae notes for rdl

[dpdk-dev] [RFC 02/14] vhost: hide inflight async structure

2021-10-07 Thread Maxime Coquelin
This patch moves async_inflight_info struct to internal header since it should not be part of the API. Signed-off-by: Maxime Coquelin --- lib/vhost/rte_vhost_async.h | 9 - lib/vhost/vhost.h | 9 + 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/vhost

[dpdk-dev] [PATCH v3 1/2] net: rename Ethernet header fields

2021-10-07 Thread Dmitry Kozlyuk
Definition of `rte_ether_addr` structure used a workaround allowing DPDK and Windows SDK headers to be used in the same file, because Windows SDK defines `s_addr` as a macro. Rename `s_addr` to `src_addr` and `d_addr` to `dst_addr` to avoid the conflict and remove the workaround. Deprecation notice

[dpdk-dev] [PATCH v3 2/2] doc: remove unneeded deprecations

2021-10-07 Thread Dmitry Kozlyuk
It was announced that `min` and `max` fields and variables in public headers will be renamed to avoid clash with `min` and `max` macros defined in Windows headers. However, it is unnecessary, because these are function-like macros, which are not expanded unless the next token is an opening brace. I

[dpdk-dev] [PATCH v3 0/2] net: Windows compatibility renaming

2021-10-07 Thread Dmitry Kozlyuk
v3: Fix build failures (Thomas). v2: Realized that issues with cryptodev and compressdev were nonexistent, dropped corresponding patches and removed the deprecation notices instead. Placed release notes in 21.11 file (Thomas). Some checkpatch warnings about long lines are left: - when

[dpdk-dev] [PATCH v2] windows/netuio: add Intel 82599 Virtual Function

2021-10-07 Thread William Tu
Add Intel 82599 10GbE Ethernet adapter VF device IDs (0x10ED) to netuio inf file. Signed-off-by: William Tu --- v2: * use "Intel(R) 82599 Virtual Function" suggested by Pallavi * the dpdk part of the code is on main branch commit 4902f13875e7 ("net/e1000: build on Windows") --- windows/netuio/

Re: [dpdk-dev] [PATCH 0/3] patchset for bnxt PMD

2021-10-07 Thread Ajit Khaparde
On Wed, Oct 6, 2021 at 8:23 PM Ajit Khaparde wrote: > Apart from fixing an issue with Rx queue state at startup, > this patchset enhances support for RSS action and > optimizes the mbuf requirement at startup by creating the > aggregation rings only when needed (rx_scatter is enabled). > > Please

Re: [dpdk-dev] [PATCH v3 11/14] eventdev: move timer adapters memory to hugepage

2021-10-07 Thread Carrillo, Erik G
Hi Pavan, Some comments below: > -Original Message- > From: pbhagavat...@marvell.com > Sent: Wednesday, October 6, 2021 1:50 AM > To: jer...@marvell.com; Carrillo, Erik G > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v3 11/14] eventdev: move timer adapters > memory t

[dpdk-dev] [PATCH] net/e1000: build on Windows

2021-10-07 Thread William Tu
This patch enables building the e1000 driver for Windows. I tested using two Windows VM on top of VMware Fusion, creating two e1000 devices with device ID 0x10D3, verifying rx/tx works correctly using dpdk-testpmd.exe rxonly and txonly mode. Signed-off-by: William Tu --- Example when running: PS

Re: [dpdk-dev] [PATCH] doc: remove web references to internal guides

2021-10-07 Thread Ajit Khaparde
On Thu, Oct 7, 2021 at 5:22 AM Thomas Monjalon wrote: > The guides should be referenced locally with RST syntax > :doc: (beginning of page) or :ref: (specific chapter). > The links to doc.dpdk.org/guides/ are removed. > > The links to the doc.dpdk.org/api/ are acceptable, > but should not point t

Re: [dpdk-dev] [EXT] [PATCH v9] bbdev: add device info related to data endianness assumption

2021-10-07 Thread Chautru, Nicolas
Hi Nipun, > -Original Message- > From: Nipun Gupta > Sent: Thursday, October 7, 2021 9:49 AM > To: Chautru, Nicolas ; Akhil Goyal > ; dev@dpdk.org; t...@redhat.com > Cc: tho...@monjalon.net; Zhang, Mingshan ; > Joshi, Arun ; Hemant Agrawal > ; david.march...@redhat.com > Subject: RE: [EX

Re: [dpdk-dev] [PATCH v4] ethdev: replace bit shifts with macros

2021-10-07 Thread Thomas Monjalon
07/10/2021 19:32, Ferruh Yigit: > Is 'ETH_RSS_L4_CHKSUM' left unchanged intentionally? > > #define ETH_RSS_L4_CHKSUM (1ULL << 35) No, I missed it when rebasing.

Re: [dpdk-dev] [PATCH 1/5] hash: add new toeplitz hash implementation

2021-10-07 Thread Ananyev, Konstantin
> This patch add a new Toeplitz hash implementation using > Galios Fields New Instructions (GFNI). > > Signed-off-by: Vladimir Medvedkin > --- > doc/api/doxy-api-index.md | 1 + > lib/hash/meson.build | 1 + > lib/hash/rte_thash.c | 26 ++ > lib/hash/rte_thash.h | 22 +

Re: [dpdk-dev] [RFC PATCH v3 4/5] lib/bpf: use wait event scheme for Rx/Tx iteration

2021-10-07 Thread Ananyev, Konstantin
> -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, October 7, 2021 4:50 PM > To: Feifei Wang > Cc: dev@dpdk.org; n...@arm.com; Ruifeng Wang > Subject: RE: [RFC PATCH v3 4/5] lib/bpf: use wait event scheme for Rx/Tx > iteration > > > > > > > Signed-off-by: Feifei Wan

Re: [dpdk-dev] [PATCH v2 02/18] ipsec: fix spelling errors

2021-10-07 Thread Ananyev, Konstantin
> -Original Message- > From: dev On Behalf Of Stephen Hemminger > Sent: Monday, September 13, 2021 5:10 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH v2 02/18] ipsec: fix spelling errors > > Lots of typos in comments found by codespell > > Signed-off-by:

Re: [dpdk-dev] [PATCH v4] ethdev: replace bit shifts with macros

2021-10-07 Thread Ferruh Yigit
On 10/7/2021 4:48 PM, Thomas Monjalon wrote: The macros RTE_BIT32 and RTE_BIT64 are used to replace bit shifts. The macro UINT64C is also used to replace remaining occurrences of ULL. The bit shifts of ETH_RSS_LEVEL_* are kept for aesthetic reason. The API of rte_mtr and rte_tm is using enums f

Re: [dpdk-dev] [PATCH] ip_frag: modify the fragment offset and mf

2021-10-07 Thread Ananyev, Konstantin
> From: huichao cai > > According to RFC791,the fragment offset value should be > calculated based on the long datagram,the more fragments flag > for the last fragment carries the same value as the long datagram. Have to admit, that commit log is really cryptic. I couldn't figure out what it

[dpdk-dev] [PATCH v5 2/6] ethdev: move jumbo frame offload check to library

2021-10-07 Thread Ferruh Yigit
Setting MTU bigger than RTE_ETHER_MTU requires the jumbo frame support, and application should enable the jumbo frame offload support for it. When jumbo frame offload is not enabled by application, but MTU bigger than RTE_ETHER_MTU is requested there are two options, either fail or enable jumbo fr

Re: [dpdk-dev] [PATCH v1 02/12] ethdev: add eswitch port item to flow API

2021-10-07 Thread Ori Kam
Hi Ivan, > -Original Message- > From: Ivan Malov > Subject: Re: [PATCH v1 02/12] ethdev: add eswitch port item to flow API > > Hi all, > > I apologise for sending more mail. In fact, yet another option comes to mind. > In > order to move away from confusion with "port mirroring" but pr

[dpdk-dev] [PATCH v5 6/6] examples/ip_reassembly: remove unused parameter

2021-10-07 Thread Ferruh Yigit
Remove 'max-pkt-len' parameter. Signed-off-by: Ferruh Yigit --- examples/ip_reassembly/main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/examples/ip_reassembly/main.c b/examples/ip_reassembly/main.c index af67db49f7fb..2ff5ea3e7bc5 100644 --- a/examples/ip_reassembly/main.c +++ b/examp

[dpdk-dev] [PATCH v5 5/6] ethdev: unify MTU checks

2021-10-07 Thread Ferruh Yigit
Both 'rte_eth_dev_configure()' & 'rte_eth_dev_set_mtu()' sets MTU but have slightly different checks. Like one checks min MTU against RTE_ETHER_MIN_MTU and other RTE_ETHER_MIN_LEN. Checks moved into common function to unify the checks. Also this has benefit to have common error logs. Suggested-by

[dpdk-dev] [PATCH v5 4/6] ethdev: remove jumbo offload flag

2021-10-07 Thread Ferruh Yigit
Removing 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag. Instead of drivers announce this capability, application can deduct the capability by checking reported 'dev_info.max_mtu' or 'dev_info.max_rx_pktlen'. And instead of application setting this flag explicitly to enable jumbo frames, this can be d

[dpdk-dev] [PATCH v5 3/6] ethdev: move check to library for MTU set

2021-10-07 Thread Ferruh Yigit
Move requested MTU value check to the API to prevent the duplicated code. Signed-off-by: Ferruh Yigit Reviewed-by: Andrew Rybchenko Reviewed-by: Rosen Xu Acked-by: Somnath Kotur --- drivers/net/axgbe/axgbe_ethdev.c| 15 --- drivers/net/bnxt/bnxt_ethdev.c | 2 +-

Re: [dpdk-dev] [EXT] [PATCH v9] bbdev: add device info related to data endianness assumption

2021-10-07 Thread Nipun Gupta
> -Original Message- > From: Chautru, Nicolas > Sent: Thursday, October 7, 2021 9:12 PM > To: Akhil Goyal ; dev@dpdk.org; Nipun Gupta > ; t...@redhat.com > Cc: tho...@monjalon.net; Zhang, Mingshan ; > Joshi, Arun ; Hemant Agrawal > ; david.march...@redhat.com > Subject: RE: [EXT] [PATCH

Re: [dpdk-dev] [PATCH v2 16/18] ip_frag: fix typos

2021-10-07 Thread Ananyev, Konstantin
> Minor typos in comment. > > Signed-off-by: Stephen Hemminger > --- > lib/ip_frag/rte_ipv4_reassembly.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/ip_frag/rte_ipv4_reassembly.c > b/lib/ip_frag/rte_ipv4_reassembly.c > index 69666c8b8271..4a89a5f5365a 100644

Re: [dpdk-dev] [PATCH v2 07/18] acl: fix spelling errors

2021-10-07 Thread Ananyev, Konstantin
> > Lots of little typos in comments > > Signed-off-by: Stephen Hemminger > --- > lib/acl/acl.h | 4 ++-- > lib/acl/acl_bld.c | 2 +- > lib/acl/acl_run_avx2.h | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/lib/acl/acl.h b/lib/acl/acl.h > index 4089a

Re: [dpdk-dev] [PATCH] net: promote ip6 external headers skip API as stable

2021-10-07 Thread Kinsella, Ray
On 02/10/2021 10:40, David Marchand wrote: > On Fri, Sep 24, 2021 at 3:02 PM Olivier Matz wrote: >> >> This function is public since commit 8f0e4d6a78a5 ("net: export IPv6 >> header extensions skip function") (2018), and is used by vmxnet3 driver. >> Promote it as stable. >> >> Signed-off-by: O

Re: [dpdk-dev] [RFC PATCH v3 1/5] eal: add new definitions for wait scheme

2021-10-07 Thread Ananyev, Konstantin
> Introduce macros as generic interface for address monitoring. > > Signed-off-by: Feifei Wang > Reviewed-by: Ruifeng Wang > --- > lib/eal/arm/include/rte_pause_64.h | 151 ++-- > lib/eal/include/generic/rte_pause.h | 78 ++ > 2 files changed, 175 inserti

Re: [dpdk-dev] [PATCH v1 02/12] ethdev: add eswitch port item to flow API

2021-10-07 Thread Andrew Rybchenko
Hi Ori, Ivan, On 10/7/21 5:35 PM, Ivan Malov wrote: Hi Ori, On 07/10/2021 16:00, Ori Kam wrote: Hi Ivan, -Original Message- From: Ivan Malov Subject: Re: [PATCH v1 02/12] ethdev: add eswitch port item to flow API Hi all, I apologise for sending more mail. In fact, yet another opti

Re: [dpdk-dev] [EXT] [PATCH v2] eventdev/rx-adapter: add telemetry callbacks

2021-10-07 Thread Gowrishankar Muthukrishnan
Just few minor corrections as below. > > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c > b/lib/eventdev/rte_event_eth_rx_adapter.c > index 9ac976c..c2fb54a 100644 > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > @@ -23,6 +23,7 @@ > #include

Re: [dpdk-dev] [RFC PATCH v3 4/5] lib/bpf: use wait event scheme for Rx/Tx iteration

2021-10-07 Thread Ananyev, Konstantin
> > Signed-off-by: Feifei Wang > Reviewed-by: Ruifeng Wang > --- > lib/bpf/bpf_pkt.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/lib/bpf/bpf_pkt.c b/lib/bpf/bpf_pkt.c > index 6e8248f0d6..3af15ae97b 100644 > --- a/lib/bpf/bpf_pkt.c > +++ b/lib/bpf/bpf_pk

[dpdk-dev] [PATCH v4] ethdev: replace bit shifts with macros

2021-10-07 Thread Thomas Monjalon
The macros RTE_BIT32 and RTE_BIT64 are used to replace bit shifts. The macro UINT64C is also used to replace remaining occurrences of ULL. The bit shifts of ETH_RSS_LEVEL_* are kept for aesthetic reason. The API of rte_mtr and rte_tm is using enums for 64-bit variables. As they are enums, unsigne

Re: [dpdk-dev] [PATCH] usertools/telemetry: add listing of available file prefixes

2021-10-07 Thread Power, Ciara
Hi Conor, >-Original Message- >From: Walsh, Conor >Sent: Tuesday 5 October 2021 16:00 >To: Power, Ciara ; Richardson, Bruce > >Cc: dev@dpdk.org; Walsh, Conor >Subject: [PATCH] usertools/telemetry: add listing of available file prefixes > >This patch adds the option --list (-l) to dpdk-te

Re: [dpdk-dev] [EXT] [dpdk-dev v1] test/crypto: maxlen calculation update

2021-10-07 Thread Zhang, Roy Fan
Thanks Akhil - again anything we can help please let us know. Regards, Fan > -Original Message- > From: Akhil Goyal > Sent: Thursday, October 7, 2021 4:20 PM > To: Zhang, Roy Fan ; Ji, Kai ; > dev@dpdk.org > Cc: hemant.agra...@nxp.com; g.si...@nxp.com > Subject: RE: [EXT] [dpdk-dev] [dpd

Re: [dpdk-dev] [EXT] [PATCH v9] bbdev: add device info related to data endianness assumption

2021-10-07 Thread Chautru, Nicolas
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Thursday, October 7, 2021 6:14 AM > To: Chautru, Nicolas ; dev@dpdk.org; > nipun.gu...@nxp.com; t...@redhat.com > Cc: tho...@monjalon.net; Zhang, Mingshan ; > Joshi, Arun ; hemant.agra...@nxp.com; > david.march...@redhat.com > S

Re: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: accept inline proto pkts in single sa

2021-10-07 Thread Ananyev, Konstantin
> > Subject: [PATCH v2] examples/ipsec-secgw: accept inline proto pkts in single > > sa > > > > In inline protocol inbound SA's, plain ipv4 and ipv6 packets are > > delivered to application unlike inline crypto or lookaside. > > Hence fix the application to not drop them when working in > > sing

Re: [dpdk-dev] [PATCH v9] bbdev: add device info related to data endianness assumption

2021-10-07 Thread Chautru, Nicolas
Hi Tom, > -Original Message- > From: Tom Rix > Sent: Thursday, October 7, 2021 5:01 AM > To: Chautru, Nicolas ; dev@dpdk.org; > gak...@marvell.com; nipun.gu...@nxp.com > Cc: tho...@monjalon.net; Zhang, Mingshan ; > Joshi, Arun ; hemant.agra...@nxp.com; > david.march...@redhat.com > Subje

Re: [dpdk-dev] [EXT] [PATCH v3 09/10] crypto/ipsec_mb: add chacha20-poly1305 PMD to framework

2021-10-07 Thread Akhil Goyal
> > The addition chacha20-poly test was added for a more robust test case to > cover oop sgl test scenario. > Ok. Split the test app changes in a separate patch. Please avoid top posting comments and delete irrelevant stuff while replying.

Re: [dpdk-dev] [EXT] [dpdk-dev v1] test/crypto: maxlen calculation update

2021-10-07 Thread Akhil Goyal
> Sorry didn't catch you are mentioning this part - yes we have been preparing > for adding oop support into qat for a while :-). Rebecca has already tested > and > acked the patchset. We are waiting for you merging them before rebasing. > I am expecting a new patchset from Hemant to handle Konsta

Re: [dpdk-dev] [PATCH v2 01/14] ethdev: introduce configurable flexible item

2021-10-07 Thread Ori Kam
Hi Slava, > -Original Message- > From: Slava Ovsiienko > Sent: Friday, October 1, 2021 10:34 PM > Subject: [PATCH v2 01/14] ethdev: introduce configurable flexible item > > 1. Introduction and Retrospective > > Nowadays the networks are evolving fast and wide, the network structures are

Re: [dpdk-dev] [EXT] [PATCH v3 09/10] crypto/ipsec_mb: add chacha20-poly1305 PMD to framework

2021-10-07 Thread Ji, Kai
Hi Ahkill, The addition chacha20-poly test was added for a more robust test case to cover oop sgl test scenario. Regards Kai > > Any specific reason to add new vectors for chacha poly? > Are the ones already present not enough? > > > +static uint8_t chacha_aad_2[] = { > > +

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: relax SW packets/bytes atomic ops memory ordering

2021-10-07 Thread Ferruh Yigit
On 9/17/2021 12:15 PM, Andrew Rybchenko wrote: No barriers are required when stats are incremented or read. Fixes: 96fd2bd69b58 ("net/sfc: support flow action count in transfer rules") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko Applied to dpdk-next-net/main, thanks.

Re: [dpdk-dev] [PATCH v1 02/12] ethdev: add eswitch port item to flow API

2021-10-07 Thread Ivan Malov
Hi Ori, On 07/10/2021 16:00, Ori Kam wrote: Hi Ivan, -Original Message- From: Ivan Malov Subject: Re: [PATCH v1 02/12] ethdev: add eswitch port item to flow API Hi all, I apologise for sending more mail. In fact, yet another option comes to mind. In order to move away from confusion

Re: [dpdk-dev] [EXT] [dpdk-dev v1] test/crypto: maxlen calculation update

2021-10-07 Thread Zhang, Roy Fan
Hi Akhil, Sorry didn't catch you are mentioning this part - yes we have been preparing for adding oop support into qat for a while :-). Rebecca has already tested and acked the patchset. We are waiting for you merging them before rebasing. Regards, Fan > -Original Message- > From: Akhil

Re: [dpdk-dev] [PATCH v3] ethdev: replace bit shifts with macros

2021-10-07 Thread Thomas Monjalon
07/10/2021 15:26, Thomas Monjalon: > The macros RTE_BIT32 and RTE_BIT64 are used to replace bit shifts. > The macro UINT64C is also used to replace remaining occurrences of ULL. > > Only bit shifts of ETH_RSS_LEVEL_* are kept for aesthetic reason. > > The API of rte_mtr and rte_tm is using enums

[dpdk-dev] [PATCH v3] cryptodev: add telemetry callbacks

2021-10-07 Thread Rebecca Troy
The cryptodev library now registers commands with telemetry, and implements the corresponding callback functions. These commands allow a list of cryptodevs to be queried, as well as info and stats for the corresponding cryptodev. An example usage can be seen below: Connecting to /var/run/dpdk/rte

Re: [dpdk-dev] [EXT] [dpdk-dev v1] test/crypto: maxlen calculation update

2021-10-07 Thread Akhil Goyal
Hi Fan, > Hi Akhil and Hemant, > > This is a generic problem to raw_api applies either with dst_buf added or > not. > > The idea is for SGL test when Wireless algo digest encrypted case is tested > and > RTE_MAX(cipher_off + cipher len, auth_off + auth_len) is smaller than > RTE_MAX(cipher_off +

Re: [dpdk-dev] [EXT] [dpdk-dev v1] test/crypto: maxlen calculation update

2021-10-07 Thread Zhang, Roy Fan
Hi Akhil and Hemant, This is a generic problem to raw_api applies either with dst_buf added or not. The idea is for SGL test when Wireless algo digest encrypted case is tested and RTE_MAX(cipher_off + cipher len, auth_off + auth_len) is smaller than RTE_MAX(cipher_off + cipher len, auth_off + au

[dpdk-dev] [PATCH v2] eventdev/rx-adapter: add telemetry callbacks

2021-10-07 Thread Ganapati Kundapura
Added telemetry callbacks to get Rx adapter stats, reset stats and to get rx queue config information. Signed-off-by: Ganapati Kundapura --- v2: Fixed checkpatch warning --- diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c index 9ac976c..c2fb54a 100

Re: [dpdk-dev] [PATCH v4 0/3] add SA config option for inner pkt csum

2021-10-07 Thread Akhil Goyal
> Add inner packet IPv4 hdr and L4 checksum enable options > in conf. These will be used in case of protocol offload. > Per SA, application could specify whether the > checksum(compute/verify) can be offloaded to security device. > > Changes in v4: > - Rebased to ToT > - Added documentation for pe

Re: [dpdk-dev] [PATCH v6 3/5] telemetry: use unique socket paths for in-memory mode

2021-10-07 Thread Power, Ciara
>-Original Message- >From: Kevin Traynor >Sent: Tuesday 5 October 2021 16:15 >To: Richardson, Bruce >Cc: dev@dpdk.org; Power, Ciara ; David Marchand >; Burakov, Anatoly >Subject: Re: [PATCH v6 3/5] telemetry: use unique socket paths for in-memory >mode > >On 05/10/2021 15:52, Bruce Rich

[dpdk-dev] [PATCH v3] ethdev: replace bit shifts with macros

2021-10-07 Thread Thomas Monjalon
The macros RTE_BIT32 and RTE_BIT64 are used to replace bit shifts. The macro UINT64C is also used to replace remaining occurrences of ULL. Only bit shifts of ETH_RSS_LEVEL_* are kept for aesthetic reason. The API of rte_mtr and rte_tm is using enums for 64-bit variables. As they are enums, RTE_BI

Re: [dpdk-dev] [PATCH] crypto/cnxk: use IE engine group for IPsec

2021-10-07 Thread Akhil Goyal
> > Use IE engine group for cn9k IPsec. > > > > Signed-off-by: Archana Muniganti > > --- > > drivers/crypto/cnxk/cn9k_ipsec.c | 9 ++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > > > Acked-by: Anoob Joseph Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: accept inline proto pkts in single sa

2021-10-07 Thread Akhil Goyal
> Subject: [PATCH v2] examples/ipsec-secgw: accept inline proto pkts in single > sa > > In inline protocol inbound SA's, plain ipv4 and ipv6 packets are > delivered to application unlike inline crypto or lookaside. > Hence fix the application to not drop them when working in > single SA mode. > >

Re: [dpdk-dev] [EXT] [PATCH v9] bbdev: add device info related to data endianness assumption

2021-10-07 Thread Akhil Goyal
> Subject: [EXT] [PATCH v9] bbdev: add device info related to data endianness > assumption > Title is too long. bbdev: add dev info for data endianness > Adding device information to capture explicitly the assumption > of the input/output data byte endianness being processed. > > Signed-off-by:

Re: [dpdk-dev] [PATCH v6 1/5] eal: limit telemetry to primary processes

2021-10-07 Thread Power, Ciara
Hi Bruce, >-Original Message- >From: Richardson, Bruce >Sent: Tuesday 5 October 2021 14:59 >To: dev@dpdk.org >Cc: Power, Ciara ; David Marchand >; Burakov, Anatoly >; Kevin Traynor ; >Richardson, Bruce >Subject: [PATCH v6 1/5] eal: limit telemetry to primary processes > >Telemetry interf

[dpdk-dev] [PATCH v1] eventdev/rx-adapter: add telemetry callbacks

2021-10-07 Thread Ganapati Kundapura
Added telemetry callbacks to get Rx adapter stats, reset stats and to get rx queue config information. Signed-off-by: Ganapati Kundapura diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c index 9ac976c..fa7191c 100644 --- a/lib/eventdev/rte_event_eth_

  1   2   >