Re: [dpdk-dev] [PATCH v3 5/6] mempool: add namespace to driver register macro

2021-10-19 Thread Olivier Matz
On Tue, Oct 19, 2021 at 08:40:21PM +0300, Andrew Rybchenko wrote: > Add RTE_ prefix to macro used to register mempool driver. > The old one is still available but deprecated. > > Signed-off-by: Andrew Rybchenko Acked-by: Olivier Matz

Re: [dpdk-dev] [PATCH v3 4/6] mempool: make header size calculation internal

2021-10-19 Thread Olivier Matz
On Tue, Oct 19, 2021 at 08:40:20PM +0300, Andrew Rybchenko wrote: > Add RTE_ prefix to helper macro to calculate mempool header size and > make it internal. Old macro is still available, but deprecated. > > Signed-off-by: Andrew Rybchenko Acked-by: Olivier Matz

Re: [dpdk-dev] [PATCH v10 03/16] dma/idxd: add bus device probing

2021-10-19 Thread fengchengwen
On 2021/10/19 22:10, Kevin Laatz wrote: > Add the basic device probing for DSA devices bound to the IDXD kernel > driver. These devices can be configured via sysfs and made available to > DPDK if they are found during bus scan. Relevant documentation is included. > [snip] > diff --git a/lib/dmad

Re: [dpdk-dev] [PATCH v2] ethdev: fix one MAC address occupies two index in mac addrs

2021-10-19 Thread lihuisong (C)
Hi Ferruh 在 2021/10/20 1:45, Ferruh Yigit 写道: On 10/11/2021 10:28 AM, Min Hu (Connor) wrote: From: Huisong Li The dev->data->mac_addrs[0] will be changed to a new MAC address when applications modify the default MAC address by rte_eth_dev_default_mac_addr_set() API. However, If the new defaul

Re: [dpdk-dev] [PATCH] dmadev: enable build on Windows

2021-10-19 Thread fengchengwen
On 2021/10/19 20:28, Bruce Richardson wrote: > The dmadev library was not added to the list of libraries built on > Windows, meaning it was skipped in those builds and also that none of > the drivers were being considered for build. Adding dmadev to the list > fixes this, and also enables the skele

Re: [dpdk-dev] [PATCH] dmadev: enable build on Windows

2021-10-19 Thread David Marchand
On Tue, Oct 19, 2021 at 2:28 PM Bruce Richardson wrote: > > The dmadev library was not added to the list of libraries built on > Windows, meaning it was skipped in those builds and also that none of > the drivers were being considered for build. Adding dmadev to the list > fixes this, and also ena

Re: [dpdk-dev] [PATCH] build/windows: remove separate list of libs

2021-10-19 Thread David Marchand
On Tue, Oct 19, 2021 at 6:19 PM Bruce Richardson wrote: > > Rather than maintaining a separate list of libraries which are to be > built on windows, use the standard library list and explicitly add to > each library that is not to be built a check for windows and disable > the library at that per-

Re: [dpdk-dev] [PATCH v2 0/2] replace tight loop with wait until equal api

2021-10-19 Thread David Marchand
On Wed, Oct 20, 2021 at 5:03 AM Feifei Wang wrote: > > For dpdk/lib, directly use wait_until_equal API to replace tight loop. > > v2: > 1. delete wrong 'volatile' in mcslock (David) > > Feifei Wang (2): > eal/common: use wait until equal API for tight loop > mcslock: use wait until equal API f

[dpdk-dev] 回复: [RFC PATCH v3 4/5] lib/bpf: use wait event scheme for Rx/Tx iteration

2021-10-19 Thread Feifei Wang
> -邮件原件- > 发件人: dev 代表 Ananyev, Konstantin > 发送时间: Friday, October 8, 2021 1:40 AM > 收件人: Feifei Wang > 抄送: dev@dpdk.org; nd ; Ruifeng Wang > > 主题: Re: [dpdk-dev] [RFC PATCH v3 4/5] lib/bpf: use wait event scheme for > Rx/Tx iteration > > > > > -Original Message- > > From: Ana

Re: [dpdk-dev] [PATCH v4 2/7] eal/interrupts: implement get set APIs

2021-10-19 Thread David Marchand
On Tue, Oct 19, 2021 at 8:36 PM Harman Kalra wrote: > diff --git a/lib/eal/version.map b/lib/eal/version.map > index 38f7de83e1..7112dbc146 100644 > --- a/lib/eal/version.map > +++ b/lib/eal/version.map > @@ -109,18 +109,10 @@ DPDK_22 { > rte_hexdump; > rte_hypervisor_get; >

Re: [dpdk-dev] [RFC PATCH 0/1] Dataplane Workload Accelerator library

2021-10-19 Thread Tom Herbert
On Tue, Oct 19, 2021 at 12:36 PM Jerin Jacob wrote: > > On Wed, Oct 20, 2021 at 12:38 AM Thomas Monjalon wrote: > > > > 19/10/2021 20:14, jer...@marvell.com: > > > Definition of Dataplane Workload Accelerator > > > > > > Dataplane Workload Accelerator(

Re: [dpdk-dev] [RFC PATCH 0/1] Dataplane Workload Accelerator library

2021-10-19 Thread Jerin Jacob
On Wed, Oct 20, 2021 at 2:12 AM Tom Herbert wrote: > > On Tue, Oct 19, 2021 at 12:36 PM Jerin Jacob wrote: > > > > On Wed, Oct 20, 2021 at 12:38 AM Thomas Monjalon > > wrote: > > > > > > 19/10/2021 20:14, jer...@marvell.com: > > > > Definition of Dataplane Workload Accelerator > > > > -

Re: [dpdk-dev] [RFC PATCH 0/1] Dataplane Workload Accelerator library

2021-10-19 Thread Jerin Jacob
On Wed, Oct 20, 2021 at 2:12 AM Stephen Hemminger wrote: > > On Wed, 20 Oct 2021 01:06:10 +0530 > Jerin Jacob wrote: > > > On Wed, Oct 20, 2021 at 12:38 AM Thomas Monjalon > > wrote: > > > > > > 19/10/2021 20:14, jer...@marvell.com: > > > > Definition of Dataplane Workload Accelerator > > > > -

Re: [dpdk-dev] [EXT] [PATCH v4 00/14] drivers/crypto: introduce ipsec_mb framework

2021-10-19 Thread Akhil Goyal
> 18/10/2021 17:21, Akhil Goyal: > > > This set of patches introduces a new framework, making all common > code of > > > SW crypto PMD implementations built on top of intel-ipsec-mb library > > > sharable. This helps to reduce future effort on the code maintenance and > > > future updates. It also

Re: [dpdk-dev] [PATCH v5 01/14] eventdev: make driver interface as internal

2021-10-19 Thread Jerin Jacob
On Tue, Oct 19, 2021 at 5:06 AM wrote: > > From: Pavan Nikhilesh > > Mark all the driver specific functions as internal, remove > `rte` prefix from `struct rte_eventdev_ops`. > Remove experimental tag from internal functions. > Remove `eventdev_pmd.h` from non-internal header files. > > Signed-of

[dpdk-dev] [PATCH v4] net/e1000: build on Windows

2021-10-19 Thread William Tu
This patch enables building the e1000 driver for Windows. I tested using two Windows VM on top of VMware Fusion, creating two e1000 devices with device ID 0x10D3 (8274L), verifying rx/tx works correctly using dpdk-testpmd.exe rxonly and txonly mode. Signed-off-by: William Tu Acked-by: Haiyue Wang

Re: [dpdk-dev] [PATCH] net/ixgbe: initialize max_rx_pkt_len if rlpml_set_vf fails

2021-10-19 Thread Zhang, AlvinX
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, October 19, 2021 8:58 PM > To: Tudor Cornea ; Zhang, Qi Z > > Cc: Zhang, AlvinX ; Wang, Haiyue > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: initialize max_rx_pkt_len if > rlpml_set_vf fails > > On 10/15/2021 3:2

[dpdk-dev] [PATCH v2 2/2] mcslock: use wait until equal API for tight loop

2021-10-19 Thread Feifei Wang
Instead of polling for previous lock holder unlocking, use wait_until_equal API. Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang --- lib/eal/include/generic/rte_mcslock.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/eal/include/generic/rte_mcslock.h b/lib/eal/

[dpdk-dev] [PATCH v2 1/2] eal/common: use wait until equal API for tight loop

2021-10-19 Thread Feifei Wang
Instead of polling for mcfg->magic to be updated, use wait_until_equal API. Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang --- lib/eal/common/eal_common_mcfg.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/eal/common/eal_common_mcfg.c b/lib/eal/common/eal_commo

[dpdk-dev] [PATCH v2 0/2] replace tight loop with wait until equal api

2021-10-19 Thread Feifei Wang
For dpdk/lib, directly use wait_until_equal API to replace tight loop. v2: 1. delete wrong 'volatile' in mcslock (David) Feifei Wang (2): eal/common: use wait until equal API for tight loop mcslock: use wait until equal API for tight loop lib/eal/common/eal_common_mcfg.c | 3 +-- lib/e

[dpdk-dev] 回复: [PATCH v1 2/2] mcslock: use wait until equal API for tight loop

2021-10-19 Thread Feifei Wang
> -邮件原件- > 发件人: Feifei Wang > 发送时间: Wednesday, October 20, 2021 10:46 AM > 收件人: David Marchand > 抄送: Honnappa Nagarahalli ; dev > ; nd ; Ruifeng Wang > ; nd > 主题: 回复: [dpdk-dev] [PATCH v1 2/2] mcslock: use wait until equal API for > tight loop > > > -邮件原件- > > 发件人: dev 代表 Davi

[dpdk-dev] 回复: [PATCH v1 2/2] mcslock: use wait until equal API for tight loop

2021-10-19 Thread Feifei Wang
> -邮件原件- > 发件人: dev 代表 David Marchand > 发送时间: Tuesday, October 19, 2021 7:10 PM > 收件人: Feifei Wang > 抄送: Honnappa Nagarahalli ; dev > ; nd ; Ruifeng Wang > > 主题: Re: [dpdk-dev] [PATCH v1 2/2] mcslock: use wait until equal API for > tight loop > > On Wed, Aug 25, 2021 at 10:02 AM Feifei

Re: [dpdk-dev] [PATCH v12 1/4] Enable ASan Address Sanitization

2021-10-19 Thread Lin, Xueqin
> -Original Message- > From: David Marchand > Sent: Tuesday, October 19, 2021 11:21 PM > To: Peng, ZhihongX > Cc: Burakov, Anatoly ; Ananyev, Konstantin > ; step...@networkplumber.org; > Dumitrescu, Cristian ; Mcnamara, John > ; Richardson, Bruce > ; dev@dpdk.org; Lin, Xueqin > > Subject

Re: [dpdk-dev] [EXT] [PATCH v7 11/12] net/octeontx2: support port representor flow action

2021-10-19 Thread Kiran Kumar Kokkilagadda
> -Original Message- > From: Ivan Malov > Sent: Wednesday, October 13, 2021 11:05 PM > To: dev@dpdk.org > Cc: Ferruh Yigit ; Thomas Monjalon > ; Ori Kam ; Andrew Rybchenko > ; Jerin Jacob Kollanukkaran > ; Nithin Kumar Dabilpuram ; > Kiran Kumar Kokkilagadda > Subject: [EXT] [PATCH v7

Re: [dpdk-dev] [PATCH v4 5/7] drivers: remove direct access to interrupt handle

2021-10-19 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Harman Kalra > Sent: Wednesday, October 20, 2021 3:36 AM [...] > Subject: [PATCH v4 5/7] drivers: remove direct access to interrupt handle > > Removing direct access to interrupt handle structure fields, > rather use respective get set APIs for the same. > Mak

Re: [dpdk-dev] [PATCH v5 2/3] net/iavf: support PPPoL2TPv2oUDP RSS Hash

2021-10-19 Thread Xing, Beilei
> -Original Message- > From: Wang, Jie1X > Sent: Tuesday, October 19, 2021 11:08 AM > To: dev@dpdk.org > Cc: or...@nvidia.com; Yigit, Ferruh ; > tho...@monjalon.net; andrew.rybche...@oktetlabs.ru; Li, Xiaoyun > ; Yang, SteveX ; Wu, Jingjing > ; Xing, Beilei ; Wu, Wenjun1 > ; Zhang, Qi Z

Re: [dpdk-dev] [PATCH v12 1/4] Enable ASan Address Sanitization

2021-10-19 Thread Peng, ZhihongX
> -Original Message- > From: Mcnamara, John > Sent: Tuesday, October 19, 2021 11:18 PM > To: Peng, ZhihongX ; > david.march...@redhat.com; Burakov, Anatoly > ; Ananyev, Konstantin > ; step...@networkplumber.org; > Dumitrescu, Cristian ; Richardson, Bruce > > Cc: dev@dpdk.org; Lin, Xueqin

Re: [dpdk-dev] [PATCH] net/ice: fix sideband queue initialization

2021-10-19 Thread Zhang, Qi Z
> -Original Message- > From: Yu, DapengX > Sent: Tuesday, October 19, 2021 5:45 PM > To: Yang, Qiming ; Zhang, Qi Z > > Cc: dev@dpdk.org; Yu, DapengX ; sta...@dpdk.org > Subject: [PATCH] net/ice: fix sideband queue initialization > > From: Dapeng Yu > > Sideband queue need to be ini

[dpdk-dev] [PATCH v3] net/i40e: disable source pruning

2021-10-19 Thread Alvin Zhang
VRRP advertisement packets are dropped on i40e PF devices because when a MAC address is added to a device, packets originating from that MAC address are dropped. This patch adds a devarg to support disabling source pruning to work around above issue. Bugzilla ID: 648 Signed-off-by: Alvin Zhang

[dpdk-dev] [PATCH v3 14/18] common/mlx5: add global MR cache create function

2021-10-19 Thread michaelba
From: Michael Baum Add function for global shared MR cache structure initialization. This function include: - btree initialization. - set callbacks for reg and dereg MR. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/linux/mlx5_common_verbs.c | 15 +++ drivers

[dpdk-dev] [PATCH v3 15/18] common/mlx5: share MR top-half search function

2021-10-19 Thread michaelba
From: Michael Baum Add function to search in local liniar cache and use it in the drivers instead of their functions. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.h| 9 drivers/common/mlx5/mlx5_common_mr.c | 52 +++

[dpdk-dev] [PATCH v3 13/18] common/mlx5: add MR ctrl init function

2021-10-19 Thread michaelba
From: Michael Baum Add function for MR control structure initialization. This function include: - btree initialization. - dev_gen_ptr initialization. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common_mr.c| 28 + drivers/common/

[dpdk-dev] [PATCH v3 17/18] common/mlx5: support device DMA map and unmap

2021-10-19 Thread michaelba
From: Michael Baum Since MR management has moved to the common area, there is no longer a need for the DMA map and unmap function for each driver. This patch share those functions. For most drivers it supports these operations for the first time. Signed-off-by: Michael Baum Acked-by: Matan Azra

[dpdk-dev] [PATCH v3 11/18] common/mlx5: share the HCA capabilities handle

2021-10-19 Thread michaelba
From: Michael Baum Add HCA attributes structure as a field of device config structure. It query in common probing, and updates the timestamp format fields. Each driver use HCA attributes from common device config structure, instead of query it for itself. Signed-off-by: Michael Baum Acked-by:

[dpdk-dev] [PATCH v3 18/18] common/mlx5: share MR mempool registration

2021-10-19 Thread michaelba
From: Michael Baum Expand the use of mempool registration to MR management for other drivers. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c | 148 ++ drivers/common/mlx5/mlx5_common.h | 9 ++ drivers/common/mlx5/mlx5_

[dpdk-dev] [PATCH v3 12/18] net/mlx5: remove redundancy in MR file

2021-10-19 Thread michaelba
From: Michael Baum This patch remove two redundant things from MR file: 1. mr_find_contig_memsegs_data structure which is moved to common file before. 2. External memory mechanism - mlx5_tx_update_ext_mp function. Since commit [1] which added support for DMA map and unmap, external mem

[dpdk-dev] [PATCH v3 16/18] common/mlx5: share MR management

2021-10-19 Thread michaelba
From: Michael Baum Add global shared MR cache as a field of common device structure. Move MR management to use this global cache for all drivers. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c| 54 - drivers/common/mlx5/mlx5_com

[dpdk-dev] [PATCH v3 09/18] common/mlx5: add ROCE disable in context device creation

2021-10-19 Thread michaelba
From: Michael Baum Add option to get IB device after disabling RoCE. It is relevant if there is vDPA class in device arguments list. Use common device context in vDPA driver and remove the ctx field from its private structure. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/com

[dpdk-dev] [PATCH v3 06/18] common/mlx5: move basic probing functions to common

2021-10-19 Thread michaelba
From: Michael Baum Move open IBV/DevX device function to common. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/linux/mlx5_common_os.c| 86 ++ drivers/common/mlx5/linux/mlx5_common_os.h| 3 + drivers/common/mlx5/linux/mlx5_common_verbs.c | 70 +

[dpdk-dev] [PATCH v3 07/18] net/mlx5: remove redundant flag in device config

2021-10-19 Thread michaelba
From: Michael Baum Device configure structure has flag named devx as same as SH structure with the same meaning. Remove the flag from the configuration structure and move all the usages to the SH flag. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_os.c |

[dpdk-dev] [PATCH v3 08/18] common/mlx5: share device context object

2021-10-19 Thread michaelba
From: Michael Baum Create shared context device in common area and add it as a field of common device. Use this context device in all drivers and remove the ctx field from their private structure. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/linux/mlx5_common_os.c

[dpdk-dev] [PATCH v3 05/18] net/mlx5/windows: rearrange probing code

2021-10-19 Thread michaelba
From: Michael Baum Rearrange device detection code. Rearrange configuration structures filling. Remove unneeded variables. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/windows/mlx5_os.c | 224 - 1 file changed, 94 insertions(+), 130 deleti

[dpdk-dev] [PATCH v3 10/18] common/mlx5: share the protection domain object

2021-10-19 Thread michaelba
From: Michael Baum Create shared Protection Domain in common area and add it and its PDN as fields of common device structure. Use this Protection Domain in all drivers and remove the PD and PDN fields from their private structure. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- driver

[dpdk-dev] [PATCH v3 01/18] net/mlx5/windows: fix miss callback register for mem event

2021-10-19 Thread michaelba
From: Michael Baum In device initialization, the driver registers to free hugepages events. When husepage is released, this callback frees all its related MRs. In Windows initialization, this callback is not registered what may cause to use invalid memory. This patch adds memory event callback

[dpdk-dev] [PATCH v3 02/18] common/mlx5: share basic probing with the internal drivers

2021-10-19 Thread michaelba
From: Michael Baum Create common probing structure that includes, for now, basic probing information detected by the common driver and share it with all the internal drivers. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c | 4 +- drivers/commo

[dpdk-dev] [PATCH v3 03/18] common/mlx5: share common definitions

2021-10-19 Thread michaelba
From: Michael Baum Create MACRO definitions file in the common driver as preparation for MR and basic probe sharing. Move relevant definitions from the net driver to the above file. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c | 1 + drivers/co

[dpdk-dev] [PATCH v3 04/18] common/mlx5: share memory related devargs

2021-10-19 Thread michaelba
From: Michael Baum Add device configure structure and function to parse user device arguments into it. Move parsing and management of relevant device arguments to common. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c | 184 ++

[dpdk-dev] [PATCH v3 00/18] mlx5: sharing global MR cache between drivers

2021-10-19 Thread michaelba
From: Michael Baum The MLNX PMD supports 5 classes (net, RegEx, vDPA, Compress and Crypto). The various drivers are registered under the common driver, and managed by it. In the common driver probing, it calls in a loop the probe function of each driver registered to it. Each driver creates for i

Re: [dpdk-dev] [PATCH v2 04/18] common/mlx5: share memory related devargs

2021-10-19 Thread Michael Baum
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, October 19, 2021 7:54 PM > To: Michael Baum > Cc: dev@dpdk.org; Matan Azrad > Subject: Re: [dpdk-dev] [PATCH v2 04/18] common/mlx5: share memory > related devargs > > External email: Use caution opening links or attachments

Re: [dpdk-dev] [EXT] [PATCH v4 00/14] drivers/crypto: introduce ipsec_mb framework

2021-10-19 Thread Thomas Monjalon
18/10/2021 17:21, Akhil Goyal: > > This set of patches introduces a new framework, making all common code of > > SW crypto PMD implementations built on top of intel-ipsec-mb library > > sharable. This helps to reduce future effort on the code maintenance and > > future updates. It also moves all SW

Re: [dpdk-dev] [PATCH 0/5] ethdev: cosmetic fixes for just moved structures

2021-10-19 Thread Thomas Monjalon
20/10/2021 00:05, Ferruh Yigit: > On 10/19/2021 7:07 PM, Andrew Rybchenko wrote: > > On 10/19/21 2:55 PM, Ferruh Yigit wrote: > >> On 10/14/2021 9:36 AM, Andrew Rybchenko wrote: > >>> Sicne rte_eth_dev and rte_eth_dev_data structures are just moved > >>> right now is a good chance to make a cleanup

Re: [dpdk-dev] [PATCH 0/5] ethdev: cosmetic fixes for just moved structures

2021-10-19 Thread Ferruh Yigit
On 10/19/2021 7:07 PM, Andrew Rybchenko wrote: On 10/19/21 2:55 PM, Ferruh Yigit wrote: On 10/14/2021 9:36 AM, Andrew Rybchenko wrote: Sicne rte_eth_dev and rte_eth_dev_data structures are just moved right now is a good chance to make a cleanup. No strong opinion, but I think it would be usefu

Re: [dpdk-dev] [PATCH v4 1/7] malloc: introduce malloc is ready API

2021-10-19 Thread Dmitry Kozlyuk
2021-10-20 01:01 (UTC+0300), Dmitry Kozlyuk: > 2021-10-20 00:05 (UTC+0530), Harman Kalra: > [...] > > static unsigned > > check_hugepage_sz(unsigned flags, uint64_t hugepage_sz) > > { > > @@ -1328,6 +1330,7 @@ rte_eal_malloc_heap_init(void) > > { > > struct rte_mem_config *mcfg = rte_eal_ge

Re: [dpdk-dev] [PATCH v4 1/7] malloc: introduce malloc is ready API

2021-10-19 Thread Dmitry Kozlyuk
2021-10-20 00:05 (UTC+0530), Harman Kalra: [...] > static unsigned > check_hugepage_sz(unsigned flags, uint64_t hugepage_sz) > { > @@ -1328,6 +1330,7 @@ rte_eal_malloc_heap_init(void) > { > struct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config; > unsigned int i; > +

Re: [dpdk-dev] [PATCH V2 1/2] app/testpmd: add tunnel types

2021-10-19 Thread Ferruh Yigit
On 10/14/2021 7:29 PM, Gregory Etelson wrote: Subject: [PATCH V2 1/2] app/testpmd: add tunnel types Current testpmd implementation supports VXLAN only for tunnel offload. Add GRE, NVGRE and GENEVE for tunnel offload flow matches. For example: testpmd> flow tunnel create 0 type vxlan port 0: flo

Re: [dpdk-dev] [PATCH V2 2/2] net/mlx5: add support for more tunnel types

2021-10-19 Thread Ferruh Yigit
On 9/23/2021 9:43 AM, Eli Britstein wrote: Accept RTE_FLOW_ITEM_TYPE_GRE, RTE_FLOW_ITEM_TYPE_NVGRE and RTE_FLOW_ITEM_TYPE_GENEVE as valid tunnel types. Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload") Cc: sta...@dpdk.org Signed-off-by: Eli Britstein Moving ack form first version of

Re: [dpdk-dev] [PATCH v4 7/7] eal/alarm: introduce alarm fini routine

2021-10-19 Thread Dmitry Kozlyuk
2021-10-20 00:05 (UTC+0530), Harman Kalra: > Implementing alarm cleanup routine, where the memory allocated > for interrupt instance can be freed. > > Signed-off-by: Harman Kalra > --- > lib/eal/common/eal_private.h | 11 +++ > lib/eal/freebsd/eal.c| 1 + > lib/eal/freebsd/eal_a

Re: [dpdk-dev] [PATCH v4 3/7] eal/interrupts: avoid direct access to interrupt handle

2021-10-19 Thread Dmitry Kozlyuk
2021-10-20 00:05 (UTC+0530), Harman Kalra: > Making changes to the interrupt framework to use interrupt handle > APIs to get/set any field. Direct access to any of the fields > should be avoided to avoid any ABI breakage in future. I get and accept the point why EAL also should use the API. Howeve

Re: [dpdk-dev] [PATCH v1] examples/l3fwd: fix jumbo packet drop issue

2021-10-19 Thread Ferruh Yigit
On 8/13/2021 9:42 AM, Ferruh Yigit wrote: On 8/13/2021 5:48 AM, Rohit Raj wrote: -Original Message- From: Ferruh Yigit Sent: Wednesday, August 11, 2021 5:01 PM To: Rohit Raj Cc: dev@dpdk.org; Nipun Gupta ; Hemant Agrawal ; Sachin Saxena ; Vanshika Shukla Subject: Re: [dpdk-dev] [PA

Re: [dpdk-dev] [PATCH] net/mlx5: do not close stdin on error

2021-10-19 Thread Dmitry Kozlyuk
> -Original Message- > From: David Marchand > Sent: 14 октября 2021 г. 14:37 > To: dev@dpdk.org > Cc: Dmitry Kozlyuk ; sta...@dpdk.org; Matan Azrad > ; Slava Ovsiienko ; > Xueming(Steven) Li ; Jack Min > Subject: [PATCH] net/mlx5: do not close stdin on error > > External email: Use cauti

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/softnic: fix memory leak of meter policy

2021-10-19 Thread Ferruh Yigit
On 10/19/2021 3:01 PM, Singh, Jasvinder wrote: -Original Message- From: Yu, DapengX Sent: Thursday, October 14, 2021 3:12 AM To: Singh, Jasvinder ; Dumitrescu, Cristian Cc: dev@dpdk.org; Yu, DapengX ; sta...@dpdk.org Subject: [PATCH v2] net/softnic: fix memory leak of meter policy F

Re: [dpdk-dev] [RFC PATCH 0/1] Dataplane Workload Accelerator library

2021-10-19 Thread Stephen Hemminger
On Wed, 20 Oct 2021 01:06:10 +0530 Jerin Jacob wrote: > On Wed, Oct 20, 2021 at 12:38 AM Thomas Monjalon wrote: > > > > 19/10/2021 20:14, jer...@marvell.com: > > > Definition of Dataplane Workload Accelerator > > > > > > Dataplane Workload Accelerat

Re: [dpdk-dev] [PATCH v3 0/6] mempool: cleanup namespace

2021-10-19 Thread David Marchand
On Tue, Oct 19, 2021 at 7:40 PM Andrew Rybchenko wrote: > > Add RTE_ prefix to mempool API including internal. Keep old public API > with fallback to new defines. Internal API is just renamed. > > v3: > - fix typo > - rebase on top of current main > - add prefix to newly added MEMPOOL_

Re: [dpdk-dev] [PATCH v3 2/6] mempool: add namespace prefix to flags

2021-10-19 Thread David Marchand
On Tue, Oct 19, 2021 at 7:40 PM Andrew Rybchenko wrote: > @@ -752,7 +752,7 @@ test_mempool_flag_non_io_set_when_no_iova_contig_set(void) > ret = rte_mempool_populate_default(mp); > RTE_TEST_ASSERT(ret > 0, "Failed to populate mempool: %s", > rte_strerror(-re

Re: [dpdk-dev] [EXT] Re: [PATCH v3 0/9] GPU library

2021-10-19 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: dev On Behalf Of Thomas Monjalon > Sent: Wednesday, October 20, 2021 12:42 AM > To: Jerin Jacob > Cc: Elena Agostini ; techbo...@dpdk.org; dpdk-dev > > Subject: [EXT] Re: [dpdk-dev] [PATCH v3 0/9] GPU library > > External Email > > -

Re: [dpdk-dev] [RFC PATCH 0/1] Dataplane Workload Accelerator library

2021-10-19 Thread Jerin Jacob
On Wed, Oct 20, 2021 at 12:38 AM Thomas Monjalon wrote: > > 19/10/2021 20:14, jer...@marvell.com: > > Definition of Dataplane Workload Accelerator > > > > Dataplane Workload Accelerator(DWA) typically contains a set of CPUs, > > Network controllers and

[dpdk-dev] [PATCH v10 7/7] app/testpmd: add forwarding engine for shared Rx queue

2021-10-19 Thread Xueming Li
To support shared Rx queue, this patch introduces dedicate forwarding engine. The engine groups received packets by mbuf->port into sub-group, updates stream statistics and simply frees packets. Signed-off-by: Xueming Li --- app/test-pmd/meson.build| 1 + app/test-pmd/share

[dpdk-dev] [PATCH v10 5/7] app/testpmd: dump port info for shared Rx queue

2021-10-19 Thread Xueming Li
In case of shared Rx queue, polling any member port returns mbufs for all members. This patch dumps mbuf->port for each packet. Signed-off-by: Xueming Li --- app/test-pmd/util.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/util.c b/app/test-pmd/util.c index 51506e49404..e9

[dpdk-dev] [PATCH v10 6/7] app/testpmd: force shared Rx queue polled on same core

2021-10-19 Thread Xueming Li
Shared Rx queue must be polled on same core. This patch checks and stops forwarding if shared RxQ being scheduled on multiple cores. It's suggested to use same number of Rx queues and polling cores. Signed-off-by: Xueming Li --- app/test-pmd/config.c | 103 +

[dpdk-dev] [PATCH v10 4/7] app/testpmd: new parameter to enable shared Rx queue

2021-10-19 Thread Xueming Li
Adds "--rxq-share=X" parameter to enable shared RxQ, share if device supports, otherwise fallback to standard RxQ. Share group number grows per X ports. X defaults to MAX, implies all ports join share group 1. Queue ID is mapped equally with shared Rx queue ID. Forwarding engine "shared-rxq" shou

[dpdk-dev] [PATCH v10 3/7] app/testpmd: dump device capability and Rx domain info

2021-10-19 Thread Xueming Li
Dump device capability and Rx domain ID if shared Rx queue is supported by device. Signed-off-by: Xueming Li Acked-by: Andrew Rybchenko --- app/test-pmd/config.c | 29 + 1 file changed, 29 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c inde

[dpdk-dev] [PATCH v10 2/7] ethdev: new API to resolve device capability name

2021-10-19 Thread Xueming Li
This patch adds API to return name of device capability. Signed-off-by: Xueming Li --- lib/ethdev/rte_ethdev.c | 30 ++ lib/ethdev/rte_ethdev.h | 14 ++ lib/ethdev/version.map | 3 +++ 3 files changed, 47 insertions(+) diff --git a/lib/ethdev/rte_ethdev

[dpdk-dev] [PATCH v10 1/7] ethdev: introduce shared Rx queue

2021-10-19 Thread Xueming Li
In current DPDK framework, each Rx queue is pre-loaded with mbufs to save incoming packets. For some PMDs, when number of representors scale out in a switch domain, the memory consumption became significant. Polling all ports also leads to high cache miss, high latency and low throughput. This pat

[dpdk-dev] [PATCH v10 0/7] ethdev: introduce shared Rx queue

2021-10-19 Thread Xueming Li
In current DPDK framework, all Rx queues is pre-loaded with mbufs for incoming packets. When number of representors scale out in a switch domain, the memory consumption became significant. Further more, polling all ports leads to high cache miss, high latency and low throughputs. This patch introd

Re: [dpdk-dev] [PATCH v2] test: rely on EAL detection for core list

2021-10-19 Thread David Marchand
On Tue, Oct 19, 2021 at 9:09 PM Aaron Conole wrote: > > David Marchand writes: > > > Cores count has a direct impact on the time needed to complete unit > > tests. > > > > Currently, the core list used for unit test is enforced to "all cores on > > the system" with no way for (CI) users to adapt

Re: [dpdk-dev] [PATCH v3 1/6] ethdev: add capability to keep flow rules on restart

2021-10-19 Thread Ori Kam
Hi Dmitry, > -Original Message- > From: dev On Behalf Of Dmitry Kozlyuk > Sent: Tuesday, October 19, 2021 3:37 PM > To: dev@dpdk.org > Cc: Qi Zhang ; Ori Kam ; > NBU-Contact-Thomas > Monjalon ; Ferruh Yigit ; Andrew > Rybchenko > > Subject: [dpdk-dev] [PATCH v3 1/6] ethdev: add capabil

Re: [dpdk-dev] [PATCH v3 2/6] ethdev: add capability to keep shared objects on restart

2021-10-19 Thread Ori Kam
> -Original Message- > From: Dmitry Kozlyuk > Sent: Tuesday, October 19, 2021 3:37 PM > To: dev@dpdk.org > Cc: Ori Kam ; NBU-Contact-Thomas Monjalon > ; Ferruh > Yigit ; Andrew Rybchenko > > Subject: [PATCH v3 2/6] ethdev: add capability to keep shared objects on > restart > > rte_

[dpdk-dev] [PATCH v10 5/6] app/testpmd: force shared Rx queue polled on same core

2021-10-19 Thread Xueming Li
Shared Rx queue must be polled on same core. This patch checks and stops forwarding if shared RxQ being scheduled on multiple cores. It's suggested to use same number of Rx queues and polling cores. Signed-off-by: Xueming Li --- app/test-pmd/config.c | 103 +

[dpdk-dev] [PATCH v10 6/6] app/testpmd: add forwarding engine for shared Rx queue

2021-10-19 Thread Xueming Li
To support shared Rx queue, this patch introduces dedicate forwarding engine. The engine groups received packets by mbuf->port into sub-group, updates stream statistics and simply frees packets. Signed-off-by: Xueming Li --- app/test-pmd/meson.build| 1 + app/test-pmd/share

[dpdk-dev] [PATCH v10 3/6] app/testpmd: new parameter to enable shared Rx queue

2021-10-19 Thread Xueming Li
Adds "--rxq-share=X" parameter to enable shared RxQ, share if device supports, otherwise fallback to standard RxQ. Share group number grows per X ports. X defaults to MAX, implies all ports join share group 1. Queue ID is mapped equally with shared Rx queue ID. Forwarding engine "shared-rxq" shou

[dpdk-dev] [PATCH v10 2/6] app/testpmd: dump device capability and Rx domain info

2021-10-19 Thread Xueming Li
Dump device capability and Rx domain ID if shared Rx queue is supported by device. Signed-off-by: Xueming Li Acked-by: Andrew Rybchenko --- app/test-pmd/config.c | 29 + 1 file changed, 29 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c inde

[dpdk-dev] [PATCH v10 4/6] app/testpmd: dump port info for shared Rx queue

2021-10-19 Thread Xueming Li
In case of shared Rx queue, polling any member port returns mbufs for all members. This patch dumps mbuf->port for each packet. Signed-off-by: Xueming Li --- app/test-pmd/util.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/util.c b/app/test-pmd/util.c index 51506e49404..e9

[dpdk-dev] [PATCH v10 1/6] ethdev: new API to resolve device capability name

2021-10-19 Thread Xueming Li
This patch adds API to return name of device capability. Signed-off-by: Xueming Li --- lib/ethdev/rte_ethdev.c | 30 ++ lib/ethdev/rte_ethdev.h | 14 ++ lib/ethdev/version.map | 3 +++ 3 files changed, 47 insertions(+) diff --git a/lib/ethdev/rte_ethdev

[dpdk-dev] [PATCH v10 0/6] ethdev: introduce shared Rx queue

2021-10-19 Thread Xueming Li
In current DPDK framework, all Rx queues is pre-loaded with mbufs for incoming packets. When number of representors scale out in a switch domain, the memory consumption became significant. Further more, polling all ports leads to high cache miss, high latency and low throughputs. This patch introd

Re: [dpdk-dev] [PATCH v3] net/e1000: build on Windows

2021-10-19 Thread Thomas Monjalon
19/10/2021 21:05, William Tu: > Hi Thomas, > Can we apply this patch? The net driver patches are managed in next-net by Ferruh. > On Sat, Oct 9, 2021 at 9:32 AM William Tu wrote: > > This patch enables building the e1000 driver for Windows. > > I tested using two Windows VM on top of VMware Fus

Re: [dpdk-dev] [PATCH v3 0/9] GPU library

2021-10-19 Thread Thomas Monjalon
19/10/2021 20:47, Jerin Jacob: > > As I stated multiple times, let’s start with something simple that works and > > then think about how to enhance the library/driver. > > I have submitted RFC[1] to abstract in a generic way so that > workload-specific _driver_ aspects are NOT EXPOSED to the appli

Re: [dpdk-dev] [PATCH v2] test: rely on EAL detection for core list

2021-10-19 Thread Aaron Conole
David Marchand writes: > Cores count has a direct impact on the time needed to complete unit > tests. > > Currently, the core list used for unit test is enforced to "all cores on > the system" with no way for (CI) users to adapt it. > On the other hand, EAL default behavior (when no -c/-l option

Re: [dpdk-dev] [RFC PATCH 0/1] Dataplane Workload Accelerator library

2021-10-19 Thread Thomas Monjalon
19/10/2021 20:14, jer...@marvell.com: > Definition of Dataplane Workload Accelerator > > Dataplane Workload Accelerator(DWA) typically contains a set of CPUs, > Network controllers and programmable data acceleration engines for > packet processing, crypt

Re: [dpdk-dev] [PATCH v3] net/e1000: build on Windows

2021-10-19 Thread William Tu
Hi Thomas, Can we apply this patch? Thanks William On Sat, Oct 9, 2021 at 9:32 AM William Tu wrote: > > This patch enables building the e1000 driver for Windows. > I tested using two Windows VM on top of VMware Fusion, > creating two e1000 devices with device ID 0x10D3 (8274L), > verifying rx/tx

Re: [dpdk-dev] [PATCH] common/cnxk: change MCAM entries management scheme

2021-10-19 Thread Jerin Jacob
On Tue, Oct 5, 2021 at 8:25 AM wrote: > > From: Satheesh Paul > > This patch removes the MCAM preallocation scheme. The free > entry cache is removed and for every flow created, an MCAM > allocation request is made to the kernel. Each priority level > has a list of MCAM entries. For every flow ru

[dpdk-dev] [kmods PATCH v2] windows/netuio: add Intel device ID

2021-10-19 Thread William Tu
The patch adds three Intel device IDs, I350 (0x1521), 82574L (0x10D3), and 82599 (0x10ED). Signed-off-by: William Tu Acked-by: Dmitry Kozlyuk Acked-by: Pallavi Kadam --- v2: * fix the device string suggested by Pallavi * combine this patch with the 82599 ixgbevf --- windows/netuio/netuio.inf

Re: [dpdk-dev] [PATCH v3 0/9] GPU library

2021-10-19 Thread Jerin Jacob
> > > > > > > He wants only feature-specific API. > > > > > > To re-reiterate, feature-specific "application" API. A device-specific > > > bit can be > > > driver API and accessible to the out-of-tree driver if needed. > > > > > > IMO, if we take this path, DPU, XPU, GPU, etc we need N different li

Re: [dpdk-dev] [EXT] Re: [PATCH v3 2/7] eal/interrupts: implement get set APIs

2021-10-19 Thread Harman Kalra
> -Original Message- > From: dev On Behalf Of Harman Kalra > Sent: Tuesday, October 19, 2021 2:21 PM > To: Dmitry Kozlyuk > Cc: dev@dpdk.org; Thomas Monjalon ; Ray Kinsella > ; david.march...@redhat.com > Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v3 2/7] eal/interrupts: implement > get

[dpdk-dev] [PATCH v5 5/5] net/enetfec: add features

2021-10-19 Thread Apeksha Gupta
This patch adds checksum and VLAN offloads in enetfec network poll mode driver. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- doc/guides/nics/enetfec.rst | 2 ++ doc/guides/nics/features/enetfec.ini | 3 ++ drivers/net/enetfec/enet_ethdev.c| 17 - drivers/

[dpdk-dev] [PATCH v5 4/5] net/enetfec: add enqueue and dequeue support

2021-10-19 Thread Apeksha Gupta
This patch adds burst enqueue and dequeue operations to the enetfec PMD. Loopback mode is also added, compile time flag 'ENETFEC_LOOPBACK' is used to enable this feature. By default loopback mode is disabled. Basic features added like promiscuous enable, basic stats. Signed-off-by: Sachin Saxena

[dpdk-dev] [PATCH v5 3/5] net/enetfec: support queue configuration

2021-10-19 Thread Apeksha Gupta
This patch adds Rx/Tx queue configuration setup operations. On packet reception the respective BD Ring status bit is set which is then used for packet processing. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- drivers/net/enetfec/enet_ethdev.c | 230 +-

[dpdk-dev] [PATCH v5 2/5] net/enetfec: add UIO support

2021-10-19 Thread Apeksha Gupta
Implemented the fec-uio driver in kernel. enetfec PMD uses UIO interface to interact with "fec-uio" driver implemented in kernel for PHY initialisation and for mapping the allocated memory of register & BD from kernel to DPDK which gives access to non-cacheable memory for BD. Signed-off-by: Sachin

[dpdk-dev] [PATCH v5 1/5] net/enetfec: introduce NXP ENETFEC driver

2021-10-19 Thread Apeksha Gupta
ENETFEC (Fast Ethernet Controller) is a network poll mode driver for NXP SoC i.MX 8M Mini. This patch adds skeleton for enetfec driver with probe function. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- MAINTAINERS| 7 + doc/guides/nics/enetfec.rst

[dpdk-dev] [PATCH v5 0/5] drivers/net: add NXP ENETFEC driver

2021-10-19 Thread Apeksha Gupta
This patch series introduce the enetfec driver, ENETFEC (Fast Ethernet Controller) is a network poll mode driver for the inbuilt NIC found in the NXP i.MX 8M Mini SoC. An overview of the enetfec driver with probe and remove are in patch 1. Patch 2 design UIO interface so that user space directly c

[dpdk-dev] [PATCH v4 7/7] eal/alarm: introduce alarm fini routine

2021-10-19 Thread Harman Kalra
Implementing alarm cleanup routine, where the memory allocated for interrupt instance can be freed. Signed-off-by: Harman Kalra --- lib/eal/common/eal_private.h | 11 +++ lib/eal/freebsd/eal.c| 1 + lib/eal/freebsd/eal_alarm.c | 7 +++ lib/eal/linux/eal.c | 1 +

  1   2   3   4   >