[dpdk-dev] [PATCH] examples/vhost: fix port init failure in mergeable mode

2021-11-03 Thread Chenbo Xia
When the example starts in mergeable mode with an i40e port, it fails to launch because the examples use default mtu MAX_MTU to configure ethdev. The root cause is some devices have Ethernet frame overhead and then MAX_MTU will be larger than device's max mtu, so the ethdev configure will fail. Th

[dpdk-dev] [v5] security: add telemetry endpoint for cryptodev security capabilities

2021-11-03 Thread Gowrishankar Muthukrishnan
Add telemetry endpoint for cryptodev security capabilities. Signed-off-by: Gowrishankar Muthukrishnan --- v5: - fixed parsing security capabilities for a requested index. --- doc/guides/prog_guide/rte_security.rst | 28 doc/guides/rel_notes/release_21_11.rst | 5 + lib/security/rte_sec

Re: [dpdk-dev] [RFC] mempool: implement index-based per core cache

2021-11-03 Thread Dharmik Thakkar
> On Nov 3, 2021, at 10:52 AM, Morten Brørup wrote: > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Dharmik Thakkar >> Sent: Wednesday, 3 November 2021 16.13 >> >> Hi, >> >> Thank you everyone for the comments! I am currently working on making >> the global pool ring’s implementatio

Re: [dpdk-dev] [v4] security: add telemetry endpoint for cryptodev security capabilities

2021-11-03 Thread Gowrishankar Muthukrishnan
> > > +static int > > +security_handle_cryptodev_crypto_caps(const char *cmd __rte_unused, > > const char *params, > > + struct rte_tel_data *d) > > +{ > > + const struct rte_security_capability *capabilities; > > + struct rte_tel_data *crypto_caps; > > + cons

[dpdk-dev] [PATCH] vhost: fix packed ring descriptor update in async enqueue

2021-11-03 Thread Jiayu Hu
For the packet using multiple descriptors, the flag of first descriptor cannot be updated until finishing updating the flag of remaining descriptors. However, if the packet's descriptor index is wrapped, the first descriptor's flag is updated earlier than the others. Fixes: 873e8dad6f49 ("vhost: s

Re: [dpdk-dev] [PATCH v4 0/2] enable protocol agnostic flow offloading in RSS

2021-11-03 Thread Zhang, Qi Z
> -Original Message- > From: Xu, Ting > Sent: Thursday, November 4, 2021 10:22 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; Guo, Junfeng ; Xu, Ting > > Subject: [PATCH v4 0/2] enable protocol agnostic flow offloading in RSS > > Enable protocol agnostic flow offloading to

Re: [dpdk-dev] [PATCH v3 2/3] net/ice: enable protocol agnostic flow offloading in RSS

2021-11-03 Thread Xu, Ting
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, November 3, 2021 10:13 PM > To: Xu, Ting ; dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; Guo, Junfeng > Subject: Re: [dpdk-dev] [PATCH v3 2/3] net/ice: enable protocol agnostic flow > offloading in RSS > > On 11/2/2021 1:4

Re: [dpdk-dev] [PATCH] vhost: rename driver callbacks struct

2021-11-03 Thread Liu, Changpeng
I'm on it. SPDK is using DPDK 21.08 now, we will bump to DPDK 21.11 in next SPDK 22.01 release. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, November 3, 2021 5:10 PM > To: David Marchand ; Maxime Coquelin > > Cc: dev@dpdk.org; Liu, Changpeng ; Thomas > Monjalon ; Aaron C

[dpdk-dev] [PATCH v4 2/2] net/ice: enable protocol agnostic flow offloading in RSS

2021-11-03 Thread Ting Xu
Enable protocol agnostic flow offloading to support raw pattern input for RSS hash flow rule creation. It is based on Parser Library feature. Current rte_flow raw API is utilized. Signed-off-by: Ting Xu --- doc/guides/rel_notes/release_21_11.rst | 1 + drivers/net/ice/ice_ethdev.h |

[dpdk-dev] [PATCH v4 1/2] net/ice/base: support add HW profile for RSS raw flow

2021-11-03 Thread Ting Xu
Based on the parser library, we can directly set HW profile and associate VSI for RSS raw flows. Add symmetric hash configuration for raw flow. Signed-off-by: Ting Xu --- drivers/net/ice/base/ice_flow.c | 109 drivers/net/ice/base/ice_flow.h | 16 + 2 files

[dpdk-dev] [PATCH v4 0/2] enable protocol agnostic flow offloading in RSS

2021-11-03 Thread Ting Xu
Enable protocol agnostic flow offloading to support raw pattern input for RSS hash flow rule creation. It is based on Parser Library feature. Current rte_flow raw API is utilized. Ting Xu (2): net/ice/base: support add HW profile for RSS raw flow net/ice: enable protocol agnostic flow offloadi

[dpdk-dev] 回复: [PATCH v9 2/5] pflock: use wait until scheme for read pflock

2021-11-03 Thread Feifei Wang
> -邮件原件- > 发件人: David Marchand > 发送时间: Wednesday, November 3, 2021 10:47 PM > 收件人: Feifei Wang > 抄送: dev ; nd ; Jerin Jacob > ; Stephen Hemminger > ; tho...@monjalon.net; Ruifeng Wang > ; jer...@marvell.com > 主题: Re: [PATCH v9 2/5] pflock: use wait until scheme for read pflock > > On M

Re: [dpdk-dev] [PATCH v7 1/5] net/enetfec: introduce NXP ENETFEC driver

2021-11-03 Thread Ferruh Yigit
On 11/3/2021 7:20 PM, Apeksha Gupta wrote: @@ -882,6 +882,13 @@ F: drivers/net/enetc/ F: doc/guides/nics/enetc.rst F: doc/guides/nics/features/enetc.ini +NXP enetfec +M: Apeksha Gupta +M: Sachin Saxena +F: drivers/net/enetfec/ +F: doc/guides/nics/enetfec.rst +F: doc/guides/nics/features/e

[dpdk-dev] [PATCH v2] ethdev: mark old macros as deprecated

2021-11-03 Thread Ferruh Yigit
Old macros kept for backward compatibility, but this cause old macro usage to sneak in silently. Marking old macros as deprecated. Downside is this will cause some noise for applications that are using old macros. Fixes: 295968d17407 ("ethdev: add namespace") Signed-off-by: Ferruh Yigit Acked-b

Re: [dpdk-dev] [PATCH v2] kni: allow configuring the kni thread granularity

2021-11-03 Thread Stephen Hemminger
On Wed, 3 Nov 2021 22:40:51 +0200 Tudor Cornea wrote: > On Tue, 2 Nov 2021 at 17:53, Stephen Hemminger > wrote: > > > On Tue, 2 Nov 2021 17:51:13 +0200 > > Tudor Cornea wrote: > > > > > +#ifdef RTE_KNI_PREEMPT_DEFAULT > > > +module_param(min_scheduling_interval, long, 0644); > > > +MODULE_P

Re: [dpdk-dev] [PATCH 10/10] doc: updated release notes and mlx5 file

2021-11-03 Thread Thomas Monjalon
A cover letter is missing for this series. > > Provided further description within documentation regarding > > the RXP to CRSpace changes. This patch should be squashed with the relevant code change. > > --- a/doc/guides/rel_notes/release_21_11.rst > > +++ b/doc/guides/rel_notes/release_21_11.rs

[dpdk-dev] [RFC] build: allow build DPDK as a meson submodule

2021-11-03 Thread Stephen Hemminger
Some other projects using meson may not be able to use DPDK using the standard distribution pkg-config mechanism. Meson supports a way to handle this via the subproject https://mesonbuild.com/Subprojects.html This patch adds the necessary depedency to follow the "Naming convention for depedency

Re: [dpdk-dev] [PATCH] ethdev: fix variable length flow elements support

2021-11-03 Thread Ferruh Yigit
On 10/26/2021 10:05 AM, Gregory Etelson wrote: RTE flow API defines two flow items and actions types - common and PMD private. Common RTE flow types are defined in rte_flow.h while PMD private types restricted to specific PMD only. RTE flow API allows PMD private types in flow rule, but it must n

Re: [dpdk-dev] [PATCH v4 3/3] examples/l3fwd: use reserved addresses for EM mode

2021-11-03 Thread David Marchand
On Sun, Oct 3, 2021 at 10:25 PM wrote: > > From: Pavan Nikhilesh > > The l3fwd example should use the reserved IPv4/v6 reserved address > ranges defined in RFC5735, RFC5180 and RFC863 discard protocol for > the port number in the exact match mode of L3 forwarding. > > Signed-off-by: Pavan Nikhile

Re: [dpdk-dev] [PATCH v2] kni: allow configuring the kni thread granularity

2021-11-03 Thread Tudor Cornea
On Tue, 2 Nov 2021 at 17:53, Stephen Hemminger wrote: > On Tue, 2 Nov 2021 17:51:13 +0200 > Tudor Cornea wrote: > > > +#ifdef RTE_KNI_PREEMPT_DEFAULT > > +module_param(min_scheduling_interval, long, 0644); > > +MODULE_PARM_DESC(min_scheduling_interval, > > +"Kni thread min scheduling interval (

Re: [dpdk-dev] [PATCH] bus/pci: fix selection of default device NUMA node

2021-11-03 Thread David Marchand
On Fri, Oct 29, 2021 at 10:45 AM Olivier Matz wrote: > > +CC David > > On Tue, Oct 26, 2021 at 11:17:08AM +0200, Olivier Matz wrote: > > On Tue, Oct 26, 2021 at 11:06:10AM +0200, Houssem Bouhlel wrote: > > > There can be dev binding issue when no hugepages > > > are allocated for socket 0. > > > T

Re: [dpdk-dev] [PATCH] eal: fix mem alloc from control thread if socket 0 is unused

2021-11-03 Thread David Marchand
On Fri, Oct 29, 2021 at 11:49 AM Olivier Matz wrote: > > From: Ilyes Ben Hamouda > > When using rte_malloc() from a control thread, the used heap is the one > from numa socket 0, which may not have available memory. > > Fix this by selecting the first socket which has available memory. > > Note:

Re: [dpdk-dev] [PATCH] eal/memory: fix unused SIGBUS handler

2021-11-03 Thread David Marchand
On Fri, Oct 29, 2021 at 11:53 AM Olivier Matz wrote: > > Since its introduction in 2018, the SIGBUS handler was never registered, > and all related functions were unused. > > A SIGBUS can be received by the application when accessing to hugepages > even if mmap() was successful, This happens espec

[dpdk-dev] [PATCH] config/ppc: fix meson build failure with gcc 4.8.5 on RHEL/CENTOS7

2021-11-03 Thread David Christensen
The POWER meson.build file incorrectly checks if the detected CPU is "greater than" POWER8 when it should actually test for "greater than or equal to" POWER8. Fixed the comparison operator. Bugzilla ID: 875 Fixes: 750196880843 ("config/ppc: select instruction set for IBM Power10") Cc: thin...@lin

[dpdk-dev] [Bug 875] meson build fails on POWER9 with gcc 4.8.5

2021-11-03 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=875 David Christensen (d...@linux.vnet.ibm.com) changed: What|Removed |Added Resolution|--- |FIXED St

Re: [dpdk-dev] [v4] security: add telemetry endpoint for cryptodev security capabilities

2021-11-03 Thread Akhil Goyal
> +static int > +security_handle_cryptodev_crypto_caps(const char *cmd __rte_unused, > const char *params, > + struct rte_tel_data *d) > +{ > + const struct rte_security_capability *capabilities; > + struct rte_tel_data *crypto_caps; > + const char *cap

Re: [dpdk-dev] [PATCH v2 1/2] common/cnxk: fix: use appropriate zuc constants

2021-11-03 Thread Akhil Goyal
> Use appropriate ZUC constants based on key length and mac length > > Fixes: a90db80d7d72 ("common/cnxk: set key length for PDCP algos") > Cc: vvelum...@marvell.com > > Signed-off-by: Vidya Sagar Velumuri > v2: > * Fixed remove gerrit ID warning Applied to dpdk-next-crypto Thanks.

[dpdk-dev] [PATCH v7 5/5] net/enetfec: add features

2021-11-03 Thread Apeksha Gupta
This patch adds checksum and VLAN offloads in enetfec network poll mode driver. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- doc/guides/nics/enetfec.rst | 2 + doc/guides/nics/features/enetfec.ini | 3 ++ drivers/net/enetfec/enet_ethdev.c| 17 - drivers/n

[dpdk-dev] [PATCH v7 4/5] net/enetfec: add Rx/Tx support

2021-11-03 Thread Apeksha Gupta
This patch adds burst enqueue and dequeue operations to the enetfec PMD. Loopback mode is also added, compile time flag 'ENETFEC_LOOPBACK' is used to enable this feature. By default loopback mode is disabled. Basic features added like promiscuous enable, basic stats. Signed-off-by: Sachin Saxena

[dpdk-dev] [PATCH v7 3/5] net/enetfec: support queue configuration

2021-11-03 Thread Apeksha Gupta
This patch adds Rx/Tx queue configuration setup operations. On packet reception the respective BD Ring status bit is set which is then used for packet processing. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- drivers/net/enetfec/enet_ethdev.c | 230 +-

[dpdk-dev] [PATCH v7 2/5] net/enetfec: add UIO support

2021-11-03 Thread Apeksha Gupta
Implemented the fec-uio driver in kernel. enetfec PMD uses UIO interface to interact with "fec-uio" driver implemented in kernel for PHY initialisation and for mapping the allocated memory of register & BD from kernel to DPDK which gives access to non-cacheable memory for BD. Signed-off-by: Sachin

[dpdk-dev] [PATCH v7 1/5] net/enetfec: introduce NXP ENETFEC driver

2021-11-03 Thread Apeksha Gupta
ENETFEC (Fast Ethernet Controller) is a network poll mode driver for NXP SoC i.MX 8M Mini. This patch adds skeleton for enetfec driver with probe function. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- v7: - Fix compilation - code cleanup v6: - Fix document build errors ---

[dpdk-dev] [PATCH v7 0/5] drivers/net: add NXP ENETFEC driver

2021-11-03 Thread Apeksha Gupta
This patch series introduce the enetfec driver, ENETFEC (Fast Ethernet Controller) is a network poll mode driver for the inbuilt NIC found in the NXP i.MX 8M Mini SoC. An overview of the enetfec driver with probe and remove are in patch 1. Patch 2 design UIO interface so that user space directly c

Re: [dpdk-dev] [EXT] [PATCH V2] crypto/mlx5: support 1MB data-unit

2021-11-03 Thread Akhil Goyal
> Add 1MB data-unit length to the capability's bitmap. > Handle 1MB data-unit length in the mlx5 session create operation, > and expose its capability in the mlx5 capabilities. > V2: fix doc. Write change log after --- below > > Signed-off-by: Raja Zidane > Acked-by: Matan Azrad > --- Applied to

Re: [dpdk-dev] [PATCH] app/testpmd: fix flex item flush

2021-11-03 Thread Ferruh Yigit
On 10/26/2021 4:20 PM, Gregory Etelson wrote: Testpmd provides 2 sets of flex item create and destroy functions One for hosts with JSON library. These functions parse flex item configuration stored in JSON file and create or destroy flex item object. The second functions set is for hosts without

Re: [dpdk-dev] [PATCH] net/enic: fix unwanted error message

2021-11-03 Thread Ferruh Yigit
On 10/26/2021 1:04 AM, Hyong Youb Kim wrote: Probing the availability of Flow Manager API may print the following error log. PMD: rte_enic_pmd: Devcmd 88 failed with error code -1 The error indicates a flow manager operation failed and happens when advanced filtering is disabled on vNIC. It is

Re: [dpdk-dev] [PATCH v2] test/crypto: refactor DOCSIS to show hidden cases

2021-11-03 Thread Akhil Goyal
> >In the current implementation, the DOCSIS test cases are running and being > >reported as one test, despite the fact that multiple test cases are hidden > >inside i.e. "test_DOCSIS_PROTO_all" runs > >52 test cases. Each DOCSIS test case should be reported individually instead. > > > >This commit

Re: [dpdk-dev] [EXT] [dpdk-dev v3 0/8] drivers/qat: QAT symmetric crypto datapatch rework

2021-11-03 Thread Akhil Goyal
> This patch reworks QAT symmetric crypto datapatch implementation where > each > generation request building separated and the crypto operation under the > raw datapath api implementation are unified. > > In addtion this patchset also enables QAT OOP support in raw datapath api > implementation.

Re: [dpdk-dev] [PATCH] net/enic: fix segfault caused by changing MTU

2021-11-03 Thread Ferruh Yigit
On 10/26/2021 1:02 AM, Hyong Youb Kim wrote: Changing MTU after the device start causes a segfault in the Rx handler. The MTU handler (enic_set_mtu) performs the following steps. 1. Stop NIC Rx 2. Change Rx handler '(struct rte_eth_dev)->rx_pkt_burst' to the dummy handler and sleep a while to

Re: [dpdk-dev] [PATCH v2 0/9] net/mlx5: add flex item support

2021-11-03 Thread Ferruh Yigit
On 11/2/2021 8:53 AM, Gregory Etelson wrote: Gregory Etelson (4): common/mlx5: extend flex parser capabilities common/mlx5: fix flex parser DevX creation routine net/mlx5: add flex parser DevX object management net/mlx5: handle flex item in flows Viacheslav Ovsiienko (5): common/m

Re: [dpdk-dev] [PATCH v2 1/1] gpu/cuda: introduce CUDA driver

2021-11-03 Thread Stephen Hemminger
On Thu, 4 Nov 2021 02:01:28 + wrote: > + > +#define CUDA_MAX_ALLOCATION_NUM 512 > + > +#define GPU_PAGE_SHIFT 16 > +#define GPU_PAGE_SIZE (1UL << GPU_PAGE_SHIFT) > + > +RTE_LOG_REGISTER_DEFAULT(gpu_logtype, NOTICE); Use static before this RTE_LOG_REGISTER_DEFAULT. You don't need to export gp

Re: [dpdk-dev] [PATCH] crypto/qat: fix access to null pointer

2021-11-03 Thread Kusztal, ArkadiuszX
> -Original Message- > From: dev On Behalf Of Przemyslaw Zegan > Sent: Wednesday, November 3, 2021 4:09 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Zhang, Roy Fan ; Zegan, > PrzemyslawX > Subject: [dpdk-dev] [PATCH] crypto/qat: fix access to null pointer > > This patch fixes a pos

Re: [dpdk-dev] [PATCH] crypto/qat: fix qp number

2021-11-03 Thread Kusztal, ArkadiuszX
> -Original Message- > From: dev On Behalf Of Przemyslaw Zegan > Sent: Wednesday, November 3, 2021 4:08 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Zhang, Roy Fan ; Zegan, > PrzemyslawX > Subject: [dpdk-dev] [PATCH] crypto/qat: fix qp number > > This patch fixes incorrect number o

[dpdk-dev] [PATCH v3 5/5] dma/cnxk: add stats function

2021-11-03 Thread Radha Mohan Chintakuntla
Add the stats function to get the DMA statistics. Signed-off-by: Radha Mohan Chintakuntla --- drivers/dma/cnxk/cnxk_dmadev.c | 41 -- drivers/dma/cnxk/cnxk_dmadev.h | 1 + 2 files changed, 40 insertions(+), 2 deletions(-) diff --git a/drivers/dma/cnxk/cnxk_dmade

[dpdk-dev] [PATCH v3 4/5] dma/cnxk: add copy_sg function

2021-11-03 Thread Radha Mohan Chintakuntla
Add the copy_sg function that will do the multiple DMA transfers of different sizes and different source/destination as well. Signed-off-by: Radha Mohan Chintakuntla --- drivers/dma/cnxk/cnxk_dmadev.c | 69 +- 1 file changed, 68 insertions(+), 1 deletion(-) diff

[dpdk-dev] [PATCH v3 3/5] dma/cnxk: add dma channel operations

2021-11-03 Thread Radha Mohan Chintakuntla
Add functions for the dmadev vchan setup and DMA operations. Signed-off-by: Radha Mohan Chintakuntla --- drivers/dma/cnxk/cnxk_dmadev.c | 331 + drivers/dma/cnxk/cnxk_dmadev.h | 32 drivers/dma/cnxk/version.map | 3 + 3 files changed, 366 insertions(+)

[dpdk-dev] [PATCH v3 1/5] common/cnxk: add DPI DMA support

2021-11-03 Thread Radha Mohan Chintakuntla
Add base support as ROC(Rest of Chip) API which will be used by PMD dmadev driver. This patch adds routines to init, fini, configure the DPI DMA device found in Marvell's CN9k or CN10k SoC families. Signed-off-by: Radha Mohan Chintakuntla --- Changes from v2: - added stats function - update has_

[dpdk-dev] [PATCH v3 2/5] dma/cnxk: create and initialize dmadev on pci probe

2021-11-03 Thread Radha Mohan Chintakuntla
This patch creates and initializes a dmadev device on pci probe. Signed-off-by: Radha Mohan Chintakuntla --- MAINTAINERS| 6 ++ doc/guides/dmadevs/cnxk.rst| 58 +++ doc/guides/dmadevs/index.rst | 1 + doc/guides/platform/cnxk.rst | 5 +- drivers

Re: [dpdk-dev] [PATCH v20 0/5] Add PIE support for HQoS library

2021-11-03 Thread Thomas Monjalon
03/11/2021 00:57, Liguzinski, WojciechX: > From: Wojciech Liguzinski > > DPDK sched library is equipped with mechanism that secures it from the > bufferbloat problem > which is a situation when excess buffers in the network cause high latency > and latency > variation. Currently, it supports RE

[dpdk-dev] [PATCH] doc: remove deprecation notice for interrupt

2021-11-03 Thread Harman Kalra
Deprecation notice targeted for 21.11 has been committed with following as the first commit of the series. Fixes: b7c984291611 ("interrupts: add allocator and accessors") Signed-off-by: Harman Kalra --- doc/guides/rel_notes/deprecation.rst | 3 --- 1 file changed, 3 deletions(-) diff --git a/d

[dpdk-dev] Question Regarding FIPS Validation in DPDK

2021-11-03 Thread Brandon Lo
Hello, I have been able to use Cisco's libacvp tool to retrieve test vectors from the NIST ACVP API. However, after building the dpdk-fips_validation example and reading through its documentation, it seems like the example application is unable to parse the request files due to them being in a dif

Re: [dpdk-dev] [PATCH] eal: promote non-EAL lcore API as stable

2021-11-03 Thread Thomas Monjalon
22/10/2021 12:22, Kevin Traynor: > On 22/10/2021 07:55, David Marchand wrote: > > This API has been around for more than a year (and is in LTS 20.11). > > It did not receive negative feedback and will be used in a next OVS > > release. > > Mark it stable. > > > > Signed-off-by: David Marchand >

Re: [dpdk-dev] [PATCH v3 0/3] Mempool fixes for FreeBSD

2021-11-03 Thread Thomas Monjalon
02/11/2021 11:08, Dmitry Kozlyuk: > mempool_autotest was failing on FreeBSD, > because rte_virt2iova() is not implemented. > After the test started using memzones, > it appeared that in --no-huge memzones have iova=RTE_BAD_IOVA, > which is unexpected and contradicts with selected IOVA-as-PA. > Inte

Re: [dpdk-dev] [PATCH v3] devtools: add acronyms in dictionary for commit checks

2021-11-03 Thread Ferruh Yigit
On 9/20/2021 11:32 AM, Ferruh Yigit wrote: On 9/20/2021 10:10 AM, Jerin Jacob wrote: On Mon, Sep 20, 2021 at 2:37 PM Ferruh Yigit wrote: On 9/17/2021 11:58 AM, Ashwin Sekhar T K wrote: Update word list with Marvell specific acronyms. CPT -> Cryptographic Accelerator Unit CQ -> Completion

Re: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: add support for event vector

2021-11-03 Thread Akhil Goyal
> From: Srujana Challa > > Adds event vector support to inline protocol offload mode. > By default vector support is disabled, it can be enabled by > using the option --event-vector. > Additional options to configure vector size and vector timeout are > also implemented and can be used by specify

Re: [dpdk-dev] [RFC] mempool: implement index-based per core cache

2021-11-03 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Dharmik Thakkar > Sent: Wednesday, 3 November 2021 16.13 > > Hi, > > Thank you everyone for the comments! I am currently working on making > the global pool ring’s implementation as index based. > Once done, I will send a patch for community

Re: [dpdk-dev] [dpdk-dev v3 0/8] drivers/qat: QAT symmetric crypto datapatch rework

2021-11-03 Thread Zhang, Roy Fan
> -Original Message- > From: dev On Behalf Of Kai Ji > Sent: Tuesday, November 2, 2021 1:49 PM > To: dev@dpdk.org > Cc: Ji, Kai > Subject: [dpdk-dev] [dpdk-dev v3 0/8] drivers/qat: QAT symmetric crypto > datapatch rework > > This patch reworks QAT symmetric crypto datapatch implementatio

Re: [dpdk-dev] [dpdk-dev v3 6/8] crypto/qat: support sgl oop operation

2021-11-03 Thread Zhang, Roy Fan
> -Original Message- > From: dev On Behalf Of Kai Ji > Sent: Tuesday, November 2, 2021 1:49 PM > To: dev@dpdk.org > Cc: Ji, Kai > Subject: [dpdk-dev] [dpdk-dev v3 6/8] crypto/qat: support sgl oop operation > > This patch add-in sgl oop support in qat driver > > Signed-off-by: Kai Ji >

Re: [dpdk-dev] [dpdk-dev v3 7/8] app/test: cryptodev test fix

2021-11-03 Thread Zhang, Roy Fan
> -Original Message- > From: dev On Behalf Of Kai Ji > Sent: Tuesday, November 2, 2021 1:49 PM > To: dev@dpdk.org > Cc: Ji, Kai ; De Lara Guarch, Pablo > ; adamx.dybkow...@intel.com > Subject: [dpdk-dev] [dpdk-dev v3 7/8] app/test: cryptodev test fix > > test_mixed_auth_cipher: ensure eno

Re: [dpdk-dev] [PATCH] hash: fix use after free in thash

2021-11-03 Thread David Marchand
On Fri, Oct 29, 2021 at 4:55 PM Vladimir Medvedkin wrote: > > This patch fixes use after free in thash library, reported by ASAN. > > Bugzilla ID: 868 > Fixes: 28ebff11c2dc ("hash: add predictable RSS") > > Signed-off-by: Vladimir Medvedkin Reviewed-by: David Marchand -- David Marchand

Re: [dpdk-dev] [PATCH 0/4] raw/cnxk_bphy: sync with local changes

2021-11-03 Thread Jerin Jacob
On Wed, Nov 3, 2021 at 12:12 AM Tomasz Duszynski wrote: > > This series does not introduce any new features. Just a few > improvements and fixes. > > Jakub Palider (1): > raw/cnxk_bphy: remove deps from internal headers > > Tomasz Duszynski (3): > raw/cnxk_bphy: keep leading zero in device nam

Re: [dpdk-dev] [PATCH 2/2] net/cnxk: integrate bpfcount get MBOX interface

2021-11-03 Thread Jerin Jacob
On Tue, Nov 2, 2021 at 11:29 AM Rakesh Kudurumalla wrote: > > Bpf count is updated in meter capabilities during device > initialization using mbox interface > > Signed-off-by: Rakesh Kudurumalla Updated the commit to: net/cnxk: integrate BPF count get mailbox Bandwidth profile count i

Re: [dpdk-dev] [PATCH v2 1/2] common/cnxk: change policer timeuint to configured value

2021-11-03 Thread Jerin Jacob
On Tue, Nov 2, 2021 at 12:12 PM Rakesh Kudurumalla wrote: > > Ingress meter rate is calculated based on hardcoded > policer timeunit. Patch adds mbox interface to > retrieve configured policer timeunit > > Signed-off-by: Rakesh Kudurumalla Acked-by: Jerin Jacob Applied to dpdk-next-net-mrvl/for

Re: [dpdk-dev] [PATCH] common/cnxk: consider adjust value for tm burst calculation

2021-11-03 Thread Jerin Jacob
On Mon, Nov 1, 2021 at 12:59 PM wrote: > > From: Satha Rao > > To support lower pps in packet mode we are changing adjust value, > same needs to be consider for burst size calculations. > > When both peak and committed rates requested, then peak rate should > be larger than committed rate. > > Si

Re: [dpdk-dev] [RFC] mempool: implement index-based per core cache

2021-11-03 Thread Dharmik Thakkar
Hi, Thank you everyone for the comments! I am currently working on making the global pool ring’s implementation as index based. Once done, I will send a patch for community review. I will also make it as a compile time option. > On Oct 31, 2021, at 3:14 AM, Morten Brørup wrote: > >> From: Mor

Re: [dpdk-dev] [PATCH] common/cnxk: fix a few typos

2021-11-03 Thread Jerin Jacob
On Wed, Nov 3, 2021 at 12:18 AM Tomasz Duszynski wrote: > > Fix typos here and there. > > Signed-off-by: Tomasz Duszynski > Reviewed-by: Jerin Jacob Kollanukkaran Changed to common/cnxk: fix a few typos Fix a few typos. Fixes: fa8f86a14e2e ("common/cnxk: add build infrastructre

Re: [dpdk-dev] [PATCH v2] common/cnxk: fix device MSIX greater than default value

2021-11-03 Thread Jerin Jacob
On Wed, Nov 3, 2021 at 1:29 PM Harman Kalra wrote: > > Handling the case where number of MSIX interrupts are greater > than default value i.e. PLT_MAX_RXTX_INTR_VEC_ID. On PCI probe > device is queried for supported MSIX interrupts, and respective > interrupt resources are reallocated with this va

[dpdk-dev] [PATCH] crypto/qat: fix access to null pointer

2021-11-03 Thread Przemyslaw Zegan
This patch fixes a possible access to null pointer Fixes: 9f4b9222019c ("common/qat: add gen specific queue implementation") Cc: roy.fan.zh...@intel.com Signed-off-by: Przemyslaw Zegan --- drivers/common/qat/dev/qat_dev_gen1.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/commo

Re: [dpdk-dev] [PATCH 1/9] common/cnxk: add code to write CPT CTX through microcode op

2021-11-03 Thread Jerin Jacob
On Tue, Nov 2, 2021 at 9:24 PM Nithin Dabilpuram wrote: > > From: Srujana Challa > > Adds APIs to write CPT CTX through microcode op(SET_CTX/WRITE_SA). > > Signed-off-by: Srujana Challa Series Acked-by: Jerin Jacob Series applied to dpdk-next-net-mrvl/for-next-net. Thanks. > --- > drivers/c

[dpdk-dev] [PATCH] crypto/qat: fix qp number

2021-11-03 Thread Przemyslaw Zegan
This patch fixes incorrect number of queue pairs Fixes: 4c0d2ee23c39 ("crypto/qat: remove incorrect usage of bundle number" ) Cc: roy.fan.zh...@intel.com Signed-off-by: Przemyslaw Zegan --- drivers/common/qat/qat_adf/adf_transport_access_macros.h | 2 +- 1 file changed, 1 insertion(+), 1 deleti

Re: [dpdk-dev] [PATCH] test/mbuf: fix access to freed memory

2021-11-03 Thread David Marchand
On Fri, Oct 29, 2021 at 2:16 PM Olivier Matz wrote: > > Seen by ASan. > > In the external buffer mbuf test, we check that the buffer is freed > by checking that its refcount is 0. This is not a valid condition, > because it accesses to an already freed area. > > Fix this by setting a boolean flag

Re: [dpdk-dev] [PATCH v9 0/5] add new helper for wait scheme

2021-11-03 Thread David Marchand
On Mon, Nov 1, 2021 at 7:00 AM Feifei Wang wrote: > > Add new helper for wait scheme, and apply this new definitions into > lib to replace rte_pause. > > v2: > 1. use macro to create new wait scheme (Stephen) > > v3: > 1. delete unnecessary bug fix in bpf (Konstantin) > > v4: > 1. put size into th

Re: [dpdk-dev] [PATCH v9 2/5] pflock: use wait until scheme for read pflock

2021-11-03 Thread David Marchand
On Mon, Nov 1, 2021 at 7:00 AM Feifei Wang wrote: > > Instead of polling for read pflock update, use wait until scheme for > this case. > > Jira: ENTNET-2903 I dropped what looks like an internal tag. > Signed-off-by: Feifei Wang > Reviewed-by: Ruifeng Wang > Acked-by: Jerin Jacob -- David

Re: [dpdk-dev] [dpdklab] Re: [PATCH] vhost: rename driver callbacks struct

2021-11-03 Thread Lincoln Lavoie
On Wed, Nov 3, 2021 at 9:16 AM Maxime Coquelin wrote: > > > On 11/3/21 14:11, Lincoln Lavoie wrote: > > > > > > > > On Wed, Nov 3, 2021 at 5:53 AM Maxime Coquelin > > mailto:maxime.coque...@redhat.com>> wrote: > > > > > > > > On 11/3/21 09:38, Maxime Coquelin wrote: > > > Hi David, > >

Re: [dpdk-dev] Overriding rte_config.h

2021-11-03 Thread Ben Magistro
Thanks for the clarification. I agree bumping RTE_LIBRTE_IP_FRAG_MAX_FRAG to 8 probably makes sense to easily support jumbo frames. The other use case we have is supporting highly fragmented UDP. To support this we were increasing to 64 (next power of 2) based on a 64K UDP max and a link MTU of

[dpdk-dev] [PATCH v6 2/2] eal: add additional info if core mask too long

2021-11-03 Thread David Hunt
If the user requests to use an lcore above 128 using -c, the eal will exit with "EAL: invalid coremask syntax" and very little else useful information. This patch adds some extra information suggesting to use --lcores so that physical cores above RTE_MAX_LCORE (default 128) can be used. This is ac

[dpdk-dev] [PATCH v6 1/2] eal: add additional info if core list too long

2021-11-03 Thread David Hunt
If the user requests to use an lcore above 128 using -l, the eal will exit with "EAL: invalid core list syntax" and very little else useful information. This patch adds some extra information suggesting to use --lcores so that physical cores above RTE_MAX_LCORE (default 128) can be used. This is a

Re: [dpdk-dev] [PATCH v3 0/3] enable protocol agnostic flow offloading in RSS

2021-11-03 Thread Ferruh Yigit
On 11/3/2021 12:45 PM, Zhang, Qi Z wrote: -Original Message- From: Xu, Ting Sent: Tuesday, November 2, 2021 9:50 AM To: dev@dpdk.org Cc: Zhang, Qi Z ; Yang, Qiming ; Guo, Junfeng ; Xu, Ting Subject: [PATCH v3 0/3] enable protocol agnostic flow offloading in RSS Enable protocol agnos

Re: [dpdk-dev] [EXT] [PATCH v6 0/7] IPsec Sec GW new features

2021-11-03 Thread Akhil Goyal
> Update the IPsec sample app with new features and updates: > - telemetry support > - add reset callback > - stats screen configurable as a command line parameter > - UDP encapsulation support for inline crypto > - ESN with configurable start value > > Radu Nicolau (7): > examples/ipsec-secgw:

Re: [dpdk-dev] [PATCH v3 2/3] net/ice: enable protocol agnostic flow offloading in RSS

2021-11-03 Thread Ferruh Yigit
On 11/2/2021 1:49 AM, Ting Xu wrote: +static int +ice_hash_rem_raw_cfg(struct ice_adapter *ad, + struct ice_parser_profile *prof, + u16 vsi_handle) +{ + struct ice_hw *hw = &ad->hw; + int ptg, ret; + u16 vsig; + u64 id; + + id

[dpdk-dev] [PATCH v4 06/10] vdpa/sfc: add support for dev conf and dev close ops

2021-11-03 Thread Vijay Srivastava
From: Vijay Kumar Srivastava Implement vDPA ops dev_conf and dev_close for DMA mapping, interrupt and virtqueue configurations. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko --- v2: * Removed redundant null check while calling free(). * Added error handling for rte_vhost_get

[dpdk-dev] [PATCH v4 10/10] vdpa/sfc: set a multicast filter during vDPA init

2021-11-03 Thread Vijay Srivastava
From: Vijay Kumar Srivastava Insert unknown multicast filter to allow IPv6 neighbor discovery Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko Reviewed-by: Chenbo Xia --- v4: * Improved line usage by rearranging function params. drivers/vdpa/sfc/sfc_vdpa.h| 3 ++- d

[dpdk-dev] [PATCH v4 09/10] vdpa/sfc: add support to set vring state

2021-11-03 Thread Vijay Srivastava
From: Vijay Kumar Srivastava Implements vDPA ops set_vring_state to configure vring state. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko Reviewed-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/vdpa/sfc/sfc_vdpa_ops.c | 54 ++---

[dpdk-dev] [PATCH v4 08/10] vdpa/sfc: add support for MAC filter config

2021-11-03 Thread Vijay Srivastava
From: Vijay Kumar Srivastava Add support for unicast and broadcast MAC filter configuration. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko --- v4: * Removed redundant NULL check. * Improved line usage by rearranging function params. doc/guides/vdpadevs/sfc.rst| 4

[dpdk-dev] [PATCH v4 07/10] vdpa/sfc: add support to get queue notify area info

2021-11-03 Thread Vijay Srivastava
From: Vijay Kumar Srivastava Implement the vDPA ops get_notify_area to get the notify area info of the queue. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko --- v2: * Added error log in sfc_vdpa_get_notify_area. v4: * Updated parameter for sfc_vdpa_setup_notify_ctrl driver

[dpdk-dev] [PATCH v4 05/10] vdpa/sfc: add support to get VFIO device fd

2021-11-03 Thread Vijay Srivastava
From: Vijay Kumar Srivastava Implement vDPA ops get_vfio_device_fd to get the VFIO device fd. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko Reviewed-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/vdpa/sfc/sfc_vdpa_ops.c | 24 1 file chang

[dpdk-dev] [PATCH v4 04/10] vdpa/sfc: get device supported max queue count

2021-11-03 Thread Vijay Srivastava
From: Vijay Kumar Srivastava Implement vDPA ops get_queue_num to get the maximum number of queues supported by the device. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko Reviewed-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- v4: * Updated format specifier in log message.

[dpdk-dev] [PATCH v4 03/10] vdpa/sfc: add support to get device and protocol features

2021-11-03 Thread Vijay Srivastava
From: Vijay Kumar Srivastava Implement vDPA ops get_feature and get_protocol_features. This patch retrieves device supported features and enables protocol features. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko Reviewed-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- doc/

[dpdk-dev] [PATCH v4 02/10] vdpa/sfc: add support for device initialization

2021-11-03 Thread Vijay Srivastava
From: Vijay Kumar Srivastava Add HW initialization and vDPA device registration support. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko --- v2: * Used rte_memzone_reserve_aligned for mcdi buffer allocation. * Freeing mcdi buff when DMA map fails. * Fixed one typo. v4: * Remo

[dpdk-dev] [PATCH v4 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-11-03 Thread Vijay Srivastava
From: Vijay Kumar Srivastava Add new vDPA PMD to support vDPA operations of Xilinx devices. This patch implements probe and remove functions. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko --- v2: * Updated logging macros to remove redundant code. v3: * Replaced depreciated

[dpdk-dev] [PATCH v4 00/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-11-03 Thread Vijay Srivastava
This patch series introduces vDPA driver for Xilinx devices. The Xilinx vDPA (vhost data path acceleration) provides support for the Xilinx SN1022 SmartNICs. Vijay Kumar Srivastava (10): vdpa/sfc: introduce Xilinx vDPA driver vdpa/sfc: add support for device initialization vdpa/sfc: add supp

Re: [dpdk-dev] [EXT] Re: [dpdk-stable] [PATCH v2] examples/ipsec-secgw: fix potential build error

2021-11-03 Thread Akhil Goyal
> > Yes this series initiated the issue, applying both the patch and the series > now > > On next-crypto > > It means a patch of this series broke compilation, and this fix here > should be squashed in it. Actually no, this is definitely an issue introduced earlier and should be part of stable. T

Re: [dpdk-dev] [EXT] Re: [dpdk-stable] [PATCH v2] examples/ipsec-secgw: fix potential build error

2021-11-03 Thread David Marchand
On Wed, Nov 3, 2021 at 2:45 PM Akhil Goyal wrote: > > > On Wed, Nov 3, 2021 at 2:09 PM Thomas Monjalon > > wrote: > > > > > > 03/11/2021 12:56, Radu Nicolau: > > > > When STATS_INTERVAL is set to a non-zero value the core_statistics array > > > > will be defined in multiple compilation units and

Re: [dpdk-dev] [PATCH] vhost: add vDPA resource cleanup callback

2021-11-03 Thread Maxime Coquelin
On 11/3/21 14:45, Xueming(Steven) Li wrote: On Wed, 2021-11-03 at 09:46 +0100, Maxime Coquelin wrote: On 11/3/21 09:41, Xia, Chenbo wrote: Hi Xueming, -Original Message- From: Xueming(Steven) Li Sent: Thursday, October 21, 2021 8:36 PM To: maxime.coque...@redhat.com; dev@dpdk.org

Re: [dpdk-dev] [PATCH v3] vhost: mark vDPA driver API as internal

2021-11-03 Thread Maxime Coquelin
On 11/2/21 10:56, Maxime Coquelin wrote: This patch marks the vDPA driver APIs as internal and rename the corresponding header file to vdpa_driver.h. Signed-off-by: Maxime Coquelin Acked-by: Thomas Monjalon Reviewed-by: Chenbo Xia --- Changes in v3: == - Update deprecation noti

Re: [dpdk-dev] [PATCH] doc: remove deprecation notice for vhost

2021-11-03 Thread Maxime Coquelin
On 11/3/21 06:00, Chenbo Xia wrote: Ten vhost APIs were announced to be stable and promoted in below commit, so remove the related deprecation notice. Fixes: 945ef8a04098 ("vhost: promote some APIs to stable") Signed-off-by: Chenbo Xia Reported-by: Maxime Coquelin --- doc/guides/rel_note

Re: [dpdk-dev] [PATCH] vhost: rename driver callbacks struct

2021-11-03 Thread Maxime Coquelin
On 11/2/21 11:47, Maxime Coquelin wrote: As previously announced, this patch renames struct vhost_device_ops to struct rte_vhost_device_ops. Signed-off-by: Maxime Coquelin --- doc/guides/rel_notes/deprecation.rst | 3 --- doc/guides/rel_notes/release_21_11.rst | 2 ++ drivers/net/vhost

Re: [dpdk-dev] [EXT] Re: [dpdk-stable] [PATCH v2] examples/ipsec-secgw: fix potential build error

2021-11-03 Thread Akhil Goyal
> On Wed, Nov 3, 2021 at 2:09 PM Thomas Monjalon > wrote: > > > > 03/11/2021 12:56, Radu Nicolau: > > > When STATS_INTERVAL is set to a non-zero value the core_statistics array > > > will be defined in multiple compilation units and this can trigger a > > > linker error on particular environments.

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] examples/ipsec-secgw: fix potential build error

2021-11-03 Thread David Marchand
On Wed, Nov 3, 2021 at 2:09 PM Thomas Monjalon wrote: > > 03/11/2021 12:56, Radu Nicolau: > > When STATS_INTERVAL is set to a non-zero value the core_statistics array > > will be defined in multiple compilation units and this can trigger a > > linker error on particular environments. In order to f

Re: [dpdk-dev] [EXT] Re: [PATCH v2] examples/ipsec-secgw: fix potential build error

2021-11-03 Thread Akhil Goyal
> 03/11/2021 12:56, Radu Nicolau: > > When STATS_INTERVAL is set to a non-zero value the core_statistics array > > will be defined in multiple compilation units and this can trigger a > > linker error on particular environments. In order to fix this the > > core_statistics definition was moved out

  1   2   >