RE: [EXT] Re: [PATCH v9 3/5] net/enetfec: support queue configuration

2021-11-12 Thread Apeksha Gupta
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, November 10, 2021 7:25 PM > To: Apeksha Gupta ; > david.march...@redhat.com; andrew.rybche...@oktetlabs.ru > Cc: dev@dpdk.org; Sachin Saxena ; Hemant > Agrawal > Subject: [EXT] Re: [PATCH v9 3/5] net/enetfec: support queue confi

[PATCH v10 5/5] net/enetfec: add features

2021-11-12 Thread Apeksha Gupta
This patch adds checksum and VLAN offloads in enetfec network poll mode driver. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- doc/guides/nics/enetfec.rst | 2 + doc/guides/nics/features/enetfec.ini | 3 ++ drivers/net/enetfec/enet_ethdev.c| 12 +- drivers/net/

[PATCH v10 4/5] net/enetfec: add Rx/Tx support

2021-11-12 Thread Apeksha Gupta
This patch adds burst enqueue and dequeue operations to the enetfec PMD. Basic features added like promiscuous enable, basic stats. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- doc/guides/nics/enetfec.rst | 2 + doc/guides/nics/features/enetfec.ini | 2 + drivers/n

[PATCH v10 3/5] net/enetfec: support queue configuration

2021-11-12 Thread Apeksha Gupta
This patch adds Rx/Tx queue configuration setup operations. On packet reception the respective BD Ring status bit is set which is then used for packet processing. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- drivers/net/enetfec/enet_ethdev.c | 222 +-

[PATCH v10 2/5] net/enetfec: add UIO support

2021-11-12 Thread Apeksha Gupta
Implemented the fec-uio driver in kernel. enetfec PMD uses UIO interface to interact with "fec-uio" driver implemented in kernel for PHY initialisation and for mapping the allocated memory of register & BD from kernel to DPDK which gives access to non-cacheable memory for BD. Signed-off-by: Sachin

[PATCH v10 1/5] net/enetfec: introduce NXP ENETFEC driver

2021-11-12 Thread Apeksha Gupta
ENETFEC (Fast Ethernet Controller) is a network poll mode driver for NXP SoC i.MX 8M Mini. This patch adds skeleton for enetfec driver with probe function. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- MAINTAINERS| 7 ++ doc/guides/nics/enetfec.rst

[PATCH v10 0/5] drivers/net: add NXP ENETFEC driver

2021-11-12 Thread Apeksha Gupta
This patch series introduce the enetfec driver, ENETFEC (Fast Ethernet Controller) is a network poll mode driver for the inbuilt NIC found in the NXP i.MX 8M Mini SoC. An overview of the enetfec driver with probe and remove are in patch 1. Patch 2 design UIO interface so that user space directly c

[PATCH v5 5/5] eal: malloc: cleanup mp resources

2021-11-12 Thread Stephen Hemminger
The mp action resources in malloc should be cleaned up via rte_eal_cleanup. Signed-off-by: Stephen Hemminger Acked-by: Anatoly Burakov --- lib/eal/common/malloc_heap.c | 6 ++ lib/eal/common/malloc_heap.h | 3 +++ lib/eal/common/malloc_mp.c | 12 lib/eal/common/malloc_mp.h

[PATCH v5 4/5] eal: hotplug: cleanup multiprocess resources

2021-11-12 Thread Stephen Hemminger
When rte_eal_cleanup is called, hotplug should unregister the resources associated with the multi-process server. Signed-off-by: Stephen Hemminger --- lib/eal/common/hotplug_mp.c | 5 + lib/eal/common/hotplug_mp.h | 6 ++ lib/eal/linux/eal.c | 1 + 3 files changed, 12 insertions(

[PATCH v5 3/5] eal: vfio: cleanup the mp sync handle

2021-11-12 Thread Stephen Hemminger
When rte_eal_cleanup is called the rte_mp_action for VFIO should be freed. Fixes: edf73dd33072 ("ipc: handle unsupported IPC in action register") Cc: anatoly.bura...@intel.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger Acked-by: Anatoly Burakov --- lib/eal/linux/eal.c | 4

[PATCH v5 2/5] eal: mp: end the multiprocess thread during cleanup

2021-11-12 Thread Stephen Hemminger
When rte_eal_cleanup is called, all control threads should exit. For the mp thread, this best handled by closing the mp_socket and letting the thread see that. This also fixes potential problems where the mp_socket gets another hard error, and the thread runs away repeating itself by reading the s

[PATCH v5 1/5] eal: close log in eal_cleanup

2021-11-12 Thread Stephen Hemminger
When application calls rte_eal_cleanup on shutdown, the DPDK log should be closed and cleaned up. This helps reduce false reports from tools like ASAN and valgrind that track memory leaks. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 13 + lib/eal/common/ea

[PATCH v5 0/5] cleanup DPDK resources via eal_cleanup

2021-11-12 Thread Stephen Hemminger
When testing using ASAN or valgrind with DPDK; there are lots of leftover memory and file descriptors. This makes it hard to find application leaks versus internal DPDK leaks. The DPDK has a function that applications can use to tell it to cleanup resources on shutdown (rte_eal_cleanup). But the c

[PATCH v4 5/5] eal: malloc: cleanup mp resources

2021-11-12 Thread Stephen Hemminger
The mp action resources in malloc should be cleaned up via rte_eal_cleanup. Signed-off-by: Stephen Hemminger Acked-by: Anatoly Burakov --- lib/eal/common/malloc_heap.c | 6 ++ lib/eal/common/malloc_heap.h | 3 +++ lib/eal/common/malloc_mp.c | 12 lib/eal/common/malloc_mp.h

[PATCH v4 4/5] eal: hotplug: cleanup multiprocess resources

2021-11-12 Thread Stephen Hemminger
When rte_eal_cleanup is called, hotplug should unregister the resources associated with the multi-process server. Signed-off-by: Stephen Hemminger --- lib/eal/common/hotplug_mp.c | 5 + lib/eal/common/hotplug_mp.h | 6 ++ lib/eal/linux/eal.c | 1 + 3 files changed, 12 insertions(

[PATCH v4 3/5] eal: vfio: cleanup the mp sync handle

2021-11-12 Thread Stephen Hemminger
When rte_eal_cleanup is called the rte_mp_action for VFIO should be freed. Fixes: edf73dd33072 ("ipc: handle unsupported IPC in action register") Cc: anatoly.bura...@intel.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger Acked-by: Anatoly Burakov --- lib/eal/linux/eal.c | 4

[PATCH v4 2/5] eal: mp: end the multiprocess thread during cleanup

2021-11-12 Thread Stephen Hemminger
When rte_eal_cleanup is called, all control threads should exit. For the mp thread, this best handled by closing the mp_socket and letting the thread see that. This also fixes potential problems where the mp_socket gets another hard error, and the thread runs away repeating itself by reading the s

[PATCH v4 1/5] eal: close log in eal_cleanup

2021-11-12 Thread Stephen Hemminger
When application calls rte_eal_cleanup on shutdown, the DPDK log should be closed and cleaned up. This helps reduce false reports from tools like ASAN and valgrind that track memory leaks. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 13 + lib/eal/common/ea

[PATCH v4 0/5] cleanup more stuff on shutdown

2021-11-12 Thread Stephen Hemminger
Started using valgrind with DPDK, and there are lots of leftover memory and file descriptors. This makes it hard to find application leaks versus DPDK leaks. The DPDK has a function that applications can use to tell it to cleanup resources on shutdown (rte_eal_cleanup). But the current coverage of

[PATCH] doc: discourage using meson 0.58 on Windows

2021-11-12 Thread Dmitry Kozlyuk
Meson 0.58 and above cannot build DPDK on Windows with clang. Recommend the latest known working version and warn about the issue and the affected versions. Suggested-by: Thomas Monjalon Signed-off-by: Dmitry Kozlyuk --- doc/guides/windows_gsg/build_dpdk.rst | 6 +- 1 file changed, 5 insert

[PATCH 3/3] config/x86: fix MinGW cross build with meson 0.49

2021-11-12 Thread Dmitry Kozlyuk
Cross build with MinGW was broken for the baseline meson 0.49.2. Cause: in c_args = '-mno-avx512f' from config/x86/cross-mingw, each character was treated as a separate compiler option: meson.build:4:0: ERROR: Compiler x86_64-w64-mingw32-gcc can not compile programs. With c_args = ['-mno-av

[PATCH 2/3] buildtools: make AVX512 check script portable

2021-11-12 Thread Dmitry Kozlyuk
buildtools/binutils-avx512-check.sh was Unix-only and could not be used in cross builds: 1) written in shell; 2) used the assembler binary that may be missing, e.g. when building on Windows with LLVM; 3) located the assembler as ${AS:-as} and referenced objdump, but those binaries may be over

[PATCH 1/3] config/x86: skip GNU binutils bug check for LLVM

2021-11-12 Thread Dmitry Kozlyuk
AVX512 was disabled when GNU binutils were missing or had a known bug, even if LLVM binutils were used for the build, because binutils-avx512-check.sh was invoked regardless and failed. In particular, this was the case for FreeBSD with clang (default). Run the check only when GNU binutils are used.

[PATCH 0/3] config/x86: improve AVX512 availability check

2021-11-12 Thread Dmitry Kozlyuk
The goal of this series is to enable cross-compilation of Windows binaries from Linux using MinGW with Meson 0.49 used in CI. It also aims to reduce difference between Unix and Windows build code. AVX512 was switched off for MinGW cross builds, but unfortunately in a way that is not usable with me

RE: [PATCH] event/dlb2: fix delayed_pop test in dlb2_selftest

2021-11-12 Thread Chen, Mike Ximing
> -Original Message- > From: Shetty, Rashmi > Sent: Friday, November 12, 2021 2:49 PM > To: dev@dpdk.org > Cc: jer...@marvell.com; Van Haaren, Harry ; > Pathak, Pravin > ; Chen, Mike Ximing ; > McDaniel, Timothy > ; Shetty, Rashmi > Subject: [PATCH] event/dlb2: fix delayed_pop test i

[PATCH] event/dlb2: fix delayed_pop test in dlb2_selftest

2021-11-12 Thread Rashmi Shetty
Number of events scheduled and available for dequeue after token pop was set to dequeue_depth-1 instead of dequeue_depth in test_delayed_pop. The expectation is that all dequeue_depth number of events can be dequeued once the last event is released. Signed-off-by: Rashmi Shetty --- drivers/event

Re: [PATCH v2] devtools: spell check

2021-11-12 Thread Stephen Hemminger
On Fri, 12 Nov 2021 13:14:45 -0500 Henry Nadeau wrote: > +# Compares diff between current branch and it's remote counterpart > +if [ ! $all_check = 'true' ]; then > + git diff "$branch" origin/"$remote_branch" --name-only | > + grep ".*\.rst" | > + # run the spellcheck function over

[PATCH v2] devtools: spell check

2021-11-12 Thread Henry Nadeau
A spell check script that checks for spelling errors in modified .rst files using git. There is also an optional flag to have the script check the entire doc directory for errors. The dictionary is used for word exceptions, and the regex file will exclude any regex patterns supplied on each line.

[PATCH] devtools: spell check

2021-11-12 Thread Henry Nadeau
[ upstream commit d4fb4eb08725a3e667042c1f5cd3ed72b94505a7 ] The spell check script checks for changed files using git, then parses those files for potential spelling errors. The dictionary is used for word exeptions, and the regex file will exclude any regex patterns supplied on a given line. Si

RE: [PATCH 5/7] drivers/net: fix unused but set variables

2021-11-12 Thread Walsh, Conor
> On Fri, 12 Nov 2021 16:38:37 + > "Walsh, Conor" wrote: > > > Would something along the lines of this make more sense? > > > > #ifdef RTE_LIBRTE_VMXNET3_DEBUG_TX > > completed += vmxnet3_unmap_pkt(tcd->txdIdx, txq); > > #else > > vmxnet3_unmap_pkt(tcd->txdIdx, txq); > > #endif > > > > Thanks

Re: [PATCH 5/7] drivers/net: fix unused but set variables

2021-11-12 Thread Stephen Hemminger
On Fri, 12 Nov 2021 16:38:37 + "Walsh, Conor" wrote: > Would something along the lines of this make more sense? > > #ifdef RTE_LIBRTE_VMXNET3_DEBUG_TX > completed += vmxnet3_unmap_pkt(tcd->txdIdx, txq); > #else > vmxnet3_unmap_pkt(tcd->txdIdx, txq); > #endif > > Thanks, > Conor. Why not ju

RE: [PATCH 5/7] drivers/net: fix unused but set variables

2021-11-12 Thread Walsh, Conor
> Subject: Re: [PATCH 5/7] drivers/net: fix unused but set variables > > On Fri, Nov 12, 2021 at 5:18 PM Ferruh Yigit wrote: > > > > On 11/12/2021 2:01 PM, Conor Walsh wrote: > > > static void > > > vmxnet3_tq_tx_complete(vmxnet3_tx_queue_t *txq) > > > { > > > + #ifdef RTE_LIBRTE_VMXNET

RE: [PATCH 5/7] drivers/net: fix unused but set variables

2021-11-12 Thread Walsh, Conor
> On 11/12/2021 2:01 PM, Conor Walsh wrote: > > static void > > vmxnet3_tq_tx_complete(vmxnet3_tx_queue_t *txq) > > { > > + #ifdef RTE_LIBRTE_VMXNET3_DEBUG_TX > > int completed = 0; > > + #endif > > vmxnet3_comp_ring_t *comp_ring = &txq->comp_ring; > > struct Vmxnet3_TxCompDes

Re: [PATCH 5/7] drivers/net: fix unused but set variables

2021-11-12 Thread David Marchand
On Fri, Nov 12, 2021 at 5:18 PM Ferruh Yigit wrote: > > On 11/12/2021 2:01 PM, Conor Walsh wrote: > > static void > > vmxnet3_tq_tx_complete(vmxnet3_tx_queue_t *txq) > > { > > + #ifdef RTE_LIBRTE_VMXNET3_DEBUG_TX > > int completed = 0; > > + #endif > > vmxnet3_comp_ring_t

[Bug 882] ixgbe dirver may resue some unreleased mbufs

2021-11-12 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=882 Bug ID: 882 Summary: ixgbe dirver may resue some unreleased mbufs Product: DPDK Version: 20.11 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal

DPDK Release Status Meeting 2021-11-11

2021-11-12 Thread Mcnamara, John
Release status meeting minutes 2021-11-11 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * ARM * Intel * Marvell * Nvidia * Red Hat Release Dates - * v21.11 dates: http://core.dpdk.org/roadmap/#dates *

Re: [PATCH 5/7] drivers/net: fix unused but set variables

2021-11-12 Thread Ferruh Yigit
On 11/12/2021 2:01 PM, Conor Walsh wrote: static void vmxnet3_tq_tx_complete(vmxnet3_tx_queue_t *txq) { + #ifdef RTE_LIBRTE_VMXNET3_DEBUG_TX int completed = 0; + #endif vmxnet3_comp_ring_t *comp_ring = &txq->comp_ring; struct Vmxnet3_TxCompDesc *tcd = (st

Re: [PATCH v4 08/18] eal: fix typos in comments

2021-11-12 Thread Kinsella, Ray
On 12/11/2021 00:02, Stephen Hemminger wrote: Minor spelling errors. Signed-off-by: Stephen Hemminger --- lib/eal/include/rte_function_versioning.h | 2 +- lib/eal/windows/include/fnmatch.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/eal/include/rte

RE: [PATCH 4/7] drivers/event/sw: fix unused but set variables

2021-11-12 Thread Van Haaren, Harry
> -Original Message- > From: Walsh, Conor > Sent: Friday, November 12, 2021 2:01 PM > To: Yigit, Ferruh ; david.march...@redhat.com; Liang, > LongfengX ; dev@dpdk.org > Cc: Hunt, David ; Wang, Yipeng1 > ; Gobriel, Sameh ; > Richardson, Bruce ; Medvedkin, Vladimir > ; hemant.agra...@nxp.com

RE: [PATCH] net/axgbe: fix PCI ID to distinguish v1000 vs e3000

2021-11-12 Thread Namburu, Chandu-babu
[AMD Official Use Only] Hi Arsalan Awan, Thank you for sharing the patch. DPDK not working on V1000 is regression due to "bus/pci: optimize bus scan" patch. As RV Root Complex device does not have any Linux kernel driver assigned, this device is removed from PCI scan list and not found using p

Re: [PATCH v2] power: fix unused-but-set variable error

2021-11-12 Thread David Marchand
On Mon, Nov 8, 2021 at 9:40 PM David Marchand wrote: > > clang-13 rightfully complains that the tot_ppi > > variable in update_stats is set but not used, since > > the final accumulated tot_ppi results isn't used > > anywhere. > > > > Signed-off-by: Jim Harris > Reviewed-by: David Marchand I sp

[PATCH] vdpa/mlx5: fix return value check of mkey create

2021-11-12 Thread Bing Zhao
The return value of "mlx5_os_wrapped_mkey_create" is checked in the caller. A zero means success without any error. The typo in the if-condition should be fixed in case there is a misjudgment. Fixes: f26e06d97d57 ("vdpa/mlx5: workaround dirty bitmap MR creation") Signed-off-by: Bing Zhao Acked-

[PATCH] net/mlx5: fix the delay drop bit set overflow

2021-11-12 Thread Bing Zhao
The attribute to record the global control of hairpin queues' delay drop was defined as a bit-field with one bit, and the intention was to reduce the memory overhead. In the meanwhile, the macro was defined as an enumerated value 0x2. No matter what value inputted via devarg, the lowest bit was al

Re: [PATCH 1/7] app/test: fix unused but set variables

2021-11-12 Thread Medvedkin, Vladimir
On 12/11/2021 15:01, Conor Walsh wrote: This patch fixes unused but set variables within the following test apps: - test distributor perf - test thash perf Bugzilla ID: 881 Fixes: c0de0eb82e40 ("distributor: switch over to new API") Fixes: 239fffe0402e ("test/thash: add performance tests

Re: [PATCH 7/7] lib/power: fix unused but set variables

2021-11-12 Thread David Marchand
On Fri, Nov 12, 2021 at 3:17 PM Walsh, Conor wrote: > > Hi David, > > I will make those changes to the commit logs and respin them. > I'll also drop this patch from the set. These comments are trivial. We might get more substantial comments from drivers maintainers. I recommend waiting a bit bef

Re: [PATCH v4 13/18] rib: fix typo in comment

2021-11-12 Thread Medvedkin, Vladimir
On 12/11/2021 01:02, Stephen Hemminger wrote: Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/rib/rte_rib6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rib/rte_rib6.c b/lib/rib/rte_rib6.c index b00c7fbf5ab0..70405113b419

Re: [PATCH v4 12/18] hash: fix typo in comment

2021-11-12 Thread Medvedkin, Vladimir
On 12/11/2021 01:02, Stephen Hemminger wrote: Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/hash/rte_thash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/hash/rte_thash.c b/lib/hash/rte_thash.c index 394e1328c531..6847e3

Re: [PATCH v4 02/18] ipsec: fix spelling errors

2021-11-12 Thread Medvedkin, Vladimir
On 12/11/2021 01:02, Stephen Hemminger wrote: Lots of typos in comments found by codespell Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- lib/ipsec/esp_inb.c | 4 ++-- lib/ipsec/esp_outb.c | 2 +- lib/ipsec/ipsec_sad.c | 2 +- lib/ipsec/sa.c| 2 +- lib/ip

RE: [PATCH 7/7] lib/power: fix unused but set variables

2021-11-12 Thread Walsh, Conor
Hi David, I will make those changes to the commit logs and respin them. I'll also drop this patch from the set. Thanks, Conor. > Hello Conor, > > > On Fri, Nov 12, 2021 at 3:02 PM Conor Walsh > wrote: > > > > This patch removes the tot_ppi variable from the update_stats function > > within em

[PATCH v2] hash: fix thash gfni implementation

2021-11-12 Thread Vladimir Medvedkin
1. This patch replaces _mm512_set_epi8 with _mm512_set_epi32 due to the lack of support by some compilers. 2. This patch checks if AVX512F is supported along with GFNI. This is done if the code is built on a platform that supports GFNI, but does not support AVX512. 3. Also this patch fixes compilat

Re: [dpdk-dev] [Bug 826] red_autotest random failures

2021-11-12 Thread David Marchand
On Fri, Nov 12, 2021 at 3:11 PM Lincoln Lavoie wrote: >> This failure keeps on popping in the CI. >> The bug report is one month old, with no reply. >> >> >> I sent a proposal of removing red_autotest from the list executed by the CI. >> https://patchwork.dpdk.org/project/dpdk/patch/20211027140458

Re: [PATCH 7/7] lib/power: fix unused but set variables

2021-11-12 Thread David Marchand
Hello Conor, On Fri, Nov 12, 2021 at 3:02 PM Conor Walsh wrote: > > This patch removes the tot_ppi variable from the update_stats function > within empty poll in the power library as it is an unused but set > variable. About the commitlog, commenting on this patch, but it applies to other of th

Re: [dpdk-dev] [Bug 826] red_autotest random failures

2021-11-12 Thread Lincoln Lavoie
On Fri, Nov 12, 2021 at 8:52 AM David Marchand wrote: > On Fri, Oct 8, 2021 at 9:24 AM wrote: > > > > https://bugs.dpdk.org/show_bug.cgi?id=826 > > > > Bug ID: 826 > >Summary: red_autotest random failures > >Product: DPDK > >Version: unspecified >

RE: [PATCH] common/qat: fix overrun of qp config

2021-11-12 Thread Power, Ciara
Hi Arek, >-Original Message- >From: Kusztal, ArkadiuszX >Sent: Friday 12 November 2021 12:02 >To: dev@dpdk.org >Cc: gak...@marvell.com; Zhang, Roy Fan ; Power, >Ciara ; Kusztal, ArkadiuszX >; Zegan, PrzemyslawX > >Subject: [PATCH] common/qat: fix overrun of qp config > >This commint fixes

[PATCH 5/7] drivers/net: fix unused but set variables

2021-11-12 Thread Conor Walsh
This patch fixes unused but set variables in the following net drivers: - bnxt - hinic - liquidio - nfp - octeontx - qede - txgbe - vmxnet3 This patch also fixes an unused function warning for vmxnet3_unmap_pkt from within vmxnet3 Bugzilla ID: 881 Fixes: b87abb2e55cb ("net/bnxt: support

[PATCH 7/7] lib/power: fix unused but set variables

2021-11-12 Thread Conor Walsh
This patch removes the tot_ppi variable from the update_stats function within empty poll in the power library as it is an unused but set variable. Bugzilla ID: 881 Fixes: 450f0791312c ("power: add traffic pattern aware power control") Signed-off-by: Conor Walsh Reported-by: Liang Longfeng ---

[PATCH 6/7] examples/performance-thread: fix unused but set variables

2021-11-12 Thread Conor Walsh
This patch removes the hits variable from the cpu_load_collector function within the performance thread example app as it is an unused but set variable. Bugzilla ID: 881 Fixes: d48415e1fee3 ("examples/performance-thread: add l3fwd-thread app") Signed-off-by: Conor Walsh Reported-by: Liang Longf

[PATCH 4/7] drivers/event/sw: fix unused but set variables

2021-11-12 Thread Conor Walsh
This patch removes the inflights variable from the sw_dump function within the software section of the event driver as it is an unused but set variable. Bugzilla ID: 881 Fixes: c66baa68e453 ("event/sw: add dump function for easier debugging") Signed-off-by: Conor Walsh Reported-by: Liang Longfe

[PATCH 2/7] drivers/bus/fslmc: fix unused but set variables

2021-11-12 Thread Conor Walsh
This patch removes the device_count variable from the rte_fslmc_scan function within the fslmc bus driver as it is an unused but set variable. Bugzilla ID: 881 Fixes: 828d51d8fc3e ("bus/fslmc: refactor scan and probe functions") Signed-off-by: Conor Walsh Reported-by: Liang Longfeng --- drive

[PATCH 0/7] fix unused but set variables

2021-11-12 Thread Conor Walsh
When DPDK is compiled with clang 13, several warnings for unused but set variables are present. This patchset fixes these warnings, which were present within: - app/test - drivers/bus/fslmc - drivers/common/qat - drivers/event/sw - drivers/net - examples/performance-thread - lib/power I sp

[PATCH 3/7] drivers/common/qat: fix unused but set variables

2021-11-12 Thread Conor Walsh
This patch removes the us variable from the qat_pf2vf_exch_msg function within the PF to VF section of the QAT driver as it is an unused but set variable. Bugzilla ID: 881 Fixes: b17d16fb47b4 ("common/qat: add PF to VF communication") Signed-off-by: Conor Walsh Reported-by: Liang Longfeng ---

[PATCH 1/7] app/test: fix unused but set variables

2021-11-12 Thread Conor Walsh
This patch fixes unused but set variables within the following test apps: - test distributor perf - test thash perf Bugzilla ID: 881 Fixes: c0de0eb82e40 ("distributor: switch over to new API") Fixes: 239fffe0402e ("test/thash: add performance tests for Toeplitz hash") Signed-off-by: Conor Wals

[PATCH] test/red: fix typo in comment

2021-11-12 Thread David Marchand
This is probably due a s/red/rte_red/ a long time ago. Fixes: de3cfa2c9823 ("sched: initial import") Signed-off-by: David Marchand --- app/test/test_red.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_red.c b/app/test/test_red.c index e973f3131e..05936cfee8 1

Re: [dpdk-dev] [Bug 826] red_autotest random failures

2021-11-12 Thread David Marchand
On Fri, Oct 8, 2021 at 9:24 AM wrote: > > https://bugs.dpdk.org/show_bug.cgi?id=826 > > Bug ID: 826 >Summary: red_autotest random failures >Product: DPDK >Version: unspecified > Hardware: All > OS: All > Status:

Re: buildtools/binutils-avx512-check.sh

2021-11-12 Thread Bruce Richardson
On Fri, Nov 12, 2021 at 04:08:37PM +0300, Dmitry Kozlyuk wrote: > Hello, > > I'm working on improvement of Linux-to-Windows cross-compilation using MinGW. > Currently there is c_args = '-mno-avx512f' in config/x86/cross-mingw, however, > 1) baseline meson 0.49.2 doesn't like it* > 2) it should be

Re: [PATCH v3] eal/arm64: support ASan

2021-11-12 Thread David Marchand
On Tue, Nov 9, 2021 at 11:00 AM Volodymyr Fialko wrote: > > This patch defines ASAN_SHADOW_OFFSET for arm64 according to the ASan > documentation. This offset should cover all arm64 VMAs supported by > ASan. > > Signed-off-by: Volodymyr Fialko > Reviewed-by: David Marchand > Acked-by: Jerin Jaco

buildtools/binutils-avx512-check.sh

2021-11-12 Thread Dmitry Kozlyuk
Hello, I'm working on improvement of Linux-to-Windows cross-compilation using MinGW. Currently there is c_args = '-mno-avx512f' in config/x86/cross-mingw, however, 1) baseline meson 0.49.2 doesn't like it* 2) it should be in machine_args because they are checked in various places 3) I don't like d

[PATCH v3] net/mlx5: fix the NIC egress flow mismatch in switchdev mode

2021-11-12 Thread Jiawei Wang
When E-Switch mode was enabled, the NIC egress flows was implicitly appended with source vport to match on. If the metadata register C0 was used to maintain the source vport, it was initialized to zero on packet steering engine entry, the flow could be hit only if source vport was zero, the registe

[PATCH] ethdev: fix typos

2021-11-12 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- lib/ethdev/ethdev_driver.h | 4 ++-- lib/ethdev/rte_flow.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/ethdev/ethdev_driver.h b/lib/ethdev/ethdev_driver.h index dcbffd4265fa..d95605a355ae 100644 --- a/lib/ethdev/ethdev_driver.h

[PATCH] common/qat: fix overrun of qp config

2021-11-12 Thread Arek Kusztal
This commint fixes overrun of ring configuration due to insufficient check. Fixes: 4badfb0205f7 ("common/qat: fix queue pairs number") Cc: przemyslawx.ze...@intel.com Signed-off-by: Arek Kusztal --- drivers/common/qat/dev/qat_dev_gen1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

Re: [PATCH v4 00/18] fix docbook and spelling errors

2021-11-12 Thread Ferruh Yigit
On 11/12/2021 12:02 AM, Stephen Hemminger wrote: After finding a few typos in BPF, decided to cast a wider net and fix lots more places. These are all contained to typos in strings or comments. v4 - rebase and resend There are a few typo fix in ethdev, which are sitting in my local repo for

Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are full and Tx fails

2021-11-12 Thread Thomas Monjalon
20/07/2021 18:50, Rakesh Kudurumalla: > Current pmd_perf_autotest() in continuous mode tries > to enqueue MAX_TRAFFIC_BURST completely before starting > the test. Some drivers cannot accept complete > MAX_TRAFFIC_BURST even though rx+tx desc count can fit it. Which driver is failing to do so? Why

RE: [EXT] Re: [dpdk-dev] [PATCH] doc: deprecation notice to remove octeontx2 drivers

2021-11-12 Thread Akhil Goyal
> On 11/9/2021 3:51 PM, jer...@marvell.com wrote: > > From: Jerin Jacob > > > > In the view of enabling unified driver for octeontx2(cn9k)/ > > octeontx3(cn10k), removing drivers/octeontx2 drivers and > > replace with drivers/cnxk/ which supports both octeontx2(cn9k) > > and octeontx3(cn10k) SoCs.

RE: [PATCH v4 18/18] test: fix spelling errors in comments

2021-11-12 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger > Sent: Friday, November 12, 2021 12:02 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Ananyev, > Konstantin ; Trahe, Fiona > ; Ashish Gupta ; > Wang, Yipeng1 ; Gobriel, Sameh > ; Richardson, Bruce > ; Medvedkin, Vladimir > ; Olivier Matz

RE: [PATCH v4 14/18] sched: fix typo in comment

2021-11-12 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger > Sent: Friday, November 12, 2021 12:02 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Dumitrescu, > Cristian ; Singh, Jasvinder > > Subject: [PATCH v4 14/18] sched: fix typo in comment > > Yet another spelling error found by codespell.

RE: [PATCH v4 11/18] pipeline: fix spellin error in comment

2021-11-12 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger > Sent: Friday, November 12, 2021 12:02 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Dumitrescu, > Cristian > Subject: [PATCH v4 11/18] pipeline: fix spellin error in comment > > Minor typo > > Signed-off-by: Stephen Hemminger > ---

[PATCH 2/2] net/af_xdp: workaround custom program loading issue

2021-11-12 Thread Ciara Loftus
Since v0.4.0, if the underlying kernel supports it, libbpf uses 'bpf link' to manage the programs on the interfaces of the XDP sockets (xsks). This is not compatible with the PMD's custom XDP program loading feature which uses the netlink-based method for loading custom programs. The conflict aris

[PATCH 1/2] net/af_xdp: revert use BPF link for XDP programs

2021-11-12 Thread Ciara Loftus
The commit ae70cc6e893b ("net/af_xdp: use BPF link for XDP programs") caused compilation errors on kernels older than v5.8 due to absence of the bpf_link_info struct and some definitions in the linux/bpf.h header. Since relying on the reported kernel version is not a robust solution and also since

RE: [PATCH v2] examples/l3fwd: fix jumbo packet drop issue

2021-11-12 Thread Ananyev, Konstantin
> From: Rohit Raj > > l3fwd uses mbufs with 2KB data size. If we enable jumbo packets, it is > not able to store packets with size greater than 2KB, hence these > packets are dropped. > > This patch fixes this issue by enabling scatter for jumbo packet, if > it is supported by NIC. > > If sc

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix DCB configuration

2021-11-12 Thread Singh, Aman Deep
On 11/10/2021 2:38 PM, Jie Wang wrote: When set port DCB mode enabled, it should remove RSS HASH offload before reconfiguring the device and queues. Because port multi-queue mode is changed from RSS to DCB. Fixes: 2a977b891f99 ("app/testpmd: fix DCB configuration") Signed-off-by: Jie Wang -

[PATCH] net/ice/base: fix wrong defines of GTPU UL/DL flag

2021-11-12 Thread Junfeng Guo
Just fix the wrong defines of GTPU flags between UL and DL. These two are defined are misplaced to each other. Fixes: 8ebb93942b2c ("net/ice/base: add function to set HW profile for raw flow") Cc: sta...@dpdk.org Signed-off-by: Junfeng Guo --- drivers/net/ice/base/ice_flow.c | 4 ++-- 1 file c

RE: [EXT] [PATCH V5] crypto/mlx5: support BF2 and ConnectX6-DX devices

2021-11-12 Thread Akhil Goyal
> Starting from FW version xx.32.0108. version, the BlueField2 and > ConnextX6-DX adapters support crypto operations. > > Add them to the supported PCI devices list. > > Signed-off-by: Raja Zidane > Acked-by: Matan Azrad > Acked-by: Tal Shnaiderman > --- > V2: fixed checkpatch warning. > V3: f