[PATCH v2 4/4] raw/ifpga/base: fix port feature ID

2022-01-17 Thread Wei Huang
Fix ID value of port features to match the definition from hardware. Fixes: 473c88f9 ("drivers/raw: remove rawdev from directory names") Signed-off-by: Wei Huang --- drivers/raw/ifpga/base/ifpga_defines.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/raw/ifpg

[PATCH v2 3/4] raw/ifpga: fix ifpga devices cleanup function

2022-01-17 Thread Wei Huang
Use rte_dev_remove() to replace rte_rawdev_pmd_release() in ifpga_rawdev_cleanup(), resources occupied by ifpga raw devices such as threads can be released correctly. Fixes: f724a802 ("raw/ifpga: add miscellaneous APIs") Signed-off-by: Wei Huang --- drivers/raw/ifpga/ifpga_rawdev.c | 4 +++- 1

[PATCH v2 2/4] raw/ifpga: fix pthread cannot join

2022-01-17 Thread Wei Huang
From: Tianfei Zhang When we want to close a thread, we should set a flag to thread handler function. Fixes: 9c006c45 ("raw/ifpga: scan PCIe BDF device tree") Cc: sta...@dpdk.org Signed-off-by: Tianfei Zhang --- drivers/raw/ifpga/ifpga_rawdev.c | 8 1 file changed, 4 insertions(+), 4

[PATCH v2 1/4] raw/ifpga/base: fix SPI transaction

2022-01-17 Thread Wei Huang
From: Tianfei Zhang When EOP is detected, 2 more bytes should be received (may be a SPI_PACKET_ESC before last valid byte) then rx should be finished. Fixes: 96ebfcf8 ("raw/ifpga/base: add SPI and MAX10 device driver") Cc: sta...@dpdk.org Signed-off-by: Tianfei Zhang --- drivers/raw/ifpga/bas

[PATCH v2 0/4] Fix bugs found in raw/ifpga development for arrow creek

2022-01-17 Thread Wei Huang
This patchset is bug fix for raw/ifpga driver. Changes since v1: * Refine commit log. Tianfei Zhang (2): raw/ifpga/base: fix SPI transaction raw/ifpga: fix pthread cannot join Wei Huang (2): raw/ifpga: fix ifpga devices cleanup function raw/ifpga/base: fix port feature ID drivers/raw/if

[PATCH v2 2/2] net/ice: support drop any and steer all to queue

2022-01-17 Thread Yuying Zhang
This patch supports drop any and steer all to queue in switch filter. Support new rte_flow pattern any to handle all packets. The usage is listed below. 1. drop any: flow create 0 ingress pattern any / end actions drop / end All packets received in port 0 will be dropped. 2. steer all to queue: f

[PATCH v2 1/2] net/ice/base: support ANY software type on switch filter

2022-01-17 Thread Yuying Zhang
Add support of ANY software type on switch filter for steering all kinds of common packets to specific queue or drop all kinds of common packets. Signed-off-by: Yuying Zhang --- drivers/net/ice/base/ice_flex_pipe.c | 72 +++- drivers/net/ice/base/ice_flex_pipe.h | 5

RE: [PATCH v1 4/4] raw/ifpga/base: fix port feature ID

2022-01-17 Thread Xu, Rosen
Hi Wei, Some issues of ci/iol-x86_64-unit-testing, pls check it. Thanks a lot. Thanks, Rosen -Original Message- From: Huang, Wei Sent: Tuesday, January 18, 2022 11:18 AM To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z Cc: sta...@dpdk.org; Zhang, Tianfei ; Yigit, Ferruh ; Huang, Wei Subje

RE: [EXT] Re: [PATCH v4 1/1] eal: add internal function to get base address

2022-01-17 Thread Srikanth Yalavarthi
Hi Dmitry, This is to cater to use cases where chunks of memory are allocated by the host / application, and would like to represent it as an offset from the Linux virtual base address. One use case is for a firmware running on an accelerator, this can be used as reference address to access hos

[PATCH 10/10] app/testpmd: implement rte flow queue indirect action

2022-01-17 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_q_action_handle API. Provide the command line interface for operations dequeue. Usage example: flow queue 0 indirect_action 0 create action_id 9 ingress drain yes action rss / end flow queue 0 indirect_action 0 update action_id 9 action queue index 0

[PATCH 09/10] app/testpmd: implement rte flow queue dequeue

2022-01-17 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_q_dequeue API. Provide the command line interface for operations dequeue. Usage example: flow dequeue 0 queue 0 Signed-off-by: Alexander Kozyrev --- app/test-pmd/cmdline_flow.c | 54 +++ app/test-pmd/config.c

[PATCH 07/10] app/testpmd: implement rte flow queue create flow

2022-01-17 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_q_create/rte_flow_q_destroy API. Provide the command line interface for enqueueing flow creation/destruction operations. Usage example: testpmd> flow queue 0 create 0 drain yes table 6 item_template 0 action_template 0 pattern eth dst is

[PATCH 08/10] app/testpmd: implement rte flow queue drain

2022-01-17 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_q_drain API. Provide the command line interface for the queue draining. Usage example: flow queue 0 drain 0 Signed-off-by: Alexander Kozyrev --- app/test-pmd/cmdline_flow.c | 56 - app/test-pmd/config.c

[PATCH 06/10] app/testpmd: implement rte flow table

2022-01-17 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_table API. Provide the command line interface for the flow table creation/destruction. Usage example: testpmd> flow table 0 create table_id 6 group 9 priority 4 ingress mode 1 rules_number 64 item_template 2 action_template 4 testpmd> flow table 0 de

[PATCH 05/10] app/testpmd: implement rte flow item/action template

2022-01-17 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_item_template and rte_flow_action_template APIs. Provide the command line interface for the template creation/destruction. Usage example: testpmd> flow item_template 0 create item_template_id 2 template eth dst is 00:16:3e:31:15:c3 / end testpmd>

[PATCH 04/10] app/testpmd: implement rte flow configure

2022-01-17 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_configure API. Provide the command line interface for the Flow management. Usage example: flow configure 0 queues_number 8 queues_size 256 Signed-off-by: Alexander Kozyrev --- app/test-pmd/cmdline_flow.c | 109 +++- app/test-pm

[PATCH 03/10] ethdev: bring in async queue-based flow rules operations

2022-01-17 Thread Alexander Kozyrev
A new, faster, queue-based flow rules management mechanism is needed for applications offloading rules inside the datapath. This asynchronous and lockless mechanism frees the CPU for further packet processing and reduces the performance impact of the flow rules creation/destruction on the datapath.

[PATCH 02/10] ethdev: add flow item/action templates

2022-01-17 Thread Alexander Kozyrev
Treating every single flow rule as a completely independent and separate entity negatively impacts the flow rules insertion rate. Oftentimes in an application, many flow rules share a common structure (the same item mask and/or action list) so they can be grouped and classified together. This knowl

[PATCH 01/10] ethdev: introduce flow pre-configuration hints

2022-01-17 Thread Alexander Kozyrev
The flow rules creation/destruction at a large scale incurs a performance penalty and may negatively impact the packet processing when used as part of the datapath logic. This is mainly because software/hardware resources are allocated and prepared during the flow rule creation. In order to optimi

[PATCH 00/10] ethdev: datapath-focused flow rules management

2022-01-17 Thread Alexander Kozyrev
Three major changes to a generic RTE Flow API were implemented in order to speed up flow rule insertion/destruction and adapt the API to the needs of a datapath-focused flow rules management applications: 1. Pre-configuration hints. Application may give us some hints on what type of resources are

[PATCH v1 4/4] raw/ifpga/base: fix port feature ID

2022-01-17 Thread Wei Huang
Fix ID value of port features to match the definition from hardware. Fixes: 473c88f9 ("drivers/raw: remove rawdev from directory names") Signed-off-by: Wei Huang --- drivers/raw/ifpga/base/ifpga_defines.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/raw/ifpg

[PATCH v1 3/4] raw/ifpga: fix ifpga devices cleanup function

2022-01-17 Thread Wei Huang
Use rte_dev_remove() to replace rte_rawdev_pmd_release() in ifpga_rawdev_cleanup(), resources occupied by ifpga raw devices such as threads can be released correctly. Fixes: f724a802 ("raw/ifpga: add miscellaneous APIs") Signed-off-by: Wei Huang --- drivers/raw/ifpga/ifpga_rawdev.c | 4 +++- 1

[PATCH v1 2/4] raw/ifpga: fix pthread cannot join

2022-01-17 Thread Wei Huang
From: Tianfei Zhang When we want to close a thread, we should set a flag to thread handler function. Fixes: 9c006c45 ("raw/ifpga: scan PCIe BDF device tree") Cc: sta...@dpdk.org Signed-off-by: Tianfei Zhang --- drivers/raw/ifpga/ifpga_rawdev.c | 8 1 file changed, 4 insertions(+), 4

[PATCH v1 1/4] raw/ifpga/base: fix SPI transaction

2022-01-17 Thread Wei Huang
From: Tianfei Zhang When EOP is detected, 2 more bytes should be received (may be a SPI_PACKET_ESC before last valid byte) then rx should be finished. Fixes: 96ebfcf8 ("raw/ifpga/base: add SPI and MAX10 device driver") Cc: sta...@dpdk.org Signed-off-by: Tianfei Zhang --- drivers/raw/ifpga/bas

[PATCH v1 0/4] Fix bugs found in raw/ifpga development for arrow creek

2022-01-17 Thread Wei Huang
This patchset is bug fix for raw/ifpga driver. Changes: * Fix SPI transaction. * Fix pthread cannot join. * Fix ifpga devices cleanup function. * Fix port feature ID. Tianfei Zhang (2): raw/ifpga/base: fix SPI transaction raw/ifpga: fix pthread cannot join Wei Huang (2): raw/ifpga: fix ifpg

[PATCH] examples/flow_classify: fix spelling when log error

2022-01-17 Thread Chuanshe Zhang
Signed-off-by: Chuanshe Zhang --- examples/flow_classify/flow_classify.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/flow_classify/flow_classify.c b/examples/flow_classify/flow_classify.c index 6185b34..97708b7 100644 --- a/examples/flow_classify/flow_classify.c

[PATCH v2] Add pragma to ignore gcc-compat warnings in clang when used with diagnose_if.

2022-01-17 Thread Michael Barker
When using clang with -Wall the use of diagnose_if kicks up a warning, requiring all dpdk includes to be wrapped with the pragma. This change isolates the ignore just the appropriate location and makes it easier for users to apply -Wall,-Werror Signed-off-by: Michael Barker --- lib/eal/include/

[PATCH] Add pragma to ignore gcc-compat warnings in clang when used with diagnose_if.

2022-01-17 Thread Michael Barker
Signed-off-by: Michael Barker --- lib/eal/include/rte_compat.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/eal/include/rte_compat.h b/lib/eal/include/rte_compat.h index 2718612cce..9556bbf4d0 100644 --- a/lib/eal/include/rte_compat.h +++ b/lib/eal/include/rte_compa

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-17 Thread Stephen Hemminger
On Fri, 26 Nov 2021 09:45:15 +0530 Kumara Parameshwaran wrote: > + ret = rte_eth_dev_get_port_by_name(request_param->port_name, &port_id); > + if (ret) { > + TAP_LOG(ERR, "Failed to get port id for %s", > + request_param->port_name); > + return

[PATCH v5 50/50] acl: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/acl/rte_acl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/acl/rte_acl.c b/lib/acl/rte_acl.c index 4e693b2488..a61c3ba188 100644 --- a/lib/acl/rte_acl.c +++ b/lib/acl/rte_acl.c @

[PATCH v5 49/50] cryptodev: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/cryptodev/cryptodev_pmd.h | 4 lib/cryptodev/rte_cryptodev.c | 11 --- lib/cryptodev/rte_cryptodev.h | 2 -- 3 files changed, 17 deletions(-) diff --git a/lib/cryptodev/cry

[PATCH v5 48/50] bbdev: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/bbdev/rte_bbdev.c | 4 lib/bbdev/rte_bbdev.h | 4 2 files changed, 8 deletions(-) diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c index 7f353d4f7e..aaee7b7872 100644

[PATCH v5 47/50] bpf: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/bpf/bpf.c | 4 lib/bpf/bpf_exec.c | 6 -- lib/bpf/bpf_jit_x86.c | 5 - lib/bpf/bpf_load.c | 8 lib/bpf/bpf_pkt.c | 12 lib/bpf

[PATCH v5 46/50] cmdline: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/cmdline/cmdline.c| 2 -- lib/cmdline/cmdline_parse.c | 3 --- lib/cmdline/cmdline_parse_num.c | 4 lib/cmdline/cmdline_parse_portlist.c | 3 --- lib/cmdl

[PATCH v5 45/50] compressdev: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/compressdev/rte_comp.c| 1 - lib/compressdev/rte_comp.h| 1 - lib/compressdev/rte_compressdev.c | 1 - lib/compressdev/rte_compressdev.h | 1 - lib/compress

[PATCH v5 44/50] distributor: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/distributor/rte_distributor.c | 2 -- lib/distributor/rte_distributor_match_sse.c | 2 -- lib/distributor/rte_distributor_single.c| 2 -- 3 files changed, 6 deletions(-) dif

[PATCH v5 43/50] dmadev: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/dmadev/rte_dmadev.h | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/dmadev/rte_dmadev.h b/lib/dmadev/rte_dmadev.h index 4abe79c536..ad9e7a0975 100644 --- a/lib/dmadev/rte_dmadev.h +

[PATCH v5 42/50] efd: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/efd/rte_efd.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/efd/rte_efd.c b/lib/efd/rte_efd.c index 86ef46863c..560cd78961 100644 --- a/lib/efd/rte_efd.c +++ b/lib/efd/rte_efd.

[PATCH v5 41/50] eventdev: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/eventdev/rte_event_ring.c | 6 -- lib/eventdev/rte_event_ring.h | 2 -- lib/eventdev/rte_event_timer_adapter.c | 5 - lib/eventdev/rte_event_timer_adapter.h |

[PATCH v5 40/50] fib: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/fib/dir24_8.c | 4 lib/fib/rte_fib.c | 2 -- lib/fib/rte_fib.h | 1 - lib/fib/rte_fib6.c | 2 -- lib/fib/rte_fib6.h | 1 - lib/fib/trie.c | 5 - lib/fib/trie.h | 2 --

[PATCH v5 39/50] flow_classify: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/flow_classify/rte_flow_classify.c | 3 --- lib/flow_classify/rte_flow_classify.h | 4 lib/flow_classify/rte_flow_classify_parse.c | 1 - lib/flow_classify/rte_flow_classif

[PATCH v5 38/50] gpudev: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/gpudev/gpudev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/gpudev/gpudev.c b/lib/gpudev/gpudev.c index 9ae36dbae9..98bb759fb2 100644 --- a/lib/gpudev/gpudev.c +++ b/lib/gpudev/

[PATCH v5 37/50] graph: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/graph/graph_debug.c| 2 -- lib/graph/graph_ops.c | 1 - lib/graph/graph_populate.c | 2 -- lib/graph/node.c | 1 - 4 files changed, 6 deletions(-) diff --git a/lib/grap

[PATCH v5 36/50] gro: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/gro/gro_tcp4.c | 1 - lib/gro/gro_tcp4.h | 2 -- lib/gro/gro_udp4.c | 1 - lib/gro/gro_udp4.h | 2 -- lib/gro/gro_vxlan_tcp4.c | 1 - lib/gro/gro_vxlan_udp4.c | 1 -

[PATCH v5 35/50] hash: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/hash/rte_cuckoo_hash.c | 4 lib/hash/rte_fbk_hash.c| 6 -- lib/hash/rte_fbk_hash.h| 1 - lib/hash/rte_thash.c | 1 - lib/hash/rte_thash.h | 1 - 5 files change

[PATCH v5 34/50] ip_frag: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/ip_frag/rte_ip_frag_common.c | 1 - lib/ip_frag/rte_ipv4_fragmentation.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/lib/ip_frag/rte_ip_frag_common.c b/lib/ip_frag/rte_ip_fra

[PATCH v5 33/50] ipsec: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/ipsec/esp_inb.c | 1 - lib/ipsec/esp_outb.c | 1 - lib/ipsec/ipsec_sad.c | 1 - lib/ipsec/sa.c| 3 --- lib/ipsec/sa.h| 1 - 5 files changed, 7 deletions(-) diff --git a

[PATCH v5 32/50] jobstats: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/jobstats/rte_jobstats.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/jobstats/rte_jobstats.c b/lib/jobstats/rte_jobstats.c index 9b8fde5d55..af565a14ea 100644 --- a/lib/jobsta

[PATCH v5 31/50] kni: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/kni/rte_kni.c | 2 -- lib/kni/rte_kni.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/lib/kni/rte_kni.c b/lib/kni/rte_kni.c index fc8f0e7b5a..7971c56bb4 100644 --- a/lib/kni/rte_kn

[PATCH v5 30/50] latencystats: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/latencystats/rte_latencystats.c | 4 1 file changed, 4 deletions(-) diff --git a/lib/latencystats/rte_latencystats.c b/lib/latencystats/rte_latencystats.c index ab8db7a139..8985a377

[PATCH v5 29/50] lpm: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/lpm/rte_lpm.c | 7 --- lib/lpm/rte_lpm.h | 4 lib/lpm/rte_lpm6.c | 7 --- lib/lpm/rte_lpm6.h | 1 - 4 files changed, 19 deletions(-) diff --git a/lib/lpm/rte_lpm.c b/lib/lp

[PATCH v5 28/50] mbuf: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/mbuf/rte_mbuf.c | 11 --- lib/mbuf/rte_mbuf.h | 2 -- lib/mbuf/rte_mbuf_dyn.h | 2 -- lib/mbuf/rte_mbuf_pool_ops.c | 1 - lib/mbuf/rte_mbuf_pool_ops.h |

[PATCH v5 27/50] member: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/member/rte_member.c | 2 -- lib/member/rte_member.h | 1 - lib/member/rte_member_vbf.c | 1 - 3 files changed, 4 deletions(-) diff --git a/lib/member/rte_member.c b/lib/member/rte

[PATCH v5 26/50] mempool: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/mempool/rte_mempool.c | 7 --- lib/mempool/rte_mempool.h | 4 2 files changed, 11 deletions(-) diff --git a/lib/mempool/rte_mempool.c b/lib/mempool/rte_mempool.c index c5a699b1d6

[PATCH v5 25/50] metrics: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/metrics/rte_metrics.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/metrics/rte_metrics.c b/lib/metrics/rte_metrics.c index e2a0fbeda8..0c7878e65f 100644 --- a/lib/metrics/rte_

[PATCH v5 24/50] net: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/net/net_crc_avx512.c | 3 --- lib/net/net_crc_sse.c| 1 - lib/net/rte_arp.c| 1 - lib/net/rte_ether.h | 1 - lib/net/rte_net.h| 1 - lib/net/rte_net_crc.c| 2 -

[PATCH v5 23/50] node: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/node/ethdev_ctrl.c | 2 -- lib/node/ethdev_rx.c | 1 - lib/node/ethdev_tx.c | 1 - lib/node/ip4_lookup.c | 5 - lib/node/ip4_rewrite.c | 4 lib/node/pkt_cls.c | 4 l

[PATCH v5 22/50] pcapng: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/pcapng/rte_pcapng.c | 1 - lib/pcapng/rte_pcapng.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/lib/pcapng/rte_pcapng.c b/lib/pcapng/rte_pcapng.c index 03edabe73e..5ae96a5bc9 1006

[PATCH v5 21/50] pci: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/pci/rte_pci.c | 15 +-- lib/pci/rte_pci.h | 2 -- 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/lib/pci/rte_pci.c b/lib/pci/rte_pci.c index c91be8b167..355772

[PATCH v5 20/50] pdump: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/pdump/rte_pdump.c | 1 - lib/pdump/rte_pdump.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c index af450695ec..b3a62df591 100644 --- a

[PATCH v5 19/50] pipeline: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/pipeline/rte_pipeline.c | 4 lib/pipeline/rte_port_in_action.c| 2 -- lib/pipeline/rte_swx_ctl.h | 2 -- lib/pipeline/rte_swx_pipeline.c | 1 - lib/pipelin

[PATCH v5 18/50] port: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/port/rte_port_fd.h | 1 - lib/port/rte_port_frag.c| 2 -- lib/port/rte_port_frag.h| 1 - lib/port/rte_port_kni.c | 1 - lib/port/rte_port_kni.h | 1

[PATCH v5 17/50] power: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Also added rte_string_fns.h to example app vm_power_manager for users without libbsd. Signed-off-by: Sean Morrissey --- examples/vm_power_manager/guest_cli/main.c | 1 + lib/power/guest_channel.c | 2 -- lib/p

[PATCH v5 16/50] rawdev: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/rawdev/rte_rawdev.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/lib/rawdev/rte_rawdev.c b/lib/rawdev/rte_rawdev.c index a6134e76ea..2f0a4f132e 100644 --- a/lib/rawde

[PATCH v5 15/50] rcu: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/rcu/rte_rcu_qsbr.c | 4 lib/rcu/rte_rcu_qsbr.h | 4 2 files changed, 8 deletions(-) diff --git a/lib/rcu/rte_rcu_qsbr.c b/lib/rcu/rte_rcu_qsbr.c index 7510db2f81..17be93e830 100

[PATCH v5 14/50] regexdev: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey Acked-by: Ori Kam --- lib/regexdev/rte_regexdev.c | 2 -- lib/regexdev/rte_regexdev.h | 3 --- 2 files changed, 5 deletions(-) diff --git a/lib/regexdev/rte_regexdev.c b/lib/regexdev/rte_regexd

[PATCH v5 13/50] reorder: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/reorder/rte_reorder.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/reorder/rte_reorder.c b/lib/reorder/rte_reorder.c index 9445853b79..f40a48201f 100644 --- a/lib/reorder/rte_reo

[PATCH v5 12/50] rib: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/rib/rte_rib.c | 2 -- lib/rib/rte_rib.h | 1 - lib/rib/rte_rib6.c | 2 -- lib/rib/rte_rib6.h | 1 - 4 files changed, 6 deletions(-) diff --git a/lib/rib/rte_rib.c b/lib/rib/rte_rib.c in

[PATCH v5 11/50] sched: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/sched/rte_pie.c | 2 -- lib/sched/rte_red.h | 1 - lib/sched/rte_sched.c | 1 - lib/sched/rte_sched.h | 1 - 4 files changed, 5 deletions(-) diff --git a/lib/sched/rte_pie.c b/lib/sch

[PATCH v5 10/50] security: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/security/rte_security.c | 2 -- lib/security/rte_security.h | 3 --- 2 files changed, 5 deletions(-) diff --git a/lib/security/rte_security.c b/lib/security/rte_security.c index 6e45a03fa

[PATCH v5 09/50] stack: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/stack/rte_stack.c | 2 -- lib/stack/rte_stack.h | 1 - 2 files changed, 3 deletions(-) diff --git a/lib/stack/rte_stack.c b/lib/stack/rte_stack.c index 56bf2c8d6d..1fabec2bfe 100644 --- a

[PATCH v5 08/50] table: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/table/rte_swx_table_em.c | 1 - lib/table/rte_swx_table_em.h | 1 - lib/table/rte_swx_table_learner.c | 1 - lib/table/rte_swx_table_learner.h | 1 - lib/table/rte_swx_table_

[PATCH v5 07/50] timer: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/timer/rte_timer.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/lib/timer/rte_timer.c b/lib/timer/rte_timer.c index 6d19ce469b..b3f3e229f6 100644 --- a/lib/timer/rte_timer.c ++

[PATCH v5 06/50] vhost: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/vhost/fd_man.c | 6 -- lib/vhost/fd_man.h | 1 - lib/vhost/socket.c | 1 - lib/vhost/vdpa.c | 1 - lib/vhost/vhost.c | 4 lib/vhost/vhost.h | 2 -- lib

[PATCH v5 05/50] eal: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey Reviewed-by: Harry van Haaren Reviewed-by: Mattias Rönnblom Reviewed-by: David Christensen --- lib/eal/common/eal_common_dev.c| 5 - lib/eal/common/eal_common_devargs.c| 1

[PATCH v5 04/50] kvargs: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/kvargs/rte_kvargs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/kvargs/rte_kvargs.c b/lib/kvargs/rte_kvargs.c index 11f624ef14..9a59c500bf 100644 --- a/lib/kvargs/rte_kvargs.c

[PATCH v5 03/50] ring: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/ring/rte_ring.c | 9 - 1 file changed, 9 deletions(-) diff --git a/lib/ring/rte_ring.c b/lib/ring/rte_ring.c index f17bd966be..7945e5d9ed 100644 --- a/lib/ring/rte_ring.c +++ b/li

[PATCH v5 02/50] telemetry: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey Acked-by: Ciara Power --- lib/telemetry/telemetry.c | 1 - lib/telemetry/telemetry_data.h | 1 - 2 files changed, 2 deletions(-) diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/tele

[PATCH v5 01/50] devtools: script to remove unused headers includes

2022-01-17 Thread Sean Morrissey
This script can be used for removing headers flagged for removal by the include-what-you-use (IWYU) tool. The script has the ability to remove headers from specified sub-directories or dpdk as a whole and tests the build after each removal by calling meson compile. example usages: Remove headers

[PATCH v5 00/50] introduce IWYU

2022-01-17 Thread Sean Morrissey
This patchset introduces the include-what-you-use script which removes unused header includes. IWYU GitHub: https://github.com/include-what-you-use/include-what-you-use Along with the script there are some patches which make a start on removing unneeded headers. V4: * Re-added removed headers th

Re: [PATCH v14 04/11] app/test: skip interrupt tests on Windows

2022-01-17 Thread Thomas Monjalon
The proposal below is now merged. Please Jie, use it in a v15 of this series. 10/12/2021 10:30, Bruce Richardson: > On Fri, Dec 10, 2021 at 12:23:59PM +0300, Dmitry Kozlyuk wrote: > > 2021-12-09 16:39 (UTC+), Bruce Richardson: > > > On Thu, Dec 09, 2021 at 04:17:08PM +, Bruce Richardson w

Re: dev Digest, Vol 381, Issue 38

2022-01-17 Thread Thomas Monjalon
13/12/2021 16:41, McDaniel, Timothy: [...] > Reviewed-by: Timothy McDaniel This isn't usable because you reply to a digest email. Please do not register as digest. You change it in the mailman options.

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-17 Thread Thomas Monjalon
17/01/2022 19:28, Ferruh Yigit: > > + ret = rte_eth_dev_get_port_by_name(request_param->port_name, &port_id); > > + if (ret) { > > + TAP_LOG(ERR, "Failed to get port id for %s", > > + request_param->port_name); > > + return -1; > > + } > > + dev = &rte_

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-17 Thread Ferruh Yigit
On 11/26/2021 4:15 AM, Kumara Parameshwaran wrote: From: Kumara Parameshwaran When a tap device is hotplugged to primary process which in turn adds the device to all secondary process, the secondary process does a tap_mp_attach_queues, but the fds are not populated in the primary during the pro

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-17 Thread Ferruh Yigit
On 11/26/2021 4:15 AM, Kumara Parameshwaran wrote: From: Kumara Parameshwaran When a tap device is hotplugged to primary process which in turn adds the device to all secondary process, the secondary process does a tap_mp_attach_queues, but the fds are not populated in the primary during the pro

Re: [PATCH v2] build/eal: add OS defines for C conditional checks

2022-01-17 Thread Thomas Monjalon
16/12/2021 16:21, Bruce Richardson: > Define a set of macros in the build configuration to allow C runtime > code to check the current OS environment. This saves the user having to > use ifdefs for e.g. disabling particular tests on Windows. See included > documentation changes for usage examples.

[PATCH] common/mlx5: fix probing return value when failing

2022-01-17 Thread Bing Zhao
While probing the device with unsupported class, the process should fail because no appropriate driver was found. After traversing all the drivers, an error value should be returned for the case. In the previous implementation, zero value indicating probing success was wrongly returned. Fixes: ad

Re: [PATCH] mempool: fix get objects from mempool with cache

2022-01-17 Thread Bruce Richardson
On Fri, Jan 14, 2022 at 05:36:50PM +0100, Morten Brørup wrote: > A flush threshold for the mempool cache was introduced in DPDK version > 1.3, but rte_mempool_do_generic_get() was not completely updated back > then, and some inefficiencies were introduced. > > This patch fixes the following in rte

Re: [PATCH v1 0/6] Fast restart with many hugepages

2022-01-17 Thread Bruce Richardson
On Mon, Jan 17, 2022 at 10:07:55AM +0200, Dmitry Kozlyuk wrote: > This patchset is a new design and implementation of [1]. > Changes since RFC: > * Fix bugs with -m and --single-file-segments. > * Reject optimization of mmap() call number (see below). > > # Problem Statement > > Large allocations

Re: [PATCH v5] kni: allow configuring the kni thread granularity

2022-01-17 Thread Tudor Cornea
On Fri, 14 Jan 2022 at 18:44, Ferruh Yigit wrote: > On 1/14/2022 4:24 PM, Stephen Hemminger wrote: > > On Fri, 14 Jan 2022 17:18:19 +0200 > > Tudor Cornea wrote: > > > >> +module_param(min_scheduling_interval, long, 0644); > >> +MODULE_PARM_DESC(min_scheduling_interval, > >> +"\t\tKni thread min

Re: [PATCH v1 2/6] app/test: add allocator performance benchmark

2022-01-17 Thread Aaron Conole
Dmitry Kozlyuk writes: > Memory allocator performance is crucial to applications that deal > with large amount of memory or allocate frequently. DPDK allocator > performance is affected by EAL options, API used and, at least, > allocation size. New autotest is intended to be run with different >

Re: [PATCH v1 2/6] app/test: add allocator performance benchmark

2022-01-17 Thread Bruce Richardson
On Mon, Jan 17, 2022 at 03:47:41PM +, Bruce Richardson wrote: > On Mon, Jan 17, 2022 at 10:07:57AM +0200, Dmitry Kozlyuk wrote: > > Memory allocator performance is crucial to applications that deal > > with large amount of memory or allocate frequently. DPDK allocator > > performance is affecte

Re: [PATCH v1 2/6] app/test: add allocator performance benchmark

2022-01-17 Thread Bruce Richardson
On Mon, Jan 17, 2022 at 10:07:57AM +0200, Dmitry Kozlyuk wrote: > Memory allocator performance is crucial to applications that deal > with large amount of memory or allocate frequently. DPDK allocator > performance is affected by EAL options, API used and, at least, > allocation size. New autotest

[PATCH v5] eal: fix unaligned loads/stores in rte_memcpy_generic

2022-01-17 Thread Luc Pelletier
Calls to rte_memcpy_generic could result in unaligned loads/stores for 1 < n < 16. This is undefined behavior according to the C standard, and it gets flagged by the clang undefined behavior sanitizer. rte_memcpy_generic is called with unaligned src and dst addresses. When 1 < n < 16, the code wou

Re: [PATCH] kernel/kni: retry the xmit in case ring is full

2022-01-17 Thread Tudor Cornea
Hi Stephen, > NAK > Doing this risks having a CPU lockup if userspace does not keep up > or the DPDK application gets stuck. > > There are better ways to solve the TCP stack queue overrun issue: > 1. Use a better queueing discipline on the kni device. The Linux default >of pfifo_fast has buff

softnic pull request

2022-01-17 Thread Thomas Monjalon
Please check this pull request in GitHub: https://github.com/DPDK/dpdk/pull/35

Re: [PATCH v4 1/1] eal: add internal function to get base address

2022-01-17 Thread Dmitry Kozlyuk
2022-01-17 05:42 (UTC-0800), Srikanth Yalavarthi: > Added an internal helper to get OS-specific EAL mapping base address > > This helper can be used by the drivers to map host address range with > offload devices and would be need for device specific operations like > firmware load Hello Srikanth

[PATCH] net/cxgbe: fix dangling pointer for gcc12

2022-01-17 Thread Ferruh Yigit
Observed with: gcc (GCC) 12.0.0 20220116 (experimental) In file included from ../lib/eal/linux/include/rte_os.h:14, from ../lib/eal/include/rte_common.h:28, from ../lib/eal/include/rte_log.h:25, from ../lib/ethdev/rte_ethdev.h:164,

Re: [PATCH v1 6/6] eal: extend --huge-unlink for hugepage file reuse

2022-01-17 Thread Thomas Monjalon
17/01/2022 09:14, Dmitry Kozlyuk: > Expose Linux EAL ability to reuse existing hugepage files > via --huge-unlink=never switch. > Default behavior is unchanged, it can also be specified > using --huge-unlink=existing for consistency. > Old --huge-unlink switch is kept, > it is an alias for --huge-u

Re: [PATCH v1 5/6] eal/linux: allow hugepage file reuse

2022-01-17 Thread Thomas Monjalon
17/01/2022 09:14, Dmitry Kozlyuk: > Linux EAL ensured that mapped hugepages are clean > by always mapping from newly created files: > existing hugepage backing files were always removed. > In this case, the kernel clears the page to prevent data leaks, > because the mapped memory may contain leftov

  1   2   >